| openstackgerrit | Merged zuul/zuul master: Update node to v14 and update to new jobs https://review.opendev.org/726553 | 00:00 |
|---|---|---|
| openstackgerrit | Merged zuul/zuul master: Add new timezone selector in web interface https://review.opendev.org/722653 | 00:13 |
| *** rfolco|rover|off has quit IRC | 00:16 | |
| *** rlandy has quit IRC | 00:17 | |
| *** jamesmcarthur has quit IRC | 00:25 | |
| *** jamesmcarthur has joined #zuul | 00:25 | |
| *** jamesmcarthur has quit IRC | 00:31 | |
| *** armstrongs has joined #zuul | 00:42 | |
| *** armstrongs has quit IRC | 00:51 | |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: Fix quickstart gating, Add git name and email to executor https://review.opendev.org/724096 | 00:52 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: WIP: Import user tutorials from Software Factory project blog https://review.opendev.org/728193 | 00:52 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: WIP: Add tutorial tests https://review.opendev.org/728194 | 00:52 |
| *** guillaumec has quit IRC | 00:53 | |
| *** jamesmcarthur has joined #zuul | 00:59 | |
| *** jamesmcarthur has quit IRC | 01:37 | |
| *** jamesmcarthur has joined #zuul | 01:37 | |
| *** swest has quit IRC | 01:37 | |
| *** jamesmcarthur has quit IRC | 01:43 | |
| *** rfolco|rover|off has joined #zuul | 01:45 | |
| *** rfolco|rover|off has quit IRC | 01:50 | |
| *** jamesmcarthur has joined #zuul | 01:50 | |
| *** swest has joined #zuul | 01:51 | |
| *** adam_g has quit IRC | 02:11 | |
| *** adam_g has joined #zuul | 02:12 | |
| *** jamesmcarthur has quit IRC | 02:23 | |
| *** jamesmcarthur has joined #zuul | 02:24 | |
| *** bhavikdbavishi has joined #zuul | 02:24 | |
| *** jamesmcarthur has quit IRC | 02:27 | |
| *** jamesmcarthur_ has joined #zuul | 02:27 | |
| *** bhavikdbavishi1 has joined #zuul | 02:27 | |
| *** bhavikdbavishi has quit IRC | 02:29 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 02:29 | |
| *** ysandeep|away is now known as ysandeep | 02:33 | |
| *** jamesmcarthur_ has quit IRC | 02:52 | |
| *** jamesmcarthur has joined #zuul | 02:53 | |
| *** jamesmcarthur has quit IRC | 02:59 | |
| *** jamesmcarthur has joined #zuul | 03:29 | |
| *** jamesmcarthur has quit IRC | 03:35 | |
| *** jamesmcarthur has joined #zuul | 03:35 | |
| *** bhavikdbavishi has quit IRC | 03:36 | |
| *** bhavikdbavishi has joined #zuul | 03:43 | |
| *** jamesmcarthur has quit IRC | 03:50 | |
| *** jamesmcarthur has joined #zuul | 03:51 | |
| *** jamesmcarthur has quit IRC | 03:56 | |
| *** saneax has quit IRC | 04:11 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #zuul | 04:33 | |
| *** bhavikdbavishi has quit IRC | 04:41 | |
| *** raukadah is now known as chandankumar | 05:32 | |
| *** reiterative has quit IRC | 05:39 | |
| *** reiterative has joined #zuul | 05:40 | |
| *** zxiiro has quit IRC | 06:01 | |
| *** dpawlik has joined #zuul | 06:01 | |
| *** saneax has joined #zuul | 06:16 | |
| *** ianw has quit IRC | 06:30 | |
| *** ianw has joined #zuul | 06:33 | |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Support dynamic badges https://review.opendev.org/702128 | 06:57 |
| *** dpawlik has quit IRC | 07:05 | |
| *** threestrands has quit IRC | 07:08 | |
| *** dpawlik has joined #zuul | 07:18 | |
| *** dpawlik has quit IRC | 07:24 | |
| *** dpawlik has joined #zuul | 07:25 | |
| *** tosky has joined #zuul | 07:31 | |
| *** dpawlik has quit IRC | 07:34 | |
| *** dpawlik has joined #zuul | 07:34 | |
| *** sugaar has joined #zuul | 07:39 | |
| *** dpawlik has quit IRC | 07:44 | |
| *** dpawlik has joined #zuul | 07:45 | |
| *** dpawlik has quit IRC | 07:49 | |
| *** dpawlik has joined #zuul | 07:50 | |
| openstackgerrit | Merged zuul/zuul master: Support dynamic badges https://review.opendev.org/702128 | 07:54 |
| *** jpena|off is now known as jpena | 07:55 | |
| *** dpawlik has quit IRC | 08:11 | |
| zbr | infra-core: https://review.opendev.org/#/c/729734/ thanks | 08:11 |
| *** dpawlik has joined #zuul | 08:11 | |
| *** dpawlik has quit IRC | 08:16 | |
| *** dpawlik has joined #zuul | 08:16 | |
| *** ysandeep is now known as ysandeep|lunch | 08:20 | |
| *** newbie2020 has joined #zuul | 08:36 | |
| newbie2020 | Hi all | 08:36 |
| newbie2020 | tobiash, fungi and corvus you were right yesterday and the day before about what is going on :) | 08:37 |
| newbie2020 | thank you | 08:37 |
| newbie2020 | there is something that still bothers me though | 08:37 |
| newbie2020 | in the periodic pipeline I have, a job is executed multiple times - where I was expecting to be executed only once for master | 08:38 |
| newbie2020 | before playing with the configuration I would like to understand what is going on | 08:38 |
| newbie2020 | from the scheduler logs it seems that | 08:39 |
| newbie2020 | project is defined in repo1, branch A, B and C | 08:39 |
| newbie2020 | job is defined in repo2, branch A, B and C | 08:40 |
| newbie2020 | from the logs it seems there is a match repo1@A + repo2@A, repo1@B + repo2@B and repo1@C + repo2@C when jobs are collected | 08:41 |
| newbie2020 | I suppose that is fine | 08:41 |
| newbie2020 | but repo1 is a 'config' project and I read in the Zuul docs that only the 'master' branch is considered for configuration loading in case of 'config' project | 08:41 |
| newbie2020 | so how is the above possible? | 08:41 |
| newbie2020 | (actually branch 'A' in the example is the 'master' in my case) | 08:42 |
| newbie2020 | (like is named 'master') | 08:42 |
| *** asaleh_ has joined #zuul | 08:43 | |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: WIP: Add tutorial tests https://review.opendev.org/728194 | 08:45 |
| *** iurygregory has quit IRC | 08:51 | |
| *** guillaumec has joined #zuul | 08:53 | |
| *** ysandeep|lunch is now known as ysandeep | 08:57 | |
| *** dpawlik has quit IRC | 09:10 | |
| *** dpawlik has joined #zuul | 09:10 | |
| *** dpawlik has quit IRC | 09:14 | |
| *** newbie2020 has quit IRC | 09:18 | |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: add simple test runner https://review.opendev.org/728684 | 09:26 |
| *** arxcruz is now known as arxcruz|off | 09:33 | |
| *** iurygregory has joined #zuul | 09:39 | |
| *** bhavikdbavishi has joined #zuul | 10:13 | |
| *** bhavikdbavishi1 has joined #zuul | 10:16 | |
| *** bhavikdbavishi has quit IRC | 10:17 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 10:17 | |
| *** dpawlik has joined #zuul | 11:29 | |
| *** jpena is now known as jpena|lunch | 11:30 | |
| *** rfolco|rover|off has joined #zuul | 11:46 | |
| *** rfolco|rover|off is now known as rfolco|rover | 11:46 | |
| *** newbie2020 has joined #zuul | 11:49 | |
| *** ysandeep is now known as ysandeep|afk | 12:03 | |
| *** rlandy has joined #zuul | 12:19 | |
| *** ysandeep|afk is now known as ysandeep | 12:29 | |
| *** ysandeep is now known as ysandeep|afk | 12:32 | |
| *** jpena|lunch is now known as jpena | 12:38 | |
| sshnaidm | where can I see possible format of /etc/zuul/scheduler-logging.yaml ? | 12:42 |
| *** ysandeep|afk is now known as ysandeep | 12:58 | |
| *** zxiiro has joined #zuul | 13:03 | |
| *** rlandy is now known as rlandy|mtg | 13:04 | |
| fungi | sshnaidm: this is how we set it in opendev, but we acknowledge the python-logging configuration mechanism is a poor user experience and discourage its use: https://opendev.org/opendev/system-config/src/branch/master/playbooks/roles/zuul-scheduler/files/logging.conf | 13:08 |
| fungi | newbie2020: not sure if it helps, but we generally only have a "master" branch in our config projects | 13:10 |
| fungi | so i don't really have an example of a multi-branch config project to look at for comparison | 13:10 |
| sshnaidm | fungi, thanks, I'm actually looking for a way to limit debug messages from one gerrit, but leave debug for other | 13:11 |
| *** Goneri has joined #zuul | 13:12 | |
| fungi | sshnaidm: that example has multiple gerrits in it, so probably close to what you need | 13:12 |
| sshnaidm | fungi, yep, trying, thanks | 13:12 |
| *** toabctl has quit IRC | 13:26 | |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Update to create-react-app 3.4.1 https://review.opendev.org/716305 | 13:33 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Update create-react-scripts to 3.4.2 https://review.opendev.org/729954 | 13:33 |
| zbr | clarkb: what is the meaning of GerritWatcher: Exception consuming ssh event stream ? | 13:36 |
| fungi | pretty sure the gerritwatcher thread (or is it a fork/subprocess?) is what monitors the gerrit event stream for the er-bot, so that sounds like it encountered some error either connecting to or parsing the stream | 13:42 |
| zbr | fungi: probaly is my "fault" of trying to run it using py38 | 13:42 |
| fungi | did it give you any additional detail? | 13:42 |
| corvus | zbr, fungi: is this about er-bot or zuul? er-bot discussion is more appropriate for #opendev | 13:42 |
| zbr | is erbot related | 13:43 |
| corvus | (and this isn't theoretical, i just spent time researching the answer assuming you were asking about zuul) | 13:43 |
| fungi | ahh, yep, context issue on my part | 13:44 |
| fungi | though i see there is a GerritWatcher class in zuul.driver.gerrit.gerritconnection | 13:44 |
| fungi | and yep, i thought i was in another channel, sorry for the noise | 13:44 |
| *** rlandy|mtg is now known as rlandy | 13:47 | |
| *** bhavikdbavishi has quit IRC | 13:50 | |
| *** sgw has quit IRC | 13:57 | |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Update to create-react-app 3.4.1 https://review.opendev.org/716305 | 14:02 |
| corvus | newbie2020: your understanding is correct; i'm not sure why it would be consulting repo1@B. | 14:02 |
| corvus | newbie2020: if you are able to share your logs (via a paste service like paste.openstack.org) that might be helpful | 14:03 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: WIP: Import user tutorials from Software Factory project blog https://review.opendev.org/728193 | 14:03 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: WIP: Add tutorial tests https://review.opendev.org/728194 | 14:03 |
| openstackgerrit | Guillaume Chauvel proposed zuul/nodepool master: Add zuul/zuul tutorials https://review.opendev.org/728262 | 14:08 |
| *** Goneri has quit IRC | 14:13 | |
| *** sgw has joined #zuul | 14:14 | |
| *** Goneri has joined #zuul | 14:29 | |
| *** rlandy is now known as rlandy|mtg | 14:37 | |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Update create-react-scripts to 3.4.2 https://review.opendev.org/729954 | 14:39 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: WIP: Enable ANSI rendering on stdout/stderr https://review.opendev.org/716251 | 14:41 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: WIP: Add tutorial tests https://review.opendev.org/728194 | 14:52 |
| mordred | corvus, tobiash, avass, tristanC: https://review.opendev.org/#/c/716305/ - the create-react-app update patch is green, and the notification drawer issue is fixed. I have not figured anything out with the button spinner yet | 15:04 |
| mordred | corvus: actually - I have an idea - how about we don't change those links to buttons until we have a solution | 15:10 |
| corvus | mordred: did that patch change them from links to buttons? | 15:11 |
| tristanC | corvus: it does yes, iirc that was to satisfy a linting issue (<a> without `href`)... | 15:15 |
| tristanC | mordred: that looks good, perhaps the linting can be relaxed to keep the previous reload button style? | 15:15 |
| corvus | yes, relaxing the linting sounds like a great solution | 15:16 |
| corvus | linters aren't supposed to drive functional and design decisions for programs | 15:17 |
| corvus | we must not let them do so | 15:17 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Update to create-react-app 3.4.1 https://review.opendev.org/716305 | 15:18 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Update links to buttons https://review.opendev.org/729996 | 15:18 |
| mordred | corvus: ^^ fixed the linting, and then did a followup changing to a button that is then styled to look like a link and included a link to the discussion of the issue (it's communicated as an accessibility issue) | 15:20 |
| tristanC | corvus: it seems like in that case the lint rule points out a legitimate accessibility issue | 15:22 |
| corvus | mordred, tristanC: an accessibility issue is a great reason to have a check -- it's worth considering whether that's applicable in this situation | 15:23 |
| corvus | anyway, this seems like a great solution | 15:24 |
| *** dpawlik has quit IRC | 15:24 | |
| corvus | i didn't realize that mordred made an intentional change in the create-react update patch; it was so big | 15:24 |
| corvus | and it wasn't highlighted in the commit message | 15:24 |
| mordred | yeah - and I think we could in the future, when we have time, consider making a thing that looks more like a button than a link but _doesn't_ do the flashing thing | 15:24 |
| mordred | corvus: it actually was highlighted in the commit message | 15:24 |
| mordred | but I agree - it's a big patch | 15:25 |
| mordred | corvus: https://review.opendev.org/#/c/716305/29//COMMIT_MSG line 18-21 | 15:25 |
| corvus | mordred: ah, sorry, i misunderstood that | 15:26 |
| corvus | mordred: i don't have any suggestions for better wording, i just misparsed it | 15:26 |
| mordred | I blame javascript | 15:26 |
| mordred | corvus: also - last time I went to the write up of the issue there was not an example of how to do the css | 15:26 |
| mordred | so - they updated that and it was definitely more helpful this time :) | 15:27 |
| corvus | mordred, tristanC: i'm happy with this outcome -- hopefully we can fix the accessibility issue without the visual regression, and it's subtle enough that considering it as its own change makes sense i think | 15:29 |
| mordred | ++ | 15:29 |
| *** rlandy|mtg is now known as rlandy | 15:30 | |
| clarkb | re accessibility, I've often wondered how zuul's dashboard does with colorblindness. I've run it in some browser plugins that try to approximate it for people who aren't colorblind, and it seems like we're mostly ok but workign with someone who can provide first hand feedback might be a good idea too. jungleboyj perhaps | 15:31 |
| corvus | clarkb: the colors were chosen explicitly with that in mind | 15:32 |
| clarkb | corvus: ya I want to say the only thing I noticed was the status bar for each change can blend together | 15:33 |
| clarkb | otherwise our use of icons and words really help (but again this was via browser extension approximation) | 15:33 |
| corvus | yep, not relying on any one signal is another important choice | 15:34 |
| corvus | but yeah, the squashed progress bar is tricky | 15:34 |
| clarkb | AJaeger: on https://review.opendev.org/#/c/729407/ you mentioned you couldn't find where my test change was running. I found https://zuul.opendev.org/t/zuul/build/150656acf4d4488784b41c97bd245373/log/job-output.txt#359 and https://zuul.opendev.org/t/zuul/build/150656acf4d4488784b41c97bd245373/log/job-output.txt#426 on the centos8 job. Do you know which log showed it not running? | 15:37 |
| clarkb | AJaeger: I think the above links show it running on the centos8 job at least | 15:37 |
| clarkb | AJaeger: spot checking fedora31 and ubuntu bionic jobs I also see it installing the package multiple times | 15:39 |
| AJaeger | clarkb: interesting - if I go to console that task is not shown, so https://zuul.opendev.org/t/zuul/build/150656acf4d4488784b41c97bd245373/console shows me "Set emacs package fact for gentoo" but not "Install a package to sanity check the http mirror configuration" ;( | 15:50 |
| AJaeger | at least it runs ;) | 15:50 |
| AJaeger | clarkb: interesting, https://zuul.opendev.org/t/zuul/build/4e55faf3c12b4c7abe55cd29c7307da9/console shows both | 15:51 |
| AJaeger | clarkb: do you see this as well - or want a screenshot? | 15:52 |
| clarkb | AJaeger: I see it as well. | 15:53 |
| *** bhavikdbavishi has joined #zuul | 15:54 | |
| clarkb | looking at the json those tasks have a start but not end attribute I wonder if that breaks the rendering https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_150/729407/6/check/zuul-jobs-test-base-roles-centos-8/150656a/job-output.json grep for bc764e04-4f0d-8bf4-011d-000000000076 and bc764e04-4f0d-8bf4-011d-000000000077 | 15:54 |
| clarkb | corvus: ^ fyi possible ansible bug affecting the console render from json | 15:54 |
| AJaeger | clarkb: gave a +2 now. | 15:54 |
| clarkb | interesting they also lack hosts content | 15:54 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Update to create-react-app 3.4.1 https://review.opendev.org/716305 | 15:55 |
| clarkb | AJaeger: I expect this is an underlying ansible bug and the console render is unable to render properly as a result | 15:56 |
| clarkb | AJaeger: the zuul live stream runs out of band of the normal json logging so isn't hit by it | 15:56 |
| AJaeger | clarkb: agreed, this does not look like your change - so, hope you get a second +2 soon on https://review.opendev.org/729407 | 15:57 |
| *** bhavikdbavishi1 has joined #zuul | 15:59 | |
| *** bhavikdbavishi has quit IRC | 16:01 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 16:01 | |
| *** ysandeep is now known as ysandeep|afk | 16:14 | |
| *** hashar has joined #zuul | 16:14 | |
| clarkb | zuulians https://review.opendev.org/#/c/729774/ is a straightforward and simple cleanup for dnf/fedora if you ahve a moment. Not having that creates error like logs in our logs | 16:30 |
| *** jamesmcarthur has joined #zuul | 16:39 | |
| *** jamesmcarthur has quit IRC | 16:44 | |
| *** jpena is now known as jpena|off | 16:55 | |
| *** newbie2020 has quit IRC | 17:21 | |
| *** ysandeep|afk is now known as ysandeep | 17:25 | |
| *** saneax has quit IRC | 17:31 | |
| openstackgerrit | Merged zuul/zuul-jobs master: Remove failovermethod from fedora dnf repo configs https://review.opendev.org/729774 | 17:33 |
| corvus | clarkb, AJaeger: re the json logs -- task 76 and 77 have an empty hosts entry | 17:37 |
| *** ysandeep is now known as ysandeep|away | 17:40 | |
| corvus | so it seems like we're missing some data in the json log | 17:40 |
| clarkb | corvus: I wonder if it is related to use post tasks in that play | 17:57 |
| corvus | oh interesting idea | 18:06 |
| corvus | i'll try to set up a reproducer in a bit | 18:06 |
| *** hashar has quit IRC | 18:40 | |
| *** rlandy is now known as rlandy|biab | 18:46 | |
| *** jamesmcarthur has joined #zuul | 19:11 | |
| *** bhavikdbavishi has quit IRC | 19:11 | |
| avass | mordred, corvus, tristanC: I think 716305 looks good but we should probably do a follow up where we fix the test-cases that breaks when we bump react-redux to >=7.1.1 | 19:18 |
| corvus | avass, mordred, tristanC: tell me if this happens for you: go to https://c0fd7cac0d91a05f159e-bfa575caa653e6626d0ca0e6976a8b70.ssl.cf2.rackcdn.com/716305/31/check/zuul-build-dashboard-opendev/1ce9e04/npm/html/ click any "status" link (i chose zuul) and there are no pipelines listed. then click 'refresh' and they show up. | 19:23 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Do not interpolate values from tox --showconfig https://review.opendev.org/729520 | 19:23 |
| avass | corvus: no pipelines :( | 19:23 |
| avass | corvus: okay, so new problem | 19:24 |
| corvus | when i go to the openstack-whitelabel build i don't see the same problem: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_f1a/716305/31/check/zuul-build-dashboard-openstack-whitelabel/f1a4b80/npm/html/ | 19:25 |
| avass | corvus: no it seems to be whenever you go a status page from the tenants page | 19:25 |
| corvus | switching to a different tab and then switching back fixes it too | 19:26 |
| corvus | so it seems like it's just the initial load, and just from the tenant page | 19:26 |
| avass | maybe something is 'false' when it should be 'true' | 19:29 |
| avass | :) | 19:29 |
| avass | corvus: oh could it be that the visibilityChangeEvent doesn't get fired when you go from the tenant page to the status page, but it does when you change tab? https://opendev.org/zuul/zuul/src/branch/master/web/src/pages/Status.jsx#L79 | 19:41 |
| tristanC | https://opendev.org/zuul/zuul/src/branch/master/web/src/pages/Status.jsx#L117 is it normal that there is a `prevProps.timezo` ? | 19:42 |
| corvus | tristanC: that certainly looks suspicious | 19:43 |
| *** yolanda has quit IRC | 19:43 | |
| corvus | tristanC: though that is in the current codebase | 19:45 |
| corvus | the timezone change hasn't deployed in opendev though | 19:45 |
| corvus | so i can't test it that way | 19:45 |
| corvus | was change https://review.opendev.org/722653 | 19:46 |
| tristanC | corvus: and master is already affected https://f3cf66b89bf64d495e44-f254b82d56f00afed164d6502a24a72d.ssl.cf1.rackcdn.com/722653/10/check/zuul-build-dashboard-multi-tenant/1345afd/npm/html | 19:46 |
| corvus | tristanC: what's that link from? | 19:46 |
| tristanC | from https://review.opendev.org/722653 check | 19:47 |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: web: fix typo in status page preventing initial load https://review.opendev.org/730115 | 19:47 |
| corvus | tristanC: ah from ps10; i was trying ps11 and that wasn't working for some reason | 19:48 |
| corvus | tristanC: thanks for finding that | 19:49 |
| tristanC | it seems like this might be cause an issue with regards to the initial status page loading, though i'm not sure if using the right prop name will fix that | 19:49 |
| corvus | i agree | 19:49 |
| corvus | tristanC, avass, mordred: the build of 730115 should tell us, and if it works, then probably the react-app upgrade is good to go | 19:50 |
| avass | oh I see, that makes sense | 19:52 |
| avass | I have a couple of small changes in zuul-jobs by the way: https://review.opendev.org/#/c/728708/ https://review.opendev.org/#/c/729520/ https://review.opendev.org/#/c/726836/ | 19:53 |
| avass | doesn't look like we're going to get a response from XiaojueGuan on 726836 | 19:54 |
| tristanC | corvus: https://review.opendev.org/730115 was not enough , https://de4aad5b1ac855d3c863-c46dc4d37fef1869c0d0d51dc6a4d27f.ssl.cf2.rackcdn.com/730115/1/check/zuul-build-dashboard-software-factory/eb90d96/npm/html/ still has the issue | 20:06 |
| tristanC | i'll dig some more and write some comment | 20:06 |
| *** rlandy|biab is now known as rlandy | 20:08 | |
| *** dpawlik has joined #zuul | 20:08 | |
| corvus | clarkb: when i run the 'package' task locally with the zuul_json callback enabled, i get the expected output; i'll dig in the logs on the executor and see if it logged anything unusual | 20:10 |
| corvus | 2020-05-20 22:23:58,422 DEBUG zuul.AnsibleJob.output: [e: 92d3592b9b9441df8010d9edf2d674aa] [build: 150656acf4d4488784b41c97bd245373] Ansible output: b'[WARNING]: Failure using method (v2_runner_on_ok) in callback plugin' | 20:13 |
| corvus | 2020-05-20 22:23:58,423 DEBUG zuul.AnsibleJob.output: [e: 92d3592b9b9441df8010d9edf2d674aa] [build: 150656acf4d4488784b41c97bd245373] Ansible output: b"'AnsibleUnsafeText' object has no attribute 'get'" | 20:13 |
| corvus | that looks like something | 20:13 |
| tristanC | ok i understood, it's because the StatusPage.componentDidUpdate is shadowing the function from the Refreshable class which does the status page refresh on initial page load | 20:18 |
| tristanC | and i'm not sure to understand why should we call loadState when the timezone change | 20:21 |
| corvus | tristanC: if we want to revert the timezone change until this is fixed, that's ok | 20:23 |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: web: remove status page componentDidUpdate implementation https://review.opendev.org/730115 | 20:24 |
| corvus | tobiash: do you happen to know why the zuul_unreachable callback inherits from default.CallbackModule instead of CallbackBase? | 20:25 |
| tristanC | corvus: well i think ^ is the correct fix, otherwise we can add a super.componentDidUpdate() call | 20:25 |
| tobiash | corvus: no, I think I just bootstrapped based on the other callbacks | 20:26 |
| corvus | tobiash: the other ones use CallbackBase; maybe something changed since then | 20:26 |
| tobiash | is there a problem with it? | 20:27 |
| corvus | tobiash: i happened to notice when i'm running with it locally i get: [WARNING]: Failure using method (v2_runner_on_start) in callback plugin (<ansible.plugins.callback.zuul_unreachable.CallbackModule object at 0x7f76c024e208>): 'show_per_host_start' | 20:28 |
| corvus | and now that i look in prod, i see that too | 20:28 |
| corvus | switching to CallbackBase seems to resolve that | 20:28 |
| corvus | i think it may be 2.9+ behavior | 20:29 |
| corvus | https://github.com/ansible/ansible-runner/issues/279 is relevant | 20:29 |
| tobiash | corvus: zuul_stream inherits from the same (I think I copied from that) | 20:29 |
| corvus | ah so it does; it's zuul_json that does the other | 20:30 |
| corvus | i have no idea why it would not emit the same error | 20:30 |
| corvus | maybe because it's not an aggregate plugin? <shrug> | 20:31 |
| corvus | tobiash: i'll push up a change to switch it in a bit | 20:32 |
| tobiash | ++ | 20:32 |
| *** dpawlik has quit IRC | 20:52 | |
| *** asaleh_ has quit IRC | 20:54 | |
| corvus | clarkb: i'm unable to reproduce the error we see in production; i'm using the same ansible version (2.9.5), and using post_tasks. i'm not running the actual mirror config role locally though. | 20:55 |
| corvus | so maybe there's some state built up from previous actions that affects it | 20:55 |
| clarkb | corvus: we are repeating actions there so that could be it | 20:56 |
| corvus | clarkb: well, even the first "install a package" task didn't have the output right? | 20:57 |
| clarkb | I'm double checking | 21:01 |
| clarkb | and ya it happens in both passes | 21:02 |
| clarkb | at the same point, the tasks after the gentoo fact are "lost" | 21:02 |
| *** mattw4 has joined #zuul | 21:17 | |
| *** mattw4 has quit IRC | 21:20 | |
| mordred | corvus, tristanC: 730115 seems to have fixed it | 21:21 |
| corvus | mordred, tristanC: w00t! +3 | 21:21 |
| corvus | mordred: switched to +2 on https://review.opendev.org/716305 | 21:22 |
| mordred | corvus: woot | 21:22 |
| mordred | tobiash, tristanC: if you find yourself bored with extra time on your hands, https://review.opendev.org/#/c/716305/ is ready | 21:24 |
| mordred | (it's not as bad a change as it might at first seem) | 21:24 |
| avass | it only took two months to figure out why it didn't work ;) | 21:26 |
| *** jamesmcarthur has quit IRC | 21:41 | |
| mordred | avass: it's a team effort :) | 21:46 |
| mordred | avass: on the positive side - the patternfly-react folks reacted VERY quickly | 21:47 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: add simple test runner https://review.opendev.org/728684 | 21:50 |
| *** jamesmcarthur has joined #zuul | 21:51 | |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Update links to buttons https://review.opendev.org/729996 | 21:54 |
| avass | mordred: yeah, that was really nice | 21:58 |
| *** jamesmcarthur has quit IRC | 22:05 | |
| *** jamesmcarthur has joined #zuul | 22:05 | |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: add simple test runner https://review.opendev.org/728684 | 22:06 |
| openstackgerrit | Merged zuul/zuul master: web: remove status page componentDidUpdate implementation https://review.opendev.org/730115 | 22:17 |
| *** jamesmcarthur has quit IRC | 23:16 | |
| *** zxiiro has quit IRC | 23:17 | |
| *** jamesmcarthur has joined #zuul | 23:26 | |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: WIP: Add tutorial tests https://review.opendev.org/728194 | 23:28 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: WIP: Add tutorial tests https://review.opendev.org/728194 | 23:34 |
| *** jamesmcarthur has quit IRC | 23:49 | |
| *** jamesmcarthur has joined #zuul | 23:50 | |
| *** jamesmcarthur has quit IRC | 23:55 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!