| *** tosky has quit IRC | 00:01 | |
| *** jamesmcarthur has quit IRC | 00:01 | |
| *** jamesmcarthur has joined #zuul | 00:13 | |
| *** jamesmcarthur has quit IRC | 00:16 | |
| *** threestrands has joined #zuul | 00:19 | |
| *** jamesmcarthur has joined #zuul | 00:29 | |
| *** jamesmcarthur has quit IRC | 00:30 | |
| *** guillaumec has quit IRC | 00:32 | |
| *** cdearborn has quit IRC | 00:48 | |
| *** swest has quit IRC | 01:36 | |
| *** saneax has quit IRC | 01:42 | |
| *** swest has joined #zuul | 01:54 | |
| *** jamesmcarthur has joined #zuul | 01:59 | |
| *** jamesmcarthur has quit IRC | 02:10 | |
| *** rlandy has quit IRC | 02:16 | |
| *** jamesmcarthur has joined #zuul | 02:51 | |
| *** bhavikdbavishi has joined #zuul | 02:56 | |
| *** bhavikdbavishi1 has joined #zuul | 03:00 | |
| *** bhavikdbavishi has quit IRC | 03:02 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 03:02 | |
| *** saneax has joined #zuul | 03:15 | |
| *** zxiiro has quit IRC | 03:21 | |
| *** jamesmcarthur has quit IRC | 03:54 | |
| *** jamesmcarthur has joined #zuul | 03:55 | |
| *** jamesmcarthur has quit IRC | 04:12 | |
| *** jamesmcarthur has joined #zuul | 04:12 | |
| *** jamesmcarthur has quit IRC | 04:16 | |
| *** jamesmcarthur has joined #zuul | 04:16 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #zuul | 04:33 | |
| *** raukadah is now known as chandankumar | 04:36 | |
| *** sgw has quit IRC | 04:59 | |
| *** hashar has joined #zuul | 05:09 | |
| *** sgw has joined #zuul | 05:17 | |
| *** jamesmcarthur has quit IRC | 05:32 | |
| *** jamesmcarthur has joined #zuul | 05:33 | |
| *** bhavikdbavishi has quit IRC | 05:34 | |
| *** jamesmcarthur has quit IRC | 05:38 | |
| ianw | swest: see https://review.opendev.org/728889 re dib python2 discussion yesterday | 05:45 |
|---|---|---|
| swest | ianw: yay, that should fix https://review.opendev.org/#/c/728824/ for me, thanks! | 05:48 |
| *** bhavikdbavishi has joined #zuul | 05:54 | |
| *** dpawlik has joined #zuul | 05:57 | |
| *** hashar has quit IRC | 05:59 | |
| AJaeger | clarkb: thanks for fixing the tox env change. | 06:00 |
| *** jamesmcarthur has joined #zuul | 06:09 | |
| *** jamesmcarthur has quit IRC | 06:19 | |
| *** yolanda has joined #zuul | 06:33 | |
| *** bhavikdbavishi has quit IRC | 06:35 | |
| *** ysandeep|away is now known as ysandeep | 06:39 | |
| avass | clarkb, AJaeger: I think the solution is to turn off interpolation in configparser because I don't think tox supports it | 06:50 |
| avass | I'll push a change for that later | 06:50 |
| *** newbie2020 has joined #zuul | 06:54 | |
| newbie2020 | . | 06:54 |
| AJaeger | avass: Ah, thx | 06:54 |
| *** jamesmcarthur has joined #zuul | 06:54 | |
| newbie2020 | @fungi and @corvus you were right about the question I had yesterday on things getting picked from multiple branch in the same build: thanks! | 06:56 |
| newbie2020 | Now there is a question, the situation goes like this. The directive 'branches: master' was added to repoA@master, then someone created a branch repoA@foo and that branch contains the directive 'brances: master' of course | 06:58 |
| newbie2020 | So now also repoA@foo matched and that resulted in the specific job (same name and present in both branches, the one with the 'branches: master' directive) role in the PRE-RUN being executed twice. | 06:59 |
| newbie2020 | I find it a bit weird, but that is fine. | 06:59 |
| newbie2020 | However that job runs in a periodic pipeline so I would like for that to run only once and ignoring any other branches that may contain a variant of the same job | 07:00 |
| newbie2020 | Is that possible? | 07:00 |
| newbie2020 | I was looking at 'exclude-unprotected-branches' since we use GitHub, but not sure it is the proper way to proceed | 07:01 |
| *** dmellado has quit IRC | 07:02 | |
| tobiash | newbie2020: did you specify the branches attribute on jobs? | 07:03 |
| newbie2020 | this is what caused the problem I was describing yesterday http://eavesdrop.openstack.org/irclogs/%23zuul/%23zuul.2020-05-19.log.html | 07:04 |
| *** jamesmcarthur has quit IRC | 07:05 | |
| *** bhavikdbavishi has joined #zuul | 07:06 | |
| tobiash | newbie2020: zuul has a global configuration namespace and branch matchers define to what branches that configuration snippet matches. If you branch a repo containing such a snippet it also matches the master branch. Hence this snippet gets used twice during job freezing and can lead to unexpected effects when they differ | 07:07 |
| tobiash | thus it's better to scope jobs to specific branches in the 'project' configuration snippet | 07:08 |
| *** jcapitao has joined #zuul | 07:08 | |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Do not interpolate values from tox --showconfig https://review.opendev.org/729520 | 07:09 |
| newbie2020 | thanks tobiash! | 07:09 |
| newbie2020 | > thus it's better to scope jobs to specific branches in the 'project' configuration snippet> | 07:09 |
| newbie2020 | any suggestions about the correct way to do that? Is the branches directive? | 07:09 |
| tobiash | further exclude-unprotected-branches should basically enabled for all github repos as soon as you use branch+push workmode instead of fork+push | 07:10 |
| newbie2020 | got it, I will try that | 07:12 |
| newbie2020 | last question (for today :P) | 07:12 |
| tobiash | newbie2020: you could try something like this: https://etherpad.opendev.org/p/Hd6FpHxQc9-_ZED5aOA8 | 07:12 |
| avass | AJaeger: lets see if 729520 does the trick | 07:13 |
| AJaeger | avass: Run (before the project-config change merged) "tox -e linters --showconfig" on project-config and see it fail. I don't think your change will fix that | 07:13 |
| newbie2020 | @tobiash I think part of my confusion comes from the difference job/project branch matchers | 07:14 |
| AJaeger | avass: I guess there's nothing you can do... | 07:14 |
| avass | AJaeger: oh! it was the --showconfig that broke | 07:15 |
| AJaeger | avass: yes! | 07:15 |
| avass | AJaeger: so that's tox itself then | 07:16 |
| AJaeger | avass: see https://review.opendev.org/#/c/729402/ - first failures on linters | 07:16 |
| avass | AJaeger: is that a bug in tox then? | 07:16 |
| AJaeger | might be ;( | 07:17 |
| *** bhavikdbavishi has quit IRC | 07:18 | |
| *** tosky has joined #zuul | 07:30 | |
| *** bhavikdbavishi has joined #zuul | 07:31 | |
| *** bhavikdbavishi has quit IRC | 07:36 | |
| *** bhavikdbavishi has joined #zuul | 07:37 | |
| avass | AJaeger: it works in tox 3.11 but breaks in 3.12 | 07:45 |
| avass | AJaeger: So I'd say that's a regression in tox | 07:45 |
| avass | AJaeger: 3.11 introduced configparser and I guess 3.12 broke it :( | 07:47 |
| *** jpena|off is now known as jpena | 07:52 | |
| avass | AJaeger: actually, it was 3.11 that breaks showconfig, and that's the release that overhauled --showconfig to use configparser https://tox.readthedocs.io/en/latest/changelog.html#v3-11-0-2019-05-15 | 07:53 |
| AJaeger | avass: want to file a bugreport? thanks! | 07:57 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Increase wait time in remote tests https://review.opendev.org/728892 | 07:57 |
| avass | AJaeger: already on it :) | 07:59 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Link to previous buildset results when reporting a check to Github https://review.opendev.org/728463 | 08:00 |
| *** nils has joined #zuul | 08:07 | |
| avass | AJaeger: the fix for it looks easy so I'll push a change to tox later and discuss it with the devs | 08:14 |
| *** asaleh_ has joined #zuul | 08:16 | |
| zbr | avass: post tox bug reports here, i may be able to help. | 08:21 |
| avass | zbr: https://github.com/tox-dev/tox/issues/1584 | 08:22 |
| AJaeger | thanks, avass ! | 08:22 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Zuul CLI: add console-stream command https://review.opendev.org/729236 | 08:24 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [WIP] web UI: add Autoholds Requests page https://review.opendev.org/729307 | 08:31 |
| *** dmellado has joined #zuul | 08:34 | |
| openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul-jobs master: tox: allow tox to be upgraded https://review.opendev.org/690057 | 08:45 |
| *** jamesmcarthur has joined #zuul | 09:02 | |
| *** jamesmcarthur has quit IRC | 09:06 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [WIP] web UI: add Autoholds Requests page https://review.opendev.org/729307 | 09:24 |
| avass | AJaeger, clarkb, zbr: This should fix it: https://github.com/tox-dev/tox/pull/1585/files | 09:28 |
| *** ysandeep is now known as ysandeep|lunch | 09:29 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: set Access-Control-Allow-Origin header for autohold https://review.opendev.org/729549 | 09:31 |
| *** bhavikdbavishi has quit IRC | 09:41 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [WIP] web UI: add Autoholds Requests page https://review.opendev.org/729307 | 09:46 |
| *** ysandeep|lunch is now known as ysandeep | 10:09 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Builds: add "held" attribute https://review.opendev.org/728994 | 10:21 |
| tobiash | mordred: is the job nodejs-npm-run-test broken atm? It's unrelated to the dynamic badge change https://review.opendev.org/702128 but fails constantly | 10:22 |
| mhu | tobiash, I've just seen this too: Error: Cannot find module '/home/zuul/src/opendev.org/zuul/zuul/web/node_modules/jest-cli' | 10:24 |
| mhu | in that test | 10:24 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Do not interpolate values from tox --showconfig https://review.opendev.org/729520 | 10:27 |
| tobiash | hrm, here it works: https://review.opendev.org/716305 | 10:27 |
| tobiash | maybe that fixes it | 10:27 |
| tobiash | I'll try with a test change | 10:27 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Support dynamic badges https://review.opendev.org/702128 | 10:28 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Update to create-react-app 3.4.1 https://review.opendev.org/716305 | 10:33 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Support dynamic badges https://review.opendev.org/702128 | 10:33 |
| mhu | could I get a +3 on this please: https://review.opendev.org/#/c/729549/ - it adds CORS headers for the autohold endpoint | 10:35 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Support dynamic badges https://review.opendev.org/702128 | 10:35 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Do not interpolate values from tox --showconfig https://review.opendev.org/729520 | 10:37 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Support dynamic badges https://review.opendev.org/702128 | 10:38 |
| *** bhavikdbavishi has joined #zuul | 10:40 | |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Update to create-react-app 3.4.1 https://review.opendev.org/716305 | 10:42 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Support dynamic badges https://review.opendev.org/702128 | 10:42 |
| *** jcapitao is now known as jcapitao_lunch | 10:44 | |
| openstackgerrit | Timo Lotterbach proposed zuul/zuul master: Fix trivial typo in glossary https://review.opendev.org/729562 | 10:45 |
| *** ysandeep is now known as ysandeep|brb | 11:00 | |
| *** jamesmcarthur has joined #zuul | 11:03 | |
| *** ysandeep|brb is now known as ysandeep | 11:13 | |
| *** jamesmcarthur has quit IRC | 11:22 | |
| *** jpena is now known as jpena|lunch | 11:30 | |
| openstackgerrit | Merged zuul/zuul master: set Access-Control-Allow-Origin header for autohold https://review.opendev.org/729549 | 11:32 |
| openstackgerrit | Merged zuul/zuul master: Fix trivial typo in glossary https://review.opendev.org/729562 | 11:37 |
| *** sshnaidm is now known as sshnaidm|afk | 11:42 | |
| openstackgerrit | Tristan Cacqueray proposed zuul/nodepool master: config: add environment variable substitution https://review.opendev.org/719599 | 11:45 |
| *** bhavikdbavishi has quit IRC | 11:54 | |
| *** bhavikdbavishi has joined #zuul | 12:06 | |
| *** jcapitao_lunch is now known as jcapitao | 12:17 | |
| *** rlandy has joined #zuul | 12:21 | |
| *** hashar has joined #zuul | 12:26 | |
| *** jpena|lunch is now known as jpena | 12:26 | |
| mordred | tobiash: hrm - i'll look at that - however, check this out: https://review.opendev.org/#/c/726553/ | 12:35 |
| mordred | tobiash: (updates us to the new jobs) | 12:35 |
| tobiash | mordred: I'll try a depends-on to that, let's see | 12:39 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Support dynamic badges https://review.opendev.org/702128 | 12:39 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Update node to v14 and update to new jobs https://review.opendev.org/726553 | 12:44 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Use node image to build javascript https://review.opendev.org/728690 | 12:45 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Support dynamic badges https://review.opendev.org/702128 | 12:45 |
| *** Goneri has joined #zuul | 12:45 | |
| mordred | tobiash: in any case I do not understand that error | 12:47 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Update to create-react-app 3.4.1 https://review.opendev.org/716305 | 12:52 |
| *** sshnaidm|afk is now known as sshnaidm | 12:53 | |
| avass | mordred: have we figured out why react-scripts build doesn't do what we want it to do yet? | 12:57 |
| mordred | avass: nope! not yet. I mean, I'm certain that it's webpack optimizing away what it thinks is unused code | 13:04 |
| mordred | avass: I haven't figured out how to change the code to make webpack realize we actually are using it | 13:04 |
| avass | mordred: yeah, I haven't been able to find any bug report or anyone else experiencing this problem | 13:10 |
| *** cdearborn has joined #zuul | 13:11 | |
| mordred | avass: I found a few but none of them were helpful in our case - lemme see if I can find one again to share | 13:14 |
| mordred | avass: https://github.com/webpack/webpack/issues/7499 | 13:15 |
| mordred | avass: it's not quite the same thing - but I think it's likely to be a similar issue | 13:16 |
| mordred | avass: unfortunately, editing our webpack config is hard becase it's managed by create-react-scripts | 13:17 |
| *** jamesmcarthur has joined #zuul | 13:19 | |
| avass | mordred: I've been trying to avoid ejecting the config so we don't have to deal with that :) | 13:19 |
| mordred | yeah | 13:22 |
| mordred | avass: https://dev.to/nodewarrior/override-cra-and-add-webpack-config-without-ejecting-2f3n | 13:22 |
| *** jamesmcarthur has quit IRC | 13:26 | |
| avass | mordred: I wonder if it could be related to this: https://github.com/facebook/create-react-app/issues/8687 | 13:31 |
| mordred | avass: also - maybe what we should do is a followup patch where we've ejected so we can poke at tweaking webpack settings a little cleaner - and if we find something that fixes it we can then figure out how to apply that without ejecting | 13:32 |
| * mordred reads | 13:32 | |
| avass | So what if the problem isn't that webpack is optimizing the code away, the minifier messes up the comments so it isn't used | 13:33 |
| *** jamesmcarthur has joined #zuul | 13:35 | |
| avass | well I guess those are releated | 13:36 |
| mordred | hrm. remind me where the problem chunk is again | 13:37 |
| mordred | ? | 13:37 |
| * mordred goes to look | 13:38 | |
| avass | mordred: in App.jsx, anything to do with fetchConfigErrors really | 13:39 |
| avass | testing it by removing any comments in that file | 13:40 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Builds: add "held" attribute https://review.opendev.org/728994 | 13:40 |
| *** bhavikdbavishi has quit IRC | 13:42 | |
| mordred | avass: cool | 13:44 |
| mordred | avass: also - another thought I had was in the render function, get rid of this: { configErrors.length > 0 && | 13:45 |
| mordred | avass: and always return the component, but instead tie its visibility css property to configErrors.length | 13:45 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: DNM Does this conditional break things https://review.opendev.org/729605 | 13:46 |
| mordred | avass: ^^ stupid attempt | 13:46 |
| avass | mordred: I think I already tested that :) | 13:49 |
| avass | AJaeger, clarkb: there's a new tox release now https://tox.readthedocs.io/en/latest/changelog.html#v3-15-1-2020-05-20 :) | 13:59 |
| mordred | avass: yeah - it didn't work | 14:02 |
| *** newbie2020 has quit IRC | 14:02 | |
| AJaeger | avass: nice! | 14:05 |
| *** hashar has quit IRC | 14:10 | |
| mordred | avass: sideEffects = false fixes it | 14:18 |
| mordred | avass: I do not know how to set that without ejecting - but it definitely fixes it | 14:18 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: DNM Ejected config https://review.opendev.org/729616 | 14:21 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: DNM Set sideEffects to false https://review.opendev.org/729617 | 14:21 |
| mordred | avass: ^^ that shoudl show it in jobs - so I think if we can then figure out how to set just that one thing without making our setup SUPER crazy, we should be good | 14:22 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Update to create-react-app 3.4.1 https://review.opendev.org/716305 | 14:24 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: DNM Ejected config https://review.opendev.org/729616 | 14:25 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: DNM Set sideEffects to false https://review.opendev.org/729617 | 14:25 |
| avass | mordred: so that turns off the sideEffects flag in package.json | 14:27 |
| avass | mordred: I have a wonderful solution :) | 14:30 |
| avass | mordred: setting sideEffects: true in package.json in patternfly-react fixes it! | 14:30 |
| avass | mordred: so we could do something like: 1) run yarn install, 2) modify node_modules/patternfly-react/package.json, 3) run yarn build | 14:32 |
| avass | or push a fix upstream I guess | 14:32 |
| mordred | yeah. although upstream is on v4 now | 14:33 |
| avass | yeah that might be a problem | 14:33 |
| mordred | we could also try updating to their v4 - I have no idea how much effort _that_ would be | 14:33 |
| mordred | avass: I'm kind of partial to the "just fix the node_modules/patternfly-react/package.json for now" approach | 14:33 |
| avass | I took a quick look at that, it didn't look like they have a 1:1 mapping of NotificationDrawer etc | 14:33 |
| *** threestrands has quit IRC | 14:34 | |
| mordred | avass: they don't even have a v2 branch | 14:35 |
| *** bhavikdbavishi has joined #zuul | 14:37 | |
| avass | mordred: I would say patternfly-react actually has side-effects in NotificationDrawer if I'm reading this right: https://stackoverflow.com/questions/49160752/what-does-webpack-4-expect-from-a-package-with-sideeffects-false | 14:39 |
| mordred | avass: yeah - I think it's definitely a bug in patternfly-react | 14:40 |
| mordred | avass: oh - so the patternfly-3 branch is where v2.39 is | 14:42 |
| mordred | (don't even ask) | 14:42 |
| mordred | so I think we can send in a PR | 14:42 |
| *** zxiiro has joined #zuul | 14:44 | |
| mordred | avass: https://github.com/patternfly/patternfly-react/pull/4267 | 14:45 |
| mordred | avass: I think with that, we should just add an edit of the file in our package.json scripts for now and we can remove it when they land that | 14:46 |
| mordred | avass: alternately, we could published a forked version of p-r to npm and depend on that until they do | 14:47 |
| mordred | which might be easier than having a script edit the file | 14:48 |
| mordred | in other news though - \o/ | 14:48 |
| mordred | corvus: do you have an opinion on which of the options would be a better solution ^^ | 14:49 |
| mordred | corvus: tl;dr - have javascript build edit a file in node_modules before building, or publishing a forked copy of the lib in question with the fix applied and depending on that | 14:49 |
| mordred | (hopefully both are temporary, a fix has been submitted upstream - but no clue how responsive/receptive they'll be) | 14:50 |
| corvus | mordred: hehe, any *good* options? :) i kind of lean toward the patch for now... | 14:50 |
| corvus | mordred: mostly, i think, because of an aversion to removing things published to npm. i could get over that though. | 14:51 |
| mordred | corvus: I was thinking publishing it as @emonty/patternfly-react-with-sideeffects | 14:52 |
| mordred | so that it wouldn't be attractive to other people | 14:52 |
| corvus | mordred: okay, that wfm if you want. it looks like they haven't toched the -3 branch in 3 monhts | 14:52 |
| mordred | yeah | 14:52 |
| mordred | let me see how easy that winds up being | 14:52 |
| avass | mordred, corvus: if we don't go with the npm package we would have to split the js-package-manager role or allow users to somehow modify a package before build in the role | 14:55 |
| avass | or just not use the role | 14:56 |
| avass | or run it twice :) | 14:56 |
| corvus | that's a compelling reason for the npm route | 14:56 |
| avass | yeah | 14:56 |
| *** bhavikdbavishi has quit IRC | 14:57 | |
| mordred | avass, corvus: @emonty/patternfly-react-side-effects has been published | 15:00 |
| mordred | https://github.com/emonty/patternfly-react-side-effects https://www.npmjs.com/package/@emonty/patternfly-react-side-effects | 15:02 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Update to create-react-app 3.4.1 https://review.opendev.org/716305 | 15:03 |
| mordred | corvus, avass: ^^ updated to use it | 15:03 |
| avass | mordred: I jsut had to: https://github.com/emonty/patternfly-react-side-effects/pull/1 | 15:06 |
| avass | ;) | 15:06 |
| mordred | corvus: while i've distracted you with javascript, https://review.opendev.org/#/c/726553/ is ready for review | 15:06 |
| mordred | avass: haha | 15:06 |
| *** jamesmcarthur has quit IRC | 15:11 | |
| *** jamesmcarthur has joined #zuul | 15:12 | |
| mhu | hey there, I'm a bit stumped with testing in https://review.opendev.org/#/c/728994/7/tests/unit/test_scheduler.py - the builds in self.history are not actual builds? | 15:18 |
| corvus | mhu: not sure what you mean by 'actual builds' | 15:19 |
| mhu | corvus, in this patch I'm adding an attribute to builds and would like to check it in the build history, but it isn't present - so either builds stored in history are not "actual builds", or I'm not actually setting the new attribute, and in both cases I'd like to know what I'm doing wrong :) | 15:21 |
| corvus | mhu: gotcha. self.history is a list of FakeBuild objects recorded by the test system for inspecting characteristics of the builds | 15:26 |
| corvus | mhu: i'd suggest using the api to retrieve the build results and checking that. | 15:27 |
| corvus | (rest api) | 15:28 |
| mhu | corvus, alright, thanks! | 15:29 |
| *** jcapitao has quit IRC | 16:00 | |
| openstackgerrit | Albin Vass proposed zuul/zuul master: Update to create-react-app 3.4.1 https://review.opendev.org/716305 | 16:00 |
| avass | mordred: ^ | 16:00 |
| mordred | avass: ++ - I was just looking at that :) | 16:01 |
| avass | mordred: :) | 16:02 |
| avass | mordred: just had to do a find src -name '*.jsx' -exec sed... ;) | 16:02 |
| *** asaleh_ has quit IRC | 16:16 | |
| *** jamesmcarthur has quit IRC | 16:36 | |
| *** jamesmcarthur has joined #zuul | 16:39 | |
| *** ysandeep is now known as ysandeep|afk | 16:42 | |
| corvus | mordred, avass: will it mess you up if i +W https://review.opendev.org/722653 ? (yarn.lock change) | 16:51 |
| mordred | avass, corvus: dashboard patch is green: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_1dc/716305/24/check/zuul-build-dashboard-opendev/1dcf6a1/npm/html/tenants | 16:51 |
| zbr | mordred: avass: corvus: https://review.opendev.org/#/c/720145/ oneliner. | 16:51 |
| mordred | (click on zuul to verify) | 16:51 |
| mordred | corvus: nope. go for it, I can rebase on top of it | 16:52 |
| corvus | mordred, avass: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_1dc/716305/24/check/zuul-build-dashboard-opendev/1dcf6a1/npm/html/ is better url :) | 16:52 |
| corvus | mordred, avass: did we ever figure out the refresh thing? | 16:52 |
| mordred | corvus: (general yarn.lock rebase strategy is "delete yarn.lock and run yarn install") | 16:52 |
| corvus | the rando disappearing button is annoying :/ | 16:53 |
| mordred | corvus: oh - I don't know that I've looked in to that (or noticed it) - ah I see it now | 16:53 |
| mordred | corvus: nope, that wasn't on my list | 16:53 |
| corvus | mordred: yeah, the status page is the most egregious example | 16:53 |
| mordred | yeah | 16:53 |
| mordred | corvus: I landed 722653 - it'll be easier to do the rebase once it has landed - and it's not a hard rebase | 17:00 |
| fungi | on python 3.5, we should probably be prepared for it to go eol later this year i guess? 3.4 reached end of life after roughly 5 years from 3.4.0's release, and 3.5.0 was released september 2015 so is only a few months from its fifth birthday as well | 17:06 |
| avass | corvus, mordred: \o/ | 17:06 |
| fungi | oh, though i guess that conversation was going on in #opendev, not in here. sorry about the noise | 17:06 |
| avass | corvus, mordred: what's the refresh thing? | 17:08 |
| *** reiterative has quit IRC | 17:08 | |
| *** reiterative has joined #zuul | 17:09 | |
| corvus | avass: the refresh icon/button in the top right of the status page (also several other pages, but mostly status) | 17:10 |
| avass | corvus: what's wrong with it? | 17:11 |
| mordred | avass: I'm chatting with the patternfly dev about the issue on github - do you have a github id I can mention? | 17:11 |
| mordred | avass: (he's suggesting there might be a better fix on the patternfly side) | 17:12 |
| corvus | avass: compare to current -- it's unstyled and much bigger | 17:12 |
| avass | corvus: oh wow, I was going to say that I couldn't see a difference but it just popped up | 17:13 |
| corvus | mordred: @albinvass :) | 17:13 |
| avass | mordred: ^ | 17:13 |
| mordred | avass: consider yourself pinged :) | 17:14 |
| *** dpawlik has quit IRC | 17:15 | |
| mordred | I may have pinged the dev internally at rh just so they'd pay attention - I can imagine things on the patternfly-3 branch going unnoticed | 17:15 |
| *** jpena is now known as jpena|off | 17:15 | |
| *** ysandeep|afk is now known as ysandeep | 17:22 | |
| *** jamesmcarthur has quit IRC | 17:24 | |
| *** sugaar has quit IRC | 17:24 | |
| avass | mordred: I think the real fix is to just move the code at https://stackoverflow.com/questions/49160752/what-does-webpack-4-expect-from-a-package-with-sideeffects-false inside NotificationDrawer.js | 17:27 |
| avass | mordred: oh, wrong link: https://github.com/patternfly/patternfly-react/blob/patternfly-3/packages/patternfly-react/src/components/Notification/NotificationDrawer/index.js#L32 | 17:27 |
| *** jamesmcarthur has joined #zuul | 17:45 | |
| *** tumble has joined #zuul | 17:45 | |
| *** nils has quit IRC | 17:46 | |
| *** kmalloc has joined #zuul | 17:46 | |
| *** jamesmcarthur has quit IRC | 17:51 | |
| *** hashar has joined #zuul | 17:57 | |
| *** jamesmcarthur has joined #zuul | 18:00 | |
| *** guillaumec has joined #zuul | 18:04 | |
| *** chandankumar is now known as raukadah | 18:06 | |
| *** ysandeep is now known as ysandeep|away | 18:10 | |
| mordred | avass, corvus: woot - fix landed in patternfly (not our fix, he did a different thing) | 18:28 |
| mordred | fwiw: https://github.com/patternfly/patternfly-react/pull/4273 is the PR they made to fix it more properly | 18:29 |
| mordred | corvus: should I pull that in to my fake thing so we can verify it'll work for us? | 18:30 |
| mordred | oh - I can just point at that branch | 18:32 |
| avass | mordred: oh it's what I thought it was :) | 18:32 |
| mordred | avass: \o/ | 18:33 |
| *** hashar is now known as hasharAway | 18:35 | |
| *** jamesmcarthur has quit IRC | 18:40 | |
| *** jamesmcarthur has joined #zuul | 18:41 | |
| corvus | mordred: apparently they do continuous releasing? https://github.com/patternfly/patternfly-react/pull/4273#issuecomment-631648917 | 18:47 |
| corvus | so i guess we can just upgrade? | 18:49 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Update to create-react-app 3.4.1 https://review.opendev.org/716305 | 18:50 |
| mordred | corvus: oh neat! I'll update that patch to do less | 18:51 |
| zbr | this went ignored for over 4 years... https://review.opendev.org/#/c/277654/3 | 18:51 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Update to create-react-app 3.4.1 https://review.opendev.org/716305 | 18:55 |
| mordred | zbr: it's actually not correct to initialize the logger like that in a library - loggers should be initialized in applications - because if a library initializes the loggers (especially with basicConfig) it can introduce logging config that is at odds with the application using the library | 18:55 |
| corvus | zbr: you probably want the #opendev channel for that | 18:55 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Update node to v14 and update to new jobs https://review.opendev.org/726553 | 19:13 |
| mordred | corvus, clarkb, tobiash: ^^ sad-panda re-review? | 19:14 |
| mordred | corvus: we run a job in gate that we don't run in check - perhaps we shoudl add it to check? the thign is - we run it in gate without having an API_URL set (which will make it not have an override, making the artifact it produces usable by people directly) - but we weren't running that version in check because we already run build-dashboard 3 times with different API URL overrides | 19:15 |
| mordred | so - it seemed silly to run it a fourth time for a build we'll never browse - but maybe we should on general principle to make sure the job doesn't break like that? | 19:16 |
| clarkb | mordred: left a note. I think we should continue specifying the version, but specify 14 | 19:18 |
| clarkb | otherwise we'll be back out of sync soon | 19:18 |
| corvus | clarkb, mordred: is now a good time to remind about the project vars stanza? https://zuul-ci.org/docs/zuul/reference/project_def.html#attr-project.vars | 19:22 |
| corvus | eg: project.vars: node_version: 14 | 19:22 |
| clarkb | corvus: ya that might eb a good way to do it (the tools script for pip would still be separate though) | 19:23 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Update node to v14 and update to new jobs https://review.opendev.org/726553 | 19:23 |
| clarkb | the key to me is ensuring that we don't have 3 different nodejs versions in use with different failures across them | 19:23 |
| clarkb | any thing to remain consistent | 19:23 |
| mordred | clarkb: done | 19:24 |
| corvus | that's run via tox, we could probably plumb a zuul var through somehow | 19:24 |
| mordred | corvus: oh - yeah | 19:24 |
| mordred | well - sadly the nodeenv needs a specific version - "14" isn't enough - but let's at least start with project.vars | 19:25 |
| corvus | it's at least a nice feature demo :) | 19:25 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Update node to v14 and update to new jobs https://review.opendev.org/726553 | 19:25 |
| mordred | corvus: yeah - cause I keep forgetting we added it (and wishing we would :) ) | 19:26 |
| corvus | mordred: re the other thing -- just brainstorming -- would it make sense to run all 4 builds in one job? link to them as different artifacts? | 19:26 |
| corvus | ie, would that be fast enough, more efficient, and not too difficult to implement? | 19:26 |
| mordred | corvus: yeah - I had a similar thought the other day - I think it would be much more efficient - might take a minute of thinking about how to do it sanely - but probably not that bad | 19:27 |
| corvus | i'm kinda assuming than "yarn build" is faster the second time :) | 19:27 |
| mordred | you'd think | 19:28 |
| mordred | but I'm actually not sure it would be in this case | 19:28 |
| corvus | well, there's probably lots of dependency downloading (not to mention node setup) that we would dodge | 19:28 |
| mordred | (doing local test) | 19:29 |
| mordred | oh - yeah - we'd only do one yarn install for sure | 19:29 |
| mordred | hrm. I lost the browserlist in that last patch :( | 19:30 |
| mordred | oh - no - that was added in a subsequent patch | 19:32 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Use node image to build javascript https://review.opendev.org/728690 | 19:34 |
| mordred | corvus: ^^ that is a related idea I had the other day | 19:34 |
| corvus | mordred: interesting -- a side effect is we lose the [accidental] testing of install-js-tools.sh. it may be worth the slight inefficiency to keep that, or maybe we don't care and losing it is okay? maybe we should encourage js builds with docker instead? | 19:37 |
| openstackgerrit | Clark Boylan proposed zuul/zuul-jobs master: Add option to prefer https/ssl in configure-mirrors https://review.opendev.org/729407 | 19:43 |
| *** hasharAway has quit IRC | 19:51 | |
| clarkb | mordred: I +2'd the change but didn't approve it as another less important suggestion came to mind. You may just want to do that in a followup. Basically the value in multitenant designators and that is to indicate to the zuul dev what we expect those artificats to test | 19:53 |
| clarkb | I think we actually won't both pieces of info there, the backend zuul service as well as the "what is this testing for us" clue | 19:53 |
| *** mgoddard has quit IRC | 19:59 | |
| mordred | corvus: I'm leaning towards encouraging js builds with docker instead. we could even make a package entry that you could use to do that hostside | 20:02 |
| mordred | in fact, let me update that patch to do something along those lines as an example | 20:02 |
| corvus | neat, updating host-vars doesn't trigger the run-job-on-self-update path | 20:09 |
| corvus | https://review.opendev.org/729619 did not run the jobs that it updated | 20:09 |
| corvus | i've reproduced in a test | 20:10 |
| openstackgerrit | James E. Blair proposed zuul/zuul master: Include extra, host, and group variables in job serialization https://review.opendev.org/729753 | 20:15 |
| corvus | easy fix; i'm not sure it's worth a test (it could get exhaustive) | 20:15 |
| *** jamesmcarthur has quit IRC | 20:19 | |
| *** jamesmcarthur has joined #zuul | 20:19 | |
| *** rlandy is now known as rlandy|biab | 20:32 | |
| *** mgoddard has joined #zuul | 20:34 | |
| *** hashar has joined #zuul | 20:37 | |
| *** tumble has quit IRC | 20:44 | |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: add simple test runner https://review.opendev.org/728684 | 20:49 |
| *** rlandy|biab is now known as rlandy | 20:59 | |
| *** sgw has quit IRC | 21:00 | |
| *** rfolco|rover is now known as rfolco|rover|off | 21:04 | |
| *** jamesmcarthur has quit IRC | 21:12 | |
| *** jamesmcarthur has joined #zuul | 21:12 | |
| *** jamesmcarthur has quit IRC | 21:15 | |
| *** jamesmcarthur has joined #zuul | 21:15 | |
| *** cdearborn has quit IRC | 21:21 | |
| openstackgerrit | Lida Liu proposed zuul/zuul master: WIP: Add commit id to Change for mqtt reporter https://review.opendev.org/722478 | 21:25 |
| openstackgerrit | James E. Blair proposed zuul/zuul master: Include extra, host, and group variables in job serialization https://review.opendev.org/729753 | 21:26 |
| *** jamesmcarthur has quit IRC | 21:32 | |
| *** jamesmcarthur has joined #zuul | 21:33 | |
| *** jamesmcarthur has quit IRC | 21:35 | |
| mordred | corvus: javascript build is broken due to an update to a dependency of a depdendency to a depedency | 21:37 |
| mordred | corvus: which has broken the create-react-app test runner which has had a PR landed for but not yet released | 21:38 |
| mordred | I'm trying to figure out a reasonable workaround | 21:38 |
| mordred | but until I find one, dashboard will be red | 21:38 |
| corvus | mordred: aren't all the deps locked? | 21:39 |
| openstackgerrit | Clark Boylan proposed zuul/zuul-jobs master: Add option to prefer https/ssl in configure-mirrors https://review.opendev.org/729407 | 21:40 |
| *** jamesmcarthur has joined #zuul | 21:42 | |
| mordred | corvus: well - yes - but each of the patches in flight updated something which caused the more flexible deps to get a "safe" new version | 21:42 |
| mordred | corvus: (I'm trying to figure out the right cantrip to lock the right things better) | 21:42 |
| corvus | mordred: i guess i'm still missing how, if we run the test in gate with all the versions explicitly specified, something could be broken | 21:43 |
| mordred | corvus: this broke in between check and gate for each of the js patches that got approved today | 21:43 |
| mordred | corvus: or - hang on | 21:44 |
| mordred | corvus: that's a good point - let me figure out what's going on | 21:44 |
| mordred | corvus: yeah - 2 different things broke in 2 different patches. \o/ | 21:45 |
| corvus | mordred: okay, but it's kind of zuul's value proposition that gating is supposed to prevent this :( | 21:46 |
| mordred | corvus: yup. couldn't agree more | 21:47 |
| corvus | mordred: where is this failure observable? | 21:47 |
| mordred | corvus: https://review.opendev.org/#/c/722653/ and https://review.opendev.org/#/c/716305/ - 722653 is the one that changed between check and gate - but is _not_ the dependency issue I was just looking at. 716305 is failing in check with a shiny new error that wasn't there before which _is_ the dependency issue | 21:48 |
| mordred | corvus: so - I was incorrectly conflating the two issues before | 21:48 |
| openstackgerrit | James E. Blair proposed zuul/zuul master: DNM: run a dashboard build https://review.opendev.org/729769 | 21:48 |
| corvus | mordred: okay, so 653 failed as designed | 21:49 |
| mordred | corvus: yes | 21:49 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Update to create-react-app 3.4.1 https://review.opendev.org/716305 | 21:50 |
| mordred | corvus: and that ^^ should fix the dependency issue - and was caught as designed | 21:50 |
| mordred | I'll now figure out why 653 failed | 21:50 |
| corvus | mordred: and we haven't merged any js-related changes between 17:10 and 19:57 (when nodejs-run-test) changed to red, so it's not something that changed in the zuul tree | 21:51 |
| mordred | yeah | 21:51 |
| corvus | mordred: could the yarn.lock file not be exhaustive? | 21:51 |
| corvus | mordred: or perhaps someone overwrote a published dependency artifact? | 21:51 |
| mordred | either one of those could be true | 21:51 |
| corvus | okay, at least we're back in the realm of expected gating behavior :) | 21:52 |
| * mordred trying locally | 21:52 | |
| mordred | yeah | 21:52 |
| mordred | corvus: it worked locally - I might chalk this one up to gremlins | 21:52 |
| openstackgerrit | Clark Boylan proposed zuul/zuul-jobs master: Add option to prefer https/ssl in configure-mirrors https://review.opendev.org/729407 | 21:52 |
| openstackgerrit | Clark Boylan proposed zuul/zuul-jobs master: Add option to prefer https/ssl in configure-mirrors https://review.opendev.org/729407 | 21:59 |
| *** sgw has joined #zuul | 21:59 | |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Add new timezone selector in web interface https://review.opendev.org/722653 | 22:04 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Add descriptions to the different dashboard jobs https://review.opendev.org/729773 | 22:04 |
| mordred | clarkb: ^^ I add job descriptions - good point | 22:05 |
| *** Goneri has quit IRC | 22:06 | |
| clarkb | mordred: small thing on that but I +2'd anyway bceause I think the intent gets across | 22:07 |
| *** klindgren has quit IRC | 22:09 | |
| openstackgerrit | Clark Boylan proposed zuul/zuul-jobs master: Add option to prefer https/ssl in configure-mirrors https://review.opendev.org/729407 | 22:20 |
| openstackgerrit | Clark Boylan proposed zuul/zuul-jobs master: Remove failovermethod from fedora dnf repo configs https://review.opendev.org/729774 | 22:20 |
| clarkb | ianw: ^ that second change failed on fedora 31 during the previous patchset. If it fails again I may have you look at it. THe onyl thing I noticed is the failovermethod complaints which the parent change now fixes | 22:21 |
| ianw | yeah i think that's a red-herring, but agree we can get rid of that | 22:21 |
| clarkb | ya I don't expect it to fix anyhting. Just removes an attractive nuisance | 22:21 |
| clarkb | ianw: in the failure on the previous patchset it appears to try and talk to uwaterloo's fedora mirror | 22:23 |
| clarkb | but from what I can tell https is totally valid in dnf | 22:23 |
| clarkb | not sure why it would failover | 22:23 |
| *** jamesmcarthur has quit IRC | 22:29 | |
| *** jamesmcarthur has joined #zuul | 22:30 | |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: WIP: Add tutorial tests https://review.opendev.org/728194 | 22:35 |
| *** hashar has quit IRC | 22:37 | |
| *** jamesmcarthur has quit IRC | 22:52 | |
| *** jamesmcarthur has joined #zuul | 22:53 | |
| openstackgerrit | Oleksandr Kozachenko proposed zuul/zuul-jobs master: Patch CoreDNS corefile https://review.opendev.org/727868 | 22:54 |
| *** jamesmcarthur has quit IRC | 22:56 | |
| *** jamesmcarthur has joined #zuul | 22:56 | |
| *** jamesmcarthur has quit IRC | 23:07 | |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: WIP: Add tutorial tests https://review.opendev.org/728194 | 23:08 |
| *** jamesmcarthur has joined #zuul | 23:14 | |
| *** jamesmcarthur has quit IRC | 23:20 | |
| *** jamesmcarthur has joined #zuul | 23:20 | |
| *** jamesmcarthur has quit IRC | 23:25 | |
| *** tosky has quit IRC | 23:48 | |
| *** threestrands has joined #zuul | 23:49 | |
| *** jamesmcarthur has joined #zuul | 23:59 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!