Friday, 2020-05-22

*** tosky has quit IRC00:01
*** rlandy has quit IRC00:06
*** jamesmcarthur has joined #zuul00:06
openstackgerritGuillaume Chauvel proposed zuul/zuul master: WIP: Add tutorial tests  https://review.opendev.org/72819400:15
*** jamesmcarthur has quit IRC00:33
*** jamesmcarthur has joined #zuul00:33
*** jamesmcarthur has quit IRC00:37
*** Goneri has quit IRC00:42
*** ysandeep|away is now known as ysandeep01:02
*** jamesmcarthur has joined #zuul01:14
openstackgerritGuillaume Chauvel proposed zuul/zuul master: WIP: Add tutorial tests  https://review.opendev.org/72819401:26
*** jamesmcarthur has quit IRC01:27
*** guillaumec has quit IRC01:30
*** swest has quit IRC01:36
*** swest has joined #zuul01:51
*** jamesmcarthur has joined #zuul02:59
*** jamesmcarthur has quit IRC03:15
*** jamesmcarthur has joined #zuul03:15
*** bhavikdbavishi has joined #zuul03:16
*** jamesmcarthur has quit IRC03:20
*** tobberydberg has quit IRC03:25
*** bhavikdbavishi1 has joined #zuul03:27
*** bhavikdbavishi has quit IRC03:29
*** bhavikdbavishi1 is now known as bhavikdbavishi03:29
*** tobberydberg has joined #zuul03:35
*** jamesmcarthur has joined #zuul03:54
*** jamesmcarthur has quit IRC04:01
*** jamesmcarthur has joined #zuul04:01
*** saneax has joined #zuul04:31
*** evrardjp has quit IRC04:33
*** sshnaidm is now known as sshnaidm|off04:33
*** evrardjp has joined #zuul04:33
*** bhavikdbavishi has quit IRC04:45
*** jamesmcarthur_ has joined #zuul05:01
*** jamesmcarthur has quit IRC05:05
*** bhavikdbavishi has joined #zuul05:14
*** bhavikdbavishi has quit IRC05:16
*** bhavikdbavishi has joined #zuul05:17
*** bhavikdbavishi1 has joined #zuul05:26
*** bhavikdbavishi has quit IRC05:28
*** bhavikdbavishi1 is now known as bhavikdbavishi05:28
*** sgw has quit IRC06:01
*** bhavikdbavishi has quit IRC06:42
*** jamesmcarthur_ has quit IRC06:44
*** jamesmcarthur has joined #zuul06:44
*** jamesmcarthur_ has joined #zuul06:45
*** jamesmcarthur has quit IRC06:49
*** jamesmcarthur_ has quit IRC06:50
*** guillaumec has joined #zuul06:55
*** ysandeep is now known as ysandeep|afk07:12
*** jamesmcarthur has joined #zuul07:20
*** ysandeep|afk is now known as ysandeep07:34
*** tosky has joined #zuul07:34
*** jamesmcarthur has quit IRC07:35
*** asaleh_ has joined #zuul07:35
*** jpena|off is now known as jpena07:38
*** bhavikdbavishi has joined #zuul07:41
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul master: WIP: Enable ANSI rendering on stdout/stderr  https://review.opendev.org/71625107:44
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul master: Enable ANSI rendering on stdout/stderr  https://review.opendev.org/71625107:54
*** nils has joined #zuul08:04
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: Bump ansible-lint to 4.3.0  https://review.opendev.org/70267908:04
*** tumble has joined #zuul08:12
*** hashar has joined #zuul08:32
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: revoke-sudo: improve sudo removal  https://review.opendev.org/70306508:44
openstackgerritGuillaume Chauvel proposed zuul/zuul master: WIP: Import user tutorials from Software Factory project blog  https://review.opendev.org/72819309:05
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Add tutorial tests  https://review.opendev.org/72819409:05
*** ysandeep is now known as ysandeep|lunch09:09
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: bindep: Add missing virtualenv and fixed repo install  https://review.opendev.org/69363709:10
zbrdo we have a chaperone for gentoo jobs?09:13
zbri would really want to avoid having to look into anything broken suse or gentoo jobs, dpkg and rpm distros take enough time to tame any way :D09:14
openstackgerritGuillaume Chauvel proposed zuul/nodepool master: Initial change to rename zuul-quick-start to zuul-tutorial-quick-start  https://review.opendev.org/72826209:20
*** jamesmcarthur has joined #zuul09:37
*** bhavikdbavishi has quit IRC09:45
*** jamesmcarthur has quit IRC09:46
*** ysandeep|lunch is now known as ysandeep10:01
*** bhavikdbavishi has joined #zuul10:03
*** hashar has quit IRC10:31
*** zenkuro has joined #zuul10:37
zenkurohi if I want to add another place to put on logos I have add secret encrypted with specific project name, but what If I want to add another base job. What project should I spacify within tool/encrypt_secret.py?10:40
*** zenkuro has quit IRC10:45
*** bhavikdbavishi has quit IRC10:50
*** guillaumec has quit IRC11:00
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: add simple test runner  https://review.opendev.org/72868411:26
*** jpena is now known as jpena|lunch11:30
AJaegeravass: what do you think of https://review.opendev.org/730306 ?11:43
avassAJaeger: I'm confused to why we need to specify venv? is that wanted there?12:00
avassAJaeger: what does tox -e venv do? run the default tox envlist in a venv instead of virtualenv?12:01
AJaegeravass: I was helping you with https://review.opendev.org/#/c/726830 - but the horizon change is not needed12:02
avassAJaeger: yeah, but I don't think I understand why -e venv is needed in the first place :)12:03
AJaegeravass: it's not needed in that change. In the past we build docs this way "tox -e venv -- python setup.py build_sphinx"12:04
avassAJaeger: ah so it's just a way to run a python script in a venv12:06
AJaegeravass: that's what we did in the past - but all of that was Jenkins time, so should be gone. I think we can move forward with 72683012:07
avassAJaeger: nice! thanks :)12:08
fungiand it wasn't any sort of built-in tox magic, we literally defined a [testenv:venv] in every project which just did command={posargs}12:09
fungiso no different from any other tox testenv really, there was nothing particularly special about it12:09
avassgot it, that's what confused me12:11
avassAJaeger: so all we need to do for 726830 is to get software factory working12:13
AJaegeravass: yep, just rechecked12:14
AJaegeravass: and decide whether we need an announcement email. corvus, do we need one?12:14
avassAJaeger: I think the problem is that they don't set a default envlist in their tox.ini12:14
AJaegeravass: let's ask tristanC ^^12:16
*** rlandy has joined #zuul12:17
tristanCAJaeger: avass: what is the issue?12:21
AJaegertristanC: check 726830 - why is Software Factory CI failing with that change? avass had one suggestion...12:22
tristanCit fails because `tox: error: argument -e: expected one argument` : https://softwarefactory-project.io/logs/30/726830/8/third-party-check/test-job-tox-el7/26f7267/ara-report/12:23
avasstristanC: yeah, since we no longer default to tox_envlist: venv12:23
avass(with that change)12:23
tristanCand i guess that is failing because we use the `tox` job, not one of the `tox-*`12:24
avassyeah, adding envlist = venv in tox.ini should produce the same behaviour12:26
avasstristanC: so adding a couple of line to this: https://softwarefactory-project.io/logs/30/726830/8/third-party-check/test-job-tox-el7/26f7267/ara-report/ :)12:27
tristanCavass: we can do that, but what about projects which do not have that setting in their tox.ini, is this a new requirement?12:27
avasstristanC: yes, I believe AJaeger could't find any projects that uses venv in opendev at least, but we might want to do an announcement for the change12:29
avassjust to be sure12:29
avasstristanC: the idea is that the tox role should work the same as running 'tox' on the commandline12:30
tristanCavass: then why not removing the `-e` argument?12:31
*** jpena|lunch is now known as jpena12:32
avasstristanC: hmm, I guess we could do that but we need to expand the envlist for tox_siblings12:34
avasstristanC: but that sets a different internal variable so we could handle that12:34
*** hashar has joined #zuul12:36
tristanCavass: as you prefer, i'd be happy to add the new tox.ini option, `Software Factory CI` ci job config is: https://softwarefactory-project.io/cgit/third-party-ci-jobs/tree/playbooks/fake-tox.yaml#n912:37
avasstristanC: just noticed that's a case I missed, if envlist isn't set it has the same behaviour as ALL12:39
avasstristanC: so let's not change software factory ci, I'll fix that instead12:39
tristanCavass: nice, thank you!12:40
*** rlandy is now known as rlandy|mtg12:50
*** bhavikdbavishi has joined #zuul12:50
*** rfolco|rover is now known as rfolco|rover|bbl12:52
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: Minor documentation rephrase  https://review.opendev.org/72864012:52
*** guillaumec has joined #zuul12:53
*** bhavikdbavishi1 has joined #zuul12:58
*** bhavikdbavishi has quit IRC13:00
*** bhavikdbavishi1 is now known as bhavikdbavishi13:00
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Undefined envlist should behave like tox -e ALL  https://review.opendev.org/73032213:12
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Undefined envlist should behave like tox -e ALL  https://review.opendev.org/73032213:17
avassAJaeger, tristanC: that's ^ probably what I've should have done from the beginning13:17
*** rlandy|mtg is now known as rlandy13:19
*** guillaumec has quit IRC13:20
*** cdearborn has joined #zuul13:24
*** cdearborn has left #zuul13:26
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Undefined envlist should behave like tox -e ALL  https://review.opendev.org/73032213:27
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv  https://review.opendev.org/72683013:28
avasstristanC: that should give us the behaviour we want13:28
*** bhavikdbavishi has quit IRC13:34
*** bhavikdbavishi has joined #zuul13:34
mordredavass: nice13:35
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Undefined envlist should behave like tox -e ALL  https://review.opendev.org/73032213:36
openstackgerritMonty Taylor proposed zuul/zuul master: Update create-react-scripts to 3.4.2  https://review.opendev.org/72995413:36
*** Goneri has joined #zuul13:39
*** bhavikdbavishi has quit IRC13:39
*** guillaumec has joined #zuul13:39
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Undefined envlist should behave like tox -e ALL  https://review.opendev.org/73032213:43
*** jamesmcarthur has joined #zuul13:43
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv  https://review.opendev.org/72683013:44
avassAJaeger: oh, fetch-tox-output is probably broken if envdir is set to something else then13:45
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: Revert "Add Gentoo integration tests"  https://review.opendev.org/73032913:47
*** jamesmcarthur has quit IRC13:49
*** rlandy is now known as rlandy|mtg13:55
*** zenkuro has joined #zuul13:57
zenkurohi if I want to add another place to put on logos I have add secret encrypted with specific project name, but what If I want to add another base job. What project should I spacify within tool/encrypt_secret.py?13:57
mordredzenkuro: you always want to use encrypt_secret for the project where the secret is going13:59
mordredzenkuro: secrets are only accessible by playbooks in the project where they are defined - so if you put a secret in a base job (encrypted to the project where the base job is) - then only the base job will have access to those secrets. (the base job can use them to do things so that child jobs can have the benefit of the secret having been used without the child job needing to acess the secret)14:00
*** nhicher has quit IRC14:03
zenkuromordred: yes. regsrdless your last statment. what pub key should I use for making universal base job?14:05
zenkuroor Im missing something14:05
mordredzenkuro: you should use the key of the project the base job is defined in14:06
mordredor - wait - let me ask a question to make sure I understand14:06
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: tox: empty envlist should behave like tox -e ALL  https://review.opendev.org/73032214:06
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv  https://review.opendev.org/72683014:06
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: fetch-tox-output: empty envlist should behave like tox -e ALL  https://review.opendev.org/73033414:06
mordredzenkuro: you want to make a base job that uses a secret to define something? or you want to make a base job that does something but you expect it to need a secret that would be different per-project using it?14:07
zenkuromordred: I want base job to push logs on different ftp server for every its child job14:09
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul master: Make task errors expandable  https://review.opendev.org/72353414:10
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul master: Make task errors expandable  https://review.opendev.org/72353414:10
avasszenkuro: is the child job in an untrusted project?14:12
mordredzenkuro: ok. so this is possible, but I think it might get slightly annoying for you14:12
avasszenkuro: or in a different project14:12
zenkuroit is untrusted priject14:13
zenkuroand I do not want to add anothere key for every new project14:13
mordredzenkuro: what you want is the base job with the ftp publishing roles but without a secret. then, in each project you will want a child job of that base job that defines a secret with the ftp credentials, with the secret encrypted for that project, and the job sets pass-to-parent on the ftp credentials secret: https://zuul-ci.org/docs/zuul/reference/config.html#attr-job.secrets.pass-to-parent14:13
avassmordred, zenkuro: it wouldn't be possible to upload logs in a pre-review pipeline that way14:14
mordredavass: yeah14:14
avasszenkuro: if it's okay for the different projects to have access to eachothers logservers you could define a dictionary of credentials in the base job and let the child job choose which one to upload to by setting a variable14:16
mordredOH14:16
mordredwait14:16
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul master: Make task errors expandable  https://review.opendev.org/72353414:16
mordredI think I might understand the issue14:16
*** nhicher has joined #zuul14:16
mordredzenkuro: is the problem that you want different log locations per-project - but the add-fileserver role is designed to put the base path into the secret?14:17
mordred(I'm certain there is a solution to do what you want to do - but we might just need to learn a little more about the details of what you need here)14:18
zenkuronope, in general I have main zuul server with logs and Im bulding ci for openstack and I need to share some of the logs to public server14:21
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: tox: empty envlist should behave like tox -e ALL  https://review.opendev.org/73032214:24
*** y2kenny has joined #zuul14:27
y2kennyIs there a way to configure a playbook such that the executor will ignore host key checking when connecting to the nodes?14:28
corvusy2kenny: i don't think so; instead we try to get the host keys correctly supplied to the executor from nodepool14:29
y2kennycorvus: this is the case where the job pre-step is doing majority of the node preparation.14:30
y2kennyit's actually not the baremetal use case yet but I will probably run into the same problem when I get to that one.14:31
y2kennyfor now, I am actually launching VMs on kubernetes using kubevirt14:31
corvusy2kenny: with nodepool's static driver, you can specify the host keys for the bare metal nodes14:31
corvusy2kenny: so you're getting a k8s namespace from nodepool, and creating vms in that?14:32
y2kennyyes14:32
corvusy2kenny: i have 2 thoughts: 1) maybe we should look into a new nodepool driver for that use case :)14:32
y2kennysigh...14:32
*** nhicher has quit IRC14:32
y2kennyI guess I have two nodepool driver to write...14:32
*** rlandy|mtg is now known as rlandy14:32
corvusy2kenny: well, i was just thinking it might be useful for other folks, it sounds neat14:33
corvusy2kenny: but wait i have more14:33
corvusy2kenny: 2) the known_hosts file is writeable in the work dir, so if you can get the host keys in your prep step, you can write them to .ssh/known_hosts in the zuul work dir14:33
y2kennycorvus: I want to write them... it's the corporate open source policy/paper work that cause me headache.14:34
avasscorvus, y2kenny: can't you modify the inventory at runtime? if so you could add a ansible_extra_ssh_args: -o StrictHostKeyChecking=no as a temporary solution14:34
y2kennycorvus: Oh... like a direct file write?  I haven't tried that one.  I tried using the known_host ansible module but it failed on something.14:35
avassbut I like corvus solution more :)14:35
y2kennyavass, corvus: ansible_extra_ssh_args is prohibited for Zuul's add_host (that solution I tried)14:35
corvusit's worth at least trying to keep host validation working :)14:35
y2kennyI also tried setting a var for the play (ansible_host_key_check=false) that one seems to be a long standing ansible bug that hasn't been fixed14:36
corvusavass's solution may work if you can do that in a trusted execution context (ie, config-project playbook).14:36
corvusbut yeah, the known_hosts file is intended to be writeable, so that seems the most straightforward way14:37
openstackgerritMerged zuul/zuul master: Update to create-react-app 3.4.1  https://review.opendev.org/71630514:37
y2kennycorvus: Oh... I forgot about that.  Yes, eventually the role/job will be in a trusted context.  I was just doing things in untrusted environment right now to leverge the pre-submit test/iteration.14:38
corvusy2kenny: cool.  i suggest trying the known_hosts thing first -- it's less dodgy.  and if it doesn't work or you need the other thing somehow, that should be possible.14:38
y2kennycorvus: and fwiw, I was going to start writing nodepool driver after this task.14:38
*** sgw has joined #zuul14:39
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: fetch-tox-output: empty envlist should behave like tox -e ALL  https://review.opendev.org/73033414:40
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv  https://review.opendev.org/72683014:40
y2kennycorvus: totally unrelated question.  Do you guys have any plans create an entity to do commercial support (or if there's one already that I am not aware of)?  Kind of like how Cloudbee is to Jenkins?14:40
y2kennycorvus: (this is not related to the nodepool drivers thing... I will try to write those.  it's more about pitching and recommending zuul in other contexts.)14:42
*** jamesmcarthur has joined #zuul14:45
*** zenkuro has quit IRC14:46
corvusy2kenny: that's a great question;  vexxhost does provide a commercial saas offering, and i'd love there to be more in that space14:47
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: fetch-tox-output: empty envlist should behave like tox -e ALL  https://review.opendev.org/73033414:53
*** jamesmcarthur has quit IRC15:03
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv  https://review.opendev.org/72683015:04
*** nhicher has joined #zuul15:05
*** jamesmcarthur has joined #zuul15:07
openstackgerritSagi Shnaidman proposed zuul/zuul-jobs master: WIP Add ansible collection roles  https://review.opendev.org/73036015:14
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv  https://review.opendev.org/72683015:19
*** nhicher has quit IRC15:23
avasstristanC: I think https://review.opendev.org/#/c/726830/ is breaking because a bug in tox now15:25
avassI mean, it's failing because it looks like tox itself is broken15:26
*** nhicher has joined #zuul15:28
avasstristanC: I'm able to reproduce that with tox==3.13.2 if envlist isn't set. Anything above that works15:30
tristanCavass: 3.13.2 is the version shipped in fedora3115:31
*** rfolco|rover|bbl is now known as rfolco|rover15:31
avasstristanC: oh :(15:32
avasstristanC: maybe just adding a failed_when: false there is enough?15:32
tristanCavass: i don't think zuul-jobs should silence all failure just because there is a bug in the tox version shipped by fedora3115:35
tristanCavass: in f32 it is tox-3.14.6 , let me see if can add ci for that version instead15:36
tristanCavass: ideally we would 'failed_when: distro != f31' until the bug is fixed15:36
avassoh fedora32 is out, I should probably upgrade :)15:37
*** y2kenny has quit IRC15:38
*** hashar has quit IRC15:40
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv  https://review.opendev.org/72683015:40
tristanChttps://softwarefactory-project.io/r/#/q/topic:f32-tp-ci should adds new -f32 jobs15:42
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: Disable broken gentoo job nv  https://review.opendev.org/72864015:43
avasstristanC: nice15:44
*** nhicher has quit IRC15:46
*** jamesmcarthur has quit IRC15:49
avasstristanC: actually, adding a check for tox version is probably better. I'll see if I can do that15:50
*** nils has quit IRC15:51
*** nhicher has joined #zuul15:54
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul master: Make task errors expandable  https://review.opendev.org/72353415:59
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv  https://review.opendev.org/72683015:59
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv  https://review.opendev.org/72683016:03
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: Make gentoo jobs nv  https://review.opendev.org/72864016:03
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv  https://review.opendev.org/72683016:14
*** nhicher has quit IRC16:15
*** jamesmcarthur has joined #zuul16:17
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv  https://review.opendev.org/72683016:18
*** nhicher has joined #zuul16:19
*** jamesmcarthur has quit IRC16:21
*** bhavikdbavishi has joined #zuul16:21
*** jamesmcarthur has joined #zuul16:21
*** jamesmcarthur has quit IRC16:21
*** jamesmcarthur has joined #zuul16:21
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv  https://review.opendev.org/72683016:31
*** jamesmcarthur has quit IRC16:34
*** jamesmcarthur has joined #zuul16:35
*** jamesmcarthur has quit IRC16:39
*** jamesmcarthur has joined #zuul16:39
zbrtristanC: avass: maybe is time to allow tox to be upgraded via https://review.opendev.org/#/c/690057/16:43
*** jpena is now known as jpena|off16:43
tristanCzbr: this is not related, unless we make the upgrade a default, our use-case doesn't involve upgrading tox16:48
zbrit would allow us to do whatever we want, upgrading or not.16:48
zbrsooner or later we would have users requiring a specific tox version16:49
zbrits ability to bootstrap itself is cool, but it would still not be enough if the pre-installed version is buggy16:50
tristanCzbr: i agree this is good to have, but what we are testing here is that you a python project can be tested by the tox provided by the distro, thus we explicitely do not want to upgrade tox using pip16:51
zbrtristanC: good luck with that, centos-8 does not have any tox and the one from centos-7 is unusable-old.16:51
tristanCzbr: we are already using the fedora and centos tox package successfully16:53
avasstristanC: that ^ works and I just added a comment to explain why we set the failed_when the way we do16:53
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv  https://review.opendev.org/72683016:53
avassoh, that ^ :)16:53
*** ysandeep is now known as ysandeep|away16:54
tristanCzbr: and if zuul-jobs can't support fedora or centos pacakge, then that's ok and we will remove the third party ci16:54
zbri do no see reasons why it would not be able to, it should definitely support them16:55
avassactually, let me break that into it's own change since that should be separate from deprecating tox_envlist: venv16:56
tristanCzbr: well if the old version prevent using more recent feature, then i think that's fair to stop supporting them from zuul-jobs16:56
zbrtbh, i am glad to see venv default being removed, the default should be empty, and should just run "tox".16:57
tristanCbut thanks to avass work so far, it seems like it is possible to keep the support16:57
zbri wonder when -l was added and if it did change over time.16:58
tristanCavass: btw, f32 variant are now in place16:58
avasstristanC: nice!16:59
*** bhavikdbavishi has quit IRC17:18
*** bhavikdbavishi has joined #zuul17:33
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv  https://review.opendev.org/72683017:33
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: tox: envlist bugfixes  https://review.opendev.org/73038117:33
avasszbr: why does 690057 loop over the tox_requirements?17:45
avasszbr: oh, it has to be a list and can't be packages separated by a space?17:46
zbravass: yep17:47
zbrmainly to allow installing tox plugins17:47
avasszbr: but shouldn't .split() be enough to produce a list then?17:47
zbrsimilar to "pip install tox tox-pyenv>12"17:48
zbrno, not enough17:48
zbrwe need to remove the quotes, in case user added them when doing a copy/paste from bash17:48
zbrpip module does not expects or allow quotes, but allows conditions.17:49
*** nhicher has quit IRC17:49
*** tosky has quit IRC17:50
*** tosky has joined #zuul17:51
avasszbr: left a comment, I think the rest of the change looks good otherwise17:54
openstackgerritLida Liu proposed zuul/zuul master: WIP: Add commit id to Change for mqtt reporter  https://review.opendev.org/72247818:03
*** nhicher has joined #zuul18:16
mnaserzuul-maint: ensure-kubernetes is still broken and https://review.opendev.org/#/c/727868/9 is the fix.  minikube ack'd it's broken but needs someone to do the fix -- we'll try to drive that but at least for the meantime... https://github.com/kubernetes/minikube/issues/813018:20
mnaser(and it means any service discovery with coredns is broken)18:21
*** nhicher has quit IRC18:24
*** nhicher has joined #zuul18:36
AJaegeravass: is the teox stack ready for review now?18:37
avassAJaeger: I see a minor change, but you can start nitting ;)18:39
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: add simple test runner  https://review.opendev.org/72868418:39
AJaegeravass: sorry, didn't find nits ;)18:40
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: tox: empty envlist should behave like tox -e ALL  https://review.opendev.org/73032218:41
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: fetch-tox-output: empty envlist should behave like tox -e ALL  https://review.opendev.org/73033418:41
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: tox: envlist bugfixes  https://review.opendev.org/73038118:41
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv  https://review.opendev.org/72683018:41
avassAJaeger: too bad that changes the entire stack, but I don't need to add default(omit) to change it to default("default") later on18:41
AJaegercorvus, mordred , if you have time, could you give  avass' tox stack some review love, please? https://review.opendev.org/#/c/730322 the stack looks good to me but this is all tricky so want you to review as well. Do we need to announce the venv change and wait with merging? I have not found any users that we would break, we seem to set venv everywhere (still, the search was tricky, so I might have18:43
AJaegermissed something).18:44
*** bhavikdbavishi has quit IRC18:47
*** jamesmcarthur has quit IRC18:54
*** nhicher has quit IRC18:54
openstackgerritTristan Cacqueray proposed zuul/zuul-operator master: Add zuul-operator-upload-image job  https://review.opendev.org/70886018:58
*** jamesmcarthur has joined #zuul18:59
*** nhicher has joined #zuul19:24
*** nhicher has quit IRC19:28
*** jamesmcarthur has quit IRC19:35
*** jamesmcarthur has joined #zuul19:48
*** jamesmcarthur has quit IRC20:12
*** jamesmcarthur has joined #zuul20:12
openstackgerritTristan Cacqueray proposed zuul/zuul-operator master: Add zuul-operator-upload-image job  https://review.opendev.org/70886020:45
*** jamesmcarthur has quit IRC20:50
*** jamesmcarthur has joined #zuul20:51
*** jamesmcarthur has quit IRC20:56
*** jamesmcarthur has joined #zuul20:56
*** jamesmcarthur has quit IRC21:11
*** jamesmcarthur has joined #zuul21:11
*** tumble has quit IRC21:11
*** jamesmcarthur has quit IRC21:17
*** jamesmcarthur has joined #zuul21:18
*** rfolco|rover has quit IRC21:22
*** rlandy has quit IRC21:42
Open10K8SHi team21:44
Open10K8SCould you merge this PS https://review.opendev.org/#/c/727868/?21:44
Open10K8Srelated to the zuul job for ensure-kubernetes21:44
Open10K8SMaybe you can remeber about this, started when the minikube 1.10.x released21:44
Open10K8Sclarkb: we discussed about this before :)21:44
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: add simple test runner  https://review.opendev.org/72868421:45
*** nhicher has joined #zuul22:10
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: add simple test runner  https://review.opendev.org/72868422:21
*** jamesmcarthur has quit IRC22:50
*** jamesmcarthur has joined #zuul22:51
*** jamesmcarthur has quit IRC22:53
*** jamesmcarthur_ has joined #zuul22:53
*** tosky has quit IRC22:59
tristanCOpen10K8S: mnaser: not sure if you had a reproducer and a depends-on to show that the fix is correct, thus i'm waiting for ci result with https://review.opendev.org/70886023:08
Open10K8SI did this patchset https://review.opendev.org/#/c/729430/ depends on 72868423:10
Open10K8StristanC: I did this patchset https://review.opendev.org/#/c/729430/ depends on 72868423:11
tristanCalright, then i approved the zuul-jobs change23:12
*** nhicher has quit IRC23:12
openstackgerritMerged zuul/zuul-jobs master: Patch CoreDNS corefile  https://review.opendev.org/72786823:24
*** nhicher has joined #zuul23:26
logan-i'm trying to register and pass some variables from a pre-run playbook to a run playbook. is that something I should use zuul_return for?23:43
logan-I found https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/build-container-image/tasks/main.yaml#L1-L15, it looks like that should do it, but I didn't see any documentation about results.json in the zuul_return docs.23:44

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!