| *** alexismonville has quit IRC | 01:53 | |
| *** fay has joined #storyboard | 06:59 | |
| *** fay is now known as faybrocklebank | 06:59 | |
| *** matthewbodkin has joined #storyboard | 07:41 | |
| *** matthewbodkin has quit IRC | 07:41 | |
| *** matthewbodkin has joined #storyboard | 07:41 | |
| *** alexismonville has joined #storyboard | 11:31 | |
| Zara | I made `verify` properly configurable, but that's just in usr/local/lib, so now I get to move it all into git places and hope I do it right. :< | 12:34 |
|---|---|---|
| openstackgerrit | Zara proposed openstack-infra/python-storyboardclient: Give user option to bypass verification https://review.openstack.org/366099 | 12:47 |
| Zara | I thiiiink that's all of it... | 12:47 |
| Zara | haha, with bonus 'me working out how to do things' comments for free | 12:54 |
| openstackgerrit | Zara proposed openstack-infra/python-storyboardclient: Give user option to bypass verification https://review.openstack.org/366099 | 12:55 |
| Zara | it needs tidying up (there's a function that passes verify but there's no indication of that in the name, and it needs documenting in client.py)-- but I'd rather check if the overall approach makes sense | 12:56 |
| Zara | it does also mean that the commandline thing might need to get a bit smarter, since atm it just decides what's been passed based on the order of arguments. | 12:57 |
| pedroalvarez | Zara: reviewed, if you don't understand what I'm talking about in the comments, please, ping me. Brain and language is not working very well after holidays :) | 13:09 |
| Zara | pedroalvarez: it's fine, I think I get it, thanks. :) I did it the long way round! xD | 13:15 |
| Zara | how was the holiday? | 13:20 |
| *** zigo has quit IRC | 14:25 | |
| *** zigo has joined #storyboard | 14:32 | |
| *** zigo is now known as Guest39147 | 14:33 | |
| pedroalvarez | Zara: very good thanks :) | 14:36 |
| *** Guest39147 has quit IRC | 14:39 | |
| *** zigo_ has joined #storyboard | 14:42 | |
| *** zigo_ has quit IRC | 14:47 | |
| *** zigo_ has joined #storyboard | 14:48 | |
| openstackgerrit | Zara proposed openstack-infra/python-storyboardclient: Give user option to bypass verification https://review.openstack.org/366099 | 15:09 |
| openstackgerrit | Matthew Bodkin proposed openstack-infra/storyboard-webclient: Make tags reusable https://review.openstack.org/366188 | 15:09 |
| pedroalvarez | Zara: that looks great. Does is still work? | 15:19 |
| *** zigo_ is now known as zigo | 15:20 | |
| Zara | it did for me, though there's a chance I've missed something (since I tested versions of files in usr/local/lib but sent that from a different repo...) so it's worth checking. | 15:21 |
| pedroalvarez | don't have time for testing it now, but code looks correct | 15:25 |
| pedroalvarez | no idea bout the pep8 issue though | 15:25 |
| Zara | ah, line too long | 15:26 |
| Zara | 2016-09-06 15:15:19.330975 | ./storyboardclient/base.py:34:80: E501 line too long (86 > 79 characters) | 15:26 |
| Zara | 2016-09-06 15:15:19.331063 | self.http_client = BaseHTTPClient(auth_plugin=self.auth_plugin, verify=verify) | 15:26 |
| Zara | suppose I should learn how to do multiline python things | 15:26 |
| pedroalvarez | meh, failed to see that in the log | 15:26 |
| pedroalvarez | that one should be easy | 15:27 |
| Zara | :) sending patch now | 15:28 |
| pedroalvarez | self.http_client = BaseHTTPClient(auth_plugin=self.auth_plugin, | 15:28 |
| pedroalvarez | verify=verify) | 15:28 |
| pedroalvarez | grrreat | 15:28 |
| openstackgerrit | Zara proposed openstack-infra/python-storyboardclient: Give user option to bypass verification https://review.openstack.org/366099 | 15:29 |
| Zara | hah, the first thing I saw suggested the slash | 15:29 |
| Zara | if it's not necessary I can chuck it. | 15:30 |
| pedroalvarez | I believe it's not needed, but my brain is still in holiday mode, mind | 15:32 |
| openstackgerrit | Zara proposed openstack-infra/python-storyboardclient: Give user option to bypass verification https://review.openstack.org/366099 | 15:32 |
| Zara | I tried a few things, indentation should be nicer now too | 15:32 |
| Zara | I can never keep track of the times python doesn't care about whitespace/newlines. | 15:33 |
| Zara | it seems to alternate between 'this is the most important thing' and 'lol I don't care' | 15:34 |
| pedroalvarez | it does care about new lines, but if you put the newline inside '()', everything is fine | 15:34 |
| pedroalvarez | same for '[]' I believe | 15:35 |
| Zara | ah, okay. yeah, I think I've done that with arrays before. | 15:35 |
| Zara | it makes sense, just hard to remember when also switching between python and js. | 15:36 |
| Zara | also I found this at the weekend when I'd forgotten to put something in a loop and was too lazy to do it in vim: http://wittman.org/projects/stackoverflowindentfourspaces/ | 15:38 |
| Zara | bookmarked forever. | 15:39 |
| persia | 34,72 s/^/ / ? | 15:39 |
| * persia thinks typing that (or the equivalent for someone else's favourite editor) is faster than cut+paste and fussing with bookmarks | 15:40 | |
| pedroalvarez | oh, i discovered that in vim you can do: 3>> | 15:40 |
| pedroalvarez | to indent 3 lines, for example | 15:40 |
| pedroalvarez | and assuming that you have configured vim to put 4 spaces instead of tabs, that will work | 15:41 |
| Zara | pedroalvarez: yeah, I looked at it and was like 'I'll have to scroll through all these and subtract to find out how many lines it is; if I'm scrolling I might as well copy as I go and paste it somewhere'. xD | 15:45 |
| Zara | (small batches of a few lines apiece would also work, just runs more risk of confusing me if interrupted) | 15:46 |
| * SotK votes then changes his mind | 15:47 | |
| Zara | (+ I mainly bookmark things so that when I type the first letter of their name (or a word), they come up in my browser, so it's not that different a workflow) | 15:48 |
| persia | Zara: Your editor probably gives you line numbers: if you look at the number at the top, and then again at the bottom (scroll, search, whatever), you can use those without math, like: | 15:51 |
| persia | `:17,21 >>` | 15:51 |
| persia | (put as many '>'s as you need to get the right amount of indent) | 15:51 |
| persia | If your editor is being uncooperative, ^g may help. | 15:52 |
| SotK | TIL about >> in vim | 15:52 |
| Zara | I didn't realise you could use a range for >> when I searched the problem. | 15:53 |
| Zara | gah, meant to add to that docstring, thanks | 15:55 |
| Zara | also double gah I've just noticed that the api url is described as optional and defaults to s.o.o | 15:57 |
| Zara | that seems risky | 15:57 |
| persia | I haven't written elisp for a while, but I believe that in both popular editors, one can apply any command to either a range or a marked area. Some of the results can be odd. | 15:57 |
| pedroalvarez | Zara: that's for another change, but yes, I would change that too | 15:59 |
| Zara | I can quickly add it now :) | 16:02 |
| openstackgerrit | Zara proposed openstack-infra/python-storyboardclient: Give user option to bypass verification https://review.openstack.org/366099 | 16:03 |
| Zara | oh, the s.o.o thing, yeah | 16:04 |
| Zara | agree it should be a separate change | 16:04 |
| openstackgerrit | Matthew Bodkin proposed openstack-infra/storyboard-webclient: Make tags reusable https://review.openstack.org/366188 | 16:09 |
| openstackgerrit | Zara proposed openstack-infra/python-storyboardclient: Make dev the default StoryBoard instance https://review.openstack.org/366238 | 16:10 |
| *** faybrocklebank has quit IRC | 16:14 | |
| Zara | hah, that pep8 is harder to fix... | 16:28 |
| Zara | I guess I'll have to make it a named variable, unless anyone has a better idea | 16:28 |
| *** matthewbodkin has quit IRC | 16:30 | |
| openstackgerrit | Zara proposed openstack-infra/python-storyboardclient: Make dev the default StoryBoard instance https://review.openstack.org/366238 | 16:31 |
| Zara | huh... for browses, storyboard-dev does GET, but js-draft does OPTIONS | 17:29 |
| Zara | (along with GET. it ends up with a 204 no content with the OPTIONS) | 17:30 |
| *** persia_ has quit IRC | 18:01 | |
| *** persia has quit IRC | 18:01 | |
| *** thrace has quit IRC | 18:01 | |
| *** alexismonville has quit IRC | 19:21 | |
| *** persia_ has joined #storyboard | 19:27 | |
| *** persia has joined #storyboard | 19:27 | |
| *** davidlenwell has quit IRC | 19:59 | |
| *** alexismonville has joined #storyboard | 20:10 | |
| *** davidlenwell has joined #storyboard | 20:12 | |
| *** alexismonville has quit IRC | 22:28 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!