*** fay has joined #storyboard | 07:02 | |
*** fay is now known as faybrocklebank | 07:03 | |
*** matthewbodkin has joined #storyboard | 07:49 | |
*** openstackgerrit has quit IRC | 08:18 | |
*** openstackgerrit has joined #storyboard | 08:19 | |
*** openstackgerrit has quit IRC | 09:04 | |
*** openstackgerrit has joined #storyboard | 09:04 | |
*** bethwhite_ has joined #storyboard | 09:08 | |
Zara | mooooorniiiiiiing storyboooooard | 09:32 |
---|---|---|
SotK | morning! | 09:36 |
openstackgerrit | Merged openstack-infra/python-storyboardclient: Add basic docs for python client https://review.openstack.org/362878 | 10:06 |
openstackgerrit | Merged openstack-infra/python-storyboardclient: Add due_dates https://review.openstack.org/345995 | 10:06 |
Zara | ah, now I can add docs to index pg | 10:07 |
pedroalvarez | oh, sidebar moved to the left in small screens | 10:09 |
pedroalvarez | ah, no | 10:10 |
pedroalvarez | not double scroll bars, nice matthewbodkin :) | 10:11 |
matthewbodkin | good :) | 10:11 |
openstackgerrit | Andreas Jaeger proposed openstack-infra/python-storyboardclient: It's 2016 https://review.openstack.org/365558 | 10:20 |
openstackgerrit | Merged openstack-infra/storyboard: Send notifications to subscribers for worklists https://review.openstack.org/354730 | 10:25 |
openstackgerrit | Merged openstack-infra/python-storyboardclient: It's 2016 https://review.openstack.org/365558 | 10:30 |
*** alexismonville has joined #storyboard | 10:52 | |
*** alexismonville has quit IRC | 10:57 | |
*** matthewbodkin has quit IRC | 11:30 | |
openstackgerrit | Merged openstack-infra/storyboard-webclient: Make sidebar submenu the same length as sidebar https://review.openstack.org/355554 | 12:14 |
SotK | Zara: can https://review.openstack.org/#/c/302912/ be abandoned at this point? | 12:17 |
Zara | oh, hah, sure | 12:18 |
Zara | thought it was already abandoned | 12:18 |
*** matthewbodkin has joined #storyboard | 12:27 | |
*** matthewbodkin has quit IRC | 13:02 | |
*** matthewbodkin has joined #storyboard | 13:40 | |
Zara | SotK: what was the exact command that worked for you with storyboard-dev on fri? I want to compare and contrast... | 13:47 |
Zara | huh. http://paste.openstack.org/show/566867/ | 14:01 |
Zara | (I'm printing out 'info' there) | 14:01 |
Zara | so for dev, it's getting a list of every story when I ask to create a new one | 14:02 |
Zara | for my own test instance, it's just getting the story I'm creating. | 14:03 |
Zara | so the error's coming up because the code is calling a method that isn't meant for lists... but it shouldn't be getting that list there to begin with. | 14:03 |
Zara | seems like the baseobject's getting different values for its params. | 14:11 |
Zara | since it's saying there's nothing for self or for manager for dev, but it gets sensible things for my test instance. | 14:13 |
SotK | Zara: iirc something like `storyboard.stories.create(title="test story")` | 14:15 |
SotK | I don't have the actual script to hand atm | 14:15 |
Zara | bah, that's exactly what I'm doing. | 14:15 |
Zara | I suspect there's some difference in my base.py or similar | 14:15 |
Zara | but it's weird that it works for my test instance | 14:16 |
SotK | I'd modified things to allow a `verify` kwarg to be passed to Client, but that should have had the same effect as just changing the default to False | 14:17 |
Zara | yeah, I just changed it to False in mine, and that worked for GETs. | 14:17 |
Zara | for this bit in BaseObject: | 14:18 |
Zara | def __init__(self, manager, info, loaded=False, parent_id=None): | 14:18 |
Zara | I tried printing each param | 14:18 |
Zara | and yeah, self and manager aren't there for dev, and info is different. | 14:19 |
* Zara tries with dodgy token to see what happens | 14:21 | |
Zara | 401 as expected, but no token gives me the same error | 14:22 |
Zara | making me think it's not trying to auth for dev | 14:22 |
SotK | what is the error when you have a good token again? | 14:23 |
Zara | http://paste.openstack.org/show/566872/ | 14:26 |
Zara | I think it's skipping it. | 14:27 |
Zara | so I'm wondering if it interprets verify=False too broadly somehow. | 14:28 |
SotK | try printing out the value of "info" before the loop on line 192 of storyboardclient/base.py to see what its actually trying to iterate over | 14:32 |
Zara | that's what I pasted above, which is why I think it's skipping the auth | 14:33 |
Zara | since it's trying to iterate over a list of all the stories in storyboard-dev | 14:33 |
Zara | which matches what would be found at the public endpoint | 14:34 |
SotK | oh I missed that, sorry | 14:34 |
Zara | np, it was a big paste and not at all obvious unless you were the one doing the pasting xD | 14:34 |
* SotK missed the paste entirely :) | 14:35 | |
Zara | haha | 14:35 |
SotK | if it was skipping the auth then you should get a 401 instead when trying to POST | 14:35 |
Zara | yeah, I get the same error when I just leave out the access token and try to POST, though | 14:36 |
Zara | I only see the 401 when I give it a dodgy token | 14:36 |
Zara | http://paste.openstack.org/show/566875/ | 14:37 |
Zara | so there, I'm not giving it a token when I should be | 14:37 |
Zara | (the rubbishy commandline thing expects a token right after the api url) | 14:38 |
* SotK plays around | 14:38 | |
Zara | I have also checked with scripts in case it was my cli but it seems consistent | 14:38 |
*** alexismonville has joined #storyboard | 14:39 | |
SotK | hmm, I get a 500 error without a token set (which is expected since that part of the api is a bit broken | 14:41 |
SotK | ) | 14:41 |
SotK | same with a bad token | 14:43 |
SotK | which is odd | 14:43 |
SotK | if you see a 401 in that case | 14:44 |
SotK | it works if I set the right token though | 14:47 |
SotK | https://storyboard-dev.openstack.org/?#!/story/37 | 14:47 |
SotK | (from a different machine to the one I was using on Friday) | 14:47 |
Zara | hah, my token just expired for added excitement | 14:51 |
Zara | and seems to have completely vanished, hm. | 14:51 |
Zara | going through all the things in base.py to see if I can narrow it down... my client request seems sensible. | 14:52 |
SotK | its definitely actually making a POST request right? xD | 14:52 |
Zara | looks like! | 14:54 |
Zara | What would you like this lovely python client to do today?storyboard.stories.create(title="cats") | 14:54 |
Zara | <storyboardclient.base.BaseHTTPClient object at 0x7f6d7e3bded0> <storyboardclient.v1.client.Client object at 0x7f6d7e9cf5d0> POST /stories | 14:54 |
Zara | printing out (self, client, method, url) | 14:54 |
Zara | from client_request in base.py | 14:54 |
Zara | token and endpoint also look sensible. | 14:54 |
SotK | how bizarre | 14:54 |
Zara | though hm, in build_url it's reporting the method as 'None' | 14:56 |
Zara | I wonder if I have old code in that bit | 14:56 |
Zara | buuuut that's the same for my test instance, so I don't think it's that. | 14:58 |
SotK | yeah, I don't think that should cause a problem | 15:04 |
* SotK reproduces the issue | 15:05 | |
SotK | try using `https://storyboard-dev.openstack.org/api/v1` as your api_url instead of `http://storyboard-dev.openstack.org/api/v1` :P | 15:06 |
Zara | I was able to create a story: https://storyboard-dev.openstack.org/#!/story/38 | 15:09 |
SotK | \o/ | 15:11 |
openstackgerrit | Zara proposed openstack-infra/python-storyboardclient: Note importance of using https url instead of http https://review.openstack.org/365704 | 15:18 |
Zara | :P | 15:18 |
*** sparkycollier_ has joined #storyboard | 15:47 | |
*** dabukalam_ has joined #storyboard | 15:47 | |
*** sparkycollier has quit IRC | 15:48 | |
*** dabukalam has quit IRC | 15:49 | |
*** tlbr has quit IRC | 15:49 | |
*** fungi has quit IRC | 15:49 | |
*** sparkycollier_ is now known as sparkycollier | 15:49 | |
*** fungi has joined #storyboard | 15:51 | |
*** tlbr has joined #storyboard | 15:51 | |
*** ttx has quit IRC | 16:29 | |
*** ttx has joined #storyboard | 16:29 | |
*** matthewbodkin has quit IRC | 17:01 | |
*** faybrocklebank has quit IRC | 17:03 | |
*** openstackgerrit has quit IRC | 18:03 | |
*** openstackgerrit has joined #storyboard | 18:04 | |
*** alexismonville has quit IRC | 19:22 | |
*** sparkycollier has quit IRC | 20:10 | |
*** jtomasek has quit IRC | 20:10 | |
*** jamesmcarthur has quit IRC | 20:10 | |
*** sparkycollier has joined #storyboard | 20:11 | |
*** jamesmcarthur has joined #storyboard | 20:11 | |
*** jtomasek has joined #storyboard | 20:12 | |
*** alexismonville has joined #storyboard | 23:21 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!