| *** jamesmcarthur has joined #storyboard | 00:58 | |
| *** jamesmcarthur has quit IRC | 01:56 | |
| *** jamesmcarthur has joined #storyboard | 02:16 | |
| *** jamesmcarthur has quit IRC | 03:39 | |
| zaro | Zara, anteaya: Ok. gerrit-dev <--> sb-dev integration has been setup. https://review-dev.openstack.org/#/c/5454 | 05:48 |
|---|---|---|
| zaro | a comment is automagically posted to sb-dev on the following events: patchset-created, change-abandoned, change-restored, change-merged, and comment-added. | 05:51 |
| zaro | which correspond to these rules: https://review.openstack.org/#/c/330925/6/modules/openstack_project/manifests/review_dev.pp@144 | 05:55 |
| zaro | pleia2: we don't need gerrit_dev_storyboard_uid so you can remove from heira if you like. thanks for setting up the token. | 05:56 |
| *** alexismonville has joined #storyboard | 06:02 | |
| *** alexismonville has quit IRC | 06:18 | |
| *** alexismonville has joined #storyboard | 06:23 | |
| *** dmsimard1 has joined #storyboard | 06:57 | |
| *** dmsimard has quit IRC | 07:04 | |
| *** fay has joined #storyboard | 07:12 | |
| *** fay is now known as Guest21835 | 07:12 | |
| *** jtomasek has quit IRC | 07:45 | |
| *** jtomasek has joined #storyboard | 07:47 | |
| pedroalvarez | these are great news! :D | 08:09 |
| *** Guest21835 is now known as faybrocklebank | 08:12 | |
| Zara | yayyyyyy! thank you, everyone | 09:11 |
| Zara | I will try it out SOON | 09:22 |
| Zara | ahahaha, I like that example story :) | 09:22 |
| pedroalvarez | I found it sad :( | 09:31 |
| Zara | Khai Do | 09:41 |
| Zara | Abandoned My life does not need fixing | 09:41 |
| Zara | 1:47 AM | 09:41 |
| Zara | Khai Do | 09:41 |
| Zara | 1:55 AM | 09:41 |
| Zara | Restored | 09:41 |
| Zara | ohh wait i do need it fixed | 09:41 |
| Zara | ^ we've all been there | 09:41 |
| Zara | bugsquash starts in a couple of hours | 09:52 |
| * Zara will try to remember to join #openstack-sprint before then | 09:52 | |
| Zara | (well, hour and a bit) | 09:52 |
| Zara | some monstrous colleagues of mine got 'narwhals' stuck in my head yesterday, and now it's there for good. | 09:55 |
| * SotK is slowly discovering that the automatic resolution of things in the worklists/boards api is kinda annoying for things other than the webclient | 10:00 | |
| SotK | I wonder if there should be a "resolved" parameter that we can pass or something | 10:02 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: RFC: Make server-side resolving of worklist fields togglable https://review.openstack.org/332728 | 10:22 |
| SotK | well if anyone wants to see what I meant, ^^ is an implementation of it | 10:24 |
| Zara | thanks, that should be easier for me to follow-- when I get to it. :/ I can't promise to be helpful but I'll still look at it! | 10:26 |
| Zara | hm, I feel Christmassy. | 10:30 |
| Zara | bugsquash starts in 1 minute! | 10:59 |
| Zara | officially. | 10:59 |
| Zara | I hope people can join in whenever they have a free moment over the next 24 hours | 10:59 |
| Zara | me -> #openstack-sprint | 11:00 |
| SotK | ha, previewing edits to the story description in the card details modal is a bit broken | 11:17 |
| Zara | oh? | 11:17 |
| SotK | it shows both your modified version and the original version | 11:18 |
| Zara | \o/ | 11:18 |
| Zara | huh, trying to reproduce now | 11:22 |
| Zara | aha | 11:22 |
| Zara | it's a problem for task cards | 11:22 |
| Zara | but not story cards | 11:22 |
| Zara | afaict | 11:22 |
| Zara | I was very confused at first since it wasn't doing it, but that's because I was looking at a story card | 11:23 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Make `/v1/worklists/:id/filters` resolve criteria https://review.openstack.org/332764 | 11:31 |
| bilaltariq | That looks like a good move. Since the criteria detail is now obtainable from that request, is sending the same data with the Worklist payload still necessary? | 11:34 |
| SotK | probably not, though its sent with the Worklist to allow the webclient to just make one request rather than loading things separately, which means it'll be a bit more work to remove that functionality | 11:36 |
| Zara | I've added a task for the preview description oddness to https://storyboard.openstack.org/#!/story/2000464 | 11:40 |
| Zara | I've also attempted to make a story for the bug pedro found (or 'bug', if you prefer, but I think it's a bug :P). It was hard to phrase. https://storyboard.openstack.org/#!/story/2000656 | 11:44 |
| Zara | anyone who wants to edit it, go forth | 11:45 |
| Zara | also, the kanban ui story reminded me that we used to not have card modals, and now I'm happy | 11:46 |
| *** dmsimard1 has quit IRC | 12:00 | |
| *** dmsimard has joined #storyboard | 12:01 | |
| *** jtomasek_ has joined #storyboard | 12:02 | |
| *** jtomasek_ has quit IRC | 12:19 | |
| Zara | I've learned for the next bugsquash that I should define some roles in advance and decide which I'm filling when, so I don't jump around in a panic. | 12:21 |
| Zara | and to duplicate from #openstack-sprint: | 12:25 |
| Zara | https://review.openstack.org/#/q/status:open+project:openstack-infra/python-storyboardclient,n,z | 12:25 |
| Zara | erm | 12:25 |
| Zara | for newcomers, things in review live: https://review.openstack.org/#/q/status:open+project:openstack-infra/storyboard , https://review.openstack.org/#/q/status:open+project:openstack-infra/storyboard-webclient and https://review.openstack.org/#/q/status:open+project:openstack-infra/python-storyboardclient,n,z | 12:25 |
| Zara | there, that's a bit more useful than just the last line :) | 12:25 |
| * Zara wonders about the possibility of one day having 'tasks in stories matching foo' for worklist filters. | 12:51 | |
| Zara | I'm thinking about, say 'tasks in stories tagged low-hanging-fruit' . atm you can have a worklist of stories tagged that way, or a worklist of tasks that aren't filtered by the story tag. | 12:53 |
| Zara | so that's a bit annoying if you want only active tasks in stories tagged low-hanging-fruit . it's pretty common ime to have stories with a mix of simpler and more complex tasks. | 12:54 |
| Zara | atm you'd work around this by putting smaller tasks in their own stories | 12:54 |
| Zara | tags at the task level might be an option, but I'm not volunteering to do that. | 12:55 |
| Zara | I think it's a tension between goal-based tags ('this is why we're doing this') and descriptive tags ('this is what this thing is') so we'll find it in more places. | 12:56 |
| Zara | so for now I'll just note it. | 12:56 |
| Zara | and thus it is noted. :) | 12:56 |
| bilaltariq | i think the filter system needs a brushup, it's quite inconsistent when it comes to what data can be requested and what is sent | 12:58 |
| bilaltariq | for example, when a worklist is requested, filters and filter criteria are sent | 12:58 |
| bilaltariq | before requesting to worklist/id/filters didnt return criteria | 12:58 |
| bilaltariq | and now criteria is being returned in two places | 12:58 |
| bilaltariq | and the model for the python client doesnt fit in the same | 12:58 |
| bilaltariq | way | 12:59 |
| Zara | yeah, I see sotk's already sent a couple of patches for the filters in the last couple of days; it's good that you're finding all the places it's weird. :) | 13:02 |
| bilaltariq | were you talking about making a java client/api on monday? | 13:03 |
| Zara | ah, that was the gerrit plugin, which is written in java. | 13:03 |
| Zara | https://gerrit.googlesource.com/plugins/its-storyboard/ | 13:04 |
| Zara | currently half-finished. | 13:04 |
| Zara | if you've seen zaro about in the channel, that's the thing he's been helping us out with this week. | 13:05 |
| Zara | so yeah, that should update a storyboard instance from a gerrit intance (and now it does update storyboard-dev from review-dev!) | 13:06 |
| SotK | I didn't realise before today how tied-up with the webclient the worklist and worklist filter api was | 13:10 |
| bilaltariq | np at least it's on the radar now | 13:10 |
| SotK | yeah, thanks :) | 13:10 |
| Zara | yeah, I guess having a variety of clients is a nice way to see if things are modular | 13:14 |
| Zara | bilaltariq: btw, the patch you +1'd depends on this one to merge: https://review.openstack.org/#/c/332210/ , which is still awaiting reviews, if you'd like to take a look when you have a moment. :) | 13:14 |
| bilaltariq | What's the difference between the api and v1 packages | 13:15 |
| bilaltariq | Wouldn't it make more sense for the object models to be shared as a common api between the client and server so that they match | 13:15 |
| bilaltariq | or is that already how it works | 13:15 |
| bilaltariq | the js-integration failed for that commit | 13:18 |
| bilaltariq | test* | 13:18 |
| SotK | yeah, that test doesn't work properly for changes in openstack-infra/storyboard yet (only for openstack-infra/storyboard-webclient) | 13:19 |
| SotK | I don't actually know why the object models aren't shared, I suspect NikitaKonovalov is the only person likely to know the answer for certain | 13:21 |
| bilaltariq | what's the easiest way to contact him | 13:21 |
| Zara | saying his name in this channel has worked in the past. I haven't seen much of him lately, last I heard he was working on Sahara | 13:22 |
| Zara | he is still in this channel | 13:23 |
| Zara | pinged, he's away | 13:24 |
| Zara | maybe we'll see him in a bit | 13:24 |
| SotK | I'd guess at the reason being so that the openstack common apiclient library from oslo-incubator could be used, though that is deprecated | 13:28 |
| Zara | also! guess what day it is today! | 13:32 |
| SotK | I guess the best thing for now is to work around it in the python client (ie. have a manager for `/v1/worklists/:id/filters` so it can be used for creating, updating, and deleting, and just ignore it for get/get_all, same for items), and leave some comments in the code explaining that its working around the lack of api sanity | 13:32 |
| SotK | meeting day! | 13:32 |
| Zara | well that as well | 13:32 |
| SotK | since it'll take longer than the rest of this week to get the API sensible without breaking the webclient | 13:33 |
| SotK | is it a different kind of day too? | 13:35 |
| SotK | oh, is it a year since we started on sb? | 13:35 |
| bilaltariq | it's at this point where you release api breaking changes for storyboard-v2 /s | 13:37 |
| Zara | SotK: yes. | 13:38 |
| Zara | that approach possibly works better when you don't have downstreams consuming master | 13:41 |
| Zara | I think we have to live with incremental improvement for now. | 13:41 |
| SotK | heh, we could add a /api/v2 endpoint that is optionally used, but no time | 13:42 |
| Zara | gah, I forgot to actually merge that worklists patch. | 13:47 |
| openstackgerrit | Merged openstack-infra/storyboard: Fix GET /v1/worklists/:id/filters/:id https://review.openstack.org/332210 | 14:04 |
| zaro | pleia2: i think fungi said we should create a cert for storyboard-dev.o.o and put it in heira so that the puppet module can just retrieve it. would you be able to help with that? | 14:22 |
| bilaltariq | i might've found a way to easily disable verification in the client | 14:23 |
| bilaltariq | need to get another access token to test it | 14:23 |
| fungi | zaro: pleia2: i actually said we can just copy the cert from storyboard-dev into hiera. no need to generate another right now | 14:24 |
| SotK | hm, launchpad login seems to be broken \o/ | 14:28 |
| Zara | \o/ | 14:29 |
| Zara | \o\ | 14:29 |
| Zara | /o/ | 14:29 |
| SotK | and its fixed again | 14:29 |
| Zara | oh okay | 14:29 |
| bilaltariq | How do I find worklists on storyboard-dev | 14:31 |
| SotK | there's no easy way to find worklists on the UI yet, but you can look at https://storyboard-dev.openstack.org/api/v1/worklists | 14:32 |
| bilaltariq | nvm, i was querying the wrong end point >.< | 14:32 |
| bilaltariq | yeah i was missing the v1 bit | 14:32 |
| *** jamesmcarthur has joined #storyboard | 14:36 | |
| bilaltariq | https://review.openstack.org/#/c/332764/ | 14:47 |
| bilaltariq | whenever anyone has time could they review that commit please | 14:51 |
| Zara | got to it at last :) | 14:56 |
| Zara | sb meeting in 3 minutes in #openstack-meeting, I haven't updated the agenda yet | 14:58 |
| Zara | gah I got logged out | 14:58 |
| *** yarkot1 has quit IRC | 15:10 | |
| *** yarkot1 has joined #storyboard | 15:11 | |
| bilaltariq | Is there anyone would review this commit for me: https://review.openstack.org/#/c/332764/ | 15:13 |
| openstackgerrit | Merged openstack-infra/storyboard: Make `/v1/worklists/:id/filters` resolve criteria https://review.openstack.org/332764 | 15:13 |
| bilaltariq | thanks | 15:13 |
| fungi | SotK: Zara: i haven't been following along closely yet, but did your admin access addition for storyboard-dev work out? i made sure the changes merged before i passed out, but didn't get a chance to check that they actually ended up in the server's running configuration | 15:45 |
| Zara | yes, it did! | 15:46 |
| SotK | fungi: I appear to be an admin on there now, thanks! | 15:46 |
| Zara | thank you! :) | 15:46 |
| fungi | okay, cool, and you're welcome. just wanted to make sure you didn't still need more help on that piece | 15:46 |
| Zara | yeah, thank you, sorry, I should've let you know | 15:48 |
| *** cknight has joined #storyboard | 15:59 | |
| *** jamesmcarthur has quit IRC | 16:05 | |
| *** cknight has left #storyboard | 16:10 | |
| *** jamesmcarthur has joined #storyboard | 16:18 | |
| *** jamesmcarthur has quit IRC | 16:36 | |
| *** jamesmcarthur has joined #storyboard | 16:46 | |
| pleia2 | zaro: where is the cert on storyboard-dev that you want in hiera? (and you're not in the sprint channel :)) | 17:10 |
| *** faybrocklebank has quit IRC | 17:14 | |
| Zara | 'night, all! | 17:16 |
| pleia2 | zaro: also, removed uid from hiera (and noted in the review) | 17:16 |
| pleia2 | night Zara :) | 17:16 |
| zaro | pleia2: i have no idea. i don't have access. fungi? | 17:27 |
| fungi | zaro: pleia2: you both have access, as does the entire world | 17:27 |
| fungi | it's being served vt https://storyboard-dev.openstack.org./ | 17:27 |
| fungi | or some series of typing relatively similar to what i said, just with fewer typos | 17:28 |
| fungi | zaro even had an example in a paste earlier this week of retrieving that cert over the web and saving it to a local file before importing it into the jvm trust store | 17:29 |
| zaro | so yeah, i think i mean to just get that cert and put it in heira. command is.. | 17:29 |
| zaro | openssl s_client -connect storyboard-dev.openstack.org:443 < /dev/null | sed -ne '/-BEGIN CERTIFICATE-/,/-END CERTIFICATE-/p' > storyboard-dev.crt | 17:30 |
| fungi | yep, that would be the cert | 17:30 |
| pleia2 | oh ok, just the regular ssl cert from apache | 17:32 |
| fungi | right, the gerrit plugin is contacting https://storyboard-dev.openstack.org/something to get to the api, and since that site uses a self-signed cert we're just informing the jvm for gerrit-dev that it can trust that | 17:34 |
| pleia2 | zaro: ok, gerrit_dev_storyboard_ssl_crt exists in hiera for review-dev now | 17:35 |
| pleia2 | fungi: gotcha | 17:35 |
| *** jamesmcarthur has quit IRC | 17:40 | |
| zaro | pleia2: thanks | 17:46 |
| *** zara_the_lemur__ has joined #storyboard | 17:50 | |
| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Story api https://review.openstack.org/332946 | 17:55 |
| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Story api https://review.openstack.org/332946 | 17:57 |
| *** jamesmcarthur has joined #storyboard | 18:01 | |
| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Story api https://review.openstack.org/332946 | 18:17 |
| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Story api https://review.openstack.org/332946 | 18:33 |
| *** jamesmcarthur has quit IRC | 18:34 | |
| *** jamesmcarthur has joined #storyboard | 18:35 | |
| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Story api https://review.openstack.org/332946 | 19:11 |
| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Story api https://review.openstack.org/332946 | 20:01 |
| *** alexismonville has quit IRC | 20:03 | |
| *** alexismonville has joined #storyboard | 20:05 | |
| openstackgerrit | Doug Hellmann proposed openstack-infra/storyboard: Add example commands for the Story api https://review.openstack.org/332946 | 20:23 |
| *** jamesmcarthur has quit IRC | 20:58 | |
| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Story api https://review.openstack.org/332946 | 21:00 |
| *** jamesmcarthur has joined #storyboard | 21:01 | |
| *** jamesmcarthur has quit IRC | 21:17 | |
| *** jamesmcarthur has joined #storyboard | 21:26 | |
| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Story api https://review.openstack.org/332946 | 21:50 |
| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Story api https://review.openstack.org/332946 | 21:51 |
| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Story api https://review.openstack.org/332946 | 21:54 |
| *** alexismonville has quit IRC | 22:12 | |
| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Story api https://review.openstack.org/332946 | 22:18 |
| *** zara_the_lemur__ has quit IRC | 22:25 | |
| *** jamesmcarthur has quit IRC | 22:44 | |
| *** jamesmcarthur has joined #storyboard | 22:51 | |
| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Story api https://review.openstack.org/332946 | 23:03 |
| openstackgerrit | Anita Kuno proposed openstack-infra/storyboard: Add example commands for the Story api https://review.openstack.org/332946 | 23:05 |
| *** jamesmcarthur has quit IRC | 23:14 | |
| *** jamesmcarthur has joined #storyboard | 23:18 | |
| *** jamesmcarthur has quit IRC | 23:24 | |
| *** jamesmcarthur has joined #storyboard | 23:25 | |
| *** jamesmcarthur has quit IRC | 23:29 | |
| *** jamesmcarthur has joined #storyboard | 23:34 | |
| zaro | pleia2: was wondering if you can now created a long-live token for Openstack Gerrit user (uid 20) on storyboard.o.o and add this to heira? | 23:45 |
| pleia2 | zaro: have you confirmed it's working on -dev? | 23:45 |
| pleia2 | I wanted to wait to confirm, in case I didn't create the token wrong or something | 23:45 |
| pleia2 | er, didn't create it right | 23:45 |
| pleia2 | I want to make sure dev works before doing prod:) | 23:46 |
| zaro | yeah. token works. was able to setup gerrit-dev to post to sb-dev | 23:46 |
| pleia2 | awesome, I'll do that now then | 23:46 |
| zaro | have you seen? https://review-dev.openstack.org/#/c/5454 | 23:47 |
| pleia2 | I only see comments from you | 23:49 |
| zaro | yeah, an update gets POST to the linked story on every update I made to that change. if you update that change a comment will get posted to the story as well. | 23:51 |
| pleia2 | oh, I see | 23:53 |
| pleia2 | all sorted (and committed the change this time ;)) | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!