| *** jamesmcarthur has joined #storyboard | 00:08 | |
| *** jamesmcarthur has quit IRC | 00:23 | |
| *** jamesmcarthur has joined #storyboard | 00:29 | |
| *** jamesmcarthur has quit IRC | 01:05 | |
| *** jamesmcarthur has joined #storyboard | 01:05 | |
| *** jamesmcarthur has quit IRC | 01:10 | |
| anteaya | Zara: SotK so when you get in can you read pleia2's comment on patchset 5: https://review.openstack.org/#/c/330925 and can you create long lived tokens for both Openstack Gerrit (storyboard uid 20) and Openstack Gerrit Dev (storyboard uid 21) users and send the tokens to pleia2, please? | 01:47 |
|---|---|---|
| anteaya | thank you | 01:48 |
| pleia2 | are we going to use them both? | 01:49 |
| anteaya | Zara: SotK if you can't can you give pleia2 the exact api command to run so she can do it herself | 01:49 |
| pleia2 | I think we need to decide which one we're going to use | 01:49 |
| anteaya | pleia2: I didn't know if you were still online or what you wanted here | 01:49 |
| anteaya | okay OpenStack Gerrit | 01:49 |
| anteaya | that is my vote | 01:49 |
| anteaya | I just didn't want to but Zara and SotK in a position where they took zero action | 01:50 |
| anteaya | s/but/put | 01:50 |
| pleia2 | I was thinking we'd use OpenStack Gerrit for storyboard and OpenStack Gerrit Dev for storyboard-dev (otherwise, why do we have them both?) | 01:50 |
| anteaya | and I'm coming in off my phone, the thunderstorm may or may not have taken out my modem | 01:50 |
| anteaya | I don't know | 01:50 |
| anteaya | and what you want is what I asked Zara and SotK to provide for you | 01:51 |
| anteaya | so what do you want Zara and SotK to do when they read the log tomorrow? | 01:51 |
| pleia2 | well I don't want to create a token for both on both servers if we're only using one of them | 01:51 |
| anteaya | well it is up to you then | 01:51 |
| anteaya | what do you want | 01:51 |
| pleia2 | so I think I need: decision about which account to use (probably ask others in -infra?), how long we should make the long-lived tokens last (a year? 30 years?) and the basic API command an admin can run to create the token for these accounts | 01:52 |
| pleia2 | SotK and Zara can help with the last :) | 01:52 |
| pleia2 | once we figure out the other things I'll have the command ready | 01:52 |
| anteaya | okay do you want to put this on tomorrow's infra meeting agenda then? | 01:53 |
| anteaya | then you can get the answers you would like | 01:53 |
| pleia2 | I think I can just ask in channel tomorrow, shouldn't be a big discussion | 01:53 |
| anteaya | okay well let me know when you are happy | 01:54 |
| anteaya | and I'll let you get back to Zara and SotK with what if anything you would like them to do | 01:54 |
| pleia2 | thanks for your help | 01:54 |
| anteaya | welcome | 01:54 |
| anteaya | I may or may not have internets tomorrow | 01:54 |
| anteaya | I don't now | 01:54 |
| pleia2 | more storms? | 01:54 |
| anteaya | coming in off my phone now | 01:55 |
| * pleia2 nods | 01:55 | |
| anteaya | my modem couldn't connect | 01:55 |
| pleia2 | good luck :) | 01:55 |
| anteaya | I just came on to tie up anything loose from today | 01:55 |
| anteaya | hence my aversion to a long discussion on the topic and desire to give a clear request to Zara and SotK if they are expected to provide anything | 01:55 |
| anteaya | pleia2: thanks | 01:55 |
| anteaya | as I dont know to what extent I will be availalbe to discuss tomorrow | 01:56 |
| pleia2 | I appreciate that, thank you | 01:56 |
| anteaya | for me, I don't care as long as something is decided | 01:56 |
| anteaya | if I have a vote it is for one user on both servers, OpenStack Gerrit | 01:56 |
| anteaya | but if you want something else do what makees you happy | 01:57 |
| *** jamesmcarthur has joined #storyboard | 01:59 | |
| *** jamesmcarthur has quit IRC | 02:03 | |
| zaro | pleia2, anteaya: In our other installs we’ve used both, just as you said, OpenStack Gerrit for storyboard and OpenStack Gerrit Dev for storyboard-dev. | 03:47 |
| zaro | I believe we did the same thing for accounts on jenkins. | 03:48 |
| zaro | which will be just fine because we pass seperate accounts in thru review.pp and review_dev.pp | 03:49 |
| pleia2 | zaro: yeah, I think that makes sense | 03:52 |
| zaro | pleia2: i think it’s definately fine to create a decade token for Gerrit Dev account but not sure about Gerrit account though. I think 10 yr is fine there as well but you might want to double check with fungi first :) | 04:08 |
| pleia2 | zaro: ok, let's check with him in the morning :) | 04:08 |
| zaro | pleia2: cool. it’s not clear to me how to create a token with an expiration date using the REST api. it doesn’t even look like the token endpoint supports selecting an expiration date. It might be a parameter of the AccessToken object but the documentation doesn’t provide enough details. Unless you can login with those accounts to create the token | 04:18 |
| zaro | we’ll need Zara or SotK to help us with the REST api. | 04:18 |
| pleia2 | zaro: yeah, I haven't figured it out either, hopefully they can help in the AM too | 04:20 |
| pleia2 | decided it was better to ask them than spend more time trying to figure it out (busy day already, too much to do) | 04:20 |
| *** jtomasek has joined #storyboard | 06:02 | |
| *** alexismonville has joined #storyboard | 06:50 | |
| *** bethwhite has joined #storyboard | 07:13 | |
| SotK | oh wow, our API docs are very bad there | 07:48 |
| betherly | morning! | 07:57 |
| SotK | you need to send a POST request to `https://storyboard-dev.openstack.org/api/v1/users/:id/tokens` with the Authorization header set to `Bearer SOME_VALID_TOKEN` with a body like `{"user_id":10,"expires_in":"604800"}` | 08:05 |
| SotK | oh and, morning betherly :) | 08:15 |
| *** openstackgerrit has quit IRC | 09:18 | |
| *** openstackgerrit has joined #storyboard | 09:18 | |
| Zara | the one day I'm not looking at the channel in the evening! | 09:29 |
| Zara | will catch up on backscroll in a bit, sorry | 09:29 |
| Zara | though skimming showed someone had asked about the patch to make us storyboard admins-- yesterday, mine was still in review | 09:29 |
| * SotK missed the memo about writing such a patch I think | 09:30 | |
| Zara | huh, sorry, I thought you were there at the time but I don't remember | 09:31 |
| Zara | we were talking about creating projects | 09:31 |
| Zara | aha, it was when you were ill last monday | 09:37 |
| Zara | sorry about that | 09:37 |
| Zara | http://eavesdrop.openstack.org/irclogs/%23storyboard/%23storyboard.2016-06-13.log.html#t2016-06-13T15:54:17 (there might be corresponding coversation in #infra) | 09:38 |
| SotK | aha! | 09:41 |
| Zara | SotK: finally finished backscroll... could you update the api docs? I only know how to post a token through the api based on comments you've made on it in the past, so I can't give as much context (though I can just copy that in a pinch and guess stuff from the db schema, just not sure of syntax)... | 10:07 |
| Zara | so, seems there was lot of conversation earlier and the issue of me + SotK being admins on sb is separate to the updating-from-gerrit stuff. but here's where my patch for making me an admin was living, anyway: https://review.openstack.org/#/c/329092/ | 10:08 |
| bilaltariq | Is there a working example of worklists on the storyboard dev that I can test the client with | 10:11 |
| Zara | bilaltariq: sure, there's https://storyboard-dev.openstack.org/#!/worklist/13 -- though you also might like to try creating one, to see how it works | 10:12 |
| Zara | and if it's confusing, heh | 10:12 |
| Zara | ohh, that one's automatic | 10:13 |
| Zara | hm, I wonder if that'll be weird | 10:13 |
| bilaltariq | I'm currently trying to write the object classes for the python client but there are some inconsistencies in the online API spec and the actual client code | 10:13 |
| bilaltariq | for example, all of the classes in v1/ in the python client extend BaseObject which has a created_at and an updated_at field | 10:14 |
| bilaltariq | but on the online spec not all of the objects say they do | 10:14 |
| Zara | not all the objects are covered by the client yet, so it miiight be that | 10:15 |
| Zara | or it might be a bug \o/ | 10:15 |
| bilaltariq | sotk said that they actually send those fields but its just not on the web docs | 10:15 |
| bilaltariq | but since half the stuff on the web docs don't say what fields they really send, i need to take a look at the responses | 10:16 |
| Zara | heh, count it as a documentation bug then :) | 10:19 |
| Zara | there is an autogenerated schema that is moooore up to date than some things, though already a bit old, with no relations noted on it. | 10:23 |
| Zara | http://imgur.com/QhZBKjR | 10:24 |
| Zara | I need automation for making and uploading those. that one's from march 15th, so not perfect, but yeah, should be more complete than some things. | 10:25 |
| Zara | (so yeah, I can see that on the docs for the api, there's no created_at or updated_at listed for events, but they do have those in the db) | 10:27 |
| bilaltariq | so should they be included as a client field? | 10:28 |
| bilaltariq | client fields* | 10:29 |
| bilaltariq | i'll include them | 10:30 |
| SotK | bilaltariq: http://git.openstack.org/cgit/openstack-infra/storyboard/tree/storyboard/api/v1/wmodels.py defines most of the objects we ever send, I think they all inherit from http://git.openstack.org/cgit/openstack-infra/storyboard/tree/storyboard/api/v1/base.py#n21 | 10:31 |
| SotK | I would recommend including them :) | 10:31 |
| openstackgerrit | Zara proposed openstack-infra/python-storyboardclient: Add boards https://review.openstack.org/299445 | 10:32 |
| Zara | finally rebased that | 10:32 |
| SotK | \o/ | 10:33 |
| Zara | I would hope there isn't much difference between the objects sent and the db things... | 10:33 |
| Zara | xD | 10:33 |
| SotK | there mostly isn't | 10:33 |
| * SotK will look at improving the access token docs | 10:34 | |
| Zara | (:) given I always fall back on the db schema because I find it easier to find things that way) | 10:34 |
| SotK | oh, the reason the object model documentation doesn't mention the missing fields is because the autodoc thing in wsme didn't seem to cope well with inheritance | 10:35 |
| Zara | aha | 10:35 |
| SotK | (it didn't pick up the docstrings or actual types in http://git.openstack.org/cgit/openstack-infra/storyboard/tree/storyboard/api/v1/base.py#n21) | 10:36 |
| * Zara idly wonders about the 'strange wsme workarounds' again | 10:36 | |
| Zara | ahhhh | 10:36 |
| Zara | gotcha | 10:36 |
| SotK | so the docs for id, created_at, and updated_at were rendered like this: http://wsme.readthedocs.io/en/0.5b6/api.html#wsme.wsattr | 10:37 |
| Zara | so, a docs bug, but a docs bug that might involve delving into wsme... :/ | 10:37 |
| SotK | yes | 10:39 |
| Zara | okay that example has baffled me | 10:39 |
| Zara | and it's only 11:40! | 10:39 |
| bilaltariq | Also there are two files called base.py which is a little bit confusing | 10:40 |
| Zara | :) | 10:48 |
| bilaltariq | http://i.imgur.com/QhZBKjR.png What does worklists_ibfk_1 and 3 under Worklists refer to | 11:01 |
| bilaltariq | Also, I'm receiving 'users' and 'owners' arrays as well as what is listed under Worklists | 11:02 |
| Zara | ahh, patches for users and owners must have been merged after that diagram was made. :( I should make a new one sometime. where it differs from the files adam linked, the files will be up to date. | 11:04 |
| SotK | worklists_ibfk_3 is a foreign key to the projects table, from before we decided we weren't going to use the "assign a worklist to a project" functionality | 11:05 |
| Zara | I don't know much about the ibfk_1 bit, but googling 'mysql ibfk' gives some stuff | 11:05 |
| Zara | heh | 11:05 |
| SotK | worklists_ibfk_1 doesn't exist in my database, but I expect it was a foreign key to the users table (for creator_id) | 11:05 |
| Zara | ugh I really need to update that, then | 11:06 |
| SotK | we should really have given our foreign keys names in the db migrations... | 11:06 |
| Zara | ~hindsiiiiight~ | 11:06 |
| Zara | I want automation to make a pretty db schema every time the db migrates | 11:06 |
| * Zara puts it in a story.... ;_; | 11:07 | |
| SotK | the users/owners arrays aren't actually in the db | 11:07 |
| Zara | oh, I'll shut up then. | 11:08 |
| Zara | I *know* that db schema is missing some permissions things, so I thought that was part of it | 11:08 |
| Zara | oh well | 11:08 |
| Zara | private stories won't be on there | 11:08 |
| Zara | nor will subscriptions to worklists, as that was merged yesterday xD | 11:09 |
| bilaltariq | I'm getting a users and owners array though | 11:09 |
| bilaltariq | users is empty and owners has the creator_id user in it | 11:09 |
| SotK | users is the result of joining the users, user_permissions, and permissions tables and filtering by a given permission name (something like "edit_worklist_$ID") | 11:09 |
| SotK | yup, that is the default set of users and owners for a worklist | 11:09 |
| bilaltariq | this is so confusing... | 11:10 |
| SotK | (owners is the same, but a different permission name) | 11:10 |
| * Zara makes https://storyboard.openstack.org/#!/story/2000654 | 11:15 | |
| Zara | I am so glad I write copious notes to myself all over my computer. | 11:15 |
| pedroalvarez | oh, I think I found a bug yesterday | 11:17 |
| Zara | oh? | 11:18 |
| pedroalvarez | well, not a bug, but maybe unexpected behaviour | 11:18 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add quick non-permanent filter buttons for timeline events https://review.openstack.org/331748 | 11:19 |
| SotK | pedroalvarez: go on... | 11:19 |
| Zara | pedroalvarez: what is it? | 11:19 |
| Zara | such suspense! | 11:19 |
| pedroalvarez | so, go to a project page: https://storyboard.openstack.org/#!/project/456 | 11:20 |
| pedroalvarez | navigate to the last page (assuming you can only see 10 stories) | 11:20 |
| pedroalvarez | then click "invalid" | 11:20 |
| pedroalvarez | you would expect to see the first page of invaild stories, maybe? | 11:20 |
| Zara | ahahahahah | 11:21 |
| Zara | that's so specific | 11:21 |
| Zara | but yes, 51 to 37 of 37 | 11:21 |
| Zara | I would consider that a bug | 11:21 |
| * SotK has 1 to 10 of 37 | 11:21 | |
| Zara | huh | 11:21 |
| SotK | and 1 to 37 of 37 with 100 per page | 11:22 |
| Zara | ah, right, I had mine set to 10 per page | 11:22 |
| Zara | so navigated to the last page with the arrows | 11:22 |
| Zara | then clicked 'invalid', and I get nothing until I click hte arrows back down to the 37th | 11:22 |
| SotK | aha! | 11:22 |
| SotK | I missed 12:20:30 < pedroalvarez> navigate to the last page (assuming you can only see 10 stories) | 11:22 |
| pedroalvarez | not really a bug, I know | 11:25 |
| Zara | is there a story for it? | 11:45 |
| * Zara makes a manual worklist on storyboard-dev for use with testing things https://storyboard-dev.openstack.org/#!/worklist/14 (actually made it hours ago but forgot it) | 11:46 | |
| Zara | might be useful, might not | 11:46 |
| *** bethwhite has quit IRC | 11:49 | |
| pedroalvarez | there isn't a story, given that it might not be considered a bug. I can create one if you want me to | 11:50 |
| Zara | yeah, I think it's a bug (at least the display of the numbers; '51 to 37 of 37' doesn't seem right in any case) | 11:51 |
| Zara | people might argue over what page the results should go to, but I think it's good to note the current thing confused at least one person, anyway | 11:51 |
| *** bethwhite has joined #storyboard | 12:03 | |
| openstackgerrit | Merged openstack-infra/storyboard: Allow tags to be filtered by name https://review.openstack.org/331027 | 12:53 |
| Zara | bilaltariq: how's it going? does anything make any more sense, or does it just get weirder the more stuff you look at? :) | 12:57 |
| bilaltariq | I've added some some for worklists like items and filters/criterion, i'm just wondering how i can test the client | 12:59 |
| Zara | okay, I'll see if I can dig up example scripts and check some config... | 13:01 |
| bilaltariq | in the OAuthPlugin class, the request method hasn't been implemented | 13:02 |
| Zara | hmmm, the client really doesn't seem to like the self-signed certs | 13:10 |
| Zara | ooh, and also, I seem to be unable to GET a worklist that is publicly available if I don't have a token. how exciting! | 13:12 |
| SotK | oh? :( | 13:13 |
| Zara | oh, actually, it's odder than that | 13:13 |
| Zara | I had the wrong token, so it wasn't letting me do a GET | 13:13 |
| Zara | with no token, it works | 13:13 |
| Zara | with the right token, it works | 13:13 |
| Zara | but the wrong token, no GET for you | 13:13 |
| Zara | that seems odd | 13:13 |
| Zara | anyway... | 13:13 |
| SotK | what do you mean "wrong token"? | 13:13 |
| Zara | hang on, will paste the script | 13:14 |
| Zara | http://paste.openstack.org/show/520936/ | 13:15 |
| Zara | so there, if the access_token is an invalid value | 13:16 |
| Zara | it nopes out | 13:16 |
| Zara | if that field is just omitted, it's fine | 13:16 |
| Zara | and either way, it won't work with storyboard-dev; I get an error about certificates | 13:17 |
| pedroalvarez | there might be a way of ignoring the certificate, or imporing it into your computer to work around that | 13:17 |
| Zara | http://paste.openstack.org/show/520937/ | 13:18 |
| Zara | is the error | 13:18 |
| Zara | I was *going* to say that the way to test worklist criteria is probably to swap out 'worklists' in there for 'worklist_criteria'.... but that means testing with storyboard-dev won't work yet | 13:21 |
| Zara | tbf if it's just GET requests then it's fine to test with storyboard.openstack.org | 13:22 |
| Zara | you just don't want to be doing POSTs or PUTs over there | 13:22 |
| SotK | ah, that 401 is expected behaviour to me | 13:23 |
| SotK | "you attempted to identify yourself and I found you aren't authorized" | 13:24 |
| Zara | yeah, tbf the actual problem is that it errors out as a result of that... which is a problem with the script. | 13:25 |
| pedroalvarez | Zara: do you create a `client` in your example.py program? | 13:26 |
| Zara | pedroalvarez: it uses client.py in here https://git.openstack.org/cgit/openstack-infra/python-storyboardclient/tree/storyboardclient/v1 | 13:27 |
| Zara | (I just put all my test programs in that directory because I am a terrible person) | 13:27 |
| Zara | it does mean that when I change things, I have to update my installed version (in usr/lib, iirc) to run the right thing, so that's a bit silly | 13:28 |
| Zara | really I should configure it to run from the repo some time... | 13:28 |
| pedroalvarez | Zara: right, so I guess you do something like in the "gerrit-to-storyboard" thingie you were developing: `client.Client(api_url="http://0.0.0.0:9000/api/v1", access_token="secret")` | 13:30 |
| pedroalvarez | if you also add `verify=False`, it may work with storyboard-dev | 13:31 |
| Zara | I don't think it knows about 'verify' | 13:33 |
| Zara | going by https://git.openstack.org/cgit/openstack-infra/python-storyboardclient/tree/storyboardclient/v1/client.py | 13:34 |
| pedroalvarez | but that Client class inherits this one: http://git.openstack.org/cgit/openstack-infra/python-storyboardclient/tree/storyboardclient/base.py#n27 | 13:35 |
| pedroalvarez | wait, I was woing to continue, but I guess I'm wrong | 13:35 |
| SotK | it doesn't accept arbitrary keyword args though | 13:36 |
| pedroalvarez | that too | 13:36 |
| Zara | heh, I even tried it before, just in case it inherited something from somewhere *somehow*, and got an 'unexpected keyword arg' error. ;_; | 13:37 |
| SotK | we should add the ability to pass verify to it | 13:37 |
| Zara | yup | 13:38 |
| zaro | SotK: i need a 10 yr token for Openstack Gerrit Dev (storyboard uid 21) user so i can setup review-dev.o.o <--> storyboard-dev.o.o integration | 13:43 |
| zaro | you able to help with that? | 13:44 |
| * SotK has a look | 13:44 | |
| zaro | SotK, Zara : we'll need a token for Openstack Gerrit (storyboard uid 20) but not sure the expiration time for that one yet. pleia2 is going to figure that out for us. | 13:46 |
| Zara | (hm, I tried adding 'verify=True' (and then even 'verify=False') to client.py and then verify=False to my script; it no longer gives an 'unexpected keyword argument' error, but it still gives me the 'certificate verify failed' error. I may just have no idea how to pass verify so that it actually has meaning...) | 13:47 |
| Zara | zaro: okay, thank you :) | 13:47 |
| *** openstackgerrit has quit IRC | 13:48 | |
| Zara | aw it doesn't like us | 13:48 |
| SotK | you need to cause it to be passed through to the HTTPClient that is created http://git.openstack.org/cgit/openstack-infra/python-storyboardclient/tree/storyboardclient/base.py#n34 | 13:48 |
| *** openstackgerrit has joined #storyboard | 13:48 | |
| bilaltariq | I'm confused, why are you using the oauth plugin | 13:51 |
| bilaltariq | http://git.openstack.org/cgit/openstack-infra/python-storyboardclient/tree/storyboardclient/auth/oauth.py#n21 | 13:51 |
| SotK | bilaltariq: I think the original intention was to implement something there which handled authentication with an openid provider in order to be able to use the python client library without having an existing access token | 13:52 |
| SotK | but no-one got round to actually doing that | 13:53 |
| SotK | zaro: I think the easiest way will be for someone who has the ability to log in to storyboard with that account does so and issues a decade long token using the webclient | 13:53 |
| SotK | or for a storyboard-dev admin to run http://paste.openstack.org/show/520942/ | 13:58 |
| fungi | pleia2: zaro: creating a long-lived bearer token for any account on a dev server is fine (even if it's an account we use for other things on a production server elsewhere) | 14:06 |
| fungi | in this case what's being authenticated is access to resources _on_ or controlled by the dev server, so no risk there | 14:06 |
| bilaltariq | wow just spent 30 minutes trying to debug why i couldnt run that python script and it was because i hadn't installed the requirements | 14:10 |
| Zara | hahaha, sounds familiar! :D | 14:11 |
| Zara | please feel free to ask about anything and everything in here :) | 14:12 |
| SotK | `tox -e venv "command-you-want-to-run-here"` :) | 14:12 |
| Zara | (it's tempting to feel embarrassed and go quiet when something isn't working, but asking around saves a lot of time, so it's better if you ask! plus most of us spend 99% of our time with *no* idea what we're doing.) | 14:15 |
| Zara | I think there's an unofficial 2-hour rule (ie: stuck for two hours, ask) but that's the maximum; it's fine to ask before then. | 14:16 |
| bilaltariq | I get "ERROR: venv: could not install deps" but I can run the python files with python now so it's all good | 14:16 |
| bilaltariq | when i run tox | 14:17 |
| bilaltariq | I get "ERROR: venv: could not install deps" but I can run the python files with python now so it's all goodclear | 14:17 |
| bilaltariq | sorry i thought i was typing in the terminal hahah | 14:17 |
| Zara | yay | 14:17 |
| Zara | xD np | 14:17 |
| SotK | :( | 14:17 |
| zaro | SotK so aren't you an admin? if not who is? | 14:17 |
| Zara | neither of us are, yet. the patches to make us admins are over here: https://review.openstack.org/#/c/332072/ and https://review.openstack.org/#/c/329092/ . | 14:18 |
| zaro | Zara: are the infra-core people admins? | 14:19 |
| SotK | zaro: not yet, current admins are defined in https://git.openstack.org/cgit/openstack-infra/system-config/tree/modules/openstack_project/files/storyboard/superusers.yaml | 14:19 |
| zaro | ahh ok, so pleia2, your it. | 14:20 |
| bilaltariq | is the access_token for the python client the one that it sent from /token | 14:22 |
| bilaltariq | because I still seem to be getting 401's | 14:22 |
| zaro | fungi: and what about the token for the account on storyboard.o.o? what's an appropriate expiration date for that one? | 14:23 |
| SotK | bilaltariq: it should be I think, yes | 14:25 |
| SotK | check that it exists and is active on https://storyboard-dev.openstack.org/#!/profile/tokens | 14:25 |
| fungi | zaro: for storyboard.o.o we can probably set a similarly long expiration. oh though i get where you're coming from with using the production gerrit account from review-dev... its credentials actually allow review-dev to access production storyboard.o.o as well... for now i think it's fine, but sometime in the coming months we should create a separate gerrit dev account on lp to use for the dev server | 14:25 |
| fungi | interactions | 14:25 |
| fungi | there's no need for them to be the same, so eventually we should separate them for better security hygiene | 14:26 |
| zaro | fungi: pleia2 says there are two accounts, Openstack Gerrit (storyboard uid 20) and Openstack Gerrit Dev (storyboard uid 21) | 14:27 |
| zaro | we were planning to make review-dev use 21 and review use 20 | 14:28 |
| fungi | zaro: pleia2: oh, i was skimming and missed that. even better if we can use the Openstack Gerrit Dev account on sb-dev and the Openstack Gerrit account on production sb | 14:28 |
| fungi | i agree | 14:28 |
| fungi | that's what i was eventually wanting to see anyway | 14:29 |
| * Zara remembers she was meant to tag some things before the bugsquash | 14:33 | |
| Zara | welp, guess that's my evening | 14:33 |
| SotK | did we end up with a story for pedroalvarez's kind-of-a-bug? that's probably a low-hanging-fruit | 14:34 |
| pedroalvarez | I didn't create it | 14:34 |
| *** jamesmcarthur has joined #storyboard | 14:42 | |
| Zara | oh yeah, this is the story about problems with the autogenerated documentation: https://storyboard.openstack.org/#!/story/298 | 14:52 |
| Zara | so would imagine that's the place to add details about things not being correctly inherited thanks to wsme | 14:52 |
| bilaltariq | Are there any examples of worklists where filters are used? | 15:04 |
| Zara | any 'automatic' worklist. So on storyboard.openstack.org, there's: https://storyboard.openstack.org/#!/worklist/55 | 15:05 |
| Zara | for example | 15:05 |
| bilaltariq | I get 2 error notifications with that last example | 15:06 |
| bilaltariq | 404: GET /api/v1/worklists/55: Worklist 55 not found | 15:06 |
| bilaltariq | and | 15:06 |
| Zara | ohhhh, it must be a super secret one! | 15:06 |
| bilaltariq | Yeah | 15:06 |
| Zara | hang on, I'll find another :) | 15:06 |
| Zara | https://storyboard-dev.openstack.org/#!/worklist/13 is an automatic one on storyboard-dev | 15:06 |
| bilaltariq | /55/permissions not found either | 15:06 |
| Zara | https://storyboard.openstack.org/#!/worklist/76 | 15:07 |
| persia | Not being able to check the permissions for something one cannot see is a feature in my book. | 15:07 |
| Zara | it should behave the same way if there's no worklist there | 15:08 |
| Zara | anyway, worklist 76 should work on storyboard.openstack.org, or worklist 13 on storyboard-dev.openstack.org... | 15:08 |
| bilaltariq | thanks | 15:09 |
| SotK | Zara: it does :) | 15:10 |
| bilaltariq | in the spec, a field with the name 'type' is being sent | 15:19 |
| bilaltariq | for WorklistFilter's | 15:19 |
| bilaltariq | when I do filter.type it confuses it with the langauge construct, is there any way around that? | 15:20 |
| persia | Name the thing in the client something wordier? | 15:22 |
| bilaltariq | does it need to match the field being sent from the server? | 15:22 |
| persia | No, as long as the code has consistent mapping between the names. Having something conceptually similar will confuse users less when they debug things by looking at the JSON. | 15:25 |
| Zara | I wonder if we should change 'type' at some point... that's going to be fun. | 15:26 |
| SotK | hmm, in what way is it being confused? | 15:26 |
| SotK | giving a class an attribute called type shouldn't affect the `type()` builtin | 15:27 |
| bilaltariq | I cant find the exact message but it was an attribute error i think | 15:27 |
| bilaltariq | i'm going to add a few managers for the worklists and try it again | 15:28 |
| Zara | SotK: ah, okay, at a glance I noticed that vim was treating 'type' differently to the other attribute names | 15:29 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Store history of a comment when editing https://review.openstack.org/332208 | 15:32 |
| Zara | (well, I guess this demonstrates the naming can make it more confusing to debug. but probably best just mentioning it to people, unless anyone's passionate about renaming things all over.) | 15:32 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Fix GET /v1/worklists/:id/filters/:id https://review.openstack.org/332210 | 15:33 |
| * SotK disappears for a while | 15:35 | |
| bilaltariq | Ok another thing has popped up | 15:39 |
| Zara | =D | 15:39 |
| bilaltariq | in v1/teams.py of the python client, there is a UserNestedManager and the parent_url_key is "teams" | 15:39 |
| bilaltariq | but Worklists also need a UserNestedManager | 15:40 |
| Zara | oh, okay, cool | 15:41 |
| Zara | yeah, both worklists and boards have the *bare* minimum to be able to do a GET for them, I can easily believe there's stuff missing from both | 15:42 |
| Zara | in the client, that is | 15:42 |
| Zara | well, boards still aren't *in* the client xD | 15:42 |
| bilaltariq | the thing is, there's no constructor for UsersNestedManager so the parent_url_key is just a hardcoded string in it | 15:44 |
| bilaltariq | and it needs to be different for different parent classes | 15:44 |
| bilaltariq | do the managers need to be constructor-less? | 15:44 |
| Zara | honestly, I don't know yet. :) | 15:46 |
| Zara | Nikitakonovalov, can you help? | 15:46 |
| Zara | (I'm about to go off for dinner so I'll look when I get back) | 15:47 |
| *** bethwhite has quit IRC | 15:54 | |
| anteaya | I have no internets | 15:59 |
| pedroalvarez | well, you have IRC | 15:59 |
| anteaya | please please please whoever reads this message, I don't care what the account is called I would just really like to have gerrit/storyboard integration in place for tomorrow on dev servers | 16:00 |
| anteaya | pedroalvarez: my phone | 16:00 |
| anteaya | I'm not going to be coming in on my phone for the day | 16:00 |
| anteaya | if this won't be fixed for sometime I will walk up to the library for the bug sprint tomorrow and thursday | 16:01 |
| pedroalvarez | I hope the right people reads that message :) | 16:03 |
| *** faybrocklebank has quit IRC | 16:04 | |
| -openstackstatus- NOTICE: Gerrit is being restarted now to apply an emergency security-related configuration change | 16:07 | |
| Zara | so am I right in thinking that pleia2 needs to create the long-lived tokens? I'm not totally sure who the right people are and as far as I know I'm not meant to be doing anything for this, but if I do, now's definitely the time to let me know... | 16:28 |
| zaro | Zara: yeah, we waiting on pleia2 or if she’s not around one of the other infra-root people on the list can do as well. | 16:35 |
| Zara | okay. is there anything else anyone needs to do? | 16:36 |
| zaro | she’s probably just not awake yet. | 16:36 |
| zaro | no, not in regards to token thing. hope you get onto the cool list soon | 16:37 |
| Zara | :) hahaha, thanks. yay, timezone differences-- it's nearly 6pm for us! | 16:37 |
| Zara | we'll be around for the next 4 hours anyway, though | 16:38 |
| Zara | (well, right this second, I'm having a sandwich, but after that.) | 16:38 |
| SotK | bilaltariq: what do you need a UsersNestedManager for in worklists ooi? | 16:46 |
| Zara | btw, if you want to paste example code at all, http://paste.openstack.org/ is useful. or try uploading work-in-progress to gerrit, though that's better left 'til tomorrow because it might take a while to sign up for things. | 16:53 |
| zaro | anteaya: i’ll be missing the infra meeting today but rest assured that i can get review-dev <—> storyboard dev integration working pretty quickly once i have the token for the Openstack Gerrit Dev user. | 16:53 |
| Zara | I'm so excited about this | 16:53 |
| zaro | Zara: then you should stake awake for it :) | 16:54 |
| Zara | zaro: heehee, what time is it likely to be? :D | 16:54 |
| zaro | but big day for you tomorrow so i would advice sleeping | 16:55 |
| Zara | (Idk how your timezone and pleia2's match up with mine) | 16:55 |
| Zara | aw, every day is storyboard bugsquash day really | 16:56 |
| zaro | i've gotta head out soonish then won't be online again again until around 1500 UTC | 16:58 |
| *** dmsimard is now known as dmsimard|afk | 16:59 | |
| pleia2 | at a dr appt this morning, will be back for the meeting and can work on the account stuff then | 17:00 |
| Zara | cool. :) I'm asking around about stuff so I don't suddenly discover I was meant to do 6 things, the day after I should've done them. sounds like everything's covered and I can relax. | 17:03 |
| Zara | thanks, everyone | 17:03 |
| zaro | Zara: oops i meant 2200 utc. | 17:10 |
| Zara | heh, I'll be awake then anyway. sleepy, but awake! | 17:12 |
| anteaya | zaro: great thank you | 17:47 |
| anteaya | pleia2: great thank you | 17:47 |
| anteaya | Zara: your storyboard admin patch is caught in the same beaker test global failure all the other patches are caugtht in | 18:13 |
| Zara | gah, shall I recheck? | 18:13 |
| anteaya | nibalizer: is working on creating an infra gem that all other infra modules will call that will pin versions of gems | 18:14 |
| anteaya | recheck is futile | 18:14 |
| nibalizer | yes | 18:14 |
| anteaya | yes? | 18:14 |
| anteaya | recheck will work today? | 18:14 |
| nibalizer | https://review.openstack.org/#/c/331923/ | 18:15 |
| nibalizer | need that | 18:15 |
| nibalizer | then a ton of infra patches | 18:15 |
| nibalizer | then recheck will work | 18:15 |
| Zara | thanks :) | 18:15 |
| anteaya | nibalizer: ah thanks | 18:15 |
| anteaya | Zara: so probably broke until the end of the week | 18:16 |
| Zara | okay | 18:16 |
| anteaya | nibalizer: thank you | 18:16 |
| nibalizer | i mean im gonna try to get it today | 18:16 |
| nibalizer | things take time, it turns out | 18:16 |
| anteaya | Zara: I'll be helping nibalizer and crinkle create the ton of infra patches once that linked patch aboeve is merged | 18:16 |
| anteaya | nibalizer: no? | 18:17 |
| Zara | okay. well the trapped patch isn't urgent for us, anyway :) | 18:17 |
| * anteaya is shocked | 18:17 | |
| anteaya | Zara: indeed | 18:17 |
| anteaya | nibalizer: I'm at the library on public wifi until Thursday due to no internest at home | 18:17 |
| anteaya | nibalizer: ping when you are at the ton 'o pathces stage and I'll write some | 18:17 |
| anteaya | patches too | 18:18 |
| nibalizer | anteaya: https://review.openstack.org/332412 | 18:19 |
| anteaya | nibalizer: your patch removed the two whitespaces before `project:` | 18:23 |
| anteaya | I think you still need those spaces: http://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/jobs/infra.yaml#n328 | 18:23 |
| nibalizer | crap | 18:25 |
| nibalizer | thanks | 18:25 |
| anteaya | frowny face | 18:26 |
| anteaya | and welcome | 18:26 |
| nibalizer | okay fixed | 18:26 |
| anteaya | nibalizer: I left a question on https://review.openstack.org/#/c/331923/3 | 18:31 |
| * pleia2 catches up on backscroll | 18:39 | |
| pleia2 | alright, so I'm still not sure how to create a long-lived token | 18:44 |
| pleia2 | 01:05:03 < SotK> you need to send a POST request to `https://storyboard-dev.openstack.org/api/v1/users/:id/tokens` with the Authorization header set to `Bearer SOME_VALID_TOKEN` with a body like `{"user_id":10,"expires_in":"604800"}` | 18:45 |
| pleia2 | that seems to get close to what I need, so I'll try to make time to figure out the command with this | 18:46 |
| SotK | pleia2: http://paste.openstack.org/show/520942/ | 18:46 |
| pleia2 | SotK: great, thank you | 18:46 |
| pleia2 | and 315360000 is seconds | 18:47 |
| pleia2 | til how many seconds are in 10 years | 18:47 |
| SotK | yw :) | 18:48 |
| * SotK realises that's actually a day less than a full decade, since it doesn't include leap years | 18:48 | |
| pleia2 | hah, that's ok, I think we'll cope | 18:51 |
| Zara | reminds me of the kind of thing I'd lose marks for in highschool maths exam papers. | 18:56 |
| anteaya | they look for things like that | 18:57 |
| anteaya | the leap year set-up | 18:58 |
| Zara | I would also always switch numbers round in at least one answer box. | 18:58 |
| Zara | finish the exam, find the place where it says '27' instead of '72'... | 18:58 |
| pleia2 | zaro: do you know what the storyboard username is re: https://review.openstack.org/#/c/330925/6/manifests/site.pp ? | 18:59 |
| pleia2 | is it the UID number? | 18:59 |
| pleia2 | asked the question inline in the change instead | 19:03 |
| pleia2 | oops, meeting time | 19:04 |
| anteaya | pleia2: zaro is on a field trip with his children for their school right now but will be back later | 19:15 |
| *** dmsimard|afk is now known as dmsimard | 19:15 | |
| pleia2 | anteaya: yeah, that's why I decided to ask in the change instead :) | 19:19 |
| pleia2 | I'll catch up with him ~2200 utc when he gets back | 19:19 |
| anteaya | pleia2: awesome, thanks | 19:20 |
| *** SotK has quit IRC | 19:30 | |
| zaro | pleia2: username should be whatever is used to login to storyboard | 19:30 |
| pleia2 | zaro: we use launchpad to log into storyboard | 19:31 |
| zaro | if you can login with uid tgen that should work. otherwise would need the actual name | 19:31 |
| pleia2 | so there isn't really a username in storyboard, there's a name for the account "OpenStack Gerrit Dev" and the UID | 19:31 |
| pleia2 | we only allow login with launchpad, no usernames | 19:32 |
| pleia2 | the API takes the token, which is what I generated | 19:32 |
| pleia2 | the token-based auth in the API doesn't need a username/uid at all | 19:32 |
| Zara | huh, we've lost SotK | 19:32 |
| *** SotK has joined #storyboard | 19:36 | |
| zaro | plei | 19:42 |
| zaro | pleia2: ohh true. so probably only need the token then. | 19:43 |
| pleia2 | zaro: that's what I'm thinking :) but I wasn't sure how your plugin worked | 19:43 |
| *** alexismonville has quit IRC | 19:55 | |
| *** alexismonville has joined #storyboard | 19:56 | |
| pleia2 | zaro: sent you email | 20:21 |
| pleia2 | going to get some lunch | 20:40 |
| Zara | yay | 20:41 |
| *** alexismonville has quit IRC | 21:37 | |
| *** jamesmca_ has joined #storyboard | 21:44 | |
| *** jamesmcarthur has quit IRC | 21:47 | |
| *** jamesmca_ has quit IRC | 22:00 | |
| Zara | well, I hung around for a bit, but I'm off to bed now. 'night! | 22:46 |
| pleia2 | night Zara | 22:46 |
| Zara | :) | 22:47 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
