| *** openstack has joined #storyboard | 00:09 | |
| *** openstackgerrit has quit IRC | 00:17 | |
| *** openstackgerrit has joined #storyboard | 00:18 | |
| *** thrace_ has joined #storyboard | 00:48 | |
| *** thrace has quit IRC | 00:49 | |
| *** persia has quit IRC | 01:35 | |
| *** persia has joined #storyboard | 01:38 | |
| *** NikitaKonovalov has quit IRC | 02:56 | |
| *** NikitaKonovalov has joined #storyboard | 03:03 | |
| *** thrace_ has quit IRC | 05:40 | |
| *** thrace_ has joined #storyboard | 05:46 | |
| *** jtomasek has joined #storyboard | 05:53 | |
| *** thrace_ has quit IRC | 06:02 | |
| *** thrace_ has joined #storyboard | 06:08 | |
| *** jtomasek has quit IRC | 06:53 | |
| *** mrmartin has joined #storyboard | 07:54 | |
| *** jjardon has quit IRC | 08:35 | |
| *** betherly has quit IRC | 08:36 | |
| *** betherly has joined #storyboard | 08:40 | |
| *** jjardon has joined #storyboard | 08:42 | |
| *** openstackgerrit has quit IRC | 09:30 | |
| *** openstackgerrit_ has joined #storyboard | 09:30 | |
| *** openstackgerrit_ is now known as openstackgerrit | 09:31 | |
| *** openstackgerrit has quit IRC | 09:31 | |
| *** openstackgerrit_ has joined #storyboard | 09:31 | |
| *** openstackgerrit_ is now known as openstackgerrit | 09:32 | |
| *** openstackgerrit has quit IRC | 09:32 | |
| *** openstackgerrit_ has joined #storyboard | 09:33 | |
| *** openstackgerrit_ is now known as openstackgerrit | 09:33 | |
| *** openstackgerrit has quit IRC | 09:33 | |
| *** openstackgerrit_ has joined #storyboard | 09:34 | |
| *** openstackgerrit_ is now known as openstackgerrit | 09:34 | |
| *** jtomasek has joined #storyboard | 10:16 | |
| SotK | good morning storyboard! | 10:41 |
|---|---|---|
| Zara | morning! | 10:42 |
| Zara | how are the boards doing? | 10:42 |
| SotK | I remembered I need to make the function which updates criteria do more than return the worklist it was passed | 10:43 |
| Zara | =D | 10:43 |
| Zara | that sounds like a big chunk of work | 10:44 |
| SotK | mayyyyybe, we'll see | 10:45 |
| Zara | luckily, I guess you're working 'til midnight or whatever it is anyway | 10:45 |
| SotK | :D | 10:46 |
| SotK | not quite midnight :D | 10:46 |
| Zara | don't be so sure | 10:47 |
| * Zara gives charlotte £75 | 10:47 | |
| Zara | I'm going to look at the task links modal today, anyway. maybe if I say that enough times, I'll actually get to it | 10:48 |
| Zara | my concentration has been awful this week, sorry | 10:48 |
| * SotK has had the same problem :) | 11:02 | |
| Zara | o/ | 11:04 |
| Zara | \o | 11:05 |
| * SotK missed this and now feels bad | 11:14 | |
| Zara | ahahaha | 11:14 |
| SotK | \o | 11:15 |
| Zara | o/ | 11:15 |
| SotK | \o/ | 11:15 |
| Zara | \o/ | 11:15 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Fix removing due dates from boards https://review.openstack.org/291121 | 11:39 |
| Zara | double \o/ | 11:41 |
| openstackgerrit | Merged openstack-infra/storyboard: Fix removing due dates from boards https://review.openstack.org/291121 | 12:20 |
| SotK | thanks for the quick reviews! | 13:00 |
| Zara | :) yw | 13:00 |
| Zara | I tried putting $modalInstance in the story detail controller function (basically nabbing things from the card modal) but it didn't like it | 13:02 |
| * SotK wonders what went wrong | 13:03 | |
| Zara | on a separate note, we should split up the story detail controller sometime, but I'm procrastinating from that one | 13:03 |
| Zara | SotK: the story doesn't load and I get "Error: [$injector:unpr] Unknown provider: $modalInstanceProvider <- $modalInstance <- StoryDetailController | 13:04 |
| Zara | in the web console | 13:04 |
| Zara | so might be something missing from the module? | 13:04 |
| Zara | but the story controller also already has a few modal things in there so i'm also wary of duplicating | 13:05 |
| SotK | o.O | 13:05 |
| SotK | can you paste the changes you've made somewhere? | 13:05 |
| SotK | (`git diff src/app/stories/controller/story_detail_controller.js`) | 13:06 |
| Zara | yeah, I'm pretty sure it's just from editing the function, gimme a sec | 13:08 |
| Zara | (that is, putting $modalInstance as a parameter) | 13:08 |
| Zara | there's other wip frankenstein stuff nicked from the card modal here-- but I tried it without and it was the same: http://paste.openstack.org/show/489990/ | 13:09 |
| Zara | so I'd guess it's to do with how $modalInstance in the function is talking to other things in the detail controller for stories, that aren't present in the card detail controller | 13:10 |
| Zara | oh, I also did something weird when testing and the other stuff is even more wrong than it was | 13:11 |
| SotK | aha, I seem to inject `$modal` into the controllers which cause modals to open, and `$modalInstance` into controllers which are used in the modal | 13:11 |
| Zara | ah, in this case I was trying to do it all from the story detail controller | 13:12 |
| Zara | because it wasn't going to be a very elaborate modal | 13:12 |
| Zara | but maybe it's better doing it in a different one | 13:12 |
| SotK | I think the only way to do it is in a different one | 13:13 |
| SotK | certainly the only not-really-confusing-in-6-months-time way :) | 13:13 |
| Zara | xD yeah, I saw some tutorials for the same one, earlier, but they were pretty hacky | 13:13 |
| Zara | I'm up for whatever way is not really confusing right now. | 13:14 |
| Zara | I'd imagine there is no such way | 13:14 |
| * SotK recommends calling $modal.open() in the story detail controller passing it a separate controller (which might only need to be tiny), so we are consistent across StoryBoard | 13:15 | |
| Zara | okay, wfm. | 13:15 |
| Zara | I think I had a draft that did things that way earlier | 13:16 |
| Zara | then got to the poitn where I wasw going to make the controller and got tired or distracted or something | 13:16 |
| Zara | hm, moved to anotehr controller (currently a bare husk that bears a suspicious resemblence to delete controller, now I get "Error: [$injector:unpr] Unknown provider: paramsProvider <- params <- StoryTaskDetailController | 13:25 |
| Zara | oh nvm | 13:27 |
| Zara | I was being silly | 13:27 |
| Zara | hadn't passed it any params, but had effectively copied the delete controller, which was expecting some | 13:27 |
| Zara | I can now open and delete an empty modal by clicking on a word, it's sad that that's progress but I suppose I did some review earlier. | 13:28 |
| Zara | also this keeps coming up in my console and I blame you: "angular-moment: timezone specified but moment.tz() is undefined. Did you forget to include moment-timezone.js?" | 13:29 |
| Zara | DID YOU | 13:29 |
| SotK | I didn't do it on purpose | 13:29 |
| Zara | :P | 13:29 |
| SotK | I guess I must have needed to | 13:29 |
| Zara | the messages are annoying but I trust you. | 13:30 |
| SotK | :D | 13:30 |
| SotK | I'll send a patch to include it at some point | 13:31 |
| Zara | :) I'd ask for a time but I'd have no way of knowing what timezone that applies to. | 13:32 |
| * persia wishes everything could just be UTC | 13:34 | |
| * SotK would like that | 13:35 | |
| *** openstackgerrit has quit IRC | 14:03 | |
| *** openstackgerrit_ has joined #storyboard | 14:03 | |
| *** openstackgerrit_ is now known as openstackgerrit | 14:04 | |
| *** openstackgerrit has quit IRC | 14:04 | |
| *** openstackgerrit_ has joined #storyboard | 14:05 | |
| *** openstackgerrit_ is now known as openstackgerrit | 14:05 | |
| *** openstackgerrit has quit IRC | 14:05 | |
| *** openstackgerrit_ has joined #storyboard | 14:06 | |
| *** openstackgerrit_ is now known as openstackgerrit | 14:06 | |
| *** openstackgerrit has quit IRC | 14:07 | |
| *** openstackgerrit_ has joined #storyboard | 14:07 | |
| *** openstackgerrit_ is now known as openstackgerrit | 14:08 | |
| *** openstackgerrit has quit IRC | 14:08 | |
| *** openstackgerrit_ has joined #storyboard | 14:08 | |
| *** openstackgerrit_ is now known as openstackgerrit | 14:09 | |
| *** openstackgerrit has quit IRC | 14:09 | |
| *** openstackgerrit_ has joined #storyboard | 14:09 | |
| *** openstackgerrit_ is now known as openstackgerrit | 14:10 | |
| *** Guest41345 has joined #storyboard | 14:10 | |
| Zara | argh | 14:11 |
| Zara | I just spent a while trying to work out why my modal wasn't getting the right data | 14:11 |
| Zara | turns out it was | 14:11 |
| Zara | there just wasn't any yet | 14:11 |
| Zara | argh | 14:11 |
| SotK | :D | 14:12 |
| * SotK is familiar with that realisation | 14:12 | |
| Zara | hahaha | 14:12 |
| Zara | that sinking feeling when you're like, "hang on, what if I hardcode task.link as 'cat', juuust to check " | 14:13 |
| SotK | ".... oh" | 14:13 |
| Zara | 'there's a cat on my screen, dammit' | 14:13 |
| Zara | me today: https://www.youtube.com/watch?v=PKg2ZzPKl2M | 14:16 |
| *** b3rnard0_away is now known as b3rnard0 | 14:32 | |
| Zara | rant part 2: when you forget you've hardcoded it to cat, and it keeps overwriting your new value | 14:34 |
| Zara | got a basic task commenting modal working, anyway | 14:38 |
| Zara | it's absolutely horrible at this point | 14:38 |
| *** mrmartin has quit IRC | 15:06 | |
| *** mrmartin has joined #storyboard | 15:16 | |
| *** mrmartin has quit IRC | 15:59 | |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: WIP task notes https://review.openstack.org/291267 | 16:00 |
| *** jtomasek has quit IRC | 16:00 | |
| *** mrmartin has joined #storyboard | 16:02 | |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Update Fontawesome to 4.5.0 https://review.openstack.org/291274 | 16:16 |
| pedroalvarez | Zara: ooi, anything interesting in the new version? | 16:17 |
| Zara | pedroalvarez: more icons | 16:19 |
| Zara | I wanted a 'sticky note' icon to use when attaching notes to tasks | 16:19 |
| Zara | and there wasn't a good one | 16:19 |
| pedroalvarez | that's exactly the reason I expected :) | 16:19 |
| pedroalvarez | moar icons! | 16:20 |
| Zara | \o/ | 16:21 |
| * Zara wants to replace every icon with fa-bed | 16:21 | |
| Zara | oh wow, there's a fa-linux | 16:22 |
| Zara | http://fontawesome.bootstrapcheatsheets.com/ (our current version) | 16:23 |
| Zara | another thing to bear in mind with task notes: it currently updates the events timeline | 16:24 |
| Zara | so if people edit a lot, there will be a lot of noise, and there's not yet a preference for turning those updates off | 16:24 |
| Zara | so we either need to turn notifications for these off premptively, or put stuff in for preferences before we merge | 16:26 |
| Zara | preferences and templates, that is | 16:26 |
| SotK | the "task details changed" preference seems to hide them | 16:28 |
| *** b3rnard0 has left #storyboard | 16:28 | |
| * Zara smacks forehead | 16:29 | |
| Zara | it's still a PUT | 16:29 |
| Zara | gah, I knew that, which is why I nkew it would notify | 16:29 |
| Zara | but forgot that the thing is for all PUTS | 16:29 |
| Zara | though still | 16:29 |
| Zara | that might mean people will get some useless emails | 16:30 |
| * Zara checks | 16:30 | |
| SotK | I think emails when the notes change are useful, to people who want to be emailed about tasks | 16:30 |
| Zara | yeah, what I mean there is that there isn't a template for them | 16:31 |
| Zara | so they might get an email with no info in it | 16:31 |
| SotK | if there isn't a template it should just fail to send the email | 16:31 |
| Zara | no, there's a template for task details changed | 16:32 |
| Zara | buuut there's no bit of that template | 16:32 |
| Zara | unique to comments | 16:32 |
| * SotK sees | 16:32 | |
| Zara | it might still display the change, I'm nooot sure | 16:32 |
| SotK | yeah, might be annoying | 16:32 |
| Zara | been ages since I looked at it | 16:32 |
| Zara | so long, in fact | 16:33 |
| Zara | that I | 16:33 |
| Zara | have lost | 16:33 |
| Zara | the command | 16:33 |
| Zara | to | 16:33 |
| Zara | restart the worker | 16:33 |
| *** mrmartin has quit IRC | 16:34 | |
| * SotK was going to look at what it was but accidentally obliterated the screen session it was running in | 16:34 | |
| Zara | :) it's fine, I went to the docs | 16:35 |
| Zara | ooh, lots of errors | 16:36 |
| Zara | ooookay | 16:36 |
| Zara | so when you start it again after a while | 16:36 |
| Zara | it will send you all the emails | 16:36 |
| Zara | just as a warning | 16:37 |
| Zara | presumably so it doesn't lose them | 16:37 |
| Zara | if it went down for a bit | 16:37 |
| SotK | :D | 16:37 |
| Zara | I currently have 116 emails from storyboard, and counting | 16:37 |
| Zara | 126 | 16:37 |
| SotK | I guess all the messages were stuck in rabbitmq | 16:37 |
| Zara | yes | 16:37 |
| Zara | I guess they were | 16:37 |
| Zara | 144 | 16:38 |
| Zara | our ops team are going to kill me | 16:38 |
| Zara | 165 | 16:38 |
| Zara | 171 | 16:38 |
| Zara | 189 | 16:38 |
| * Zara buries head in hands | 16:39 | |
| Zara | gah, I was hoping it would hit 200 | 16:40 |
| Zara | it's stopped on 199 | 16:41 |
| Zara | about 20 of those were old unread ones, so storyboard just sent me 170 emails | 16:41 |
| Zara | is it likely to do this to everyone when infra set up the config for s.o.o? | 16:42 |
| SotK | nah, its sending them but exim is swallowing them I think | 16:42 |
| Zara | ahh, okay | 16:42 |
| Zara | it's nice that it keeps them, really | 16:42 |
| Zara | though ouch, I stopped running it early feb | 16:43 |
| Zara | so apparently I test enough to generate 170 emails a month | 16:44 |
| Zara | okay, tested task links templates, this is what it'll look like: | 16:47 |
| Zara | http://paste.openstack.org/show/490031/ | 16:47 |
| Zara | so not really much worse than the others. though I wish I'd just called 'link' 'notes' all along. | 16:48 |
| * SotK wonders if we can print the changes dict more prettily | 16:48 | |
| Zara | (Are there any objections to shifting toward 'notes'?) | 16:49 |
| Zara | probably | 16:49 |
| Zara | that was written before the timeline events bug was fixed | 16:49 |
| Zara | so there's a chance we can get the changes more directly now | 16:49 |
| Zara | I'm not sure | 16:49 |
| SotK | even just getting rid of the quotes and braces would be a good start xD | 16:49 |
| Zara | yeah yeah yea | 16:50 |
| Zara | even just getting automatic boards and worklists would be a good start :P | 16:50 |
| Zara | in seriousness, I'll have a look | 16:50 |
| Zara | once I've tried to tidy up this modal code a bit | 16:50 |
| Zara | it's been on a backburner for literally months. | 16:51 |
| SotK | thanks :D | 16:51 |
| pedroalvarez | I wonder if emails are also being kept in production rabbitmq | 16:54 |
| SotK | they were being sent but swallowed by exim iirc | 16:55 |
| Zara | :) right, so what I propose to do first, is use 'notes' in the front end, where the back end currently says 'link' | 16:57 |
| Zara | then update the back end to match | 16:57 |
| SotK | +1 | 16:58 |
| Zara | so this will be mismatched for a bit, but better then some strange hybrid. though it does need to say 'link' in the front end in one place... but anything called 'task details' will become 'task notes' | 16:58 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Update Fontawesome to 4.5.0 https://review.openstack.org/291274 | 17:06 |
| Zara | \o/ | 17:08 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: WIP task notes https://review.openstack.org/291267 | 17:09 |
| Zara | variable names should now be consistent with that plan | 17:09 |
| Zara | there may be some odd alignment and missing licensing, though | 17:11 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Let Users Add Notes to Tasks https://review.openstack.org/291267 | 17:18 |
| Zara | okay, I thiiink that's ready for reviews now | 17:19 |
| Zara | there's still gonna be weird stuff in it but I won't spot it | 17:19 |
| * Zara notices commit message is in a weird tense | 17:32 | |
| Zara | huh, hang on, no it isn't | 17:33 |
| Zara | my mind is playing tricks | 17:33 |
| * SotK reviews | 17:38 | |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Let Users Add Notes to Tasks https://review.openstack.org/291267 | 17:44 |
| Zara | thanks | 17:45 |
| *** jtomasek has joined #storyboard | 17:51 | |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Let Users Add Notes to Tasks https://review.openstack.org/291267 | 17:57 |
| Zara | I need to head off soon, can take laptop if it would be useful for me to look at things later this evening | 18:22 |
| * SotK doesn't know if he'll send patches today, after remembering I hadn't thought about updates | 18:23 | |
| Zara | okay, how likely do you think it is that you'll send them tomorrow? | 18:24 |
| SotK | pretty likely unless I remember/find something else | 18:24 |
| Zara | hah | 18:24 |
| * Zara keeps estimate at two weeks | 18:24 | |
| Zara | :P | 18:24 |
| SotK | (you can say "I told you so) :P | 18:24 |
| SotK | +" | 18:24 |
| Zara | :D I love doing that! | 18:25 |
| Zara | makes up for the vast discrepancy in coding ability | 18:25 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Let Users Add Notes to Tasks https://review.openstack.org/291267 | 18:25 |
| Zara | \o/ | 18:25 |
| *** openstackgerrit_ has joined #storyboard | 18:30 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add a tooltip when hovering on the "Task notes" button https://review.openstack.org/291391 | 19:50 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Highlight the notes button if a task has notes https://review.openstack.org/291404 | 20:09 |
| *** mrmartin has joined #storyboard | 20:13 | |
| *** b3rnard0 has joined #storyboard | 20:35 | |
| *** mrmartin has quit IRC | 21:33 | |
| *** openstackstatus has quit IRC | 21:42 | |
| *** openstackstatus has joined #storyboard | 21:45 | |
| *** ChanServ sets mode: +v openstackstatus | 21:45 | |
| *** jtomasek has quit IRC | 22:18 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!