| *** jtomasek has joined #storyboard | 08:35 | |
| SotK | It struck me this morning that people will probably want to be able to subscribe to tags | 10:17 |
|---|---|---|
| SotK | I should probably go and read the tags spec | 10:17 |
| pedroalvarez | subscribe to a search maybe? | 10:18 |
| pedroalvarez | stories of project storyboard or project storyboard-webclient that has the tag "bug" | 10:19 |
| pedroalvarez | and priority "high" | 10:20 |
| * SotK isn't sure if that global priority setting has a future once worklists are in use | 10:20 | |
| Zara | yeah, been wondering about that. | 10:22 |
| * SotK finds that the tags spec already talks about subscriptions, and is pleased | 10:44 | |
| Zara | lol, SotK and I just realised that it's possible to put images in storyboard since the markdown patches | 10:55 |
| Zara | ie: hosted on another service, using <img> tags | 10:55 |
| Zara | can't believe that didn't click earlier xD | 10:55 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add plugin_email_enabled preference by default https://review.openstack.org/241665 | 10:58 |
| *** coolsvap is now known as coolsvap|away | 11:01 | |
| Zara | I wanted to demonstrate it in a comment then got paranoid about hotlinking from imgur | 11:12 |
| SotK | do it on storyboard.sotk.co.uk? | 11:13 |
| Zara | (I daresay it's fine for a one-off, but does openstack have its own image-hosting thing we'd be better off using?) | 11:13 |
| Zara | I mainly wanted to demonstrate it so other people would be aware of it, because it took this long for it to click for us! | 11:14 |
| persia | I would like to see classic priorities removed once worklists land. | 11:23 |
| persia | Also, if someone has a good image hosting tool, proposing it in infra may be useful. | 11:23 |
| Zara | I've now asked around there | 11:30 |
| Zara | my only previous experience with this sort of thing is forums, and people are pretty lax about hotlinking there. (tbf, imgur provides bbcode links so I don't think they'd care about one-off uses, guessing they just wouldn't want to be regularly used for hosting a whole bunch of assets) | 11:31 |
| Zara | so I'm probably just being paranoid, but hey. | 11:32 |
| * SotK would imagine imgur don't care about hotlinking unless you're hosting all your assets there | 11:40 | |
| SotK | given imgur is intended for sharing images | 11:40 |
| * SotK could be wrong though | 11:40 | |
| Zara | yeah, nah, I was just being paranoid | 11:43 |
| Zara | see also: looked specifically for an image one of us had uploaded instead of something fun, because licensing | 11:43 |
| Zara | doubt anyone would care | 11:43 |
| Zara | but comments aren't deletable so just covering our backs | 11:44 |
| Zara | (I was thinking about this on the train-- I think comments should be deletable by admin, because of the risk from spam and dodgy links. although it requires a login to post comments, I think that anyone can have an account, so it still seems like a risk to me.) | 13:03 |
| *** mase_x200 has joined #storyboard | 13:06 | |
| persia | I remember a similar debate in Launchpad, for which the resolution was delete-by-admin. In addition to dodgy links, outright obscenity or prohibited speech can be an issue for the hosting organisation. | 13:08 |
| Zara | yeah | 13:10 |
| Zara | I agree that delete-by-user is a bad idea (I think that point came up a while ago), because threads will be confused, but I think we need some way for admin to delete via the UX so they don't have to resort to fiddling around in mysql | 13:11 |
| Zara | okay, I don't think I can test the email worker myself, but I can test that it doesn't cause problems elsewhere. | 13:13 |
| Zara | argh, bug in my events timeline, not sure when introduced | 13:19 |
| SotK | :( | 13:19 |
| SotK | what is it? | 13:19 |
| Zara | 1-10 displays 4 results. 1-25 displays 5. 1-50 also displays 5. 1-100 displays 13. | 13:20 |
| Zara | (of 190 in all cases_ | 13:21 |
| SotK | what are your preferences? | 13:21 |
| Zara | ahahaha I'm a fool, I'd unchecked the boxes xD | 13:22 |
| SotK | I still think that is a bug, but its been around as long as the preferences I thikn | 13:22 |
| Zara | we now know exactly how many 'task details changed' we have per set of results... | 13:22 |
| SotK | we should filter by preference on the server side imo | 13:23 |
| Zara | I think it's a bug that it's not obvious to a user what's going on in that situation, but not sure how to represent it tidily. at least I can stop panicking... | 13:24 |
| Zara | okay, turns out I probably can test but still can't see any emails when I change stories I'm subscribed to etc. wondering if there's anything else I need to do? | 13:43 |
| SotK | hmm, do you see notifications for those changes on the dashboard? | 13:44 |
| Zara | yeah | 13:45 |
| SotK | oh dear, anything useful in the output from the worker? | 13:45 |
| Zara | nothing, am I right in thinking that tox -e venv "storyboard-worker-daemon --config-file ./etc/storyboard.conf" | 13:46 |
| Zara | is the worker command | 13:46 |
| SotK | correct | 13:46 |
| Zara | gah. | 13:46 |
| SotK | what did you change about the story? | 13:46 |
| Zara | Tried changing the description and adding a tag | 13:46 |
| SotK | :( | 13:46 |
| SotK | you should have got an email about the description change | 13:47 |
| Zara | :( | 13:48 |
| Zara | I wonder what's going on | 13:48 |
| pedroalvarez | didn't you need to install an MTA or something? or is that already installed in your environment? | 13:49 |
| SotK | oh, have you set the email preference? | 13:50 |
| Zara | idk what an MTA is so it might be that, and the only preferences I've set manually are in storyboard.conf | 13:51 |
| Zara | so if there's anything else, then I haven't done that yet, and that's probably the problem :) | 13:51 |
| SotK | use https://review.openstack.org/#/c/241665/ and set it in the web UI is probably the easiest way :) | 13:52 |
| Zara | hahaha, okay, I guess at least I've confirmed that patch as-is won't send emails, so that's good to me (I'm scared we'll spam people accidentally) | 13:53 |
| Zara | will try with preferences patch now | 13:53 |
| Zara | yay, worked | 13:55 |
| SotK | \o/ | 13:55 |
| Zara | enabling-then-disabling them seems to work, too :P well, pedro had already checked that-- but I like to be extra careful! :P | 13:57 |
| SotK | hooray! | 13:57 |
| SotK | we'll need to patch puppet to turn them on in production | 13:57 |
| Zara | hm, do tags not trigger emails atm? | 13:59 |
| Zara | or comments? | 14:00 |
| SotK | nope, just editing descriptions | 14:00 |
| SotK | and titles | 14:00 |
| SotK | of stories | 14:00 |
| SotK | well, everything that creates a notification attempts to trigger an email, but there is only a template for updating a story title/description at the moment | 14:02 |
| SotK | so expanding the functionality just means adding templates | 14:02 |
| Zara | heh, I guess we'll build it up, I think we should make it clear to users what things it currently tracks (maybe it should say that on preferences page)? | 14:03 |
| Zara | I can see a new user getting confused because emails aren't showing up for comments etc, and I doubt they'll all see things on gerrit. | 14:03 |
| * pedroalvarez is excited | 14:04 | |
| SotK | that could vary per-instance though | 14:04 |
| * SotK wonders what the best way is | 14:04 | |
| SotK | eg. pedroalvarez may plan to write templates for his instance, so a note on the UI would be a lie | 14:04 |
| SotK | then again, he may not | 14:04 |
| Zara | The alternative is to make the templates first and then merge the UX preferences patch, I guess? | 14:05 |
| pedroalvarez | hm.. I wasn't planning to write my own templates tbh, but I see the point | 14:05 |
| pedroalvarez | if that is possible, some people might want to | 14:05 |
| Zara | I'm a bit wary of going 'we have working email notifications!' and then people get excited, try them, find they're not useful yet and wander off again. | 14:06 |
| * SotK suggests that we don't say "we have working email notifications!" just yet :P | 14:06 | |
| SotK | more "we have an initial implementation of email notifications for changes to story descriptions!" | 14:07 |
| Zara | heh, that works too. | 14:08 |
| SotK | more realistically, we should maybe add more templates before patching puppet to enable them on storyboard.o.o | 14:08 |
| Zara | yeah, I'd be more concerned if the button for notificatons were more prominent | 14:08 |
| Zara | because that could actively confuse users | 14:08 |
| Zara | but it's on the profile page and people won't see that much | 14:08 |
| Zara | so interested parties can see progress but I don't think it'll mislead people | 14:08 |
| SotK | maybe we shouldn't merge that patch until we've patched puppet | 14:09 |
| SotK | hmm | 14:09 |
| pedroalvarez | heh | 14:10 |
| pedroalvarez | are we sure that this puppet script is the one used to deploy? | 14:10 |
| Zara | have +2'd the worker | 14:11 |
| SotK | I think so, I'll check before I send any patches though | 14:11 |
| SotK | \o/ | 14:11 |
| pedroalvarez | so, if Zara has managed to test the patches, that means that the vagrant scripts install a Mail Transfer Agent? | 14:12 |
| persia | I suggest that notifications not be announced until they are considered to work well. | 14:13 |
| SotK | pedroalvarez: I believe she is using a pre-existing MTA | 14:13 |
| openstackgerrit | Merged openstack-infra/storyboard: Single event email worker. https://review.openstack.org/240346 | 14:14 |
| pedroalvarez | woo | 14:14 |
| pedroalvarez | SotK: what do you mean with pre-existing | 14:15 |
| pedroalvarez | I'm just wondering if we have to do anything in puppet to install that too | 14:15 |
| * SotK assumes OpenStack have a mail server we can use | 14:15 | |
| persia | At least there is one for gerrit, but there may well be several. | 14:16 |
| pedroalvarez | makes sense | 14:18 |
| pedroalvarez | maybe the database isn't also on the same host? | 14:18 |
| pedroalvarez | who knows | 14:18 |
| pedroalvarez | SotK: I have the changes needed to the template but in a jinja2 format. Might be easy to translate to puppet templates | 14:20 |
| * pedroalvarez pastes the info just in case | 14:22 | |
| pedroalvarez | http://paste.openstack.org/show/482079/ | 14:22 |
| * SotK gets the webclient SHA into the UI successfully | 14:23 | |
| Zara | storyboard meeting in about half an hour btw | 14:23 |
| SotK | pedroalvarez: I expect that will be helpful, thanks | 14:23 |
| Zara | I completely forgot about it last week | 14:23 |
| pedroalvarez | SotK: ohh!!! you are a grunt expert now :) | 14:23 |
| SotK | fsvo expert :) | 14:24 |
| pedroalvarez | you know what I mean :) | 14:24 |
| Zara | one thing I haven't checked is that emails will work well for multiple subscribers. SotK tested some of this with me as he went along, so I've assumed it's still okay, but my instance doesn't have many users so it's something to watch out for. | 14:26 |
| *** mase_x200 has quit IRC | 14:26 | |
| Zara | btw, I can't merge the preferences-enabled patch yet as it has been updated since pedro's last +1 (and I'm also not sure if people want to merge it, personally I'm okay with it as long as notifications aren't announced yet) | 14:30 |
| SotK | the update just made the default a string rather than a boolean | 14:31 |
| SotK | I don't think we should merge it without something to say it isn't complete (or even running) at the moment | 14:32 |
| Zara | okay | 14:35 |
| SotK | is it worthwhile me sending a patch that just adds the webclient version, or waiting until I've come up with a way to get the API version too? | 14:41 |
| pedroalvarez | it is worthwhile as long as it's clear It's referring to the -webclient version] | 14:44 |
| Zara | 1 minute 'til meeting! | 14:59 |
| Zara | the tension! | 14:59 |
| SotK | oh yeah | 14:59 |
| SotK | the agenda is at https://wiki.openstack.org/wiki/Meetings/StoryBoard if anyone has anything to add | 14:59 |
| *** pedroalvarez has quit IRC | 15:00 | |
| *** pedroalvarez has joined #storyboard | 15:01 | |
| Zara | (and TIL the phrase 'mail transfer agent' B)) | 15:11 |
| pedroalvarez | I put exim on google, and used wikipedia's description :) | 15:12 |
| Zara | heh | 15:18 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Place most recent items at the top of lists https://review.openstack.org/251409 | 15:30 |
| Zara | \o/ | 15:31 |
| pedroalvarez | I'm curious about what was the problem to do this change: https://review.openstack.org/#/c/235476/6..7/src/app/worklists/controller/detail_controller.js | 15:33 |
| pedroalvarez | I guess it was a bug, given that everything else it's at -1 | 15:34 |
| pedroalvarez | ah, it's just a check | 15:34 |
| SotK | yeah its a bug, checking that the index is > -1 checks if it's in the list, but checking that the index is > 1 checks that it is the 3rd or later item in the list | 15:34 |
| SotK | which was broken, as the list in question only had at most two entries | 15:35 |
| SotK | (I missed out the - and didn't notice) | 15:35 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Display the most recent commit SHA on the about page https://review.openstack.org/258583 | 15:40 |
| pedroalvarez | oh no, we broke something | 15:43 |
| pedroalvarez | 500: POST /api/v1/worklists: No error details available. | 15:43 |
| SotK | :( | 15:45 |
| Zara | :0 that's happening on master? | 15:45 |
| pedroalvarez | and in s.o.o | 15:46 |
| SotK | when creating a worklist? | 15:46 |
| pedroalvarez | when creating a board | 15:46 |
| pedroalvarez | it creates the worklist (because I can see them in the dashboard) | 15:46 |
| pedroalvarez | but the board is not created | 15:46 |
| SotK | o.o | 15:47 |
| * SotK fails to reproduce | 15:47 | |
| SotK | on his test instance anyway | 15:47 |
| Zara | yeah, can't reproduce on my instance, hm | 15:48 |
| Zara | s.o.o seems to be down when refreshed | 15:49 |
| Zara | hang on, there we go | 15:49 |
| SotK | hmm | 15:49 |
| Zara | are you sure you're logged in? | 15:49 |
| SotK | I reproduced it on s.o.o | 15:49 |
| Zara | just made a board and it worked | 15:49 |
| pedroalvarez | I noticed this first on teststoryboard.baserock.org | 15:49 |
| SotK | then it worked when I refreshed and tried again | 15:49 |
| SotK | I wonder if this is related to the access token thing? | 15:50 |
| Zara | but at first I reproduced it. I'd been logged out, I think | 15:50 |
| Zara | yeah | 15:50 |
| Zara | I think it's that | 15:50 |
| pedroalvarez | gr | 15:50 |
| pedroalvarez | well, grr, and phew at the same time | 15:50 |
| Zara | yeah | 15:50 |
| Zara | a bug, but not as bad as we feared | 15:50 |
| pedroalvarez | it is the bug | 15:51 |
| -openstackstatus- NOTICE: Gerrit will be offline for a software upgrade from 17:00 to 21:00 UTC. See: http://lists.openstack.org/pipermail/openstack-dev/2015-December/081037.html | 16:21 | |
| pedroalvarez | oh, that's in 40 minutes | 16:22 |
| pedroalvarez | merge all the things! | 16:22 |
| pedroalvarez | I only have one patch more to review :) | 16:25 |
| pedroalvarez | trying to reproduce this problem now: https://review.openstack.org/#/c/256457/ | 16:26 |
| pedroalvarez | (the problem that this patch solves) | 16:26 |
| SotK | view a board you can edit in chrome to see it at its worst | 16:26 |
| pedroalvarez | Oh yes | 16:29 |
| pedroalvarez | cards not taking all the space of the lane | 16:29 |
| pedroalvarez | that works | 16:29 |
| SotK | ok, I think we actually need to patch openstack-infra/system-config to make changes to production | 16:30 |
| pedroalvarez | SotK: I looked for the right place in that repo and didn't find it :S | 16:31 |
| * pedroalvarez finishes reviewing | 16:31 | |
| SotK | yeah, I'm struggling too | 16:33 |
| SotK | perhaps it somehow gets its templates from puppet-storyboard | 16:36 |
| SotK | I'll ask in infra | 16:36 |
| *** persia has quit IRC | 17:00 | |
| *** thrace has quit IRC | 17:00 | |
| -openstackstatus- NOTICE: Gerrit is offline for a software upgrade from 17:00 to 21:00 UTC. See: http://lists.openstack.org/pipermail/openstack-dev/2015-December/081037.html | 17:06 | |
| *** ChanServ changes topic to "Gerrit is offline for a software upgrade from 17:00 to 21:00 UTC. See: http://lists.openstack.org/pipermail/openstack-dev/2015-December/081037.html" | 17:06 | |
| pedroalvarez | just tested the API version patch. Live here: http://teststoryboard.baserock.org/#!/page/about | 17:12 |
| SotK | s/api/webclient/ I guess? | 17:12 |
| pedroalvarez | oh yes | 17:15 |
| *** jtomasek has quit IRC | 17:43 | |
| *** dabukalam has quit IRC | 17:54 | |
| *** Zara_ has quit IRC | 17:54 | |
| *** dabukalam has joined #storyboard | 17:54 | |
| *** Zara_ has joined #storyboard | 17:55 | |
| Zara | gah, it's annoying that storyboard was rolled out to infra too early; looks like people still think there are bugs that must have been fixed n months ago. | 18:14 |
| Zara | good lesson in there about dogfooding if you don't supply adequate resources to improve things. | 18:15 |
| Zara | welp, gerrit's down so can't do much now; night, all! :) | 18:21 |
| *** persia has joined #storyboard | 18:39 | |
| *** persia_ has joined #storyboard | 18:39 | |
| *** ChanServ changes topic to "StoryBoard - A task tracker for OpenStack development needs :: http://storyboard.openstack.org/ :: https://wiki.openstack.org/wiki/StoryBoard" | 21:02 | |
| -openstackstatus- NOTICE: Gerrit has been upgraded to 2.11. Please report any issues in #openstack-infra as soon as possible. | 21:02 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!