| *** openstack has joined #storyboard | 01:08 | |
| *** krotscheck is now known as krotscheck_vaca | 04:00 | |
| *** openstackstatus has quit IRC | 04:24 | |
| *** openstack has joined #storyboard | 04:26 | |
| -wolfe.freenode.net- [freenode-info] channel flooding and no channel staff around to help? Please check with freenode support: http://freenode.net/faq.shtml#gettinghelp | 04:26 | |
| *** openstackstatus has joined #storyboard | 04:26 | |
| *** ChanServ sets mode: +v openstackstatus | 04:26 | |
| *** mrmartin has joined #storyboard | 06:06 | |
| pedroalvarez | well, I think emails are working now on my test instance :) | 09:13 |
|---|---|---|
| SotK | \o/ | 09:15 |
| * SotK has a try | 09:15 | |
| pedroalvarez | took me a while to understand that it won't send you emails when you comment, or modify a task | 09:16 |
| pedroalvarez | So for testing, I modified the description of a story | 09:16 |
| SotK | yeah, its extremely minimal at the moment | 09:17 |
| SotK | you can make it do more stuff by adding more templates though | 09:17 |
| SotK | so if you create `storyboard/plugin/email/templates/task/PUT.txt` and `storyboard/plugin/email/templates/task/PUT_subject.txt` then emails for modifying tasks should work | 09:19 |
| SotK | I'll try to figure out what template is needed for comments, since that is where the system will be most useful I think | 09:24 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add a page to view all of your subscriptions https://review.openstack.org/257509 | 09:26 |
| pedroalvarez | SotK: let's get merged the minimal version first :) | 09:26 |
| pedroalvarez | ohh, that patch sounds useful ^ | 09:27 |
| pedroalvarez | I was angry after spending some time subscribing to stories and realising that I couldn't see them anywhere | 09:28 |
| SotK | yep, its been driving me mad too | 09:29 |
| SotK | aha, its `storyboard/plugin/email/templates/story/comment/POST.txt` and `storyboard/plugin/email/templates/story/comment/POST_subject.txt` | 09:32 |
| pedroalvarez | Could anyone tell me what this patch fixes? https://review.openstack.org/#/c/249776/ | 09:47 |
| *** openstackgerrit has quit IRC | 09:47 | |
| pedroalvarez | I can't see anything broken in storyboard.baserock.org | 09:47 |
| *** openstackgerrit has joined #storyboard | 09:48 | |
| pedroalvarez | oh, project group subscription.. | 09:48 |
| pedroalvarez | yes, broken :) | 09:48 |
| paulsherwood | am i right that there's no way to tell which version of storyboard is running at a given instance? | 09:48 |
| SotK | I believe so yes | 09:49 |
| persia | It is not clearly exposed in the UI. | 09:49 |
| paulsherwood | bug | 09:49 |
| SotK | there is a story for it in storyboard.o.o iirc | 09:49 |
| pedroalvarez | paulsherwood: that but is already a story in storyboard | 09:49 |
| paulsherwood | which one? | 09:49 |
| pedroalvarez | https://storyboard.openstack.org/#!/story/318 | 09:50 |
| *** jtomasek has joined #storyboard | 09:51 | |
| paulsherwood | over a year old? this would be trivial to fix, surely... | 09:51 |
| SotK | probably, but also low priority compared with other problems | 09:57 |
| paulsherwood | hmmm.... | 09:57 |
| pedroalvarez | I agree, I saw that story like a "nice to have" | 09:57 |
| pedroalvarez | and for example, worklists, emails, and bugs like "we need them now" | 09:58 |
| paulsherwood | well, i may be wrong, of course, but i personally prefer to fix/dealwith trivial problems as they occur - it avoids a pileup of unfixed issues. by trivial, i mean somethinhg that can be fixed in minutes/hours, as opposed to days. | 10:00 |
| * persia also | 10:00 | |
| paulsherwood | this specific bug is only 'nice to have' for sb.openstack.org, since it's running master iiuc... for any other instance, maybe the first thing you'd need from a user seeking support is 'which version are you running'? | 10:02 |
| paulsherwood | sorry... i guess i'm sounding like a troll... i'll depart | 10:02 |
| persia | paulsherwood: yes, but often such interrupts delay when one is focused on longer-term things. Without notifications or usable priorities, Storyboard has been unusable. We are now approaching the point where the papwrcyts can be sorted. | 10:02 |
| *** paulsherwood has left #storyboard | 10:03 | |
| persia | That is a good point(even though he left). We should make it easier for other installations to consume master. | 10:04 |
| persia | pedroalvarez: yours is likely the most heavily used: what support would you find useful to consume master? | 10:05 |
| pedroalvarez | I might be wrong, but isn't baserock the only other installation? :) | 10:05 |
| persia | I do not know, but I never like to assume a lack of users :) | 10:07 |
| Zara | I can test and review today! I don't know if I'll be well all day, so please point me at the most important things so I can get to those while I'm still feeling okay. | 10:13 |
| SotK | I guess the email stuff is most important, and also the permissions UI for worklists patch | 10:14 |
| Zara | okay, will look at those. :) glad we can move forward with the emails stuff at last! | 10:20 |
| *** openstackgerrit has quit IRC | 10:32 | |
| *** openstackgerrit has joined #storyboard | 10:32 | |
| SotK | thanks :) | 10:37 |
| pedroalvarez | this one is also important I believe: https://review.openstack.org/#/c/254859/ | 10:38 |
| SotK | oh yeah, I forgot about that one | 10:39 |
| * persia should review the updated patch really | 10:42 | |
| persia | So, I'm confused. the first revision worked for pedro and I, and then the index changed for the second revision. Why? | 10:44 |
| * persia won't be able to test today | 10:44 | |
| SotK | the condition was never True in the first revision, because the first match was always either '' or '/api', never 'openid' | 10:46 |
| SotK | I doubt it would actually cause trouble, but the tests caught it | 10:46 |
| persia | Ah, right, but the manual testing didn't include attempting to test the error condition :) | 10:48 |
| * persia restores the prior review value | 10:48 | |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Fix subscription display for project groups https://review.openstack.org/249776 | 10:56 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Use a modal to add projects https://review.openstack.org/257872 | 12:26 |
| * SotK ponders the best way to get the version of the webclient | 12:34 | |
| pedroalvarez | that should be generated by grunt build | 12:34 |
| SotK | I guess I'm going to have to learn a bit more about how grunt works | 12:38 |
| pedroalvarez | hey, I was just suggesting :) | 12:38 |
| pedroalvarez | I might be wrong | 12:38 |
| SotK | I think you are right :) | 12:40 |
| pedroalvarez | I was thinking about the case were you download the compiled tarball | 12:41 |
| pedroalvarez | the version has to be in there already | 12:41 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Use a modal to add projects https://review.openstack.org/257872 | 13:22 |
| SotK | So I was looking at displaying the user's email as well as their name when searching for a user (eg. when assigning to a task) to have something more unique than a name, but the user's email is not a public field | 14:17 |
| SotK | (see https://storyboard.openstack.org/#!/story/2000132 ) | 14:17 |
| SotK | I assume there is a good reason for that, but I may be assuming wrong | 14:18 |
| * SotK looks in history | 14:18 | |
| SotK | there used to be a unique "nickname", but I think that was causing a bug when logging in with launchpad before logging into ubuntu one | 14:20 |
| SotK | (due to the oauth nickname not being set or something weird like that) | 14:20 |
| * SotK doesn't know how to solve this | 14:24 | |
| Zara | yeah, I'm guessing the user might not want their email to be displayed (maybe also a spam risk?) | 14:27 |
| SotK | indeed | 14:28 |
| * SotK decides to go back to reading about grunt plugins | 14:33 | |
| * SotK thinks he has found a suitable set of grunt plugins to do the job required | 14:58 | |
| pedroalvarez | Zara: regarding to the -1, that was put as a reminder of another comment | 14:58 |
| pedroalvarez | I believe the comment was addresed | 14:58 |
| * SotK thinks so too, and the author of the original comment didn't feel strongly enough about it to -1 | 14:59 | |
| Zara | yeah, it's just not clear on the gerrit page itself, so I'm not sure if it's rude not to check with mordred first | 15:00 |
| openstackgerrit | Merged openstack-infra/storyboard: Parse path correctly when it begins with /api https://review.openstack.org/254859 | 15:02 |
| pedroalvarez | nice :) | 15:03 |
| Zara | if someone can summarise the conversation with jeblair in the gerrit thread then I'll merge the patch, I just don't want it to be confusing/seem like we're ignoring criticism if somone looks at it later. | 15:13 |
| * SotK didn't actually discuss the subject/body thing with jeblair | 15:17 | |
| SotK | just the patch he had -1'd | 15:18 |
| Zara | :S | 15:21 |
| * pedroalvarez is happy after reading -infra backlog | 16:03 | |
| Zara | yeah :) | 16:04 |
| pedroalvarez | Is anyone going to put the conclusion in the patch in gerrit? | 16:08 |
| * SotK will | 16:10 | |
| SotK | done | 16:12 |
| pedroalvarez | good! :D | 16:13 |
| * Zara starts reviewing, gets distracted by a snake in the office. | 16:34 | |
| openstackgerrit | Merged openstack-infra/storyboard: Factory subject is now a template file. https://review.openstack.org/240345 | 16:36 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add UI for complex permissions on boards and worklists https://review.openstack.org/235476 | 16:38 |
| pedroalvarez | \o/ | 16:56 |
| pedroalvarez | this is good, I take that now https://review.openstack.org/#/c/240346/ can be merged too :) | 16:58 |
| pedroalvarez | hang on, I still get emails even with the option marked as disabled | 17:10 |
| *** mrmartin has quit IRC | 17:50 | |
| Zara | heh, just as well you found it now instead of later... :) | 17:55 |
| SotK | whaaaaat | 18:06 |
| SotK | aha, thanks for the comment pedroalvarez | 18:07 |
| * SotK doesn't know how he missed that | 18:07 | |
| *** mrmartin has joined #storyboard | 18:13 | |
| pedroalvarez | Yeah, I worried again about bothering people, so I tested that | 18:17 |
| pedroalvarez | I guess the fix is easy | 18:18 |
| SotK | yeah | 18:26 |
| SotK | I think its actually caused a few lines higher than your comment, since I changed from using a boolean to using a string like all the other preferences for consistency | 18:26 |
| SotK | and "false" is just as true as "true" | 18:27 |
| Zara | =D | 18:31 |
| pedroalvarez | I can test things later :) | 18:38 |
| pedroalvarez | But I noted that user preferences is a dictionary, and the value of every preference is a preference object | 18:39 |
| pedroalvarez | I thought the fix would be to check the contents of that object, instead of checking for the key | 18:39 |
| pedroalvarez | But I can't see the code now, you may be right | 18:40 |
| pedroalvarez | Oh, yes, you are right :) | 18:49 |
| *** jtomasek has quit IRC | 18:55 | |
| *** openstackgerrit has quit IRC | 19:32 | |
| *** openstackgerrit has joined #storyboard | 19:32 | |
| *** b3rnard0 is now known as b3rnard0_away | 19:52 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Single event email worker. https://review.openstack.org/240346 | 20:01 |
| SotK | pedroalvarez: is that any better? | 20:02 |
| * SotK isn't in a situation to be able to test easily right now | 20:02 | |
| *** mrmartin has quit IRC | 20:20 | |
| *** mrmartin has joined #storyboard | 20:22 | |
| *** mrmartin has quit IRC | 20:27 | |
| SotK | gah, the tests broke | 20:31 |
| *** jtomasek has joined #storyboard | 20:32 | |
| * SotK tries to find where the test data lives | 20:34 | |
| SotK | storyboard/tests/mock_data.py, unsurprisingly | 20:35 |
| *** b3rnard0_away is now known as b3rnard0 | 20:48 | |
| *** jtomasek has quit IRC | 21:59 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Single event email worker. https://review.openstack.org/240346 | 22:14 |
| *** betherly has quit IRC | 22:56 | |
| *** betherly has joined #storyboard | 22:57 | |
| *** jtomasek has joined #storyboard | 23:11 | |
| *** jtomasek has quit IRC | 23:16 | |
| *** jjardon has quit IRC | 23:23 | |
| *** jjardon has joined #storyboard | 23:25 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!