| *** openstack has joined #storyboard | 05:55 | |
| *** mrmartin has quit IRC | 06:15 | |
| *** openstack has quit IRC | 07:28 | |
| *** openstack has joined #storyboard | 14:06 | |
| *** openstackstatus has joined #storyboard | 14:06 | |
| *** ChanServ sets mode: +v openstackstatus | 14:06 | |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Align story subscription stars on right https://review.openstack.org/250417 | 14:42 |
|---|---|---|
| Zara | I wrote that patch hours ago and forgot about it, hm. | 14:43 |
| pedroalvarez | Zara: arrghh! gerrit shows a whitespace in red!! | 14:43 |
| Zara | and there's an extra whitespace! | 14:43 |
| Zara | snap! | 14:43 |
| Zara | argh! | 14:43 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Align story subscription stars on right https://review.openstack.org/250417 | 14:44 |
| pedroalvarez | should we poke Monty Taylor regarding this patch? https://review.openstack.org/#/c/240345/ | 14:45 |
| Zara | yeah, though I think we're mainly waiting on a response from jeblair about that one | 14:54 |
| SotK | also waiting on jeblair for https://review.openstack.org/#/c/240346/ | 14:54 |
| * SotK hopes to get to poking him today | 14:55 | |
| pedroalvarez | oh true, Monty only -1ed as a reminder | 14:55 |
| Zara | I thought you also needed to update that second one, SotK? | 14:55 |
| Zara | to match the inline comment | 14:56 |
| SotK | oh yeah | 14:57 |
| SotK | oops | 14:57 |
| SotK | :) | 14:57 |
| Zara | I keep forgetting about that one too, or I'd've mentioned it earlier, sorry. | 14:57 |
| Zara | time to tackle some reviews... | 14:58 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Allow boolean preferences https://review.openstack.org/241661 | 15:02 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Factory subject is now a template file. https://review.openstack.org/240345 | 15:02 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Single event email worker. https://review.openstack.org/240346 | 15:02 |
| SotK | https://review.openstack.org/#/c/241661/ should be mergeable now | 15:03 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Fix SubscriptionEvents not making it into the database https://review.openstack.org/240301 | 15:04 |
| Zara | woop, I'll take a look! | 15:04 |
| SotK | and now https://review.openstack.org/240301 should be too | 15:04 |
| Zara | argh | 15:05 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Add a page to view a board https://review.openstack.org/231971 | 15:14 |
| openstackgerrit | Merged openstack-infra/storyboard: Allow boolean preferences https://review.openstack.org/241661 | 15:18 |
| SotK | \o/ | 15:19 |
| openstackgerrit | Merged openstack-infra/storyboard: Fix SubscriptionEvents not making it into the database https://review.openstack.org/240301 | 15:25 |
| Zara | Thmergedsday | 15:26 |
| Zara | hm, doesn't really work | 15:26 |
| pedroalvarez | Zara: just tested your "move the start to the right" patch | 15:27 |
| SotK | I wonder if https://review.openstack.org/240301 will fix the weirdness with recent events on storyboard.o.o | 15:28 |
| pedroalvarez | it is nicer, but it doesn't really match with the stories list | 15:28 |
| Zara | yeah, I think the stars should be *right* at the end | 15:29 |
| Zara | I didn't look too closely at that, but actually it might just be a question of moving a class down on the template. I'll look at that now. | 15:29 |
| pedroalvarez | -1ed in gerrit so that is noted | 15:31 |
| Zara | I'm guessing that template needs a general so that the relevant bits look more like these: https://github.com/openstack-infra/storyboard-webclient/blob/master/src/app/search/template/story_search_item.html | 15:37 |
| Zara | (that's where the list of stories is displayed from; the story list template gets that one from src/app/search/...) | 15:38 |
| Zara | whereas the stories that are displayed within a project come from a template that looks like this: https://github.com/openstack-infra/storyboard-webclient/blob/master/src/app/stories/template/story_list_item.html | 15:38 |
| Zara | I think it's just a question of mkaing the latter look more like the former, may not have time for it today | 15:39 |
| Zara | *making | 15:39 |
| Zara | *a general fix | 15:40 |
| pedroalvarez | It does look weird to me that the list of stories in a project look different than the full list of stories | 15:41 |
| Zara | yup | 15:43 |
| SotK | I agree | 15:44 |
| Zara | it's probably quite a fun bug to fix, as bugs go; supect it's mainly a question of playing 'spot the difference' between the relevant sections of those templates | 15:48 |
| Zara | I reserve the right to be horribly wrong on that \o/ | 15:48 |
| Zara | so top right search is referred to in storyboard/header_controller.js; TIL (writing it down so that maybe it sticks) | 15:53 |
| Zara | I guess that's common sense since it's in the header | 15:53 |
| Zara | but hey | 15:53 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Fix top-right search for project groups https://review.openstack.org/250465 | 15:56 |
| * pedroalvarez reviews | 16:00 | |
| SotK | Zara: when you were looking at access tokens, where did you find the 3600 value? | 16:06 |
| Zara | profile/controller/profile_token_new_controller.js , iirc | 16:07 |
| pedroalvarez | hm.. I thought I knew the answer | 16:08 |
| Zara | though that was the webclient end | 16:08 |
| * SotK may have discovered the answer at last | 16:08 | |
| pedroalvarez | https://github.com/openstack-infra/puppet-storyboard/blob/master/manifests/application.pp#L36 | 16:08 |
| *** pleia2_ is now known as pleia2 | 16:08 | |
| SotK | indeed | 16:09 |
| pedroalvarez | :) | 16:09 |
| SotK | in storyboard.conf: | 16:09 |
| SotK | 53 # Time in seconds before an access_token expires | 16:09 |
| SotK | 54 # access_token_ttl = 3600 | 16:09 |
| pedroalvarez | exactly | 16:09 |
| Zara | I thought I also tried changing that and it made no difference | 16:09 |
| Zara | but I could be misremembering | 16:09 |
| Zara | I notice there are also a bunch of 3600s in the api | 16:10 |
| SotK | if that doesn't work then something is majorly broken | 16:10 |
| Zara | grepping gets me: api/app.py: default=3600, | 16:10 |
| Zara | api/v1/wmodels.py: expires_in=3600 | 16:10 |
| Zara | api/v1/wmodels.py: expires_in=3600) | 16:10 |
| Zara | api/middleware/cors_middleware.py: allowed_headers=None, max_age=3600): | 16:10 |
| Zara | in the api | 16:10 |
| SotK | the wmodels ones are examples I believe | 16:11 |
| Zara | ah, okay | 16:11 |
| SotK | and the other two are for CORS cache timeouts | 16:11 |
| * SotK tries changing it to see what happens | 16:11 | |
| * pedroalvarez wonders what are we trying to fix with that | 16:12 | |
| Zara | we think it relates to the annoying 401. | 16:12 |
| pedroalvarez | I knew it :) | 16:12 |
| pedroalvarez | that will only delay it, right? | 16:12 |
| Zara | yup | 16:12 |
| pedroalvarez | access_token_ttl = 999999999999999999 | 16:13 |
| SotK | trying to do the first task in https://storyboard.openstack.org/#!/story/36 | 16:13 |
| Zara | (it's a workaround, but better than nothing, imo. My preferred time would probably be about a week, fwiw.) | 16:13 |
| * pedroalvarez clicks and 401!!!!!!!!! | 16:14 | |
| SotK | :D | 16:14 |
| Zara | saaaaaaaaaame | 16:14 |
| Zara | I looked at this very briefly before Tokyo but I was mainly concentrating on printing off boarding passes by that point. :S | 16:14 |
| * SotK gets a new token.... "Current U8V1aB3mwMfAjn6RPrTUSXCTJSOjizin 3 minutes in a day" | 16:14 | |
| SotK | \o/ | 16:14 |
| pedroalvarez | yay | 16:14 |
| Zara | \o/ | 16:15 |
| pedroalvarez | so.. you have to patch puppet? | 16:15 |
| SotK | I guess so | 16:15 |
| SotK | we should set a sensible default in the example config too | 16:17 |
| pedroalvarez | heheh, will you be able to test puppet changes? | 16:24 |
| pedroalvarez | I just gave up when trying to use puppet... | 16:24 |
| SotK | perhaps, I think storyboard's vagrantfile uses puppet somehow | 16:25 |
| * SotK notices puppet-storyboard has a vagrantfile and tries using that | 16:27 | |
| pedroalvarez | argh, I might be stupid after all | 16:28 |
| Zara | looking at review comments on project group search-- I agree that would be a better approach; there's some reason why changing it to project_group.detail doesn't work. it's something to do with the urls, I think; it works for project_group.list because the url is /list , but detail has a url of /project_group/detail/id. There's probably a fix for it, I just wasn't able to get it to work last time I looked at it, so that's why it's that | 16:29 |
| Zara | but that was partly because I knew way less angularjs, so I can take another look. | 16:30 |
| pedroalvarez | i see.. | 16:48 |
| pedroalvarez | Hm.. feel free to ignore my comment if other reviewers agree with your solution | 16:49 |
| pedroalvarez | to be honest I thought that doing what I suggested would be easy. | 16:49 |
| Zara | it requires shifting some things around, but it might not be very difficult and it's just my ignorance showing. Just had a look at it and didn't get any closer. It's not the most urgent thing and I'd rather the codebase gets more consistent if possible. Hopefully someone who knows angularjs a bit better can explain what's going on and how I can fix it... | 16:54 |
| Zara | I'm happy to leave it hanging around in review for now, anyway. | 16:54 |
| *** wendar_ is now known as wendar | 16:56 | |
| pedroalvarez | Zara: I found this: http://paste.baserock.org/oyekoqadix | 17:04 |
| pedroalvarez | not sure if that helps | 17:04 |
| pedroalvarez | well, I guess you have investigated that too | 17:05 |
| Zara | yeah, iirc I had to change it that way originally to get it to work, though I don't really understand *why* that worked... \o/ | 17:05 |
| pedroalvarez | hah | 17:05 |
| pedroalvarez | :) | 17:05 |
| Zara | so originally, there were two project group pages | 17:06 |
| Zara | one from an admin menu, and one from the 'project groups' menu | 17:06 |
| Zara | with completely different layouts | 17:06 |
| Zara | so I combined them, partly to learn more about the codebase, partly because it was just confusing | 17:07 |
| Zara | well, mainly because it was just confusing | 17:07 |
| Zara | (on one page, clicking a project title would navigate to the project, on the other, it'd edit the project title, and so on.) | 17:07 |
| Zara | so now it's one page that just displays extra admin options to admin | 17:08 |
| Zara | *but* the code is partly my work, so. :/ | 17:08 |
| Zara | there's definitely some weirdness in it. | 17:08 |
| Zara | I should probably change :id to {id:[0-9]+} , though, so it's more consistent. | 17:14 |
| Zara | even if I don't know how to change everything around that yet :S | 17:15 |
| SotK | the vagrant file did a lot of grumbling, ground my laptop to a halt, then failed | 17:16 |
| SotK | \o/ | 17:16 |
| pedroalvarez | :D | 17:16 |
| pedroalvarez | oh, I should be sad | 17:17 |
| SotK | doesn't seem like it failed for any sensible reason, a command just timed out | 17:18 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: List id for url consistently https://review.openstack.org/250505 | 17:23 |
| Zara | I think that's probably my least significant change so far | 17:24 |
| Zara | should hopefully make it easier to see what the important differences are between the project groups code and the code for stories and projects | 17:24 |
| Zara | so one day, someone can work out what's going on. maybe it'll be me, who knows... | 17:25 |
| Zara | ack, completely forgot about dropdown 'new...' button, sorry, will review now (meant to review it first thing this morning, ahahaha) | 17:31 |
| * SotK decides puppet can wait for tomorrow | 17:32 | |
| Zara | hm, there's a 'private' checkbox for worklists/boards, but afaik the permissions stuff hasn't been merged yet, so does that do anything? | 17:39 |
| Zara | if it doesn't, I'm in favour of hiding it, or at least letting the user know that it's not implemented yet | 17:40 |
| Zara | different patch, but have to say, I still find the drag'n'drop for worklists a bit weird, since you have to start dragging to move them (because if you just click, you open the story listed), but then let go and click to place them. I'd expect it to either be drag and drop, or click, release, and click again. | 17:44 |
| Zara | odd comment from gerrit here about this depending on an outdated patch set: https://review.openstack.org/#/c/231973/ | 18:00 |
| Zara | well, outdated patch. | 18:00 |
| Zara | I believe some form of rebasing is needed, anyway | 18:00 |
| pedroalvarez | yes, my guess is that this patch depends on some of the previous versions of the other patch | 18:02 |
| pedroalvarez | I normally see this when I edit the patch (or commit msg) using the web UI | 18:03 |
| pedroalvarez | which looks like the case here | 18:03 |
| Zara | makes sense | 18:03 |
| Zara | btw, I think we should think about releases and things, once boards/worklists are merged, since that's a pretty significant change and I'd like to say 'get this version of storyboard for worklists and boards!'. versioning has fallen by the wayside, but I'd like to get it started again. | 18:06 |
| pedroalvarez | yeah, and set goals for next release :) | 18:09 |
| Zara | yeah, we're getting toward that (focussing on notification, at least), but the exact goals still need to be worked out | 18:10 |
| Zara | I'm veering toward 'email notifications with some basic filtering' as a goal, but idk if that's not ambitious enough. | 18:11 |
| Zara | anyway, more tomorrow, 'night! | 18:14 |
| *** openstackgerrit has quit IRC | 18:49 | |
| *** paulsher1ood has joined #storyboard | 18:59 | |
| *** jtomasek has quit IRC | 19:01 | |
| *** SotK has quit IRC | 19:01 | |
| *** Zara___ has quit IRC | 19:01 | |
| *** Zara has quit IRC | 19:01 | |
| *** paulsherwood has quit IRC | 19:01 | |
| *** persia has quit IRC | 19:01 | |
| *** krotscheck has quit IRC | 19:01 | |
| *** coolsvap has quit IRC | 19:01 | |
| *** gothicmindfood has quit IRC | 19:01 | |
| *** tlbr has quit IRC | 19:01 | |
| *** NikitaKonovalov has quit IRC | 19:01 | |
| *** cody-somerville has quit IRC | 19:01 | |
| *** cody-somerville- has quit IRC | 19:01 | |
| *** dabukalam has quit IRC | 19:01 | |
| *** betherly has quit IRC | 19:01 | |
| *** jjardon has quit IRC | 19:01 | |
| *** ttx has quit IRC | 19:01 | |
| *** Zara_ has joined #storyboard | 19:08 | |
| *** SotK_ has joined #storyboard | 19:08 | |
| *** krotscheck has joined #storyboard | 19:08 | |
| *** coolsvap has joined #storyboard | 19:08 | |
| *** gothicmindfood has joined #storyboard | 19:08 | |
| *** tlbr has joined #storyboard | 19:08 | |
| *** NikitaKonovalov has joined #storyboard | 19:08 | |
| *** 92AAB9ZGC has joined #storyboard | 19:10 | |
| *** ttx has joined #storyboard | 19:10 | |
| *** openstackgerrit has joined #storyboard | 19:10 | |
| SotK_ | Zara: it's very weird that you're having to click to drop things, I've never had that problem | 19:11 |
| * SotK_ imagines persia will have an opinion on releases :) | 19:11 | |
| SotK_ | I certainly think at least some kind of announcement email is in order when we get boards and worklists though | 19:13 |
| SotK_ | the private box does do something without the permissions patch, it makes the board/worklist visible to only the person who created it | 19:14 |
| *** cody-somerville has joined #storyboard | 19:14 | |
| *** cody-somerville- has joined #storyboard | 19:14 | |
| *** dabukalam has joined #storyboard | 19:14 | |
| *** betherly has joined #storyboard | 19:14 | |
| *** jjardon has joined #storyboard | 19:14 | |
| *** paulsherwood has joined #storyboard | 19:24 | |
| *** paulsher1ood has quit IRC | 19:26 | |
| *** persia_ has quit IRC | 19:39 | |
| *** SotK_ is now known as SotK | 19:59 | |
| *** jtomasek has joined #storyboard | 20:42 | |
| *** Zara has joined #storyboard | 20:44 | |
| *** ttx_ has joined #storyboard | 20:56 | |
| *** 92AAB9ZGC has quit IRC | 20:57 | |
| *** ttx has quit IRC | 20:57 | |
| *** openstackgerrit has quit IRC | 21:06 | |
| *** openstackgerrit has joined #storyboard | 21:07 | |
| *** openstackgerrit has quit IRC | 23:47 | |
| *** openstackgerrit_ has joined #storyboard | 23:48 | |
| *** openstackgerrit_ is now known as openstackgerrit | 23:48 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!