| *** mrmartin has joined #storyboard | 06:49 | |
| *** mrmartin has quit IRC | 07:29 | |
| *** mrmartin has joined #storyboard | 09:15 | |
| SotK | good morning storyboard! | 10:42 |
|---|---|---|
| Zara | morning! | 10:42 |
| Zara | I can't wake up in the winter, zzzzzzzz | 10:53 |
| pedroalvarez | o/ | 10:56 |
| Zara | hey, pedro! :) | 10:56 |
| Zara | okay, so my rough plan today is to go through that spec draft thing and flesh it out a bit (ie: where I've asked questions, come up with some possible answers), so that we get closer to a roadmap. I also need to do some review... | 10:58 |
| Zara | anything else I need to be thinking about? | 10:59 |
| pedroalvarez | I can help you reviewing https://review.openstack.org/#/c/249219/ :) | 10:59 |
| pedroalvarez | (I want that merged :P) | 10:59 |
| Zara | hah, I think I was checking that yesterday and forgot to actually comment on it, whoops. | 11:00 |
| Zara | will double-triple check but expect review on that very shortly | 11:00 |
| SotK | \o/ | 11:00 |
| pedroalvarez | nice :) | 11:03 |
| pedroalvarez | upgrading WSME in the vm that you have storyboard api installed will be enough to make it break | 11:04 |
| pedroalvarez | and then apply that patch to fix it | 11:04 |
| Zara | I was a little lazy and didn't check it fixed it, since you'd already tested that; it was enough for me that it didn't break anything I could find on my instance and had fixed the issue for you. | 11:05 |
| pedroalvarez | good | 11:08 |
| Zara | trying to strike a balance between being thorough and getting things merged reasonably quickly; hope it's working out! | 11:10 |
| pedroalvarez | I think it's fair if you trust the reviewer that has done the testing | 11:10 |
| Zara | :) | 11:11 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Don't add unexpected `story_id` attribute to Comment https://review.openstack.org/249219 | 11:13 |
| *** wuhg has quit IRC | 11:31 | |
| SotK | I'm not actually sure that shoving the subject in the template is going to be any neater now I'm doing it | 11:37 |
| Zara | :S | 11:38 |
| SotK | it means that the plain text template is special, when the current implementation treats all templates as equal (although only adds a plain text one at the moment) | 11:39 |
| Zara | I don't follow, sorry (I think I need more context, since I'm only going from the review comments atm). In my head there are three steps: plain text template, which is rendered, then subject taken out of the rendered one. so I think there are some (ie: lots of) gaps in my mind about the implementation. | 11:46 |
| Zara | (am looking at the code now to see if that helps; I'd imagine it would) | 11:47 |
| *** mrmartin has quit IRC | 12:01 | |
| SotK | the implementation also allows an arbitrary set of other templates to be rendered (eg an html template), but doesn't actually use that functionality anywhere (yet?) | 12:28 |
| SotK | s/templates/content templates/ | 12:28 |
| SotK | at the moment it just adds one (the text/plain template) and renders that, with the subject in a different file | 12:29 |
| SotK | but if for example the old plan was for something like "if user wants html emails, add html template, else add plain template", its going to get messy having the subject in the content template | 12:30 |
| Zara | ah, if I've followed then it seems like you'd have to have a field for the subject in both templates? (and those templates might be used for things other than emails?) | 12:33 |
| persia | I think HTML email is uninteresting, but it might be interesting to have other sorts of subscription feeds to drive various types of automation. | 12:33 |
| persia | (and some of those may wish to consume HTML content) | 12:34 |
| SotK | Zara: potentially the subject might need to be in both, it depends on what further development is done | 12:34 |
| SotK | but I like that it is currently nicely separated and the code is general | 12:34 |
| Zara | yeah, maybe I'm leaping ahead there by jumping to possible ways around it | 12:35 |
| Zara | from what you've said it sounds like it makes sense to keep the subjects separate; what are the pros/cons of each approach? is there some way subjects and bodies might get mismatched if they're in seaprate templates? more things that could end up being incompatible with each other? | 12:36 |
| Zara | *separate | 12:36 |
| SotK | cons: changing the look of an email could mean editing two files rather than one | 12:37 |
| Zara | maybe users should edit one file that then gets split into two and recombined later, just for the fun of it xD | 12:38 |
| Zara | how often are people likely to change templates? I'd've thought it wasn't something people would do very frequently | 12:39 |
| SotK | pros: not trying to parse a rendered template as if its an email, code without a special case for one template (or alternatively, subject duplicated across all templates), already implemented and known to work | 12:39 |
| SotK | I doubt it will be very frequent, and its easy to document | 12:39 |
| SotK | also the subject is in `templates/stories/PUT_subject.txt`, with the content in `templates/stories/PUT.txt`, so it shouldn't be too confusing | 12:40 |
| Zara | okay, in that case, to me it looks like you should argue it and see if people are thinking of any other cons that we've not thought of. :) | 12:41 |
| Zara | I prefer modular code, too | 12:41 |
| Zara | (I think PUT_subject.txt and PUT_body.txt would be clearer, if that does accurately capture the whole difference between the two) | 12:45 |
| Zara | argh, project group subscriptions aren't displaying properly with the new layout. how didn't I notice this?! | 12:52 |
| Zara | gah | 12:52 |
| Zara | fixed on my instance, ugh, that was stressful. | 13:12 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Fix subscription display for project groups https://review.openstack.org/249776 | 13:18 |
| Zara | this also reminds me that at some point those templates need pruning. I'm not convinced they're all needed anymore. | 13:19 |
| * SotK remembers its the storyboard meeting this afternoon | 13:21 | |
| Zara | (controllers too, for that matter. I think there are some weird relics.) | 13:21 |
| Zara | ack | 13:21 |
| Zara | I should get on with fleshing out that spec... | 13:22 |
| * Zara hides under her desk instead. | 13:22 | |
| Zara | close enough. | 13:22 |
| SotK | why does adding a new story/project group open a modal, but adding a new project goes to a special page? | 13:53 |
| *** mrmartin has joined #storyboard | 13:57 | |
| Zara | oh, it's different in the different controllers? I don't know. | 14:05 |
| *** openstackgerrit has quit IRC | 14:06 | |
| *** openstackgerrit has joined #storyboard | 14:07 | |
| SotK | meeting in 45 minutes in #openstack-meeting, feel free to edit the agenda at https://wiki.openstack.org/wiki/Meetings/StoryBoard | 14:16 |
| Zara | how is it already 2:30? | 14:24 |
| SotK | I have no idea | 14:24 |
| * persia blames the rotation of the planet | 14:32 | |
| Zara | interesting hypothesis; how should we test it? | 14:36 |
| SotK | we could try getting off the world and measuring if time still passes | 14:47 |
| Zara | ah, so I'm guessing we need some kind of extension to storyboard that will remove us from the planet. | 14:55 |
| * SotK updates http://storyboard.sotk.co.uk/ | 14:56 | |
| SotK | any opinions on that dropdown vs. the old button approach? | 14:57 |
| SotK | oh, I forgot to handle logged-out people, oops | 14:58 |
| Zara | I prefer it aesthetically, though I can't test it on a mobile or tablet screen | 14:58 |
| Zara | also hahaha I forgot my demo worklist went 'get good wifi, give up, go home' | 14:58 |
| Zara | -> meeting | 15:00 |
| pedroalvarez | as I said already in the meeting, is nicer now | 15:04 |
| *** mrmartin has quit IRC | 15:23 | |
| pedroalvarez | btw: https://galaxy.ansible.com/detail#/role/6187 | 15:49 |
| pedroalvarez | ansible role to install storyboard | 15:49 |
| pedroalvarez | I found that openstack-ansible only has roles to install components of openstack itself, nothing to do with infra | 15:50 |
| pedroalvarez | So I decided to publish it here | 15:50 |
| pedroalvarez | I'll create some documentation for it, I promise :) | 15:50 |
| pedroalvarez | So SotK.. to be honest, I don't really understand worklists :/ | 15:51 |
| SotK | pedroalvarez: which bit? | 15:52 |
| SotK | that ansible role looks shiny :) | 15:52 |
| pedroalvarez | well, and boards... | 15:53 |
| pedroalvarez | I don't know how it's supposed to be the workflow | 15:53 |
| pedroalvarez | so is something that you have to create "manually" for yourself, to track your work, right? | 15:56 |
| persia | Or to track desired work | 15:57 |
| SotK | indeed | 15:57 |
| persia | Set your opinion of priorities, etc. | 15:57 |
| persia | Or a list of stories required to implement a spec. | 15:58 |
| pedroalvarez | I see, so one board or one worklist is not for one user. It might be for a team | 15:59 |
| SotK | yep, it can be for as many or as few people as the owner(s) of the board desire | 15:59 |
| pedroalvarez | I see | 16:00 |
| pedroalvarez | alright, I think I understand | 16:00 |
| pedroalvarez | So for example, a team can have a worklist of bugs, so that they are prioritized | 16:01 |
| SotK | yep | 16:02 |
| pedroalvarez | or for example, a team can share a board to track what is needed for the next release | 16:02 |
| SotK | that is the plan | 16:03 |
| persia | Or one team can see what another team is doing on the same project, to coordinate. | 16:03 |
| SotK | using them for priorities means that there is no "global" priority needed, and so other people can prioritise the same thing according to their work | 16:04 |
| persia | The idea being to remove the need for those massive multiparty prioritisation meetings where someone claims X is high priority, and someone else claims they don7t care about X, and the first person shuold work on Y, etc. | 16:04 |
| pedroalvarez | well, there will be meetings to discuss where to put the task in the worklist | 16:05 |
| persia | Only within a team. | 16:05 |
| pedroalvarez | btw SotK, in your instance I can create worklists with the same task several times | 16:06 |
| persia | So, for example, if a project has three organisations funding development, each organisation can have a separate priority list, and they can avoid the arguments. | 16:06 |
| SotK | pedroalvarez: that is expected, I'm not sure if we want to limit the contents of worklists or not | 16:09 |
| SotK | I guess it is probably sensible to do so | 16:09 |
| pedroalvarez | just raising the point, given that it's a bit confusing | 16:13 |
| persia | I agree it is sensible to force worklists to have a unique set of stories. | 16:14 |
| pedroalvarez | It would be good to have a board and a worklist for storyboard when we merge these patches :) | 16:22 |
| SotK | I agree | 16:23 |
| * SotK is looking forward to getting them merged so we can have one | 16:23 | |
| Zara | argh did someone say something relevant to me no im not here nothing to see here nope | 16:24 |
| Zara | erm, I mean, I'm slowly working through them! ^^' | 16:25 |
| Zara | I've actually reviewed this one, waiting on other reviewers: https://review.openstack.org/#/c/231971/ | 16:26 |
| Zara | same with https://review.openstack.org/#/c/222268/ | 16:27 |
| pedroalvarez | hm... | 16:38 |
| pedroalvarez | just tested the UI from phone | 16:38 |
| * pedroalvarez is known as the-phone-reviewer | 16:38 | |
| pedroalvarez | bit weird, but I guess it can be polished later | 16:39 |
| SotK | pedroalvarez: which bit is weird? | 16:41 |
| pedroalvarez | well, all the lanes in the board are one next to the other | 16:41 |
| pedroalvarez | in horizontal | 16:41 |
| pedroalvarez | so you have to scroll to the sides | 16:41 |
| pedroalvarez | and is a bit odd | 16:41 |
| pedroalvarez | but as I said, we shouldn't be focusing in phone users, although it might be nice to have in the future | 16:42 |
| persia | "phone users" is a tricky segment. | 16:42 |
| persia | But some laptop users are still 1366x768, and some phone users well above 1920x1080, so resolution/size issues matter beyond "phone" vs. "laptop" | 16:43 |
| SotK | oh yeah, I just went for the same approach as Trello uses there in the end | 16:43 |
| pedroalvarez | right, trello approach looks good | 16:45 |
| pedroalvarez | ok I'm ok with it :) | 16:51 |
| pedroalvarez | persia: yes, resolution *and* size | 16:54 |
| *** mrmartin has joined #storyboard | 16:56 | |
| Zara | I've updated https://wiki.openstack.org/wiki/StoryBoard/Notifications with a list of things that can update. in the process found a few odd general things, but hopefully that helps people visualise how elements relate in the current implementation. | 17:00 |
| Zara | I suspect things may not be nested atm; that is, if you subscribe to a project group, the dashboard (etc) updates when its title or description is changed, but not when a project within the group is changed. | 17:03 |
| Zara | but could be wrong on that. looks like 'find out how far things are nested currently' would be a useful early task on the roadmap for notifications, anyway. | 17:04 |
| SotK | Zara: https://git.openstack.org/cgit/openstack-infra/storyboard/tree/storyboard/db/api/subscriptions.py#n67 | 17:06 |
| SotK | IIRC that is how the set of people to create a SubscriptionEvent (notification) for is decided | 17:06 |
| Zara | heh, that's reassuring | 17:08 |
| SotK | what is the "(why is this currently editable at this level?)" asking? | 17:09 |
| Zara | why you can change a task's project on the task page. seemed weird since you couldn't change a story's project on the story's page. | 17:09 |
| SotK | because stories don't have projects :) | 17:10 |
| SotK | since they are supposed to be able to handle a cross-project bug | 17:10 |
| SotK | (or feature) | 17:10 |
| Zara | ah, it's b/c in practice they're filed under projects and can't be made without a task that comes under a project. I'm guessing changing the task's project would automatically change the story's project | 17:11 |
| Zara | but haven't actually tested that. | 17:11 |
| Zara | ah yeah, seems to work, just a bit weird since in practice you can't have a projectless story, but stories aren't meant to have projects. | 17:13 |
| SotK | yep, a story appears in a project iff it contains a task assigned to that project | 17:13 |
| SotK | its more you can't have a projectless task, and can't have a taskless story | 17:13 |
| * SotK agrees its confusing | 17:13 | |
| Zara | yeah, I get it, w | 17:14 |
| Zara | *dw | 17:14 |
| Zara | edited it | 17:15 |
| Zara | haha, the limits of <pre> tags are showing | 17:15 |
| *** b3rnard0 is now known as b3rnard0_away | 17:25 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add a dashboard page for boards and worklists https://review.openstack.org/231973 | 17:36 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add buttons for creating new boards and worklists https://review.openstack.org/231972 | 17:36 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Update $resource wrappers to use new permissions API https://review.openstack.org/235475 | 17:36 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add UI for complex permissions on boards and worklists https://review.openstack.org/235476 | 17:36 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add a page to view a board https://review.openstack.org/231971 | 17:36 |
| pedroalvarez | oh | 17:39 |
| pedroalvarez | what really changed? is it just a rebase? | 17:39 |
| SotK | oops, I should have changed the commit message in one of those | 17:40 |
| SotK | a rebase to fix merge conflicts, plus I changed https://review.openstack.org/231972 to use dropdowns instead of loads of buttons | 17:40 |
| Zara | \o/ | 17:48 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Replace "New Story" button in the top bar with a dropdown menu https://review.openstack.org/231972 | 17:52 |
| Zara | hm, creating a board is weird on my instance | 18:01 |
| SotK | :'( | 18:01 |
| Zara | it might not be anything to do with that patch, actually | 18:01 |
| Zara | I think it's b/c the api endpoint one hasn't been merged and I'm rebasing on master. | 18:02 |
| Zara | will check now... | 18:02 |
| SotK | works fine here | 18:02 |
| Zara | I need to get rid of some git branches; I wonder if api-boards or api-endpoint-boards was the most recent one on my machine... | 18:03 |
| Zara | yeah, works fine now, that was the issue | 18:04 |
| * SotK is glad | 18:04 | |
| SotK | I also have a tangle of branches and was worried I'd messed something up in the rebase | 18:04 |
| Zara | glad it wasn't that :) | 18:06 |
| * pedroalvarez ponders adding some variables to the ansible role so that is easier to test these patches | 18:06 | |
| pedroalvarez | storyboard_api_changeid | 18:07 |
| pedroalvarez | idk | 18:07 |
| pedroalvarez | so you `vagrant up` and you are in your testing environment :) | 18:08 |
| SotK | sounds like it would be pretty handy | 18:11 |
| persia | +1 | 18:21 |
| Zara | weird, why is api endpoint for boards behaving differently | 18:28 |
| SotK | what is it doing? | 18:28 |
| Zara | Jenkins has submitted this change and it FAILED to merge. | 18:28 |
| Zara | Change subject: Add an API endpoint for boards | 18:28 |
| Zara | ...................................................................... | 18:28 |
| Zara | The change requires a local merge to resolve. | 18:28 |
| Zara | Please merge (or rebase) the change locally and upload the resolution for review. | 18:28 |
| Zara | this is after jenkins said it was fine | 18:29 |
| SotK | o.O | 18:29 |
| * SotK rebases | 18:29 | |
| Zara | I have ticks from jenkins on my screen, oh well | 18:29 |
| *** b3rnard0_away is now known as b3rnard0 | 18:40 | |
| Zara | I like that it put FAILED in allcaps | 18:43 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Add an API endpoint for boards https://review.openstack.org/222268 | 18:49 |
| * SotK tries again | 18:50 | |
| SotK | https://storyboard.openstack.org/#!/story/2000430 is definitely because we cache GETs by default | 19:00 |
| SotK | It is fixed inadvertently by https://review.openstack.org/235476 | 19:01 |
| openstackgerrit | Merged openstack-infra/storyboard: Add an API endpoint for boards https://review.openstack.org/222268 | 19:06 |
| SotK | \o/ | 19:07 |
| SotK | fun fact: there was no merge conflict | 19:07 |
| SotK | more merge conflicts now, yay | 19:07 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Implement complex permissions for worklists and boards https://review.openstack.org/235472 | 19:09 |
| Zara | ack | 19:14 |
| SotK | I also am wanting more and more to encode the search filters on list pages in the url | 19:16 |
| SotK | there is no way to currently refresh a search | 19:17 |
| * SotK wonders if anyone actually uses https://storyboard.openstack.org/#!/search | 19:21 | |
| persia | SotK: I think some people try, because of the large button on the left. It seems pointlessly duplicate to the search on top, or the search on any of the detail pages. | 20:42 |
| persia | s/detail/list/ | 20:42 |
| SotK | I was writing a thing to try to figure out the differences between the 3 different search places earlier, but didn't put it anywhere before I left the office :) | 21:08 |
| SotK | https://storyboard.openstack.org/#!/search seems to be a combination of the various list pages (eg stories/projects) | 21:08 |
| SotK | and the top search doesn't allow "filtering with criteria", instead it just shows the top 5 matches for each of stories, projects, and project groups based on the string you are typing | 21:09 |
| SotK | then the search bars on the list pages just show results for the thing they list, and also allow criteria to set up a filtered list | 21:10 |
| SotK | however, there is no way to share those criteria easily, so its not as useful as it could be | 21:10 |
| *** openstackgerrit has quit IRC | 21:36 | |
| *** openstackgerrit has joined #storyboard | 21:37 | |
| persia | It is good to expose functionality, but only insofar as the result does not confuse the user. | 22:30 |
| persia | I realise that isn't actually that helpful, but I offer it mostly in the hopes that someone with an eye towards UX can come up with a sensible representation :) | 22:31 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!