| *** openstackgerrit has quit IRC | 06:23 | |
| *** openstackgerrit has joined #storyboard | 06:39 | |
| *** coolsvap has quit IRC | 07:39 | |
| *** coolsvap has joined #storyboard | 07:47 | |
| *** wuhg has joined #storyboard | 07:48 | |
| *** ttx_ is now known as ttx | 08:07 | |
| *** NikitaKonovalov has quit IRC | 08:16 | |
| *** NikitaKonovalov has joined #storyboard | 08:20 | |
| *** NikitaKonovalov2 has joined #storyboard | 08:28 | |
| *** NikitaKo- has joined #storyboard | 08:37 | |
| *** ttx_ has joined #storyboard | 08:40 | |
| *** ttx has quit IRC | 08:41 | |
| *** NikitaKonovalov has quit IRC | 08:41 | |
| *** NikitaKo- is now known as NikitaKonovalov | 08:41 | |
| *** NikitaKonovalov2 has quit IRC | 08:42 | |
| *** ttx_ is now known as ttx | 08:42 | |
| *** NikitaKonovalov2 has joined #storyboard | 08:59 | |
| *** ttx has quit IRC | 09:02 | |
| *** NikitaKonovalov has quit IRC | 09:02 | |
| *** coolsvap has quit IRC | 09:02 | |
| *** openstackgerrit has quit IRC | 09:02 | |
| *** NikitaKonovalov2 is now known as NikitaKonovalov | 09:03 | |
| *** NikitaKonovalov has quit IRC | 09:10 | |
| *** ttx has joined #storyboard | 09:12 | |
| *** coolsvap has joined #storyboard | 09:12 | |
| *** NikitaKonovalov has joined #storyboard | 09:19 | |
| *** b3rnard0- has quit IRC | 09:23 | |
| *** openstackgerrit has joined #storyboard | 09:26 | |
| *** b3rnard0 has joined #storyboard | 09:26 | |
| *** NikitaKonovalov has quit IRC | 09:33 | |
| *** ttx has quit IRC | 09:33 | |
| *** coolsvap has quit IRC | 09:33 | |
| *** ttx has joined #storyboard | 09:34 | |
| *** coolsvap has joined #storyboard | 09:34 | |
| *** NikitaKonovalov has joined #storyboard | 09:45 | |
| *** NikitaKonovalov has quit IRC | 09:55 | |
| *** NikitaKonovalov has joined #storyboard | 10:06 | |
| *** b3rnard0 has quit IRC | 10:18 | |
| Zara | SotK_: ah, okay, thanks for explaining! | 10:18 |
|---|---|---|
| *** davidlenwell_ has quit IRC | 10:20 | |
| *** davidlenwell has joined #storyboard | 10:20 | |
| *** b3rnard0 has joined #storyboard | 10:24 | |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Replace "New Story" button in the top bar with a dropdown menu https://review.openstack.org/231972 | 10:29 |
| SotK | \o/ | 10:29 |
| *** NikitaKonovalov2 has joined #storyboard | 10:32 | |
| *** NikitaKonovalov has quit IRC | 10:34 | |
| *** ttx has quit IRC | 10:34 | |
| *** coolsvap has quit IRC | 10:34 | |
| *** NikitaKonovalov2 is now known as NikitaKonovalov | 10:34 | |
| *** coolsvap- has joined #storyboard | 10:34 | |
| pedroalvarez | nice | 10:41 |
| * pedroalvarez upgrades his storyboard instance | 10:41 | |
| SotK | now we just need https://review.openstack.org/#/c/231973/ and everything for single-user worklists/boards will be merged :D | 10:41 |
| *** ttx has joined #storyboard | 10:42 | |
| *** ttx has quit IRC | 10:45 | |
| paulsherwood | 400: POST /api/v1/openid/token?grant_type=refresh_token&refresh_token=p7jUlG3vRqZe0sutQqx8BMLpeFu1XW: No error details available. | 10:46 |
| paulsherwood | when visiting https://storyboard.openstack.org/#!/ | 10:46 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Fix top-right search for project groups https://review.openstack.org/250465 | 10:46 |
| *** ttx has joined #storyboard | 10:46 | |
| SotK | paulsherwood: does it happen if you try again? | 10:47 |
| paulsherwood | SotK: no | 10:48 |
| Zara | I suspected it related to: https://storyboard.openstack.org/#!/story/2000407 , though odd that it's a 400 and not a 401 | 10:51 |
| Zara | story needs updating; I think we got to the bottom of that yesterday, and it involves patching puppet? | 10:52 |
| SotK | I've seen that api call break when my token expires before now I think | 10:52 |
| paulsherwood | cna't reproduce now, anyway | 10:52 |
| SotK | no way to be sure without access to the production logs | 10:52 |
| paulsherwood | ghost in the macchine? :) | 10:52 |
| SotK | paulsherwood: if it comes back in about an hour, it's definitely the issue Zara linked | 10:52 |
| SotK | Zara: FSVO bottom, yes | 10:53 |
| paulsherwood | ok i'll try, if i remember (or someone pings me) | 10:53 |
| SotK | increasing the lifetime of the tokens will make it less annoying for sure | 10:53 |
| Zara | paulsherwood: if you look at your list of authentication tokens (in 'profile' on the sidebar, then the key icon on the submenu), it should tell you when the last one expired/when the current one was generated | 10:54 |
| SotK | but really we should implement the request caching stuff mentioned in https://storyboard.openstack.org/#!/story/36 | 10:55 |
| Zara | (if you're not logged in then those icons won't be there, but otherwise there might be some information) | 10:55 |
| Zara | yeah | 10:55 |
| Zara | ooh, recent events are displaying properly on my dashboard now | 10:55 |
| Zara | nice, thanks | 10:55 |
| SotK | what does properly mean? :D | 10:56 |
| *** b3rnard0 has quit IRC | 10:58 | |
| Zara | they seem to be displaying for stories other than ones I've created. Maybe the timing was just luck, but it seems like it's picking up on more of them. | 10:58 |
| SotK | do you have one for the comment I just left on https://storyboard.openstack.org/#!/story/2000402 ? | 11:00 |
| * SotK realises Zara might not be subscribed to that | 11:00 | |
| SotK | I still think we should autosubscribe people to stories they create | 11:01 |
| paulsherwood | +1 | 11:01 |
| Zara | SotK: I wasn't subscribed to it; feel free to comment again. :) | 11:01 |
| *** b3rnard0 has joined #storyboard | 11:02 | |
| * SotK comments | 11:03 | |
| Zara | nothing's showing up :/ | 11:04 |
| SotK | :( | 11:04 |
| Zara | I have one for a story creation for jjb, which I think is because I'm subscribed to the project group | 11:09 |
| Zara | and one for a task creation in one of my stories | 11:10 |
| *** b3rnard0 has quit IRC | 11:10 | |
| pedroalvarez | doh: "400: POST /api/v1/worklists: Unknown attribute for argument worklist: editing" | 11:15 |
| SotK | heh, is that with newer wsme? | 11:15 |
| pedroalvarez | I guess is the same kind of issue yes | 11:16 |
| *** b3rnard0 has joined #storyboard | 11:17 | |
| pedroalvarez | It does work with older wsme, yes | 11:18 |
| Zara | have looked at my weird drag and drop issues with worklists in another browser-- everything works as expected in chrome. in iceweasel, it's usable, but a bit odd. | 11:18 |
| Zara | (a bit odd= you have to start dragging, then let go of mouse button, then click to drop. though drag and drop works on occasion. 'click, release, click' without any dragging won't work, as worklist item then acts as a link to the story or task.) | 11:22 |
| Zara | in chrome, drag and drop just works. | 11:22 |
| * pedroalvarez opens iceweasel | 11:23 | |
| *** ttx has quit IRC | 11:24 | |
| *** coolsvap- has quit IRC | 11:25 | |
| *** NikitaKonovalov has quit IRC | 11:25 | |
| Zara | hopefully, we'll all have different experiences, just to make it exciting. | 11:25 |
| SotK | it worked fine in iceweasel for me fwiw | 11:26 |
| SotK | although it highlighted bits when I dragged | 11:26 |
| pedroalvarez | worked fine here too | 11:26 |
| pedroalvarez | oh, worklists | 11:27 |
| pedroalvarez | I was testing boards | 11:27 |
| SotK | oh, me too | 11:27 |
| SotK | I have the clicky issue on worklists | 11:28 |
| SotK | :( | 11:28 |
| pedroalvarez | me too | 11:28 |
| pedroalvarez | sometimes it works nice | 11:28 |
| pedroalvarez | sometimes you have to click again | 11:29 |
| SotK | oh, iceweasel is trying to drag the link I think | 11:29 |
| SotK | happens in boards too if you drag the link part | 11:30 |
| Zara | \o/ | 11:35 |
| SotK | I wonder how many other browsers attempt to drag links like that | 11:35 |
| *** ttx has joined #storyboard | 11:36 | |
| pedroalvarez | any solution in mind? | 11:36 |
| * SotK is investigating to see if he can disable the dragging behaviour somehow | 11:36 | |
| pedroalvarez | new button showing up in storyboard.openstack.org :) | 11:37 |
| Zara | I'm curious about the reasons for it; presumably it suits someone's workflow somewhere. is it so you can open a link in a different, existing window or something? | 11:37 |
| Zara | or just a bug :P | 11:38 |
| Zara | this https://review.openstack.org/#/c/231973/ still seems to depend on an outdated version of a patch | 11:38 |
| pedroalvarez | I was wondering if only allowing drag and drop when clicking on the icon would be a good idea | 11:38 |
| SotK | Zara: yeah, its so you can drag the link to somewhere I think (eg a new tab or window) | 11:39 |
| SotK | Chrome does it too, but in a way that doesn't break everything | 11:39 |
| SotK | pedroalvarez: I did it like that at first, but it was unintuitive and annoying (especially on mobile) | 11:39 |
| Zara | pedroalvarez: iirc we tried that earlier and there were issues with it. | 11:39 |
| Zara | snap | 11:39 |
| pedroalvarez | good we know why not :) | 11:40 |
| Zara | now we all just have to patch iceweasel and everything'll be fiiiiiine... | 11:43 |
| *** cody-somerville has quit IRC | 11:43 | |
| *** cody-somerville- has quit IRC | 11:43 | |
| *** dabukalam has quit IRC | 11:43 | |
| *** betherly has quit IRC | 11:43 | |
| *** jjardon has quit IRC | 11:43 | |
| pedroalvarez | hahah, it might be possible to do it in our codebase :) | 11:44 |
| Zara | (what's up with all the netsplitting today) would be good, though I'm guessing the angularjs codebase would turn out to be the place to fix it. | 11:47 |
| Zara | or maybe the modules we import | 11:47 |
| * SotK suspects it might need a patch to ng-sortable, but isn't sure | 11:47 | |
| Zara | yeah | 11:47 |
| *** cody-somerville has joined #storyboard | 11:48 | |
| *** betherly has joined #storyboard | 11:48 | |
| *** jjardon has joined #storyboard | 11:48 | |
| Zara | I doubt it's anything storyboard-specific, though it'd be great if there were just some config option | 11:48 |
| pedroalvarez | I found this http://stackoverflow.com/questions/3873595/how-to-disable-firefoxs-default-drag-and-drop-on-all-images-behavior-with-jquer | 11:50 |
| pedroalvarez | but from there to our solution ... might not be easy, at least for me | 11:51 |
| Zara | at a glance, it starts off with jquery stuff, but there's stuff that looks more relevant to us farther down. | 11:51 |
| Zara | that suggests it's just a question of adding an attribute 'onmousedown=false' to the relevant tags | 11:52 |
| Zara | but that's witchcraft to me | 11:53 |
| Zara | quick to code, if it works | 11:53 |
| * SotK worries that might break the dragging we want too | 11:53 | |
| SotK | I'm going to see if event.preventDefault() works | 11:53 |
| Zara | ah, yeah, assuming the name of the attribute means 'the user hasn't clicked', I assume it'd stop all dragging | 11:54 |
| Zara | or just 'don't do anything when the user clicks' | 11:54 |
| Zara | if only there were a 'onmousedown=stopbeingannoying' | 11:55 |
| SotK | grr, doing event.preventDefault() in the drag callbacks doesn't help | 11:59 |
| SotK | adding an event listener to do it worked though \o/ | 12:04 |
| * SotK prepares a patch | 12:04 | |
| Zara | SotKman, SotKman, does whatever a SotKman can~ | 12:05 |
| * pedroalvarez is ready to test :) | 12:07 | |
| SotK | that's also fixed the highlighting of half the page | 12:07 |
| pedroalvarez | :D | 12:09 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Fix confusing drag behaviour on some browsers https://review.openstack.org/250771 | 12:10 |
| *** cody-somerville- has joined #storyboard | 12:11 | |
| *** coolsvap has joined #storyboard | 12:11 | |
| *** dabukalam has joined #storyboard | 12:12 | |
| *** NikitaKonovalov has joined #storyboard | 12:12 | |
| *** wuhg has quit IRC | 12:15 | |
| pedroalvarez | that just works | 12:22 |
| pedroalvarez | :) | 12:22 |
| Zara | it seems a bit weird for an angular thing to be accessing the document directly | 12:30 |
| *** wuhg has joined #storyboard | 12:30 | |
| *** coolsvap has quit IRC | 12:38 | |
| *** NikitaKonovalov has quit IRC | 12:39 | |
| *** dabukalam has quit IRC | 12:40 | |
| *** cody-somerville- has quit IRC | 12:40 | |
| *** cody-somerville- has joined #storyboard | 12:40 | |
| *** dabukalam has joined #storyboard | 12:42 | |
| *** coolsvap has joined #storyboard | 12:44 | |
| *** NikitaKonovalov has joined #storyboard | 12:44 | |
| SotK | so, it seems angular's $document doesn't expose enough functionality to add an event listener | 12:50 |
| * SotK tries a different thing | 12:51 | |
| SotK | ok, got it working using $document now :) | 12:54 |
| * SotK resends | 12:54 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Fix confusing drag behaviour on some browsers https://review.openstack.org/250771 | 12:59 |
| *** wuhg has quit IRC | 13:00 | |
| * pedroalvarez tests | 13:00 | |
| pedroalvarez | does that solution look better to you Zara? | 13:00 |
| *** wuhg has joined #storyboard | 13:06 | |
| Zara | sorry, wasn't looking at this tab! | 13:09 |
| Zara | will test now | 13:09 |
| Zara | hmmm, function (e) -- does that have to be one letter? | 13:14 |
| Zara | it does solve the issue, so if 'e' can be replaced with something more informative, or if there's a reason it has to be 'e', I'm ready to merge it. | 13:19 |
| * pedroalvarez likes Zara's reviews | 13:23 | |
| Zara | :) most of my review comments seem to end up on irc, so on gerrit it always looks like I just +2 everything right away | 13:32 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Fix confusing drag behaviour on some browsers https://review.openstack.org/250771 | 13:42 |
| SotK | there :P | 13:42 |
| *** wuhg has quit IRC | 14:01 | |
| pedroalvarez | Zara: I agree that IRC reviews are more friendly, but it might be good to note those comments on gerrit as well. | 14:01 |
| Zara | yeah, whether they end up on gerrit tends to depend on whether the patch gets fixed too fast for me to copy them up xD | 14:25 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Fix confusing drag behaviour on some browsers https://review.openstack.org/250771 | 14:26 |
| *** ttx has quit IRC | 14:27 | |
| *** ttx has joined #storyboard | 14:48 | |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Link to the relevant story in comment notifications https://review.openstack.org/249273 | 15:00 |
| *** thrace has quit IRC | 15:27 | |
| *** thrace has joined #storyboard | 15:29 | |
| Zara | have we heard anything further from anyone about the email patches? | 15:52 |
| SotK | nope | 15:52 |
| * SotK hasn't seen jeblair around | 15:52 | |
| Zara | ah, okay. :S | 15:53 |
| *** cody-somerville has quit IRC | 15:55 | |
| *** cody-somerville has joined #storyboard | 16:08 | |
| *** cody-somerville has quit IRC | 16:46 | |
| *** ttx has quit IRC | 16:46 | |
| * pedroalvarez suggests SotK to upgrade WSME on his instance :) | 16:53 | |
| *** cody-somerville has joined #storyboard | 16:54 | |
| * SotK is using whatever tox is deciding to install | 16:54 | |
| SotK | how many broken bits are there? :/ | 16:54 |
| pedroalvarez | just the one I pointed out before I think | 16:54 |
| pedroalvarez | but I think it might be good for you tou use the restrictive version of wsme | 16:54 |
| pedroalvarez | or at least, limit WSME version in the requirements | 16:55 |
| *** ttx has joined #storyboard | 16:56 | |
| SotK | yeah, it would make sense I think | 16:56 |
| Zara | yeah, we should at least be using whatever storyboard.openstack.org will be using, since that's the biggest consumer of storyboard. | 16:56 |
| pedroalvarez | note that if storyboard.openstack.org is re-deployed, it will be a bit broken | 17:00 |
| Zara | yeah, we don't want that. :( | 17:00 |
| *** cody-somerville has quit IRC | 17:27 | |
| *** cody-somerville has joined #storyboard | 17:31 | |
| SotK | should we enforce <0.8, or >=0.8 and make sure it always works with that? | 17:50 |
| Zara | maybe <0.8 until we upgrade our own wsmes and fix things? | 17:50 |
| Zara | then make it >=0.8 after that | 17:51 |
| SotK | that sounds like the most sensible plan to me too | 17:51 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Limit WSME to <0.8 https://review.openstack.org/250920 | 17:56 |
| *** cody-somerville has quit IRC | 18:00 | |
| *** cody-somerville has joined #storyboard | 18:02 | |
| *** cody-somerville has quit IRC | 18:07 | |
| *** cody-somerville has joined #storyboard | 18:20 | |
| pedroalvarez | reviewed | 18:34 |
| Zara | \o/ | 18:35 |
| openstackgerrit | Merged openstack-infra/storyboard: Limit WSME to <0.8 https://review.openstack.org/250920 | 18:42 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!