| *** kopecmartin has joined #refstack | 05:51 | |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: [DNM] Test --create-accounts-file argument https://review.openstack.org/572695 | 05:58 |
|---|---|---|
| *** lifeless has quit IRC | 06:26 | |
| *** lifeless has joined #refstack | 06:26 | |
| *** tosky has joined #refstack | 06:40 | |
| *** lifeless_ has joined #refstack | 06:48 | |
| *** lifeless has quit IRC | 06:48 | |
| openstackgerrit | Chandan Kumar proposed openstack/refstack-client master: Generate tempest.conf automatically using refstack-client https://review.openstack.org/541273 | 07:31 |
| *** lifeless has joined #refstack | 07:52 | |
| *** lifeless_ has quit IRC | 07:52 | |
| arxcruz|brb | tosky: around? do you mind https://review.openstack.org/#/c/574691/ ? | 07:56 |
| *** arxcruz|brb is now known as arxcruz|ruck | 07:59 | |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: [DNM] Test --create-accounts-file argument https://review.openstack.org/572695 | 08:33 |
| arxcruz|ruck | kopecmartin: https://review.openstack.org/#/c/574691/ | 08:35 |
| kopecmartin | arxcruz|ruck, it's already workflowed if you meant that | 08:36 |
| arxcruz|ruck | oh, tosky +2 didn't saw it :) | 08:37 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Use healthcheck api to determine swift service https://review.openstack.org/568869 | 09:00 |
| chandankumar | arxcruz|ruck: I have updated the patchset based on tosky comment, removed default conf setting | 09:09 |
| arxcruz|ruck | chandankumar: yeah, just notice that when i finish my comments | 09:09 |
| arxcruz|ruck | chandankumar: what's the difference between get_service and check_service_status ? | 09:10 |
| chandankumar | arxcruz|ruck: get_service returns the class name assoiated with a service, check_service_status will check the status of service based on some logic | 09:12 |
| arxcruz|ruck | chandankumar: so, check_service_status has the same functionality as is_service ? | 09:13 |
| chandankumar | arxcruz|ruck: is_service [service available or not ] depends on get_service -> which depends on discover -> which set the status of sevice based on service catalog list | 09:16 |
| chandankumar | arxcruz|ruck: check_service_status goes one step ahead ,if a service is in catalog list, it will some more operation to confirm whether service is actually available or not | 09:17 |
| arxcruz|ruck | chandankumar: so, the service is only in catalog list if is available no ? | 09:18 |
| arxcruz|ruck | just trying to understand be patient | 09:18 |
| chandankumar | arxcruz|ruck: yup | 09:19 |
| arxcruz|ruck | chandankumar: so, if is there only if is available, what's the point of check_service_status? | 09:19 |
| chandankumar | arxcruz|ruck: for swift case, if swift is listed in catalog list, but the system does not have swift functionaliyt because of ceph or other backend, that time swift is set to true from is_service which leds to failures of swift tests, so here check_service_status use healthcheck api to determine the swift status | 09:22 |
| tosky | uhm, is_service is defined centrally in Services and its behavior can't be redefined | 09:22 |
| chandankumar | in future, if check_service_status can be used for other componenet to add similar behaviour if needed | 09:22 |
| tosky | or make it general | 09:23 |
| chandankumar | yup make it general | 09:23 |
| arxcruz|ruck | chandankumar: okay, so, an action item is implement it in other services, and 'deprecate' is_service | 09:23 |
| tosky | one solution could be: not use is_service, but check_service_status for the specific service, which by default uses is_service but it can be redefined | 09:23 |
| arxcruz|ruck | or as tosky said, make it general | 09:23 |
| chandankumar | then we can carry few more if else | 09:23 |
| tosky | is_service could be still useful because it access internal structures of Services; unless the new method can be refactored to easily gets those data | 09:24 |
| chandankumar | sure | 09:24 |
| tosky | do you mean that we will have more if/else, or that we can kill more of them? | 09:24 |
| arxcruz|ruck | also, we should consider pass the self._conf for the services class | 09:24 |
| arxcruz|ruck | we are passing it through several functions already | 09:24 |
| tosky | in the constructor? | 09:25 |
| arxcruz|ruck | tosky: yup | 09:25 |
| arxcruz|ruck | check_service_status is getting it | 09:25 |
| arxcruz|ruck | tempest_default_settings also | 09:25 |
| arxcruz|ruck | anything in the services class that requires to access the conf, we are passing as argument | 09:25 |
| arxcruz|ruck | so maybe is better to pass in the constructor no? | 09:26 |
| tosky | generally yes; unless we can identify a subset the configuration that's really needed and pass only that, but yeah | 09:27 |
| openstackgerrit | Nir Magnezi proposed openstack/python-tempestconf master: Configure tempest for Octavia tests https://review.openstack.org/571177 | 09:27 |
| openstackgerrit | Nir Magnezi proposed openstack/python-tempestconf master: Configure tempest for Octavia tests https://review.openstack.org/571177 | 09:33 |
| *** lifeless_ has joined #refstack | 09:34 | |
| *** lifeless has quit IRC | 09:34 | |
| *** lifeless has joined #refstack | 09:44 | |
| *** lifeless_ has quit IRC | 09:46 | |
| tosky | chandankumar: do you want to try to add -W to https://review.rdoproject.org/r/#/c/14199/? Otherwise it's time to merge it as in ~1 hour the doc change could land | 09:59 |
| openstackgerrit | Nir Magnezi proposed openstack/python-tempestconf master: DNM: Test Octavia https://review.openstack.org/575063 | 09:59 |
| openstackgerrit | Nir Magnezi proposed openstack/python-tempestconf master: DNM: Test Octavia https://review.openstack.org/575063 | 10:02 |
| openstackgerrit | Merged openstack/python-tempestconf master: Remove admin_* from identity section https://review.openstack.org/573022 | 10:05 |
| chandankumar | tosky: sure | 10:05 |
| chandankumar | arxcruz|ruck: tosky passing self._conf to service class require some big change in component service class? | 10:07 |
| chandankumar | arxcruz|ruck: tosky regarding octavia patch https://review.openstack.org/#/c/571177/10/config_tempest/services/octavia.py@24 | 10:07 |
| chandankumar | i have some concerns, I think it would be good to add some code to check whether roles are present or not before setting it | 10:08 |
| tosky | but not in that code | 10:08 |
| chandankumar | otherwise we will generate the config, but if those things were not present tests will fail and in the end peiple will blame tempestconf is not working properly | 10:09 |
| tosky | chandankumar: then ping nmagnezi or add -1 | 10:09 |
| openstackgerrit | Chandan Kumar proposed openstack/refstack-client master: Generate tempest.conf automatically using refstack-client https://review.openstack.org/541273 | 10:13 |
| openstackgerrit | Luigi Toscano proposed openstack/python-tempestconf master: More compatibility with Python 3 https://review.openstack.org/574773 | 10:19 |
| *** lifeless has quit IRC | 10:23 | |
| *** lifeless has joined #refstack | 10:24 | |
| *** lifeless_ has joined #refstack | 10:32 | |
| *** lifeless has quit IRC | 10:32 | |
| tosky | chandankumar: oh, I didn't explain it properly: in https://review.rdoproject.org/r/#/c/14199/ I meant to add -W to the call of sphinx-build (see my comment) | 10:34 |
| tosky | not -w vote | 10:34 |
| chandankumar | tosky: sorry | 10:34 |
| chandankumar | tosky: I will update that | 10:34 |
| chandankumar | so many things going on right now | 10:34 |
| tosky | I did not realize that -W had a different meaning there >.< | 10:35 |
| openstackgerrit | Merged openstack/python-tempestconf master: Fix identity service url for v3 https://review.openstack.org/574691 | 10:56 |
| openstackgerrit | Merged openstack/python-tempestconf master: Allow non admin users to upload image to glance https://review.openstack.org/568252 | 10:56 |
| openstackgerrit | Merged openstack/python-tempestconf master: Switch to openstackdocstheme (doc and release notes) https://review.openstack.org/573795 | 10:56 |
| tosky | chandankumar: so now it's the time to update that review, or we will get the failures from rdo | 10:59 |
| arxcruz|ruck | chandankumar: octavia requires specific roles? | 11:03 |
| openstackgerrit | Luigi Toscano proposed openstack/python-tempestconf master: More compatibility with Python 3 https://review.openstack.org/574773 | 11:07 |
| arxcruz|ruck | chandankumar: why -w the octavia patch? should a -1 work :) | 11:08 |
| *** rmart04 has joined #refstack | 11:17 | |
| *** lifeless_ has quit IRC | 11:42 | |
| *** lifeless has joined #refstack | 11:42 | |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Use healthcheck api to determine swift service https://review.openstack.org/568869 | 12:12 |
| chandankumar | arxcruz|ruck: tosky I have updated as per suggested changes on healthcheck apo | 12:12 |
| arxcruz|ruck | chandankumar: and you have my -1 my friend :) | 12:17 |
| openstackgerrit | Chandan Kumar proposed openstack/refstack-client master: Generate tempest.conf automatically using refstack-client https://review.openstack.org/541273 | 12:20 |
| arxcruz|ruck | kopecmartin: around ? meeting | 13:07 |
| chandankumar | arxcruz|ruck: He is out, he want to give school exam | 13:12 |
| *** kopecmartin has quit IRC | 13:34 | |
| openstackgerrit | Luigi Toscano proposed openstack/python-tempestconf master: More compatibility with Python 3 https://review.openstack.org/574773 | 13:45 |
| *** kopecmartin has joined #refstack | 14:45 | |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: [DNM] Test --create-accounts-file argument https://review.openstack.org/572695 | 14:57 |
| tosky | so I guess that "Class[Gnocchi::Api]: has no parameter named 'host'" while running packstack is not an issue on our side, right? | 15:24 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Use healthcheck api to determine swift service https://review.openstack.org/568869 | 15:29 |
| *** lifeless has quit IRC | 15:31 | |
| *** lifeless has joined #refstack | 15:31 | |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Use healthcheck api to determine swift service https://review.openstack.org/568869 | 15:31 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Remove default-overrides.conf https://review.openstack.org/572418 | 15:31 |
| *** arxcruz|ruck is now known as arxcruz | 16:01 | |
| *** kopecmartin has quit IRC | 16:17 | |
| *** rmart04 has quit IRC | 16:20 | |
| *** openstackgerrit has quit IRC | 18:04 | |
| *** openstackgerrit has joined #refstack | 18:55 | |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: [DNM] Test --create-accounts-file argument https://review.openstack.org/572695 | 18:55 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Fix username is not defined warning https://review.openstack.org/575204 | 19:14 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Remove deprecated configuration of boto https://review.openstack.org/575213 | 19:44 |
| openstackgerrit | Nir Magnezi proposed openstack/python-tempestconf master: Configure tempest for Octavia tests https://review.openstack.org/571177 | 19:49 |
| *** lifeless_ has joined #refstack | 19:49 | |
| *** lifeless has quit IRC | 19:49 | |
| openstackgerrit | Nir Magnezi proposed openstack/python-tempestconf master: DNM: Test Octavia https://review.openstack.org/575063 | 20:55 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: WIP: Replace tenant by project, part 2 https://review.openstack.org/575233 | 21:02 |
| *** openstackgerrit has quit IRC | 21:04 | |
| *** openstackgerrit has joined #refstack | 21:05 | |
| openstackgerrit | megan guiney proposed openstack/refstack master: WIP Migrating from bower to yarn https://review.openstack.org/573404 | 21:05 |
| *** lifeless_ has quit IRC | 21:23 | |
| *** lifeless has joined #refstack | 21:24 | |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Fix boto method https://review.openstack.org/575213 | 21:31 |
| *** lifeless_ has joined #refstack | 21:36 | |
| *** lifeless has quit IRC | 21:37 | |
| openstackgerrit | megan guiney proposed openstack/refstack master: Migrating from bower to yarn https://review.openstack.org/573404 | 23:25 |
| *** tosky has quit IRC | 23:51 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!