| *** lifeless has quit IRC | 00:09 | |
| *** lifeless has joined #refstack | 01:41 | |
| openstackgerrit | megan guiney proposed openstack/refstack master: WIP Migrating from bower to yarn https://review.openstack.org/573404 | 01:49 |
|---|---|---|
| *** lifeless has quit IRC | 02:32 | |
| *** lifeless has joined #refstack | 02:33 | |
| openstackgerrit | qingszhao proposed openstack/python-tempestconf master: fix tox python3 overrides https://review.openstack.org/574556 | 05:40 |
| *** tosky has joined #refstack | 07:07 | |
| chandankumar | tosky: Good morning | 07:08 |
| chandankumar | tosky: please have a look at the last comment on healthcheck api patch, I am little lost on that | 07:08 |
| chandankumar | thanks :-) | 07:08 |
| *** kopecmartin has joined #refstack | 07:12 | |
| *** lifeless has quit IRC | 07:39 | |
| *** lifeless has joined #refstack | 07:39 | |
| tosky | chandankumar: answered (sorry, a bit late) | 09:53 |
| tosky | chandankumar: different question: when you were talking about python 3 jobs yesterday, did you mean devstack jobs or simply unit tests? | 09:54 |
| *** lifeless has quit IRC | 09:59 | |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Fix identity service url for v3 https://review.openstack.org/574691 | 10:43 |
| chandankumar | arxcruz|ruck: ^^ | 10:43 |
| arxcruz|ruck | chandankumar: add closes-bug | 10:45 |
| arxcruz|ruck | or related-bug | 10:45 |
| chandankumar | arxcruz|ruck: ack | 10:48 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Fix identity service url for v3 https://review.openstack.org/574691 | 10:48 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Fix identity service url for v3 https://review.openstack.org/574691 | 10:51 |
| chandankumar | tosky: https://review.openstack.org/#/c/568252/ | 10:57 |
| chandankumar | please havea look at this one | 10:57 |
| *** lifeless has joined #refstack | 11:03 | |
| *** lifeless has quit IRC | 11:13 | |
| *** lifeless has joined #refstack | 11:13 | |
| chandankumar | arxcruz|ruck: I also need your views on that also https://review.openstack.org/#/c/568869/ so I will update the next patch set together | 11:46 |
| arxcruz|ruck | chandankumar: -1 from tosky and zuul, i only review when i get at least +1 from zuul, I already set this rule on my gmail :) | 11:54 |
| chandankumar | arxcruz|ruck: but it is a complicated one | 11:55 |
| arxcruz|ruck | chandankumar: one more reason to wait zuul+1 :D | 11:55 |
| tosky | arxcruz|ruck: no, this is one of those cases where you can save a roundtrip | 12:08 |
| tosky | arxcruz|ruck: so please review it, because it's a matter of architectural changes, and it would be useless to fix some stuff to pass the gates and then redo everything | 12:09 |
| tosky | chandankumar: in general, unless you want an immediate review because you need to merge it immediately or you have some specific questions, no need to ping me for each review | 12:09 |
| tosky | I get notified | 12:09 |
| arxcruz|ruck | tosky: how do you get notified ? | 12:10 |
| tosky | arxcruz|ruck: subscribed, email | 12:10 |
| tosky | chandankumar, arxcruz|ruck: are you sure that https://review.openstack.org/#/c/568252/ will work in all cases and with older versions? | 12:11 |
| tosky | we went through many reviews were v3 was present or not | 12:11 |
| arxcruz|ruck | tosky: so, if i wrote a patch, you will be notified even if i don't add you as reviewer ? | 12:11 |
| tosky | arxcruz|ruck: I'm subscribed for all patches in the project | 12:11 |
| tosky | forcibly adding /v3 at the end may not work with older versions of keystone | 12:11 |
| arxcruz|ruck | tosky: older versions has /v2 | 12:12 |
| chandankumar | arxcruz|ruck: /v3 stuff broke devstack http://logs.openstack.org/91/574691/3/check/python-tempestconf-tempest-devstack-admin/369e943/job-output.txt.gz#_2018-06-12_11_22_29_371775 | 12:12 |
| chandankumar | tosky: yes from my side | 12:12 |
| tosky | arxcruz|ruck: I remember that we had to rollback the addition of /v3 | 12:12 |
| chandankumar | for image patch | 12:12 |
| tosky | because it was breaking, because the endpoint for v3 has no /v3 | 12:12 |
| tosky | now for master it changed again, but... | 12:13 |
| arxcruz|ruck | tosky: there were some changes in keystone | 12:13 |
| tosky | arxcruz|ruck: for *master*, but we need to keep compatibility | 12:13 |
| tosky | so no merge until the RDO CI jobs says that it works | 12:13 |
| arxcruz|ruck | chandankumar: perhaps we should run both | 12:14 |
| arxcruz|ruck | with and without v3 | 12:14 |
| arxcruz|ruck | if we get from / nice, otherwise, try v3 | 12:15 |
| chandankumar | arxcruz|ruck: with or without v3 not getting this part? | 12:16 |
| tosky | yes, most likely | 12:16 |
| arxcruz|ruck | chandankumar: check without the v3 | 12:16 |
| arxcruz|ruck | get an error? try again now with /v3 in the url | 12:16 |
| chandankumar | arxcruz|ruck: you mean in the ci or locally, in locally without v3 in fs30 env, the error is reproduable | 12:17 |
| arxcruz|ruck | chandankumar: in python-tempestconf | 12:17 |
| arxcruz|ruck | do the check twice, one without, and one with the /v3 | 12:18 |
| chandankumar | arxcruz|ruck: got that | 12:18 |
| arxcruz|ruck | if 'v3' not in url: test | 12:19 |
| arxcruz|ruck | fail: url += '/v3' | 12:19 |
| arxcruz|ruck | test again | 12:19 |
| arxcruz|ruck | tosky: do you agree with this approach ? | 12:23 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Fix identity service url for v3 https://review.openstack.org/574691 | 12:26 |
| tosky | yep | 12:26 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: [DNM] without v3 https://review.openstack.org/574710 | 12:27 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Generate accounts.yaml https://review.openstack.org/570781 | 12:51 |
| openstackgerrit | Nir Magnezi proposed openstack/python-tempestconf master: Configure tempest for Octavia tests https://review.openstack.org/571177 | 12:53 |
| openstackgerrit | Nir Magnezi proposed openstack/python-tempestconf master: Configure tempest for Octavia tests https://review.openstack.org/571177 | 12:56 |
| openstackgerrit | Nir Magnezi proposed openstack/python-tempestconf master: Configure tempest for Octavia tests https://review.openstack.org/571177 | 13:16 |
| *** kopecmartin has quit IRC | 13:19 | |
| *** kopecmartin has joined #refstack | 13:20 | |
| openstackgerrit | Nir Magnezi proposed openstack/python-tempestconf master: Configure tempest for Octavia tests https://review.openstack.org/571177 | 13:30 |
| openstackgerrit | Chandan Kumar proposed openstack/refstack-client master: Generate tempest.conf automatically using refstack-client https://review.openstack.org/541273 | 13:36 |
| *** kopecmartin has quit IRC | 13:50 | |
| *** kopecmartin has joined #refstack | 14:02 | |
| *** kopecmartin has quit IRC | 14:07 | |
| *** kopecmartin has joined #refstack | 14:07 | |
| *** kopecmartin has quit IRC | 14:07 | |
| *** kopecmartin has joined #refstack | 14:08 | |
| *** arxcruz|ruck is now known as arxcruz|brb | 14:25 | |
| openstackgerrit | Chandan Kumar proposed openstack/refstack-client master: Generate tempest.conf automatically using refstack-client https://review.openstack.org/541273 | 15:11 |
| openstackgerrit | Luigi Toscano proposed openstack/python-tempestconf master: More compatibility with Python 3 https://review.openstack.org/574773 | 15:25 |
| tosky | aehem | 15:25 |
| tosky | let's try if it works | 15:25 |
| kopecmartin | tosky, did i answer all of the questions here? https://review.openstack.org/#/c/573022/ | 15:29 |
| openstackgerrit | Luigi Toscano proposed openstack/python-tempestconf master: More compatibility with Python 3 https://review.openstack.org/574773 | 15:29 |
| tosky | kopecmartin: oh, right, yes | 15:30 |
| kopecmartin | so no more changes needed? | 15:30 |
| tosky | I'm not going to block it for "other" | 15:32 |
| chandankumar | kopecmartin: https://review.openstack.org/#/c/570781/ -> so nonadmin cannot create accounts.yaml? | 15:32 |
| chandankumar | i thought the idea was anyone can create accounts.yaml if he needs to create | 15:33 |
| kopecmartin | chandankumar, why, if you run the tool with --non-admin, you don't have rights to create resources, what's the point of having an accounts.yaml file with that resources? | 15:34 |
| chandankumar | kopecmartin: but heere we are just dumping the credentials in accounts.yaml file na? | 15:35 |
| kopecmartin | but i don't care about this so much , if you think even non-admin user should be able to create that file, I'll change that, but i don't see the point | 15:36 |
| chandankumar | there is no reource creation happening | 15:36 |
| kopecmartin | yeah, dumping the credentials, but the point of the accounts.yaml is that it holds credentials for creating resources .. | 15:36 |
| tosky | kopecmartin: accounts.yaml is mainly useful for poor users who want to test the cloud as non-admin and share the tempest.conf | 15:36 |
| tosky | kopecmartin: so in that case non-admin users will have their credentials on accounts.yaml, and they will use the resources that are available | 15:36 |
| chandankumar | yup | 15:38 |
| kopecmartin | tosky, fair enough , I'll change that , so that everyone can have their accounts.yaml file | 15:38 |
| kopecmartin | chandankumar, ^^ | 15:38 |
| chandankumar | kopecmartin: yup | 15:38 |
| kopecmartin | but it'd be great if we can move forward this patch https://review.openstack.org/#/c/573022/, i need it in other review :D | 15:38 |
| chandankumar | tosky: can I bring one more tripleo ci job with test stuff from tempest package? tempest container is still not getting updated due to some fishy happening in container check | 15:39 |
| chandankumar | ? | 15:40 |
| tosky | chandankumar: if infra or rdo cloud people are not going to kill us, I can't complain about more tests | 15:40 |
| chandankumar | tosky: ack! | 15:40 |
| chandankumar | kopecmartin: tosky: can we move with image patch also? | 15:41 |
| kopecmartin | chandankumar, this one https://review.openstack.org/#/c/568252/ | 15:42 |
| kopecmartin | I already gave +2 | 15:42 |
| tosky | chandankumar: the "other" point is really an internal change, I would not put it in the release notes# | 15:43 |
| chandankumar | removing that one | 15:43 |
| tosky | release notes should contain stuff relevant for the users, whether they are users of the CLI interface or the API | 15:43 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Allow non admin users to upload image to glance https://review.openstack.org/568252 | 15:44 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Generate accounts.yaml https://review.openstack.org/570781 | 15:45 |
| tosky | so after all those +2, I can only remind you about the openstackdocstheme patch (already ack-ed by chandankumar :) | 15:45 |
| chandankumar | need a spec update also | 15:47 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: [DNM] Test --create-accounts-file argument https://review.openstack.org/572695 | 15:47 |
| tosky | right, but maybe after the fact? | 15:47 |
| tosky | uhm | 15:47 |
| tosky | when I changed the theme in sahara, I usually patched the packages immediately after | 15:47 |
| *** kopecmartin has quit IRC | 16:02 | |
| *** lifeless_ has joined #refstack | 17:15 | |
| *** lifeless has quit IRC | 17:16 | |
| *** lifeless_ has quit IRC | 19:31 | |
| *** lifeless has joined #refstack | 19:49 | |
| chandankumar | tosky: around | 21:15 |
| chandankumar | tosky: https://review.openstack.org/#/c/574691/ it needs to be merged to unblock ci | 21:15 |
| chandankumar | on tripleo side | 21:15 |
| tosky | I'm not sure if I can add a single approval +2 that can't wait until tomorrow | 21:18 |
| tosky | let me recheck it | 21:18 |
| chandankumar | tosky: will i workflow it? | 21:18 |
| tosky | no need, arxcruz|brb did it | 21:18 |
| tosky | chandankumar: but in the end it forcibly add v3, isn't it what we said to NOT to do? | 21:19 |
| tosky | wasn't the idea to first check if it works with v3? | 21:19 |
| tosky | without adding v3, I mean | 21:19 |
| chandankumar | tosky: https://review.openstack.org/574710 | 21:20 |
| arxcruz|brb | tosky: yeah, but since wes asked and it's blocking promotion pipeline, i did the +w | 21:20 |
| chandankumar | without v3 | 21:20 |
| tosky | arxcruz|brb: sure, so something else can break | 21:20 |
| tosky | chandankumar: I don't understand the meaning of that review | 21:20 |
| chandankumar | both will pass, as container tripleo has oldest package | 21:20 |
| arxcruz|brb | chandankumar: well, i might express myself wrong, i said test both in the code, not two reviews | 21:20 |
| tosky | chandankumar: still don't get it | 21:21 |
| *** lifeless has quit IRC | 21:21 | |
| chandankumar | tosky: https://review.openstack.org/#/c/574710/ this one? | 21:22 |
| chandankumar | tosky: I have just improved the exception | 21:22 |
| chandankumar | tosky: https://stackoverflow.com/questions/24518944/try-except-when-using-python-requests-module/24519419 | 21:23 |
| tosky | chandankumar: https://review.openstack.org/#/c/574710/ says that, without adding without adding v3, in the current code, everything works | 21:23 |
| tosky | which we already knew, right | 21:23 |
| tosky | ? | 21:23 |
| *** tosky has quit IRC | 21:25 | |
| *** lifeless has joined #refstack | 21:29 | |
| openstackgerrit | Arx Cruz proposed openstack/python-tempestconf master: Fix identity service url for v3 https://review.openstack.org/574691 | 21:44 |
| openstackgerrit | Merged openstack-infra/puppet-refstack master: Fix scope of vhost template variables https://review.openstack.org/564863 | 22:33 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!