| openstackgerrit | Merged openstack/refstack master: Migrating from bower to yarn https://review.openstack.org/573404 | 01:34 |
|---|---|---|
| *** lifeless_ has quit IRC | 04:22 | |
| *** lifeless has joined #refstack | 05:17 | |
| *** mtreinish has quit IRC | 06:19 | |
| *** kopecmartin has joined #refstack | 06:20 | |
| chandankumar | kopecmartin: packstack gates are broken due to gnoochi error | 06:22 |
| openstackgerrit | Chandan Kumar proposed openstack/refstack-client master: Generate tempest.conf automatically using refstack-client https://review.openstack.org/541273 | 06:56 |
| *** mtreinish has joined #refstack | 06:58 | |
| *** rmart04 has joined #refstack | 07:26 | |
| *** lifeless has quit IRC | 07:28 | |
| *** kopecmartin has quit IRC | 07:30 | |
| *** lifeless has joined #refstack | 07:35 | |
| *** tosky has joined #refstack | 07:37 | |
| *** kopecmartin has joined #refstack | 07:41 | |
| tosky | ok, so all packstack jobs are failing thanks to a gnocchi/puppet change | 07:52 |
| tosky | and it's not difficult to find the reason: https://review.openstack.org/#/c/569542/ | 07:59 |
| chandankumar | tosky: kopecmartin https://review.openstack.org/#/c/575340/ fix is up npw for packstack | 08:00 |
| kopecmartin | chandankumar, great | 08:02 |
| tosky | yep, just noticed | 08:03 |
| tosky | and voted | 08:03 |
| tosky | so we can wait, it's pointless to approve or submit new patches now | 08:30 |
| *** chkumar246 has joined #refstack | 09:30 | |
| *** chandankumar has quit IRC | 09:33 | |
| *** chkumar246 has quit IRC | 09:35 | |
| *** chandankumar has joined #refstack | 09:39 | |
| kopecmartin | tosky, chandankumar btw, regarding this review https://review.openstack.org/#/c/570781/ | 09:55 |
| kopecmartin | as i was playing with the DNM patch to test it | 09:55 |
| kopecmartin | wouldn't it be useful to set the path to the newly generated accounts.yaml to conf? | 09:56 |
| kopecmartin | I'm trying to image the real usecase | 09:56 |
| tosky | kopecmartin: I thought you could pass a full path as file name | 09:58 |
| kopecmartin | tosky, you can, .. and the file will be generated there, but what then? if you want to use it, you need to set it also to tempest.conf , right? | 10:00 |
| chandankumar | kopecmartin: it will just create the accounts.yaml file if user want to use it they can run second step to generate tempest.conf | 10:01 |
| tosky | kopecmartin: uh, I didn't check that part: do you mean that it may not possible to specify the path to that file in tempest.conf? | 10:02 |
| kopecmartin | chandankumar, if i need to run it twice, i can use tempest account-generator instead | 10:03 |
| kopecmartin | tosky, it is possible, but in current design, you can't set --test-accounts and --create-accounts-file , that's logical | 10:03 |
| kopecmartin | but what i'm thinking is, If i want from python-tempestconf (which is run from refstack-client) to generate accounts.yaml, it's because i want to use it | 10:04 |
| tosky | yes, most likely yes | 10:04 |
| kopecmartin | so why not just to set the path to that newly generated accounts.yaml file right after it's generated? | 10:05 |
| kopecmartin | does it make sense? | 10:05 |
| tosky | totally | 10:05 |
| chandankumar | kopecmartin: yup | 10:05 |
| kopecmartin | great, I'll edit the patch | 10:05 |
| tosky | I would have said that it was part of the workflow already, but I didn't though about it | 10:06 |
| kopecmartin | me neither, .. and then i was playing with it for a while as a user would do .. | 10:06 |
| kopecmartin | sometimes I'm glad I'm a little lazy :D | 10:07 |
| tosky | so we need a test for this! | 10:07 |
| * tosky runs | 10:07 | |
| *** rmart04 has quit IRC | 11:12 | |
| *** rmart04 has joined #refstack | 11:12 | |
| openstackgerrit | Chandan Kumar proposed openstack/refstack-client master: Generate tempest.conf automatically using refstack-client https://review.openstack.org/541273 | 11:24 |
| *** lifeless has quit IRC | 12:48 | |
| *** lifeless has joined #refstack | 12:49 | |
| openstackgerrit | Chandan Kumar proposed openstack/refstack-client master: Generate tempest.conf automatically using refstack-client https://review.openstack.org/541273 | 12:50 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: Generate accounts.yaml https://review.openstack.org/570781 | 12:54 |
| openstackgerrit | Martin Kopec proposed openstack/python-tempestconf master: [DNM] Test --create-accounts-file argument https://review.openstack.org/572695 | 12:57 |
| openstackgerrit | Nir Magnezi proposed openstack/python-tempestconf master: DNM: Test Octavia https://review.openstack.org/575063 | 13:28 |
| openstackgerrit | Nir Magnezi proposed openstack/python-tempestconf master: Configure tempest for Octavia tests https://review.openstack.org/571177 | 13:31 |
| openstackgerrit | Nir Magnezi proposed openstack/python-tempestconf master: DNM: Test Octavia https://review.openstack.org/575063 | 13:31 |
| chandankumar | arxcruz: please have a look at healthcheck api https://review.openstack.org/#/c/568869/ | 13:36 |
| openstackgerrit | Chandan Kumar proposed openstack/refstack-client master: Generate tempest.conf automatically using refstack-client https://review.openstack.org/541273 | 13:47 |
| arxcruz | chandankumar: in a few, checking the object-storage problem | 14:01 |
| arxcruz | chandankumar: tosky kopecmartin I have a doubt | 14:01 |
| arxcruz | swift default operator_role is set to Member | 14:01 |
| arxcruz | HOWEVER | 14:01 |
| arxcruz | in the swift proxy config file, the operator role alowed is ResellerAdmin, admin and swiftoperator | 14:01 |
| tosky | this part gives me headaches every time | 14:02 |
| arxcruz | so, set operator_role in object-storage section to Member is making the test fail with access denied | 14:02 |
| arxcruz | yup, i can relate to that :) | 14:02 |
| arxcruz | since you guys know more about packstack and other openstack installation | 14:02 |
| arxcruz | what's the best thing to do here ? | 14:02 |
| chandankumar | tosky: arxcruz then we need to add condition and check which one is present | 14:04 |
| chandankumar | Member or admin, if both present, it again will be a problem | 14:04 |
| chandankumar | arxcruz: tosky in which job it is failing? | 14:09 |
| arxcruz | chandankumar: https://logs.rdoproject.org/openstack-periodic/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset020-master/66bb1bf/tempest.html.gz | 14:10 |
| arxcruz | me and tiago are debugging the problem, but first thing we already notice was that | 14:10 |
| arxcruz | Member wasn't in the list for swift | 14:10 |
| arxcruz | chandankumar: tosky so, on packstack tests, the object-storage tests are being skipped because swift isn't configured | 14:21 |
| arxcruz | so we don't see this problem | 14:21 |
| *** rmart04 has quit IRC | 15:04 | |
| openstackgerrit | Luigi Toscano proposed openstack/python-tempestconf master: DNM: Test Octavia https://review.openstack.org/575063 | 16:05 |
| *** kopecmartin has quit IRC | 16:06 | |
| *** lifeless has quit IRC | 16:07 | |
| *** lifeless has joined #refstack | 16:08 | |
| arxcruz | chandankumar: is there a swift-tempest-plugins repo ? | 16:34 |
| arxcruz | or something like that ? | 16:34 |
| openstackgerrit | Chandan Kumar proposed openstack/python-tempestconf master: Use healthcheck api to determine swift service https://review.openstack.org/568869 | 16:36 |
| chandankumar | arxcruz: nope | 16:37 |
| chandankumar | arxcruz: nova glance swift have no plugins | 16:38 |
| arxcruz | chandankumar: so, why we are checking for reseller_admin here https://github.com/openstack/python-tempestconf/blob/master/config_tempest/services/object_storage.py#L42 | 16:39 |
| arxcruz | the config is reseller_admin_role | 16:39 |
| chandankumar | arxcruz: those are coming from tempest config default | 16:39 |
| arxcruz | chandankumar: there's no tempest config default for reseller_admin | 16:40 |
| arxcruz | it's reseller_admin_role | 16:40 |
| chandankumar | arxcruz: https://github.com/openstack/tempest/blob/master/tempest/config.py#L892 | 16:40 |
| arxcruz | chandankumar: what operator has to do with reseller ? | 16:41 |
| arxcruz | https://github.com/openstack/tempest/blob/master/tempest/config.py#L896 | 16:41 |
| chandankumar | arxcruz: since these things are dependent on deployment tool they need to create it and dump in tempest deployer input file | 16:41 |
| chandankumar | which is a another mess on tripleo side | 16:41 |
| arxcruz | chandankumar: let's go back | 16:41 |
| arxcruz | the config key object-storage.reseller_admin doesn't exist | 16:41 |
| arxcruz | the key is object-storage.reseller_admin_role | 16:42 |
| chandankumar | arxcruz: ah yes, it is a typo | 16:42 |
| chandankumar | let me send a patch | 16:43 |
| arxcruz | chandankumar: tosky is that okay if i change the operator_role in python-tempestconf to admin? tripleo uses admin, SwiftOperator and ResellerAdmin while packstack uses admin and Member | 16:43 |
| arxcruz | chandankumar: no, hold on | 16:43 |
| chandankumar | arxcruz: let's not hardcode stuff in tempestconf | 16:43 |
| arxcruz | this will not fix the problem | 16:43 |
| chandankumar | we should put it in tripleoclient side | 16:44 |
| * chandankumar waits for tosky | 16:44 | |
| arxcruz | chandankumar: Member role according tdasilva is a security risk, and will not be on tripleo | 16:45 |
| arxcruz | and also, they want to get rid of the defaults-override | 16:45 |
| chandankumar | arxcruz: https://github.com/openstack-dev/devstack/blob/0d1bee17680d55c654e9b804d1b55e1437b65d06/lib/swift#L459 | 16:46 |
| tosky | arxcruz: they == ? | 16:46 |
| arxcruz | chandankumar: do you see anyone installing openstack in production via devstack? ;) this is just a test | 16:46 |
| arxcruz | tosky: according mwhahaha | 16:47 |
| chandankumar | arxcruz: I am talking about this onbe https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/utils.py#L126 | 16:47 |
| tosky | arxcruz: it's not like defaults-override is something that they control | 16:47 |
| tosky | arxcruz: that's not their business | 16:47 |
| tosky | it's not a tripleo stuff | 16:47 |
| arxcruz | default-override comes from tripleo-client | 16:47 |
| arxcruz | ops | 16:47 |
| chandankumar | arxcruz: nope | 16:47 |
| arxcruz | sorry | 16:47 |
| arxcruz | my bad | 16:47 |
| chandankumar | arxcruz: it is coming from tempestconf | 16:47 |
| arxcruz | tempest-deployer-input | 16:47 |
| arxcruz | guys, can we do a quickly bj ? | 16:47 |
| tosky | sh*t | 16:47 |
| chandankumar | utils.py is generating tempest deployer input file | 16:47 |
| arxcruz | it's really hard to keep typing | 16:47 |
| * chandankumar not with computer from cell phone | 16:48 | |
| arxcruz | https://bluejeans.com/u/acruz77/ | 16:48 |
| arxcruz | so | 16:48 |
| tosky | arxcruz: I had this discussion already, and the only answer is "delete this" | 16:48 |
| tosky | of course I didn't have the time to work on that | 16:48 |
| arxcruz | here's the thing | 16:48 |
| tosky | the solution is not to remove that file | 16:48 |
| arxcruz | we have a problem | 16:48 |
| arxcruz | the problem is | 16:48 |
| tosky | but no one aparts from me want to solve it in the proper way | 16:49 |
| tosky | another thing that makes me really angry | 16:49 |
| arxcruz | tripleo uses on swift admin, ResellerAdmin and swiftoperator as roles allowed to create containers | 16:49 |
| arxcruz | packstack, and devstack uses Member and admin | 16:49 |
| chandankumar | longer term plan was write misteral workflow to generate tempest.conf for tripleo | 16:49 |
| arxcruz | tripleo says use Member in the installer is security risk | 16:49 |
| chandankumar | packstack has swiftoperator role | 16:49 |
| chandankumar | camelcassing | 16:50 |
| arxcruz | chandankumar: okay, so | 16:50 |
| arxcruz | so, the only role in common to all of three, devstack, packstac, and tripleo is the admin one | 16:50 |
| chandankumar | if member is security risk it needs to be fixed in tempest and devstack | 16:50 |
| arxcruz | can I write a patch to set this as the default operator role in python-tempestconf | 16:50 |
| tosky | if it works for all 3, yes | 16:51 |
| chandankumar | sure | 16:51 |
| arxcruz | 18:40:57 tdasilva | arxcruz: please don't change swift config to add Member, that could be construed as a security issue. my guess is that most users are "Members" and should not really have a "operator" type role | 16:51 |
| arxcruz | tosky: do you agree with that ? | 16:51 |
| tosky | see above | 16:52 |
| arxcruz | oh, sorry | 16:52 |
| arxcruz | :) | 16:52 |
| arxcruz | so everybody agree right? | 16:52 |
| tosky | it's not that I should agree | 16:52 |
| tosky | the gates should agree | 16:52 |
| tosky | not me | 16:52 |
| tosky | and so far there was no solution | 16:52 |
| arxcruz | in that case the list_create_roles is useless | 16:53 |
| arxcruz | tosky: i just don't want to do something before consulting my pals :) | 16:53 |
| chandankumar | arxcruz: other solution is just add a small piece of code in tripleocient and job is done | 16:53 |
| tosky | it's not a small code | 16:54 |
| arxcruz | chandankumar: yeah, but again, they want to get rid of that deployer-input | 16:54 |
| tosky | arxcruz: and they won't solve anything | 16:54 |
| tosky | because there are values that we can't discover | 16:55 |
| tosky | so they will still need to provide them | 16:55 |
| arxcruz | tosky: ¯\_(ツ)_/¯ | 16:55 |
| chandankumar | arxcruz: we need a proper replacement of thst before getting rid | 16:55 |
| tosky | again, interesting like they want to just kill kill and not fix | 16:55 |
| arxcruz | chandankumar: agree, but it's not my call, I'll not be the guy who will get rid of that file | 16:55 |
| chandankumar | those are deployment specific values | 16:55 |
| tosky | fix in the proper way, which would solve the problem once and forever | 16:55 |
| chandankumar | arxcruz: i will check with emilien in next meeting | 16:55 |
| arxcruz | chandankumar: ok | 16:56 |
| tosky | chandankumar: and he will tell that I promised to work on that and I didn't do anything | 16:56 |
| * chandankumar createa a card | 16:56 | |
| tosky | so no hopes | 16:56 |
| arxcruz | chandankumar: i hear some talk about it from mwhahaha | 16:56 |
| arxcruz | they asked if we use that, if not we should delete it | 16:56 |
| arxcruz | he, mwhahaha asked* | 16:56 |
| tosky | arxcruz: and we use it | 16:56 |
| tosky | so... | 16:56 |
| arxcruz | tosky: okay, i'll create in tripleo client | 16:57 |
| tosky | arxcruz: what? The role? | 16:57 |
| tosky | arxcruz: if admin already exists and works for all 3 installers, just use it | 16:57 |
| tosky | the deployer-input is *another* problem | 16:58 |
| chandankumar | tosky: arxcruz on tripleo channel i am talking abiut that | 17:02 |
| openstackgerrit | Arx Cruz proposed openstack/python-tempestconf master: Updating object-storage.operator_role https://review.openstack.org/575501 | 17:14 |
| *** lifeless has quit IRC | 19:37 | |
| *** lifeless has joined #refstack | 19:53 | |
| *** lifeless has quit IRC | 21:49 | |
| *** lifeless has joined #refstack | 21:51 | |
| *** tosky has quit IRC | 22:49 | |
| *** lifeless_ has joined #refstack | 23:42 | |
| *** lifeless has quit IRC | 23:43 | |
| *** markvoelker has quit IRC | 23:46 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!