Tuesday, 2021-06-15

opendevreviewnorman shen proposed openstack/nova master: Saving security group to info_cache  https://review.opendev.org/c/openstack/nova/+/78634800:36
opendevreviewMerged openstack/nova master: Test the NotificationFixture  https://review.opendev.org/c/openstack/nova/+/75845000:47
opendevreviewMerged openstack/nova master: Move fake_notifier impl under NotificationFixture  https://review.opendev.org/c/openstack/nova/+/75845100:47
*** liuyulong_ is now known as liuyulong02:25
opendevreviewYongli He proposed openstack/nova master: Smartnic support - cyborg drive  https://review.opendev.org/c/openstack/nova/+/77136202:33
opendevreviewYongli He proposed openstack/nova master: smartnic support - new vnic type  https://review.opendev.org/c/openstack/nova/+/77136302:33
opendevreviewYongli He proposed openstack/nova master: smartnic support  https://review.opendev.org/c/openstack/nova/+/75894402:33
opendevreviewYongli He proposed openstack/nova master: smartnic support - reject server move and suspend  https://review.opendev.org/c/openstack/nova/+/77991302:33
opendevreviewYongli He proposed openstack/nova master: smartnic support - functional tests  https://review.opendev.org/c/openstack/nova/+/78014702:33
*** iurygregory_ is now known as iurygregory06:19
gibilyarwood, stephenfin: good morning! another pip conflict http://paste.openstack.org/show/806617/ in https://f4c7a70c63adb2c6ee00-366864060e164744cd046650ee1657de.ssl.cf1.rackcdn.com/794639/6/gate/nova-ceph-multistore/cbf9aff/job-output.txt07:04
gibilyarwood: did you managed to find some hint yesterday about the websockify or the the stevedore case?07:08
gibithis feels pretty random07:09
*** rpittau|afk is now known as rpittau07:13
opendevreviewYongli He proposed openstack/nova master: smartnic support - reject server move and suspend  https://review.opendev.org/c/openstack/nova/+/77991307:31
opendevreviewYongli He proposed openstack/nova master: smartnic support - functional tests  https://review.opendev.org/c/openstack/nova/+/78014707:31
lyarwoodgibi: no I couldn't work it out, is this another hit?08:04
lyarwoodsean-k-mooney: https://bugs.launchpad.net/nova/+bug/1912310/comments/4 btw looks like more evidence of the ovsdbapp polling bug #1929446 the client here fails to send some keepalives to libvirtd on the dest so it kills the migration and domain08:36
lyarwoodgibi:  https://zuul.opendev.org/t/openstack/build/cbf9affc449848f9910eaab857c5df74/log/job-output.txt#29072 another example08:43
lyarwood2021-06-14 17:43:15.964340 | controller | The conflict is caused by:08:43
lyarwood2021-06-14 17:43:15.964414 | controller |     cinder-tempest-plugin 1.4.1.dev16 depends on tempest>=17.1.008:43
lyarwood2021-06-14 17:43:15.964457 | controller |     The user requested (constraint) tempest===27.0.008:43
lyarwood/o\08:43
lyarwoodoh sorry that was the same one you pointed out08:46
lyarwoodI've updated https://bugs.launchpad.net/nova/+bug/1931864 to track these08:46
bauzaslyarwood: gibi: sorry was on and off those 2 days as I need to use another laptop, but is https://bugs.launchpad.net/nova/+bug/1931864 a gate failure for all the changes ?08:48
lyarwoodnot all changes, I've seen it ~3 or 4 times now in the gate08:48
bauzasack thanks08:49
sean-k-mooneylyarwood: ack, terry would prefer to not merge my ovsdbapp fix and is instead fixing the issue in ovs10:02
sean-k-mooneylyarwood: although i think we need to have a backportable fix also10:02
lyarwoodkk awesome, I'm starting to think that we can likely attribute lots of the recent weirdness in the gate to this tbh10:03
sean-k-mooneyya proably10:03
sean-k-mooneywe change the default to native in victoria10:03
sean-k-mooneyuntil then we were still using the cli based driver instead of the python libs 10:03
sean-k-mooneyso this being the default is relitivly recent form a ci point of view10:04
gibilyarwood: no worries10:23
* gibi will be on and off today10:24
opendevreviewBalazs Gibizer proposed openstack/nova master: Retry lvm volume and volume group query  https://review.opendev.org/c/openstack/nova/+/79626910:44
gibistephenfin: fixed up the syle nit ^^10:44
gibilyarwood: an easy review for the lvm job fix ^^10:45
stephenfinta, done10:45
gibithanks10:45
lyarwoodthanks ack'd10:46
gibilyarwood: this is also ready to go https://review.opendev.org/c/openstack/nova/+/79625510:57
lyarwoodack thanks10:58
gibithanks11:00
opendevreviewMohammed Naser proposed openstack/nova master: Allow X-OpenStack-Nova-API-Version header in CORS  https://review.opendev.org/c/openstack/nova/+/79631911:35
opendevreviewLee Yarwood proposed openstack/nova master: tests: Allow bindep and test-setup.sh to run successfully on RHEL  https://review.opendev.org/c/openstack/nova/+/79642811:51
opendevreviewLee Yarwood proposed openstack/nova master: tests: Allow bindep and test-setup.sh to run successfully on RHEL  https://review.opendev.org/c/openstack/nova/+/79642811:58
*** halali is now known as halali_13:08
*** rpittau is now known as rpittau|afk14:29
bauzasgibi: I have a scheduled appointment in 30 mins, I could not be back at the meeting time14:51
bauzasin case I'm not around, nothing to say about the libvirt subteam14:51
opendevreviewnorman shen proposed openstack/nova master: Saving security group to info_cache  https://review.opendev.org/c/openstack/nova/+/78634814:53
gibibauzas: thanks for the info14:58
spatelsean-k-mooney do you know where is this error coming from -  default default] [instance: 9a490cfa-8da6-4c14-868a-e10a08278c66] Instance failed to spawn: libvirt.libvirtError: unsupported configuration: Emulator '/usr/bin/qemu-system-x86_64' does not support virt type 'kvm'14:58
spateli have 20 compute nodes and only 4 compute nodes complaining about that error, they all running same config/os etc..14:58
pjakuszewspatel: sounds like virtualisation support is disabled on these machines15:00
spatelhmm 15:00
spatellet me go to bios and verify incase i missed something 15:00
pjakuszewspatel: does /dev/kvm exist?15:02
spatel'/dev/kvm': No such file or directory15:03
pjakuszewand how about lsmod | grep kvm?15:03
spatelkvm                   663552  015:03
pjakuszewit depends on the architecture, but on x86 there should be kvm + kvm_{intel,amd}15:04
pjakuszewyou only have kvm15:04
spatellook like something is wrong in my BIOS setting then.. 15:04
pjakuszewwhich suggests that either the cpu doesn't handle vt-x/svm, or you simply have it disabled in bios/uefi15:04
pjakuszewyeah15:04
spatelrebooting my VM to verify15:04
spatelhost i meant15:05
opendevreviewnorman shen proposed openstack/nova master: Saving security group to info_cache  https://review.opendev.org/c/openstack/nova/+/78634815:08
spatelpjakuszew turned out VT was disable in BIOS :) good catch thank you..15:10
sean-k-mooneyspatel: i was just going to say likely vt-d15:12
sean-k-mooneyor vt-x15:12
sean-k-mooneythere is a script to check that15:13
pjakuszewubuntu has one iirc15:14
sean-k-mooneyvirt-host-validate15:14
sean-k-mooneyor you can use kvm_ok on ubuntu15:14
sean-k-mooneyvirt-host-validate is what you use on fedora/centos/rhel15:14
sean-k-mooneyalthough it might be on ubuntu also15:15
sean-k-mooneyi think its actully part of libvirt where as kvm_ok is part of cpu-checker i think15:15
sean-k-mooneyits not actully part of libvirt15:15
spatelsean-k-mooney here its - http://paste.openstack.org/show/806634/15:17
spatelkvm-ok 15:17
sean-k-mooneyyep so it deteced the problem15:17
sean-k-mooneydo you happen to have virt-host-validate also15:17
sean-k-mooneyit check more things but kvm_ok is nice for a quick check15:18
spatelyes i do have virt-host-validate, it has nice output.. i didn't know about this 15:18
spateli will add in my ansible playbook to validate VT before start deploying code15:19
sean-k-mooneykvm-ok was what i always used to use only found out about virt-host-validate about a year ago15:19
pjakuszewspatel: the hostname from your pastebin suggests that you probably will be interested in vt-d and intel_iommu=on as well15:19
sean-k-mooneyvirt-host-validate will check if you can use sriov and a few other things also15:19
sean-k-mooneyintel_iommu=on iommu=pt most likely15:20
spatelpjakuszew my all computes running on sriov 15:20
sean-k-mooneyiommu=pt is not strictly requried if its only sriov and not dpdk15:20
spateli have added both anyway 15:20
spatelsean-k-mooney nowadays i am playing with OVN, it looks complicated but promissing 15:22
spatelpromising*15:23
sean-k-mooneyit is on both counts15:23
sean-k-mooneysimpler then odl or onos15:23
sean-k-mooneybut more complex the simple sriov15:23
spatelcomplex with sriov? 15:24
spateli haven't started playing with OVN + SR-IOV yet. I am planning to use dpdk instead of sriov this time 15:25
sean-k-mooneyno i ment sriov is relitvly simple in that its just a vlan on a vf in most case with simpel vlan networking15:26
spateloh! 15:26
sean-k-mooneyovn is more complex because of the need to under stand how the logical switchs in ovn mape too the neutron network and how ovn translattes the configuretion into openflow rules and the complexites of geneve tunneling15:27
sean-k-mooneyonce you wrap your head around it its fine but there is a lot more context to understand with ovn15:27
spatelno doubt about complexity. it has lots of moving components in single piece. l2/l3/firewall/dhcp so it looks simple but kinda hard to troubleshoot. 15:29
spatelsometime its very hard to read flow table for troubleshooting, specially when it has hundreds of entries.15:30
spatelbut i like all the feature it providing like DVR etc.. which is very easy and it won't waste of public IPs unlike legacy DVR 15:31
*** halali is now known as halali_15:32
gibifyi I've opened a new gate-failure bug https://bugs.launchpad.net/nova/+bug/1932043 nova-ceph-multinode test_resize_server_revert fails with rbd.ReadOnlyImage: [errno 30] RBD read-only image15:35
melwittelodilles: if I could trouble you for review on https://review.opendev.org/c/openstack/nova/+/794186 and https://review.opendev.org/c/openstack/nova/+/791577 please if you get a chance15:35
sean-k-mooneygibi: strange was the a new cpeh release or soemthign15:36
sean-k-mooneye.g. did somethign cause a change in the behaivor15:37
gibisean-k-mooney: I saw it 3 times in the last couple of days, so it is not a total blocker15:37
sean-k-mooneyim not sure why the image would be ReadOnlyImage15:37
sean-k-mooneyok15:37
melwittlyarwood: and if I could trouble you for review on https://review.opendev.org/c/openstack/nova/+/791577 please if you get a chance15:37
gibisean-k-mooney: I don't see ceph version differences between failed and successfull jobs both using nautilus 15:44
sean-k-mooneyack do you know why an image would be read only?15:45
sean-k-mooneyi can only assume its a permissions issue but i woudl expect taht to affect all vms in the same tempest run15:46
gibisean-k-mooney: no idea. it happens during a same host resize 15:48
sean-k-mooneythat does a direct snapshot of the volumn in ceph15:49
sean-k-mooneyat least when using the rbd image backend in nova15:50
gibiFYI nova meeting starts in 10 minutes _in this channel_15:50
sean-k-mooney:)15:50
gibisean-k-mooney: yes it does a snapshot during finish_migration and that fails15:51
pjakuszewI have a question about extra_specs mangling but I guess I will ask about it after the meeting :)15:52
sean-k-mooneypjakuszew: we dont actully mangel extra specs in the db as far as im aware15:52
sean-k-mooneywe do prefix image properties with image_ in the system metadata table15:52
pjakuszewuh I phrased it wrong15:53
pjakuszewthis is something I mentioned ~last week here15:53
pjakuszew"regenerate extra_specs in requestspec" topic15:53
sean-k-mooneyregenerating the request spec?15:53
pjakuszewyeah15:53
sean-k-mooneywe store an copy of the entire flavor as a json bob i think15:54
pjakuszewso, I noticed that Instance.flavor seems to be a different entity stored somewhere else15:54
pjakuszewhttp://paste.openstack.org/show/806638/15:54
sean-k-mooneyin instnace_extra maybe havent checked in a while15:54
pjakuszewand I wonder where Instance.flavor is actually stored, if it is not looked up from either RequestSpec, or the actual Flavor15:55
sean-k-mooneypjakuszew: yes when we create an instance we make a copy of the flavor and extra specs an store a copy to use for the lifetime of the instace15:55
sean-k-mooneyto intentionally not pick up any change to extra specs that operators do after the vm is created15:56
sean-k-mooneyhttps://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L38915:56
opendevreviewStephen Finucane proposed openstack/nova master: db: Remove dead code  https://review.opendev.org/c/openstack/nova/+/78629115:56
sean-k-mooneyits sotred in the instance_extra db tables as a json blob15:56
opendevreviewStephen Finucane proposed openstack/nova master: db: Remove 'nova.db.sqlalchemy.utils'  https://review.opendev.org/c/openstack/nova/+/78629215:56
opendevreviewStephen Finucane proposed openstack/nova master: db: Remove unused DB methods  https://review.opendev.org/c/openstack/nova/+/78629315:56
opendevreviewStephen Finucane proposed openstack/nova master: db: Use module-level imports for sqlalchemy  https://review.opendev.org/c/openstack/nova/+/78629515:56
opendevreviewStephen Finucane proposed openstack/nova master: db: Fold in indexes  https://review.opendev.org/c/openstack/nova/+/78629615:56
opendevreviewStephen Finucane proposed openstack/nova master: db: Fold in ForeignKey constraints  https://review.opendev.org/c/openstack/nova/+/78629715:56
opendevreviewStephen Finucane proposed openstack/nova master: db: Remove 'nova.db.base' module  https://review.opendev.org/c/openstack/nova/+/78629815:57
opendevreviewStephen Finucane proposed openstack/nova master: db: Copy docs from 'nova.db.*' to 'nova.db.sqlalchemy.*'  https://review.opendev.org/c/openstack/nova/+/78629915:57
opendevreviewStephen Finucane proposed openstack/nova master: db: Synchronize function signatures  https://review.opendev.org/c/openstack/nova/+/78630015:57
opendevreviewStephen Finucane proposed openstack/nova master: db: Clean up migration code  https://review.opendev.org/c/openstack/nova/+/78630115:57
opendevreviewStephen Finucane proposed openstack/nova master: db: Use module-level imports for sqlalchemy (for real)  https://review.opendev.org/c/openstack/nova/+/79651915:57
sean-k-mooneylol i just realise that that is one drawback of having the meeting here15:57
pjakuszewsean-k-mooney: huh ok, I thought that InstanceExtra was the RequestSpec actually15:57
sean-k-mooneypjakuszew: no that is in the api db15:57
sean-k-mooneyinstance extra is in the cell db15:58
sean-k-mooneyhttps://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api_models.py#L169-L18115:58
pjakuszewhm, okay, and what is taken into consideration when a migration is requested?15:58
pjakuszewthe cell db, or api db?15:58
sean-k-mooneyboth15:58
sean-k-mooneythe flavor will come form the instance_extra table15:59
sean-k-mooneyschduler hints and other thing like az will come form teh request spec15:59
pjakuszewright, so if I want to make it behave like new instances, should I change both objects?15:59
sean-k-mooneybut lets pick this up after the meeting15:59
pjakuszewsure thing15:59
gibi#startmeeting nova16:00
opendevmeetMeeting started Tue Jun 15 16:00:03 2021 UTC and is due to finish in 60 minutes.  The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot.16:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:00
opendevmeetThe meeting name has been set to 'nova'16:00
gibio/ 16:00
gmanno/16:00
gibiwelcome in our new meeting venue 16:00
sean-k-mooneyo/ it feels familar for some reason i woneder why :)16:00
stephenfincould do with a lick of paint but otherwise not bad16:01
gibiyou should appreciate that you did not need to move rooms :)16:01
gibino uncessary walking around16:01
elodilleso/16:01
melwittmeetingshed paint debate time16:01
sean-k-mooney:)16:02
* gibi bad at colors16:02
gibianyhow lets get started16:02
artomBecause it's colours ;)16:02
lyarwoodo/16:02
gibi;)16:02
melwittopenstack server create --flavour16:02
sean-k-mooney:) that used to be in the docs16:03
sean-k-mooneyi think most people are hear now16:03
gibinyitottverem gep elterhozas --iz16:03
gibi;)16:03
gibiif we are at linguistics16:03
stephenfingibi's having a stroke16:03
dansmitho/16:03
gibis/eletrhozas/letrehozas/16:03
artomThe old channel was better, I could understand what people were saying :(16:03
artom(Some of the time)16:04
gibi#topic Bugs (stuck/critical) 16:04
gibino critical onse16:04
gibiones16:04
gibi#link 14 new untriaged bugs (+3 since the last meeting): #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New16:04
gibibesides gate bugs (coming in the next topic) is there any bug we need to talk about?16:04
gibi#topic Gate status 16:06
gibiNova gate bugs #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure16:06
gibiwe fixed the mypy blockage but the gate is still shaky16:07
gibiwe are tracking a list of new bugs that causing intermittent failures16:07
gibiand rechecking fixes 16:08
gibiI don't want to go through the whole list of bugs16:08
sean-k-mooneywe have made some progress on https://bugs.launchpad.net/nova/+bug/1929446 , otherwiseguy summerised some of the steps forward in https://bugs.launchpad.net/nova/+bug/1929446/comments/3 while https://review.opendev.org/c/openstack/ovsdbapp/+/795789 seams to fix it we are not going to proceedd with merging it16:08
sean-k-mooneyim going to try and implement the os-vif changes this week16:08
gibisean-k-mooney: it is the one that suspected to causing timeouts in live migrations?16:09
sean-k-mooneyterry is proceedign with the fix in ovs.16:09
sean-k-mooneyyes16:09
sean-k-mooneynot just live migrations16:09
sean-k-mooneyit i causeing the agent to periodically block for several seconds whenever there is a disconnection form ovs16:10
sean-k-mooneyso its likely makeing the many things flaky16:10
* melwitt majorly looks forward to that fix16:11
gibisean-k-mooney: thanks16:11
gibiany other bug needs discussion?16:11
gibiPlacement periodic jobs looks green16:13
gibi#link https://zuul.openstack.org/builds?project=openstack%2Fplacement&pipeline=periodic-weekly16:13
gibi#topic Release Planning 16:13
gibiMilestone 2 is 15 of July16:13
gibianything else about the release?16:13
gibi#topic Stable Branches 16:14
gibistable/ussuri is blocked -- fix needs to be merged: https://review.opendev.org/c/openstack/nova/+/79467516:14
gibiother branches should be OK16:14
gibistable/ocata will be EOL'd -- nova patch: https://review.opendev.org/c/openstack/releases/+/79566416:14
gibiEOM16:14
gibithanks elodilles for the summary16:14
elodillesnp16:15
gibianything else on stable?16:15
toskygibi: about that first patch, I think it's a bit more complicated, melwitt created a squashed patch with more changes16:15
toskybut it's failing too16:15
melwittyeah elodilles has added a comment wrt the fail16:15
elodillesyes, I've just commented on it as it is failing on the post tasks16:16
elodilles:]16:16
melwittand yes it's a megasquash. I defer to elodilles as to how the commit message should be bc I don't know :)16:16
toskythis one: https://review.opendev.org/c/openstack/nova/+/795432/2 (which should probably get a better combined subject)16:17
lyarwoodI missed our reasoning for doing this but as it's mostly my work I'll try to take a look before I leave today16:17
toskyor you can preserve https://review.opendev.org/c/openstack/nova/+/794675 as it is, but set nova-live-migration as non-voting, and re-enable it in a subsequent commit 16:17
toskywhich would reduce the diff and avoid a supermegasquash16:18
gibilyarwood: thanks16:18
melwittlyarwood: tl;dr is tosky recommended we backport the native zuul v3 patches instead of fixing legacy versions16:18
melwittso I tried to do it. it worked ok until ussuri16:19
lyarwoodack understood16:19
toskyit's mostly working in fact: https://review.opendev.org/c/openstack/nova/+/795432/ shows that the backported change works, but something else fails 16:19
melwittso feel free to take another approach if it's too messy16:19
elodillesmaybe just that post task should be fixed (to avoid the supermegasquash :))16:20
elodillesI mean... if that is possible...16:20
elodilleswithout the supermegasquash16:20
lyarwoodyeah it's possible16:21
elodilles\o/16:21
lyarwoodit's just because this was written against focal but the nodes here are bionic AFAICT16:21
sean-k-mooneyon ussuri?16:21
elodillesyes, it's bionic16:21
gmannyeah ussuri is on bionic16:21
sean-k-mooneyreally ok i thought that was focal16:21
gmannfrom victoria we moved to focal16:22
sean-k-mooneyhopefully that wont be hard to fix then16:22
sean-k-mooneyCould not find the requested service libvirtd-ro.socket: host16:22
sean-k-mooneyok so likely hte service names are different16:22
sean-k-mooneyboth that should be a quick fix16:22
gibiOK I think we generated ideas about the way forwards16:23
gibianything else about stable?16:23
elodillesnothing from me16:23
gibiOK moving on 16:24
gibiskipping the libvirt subteam topic as bauzas is absent, but he said nothing to report16:24
gibi#topic Open discussion 16:24
gibithere is one item on the agenda16:24
gibi(yonglihe)smartnic support need one extra core reviewer , we have alex now, anyone else could help? thanks : https://review.opendev.org/c/openstack/nova/+/779913 (yongli could not attending due to time slot...)16:25
gibilooking at the patches I think alex_xu haven't reviewed them16:25
*** ricolin_ is now known as ricolin16:26
gibior at least not recently16:26
gibias I reviewed these in the past I can be the second core16:26
gibibut I will wait for Alex to to the first rounds16:27
gibiany comment?16:27
sean-k-mooneyi can proably take another look at that although i kind of wanted16:28
sean-k-mooneysomeone else who can review the code to be on board with it16:28
sean-k-mooneyoh that the implemtion not the spec16:28
gibiyep the spec is approved16:29
sean-k-mooneywell i can try and review the code i guess but maybe stephenfin  or bauzas could take a look?16:30
stephenfinI can give it a shot16:30
gibiOK thanks I think this is more than enough :)16:31
gibiany other topic for today?16:31
stephenfinoh, one16:32
stephenfinspecless BP approval16:32
stephenfinfor https://blueprints.launchpad.net/nova/+spec/remove-sqlalchemy-migrate16:32
stephenfinI thought I had done this before, but clearly not16:32
stephenfinthat's the spec to track replacing sqlalchemy-migrate with alembic16:32
sean-k-mooneyyou mean blueprint16:33
sean-k-mooneyor is there actully a spec16:33
stephenfinsorry, blueprint, yeah16:33
sean-k-mooneyi assume you want to track it as a specless blueprint16:33
sean-k-mooneyok16:34
opendevreviewLee Yarwood proposed openstack/nova stable/ussuri: zuul: Start to migrate nova-live-migration to zuulv3  https://review.opendev.org/c/openstack/nova/+/79543216:34
gibistephenfin: do you forsee any complication that might warrant a spec?16:34
stephenfinnot at the moment, no. It's very simple if tedious so far16:35
sean-k-mooneyin the ptg we said """create a contributor doc showing how a migration will look like after the change. Document how to backport a migration to stable""" and """figure out if alembic collapsing migrations can this cause timeouts for big migrations"""16:35
stephenfinif I encounter something that I think warrants discussion, I'll happily write one then16:35
sean-k-mooneydid we we figure out the latter16:35
stephenfinI haven't managed to rewrite all the migrations yet, so no16:36
sean-k-mooneyi think that was the only concern we had e.g. how does it scale16:36
sean-k-mooneyok16:36
opendevreviewLee Yarwood proposed openstack/nova master: gate: Remove test_evacuate.sh  https://review.opendev.org/c/openstack/nova/+/79652316:36
stephenfinthough neutron's use of this suggests we'll be fine (famous last words :))16:36
sean-k-mooneyi suspect as well as what we currently use or at least well enough for neutron 16:36
stephenfinyup16:36
sean-k-mooneyi dont really have any open quetsion that woudl warrent a spec16:37
sean-k-mooneyprovided you provide the contib doc as part of the series16:37
gibiany objection against approving it as specless bp?16:38
gibithen it is approved16:39
gibiany other topic for today?16:39
stephenfinhurrah16:39
stephenfinnot from me16:39
sean-k-mooneyam one16:40
gibiany feedback on having the meeting on this channel?16:40
sean-k-mooneygibi: when did you want to do the next spec review day16:40
dansmith++ on meeting in channel :)16:40
sean-k-mooneygibi: and i think it worked ok16:40
gmann++16:40
gibisean-k-mooney: 6th of July maybe?16:40
stephenfinmeeting in the channel seems sensible so far, yup16:41
sean-k-mooneyya that gives a few days befor m2 on the 12th16:41
gibithat is a bit more than a week before the freeze16:41
sean-k-mooneyso works for me16:41
stephenfinas does that date16:41
sean-k-mooneyoh m2 is the 15th 16:42
sean-k-mooneyya16:42
sean-k-mooneyok that was all i wanted to ask16:42
gibiif nothing else then thanks for joining. 16:42
gibiI give the channel back :)16:42
gibi#endmeeting16:42
opendevmeetMeeting ended Tue Jun 15 16:42:57 2021 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:42
opendevmeetMinutes:        https://meetings.opendev.org/meetings/nova/2021/nova.2021-06-15-16.00.html16:42
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/nova/2021/nova.2021-06-15-16.00.txt16:42
opendevmeetLog:            https://meetings.opendev.org/meetings/nova/2021/nova.2021-06-15-16.00.log.html16:42
sean-k-mooneypjakuszew: im going to get somethign to drink but if you have more question regarding the embeded flavor feel free to ask them 16:43
sean-k-mooneybrb16:43
gibifyi I noticed a new version of the wierd pip version conflict, now with paramiko. Added the info to https://bugs.launchpad.net/nova/+bug/193186416:46
pjakuszewsean-k-mooney: just one, should I change both Instance.flavor.extra_specs and RequestSpec.flavor.extra_specs to the new ones from Flavor, if I want the instance migration to work in the same way as the new instances with that modified flavor16:46
pjakuszewi.e. if I added 'foo':'bar' to flavor extra_specs, should I modify both Instance and RequestSpec so migrations behave in the same way as for new instances which have these specs already16:47
pjakuszewthis is all assuming that I have enabled InstanceAggregateExtraSpecs scheduler filter and now I want the old instance migrations to behave like the new ones16:49
sean-k-mooneyyes you would have to update both16:52
sean-k-mooneythe request spec flavor is used for schduling but the instinace.flavor is used form cretating the vm xml16:52
sean-k-mooneybut it depends on your goal16:52
sean-k-mooneyif you only wanted to sync the extra spec use for the InstanceAggregateExtraSpecs filter technically only the request spec flavor would need to be updated16:53
pjakuszewright, though it wouldn't probably hurt to also have the Instance flavor in-sync, just to keep things "clean"16:54
sean-k-mooneyam is your pimary usecase the InstanceAggregateExtraSpecs filter16:55
sean-k-mooneyif so you could limit the extra spec update to just those that are prefixed with aggregate_instance_extra_specs16:55
sean-k-mooneypjakuszew: the main issue is the two flavor opies are stored in different databases16:56
sean-k-mooneyso you cant update both in the same transaction i bleive16:56
pjakuszewit shouldn't be a big issue in this situation16:58
pjakuszewok, then my main focus is requestspec flavor object16:58
sean-k-mooneythe main thing you would have to do is look up the cell/instance maping to know which db to update it in for the instnace copy16:58
sean-k-mooneyi would start with the request spec yes and preferably limit it to extra specs that are used by that filter16:59
sean-k-mooneyso extra specs with aggregate_instance_extra_specs: or no namespeace16:59
sean-k-mooneyif you wanted all extra specs to be updated via nova manage in this way i think you would have to update the copy in instnace_extra also17:00
pjakuszewyes I have some preliminary version of that added into nova-manage locally for tests17:02
pjakuszewin current form it iterates over InstanceList and does 'if instance.flavor.extra_specs != flavor.extra_specs: instance.flavor.extra_specs = flavor.extra_specs; instance.save()'17:03
pjakuszewthat was before we talked17:04
pjakuszewnow I know that reqspec.flavor.extra_specs = flavor.extra_specs is the way17:05
pjakuszewand there's a separate command which prints a table of instances that don't have extra_specs matching their flavors17:09
pjakuszewsean-k-mooney: thanks for the help, it is now more clear to me17:11
*** ricolin_ is now known as ricolin17:32
opendevreviewsean mooney proposed openstack/nova-specs master: [WIP] pci device tracking in placment  https://review.opendev.org/c/openstack/nova-specs/+/79104718:50
opendevreviewMerged openstack/nova stable/wallaby: Error anti-affinity violation on migrations  https://review.opendev.org/c/openstack/nova/+/79432818:55
opendevreviewMerged openstack/nova master: Remove references to 'inst_type'  https://review.opendev.org/c/openstack/nova/+/77854821:47

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!