| opendevreview | norman shen proposed openstack/nova master: Saving security group to info_cache https://review.opendev.org/c/openstack/nova/+/786348 | 00:03 |
|---|---|---|
| opendevreview | Merged openstack/nova master: libvirt: Set driver_iommu when attaching virtio devices to SEV instance https://review.opendev.org/c/openstack/nova/+/794639 | 00:53 |
| opendevreview | melanie witt proposed openstack/nova master: Add test coverage for API version headers in CORS https://review.opendev.org/c/openstack/nova/+/796580 | 02:19 |
| opendevreview | melanie witt proposed openstack/nova master: Add test coverage for API version headers in CORS https://review.opendev.org/c/openstack/nova/+/796580 | 02:19 |
| kevinz | Hi lyarwood, would be really appreciated if you can help to review this for live migrate on Arm64: https://review.opendev.org/c/openstack/nova/+/763928, the patch has been updated | 06:17 |
| opendevreview | Balazs Gibizer proposed openstack/os-resource-classes master: Add packet rate related resource classes https://review.opendev.org/c/openstack/os-resource-classes/+/796591 | 06:56 |
| gibi | stephenfin: do you have an example how to backport db migrations with alembic? | 06:58 |
| *** rpittau|afk is now known as rpittau | 07:15 | |
| opendevreview | Balazs Gibizer proposed openstack/placement master: Bump os-resource-classes deps to 1.0.0 https://review.opendev.org/c/openstack/placement/+/796593 | 07:28 |
| gibi | stephenfin, melwitt: it is a trivial bump to keep the modules in sync ^^ | 07:31 |
| opendevreview | Balazs Gibizer proposed openstack/placement master: Bump os-resource-classes requirements https://review.opendev.org/c/openstack/placement/+/796595 | 07:36 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | 07:45 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | 07:45 |
| yonglihe | gibi, alex_xu had reviewed the smart nic patch set several rounds, and about to review another round, just after i add more functional/unit test. | 07:47 |
| gibi | yonglihe: OK. I will try to look at the patches as promised on the meeting yesterday | 07:58 |
| yonglihe | thanks. | 07:59 |
| *** elodilles is now known as elodilles_afk | 08:10 | |
| opendevreview | liujiong proposed openstack/nova master: Do not create attachment for old root volume https://review.opendev.org/c/openstack/nova/+/795950 | 08:20 |
| gibi | lyarwood: FYI limestone is now disabled https://review.opendev.org/c/openstack/project-config/+/796590 due to mirror issues. We only saw https://review.opendev.org/c/openstack/project-config/+/796590 from limestone so that issue hopefuly removed from the active gate faliures | 08:42 |
| gibi | I wanted to link to the bug https://bugs.launchpad.net/nova/+bug/1931864 | 08:43 |
| opendevreview | Lee Yarwood proposed openstack/nova stable/wallaby: libvirt: Set driver_iommu when attaching virtio devices to SEV instance https://review.opendev.org/c/openstack/nova/+/796607 | 08:44 |
| stephenfin | gibi: alembic is a bit different. You don't need placeholders since the migrations don't have to be applied linearly. Each migration encodes its predecessor inline, so you could backport the new migration and simply rework the other migrations either side | 08:54 |
| stephenfin | I haven't spent a long time thinking about it though. We haven't backported a migration in 4 or 5 years now, iirc | 08:55 |
| gibi | stephenfin: I got a pointer from slaweq how neutron did it supporting a downstream backport in https://review.opendev.org/c/openstack/neutron/+/601336/92/neutron/db/migration/alembic_migrations/versions/xena/expand/d863c3bdc0c5_add_active_allowed_address_pairs.py | 08:57 |
| gibi | stephenfin: so they needed to prepare the patch on master to be conditional | 08:57 |
| gibi | i.e. not to fail on if the change already applied | 08:57 |
| gibi | I have to run now but we can talk about it later | 08:58 |
| stephenfin | okay, no worries. We'll just have to document it, I suppose | 08:58 |
| * stephenfin was planning to bug zzzeek if this ever actually came up :) | 08:58 | |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Remove dead code https://review.opendev.org/c/openstack/nova/+/786291 | 09:12 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Remove 'nova.db.sqlalchemy.utils' https://review.opendev.org/c/openstack/nova/+/786292 | 09:12 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Remove unused DB methods https://review.opendev.org/c/openstack/nova/+/786293 | 09:12 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Use module-level imports for sqlalchemy https://review.opendev.org/c/openstack/nova/+/786295 | 09:12 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Fold in indexes https://review.opendev.org/c/openstack/nova/+/786296 | 09:12 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Fold in ForeignKey constraints https://review.opendev.org/c/openstack/nova/+/786297 | 09:12 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Remove 'nova.db.base' module https://review.opendev.org/c/openstack/nova/+/786298 | 09:13 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Copy docs from 'nova.db.*' to 'nova.db.sqlalchemy.*' https://review.opendev.org/c/openstack/nova/+/786299 | 09:13 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Synchronize function signatures https://review.opendev.org/c/openstack/nova/+/786300 | 09:13 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Clean up migration code https://review.opendev.org/c/openstack/nova/+/786301 | 09:13 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Use module-level imports for sqlalchemy (for real) https://review.opendev.org/c/openstack/nova/+/796519 | 09:13 |
| opendevreview | Lee Yarwood proposed openstack/nova stable/victoria: libvirt: Set driver_iommu when attaching virtio devices to SEV instance https://review.opendev.org/c/openstack/nova/+/796611 | 09:19 |
| opendevreview | Lee Yarwood proposed openstack/nova stable/ussuri: libvirt: Set driver_iommu when attaching virtio devices to SEV instance https://review.opendev.org/c/openstack/nova/+/796618 | 09:44 |
| kashyap | sean-k-mooney[m]: Hey, remind me again: do you think we can set a different display device based on guest's capabilities? E.g. if the guest has a virtio-gpu driver, use "virtio-vga" and so on | 09:49 |
| stephenfin | lyarwood, gibi: bauzas is out for all of this week, right? Could I ask you to work through that DB series before it goes into merge conflict again. It's very trivial, if that helps (mostly moving things around in prep for alembic) | 10:06 |
| bauzas | no, I'm here | 10:06 |
| alex_xu | gibi: I reviewed few around on first three patches, since the major logic on the the thrid one. | 10:07 |
| bauzas | I was just having a conflict for the upstream meeting | 10:07 |
| stephenfin | bauzas: oh, sorry /o\ in that case, I might ask you to take a look also, if you can :) | 10:07 |
| bauzas | stephenfin: yup, I can do it | 10:07 |
| stephenfin | great, ty | 10:08 |
| * bauzas will have some PTOs in July, that's it ;) | 10:08 | |
| stephenfin | elodilles_afk: lyarwood: melwitt: Now that we have the cherry-pick check to prevent us backporting a change out-of-order, would it make sense to start approving a whole series of backports at once and relying on said check to prevent out-of-order merges? | 10:10 |
| *** bhagyashris_ is now known as bhagyashris | 10:27 | |
| lyarwood | stephenfin: sorry was on a call, happy to help with the DB series. We can but until the parent branch changes have landed the SHAs can still change but I guess that's the case either way. I'd be happy justifying +W'ing something if the parent is already W'd tbh. | 10:29 |
| stephenfin | doesn't the cherry-pick script take care of that? | 10:29 |
| stephenfin | the SHAs | 10:29 |
| lyarwood | Yeah checking them, it doesn't automatically update anything | 10:29 |
| lyarwood | I was agreeing that we may as well ACK things all the way down and rely on the script | 10:30 |
| stephenfin | ah, okay, yeah, that's my thinking | 10:30 |
| bauzas | in general, we prefer to hold stable changes until master merges | 10:30 |
| bauzas | as indeed SHA1s can change | 10:30 |
| lyarwood | right stephenfin's point is after that on stable | 10:30 |
| stephenfin | oh, I'm not arguing for approving before master is merged | 10:30 |
| lyarwood | instead of waiting for each branch to merge | 10:30 |
| stephenfin | we should definitely wait for that | 10:30 |
| lyarwood | there is a potential race at that point stephenfin | 10:31 |
| lyarwood | the older branches having less CI | 10:31 |
| bauzas | stephenfin: sorry if i misunderstood, your concern is about a series ? | 10:31 |
| lyarwood | will fail first | 10:31 |
| lyarwood | because the newer branches haven't merged the required change | 10:31 |
| stephenfin | bauzas: I'm suggesting if you have a patch backported from stable/wallaby to stable/train, we can approve all of them at once and rely on the pep8 job to ensure they go in in the correct order | 10:32 |
| opendevreview | Sylvain Bauza proposed openstack/nova-specs master: Add generic mdevs to Nova https://review.opendev.org/c/openstack/nova-specs/+/792796 | 10:32 |
| lyarwood | I'm fine with it, it's just going to take a few rechecks still | 10:32 |
| bauzas | stephenfin: ah that | 10:33 |
| stephenfin | ah yeah, there's going to be a recheck anyway | 10:33 |
| lyarwood | what's life without 20 rechecks | 10:33 |
| stephenfin | since the pep8 job will fail on everything older than stable/wallaby | 10:33 |
| lyarwood | yup | 10:33 |
| bauzas | well, in general, I'm holding approvals until the original branch merges | 10:33 |
| stephenfin | but it's easy to recheck one by one | 10:33 |
| bauzas | as they can be races | 10:33 |
| bauzas | there* | 10:33 |
| stephenfin | certainly easier than asking stable cores every few days to review the latest stable branch | 10:34 |
| stephenfin | bauzas: again, no issues holding off on approving (or even reviewing) backports until the master change has landed | 10:34 |
| stephenfin | but the pep8 job means that e.g. a stable/train change simply can't land before the stable/ussuri one now | 10:35 |
| stephenfin | even if +Wd | 10:35 |
| bauzas | oh, I see your point | 10:35 |
| bauzas | well, then sure | 10:35 |
| stephenfin | I just want to avoid having to continuously poll stable cores as each stable branch lands, particularly since I'm typically going back to Train (so that's four instances of polling, at a minimum :)) | 10:36 |
| lyarwood | the only issue I have personally is that it breaks my review dashboards | 10:36 |
| lyarwood | as they rely on reviews being +1'd | 10:37 |
| lyarwood | but I guess someone is asking us to review a given topic here making it easier | 10:37 |
| lyarwood | and/or change-id | 10:37 |
| stephenfin | yeah, I'd like it if we could use something other than the verified label for this | 10:38 |
| stephenfin | like a Parent-Merged label, without which zuul wouldn't merge the patch (so like Verified in that way). I don't know how hard that is though. I don't know if a zuul job can set a label other than verified | 10:39 |
| stephenfin | however, as things stand, the dashboard is already broken so nothing has changed, right lyarwood? | 10:40 |
| stephenfin | because of the pep8 fail | 10:40 |
| lyarwood | yeah correct things are hidden | 10:41 |
| lyarwood | tinyurl.com/f9y6vr6d for example | 10:41 |
| lyarwood | tbh I could just change them to drop the +1 requirement | 10:42 |
| lyarwood | but then it gets a little mad | 10:42 |
| stephenfin | I can imagine | 10:42 |
| lyarwood | I still use https://review.opendev.org/q/project:openstack/nova+branch:%5Estable/.*+status:open from time to time to check everything | 10:43 |
| * stephenfin tries to figure out what causes zuul to set the Verified label as opposed to something else | 10:43 | |
| stephenfin | oh, zuul itself | 10:44 |
| stephenfin | https://opendev.org/zuul/zuul/src/branch/master/doc/source/examples/pipelines/gerrit-reference-pipelines.yaml | 10:44 |
| stephenfin | so we'd need a new pipeline | 10:44 |
| lyarwood | it would be nice to have something else the script could set tbh | 10:44 |
| stephenfin | the other option is to have a separate "CI" running that particular job, so you could filter on that instead | 10:45 |
| stephenfin | i.e. -1 by $PEP8_CI | 10:46 |
| stephenfin | again, no idea how difficult that is. I suspect that name is global to the deployment | 10:46 |
| stephenfin | oh, we could just move it to a separate job in the gate queue? | 10:48 |
| stephenfin | instead of the check queue | 10:48 |
| lyarwood | yeah I'm cool with that | 10:51 |
| lyarwood | well it would have to be non-voting, slightly defeating the purpose of the script | 10:51 |
| stephenfin | would it? The check job would now report +1 but the gate job would -2 if the parent wasn't merged | 10:52 |
| lyarwood | Ah sorry I see what you're suggesting now | 10:53 |
| lyarwood | Okay yeah that could work well in that case | 10:53 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Move 'check-cherry-picks' test to gate https://review.opendev.org/c/openstack/nova/+/796626 | 11:04 |
| stephenfin | lyarwood: ^ | 11:04 |
| sean-k-mooney | kashyap: no we cant know the guest capablites in advance | 11:05 |
| kashyap | sean-k-mooney: Hmm, okay; I have a couple more questions. But I'm on a call, will come back to them in a bit. | 11:06 |
| sean-k-mooney | kashyap: the closest thing w have to that is libosinfo but that is not a greate approch in my view | 11:06 |
| sean-k-mooney | ack | 11:06 |
| kashyap | Right; 'libosinfo' was what I was thinking; why isn't it feasible? Do outline your thoughts here; will come back and read | 11:07 |
| sean-k-mooney | we have libosinfo "support" today but its not machine type aware and it does not know if you have the driver avaiable | 11:09 |
| sean-k-mooney | they also can change the hardware modeles over time which has broken us in the past | 11:09 |
| sean-k-mooney | and it currently missues the image propety fields | 11:09 |
| sean-k-mooney | it forches you to put the version in the os name field ignoring the os_version field | 11:10 |
| sean-k-mooney | so have to do os_name rhel8 not os_name rhel os_version 8 | 11:10 |
| sean-k-mooney | so it breaks the standard usage of that attribute | 11:10 |
| sean-k-mooney | the lib osinfo devs assume that the xml will be persisted so its ok for them to break compatiablity and change the resules in later versions | 11:11 |
| sean-k-mooney | that is not how openstack works | 11:11 |
| sean-k-mooney | libosinfo also has no awareness of the libvirt verison installed on the system as far as i am aware so it does not know if the models are supported by the libvirt/qemu installed | 11:12 |
| lyarwood | stephenfin: LGTM | 11:12 |
| sean-k-mooney | this is why i recommend that no one ever use this feature and why i have suggested removing it in the past | 11:12 |
| lyarwood | stephenfin: wait, the `deps =` line in the tox env isn't a mistake is it? | 11:14 |
| * lyarwood can't recall if that's just ignored | 11:15 | |
| sean-k-mooney | lyarwood: i belive that ill install no deps | 11:16 |
| sean-k-mooney | which in this case is fine | 11:16 |
| sean-k-mooney | we just need bash | 11:16 |
| lyarwood | yeah wasn't sure if tox would bork at it tis all | 11:17 |
| sean-k-mooney | well the ci will tell us | 11:17 |
| sean-k-mooney | lyarwood: stephenfin why are we doing this by the way | 11:18 |
| sean-k-mooney | i agree we can do this but i dont expect this to really save much time in the gate | 11:18 |
| lyarwood | sean-k-mooney: it should save at least one check run per backport | 11:19 |
| lyarwood | sean-k-mooney: but really this is more about allowing stable cores to see acceptable backports earlier | 11:19 |
| lyarwood | sean-k-mooney: so instead of them getting -1'd by the cherry pick script they just get held by the gate | 11:19 |
| sean-k-mooney | ya so reading the commit message im not sure i buy that | 11:19 |
| sean-k-mooney | but the 1 recheck i guess makes sense | 11:20 |
| sean-k-mooney | althoguh we are loosing one thing that would be nice to keep | 11:20 |
| sean-k-mooney | which is check that backports to stable acutlly are a backport or have stable only | 11:20 |
| lyarwood | we still get that, it's just in the gate now | 11:20 |
| sean-k-mooney | yep which is too late | 11:21 |
| lyarwood | tbh we could make this non voting in the check queue | 11:21 |
| sean-k-mooney | it should tell author that are unfamilar with our policy in check | 11:21 |
| sean-k-mooney | this new job | 11:21 |
| sean-k-mooney | that would work for me | 11:21 |
| lyarwood | yeah | 11:21 |
| lyarwood | stephenfin: ^ is that okay? | 11:21 |
| sean-k-mooney | it lest you know if it will fail but no need to recheck it | 11:21 |
| admin1 | where is the live_migration_downtime defined ? | 11:59 |
| admin1 | is it on kvm or in nova ? | 11:59 |
| sean-k-mooney | admin1: nova has options that we pass to libvirt which then modulates the qemu downtime | 12:01 |
| sean-k-mooney | admin1: https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.live_migration_downtime | 12:01 |
| sean-k-mooney | admin1: nova is not direcly involved in managing the vm during the livemigration | 12:01 |
| sean-k-mooney | we invoke libvirt wiht a set of parmaters and then wait for ti to complete | 12:02 |
| sean-k-mooney | melwitt: i think this is all you need to fix in the backports for bionic by the way https://review.opendev.org/c/openstack/nova/+/795433/1/roles/run-evacuate-hook/tasks/main.yaml#44 | 12:04 |
| sean-k-mooney | well and lines 67-69 | 12:05 |
| sean-k-mooney | the version of libvirt in bionic does not support socket activation so we just need to remove the socket lines | 12:05 |
| admin1 | sean-k-mooney, so i just need to add those lines in nova.conf, restart the compute service ( systemctl ) and thats it ? | 12:11 |
| admin1 | are those lines only needed in the actual compute nodes, or in the whole cluster ( nova scheduler, api etc ) ? | 12:11 |
| sean-k-mooney | they are used on the source compute i think | 12:12 |
| sean-k-mooney | so all the comptues that you want to tune | 12:12 |
| admin1 | do they go under libvirt or under default ? | 12:12 |
| sean-k-mooney | but i do not think they are used by any other services | 12:13 |
| sean-k-mooney | they are in the libvirt section | 12:13 |
| admin1 | libvirt. ( dot ) means its under libvirt i guess | 12:13 |
| sean-k-mooney | yes | 12:13 |
| sean-k-mooney | it does | 12:13 |
| sean-k-mooney | so update the configs on the computes restart compute services and it will take effect | 12:13 |
| admin1 | does these value make sense: live_migration_downtime: 5000 # ( default 500) && live_migration_downtime_steps: 20 # default (10) && live_migration_completion_timeout: 8000 # (default 800) | 12:20 |
| admin1 | don't want to corrupt the instance , ram etc | 12:21 |
| opendevreview | Lee Yarwood proposed openstack/nova stable/train: libvirt: Set driver_iommu when attaching virtio devices to SEV instance https://review.opendev.org/c/openstack/nova/+/796642 | 12:28 |
| *** elodilles_afk is now known as elodilles | 13:04 | |
| opendevreview | Stephen Finucane proposed openstack/nova stable/train: Reproduce bug 1897528 https://review.opendev.org/c/openstack/nova/+/792116 | 13:13 |
| opendevreview | Stephen Finucane proposed openstack/nova stable/train: Ignore PCI devices with 32bit domain https://review.opendev.org/c/openstack/nova/+/792117 | 13:13 |
| ozzzo | The topic in this channel is a bit unfriendly, and gives bad advice. Nobody is answering questions in #openstack, and this is the correct place to ask Nova questions. Can we change the topic? | 13:40 |
| opendevreview | Lee Yarwood proposed openstack/nova master: Add check job for FIPS https://review.opendev.org/c/openstack/nova/+/790519 | 14:08 |
| sean-k-mooney | ozzzo: the topic is intentional | 14:21 |
| ozzzo | i don't doubt that, but it is still bad advice | 14:21 |
| sean-k-mooney | in the past we have had some user be quite unresonable and demand support form upstream for there sepcific thing | 14:21 |
| lyarwood | stephenfin / gibi ; https://review.opendev.org/c/openstack/nova/+/796523 easy review if you have time | 14:21 |
| sean-k-mooney | ozzzo: #openstack is inteded to be for general quetions | 14:22 |
| ozzzo | it's true that there are idiots on irc, but asking questions in #openstack is a waste of time because nobody who knows any answers is watching there | 14:22 |
| sean-k-mooney | but ill admign i dont tend to have it open | 14:22 |
| ozzzo | I try to help out sometimes but I don't know much | 14:22 |
| sean-k-mooney | i do not monitor it i used to have it open by default but i only responded if i was pingged | 14:22 |
| sean-k-mooney | i shoudl set back up my default chanlles list after the mvoe | 14:23 |
| sean-k-mooney | ozzzo: did you have a question by the way | 14:23 |
| sean-k-mooney | ozzzo: we proably could just remove for support bit | 14:23 |
| ozzzo | I don't, but the other day someone was fruitlessly asking questions in #openstack, and I sent him here, but the message scared him off | 14:23 |
| sean-k-mooney | and just not this is for development mainly | 14:24 |
| ozzzo | *nova questions | 14:24 |
| opendevreview | Lee Yarwood proposed openstack/nova master: tests: Allow bindep and test-setup.sh to run successfully on RHEL https://review.opendev.org/c/openstack/nova/+/796428 | 14:25 |
| sean-k-mooney | its hard to express what type of questions are ok here in a way that is aprochable to new commer but also provides a safty net for peopel to fall back on when peopel are lookign for upstream to provide support for free | 14:25 |
| sean-k-mooney | you know that most of use are happy to help, at least to a point | 14:26 |
| opendevreview | Lee Yarwood proposed openstack/nova master: DNM - Test bindep and test-setup.sh changes against centos8 https://review.opendev.org/c/openstack/nova/+/796684 | 14:31 |
| lyarwood | stephenfin: ^ | 14:32 |
| ganso | lyarwood, melwitt: thanks for the +2+W on the wallaby one! if you could please take a look at the victoria backport now when you have a minute: https://review.opendev.org/c/openstack/nova/+/795542 | 14:43 |
| ganso | bauzas also as reviewed the original patch ^ | 14:43 |
| ganso | thanks in advance | 14:43 |
| bauzas | ganso: ack, opening a new tab | 14:44 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Move 'check-cherry-picks' test to gate, n-v check https://review.opendev.org/c/openstack/nova/+/796626 | 14:52 |
| stephenfin | lyarwood: sean-k-mooney: ^ | 14:53 |
| lyarwood | stephenfin: awesome thanks | 14:54 |
| sean-k-mooney | looks good to me | 14:56 |
| sean-k-mooney | we had the env varable beforefore for downstream? | 14:56 |
| sean-k-mooney | or was it there for another reason | 14:56 |
| sean-k-mooney | having it be a different tox enve removes the need for it but just wondering | 14:57 |
| lyarwood | downstream | 14:57 |
| sean-k-mooney | ack, thats what i tought but was not sure | 14:58 |
| lyarwood | but I never got around to replacing the original hackaround with it | 14:58 |
| lyarwood | the original being to truncate the file | 14:58 |
| lyarwood | \o/ | 14:58 |
| opendevreview | Merged openstack/nova master: tests: Merge flavor tests https://review.opendev.org/c/openstack/nova/+/783662 | 15:07 |
| opendevreview | Merged openstack/nova master: tests: Remove useless mocks https://review.opendev.org/c/openstack/nova/+/778730 | 15:08 |
| admin1 | if vms ( backed up by ceph) fail to live migrate, is a pause + migrate enough .. or they need to be shutdown and then migrated ? | 15:10 |
| admin1 | i used this setting: live_migration_downtime: 10000 ; live_migration_downtime_steps: 20 ; live_migration_downtime_delay: 100 ; live_migration_completion_timeout: 15000 | 15:11 |
| admin1 | which helped 8 stuck instances to migrate .. 2 fail to migrate no matter what | 15:11 |
| opendevreview | Lee Yarwood proposed openstack/nova master: tests: Allow bindep and test-setup.sh to run on EL distros https://review.opendev.org/c/openstack/nova/+/796428 | 15:41 |
| opendevreview | Lee Yarwood proposed openstack/nova master: DNM - Test bindep and test-setup.sh changes against centos8 https://review.opendev.org/c/openstack/nova/+/796684 | 15:41 |
| opendevreview | Merged openstack/nova master: Allow X-OpenStack-Nova-API-Version header in CORS https://review.opendev.org/c/openstack/nova/+/796319 | 15:49 |
| opendevreview | Merged openstack/nova master: tests: Remove duplicate policy tests https://review.opendev.org/c/openstack/nova/+/778731 | 15:49 |
| melwitt | ganso: ack will do | 15:50 |
| sean-k-mooney | admin1: you can jsut do a cloud migrate | 15:51 |
| sean-k-mooney | no need to pause | 15:51 |
| melwitt | sean-k-mooney: ack thanks for the hint | 15:52 |
| sean-k-mooney | or you can do a live migrate with a force complete call | 15:52 |
| sean-k-mooney | force-complete will pause the vm | 15:52 |
| admin1 | oh .. ok | 15:52 |
| admin1 | openstack server migrate --help .. there is no such parameter ( force-complete) | 15:53 |
| sean-k-mooney | https://docs.openstack.org/api-ref/compute/?expanded=force-migration-complete-action-force-complete-action-detail#force-migration-complete-action-force-complete-action | 15:54 |
| sean-k-mooney | "openstack server migration force complete" is the comand | 15:55 |
| sean-k-mooney | sean@p50:~$ openstack help server migration force complete | 15:55 |
| sean-k-mooney | usage: openstack server migration force complete [-h] <server> <migration> | 15:55 |
| sean-k-mooney | Force an ongoing live migration to complete. This command requires ``--os-compute-api-version`` 2.22 or greater. | 15:55 |
| sean-k-mooney | positional arguments: | 15:56 |
| sean-k-mooney | <server> Server (name or ID) | 15:56 |
| sean-k-mooney | <migration> Migration (ID) | 15:56 |
| sean-k-mooney | so basically you have to start the live migration | 15:56 |
| sean-k-mooney | then you can get the migration id and then force the completeion of the live migation | 15:56 |
| sean-k-mooney | melwitt: sorry dont rememebr the context of that but if the hint? helpped im glad | 15:57 |
| sean-k-mooney | oh | 15:57 |
| sean-k-mooney | melwitt: the socket activation? | 15:58 |
| melwitt | sean-k-mooney: haha yeah the fixing for bionic thing | 15:58 |
| melwitt | stephenfin, lyarwood, bauzas: I'm meh about approving older branches before the newer one merges, I don't think it solves the ping problem. in my case it's just I don't always remember to review all the older versions and I don't often like to do them all at the same time anyway | 16:00 |
| stephenfin | I figured it would solve the ping problem, or at least significantly reduce it | 16:01 |
| stephenfin | in theory, if all branches were approved, one could get them merged by a simple recheck | 16:01 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | 16:05 |
| melwitt | yeah. I guess one potential thing that could happen is if the author/rechecker doesn't realize they can't merge out of order and they go on a recheck loop in the wrong order. I have seen that before anyway but I'd imagine it's more tempting when you see the shiny +W on there | 16:05 |
| admin1 | sean-k-mooneythanks .. it worked | 16:10 |
| *** rpittau is now known as rpittau|afk | 16:11 | |
| opendevreview | Merged openstack/nova master: Retry lvm volume and volume group query https://review.opendev.org/c/openstack/nova/+/796269 | 16:22 |
| opendevreview | Stephen Finucane proposed openstack/nova stable/wallaby: Retry lvm volume and volume group query https://review.opendev.org/c/openstack/nova/+/796707 | 16:31 |
| stephenfin | le sigh https://storyboard.openstack.org/#!/story/2008549 | 16:59 |
| stephenfin | "I set the state of my shelved offloaded instance to active and it broke things" | 17:00 |
| lyarwood | lol | 17:01 |
| melwitt | lol | 17:01 |
| melwitt | we need a required option on set state like --I-acknowledge-this-might-break-something | 17:02 |
| * melwitt loves the --yes-i-really-mean-it option in ceph | 17:02 | |
| lyarwood | -i-really-know-what-im-doing-and-if-this-breaks-anything-i-am-to-blame | 17:03 |
| melwitt | 😂 yeah the longer the option, the better | 17:03 |
| melwitt | realistically, we should put a big fat warning in the set state help that says something similar. if there already is one, then ... :| | 17:05 |
| lyarwood | I think there might be in the api-ref but yeah osc could say more | 17:06 |
| stephenfin | melwitt: lyarwood: 96707 | 17:12 |
| stephenfin | <stephenfin> le sigh https://storyboard.openstack.org/#!/story/2008549 | 17:12 |
| stephenfin | <stephenfin> "I set the state of my shelved offloaded instance to active and it broke things" | 17:12 |
| stephenfin | * derekh has quit (Quit: Leaving) | 17:12 |
| stephenfin | whoops | 17:12 |
| stephenfin | lyarwood: melwitt: https://review.opendev.org/c/openstack/python-openstackclient/+/796713 | 17:12 |
| stephenfin | (HexChat copies whatever you highlight to the clipboard) | 17:12 |
| melwitt | sweet | 17:15 |
| lyarwood | stephenfin: that could've been so much worse ^_^ | 17:20 |
| opendevreview | Merged openstack/nova stable/victoria: Error anti-affinity violation on migrations https://review.opendev.org/c/openstack/nova/+/795542 | 17:30 |
| opendevreview | Merged openstack/placement master: Bump os-resource-classes deps to 1.0.0 https://review.opendev.org/c/openstack/placement/+/796593 | 17:31 |
| sean-k-mooney | admin1: useing force complete cool | 17:39 |
| sean-k-mooney | admin1: that makes it a semi live migration | 17:40 |
| sean-k-mooney | the vm does not restart or anythng but it proably will notice its clock is wrong and or drop packets | 17:40 |
| sean-k-mooney | so normally we avoid that but its good to know its an option when you really need to move soemthing and is still friendlier then a cold migrate | 17:41 |
| sean-k-mooney | why is that in story board | 17:41 |
| sean-k-mooney | and ya we had a downstream issue to the same effect recently | 17:42 |
| sean-k-mooney | melwitt: i wonder if we should actully consier blocking that in the api | 17:42 |
| sean-k-mooney | its never valide to reset state form shelve offloaded to any other state then error | 17:43 |
| sean-k-mooney | lyarwood: stephenfin melwitt by the way we still have a todo item somehwer to extend the reset state api to allow more states and to allow settign the task_state too | 17:45 |
| sean-k-mooney | if we do that we should harden the allowed state transations IMO | 17:46 |
| melwitt | sean-k-mooney: yeah... conflicted about that because reset state is kind of a wild west api call to make but on the other hand if we can block something that's guaranteed to be invalid, that makes sense too | 17:46 |
| sean-k-mooney | e.g. ERROR we woudl allow to go to any sate as an escape hatch. but any none ERROR state should not be changable arbitrailly | 17:46 |
| sean-k-mooney | melwitt: im pretty sure it can result in data lose | 17:47 |
| sean-k-mooney | if you do resetstat form shelve offloaded and then do either hard reboot or a migration i cant rememebr which | 17:48 |
| melwitt | ? | 17:48 |
| sean-k-mooney | we had a customer do that with ceph recently | 17:48 |
| sean-k-mooney | and they lost the snapshot | 17:48 |
| melwitt | I guess I'm not realizing how that happens. if it's shelved offloaded there's no guest to reboot | 17:49 |
| *** ricolin_ is now known as ricolin | 17:49 | |
| sean-k-mooney | yes so if i rememebr correctly unshleve failed so the reset state then hard rebooted | 17:49 |
| sean-k-mooney | that failed because no host | 17:50 |
| sean-k-mooney | the then reset state again and tired to shleve i think? this is where my memory is blank | 17:50 |
| sean-k-mooney | when we got the bz they had tried some cobination of that several times | 17:51 |
| sean-k-mooney | and the rbd volume was nolonger preset for the vm root disk | 17:51 |
| melwitt | ah ok, so you're saying if we prevent that path from even starting, it can avoid whatever future thing they managed to do to lose the data | 17:52 |
| sean-k-mooney | yes | 17:52 |
| melwitt | yeah ok | 17:52 |
| opendevreview | Rodrigo Barbieri proposed openstack/nova stable/ussuri: Error anti-affinity violation on migrations https://review.opendev.org/c/openstack/nova/+/796719 | 17:58 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!