Monday, 2021-06-14

*** bhagyashris__ <bhagyashris__!~bhagyashr@103.98.79.86> has joined #openstack-nova01:51
*** bhagyashris_ <bhagyashris_!~bhagyashr@103.98.79.86> has quit IRC (Ping timeout: 480 seconds)01:58
*** priteau <priteau!~priteau@93.186.40.84> has quit IRC (Ping timeout: 480 seconds)02:04
*** priteau <priteau!~priteau@93.186.40.84> has joined #openstack-nova02:06
*** vishalmanchanda <vishalmanchanda!uid326448@id-326448.charlton.irccloud.com> has joined #openstack-nova04:40
gibigood morning05:16
gibiearly cores, can we turn on mypy now https://review.opendev.org/c/openstack/nova/+/795973 ?05:16
gibithe missing requirement for mpyp 0.9 has been merged over the weekend05:17
*** abhishekk <abhishekk!~akekane@116.74.162.143> has joined #openstack-nova05:18
*** ratailor_ <ratailor_!~ratailor@103.115.207.241> has joined #openstack-nova05:43
*** ratailor_ is now known as ratailor05:48
*** ralonsoh <ralonsoh!~ralonsoh@36.red-79-150-231.dynamicip.rima-tde.net> has joined #openstack-nova06:02
*** iurygregory_ <iurygregory_!~iurygrego@2a02:8308:a007:3900:93ab:1c8f:2b9e:9349> has joined #openstack-nova06:07
*** iurygregory|afk <iurygregory|afk!~iurygrego@ip-86-49-241-46.net.upcbroadband.cz> has quit IRC (Read error: Connection reset by peer)06:07
*** icey <icey!~icey@0001bbad.user.oftc.net> has quit IRC ()06:18
*** icey <icey!~icey@0001bbad.user.oftc.net> has joined #openstack-nova06:18
*** bhagyashris__ is now known as bhagyashris06:36
*** rpittau|afk is now known as rpittau07:07
*** luksky <luksky!~luksky@hC1F2D42A.cust.netmar.net.pl> has joined #openstack-nova07:16
*** tkajinam <tkajinam!~tkajinam@240d:1a:6af:1b00:3462:14d1:c5f6:8946> has quit IRC (Quit: Leaving)07:16
*** tkajinam <tkajinam!~tkajinam@240d:1a:6af:1b00:3462:14d1:c5f6:8946> has joined #openstack-nova07:17
*** andrewbonney <andrewbonney!uid417545@id-417545.highgate.irccloud.com> has joined #openstack-nova07:21
*** tosky <tosky!~luigi@dynamic-adsl-78-13-253-141.clienti.tiscali.it> has joined #openstack-nova07:45
bauzasgibi: I could do it but...07:47
gibibut? :)07:47
gibiahh, you are the author07:47
bauzas;)07:47
gibiyou tricked me :)07:48
bauzasgibi: just do a fast approval07:48
gibiI think stephenfin will be up soon07:48
bauzaswell ok07:49
*** lucasagomes <lucasagomes!~lucasagom@89.100.20.18> has joined #openstack-nova07:55
*** CeeMac <CeeMac!uid366483@id-366483.brockwell.irccloud.com> has joined #openstack-nova08:05
*** elodilles is now known as elodilles_afk08:05
*** derekh <derekh!~derekh@2a01:b340:80:9a52:6423:15e0:3703:2> has joined #openstack-nova08:12
*** whoami-rajat <whoami-rajat!uid314320@id-314320.brockwell.irccloud.com> has joined #openstack-nova08:14
lyarwood+W'd08:37
lyarwoodlooking at https://bugs.launchpad.net/nova/+bug/1931716 now btw08:38
opendevreviewWenping Song proposed openstack/nova master: Replaces tenant_id with project_id from Rebuild Server API  https://review.opendev.org/c/openstack/nova/+/76638008:41
opendevreviewWenping Song proposed openstack/nova master: Replaces tenant_id with project_id from List SG API  https://review.opendev.org/c/openstack/nova/+/76672608:42
opendevreviewWenping Song proposed openstack/nova master: Replaces tenant_id with project_id from Flavor Access APIs  https://review.opendev.org/c/openstack/nova/+/76770408:43
opendevreviewWenping Song proposed openstack/nova master: Replaces tenant_id with project_id from List/Show usage APIs  https://review.opendev.org/c/openstack/nova/+/76850908:44
gibilyarwood: thanks. I pushed a small patch with debug log to see what is the error code libvirt sends https://review.opendev.org/c/openstack/nova/+/79604308:44
kashyapHmm, it's this disk not found thing ... I have a deja vu of this w/ device-detach08:48
gibikashyap: yes, it is totally deja vus08:49
* kashyap nods; morning, folks08:50
gibimorning08:50
lyarwoodI called out some commits in https://review.opendev.org/c/openstack/nova/+/741561 that seemed to show we were using VIR_ERR_DEVICE_MISSING now so I'm slightly confused by this08:52
lyarwoodunless someone reverted some of this in libvirt08:53
lyarwoodhttps://libvirt.org/git/?p=libvirt.git;a=blobdiff;f=src/qemu/qemu_hotplug.c;h=5be3e0659ad749e7e8a3585f6b98e2f218f34059;hp=a62dbe79e5650b051f02bb059afbd251b296b899;hb=126db34a81bc9f9f9710408f88cceaa1e34bbbd7;hpb=bb189c8e8c93f115c13fa3bfffdf64498f3f0ce1 for example08:53
gibilyarwood: I think we can wait until I can reproduce the problem with the extra debug log to is what is the error code, then after that I can add that code to the handler in nova08:55
gibis/to is/to see/08:55
lyarwoodack yeah and I'll have a quick look at the libvirt code to see what's changed if anything08:57
gibiack, thanks08:57
lyarwoodhttps://github.com/libvirt/libvirt/blob/55ea45acc99c549c7757efe954aacc33ad30a8ef/src/qemu/qemu_hotplug.c#L5324-L5328 yeah it didn't change all the paths09:03
lyarwoodgah!09:03
lyarwoodthat's the one I'm assuming we are hitting here tbh09:03
gibijepp, that could be the case09:10
gibithen I will prepare a commit adding handler for it09:10
*** abhishekk <abhishekk!~akekane@116.74.162.143> has quit IRC (Quit: Bye...)09:19
*** Luzi <Luzi!~Luzi@ipservice-092-208-056-099.092.208.pools.vodafone-ip.de> has joined #openstack-nova09:47
*** MrClayPole <MrClayPole!~quassel@2a02:8010:6538:104:216:3eff:fed5:272f> has joined #openstack-nova10:00
opendevreviewJorhson Deng proposed openstack/nova master: remove the redundant code for attach interface  https://review.opendev.org/c/openstack/nova/+/79620810:10
opendevreviewJorhson Deng proposed openstack/nova master: recheck the attachment_id after the reschedule successful reference: https://opendev.org/openstack/nova/src/branch/master/nova/compute/manager.py#L2897  https://review.opendev.org/c/openstack/nova/+/79620910:13
opendevreviewJorhson Deng proposed openstack/nova master: recheck the attachment_id after the reschedule successful  https://review.opendev.org/c/openstack/nova/+/79620910:14
lyarwoodgibi: https://listman.redhat.com/archives/libvir-list/2021-June/msg00337.html FWIW10:19
gibilyarwood: awesome10:20
gibithanks10:20
gibiI'm just writing the unit test for the nova patch10:20
opendevreviewBalazs Gibizer proposed openstack/nova master: Handle OPERATION_FAILED error during detach  https://review.opendev.org/c/openstack/nova/+/79625510:35
*** ratailor_ <ratailor_!~ratailor@2409:4052:2204:5df:d46:7ddd:22bd:3dc0> has joined #openstack-nova10:40
*** ratailor_ <ratailor_!~ratailor@2409:4052:2204:5df:d46:7ddd:22bd:3dc0> has quit IRC (Remote host closed the connection)10:40
gibilyarwood: ^^10:41
lyarwoodack looking10:41
lyarwoodLGTM10:45
*** ratailor_ <ratailor_!~ratailor@103.115.207.228> has joined #openstack-nova10:46
*** ratailor <ratailor!~ratailor@103.115.207.241> has quit IRC (Ping timeout: 480 seconds)10:46
*** mgariepy <mgariepy!~mgariepy@0002bc4d.user.oftc.net> has quit IRC (Ping timeout: 480 seconds)10:55
opendevreviewLee Yarwood proposed openstack/nova stable/wallaby: virt: Add destroy_secrets kwarg to destroy and cleanup  https://review.opendev.org/c/openstack/nova/+/79625711:00
opendevreviewLee Yarwood proposed openstack/nova stable/wallaby: libvirt: Do not destroy volume secrets during _hard_reboot  https://review.opendev.org/c/openstack/nova/+/79625811:00
opendevreviewLee Yarwood proposed openstack/nova stable/victoria: virt: Add destroy_secrets kwarg to destroy and cleanup  https://review.opendev.org/c/openstack/nova/+/79625911:01
opendevreviewLee Yarwood proposed openstack/nova stable/victoria: libvirt: Do not destroy volume secrets during _hard_reboot  https://review.opendev.org/c/openstack/nova/+/79626011:01
opendevreviewLee Yarwood proposed openstack/nova stable/ussuri: virt: Add destroy_secrets kwarg to destroy and cleanup  https://review.opendev.org/c/openstack/nova/+/79626211:05
opendevreviewLee Yarwood proposed openstack/nova stable/ussuri: Detach is broken for multi-attached fs-based volumes  https://review.opendev.org/c/openstack/nova/+/79626311:05
opendevreviewLee Yarwood proposed openstack/nova stable/ussuri: libvirt: Do not destroy volume secrets during _hard_reboot  https://review.opendev.org/c/openstack/nova/+/79626411:05
stephenfinlyarwood: elodilles_afk: Could you folks stick https://review.opendev.org/c/openstack/os-vif/+/765967 and its relatives on the stable review list for this week?11:09
lyarwoodack11:09
stephenfinta11:09
lyarwooddidn't we say that the os-vif cores were going to end up as stable cores?11:10
lyarwoodah lunch is ready, I'll get to this afterwards brb11:10
stephenfinI thought we did but we haven't made the change yet11:10
stephenfinnw11:10
*** elodilles_afk is now known as elodilles11:17
elodillesstephenfin: sure, will review as soon as I get there :)11:18
*** smcginnis <smcginnis!~smcginnis@72-50-207-44.fttp.usinternet.com> has quit IRC (Remote host closed the connection)11:27
*** mgoddard- <mgoddard-!~mgoddard@240.240.125.91.dyn.plus.net> has joined #openstack-nova11:35
*** smcginnis <smcginnis!~smcginnis@72-50-207-44.fttp.usinternet.com> has joined #openstack-nova11:37
*** artom <artom!~artom@205.233.59.73> has joined #openstack-nova11:37
*** mgoddard <mgoddard!~mgoddard@238.240.125.91.dyn.plus.net> has quit IRC (Ping timeout: 480 seconds)11:38
*** mgoddard- is now known as mgoddard11:38
opendevreviewBalazs Gibizer proposed openstack/nova master: [func test] create pps resource on OVS agent RP  https://review.opendev.org/c/openstack/nova/+/78720511:39
opendevreviewBalazs Gibizer proposed openstack/nova master: [func test] move port creation to the NeutronFixture  https://review.opendev.org/c/openstack/nova/+/78720611:39
opendevreviewBalazs Gibizer proposed openstack/nova master: [func test] refactor assertPortMatchesAllocation  https://review.opendev.org/c/openstack/nova/+/79245811:39
opendevreviewBalazs Gibizer proposed openstack/nova master: [func test] neutron fixture for extended resource request  https://review.opendev.org/c/openstack/nova/+/79430611:39
opendevreviewBalazs Gibizer proposed openstack/nova master: Detect extended_resource_request neutron API extension  https://review.opendev.org/c/openstack/nova/+/79361811:40
*** smcginnis <smcginnis!~smcginnis@72-50-207-44.fttp.usinternet.com> has quit IRC (Quit: leaving)11:43
*** smcginnis <smcginnis!~smcginnis@72-50-207-44.fttp.usinternet.com> has joined #openstack-nova11:43
opendevreviewBalazs Gibizer proposed openstack/nova master: Reject server create with extended resource req  https://review.opendev.org/c/openstack/nova/+/79361911:44
*** smcginnis <smcginnis!~smcginnis@72-50-207-44.fttp.usinternet.com> has quit IRC ()11:45
*** smcginnis <smcginnis!~smcginnis@72-50-207-44.fttp.usinternet.com> has joined #openstack-nova11:46
opendevreviewBalazs Gibizer proposed openstack/nova master: Reject server operations with extended resource req  https://review.opendev.org/c/openstack/nova/+/79362011:46
opendevreviewBalazs Gibizer proposed openstack/nova master: Add same_subtree field to RequestLevelParams  https://review.opendev.org/c/openstack/nova/+/79150311:48
opendevreviewBalazs Gibizer proposed openstack/nova master: Bump min placement microversion to 1.36  https://review.opendev.org/c/openstack/nova/+/79150411:49
opendevreviewBalazs Gibizer proposed openstack/nova master: Support same_subtree in allocation_canadidate query  https://review.opendev.org/c/openstack/nova/+/79150511:49
opendevreviewBalazs Gibizer proposed openstack/nova master: Support the new port resource_request format  https://review.opendev.org/c/openstack/nova/+/78720811:52
opendevreviewBalazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling  https://review.opendev.org/c/openstack/nova/+/79150611:53
opendevreviewBalazs Gibizer proposed openstack/nova master: [func test] ports with both bw and pps resources  https://review.opendev.org/c/openstack/nova/+/79239411:54
opendevreviewBalazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place  https://review.opendev.org/c/openstack/nova/+/79362111:54
gibilyarwood: are you working on adding a retry to nova.virt.libvirt.storage.lvm.get_volume_group_info due to https://bugs.launchpad.net/nova/+bug/1931710 ? If not then I can jump on that (I just so that error again in a fresh run)(11:55
lyarwoodgibi: I haven't started so if you have the time please go ahead :)11:56
gibithen I go and do it11:56
gibi:)11:56
*** mgariepy <mgariepy!~mgariepy@styx-204.ccs.usherbrooke.ca> has joined #openstack-nova12:09
opendevreviewBalazs Gibizer proposed openstack/nova master: Retry volume group query  https://review.opendev.org/c/openstack/nova/+/79626912:17
gibilyarwood: here it is ^^12:17
*** erlon <erlon!uid7593@id-7593.brockwell.irccloud.com> has joined #openstack-nova12:18
opendevreviewBalazs Gibizer proposed openstack/nova master: Retry lvm volume and volume group query  https://review.opendev.org/c/openstack/nova/+/79626912:37
gibirealized that I saw failures both in case of lvs and vgs queries12:38
lyarwoodYeah indeed sorry the UI didn't refresh in time12:40
* lyarwood < https://matrix.org/_matrix/media/r0/download/matrix.org/XfLAFrLrlNopmHKdnwasGPBm/message.txt >12:40
lyarwoodfun12:40
lyarwood^ in nova-multi-cell12:41
lyarwoodand 12:41
* lyarwood < https://matrix.org/_matrix/media/r0/download/matrix.org/xHwHZZDQSCYqDpBONAKLZWRZ/message.txt >12:41
lyarwoodin tox-py-3612:41
* lyarwood creates some bugs12:41
gibioh nice12:42
gibiit was release monday out there it seems :D12:42
gibibut what is the conflict in the stevedore case? stevedore >=1.20.0 and stevedore === 3.3.0 are not conflicting12:44
gibior am I missing something?12:44
lyarwoodtbh both are confusing12:44
*** ratailor_ <ratailor_!~ratailor@103.115.207.228> has quit IRC (Quit: Leaving)12:46
lyarwoodyeah I can't reproduce the numpy websockify one12:50
*** rloo <rloo!~rloo@2001:4998:ef83:14:8000::10c2> has joined #openstack-nova13:06
sean-k-mooneylyarwood: how are you finding the matix bridge? i likke the way image sharing work on the irc side13:06
sean-k-mooneyits nicer on the matrix side of cource since its inline but the urls work well for irc users too13:07
lyarwoodI've hardly noticed it thus far that's a great thing13:07
sean-k-mooneystill using the web interface or have you tried the weechat plugin13:07
sean-k-mooneygibi: lyarwood  if you want a third person to test just let me know 13:08
lyarwoodsean-k-mooney: I'm using element13:09
sean-k-mooneygibi: lyarwood  oh wile i rememebr while i rememeber https://review.opendev.org/c/openstack/ovsdbapp/+/795789 seams to work but terry is fixing it properly in ovs.13:11
sean-k-mooneyim going to also see if i can find an os-vif only solution that we could backport13:12
gibicool13:12
gibilet me know if you need a reviewer to let the solution merges13:12
sean-k-mooneyack will do im not going to get to working on it today but its on my todo list for tomorrow13:12
sean-k-mooneyim going to try and finish the off path accleartor spec review today and start on the next revision or the pci in placemnet one13:13
gibiack13:13
sean-k-mooneyi spoke to artom about it last week and im going to split the pci one the first spec will just be for non neutron devices and the second will cover the netruon aspect im also goign to file a but for a different semi feature semi bug which ill bring up in either this weeks meetign or next13:14
gibithe split works for me13:15
gibijust try not to do something for the non neutron devices that will be a dead en for the neutron ones13:15
*** ralonsoh <ralonsoh!~ralonsoh@36.red-79-150-231.dynamicip.rima-tde.net> has quit IRC (Quit: Leaving)13:26
*** ralonsoh <ralonsoh!~ralonsoh@36.red-79-150-231.dynamicip.rima-tde.net> has joined #openstack-nova13:26
sean-k-mooneyack13:26
*** abhishekk <abhishekk!~akekane@116.74.162.143> has joined #openstack-nova13:37
*** abhishekk is now known as akekane|home13:37
*** akekane|home is now known as abhishekk13:37
opendevreviewMerged openstack/nova master: Revert "Removing mypy to fix the nova CI"  https://review.opendev.org/c/openstack/nova/+/79597313:41
*** Luzi <Luzi!~Luzi@ipservice-092-208-056-099.092.208.pools.vodafone-ip.de> has quit IRC (Quit: Leaving)14:01
stephenfinlyarwood++ Good catch on the libvirt device removal thing14:34
stephenfinand gibi++ too14:35
stephenfingibi: I've a small nit on https://review.opendev.org/c/openstack/nova/+/796255. Do you want to address now (since CI is rerunning anyway) or in a follow-up?14:35
*** rpittau is now known as rpittau|afk16:08
opendevreviewStephen Finucane proposed openstack/nova master: docs: Replace 'nova boot' with 'openstack server create'  https://review.opendev.org/c/openstack/nova/+/79400717:22
opendevreviewBalazs Gibizer proposed openstack/nova master: Handle OPERATION_FAILED error during detach  https://review.opendev.org/c/openstack/nova/+/79625517:40
gibilyarwood, stephenfin: fixed up ^^17:40
opendevreviewMerged openstack/nova master: Add debug log for device detach libvirt error  https://review.opendev.org/c/openstack/nova/+/79604317:44
opendevreviewMohammed Naser proposed openstack/nova master: Allow X-OpenStack-Nova-API-Version header in CORS  https://review.opendev.org/c/openstack/nova/+/79631920:55
opendevreviewMohammed Naser proposed openstack/nova master: Allow X-OpenStack-Nova-API-Version header in CORS  https://review.opendev.org/c/openstack/nova/+/79631920:57

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!