| *** zzzeek has quit IRC | 00:03 | |
| *** mlavalle has quit IRC | 00:05 | |
| *** zzzeek has joined #openstack-nova | 00:05 | |
| *** tetsuro has joined #openstack-nova | 00:08 | |
| *** tonyb has joined #openstack-nova | 00:22 | |
| *** LinPeiWen has joined #openstack-nova | 00:33 | |
| *** zzzeek has quit IRC | 00:35 | |
| *** zzzeek has joined #openstack-nova | 00:36 | |
| *** JamesBenson has joined #openstack-nova | 00:57 | |
| *** tetsuro has quit IRC | 00:58 | |
| *** tetsuro has joined #openstack-nova | 00:59 | |
| *** JamesBenson has quit IRC | 01:02 | |
| *** tetsuro has quit IRC | 01:03 | |
| *** yingjisun has joined #openstack-nova | 01:14 | |
| *** Liang__ has joined #openstack-nova | 01:20 | |
| *** zzzeek has quit IRC | 01:26 | |
| *** zzzeek has joined #openstack-nova | 01:27 | |
| *** JamesBenson has joined #openstack-nova | 01:29 | |
| *** tetsuro has joined #openstack-nova | 01:32 | |
| *** sapd__x has joined #openstack-nova | 01:33 | |
| *** JamesBenson has quit IRC | 01:34 | |
| *** tetsuro has quit IRC | 01:37 | |
| *** brinzhang_ has joined #openstack-nova | 02:10 | |
| *** brinzhang0 has quit IRC | 02:13 | |
| *** Liang__ is now known as LiangFang | 02:15 | |
| *** spatel has joined #openstack-nova | 02:22 | |
| *** zzzeek has quit IRC | 02:24 | |
| *** zzzeek has joined #openstack-nova | 02:26 | |
| *** JamesBenson has joined #openstack-nova | 02:26 | |
| *** elod has quit IRC | 02:29 | |
| *** elod has joined #openstack-nova | 02:30 | |
| *** jangutter_ has joined #openstack-nova | 02:49 | |
| *** spatel has quit IRC | 02:52 | |
| *** jangutter has quit IRC | 02:52 | |
| *** swp20 has joined #openstack-nova | 02:53 | |
| *** Yumeng has joined #openstack-nova | 02:55 | |
| *** xinranwang__ has joined #openstack-nova | 03:07 | |
| *** spatel has joined #openstack-nova | 03:20 | |
| *** mkrai has joined #openstack-nova | 03:20 | |
| *** links has joined #openstack-nova | 03:21 | |
| *** LiangFang has quit IRC | 03:24 | |
| *** spatel has quit IRC | 03:24 | |
| *** psachin has joined #openstack-nova | 03:24 | |
| *** Liang__ has joined #openstack-nova | 03:25 | |
| *** yingjisun has quit IRC | 03:32 | |
| *** chenhaw has quit IRC | 03:38 | |
| *** Liang__ has quit IRC | 03:52 | |
| *** Liang__ has joined #openstack-nova | 03:53 | |
| *** sapd__x has quit IRC | 03:56 | |
| *** songwenping_ has joined #openstack-nova | 04:03 | |
| *** swp20 has quit IRC | 04:06 | |
| *** mkrai has quit IRC | 04:06 | |
| *** sapd__x has joined #openstack-nova | 04:08 | |
| *** songwenping__ has joined #openstack-nova | 04:09 | |
| *** songwenping_ has quit IRC | 04:12 | |
| *** zzzeek has quit IRC | 04:17 | |
| *** zzzeek has joined #openstack-nova | 04:18 | |
| *** mkrai has joined #openstack-nova | 04:19 | |
| *** songwenping__ has quit IRC | 04:25 | |
| *** songwenping__ has joined #openstack-nova | 04:26 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-nova | 04:33 | |
| *** vishalmanchanda has joined #openstack-nova | 04:45 | |
| *** dave-mccowan has quit IRC | 04:51 | |
| *** JamesBenson has quit IRC | 04:56 | |
| *** yingjisun has joined #openstack-nova | 04:59 | |
| *** songwenping__ has quit IRC | 05:03 | |
| *** Liang__ has quit IRC | 05:06 | |
| *** Liang__ has joined #openstack-nova | 05:07 | |
| *** ratailor has joined #openstack-nova | 05:10 | |
| *** tetsuro has joined #openstack-nova | 05:14 | |
| *** zzzeek has quit IRC | 05:21 | |
| *** zzzeek has joined #openstack-nova | 05:21 | |
| *** gyee has quit IRC | 05:38 | |
| *** songwenping__ has joined #openstack-nova | 05:38 | |
| *** JamesBenson has joined #openstack-nova | 05:40 | |
| openstackgerrit | Brin Zhang proposed openstack/nova stable/ussuri: tests: Add regression test for bug 1894966 https://review.opendev.org/752371 | 05:44 |
|---|---|---|
| openstack | bug 1894966 in OpenStack Compute (nova) "Create servergroup failed with unexpected error" [Low,In progress] https://launchpad.net/bugs/1894966 - Assigned to Stephen Finucane (stephenfinucane) | 05:44 |
| *** manuvakery has joined #openstack-nova | 05:47 | |
| *** zzzeek has quit IRC | 05:52 | |
| *** zzzeek has joined #openstack-nova | 05:53 | |
| *** JamesBenson has quit IRC | 06:11 | |
| *** kukacz has joined #openstack-nova | 06:18 | |
| *** zzzeek has quit IRC | 06:21 | |
| *** zzzeek has joined #openstack-nova | 06:23 | |
| *** slaweq_ has joined #openstack-nova | 06:26 | |
| *** lpetrut has joined #openstack-nova | 06:43 | |
| *** suryasingh has joined #openstack-nova | 06:44 | |
| *** ralonsoh has joined #openstack-nova | 06:50 | |
| *** rcernin has quit IRC | 06:50 | |
| *** jraju__ has joined #openstack-nova | 06:59 | |
| *** links has quit IRC | 07:00 | |
| *** mkrai has quit IRC | 07:03 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: WIP: nova supports password encrypted VNC https://review.opendev.org/622336 | 07:05 |
| *** rcernin has joined #openstack-nova | 07:08 | |
| *** zzzeek has quit IRC | 07:09 | |
| *** zzzeek has joined #openstack-nova | 07:11 | |
| *** tesseract has joined #openstack-nova | 07:14 | |
| bauzas | good morning Nova | 07:16 |
| bauzas | sean-k-mooney: sorry, was afk yesterday so wasn't able to answer your backportability question, just ping me when you're back up | 07:17 |
| gibi | good morning | 07:19 |
| *** mkrai has joined #openstack-nova | 07:21 | |
| *** rcernin has quit IRC | 07:28 | |
| *** jawad_axd has joined #openstack-nova | 07:32 | |
| *** xinranwang__ has quit IRC | 07:36 | |
| *** elod has quit IRC | 07:39 | |
| *** elod has joined #openstack-nova | 07:41 | |
| *** xek has joined #openstack-nova | 07:44 | |
| *** nightmare_unreal has joined #openstack-nova | 07:46 | |
| *** ociuhandu has joined #openstack-nova | 07:48 | |
| *** dtantsur|afk is now known as dtantsur | 07:58 | |
| *** mkrai has quit IRC | 07:59 | |
| *** rcernin has joined #openstack-nova | 08:11 | |
| *** rcernin has quit IRC | 08:17 | |
| *** mkrai has joined #openstack-nova | 08:17 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Handle libvirt reporting incorrect 4k page quantities https://review.opendev.org/631038 | 08:37 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Make overcommit check for pinned instance pagesize aware https://review.opendev.org/631053 | 08:37 |
| *** derekh has joined #openstack-nova | 08:40 | |
| lyarwood | stephenfin: https://review.opendev.org/#/q/topic:bug/1895696 - would you mind hitting this again | 08:41 |
| *** slaweq_ is now known as slaweq | 08:48 | |
| *** rcernin has joined #openstack-nova | 08:50 | |
| lyarwood | gibi: ^ also if you wouldn't mind, it's a regression for an awkward slightly convoluted encrypted volume use case | 08:56 |
| gibi | lyarwood: looking.. | 08:57 |
| *** k_mouza has joined #openstack-nova | 08:57 | |
| lyarwood | many thanks | 08:58 |
| *** jangutter has joined #openstack-nova | 08:59 | |
| *** zzzeek has quit IRC | 08:59 | |
| *** jangutter_ has quit IRC | 09:02 | |
| *** rcernin has quit IRC | 09:03 | |
| *** zzzeek has joined #openstack-nova | 09:05 | |
| aarents | Hi Nova! | 09:17 |
| aarents | lyarwood you where close to +2 on that https://review.opendev.org/#/c/743708/ few weeks ago, if you can have a look when possible thks! | 09:17 |
| lyarwood | aarents: morning, looking | 09:21 |
| *** tetsuro has quit IRC | 09:25 | |
| *** slaweq has quit IRC | 09:38 | |
| *** slaweq has joined #openstack-nova | 09:40 | |
| lyarwood | aarents: sorry for the delay, LGTM still, can you follow up with a devstack change so we can see it running somewhere? | 09:42 |
| lyarwood | aarents: I left an example in the change FWIW | 09:42 |
| *** dtantsur has quit IRC | 09:59 | |
| openstackgerrit | Merged openstack/nova stable/stein: Add checks for volume status when rebuilding https://review.opendev.org/748559 | 09:59 |
| *** dtantsur has joined #openstack-nova | 10:01 | |
| *** dklyle has quit IRC | 10:08 | |
| *** zzzeek has quit IRC | 10:08 | |
| *** zzzeek has joined #openstack-nova | 10:10 | |
| *** admin0 has joined #openstack-nova | 10:11 | |
| admin0 | hi all .. what do I need to do in the database when i rename a hypervisor | 10:11 |
| admin0 | i changed the hostname and did a nova-compute restart | 10:11 |
| admin0 | what do i need to do to associate running instances to the new name | 10:12 |
| lyarwood | erm that isn't supported at all | 10:12 |
| lyarwood | your placement allocations are going to be totally borked | 10:13 |
| lyarwood | can you undo the hostname change, empty the host of any instances and then do the hostname change? | 10:13 |
| lyarwood | you should be able to delete service in nova and resource provider in placement with the old hostname | 10:14 |
| lyarwood | and migrate everything back into the host | 10:14 |
| *** tosky has joined #openstack-nova | 10:19 | |
| admin0 | lyarwood, thanks | 10:22 |
| *** Liang__ has quit IRC | 10:22 | |
| *** yingjisun has quit IRC | 10:23 | |
| aarents | lyarwood: thank you will check | 10:26 |
| stephenfin | lyarwood: question on https://review.opendev.org/#/c/752247/ | 10:27 |
| lyarwood | stephenfin: https://review.opendev.org/#/c/752247/2/nova/tests/fixtures.py@2541 was the reason I left this in the fixture | 10:28 |
| lyarwood | stephenfin: I can do that in the test itself as well tbh | 10:29 |
| * lyarwood reworks quickly | 10:29 | |
| *** martinkennelly has joined #openstack-nova | 10:35 | |
| *** jangutter has quit IRC | 10:36 | |
| *** jangutter has joined #openstack-nova | 10:38 | |
| *** jangutter has quit IRC | 10:38 | |
| *** jangutter has joined #openstack-nova | 10:39 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug #1895696 https://review.opendev.org/752247 | 10:55 |
| openstack | bug 1895696 in OpenStack Compute (nova) "unable to boot instance from encrypted volume created from a glance image of an encrypted volume" [High,In progress] https://launchpad.net/bugs/1895696 - Assigned to Lee Yarwood (lyarwood) | 10:55 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Skip cinder_encryption_key_id check when booting from volume https://review.opendev.org/752090 | 10:55 |
| lyarwood | stephenfin: ^ there you go, slightly more self contained now. | 10:55 |
| *** vishalmanchanda has quit IRC | 10:55 | |
| lyarwood | stephenfin: should be easy enough to backport as well | 10:55 |
| *** zzzeek has quit IRC | 11:01 | |
| *** zzzeek has joined #openstack-nova | 11:03 | |
| *** JamesBenson has joined #openstack-nova | 11:07 | |
| *** jangutter_ has joined #openstack-nova | 11:10 | |
| *** mkrai has quit IRC | 11:11 | |
| *** jangutter has quit IRC | 11:13 | |
| *** mkrai has joined #openstack-nova | 11:13 | |
| gibi | lyarwood: +2 from me, sorry to take soo long I was distracted midday | 11:16 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug #1895696 https://review.opendev.org/752247 | 11:17 |
| openstack | bug 1895696 in OpenStack Compute (nova) "unable to boot instance from encrypted volume created from a glance image of an encrypted volume" [High,In progress] https://launchpad.net/bugs/1895696 - Assigned to Lee Yarwood (lyarwood) | 11:17 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Skip cinder_encryption_key_id check when booting from volume https://review.opendev.org/752090 | 11:17 |
| lyarwood | gibi: np, ^ just sorted the nit out quickly | 11:17 |
| gibi | thanks | 11:19 |
| *** sapd__x has quit IRC | 11:20 | |
| openstackgerrit | Hemanth Nakkina proposed openstack/nova master: Update pci stat pools based on PCI device changes https://review.opendev.org/749175 | 11:24 |
| *** lemko has quit IRC | 11:26 | |
| *** lemko0 has joined #openstack-nova | 11:26 | |
| *** yingjisun has joined #openstack-nova | 11:31 | |
| *** zzzeek has quit IRC | 11:35 | |
| *** zzzeek has joined #openstack-nova | 11:36 | |
| *** slaweq has quit IRC | 11:38 | |
| *** efried has quit IRC | 11:49 | |
| *** zzzeek has quit IRC | 11:50 | |
| *** efried has joined #openstack-nova | 11:51 | |
| *** zzzeek has joined #openstack-nova | 11:52 | |
| nightmare_unreal | brinzhang_: hello \0 , brinzhang. Can you please see my comment on your patch : https://review.opendev.org/#/c/675304/ . Thanks | 12:00 |
| *** efried has quit IRC | 12:01 | |
| brinzhang_ | nightmare_unreal: of course ^^ | 12:02 |
| brinzhang_ | nightmare_unreal: IMO, this patch is ready a looong time, but I dont know the where need to change, and why no-body +2 or -1 for it | 12:04 |
| sean-k-mooney | brinzhang_: it looks like it has not really got any code review | 12:05 |
| sean-k-mooney | at least not in the last year or so | 12:05 |
| sean-k-mooney | nightmare_unreal: brinzhang_ so ye need to join the sdk/osc irc channel and talk to the core team about it | 12:06 |
| nightmare_unreal | can we please have a review for that patch | 12:06 |
| brinzhang_ | IMHO, since mriedem left, there is no body care that pach | 12:06 |
| nightmare_unreal | brinzhang_: i am in #osc channel but couldn't find your username | 12:07 |
| nightmare_unreal | i mean sdk | 12:07 |
| sean-k-mooney | this is not the correct channel to ask in really. i think stephenfin might have osc core rights | 12:07 |
| nightmare_unreal | yeah right, sorry about the noise | 12:07 |
| nightmare_unreal | we will move the disucssion | 12:07 |
| sean-k-mooney | its ok to bring it up | 12:07 |
| sean-k-mooney | its for nova migrations | 12:07 |
| sean-k-mooney | but just bring it up here wont help get it merged | 12:08 |
| nightmare_unreal | haha true | 12:08 |
| sean-k-mooney | it might make sense to add a ptg topic | 12:08 |
| sean-k-mooney | or a mailing list topic | 12:08 |
| brinzhang_ | nightmare_unreal: yes, it also belongs to nova ^^ | 12:08 |
| sean-k-mooney | it might make sense to add teh core teams to osc | 12:08 |
| sean-k-mooney | i.e. so each project core team that does not ahve a plugin can review there onw part of osc | 12:09 |
| nightmare_unreal | I see | 12:09 |
| brinzhang_ | sean-k-mooney: ok, I will add the osc core to that patch | 12:09 |
| brinzhang_ | nightmare_unreal: which channel? | 12:11 |
| brinzhang_ | #osc, #sdk seems not right | 12:11 |
| sean-k-mooney | #openstack-sdk | 12:11 |
| sean-k-mooney | actully no that no right | 12:12 |
| sean-k-mooney | one sec | 12:12 |
| nightmare_unreal | i am in #openstack-sdks | 12:12 |
| sean-k-mooney | ah yes plural | 12:12 |
| nightmare_unreal | yup | 12:12 |
| *** slaweq has joined #openstack-nova | 12:12 | |
| brinzhang_ | sean-k-mooney, nightmare_unreal: thanks | 12:13 |
| brinzhang_ | sean-k-mooney> Maybe I cannot add all osc core as the reviewer, sometimes they dont like do that way :( | 12:15 |
| sean-k-mooney | generally you are better off to ask for reviews in irc | 12:15 |
| sean-k-mooney | if now one responds then after a day or two look at who has been active in stackaltics and add one or two | 12:16 |
| brinzhang_ | yeah, this is a good way | 12:16 |
| sean-k-mooney | https://www.stackalytics.com/?module=python-openstackclient&release=victoria | 12:17 |
| *** dave-mccowan has joined #openstack-nova | 12:17 | |
| sean-k-mooney | frickler nad gtema | 12:18 |
| sean-k-mooney | *and | 12:18 |
| brinzhang_ | Aha, I was missed this place, here we can know who is active in the project/model | 12:18 |
| sean-k-mooney | yep | 12:18 |
| sean-k-mooney | they are likely your best bet | 12:18 |
| sean-k-mooney | monty has recently left openstack developement and changed job | 12:18 |
| brinzhang_ | ack, thank for your help | 12:19 |
| brinzhang_ | nightmare_unreal> I think I will review your patch tomorrow, I will go later, my timezone is UTC+8, thx | 12:21 |
| *** ratailor has quit IRC | 12:22 | |
| nightmare_unreal | thanks brinzhang_ . Understood | 12:23 |
| *** zzzeek has quit IRC | 12:26 | |
| *** derekh has quit IRC | 12:27 | |
| *** zzzeek has joined #openstack-nova | 12:28 | |
| *** LinPeiWen has quit IRC | 12:29 | |
| *** brinzhang has joined #openstack-nova | 12:31 | |
| *** nweinber has joined #openstack-nova | 12:31 | |
| *** brinzhang_ has quit IRC | 12:36 | |
| openstackgerrit | Merged openstack/nova master: tests: Remove '_FakeImageService' https://review.opendev.org/745908 | 12:46 |
| *** mkrai has quit IRC | 12:52 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use cell targeted context to query instance metadata https://review.opendev.org/752459 | 12:52 |
| *** iurygregory has quit IRC | 12:56 | |
| *** iurygregory has joined #openstack-nova | 12:58 | |
| *** efried has joined #openstack-nova | 13:00 | |
| *** derekh has joined #openstack-nova | 13:02 | |
| openstackgerrit | Merged openstack/nova stable/ussuri: functional: Don't inherit from 'ProviderUsageBaseTestCase' https://review.opendev.org/751351 | 13:03 |
| openstackgerrit | Merged openstack/nova stable/ussuri: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/751352 | 13:03 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Victoria 22.0.0 prelude section https://review.opendev.org/751045 | 13:35 |
| bauzas | gibi: stephenfin: takashi made a good comment on https://review.opendev.org/751045, could you please review again ? | 13:36 |
| bauzas | ideally, we could merge this prelude now and just amend it in a later change if we need | 13:37 |
| stephenfin | done | 13:37 |
| *** sapd__x has joined #openstack-nova | 13:39 | |
| bauzas | thanks | 13:55 |
| gibi | will check soon | 13:56 |
| openstackgerrit | Merged openstack/nova stable/queens: Removed the host FQDN from the exception message https://review.opendev.org/749613 | 13:56 |
| bauzas | gibi: I saw you already looked at https://bugs.launchpad.net/nova/+bug/1884217 | 14:00 |
| openstack | Launchpad bug 1884217 in OpenStack Compute (nova) "Nova informs Placement too early upon Ironic instance deletion" [Undecided,New] | 14:00 |
| bauzas | gibi: this one seems legit to me but the bugfix isn't easy | 14:01 |
| *** mriedem has joined #openstack-nova | 14:06 | |
| *** lpetrut has quit IRC | 14:14 | |
| lyarwood | gibi: https://bugs.launchpad.net/nova/+bug/1888237 - shouldn't this be moved to fix released btw? | 14:16 |
| openstack | Launchpad bug 1888237 in Ubuntu "nova-next job fails as novnc service fails with TypeError: _wrap_socket() argument 1 must be _socket.socket, not GreenSSLSocket" [Undecided,New] | 14:16 |
| *** k_mouza has quit IRC | 14:18 | |
| *** k_mouza has joined #openstack-nova | 14:20 | |
| *** abhishekk is now known as abhishekk-afk | 14:21 | |
| *** k_mouza has quit IRC | 14:25 | |
| openstackgerrit | Elod Illes proposed openstack/nova stable/pike: Removed the host FQDN from the exception message https://review.opendev.org/752477 | 14:28 |
| *** k_mouza has joined #openstack-nova | 14:28 | |
| *** zzzeek has quit IRC | 14:30 | |
| gibi | bauzas: I've just tagged https://bugs.launchpad.net/nova/+bug/1884217 I don't know the way forward with it | 14:30 |
| openstack | Launchpad bug 1884217 in OpenStack Compute (nova) "Nova informs Placement too early upon Ironic instance deletion" [Low,Incomplete] | 14:30 |
| gibi | lyarwood: you are correct. Now I marked it such | 14:31 |
| *** zzzeek has joined #openstack-nova | 14:32 | |
| lyarwood | gibi: coolio :) | 14:32 |
| gibi | thanks for noticing | 14:32 |
| gibi | bauzas: so if you have ideas how to fix please comment to the bug | 14:32 |
| gibi | nvm | 14:33 |
| gibi | I see your comment now | 14:33 |
| *** maciejjozefczyk has joined #openstack-nova | 14:33 | |
| *** abhishekk-afk is now known as abhishekk | 14:36 | |
| *** bbowen_ has joined #openstack-nova | 14:37 | |
| *** bbowen has quit IRC | 14:38 | |
| *** dklyle has joined #openstack-nova | 14:40 | |
| stephenfin | elod, lyarwood, melwitt: Obviously the top few of these are still blocked by their Ussuri equivalents, but could you add https://review.opendev.org/#/q/topic:bug/1879878+status:open+branch:stable/train to your review queues? | 14:44 |
| lyarwood | ack | 14:46 |
| *** maciejjozefczyk has quit IRC | 14:51 | |
| elod | stephenfin: sure, will do | 14:51 |
| stephenfin | thanks | 14:53 |
| *** mkrai has joined #openstack-nova | 14:56 | |
| elod | stephenfin: btw, can those heavy test refactors be avoided somehow? | 14:57 |
| stephenfin | elod: Do you mean the first three patches I brought into the series or the changes I made to later patches? | 14:58 |
| elod | stephenfin: for example this one: https://review.opendev.org/#/q/I33d8ac0a1cae0b2d275a21287d5e44c008a68122 | 14:59 |
| *** priteau has joined #openstack-nova | 15:00 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: Add regression test for bug #1895696 https://review.opendev.org/752485 | 15:00 |
| openstack | bug 1895696 in OpenStack Compute (nova) "unable to boot instance from encrypted volume created from a glance image of an encrypted volume" [High,In progress] https://launchpad.net/bugs/1895696 - Assigned to Lee Yarwood (lyarwood) | 15:00 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: compute: Skip cinder_encryption_key_id check when booting from volume https://review.opendev.org/752486 | 15:00 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: Add regression test for bug #1895696 https://review.opendev.org/752487 | 15:01 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: Create volume attachment during boot from volume in compute https://review.opendev.org/752488 | 15:01 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: compute: Skip cinder_encryption_key_id check when booting from volume https://review.opendev.org/752489 | 15:01 |
| stephenfin | elod: So the former. I could, but it would involve even more significant rewriting of the tests I'm bringing back plus significant rewrite of any future tests that depend on this feature | 15:01 |
| lyarwood | stephenfin: ^ as requested | 15:01 |
| stephenfin | lyarwood: thanks | 15:01 |
| stephenfin | elod: Given they're test-only (low risk) and avoid merge conflicts for this series and potentially many more tests in the future, I'm personally inclined to think they belong here. | 15:02 |
| elod | stephenfin: the test-only part is good, but still it would mean larger and larger extra refactor (due to conflicts) in older branches which could cause more problems later on maybe | 15:06 |
| stephenfin | elod: Fair point but tbh I'm not sure how much further back we should go. Those tests and the changes themselves are invasive enough that I think they may have to be rewritten if I want to go significantly further back | 15:08 |
| stephenfin | elod: In fact, I don't think we need to go further back. The main issue here was introduced by https://review.opendev.org/#/c/641806/ which was never backported | 15:10 |
| stephenfin | and was merged in train | 15:10 |
| elod | stephenfin: yes, that is another question, how far should a backport go. in general, whether a bugfix worth the backporting effort if it involves so much refactor, hence risks | 15:11 |
| elod | stephenfin: but i understand you are saying this won't go further than train | 15:12 |
| stephenfin | given the nasty side-effects of this race (worst case scenario: doubly pinned instances) I think bringing it back to train makes sense | 15:13 |
| *** gyee has joined #openstack-nova | 15:15 | |
| *** spatel has joined #openstack-nova | 15:21 | |
| *** yingjisun has quit IRC | 15:21 | |
| elod | stephenfin: ok, i accept it. (I won't say i'm happy with it, but i understand your point o:)) | 15:24 |
| *** mlavalle has joined #openstack-nova | 15:24 | |
| *** spatel has quit IRC | 15:25 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: Create volume attachment during boot from volume in compute https://review.opendev.org/752488 | 15:28 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: compute: Skip cinder_encryption_key_id check when booting from volume https://review.opendev.org/752489 | 15:28 |
| *** eharney has quit IRC | 15:34 | |
| sean-k-mooney | gibi: have you see error in the fucntional test that look like ValueError: Malformed PCI address 0000:00:03 | 15:37 |
| sean-k-mooney | gibi: your new sriov attach detach test are failing for me when i rebase one of my patches | 15:37 |
| sean-k-mooney | but the code im chanign i dont think should cause that | 15:37 |
| stephenfin | sean-k-mooney: I haven't, but I know those fixtures well enough that I could debug. What test? | 15:38 |
| stephenfin | *what patch? | 15:38 |
| sean-k-mooney | http://paste.openstack.org/show/798018/ | 15:38 |
| *** k_mouza has quit IRC | 15:39 | |
| sean-k-mooney | nova.tests.functional.libvirt.test_pci_sriov_servers.SRIOVAttachDetachTest.test_detach_macvtap | 15:39 |
| sean-k-mooney | and nova.tests.functional.libvirt.test_pci_sriov_servers.SRIOVAttachDetachTest.test_detach_attach_direct | 15:39 |
| sean-k-mooney | im cherry picking https://review.opendev.org/#/c/602432/16 onto another patch but after the rebase on master those new test are failing for me | 15:40 |
| sean-k-mooney | i could just push what i have it might be simpler to look at | 15:40 |
| gibi | sean-k-mooney: yes please ^^ | 15:41 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reject HW_CPU_HYPERTHREADING trait in named groups https://review.opendev.org/735947 | 15:41 |
| gibi | sean-k-mooney: I did not remember seeing such | 15:41 |
| gibi | err | 15:42 |
| stephenfin | sean-k-mooney: this is a guess but https://review.opendev.org/#/c/602432/16/nova/tests/unit/virt/libvirt/fakelibvirt.py | 15:43 |
| *** tesseract has quit IRC | 15:44 | |
| *** eharney has joined #openstack-nova | 15:46 | |
| sean-k-mooney | ya i guess that could be it ill take a look | 15:46 |
| sean-k-mooney | i made fucn be octal | 15:47 |
| sean-k-mooney | func = 0o0 | 15:47 |
| sean-k-mooney | but ya it could be the formating | 15:47 |
| stephenfin | >>> x = 0o1 | 15:48 |
| stephenfin | >>> '%s' % x | 15:48 |
| stephenfin | '1' | 15:48 |
| sean-k-mooney | ok ya so that is proably it | 15:48 |
| *** Yumeng has quit IRC | 15:48 | |
| sean-k-mooney | cool now i need to look up hex/octal format codes :) | 15:49 |
| sean-k-mooney | so it shoudl be o not s | 15:50 |
| sean-k-mooney | or i guess x would work too for hex | 15:50 |
| *** dtantsur is now known as dtantsur|afk | 15:51 | |
| gibi | the nova weekly meeting starts in 8 minutes in #openstack-meetings-3 | 15:52 |
| gibi | I mean #openstack-meeting-3 | 15:52 |
| sean-k-mooney | stephenfin: actully the adress is 0000:00:03. its missing the function e.g. 0000:00:03.1 vs 0000:00:03. | 15:59 |
| sean-k-mooney | so its proably not the formating but its likely related to that change in my patch | 16:00 |
| *** manuvakery has quit IRC | 16:03 | |
| *** ociuhandu has quit IRC | 16:07 | |
| *** mkrai has quit IRC | 16:11 | |
| *** mkrai_ has joined #openstack-nova | 16:11 | |
| *** manuvakery has joined #openstack-nova | 16:14 | |
| *** k_mouza has joined #openstack-nova | 16:15 | |
| *** psachin has quit IRC | 16:15 | |
| *** k_mouza has quit IRC | 16:19 | |
| *** k_mouza has joined #openstack-nova | 16:22 | |
| stephenfin | sean-k-mooney, bauzas: Either of you know why we pass 'live=True' here instead of actually checking the power state of the instance as we do elsewhere? https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4396 | 16:24 |
| stephenfin | for both PCI (link above) and MDEV-type devices https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L7512 | 16:24 |
| bauzas | looking | 16:25 |
| stephenfin | Is it because we pass 'persistent=True' when attaching them, e.g. https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4425 ? | 16:25 |
| sean-k-mooney | i would expect use to be consistent | 16:27 |
| *** mkrai_ has quit IRC | 16:27 | |
| sean-k-mooney | git blame on github does not work on that file because its too big | 16:27 |
| sean-k-mooney | we want to remove it form both the live and persistt doamin that said we dont use the persitent domain | 16:27 |
| bauzas | stephenfin: "–live indicates that the operation is dynamic and will reflect in the running guest." | 16:28 |
| *** jraju__ has quit IRC | 16:28 | |
| sean-k-mooney | bauzas: right but that should be true of attach too | 16:28 |
| stephenfin | So if the guest was paused or stopped, that would fail right? | 16:28 |
| sean-k-mooney | https://github.com/openstack/nova/blob/f47bde539c89d1ac1fa90ea6f0d72a7e2de19532/nova/virt/libvirt/guest.py#L488 | 16:28 |
| sean-k-mooney | yes | 16:28 |
| stephenfin | so...bug? | 16:29 |
| sean-k-mooney | although you cant detach from a paused guest | 16:29 |
| sean-k-mooney | it will fail | 16:29 |
| stephenfin | PCI devices or anything? | 16:29 |
| sean-k-mooney | so detach will send a acpi interupt to the guest | 16:29 |
| stephenfin | I guess PCI devices are different because of the whole "managed" aspect | 16:29 |
| sean-k-mooney | but when its paused nothing will repond to that | 16:29 |
| sean-k-mooney | so the detach shoudl fail | 16:30 |
| sean-k-mooney | the same shoudl be true fo mdevs | 16:30 |
| sean-k-mooney | in the pasued state the vm domain is still defined but the cpus are stopped | 16:30 |
| sean-k-mooney | qemu is still running | 16:30 |
| sean-k-mooney | unlike suspend | 16:30 |
| stephenfin | does that also apply for e.g. block devices? | 16:31 |
| sean-k-mooney | yes | 16:31 |
| bauzas | you lost me, folks | 16:31 |
| sean-k-mooney | we use virtio-blk which uses a pci per volume by default | 16:31 |
| sean-k-mooney | so volume detaches do a pci hot unplug | 16:31 |
| sean-k-mooney | so it wont work on a paused guest | 16:31 |
| sean-k-mooney | im not sure about virtio-scisi but i suspect that wont work either | 16:32 |
| stephenfin | bauzas: we're questioning whether the live parameter makes sense here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L2247 | 16:32 |
| stephenfin | or if we should be outright rejecting a request to attach/detach a device from a paused guest | 16:32 |
| sean-k-mooney | stephenfin: i think we shoudl be passing both live and persisted in almsot every case | 16:32 |
| sean-k-mooney | stephenfin: i dont know of any reason we would not want to update both | 16:33 |
| sean-k-mooney | always | 16:33 |
| sean-k-mooney | well i guess if the vm was off | 16:33 |
| sean-k-mooney | but in htat case we dont need to update the domain | 16:34 |
| sean-k-mooney | we will just recreated it when we start it | 16:34 |
| stephenfin | okay, let me see if I can untangle this /o\ | 16:36 |
| *** sapd__x has quit IRC | 16:38 | |
| sean-k-mooney | this could explain why we are getting out of sync | 16:43 |
| sean-k-mooney | there is at least one bug where the live and perstient domains get out of sync | 16:44 |
| sean-k-mooney | if we are attaching with persistent and detaching with live that would do it | 16:44 |
| *** k_mouza has quit IRC | 16:44 | |
| *** brinzhang_ has joined #openstack-nova | 16:46 | |
| lyarwood | sean-k-mooney: https://review.opendev.org/#/c/747123/ FYI | 16:48 |
| lyarwood | sean-k-mooney: moved to the train UCA | 16:48 |
| *** brinzhang has quit IRC | 16:50 | |
| *** priteau has quit IRC | 16:50 | |
| *** martinkennelly has quit IRC | 16:54 | |
| sean-k-mooney | cool if you need more testing i can try that but ill just see what the ci says first | 16:57 |
| *** tosky has quit IRC | 17:00 | |
| openstackgerrit | sean mooney proposed openstack/nova master: Fix unplugging VIF when migrate/resize VM https://review.opendev.org/751642 | 17:00 |
| openstackgerrit | sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.opendev.org/602432 | 17:00 |
| sean-k-mooney | stephenfin: gibi i have not fixed the functest failure but hopefully its simpler to figure out now that i have pushed the patches | 17:01 |
| sean-k-mooney | stephenfin: ill keep debuging it locally and see if i can figure it out | 17:01 |
| *** derekh has quit IRC | 17:04 | |
| *** k_mouza has joined #openstack-nova | 17:13 | |
| * bauzas calls it a day, bye folks | 17:17 | |
| *** k_mouza has quit IRC | 17:28 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP zuul: Introduce nova-multinode-evacuate https://review.opendev.org/744883 | 17:29 |
| *** spatel has joined #openstack-nova | 17:36 | |
| *** spatel has quit IRC | 17:41 | |
| *** k_mouza has joined #openstack-nova | 17:44 | |
| *** artom has quit IRC | 17:46 | |
| *** k_mouza has quit IRC | 17:49 | |
| *** artom has joined #openstack-nova | 17:53 | |
| *** irclogbot_2 has quit IRC | 17:58 | |
| *** hamalq has joined #openstack-nova | 17:59 | |
| *** irclogbot_1 has joined #openstack-nova | 18:01 | |
| *** jawad_axd has quit IRC | 18:05 | |
| *** eharney has quit IRC | 18:12 | |
| *** ociuhandu has joined #openstack-nova | 18:15 | |
| *** ociuhandu has quit IRC | 18:19 | |
| *** eharney has joined #openstack-nova | 18:25 | |
| *** k_mouza has joined #openstack-nova | 18:25 | |
| *** k_mouza has quit IRC | 18:25 | |
| *** k_mouza has joined #openstack-nova | 18:26 | |
| *** k_mouza has quit IRC | 18:28 | |
| *** tbachman has joined #openstack-nova | 18:31 | |
| *** k_mouza has joined #openstack-nova | 18:33 | |
| *** k_mouza has quit IRC | 18:37 | |
| openstackgerrit | Merged openstack/nova master: api: Set min, maxItems for server_group.policies field https://review.opendev.org/752211 | 19:00 |
| openstackgerrit | Merged openstack/nova master: Add regression test for bug #1895696 https://review.opendev.org/752247 | 19:00 |
| openstack | bug 1895696 in OpenStack Compute (nova) "unable to boot instance from encrypted volume created from a glance image of an encrypted volume" [High,In progress] https://launchpad.net/bugs/1895696 - Assigned to Lee Yarwood (lyarwood) | 19:00 |
| *** openstackgerrit has quit IRC | 19:21 | |
| *** ociuhandu has joined #openstack-nova | 19:41 | |
| *** nweinber has quit IRC | 19:54 | |
| *** ralonsoh has quit IRC | 19:57 | |
| *** openstackgerrit has joined #openstack-nova | 19:59 | |
| openstackgerrit | Merged openstack/nova master: compute: Skip cinder_encryption_key_id check when booting from volume https://review.opendev.org/752090 | 19:59 |
| *** kukacz has quit IRC | 20:02 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Introduce nova-multinode-evacuate https://review.opendev.org/744883 | 20:02 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Replace nova-live-migration with zuulv3 jobs https://review.opendev.org/752557 | 20:02 |
| *** manuvakery has quit IRC | 20:03 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Introduce nova-evacuate https://review.opendev.org/744883 | 20:04 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Replace nova-live-migration with zuulv3 jobs https://review.opendev.org/752557 | 20:04 |
| *** admin0 has quit IRC | 20:17 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fakelibvirt: Use versionutils to set min versions found in the driver https://review.opendev.org/749707 | 20:24 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION https://review.opendev.org/746981 | 20:24 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_FILE_BACKED_DISCARD_VERSION https://review.opendev.org/746982 | 20:24 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_NATIVE_TLS_VERSION https://review.opendev.org/746983 | 20:24 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_BETTER_SIGKILL_HANDLING https://review.opendev.org/746984 | 20:24 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_VIDEO_MODEL_VERSIONS https://review.opendev.org/746985 | 20:24 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_PMEM_SUPPORT https://review.opendev.org/746986 | 20:24 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration https://review.opendev.org/747976 | 20:28 |
| *** tosky has joined #openstack-nova | 20:34 | |
| *** JamesBenson has quit IRC | 20:44 | |
| *** ociuhandu has quit IRC | 20:52 | |
| openstackgerrit | Merged openstack/nova stable/ussuri: Move confirm resize under semaphore https://review.opendev.org/751353 | 20:56 |
| *** bbowen_ has quit IRC | 21:05 | |
| *** xek has quit IRC | 21:28 | |
| *** mriedem has left #openstack-nova | 21:45 | |
| *** jhesketh has quit IRC | 21:55 | |
| *** zzzeek has quit IRC | 21:57 | |
| *** zzzeek has joined #openstack-nova | 22:01 | |
| *** slaweq has quit IRC | 22:07 | |
| *** brinzhang0 has joined #openstack-nova | 22:14 | |
| *** brinzhang_ has quit IRC | 22:17 | |
| *** zzzeek has quit IRC | 22:17 | |
| *** tosky has quit IRC | 22:19 | |
| *** zzzeek has joined #openstack-nova | 22:19 | |
| *** bbowen_ has joined #openstack-nova | 22:24 | |
| *** mgagne has joined #openstack-nova | 22:37 | |
| *** jmlowe has quit IRC | 22:48 | |
| gregwork | is it possible to adjust the weight of vcpu qupotas in nova | 22:55 |
| gregwork | like lets say i have a flavor that has the extra spec of cpushares 256 and is part of a cpu pinset of 4 cores | 22:56 |
| gregwork | this would be a very limited amount of cpu time an instance could occupy during contention | 22:56 |
| *** rcernin has joined #openstack-nova | 23:05 | |
| *** jmlowe has joined #openstack-nova | 23:15 | |
| *** jhesketh has joined #openstack-nova | 23:31 | |
| openstackgerrit | Merged openstack/nova stable/train: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/747610 | 23:35 |
| *** mlavalle has quit IRC | 23:44 | |
| *** artom has quit IRC | 23:56 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!