Friday, 2020-09-18

openstackgerritJeremy Stanley proposed openstack/nova master: DNM: Testing PDF builds  https://review.opendev.org/75258500:00
*** yingjisun has joined #openstack-nova00:26
*** hamalq has quit IRC00:30
*** LinPeiWen has joined #openstack-nova00:31
openstackgerritGhanshyam Mann proposed openstack/nova master: DNM: Testing PDF builds  https://review.opendev.org/75258500:34
*** gyee has quit IRC01:03
*** Liang__ has joined #openstack-nova01:20
*** zzzeek has quit IRC01:21
*** zzzeek has joined #openstack-nova01:22
*** gregwork has quit IRC01:27
*** yingjisun has quit IRC01:32
*** hamalq has joined #openstack-nova01:37
*** hamalq_ has joined #openstack-nova01:41
*** hamalq has quit IRC01:44
*** sapd__x has joined #openstack-nova01:48
*** jmlowe has quit IRC01:56
*** brinzhang_ has joined #openstack-nova02:11
*** brinzhang0 has quit IRC02:14
*** brinzhang0 has joined #openstack-nova02:17
*** songwenping_ has joined #openstack-nova02:17
*** songwenping__ has quit IRC02:20
*** brinzhang_ has quit IRC02:20
*** rcernin has quit IRC02:29
*** lbragstad has quit IRC02:31
*** links has joined #openstack-nova02:35
*** sapd__x has quit IRC02:50
*** zzzeek has quit IRC02:54
*** zzzeek has joined #openstack-nova02:54
*** sapd__x has joined #openstack-nova02:59
*** zzzeek has quit IRC03:01
*** zzzeek has joined #openstack-nova03:04
*** rcernin has joined #openstack-nova03:15
*** dave-mccowan has quit IRC03:16
*** hamalq_ has quit IRC03:18
*** mkrai has joined #openstack-nova03:25
*** psachin has joined #openstack-nova03:37
*** mkrai has quit IRC04:06
*** mkrai_ has joined #openstack-nova04:06
*** mkrai_ has quit IRC04:32
*** evrardjp has quit IRC04:33
*** evrardjp has joined #openstack-nova04:33
*** mkrai has joined #openstack-nova04:34
*** mkrai has quit IRC04:50
*** mkrai_ has joined #openstack-nova04:50
*** sapd__x has quit IRC04:55
*** zzzeek has quit IRC05:19
*** zzzeek has joined #openstack-nova05:19
*** xek has joined #openstack-nova05:26
*** sapd__x has joined #openstack-nova05:30
*** vishalmanchanda has joined #openstack-nova05:33
*** hamalq has joined #openstack-nova05:44
*** ratailor has joined #openstack-nova05:54
*** xek has quit IRC06:04
*** kukacz has joined #openstack-nova06:06
*** ralonsoh has joined #openstack-nova06:08
*** slaweq has joined #openstack-nova06:14
*** hamalq has quit IRC06:29
*** hamalq has joined #openstack-nova06:32
*** Yumeng has joined #openstack-nova06:39
*** mkrai_ has quit IRC06:40
*** mkrai_ has joined #openstack-nova06:40
*** dklyle has quit IRC06:41
*** hamalq has quit IRC06:44
*** jawad_axd has joined #openstack-nova06:45
*** amorin has quit IRC06:46
*** hamalq has joined #openstack-nova06:52
*** yonglihe has quit IRC06:53
*** guilhermesp has quit IRC06:53
*** johnsom has quit IRC06:53
*** vdrok has quit IRC06:53
*** rpittau|afk has quit IRC06:53
*** nicolasbock has quit IRC06:53
*** fyx has quit IRC06:53
*** pas-ha has quit IRC06:53
*** donnyd has quit IRC06:53
*** csatari has quit IRC06:53
*** rm_work has quit IRC06:53
*** masayukig has quit IRC06:53
*** TheJulia has quit IRC06:53
*** bcm has quit IRC06:53
*** nicolasbock has joined #openstack-nova06:55
*** vdrok has joined #openstack-nova06:56
*** yonglihe has joined #openstack-nova06:56
*** guilhermesp has joined #openstack-nova06:56
*** rpittau|afk has joined #openstack-nova06:56
*** masayukig has joined #openstack-nova06:56
*** bcm has joined #openstack-nova06:56
*** csatari has joined #openstack-nova06:57
*** TheJulia has joined #openstack-nova06:57
*** johnsom has joined #openstack-nova06:57
*** donnyd has joined #openstack-nova06:57
*** fyx has joined #openstack-nova06:57
*** brinzhang_ has joined #openstack-nova07:01
*** brinzhang0 has quit IRC07:04
*** hamalq has quit IRC07:05
*** mkrai_ has quit IRC07:06
*** rm_work has joined #openstack-nova07:08
*** pas-ha has joined #openstack-nova07:09
*** tesseract has joined #openstack-nova07:14
*** derekh has joined #openstack-nova07:20
*** tosky has joined #openstack-nova07:25
*** ociuhandu has joined #openstack-nova07:45
bauzasgood Friday Nova07:51
lyarwoodMorning \o08:04
lyarwoodsean-k-mooney / bauzas / stephenfin / gibi ; so some good news, the libvirt version bump https://review.opendev.org/#/c/746981/ works with the train UCA https://review.opendev.org/#/c/747123/08:05
lyarwoodthe only issue remaining appears to be with how the grenade jobs are deployed08:05
* lyarwood assumes they aren't using bionic08:05
lyarwoodoh they are, weird08:06
lyarwoodah right I need to backport this to stable/ussuri08:09
lyarwoodfun chicken and egg problem here08:10
kashyaplyarwood: Mornin, I still haven't gotten to the Focal thing; was beset with a worser storm downstream, if you know what I mean :D08:11
lyarwoodnp08:12
nightmare_unrealHello is there a glance dedicated channel ?08:14
nightmare_unrealnvm found it08:14
gibilyarwood: what exactly need to be backported to ussir?08:19
gibiussuri08:19
lyarwoodgibi: https://review.opendev.org/#/c/752641/ I believe, do devstack uses the train UCA when deplying the stable/ussuri env during a grenade run08:21
lyarwoodthat or I could hack enabling the UCA into grenade on master somehow08:21
lyarwoodso* devstack sorry08:22
gibihm so in ussuri the train UCA has newer libvirt than the default packages?08:22
lyarwoodyes correct08:24
lyarwoodthe train UCA has the new MIN_{LIBVIRT,QEMU}_VERSIONs we are looking to set in the current bump on master08:24
lyarwoodas well08:24
gibithis means that we now change what libvirt version we use for testing the upgrade from ussuri08:26
*** kukacz has quit IRC08:26
*** dtantsur|afk is now known as dtantsur08:27
*** kukacz has joined #openstack-nova08:28
lyarwoodgibi: we would also change the version of libvirt installed when testing stable/ussuri as a whole08:36
lyarwoodgibi: but tbh I don't think anyone is actually using the default versions installed in bionic08:36
bauzassorry I was focusing on some downstream bugs08:38
bauzasa tl:dr: please ?08:39
lyarwoodbauzas: sean-k-mooney suggested that we use the Train UCA in Victoria so we can land the libvirt version bump *without* hitting the QEMU issue found in focal and the Ussuri UCA.08:40
bauzaslyarwood: for all jobs ?08:41
lyarwoodbauzas: This mostly works but we need to also use the Train UCA on stable/ussuri to allow grenade jobs on master to pass08:41
lyarwoodbauzas: yes for all jobs08:41
bauzaslyarwood: so it would be a Focal + train UCA for all jobs, right?08:41
*** k_mouza has joined #openstack-nova08:41
lyarwoodbauzas: no just bionic08:41
lyarwoodbauzas: this doesn't change the focal situation08:41
lyarwoodbauzas: it just means we can land the libvirt version bump ahead of the focal change08:42
lyarwoodbauzas: so we don't end up landing the version bump after rc08:42
bauzaslyarwood: I raised a concern yesterday about us bumping minimums so close to RC108:42
bauzasbut I heard people wanting us to bump08:42
lyarwoodbauzas: we don't have a choice if the TC are pushing us to move to focal08:43
bauzaswell, TC aren't operators08:43
bauzassome of them are08:43
bauzasbut I don't want us to hold all our gate so close to RC1 because we found some bugs unexpectedly08:43
bauzastelling "we had to do it because $TC" is a terrible explanation08:44
lyarwoodI also hate making changes like this so close to RC tbh08:44
lyarwoodbut if we don't support bionic08:44
bauzasokay, let's be pragmatic and discuss about the change surface to be as minimal as we can08:44
gibido we need to change the min libvirt version to be able to switch to Focal?08:44
bauzasthere are two different concerns here08:44
bauzas1/ people want to bump versions08:45
bauzas2/ TC wants us to move to Focal08:45
bauzasthose two concerns aren't interrelated08:45
bauzas(AFAICT)08:45
lyarwoodright, we did however say that we would bump the min versions in V08:46
lyarwoodand that we would also move the next versions in V08:46
lyarwoodgibi: correct we don't need to change the min to move to focal08:46
bauzasbumping minimums is somehow understandable08:46
bauzasmore than us moving to Focal, tbh08:47
openstackgerritLiang Fang proposed openstack/nova master: [WIP] rbd patch for volume local cache  https://review.opendev.org/72676208:47
stephenfinI personally class the bumping of minimums more important and less risky than the focal move08:47
bauzasanyway, I want us to stop focusing on distros, and rather be discussing on QEMU versions08:47
lyarwoodtbh I'd personally drop the entire move to focal at this point08:47
stephenfinoh, jinx :)08:47
lyarwood\o/08:47
gibidroping Focal needs to be agreed with the TC08:48
bauzasstephenfin: yeah I'm kinda leading to this conclusion08:48
lyarwoodI'm amazed that we continued with it after M2 tbh08:48
lyarwoodmove early or don't move at all08:48
stephenfinapologies if this was discussed yesterday, but couldn't we have a single non-voting tempest job on Focal?08:48
bauzasgibi: I don't understand why the OpenStack community makes an hard sell on a OS thing08:48
stephenfinto satisfy that request08:48
bauzasI thought we only considered dependencies and not OSes08:49
lyarwoodyeah but I get the feeling that gmann's changes are to the base jobs08:49
bauzasto be frank08:49
lyarwoodwe could overwrite the node labels in our tree however08:49
gibibauzas: me neither but I think to make the communication clear we have to be on the same side with the TC08:49
bauzasokay, let's be pragmatic08:49
bauzasthe problem is with a specific QEMU version that races on volume attach/detach, right?08:50
stephenfinah, you mean the parent 'openstack-*' and 'legacy-*' jobs?08:50
bauzasand past this version, QEMU isn't fixed yet08:50
bauzasam i correct?08:50
lyarwoodstephenfin: yeah08:50
bauzasso, we can legitamately bump the minimums without being impacted by the QEMU issue08:51
bauzaslegitimatly08:51
lyarwoodbauzas: that's the issue with focal and the ussuri UCA yes08:51
lyarwoodbauzas: but we can only bump the mins *if* we use the train UCA, ussuri UCA or move to focal08:51
bauzaslyarwood: because the ussuri UCA ships a qemu version that's impacted, right?08:51
*** Liang__ is now known as LiangFang08:51
lyarwoodbauzas: correct it's the same versions as shipped in focal08:51
lyarwoodbauzas: with the train UCA being a little older and not impacted by the bug08:52
bauzasok, so the problem is with UCA, not the distro08:52
lyarwoodbauzas: well both, it's in the core distro from focal08:52
bauzasah I see08:52
bauzasgotcha08:52
bauzasso08:52
bauzasI'm all documenting this08:52
gibibuming minimum means we change the libvirt version on stable/ussuri too08:53
gibiis it OK?08:53
bauzasgibi: why ?08:53
gibidid we do that before in other stable branches?08:53
lyarwoodgibi: yeah we've done that in the past08:53
stephenfinI guess we'll change the version tested if we backport, yes. We won't change the versions allowed though08:53
lyarwoodbauzas: grenade08:53
gibilyarwood: so it is sort of a normal thing at a min bump?08:53
brinzhang_gibi: IMO, in V release is enough08:53
lyarwoodgibi: iirc the last time we did this was due to QEMU/libvirt bugs08:54
bauzaslyarwood: what?08:54
lyarwoodgibi: so we enabled the UCA to workaround these and had to do it on an older stable release for grenade as well08:54
bauzaslyarwood: I thought grenade was upgrading on the target08:54
brinzhang_Cyborg done this today https://review.opendev.org/#/q/project:openstack/cyborg+branch:master+topic:migrate-to-focal08:54
lyarwoodbauzas: it does but it doesn't rerun devstack08:54
brinzhang_bump to the min version08:54
lyarwoodbauzas: so we'd need to use the train UCA on stable/ussuri to ensure n-cpu from master would work08:55
lyarwoodstephenfin: correct, it's just the tested version in stable/ussuri being changed08:55
lyarwoodand again I don't think anyone is using the min versions of libvirt and QEMU at the moment08:55
*** derekh has quit IRC08:55
lyarwoodif you're using Ubuntu you're using the UCAs08:56
lyarwoodif you're using el distro you;re already way past these versions on stable/ussuri08:56
bauzasok, either way08:56
bauzasif we merge the bumps08:57
bauzasare we sure that the new minimums are satisfied by the train UCA ?08:57
bauzasbecause08:57
bauzaswe could just don't care about train UCA08:57
lyarwoodbauzas: yes see https://review.opendev.org/#/c/746981/08:57
bauzasbut if we would like to tackle the other issue, we would need to deploy a Bionic with Train UCA08:58
lyarwoodbauzas: specifically https://zuul.opendev.org/t/openstack/build/318b52b1aaf6473787405c9ed1ca0bc0/log/controller/logs/dpkg-l.txt08:58
bauzasperfect, then I'm clear08:58
lyarwoodbauzas: that change Depends-On the devstack change pulling in the train UCA08:58
lyarwoodbauzas: all of the non grenade jobs are working08:58
gibiOK, so it is not unprecedentet to change the tested libvirt version on a stable branch08:58
bauzasokay, so I personnally feel that bumping minimums are reasonably safe08:59
gibiso lets do it then08:59
bauzas+108:59
gibibump the minimum and turn on train UCA in stable/ussuri08:59
bauzasand let's do what we approved yesterday for the Focal thing08:59
bauzasthe gmann's work on jobs08:59
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.moves  https://review.opendev.org/72722409:00
bauzaslyarwood: sean-k-mooney: that being said, we need to document the gap09:00
bauzasI guess we can use https://bugs.launchpad.net/nova/+bug/1882521 as a base start09:00
openstackLaunchpad bug 1882521 in OpenStack Compute (nova) "Failing device detachments on Focal" [High,Confirmed] - Assigned to Lee Yarwood (lyarwood)09:00
*** mkrai has joined #openstack-nova09:01
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys  https://review.opendev.org/72775709:01
gibibauzas: could you drop the -2 from https://review.opendev.org/#/c/749707 then?09:01
bauzasgibi: I was on it09:01
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte  https://review.opendev.org/72777709:01
gibicoolio09:01
lyarwoodubuntu-- https://zuul.opendev.org/t/openstack/build/fc4fd2d6fcd14618899060c4e84edca0/log/job-output.txt#6579 one small thing to fix here for the evacuation tests also09:01
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types  https://review.opendev.org/72809409:01
lyarwoodbauzas: and you mean outside of https://review.opendev.org/#/c/746981/6/releasenotes/notes/victoria-libvirt-version-bump-e1a09b3a72ee56a4.yaml09:01
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.text_type (1/2)  https://review.opendev.org/72810909:01
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.text_type (2/2)  https://review.opendev.org/72811709:02
*** martinkennelly has joined #openstack-nova09:02
openstackgerritTakashi Natsume proposed openstack/nova master: doc: correct the link to user/flavor.rst  https://review.opendev.org/74017609:02
bauzaslyarwood: no, it's a matter of communicating the caveat we found with Focal09:03
openstackgerritTakashi Natsume proposed openstack/nova master: doc: Fix rendering in the accelerator support doc  https://review.opendev.org/75157409:03
bauzasbecause TC and the Foundation would communicate on the fact that service projects do support Focal09:03
bauzasbut we regress on a thing09:03
bauzasso, ideally, I would comment this in a prelude section09:03
*** Yumeng has quit IRC09:03
lyarwoodbauzas: ah sorry right can we include a known issues section?09:04
bauzaslyarwood: I guess that RHEL-based distros are also impacted by the volume attach issue since it's a qemu problem ?09:04
bauzaslyarwood: that'd be the right position I guess09:04
*** k_mouza has quit IRC09:04
bauzaslyarwood: reno supports an 'issues' section https://docs.openstack.org/reno/latest/user/usage.html#editing-a-release-note09:05
lyarwoodbauzas: I've not been able to reproduce it on el distros yet09:06
bauzasah shit09:06
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION  https://review.opendev.org/74698109:06
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_FILE_BACKED_DISCARD_VERSION  https://review.opendev.org/74698209:06
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_NATIVE_TLS_VERSION  https://review.opendev.org/74698309:06
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_BETTER_SIGKILL_HANDLING  https://review.opendev.org/74698409:06
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_VIDEO_MODEL_VERSIONS  https://review.opendev.org/74698509:06
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_PMEM_SUPPORT  https://review.opendev.org/74698609:06
openstackgerritLee Yarwood proposed openstack/nova master: test_evacuate.sh: Support libvirt-bin and libvirtd systemd services  https://review.opendev.org/75265009:06
bauzasso it's not purely a qemu thing09:06
lyarwoodwe believe it is but it also appears to be caused by overall load on the host etc so it's super awkward to reproduce09:07
*** martinkennelly has quit IRC09:07
bauzasgibi: removed the -2 and +W the base patch09:08
bauzaslyarwood: what would be a recommendation for operators using Focal ?09:09
bauzasif we document a known issue09:09
*** martinkennelly has joined #openstack-nova09:09
bauzasI mean, is there any found workaround with Focal ?09:09
lyarwoodno, there's not.09:09
lyarwoodthey could hit this issue09:09
bauzasor should we document as a known issue 'hold your OS upgrade if you consider running Victoria"09:10
lyarwoodwell that's the thing we can't if we drop support for bionic09:10
bauzaslyarwood: can't they try to override the base qemu versions by downgrading them using a Train UCA ?09:10
lyarwoodif we support both then we can say that09:10
lyarwoodbauzas: I doubt ubuntu would support that for a few release tbh09:10
bauzaslyarwood: I'm in favor of continuing to support Bionic for that exact reason09:11
bauzasthis whole thing sucks.09:11
lyarwoodbauzas: if we can it would make our lives alot easier09:11
*** k_mouza has joined #openstack-nova09:12
bauzashonestly, we would then have to write "if you wanna use Victoria and you feel you're impacted by the bug, please consider running another distro that's not impacted" ?09:12
bauzasthis is absolutely serious.09:12
bauzascan't we try to find Canonical engineers to help us ?09:13
bauzassahid isn't here AFAICS09:13
bauzasjamespage neither.09:13
stephenfinsahid left Canonical and is now...somewhere else09:14
lyarwoodkashyap has been trying to engage their QEMU engineer09:14
lyarwoodyes I did mean engineer09:14
lyarwood8|09:14
bauzasgibi: have you engaged with the TC about this very critical issue ?09:14
lyarwoodbrb I need more coffee09:15
bauzashopefully gmann did the liaison09:15
kashyaplyarwood: Is this the Focal topic?09:15
* kashyap reads back09:15
kashyapstephenfin: gibi: lyarwood: In general: in the past I've gone to Ubuntu's -stable IRC channel to point out missing virt-related backports09:16
*** k_mouza has quit IRC09:16
kashyapBut that's not scalable...09:16
bauzasI'm sure that raising the problem to the TC and eventually the Foundation would send a signal that Canonical would be foolish to not capture09:17
bauzasbecause if we eventually say "sorry, but you can race on volume attach/detach with Focal and you have no other options but to consider other distros for this release if you BFV", that would certainly put some prios09:18
*** arjunbaindur has joined #openstack-nova09:18
bauzasthat's my expectation at least09:18
*** k_mouza has joined #openstack-nova09:18
bauzaslyarwood: do you feel brave enough to write the problem and the absence of solution in a reno note ?09:20
lyarwoodbauzas: I can try09:25
bauzasthanks09:26
*** derekh has joined #openstack-nova09:26
gibiso on Focal the only solution is to downgrade libvirt?09:27
gibiso on Focal the only solution is to downgrade qemu09:27
bauzasgibi: there is no solution for Focal, IIUC09:27
bauzasthat's the problem09:27
bauzasor I'd rather say "there is no solution found yet for Focal"09:27
bauzasthis leaves people investigating a potential workaround09:28
gibithere is no way to use an older qemu there?09:28
bauzasgibi: lyarwood said this is though to downgrade09:28
bauzasdue to the canonical support model09:28
*** brinzhang_ has quit IRC09:28
bauzaswe would then ask to install an old qemu version that's not supporter09:28
bauzassupported09:28
lyarwoodgibi / bauzas ; Yeah I can't speak for Canonical but we (RH) wouldn't support that with our distros09:29
bauzaswhich makes sense tbh09:29
gibiOK, then simply state what we know in the reno.09:29
gibidon't have to be sugarcoated09:29
lyarwoodkk09:29
gibithere is an open qemu bug to link to09:29
bauzasgibi: we also need to state we haven't identified yet a solution.09:29
bauzasif I was an operator, I'd surely reconsider upgrading if I feel I could be impacted09:30
gibibeing it a qemu bug I don't really think we as openstack can find a solution09:30
bauzasI do agree09:30
gibibut yes, be clear that we don't know a viable workaround on Focal09:30
bauzasthe workaround could be "don't use volumes ?"09:31
bauzasshit, I can't emoji09:31
gibithat is not a WA :D09:31
kashyapgibi: So for the Focal QEMU problem, the moment we can figure out a libvirt-level reproducer that can really speeden up the root-cause-analysis09:31
kashyapgibi: The tricky part here is, it is reproducible only in a Tempest-based setup :-(09:31
gibikashyap: I see09:32
gibibauzas: to answer your earlier question about talking to the TC, I haven't doen that (yet). I will raise the issue to them09:33
kashyapgibi: One approach I want to try (once I get these other pressing thing off my chest) is to setup a CPU-intensive workload, and do an attach+detach on a guest launched w/ plain libvirt09:33
kashyap... and then pray to the Juju under the sea that the issue will reprocuce09:33
bauzasgibi: thanks09:34
*** LiangFang has quit IRC09:35
gibibauzas: will you add the limitation to our relesenotes in a separate patch from the https://review.opendev.org/#/c/751045/3/releasenotes/notes/victoria-prelude-9b4c16ff8c6e7f3e.yaml ?09:39
gibican I approve ^^?09:39
bauzasgibi: yes, I'll add another prelude item in a separate change once lyarwood documents the issue in another reno change09:39
gibiack09:40
gibithanks09:40
bauzasgibi: lyarwood: tbc, this is what I see :  a documented 'issues' note that explains the problem and the absence of known solution09:40
bauzasand a prelude item that would only refer to this problem09:40
gibisure, that works for me09:40
*** vishalmanchanda has quit IRC09:43
* bauzas bails out for 2 hours, back to sports09:46
openstackgerritLee Yarwood proposed openstack/nova master: releasenote: Add known issue for bug #1894804  https://review.opendev.org/75265409:46
openstackbug 1894804 in qemu (Ubuntu) "Second DEVICE_DELETED event missing during virtio-blk disk device detach" [Undecided,New] https://launchpad.net/bugs/189480409:46
lyarwoodbauzas: ^09:46
bauzashah09:46
bauzaslooking now09:46
gibilyarwood: looking too09:46
bauzaslyarwood: absolutely well written09:47
bauzaslyarwood: I would +3 if I could09:47
gibilooks good to me too09:47
* bauzas leaves now this time09:49
*** vishalmanchanda has joined #openstack-nova09:57
lyarwoodstephenfin: https://review.opendev.org/#/c/746984/ thoughts on this btw09:57
*** martinkennelly has quit IRC10:00
openstackgerritMerged openstack/nova master: fakelibvirt: Use versionutils to set min versions found in the driver  https://review.opendev.org/74970710:02
openstackgerritMerged openstack/nova master: Victoria 22.0.0 prelude section  https://review.opendev.org/75104510:03
*** psachin has quit IRC10:09
*** rcernin has quit IRC10:09
*** psachin has joined #openstack-nova10:11
gibibauzas, lyarwood, gmann: pinged the TC about the our Focal limitation http://lists.openstack.org/pipermail/openstack-discuss/2020-September/017390.html10:11
stephenfingibi: Do you still have your SR-IOV environment available? If so, could you run a test for me?10:16
gibistephenfin: sure10:16
lyarwoodgibi: ack thanks10:16
*** psachin has quit IRC10:16
lyarwoodmelwitt: https://review.opendev.org/#/c/747361/ - would you mind hitting this stable backport series today?10:16
stephenfingibi: Could you try (a) pausing and (b) stopping a guest and then attaching an SR-IOV-based VIF to it?10:17
*** psachin has joined #openstack-nova10:18
gibiso try to attach it while it is pause or stopped10:18
stephenfinyup10:18
stephenfinand ideally detach also, but that's less critical10:18
gibiOK, I will check it soon10:19
stephenfinI want to see if libvirt complains and if the guest handles it when it's resumed10:19
stephenfinack, thanks :)10:19
*** vinay_m has joined #openstack-nova10:19
vinay_mhi , regarding this bug : https://bugs.launchpad.net/nova/+bug/189323810:20
openstackLaunchpad bug 1893238 in OpenStack Compute (nova) "nova document search result links not working" [Medium,Triaged]10:20
stephenfin(reason being that we call attach_device without the live or persistent flags, so I suspect libvirt might crash and burn without them https://github.com/openstack/nova/blob/f47bde539c8/nova/virt/libvirt/driver.py#L4425)10:20
vinay_mis search implementation is diff/seperate from nova service ?10:21
vinay_mmeans like is it not involved with nova code part10:22
sean-k-mooneystephenfin: i kind of figured out why the func test failed. its not the fakelibvirt changes10:24
sean-k-mooneyat least not directly10:24
stephenfinvinay_m: the search functionality is a Sphinx feature so no, it's not a nova issue10:25
sean-k-mooneythe source_dev elemnt is different in one of the comarisons so it does not find the device to detach10:25
gibistephenfin: boot, pause, attach, unpause. No error, the running guest sees the new device10:27
stephenfingibi: Okay, cool. I wonder what the point of those flags is so :-\10:28
stephenfingibi: Could you run one final check? If you attach the device then stop and start the guest, does it stick around?10:28
sean-k-mooneystephenfin: im really thinking we might want to remove tehm and pass true in all cases10:29
gibidetaching while paused leads to a failure and a retry loop10:29
sean-k-mooneygibi: yep it should10:30
vinay_mstephenfin: thx10:30
sean-k-mooneylibvirt will wait for the guest to respond to the acpi hot unplug interupt10:30
sean-k-mooneyand since its paused it wont10:30
stephenfinsean-k-mooney: Yeah, I'm not even sure what the point of them is. By passing 'live=True', we'll be passing the 'VIR_DOMAIN_AFFECT_LIVE' flag to the 'attachDeviceFlags' call10:32
stephenfinlibvirt says that "VIR_DOMAIN_AFFECT_LIVE specifies that the device shall be allocated to the active domain instance only and is not added to the persisted domain configuration."10:32
stephenfinbut if the instance is shutoff, then by definition there isn't an active domain so that should fail10:33
*** xek has joined #openstack-nova10:33
stephenfin"Note that the target hypervisor must return an error if unable to satisfy flags."10:33
sean-k-mooneyah ok10:33
sean-k-mooneyi didnt know about the error requiremetn10:33
*** mkrai has quit IRC10:34
*** mkrai_ has joined #openstack-nova10:34
sean-k-mooneywell i did but not with that wording10:34
stephenfinmy thinking was simply to set the 'VIR_DOMAIN_AFFECT_LIVE' and 'VIR_DOMAIN_AFFECT_CONFIG' flags based on checking 'domain.isActive()' and 'domain.isPersistent()' respectively10:34
stephenfinbut if it's that simple, why do you even need the flags10:35
sean-k-mooneyya10:35
* stephenfin is confused10:35
sean-k-mooneyi think that should work10:35
sean-k-mooneycan you  add a patch to try it10:35
gibistephenfin: boot, attach, stop, start: guest keeps the attached device10:35
sean-k-mooneyas i said i know we have had some issues where the live and persistent domains get out of sync10:35
stephenfinweeeeeird10:36
stephenfinmight have to ask danpb about this one10:36
sean-k-mooneygibi: start recreated the xml form start so its going to work in the nova cases10:36
sean-k-mooneyeven if we dont update the persistent domain10:36
sean-k-mooneyi kindof wish we did not have a persistnet domain in nova10:37
sean-k-mooneyjust use teh traisiant one10:37
sean-k-mooneyit would remove a subset of bugs10:37
stephenfinsean-k-mooney: ah, that's a fair point10:37
* lyarwood reads up10:37
lyarwoodsean-k-mooney: I thought that was the plan in W?10:37
lyarwoodsean-k-mooney: to look into removing the persistent domain that is10:38
stephenfinI was thinking of reboot in the libvirt sense, where you have to have a persistent domain10:38
sean-k-mooneylyarwood: add it to the ptg/spec list10:38
sean-k-mooneylyarwood: that is what we talked about after that CVE10:38
lyarwoodyup doing it now10:38
sean-k-mooneydid you bring it up upstream yet10:38
*** jangutter has joined #openstack-nova10:38
sean-k-mooneylyarwood: stephenfin is looking at the device attach/detach flag we use and tryign to figure out why we pass live/persited true/false in places10:39
lyarwoodI thought we had talked about it here but obviously not sorry10:39
lyarwoodah10:39
lyarwoodso10:39
lyarwoodthat's because the initial attempt to detach10:39
lyarwoodmight only detach from the inactive config10:40
lyarwoodafter that we only want to try the live config10:40
stephenfinlyarwood: not for PCI devices10:40
lyarwoodthat's async and can fail if the guestos doesn't work with us10:40
stephenfinwe're not using the detach_device_with_retry helper for those10:40
stephenfinhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L439610:40
stephenfinvs https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L2306-L230910:41
stephenfinalso not for mdev devices https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L751210:41
*** kukacz has quit IRC10:41
lyarwoodwhat's the reason for not using the helper with PCI devices?10:41
lyarwoodor mdevs?10:41
lyarwoodshouldn't the semantics be the same10:42
*** jangutter_ has quit IRC10:42
stephenfinnot a clue :) that's what I was thinking but I can't find proof10:42
stephenfinnor can I find proof that what we do for the other cases is even correct10:42
sean-k-mooneyso pci device detach was really only done in suspend until recently10:42
lyarwoodyeah I would think they should be the same tbh, virtio-blk devices are PCI devices after all10:42
*** jangutter_ has joined #openstack-nova10:42
lyarwoodoh right10:42
stephenfinfor example, we don't pass the live or persistent flags to the attach_device call for PCI devices10:42
stephenfinhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L442510:42
lyarwoodhotunplug wasn't always a thing with PCI passthrough10:43
stephenfinyet we do for other devices like network interfaces https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L224710:43
stephenfinwhy? I don't know10:43
sean-k-mooneyfor pci passthough its still not a thing for neutron sriov port it partly worked btu it never freed the devices10:43
sean-k-mooneyin the pci tracker10:43
lyarwoodkk then that might be why10:43
lyarwooda single call would be enough if the domain was paused10:44
lyarwoodand iirc live == running or paused right10:44
stephenfinyeah10:44
sean-k-mooneya paused domian is runnign yes10:44
sean-k-mooneywell live10:44
stephenfinI want to replace that with a call to isActive10:44
stephenfinsame thing, fwict10:44
sean-k-mooneyits still defiend and qemu is running but the cpus are stopped10:44
*** rcernin has joined #openstack-nova10:44
lyarwoodis this all from the dom.xml(PAUSED) patch btw stephenfin ?10:45
stephenfinyup :( I'm way down this rabbit hole now10:45
* lyarwood hasn't got back to that after dumping stale comments in there the other day10:45
*** jangutter has quit IRC10:45
lyarwoodkk10:45
lyarwoodwell just to confuse you even more10:45
lyarwoodhttps://review.opendev.org/#/c/749929/ is how we should be doing this10:46
lyarwoodeventually10:46
lyarwoodthat's incomplete but events are apparently a better way of checking when things are actually detached10:46
stephenfinoh, very nice10:46
lyarwoodurgh I want to rewrite detach_device_with_retry so much in W10:49
*** martinkennelly has joined #openstack-nova10:49
lyarwoodstephenfin: so sorry I lost track of what the issue is here now10:51
stephenfinThe question is whether we should be setting the live parameter here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L442510:52
stephenfingibi's testing suggests it's not necessary, in which case I guess the question is do we need to be setting it here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L224710:53
*** rcernin has quit IRC10:54
sean-k-mooneystephenfin: if we just remove the persistnt domain then this is a moot point10:54
stephenfintrue10:54
sean-k-mooneywell maybe not10:55
sean-k-mooneywe might need to backport something10:55
sean-k-mooneyfor issue on older branches10:55
lyarwoodstephenfin: yeah odd, I wonder if it's something in https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainAttachDeviceFlags that defaults to attaching it to all configs?10:55
stephenfinVIR_DOMAIN_AFFECT_CURRENT sounds reasonable10:56
lyarwoodhttps://github.com/openstack/nova/blob/c49cd3b9669da3f8da377369442bbe749fcb3c13/nova/virt/libvirt/driver.py#L1921 we also do that for disks FWIW10:56
lyarwoodprovide persistent and live that is10:56
sean-k-mooneylyarwood: ya i was wondering if currently we shoudl jsut set both to true10:57
sean-k-mooneybut was not sure if that would fail in some cases10:57
stephenfinOr drop both flags and use VIR_DOMAIN_AFFECT_CURRENT (modify whatever state the instance is currently in)10:57
lyarwoodstephenfin: right but we would need to ensure that would attach or detach from both configs at the moment11:01
stephenfincan the two get out of sync?11:01
lyarwoodstephenfin: if we dropped the inactive persistent config then yeah we could just use that11:01
lyarwoodstephenfin: yup11:01
stephenfinI thought an instance was either persistent or transient11:02
stephenfin*domain11:02
* stephenfin wonders who on earth would want them to be different11:02
lyarwoodstephenfin: https://bugzilla.redhat.com/show_bug.cgi?id=1861142 for an example btw11:03
openstackbugzilla.redhat.com bug 1861142 in openstack-nova "[OSP 13.0.z] Unable to detach volume from instance when previously removed from the inactive config" [High,Verified] - Assigned to lyarwood11:03
*** xek has quit IRC11:05
stephenfinfun11:05
lyarwoodso much11:05
sean-k-mooneyhow would people feel about backporting droping the persistent domain? is that doable or no?11:13
sean-k-mooneyim not sure how that and rolling upgrades would interact11:14
stephenfinlet's get it in master before we even think about11:14
stephenfinthat11:14
sean-k-mooneyya im just wondering for some of the downstream bugs.11:15
sean-k-mooneyalthough lyarwood you are fixign that bug via the events right11:15
*** rcernin has joined #openstack-nova11:18
lyarwoodWe could for new domains11:19
lyarwoodwe would just need to retain support for persisted domains for a while11:20
lyarwoodbut that's the same in master11:20
lyarwoodactually I don't know if we could ever drop that support really11:20
sean-k-mooneywe should be able too11:20
lyarwoodunless we wait for major OS changes11:20
lyarwoodlike bionic to focal11:20
lyarwoodthat would need LM anyway11:20
lyarwoodthat would need an upgrade check on the computes11:21
sean-k-mooneyso if all new domains are trasiant. and we make all move operations transitant and all hard reboots convert them to transient11:21
lyarwoodso ops could be told something like `you're upgrading Nova to a version without support for persistent domains, LM instances from this compute host now before moving`11:21
sean-k-mooneythen i think we only need 1 or 2 releases to drop it11:21
lyarwoodyeah that's cool11:22
sean-k-mooneywe would want a nova status check or something11:22
sean-k-mooneyto say hay these vms still need to be moved11:22
*** rcernin has quit IRC11:23
lyarwoodyup11:23
sean-k-mooneyfrom a down stream persective it woudl be nice if this was in wallaby11:25
sean-k-mooneysince the upgrade to wallaby will be an FFU and will involve migrations11:25
lyarwoodyup11:25
kashyapsean-k-mooney: I'm on the Focal box you gave me; I'm doing a bunch of tests in it, I hope it won't disappear under my feet? :-)11:26
sean-k-mooneykashyap: not unless you or lyarwood delete it11:27
sean-k-mooneyi wont be doing any maintance on it until kolla releases victoria or i hit a kernel issue that requires a reboot11:28
kashyapsean-k-mooney: Ah-ha, thank you11:29
sean-k-mooneyits the same cloud i do all my dev on too11:29
kashyapAnd thanks for doing the gratis maintenance of this cloud for us11:29
kashyapI feel like I should be paying you out in a beverage of your choice, for using your electricity remotely11:29
sean-k-mooneyits going to be running anyway11:30
sean-k-mooneyat some point im probaly going to redploy a limited third party ci on it again11:30
vinay_mstephenfin : gone through bug comments ,discussed like it would be sphinx version related issue11:32
sean-k-mooneywhen i do ill proably try and replace fort nebula for multi numa testing of the whitebox plugin11:32
vinay_mi would like to explore how a search ref link working ,added in nova/doc/source/index.rst , how can i ?11:33
sean-k-mooneyvinay_m: you can propose a patch via gerrit and the docs job will render a preview sight11:34
sean-k-mooneyyou can also build the docs locally11:34
sean-k-mooneyusing tox11:34
sean-k-mooneyif you donwload the repos11:34
sean-k-mooneyi think that woudl be enouch to test the search capablity11:35
openstackgerritLee Yarwood proposed openstack/nova master: zuul: Introduce nova-evacuate  https://review.opendev.org/74488311:40
openstackgerritLee Yarwood proposed openstack/nova master: zuul: Replace nova-live-migration with zuulv3 jobs  https://review.opendev.org/75255711:40
lyarwoodgmann: https://review.opendev.org/#/c/752641/ would you mind taking a look at this if you have time11:42
*** k_mouza has quit IRC11:45
*** suryasingh has quit IRC11:48
*** k_mouza has joined #openstack-nova11:51
openstackgerritLee Yarwood proposed openstack/nova-specs master: WIP/DNM - Image defined ephemeral storage encryption  https://review.opendev.org/75228411:54
*** rcernin has joined #openstack-nova11:54
*** ygk_12345 has joined #openstack-nova11:54
*** kukacz has joined #openstack-nova11:54
ygk_12345hi all11:54
ygk_12345i am facing a unique problem with rocky11:55
*** k_mouza has quit IRC11:55
ygk_12345when I create an instance, it is having 4 vnics inside and they are getting ips from four dhcp tenant networks. but  after sometime the vm is lossing its two network interfaces11:56
ygk_12345so when I rebooth it then, then the vnics  are coming back but again after 100 secs they are disappearing again . is this a knownw issue ? that image worked earlier11:57
*** k_mouza has joined #openstack-nova11:58
*** rcernin has quit IRC11:59
sean-k-mooneyit sounds like you have a neutron issue12:01
sean-k-mooneyygk_12345: if neutron is retruning incosistent data then the force refesh of the netwrok info cache will result in the cache being populated with that inconsitent data12:02
*** links has quit IRC12:02
sean-k-mooneywe have seen this downstream with contrail and aci  before12:02
sean-k-mooneyi have not see it be an issue with intree network backends12:02
ygk_12345sean-k-mooney I see these messages in the compute node where that instance is12:03
ygk_12345Received unexpected event network-vif-plugged-86f1034d-837d-4e67-ad5e-63d9642a0b2a for instance with vm_state active and task_state None.12:03
ygk_12345Received unexpected event network-vif-unplugged-86f1034d-837d-4e67-ad5e-63d9642a0b2a for instance with vm_state active and task_state None.12:03
sean-k-mooneywhat neutron backend are you using12:04
*** sapd__x has quit IRC12:04
ygk_12345ovs12:04
ygk_12345ovs12:04
sean-k-mooneywith iptables or contrack12:04
ygk_12345 ovs12:04
sean-k-mooneyfor the firewall driver12:04
ygk_12345how to check it ?12:04
sean-k-mooney/etc/neutron/plugins/ml2/ml2_conf.ini12:05
ygk_12345sean-k-mooney let me check12:05
ygk_12345sean-k-mooney firewall_driver = openvswitch12:06
sean-k-mooneyok that is conntrack12:06
ygk_12345sean-k-mooney so whats the workaround for this issue ?12:06
sean-k-mooneyyou have not provided enough info to know what the issue is yet12:07
ygk_12345why i s the vif intermittently loosing connection and dropping ?12:07
sean-k-mooneythose event wont casue the vif to be removed form the guest12:07
ygk_12345sean-k-mooney so what logs to check in particulaer ?12:08
sean-k-mooneywell first you need to look at the instance action logs for the affected instance and determin that no api action was performend on the guest12:08
ygk_12345sean-k-mooney its happening only with a particular image12:08
sean-k-mooneythe image cant affect this unless you are using the watchdog and the vm hung and was rebooted12:09
ygk_12345where can I find those logs ?12:09
sean-k-mooneyopenstack server event list <uuid>12:10
ygk_12345no actions except  two reboots which I did12:11
ygk_12345create,reboot,reboot12:11
sean-k-mooneyok if there are no action at the time of the events you next need to look at the neutron agent logs12:11
sean-k-mooneybasically you need to check why the agent updated the port status12:12
ygk_12345which agent in particular ?12:12
ygk_12345dhcp ?12:12
sean-k-mooneyif it was devstack it would be devstack@q-agt but its the neutron ovs l2 agent12:12
ygk_12345ok12:12
sean-k-mooneyif nova is not perfroming any instance actions then the port vif:host-id should not be updating12:13
ygk_12345how can I track the port status of an instance in the ovs logs ?12:14
sean-k-mooneyso the only thing that would cause those event to be emitted is a change in state form the ovs agent12:14
sean-k-mooneyyou need to have the neutron port uuid if the agent is in debug mode it will print the uuid of the port it is processign at differnt times12:14
ygk_12345ok let me check12:15
sean-k-mooneywhat you are looking for is if the port is listed in teh added or deleted list of ports around teh time of the events12:15
sean-k-mooneythat would indicate the port being removed or added to the ovs bridge12:15
sean-k-mooneysimialrly if the admin state on the newon port was changed it would also show up there12:15
sean-k-mooneyygk_12345: the other thing that you cold check before going into the agent logs is the qemu instance log12:16
ygk_12345oh ok12:16
sean-k-mooneyand confirm that there are no restarts12:16
sean-k-mooneyygk_12345: do you enabel the watchdog or qemu guest agent in teh image that is affected12:17
ygk_12345no idea12:18
sean-k-mooneythey would be listed in the image metadata in glance12:18
sean-k-mooneyygk_12345: those event typically mean 1 of two things. eighet the tap device was removed and added to ovs, or the port was updated (host-id or admin status)12:20
ygk_12345i dont think  they are set for that image12:20
sean-k-mooneyok12:20
sean-k-mooneythis sound like its not a nova issue for what its worth12:20
sean-k-mooneybut check the qemu log to confim there is not reboot of the instace when it happened. if so then you need to look at the l2 agent logs if that does not show anyting then you need to check the dhcp agent and neutron server logs for the port uuid12:21
sean-k-mooneyto track down why the event was sent12:21
*** ratailor has quit IRC12:25
ygk_12345ok12:26
ygk_12345sean-k-mooney even when the vnics  have disappeared, those ports are being shown as active in nova12:28
ygk_12345how can this be ?12:28
sean-k-mooneywithout logs i cant really help you resolve this. can you file a bug and attach some logs specificly the nova compute and l2 agent logs for aroudn the time when this happened12:31
*** links has joined #openstack-nova12:31
ygk_12345ok12:31
sean-k-mooneywhat your describing does not really match to any known broken behviaor that comes to mind12:32
sean-k-mooneythe only way to revmoe an interface form a vm that is runnign other then a nova interface detach which is not present in the event logs12:32
sean-k-mooneyis to delete the neutron port12:32
sean-k-mooneythat will send a network-vif-deleted event to nova12:33
sean-k-mooneybut presuably you did not delete the nuetorn port12:33
sean-k-mooneyso im not aware of any code path that could result in this12:33
ygk_12345strange12:33
sean-k-mooneythe info cache currption issue requires a hard reboot for the instance to be lost or a move operations12:34
*** k_mouza_ has joined #openstack-nova12:40
*** k_mouza has quit IRC12:42
ygk_12345sean-k-mooney when the ping is unreachable for the vm , I dont see any messages for that port in the neutron-server except when I do a manual reboot12:44
lyarwoodubuntu--12:46
openstackgerritLee Yarwood proposed openstack/nova master: test_evacuate.sh: Support libvirt-bin and libvirtd systemd services  https://review.opendev.org/75265012:46
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION  https://review.opendev.org/74698112:46
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_FILE_BACKED_DISCARD_VERSION  https://review.opendev.org/74698212:46
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_NATIVE_TLS_VERSION  https://review.opendev.org/74698312:46
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_BETTER_SIGKILL_HANDLING  https://review.opendev.org/74698412:46
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_VIDEO_MODEL_VERSIONS  https://review.opendev.org/74698512:46
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_PMEM_SUPPORT  https://review.opendev.org/74698612:46
stephenfinlyarwood: https://media.tenor.com/images/a53dc07bf0a6f8822f16c0760299f915/tenor.gif12:47
gibi:)12:49
lyarwoodyup sorry all12:51
* lyarwood needs to head offline for a few hours12:53
lyarwoodback this evening to clean up any fallout caused by all of this12:53
gibiack12:56
ygk_12345sean-k-mooney i have posted this bug https://bugs.launchpad.net/nova/+bug/189622612:58
openstackLaunchpad bug 1896226 in OpenStack Compute (nova) "The vnics are disappearing in the vm" [Undecided,New]12:58
*** nweinber has joined #openstack-nova13:00
*** martinkennelly has quit IRC13:00
*** arjunbaindur has quit IRC13:02
kashyaplyarwood: Hey, so do you know how many CPU cores did that reproducer host had?13:02
kashyaplyarwood: I'm asking because, depending on that I may need to fork my CPU workload to spread across multiple (CPU) cores13:03
*** dave-mccowan has joined #openstack-nova13:04
kashyapMeanwhile ... lovely: I just created a fresh F32 VM on Ubuntu Focal, and the bootloader is filling up little yellow squares on my screen.13:05
gibikashyap: I think it is 8 https://zuul.opendev.org/t/openstack/build/4c56def513884c5eb3ba7b0adf7fa260/log/zuul-info/host-info.controller.yaml#44013:10
gibikashyap: at least this is the CI job run linked to the bug report13:11
* kashyap clicks; thank you 13:11
*** owalsh has quit IRC13:11
kashyapgibi: So that's the "host VM" where Tempest is running, yeaH?13:17
bauzasgibi: thanks13:17
kashyapgibi: I'm trying to recreate the _exact_ damn setup :D13:18
bauzas(for the TC ping)13:18
*** k_mouza_ has quit IRC13:18
*** tosky_ has joined #openstack-nova13:18
*** tosky is now known as Guest8304713:18
*** tosky_ is now known as tosky13:18
gibikashyap: yes I think that is the "host" where tempest runs13:18
sean-k-mooneykashyap: it has 8 i think13:18
kashyapgibi: Okay, 8 vCPUs, and  7599 MB of memory13:19
kashyapgibi: And do you see what's the disk size?13:19
sean-k-mooneyyep ist my small flavor13:19
kashyapsean-k-mooney: The disk size is ~16GB?13:20
gibi size: 80.00 GB13:20
kashyapgibi: Oh, right13:20
gibihttps://zuul.opendev.org/t/openstack/build/4c56def513884c5eb3ba7b0adf7fa260/log/zuul-info/host-info.controller.yaml#259-29313:20
kashyapOkay; I need to tweak the setup so that I'm also doing QEMU-on-KVM nested and not KVM-on-KVM nested13:20
kashyapThanks; /me back in a few13:20
gibithanks kashyap13:20
openstackgerritMerged openstack/nova master: releasenote: Add known issue for bug #1894804  https://review.opendev.org/75265413:22
openstackbug 1894804 in qemu (Ubuntu) "Second DEVICE_DELETED event missing during virtio-blk disk device detach" [Undecided,New] https://launchpad.net/bugs/189480413:22
*** k_mouza has joined #openstack-nova13:22
*** LinPeiWen has quit IRC13:29
sean-k-mooneykashyap: you dont need 80G of disk by the way 25-40G is typeically more then enough13:33
*** ygk_12345 has quit IRC13:36
*** xek has joined #openstack-nova13:36
kashyapsean-k-mooney: Yeah, I have something like that anyway13:38
kashyapsean-k-mooney: Do we have the full guest command-line of the Focal VM "host" upstream is using?13:40
sean-k-mooneyif you want an account on my home cloud by the way let me know and i can create one for you13:40
sean-k-mooneyno bug its just an openstack vm13:40
*** k_mouza has quit IRC13:40
sean-k-mooneywith 8G of ram and 8 cpus and 80G fo disk13:41
sean-k-mooneyim not sure that really matters too much13:41
kashyapsean-k-mooney: Okay; so what you gave me suffices13:42
kashyapsean-k-mooney: For now, stable access (and it _is_ stable) to this VM is sufficient :) Thx!13:42
sean-k-mooneyya my small flaovr is basicaly a proxy for the ci vms13:42
sean-k-mooneyexcept i add hw:cpu_sockets=2 hw:cpu_threads=2 hw:numa_nodes=2 and hw:mem_page_size=large13:43
sean-k-mooneythat should not change the behvior in this case but just an fyi13:43
kashyapsean-k-mooney: One more: what's the CirrOS version being run here?13:44
*** vinay_m has quit IRC13:45
kashyap"here" as in, in the Tempest env13:45
sean-k-mooneythe default one form devstack so like 4.2 ish13:45
kashyapI'd like to know the exact version, although it shouldn't matter _that_ much13:45
*** vinay_m has joined #openstack-nova13:45
sean-k-mooney0.5.113:45
sean-k-mooneyhttps://github.com/openstack/devstack/blob/master/stackrc#L67013:45
kashyapExcellent13:45
sean-k-mooneyit hasnt been updated in 7 months https://github.com/openstack/devstack/commit/7a0fa4fd9e5db7253fee0820fc002703d43bca3c so that should be what its using13:46
sean-k-mooneythe fine i think shoudl still be in /opt/stack/data i think13:46
*** k_mouza has joined #openstack-nova13:50
*** k_mouza has quit IRC13:55
*** rcernin has joined #openstack-nova13:55
*** artom has joined #openstack-nova13:56
*** rcernin has quit IRC14:00
*** k_mouza has joined #openstack-nova14:02
kashyapAlso, annoyingly enough, CirrOS from 0.4.0 onwards, it's only initrd/kernel, so I can't use 'guestfish' to look around in it: https://paste.centos.org/view/10bee1e114:08
*** xek has quit IRC14:09
*** links has quit IRC14:11
*** vinay_m has quit IRC14:14
openstackgerritStephen Finucane proposed openstack/nova stable/ussuri: tests: Add regression test for bug 1894966  https://review.opendev.org/75237114:21
openstackbug 1894966 in OpenStack Compute (nova) ussuri "Create servergroup failed with unexpected error" [Undecided,Confirmed] https://launchpad.net/bugs/189496614:21
openstackgerritStephen Finucane proposed openstack/nova stable/ussuri: api: Set min, maxItems for server_group.policies field  https://review.opendev.org/75270214:21
*** songwenping_ has quit IRC14:28
*** songwenping_ has joined #openstack-nova14:28
*** owalsh has joined #openstack-nova14:29
*** sapd1 has joined #openstack-nova14:30
openstackgerritStephen Finucane proposed openstack/nova stable/train: tests: Add regression test for bug 1894966  https://review.opendev.org/75270614:31
openstackbug 1894966 in OpenStack Compute (nova) ussuri "Create servergroup failed with unexpected error" [Undecided,In progress] https://launchpad.net/bugs/1894966 - Assigned to Stephen Finucane (stephenfinucane)14:31
openstackgerritStephen Finucane proposed openstack/nova stable/train: api: Set min, maxItems for server_group.policies field  https://review.opendev.org/75270714:31
*** mkrai_ has quit IRC14:34
*** mkrai has joined #openstack-nova14:36
mnaseri'm curious as to why nova needs to ssh for cold migrations if using shared storage14:46
mnasermaybe no one just worked on that test path or?14:47
mnaseraka if shared storage: skip ssh14:47
gibimnaser: I might be wrong but I remember nova detects that the instance is on share path by checking that the same file exists on both the source and the dest14:54
mnasergibi: yeah i think that might be the only reason it still does it14:54
mnaseri think breaking out early if the VM is using volumes only would make sense cause that would eliminate the whole ssh key thing for us14:55
mnaserthe only reason we still have it is just for that14:55
gmanngibi: bauzas lyarwood what is consensus for Focal migration?  same as we discussed in meeting?14:55
sean-k-mooneymnaser: we could do that via an rpc i guess14:55
mnasersean-k-mooney: can one n-cpu rpc to another n-cpui14:55
sean-k-mooneyyes14:56
sean-k-mooneyit happens alot in move operations14:56
sean-k-mooneywell not a lot but we do rpcs between teh computes invovled14:56
gibimnaser: hm, only volume instances still can have config drives14:57
mnasergibi: right but i think we dont actually move that we just rebuild it on the target with a cold migrate14:57
mnaseri _think_14:57
gibimost probably yes14:57
mnaserhttps://github.com/openstack/nova/blob/cff7382fb3de4eef7aeddc34b6ae3409cbe50ea0/nova/virt/libvirt/driver.py#L8340-L837614:58
gibiso, yeah we can stop doing that ssh shared storage check if the instance is only using volumes14:58
mnaserhmm this doesnt seem to use ssh14:58
*** nightmare_unreal has quit IRC15:00
mnaseri cant seem to honestly find the code that does the ssh to remote host..15:00
gibithen i don't know what step needs the ssh15:00
mnaseri should go look for a traceback15:01
gibigmann: we merged the libvirt min version bump, and we go with what we discussed on the meeting yesterday as far as I understand15:01
*** dklyle has joined #openstack-nova15:02
gmanngibi: ok, thanks for confirmation I will check and reply the ML after my breakfast15:02
mnaserok i dont have the actual traceback but it looks like we try to mkdir remotely? https://bugzilla.redhat.com/show_bug.cgi?id=162470915:02
openstackbugzilla.redhat.com bug 1624709 in openstack-packstack "[OSP 13] Need to change the permission of /etc/nova/migration/identity after installation" [High,Closed: errata] - Assigned to ratailor15:02
openstackgerritElod Illes proposed openstack/nova stable/queens: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration  https://review.opendev.org/74797615:04
mnasermaybe a cold migrate does move the configdrive after all15:04
*** mkrai has quit IRC15:05
sean-k-mooneyshelve recreates it as does cross cell resize15:06
sean-k-mooneybut for same cell resize/migrate i think we copy them15:06
gibimnaser: I only see the RemoteFilesystem.create_dir used for non shared instances15:08
gibidriver.py#L69015:08
gibihttps://github.com/openstack/nova/blob/90777d790d7c268f50851ac3e5b4e02617f5ae1c/nova/virt/libvirt/driver.py#L10347-L1034915:08
gibibut during livemigrate we copy the config drive https://github.com/openstack/nova/blob/90777d790d7c268f50851ac3e5b4e02617f5ae1c/nova/virt/libvirt/driver.py#L973115:10
openstackgerritGhanshyam Mann proposed openstack/nova master: DNM Testin Focal with integrated-gate-compute on Bionic  https://review.opendev.org/75271115:11
*** mkrai has joined #openstack-nova15:15
*** xek has joined #openstack-nova15:16
*** xek has quit IRC15:17
*** mkrai has quit IRC15:22
*** mkrai_ has joined #openstack-nova15:22
*** tesseract has quit IRC15:35
*** mlavalle has joined #openstack-nova15:41
*** tkajinam has quit IRC15:44
*** martinkennelly has joined #openstack-nova15:47
*** jawad_axd has quit IRC15:49
openstackgerritBalazs Gibizer proposed openstack/nova master: Use cell targeted context to query instance metadata  https://review.opendev.org/75245915:51
openstackgerritBalazs Gibizer proposed openstack/nova master: Clean up the DynamicVendorData constructor  https://review.opendev.org/75271815:51
gibithat was all from me for this week. See you on Monday15:53
gibio/15:53
*** rcernin has joined #openstack-nova15:56
*** rcernin has quit IRC16:03
*** dtantsur is now known as dtantsur|afk16:10
openstackgerritClaudiu Belu proposed openstack/nova master: hyperv: Configures chassis asset tags for VMs.  https://review.opendev.org/75272316:12
*** mkrai_ has quit IRC16:19
*** vishalmanchanda has quit IRC16:23
sean-k-mooneystephenfin: look like this issue im facing is that the fakelibvirt dirver is incomplete16:23
*** ociuhandu_ has joined #openstack-nova16:23
sean-k-mooneystephenfin: when we generate teh fake instance domain its not provided with the info related to the vm pci devices just that the nic is type direct or whatever.16:24
stephenfinHmm, yeah, that's not surprising16:25
sean-k-mooneywe are also not generating network node_dev elements for any of the pci PF/VFs16:25
sean-k-mooneyim going to hard code a few thigs to see if i can make some minimal chagnes to get it to pass16:25
sean-k-mooneybut we likely need to flesh this out more in the future16:26
stephenfinyeah, I did the minimal amount necessary to get the sr-iov migration tests working16:26
stephenfinbut it's full of holes, for sure. I just didn't have SR-IOV hardware handy to inspect the flow and copy the XML from16:27
sean-k-mooneyso the issue is i need to backprot this to queens16:27
*** ociuhandu has quit IRC16:27
sean-k-mooneyso im hesitent to depend on your refactors16:27
sean-k-mooneybut they might also fix some of the issues16:27
*** ociuhandu_ has quit IRC16:28
sean-k-mooneythis is what causes the detach to fail to find the device currently16:28
sean-k-mooneyhttps://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/fakelibvirt.py#L1826-L183016:28
sean-k-mooneythat ses the souce_dev to fake_pf_interface_name16:28
sean-k-mooneybut in https://review.opendev.org/#/c/602432/17/nova/tests/unit/virt/libvirt/fakelibvirt.py16:29
*** jmlowe has joined #openstack-nova16:29
sean-k-mooneyboth before and after my change we dont set source_dev when generatign the vm domain16:29
*** k_mouza has quit IRC16:29
sean-k-mooneyim going to hard code if for now but im concerned then next thing ill hit is the pci adress dont match adresses form the host pci_info object16:30
sean-k-mooneysince in both cases we are just incrementing the adresses16:30
sean-k-mooneyill corss that bridge later i guess.16:30
*** ociuhandu has joined #openstack-nova16:33
sean-k-mooneythe issue with that fixture is that the comment and assumtion is wrong16:34
sean-k-mooneywe also use this with macvtal to get the vf name not jsut the parent16:34
sean-k-mooneyand we also dont have the required info to work this out when we generate the domain stuff currently.16:34
*** ociuhandu has quit IRC16:37
*** k_mouza has joined #openstack-nova16:40
*** k_mouza has quit IRC16:44
*** nweinber has quit IRC16:44
*** psachin has quit IRC16:49
*** k_mouza has joined #openstack-nova16:51
*** k_mouza has quit IRC16:55
*** derekh has quit IRC17:01
*** hamalq has joined #openstack-nova17:01
openstackgerritMerged openstack/nova master: test_evacuate: Wait until subnode is down before starting tests  https://review.opendev.org/75106517:03
*** k_mouza has joined #openstack-nova17:04
*** k_mouza has quit IRC17:09
*** iurygregory has quit IRC17:10
sean-k-mooneystephenfin: ... https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/fakelibvirt.py#L1087-L109317:14
*** ralonsoh has quit IRC17:14
sean-k-mooneydetach device in the fake libvirt fixture only support disks17:14
*** k_mouza has joined #openstack-nova17:14
sean-k-mooneyso i dont know how/why gibis func test could be passing on master.17:14
*** k_mouza has quit IRC17:19
*** k_mouza has joined #openstack-nova17:26
*** k_mouza has quit IRC17:30
*** k_mouza has joined #openstack-nova17:34
*** gyee has joined #openstack-nova17:35
*** k_mouza has quit IRC17:39
*** k_mouza has joined #openstack-nova17:42
*** k_mouza has quit IRC17:47
*** k_mouza has joined #openstack-nova17:50
*** kukacz has quit IRC17:54
*** k_mouza has quit IRC17:55
*** jawad_axd has joined #openstack-nova18:11
*** jawad_axd has quit IRC18:15
*** irclogbot_1 has quit IRC18:19
*** irclogbot_1 has joined #openstack-nova18:24
*** irclogbot_1 has quit IRC18:31
*** jawad_axd has joined #openstack-nova18:32
*** jawad_axd has quit IRC18:36
*** irclogbot_0 has joined #openstack-nova18:36
*** k_mouza has joined #openstack-nova18:51
*** jawad_axd has joined #openstack-nova18:52
*** k_mouza has quit IRC18:56
*** jawad_axd has quit IRC18:56
*** nweinber has joined #openstack-nova18:57
*** sapd1 has quit IRC18:59
lyarwoodgmann: sorry was afk, are you still around?19:19
lyarwoodgmann: AFAIK the plan is to still move to focal in V and skip the tests19:20
lyarwoodgmann: in the meantime we wanted to try to move bionic onto the train UCA to allow us to move the MIN_ versions in the libvirt driver19:20
lyarwoodgmann: https://review.opendev.org/#/c/752641/ needs to land first in stable/ussuri and then master to allow grenade to work correct19:21
lyarwoodcorrectly*19:21
lyarwoodthen the rest of https://review.opendev.org/#/q/topic:bump-libvirt-qemu-victoria+(status:open+OR+status:merged) can land19:21
*** k_mouza has joined #openstack-nova19:21
lyarwoodgmann: when do you think th focal change is actually going to land btw?19:22
*** k_mouza has quit IRC19:26
*** slaweq has quit IRC19:41
*** k_mouza has joined #openstack-nova19:47
*** k_mouza has quit IRC19:51
gmannlyarwood: hi, sorry i was away19:56
gmannlyarwood: ok, and I am keeping tempest-integrated-compute job on bionic to have those test coverage running somewhere19:59
gmannlyarwood: let me review the devstack patches19:59
gmannplan for Focal migration is pending on Barbican issue which is the only blocker left https://storyboard.openstack.org/#!/story/200773220:00
*** nweinber has quit IRC20:01
*** zzzeek has quit IRC20:06
openstackgerritGhanshyam Mann proposed openstack/nova master: DNM: testing Train UCA  https://review.opendev.org/75275920:09
*** spatel has joined #openstack-nova20:12
*** spatel has quit IRC20:17
*** k_mouza has joined #openstack-nova20:30
*** spatel has joined #openstack-nova20:33
*** k_mouza has quit IRC20:34
*** Corwin has quit IRC20:39
*** zzzeek has joined #openstack-nova20:42
*** owalsh has quit IRC20:46
*** zzzeek has quit IRC20:48
*** nweinber has joined #openstack-nova20:50
*** nweinber has quit IRC20:53
*** zzzeek has joined #openstack-nova20:54
*** spatel has quit IRC20:56
*** zzzeek has quit IRC20:59
*** ociuhandu has joined #openstack-nova21:02
*** zzzeek has joined #openstack-nova21:03
*** zzzeek has quit IRC21:05
*** zzzeek has joined #openstack-nova21:06
*** ociuhandu has quit IRC21:06
*** spatel has joined #openstack-nova21:11
*** zzzeek has quit IRC21:13
*** owalsh has joined #openstack-nova21:14
*** spatel has quit IRC21:16
*** zzzeek has joined #openstack-nova21:16
*** zzzeek has quit IRC21:23
*** zzzeek has joined #openstack-nova21:24
*** rcernin has joined #openstack-nova21:27
*** rcernin has quit IRC21:35
*** rcernin has joined #openstack-nova21:36
openstackgerritMerged openstack/nova stable/ussuri: Correctly disable greendns  https://review.opendev.org/75162121:40
*** rcernin has quit IRC21:42
*** bbowen has joined #openstack-nova21:50
*** bbowen_ has quit IRC21:53
*** rcernin has joined #openstack-nova22:00
*** spatel has joined #openstack-nova22:22
*** dave-mccowan has quit IRC22:22
*** zzzeek has quit IRC22:25
*** zzzeek has joined #openstack-nova22:26
*** spatel has quit IRC22:27
*** zzzeek has quit IRC22:30
*** zzzeek has joined #openstack-nova22:31
*** eharney has quit IRC22:35
*** mlavalle has quit IRC22:38
*** martinkennelly has quit IRC22:38
*** hamalq has quit IRC23:02
openstackgerritMerged openstack/nova master: test_evacuate.sh: Support libvirt-bin and libvirtd systemd services  https://review.opendev.org/75265023:03
openstackgerritMerged openstack/nova stable/rocky: Improve CinderFixtureNewAttachFlow  https://review.opendev.org/74922223:03
*** rcernin has quit IRC23:06
*** zzzeek has quit IRC23:08
*** zzzeek has joined #openstack-nova23:11
*** zzzeek has quit IRC23:16
*** zzzeek has joined #openstack-nova23:17
*** tosky has quit IRC23:31
*** rcernin has joined #openstack-nova23:39
*** hamalq has joined #openstack-nova23:48

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!