| *** zzzeek has quit IRC | 00:13 | |
| *** zzzeek has joined #openstack-nova | 00:15 | |
| *** zzzeek has quit IRC | 00:20 | |
| *** tetsuro has quit IRC | 00:20 | |
| *** zzzeek has joined #openstack-nova | 00:21 | |
| *** tetsuro has joined #openstack-nova | 00:21 | |
| *** tetsuro has quit IRC | 00:21 | |
| brinzhang0 | gmann: agree with you, allowing to request array([]) of the policy is itself an error, improve the error code from 500 to 400, it's good for me | 00:24 |
|---|---|---|
| *** LinPeiWen has joined #openstack-nova | 00:29 | |
| brinzhang0 | gmann, gibi, bauzas: Looks like it's a small change, and it's happened in microversion 2.1~2.63, | 00:33 |
| *** zzzeek has quit IRC | 00:33 | |
| gmann | brinzhang0: as it is already fixed in 2.64, my suggestion is that there is no much benefits to improve error code for older microversion. | 00:35 |
| *** zzzeek has joined #openstack-nova | 00:35 | |
| brinzhang0 | gmann: yeah, but improve it's error code seems friendly to end users | 00:36 |
| brinzhang0 | but as you said, in the privous release, add new microversion is no much benefits | 00:37 |
| gmann | it does not need microversion bump as it is error code improvement to existing error code only. | 00:38 |
| brinzhang0 | how about add a NOTE or WARNING in the request api docs? | 00:38 |
| gmann | yeah, that can be good. saying not to pass 'policies' as empty array. | 00:38 |
| brinzhang0 | yes | 00:39 |
| brinzhang0 | it's better than to improve the error from 500 to 400, after all it's in old release | 00:40 |
| gmann | if you can push the doc change, i am good on that. | 00:41 |
| brinzhang0 | gmann: it's my pleasure, later will do.. | 00:42 |
| gmann | brinzhang0: thanks | 00:42 |
| brinzhang0 | np | 00:42 |
| *** Liang__ has joined #openstack-nova | 01:12 | |
| *** sapd1 has joined #openstack-nova | 01:15 | |
| *** JamesBenson has joined #openstack-nova | 01:18 | |
| *** JamesBenson has quit IRC | 01:18 | |
| *** LinPeiWen has quit IRC | 01:19 | |
| *** zzzeek has quit IRC | 01:22 | |
| *** zzzeek has joined #openstack-nova | 01:24 | |
| *** gyee has quit IRC | 01:25 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add warning to os-server-groups POST api https://review.opendev.org/752133 | 01:33 |
| brinzhang0 | gmann: done by https://review.opendev.org/#/c/752133/ | 01:34 |
| *** zzzeek has quit IRC | 01:45 | |
| *** zzzeek has joined #openstack-nova | 01:47 | |
| *** JamesBenson has joined #openstack-nova | 01:52 | |
| *** JamesBenson has quit IRC | 01:57 | |
| *** k_mouza has joined #openstack-nova | 02:25 | |
| *** k_mouza has quit IRC | 02:30 | |
| *** spatel has joined #openstack-nova | 02:33 | |
| *** rcernin has quit IRC | 02:46 | |
| *** jangutter_ has joined #openstack-nova | 02:49 | |
| *** jangutter has quit IRC | 02:52 | |
| *** rcernin has joined #openstack-nova | 02:56 | |
| *** psachin has joined #openstack-nova | 02:59 | |
| *** LinPeiWen has joined #openstack-nova | 03:01 | |
| *** k_mouza has joined #openstack-nova | 03:24 | |
| *** k_mouza has quit IRC | 03:28 | |
| *** k_mouza has joined #openstack-nova | 03:32 | |
| *** k_mouza has quit IRC | 03:36 | |
| *** mkrai has joined #openstack-nova | 03:44 | |
| *** dave-mccowan has joined #openstack-nova | 03:49 | |
| *** JamesBenson has joined #openstack-nova | 03:53 | |
| *** brinzhang_ has joined #openstack-nova | 03:57 | |
| *** JamesBenson has quit IRC | 03:58 | |
| *** brinzhang0 has quit IRC | 04:00 | |
| *** Liang__ has quit IRC | 04:11 | |
| *** spatel has quit IRC | 04:17 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-nova | 04:33 | |
| *** ratailor has joined #openstack-nova | 04:34 | |
| *** mkrai has quit IRC | 04:39 | |
| *** mkrai has joined #openstack-nova | 04:54 | |
| *** dave-mccowan has quit IRC | 05:00 | |
| *** tetsuro has joined #openstack-nova | 05:03 | |
| *** k_mouza has joined #openstack-nova | 05:18 | |
| *** rcernin has quit IRC | 05:19 | |
| *** tetsuro has quit IRC | 05:22 | |
| *** k_mouza has quit IRC | 05:23 | |
| *** tetsuro has joined #openstack-nova | 05:23 | |
| *** tetsuro has quit IRC | 05:26 | |
| *** rcernin has joined #openstack-nova | 05:28 | |
| *** tetsuro has joined #openstack-nova | 05:35 | |
| *** tetsuro has quit IRC | 05:59 | |
| *** ralonsoh has joined #openstack-nova | 06:03 | |
| *** lpetrut has joined #openstack-nova | 06:15 | |
| *** xek has joined #openstack-nova | 06:32 | |
| openstackgerrit | wu.chunyang proposed openstack/nova master: remove python warnning from tox https://review.opendev.org/752190 | 06:32 |
| *** vishalmanchanda has joined #openstack-nova | 06:40 | |
| *** tetsuro has joined #openstack-nova | 06:40 | |
| *** tetsuro has quit IRC | 06:41 | |
| *** jsuchome has joined #openstack-nova | 06:44 | |
| *** slaweq has joined #openstack-nova | 06:48 | |
| *** kukacz has joined #openstack-nova | 06:49 | |
| gibi | gmann: regarding https://bugs.launchpad.net/nova/+bug/1894966 I would only fix the error code to 500 -> 400 by enhancing the request validation | 06:50 |
| openstack | Launchpad bug 1894966 in OpenStack Compute (nova) "Create servergroup failed with unexpected error" [Low,In progress] - Assigned to Brin Zhang (zhangbailin) | 06:50 |
| *** kaisers has joined #openstack-nova | 06:54 | |
| *** manuvakery has joined #openstack-nova | 06:58 | |
| *** LinPeiWen has quit IRC | 07:00 | |
| *** LinPeiWen has joined #openstack-nova | 07:07 | |
| *** ratailor has quit IRC | 07:08 | |
| *** ratailor has joined #openstack-nova | 07:08 | |
| *** tesseract has joined #openstack-nova | 07:10 | |
| *** ralonsoh has quit IRC | 07:17 | |
| *** Qianbiao has joined #openstack-nova | 07:25 | |
| *** links has joined #openstack-nova | 07:30 | |
| *** k_mouza has joined #openstack-nova | 07:40 | |
| *** yonglihe has joined #openstack-nova | 07:41 | |
| *** tosky has joined #openstack-nova | 07:43 | |
| *** k_mouza has quit IRC | 07:44 | |
| *** mkrai has quit IRC | 07:47 | |
| *** nightmare_unreal has joined #openstack-nova | 07:53 | |
| *** tetsuro has joined #openstack-nova | 07:53 | |
| *** JamesBenson has joined #openstack-nova | 08:03 | |
| *** rcernin has quit IRC | 08:06 | |
| brinzhang_ | gibi, gmann: I think that fix or the docs need to backport to the privous release, right? | 08:07 |
| gibi | brinzhang_: yes that is good to be backported | 08:07 |
| gibi | it is broken since the begining of time I guess | 08:07 |
| brinzhang_ | yes | 08:07 |
| brinzhang_ | so that we should target the bug to the stable branch | 08:08 |
| *** JamesBenson has quit IRC | 08:08 | |
| gibi | yes please | 08:08 |
| brinzhang_ | from v2.1, it's wrong | 08:08 |
| brinzhang_ | gibi: bug 1894966 was backport to ocata, I think it's enough, please check | 08:10 |
| openstack | bug 1894966 in OpenStack Compute (nova) "Create servergroup failed with unexpected error" [Low,In progress] https://launchpad.net/bugs/1894966 - Assigned to Brin Zhang (zhangbailin) | 08:10 |
| *** tetsuro has quit IRC | 08:12 | |
| *** tetsuro has joined #openstack-nova | 08:18 | |
| *** ralonsoh has joined #openstack-nova | 08:20 | |
| *** k_mouza has joined #openstack-nova | 08:22 | |
| *** brinzhang_ has quit IRC | 08:23 | |
| *** brinzhang_ has joined #openstack-nova | 08:24 | |
| *** ralonsoh has quit IRC | 08:24 | |
| *** tetsuro has quit IRC | 08:24 | |
| gibi | brinzhang_: sure, it is OK. older than ocata branches are already marked end of life and deleted | 08:25 |
| brinzhang_ | gibi: ack | 08:25 |
| *** k_mouza has quit IRC | 08:26 | |
| nightmare_unreal | I am writing a testcase for live_migration_abort feature but I keep getting this <module 'novaclient.v2.server_migrations' from '.tox/py38/lib/python3.8/site-packages/novaclient/v2/server_migrations.py'> does not have the attribute 'live_migration_abort' | 08:28 |
| nightmare_unreal | any suggestions | 08:28 |
| nightmare_unreal | it does exists that method | 08:29 |
| *** mkrai has joined #openstack-nova | 08:30 | |
| lyarwood | nightmare_unreal: are you using the correct microversion in the test | 08:31 |
| *** k_mouza has joined #openstack-nova | 08:31 | |
| nightmare_unreal | i am using v2.79 I think minimum required is 2.24 | 08:31 |
| nightmare_unreal | https://www.irccloud.com/pastebin/t91I0E9V/abort%20test%20case | 08:32 |
| nightmare_unreal | here I am doing something like this | 08:32 |
| *** dtantsur|afk is now known as dtantsur | 08:33 | |
| lyarwood | https://github.com/openstack/python-novaclient/blob/d3d88c29cb7b65f6c2a66405b0aa2e3306d7d3ea/novaclient/tests/unit/v2/test_server_migrations.py#L85-L92 looks there's already a test FWIW | 08:33 |
| *** jkulik has joined #openstack-nova | 08:35 | |
| *** k_mouza has quit IRC | 08:35 | |
| *** jsuchome has quit IRC | 08:37 | |
| nightmare_unreal | ah it's for the osc-client | 08:40 |
| nightmare_unreal | i am trying to bring this feature to osc | 08:41 |
| lyarwood | nightmare_unreal: kk, I don;t work on osc but shouldn't you just wire up an actual request to abort the migration instead of calling python-novaclient? | 08:43 |
| *** martinkennelly has joined #openstack-nova | 08:44 | |
| lyarwood | that reminds me I wanted to wire up evacuate in osc as well | 08:44 |
| *** k_mouza has joined #openstack-nova | 08:44 | |
| nightmare_unreal | hmm , but in the existing code there is already novaclient-object so it's essentially novaclient_obj.server_migrations.live_migration_abort(s, m) | 08:45 |
| nightmare_unreal | but I will think around it :) . Thanks | 08:45 |
| lyarwood | ignore me if there's code already calling it | 08:47 |
| *** derekh has joined #openstack-nova | 08:53 | |
| *** jangutter has joined #openstack-nova | 08:58 | |
| kashyap | nightmare_unreal: Reading your IRC nick may or may not induce stress in some people :D I love it, though | 09:00 |
| nightmare_unreal | thanks kashyap , I had few comments on my IRC few times ( mostly positive) . I was young(still young) and loved games, anime | 09:01 |
| nightmare_unreal | so I love that nick and using it | 09:01 |
| *** jangutter_ has quit IRC | 09:02 | |
| kashyap | Haha, nod. | 09:02 |
| kashyap | nightmare_unreal: It's particuarly _apt_ given the times ;-) | 09:02 |
| nightmare_unreal | haha true :D | 09:03 |
| *** ociuhandu has joined #openstack-nova | 09:15 | |
| *** ralonsoh has joined #openstack-nova | 09:16 | |
| *** kukacz has quit IRC | 09:38 | |
| *** kukacz has joined #openstack-nova | 09:40 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP zuul: Introduce nova-multinode-evacuate https://review.opendev.org/744883 | 09:40 |
| *** xek has quit IRC | 09:41 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP zuul: Introduce nova-multinode-evacuate https://review.opendev.org/744883 | 09:51 |
| *** ociuhandu_ has joined #openstack-nova | 09:52 | |
| *** ociuhandu has quit IRC | 09:55 | |
| openstackgerrit | Merged openstack/nova master: Allow tap interface with multiqueue https://review.opendev.org/748533 | 09:56 |
| *** JamesBenson has joined #openstack-nova | 10:04 | |
| *** mkrai has quit IRC | 10:04 | |
| brinzhang_ | stephenfin: about https://review.opendev.org/#/c/752133/1, you mean, we should change 500 to 400? | 10:04 |
| stephenfin | yes | 10:04 |
| stephenfin | gimme a sec, I have a patch | 10:04 |
| brinzhang_ | yeah | 10:04 |
| *** jawad_axd has joined #openstack-nova | 10:07 | |
| *** JamesBenson has quit IRC | 10:09 | |
| *** gryf has quit IRC | 10:12 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add regression test for bug 1894966 https://review.opendev.org/752210 | 10:14 |
| openstack | bug 1894966 in OpenStack Compute (nova) "Create servergroup failed with unexpected error" [Low,In progress] https://launchpad.net/bugs/1894966 - Assigned to Brin Zhang (zhangbailin) | 10:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Set min, maxItems for server_group.policies field https://review.opendev.org/752211 | 10:14 |
| *** gryf has joined #openstack-nova | 10:14 | |
| stephenfin | brinzhang_: gibi: ^ | 10:14 |
| stephenfin | That approach makes more sense to me, at least | 10:14 |
| gibi | stephenfin: as I stated above I'm OK with both way, just documenting, or changing the return code to 400. gmann felt it is better just to document it | 10:16 |
| gibi | gmann: ^^ | 10:18 |
| stephenfin | I consider this a better form of documentation | 10:18 |
| stephenfin | In that the API will tell the user what they did wrong, as opposed to yielding some cryptic error that they must go Google for | 10:19 |
| stephenfin | My 2c :) | 10:19 |
| gibi | make sense | 10:19 |
| gibi | I added gmann to the review | 10:19 |
| brinzhang_ | it's ok, is it need to docs that the changes of this API? | 10:20 |
| brinzhang_ | This may break the user's perception of existing create server_group API. | 10:22 |
| brinzhang_ | but it's ok for me too. | 10:22 |
| stephenfin | brinzhang_: Resolving a HTTP 5xx error does not require a microversion | 10:30 |
| stephenfin | The idea being that a user shouldn't have to opt-in to non-broken behaviour | 10:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Enable real policy fixture by default https://review.opendev.org/745906 | 10:32 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add and use 'GlanceFixture' https://review.opendev.org/745907 | 10:32 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Remove '_FakeImageService' https://review.opendev.org/745908 | 10:32 |
| stephenfin | bauzas: Fixed the failing test in that first patch ^ | 10:32 |
| sean-k-mooney | its the scond branch in the flow chard https://docs.openstack.org/nova/pike/contributor/microversions.html | 10:32 |
| brinzhang_ | stephenfin: I know, which way is ok forme | 10:32 |
| stephenfin | I'm eager to get it merged because things keep changing under my feet /o\ | 10:32 |
| bauzas | stephenfin: will look at those later today | 10:32 |
| bauzas | did a bug scrub | 10:32 |
| stephenfin | thanks | 10:32 |
| brinzhang_ | From the requirements of the manual, changing the API response requires adding microversion | 10:34 |
| gibi | bauzas: can I take the bug lock? | 10:34 |
| gibi | thanks for scrubbing | 10:35 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove 'NovaObjectDictCompat' from 'Migration' https://review.opendev.org/723572 | 10:38 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove 'NovaObjectDictCompat' from 'InstancePCIRequest' https://review.opendev.org/723573 | 10:39 |
| *** slaweq has quit IRC | 10:41 | |
| *** ociuhandu_ has quit IRC | 10:45 | |
| *** ociuhandu has joined #openstack-nova | 10:46 | |
| *** slaweq has joined #openstack-nova | 10:54 | |
| *** raildo has joined #openstack-nova | 11:03 | |
| *** JamesBenson has joined #openstack-nova | 11:15 | |
| *** JamesBenson has quit IRC | 11:17 | |
| *** JamesBenson has joined #openstack-nova | 11:17 | |
| *** elod has quit IRC | 11:18 | |
| *** elod has joined #openstack-nova | 11:18 | |
| *** zzzeek has quit IRC | 11:27 | |
| *** jraju__ has joined #openstack-nova | 11:28 | |
| *** links has quit IRC | 11:29 | |
| *** zzzeek has joined #openstack-nova | 11:30 | |
| nightmare_unreal | what can be the cause of tempest failures ? is it related to user patch or infrastructure/zuul issue ? | 11:47 |
| sean-k-mooney | nightmare_unreal: both | 11:50 |
| sean-k-mooney | normlly user patches | 11:50 |
| sean-k-mooney | the jobs can fail for infra reasons | 11:50 |
| sean-k-mooney | but then that normlaly happens before tempest runs | 11:50 |
| gibi | stephenfin: one small question / request in https://review.opendev.org/#/c/745907/9/nova/tests/functional/regressions/test_bug_1675570.py@131 | 11:50 |
| sean-k-mooney | in rare ocation tempets test will fail because of infra if for example the iops of the disk are too low | 11:51 |
| sean-k-mooney | nightmare_unreal: but normally tempest failures are because fo the use patch. unless its a POST_FAILURE which si almost always infra related | 11:51 |
| nightmare_unreal | sean-k-mooney: in my case osc-tx-py36-tips, tempest-full-py3, osc-functional-devstack and osc-functional tips failed | 11:52 |
| sean-k-mooney | nightmare_unreal: which patch? | 11:52 |
| nightmare_unreal | https://review.opendev.org/#/c/742210/ | 11:52 |
| nightmare_unreal | status is post_failure | 11:52 |
| nightmare_unreal | not for tempest | 11:53 |
| sean-k-mooney | ya so post_failure | 11:53 |
| sean-k-mooney | is not your problem | 11:53 |
| sean-k-mooney | that means it failed in one of the post jobs like uploading the logs | 11:53 |
| sean-k-mooney | that is an infra issue and you can just recheck | 11:53 |
| nightmare_unreal | Oh, thanks . will recheck help | 11:53 |
| nightmare_unreal | ah okay | 11:53 |
| sean-k-mooney | the tempst run is only 16m long | 11:53 |
| gibi | stephenfin: I'm totally OK to do an hard coded uuid GlanceFixture.imageX reference replacemnet in a separate patch | 11:53 |
| nightmare_unreal | thanks :) | 11:53 |
| sean-k-mooney | let me check that | 11:53 |
| sean-k-mooney | but that looks like it failed to deploy | 11:53 |
| sean-k-mooney | ERROR: No matching distribution found for oslo.service===2.4.0 (from -c /opt/stack/requirements/upper-constraints.txt (line 306)) | 11:54 |
| sean-k-mooney | nightmare_unreal: so the tempest job failed because it could not install oslo.service | 11:54 |
| sean-k-mooney | that is likely because our mirrors where out of sync | 11:54 |
| nightmare_unreal | oh got it | 11:55 |
| sean-k-mooney | which is also an infa issue | 11:55 |
| nightmare_unreal | I see | 11:55 |
| sean-k-mooney | so i think we can recheck this but good to ask infra if the issue is fixed first | 11:55 |
| nightmare_unreal | I guess I will wait for some time | 11:55 |
| nightmare_unreal | and then recheck | 11:55 |
| nightmare_unreal | okay | 11:55 |
| sean-k-mooney | the zuul run was yesterday | 11:56 |
| nightmare_unreal | i will ask in that channel | 11:56 |
| sean-k-mooney | so i think it shoudl be ok gibi do you know if the mirror issue we hit yesterday is fixed | 11:56 |
| frickler | nightmare_unreal: sean-k-mooney: that was an issue with pypi and should be fixed since around midnight | 11:56 |
| nightmare_unreal | alright :) . I will recheck in that case | 11:57 |
| nightmare_unreal | thanks everyone | 11:57 |
| frickler | we only proxy and cache requests to pypi, no mirroring | 11:57 |
| sean-k-mooney | frickler: ah the mirros are for the distro packages only | 11:57 |
| sean-k-mooney | i tought we have devpi running on the afs file system too | 11:58 |
| frickler | sean-k-mooney: yes, we stopped running bandersnatch when hit the 2T limit a long time ago. yesterday we learning that pypi's own mirror filled up 12T and got stuck with that a month ago | 11:58 |
| sean-k-mooney | ah i see | 11:59 |
| sean-k-mooney | 12TB im guessing it does not prune old verions regularly | 11:59 |
| frickler | well for a full mirror they likely need to keep all versions | 12:00 |
| sean-k-mooney | that or there is a lot of software reguarlly asking for old verions of stuff | 12:00 |
| sean-k-mooney | ah right | 12:00 |
| sean-k-mooney | ya i like devpi because it was a caching proxy for pypi | 12:01 |
| sean-k-mooney | as well as a local pip comparitble data store for your own packages | 12:01 |
| sean-k-mooney | frickler: are we just using squid or something now as a http cache | 12:01 |
| *** ociuhandu_ has joined #openstack-nova | 12:01 | |
| *** slaweq has quit IRC | 12:01 | |
| *** derekh has quit IRC | 12:01 | |
| *** ratailor has quit IRC | 12:01 | |
| sean-k-mooney | i havent redeployed my onw cache since i moved house and got gigabit but its still vaguly on my todo list after i redeploy my testing third party ci. | 12:02 |
| *** ociuhandu has quit IRC | 12:04 | |
| *** mkrai has joined #openstack-nova | 12:05 | |
| frickler | we use apache2 because it does both the proxying and serve our mirrored repos at the same time and on the same host, just with different paths | 12:05 |
| sean-k-mooney | ah i might have to look at how that is configured and maybe steal it for my own use at somepoint. having all of infras confic public as a referce is quite helpful that way | 12:10 |
| *** mkrai has quit IRC | 12:29 | |
| *** slaweq has joined #openstack-nova | 12:31 | |
| *** Qianbiao has quit IRC | 12:33 | |
| *** Qianbiao has joined #openstack-nova | 12:34 | |
| *** jangutter_ has joined #openstack-nova | 12:37 | |
| *** jangutter has quit IRC | 12:40 | |
| *** dave-mccowan has joined #openstack-nova | 12:41 | |
| *** nweinber has joined #openstack-nova | 12:48 | |
| *** xek has joined #openstack-nova | 12:56 | |
| *** vishalmanchanda has quit IRC | 13:04 | |
| bauzas | gibi: sorry missed your ping | 13:06 |
| bauzas | you surely can | 13:06 |
| bauzas | gibi: but I'll do some scrubbing too, so lemme know which ones you're looking | 13:06 |
| gibi | bauzas: looking at https://bugs.launchpad.net/nova/+bug/1881944 right now and I think that will be my last for today | 13:16 |
| openstack | Launchpad bug 1881944 in OpenStack Compute (nova) "nova-api returns empty block-device-mapping in metadata queries" [Undecided,New] | 13:16 |
| gibi | nice work on the open bugs, thanks | 13:16 |
| bauzas | gibi: okay, then going on the next ones | 13:16 |
| stephenfin | gibi, bauzas: Thoughts on this bug? https://bugs.launchpad.net/nova/+bug/1741810 tl;dr: since we introduced the ImageMetaProps o.vo way back in Liberty, one can no longer filter on non-standard image metadata properties using 'AggregateImagePropertiesIsolation' | 13:18 |
| openstack | Launchpad bug 1741810 in OpenStack Compute (nova) "Filter AggregateImagePropertiesIsolation doesn't Work" [Undecided,New] | 13:18 |
| stephenfin | so one can filter on 'os_distro=windows' but not 'os=windows' | 13:19 |
| *** sapd1_x has joined #openstack-nova | 13:19 | |
| bauzas | stephenfin: looking | 13:20 |
| sean-k-mooney | stephenfin: this sound invaild | 13:20 |
| stephenfin | gibi, bauzas: I have ideas on how to fix it but I wonder if we should? | 13:20 |
| sean-k-mooney | stephenfin: there are nolonger any non-standard image proeprties | 13:20 |
| *** derekh has joined #openstack-nova | 13:20 | |
| bauzas | what sean-k-mooney said | 13:20 |
| * bauzas looks at https://bugs.launchpad.net/nova/+bug/1893904 | 13:20 | |
| openstack | Launchpad bug 1893904 in OpenStack Compute (nova) "Placement is not updated if a VGPU is re-created on a new GPU upon host reboot" [Undecided,New] | 13:20 |
| stephenfin | Okay, that's what I'm thinking too. However, glance doesn't place the same restrictions on image metadata properties | 13:21 |
| sean-k-mooney | correct | 13:21 |
| sean-k-mooney | but nova will drop all nonstandard image metadata | 13:21 |
| sean-k-mooney | well no | 13:21 |
| sean-k-mooney | there is a config option for glance | 13:21 |
| stephenfin | So do we just document things, or should we store stuff that's namespaced? | 13:21 |
| sean-k-mooney | that uses the metadefs for validation | 13:21 |
| sean-k-mooney | stephenfin: there are no namespaces in glance metadata | 13:22 |
| sean-k-mooney | at least there was not untill we added trits | 13:22 |
| stephenfin | right, there are traits now | 13:22 |
| stephenfin | i.e. we store anything prefixed with 'aggregate_metadata_' | 13:22 |
| sean-k-mooney | they decied to use prefixes not namespaces | 13:22 |
| stephenfin | namespace, prefix, whatever | 13:22 |
| stephenfin | but just '<namespace>key=value' | 13:23 |
| sean-k-mooney | they are different technically | 13:23 |
| stephenfin | sure, but let's gloss over that for now | 13:23 |
| sean-k-mooney | but ya am i think we shoudl jsut close this as not a bug | 13:23 |
| sean-k-mooney | well invalid | 13:23 |
| stephenfin | wontfix | 13:23 |
| stephenfin | it was a behavior change | 13:24 |
| sean-k-mooney | ah we have that then ya | 13:24 |
| gibi | stephenfin: I agree to close it with some notes about not supporting non-standard props | 13:24 |
| sean-k-mooney | yes but it was not supproted before | 13:24 |
| sean-k-mooney | it just happened to work | 13:24 |
| stephenfin | Okay, I'll do that so. I have a functional test to prove it too. I assume I can just drop that? | 13:24 |
| *** jangutter has joined #openstack-nova | 13:25 | |
| sean-k-mooney | you could keep it as a negitve regression | 13:25 |
| sean-k-mooney | to ensure we dont acidentaly roll back and enable it | 13:25 |
| gibi | stephenfin: drop it | 13:27 |
| gibi | you could add a warning in the doc of AggregateImagePropertiesIsolation if you wish | 13:28 |
| *** jangutter_ has quit IRC | 13:28 | |
| gibi | sean-k-mooney: btw, do you familiar with this periodic log https://zuul.opendev.org/t/openstack/build/470edd644f704a578226c55c7d92ba39/log/controller/logs/screen-n-cpu.txt#8179 ? For me it seems like a new and pretty useless thing to log | 13:29 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Improve 'AggregateImagePropertiesIsolation' docs https://review.opendev.org/752236 | 13:29 |
| stephenfin | bauzas, gibi: Real easy doc-o bug there so ^ | 13:29 |
| bauzas | kk | 13:29 |
| gibi | stephenfin: +2 | 13:30 |
| bauzas | stephenfin: you closing the bug, right? | 13:30 |
| sean-k-mooney | stephenfin: glance has a allow_additional_image_properties option which when set to false means you can only use standard image properties https://docs.openstack.org/glance/latest/admin/useful-image-properties.html#using-image-properties | 13:30 |
| stephenfin | bauzas: yup, writing a reply atm | 13:31 |
| bauzas | ta | 13:31 |
| sean-k-mooney | https://docs.openstack.org/glance/latest/configuration/glance_api.html#DEFAULT.allow_additional_image_properties | 13:31 |
| stephenfin | gibi: I'm not sean-k-mooney but I suspect that's just a difference between how that modules treats DEBUG and how we do | 13:31 |
| *** jangutter_ has joined #openstack-nova | 13:31 | |
| stephenfin | we can easily configure logging levels to ignore that | 13:31 |
| gibi | stephenfin: so we just need a filter | 13:31 |
| stephenfin | yes | 13:31 |
| sean-k-mooney | gibi one sec ill take a look | 13:32 |
| stephenfin | there's a config option that we use to set the logging level for e.g. oslo.log | 13:32 |
| sean-k-mooney | gibi that is because we swapped the default backend | 13:33 |
| bauzas | sean-k-mooney: looks to me a feature https://bugs.launchpad.net/nova/+bug/1887377 | 13:33 |
| openstack | Launchpad bug 1887377 in OpenStack Compute (nova) "nova does not loadbalance asignmnet of resources on a host based on avaiablity of pci device, hugepages or pcpus." [Undecided,New] - Assigned to sean mooney (sean-k-mooney) | 13:33 |
| sean-k-mooney | os vif now uses the native backend | 13:33 |
| bauzas | sean-k-mooney: because it could be a weigher or using the placement API | 13:33 |
| sean-k-mooney | instead of ovs-vsctl | 13:33 |
| stephenfin | definitely a feature | 13:34 |
| sean-k-mooney | gibi: i can install a log filter for that if you like and drop it | 13:34 |
| stephenfin | sean-k-mooney: again, there's already a conf option for this in nova | 13:34 |
| stephenfin | that oslo.log provides | 13:34 |
| sean-k-mooney | bauzas: its one that i want to backport downstream and do as a preqquist to numa in placment | 13:34 |
| *** jangutter has quit IRC | 13:34 | |
| stephenfin | I just can't remember what it's called and quick grep doesn't return anything, heh | 13:34 |
| sean-k-mooney | bauzas: i would prefer to backport it upstream too but if we agree it a feature then fine | 13:35 |
| * gibi is also looking for that config | 13:35 | |
| sean-k-mooney | i guess its something we could not bring back but its broderlien in my view | 13:35 |
| bauzas | sean-k-mooney: well, it would change the behaviour then, right? | 13:36 |
| bauzas | at least if you modify the default | 13:36 |
| sean-k-mooney | loadbalancing between the numa nodes on the host | 13:36 |
| bauzas | surely | 13:36 |
| sean-k-mooney | it would slightly yes | 13:36 |
| bauzas | but operators already know about it, | 13:36 |
| bauzas | so they know it's packing atm | 13:36 |
| sean-k-mooney | they know that if they are using numa they should match teh numer of numa nodes that are on the host | 13:37 |
| sean-k-mooney | but they often dont do that | 13:37 |
| bauzas | if we change the default to rather spreading, then this would change their own capacity | 13:37 |
| gibi | stephenfin: https://docs.openstack.org/oslo.log/latest/configuration/index.html#DEFAULT.default_log_levels | 13:37 |
| gibi | I think this is the config | 13:37 |
| stephenfin | that's the one \o/ | 13:37 |
| bauzas | sean-k-mooney: for this reason, I don't want it to be a bug | 13:37 |
| sean-k-mooney | bauzas: it will pesimise the spawnign of large vms | 13:37 |
| stephenfin | yes, we overload that in 'nova/config.py' | 13:37 |
| sean-k-mooney | but it would fix many other issues | 13:38 |
| bauzas | and fwiw, everytime we added a new filter or weigher, we said "noooo sorry, not a bug" | 13:38 |
| *** benj_ has quit IRC | 13:38 | |
| bauzas | this would be the same | 13:38 |
| sean-k-mooney | bauzas: its not a new filter or weigher | 13:38 |
| bauzas | I know | 13:38 |
| bauzas | but spreading/packing resources are related to a weigher, even not that's the implementation way | 13:38 |
| sean-k-mooney | ok well then ill close the downstrema bz and say this wont be fixed in 16.x then | 13:39 |
| gibi | stephenfin, sean-k-mooney: I will add an extra log settings for the periodic ovs debug log in https://docs.openstack.org/oslo.log/latest/configuration/index.html#DEFAULT.default_log_levels | 13:39 |
| bauzas | ie. you want to change how to organize the resources | 13:39 |
| bauzas | for this reason, not a bug | 13:39 |
| gibi | I mean in nova.config.parse_args | 13:39 |
| sean-k-mooney | gibi: you could or i coudl do it in os-vif | 13:39 |
| sean-k-mooney | i think os-vif makes more sense | 13:39 |
| sean-k-mooney | gibi: this is coming form the ovs plugin | 13:39 |
| gibi | yeah, you are right os-vif is a better place | 13:39 |
| gmann | gibi: stephenfin brinzhang_ ok for me, +A on 500->400. | 13:39 |
| sean-k-mooney | it woudl still be configrev via the nova.conf jsut form a os vif config section | 13:39 |
| gibi | gmann: thanks | 13:40 |
| sean-k-mooney | so the ux is more or less the same | 13:40 |
| *** Qianbiao has quit IRC | 13:40 | |
| gmann | gibi: is it ocata is 'Unmaintained' for nova? we only need backport till pike? | 13:40 |
| gmann | lyarwood: ^^ | 13:40 |
| bauzas | gmann: gibi: stephenfin: are we discussing on the API issue we saw yesterday ? | 13:40 |
| gmann | bauzas: yeah, server group with empty 'policies' | 13:40 |
| bauzas | if so, there are some docs for telling whether we need to have a new microversion or not | 13:40 |
| *** Qianbiao has joined #openstack-nova | 13:40 | |
| gibi | bauzas: it is about the server group policies being an empty list before 2.63 | 13:40 |
| sean-k-mooney | bauzas: leave a comment on the loadbalancing bug and ill convert it to a blueprint/spec | 13:40 |
| bauzas | gibi: and afaict, 500 being changed 400 is told "nooope, that's a bug" | 13:40 |
| gmann | bauzas: yeah this one we do not need microversion bump for 500->400 - https://docs.openstack.org/nova/pike/contributor/microversions.html#id2 | 13:40 |
| bauzas | hence not a microversion required | 13:41 |
| gmann | yeah | 13:41 |
| gibi | yeah | 13:41 |
| bauzas | and you can backport | 13:41 |
| stephenfin | Cool, that's my understanding too. Glad we all agree | 13:41 |
| bauzas | sean-k-mooney: just did, closed at Invalid/Wishlist | 13:41 |
| stephenfin | The API telling you did a naughty thing >>> having to read docs to figure it out | 13:41 |
| gibi | gmann: I think ocata is still open in EM | 13:41 |
| gmann | it is documented also if new error code is from already returned error codethen no microversion needed - https://docs.openstack.org/nova/pike/contributor/microversions.html#id2 | 13:42 |
| gmann | stephenfin: your base patch for adding test failing, did not check why | 13:42 |
| bauzas | gmann: stephenfin: gibi: https://docs.openstack.org/nova/latest/contributor/microversions.html#when-do-i-need-a-new-microversion | 13:42 |
| stephenfin | gmann: Any chance you could swing by https://review.opendev.org/#/c/745906/ and the other two patches in the series again today so we can finally close that out? It went into merge conflict yet again :( | 13:42 |
| bauzas | "Fixing a bug so that a 400+ code is returned rather than a 500 or 503 does not require a microversion change." | 13:42 |
| gmann | gibi: i think no as CI is broken there and not fixable due to stests issue. | 13:42 |
| stephenfin | I'd say PyPI issues | 13:42 |
| gmann | i see. got it | 13:42 |
| gibi | gmann: I still see the branch exists in https://opendev.org/openstack/nova/ | 13:43 |
| bauzas | gibi: stephenfin: gmann: any change I could look ? | 13:43 |
| stephenfin | bauzas: https://review.opendev.org/#/c/752211/1 | 13:43 |
| bauzas | ta | 13:43 |
| gibi | bauzas: yeah stephenfin has some ^^ | 13:43 |
| bauzas | hah, the ship has sailed :) | 13:43 |
| stephenfin | https://review.opendev.org/#/c/752210/ is still open though | 13:43 |
| gmann | gibi: yeah that should be removed once it move to EOL after 6 month from being marked as 'unmaintained' let me check email | 13:43 |
| stephenfin | gmann: Yeah, pypi mirror issues :( | 13:43 |
| gibi | gmann: ohh, I see. the it could be unmaintained | 13:44 |
| gibi | gmann: I forgot we have such state | 13:44 |
| gibi | sean-k-mooney: so let's add the default log change to os-vif. Will you push a patch? | 13:44 |
| bauzas | stephenfin: the gate is borked, nope ? | 13:45 |
| stephenfin | on and off | 13:45 |
| stephenfin | I guess it depends on the node you land on or something | 13:45 |
| stephenfin | given one patch failed badly and the next one passed just fine | 13:45 |
| sean-k-mooney | gibi: ya im fixing some unit test on a nova bug but ill push the os-vif patch this evening. if you feel like doing it jut add me as an a review | 13:46 |
| sean-k-mooney | we can priorties the backport | 13:47 |
| gibi | sean-k-mooney: no rush, I let you do it and I wil review it when its up | 13:47 |
| gibi | sean-k-mooney: thanks | 13:47 |
| gmann | gibi: this declared ocata as unmaintained and EOL after 3 month http://lists.openstack.org/pipermail/openstack-discuss/2020-July/015747.html http://lists.openstack.org/pipermail/openstack-discuss/2020-July/015744.html | 13:47 |
| sean-k-mooney | cool ill add you to the review | 13:47 |
| gibi | sean-k-mooney: thanks | 13:47 |
| mgoddard | Hi. I'm hitting an issue with encrypted volumes and migration/evacuation. Raised a bug about it: https://bugs.launchpad.net/nova/+bug/1895848 | 13:47 |
| openstack | Launchpad bug 1895848 in OpenStack Compute (nova) "Migration and evacuation fails with encrypted volumes" [Undecided,New] | 13:47 |
| gibi | gmann: OK so we just wait until next year before we delete the branch | 13:47 |
| gibi | gmann: I would say that then backports to ocata are not needed | 13:47 |
| sean-k-mooney | gibi: for what its worth i have been looking at that for the last few days and wondering if people would complain :) | 13:48 |
| gmann | gibi: yeah | 13:48 |
| *** k_mouza has quit IRC | 13:49 | |
| gibi | sean-k-mooney: it kicked my OCD when triaged an unrealated bug in devstack | 13:49 |
| sean-k-mooney | ya some of the logs are useful but the pooling on fd one is not | 13:50 |
| sean-k-mooney | i have used some of the other debug logs so im goign to target the removal to just the pooling one and not the module | 13:50 |
| gibi | sean-k-mooney: sure, just filter this log if possible | 13:51 |
| *** benj_ has joined #openstack-nova | 13:51 | |
| sean-k-mooney | yep its pretty simple | 13:51 |
| gibi | cool | 13:51 |
| gmann | gibi: As CI is broken for ocata and not fixable, I proposed stable/release team to universally declare it 'unmaintained' instead of project wise but we went with 'let projects do by them self'. | 13:51 |
| tosky | (yes, please) | 13:52 |
| bauzas | wow, this is weirdo https://bugs.launchpad.net/nova/+bug/1892176 | 13:52 |
| openstack | Launchpad bug 1892176 in OpenStack Compute (nova) "Inconsistent result between index and show of instance api" [Undecided,New] | 13:52 |
| sapd1_x | Hi everyone, I would like to change the boot order of root device of instances. How can I do that? | 13:52 |
| sapd1_x | In my case, I use ISO file to install OS to vda device. So there are two devices (vda - iso, vdb - empty bootable volume) after installed the OS. How can I remove vda device or change the order of devices. | 13:53 |
| *** k_mouza has joined #openstack-nova | 13:56 | |
| sean-k-mooney | bauzas: by index they mean server list right | 13:58 |
| sean-k-mooney | yes they do | 13:58 |
| bauzas | sean-k-mooney: yup | 13:58 |
| sean-k-mooney | so maybe its still in the api db | 13:58 |
| bauzas | sean-k-mooney: I know that ironic makes magic balancing | 13:58 |
| sean-k-mooney | but missing either cell mapping or something in the cell db | 13:58 |
| bauzas | sean-k-mooney: well, they just kill ironic-api right? | 13:59 |
| sean-k-mooney | bauzas: of compute hosts between compute services right | 13:59 |
| bauzas | sean-k-mooney: but both servers GET and INDEX don't require our virt drivers to be up | 13:59 |
| sean-k-mooney | oh i know that | 13:59 |
| bauzas | so I suspect that ironic makes some recalculation on an ironic-api destroy, which borks either the cell DB or the API DB, I do agree | 14:00 |
| bauzas | an inconsistency | 14:00 |
| *** Liang__ has joined #openstack-nova | 14:00 | |
| *** Liang__ is now known as LiangFang | 14:00 | |
| bauzas | either way, we're missing details | 14:01 |
| sean-k-mooney | ya | 14:01 |
| sean-k-mooney | and i was suggsting that we might try to retrive something in the show that we dont in the list | 14:01 |
| sean-k-mooney | list with out details i think mainly operates on the api db | 14:02 |
| sean-k-mooney | anyway its weird | 14:02 |
| sean-k-mooney | oh did we reenable the experiation bot | 14:02 |
| sean-k-mooney | oh i think launchpad might have https://help.launchpad.net/BugExpiry | 14:03 |
| sean-k-mooney | gibi: bauzas did we recently enable bug expiry. im not against it by the way but im wondering if this now enabled by default | 14:05 |
| bauzas | well, we only do it once | 14:05 |
| bauzas | afaict, this isn't a bot | 14:05 |
| sean-k-mooney | its a launchpad feature | 14:06 |
| sean-k-mooney | we used to have an openstack bot do it | 14:06 |
| bauzas | oh, I see | 14:06 |
| bauzas | you're right | 14:06 |
| gibi | I'm not aware of any recent changes so if that is on then it is on for a while | 14:06 |
| sean-k-mooney | its strange i have teh correct permision to change this on os-vif but i dont see the option. looks like its not running for os-vif | 14:07 |
| sean-k-mooney | ah there is an "Expire "Incomplete" bug reports when they become inactive" option in the configure bugs tab | 14:09 |
| sean-k-mooney | its not unde edit details in the project page | 14:09 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/nova stable/ussuri: Allow tap interface with multiqueue https://review.opendev.org/752245 | 14:10 |
| sean-k-mooney | im going to leave that off for now we dont really get many os-vif bug reports | 14:10 |
| *** owalsh has quit IRC | 14:12 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Skip cinder_encryption_key_id check when booting from volume https://review.opendev.org/752090 | 14:15 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug #1895696 https://review.opendev.org/752247 | 14:15 |
| openstack | bug 1895696 in OpenStack Compute (nova) "unable to boot instance from encrypted volume created from a glance image of an encrypted volume" [Medium,In progress] https://launchpad.net/bugs/1895696 - Assigned to Lee Yarwood (lyarwood) | 14:15 |
| lyarwood | stephenfin: ^ I'll review your GlanceFixture stuff shortly if it still needs it as I'm using it in this bugfix | 14:15 |
| stephenfin | lyarwood: sure, if you've time that would be great. I can take a look at that bugfix | 14:16 |
| *** jangutter has joined #openstack-nova | 14:17 | |
| *** jangutter_ has quit IRC | 14:20 | |
| *** LiangFang has quit IRC | 14:25 | |
| *** Liang__ has joined #openstack-nova | 14:27 | |
| *** priteau has joined #openstack-nova | 14:30 | |
| *** LinPeiWen has quit IRC | 14:33 | |
| *** ociuhandu_ has quit IRC | 14:36 | |
| *** ociuhandu has joined #openstack-nova | 14:37 | |
| *** lpetrut has quit IRC | 14:38 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP zuul: Introduce nova-multinode-evacuate https://review.opendev.org/744883 | 14:38 |
| *** martinkennelly has quit IRC | 14:38 | |
| *** k_mouza has quit IRC | 14:55 | |
| *** ociuhandu_ has joined #openstack-nova | 14:57 | |
| *** ociuhandu has quit IRC | 14:58 | |
| *** vishalmanchanda has joined #openstack-nova | 14:58 | |
| *** k_mouza has joined #openstack-nova | 15:01 | |
| *** jangutter_ has joined #openstack-nova | 15:03 | |
| *** jangutter_ has quit IRC | 15:03 | |
| *** Liang__ has quit IRC | 15:04 | |
| *** jangutter_ has joined #openstack-nova | 15:04 | |
| *** gyee has joined #openstack-nova | 15:05 | |
| *** jangutter has quit IRC | 15:06 | |
| *** kukacz has quit IRC | 15:12 | |
| *** kukacz has joined #openstack-nova | 15:14 | |
| gibi | we are under 10 untriaged bugs. I really appreaciate all of your bug triage work! thank you! | 15:15 |
| *** mlavalle has joined #openstack-nova | 15:16 | |
| *** owalsh has joined #openstack-nova | 15:24 | |
| *** links has joined #openstack-nova | 15:28 | |
| *** jraju__ has quit IRC | 15:28 | |
| *** Qianbiao has quit IRC | 15:38 | |
| *** k_mouza has quit IRC | 15:39 | |
| *** k_mouza has joined #openstack-nova | 15:40 | |
| *** psachin has quit IRC | 15:40 | |
| stephenfin | gibi, bauzas, gmann: https://review.opendev.org/752210 is passing now (the base for the os-server-groups 500 -> 400 change) | 15:43 |
| *** hamalq has joined #openstack-nova | 15:45 | |
| bauzas | melwitt: based on your last (and old) comment on https://bugs.launchpad.net/nova/+bug/1775934 could we mark the bug as Confirmed ? this is unclear to me whether we need to fix it | 15:45 |
| openstack | Launchpad bug 1775934 in OpenStack Compute (nova) "Cannot run "openstack server list" with instance stuck in scheduling state" [Undecided,New] | 15:45 |
| gmann | stephenfin +2 | 15:45 |
| gibi | +@ | 15:45 |
| gibi | +2+A | 15:45 |
| gibi | ;d | 15:45 |
| *** slaweq has quit IRC | 15:48 | |
| *** slaweq has joined #openstack-nova | 15:50 | |
| *** mgariepy has quit IRC | 15:51 | |
| *** mgariepy has joined #openstack-nova | 15:51 | |
| melwitt | bauzas: that sounds familiar and I think "probably". I need to look around a bit to find a related/duplicate bug I've seen and add more information | 15:52 |
| bauzas | melwitt: kk, marking it as confirmed for now, but feel free to mark it duplicate if so | 15:52 |
| bauzas | thanks | 15:52 |
| melwitt | sounds good, thanks | 15:52 |
| *** tesseract has quit IRC | 15:56 | |
| *** jangutter has joined #openstack-nova | 15:56 | |
| *** jangutter_ has quit IRC | 15:59 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Make overcommit check for pinned instance pagesize aware https://review.opendev.org/631053 | 16:03 |
| *** tosky has quit IRC | 16:11 | |
| *** jawad_axd has quit IRC | 16:24 | |
| *** ociuhandu has joined #openstack-nova | 16:30 | |
| *** ociuhandu_ has quit IRC | 16:32 | |
| *** ociuhandu has quit IRC | 16:35 | |
| *** jawad_axd has joined #openstack-nova | 16:37 | |
| *** tonyb has quit IRC | 16:41 | |
| *** tonyb has joined #openstack-nova | 16:42 | |
| *** brinzhang0 has joined #openstack-nova | 16:46 | |
| *** k_mouza has quit IRC | 16:48 | |
| *** brinzhang_ has quit IRC | 16:48 | |
| *** kaisers has quit IRC | 16:50 | |
| *** tobberydberg has quit IRC | 16:51 | |
| *** tobberydberg_ has joined #openstack-nova | 16:51 | |
| *** sapd1_x has quit IRC | 16:52 | |
| *** johanssone_ has quit IRC | 16:59 | |
| *** tonyb has quit IRC | 17:01 | |
| *** johanssone has joined #openstack-nova | 17:03 | |
| *** derekh has quit IRC | 17:04 | |
| sean-k-mooney | gibi: bauzas melwitt can i get your input on how backportale someting is quickly | 17:07 |
| sean-k-mooney | basically i want to add a call to unplug_vifs in migrate_disk_and_power_off which is caleed in _resize_instance | 17:08 |
| sean-k-mooney | and ideally remove the call to clean up the souce vifs form resize confirm | 17:09 |
| sean-k-mooney | so when we do resize_instance before we go to resize_verify we would unplug the souce vif | 17:09 |
| openstackgerrit | Merged openstack/nova stable/train: post live migration: don't call Neutron needlessly https://review.opendev.org/750670 | 17:09 |
| sean-k-mooney | basicaly right after we call power off just like we remove the cinder attahcments | 17:10 |
| openstackgerrit | Merged openstack/nova master: docs: Improve 'AggregateImagePropertiesIsolation' docs https://review.opendev.org/752236 | 17:10 |
| openstackgerrit | Merged openstack/nova master: functional: Enable real policy fixture by default https://review.opendev.org/745906 | 17:10 |
| openstackgerrit | Merged openstack/nova master: functional: Add and use 'GlanceFixture' https://review.opendev.org/745907 | 17:10 |
| sean-k-mooney | it would fix bug #1895220 and i also need to do it for https://review.opendev.org/#/c/602432 to adress bug #1734320 | 17:11 |
| openstack | bug 1895220 in OpenStack Compute (nova) "Fail to cold migrate between two hosts have difference VIF type" [Medium,In progress] https://launchpad.net/bugs/1895220 - Assigned to Dat Le (datlq) | 17:11 |
| openstack | bug 1734320 in neutron "Eavesdropping private traffic" [High,In progress] https://launchpad.net/bugs/1734320 - Assigned to Rodolfo Alonso (rodolfo-alonso-hernandez) | 17:11 |
| openstackgerrit | melanie witt proposed openstack/nova stable/train: Sanity check instance mapping during scheduling https://review.opendev.org/752279 | 17:11 |
| *** dtantsur is now known as dtantsur|afk | 17:13 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/train: Sanity check instance mapping during scheduling https://review.opendev.org/752279 | 17:13 |
| *** jawad_axd has quit IRC | 17:15 | |
| sean-k-mooney | lyarwood: elod i guess same question to ye since its about backportablity ^ | 17:16 |
| sean-k-mooney | the current behavior rely on libvirt to unplug the vif so to maintain the correct behavior when we deleate that to os-vif we now need to call unplug_vifs explcitly | 17:17 |
| sean-k-mooney | which we should have been doing along really | 17:18 |
| melwitt | sean-k-mooney: is the unplug_vifs functionality in os-vif available in older branches? | 17:21 |
| sean-k-mooney | yes | 17:22 |
| sean-k-mooney | unplug_vifs is a libvirt driver function | 17:22 |
| sean-k-mooney | but the os-vif support is also there in older branches | 17:22 |
| sean-k-mooney | melwitt: it look like im going to either need to make this change to when we do it | 17:23 |
| sean-k-mooney | e.g. from confirm_resize where it is today to resize_instance | 17:23 |
| sean-k-mooney | or im going to have to alter where and if nova waits for vifs in revert | 17:24 |
| sean-k-mooney | or i guess i could have revert call unplug_vifs before it calls plug_vifs but that is slightly more complicated. | 17:25 |
| sean-k-mooney | melwitt: for the CVE fix we have to do a locksetp backport in neutron and nova. | 17:26 |
| *** ralonsoh has quit IRC | 17:26 | |
| sean-k-mooney | its a publci CVE by the way | 17:26 |
| sean-k-mooney | for the other case of cold migrating/resizign between network backends | 17:26 |
| sean-k-mooney | its technically not something tha was offically supported | 17:27 |
| sean-k-mooney | which i noted in the bug | 17:27 |
| sean-k-mooney | but it works in a limited set of cases | 17:27 |
| melwitt | yeah I guess I'm not immediately seeing a backportability issue (but I could be missing something) but I think we'd want to let bake on master for awhile before backporting everywhere, to catch bugs before it's propagated to more branches | 17:27 |
| sean-k-mooney | e.g. ml2/ovs to ml2/ovn | 17:27 |
| sean-k-mooney | melwitt: there is one edge case im not sure how to adress | 17:27 |
| melwitt | maybe it's just me but the fix sounds complicated and something we'd want to see if problems appear once it's running throughout the gate | 17:28 |
| sean-k-mooney | well the first fix is just one addtion fucntion all in resize_instance to unplug_vifs | 17:29 |
| melwitt | is that consistent with what we do with volumes today too? | 17:29 |
| sean-k-mooney | bit that makes it trickin is to fully solve the diffent backend case i need to remove the current call in confirm | 17:29 |
| sean-k-mooney | melwitt: ya for volumes we remove attacments in resize_instance | 17:29 |
| melwitt | ok. it seems like it would make sense to have them be consistent but I don't know the reason vifs are handled differently | 17:30 |
| sean-k-mooney | well technically in migrate_disk_and_poweroff | 17:30 |
| sean-k-mooney | https://github.com/openstack/nova/blob/e0f088c95d05e9cf32d4af4c7cfc20566b17f8e1/nova/virt/libvirt/driver.py#L10362 | 17:30 |
| melwitt | yeah, I did see the volume detach there | 17:31 |
| sean-k-mooney | and im suggesting adding self.unplug_vifs here https://github.com/openstack/nova/blob/e0f088c95d05e9cf32d4af4c7cfc20566b17f8e1/nova/virt/libvirt/driver.py#L10357 | 17:31 |
| sean-k-mooney | basicly 5 lines up | 17:31 |
| melwitt | yeah, seems to make sense to me | 17:32 |
| sean-k-mooney | melwitt: basically power_off call _destory() not destroy() to delete the domain xml without remving the disk images | 17:32 |
| sean-k-mooney | so we can revert without copying data | 17:32 |
| sean-k-mooney | but _destory() does not call unplug_vifs | 17:33 |
| sean-k-mooney | destroy() does via the call to cleanup() | 17:33 |
| sean-k-mooney | which delete the disk too | 17:33 |
| melwitt | right | 17:33 |
| sean-k-mooney | and today conrim does an rpc from the dest to the source to call unplug_vifs | 17:34 |
| sean-k-mooney | here in cleanup_resize https://github.com/openstack/nova/blob/e0f088c95d05e9cf32d4af4c7cfc20566b17f8e1/nova/virt/libvirt/driver.py#L1665 | 17:34 |
| melwitt | yeah I guess I wonder what are the potential issues if the deployment is in the middle of an upgrade | 17:35 |
| sean-k-mooney | for revert we call plug_vifs in create_instace_with_networks here https://github.com/openstack/nova/blob/e0f088c95d05e9cf32d4af4c7cfc20566b17f8e1/nova/virt/libvirt/driver.py#L6704 https://github.com/openstack/nova/blob/e0f088c95d05e9cf32d4af4c7cfc20566b17f8e1/nova/virt/libvirt/driver.py#L10681-L10683 | 17:35 |
| openstackgerrit | Lee Yarwood proposed openstack/nova-specs master: WIP/DNM - Flavor and image defined ephemeral storage encryption https://review.opendev.org/752284 | 17:36 |
| sean-k-mooney | melwitt: right so if i dont remove the unplug_vifs form the cleanup in confim | 17:36 |
| sean-k-mooney | i think its ok if i do | 17:36 |
| lyarwood | sean-k-mooney: sorry just pushing something and I need to drop again, can we catch up about that backport stuff in the morning? | 17:36 |
| lyarwood | s/morning/your\ morning/g ;) | 17:36 |
| sean-k-mooney | then if i have an old souce and a new dest then i think we dont clean up the vifs | 17:36 |
| sean-k-mooney | lyarwood: ya we can no rush | 17:37 |
| sean-k-mooney | melwitt: im not sure how to handel that other then leave the extra call to unplug_vifs in the backport | 17:37 |
| sean-k-mooney | melwitt: unplug_vifs shoudl be callable twice without any ill effects | 17:37 |
| melwitt | yeah, well wouldn't you have to leave it on master (not only backports) for one cycle? to bridge the N-1 to N upgrade? | 17:38 |
| sean-k-mooney | melwitt: well the proablem is i need to backport the cve issue to like queens eventually | 17:39 |
| sean-k-mooney | what i think i would have to do is keep the call to unplug_vifs in cleanup but wrap it in a try excetp | 17:39 |
| melwitt | I'm just saying re: leaving the extra call, I think you'd have to leave it on master too, not only leave it on the backports. because the upgrade issue exists for master as well | 17:39 |
| sean-k-mooney | oh right | 17:40 |
| sean-k-mooney | i woudl have to leave it on master for a cycle ya | 17:40 |
| sean-k-mooney | ill put the patches up for peopel to see as 3 patches | 17:40 |
| sean-k-mooney | 1 for the new call in resize. one for the cve fix which is alredy up for review and one for the extra call removal | 17:41 |
| sean-k-mooney | and we can defer that last one for a cycle | 17:41 |
| sean-k-mooney | and i guess we can see if peopel think of any other reason not to do it this way. | 17:42 |
| melwitt | yeah, so AFAICT the backport concern here would be the complexity and impact to something that is supposed to be "stable" but it's needed for a CVE so I think that makes it backportable (again unless I'm missing something) | 17:42 |
| sean-k-mooney | ya if we think its backportable and we are happy with it on master i guess i dont have to rush the backport either | 17:43 |
| sean-k-mooney | e.g. we coudl wait a while and let it back | 17:43 |
| sean-k-mooney | *bake | 17:43 |
| melwitt | yeah I'm just concerned about there being a bug or edge case that crops up in the gate and then we have a fix to backport 5 times too | 17:44 |
| melwitt | not the end of the world, we did it recently :P but the goal is to avoid that | 17:44 |
| sean-k-mooney | :) ya im ok with that | 17:45 |
| sean-k-mooney | this partcalar issue has been dragin on since 2018 or longer | 17:45 |
| melwitt | let's see what other ppl think. I worry I'm missing something unbackportable about it | 17:45 |
| sean-k-mooney | 2017-11-24 | 17:45 |
| melwitt | yeah, I think that might be the same neutron security bug I emailed about downstream a long time ago | 17:46 |
| sean-k-mooney | i started working on this when i was still at intel | 17:46 |
| sean-k-mooney | we have fixed in in a number of edgecases | 17:46 |
| sean-k-mooney | but there is still 1 that is unfixed | 17:46 |
| sean-k-mooney | just trying to get the fine case closed | 17:46 |
| *** links has quit IRC | 17:47 | |
| melwitt | understood | 17:47 |
| sean-k-mooney | https://review.opendev.org/#/c/602432/ fixes the final case but its failing or reverts because of the change in unplug behaivor wehn we get rid of the libvirt race | 17:47 |
| *** mriedem has joined #openstack-nova | 17:54 | |
| *** ralonsoh has joined #openstack-nova | 17:58 | |
| sean-k-mooney | melwitt: oh one related question do we think this could be an RC1 candiate so that we could count victoria as the first release or would wallaby have to be the first release with X for the removal of the second call | 17:59 |
| sean-k-mooney | i guess we can cross that bridge wehn we come to it | 17:59 |
| sean-k-mooney | but im not really sure given how latent both issue are that it qualifies for RC1 | 17:59 |
| sean-k-mooney | i would like it to but i would like many things to be true that are not :) | 18:00 |
| *** jawad_axd has joined #openstack-nova | 18:00 | |
| melwitt | sean-k-mooney: yeah I think it'd be a hard sell for RC1 because of how latent | 18:00 |
| sean-k-mooney | ya ok. when i leave the todo commont for remoinv it ill say after wallaby | 18:01 |
| melwitt | but you could bring it up at the nova meeting tomorrow to get more input | 18:01 |
| sean-k-mooney | ya. i asked the peroson that reported the other bug if they were ok with me updating there patch to just do the method move if so i should have a patch up before then if not ill submit a sperate patch for that i guess | 18:02 |
| sean-k-mooney | in either case i can add it to the open disucssion secation at the end | 18:02 |
| melwitt | but eh... looking at the release schedule RC1 is Sep 24, not sure we could get proper review done by then | 18:03 |
| sean-k-mooney | ya its rather tight | 18:03 |
| sean-k-mooney | ill just assume this will have to be backported to stable/victoria | 18:03 |
| sean-k-mooney | its fine | 18:03 |
| melwitt | yeah, realistically I think that will be the case | 18:04 |
| sean-k-mooney | ya no worries. | 18:04 |
| sean-k-mooney | ill leave it of the agenda so and just ask lee and other for review once the patches are ready | 18:05 |
| sean-k-mooney | i havent looked at the rc-potential bugs list yet | 18:05 |
| sean-k-mooney | do we have any/many | 18:06 |
| sean-k-mooney | oh just one https://bugs.launchpad.net/nova/+bugs?field.tag=victoria-rc-potential | 18:07 |
| sean-k-mooney | https://bugs.launchpad.net/nova/+bug/1882521 | 18:07 |
| openstack | Launchpad bug 1882521 in OpenStack Compute (nova) "Failing device detachments on Focal" [High,Confirmed] - Assigned to Lee Yarwood (lyarwood) | 18:07 |
| sean-k-mooney | and lee has raised a qemu bug for that https://bugs.launchpad.net/qemu/+bug/1894804 | 18:08 |
| openstack | Launchpad bug 1894804 in QEMU "Second DEVICE_DELETED event missing during virtio-blk disk device detach" [Undecided,New] | 18:08 |
| sean-k-mooney | so i guess that is not really an rc blocker | 18:08 |
| *** dklyle has joined #openstack-nova | 18:09 | |
| sean-k-mooney | and danpb basically conrimed it as a qemu bug in https://bugs.launchpad.net/qemu/+bug/1894804/comments/3 | 18:10 |
| openstack | Launchpad bug 1894804 in QEMU "Second DEVICE_DELETED event missing during virtio-blk disk device detach" [Undecided,New] | 18:10 |
| melwitt | yeah AFAICT there isn't anything we can do to workaround that either | 18:10 |
| sean-k-mooney | we might be able to mitigate it by using virtio-scsi instead of virtio-block | 18:11 |
| sean-k-mooney | but ya not really | 18:11 |
| sean-k-mooney | other then skip it in tempest for now | 18:11 |
| *** jawad_axd has quit IRC | 18:15 | |
| *** vishalmanchanda has quit IRC | 18:28 | |
| *** nightmare_unreal has quit IRC | 18:51 | |
| *** tosky has joined #openstack-nova | 18:51 | |
| openstackgerrit | Merged openstack/nova master: tests: Add regression test for bug 1894966 https://review.opendev.org/752210 | 19:07 |
| openstack | bug 1894966 in OpenStack Compute (nova) "Create servergroup failed with unexpected error" [Low,In progress] https://launchpad.net/bugs/1894966 - Assigned to Stephen Finucane (stephenfinucane) | 19:07 |
| *** priteau has quit IRC | 19:12 | |
| *** jawad_axd has joined #openstack-nova | 19:19 | |
| openstackgerrit | Merged openstack/os-vif master: Update master for stable/victoria https://review.opendev.org/750926 | 19:20 |
| *** ralonsoh has quit IRC | 19:20 | |
| *** ralonsoh has joined #openstack-nova | 19:21 | |
| *** manuvakery has quit IRC | 19:26 | |
| *** ralonsoh has quit IRC | 19:28 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug #1895696 https://review.opendev.org/752247 | 19:33 |
| openstack | bug 1895696 in OpenStack Compute (nova) "unable to boot instance from encrypted volume created from a glance image of an encrypted volume" [Medium,In progress] https://launchpad.net/bugs/1895696 - Assigned to Lee Yarwood (lyarwood) | 19:33 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Skip cinder_encryption_key_id check when booting from volume https://review.opendev.org/752090 | 19:33 |
| openstackgerrit | Merged openstack/python-novaclient master: Remove install unnecessary packages https://review.opendev.org/751637 | 19:44 |
| *** kukacz has quit IRC | 19:52 | |
| *** jawad_axd has quit IRC | 20:06 | |
| *** owalsh has quit IRC | 20:11 | |
| *** nweinber has quit IRC | 20:32 | |
| openstackgerrit | Merged openstack/os-vif master: Add Python3 wallaby unit tests https://review.opendev.org/750927 | 20:39 |
| *** owalsh has joined #openstack-nova | 20:43 | |
| *** xek has quit IRC | 20:49 | |
| *** sapd1 has quit IRC | 20:52 | |
| *** sapd1_x has joined #openstack-nova | 20:52 | |
| *** owalsh has quit IRC | 20:56 | |
| *** zzzeek has quit IRC | 21:05 | |
| *** zzzeek has joined #openstack-nova | 21:07 | |
| *** slaweq has quit IRC | 21:14 | |
| *** slaweq has joined #openstack-nova | 21:15 | |
| *** owalsh has joined #openstack-nova | 21:18 | |
| *** zzzeek has quit IRC | 21:22 | |
| *** zzzeek has joined #openstack-nova | 21:25 | |
| *** slaweq has quit IRC | 21:27 | |
| *** rcernin has joined #openstack-nova | 21:31 | |
| *** slaweq has joined #openstack-nova | 21:33 | |
| *** rcernin has quit IRC | 21:36 | |
| openstackgerrit | Merged openstack/nova master: Fix error that cannot overwrite policy rule for 'forced_host' https://review.opendev.org/751152 | 21:49 |
| *** slaweq has quit IRC | 21:54 | |
| *** tosky_ has joined #openstack-nova | 21:56 | |
| *** tosky has quit IRC | 21:59 | |
| *** tosky_ is now known as tosky | 22:00 | |
| *** slaweq has joined #openstack-nova | 22:01 | |
| *** rcernin has joined #openstack-nova | 22:09 | |
| *** slaweq_ has joined #openstack-nova | 22:10 | |
| *** slaweq has quit IRC | 22:13 | |
| *** rcernin has quit IRC | 22:18 | |
| *** slaweq_ has quit IRC | 22:19 | |
| *** JamesBenson has quit IRC | 22:29 | |
| *** rcernin has joined #openstack-nova | 22:32 | |
| *** rcernin has quit IRC | 22:33 | |
| *** rcernin has joined #openstack-nova | 22:33 | |
| *** zzzeek has quit IRC | 22:38 | |
| *** zzzeek has joined #openstack-nova | 22:40 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Removed the host FQDN from the exception message https://review.opendev.org/749612 | 22:43 |
| *** zzzeek has quit IRC | 22:58 | |
| *** tosky has quit IRC | 22:59 | |
| *** zzzeek has joined #openstack-nova | 23:00 | |
| *** mriedem has left #openstack-nova | 23:10 | |
| *** zzzeek has quit IRC | 23:17 | |
| *** suryasingh has quit IRC | 23:18 | |
| *** zzzeek has joined #openstack-nova | 23:19 | |
| *** zzzeek has quit IRC | 23:43 | |
| *** zzzeek has joined #openstack-nova | 23:44 | |
| *** zzzeek has quit IRC | 23:49 | |
| *** hamalq has quit IRC | 23:50 | |
| brinzhang0 | gibi, gmann, stephenfin: change 500-->400 is ok for me too ^^ thanks | 23:50 |
| *** zzzeek has joined #openstack-nova | 23:52 | |
| *** zzzeek has quit IRC | 23:57 | |
| *** zzzeek has joined #openstack-nova | 23:58 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!