Thursday, 2020-05-14

*** brinzhang has joined #openstack-nova00:00
*** artom has quit IRC00:02
*** artom has joined #openstack-nova00:02
*** mlavalle has quit IRC00:04
*** artom has quit IRC00:13
*** Liang__ has quit IRC00:15
*** hongbin has quit IRC00:15
*** tetsuro has joined #openstack-nova00:22
*** hongbin has joined #openstack-nova00:28
openstackgerritWenping Song proposed openstack/nova master: delete sub resource provider when delete resource provider  https://review.opendev.org/71916300:46
openstackgerritmelanie witt proposed openstack/nova master: Configure latex_engine = 'xelatex' for pdf docs build  https://review.opendev.org/72789800:49
openstackgerritmelanie witt proposed openstack/nova master: Configure latex_engine = 'xelatex' for pdf docs build  https://review.opendev.org/72789801:07
*** ttsiouts has quit IRC01:15
*** jamesdenton has joined #openstack-nova01:17
*** jamesdenton has quit IRC01:22
*** jamesdenton has joined #openstack-nova01:24
openstackgerritMerged openstack/nova-specs master: Re-propose provider-config-file spec for Victoria  https://review.opendev.org/72578801:32
*** brinzhang_ has joined #openstack-nova01:35
openstackgerritMerged openstack/nova-specs master: Re-proposes 'Proposal for a safer remote console with password authentication'  https://review.opendev.org/71972001:36
*** brinzhang has quit IRC01:38
*** awalende has joined #openstack-nova01:39
*** awalende has quit IRC01:44
*** ttsiouts has joined #openstack-nova01:53
*** ttsiouts has quit IRC01:58
*** amodi has joined #openstack-nova02:11
*** sapd1 has quit IRC02:20
*** hongbin_ has joined #openstack-nova02:25
*** hongbin has quit IRC02:28
*** gyee has quit IRC02:38
*** sapd__x has joined #openstack-nova02:38
*** xiaolin has joined #openstack-nova02:46
tony_sugibi, sean-k-mooney : Thanks for reviewing and merging the spec.02:48
tony_sugibi, sean-k-mooney : I will start to rebase related patches and send out for code review once they are ready.02:50
*** tetsuro has quit IRC03:02
melwittfyi the openstack-tox-docs job is failing for nova since a recent upper-constraints bump, I have proposed a fix here https://review.opendev.org/727898 I have also sent a ML post03:03
*** ttsiouts has joined #openstack-nova03:15
*** ttsiouts has quit IRC03:19
*** psachin has joined #openstack-nova03:23
*** hongbin_ has quit IRC03:29
*** tetsuro has joined #openstack-nova03:36
*** yedongcan has joined #openstack-nova03:37
*** tetsuro has quit IRC03:44
*** ociuhandu has joined #openstack-nova03:50
*** ratailor has joined #openstack-nova03:50
*** tetsuro has joined #openstack-nova03:51
*** tetsuro has quit IRC03:52
*** ociuhandu has quit IRC03:55
*** tetsuro has joined #openstack-nova04:02
*** evrardjp has quit IRC04:36
*** evrardjp has joined #openstack-nova04:36
*** vishalmanchanda has joined #openstack-nova04:48
*** KeithMnemonic has quit IRC05:14
*** ttsiouts has joined #openstack-nova05:21
*** udesale has joined #openstack-nova05:30
*** links has joined #openstack-nova05:36
*** ttsiouts has quit IRC05:55
openstackgerritmelanie witt proposed openstack/nova master: Configure latex_engine = 'xelatex' for pdf docs build  https://review.opendev.org/72789805:56
*** jsuchome has joined #openstack-nova06:02
*** yedongcan has left #openstack-nova06:04
*** dpawlik has joined #openstack-nova06:06
*** CeeMac has joined #openstack-nova06:16
*** ociuhandu has joined #openstack-nova06:34
*** xek_ has joined #openstack-nova06:37
*** xek has quit IRC06:40
*** ociuhandu has quit IRC06:50
*** ralonsoh has joined #openstack-nova06:55
*** ttsiouts has joined #openstack-nova07:05
*** maciejjozefczyk has joined #openstack-nova07:06
*** slaweq has joined #openstack-nova07:08
openstackgerritNalini Varshney proposed openstack/nova master: Add migration to make key field type VARBINARY in aggregate_metadata table,  https://review.opendev.org/72552207:10
*** sapd1 has joined #openstack-nova07:11
*** tesseract has joined #openstack-nova07:12
*** damien_r has joined #openstack-nova07:14
*** ttsiouts has quit IRC07:16
*** ttsiouts has joined #openstack-nova07:16
*** ociuhandu has joined #openstack-nova07:17
*** damien_r has quit IRC07:19
*** awalende has joined #openstack-nova07:22
*** tosky has joined #openstack-nova07:31
*** dtantsur|afk is now known as dtantsur07:32
*** rpittau|afk is now known as rpittau07:33
brinzhang_sean-k-mooney: https://review.opendev.org/#/c/727589/2 do I need to update this patch? I have not concern stephenfin has already fixed these issue, but he abandoned.07:35
gibigood morning Nova07:49
bauzaswhoops my manners07:49
bauzasgood morning Nova07:49
brinzhang_morning nova07:50
brinzhang_hi gibi, bauzas, I saw you are -1 for https://review.opendev.org/#/c/727140/1, the flake8 error fix patch07:50
gibibrinzhang_: my -1 is about the fact that 3.8.1 added yet another check that needs to be fixed07:51
brinzhang_I submit a same one, before that I have not concern stephenfin's patch, do I need to continue ?07:51
brinzhang_gibi: I will see http://paste.openstack.org/show/793434/07:52
bauzasbrinzhang_: my concerns was about making sure what we would need to change07:52
gibiI guess stephenfin abandoned the patch as we went a different direction, capping the version07:52
brinzhang_yeah07:53
brinzhang_I mean, if there is no sense to fix, I think I would abandon too.07:53
*** ccamacho has joined #openstack-nova07:55
brinzhang_https://review.opendev.org/#/c/727347/ gmann bumped hacking to 3.0.1, I am not sure whether this can avoid these pep8 error happen again07:56
brinzhang_gibi: stephenfin and I fixed the issue is reported by https://review.opendev.org/#/c/724260/6, and https://review.opendev.org/#/c/726564/2.07:58
brinzhang_I found your paste is not easy to fix, may need to change the function name, such as "./nova/tests/unit/api/openstack/compute/microversions.py:34:5: F811 redefinition of unused 'index' from line 29"07:59
brinzhang_:P07:59
*** ociuhandu has quit IRC08:00
*** ociuhandu has joined #openstack-nova08:00
gibibrinzhang_: those redefinitions are intentional and not cause a python bug due to the decorator top of it will generate unique functions dynamically. So I think F811 needs to be ignored in tox.ini08:02
gibiI think it is OK to fix the issues reported by the other new checks along with version bump08:03
gibibut please consult stephenfin too08:03
brinzhang_gibi: agree08:03
brinzhang_gibi: yeah, I will try to update the patch to latest, and then consult08:04
gibiOK, cool08:05
*** martinkennelly has joined #openstack-nova08:15
*** xek__ has joined #openstack-nova08:19
*** ccamacho has quit IRC08:20
openstackgerritBrin Zhang proposed openstack/nova master: Fix flake8 error from hacking <3.0.1  https://review.opendev.org/72758908:20
*** xek_ has quit IRC08:22
*** ccamacho has joined #openstack-nova08:34
*** dpawlik has quit IRC08:40
*** dpawlik has joined #openstack-nova08:45
bauzasbrinzhang_: gibi: FWIW, +Wd https://review.opendev.org/#/c/727347/108:45
bauzasbrinzhang_: but then I don't understand why we should merge https://review.opendev.org/#/c/727589/08:45
gibibauzas: thanks08:46
bauzasgibi: any change I should be reviewing ?08:50
gibibauzas: not from me at the moment. I still busy with https://bugs.launchpad.net/nova/+bug/187802408:51
openstackLaunchpad bug 1878024 in OpenStack Compute (nova) "disk usage of the nova image cache is not counted as used disk space" [Undecided,Confirmed] - Assigned to Balazs Gibizer (balazs-gibizer)08:51
bauzasgibi: okay, just saying, you have https://review.opendev.org/#/q/topic:bug/1869050+(status:open+OR+status:merged)08:51
bauzasshould I look at it ?08:51
gibibauzas: yes please. I already forgot about that08:52
bauzasheh, no worries08:52
brinzhang_bauzas: https://review.opendev.org/#/c/727589/ this patch just only fixed some unreasonable issue, IMO, if we don’t fix it, we don’t know when it will *explode*09:00
brinzhang_after all, it has reported in https://review.opendev.org/#/c/724260/6, and https://review.opendev.org/#/c/726564/2.09:01
bauzasbrinzhang_: that's the exact reason why we have minimum versions09:11
bauzasonce we bump the minimum, we no longer need to care about what was bad for older versions09:11
brinzhang_bauzas: I know you mean, but these code realy not have a good code style, right?09:12
brinzhang_I can say with certainty that merged this change will only make Nova's code more readable.09:13
bauzasthen that's not a bugfix09:14
brinzhang_especially https://review.opendev.org/#/c/727589/3/nova/tests/unit/compute/test_compute_mgr.py this patch09:14
brinzhang_s/patch/file/09:14
bauzasand just a bikeshed09:14
brinzhang_if there is no this blank line, it..09:15
brinzhang_Yes, this bug was submitted before https://review.opendev.org/#/c/727347/109:16
brinzhang_because it caused pep8 error in https://review.opendev.org/#/c/724260/6, and https://review.opendev.org/#/c/726564/2.09:16
brinzhang_that time I think it is a bug, that why report09:17
sean-k-mooneybauzas: we will eventually have to fix the pep8 issues by the way when we update hacking09:19
sean-k-mooneyand therefor get the newer flake809:19
bauzasagain, we have minimum versions FTW09:20
sean-k-mooneyyep wont help09:20
bauzasthe point is, if we want to support new flake8 version, then yes indeed we need to verify this works09:20
sean-k-mooneythe new min version of hacking is so we get a version that caps flake8 and we have capped the hacking version09:20
bauzasand then updating what we need09:20
sean-k-mooneyso when we update the hacking version we will get a new flake8 and have to fix the issue then09:21
bauzasbut that's another concern09:21
bauzascorrect, that's another change09:21
bauzasanyway, /me needs to get my kid from the school since it opened again today :(09:21
* bauzas says bye to his productivity09:21
bauzas(until next kids vacations)09:22
sean-k-mooneyi would have assumed your productivig increased with them going back to school09:22
sean-k-mooneyso in net it should still be better09:22
sean-k-mooneyeven if its about to go down now that you are going to pick them up09:23
brinzhang_Agree, a good foundation can make a difference.09:25
*** ttsiouts has quit IRC09:27
bauzassean-k-mooney: hell, unfortunately no09:42
bauzassean-k-mooney: I was working between 9am-1pm and then 2pm-7.30pm09:42
bauzaseven with the kids09:42
bauzasthey were asking me for teaching only for 1 hour09:43
bauzasnow, it's 9am-11.30am and then 1.30pm-4.30pm09:43
bauzas:(09:43
openstackgerritsean mooney proposed openstack/nova master: cyborg evacuate support  https://review.opendev.org/71532609:53
*** ttsiouts has joined #openstack-nova09:54
sean-k-mooneygibi: brinzhang_ filed https://blueprints.launchpad.net/nova/+spec/cyborg-rebuild-and-evacuate09:55
sean-k-mooneyill add it to the meeting adgenda but im hoping we are all fine with proceeding with that as a specless blueprint since i have already implemented it09:56
gibisean-k-mooney: thanks09:57
sean-k-mooneybauzas: im going to update the numa in placmenet spec for the victoria templeate and resubmit it now. that ok with you?09:58
brinzhang_sean-k-mooney: got it, thanks, I will register suspend/resume and shelve/unshelve as the same rebuild/evacuate09:59
brinzhang_sean-k-mooney, gibi: and there is also another blueprint need to be done, https://blueprints.launchpad.net/nova/+spec/define-cyborg-arq-binding-notification-event10:00
gibistephenfin: do you mean merging https://review.opendev.org/#/c/727898/ is not needed if we merging https://review.opendev.org/#/c/727898/ and doing a version bump?10:01
brinzhang_I write poc code, but there is not time to add UT, when I have free time, I will summit a WIP patch for this10:01
gibistephenfin: I mean merging your patch https://review.opendev.org/#/c/727992/10:01
gibibrinzhang_: could you write one sentence in that bp about what you need implemented?10:03
brinzhang_gibi: ok10:04
gibithanks10:04
*** jraju__ has joined #openstack-nova10:05
*** links has quit IRC10:05
stephenfingibi: Yeah, exactly10:07
gibistephenfin: if we can merge that quickly then I'm OK to wait for the better solution10:08
openstackgerritsean mooney proposed openstack/nova-specs master: re-propose numa with placement  https://review.opendev.org/72800910:09
brinzhang_gibi: I modified https://blueprints.launchpad.net/nova/+spec/define-cyborg-arq-binding-notification-event description in simple, is it ok?10:09
gibibrinzhang_: what you have to add regarding "accelerators binding notifications." ?10:11
gibiwhat you have to add to nova10:11
sean-k-mooneygmann: when you have time could you weigh in on https://review.opendev.org/#/c/702394/ i think it likely should have a specless blueprint or a spec since its technicall changing api behavior by cause the event api to force refresh the netwrok info cache. that is an internal detail however so im not sure it should have  a micro version bump as form a normal user perspecitive that should not be visable10:12
sean-k-mooneybut it would be good to get your input.10:12
brinzhang_gibi: updated, I think it's the clear I can write in10:16
brinzhang_stephenfin: what do you think of https://review.opendev.org/#/c/727589/ ?10:16
brinzhang_I saw you were abandoned https://review.opendev.org/#/c/727140/, would you like to continue that patch?10:17
*** rpittau is now known as rpittau|bbl10:18
openstackgerritLee Yarwood proposed openstack/nova master: compute: Allow snapshots to be created from PAUSED volume backed instances  https://review.opendev.org/72801110:18
openstackgerritLee Yarwood proposed openstack/nova master: compute: Remove snapshot quiesce tests for STOPPED and SUSPENDED instances  https://review.opendev.org/72801210:18
lyarwood^ simple fix if anyone has time10:18
stephenfinbrinzhang_: hacking 3.1.0 will bump the version of flake8 supported so it would probably make more sense to wait for that to be released10:18
stephenfinbrinzhang_: I'm okay for you to take over that work10:20
brinzhang_yeah, I know, I mean do we need to correct these code style, after we bump hacking>=3.0.110:20
gibibrinzhang_: I'm still confused. Nova does not have versioned notification for neutron port binding during nova server create. So I don't see why nova would emit versioned notifications for ARQ binding10:21
brinzhang_stephenfin: thanks, I want to say when I submit this patch, I have not check your patch10:21
brinzhang_gibi: this Blueprint comes from https://bugs.launchpad.net/nova/+bug/1865549, when I saw this bug, I just only think define-cyborg-arq-binding-notification-event is what I should do, or I missed something?10:23
openstackLaunchpad bug 1865549 in OpenStack Compute (nova) " Define Cyborg ARQ binding notification event." [Wishlist,Confirmed] - Assigned to Brin Zhang (zhangbailin)10:23
brinzhang_OTW, this is an invalid bug?10:23
gibibrinzhang_: this is a doc bug10:23
stephenfinbrinzhang_: all good :)10:24
gibigenerated automatically due to DocImpact in the commit message10:24
gibiso the question is what doc needs to be updated due to https://review.opendev.org/69270710:24
brinzhang_gibi: that should do DocImpact: Adds new version to doc/api_samples/versions/. ?10:26
gibias far as I see that patch itself added such doc change10:27
brinzhang_stephenfin: thanks ^10:27
brinzhang_gibi:I am sorry, I am confusing..10:27
gibiso I think that bug is Invalid we don't need to change anything due to taht10:28
brinzhang_yeah, I think so.10:28
gibibauzas: do you agree that bug https://bugs.launchpad.net/nova/+bug/1865549 is invalid? ^^10:28
openstackLaunchpad bug 1865549 in OpenStack Compute (nova) " Define Cyborg ARQ binding notification event." [Wishlist,Confirmed] - Assigned to Brin Zhang (zhangbailin)10:28
brinzhang_thanks gibi.10:28
*** tetsuro has quit IRC10:29
*** avolkov has joined #openstack-nova10:37
brinzhang_stephenfin: your comment hacking version is 3.1.0, you mean 3.0.1, right?10:38
stephenfinno, 3.1.0, which isn't released yet (I've proposed the release though)10:39
brinzhang_stephenfin: I saw gmann submit 3.0.1 to many project, if the 3.1.0 released, that has need to be changed again?10:40
brinzhang_I will update your comments after 3.1.0 released ^10:41
stephenfinyes and no. The 3.0.1 bump is necessary to ensure the correct version flake8 is installed. The 3.1.0 bump should be done but it wouldn't be as urgent10:41
*** derekh has joined #openstack-nova10:43
brinzhang_ok, thank for your explain10:43
*** ttsiouts has quit IRC10:56
openstackgerritHarshavardhan Metla proposed openstack/nova master: [Nova] Add reference to Placement installation guide  https://review.opendev.org/72693610:56
openstackgerritBrin Zhang proposed openstack/nova master: DNM: Add ARQs binding notification  https://review.opendev.org/72802710:57
*** ttsiouts has joined #openstack-nova11:10
*** ociuhandu has quit IRC11:11
*** ociuhandu has joined #openstack-nova11:11
*** ociuhandu has quit IRC11:15
*** ociuhandu has joined #openstack-nova11:17
*** lpetrut has joined #openstack-nova11:25
*** ociuhandu has quit IRC11:26
*** ociuhandu has joined #openstack-nova11:27
*** ociuhandu has quit IRC11:27
*** ociuhandu has joined #openstack-nova11:27
*** happyhemant has joined #openstack-nova11:33
*** nweinber has joined #openstack-nova11:33
openstackgerritsean mooney proposed openstack/os-vif master: update tox envs and support pdf docs  https://review.opendev.org/72803711:36
sean-k-mooneystephenfin: by the way wasnt pdf docs a goal at some point.11:37
*** ociuhandu has quit IRC11:38
*** ociuhandu has joined #openstack-nova11:40
*** JamesBenson has joined #openstack-nova11:41
*** dklyle has quit IRC11:43
*** udesale has quit IRC11:44
openstackgerritLee Yarwood proposed openstack/nova master: Add functional test for bug 1550919  https://review.opendev.org/63129411:45
openstackbug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Lee Yarwood (lyarwood)11:45
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Don't delete disks on shared storage during evacuate  https://review.opendev.org/57884611:45
*** ociuhandu has quit IRC11:49
*** lseki has quit IRC11:51
*** mriedem has joined #openstack-nova11:55
jsuchomelyarwood: Hi. Shouldn't https://review.opendev.org/#/c/727225/ be rebuilt automatically when I pushed new changes to the depends-on patch?11:57
*** udesale has joined #openstack-nova11:58
sean-k-mooneyjsuchome: no12:00
sean-k-mooneyyou have to manually recheck12:00
sean-k-mooneyjsuchome: just leave a "recheck" comment on https://review.opendev.org/#/c/727225/ and it will run again12:01
*** tkajinam has quit IRC12:01
*** udesale_ has joined #openstack-nova12:04
*** raildo has joined #openstack-nova12:06
openstackgerritsean mooney proposed openstack/nova stable/ussuri: Silence amqp heartbeat warning  https://review.opendev.org/72805412:06
* bauzas is on full steam for only 1.30 hours12:07
* bauzas loves his life12:07
bauzassean-k-mooney: sure, either you or me can repropose the spec, but let's do it12:08
bauzasif you want12:08
sean-k-mooneybauzas: i did it while you were away12:08
bauzasgibi: looking12:08
sean-k-mooneyhttps://review.opendev.org/#/c/728009/12:08
bauzassean-k-mooney: ack, clicking12:08
bauzasgibi: I triaged it as wishlist12:10
bauzasgibi: it's a doc thingies, right?12:10
bauzashttps://bugs.launchpad.net/nova/+bug/186554912:10
openstackLaunchpad bug 1865549 in OpenStack Compute (nova) " Define Cyborg ARQ binding notification event." [Wishlist,Confirmed] - Assigned to Brin Zhang (zhangbailin)12:10
gibibauzas: it seems to me that that the original patch added DocImpact tag in the commit message, and that triggered the bug creation automaticaly. But as far as I see the original patch did the documentation12:11
bauzasgibi: oh my bad then, I haven't looked at the doc12:11
openstackgerritsean mooney proposed openstack/nova stable/ussuri: remove support of oslo.messaging 9.8.0 warning message  https://review.opendev.org/72805512:11
bauzasgibi: feel free to close it then12:11
gibibauzas: thanks. closing it12:12
openstackgerritsean mooney proposed openstack/nova stable/ussuri: remove support of oslo.messaging 9.8.0 warning message  https://review.opendev.org/72805512:13
*** rpittau|bbl is now known as rpittau12:15
jsuchomesean-k-mooney: ok thanks (still don't know why it is failing, let's see if it behaves differently with new patch)12:15
openstackgerritsean mooney proposed openstack/nova stable/train: Silence amqp heartbeat warning  https://review.opendev.org/72805712:18
openstackgerritsean mooney proposed openstack/nova stable/train: remove support of oslo.messaging 9.8.0 warning message  https://review.opendev.org/72805812:18
openstackgerritsean mooney proposed openstack/nova stable/stein: Silence amqp heartbeat warning  https://review.opendev.org/72805912:20
sean-k-mooneyjsuchome: test_volume_crud_with_volume_type_and_extra_specs is what failed but that seams unrelated to your change12:21
lyarwoodjsuchome / sean-k-mooney ; yeah that was unrelated but I didn't see any DEBUG lines from your change in n-cpu FWIW12:24
lyarwoodjsuchome: I'll play around with things on a local env after a call12:24
openstackgerritIvaylo Mitev proposed openstack/nova master: Faults from cell DB missing in GET /servers/detail  https://review.opendev.org/69917612:26
jsuchomelyarwood: yeah, i did not seem them either ... it actually should be INFO line ("Successfully transferred using")...12:27
jsuchomeI would also be surprised if that volume test were related...12:27
bauzassean-k-mooney: fwiw, changed the topic name of https://review.opendev.org/#/c/728009/ since there was a typo12:28
bauzas(just in case you need to update the change)12:28
sean-k-mooneyno worries i use git review to download my patches before i update them12:28
sean-k-mooneyi ussuall keep the local patch too but it should preserve the topic12:29
sean-k-mooneybauzas: i have a few small bugfixes im planning to rebase but ill proably start creating a poc of the numa change on monday or tuesday12:31
sean-k-mooneyas much as i want to jump into the code i might actully start with a functional test but i need to see how you and stephenfin handeled the functional tests for the exsiting reshapes12:33
sean-k-mooneygetting it working for a new deployment would be simpler but im going to have to deal with the upgrade case eventurally12:34
*** derekh has quit IRC12:34
*** lpetrut has quit IRC12:36
*** ociuhandu has joined #openstack-nova12:36
*** ratailor has quit IRC12:36
bauzassean-k-mooney: I have written reshapes for vGPUs, you can look at i t12:36
sean-k-mooneyyep but i dont want to context switch to that until next week12:39
*** lseki has joined #openstack-nova12:41
*** lpetrut has joined #openstack-nova12:48
*** lbragstad_ has joined #openstack-nova12:58
*** lbragstad_ has quit IRC12:59
openstackgerritIvaylo Mitev proposed openstack/nova master: VMware: Attach volumes using adapter type from instance  https://review.opendev.org/61659912:59
*** lbragstad_ has joined #openstack-nova12:59
*** lbragstad has quit IRC13:01
*** songwenping_ has quit IRC13:05
*** songwenping_ has joined #openstack-nova13:06
*** derekh has joined #openstack-nova13:12
*** hoonetorg has quit IRC13:16
*** jraju__ has quit IRC13:22
*** hoonetorg has joined #openstack-nova13:22
*** psachin has quit IRC13:25
* kashyap TIL about Ubunutu's https://netplan.io/13:29
kashyap"a utility for easily configuring networking on a linux system"13:29
*** artom has joined #openstack-nova13:37
*** KeithMnemonic has joined #openstack-nova13:43
*** lpetrut has quit IRC13:46
sean-k-mooneykashyap: ya it became the default in ubuntu 18.0413:51
kashyapI see; yet another abstraction.13:52
sean-k-mooneyit was intoduced to make bridging ot systemd-networkd simpler over time.13:53
sean-k-mooneythere a a few neche thing it does not support but in general i thikn its an impovement13:53
*** xek__ has quit IRC14:01
*** xek__ has joined #openstack-nova14:02
*** brinzhang_ has quit IRC14:02
*** brinzhang_ has joined #openstack-nova14:03
artomstephenfin, hey, comment on https://review.opendev.org/#/c/714698/814:05
artomstephenfin, I hesitate to -1 because of it, tell me what you think14:06
gmannbrinzhang_: gibi replied on pep8 fix patch. let me release new hacking 4.0.0 which will have new checks and then we can fix and bump version in same patch to verify all work fine.14:06
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types  https://review.opendev.org/72809414:06
gmannsean-k-mooney: sure, I will check14:07
*** lbragstad_ is now known as lbragstad14:08
openstackgerritJiri Suchomel proposed openstack/nova master: Bring back allowed_direct_url_schemes in support of RBD image download  https://review.opendev.org/72809514:09
stephenfinartom: replied14:12
stephenfinartom: tl;dr: I'd suggest blindly approving that and focusing your efforts on https://review.opendev.org/#/c/714703/ instead :P14:12
artomstephenfin, hehe - yeah, I'm slowly making my way up the stack.14:15
stephenfingmann: Before you do any work on it, I already have a hacking 3.1.0 proposed https://review.opendev.org/#/c/728016/14:16
stephenfinUsing semver for hacking (or flake8 and its ilk) is weird. On one hand, you normally think of minor versions as "not breaking anything" and that entails ensuring changes are purely additive, but for hacking a change can be purely additive and still break stuff14:17
stephenfingmann: in any case, I've opted for 3.1.0 because the release doesn't remove anything (so it's correct in a literal semver sense) and bumping the major version every time we add something new to hacking (or get it for free via flake8) seems insane14:21
*** dklyle has joined #openstack-nova14:26
*** ttsiouts has quit IRC14:30
stephenfinlyarwood: Do you think you'd be able to take a look at the bottom of this series at some point? https://review.opendev.org/#/q/topic:bp/use-pcpu-and-vcpu-in-one-instance+status:open14:32
*** maciejjozefczyk has quit IRC14:33
*** maciejjozefczyk has joined #openstack-nova14:33
stephenfinThe bottom patches are almost all cleanup and shuffling of code. Things only get interesting higher up (currently in merge conflict) and I'm happy to review those ones14:34
lyarwoodstephenfin: yup but likely not today14:34
stephenfinoh yeah, just at some point14:34
lyarwoodack added14:34
* lyarwood tilts head14:35
lyarwoodgerrit really doesn't like long series like that14:35
lyarwoodit took a few clicks to work out where the bottom of the series actually was14:35
gmannstephenfin: i see, thanks. I was waiting for hacking patch to merge before release. i agree on versioning things, it is difficult to make it consistent with other as per its nature of breaking things. 3.1.0 is ok for me.14:38
*** ttsiouts has joined #openstack-nova14:39
*** mlavalle has joined #openstack-nova14:40
gmannstephenfin: thanks you pinged me, i was about to push my local patch to release it :)14:41
stephenfinheh, no problem :)14:42
lyarwoodweirdness, I'm getting the following in a functional test despite using microversion = 'latest'14:48
lyarwood nova.tests.functional.api.client.OpenStackApiException: Unexpected status code: {"badRequest": {"code": 400, "message": "'host' is a required property"}}14:48
lyarwoodself.admin_api.put_service(test_compute0_service_id, {"forced_down": True}) <- from that, looks like it's using an earlier microversion but I can't see any obvious reason why, has anyone seen this before?14:49
gmannlyarwood:  which test. 'despite using microversion = 'latest'' you mean particular test right not overall for all request14:51
lyarwoodgmann: all requests, self.admin_api.microversion == 'latest'14:51
* lyarwood sets OS_DEBUG=1 to check the actual request14:52
gmannlyarwood: that might not work as test are written per microversion cap they would(might) not run for 'latest'.14:53
*** ttsiouts has quit IRC14:54
*** evrardjp has quit IRC14:55
lyarwoodgmann: you're talking about https://github.com/openstack/nova/blob/ef3b5707328f460d0d03759061c01b1a20f28743/nova/api/openstack/compute/services.py#L380-L383 right?14:55
lyarwoodgmann: so you have to use 2.53 to use this?14:55
gibidansmith: hi! one complication of the cache bug is that the cache management is virt driver specific but the placement resource management is up in the compute manager. So for the fix I need to pass new information through the virt driver interface, either by returning disc occupancy from manage_image_cache() or by adding some new get method to the virt interface14:55
*** evrardjp has joined #openstack-nova14:56
gmannlyarwood: yes,  but i am saying if you run all the func test with 'latest' then it would not work. or you are running only update service tests ?14:57
dansmithgibi: yeah, I was saying to sean-k-mooney yesterday how it's kinda split between them in an unhelpful way14:57
lyarwoodgmann: ah sorry no this is a specific test class that's set to 'latest'14:58
dansmithgibi: doing it during manage_image_cache() means the allocations will lag reality, which isn't going to work well I think14:58
dansmithgibi: IIRC, that runs very slowly, like every 24h or something14:58
dansmith(by default)14:58
dansmithgibi: unfortunately, I think it kinda has to happen synchronously during boot to really be effective14:59
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.text_type (1/2)  https://review.opendev.org/72810914:59
gibidansmith: yeah for the boot I need a sync approach. for the periodicy resynchronization I'm thinking of reusing manage_image_cache()14:59
dansmithgibi: sure15:00
gibidansmith: OK so we agree that a virt interface impact is unavoidable15:00
gmannlyarwood: ohk, then it is taking old 2.1 schema which need host. i think we read 'latest' correctly in code- https://github.com/openstack/nova/blob/ef3b5707328f460d0d03759061c01b1a20f28743/nova/api/openstack/compute/schemas/services.py#L4615:00
dansmithgibi: yeah I dunno how else you would do it.. like I had to add driver.cache_image() for my thing15:01
dansmithgibi: and probably some signaling about the filesystem same-ness15:01
gibidansmith: OK, I will continue working through this path then15:03
*** gyee has joined #openstack-nova15:04
lyarwoodgmann: ah got it thanks15:04
lyarwoodgmann: I was missing api_major_version = 'v2.1'15:04
gmannlyarwood: ohk, and it was microversion request with 2.0 so ignored15:06
*** slaweq has quit IRC15:06
lyarwoodgmann: yeah that wasn't at all obvious, thanks again :)15:08
*** slaweq has joined #openstack-nova15:11
*** martinkennelly has quit IRC15:22
*** martinkennelly has joined #openstack-nova15:22
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.text_type (2/2)  https://review.opendev.org/72811715:26
lyarwoodstephenfin / artom: random question, do either of you recall how nova.tests.functional.libvirt.base.ServersTestBase stops the instance directories from being created?15:28
artomlyarwood, I'd have to go digging - there's a presumably a mock/monkeypatch somewhere15:29
stephenfinlyarwood: Not off the top of my head, unfortunately15:29
lyarwoodI've stopped applying ImageBackendFixture and the other obvious file_open fixtures etc but it's still not happy15:29
lyarwoodack np15:29
openstackgerritStephen Finucane proposed openstack/nova master: WIP: Add emulated TPM support to Nova  https://review.opendev.org/63136315:30
openstackgerritStephen Finucane proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files  https://review.opendev.org/63993415:30
*** ociuhandu has quit IRC15:34
*** ociuhandu has joined #openstack-nova15:35
lyarwooddoh, it was nova.virt.libvirt.LibvirtDriver._create_image15:37
*** lucadelmonte90 has joined #openstack-nova15:39
lucadelmonte90hello,15:39
lucadelmonte90i couldn't find anything online, is there a way to disable instance resize from flavor a to flavor b, but keep it enabled for flavor a to flavor c?15:40
stephenfinefried: Can you drop your -2 on https://review.opendev.org/#/c/631363/ ?15:42
*** ociuhandu has quit IRC15:42
efriedstephenfin: dangit, I thought I had removed all of my -2s. Done.15:42
stephenfinThanks15:43
*** brinzhang_ has quit IRC15:44
*** brinzhang_ has joined #openstack-nova15:45
artomlucadelmonte90, no15:45
lucadelmonte90artom thanks :D15:46
*** ociuhandu has joined #openstack-nova15:46
artomlucadelmonte90, if only all questions were that easy :)15:47
gibinova meeting going to start in 10 minutes on #openstack-meeting-315:50
artomstephenfin, question on https://review.opendev.org/#/c/468203/1415:55
artomNot confident enough to -1...15:55
*** hoonetorg has quit IRC15:56
* bauzas is back from AFK15:56
bauzasjust in time for the meeting15:56
* bauzas loves doctors who don't tell their delays15:56
artomFor the meating15:56
bauzasand yelp doesn't help for getting doctor's votes :(15:57
bauzasartom: too early for me15:58
bauzasI'm not hungry but we're close to beer time tho15:58
artomNot that kind of meating, muahaha15:58
*** bbowen has quit IRC15:58
artomstephenfin, and another question on https://review.opendev.org/#/c/461456/1316:00
*** tesseract has quit IRC16:00
*** rpittau is now known as rpittau|afk16:01
artombauzas, I beet myself up every day16:02
artom(Let's not pollute the meating)16:02
*** gregwork has joined #openstack-nova16:03
bauzasartom: my doctor told me I should heel16:04
*** hoonetorg has joined #openstack-nova16:08
*** ttsiouts has joined #openstack-nova16:18
*** happyhemant has quit IRC16:22
*** ttsiouts has quit IRC16:23
*** dpawlik has quit IRC16:27
*** udesale has quit IRC16:28
*** udesale_ has quit IRC16:28
bauzasbear time !16:31
gibi:D16:31
*** evrardjp has quit IRC16:33
*** evrardjp has joined #openstack-nova16:33
gmanngibi: https://blueprints.launchpad.net/nova/+spec/policy-defaults-refresh-deprecated-apis16:33
*** maciejjozefczyk has quit IRC16:39
*** dtantsur is now known as dtantsur|afk16:44
*** mlavalle has quit IRC16:47
*** ociuhandu has quit IRC16:52
*** ociuhandu has joined #openstack-nova16:53
*** ociuhandu has quit IRC16:53
*** ociuhandu has joined #openstack-nova16:54
*** derekh has quit IRC16:58
*** hoonetorg has quit IRC17:05
*** ociuhandu has quit IRC17:06
melwittsean-k-mooney: why do you think we need the bigger list here? https://review.opendev.org/#/c/727898/3/bindep.txt just wondering bc it works without them being explicitly named17:07
*** ociuhandu has joined #openstack-nova17:08
*** brinzhang_ has quit IRC17:13
*** brinzhang_ has joined #openstack-nova17:14
*** hoonetorg has joined #openstack-nova17:19
*** lucadelmonte90 has quit IRC17:19
*** vishalmanchanda has quit IRC17:23
*** ociuhandu has quit IRC17:27
*** ociuhandu has joined #openstack-nova17:28
openstackgerritmelissaml proposed openstack/os-traits master: Remove translation sections from setup.cfg  https://review.opendev.org/72816017:30
*** bbowen has joined #openstack-nova17:31
*** ociuhandu has quit IRC17:33
*** sapd__x has quit IRC17:55
NobodyCamGood morning Nova folk's could someone help point me to which database this would come from: `Placement API returning an error response: Conflicting resource provider name: <hostName> already exists. call_func /openstack/venvs/nova-18.1.5.dev5/lib/python2.7/site-packages/nova/api/openstack/placement/wsgi_wrapper.py:31`17:56
melwittNobodyCam: what version? (has to be older bc placement was removed from nova in train) database would be the placement database, and if the version is old enough, it would be the nova_api database18:01
NobodyCamMorning melwitt :) I'm on rocky18:01
melwittok, yeah so if you have a database called 'placement' it will be in there, if not it will be in the database called 'nova_api'18:02
*** grandchild has joined #openstack-nova18:03
NobodyCamI have nova_api18:04
melwittthere's a unique constraint on resource provider name https://github.com/openstack/nova/blob/stable/rocky/nova/db/sqlalchemy/api_models.py#L292-L30618:04
melwittresource_providers table18:04
melwittand if you want to change the name the recommended way is to use the placement cli https://docs.openstack.org/osc-placement/rocky/cli/index.html#resource-provider-set18:07
melwittalthough I guess it depends on how you're getting the error. if it's nova trying to do something then you will need to change something in nova. sorry I spoke too soon18:08
NobodyCamwe had a hypervisor crash and was brought back with the same name18:10
NobodyCamthe error is from a openstack server create with --AZ nova:<Host_fqdn> blah18:11
NobodyCamI only see one entry for the host in resource_providers18:12
melwittoh, this sounds familiar18:14
NobodyCamhum seem I'm missing something:18:14
NobodyCamhttps://www.irccloud.com/pastebin/GVwbM6LK/18:14
melwittthe placement cli is a osc plugin so you have to install the osc-placement package to get the commands18:15
melwittbut it sounds like you have a situation where nova is trying to create the resource provider but it already exists18:16
NobodyCamyea18:18
NobodyCamI can delete the record from resource_providers18:19
melwittthis is likely be related to a WIP patch https://review.opendev.org/678100 (just fyi) but to recover, you will need to delete the resource provider. but before you do it, please check if it has any allocations on it by using the placement cli18:20
melwittopenstack resource provider show --allocations <uuid>18:21
melwittand if there are allocations, save those (copy paste somewhere) because you'll want to restore them after you delete the resource provider18:21
*** ralonsoh has quit IRC18:21
melwittafter you save the allocations, delete the resource provider 'openstack resource provider delete <uuid>'18:22
*** martinkennelly has quit IRC18:22
melwittrestart nova-compute, that should create the new resource provider18:22
melwittthen if you had allocations from earlier, set them on the new resource provider https://docs.openstack.org/osc-placement/rocky/cli/index.html#resource-provider-allocation-set18:23
NobodyCamAwesome :) thank you melwitt Working on getting placement plugin going18:23
melwittok cool. yeah after you install osc-placement (either from pip or distro package) then the commands will magically be part of the 'openstack' command18:25
*** brinzhang_ has quit IRC18:31
*** brinzhang has joined #openstack-nova18:33
*** umbSublime has quit IRC18:34
*** umbSublime_ has quit IRC18:35
*** umbSublime_ has joined #openstack-nova18:36
*** umbSublime_ has quit IRC18:37
*** dpawlik has joined #openstack-nova18:51
*** ttsiouts has joined #openstack-nova18:57
*** avolkov has quit IRC19:28
*** ttsiouts has quit IRC19:32
openstackgerritAndreas Jaeger proposed openstack/nova master: Switch to newer openstackdocstheme and reno versions  https://review.opendev.org/72826319:35
NobodyCammelwitt: Again massive thank you, we are back up and working19:37
NobodyCamno allocations so just a delete and restart fixed us right up19:38
melwittNobodyCam: np, glad to hear. ah good, I was hoping it would be the easy case :)19:39
NobodyCam:)19:39
openstackgerritAndreas Jaeger proposed openstack/python-novaclient master: Switch to newer openstackdocstheme and reno versions  https://review.opendev.org/72827019:46
*** dpawlik has quit IRC19:46
openstackgerritAndreas Jaeger proposed openstack/python-novaclient master: Switch to newer openstackdocstheme and reno versions  https://review.opendev.org/72827019:46
*** slaweq has quit IRC19:51
openstackgerritmelanie witt proposed openstack/nova master: Add packages required for pdf docs build to bindep.txt  https://review.opendev.org/72789819:53
*** nweinber has quit IRC19:54
*** raildo_ has joined #openstack-nova19:58
*** slaweq has joined #openstack-nova19:59
*** raildo has quit IRC20:01
*** ociuhandu has joined #openstack-nova20:06
gmannsean-k-mooney: change lgtm and not changing the API but i am not sure about mentioned use case of this API to refresh the cache. server external event  API  is for openstack services mainly.  - https://review.opendev.org/#/c/702394/320:11
*** ociuhandu has quit IRC20:13
*** ccamacho has quit IRC20:23
*** awalende has quit IRC20:35
*** maciejjozefczyk has joined #openstack-nova20:36
*** maciejjozefczyk has quit IRC20:42
*** raildo_ has quit IRC20:47
*** raildo_ has joined #openstack-nova20:47
*** adrianc has quit IRC21:10
*** jsuchome has quit IRC21:34
*** JamesBenson has quit IRC21:34
*** lbragstad has quit IRC21:35
*** ttsiouts has joined #openstack-nova21:42
*** raildo_ has quit IRC21:49
*** slaweq has quit IRC22:02
*** mriedem has left #openstack-nova22:03
*** tbachman_ has joined #openstack-nova22:05
*** tbachman has quit IRC22:05
*** tbachman_ is now known as tbachman22:05
*** ttsiouts has quit IRC22:16
*** slaweq has joined #openstack-nova22:19
*** slaweq has quit IRC22:24
*** slaweq has joined #openstack-nova22:29
*** slaweq has quit IRC22:33
*** tbachman_ has joined #openstack-nova22:52
*** tbachman has quit IRC22:53
*** tbachman_ is now known as tbachman22:53
*** ttsiouts has joined #openstack-nova22:53
openstackgerritmelanie witt proposed openstack/nova master: DNM Try out running sphinx-build in parallel for releasenotes  https://review.opendev.org/72742922:55
*** ttsiouts has quit IRC22:58
*** tkajinam has joined #openstack-nova22:58
*** ociuhandu has joined #openstack-nova23:02
*** tosky has quit IRC23:05
*** ociuhandu has quit IRC23:07
*** grandchild has quit IRC23:18
*** ttsiouts has joined #openstack-nova23:37
*** ttsiouts has quit IRC23:42

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!