| *** tetsuro has joined #openstack-nova | 00:04 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Configure latex_engine = 'xelatex' for pdf docs build https://review.opendev.org/727898 | 00:05 |
|---|---|---|
| openstackgerrit | melanie witt proposed openstack/nova master: Fix pep8 errors uncovered by flake8 3.8.1 https://review.opendev.org/728312 | 00:09 |
| *** tbachman_ has joined #openstack-nova | 00:13 | |
| *** lbragstad has joined #openstack-nova | 00:15 | |
| *** tbachman has quit IRC | 00:16 | |
| *** tbachman_ is now known as tbachman | 00:16 | |
| *** JamesBenson has joined #openstack-nova | 00:34 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Fix flake8 error from hacking <3.0.1 https://review.opendev.org/727589 | 00:37 |
| gmann | melwitt: we need this to be in to have right cap for hacking and flake8 - https://review.opendev.org/#/c/727347/1 | 00:44 |
| gmann | i thought it was merged | 00:44 |
| gmann | but is doc job still failing ? | 00:44 |
| melwitt | gmann: rechecking not gonna help, docs job still broken | 00:45 |
| melwitt | it did merge but didn't stop the failure, I replied on the ML post | 00:46 |
| gmann | i thought openstackdocstheme 2.1.0 fixed that on gate | 00:46 |
| melwitt | 2.1.1 was intended to fix it but it did not work | 00:47 |
| melwitt | my nova side fix is still proposed but now we have a chicken and egg with the pep8 job | 00:47 |
| melwitt | I sent a ML post about that too a little while ago | 00:47 |
| gmann | ah just saw, i think we can squash it with 727898 | 00:48 |
| brinzhang | gmann: the hacking verion should change to 3.1.0? | 00:49 |
| brinzhang | right? | 00:49 |
| gmann | brinzhang: yeah in your patch yes as it will fix the code together | 00:50 |
| brinzhang | gmann: ok, update soon | 00:50 |
| melwitt | I wonder if alex_xu is around | 00:51 |
| gmann | melwitt: this should avoid doc failure - https://review.opendev.org/#/c/727943/4 | 00:56 |
| melwitt | gmann: it doesn't because 2.1.1 also fails | 00:56 |
| melwitt | if you look in the docs job build logs, 2.1.1 is installed now | 00:57 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Bump hacking min version to 3.1.0 https://review.opendev.org/727589 | 00:58 |
| gmann | melwitt: not sure why not complete revert that instead if backlist. PS1 was right revert - https://review.opendev.org/#/c/727943/1/upper-constraints.txt | 00:58 |
| brinzhang | gmann: updated, I just only keep the hacking min version to 3.1.0, i.e. hacking>=3.1.0, please check | 01:00 |
| *** ttsiouts has joined #openstack-nova | 01:00 | |
| *** ttsiouts has quit IRC | 01:05 | |
| *** Liang__ has joined #openstack-nova | 01:09 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Bump hacking min version to 3.1.0 https://review.opendev.org/727589 | 01:18 |
| brinzhang | gmann: do we need to continue merged hacking 3.0.1 https://review.opendev.org/#/c/727347/? | 01:22 |
| *** brinzhang_ has joined #openstack-nova | 01:31 | |
| *** brinzhang has quit IRC | 01:34 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Bump hacking min version to 3.0.1 https://review.opendev.org/727347 | 01:48 |
| melwitt | gmann: lol, what a day huh! | 01:51 |
| melwitt | (gate stuff) | 01:51 |
| gmann | :). I think we made little hurry to release new hacking. | 01:54 |
| gmann | I vote is to move back openstackdocstheme to 2.0.2 as nova, cinder are hitting doc + pep8 and may be more projects but not checked | 01:55 |
| gmann | *my vote | 01:55 |
| gmann | asked in requirement channel, let's see if we can get any other fast way to unblock | 01:56 |
| melwitt | yeah, I lean that way too | 01:56 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Bump hacking min version to 3.1.0 https://review.opendev.org/727589 | 01:57 |
| gmann | because hacking is blacklist req so it cannot be controlled on single place (g-r side). | 01:58 |
| melwitt | I see | 01:58 |
| *** sapd__x has joined #openstack-nova | 02:01 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Bump hacking min version to 3.1.0 https://review.opendev.org/727589 | 02:08 |
| *** gyee has quit IRC | 02:18 | |
| *** icarusfactor has joined #openstack-nova | 02:25 | |
| *** factor has quit IRC | 02:26 | |
| melwitt | gmann: do you plan to depends-on the roll back patch or did you want to try it out some other way? | 02:35 |
| gmann | i can do that. | 02:36 |
| melwitt | or could do a dummy patch | 02:36 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Bump hacking min version to 3.0.1 https://review.opendev.org/727347 | 02:37 |
| gmann | melwitt: as it needs to re-run anyways. done ^^ | 02:37 |
| melwitt | yeah, I saw it had already failed the docs job | 02:37 |
| melwitt | cool I'll keep an eye on it | 02:37 |
| *** icarusfactor has quit IRC | 02:51 | |
| *** icarusfactor has joined #openstack-nova | 02:52 | |
| *** ttsiouts has joined #openstack-nova | 03:01 | |
| *** ociuhandu has joined #openstack-nova | 03:05 | |
| *** ociuhandu has quit IRC | 03:09 | |
| *** xiaolin has quit IRC | 03:11 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Configure latex_engine = 'xelatex' for pdf docs build https://review.opendev.org/727898 | 03:13 |
| melwitt | gmann: oh no, depends-on doesn't work for requirements changes?? | 03:15 |
| melwitt | still failing | 03:15 |
| melwitt | and pulling in 2.1.1 | 03:15 |
| *** xiaolin has joined #openstack-nova | 03:15 | |
| gmann | melwitt: yeah, we need to get requirement revert merge first | 03:19 |
| melwitt | gmann: oh really? depends-on known not to work in this case? I didn't know that, guh | 03:19 |
| melwitt | I thought we were going to be able to test if job passes with the requirement revert | 03:20 |
| *** tetsuro has quit IRC | 03:21 | |
| *** ttsiouts has quit IRC | 03:35 | |
| *** kevinz has quit IRC | 03:37 | |
| *** psachin has joined #openstack-nova | 03:39 | |
| gmann | melwitt: left note on this to recheck after req patch merge - https://review.opendev.org/#/c/727347/3 | 03:43 |
| melwitt | gmann: cool, I've re-approved it so it's ready to go | 03:43 |
| gmann | bauzas: stephenfin gibi ^^ whoever wake up early. this is req patch to merge first - https://review.opendev.org/#/c/728335/ | 03:44 |
| gmann | melwitt: thanks. | 03:44 |
| gmann | going to bed... | 03:45 |
| melwitt | k seeya | 03:45 |
| *** factor has joined #openstack-nova | 03:45 | |
| *** kevinz has joined #openstack-nova | 03:46 | |
| *** icarusfactor has quit IRC | 03:47 | |
| *** xiaolin has quit IRC | 03:51 | |
| *** xiaolin has joined #openstack-nova | 03:51 | |
| *** factor has quit IRC | 03:51 | |
| *** factor has joined #openstack-nova | 03:52 | |
| *** xiaolin has quit IRC | 04:01 | |
| *** ratailor has joined #openstack-nova | 04:02 | |
| *** zzzeek has quit IRC | 04:23 | |
| *** zzzeek has joined #openstack-nova | 04:24 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** ociuhandu has joined #openstack-nova | 04:33 | |
| *** evrardjp has joined #openstack-nova | 04:33 | |
| *** ociuhandu has quit IRC | 04:43 | |
| *** ociuhandu has joined #openstack-nova | 04:44 | |
| *** ociuhandu has quit IRC | 04:50 | |
| *** vishalmanchanda has joined #openstack-nova | 04:55 | |
| *** tetsuro has joined #openstack-nova | 05:11 | |
| *** tetsuro has quit IRC | 05:11 | |
| *** ttsiouts has joined #openstack-nova | 05:11 | |
| *** ttsiouts has quit IRC | 05:16 | |
| *** tetsuro has joined #openstack-nova | 05:17 | |
| *** artom has quit IRC | 05:25 | |
| *** udesale has joined #openstack-nova | 05:25 | |
| *** ociuhandu has joined #openstack-nova | 05:52 | |
| *** ccamacho has joined #openstack-nova | 05:56 | |
| *** dpawlik has joined #openstack-nova | 05:58 | |
| *** ociuhandu has quit IRC | 05:59 | |
| *** links has joined #openstack-nova | 05:59 | |
| *** xiaolin has joined #openstack-nova | 06:00 | |
| *** xiaolin has quit IRC | 06:26 | |
| *** dklyle has quit IRC | 06:27 | |
| *** xek_ has joined #openstack-nova | 06:30 | |
| *** xek__ has quit IRC | 06:32 | |
| *** tbachman has quit IRC | 06:37 | |
| *** nightmare_unreal has joined #openstack-nova | 06:39 | |
| *** jaosorior has joined #openstack-nova | 06:43 | |
| *** ociuhandu has joined #openstack-nova | 06:45 | |
| *** tesseract has joined #openstack-nova | 06:55 | |
| openstackgerrit | Andreas Jaeger proposed openstack/nova master: DNM: Test openstackdocstheme master https://review.opendev.org/728372 | 06:57 |
| gibi | good morning nova | 07:01 |
| gibi | gmann: I see melwitt rechecked it | 07:03 |
| melwitt | gibi: yeah rechecked it just a little while ago, once that lands, our gate should be unblocked. fingers crossed nothing goes wrong | 07:03 |
| gibi | gmann: I'm approving https://blueprints.launchpad.net/nova/+spec/policy-defaults-refresh-deprecated-apis as we agreed about it on yesterday's team meeting | 07:03 |
| *** maciejjozefczyk has joined #openstack-nova | 07:09 | |
| *** ralonsoh has joined #openstack-nova | 07:12 | |
| *** rpittau|afk is now known as rpittau | 07:12 | |
| bauzas | good Friday Nova | 07:18 |
| * bauzas wonders whether he should reuse good Friday habits | 07:24 | |
| *** bauzas is now known as bauwser | 07:24 | |
| bauwser | there it is | 07:24 |
| *** ttsiouts has joined #openstack-nova | 07:31 | |
| *** jraju__ has joined #openstack-nova | 07:33 | |
| *** links has quit IRC | 07:33 | |
| *** tosky has joined #openstack-nova | 07:35 | |
| *** xek__ has joined #openstack-nova | 07:41 | |
| *** slaweq has joined #openstack-nova | 07:41 | |
| *** xek_ has quit IRC | 07:43 | |
| *** ociuhandu has quit IRC | 07:51 | |
| *** ttsiouts has quit IRC | 07:55 | |
| *** ttsiouts has joined #openstack-nova | 08:01 | |
| *** jsuchome has joined #openstack-nova | 08:02 | |
| kashyap | bauwser: /me waves | 08:05 |
| *** tkajinam has quit IRC | 08:14 | |
| *** dtantsur|afk is now known as dtantsur | 08:17 | |
| *** ttsiouts has quit IRC | 08:19 | |
| *** avolkov has joined #openstack-nova | 08:30 | |
| *** ttsiouts has joined #openstack-nova | 08:31 | |
| *** salmankhan has joined #openstack-nova | 08:32 | |
| *** salmankhan has quit IRC | 08:36 | |
| *** salmankhan has joined #openstack-nova | 08:37 | |
| *** martinkennelly has joined #openstack-nova | 08:48 | |
| *** ociuhandu has joined #openstack-nova | 08:49 | |
| *** ttsiouts has quit IRC | 08:52 | |
| *** ttsiouts has joined #openstack-nova | 08:53 | |
| openstackgerrit | Andreas Jaeger proposed openstack/nova master: DNM: Test openstackdocstheme master https://review.opendev.org/728372 | 08:56 |
| *** tetsuro has quit IRC | 09:09 | |
| *** tbachman has joined #openstack-nova | 09:10 | |
| *** jraju__ has quit IRC | 09:11 | |
| *** links has joined #openstack-nova | 09:12 | |
| *** ttsiouts has quit IRC | 09:16 | |
| lyarwood | stephenfin: https://review.opendev.org/#/c/676208/ - I'm onboard with using mypy just not adding it to the pep8 while it's still optional and not used outside of the libvirt driver. | 09:17 |
| lyarwood | pep8 env* | 09:17 |
| *** ttsiouts has joined #openstack-nova | 09:18 | |
| stephenfin | lyarwood: I originally had a separate mypy zuul job and tox target but when I proposed said zuul job against openstack-zuul-jobs, mordred noted that zuul simply integrated it into their pep8 target (or linters, I think they call it) | 09:19 |
| stephenfin | hence why I did it that way | 09:19 |
| stephenfin | where would be better? | 09:19 |
| *** links has quit IRC | 09:19 | |
| *** brinzhang_ has quit IRC | 09:24 | |
| lyarwood | stephenfin: okay it might not be worth splitting hairs over this but given it's not widely used in openstack/nova yet it seems like overkill to run it everytime we run pep8 | 09:25 |
| lyarwood | stephenfin: I guess zuul is using it as standard across their codebase and that's why they've merged things | 09:26 |
| *** links has joined #openstack-nova | 09:26 | |
| lyarwood | stephenfin: if gibi and others are cool with it being in the pep8 env then I'll shut up and let it merge :) | 09:27 |
| gibi | stephenfin, lyarwood: is it something that makes tox -e fast8 target significantly slower? | 09:29 |
| stephenfin | it doesn't affect fast8, no | 09:29 |
| stephenfin | and even for pep8, it takes seconds to run | 09:29 |
| lyarwood | with a single file at the moment ;) | 09:29 |
| lyarwood | but yeah it's little to no overhead | 09:30 |
| gibi | pep8 takes minutes so additional seconds does not cause any pain for me | 09:30 |
| gibi | so I'm OK to integrate it to the pep8 target | 09:30 |
| lyarwood | ack thank s gibi | 09:30 |
| *** brinzhang has joined #openstack-nova | 09:30 | |
| stephenfin | three files two commits later! | 09:30 |
| gibi | :D | 09:30 |
| lyarwood | lol, we can always break it out again if it does become an issue | 09:31 |
| gibi | agree ^^ | 09:31 |
| stephenfin | cool | 09:31 |
| brinzhang | stephenfin: do I need to remove this sentence from the commit message? https://review.opendev.org/#/c/727589/8//COMMIT_MSG | 09:31 |
| stephenfin | also, is it just me, or is Gerrit really slow this week? | 09:31 |
| lyarwood | stephenfin: just you | 09:31 |
| stephenfin | like, 'git review -d foo' takes minutes | 09:31 |
| stephenfin | damn | 09:31 |
| *** ircuser-1 has quit IRC | 09:32 | |
| * lyarwood hugs his 1Gbps line | 09:32 | |
| stephenfin | the web UI is a-ok, but pulling stuff is taking an age | 09:32 |
| brinzhang | git review -d, I always need minutes | 09:32 |
| lyarwood | I've really not noticed anything tbh | 09:32 |
| * gibi does not use git review | 09:33 | |
| stephenfin | brinzhang: you don't need to exclude F811 now, do you? | 09:33 |
| stephenfin | gibi: :O | 09:33 |
| stephenfin | so you manually copy download links? | 09:33 |
| stephenfin | *checkout links | 09:33 |
| gibi | stephenfin: yepp, and I use git push origin HEAD:refs/for/master/my-topic to push things up | 09:33 |
| brinzhang | stephenfin: you mean I should remove F811 from flake8 ignore in tox.ini? | 09:34 |
| stephenfin | brinzhang: I assume so, since you added noqa lines to the "duplicated" functions/methods? | 09:34 |
| stephenfin | That is what F811 is for, right? | 09:34 |
| brinzhang | yes | 09:34 |
| * gibi is an old school git guy | 09:34 | |
| brinzhang | in the future, if someone need to add one function name as the same as before, they also need to add noqa. | 09:35 |
| brinzhang | ok, I will remove F811 from tox | 09:35 |
| * stephenfin thinks gibi's just bit masochistic | 09:36 | |
| brinzhang | gibi: IMO, you can give a guide to use link to submit code, and update code. | 09:36 |
| gibi | stephenfin: I have full control this way | 09:36 |
| brinzhang | I always used 'git review ', it seems slowly always | 09:36 |
| gibi | stephenfin: e.g. I can push patches from a series during interactive rebase | 09:37 |
| stephenfin | gibi: you mean half way through the rebase? | 09:37 |
| gibi | stephenfin: yepp | 09:37 |
| gibi | stephenfin: for long chains it helps | 09:38 |
| stephenfin | Fair. I'd usually just download patch N locally and rebase all of that | 09:38 |
| gibi | stephenfin: yeah that works too | 09:38 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Bump hacking min version to 3.1.0 https://review.opendev.org/727589 | 09:39 |
| gibi | I don't see what really git review automates that I cannot do manually with git with significant extra burden | 09:39 |
| gibi | I mean plain git seems as easy as git review to me | 09:39 |
| stephenfin | Can't argue with that | 09:41 |
| * stephenfin hugs git-review tightly though | 09:41 | |
| *** brinzhang has quit IRC | 09:47 | |
| gibi | :) | 09:48 |
| *** Liang__ has quit IRC | 09:54 | |
| openstackgerrit | Harshavardhan Metla proposed openstack/nova master: [Nova] Add reference to Placement installation guide https://review.opendev.org/726936 | 10:05 |
| bauwser | fwiw, git-review does more than just uploading your series | 10:06 |
| bauwser | at least automatically rebasing on top of the remote | 10:08 |
| *** rpittau is now known as rpittau|bbl | 10:09 | |
| *** ttsiouts has quit IRC | 10:19 | |
| *** songwenping_ has quit IRC | 10:20 | |
| openstackgerrit | Jiri Suchomel proposed openstack/nova master: Adapt the admin guide to describe the direct RBD export https://review.opendev.org/728411 | 10:22 |
| *** ttsiouts has joined #openstack-nova | 10:25 | |
| *** dpawlik has quit IRC | 10:27 | |
| *** dpawlik has joined #openstack-nova | 10:28 | |
| *** happyhemant has joined #openstack-nova | 10:28 | |
| *** breizhkoala has joined #openstack-nova | 10:29 | |
| *** breizhkoala has quit IRC | 10:37 | |
| *** breizhkoala has joined #openstack-nova | 10:37 | |
| *** derekh has joined #openstack-nova | 10:43 | |
| *** ttsiouts has quit IRC | 10:59 | |
| *** ociuhandu has quit IRC | 11:01 | |
| *** ociuhandu has joined #openstack-nova | 11:02 | |
| *** ociuhandu has quit IRC | 11:02 | |
| *** ociuhandu has joined #openstack-nova | 11:03 | |
| *** ociuhandu has quit IRC | 11:13 | |
| *** ociuhandu has joined #openstack-nova | 11:14 | |
| *** ociuhandu has quit IRC | 11:14 | |
| *** ociuhandu has joined #openstack-nova | 11:15 | |
| *** ttsiouts has joined #openstack-nova | 11:18 | |
| *** ociuhandu has quit IRC | 11:25 | |
| *** ttsiouts has quit IRC | 11:33 | |
| *** threestrands has quit IRC | 11:46 | |
| sean-k-mooney | stephenfin: add mypy to the linters target i was suggesting lyarwood add bashate too and make it non voteing for now? | 11:57 |
| *** efried has quit IRC | 11:57 | |
| *** efried has joined #openstack-nova | 11:58 | |
| sean-k-mooney | stephenfin: then we can either move it to pep8 when we want to make it required or we can make the linters target voting to make both voting | 11:58 |
| lyarwood | sean-k-mooney: I didn't even think about actually using a linters target | 12:01 |
| sean-k-mooney | lyarwood: yep you should. i left a comment to that effect on your patch but it took me like an hour to realise that is where you should put the bashate command too | 12:03 |
| sean-k-mooney | given the linter tox enve and job are a semi standard now, they are just not required in the pti | 12:04 |
| sean-k-mooney | at least not yet anyway | 12:04 |
| *** ociuhandu has joined #openstack-nova | 12:05 | |
| *** rpittau|bbl is now known as rpittau | 12:06 | |
| lyarwood | sean-k-mooney: yeah I've just seen your reviews on that bashate change, missed them earlier. | 12:07 |
| lyarwood | sean-k-mooney: I've already ack'd stephenfin's initial change but we can follow up and move it into a linters target later | 12:08 |
| sean-k-mooney | where is his mypy change landing currently? | 12:09 |
| lyarwood | sean-k-mooney: https://review.opendev.org/#/c/676208/ | 12:09 |
| sean-k-mooney | to be clear i was pretty ok with it landing in pep8 straight away but i dont think it deserves its own job or tox target | 12:10 |
| *** udesale_ has joined #openstack-nova | 12:10 | |
| sean-k-mooney | ok i see | 12:10 |
| lyarwood | sean-k-mooney: kk | 12:10 |
| sean-k-mooney | its just a seperate target but not added to any job | 12:10 |
| sean-k-mooney | that works too | 12:10 |
| sean-k-mooney | but ya linter i think is the way to go | 12:11 |
| sean-k-mooney | stephenfin: by the way if you want to add mypy to os vif i wont say no :) | 12:11 |
| *** ociuhandu has quit IRC | 12:13 | |
| *** udesale has quit IRC | 12:13 | |
| *** raildo has joined #openstack-nova | 12:15 | |
| jsuchome | hey ... I do not know what are you discussing, is it related to the fact that pep8 builds are failing with errors unrelated to the patch? | 12:16 |
| sean-k-mooney | jsuchome: no | 12:16 |
| sean-k-mooney | jsuchome: mypy is a checker for python type annotations | 12:16 |
| sean-k-mooney | jsuchome: we are slowly starting to adopt it now that we are python3 only and can do so more easily | 12:17 |
| lyarwood | jsuchome: https://review.opendev.org/727347 should fix the pep8 errors | 12:17 |
| jsuchome | I see, thanks | 12:18 |
| *** ttsiouts has joined #openstack-nova | 12:25 | |
| *** artom has joined #openstack-nova | 12:32 | |
| *** ratailor has quit IRC | 12:38 | |
| openstackgerrit | Andreas Jaeger proposed openstack/python-novaclient master: Switch to newer openstackdocstheme and reno versions https://review.opendev.org/728270 | 12:39 |
| openstackgerrit | Andreas Jaeger proposed openstack/nova master: Switch to newer openstackdocstheme and reno versions https://review.opendev.org/728263 | 12:39 |
| *** ociuhandu has joined #openstack-nova | 12:39 | |
| *** ttsiouts has quit IRC | 12:51 | |
| *** lbragstad_ has joined #openstack-nova | 12:54 | |
| *** lbragstad_ has quit IRC | 12:54 | |
| *** jangutter has joined #openstack-nova | 12:55 | |
| *** lbragstad has quit IRC | 12:56 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Update and correct typing information https://review.opendev.org/714694 | 12:58 |
| stephenfin | lyarwood: Addressed your comments on ^ | 12:59 |
| *** lbragstad has joined #openstack-nova | 13:01 | |
| *** sapd__x has quit IRC | 13:04 | |
| lyarwood | stephenfin: ack thanks | 13:07 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reserve DISK_GB resource for the image cache https://review.opendev.org/728439 | 13:08 |
| gibi | dansmith: hi! fyi there is the first version of disk reservation patch for the image cache ^^ | 13:09 |
| *** nweinber has joined #openstack-nova | 13:10 | |
| gmann | gibi: thanks | 13:10 |
| francoisp | lyarwood, bauzas hello, when you get a chance: https://review.opendev.org/#/c/726508/ -thank you! | 13:11 |
| lyarwood | francoisp: ack sorry done | 13:13 |
| francoisp | thanks lyarwood | 13:15 |
| openstackgerrit | Merged openstack/nova master: Bump hacking min version to 3.0.1 https://review.opendev.org/727347 | 13:25 |
| openstackgerrit | Jiri Suchomel proposed openstack/nova master: Bring back allowed_direct_url_schemes in support of RBD image download https://review.opendev.org/728095 | 13:33 |
| *** Sundar has joined #openstack-nova | 13:34 | |
| gmann | finally merged. gate should be green now | 13:35 |
| *** ttsiouts has joined #openstack-nova | 13:38 | |
| openstackgerrit | Jiri Suchomel proposed openstack/nova master: Adapt the admin guide to describe the direct RBD export https://review.opendev.org/728411 | 13:41 |
| *** ttsiouts has quit IRC | 13:43 | |
| dansmith | gibi: you decided on reserved instead of a new allocation? | 13:44 |
| gibi | dansmith: yes, reservation is the current working assumption | 13:44 |
| dansmith | gibi: I really wasn't arguing that reserved was better (and I think I said that) I just wanted us to consider it | 13:44 |
| dansmith | gibi: it certainly looks simpler than a new allocation though. I was going to look for code that deleted the allocation if they moved the cache from shared to separate filesystem, but this would auto correct itself | 13:45 |
| gibi | dansmith: I realized that we recalculate reservation at every update_provider_tree() call anyhow | 13:46 |
| dansmith | yeah | 13:46 |
| gibi | so I plugged my calculation into that loop | 13:46 |
| dansmith | yeah, even though this is less granular, it feels like a much smaller and less scary change, even something we could backport | 13:47 |
| gibi | there is one downside, placement allow bumping the reservation over the total - usage | 13:47 |
| dansmith | the other downside is this lags the actual usage | 13:48 |
| dansmith | but, very simple | 13:48 |
| gibi | when I pushed the patch I added a TODO to bump the reservation before we download an image but since then I lost in the imagebackend code again to find the place where we download image to the cache and it is faaar from easy | 13:49 |
| dansmith | yeah, no | 13:50 |
| *** kevinz has quit IRC | 13:50 | |
| gibi | I start thinking that from the reservation handling perspective this is what we can do. This is far from perfect but it has a good roi | 13:52 |
| gibi | dansmith: would it be OK with you if we stop in the virt driver at this point? I will still look into adding the pre-filter part separately | 13:53 |
| gibi | but I'm scared from the imagebackend | 13:53 |
| dansmith | what do you mean "stop in the virt driver"? | 13:54 |
| gibi | I mean, not trying to bump the reservation before we download a new image to the cache | 13:55 |
| dansmith | oh yeah, I don't think that's the way to go.. we'd have to update inventory before each boot | 13:57 |
| dansmith | I think if we go the reservation approach, we accept the imperfectness of it, in exchange for its simplicity | 13:57 |
| *** ratailor has joined #openstack-nova | 13:57 | |
| dansmith | if it turns out to not help often enough, then we can move to the allocation method or something else | 13:58 |
| dansmith | a pre-filter will help avoid that | 13:58 |
| dansmith | I dumped some comments about the approaches on the patch just now | 13:58 |
| gibi | looking | 13:58 |
| *** breizhkoala has quit IRC | 13:59 | |
| *** mlavalle has joined #openstack-nova | 13:59 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Allow snapshots to be created from PAUSED volume backed instances https://review.opendev.org/728011 | 13:59 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Remove snapshot quiesce tests for STOPPED and SUSPENDED instances https://review.opendev.org/728012 | 13:59 |
| gibi | OK so we agree that this is a good compromise as is. I will move the config to [workaround] for now as that is safer place. | 14:02 |
| gibi | an sure I will add test and documentation to the patch | 14:02 |
| *** icarusfactor has joined #openstack-nova | 14:02 | |
| dansmith | cool | 14:03 |
| gibi | dansmith: thank you | 14:03 |
| dansmith | gibi: you're doing the work, but... sure :) | 14:03 |
| gibi | dansmith: talking about it helps :) | 14:04 |
| dansmith | gibi: my couch is always open | 14:04 |
| gibi | :D | 14:05 |
| *** factor has quit IRC | 14:05 | |
| * dansmith strokes his (non-existent) beard | 14:05 | |
| aarents | gibi: dansmith thanks for handling this reservation stuff, I will backport this once finished for sure :) | 14:09 |
| gibi | aarents: I have a mandate to backport it to Train at least due to the downstream project I'm supporintg | 14:09 |
| dansmith | especially if it's in [workarounds] I have no problem supporting it going back to train upstream, given it's something we broke and there are reports in the wild | 14:11 |
| aarents | gibi Ok I will need it for stein, I will backport it to stein if possible | 14:12 |
| gibi | aarents: cool | 14:12 |
| dansmith | I think at some point in the lineage the provider tree stuff will differ enough that it will stop being trivial | 14:14 |
| dansmith | aarents: any chance you'd take an unmerged version of this, apply to one host and let us know how it works for you? | 14:17 |
| dansmith | it would suck to do all this, backport it way back and then find out the small race windows still let too much stuff through | 14:17 |
| aarents | dansmith: yes will try to do it next week | 14:20 |
| dansmith | cool | 14:20 |
| gibi | aarents: I try to add some test to the patch still today | 14:23 |
| aarents | ok | 14:26 |
| *** bnemec is now known as beekneemech | 14:27 | |
| *** kevinz has joined #openstack-nova | 14:29 | |
| *** links has quit IRC | 14:33 | |
| *** dklyle has joined #openstack-nova | 14:41 | |
| *** munimeha1 has joined #openstack-nova | 14:46 | |
| *** ttsiouts has joined #openstack-nova | 14:48 | |
| *** Sundar has quit IRC | 14:48 | |
| jsuchome | dansmith: once you have time ... I addressed your comments in https://review.opendev.org/#/c/574301/ | 14:51 |
| dansmith | yep, in the queue | 14:52 |
| jsuchome | great | 14:52 |
| *** ttsiouts has quit IRC | 14:52 | |
| openstackgerrit | Andreas Jaeger proposed openstack/python-novaclient master: Switch to newer openstackdocstheme and reno versions https://review.opendev.org/728270 | 14:57 |
| dansmith | jsuchome: btw, the spec really needs to be merged before we move too far on the code | 15:00 |
| openstackgerrit | Andreas Jaeger proposed openstack/nova master: Switch to newer openstackdocstheme and reno versions https://review.opendev.org/728263 | 15:02 |
| *** mriedem has joined #openstack-nova | 15:07 | |
| *** udesale_ has quit IRC | 15:10 | |
| *** ratailor has quit IRC | 15:17 | |
| jsuchome | well, I just thought I start with something... nothing I can do with the spec right now | 15:38 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Integrate mypy https://review.opendev.org/676208 | 15:39 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Update and correct typing information https://review.opendev.org/714694 | 15:39 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Add typing information https://review.opendev.org/714695 | 15:39 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Split instance NUMA object tests https://review.opendev.org/714696 | 15:39 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Replace 'cpu_pinning_requested' helper https://review.opendev.org/714697 | 15:39 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Don't consider overhead CPUs for unpinned instances https://review.opendev.org/714698 | 15:39 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Remove handling of pre-Train compute nodes https://review.opendev.org/714699 | 15:39 |
| *** maciejjozefczyk has quit IRC | 15:39 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Add validation for 'cpu_realtime_mask' https://review.opendev.org/468203 | 15:39 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Tweak the 'cpu_realtime_mask' handling slightly https://review.opendev.org/461456 | 15:39 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Rework 'get_realtime_constraint' https://review.opendev.org/714700 | 15:39 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Invert order of NUMA topology generation https://review.opendev.org/714701 | 15:39 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Remove '_numa_fit_instance_cell_with_pinning' https://review.opendev.org/714703 | 15:39 |
| *** dpawlik has quit IRC | 15:41 | |
| *** ociuhandu has quit IRC | 15:47 | |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce 'pcpuset' field for InstanceNUMACell https://review.opendev.org/714658 | 15:57 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce the 'CPUAllocationPolicy.MIXED' enum https://review.opendev.org/716267 | 15:57 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Calculate the CPU usage for mixed instance https://review.opendev.org/716269 | 15:57 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: online data migration for cpuset of dedicated instance https://review.opendev.org/718493 | 15:57 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: libvirt/hardware: refactor numa_get_constraints https://review.opendev.org/718294 | 15:57 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Setup 'mixed' instance through 'PCPU' and 'VCPU' resource https://review.opendev.org/713355 | 15:57 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936 | 15:57 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: notification: add the pcpuset info to instance numa cell payload https://review.opendev.org/728480 | 15:57 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: libvirt: apply mixed instance CPU policy https://review.opendev.org/728481 | 15:57 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: scheduler: mixed instance CPU resource translating https://review.opendev.org/728482 | 15:57 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: flavor: Enable 'hw:cpu_dedicated_mask' for creating a mixed instance https://review.opendev.org/728483 | 15:57 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: compute: bump nova-compute service version for mixed instance https://review.opendev.org/728484 | 15:57 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: create 'mixed' instance for realtime and shared CPUs https://review.opendev.org/728485 | 15:57 |
| *** jaosorior has quit IRC | 16:03 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add '__version__' attribute https://review.opendev.org/728490 | 16:05 |
| *** jmlowe has quit IRC | 16:07 | |
| *** jangutter_ has joined #openstack-nova | 16:07 | |
| *** nweinber has quit IRC | 16:09 | |
| *** jangutter has quit IRC | 16:10 | |
| *** gyee has joined #openstack-nova | 16:13 | |
| openstackgerrit | Andreas Jaeger proposed openstack/nova master: Switch to newer openstackdocstheme and reno versions https://review.opendev.org/728263 | 16:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reserve DISK_GB resource for the image cache https://review.opendev.org/728439 | 16:17 |
| gibi | aarents, dansmith: this time with tests ^^ | 16:18 |
| gibi | and that marks the end of my work week. Have a nice weekend o/ | 16:19 |
| *** nweinber has joined #openstack-nova | 16:23 | |
| *** salmankhan has quit IRC | 16:24 | |
| *** kberger_ has joined #openstack-nova | 16:31 | |
| *** KeithMnemonic has quit IRC | 16:31 | |
| *** kberger_ has quit IRC | 16:32 | |
| *** kberger_ has joined #openstack-nova | 16:32 | |
| *** evrardjp has quit IRC | 16:33 | |
| *** evrardjp has joined #openstack-nova | 16:33 | |
| *** ociuhandu has joined #openstack-nova | 16:36 | |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce 'pcpuset' field for InstanceNUMACell https://review.opendev.org/714658 | 16:40 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: notification: add the pcpuset info to instance numa cell payload https://review.opendev.org/728480 | 16:40 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce the 'CPUAllocationPolicy.MIXED' enum https://review.opendev.org/716267 | 16:40 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: libvirt: apply mixed instance CPU policy https://review.opendev.org/728481 | 16:40 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: computer: validate cpu pinning configuration for mixed instance https://review.opendev.org/716268 | 16:40 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Calculate the CPU usage for mixed instance https://review.opendev.org/716269 | 16:40 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: online data migration for cpuset of dedicated instance https://review.opendev.org/718493 | 16:40 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: scheduler: mixed instance CPU resource translating https://review.opendev.org/728482 | 16:40 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: flavor: Enable 'hw:cpu_dedicated_mask' for creating a mixed instance https://review.opendev.org/714706 | 16:40 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: compute: bump nova-compute service version for mixed instance https://review.opendev.org/716271 | 16:40 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: create 'mixed' instance for realtime and shared CPUs https://review.opendev.org/728485 | 16:40 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: libvirt/hardware: refactor numa_get_constraints https://review.opendev.org/718294 | 16:40 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Setup 'mixed' instance through 'PCPU' and 'VCPU' resource https://review.opendev.org/713355 | 16:40 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936 | 16:40 |
| *** ociuhandu has quit IRC | 16:41 | |
| *** ociuhandu has joined #openstack-nova | 16:42 | |
| *** derekh has quit IRC | 16:47 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Add emulated TPM support to Nova https://review.opendev.org/631363 | 16:49 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934 | 16:49 |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Encrypted Emulated Virtual TPM https://review.opendev.org/728505 | 16:56 |
| *** jangutter_ has quit IRC | 16:58 | |
| *** psachin has quit IRC | 17:02 | |
| *** mlavalle has quit IRC | 17:05 | |
| *** mlavalle has joined #openstack-nova | 17:06 | |
| *** dtantsur is now known as dtantsur|afk | 17:08 | |
| *** rpittau is now known as rpittau|afk | 17:11 | |
| *** nightmare_unreal has quit IRC | 17:18 | |
| *** tesseract has quit IRC | 17:21 | |
| *** ociuhandu has quit IRC | 17:30 | |
| *** ociuhandu has joined #openstack-nova | 17:32 | |
| *** avolkov has quit IRC | 17:39 | |
| *** ociuhandu has quit IRC | 17:42 | |
| *** ociuhandu has joined #openstack-nova | 17:44 | |
| *** ociuhandu has quit IRC | 17:54 | |
| *** ociuhandu has joined #openstack-nova | 17:54 | |
| *** ociuhandu has quit IRC | 17:55 | |
| *** ociuhandu has joined #openstack-nova | 17:55 | |
| *** ralonsoh has quit IRC | 17:55 | |
| *** ociuhandu has quit IRC | 18:05 | |
| *** ociuhandu has joined #openstack-nova | 18:06 | |
| *** ociuhandu has quit IRC | 18:06 | |
| *** ociuhandu has joined #openstack-nova | 18:06 | |
| *** slaweq has quit IRC | 18:12 | |
| *** ociuhandu has quit IRC | 18:16 | |
| *** ociuhandu has joined #openstack-nova | 18:17 | |
| *** slaweq has joined #openstack-nova | 18:23 | |
| *** jsuchome has quit IRC | 18:27 | |
| *** slaweq has quit IRC | 18:28 | |
| *** nweinber has quit IRC | 18:33 | |
| *** iurygregory has quit IRC | 18:35 | |
| *** iurygregory has joined #openstack-nova | 18:38 | |
| *** slaweq has joined #openstack-nova | 18:38 | |
| mnaser | hmm | 18:42 |
| mnaser | i have a query that's absolutely destroying my db server and it seems pretty silly looking at it | 18:42 |
| mnaser | https://www.irccloud.com/pastebin/RZ58u5w0/ | 18:42 |
| *** slaweq has quit IRC | 18:43 | |
| mnaser | i literally have 2 cells inside cell_mappings, yet im having to scan all of the instance mappings | 18:43 |
| mnaser | explain in my case shows scanning 1.2m rows. yes, we could use an archive, but.. | 18:44 |
| mnaser | https://www.irccloud.com/pastebin/vmPO2rNN/ | 18:44 |
| *** iurygregory has quit IRC | 18:45 | |
| mnaser | it sounds like this is the root: https://github.com/openstack/nova/blob/master/nova/objects/cell_mapping.py#L275-L285 | 18:45 |
| mnaser | which i guess comes from https://github.com/openstack/nova/blob/master/nova/compute/instance_list.py#L150-L153 | 18:46 |
| *** icarusfactor has quit IRC | 18:47 | |
| mnaser | which leads to more interesting things. instance_mappings seem to be not soft deleted yet i have 2586748 records... | 18:52 |
| *** nweinber has joined #openstack-nova | 18:53 | |
| *** ociuhandu has quit IRC | 18:57 | |
| *** ociuhandu has joined #openstack-nova | 18:58 | |
| *** ociuhandu has quit IRC | 18:59 | |
| *** ociuhandu has joined #openstack-nova | 18:59 | |
| *** ociuhandu has quit IRC | 19:10 | |
| *** ociuhandu has joined #openstack-nova | 19:12 | |
| *** ociuhandu has quit IRC | 19:17 | |
| *** JamesBenson has quit IRC | 19:18 | |
| dansmith | mnaser: instance mappings are not soft deleted, | 19:23 |
| dansmith | and are only ever removed when you archive | 19:23 |
| mnaser | dansmith: ah. i'll try and add archive to happen more often because i think teh annoying thing is once a cloud grows big enough, the archive really hurt in terms of performance | 19:24 |
| dansmith | yeah, it's not a very lightweight thing | 19:25 |
| dansmith | mnaser: I guess we need to filter that instance mappings query by deleted eh? | 19:25 |
| dansmith | er, no we can't | 19:25 |
| dansmith | duh | 19:25 |
| mnaser | yeah :( | 19:25 |
| mnaser | i mean there's the queued_for_delete, i saw a lot of records with that | 19:26 |
| dansmith | you'd think it would be pretty fast though | 19:26 |
| dansmith | becase it's just distinct cell_id, and then filtered by project | 19:26 |
| dansmith | maybe we're missing an index | 19:26 |
| mnaser | the select distinct is def what hurts, im trying to run it manually and see how long it takes.. | 19:27 |
| mnaser | 16.02 seconds | 19:27 |
| dansmith | there is an index on project_id, but not on cell_id | 19:27 |
| dansmith | so maybe that is making the distinct take a long time? | 19:27 |
| mnaser | dansmith: i think the other problem is that t his code is also used for quota checks, so thats ~16s per *single* request to boot an instance | 19:27 |
| mnaser | when we'd see a big surge of instance creations, that's 16s*20 or so and it starts getting worse | 19:28 |
| mnaser | specifically here https://github.com/openstack/nova/blob/575a91ff5be79ac35aef4b61d84c78c693693304/nova/quota.py#L1194-L1195 | 19:28 |
| dansmith | apparently mysql always indexes foreign key columns, so cell_id should be indexed | 19:28 |
| mnaser | https://www.irccloud.com/pastebin/MftvYe3g/ | 19:29 |
| mnaser | thats the EXPLAIN | 19:29 |
| dansmith | mnaser: you specifically have the subset conf turned on, is that intentional? | 19:29 |
| mnaser | dansmith: sorry, nto following, subset conf? | 19:29 |
| dansmith | mnaser: see the comment just above the code in instance_list ? | 19:30 |
| dansmith | query_cell_subset = CONF.api.instance_list_per_project_cells | 19:30 |
| dansmith | if that is off then it won't do this | 19:30 |
| dansmith | defaults to false | 19:31 |
| dansmith | heh, the conf text (written by me I'm sure) says turning that on "causes one more (fast) query to the API database" | 19:31 |
| mnaser | heh, let me check if its enabled | 19:31 |
| dansmith | maybe I should edit that comment or say "assuming you're archiving regularly" :) | 19:31 |
| mnaser | instance_list_per_project_cells is not set to anything so its probably set to default False | 19:32 |
| dansmith | mnaser: okay well you see the code, not sure how you could be runningthat | 19:32 |
| mnaser | dansmith: https://github.com/openstack/nova/blob/575a91ff5be79ac35aef4b61d84c78c693693304/nova/quota.py#L1194-L1195 ? | 19:32 |
| mnaser | that doesnt seem to respect it | 19:32 |
| dansmith | mnaser: no, the instance list one | 19:33 |
| dansmith | maybe you're not actually hitting the instance_list code, just the quota one? | 19:33 |
| mnaser | dansmith: yes, sorry, should have clarified, i think that's the running theory | 19:33 |
| dansmith | okay I thought you assumed both | 19:33 |
| dansmith | I wrote instance_list so was focusing there | 19:33 |
| mnaser | i'm looking at logs and os_volume-boot is taking some ~45-60s-ish to respond | 19:33 |
| mnaser | yeah, initially that was my two findings, but i agree, it seems quota code might be what is hurting | 19:33 |
| dansmith | gotcha | 19:34 |
| dansmith | melwitt: ^ | 19:34 |
| dansmith | mnaser: maybe we could make the quota code check that same conf, as for <=1 real cell, it's probably quicker not to do the query anywa | 19:34 |
| mnaser | dansmith: yes, given we want to backport though, i'd be tempted to actually change get_by_project_id behaviour to respect that config value so its not possible for someone to miss it later | 19:35 |
| dansmith | no, we definitely don't want that | 19:35 |
| mnaser | (for the future, but backport just fixing the behaviour in quota.py) | 19:35 |
| mnaser | im sure there's details im missing why its not a good idea :) | 19:36 |
| dansmith | if a caller is looking for a set of instance mappings, you want it to get what it asked for, not altered by some random config flag | 19:36 |
| mnaser | yep makes sense | 19:37 |
| mnaser | the patch to fix this seems trivial, so ill push something up | 19:38 |
| dansmith | that's a very low-level database query routine.. the "should we optimize for lots of cells or not" is a very high-level decision | 19:38 |
| dansmith | mnaser: cool, add me and melwitt, but the latter is the important review I thnk | 19:38 |
| mnaser | dansmith: will do. i'll write up a bug right now too | 19:39 |
| dansmith | thanks | 19:40 |
| mnaser | dansmith: i could also workaronud this by enabling quota from placement, but yeah | 19:40 |
| mnaser | let's get it fixed | 19:40 |
| dansmith | mnaser: you could also archive your damned database now and then :D | 19:40 |
| mnaser | dansmith: haha, always me bringing up those massive db issues :p | 19:40 |
| dansmith | I guess the benefit of not archiving is giving us some data on these things, so ... your choice :D | 19:40 |
| *** jamesdenton has quit IRC | 19:41 | |
| *** jamesden_ has joined #openstack-nova | 19:41 | |
| *** nweinber has quit IRC | 19:45 | |
| *** kberger_ has quit IRC | 19:48 | |
| *** KeithMnemonic has joined #openstack-nova | 19:48 | |
| mnaser | it's friday and i did a bad job at writing this probably: https://bugs.launchpad.net/nova/+bug/1878979 | 19:53 |
| openstack | Launchpad bug 1878979 in OpenStack Compute (nova) "Quota code does not respect [api]/instance_list_per_project_cells" [Undecided,New] | 19:53 |
| *** jamesden_ has quit IRC | 19:53 | |
| *** jamesdenton has joined #openstack-nova | 19:53 | |
| *** jamesdenton has quit IRC | 19:59 | |
| *** jamesden_ has joined #openstack-nova | 19:59 | |
| *** jamesden_ has quit IRC | 20:08 | |
| mriedem | mnaser: related https://bugs.launchpad.net/nova/+bug/1857306 | 20:08 |
| openstack | Launchpad bug 1857306 in OpenStack Compute (nova) "_bury_in_cell0 could not handle instance duplicate exception" [Low,Triaged] | 20:08 |
| mriedem | wait a minute, that's not right | 20:09 |
| mriedem | https://review.opendev.org/#/c/700456/ | 20:09 |
| *** jamesdenton has joined #openstack-nova | 20:10 | |
| mnaser | mriedem: ehhhh, that's a lot to think about for friday :( | 20:12 |
| *** jamesden_ has joined #openstack-nova | 20:13 | |
| mriedem | you're stuck inside, what else do you have to do | 20:13 |
| *** jamesdenton has quit IRC | 20:15 | |
| *** jamesdenton has joined #openstack-nova | 20:21 | |
| *** jamesden_ has quit IRC | 20:23 | |
| mnaser | welp, _instances_cores_ram_count_legacy has zero tests | 20:37 |
| *** jamesdenton has quit IRC | 20:38 | |
| *** iurygregory has joined #openstack-nova | 20:42 | |
| *** ociuhandu has joined #openstack-nova | 20:44 | |
| *** ccamacho has quit IRC | 20:45 | |
| mriedem | i think those are covered with functional tests | 20:47 |
| mriedem | depending on if the placement flag is configured to use placement for quota or not | 20:47 |
| mnaser | mriedem: yeah i found some unit test ones but they mostly mock that function out | 20:47 |
| mriedem | yeah it's functional tests i'm pretty sure | 20:47 |
| mriedem | more reliable for those kind of tests hitting the dbs | 20:47 |
| mnaser | mriedem: ok thanks ill go dig there | 20:47 |
| mnaser | mriedem: my test is mostly "if flag X is enabled then make sure you call with all cells otherwise make sure you retrieve list of cells | 20:48 |
| *** ociuhandu has quit IRC | 20:49 | |
| openstackgerrit | Mohammed Naser proposed openstack/nova master: WIP: Make quotas respect instance_list_per_project_cells https://review.opendev.org/728575 | 20:49 |
| mnaser | mriedem: ^ for context | 20:49 |
| mnaser | yeah that code is broken now that i look at it again | 20:49 |
| mnaser | ah no nvm, python lets vars defined in if get accessed outside | 20:50 |
| openstackgerrit | Lin Yang proposed openstack/os-traits master: CPU: add traits for new AVX512 support https://review.opendev.org/728576 | 20:52 |
| *** munimeha1 has quit IRC | 21:06 | |
| *** raildo_ has joined #openstack-nova | 21:06 | |
| *** raildo has quit IRC | 21:08 | |
| openstackgerrit | Lin Yang proposed openstack/os-traits master: CPU: add traits for new AVX512 support https://review.opendev.org/728576 | 21:15 |
| *** martinkennelly has quit IRC | 21:21 | |
| openstackgerrit | Mohammed Naser proposed openstack/nova master: Make quotas respect instance_list_per_project_cells https://review.opendev.org/728575 | 21:24 |
| mnaser | dansmith, melwitt: ^ cooked up and tested locally :) thanks for the hints | 21:24 |
| openstackgerrit | Gage Hugo proposed openstack/nova stable/stein: [DNM] - testing numa placement https://review.opendev.org/728579 | 21:28 |
| *** ociuhandu has joined #openstack-nova | 21:32 | |
| *** ociuhandu has quit IRC | 21:40 | |
| *** tbachman has quit IRC | 21:40 | |
| *** bauwser is now known as bauzas | 21:41 | |
| *** KeithMnemonic has quit IRC | 21:47 | |
| *** JamesBenson has joined #openstack-nova | 21:49 | |
| *** raildo_ has quit IRC | 21:57 | |
| melwitt | mnaser: here's the func test for cores ram count https://github.com/openstack/nova/blob/master/nova/tests/functional/db/test_quota.py#L142 | 22:32 |
| melwitt | oh you found it. nevermind | 22:33 |
| mnaser | melwitt: :D | 22:35 |
| mnaser | I tried to make it as backportable as possible | 22:36 |
| melwitt | good call. this doesn't look too bad at all, so thank you for that | 22:37 |
| melwitt | mnaser: I assume you tried out this patch? what was the perf result, just curious | 22:38 |
| ikla | I'm trying to get pci_passthrough to work and followed the documents. I keep seeing Pci claimed failed. Anyway to drill this down. Config looks perfect. | 22:39 |
| mnaser | melwitt: I have not yet actually! It’s Friday and the load dropped so it wasn’t hitting as hard | 22:40 |
| mnaser | I can try on Monday though but I imagine it’ll drop scanning instance mappings and I only have 2 cells really (0 and 1) | 22:41 |
| melwitt | mnaser: I guess, this seems like the opposite of what you wrote in the bug report. it's always limiting to project_id and you're adding some that would look at all cells? | 22:41 |
| *** mgariepy has quit IRC | 22:42 | |
| mnaser | melwitt: sorry I’ve been pretty slow today. But yes before it was limited to project ID and this just doesn’t limit and checks all cells anywyas | 22:42 |
| melwitt | like before your patch it's always only looking at a particular project_id and quota check is always scoped to a project, so there's no need to look at all cells | 22:42 |
| melwitt | mnaser: if that's the case, that would mean there's a bug in objects.CellMappingList.get_by_project_id if it's not actually scoping down to a project | 22:43 |
| mnaser | melwitt: that function does actually scope by project. The only problem is that to do that, it needs to scan all instance mappings to find all cells for that project which is where I took the performance hit | 22:44 |
| mnaser | After my patch, nova checks all cells, regardless if a user has instances in it or not | 22:44 |
| melwitt | and no worry, I've been slow today too. spent all day/night yesterday dealing with fallout from a nova gate breakage and trying to get it fixed. so exhausted | 22:45 |
| mnaser | Sorry if my commit message or bug aren’t clear, I’m just feeling bleeeh and dazed all day lol | 22:45 |
| melwitt | mnaser: sorry this just doesn't seem to make sense. before your patch, it's always limiting to one project cells. after you patch, it's capable of not limiting. I don't see how that would help with any instance mapping scanning? | 22:47 |
| melwitt | oh hang on | 22:48 |
| mnaser | melwitt: I think we may be talking about two scans. One for the quota calculation and one to find which cells the user has instances in | 22:49 |
| melwitt | ok so you're saying when you can look at all cells, you actually go _faster_ because you don't do the instance mapping thing? wow ok | 22:49 |
| melwitt | yeah ok it's a tradeoff, slowly remembering now | 22:49 |
| mnaser | melwitt: https://github.com/openstack/nova/blob/master/nova/objects/cell_mapping.py#L275-L285 | 22:49 |
| melwitt | the project limiting behavior is actually worse for single cell-ers | 22:49 |
| melwitt | yeah, I see now | 22:50 |
| melwitt | sorry | 22:50 |
| mnaser | All good! Yeah, it hurt me more in this case | 22:50 |
| melwitt | yeah, I see | 22:50 |
| melwitt | nice catch | 22:50 |
| mnaser | not the catch I wanted on a Friday but it is what it is :P | 22:50 |
| melwitt | haha right | 22:50 |
| melwitt | ok, I'll review this properly a bit later. thanks for opening the bug and doing the patch | 22:51 |
| mnaser | No worries | 22:55 |
| ikla | Timed out waiting for nova-conductor. Is it running? Or did this service start before nova-conductor? | 23:05 |
| ikla | any ideas? | 23:05 |
| ikla | or normal | 23:06 |
| openstackgerrit | Merged openstack/nova master: docs: Add evacuation pre-conditions around the src host https://review.opendev.org/723853 | 23:07 |
| melwitt | ikla: nova-conductor is a required piece of nova, it needs to be running so if it isn't, that would be a problem | 23:10 |
| *** JamesBenson has quit IRC | 23:23 | |
| *** mlavalle has quit IRC | 23:31 | |
| openstackgerrit | Merged openstack/nova master: Reproduce bug 1869050 https://review.opendev.org/714997 | 23:31 |
| openstack | bug 1869050 in OpenStack Compute (nova) "migration of anti-affinity server fails due to stale scheduler instance info" [Low,In progress] https://launchpad.net/bugs/1869050 - Assigned to Balazs Gibizer (balazs-gibizer) | 23:31 |
| ikla | Insufficient compute resources: Claim pci failed. - is there anyway to see why it failed? | 23:32 |
| *** tosky has quit IRC | 23:39 | |
| *** mriedem has left #openstack-nova | 23:45 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!