| tony_su | gibi: Thanks for your review. I have changed 'Feature liasison' person from efried to gibi and uploaded the new patch 3. https://review.opendev.org/#/c/725788 | 00:06 |
|---|---|---|
| *** grandchild has quit IRC | 00:15 | |
| *** tetsuro has joined #openstack-nova | 00:30 | |
| *** amodi has quit IRC | 00:30 | |
| *** brinzhang has joined #openstack-nova | 00:36 | |
| *** ociuhandu has joined #openstack-nova | 00:36 | |
| *** tetsuro_ has joined #openstack-nova | 00:40 | |
| *** tetsuro has quit IRC | 00:43 | |
| *** ociuhandu has quit IRC | 00:44 | |
| *** Liang__ has joined #openstack-nova | 00:59 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/os-resource-classes master: Fix hacking min version to 3.0.1 https://review.opendev.org/727557 | 01:21 |
| openstackgerrit | Ghanshyam Mann proposed openstack/os-traits master: Fix hacking min version to 3.0.1 https://review.opendev.org/727559 | 01:21 |
| *** sapd1 has joined #openstack-nova | 01:31 | |
| openstackgerrit | Wenping Song proposed openstack/nova master: delete sub resource provider when delete resource provider https://review.opendev.org/727560 | 01:31 |
| *** redrobot has quit IRC | 01:34 | |
| *** brinzhang_ has joined #openstack-nova | 01:35 | |
| *** brinzhang has quit IRC | 01:39 | |
| *** brinzhang_ has quit IRC | 01:41 | |
| *** brinzhang_ has joined #openstack-nova | 01:41 | |
| *** tetsuro has joined #openstack-nova | 01:44 | |
| *** tetsuro_ has quit IRC | 01:47 | |
| *** lbragstad_ is now known as lbragstad | 01:52 | |
| *** sapd1_x has joined #openstack-nova | 02:04 | |
| *** awalende has joined #openstack-nova | 02:07 | |
| *** tetsuro_ has joined #openstack-nova | 02:12 | |
| *** awalende has quit IRC | 02:12 | |
| *** tetsuro has quit IRC | 02:15 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Fix flake8 error from hacking <3.0.1x https://review.opendev.org/727589 | 02:22 |
| openstackgerrit | Merged openstack/python-novaclient master: Bump hacking min version to 3.0.1 https://review.opendev.org/727214 | 02:24 |
| openstackgerrit | Wenping Song proposed openstack/nova master: delete sub resource provider when delete resource provider https://review.opendev.org/719163 | 02:27 |
| openstackgerrit | Wenping Song proposed openstack/nova master: delete sub resource provider when delete resource provider https://review.opendev.org/727560 | 02:27 |
| *** kevinz has joined #openstack-nova | 02:35 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Fix flake8 error from hacking <3.0.1 https://review.opendev.org/727589 | 02:36 |
| openstackgerrit | Wenping Song proposed openstack/nova master: delete sub resource provider when delete resource provider https://review.opendev.org/719163 | 02:59 |
| *** tetsuro has joined #openstack-nova | 03:06 | |
| *** tetsuro_ has quit IRC | 03:09 | |
| *** lbragstad has quit IRC | 03:18 | |
| *** gyee has quit IRC | 03:18 | |
| *** dustinc has quit IRC | 03:34 | |
| *** psachin has joined #openstack-nova | 03:37 | |
| *** tetsuro_ has joined #openstack-nova | 04:06 | |
| *** tetsuro has quit IRC | 04:09 | |
| *** ratailor has joined #openstack-nova | 04:09 | |
| *** evrardjp has quit IRC | 04:36 | |
| *** evrardjp has joined #openstack-nova | 04:36 | |
| *** ociuhandu has joined #openstack-nova | 04:42 | |
| *** ociuhandu has quit IRC | 04:49 | |
| *** psachin has quit IRC | 04:56 | |
| *** mtreinish has quit IRC | 05:01 | |
| *** dklyle has quit IRC | 05:01 | |
| *** dpawlik has quit IRC | 05:04 | |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: tox: Integrate mypy https://review.opendev.org/676208 | 05:14 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Update and correct typing information https://review.opendev.org/714694 | 05:14 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: libvirt: Add typing information https://review.opendev.org/714695 | 05:14 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: tests: Split instance NUMA object tests https://review.opendev.org/714696 | 05:14 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: objects: Replace 'cpu_pinning_requested' helper https://review.opendev.org/714697 | 05:14 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Don't consider overhead CPUs for unpinned instances https://review.opendev.org/714698 | 05:14 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Remove handling of pre-Train compute nodes https://review.opendev.org/714699 | 05:14 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Add validation for 'cpu_realtime_mask' https://review.opendev.org/468203 | 05:14 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Tweak the 'cpu_realtime_mask' handling slightly https://review.opendev.org/461456 | 05:14 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Rework 'get_realtime_constraint' https://review.opendev.org/714700 | 05:14 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Invert order of NUMA topology generation https://review.opendev.org/714701 | 05:14 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Remove '_numa_fit_instance_cell_with_pinning' https://review.opendev.org/714703 | 05:14 |
| *** mtreinish has joined #openstack-nova | 05:34 | |
| *** links has joined #openstack-nova | 05:34 | |
| *** udesale has joined #openstack-nova | 05:36 | |
| *** tetsuro has joined #openstack-nova | 05:43 | |
| *** tetsuro_ has quit IRC | 05:47 | |
| *** awalende has joined #openstack-nova | 06:00 | |
| *** ccamacho has joined #openstack-nova | 06:00 | |
| *** awalende has quit IRC | 06:04 | |
| openstackgerrit | Liang Fang proposed openstack/nova master: [WIP] rbd patch for volume local cache https://review.opendev.org/726762 | 06:07 |
| openstackgerrit | Wenping Song proposed openstack/nova master: delete sub resource provider when delete resource provider https://review.opendev.org/719163 | 06:12 |
| *** tetsuro_ has joined #openstack-nova | 06:23 | |
| *** nightmare_unreal has joined #openstack-nova | 06:23 | |
| *** belmoreira has joined #openstack-nova | 06:25 | |
| *** dpawlik has joined #openstack-nova | 06:25 | |
| *** tetsuro has quit IRC | 06:26 | |
| *** xek_ has joined #openstack-nova | 06:26 | |
| *** xek has quit IRC | 06:29 | |
| *** tetsuro has joined #openstack-nova | 06:29 | |
| *** ociuhandu has joined #openstack-nova | 06:30 | |
| *** ttsiouts has joined #openstack-nova | 06:30 | |
| *** tetsuro_ has quit IRC | 06:32 | |
| *** efried has quit IRC | 06:33 | |
| *** links has quit IRC | 06:37 | |
| *** ttsiouts has quit IRC | 06:39 | |
| *** links has joined #openstack-nova | 06:40 | |
| *** ttsiouts has joined #openstack-nova | 06:41 | |
| *** lpetrut has joined #openstack-nova | 06:42 | |
| *** slaweq has joined #openstack-nova | 06:51 | |
| *** tony_su has quit IRC | 06:53 | |
| openstackgerrit | Jiri Suchomel proposed openstack/nova-specs master: Add spec for downloading images via RBD https://review.opendev.org/572805 | 06:57 |
| *** jsuchome has joined #openstack-nova | 06:59 | |
| *** tesseract has joined #openstack-nova | 07:02 | |
| *** vishalmanchanda has joined #openstack-nova | 07:03 | |
| openstackgerrit | Merged openstack/nova master: Moving functional jobs to Victoria testing runtime https://review.opendev.org/725372 | 07:13 |
| openstackgerrit | melanie witt proposed openstack/nova master: DNM Try out running sphinx-build in parallel for releasenotes https://review.opendev.org/727429 | 07:22 |
| *** tetsuro_ has joined #openstack-nova | 07:24 | |
| *** damien_r has joined #openstack-nova | 07:25 | |
| *** tetsuro has quit IRC | 07:27 | |
| bauzas | good morning Nova | 07:27 |
| *** ociuhandu has quit IRC | 07:27 | |
| *** ociuhandu_ has joined #openstack-nova | 07:27 | |
| *** xek__ has joined #openstack-nova | 07:28 | |
| gibi | good morning | 07:28 |
| *** rpittau|afk is now known as rpittau | 07:29 | |
| *** ralonsoh has joined #openstack-nova | 07:29 | |
| *** xek_ has quit IRC | 07:30 | |
| *** tosky has joined #openstack-nova | 07:35 | |
| *** tony_ has joined #openstack-nova | 07:38 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:38 | |
| *** tony_ is now known as tony_su | 07:38 | |
| *** awalende has joined #openstack-nova | 07:39 | |
| tony_su | c | 07:51 |
| tony_su | clear | 07:52 |
| tony_su | exit | 07:52 |
| tony_su | exit | 07:52 |
| gibi | tony_su: thanks for the spec update, I have +2d it | 07:52 |
| tony_su | gibi: got it and will go to next step. Thanks gibi. | 07:58 |
| *** tony_su has quit IRC | 07:59 | |
| *** tesseract has quit IRC | 08:05 | |
| *** tesseract has joined #openstack-nova | 08:06 | |
| *** tony_ has joined #openstack-nova | 08:09 | |
| *** tony_ is now known as tony_su | 08:10 | |
| *** martinkennelly has joined #openstack-nova | 08:22 | |
| gibi | sean-k-mooney, dansmith: read back your discussion about the pre-filter. Good idea. Would that be backportable solution? | 08:29 |
| gibi | sean-k-mooney, dansmith: also I replied in the patch https://review.opendev.org/#/c/727261 and will continue investigating turning off the cache today | 08:30 |
| *** salmankhan has joined #openstack-nova | 08:30 | |
| *** xiaolin has quit IRC | 08:31 | |
| *** ttsiouts has quit IRC | 08:34 | |
| brinzhang_ | gibi: this re-propose spec comes from U release https://review.opendev.org/#/c/719720/, hope you can review again | 08:37 |
| openstackgerrit | Nalini Varshney proposed openstack/nova master: Add migration to make key field type VARBINARY in aggregate_metadata table, https://review.opendev.org/725522 | 08:40 |
| openstackgerrit | sean mooney proposed openstack/nova master: Delete ARQs by UUID if Cyborg ARQ bind fails. https://review.opendev.org/716186 | 08:43 |
| *** xiaolin has joined #openstack-nova | 08:45 | |
| *** tetsuro_ has quit IRC | 08:47 | |
| *** ttsiouts has joined #openstack-nova | 08:53 | |
| *** salmankhan1 has joined #openstack-nova | 08:57 | |
| *** salmankhan has quit IRC | 08:59 | |
| *** salmankhan1 is now known as salmankhan | 08:59 | |
| sean-k-mooney | gibi: we only have prefilters back to rocky | 08:59 |
| sean-k-mooney | gibi: i guess we could backport it that far back. | 08:59 |
| sean-k-mooney | normlaly i a prefilter would be a feature but in this case its a bug so if the stable team is ok with it maybe | 09:00 |
| sean-k-mooney | gibi: the prefilter would result in us over allocating the storage so we also need to srink the allocation on the compute node | 09:03 |
| sean-k-mooney | that said we still need to be careful for rolling updates | 09:07 |
| *** tetsuro has joined #openstack-nova | 09:07 | |
| *** xiaolin has quit IRC | 09:10 | |
| *** dtantsur|afk is now known as dtantsur | 09:13 | |
| openstackgerrit | sean mooney proposed openstack/nova master: Delete ARQs by UUID if Cyborg ARQ bind fails. https://review.opendev.org/716186 | 09:20 |
| *** tetsuro has quit IRC | 09:23 | |
| *** avolkov has joined #openstack-nova | 09:27 | |
| *** jraju__ has joined #openstack-nova | 09:27 | |
| *** links has quit IRC | 09:28 | |
| *** Liang__ has quit IRC | 09:32 | |
| *** links has joined #openstack-nova | 09:47 | |
| *** jraju__ has quit IRC | 09:47 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Add functional test for bug 1550919 https://review.opendev.org/631294 | 10:00 |
| openstack | bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Lee Yarwood (lyarwood) | 10:00 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/578846 | 10:00 |
| lyarwood | stephenfin: ^ blast from the past, you were pretty happy with this a while ago if you have anytime today to take another look? | 10:01 |
| *** ociuhandu_ has quit IRC | 10:01 | |
| stephenfin | Sure. I've my head stuck into something rn though so it might be tomorrow | 10:01 |
| *** ociuhandu has joined #openstack-nova | 10:02 | |
| lyarwood | ack np | 10:02 |
| *** derekh has joined #openstack-nova | 10:20 | |
| *** dpawlik has quit IRC | 10:21 | |
| *** hrw has quit IRC | 10:28 | |
| openstackgerrit | sean mooney proposed openstack/nova master: Delete ARQs by UUID if Cyborg ARQ bind fails. https://review.opendev.org/716186 | 10:34 |
| openstackgerrit | sean mooney proposed openstack/nova master: cyborg evacuate support https://review.opendev.org/715326 | 10:34 |
| *** udesale_ has joined #openstack-nova | 10:36 | |
| *** udesale has quit IRC | 10:38 | |
| sean-k-mooney | gibi: procedual question for you. do i need to file a spec for ^ or a blueprint? | 10:46 |
| sean-k-mooney | gibi: the first patch is clearly a bug but i likely wont have time to complete all the other move operation for cyborg this cycle at least not unless we finish the numa in placment work before m1 or m2 | 10:47 |
| sean-k-mooney | gibi: so i would like to get rebuild/evacuate merged but not sure ill get much more done in the near term | 10:47 |
| sean-k-mooney | would you be oke tracking rebuild/evacuate via a bug or speclesss blueprint? | 10:48 |
| gibi | sean-k-mooney: re: image cache, I will keep the pre-filter impl independent from the disable cache impl so we can decide about the backport independently | 10:49 |
| sean-k-mooney | gibi: ya i think that makes sense | 10:50 |
| sean-k-mooney | gibi: the disable config option is much simpler to backport but is really just a workaround | 10:50 |
| gibi | sean-k-mooney: about cyborg + evac I think at least a bp is needed for tracking | 10:50 |
| sean-k-mooney | gibi: ok ill file one so | 10:50 |
| sean-k-mooney | for the provider.yaml work im going to copy paste the spec form last cycle and repopose it | 10:51 |
| gibi | sean-k-mooney: provider yaml was re-proposed already | 10:51 |
| sean-k-mooney | oh ok cool | 10:51 |
| gibi | https://review.opendev.org/#/c/725788/ | 10:51 |
| gibi | I think tony_su from intel is willing to take it over | 10:52 |
| sean-k-mooney | ok cool. the only feedback that was pending was consolidating the negitive test into a yaml file or the posityve into python so they are consistnet | 10:53 |
| sean-k-mooney | if they can take it over then cool i can spend a little time working on it this cycle if it merges early i.e. if we can get it dont before m1 | 10:53 |
| gibi | OK | 10:56 |
| *** songwenping_ has joined #openstack-nova | 11:00 | |
| *** songwenping__ has quit IRC | 11:03 | |
| *** rpittau is now known as rpittau|bbl | 11:04 | |
| gibi | sean-k-mooney: also it would be nice to check brinzhang_ and the cyborg team about supporting other server operations with cyborg in V. I assume they would like to continue that work so you can join forces | 11:06 |
| brinzhang_ | gibi, sean-k-mooney: if you have some idea that you can add that in https://etherpad.opendev.org/p/cyborg-victoria-goals, that will be discuss in PTG | 11:08 |
| sean-k-mooney | gibi: ya maybe. honestly i dont think its that much work to make it work. its a littel non tivaial but it can be done iteritivly | 11:08 |
| gibi | sean-k-mooney: sure, I'm not talking about evac specially, but all the missing / unsupported server operation in general. | 11:09 |
| sean-k-mooney | brinzhang_: well it was more just completeing the list here https://review.opendev.org/#/c/715326/10/api-guide/source/accelerator-support.rst | 11:09 |
| huaqiang | hi, I have a question I wonder if anyone can give me some comment or deliver a conclusion directly. Does it tolerate to loose some information in a process of 'versioned_object.obj_to_primitive'? especially generating a primitive dict in a lower version number. | 11:09 |
| sean-k-mooney | everything except for live migrate should be doable | 11:10 |
| sean-k-mooney | gibi: ya i was originally planning to submit a patch for each of them im unst unlikely to have time to do that this cycle. that said i might work on it on and off this cycle. | 11:11 |
| brinzhang_ | sean-k-mooney, gibi: yeah, in accelerator-support.rst marked unsuport all need to be consider to support, as sean-k-mooney said except for live migrate | 11:11 |
| sean-k-mooney | brinzhang_: suspend/resume and shelve/unshelve should be fairly simple to do | 11:12 |
| gibi | brinzhang_: do you or the cyborg team will have bandwidth during V to work on adding support for the missing operations? | 11:12 |
| sean-k-mooney | resize/coldmigreate needs a little more work but they are effectvly the same operation | 11:12 |
| brinzhang_ | sean-k-mooney: got it ^ | 11:13 |
| gibi | huaqiang: if you generate a lower version dict then you need to drop the fields that was not present in that lower version. So that is a necessary loss of information. Other than that I think we tend to keep the information. I think dansmith is the best person to ask | 11:14 |
| brinzhang_ | gibi: yes, we will, during V we will open block operation asap, but we should talked in PTG, | 11:14 |
| gibi | brinzhang_: OK. Thanks. I just wanted to make sure that you and sean-k-mooney are in sync about who does what in V | 11:15 |
| sean-k-mooney | brinzhang_: there should not be any gaps in cyborg by the way for the remaining ops | 11:16 |
| sean-k-mooney | its all jus nova work | 11:16 |
| gibi | brinzhang_: checked https://review.opendev.org/#/c/719720/ and I left one comment about the password length | 11:17 |
| sean-k-mooney | suspend/resume just need to be exteded to hot unplug the acclerator on suspend and hot plug them on resume like we do for normla pci passtough or sriov devices | 11:17 |
| brinzhang_ | gibi: I follow sean-k-mooney, many operation may I cannt test, because of limit the hard device | 11:17 |
| gibi | brinzhang_: I hope we can add functional test cases for most of it. | 11:17 |
| sean-k-mooney | sheleve need to delete the arq binding in shelve offload and it need to claim(in placmemnt) the acclerateor and bind arques on unshelve | 11:17 |
| sean-k-mooney | gibi: we can test most of it with the fake dirver too | 11:18 |
| gibi | cool | 11:18 |
| sean-k-mooney | we might want to add some extra logging in placese to be extra sure or enhance it slightly so we have something observable | 11:19 |
| brinzhang_ | sean-k-mooney: cool, thanks, I will try to test that scenario | 11:19 |
| sean-k-mooney | e.g. adding or remvoing an xml comment for example instead of doing nothing so we can se the fake device "added" or "removed" | 11:20 |
| brinzhang_ | sean-k-mooney: I add your said in my list, I will check these thing, e.g. log, and suspend/resume or shelve/unshelve | 11:22 |
| *** ociuhandu has quit IRC | 11:23 | |
| gibi | lyarwood: hi! I see a lot of rescue failure in the lvm job http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22cannot%20be%20rescued%5C%22 is it a known issue? | 11:25 |
| huaqiang | gibi: Got. so the 'obj_to_primitive' offers the capability to run, but not with the full object function. | 11:25 |
| sean-k-mooney | huaqiang: its not that it does not have full fucntion | 11:25 |
| sean-k-mooney | its more that any feature that depends on data only contained in a later version cannot be used | 11:26 |
| sean-k-mooney | huaqiang: when you are backleveling object you baseically are restited to the feature set of the oldest code base invovled in the rpc | 11:27 |
| huaqiang | I am think my design for 'mixed-instance', that is an instance mixed with dedicated cpus and shared cpus, when I deal with the compatibility 'instanceNUMATopology', maybe one choice is dropping the dedicated CPUs directly | 11:28 |
| sean-k-mooney | there are some expctions to that but in generall we dont try to caluate the valuse in new codebases if the object was created in an older version | 11:28 |
| *** salmankhan1 has joined #openstack-nova | 11:28 | |
| *** salmankhan has quit IRC | 11:28 | |
| *** salmankhan1 is now known as salmankhan | 11:28 | |
| sean-k-mooney | huaqiang: well there are two cases | 11:29 |
| huaqiang | sean-k-mooney: pls | 11:29 |
| sean-k-mooney | if a field existied in an older version but the value was not supported we raise an excpetion if you try to backlevel it | 11:29 |
| sean-k-mooney | but if the filed does not exist we remove the filed | 11:30 |
| sean-k-mooney | let me find an example quick | 11:30 |
| huaqiang | yes... | 11:30 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L194-L200 | 11:30 |
| sean-k-mooney | so in 1.22 we extended the hw_video_model filed | 11:31 |
| huaqiang | Yes. raised an exception | 11:32 |
| sean-k-mooney | if an object was created using one of the values that was only supported in 1.22+ we raise an excption | 11:32 |
| sean-k-mooney | but for hw_time_hpet when it is backleveled it is dropped | 11:32 |
| sean-k-mooney | so for your feature | 11:32 |
| *** dpawlik has joined #openstack-nova | 11:32 | |
| sean-k-mooney | we would raise an excpetion for the cpu policy | 11:32 |
| sean-k-mooney | e.g. you would not be allowed to backevel an object with cpu_policy=mixed | 11:33 |
| huaqiang | Yes. I agree | 11:33 |
| sean-k-mooney | because that woudl result in incorrect behavior | 11:33 |
| huaqiang | how about InstanceNUMACell | 11:33 |
| huaqiang | the closest example is this:https://github.com/openstack/nova/blob/master/nova/objects/numa.py#L49 | 11:34 |
| huaqiang | It dropped the host 'pcpuset' directly | 11:34 |
| sean-k-mooney | yes | 11:35 |
| huaqiang | Not translate the pcpuset to exsiting cpuset | 11:35 |
| sean-k-mooney | so for mixed cpus you should not need to modify the OVOs out side fo adding the new value for the cpu policy correct | 11:35 |
| sean-k-mooney | we dont need to modify the host cell object | 11:36 |
| huaqiang | I don't | 11:36 |
| brinzhang_ | gibi: can you open this link http://people.redhat.com/pbonzini/qemu-test-doc/_build/html/topics/vnc_005fsecurity.html | 11:36 |
| sean-k-mooney | so the allowed values of https://github.com/openstack/nova/blob/master/nova/objects/instance_numa.py#L59 will change | 11:36 |
| sean-k-mooney | but the cpu_pinning_raw value can be used in both the dedicated or mixed case | 11:37 |
| sean-k-mooney | in the dedicated case it will have an entry for all cpus | 11:37 |
| sean-k-mooney | in the mixed case it will have a mapping only for the pinned cpus and the floating cpus will not be listed | 11:37 |
| gibi | brinzhang_: yes. Now I see where the limit is coming from. Maybe link this in the spec | 11:38 |
| brinzhang_ | gibi: Ok, I will add this to spec | 11:38 |
| gibi | brinzhang_: cool, thanks! | 11:38 |
| huaqiang | sean-k-mooney: yes. cpu_pinning_raw for pinned cpus only | 11:38 |
| sean-k-mooney | so what you will need to do is add a line here https://github.com/openstack/nova/blob/master/nova/objects/instance_numa.py#L42 | 11:39 |
| huaqiang | sean-k-mooney: https://review.opendev.org/#/c/716267/5/nova/objects/instance_numa.py | 11:39 |
| sean-k-mooney | which will raise an excpetion if you try to backlevel an object with the policy set to mixed and i think that is all | 11:40 |
| sean-k-mooney | huaqiang: yep exactly | 11:40 |
| huaqiang | For in 'obj_make_compatible' for version 1.6, we have choice to through a exception | 11:40 |
| huaqiang | and we have another choice to ' primitive.pop('pcpuset', None)' in generating version prior to 1.5 | 11:41 |
| huaqiang | I am thinking which one is better | 11:41 |
| sean-k-mooney | that the thing we dont have a choice | 11:41 |
| sean-k-mooney | for 1.6 we have to raise an excption | 11:42 |
| sean-k-mooney | if we dropped the value then we would cahgne form mixed to shared | 11:42 |
| sean-k-mooney | that is wrong | 11:42 |
| huaqiang | Yes. I don't allow change from a mixed to shared | 11:42 |
| huaqiang | sound reasonable | 11:42 |
| sean-k-mooney | i think what is being done for 1.5 and 1.6 in those patches is correct | 11:43 |
| huaqiang | sean-k-mooney: Thanks | 11:44 |
| huaqiang | It is clear for me. | 11:44 |
| huaqiang | sean-k-mooney: another thing | 11:45 |
| huaqiang | since v1.6 is not compatible with v1.5 | 11:46 |
| huaqiang | should be bump the major version number? | 11:46 |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Re-proposes 'Proposal for a safer remote console with password authentication' https://review.opendev.org/719720 | 11:46 |
| sean-k-mooney | we dont really use the major version number | 11:46 |
| brinzhang_ | gibi: done, thanks | 11:46 |
| huaqiang | s/should be/ should we/ | 11:46 |
| sean-k-mooney | but we could i guess | 11:46 |
| sean-k-mooney | that wone i would want dansmith to weigh in on as i dont know why we dont bump the major version | 11:47 |
| sean-k-mooney | proably because its only conditionally incompatiable | 11:47 |
| huaqiang | I'll leave it for revewer for designe | 11:47 |
| huaqiang | s/designe/decision/ | 11:47 |
| sean-k-mooney | e.g. if you are using shraed or dedicated we can backlevel it | 11:47 |
| sean-k-mooney | so since it not a hard incompatiablity we dont need to modify the major version | 11:48 |
| huaqiang | it true. | 11:48 |
| *** brinzhang_ has quit IRC | 11:48 | |
| huaqiang | ok, thanks | 11:48 |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.PY2 and six.PY3 https://review.opendev.org/726512 | 11:49 |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.add_metaclass https://review.opendev.org/726565 | 11:49 |
| gibi | brtknr: thanks, +2 | 11:49 |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.reraise https://review.opendev.org/726898 | 11:49 |
| brtknr | gibi: wp | 11:50 |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224 | 11:50 |
| gibi | brtknr: sorry | 11:50 |
| brtknr | np :) | 11:50 |
| openstackgerrit | sean mooney proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341 | 11:52 |
| openstackgerrit | sean mooney proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029 | 11:52 |
| openstackgerrit | sean mooney proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree https://review.opendev.org/676522 | 11:52 |
| openstackgerrit | sean mooney proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460 | 11:52 |
| sean-k-mooney | gibi: that is just a strait rebae with the merge conflicts and pep8 issues resolved by the way so its basically the same as the previous version | 11:53 |
| gibi | sean-k-mooney: thanks. you and tony_su should sync on who will work on that patch series | 11:54 |
| sean-k-mooney | gibi: yep | 11:55 |
| sean-k-mooney | tony_su: if you want to take it over and have time to adress https://review.opendev.org/#/c/676029/34/nova/tests/unit/compute/test_provider_config.py@174 that was the only open item form last cycle i belive | 11:56 |
| sean-k-mooney | ok i have been awaked since 3:30 and working more or less since 4:30 so im going to take a break for a few hours. ill be back after i have lunch and relax for a bit | 11:59 |
| *** martinkennelly has quit IRC | 12:01 | |
| *** ociuhandu has joined #openstack-nova | 12:04 | |
| *** raildo has joined #openstack-nova | 12:05 | |
| gibi | sean-k-mooney: have a nice lunch | 12:09 |
| *** ociuhandu has quit IRC | 12:10 | |
| *** ociuhandu has joined #openstack-nova | 12:10 | |
| *** mriedem has joined #openstack-nova | 12:16 | |
| *** rpittau|bbl is now known as rpittau | 12:19 | |
| jkulik | anybody else experiencing problems with querying /servers for multiple uuids? nova seems to only get one uuid for filtering. I guess the MultiDict used by webob.Request gets botched here https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L178 see http://paste.openstack.org/show/793512/ for some python-console fuu showing the problem | 12:22 |
| jkulik | docs for the MultiDict stuff https://docs.pylonsproject.org/projects/webob/en/stable/reference.html#query-post-variables | 12:23 |
| *** tkajinam has quit IRC | 12:24 | |
| *** ociuhandu has quit IRC | 12:27 | |
| *** ociuhandu has joined #openstack-nova | 12:28 | |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224 | 12:28 |
| jkulik | should I just open a bug report if I fear something is broken instead of asking on IRC for someone to confirm? | 12:29 |
| sean-k-mooney | jkulik: im not sure if this is actully supported | 12:30 |
| jkulik | oh, down the line it's checked against a list | 12:30 |
| jkulik | let me find that part again | 12:30 |
| sean-k-mooney | jkulik: the servers endpoint only supprot one uuid https://docs.openstack.org/api-ref/compute/?expanded=show-server-details-detail#show-server-details | 12:31 |
| sean-k-mooney | not a list of them | 12:31 |
| sean-k-mooney | at least the server detials endpoint | 12:32 |
| jkulik | index does support more in theory, though. it ends up here in the end https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L1849-L1854 | 12:32 |
| jkulik | oh, I mean query params to /servers or /servers/detail | 12:33 |
| sean-k-mooney | well the docs text is | 12:33 |
| sean-k-mooney | right so its not supported for /servers/detail | 12:33 |
| sean-k-mooney | well i guess it might be | 12:33 |
| sean-k-mooney | the docs text reads | 12:34 |
| sean-k-mooney | uuid (Optional) | 12:34 |
| sean-k-mooney | 12:34 | |
| sean-k-mooney | query | 12:34 |
| sean-k-mooney | 12:34 | |
| sean-k-mooney | string | 12:34 |
| sean-k-mooney | 12:34 | |
| sean-k-mooney | Filter the server list result by the UUID of the server. | 12:34 |
| sean-k-mooney | This parameter is only valid when specified by administrators. If non-admin users specify this parameter, it is ignored. | 12:34 |
| sean-k-mooney | so based on the docs we dont supprot it | 12:34 |
| jkulik | it would explicitly state that's it supports a list? | 12:34 |
| sean-k-mooney | it might be possibel but its not intended to work | 12:34 |
| sean-k-mooney | it filters the list of servers by the uuid | 12:35 |
| jkulik | (because for neutron ports "id", it looked the same but works) | 12:35 |
| sean-k-mooney | it does not say it supports a list of uuids | 12:35 |
| jkulik | sure, but the code has extra ifs for a list ;) | 12:35 |
| jkulik | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2838-L2841 | 12:36 |
| sean-k-mooney | jkulik: do we have api test for the list case | 12:36 |
| jkulik | haven't checked. will do. | 12:36 |
| *** lpetrut has quit IRC | 12:46 | |
| *** nweinber has joined #openstack-nova | 12:47 | |
| jkulik | can't find any in the unit-tests at least. for a lot of other query-params, there are tests, but uuid doesn't seem to be in there. | 12:48 |
| sean-k-mooney | jkulik: looking at the code if ti ever worke i suspect it was a nova v2 or nova v1 capablity that was never fully supproted and is not supproted anymore | 12:49 |
| jkulik | looking at the code, it seems totally supported, if we would just convert the MultiDict's multiple entries to a list instead | 12:50 |
| sean-k-mooney | https://github.com/openstack/nova/commit/3f35fe6a88672ea2ab7e080a55235c5cca45dc2c | 12:50 |
| sean-k-mooney | that code is related to listing instance by ip | 12:51 |
| sean-k-mooney | jkulik: its not for listing servers by uuid | 12:51 |
| francoisp | lyarwood, bauzas hello, when you get a chance: https://review.opendev.org/#/c/726508/ (this time around for Queens) - thanks! | 12:51 |
| bauzas | ack, will look | 12:52 |
| sean-k-mooney | jkulik: we support a list there becasue you can have multiple servers with the same ip adress | 12:52 |
| sean-k-mooney | but we dont support the uuid query arg being a list | 12:52 |
| jkulik | sean-k-mooney, but is uses the uuid key out of search_opts which comes from the query-params | 12:53 |
| jkulik | which cannot be a list because it's broken | 12:53 |
| sean-k-mooney | jkulik: the uuid quey arg is not ment to be a list | 12:53 |
| sean-k-mooney | it susing it here so you can filter by ip and uuid | 12:53 |
| jkulik | my use-case would be retrieving infos for multiple servers I know the UUID of in one request btw. | 12:53 |
| sean-k-mooney | the docs say uuid singualr | 12:54 |
| sean-k-mooney | jkulik: yep which as far as im aware we do not support | 12:54 |
| jkulik | sure. the docs say the same for "id" in ports, so I didn't think that's so important ;) | 12:54 |
| jkulik | and since search_opts gets passed down to the db layer in the end, which also can support a list, we would just have to adjust that one line to make it work | 12:55 |
| sean-k-mooney | gmann: your one of our api experst do you know if we have ever supported filtering server list by a list of uuids | 12:55 |
| jkulik | but if it's not supposed to, that's fine, too. I just think the code would support it. | 12:55 |
| *** martinkennelly has joined #openstack-nova | 12:55 | |
| sean-k-mooney | jkulik: there is a difference between things that work as a result of internal impemnstion details and what is actully supported | 12:55 |
| jkulik | sean-k-mooney, thanks for looking at it :) | 12:56 |
| sean-k-mooney | jkulik: this is the relevent spec for filtering https://specs.openstack.org/openstack/nova-specs/specs/ocata/implemented/add-whitelist-for-server-list-filter-sort-parameters.html | 12:57 |
| sean-k-mooney | jkulik: so i think we suport filterign with a singel value but not lists or any advance queries. | 13:00 |
| *** ttsiouts has quit IRC | 13:04 | |
| *** ratailor has quit IRC | 13:04 | |
| jkulik | I don't see any mentioning of either in the spec, but I can live with the answer "works as designed". | 13:05 |
| sean-k-mooney | it is a feature you could request or propose as a blueprit/spec. | 13:07 |
| sean-k-mooney | i belive its working as designed currently | 13:07 |
| sean-k-mooney | but i dont nessicaly thing it woudl be too contovertall to add support for what you want | 13:07 |
| sean-k-mooney | its just not a bug since i dont think it was ever inteded to wrok | 13:07 |
| *** ttsiouts has joined #openstack-nova | 13:13 | |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys https://review.opendev.org/727757 | 13:18 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Add functional test for bug 1550919 https://review.opendev.org/631294 | 13:21 |
| openstack | bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Lee Yarwood (lyarwood) | 13:21 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/578846 | 13:21 |
| *** lbragstad has joined #openstack-nova | 13:23 | |
| *** ociuhandu has quit IRC | 13:24 | |
| *** sapd1_x has quit IRC | 13:31 | |
| *** ttsiouts has quit IRC | 13:32 | |
| *** redrobot has joined #openstack-nova | 13:34 | |
| jkulik | functional tests don't support testing the "uuid as list" case either https://github.com/openstack/nova/blob/master/nova/tests/functional/api/client.py#L248-L250 | 13:39 |
| *** READ10 has joined #openstack-nova | 13:39 | |
| jkulik | the lack of tests for 'uuid' in search_opts isn't good, though :D | 13:39 |
| *** efried has joined #openstack-nova | 13:44 | |
| sean-k-mooney | jkulik: yep again i think that is becasue we did not orginally plan to expose this via the api and retroactivly had to try and fix it | 13:45 |
| openstackgerrit | Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | 13:46 |
| *** liuyulong has joined #openstack-nova | 13:49 | |
| *** jamesdenton has quit IRC | 14:03 | |
| *** ociuhandu has joined #openstack-nova | 14:05 | |
| *** ociuhandu has quit IRC | 14:11 | |
| *** jamesdenton has joined #openstack-nova | 14:11 | |
| *** ttsiouts has joined #openstack-nova | 14:12 | |
| *** ociuhandu has joined #openstack-nova | 14:12 | |
| *** ttsiouts has quit IRC | 14:17 | |
| *** ociuhandu has quit IRC | 14:18 | |
| openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte https://review.opendev.org/727777 | 14:24 |
| *** lpetrut has joined #openstack-nova | 14:29 | |
| *** ociuhandu has joined #openstack-nova | 14:33 | |
| gmann | jkulik: sean-k-mooney yeah, multi filters things are not supported. for this case where you want to list multiple servers you can use some other query filter which matches multiple servers. like ?name=test so it will return all servers matching with 'test*' | 14:34 |
| gmann | remember, multiple filters are with AND condition | 14:35 |
| gmann | in current behaviour only last present item is being used even you are asking for multi dict | 14:38 |
| *** ociuhandu has quit IRC | 14:39 | |
| gmann | jkulik: it should not be hard to support that, we just need to change the way we fetch filter from GET and query DB with OR condition. | 14:41 |
| gmann | jkulik: anyways, all API change need spec process, please feel free to add BP and spec for the same | 14:41 |
| *** mlavalle has joined #openstack-nova | 14:42 | |
| *** dklyle has joined #openstack-nova | 14:42 | |
| gmann | but remember any other filter present with mutli dict filter will be with AND condition. so you would not be able to do 'server-uuid1 OR (server-uuid2 AND vm_state=active)' it will be '(server-uuid1 OR server-uuid2) AND vm_state=active)' | 14:43 |
| *** ociuhandu has joined #openstack-nova | 15:01 | |
| *** priteau has joined #openstack-nova | 15:01 | |
| *** links has quit IRC | 15:02 | |
| *** lpetrut has quit IRC | 15:08 | |
| *** JamesBenson has joined #openstack-nova | 15:16 | |
| *** belmoreira has quit IRC | 15:24 | |
| * gibi hates the imagebackend code | 15:31 | |
| lyarwood | we should start a club :) | 15:32 |
| lyarwood | gibi: I've not had a chance to look at your caching change btw, I'll try to get to it tomorrow | 15:33 |
| gibi | lyarwood: dont rush it is a very incomplete messy pile of boo | 15:34 |
| gibi | lyarwood: I just figured out that the current imagebacked code my temporarily use double of the image size disk space. For example if an image is a qcow in glance but nova configured to force_raw_images then after image download we copy out the raw data from qcow and the delete the qcow file we downloaded :/ | 15:36 |
| *** dtantsur is now known as dtantsur|afk | 15:36 | |
| gibi | s/my/might/ | 15:36 |
| gibi | who thought that we will have disk space for that operation?! | 15:36 |
| gibi | I get to feel that I have no power to patch this code in a way I imagined | 15:38 |
| dansmith | lyarwood: is it a club if everyone is a member? | 15:38 |
| dansmith | I think that's called "a population" | 15:38 |
| dansmith | gibi: did you catch the scrollback of our convo yesterday? | 15:39 |
| lyarwood | dansmith: ^_^ | 15:39 |
| lyarwood | gibi: yeah I don't think we can convert in-place tbh | 15:39 |
| gibi | dansmith: yes. but honestly I have to go back to it as I already forget what was the pre-filter idea | 15:40 |
| *** tesseract has quit IRC | 15:40 | |
| dansmith | gibi: so, I think it's not unreasonable to say "to boot an instance of $root from an image of $imgsize, the host needs to have $root+$imgsize free space, as a rule | 15:40 |
| dansmith | although you know what.. | 15:41 |
| dansmith | I think we were totally missing something yesterday, now that I re-state that with a fresh mind | 15:41 |
| * gibi is listening | 15:41 | |
| *** jamesdenton has quit IRC | 15:42 | |
| dansmith | for that to even help, we have to account for the base in the inventory or allocations somehow, which is what we were trying to avoid there | 15:42 |
| dansmith | so, hrmph | 15:42 |
| dansmith | gibi: I will say that although I understand the desire to disable the cache as a workaround, it's really not a useful solution for anything other than a very small subset of cases | 15:43 |
| dansmith | i.e. where you expect only one of each image type to be booted in a disk-constrained place anyway | 15:43 |
| *** gyee has joined #openstack-nova | 15:43 | |
| gibi | and I think it is pretty impossible to do properly due to what assumption the code currently makes | 15:43 |
| dansmith | so I wouldn't want to spend a bunch of effort or cause a bunch of destabilization in the image backend to do so | 15:43 |
| dansmith | gibi: right, hence my concern yesterday :) | 15:43 |
| gibi | I needed to feel the pain to understand :) | 15:44 |
| dansmith | :D | 15:44 |
| *** jamesdenton has joined #openstack-nova | 15:46 | |
| dansmith | gibi: so, one thing I was wondering | 15:47 |
| gibi | even if we start making allocation according to the images in the cache, the current code sometimes copy things over for conversions and that doubles the disk usage temporarly, or fail if no disk space for such operation | 15:47 |
| *** sapd1_x has joined #openstack-nova | 15:47 | |
| dansmith | gibi: did you find somewhere that the DiskFilter considered the size of the image? Because even considering disk free space, you don't know if the target host will need room for the image (if it's not cached) PLUS the root, etc disks as well | 15:47 |
| dansmith | because I don't think it really took that into account.. i.e. adding the flavor disks and the possible space required for a separate image | 15:48 |
| gibi | DiskFilter used the disk_available_least value from the DB. There we count current available free space in the $instances_path (among other things) | 15:49 |
| dansmith | gibi: yeah, and like I said yesterday if we start doing allocations for images, we have a lot of cases we need to cover, a lot of new potential needs for healing that data, etc.. it concerns me to make a decision to start doing that so quickly | 15:49 |
| gibi | dansmith: ^^ agree | 15:49 |
| dansmith | gibi: right, but the scheduler only looks to see if root+swap+ephemeral will fit in that space, but it may still fail because the compute node doesn't have the image cached already and thus need root+swap+ephemeral+image space to do the work | 15:50 |
| dansmith | it's less of a problem, but it's similar | 15:50 |
| gibi | correct (shit, another edge case) | 15:50 |
| dansmith | so here's a couple of less impactful options: | 15:52 |
| dansmith | 1. Each time we cache an image, or run the periodic, we generate a disk allocation for the compute node uuid which consumes inventory according to how much space the cache is using | 15:52 |
| dansmith | 2. Same as above, but adjust the reserved amount | 15:53 |
| dansmith | both cases need to consider the case where the _base is not on the same filesystem as the instances, but there's less synchronization involved, and we're not spraying tons of new allocations into place | 15:53 |
| dansmith | we could also make it a workaround that you opt into in the short term to see how it goes, because cleanup from it would be much easier (just nuke one $cnuuid allocation) | 15:54 |
| dansmith | and we could make compute node startup nuke that allocation if present and the workaround is disabled (or the self-correcting reserved amount) | 15:55 |
| gibi | right, I would use allocation instead of reserved as allocation has a consumer attached | 15:55 |
| gibi | reserved would be a sum of configured + detected | 15:56 |
| gibi | which is math, that I dont like :) | 15:56 |
| dansmith | hopefully glance gives us enough information to be able to increase that allocation before we start the download, so we know "oh sorry, inventory says we don't have room for this base image, so fail()" | 15:56 |
| dansmith | I know it would, but I think reserved would be more obvious to an operator | 15:56 |
| dansmith | even though it's a composite value | 15:57 |
| dansmith | just because listing allocations are a bunch of meaningless-to-the-human UUIDs | 15:57 |
| dansmith | I'm not arguing for that, I'm just saying there're benefits both ways | 15:57 |
| gibi | I see. yes it is a tradeoff | 15:57 |
| dansmith | I gotta get on a call | 15:58 |
| dansmith | food for thought | 15:58 |
| gibi | dansmith: thanks! I appreciate your help | 15:59 |
| gibi | I've checked. glance give use the physical size of the image on the API. Which is good for ensuring we have still disk for the download | 16:00 |
| gibi | also I think even if nova is converting a qcow2 glace image to raw locally (due to force_raw_images config) the resulting raw file is sparse | 16:02 |
| gibi | but it might dependent on the host OS + file system support | 16:02 |
| *** maciejjozefczyk has quit IRC | 16:04 | |
| *** jamesdenton has quit IRC | 16:16 | |
| *** liuyulong has quit IRC | 16:17 | |
| *** rpittau is now known as rpittau|afk | 16:21 | |
| *** gary_perkins has quit IRC | 16:23 | |
| *** gary_perkins has joined #openstack-nova | 16:24 | |
| gibi | dansmith: if we start allocating / reserving the cache disk usage in placement then do we still need a pre-filter as well? For me it is OK to simply let the boot fail on the compute side if the extra DISK_GB resource for the cache cannot be allocated? | 16:26 |
| gibi | s/?// | 16:27 |
| gibi | anyhow documented your idea in the bug report | 16:27 |
| dansmith | gibi: weighing aside, any compute with enough space for an instance but not enough for the instance+image will become a magnet for new builds, which will all fail | 16:27 |
| dansmith | so, yeah, we can just pretend that's not worth solving, but it also sucks because avoiding that is what we're trying to solve with placement | 16:28 |
| gibi | OK, I can imagine this as a two step solution then. First the allocation / reservation management in the compute then second the pre-filter that uses instance + image DISK_GB request but allocate only the instance disk for the instance_uuid in placement | 16:31 |
| dansmith | perhaps | 16:32 |
| *** udesale_ has quit IRC | 16:33 | |
| *** evrardjp has quit IRC | 16:36 | |
| *** evrardjp has joined #openstack-nova | 16:36 | |
| *** jamesdenton has joined #openstack-nova | 16:38 | |
| *** sapd1_x has quit IRC | 16:40 | |
| openstackgerrit | melanie witt proposed openstack/nova master: DNM Try out running sphinx-build in parallel for releasenotes https://review.opendev.org/727429 | 16:40 |
| *** sapd__x has joined #openstack-nova | 16:40 | |
| *** ociuhandu has quit IRC | 16:42 | |
| *** ociuhandu has joined #openstack-nova | 16:43 | |
| *** ociuhandu has quit IRC | 16:43 | |
| *** ociuhandu has joined #openstack-nova | 16:43 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: WIP: allow disabling image cache for raw images https://review.opendev.org/727261 | 16:48 |
| *** grandchild has joined #openstack-nova | 17:01 | |
| *** derekh has quit IRC | 17:03 | |
| *** jamesdenton has quit IRC | 17:15 | |
| *** ociuhandu has quit IRC | 17:21 | |
| *** nightmare_unreal has quit IRC | 17:22 | |
| *** salmankhan has quit IRC | 17:22 | |
| *** ociuhandu has joined #openstack-nova | 17:23 | |
| openstackgerrit | melanie witt proposed openstack/nova master: DNM Try out running sphinx-build in parallel for releasenotes https://review.opendev.org/727429 | 17:23 |
| *** hemna_ has quit IRC | 17:29 | |
| *** hemna has joined #openstack-nova | 17:29 | |
| *** ociuhandu has quit IRC | 17:33 | |
| *** ociuhandu has joined #openstack-nova | 17:34 | |
| *** dpawlik has quit IRC | 17:36 | |
| *** priteau has quit IRC | 17:38 | |
| *** ociuhandu has quit IRC | 17:40 | |
| *** ralonsoh has quit IRC | 17:44 | |
| *** jamesdenton has joined #openstack-nova | 17:57 | |
| *** jamesdenton has quit IRC | 18:04 | |
| *** jamesdenton has joined #openstack-nova | 18:09 | |
| *** sapd__x has quit IRC | 18:31 | |
| *** ociuhandu has joined #openstack-nova | 18:32 | |
| *** ociuhandu has quit IRC | 18:40 | |
| *** ociuhandu has joined #openstack-nova | 18:40 | |
| *** READ10 has quit IRC | 18:41 | |
| *** jamesdenton has quit IRC | 18:53 | |
| *** jamesdenton has joined #openstack-nova | 18:57 | |
| *** belmoreira has joined #openstack-nova | 19:05 | |
| openstackgerrit | Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | 19:05 |
| *** maciejjozefczyk has joined #openstack-nova | 19:08 | |
| *** maciejjozefczyk has quit IRC | 19:25 | |
| *** ociuhandu has quit IRC | 19:27 | |
| *** ociuhandu has joined #openstack-nova | 19:28 | |
| *** dklyle has quit IRC | 19:38 | |
| *** ociuhandu has quit IRC | 19:39 | |
| *** ociuhandu has joined #openstack-nova | 19:40 | |
| *** ociuhandu has quit IRC | 19:40 | |
| *** ociuhandu has joined #openstack-nova | 19:40 | |
| *** dklyle has joined #openstack-nova | 19:46 | |
| *** ociuhandu has quit IRC | 19:51 | |
| *** ociuhandu has joined #openstack-nova | 19:52 | |
| *** ociuhandu has quit IRC | 19:52 | |
| *** ociuhandu has joined #openstack-nova | 19:52 | |
| *** martinkennelly has quit IRC | 19:57 | |
| *** ociuhandu has quit IRC | 20:02 | |
| *** jsuchome has quit IRC | 20:02 | |
| *** ociuhandu has joined #openstack-nova | 20:03 | |
| *** ociuhandu has quit IRC | 20:03 | |
| *** ociuhandu has joined #openstack-nova | 20:03 | |
| *** belmoreira has quit IRC | 20:07 | |
| *** ttsiouts has joined #openstack-nova | 20:13 | |
| *** ociuhandu has quit IRC | 20:14 | |
| *** ociuhandu has joined #openstack-nova | 20:15 | |
| *** jamesdenton has quit IRC | 20:16 | |
| openstackgerrit | melanie witt proposed openstack/nova master: DNM Try out running sphinx-build in parallel for releasenotes https://review.opendev.org/727429 | 20:20 |
| *** ociuhandu has quit IRC | 20:26 | |
| *** ociuhandu has joined #openstack-nova | 20:27 | |
| *** ociuhandu has quit IRC | 20:27 | |
| *** ociuhandu has joined #openstack-nova | 20:27 | |
| *** ttsiouts has quit IRC | 20:30 | |
| *** jamesdenton has joined #openstack-nova | 20:30 | |
| *** vishalmanchanda has quit IRC | 20:31 | |
| *** ttsiouts has joined #openstack-nova | 20:32 | |
| *** ociuhandu has quit IRC | 20:37 | |
| *** ociuhandu has joined #openstack-nova | 20:38 | |
| *** ociuhandu has quit IRC | 20:38 | |
| *** ociuhandu has joined #openstack-nova | 20:39 | |
| *** ociuhandu has quit IRC | 20:49 | |
| *** ociuhandu has joined #openstack-nova | 20:50 | |
| *** ociuhandu has quit IRC | 20:50 | |
| *** ociuhandu has joined #openstack-nova | 20:50 | |
| openstackgerrit | Sean McGinnis proposed openstack/nova master: DNM: Test making EM branch release notes static https://review.opendev.org/727875 | 20:54 |
| *** ccamacho has quit IRC | 20:54 | |
| *** ociuhandu has quit IRC | 21:01 | |
| *** ociuhandu has joined #openstack-nova | 21:02 | |
| *** ociuhandu has quit IRC | 21:07 | |
| *** nweinber has quit IRC | 21:10 | |
| *** damien_r has quit IRC | 21:19 | |
| *** jamesdenton has quit IRC | 21:30 | |
| *** mriedem has left #openstack-nova | 21:34 | |
| *** awalende has quit IRC | 21:38 | |
| *** awalende has joined #openstack-nova | 21:39 | |
| *** awalende has quit IRC | 21:43 | |
| *** raildo has quit IRC | 21:46 | |
| *** slaweq has quit IRC | 21:57 | |
| *** spatel has joined #openstack-nova | 22:08 | |
| *** slaweq has joined #openstack-nova | 22:09 | |
| *** spatel has quit IRC | 22:12 | |
| *** grandchild has quit IRC | 22:12 | |
| *** slaweq has quit IRC | 22:13 | |
| *** CeeMac has quit IRC | 22:16 | |
| *** JamesBenson has quit IRC | 22:18 | |
| *** spatel has joined #openstack-nova | 22:20 | |
| *** slaweq has joined #openstack-nova | 22:23 | |
| *** slaweq has quit IRC | 22:28 | |
| *** tbachman has quit IRC | 22:36 | |
| *** ttsiouts has quit IRC | 22:43 | |
| *** ttsiouts has joined #openstack-nova | 22:44 | |
| *** spatel has quit IRC | 22:45 | |
| *** tkajinam has joined #openstack-nova | 22:46 | |
| *** hongbin has joined #openstack-nova | 23:05 | |
| *** tosky has quit IRC | 23:06 | |
| melwitt | gmann: do you understand why even after version bump we can get pep8 errors in gate? https://review.opendev.org/727589 | 23:15 |
| gmann | melwitt: it would be an error now as hacking min version bump will stop the new checks added in flake8 3.8.0 version. | 23:18 |
| gmann | this one- https://review.opendev.org/#/c/727347/1 | 23:18 |
| melwitt | gmann: yeah but... (sorry) I thought bumping the version _stops_ the new checks from getting pulled in> | 23:19 |
| melwitt | s/>/?/ | 23:19 |
| gmann | sorry *would not be an error | 23:19 |
| gmann | missing *not* | 23:19 |
| melwitt | ok, makes sense. so why second patch needed? is it nice to have for future flake8 or something> | 23:20 |
| melwitt | gah I keep hitting > | 23:20 |
| gmann | yeah for future but we will not be able to verify it or all error till we have new hacking pulling new checks. | 23:21 |
| melwitt | yeah, ok. | 23:21 |
| gmann | I am going to release the new hacking version 4.0.0 which will pull new checks and then in 727589 patch we will bump hacking version to so that we can verify the fix | 23:21 |
| gmann | I mean fix + new hacking version bump in a single patch. | 23:22 |
| *** threestrands has joined #openstack-nova | 23:29 | |
| *** Liang__ has joined #openstack-nova | 23:29 | |
| *** tbachman has joined #openstack-nova | 23:30 | |
| *** rcernin has quit IRC | 23:31 | |
| melwitt | gmann: yeah makes sense. +2 on the 3.0.1 patch though I wondered if it's needed to avoid gate failures, would have thought we'd have a gate-failure bug around it. that is, it wasn't clear to me if the patch is needed to fix gate failure | 23:31 |
| *** rcernin has joined #openstack-nova | 23:32 | |
| gmann | melwitt: I did nova patch earlier before i described the situation in other patches cmt msg like this- https://review.opendev.org/#/c/727576/ | 23:34 |
| gmann | melwitt: basically it will 1. fix local run where the latest fixed hacking 3.0.1 is not pulled automatically. in case of gate it is pulled as fresh installation. 2. it will protect if future flake8 3.9.0 version pull other new checks. | 23:35 |
| melwitt | ah I see | 23:35 |
| melwitt | oh ok so not a gate issue | 23:35 |
| melwitt | cool thanks for explaining | 23:36 |
| melwitt | I was confused before heh | 23:36 |
| *** ociuhandu has joined #openstack-nova | 23:36 | |
| gmann | otherwise hacking before 3.0.1 is capping "flake8<4.0.0" so flake8 3.8.0 which ic current release and 3.9.0 future release both can be protected by bumping hacking to 3.0.1 | 23:37 |
| melwitt | right | 23:37 |
| melwitt | yeah, so needed for future | 23:37 |
| gmann | it is actually confusing as all inbuild deps actually. hacking does protect cap for flake8 and flake8 does protect cap for pycodestyle. but if pycodestyle is pulled as latest by some flake8 plugins then again it fail like flake8-import-order then we need pycodestyle cap explicitly. like tempest case- https://review.opendev.org/#/c/727276/2/test-requirements.txt | 23:39 |
| gmann | so our way of handling the flake8 with plugins is not so great. | 23:40 |
| melwitt | wow. mind blown | 23:40 |
| gmann | i added PR on flake8-import-order but not sure if they will accept or not with our hacky use case :) - https://github.com/PyCQA/flake8-import-order/pull/172 | 23:41 |
| melwitt | ah, good luck :) | 23:41 |
| *** avolkov has quit IRC | 23:46 | |
| *** ociuhandu has quit IRC | 23:52 | |
| *** xek has joined #openstack-nova | 23:58 | |
| *** xek__ has quit IRC | 23:59 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!