| *** wolverineav has joined #openstack-nova | 00:22 | |
| *** wolverineav has quit IRC | 00:26 | |
| *** sdake has joined #openstack-nova | 00:26 | |
| *** tetsuro has joined #openstack-nova | 00:34 | |
| *** lbragstad has quit IRC | 00:39 | |
| *** slaweq has quit IRC | 00:41 | |
| *** erlon has joined #openstack-nova | 00:45 | |
| *** sdake has quit IRC | 00:58 | |
| *** wolverineav has joined #openstack-nova | 00:59 | |
| *** ileixe has joined #openstack-nova | 01:03 | |
| *** wolverineav has quit IRC | 01:04 | |
| *** markvoelker has joined #openstack-nova | 01:10 | |
| *** sdake has joined #openstack-nova | 01:14 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750 | 01:16 |
|---|---|---|
| *** sdake has quit IRC | 01:16 | |
| *** tiendc has joined #openstack-nova | 01:19 | |
| *** whoami-rajat has joined #openstack-nova | 01:22 | |
| *** sdake has joined #openstack-nova | 01:22 | |
| *** liumk2233 has joined #openstack-nova | 01:31 | |
| *** lbragstad has joined #openstack-nova | 01:32 | |
| *** hongbin has joined #openstack-nova | 01:33 | |
| *** erlon has quit IRC | 01:38 | |
| openstackgerrit | Merged openstack/nova stable/queens: Lock detach_volume https://review.openstack.org/637535 | 01:39 |
| *** sdake has quit IRC | 01:42 | |
| *** markvoelker has quit IRC | 01:44 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Fix fake DELETE in PlacementFixture https://review.openstack.org/637657 | 01:44 |
| *** sdake has joined #openstack-nova | 01:45 | |
| *** wolverineav has joined #openstack-nova | 01:53 | |
| *** sdake has quit IRC | 01:54 | |
| *** sdake has joined #openstack-nova | 01:59 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:10 | |
| *** sapd1_ has quit IRC | 02:13 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351 | 02:16 |
| *** wolverineav has quit IRC | 02:20 | |
| *** wolverineav has joined #openstack-nova | 02:20 | |
| *** sdake has quit IRC | 02:22 | |
| *** takashin has joined #openstack-nova | 02:26 | |
| *** wolverineav has quit IRC | 02:30 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 02:32 |
| *** _alastor_ has joined #openstack-nova | 02:33 | |
| *** awalende has joined #openstack-nova | 02:35 | |
| *** _alastor_ has quit IRC | 02:38 | |
| *** sapd1 has joined #openstack-nova | 02:38 | |
| *** awalende has quit IRC | 02:39 | |
| *** markvoelker has joined #openstack-nova | 02:41 | |
| *** wolverineav has joined #openstack-nova | 02:47 | |
| *** bhagyashris has joined #openstack-nova | 02:50 | |
| *** wolverineav has quit IRC | 02:51 | |
| *** psachin has joined #openstack-nova | 02:59 | |
| *** wolverineav has joined #openstack-nova | 03:00 | |
| *** Dinesh_Bhor has quit IRC | 03:03 | |
| *** Dinesh_Bhor has joined #openstack-nova | 03:06 | |
| *** markvoelker has quit IRC | 03:13 | |
| *** dklyle has joined #openstack-nova | 03:23 | |
| *** yaawang has joined #openstack-nova | 03:26 | |
| *** gbarros has quit IRC | 03:28 | |
| *** mgariepy has quit IRC | 03:33 | |
| *** wolverineav has quit IRC | 03:34 | |
| *** sapd1 has quit IRC | 03:34 | |
| *** _fragatina has quit IRC | 03:37 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750 | 03:44 |
| *** dave-mccowan has joined #openstack-nova | 03:45 | |
| *** psachin has quit IRC | 03:50 | |
| *** sapd1 has joined #openstack-nova | 03:51 | |
| *** wolverineav has joined #openstack-nova | 03:54 | |
| *** udesale has joined #openstack-nova | 03:54 | |
| *** wolverineav has quit IRC | 03:54 | |
| *** psachin has joined #openstack-nova | 04:00 | |
| *** Dinesh_Bhor has quit IRC | 04:03 | |
| *** agopi has quit IRC | 04:06 | |
| *** mgariepy has joined #openstack-nova | 04:06 | |
| *** agopi has joined #openstack-nova | 04:07 | |
| *** andreaf has quit IRC | 04:08 | |
| *** andreaf has joined #openstack-nova | 04:09 | |
| *** belmoreira has quit IRC | 04:10 | |
| *** hamzy has quit IRC | 04:13 | |
| *** jlvillal has quit IRC | 04:14 | |
| *** janki has joined #openstack-nova | 04:14 | |
| *** jlvillal has joined #openstack-nova | 04:14 | |
| *** jamesdenton has quit IRC | 04:16 | |
| *** jamesdenton has joined #openstack-nova | 04:16 | |
| *** ade_lee_ has left #openstack-nova | 04:20 | |
| *** wolverineav has joined #openstack-nova | 04:25 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Fix output of interface-attach command https://review.openstack.org/637677 | 04:25 |
| alex_xu | melwitt: I probably didn't get what your mean about the unrelated between instance.project_id as target and removing project_only=True | 04:28 |
| alex_xu | melwitt: I'm thinking make the instance.project_id as target should be the first step, then we can remove the project_only=True. so...that I'm thinking they are related | 04:29 |
| *** wolverineav has quit IRC | 04:29 | |
| *** cfriesen has joined #openstack-nova | 04:30 | |
| *** _alastor_ has joined #openstack-nova | 04:35 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix resetting non-persistent fields when saving obj https://review.openstack.org/636271 | 04:37 |
| *** _alastor_ has quit IRC | 04:39 | |
| *** BlackDex has quit IRC | 04:43 | |
| *** zzzeek has quit IRC | 04:49 | |
| *** _fragatina has joined #openstack-nova | 04:49 | |
| *** _fragatina has quit IRC | 04:49 | |
| *** _fragatina has joined #openstack-nova | 04:50 | |
| *** zzzeek has joined #openstack-nova | 04:52 | |
| *** irclogbot_2 has quit IRC | 04:55 | |
| *** BlackDex has joined #openstack-nova | 04:56 | |
| *** medberry has quit IRC | 05:07 | |
| *** ratailor has joined #openstack-nova | 05:09 | |
| *** pbing19 has joined #openstack-nova | 05:10 | |
| *** dave-mccowan has quit IRC | 05:13 | |
| *** Dinesh_Bhor has joined #openstack-nova | 05:21 | |
| *** pbing19 has quit IRC | 05:22 | |
| *** pbing19 has joined #openstack-nova | 05:22 | |
| *** liumk2233 has quit IRC | 05:23 | |
| *** liumk2233 has joined #openstack-nova | 05:24 | |
| *** wolverineav has joined #openstack-nova | 05:27 | |
| *** pbing19 has quit IRC | 05:29 | |
| *** mgariepy has quit IRC | 05:29 | |
| *** mgariepy has joined #openstack-nova | 05:30 | |
| *** liumk2233 has quit IRC | 05:31 | |
| *** liumk2233 has joined #openstack-nova | 05:32 | |
| *** wolverineav has quit IRC | 05:32 | |
| *** udesale has quit IRC | 05:33 | |
| *** _fragatina has quit IRC | 05:36 | |
| *** hongbin has quit IRC | 05:41 | |
| *** markvoelker has joined #openstack-nova | 05:41 | |
| *** udesale has joined #openstack-nova | 05:43 | |
| *** itlinux has quit IRC | 05:45 | |
| *** moshele has joined #openstack-nova | 05:45 | |
| *** ralonsoh has joined #openstack-nova | 05:48 | |
| *** moshele has quit IRC | 05:50 | |
| *** wolverineav has joined #openstack-nova | 05:52 | |
| *** lbragstad has quit IRC | 05:53 | |
| *** sridharg has joined #openstack-nova | 05:53 | |
| *** wolverineav has quit IRC | 05:59 | |
| *** wolverineav has joined #openstack-nova | 06:01 | |
| *** wolverineav has quit IRC | 06:06 | |
| *** liumk_ has joined #openstack-nova | 06:07 | |
| *** liumk2233 has quit IRC | 06:09 | |
| *** liumk2233 has joined #openstack-nova | 06:11 | |
| *** itlinux has joined #openstack-nova | 06:11 | |
| *** liumk_ has quit IRC | 06:13 | |
| *** markvoelker has quit IRC | 06:14 | |
| *** itlinux has quit IRC | 06:16 | |
| *** liumk_ has joined #openstack-nova | 06:19 | |
| *** liumk2233 has quit IRC | 06:22 | |
| *** jackyzhu has joined #openstack-nova | 06:35 | |
| *** ccamacho has quit IRC | 06:35 | |
| *** jackyzhu has quit IRC | 06:37 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 06:37 |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server subresouce toplogy API https://review.openstack.org/621476 | 06:40 |
| *** wolverineav has joined #openstack-nova | 06:42 | |
| *** wolverineav has quit IRC | 06:47 | |
| *** Luzi has joined #openstack-nova | 06:48 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750 | 06:49 |
| bauzas | good morning Nova | 06:49 |
| *** zhubx has joined #openstack-nova | 06:52 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server subresouce toplogy API https://review.openstack.org/621476 | 06:54 |
| *** wolverineav has joined #openstack-nova | 06:56 | |
| *** pbing19 has joined #openstack-nova | 06:56 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server subresouce toplogy API https://review.openstack.org/621476 | 06:59 |
| *** slaweq has joined #openstack-nova | 07:11 | |
| *** markvoelker has joined #openstack-nova | 07:11 | |
| *** wolverineav has quit IRC | 07:12 | |
| *** itlinux has joined #openstack-nova | 07:13 | |
| *** belmoreira has joined #openstack-nova | 07:16 | |
| *** itlinux has quit IRC | 07:17 | |
| *** yaawang has quit IRC | 07:19 | |
| *** rcernin has quit IRC | 07:25 | |
| *** yaawang has joined #openstack-nova | 07:27 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix cleaning up console tokens https://review.openstack.org/637716 | 07:38 |
| *** takamatsu has joined #openstack-nova | 07:40 | |
| *** ociuhandu has joined #openstack-nova | 07:40 | |
| *** markvoelker has quit IRC | 07:43 | |
| *** ociuhandu has quit IRC | 07:47 | |
| *** ccamacho has joined #openstack-nova | 07:47 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:48 | |
| *** pbing19 has quit IRC | 07:54 | |
| *** ileixe has quit IRC | 07:55 | |
| *** yan0s has joined #openstack-nova | 07:56 | |
| *** rpittau has joined #openstack-nova | 07:57 | |
| *** udesale has quit IRC | 07:58 | |
| *** takashin has left #openstack-nova | 08:01 | |
| *** udesale has joined #openstack-nova | 08:03 | |
| *** wolverineav has joined #openstack-nova | 08:06 | |
| *** udesale has quit IRC | 08:07 | |
| *** udesale has joined #openstack-nova | 08:08 | |
| *** pcaruana has joined #openstack-nova | 08:11 | |
| *** tkajinam has quit IRC | 08:12 | |
| *** tesseract has joined #openstack-nova | 08:13 | |
| *** helenafm has joined #openstack-nova | 08:19 | |
| *** itlinux has joined #openstack-nova | 08:22 | |
| *** itlinux has quit IRC | 08:22 | |
| *** sdake has joined #openstack-nova | 08:28 | |
| *** tssurya has joined #openstack-nova | 08:31 | |
| *** evrardjp_ is now known as evrardjp | 08:31 | |
| *** liuyulong_ has joined #openstack-nova | 08:33 | |
| *** ratailor has quit IRC | 08:35 | |
| *** _alastor_ has joined #openstack-nova | 08:36 | |
| *** sdake has quit IRC | 08:37 | |
| *** wolverineav has quit IRC | 08:39 | |
| *** _alastor_ has quit IRC | 08:40 | |
| *** markvoelker has joined #openstack-nova | 08:40 | |
| *** itlinux has joined #openstack-nova | 08:41 | |
| *** itlinux has quit IRC | 08:42 | |
| *** sdake has joined #openstack-nova | 08:45 | |
| *** liuyulong_ has quit IRC | 08:54 | |
| *** ttsiouts has joined #openstack-nova | 08:57 | |
| *** priteau has joined #openstack-nova | 08:59 | |
| *** ociuhandu has joined #openstack-nova | 09:02 | |
| *** itlinux has joined #openstack-nova | 09:03 | |
| *** itlinux has quit IRC | 09:03 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server subresouce toplogy API https://review.openstack.org/621476 | 09:04 |
| *** liumk_ has quit IRC | 09:05 | |
| *** liumk_ has joined #openstack-nova | 09:06 | |
| *** ttsiouts has quit IRC | 09:08 | |
| *** pbing19 has joined #openstack-nova | 09:08 | |
| *** ttsiouts has joined #openstack-nova | 09:08 | |
| *** sapd1 has quit IRC | 09:09 | |
| *** panda|off is now known as panda | 09:11 | |
| kashyap | This needs a final +W, if anyone wants to put this through: https://review.openstack.org/#/c/632507/ (libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Stein") | 09:12 |
| *** ttsiouts has quit IRC | 09:13 | |
| *** markvoelker has quit IRC | 09:14 | |
| gibi | kashyap: I'm here but I cannot help :) | 09:14 |
| kashyap | Heh, I know. | 09:14 |
| kashyap | That's why I didn't ping anyone explicitly :-) | 09:14 |
| gibi | :) | 09:15 |
| kashyap | gibi: I _think_ this is related to my patch, isn't it: http://logs.openstack.org/78/637578/1/check/nova-tox-functional-py35/14da3dc/testr_results.html.gz | 09:16 |
| kashyap | Coming from https://review.openstack.org/#/c/637578 ("libvirt: Omit needless check on 'CONF.serial_console'") | 09:16 |
| * kashyap checks carefully | 09:16 | |
| gibi | kashyap: fells like there is a connection. Is it always fails for your patch? | 09:18 |
| kashyap | Don't know yet | 09:18 |
| * gibi pulling the patch down | 09:18 | |
| *** sapd1 has joined #openstack-nova | 09:22 | |
| *** ociuhandu has quit IRC | 09:23 | |
| kashyap | It is this test 'test_volume_swap_server_with_error' from nova/tests/functional/notification_sample_tests/test_instance.py | 09:23 |
| *** sdake has quit IRC | 09:25 | |
| *** ttsiouts has joined #openstack-nova | 09:25 | |
| kashyap | gibi: But the "IndexError: list index out of range | 09:26 |
| kashyap | " | 09:26 |
| kashyap | ... give me a déjà vu, as I fixed similar errors in unit tests in main patch. | 09:27 |
| kashyap | Usually lowering the index of devices by one, because we removed one needless serial device. | 09:27 |
| *** ratailor has joined #openstack-nova | 09:28 | |
| gibi | kashyap: that index out of range is a missing notification that is probably caused by the stack trace before it | 09:28 |
| gibi | File "/home/zuul/src/git.openstack.org/openstack/nova/nova/compute/manager.py", line 5688, in _init_volume_connection | 09:28 |
| gibi | new_cinfo['serial'] = new_volume_id | 09:28 |
| gibi | TypeError: 'tuple' object does not support item assignment | 09:28 |
| *** sdake has joined #openstack-nova | 09:28 | |
| * gibi is running functional-py35 locally | 09:28 | |
| * kashyap looks | 09:29 | |
| *** ociuhandu has joined #openstack-nova | 09:31 | |
| kashyap | gibi: What's your `tox` command-line? | 09:31 |
| gibi | tox -e functional-py35 | 09:31 |
| *** slaweq has quit IRC | 09:31 | |
| *** ccamacho has quit IRC | 09:31 | |
| *** slaweq has joined #openstack-nova | 09:32 | |
| gibi | kashyap: I cannot reproduce the failure locally | 09:32 |
| kashyap | Hmm | 09:33 |
| gibi | but the stacktrace is there in the log even if the test does not fail | 09:33 |
| kashyap | Ah, I see. | 09:33 |
| gibi | no I will check for the stack trace without your patch | 09:33 |
| kashyap | gibi: One more: did you apply the main bump patch as well? | 09:33 |
| * kashyap runs 'functional-py35' locally | 09:34 | |
| *** dtantsur|afk is now known as dtantsur | 09:34 | |
| gibi | kashyap: I checked out your Omit patch so I have the whole series | 09:34 |
| kashyap | Ah, good. | 09:35 |
| *** ociuhandu has quit IRC | 09:35 | |
| gibi | kashyap: the stacktrace is there even on master without your series | 09:35 |
| gibi | so it is something unrelated | 09:35 |
| kashyap | Okay, noted. Thanks for the quick check. | 09:36 |
| *** zhubx has quit IRC | 09:36 | |
| kashyap | Wonder then should I 'recheck', as this could be a spurious failure? | 09:36 |
| gibi | bottom line, the test fail in your patch due to some timing issue in the notification test, unrelated to that there is a ugly stack trace in the log even if it passes, all unrelated to your patch | 09:36 |
| gibi | kashyap: yep, recheck it is | 09:36 |
| *** wolverineav has joined #openstack-nova | 09:37 | |
| kashyap | Noted, thanks for the quick double-check, feel a bit saner now | 09:37 |
| *** ttsiouts has quit IRC | 09:38 | |
| *** ttsiouts has joined #openstack-nova | 09:38 | |
| *** cfriesen has quit IRC | 09:38 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Reject resize requests when the source host is down https://review.openstack.org/623489 | 09:38 |
| lyarwood | sean-k-mooney: ^ I think you looked at this a while ago, should be ready for another review if you have time today. | 09:39 |
| gibi | kashyap: filed a bug not to forget to look at that stacktrace https://bugs.launchpad.net/nova/+bug/1816538 | 09:40 |
| openstack | Launchpad bug 1816538 in OpenStack Compute (nova) "test_volume_swap_server_with_error produce a suspicious stack trace" [Undecided,New] | 09:40 |
| kashyap | Ah, excellent, thanks | 09:40 |
| *** tetsuro has quit IRC | 09:41 | |
| *** derekh has joined #openstack-nova | 09:42 | |
| *** sdake has quit IRC | 09:49 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Use the correct mdev allocated from the pGPU https://review.openstack.org/636591 | 09:50 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: implement reshaper for vgpu https://review.openstack.org/599208 | 09:50 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add functional test for libvirt vgpu reshape https://review.openstack.org/631559 | 09:50 |
| *** bhdn has quit IRC | 09:53 | |
| *** awalende has joined #openstack-nova | 09:54 | |
| *** bhagyashris has quit IRC | 09:55 | |
| *** ociuhandu has joined #openstack-nova | 09:56 | |
| *** ttsiouts has quit IRC | 09:56 | |
| *** ociuhandu has quit IRC | 09:57 | |
| *** ociuhandu has joined #openstack-nova | 09:58 | |
| *** ttsiouts has joined #openstack-nova | 09:58 | |
| kashyap | stephenfin: When you can: https://review.openstack.org/#/c/632507/ | 09:58 |
| kashyap | gibi: Remind me again, if I touch-up the commit message, will I lose all the +2s / +1s? | 09:59 |
| kashyap | There is a small grammar mistake; it absolutely needs no touching up, but it's just the OCD... | 09:59 |
| *** xek has joined #openstack-nova | 10:01 | |
| gibi | kashyap: hm, if you lose it I can give it back | 10:04 |
| gibi | kashyap: I think rebase only remove +A | 10:04 |
| gibi | but commit message change might remove +2 as well | 10:04 |
| kashyap | Not worth it; the `diff` is this: | 10:04 |
| kashyap | - create a duplicate 'pty' devices | 10:05 |
| kashyap | + create duplicate 'pty' devices | 10:05 |
| kashyap | :D | 10:05 |
| *** cdent has joined #openstack-nova | 10:06 | |
| gibi | kashyap: don't change it :D | 10:06 |
| * gibi is not native English so he has no pain over such small thing obviously | 10:07 | |
| kashyap | Won't :-) | 10:08 |
| kashyap | I'm not a native speaker either, but a stickler for (my own) language. | 10:09 |
| kashyap | s/language/words/ | 10:09 |
| *** wolverineav has quit IRC | 10:10 | |
| stephenfin | kashyap: Yup, I left one comment there | 10:11 |
| *** markvoelker has joined #openstack-nova | 10:11 | |
| stephenfin | Still wondering if we should fix the s390x as a (backportable) precursor | 10:11 |
| kashyap | stephenfin: Yeah, I'm wondering that too. I'll respond in the afternoon; need to be AFK soon for a bit | 10:12 |
| stephenfin | kashyap: Cool. I'll hold off reviewing until then so | 10:13 |
| stephenfin | It probably doesn't matter too much (no one has spotted this in ~2 years) but if it's an easy fix... | 10:13 |
| kashyap | stephenfin: Yeah. And to backport it, it's easy to glean it off | 10:14 |
| kashyap | stephenfin: Probably not worth the churn in this patch, IMHO. Not sure if you agree there | 10:14 |
| kashyap | Let me comment on the review, and then head out | 10:15 |
| *** sajauddin has joined #openstack-nova | 10:18 | |
| kashyap | stephenfin: Responded; let me know what you think there. | 10:19 |
| kashyap | stephenfin: Alright, will do. I _began_ with a separate patch, originally, you know - then squashed it :-) | 10:30 |
| *** ttsiouts has quit IRC | 10:40 | |
| *** priteau has quit IRC | 10:41 | |
| *** ttsiouts has joined #openstack-nova | 10:41 | |
| *** ttsiouts_ has joined #openstack-nova | 10:42 | |
| *** markvoelker has quit IRC | 10:43 | |
| *** ttsiouts has quit IRC | 10:45 | |
| *** lpetrut has joined #openstack-nova | 10:46 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: WIP: Convert driver supported capabilities to compute node provider traits https://review.openstack.org/538498 | 10:47 |
| *** wolverineav has joined #openstack-nova | 11:07 | |
| *** udesale has quit IRC | 11:10 | |
| *** Dinesh_Bhor has quit IRC | 11:14 | |
| *** snevi has joined #openstack-nova | 11:25 | |
| *** tiendc has quit IRC | 11:29 | |
| *** pbing19 has quit IRC | 11:30 | |
| *** snevi has quit IRC | 11:31 | |
| *** wolverineav has quit IRC | 11:39 | |
| openstackgerrit | Silvan Kaiser proposed openstack/nova master: Added mount fstype based validation of Quobyte mounts https://review.openstack.org/522245 | 11:40 |
| *** markvoelker has joined #openstack-nova | 11:40 | |
| *** thgcorrea has joined #openstack-nova | 11:41 | |
| *** awalende has quit IRC | 11:42 | |
| *** awalende has joined #openstack-nova | 11:42 | |
| *** awalende has quit IRC | 11:44 | |
| *** awalende has joined #openstack-nova | 11:44 | |
| *** tbachman has quit IRC | 11:44 | |
| openstackgerrit | sean mooney proposed openstack/os-vif master: [WIP] remove brctl from vif_plug_ovs https://review.openstack.org/636821 | 11:50 |
| openstackgerrit | sean mooney proposed openstack/os-vif master: remove brctl from vif_plug_ovs https://review.openstack.org/636821 | 11:52 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Avoid redundant initialize_connection on source post live migration https://review.openstack.org/637827 | 11:53 |
| *** xek has quit IRC | 11:56 | |
| *** ttsiouts_ has quit IRC | 11:57 | |
| *** xek has joined #openstack-nova | 11:57 | |
| *** xek_ has joined #openstack-nova | 11:59 | |
| *** xek has quit IRC | 11:59 | |
| *** awalende has quit IRC | 12:01 | |
| *** liumk_ has quit IRC | 12:01 | |
| *** awalende has joined #openstack-nova | 12:01 | |
| *** awalende has quit IRC | 12:02 | |
| *** liumk_ has joined #openstack-nova | 12:02 | |
| *** awalende has joined #openstack-nova | 12:02 | |
| *** ratailor has quit IRC | 12:06 | |
| *** mvkr has quit IRC | 12:09 | |
| *** davidsha has joined #openstack-nova | 12:13 | |
| *** liumk_ has quit IRC | 12:13 | |
| *** erlon has joined #openstack-nova | 12:14 | |
| *** markvoelker has quit IRC | 12:14 | |
| *** erlon has quit IRC | 12:14 | |
| *** erlon has joined #openstack-nova | 12:15 | |
| *** erlon has quit IRC | 12:16 | |
| *** erlon has joined #openstack-nova | 12:16 | |
| *** sajauddin has quit IRC | 12:20 | |
| openstackgerrit | ya.wang proposed openstack/nova master: Add configuration item cpu_models to libvirt https://review.openstack.org/637834 | 12:35 |
| *** wolverineav has joined #openstack-nova | 12:36 | |
| *** janki has quit IRC | 12:41 | |
| *** pbing19 has joined #openstack-nova | 12:43 | |
| *** snevi has joined #openstack-nova | 12:43 | |
| *** janki has joined #openstack-nova | 12:44 | |
| *** dpawlik has quit IRC | 12:51 | |
| *** janki has quit IRC | 12:52 | |
| *** janki has joined #openstack-nova | 12:53 | |
| *** janki has quit IRC | 12:54 | |
| *** janki has joined #openstack-nova | 12:54 | |
| *** udesale has joined #openstack-nova | 12:55 | |
| *** xek_ has quit IRC | 13:01 | |
| *** xek_ has joined #openstack-nova | 13:02 | |
| *** yan0s has quit IRC | 13:03 | |
| *** tbachman has joined #openstack-nova | 13:05 | |
| *** tbachman_ has joined #openstack-nova | 13:09 | |
| *** wolverineav has quit IRC | 13:09 | |
| *** tbachman has quit IRC | 13:10 | |
| *** tbachman_ is now known as tbachman | 13:10 | |
| *** markvoelker has joined #openstack-nova | 13:11 | |
| *** ttsiouts has joined #openstack-nova | 13:11 | |
| aspiers | cdent: you around? I'm a bit confused whether a compute driver should be able to provide a CUSTOM_ trait or not. | 13:12 |
| *** itlinux has joined #openstack-nova | 13:12 | |
| *** mvkr has joined #openstack-nova | 13:13 | |
| aspiers | https://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/resource-provider-traits.html suggests not but https://review.openstack.org/#/c/538498/7/nova/virt/driver.py@934 seems to contradict that | 13:13 |
| openstackgerrit | sean mooney proposed openstack/os-vif master: remove use of brctl from vif_plug_linux_bridge https://review.openstack.org/636822 | 13:15 |
| cdent | aspiers: I'm around now. What's up? | 13:15 |
| aspiers | that spec suggests CUSTOM_* was just for admin/operator usage, but maybe it's for everything not in os-traits? | 13:16 |
| aspiers | I see the placement API prevents a PUT of any trait without CUSTOM_ prefix | 13:16 |
| aspiers | would a virt driver ever want to provide a trait not in os-traits? | 13:16 |
| aspiers | 3rd-party drivers maybe? | 13:17 |
| *** ttsiouts has quit IRC | 13:18 | |
| *** ttsiouts has joined #openstack-nova | 13:19 | |
| *** itlinux has quit IRC | 13:21 | |
| *** itlinux has joined #openstack-nova | 13:22 | |
| *** dpawlik has joined #openstack-nova | 13:23 | |
| cdent | aspiers: sorry for the delay. It depends on who you ask. | 13:23 |
| cdent | The hope is that anything that is the result of the virt driver "knowing things" about it's environment would be traits in os-traits | 13:24 |
| *** sdake has joined #openstack-nova | 13:24 | |
| cdent | and as things are needed by the virt drivers they get added to os-traits | 13:24 |
| *** yan0s has joined #openstack-nova | 13:25 | |
| cdent | but it's pretty clear that's not always going to be realistic, but, as you say placement will only allow CUSTOM_* traits to be created over the api | 13:25 |
| cdent | s/it's/its/ | 13:25 |
| * aspiers notes a fellow punctuation perfectionist ;-) | 13:26 | |
| kashyap | stephenfin: Untangling the mess out of it turning out to be more painful than expected :-( | 13:26 |
| cdent | aspiers: it's more a matter of trying (and failing) to fix my hasty typing disease. It's especially bad with contractions and homophones. | 13:26 |
| kashyap | "the mess" -- remove the 'sclplm'-only first. | 13:26 |
| aspiers | cdent: so you mean that for now at least, we have to allow for drivers providing traits not in os-traits? but would those traits always have the CUSTOM_ prefix, or not necessarily? | 13:27 |
| cdent | If a driver needs to use something that's not in os-traits they have two choices: | 13:27 |
| cdent | * add it to os-traits | 13:27 |
| cdent | * use a CUSTOM_* | 13:27 |
| cdent | ideally the former would be the go to thing | 13:27 |
| *** itlinux has quit IRC | 13:28 | |
| aspiers | got it | 13:29 |
| *** itlinux has joined #openstack-nova | 13:32 | |
| *** gokhani has joined #openstack-nova | 13:32 | |
| *** agopi has quit IRC | 13:33 | |
| *** med_ has joined #openstack-nova | 13:34 | |
| *** itlinux has quit IRC | 13:37 | |
| *** gbarros has joined #openstack-nova | 13:39 | |
| *** jmlowe has quit IRC | 13:41 | |
| *** itlinux has joined #openstack-nova | 13:42 | |
| *** markvoelker has quit IRC | 13:43 | |
| *** hamzy has joined #openstack-nova | 13:44 | |
| *** Dinesh_Bhor has joined #openstack-nova | 13:45 | |
| aspiers | cdent: so this? https://pasteboard.co/I1Tbzp2.png | 13:47 |
| *** itlinux has quit IRC | 13:47 | |
| openstackgerrit | Silvan Kaiser proposed openstack/nova master: Exec systemd-run without --user flag in Quobyte driver https://review.openstack.org/554195 | 13:48 |
| tssurya | mriedem, dansmith: under which section of the admin docs would you prefer the down cell to be in ? or should I just start w new one? | 13:48 |
| kaisers | stephenfin: Hi! FYI: Followed up on your comments on https://review.openstack.org/#/c/522245/ and https://review.openstack.org/#/c/554195/ | 13:49 |
| *** dave-mccowan has joined #openstack-nova | 13:49 | |
| *** amorin has quit IRC | 13:50 | |
| *** janki has quit IRC | 13:54 | |
| *** eharney has joined #openstack-nova | 13:55 | |
| *** ttsiouts has quit IRC | 14:04 | |
| *** ttsiouts has joined #openstack-nova | 14:04 | |
| *** sdake has quit IRC | 14:05 | |
| *** ccamacho has joined #openstack-nova | 14:05 | |
| *** jmlowe has joined #openstack-nova | 14:07 | |
| *** wolverineav has joined #openstack-nova | 14:07 | |
| *** liuyulong has quit IRC | 14:08 | |
| *** ttsiouts has quit IRC | 14:09 | |
| *** ttsiouts has joined #openstack-nova | 14:09 | |
| *** Dinesh_Bhor has quit IRC | 14:10 | |
| *** sdake has joined #openstack-nova | 14:13 | |
| openstackgerrit | Hamdy Khader proposed openstack/os-vif master: Add create_port field in VIFPortProfileOpenVSwitch profile https://review.openstack.org/636061 | 14:17 |
| stephenfin | kaisers: Sweet. I've left comments on the systemd one. Might be as easy discuss here if you disagree | 14:17 |
| stephenfin | kaisers: I'm well aware of how many revisions it's gone through too. Sorry :( | 14:17 |
| *** ccamacho has quit IRC | 14:18 | |
| *** sdake has quit IRC | 14:19 | |
| *** itlinux has joined #openstack-nova | 14:22 | |
| *** ccamacho has joined #openstack-nova | 14:22 | |
| kaisers | stephenfin: mmh, driver changes have outgrown the tests, I'm going through those... | 14:22 |
| *** mriedem has joined #openstack-nova | 14:25 | |
| *** xek__ has joined #openstack-nova | 14:28 | |
| *** itlinux has quit IRC | 14:30 | |
| *** xek_ has quit IRC | 14:31 | |
| cdent | aspiers: was on a walk. parsing that image... | 14:32 |
| *** yan0s has quit IRC | 14:34 | |
| *** cfriesen has joined #openstack-nova | 14:34 | |
| *** lbragstad has joined #openstack-nova | 14:34 | |
| mriedem | melwitt: so on https://review.openstack.org/#/c/633351/ you're picking up a marker instance record from an earlier data migration | 14:36 |
| mriedem | and that marker instance doesn't have a user_id set | 14:36 |
| *** sdake has joined #openstack-nova | 14:36 | |
| mriedem | hence the infinite loop | 14:36 |
| stephenfin | kaisers: Addressed the other one too https://review.openstack.org/#/c/522245/ | 14:37 |
| kaisers | stephenfin: thnx! | 14:38 |
| mriedem | melwitt: this is the migration that creates the marker instance with the 0'ed uuid and no user_id https://github.com/openstack/nova/blob/ab5a9bba31664e74c1e866c620b0d284d1d4f4cb/nova/objects/virtual_interface.py#L301 | 14:38 |
| *** _alastor_ has joined #openstack-nova | 14:38 | |
| *** wolverineav has quit IRC | 14:39 | |
| mriedem | there must also be a data migration that creates a marker instance mapping with the same 00000000-0000-0000-0000-000000000000 uuid | 14:39 |
| *** mriedem has quit IRC | 14:40 | |
| *** mriedem has joined #openstack-nova | 14:40 | |
| *** markvoelker has joined #openstack-nova | 14:41 | |
| *** _alastor_ has quit IRC | 14:43 | |
| aspiers | mriedem: please can you sanity check my understanding too? https://pasteboard.co/I1Tbzp2.png | 14:44 |
| mriedem | the capabilities patch being the one you're trying to rebase? | 14:45 |
| mriedem | then yes i think so | 14:45 |
| aspiers | yes, that one | 14:46 |
| *** munimeha1 has joined #openstack-nova | 14:46 | |
| aspiers | well, I've succeeded in rebasing it ;-) the struggle now is finishing off the tests | 14:46 |
| mriedem | the compute "owns" the capabilities it reports, and if something external removes it then it will get put back on the next periodic task run | 14:46 |
| mriedem | if an admin wants to schedule around hosts with a given capability, they use forbidden traits in their flavor | 14:46 |
| aspiers | but the driver can still provide other traits outside this new capabilities-to-traits mechanism, right? like cpu flags etc. | 14:47 |
| mriedem | correct | 14:47 |
| aspiers | but it can also provide CUSTOM_* stuff which isn't capabilities? | 14:47 |
| mriedem | the libvirt driver would be reporting traits that are both cpu flags and capabilities, like COMPUTE_SUPPORTS_MULTIATTACH or whatever | 14:47 |
| mriedem | no i don't think so | 14:47 |
| aspiers | is that COMPUTE_SUPPORTS_MULTIATTACH or CUSTOM_COMPUTE_SUPPORTS_MULTIATTACH? | 14:48 |
| mriedem | not custom | 14:48 |
| mriedem | it's a standard trait | 14:48 |
| aspiers | ah OK | 14:48 |
| mriedem | https://github.com/openstack/os-traits/tree/master/os_traits/compute | 14:48 |
| openstackgerrit | Jan Gutter proposed openstack/os-vif master: Clean up versioned object backlevelling code https://review.openstack.org/630976 | 14:48 |
| mriedem | https://github.com/openstack/os-traits/blob/master/os_traits/compute/volume.py#L24 | 14:49 |
| mriedem | COMPUTE_TRUSTED_CERTS is another https://github.com/openstack/os-traits/blob/master/os_traits/compute/__init__.py#L19 | 14:49 |
| aspiers | got it | 14:49 |
| mriedem | the *only* driver i'm not sure about is ironic since i think nova proxies the traits from the ironic node to placement | 14:50 |
| mriedem | i'm not sure if those are made CUSTOM_ | 14:50 |
| mriedem | that happens here https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L831 | 14:50 |
| mriedem | looks like the traits on the node are just passed through as-is | 14:50 |
| mriedem | so they can be standard or custom | 14:51 |
| mriedem | jroll: ^ is that accurate? | 14:51 |
| mriedem | https://developer.openstack.org/api-ref/baremetal/?expanded=show-node-details-detail#node-traits-nodes | 14:51 |
| mriedem | "Traits can be either standard or custom." | 14:51 |
| *** yan0s has joined #openstack-nova | 14:52 | |
| aspiers | mriedem: so the puzzle I'm currently facing with tests is this: I want to remove a CUSTOM_ trait in order to test that the periodic update replaces it correctly. But if I delete using the placement API fixtures then the trait is still in the provider tree, so it doesn't recognise that the traits are out of sync due to https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L1046 | 14:52 |
| *** sdake has quit IRC | 14:53 | |
| aspiers | if I comment out that return then it works, but I'm not sure if that will break something else | 14:53 |
| *** udesale has quit IRC | 14:53 | |
| *** itlinux has joined #openstack-nova | 14:53 | |
| jroll | mriedem: they can only be custom: https://developer.openstack.org/api-ref/baremetal/#node-traits-nodes | 14:54 |
| jroll | er wait | 14:54 |
| mriedem | so set_traits_for_provider is being called with the traits from the provider tree in the compute driver rather than the traits from the placement API? | 14:54 |
| jroll | no, they can be both, you're right | 14:54 |
| aspiers | mriedem: correct | 14:55 |
| aspiers | (I think anyway; my head is beginning to hurt a bit at this stage) | 14:55 |
| mriedem | aspiers: that sounds like an efried question | 14:56 |
| *** itlinux has quit IRC | 14:56 | |
| aspiers | OK | 14:56 |
| mriedem | and i'm about to jump on a call | 14:56 |
| aspiers | OK np, thanks for the help | 14:56 |
| mriedem | eric should be well rested after his presidents day celebrations | 14:56 |
| efried | aspiers: gimme a sec | 14:56 |
| aspiers | haha | 14:56 |
| *** itlinux has joined #openstack-nova | 14:56 | |
| efried | yeah, it wasn't what you would call a relaxing day. | 14:56 |
| mriedem | was someone out protesting the border wall again | 14:57 |
| *** itlinux has quit IRC | 14:57 | |
| aspiers | %-/ | 14:57 |
| efried | aspiers: should I read back or you wanna summarize? | 14:58 |
| aspiers | I'll try to summarise | 14:58 |
| efried | or that | 14:58 |
| stephenfin | kashyap: What Georg Hoesch has pointed out here looks correct https://review.openstack.org/#/c/632507/12/nova/virt/libvirt/driver.py | 14:58 |
| aspiers | it looks to me like set_traits_for_provider() is currently designed as a push from the provider tree to placement, rather than a bidirectional sync | 14:58 |
| stephenfin | kashyap: If you agree, I'm happy to +2 as-is | 14:58 |
| stephenfin | (Don't know how far you got in splitting up that patch) | 14:58 |
| * efried will try to honour aspiers's spelling for a bit... | 14:58 | |
| kashyap | stephenfin: Yeah, just read that. In the last 2 hours I came to the conclusion that we should untangle it | 14:59 |
| kashyap | stephenfin: Phew. I was just about to admit myself to the "sanity ward" | 14:59 |
| aspiers | :) | 14:59 |
| efried | aspiers: true story. Up to now, virt drivers have been fully responsible for knowing what traits compute "owns". | 14:59 |
| *** sdake has joined #openstack-nova | 14:59 | |
| kashyap | stephenfin: That consoles stuff is mind-warping (to my weak brain, at least) | 14:59 |
| aspiers | efried: so the puzzle I'm currently facing with tests is this: I want to remove a CUSTOM_ trait in test_servers.py in order to test that the periodic update replaces it correctly. But if I delete using the placement API fixtures then the trait is still in the provider tree, so it doesn't recognise that the traits are out of sync due to | 14:59 |
| stephenfin | kashyap: It's a maze. So many conditionals | 14:59 |
| aspiers | https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L1046 | 14:59 |
| kashyap | And I'm glad I Cced Georg to also double-check. He writes thorough comments | 14:59 |
| efried | aspiers: This will be (I think) the first time code outside of the virt driver, but inside n-cpu, will assert "ownership" of traits. | 15:00 |
| stephenfin | kashyap: So, happy for me to go ahead and approve this as-is? | 15:00 |
| kashyap | stephenfin: Yeah, did you see the reworked table? It was a cathartic relief to turn the tri-state to binary | 15:00 |
| kashyap | stephenfin: Yes, please | 15:00 |
| stephenfin | done and done | 15:00 |
| efried | aspiers: okay, I understand the problem. Give us a tick to suss it out... | 15:00 |
| * kashyap goes to comment | 15:01 | |
| kashyap | stephenfin: Excellent. | 15:01 |
| *** jobewan has joined #openstack-nova | 15:01 | |
| *** whoami-rajat has quit IRC | 15:01 | |
| kashyap | stephenfin: Unrelated: on the top-most patch, on that nuking of 'if' conditional from _create_pty_device() -- I noticed it, had a draft comment to myself, before I saw yours. | 15:02 |
| kashyap | Will address that, too | 15:02 |
| stephenfin | kashyap: ack | 15:02 |
| *** awaugama has joined #openstack-nova | 15:03 | |
| aspiers | efried: this probably doesn't help, but this is how things work with the capabilities patch from mriedem / me: https://goo.gl/haARAc | 15:03 |
| aspiers | I didn't get as far as modelling the sync with placement | 15:04 |
| aspiers | because I didn't expect to need to change that | 15:04 |
| efried | aspiers: Okay, so this is pretty tricky. We implemented a SIGHUP trap to trigger the report client to flush its cache and re-pull everything from placement. The operator is *supposed* to SIGHUP n-cpu any time they make an "out-of-band" change like the ones you're simulating here. | 15:04 |
| efried | aspiers: So technically what you need to do is call ComputeManager.reset() before you hit the periodic and your test will work. | 15:05 |
| *** awalende has quit IRC | 15:05 | |
| aspiers | so that reset is more heavyweight than a periodic update? | 15:05 |
| efried | aspiers: But it points to an interesting real-world issue, which is: what if the operator doesn't do that? | 15:05 |
| aspiers | right | 15:05 |
| efried | aspiers: Yes, it triggers the report client to blow away its provider tree cache completely, so on the periodic it will go re-retrieve everything. | 15:05 |
| *** awalende has joined #openstack-nova | 15:05 | |
| aspiers | do we really need that have_traits_changed() check? is it more than an optimisation? | 15:05 |
| efried | it is exactly an optimiz^Hsation, so that we don't have to query placement every periodic as to whether things have changed. | 15:06 |
| aspiers | ah yeah | 15:06 |
| aspiers | how often is the periodic? | 15:06 |
| efried | uh | 15:07 |
| *** awalende has quit IRC | 15:07 | |
| aspiers | I guess with 10k compute nodes it would be a problem even if it was hourly | 15:07 |
| *** awalende has joined #openstack-nova | 15:07 | |
| *** awalende has quit IRC | 15:07 | |
| efried | yes, exactly. And in fact we implemented a way to switch off the association refresh entirely. So there's a timer that's separate from the periodic timer, and if that one expires, we go re-pull anyway. | 15:08 |
| aspiers | hrm | 15:08 |
| efried | but CERN wound up having to set that to ~inf or it brought their data center to its knees. | 15:08 |
| aspiers | haha | 15:08 |
| efried | and in fact, we found we don't need it | 15:09 |
| efried | so we enabled setting it to zero, meaning "off". | 15:09 |
| efried | this just merged a couple weeks ago. | 15:09 |
| aspiers | interesting | 15:09 |
| efried | so what would happen is, if the report client felt like it needed to update anything about the traits after your oob update, it would bounce on a generation conflict, re-GET, redrive its tweak, and redo the push. | 15:10 |
| aspiers | so my test could just call self.compute.manager.reportclient.clear_provider_cache() ? | 15:10 |
| efried | yes. And that's the right thing... for your test. | 15:10 |
| aspiers | or reset() directly | 15:10 |
| efried | I'm just not super happy with the real-world issue it points to. | 15:10 |
| aspiers | agreed | 15:10 |
| *** awalende has joined #openstack-nova | 15:11 | |
| aspiers | I guess longer term traits from compute drivers could be marked as read-only? | 15:12 |
| aspiers | so then they couldn't be deleted via placement API | 15:12 |
| aspiers | even CUSTOM_* ones | 15:12 |
| *** mlavalle has joined #openstack-nova | 15:12 | |
| aspiers | only the driver which originated it could delete it | 15:13 |
| aspiers | or traits could have an owner associated explicitly | 15:13 |
| aspiers | so then creation and deletion would always both one-way pushes from provider tree to placement | 15:14 |
| *** markvoelker has quit IRC | 15:14 | |
| *** rpittau has quit IRC | 15:14 | |
| *** awalende has quit IRC | 15:15 | |
| efried | aspiers: Have a gander at this: https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_report_cpu_traits.py | 15:15 |
| kashyap | stephenfin: What do you mean by a "UT"? | 15:15 |
| efried | aspiers: Yes, we discussed those things a bit at a PTG or two, decided on this. | 15:15 |
| stephenfin | kashyap: Unit Test | 15:15 |
| kashyap | Ah, thanks. :-) | 15:16 |
| stephenfin | I'd assume, anyway | 15:16 |
| kashyap | stephenfin: Yes, you win, because the `wtf` tool actually detects the acronym | 15:16 |
| kashyap | $> rpm -qf `which wtf` | 15:16 |
| kashyap | bsd-games-2.17-57.fc28.x86_64 | 15:16 |
| kashyap | It's super-tiny RPM. And comes with an acryonym file | 15:17 |
| aspiers | efried: I found this post-Dublin conversation http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2018-03-12.log.html#t2018-03-12T16:09:22 | 15:18 |
| *** whoami-rajat has joined #openstack-nova | 15:18 | |
| *** Luzi has quit IRC | 15:19 | |
| aspiers | I was reading through to try to catch up on a year's worth of thinking (not to mention several decades of nova experience...) | 15:19 |
| aspiers | it was linked from https://review.openstack.org/#/c/552122/4 | 15:19 |
| aspiers | efried: but OK, for now I'll just do reset() | 15:20 |
| efried | aspiers: Yeah, that's the right thing. Not sure what to do about the other. Maybe we just leave it alone and hope it doesn't become a problem. Operators always do what they're supposed to, right? | 15:20 |
| aspiers | haha yeah sure, always ;-) | 15:21 |
| *** pbing19 has quit IRC | 15:22 | |
| *** jmlowe has quit IRC | 15:23 | |
| *** jmlowe has joined #openstack-nova | 15:24 | |
| aspiers | efried: it works! | 15:28 |
| *** sdake has quit IRC | 15:28 | |
| efried | woot! | 15:30 |
| aspiers | It's been an unexpectedly rough 24 hours on this. Took me many hours yesterday trawling through with pdb to find this microversion issue https://review.openstack.org/#/c/637657/ | 15:31 |
| aspiers | Once things go wrong in the middleware that's a whole can of voodoo worms which I'm not used to opening up | 15:31 |
| efried | holy unnecessary shim, Batman | 15:33 |
| efried | I remember last time I encountered these fake_* methods I griped about how they should just diaf. | 15:33 |
| aspiers | X-) | 15:33 |
| *** jmlowe has quit IRC | 15:34 | |
| efried | aspiers: in fact, I may demand that we do that instead of the fix you've proposed. | 15:35 |
| aspiers | That would make me sad, because it would introduce a big new dependency to my SEV work | 15:36 |
| *** sdake has joined #openstack-nova | 15:36 | |
| *** pbing19 has joined #openstack-nova | 15:36 | |
| efried | aspiers: It wouldn't be a big thang; just needs someone to do it. And since I'm the one being difficult... | 15:36 |
| aspiers | I'm trying to do the right thing by landing the capabilities-to-traits feature and then implementing the SEV trait on top of it | 15:36 |
| *** wolverineav has joined #openstack-nova | 15:37 | |
| aspiers | rather than just tweaking the libvirt driver's u_p_t() | 15:37 |
| efried | okay, I hear you. | 15:37 |
| aspiers | The latter would be the easy way out, but I wanted to give something useful upstream before asking for "our" feature work to be accepted | 15:37 |
| efried | Give me half an hour? | 15:37 |
| aspiers | Oh wow, well sure, if you're that fast :) | 15:38 |
| jangutter | kashyap: wtf's pretty nifty. It's got dry, crud, rest and a bunch of others that are tricky to google. | 15:38 |
| efried | aspiers: I remember thinking it would be pretty easy. 25 minutes of that is going to be refreshing myself on the code. | 15:38 |
| aspiers | It sounded to my inexperienced ears like it would take days | 15:38 |
| efried | aspiers: What test were you running when you hit this? | 15:38 |
| kashyap | jangutter: Yeah. | 15:38 |
| aspiers | efried: the patch which sits on top of it | 15:38 |
| aspiers | efried: https://review.openstack.org/#/c/538498/10 | 15:39 |
| aspiers | but let me upload a working PS 11 | 15:39 |
| aspiers | which will even pass PEP8 *shock* :) | 15:39 |
| openstackgerrit | sean mooney proposed openstack/nova master: libvirt: auto detach/attach sriov ports on migration https://review.openstack.org/629589 | 15:39 |
| efried | aspiers: test_servers presumably? | 15:39 |
| aspiers | turns out that tox -e flake8 pretends to do something useful but actually checks nothing at all ... | 15:39 |
| aspiers | correct | 15:39 |
| aspiers | stestr --test-path=./nova/tests/functional run -n nova.tests.functional.test_servers.TraitsTrackingTests.test_resource_provider_traits | 15:40 |
| aspiers | if you want the quicker version | 15:40 |
| efried | okay, thanks. | 15:40 |
| kashyap | stephenfin: I'm still a bit squirmy about this whole muddling with s390x, and its console devices. Because both "sclp" and "sclplm" are for different purposes, per s390x maintainers. And I don't have access to a machine to test it all | 15:40 |
| *** mdbooth has joined #openstack-nova | 15:40 | |
| efried | aspiers: btw, if you install tox 3.1.1 (uh, which I guess I forced you to do anyway), tox -e functional -- test_resource_provider_traits should be almost as quick. | 15:40 |
| kashyap | So I was just poking the code to see until it poked me back... | 15:40 |
| aspiers | efried: yeah I figure that out, but I find that tox still adds unacceptable overhead | 15:41 |
| efried | for test discovery? | 15:41 |
| aspiers | the {posargs} trick is handy though | 15:41 |
| kashyap | stephenfin: Anyway, so far from our code audit it is mergeable; so no need to belabour more on it now. </EOM> | 15:41 |
| * kashyap bbiab | 15:41 | |
| aspiers | not just test discovery | 15:41 |
| efried | We got rid of the bytecode | 15:41 |
| aspiers | efried: it takes ~2s on my machine to get to the point of launching stestr | 15:42 |
| aspiers | it has to go through all the virtualenv stuff first | 15:42 |
| mdbooth | mriedem: If you recall this one: https://review.openstack.org/#/c/626952/ . It looks like the commit message there is rubbish. I haven't been able to reproduce the underlying issue and I suspect it's actually been fixed by upgrading libraries. Haven't worked out which ones, though. | 15:43 |
| mdbooth | That said, I still like this cleanup, and I suspect the approach is slightly more robust to similar issues. Is it worth rewriting the commit message and keeping it around? | 15:43 |
| mdbooth | If there's no interest I'll just drop it. Or lyarwood will, anyway :) | 15:44 |
| mriedem | i don't have a strong opinion | 15:45 |
| *** lpetrut has quit IRC | 15:45 | |
| mdbooth | mriedem: ack. I'll probably drop it then as it's likely to languish. Thanks. | 15:46 |
| mdbooth | lyarwood: ^^^ Lets drop it. | 15:46 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: WIP: Convert driver supported capabilities to compute node provider traits https://review.openstack.org/538498 | 15:49 |
| aspiers | efried: there's PS 11 with a working test which includes the reset() | 15:49 |
| efried | aspiers: The test was working for me at ps10 | 15:50 |
| aspiers | efried: yeah but it didn't test the reappearance of the trait | 15:51 |
| aspiers | efried: https://review.openstack.org/#/c/538498/10..11/nova/tests/functional/test_servers.py@2274 | 15:52 |
| *** sdake has quit IRC | 15:52 | |
| efried | okay. It doesn't really matter; I just need something that's supposed to hit that fake_delete | 15:52 |
| aspiers | good point | 15:52 |
| *** maciejjozefczyk has quit IRC | 15:53 | |
| *** pbing19 has quit IRC | 15:55 | |
| *** sdake has joined #openstack-nova | 15:58 | |
| *** _alastor_ has joined #openstack-nova | 16:00 | |
| mriedem | cdent: so the nova functional tests - they use the placement fixture from extracted placement right? not the in-tree placement code. so doing https://review.openstack.org/#/c/637892/ in nova would only be for runtime if we copied that | 16:00 |
| cdent | yes | 16:02 |
| mriedem | ok | 16:02 |
| *** sdake has quit IRC | 16:03 | |
| *** hongbin has joined #openstack-nova | 16:03 | |
| cdent | mriedem: plus that osa thing that m*naser was gunna set up | 16:05 |
| openstackgerrit | sean mooney proposed openstack/os-vif master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610068 | 16:08 |
| mriedem | cdent: yeah i'm more concerned (right now anyway) on the subunit parser thing | 16:08 |
| * cdent nods | 16:08 | |
| *** wolverineav has quit IRC | 16:10 | |
| bauzas | efried: others, I found yet another issue with vgpu reshapes... | 16:11 |
| *** markvoelker has joined #openstack-nova | 16:11 | |
| bauzas | efried: others, given we need to recreate mdevs when rebooting, we need to pass allocations when init_host() | 16:12 |
| bauzas | I wrote a bit of comment in the first change, but I'm working on a change that will do this | 16:12 |
| *** pbing19 has joined #openstack-nova | 16:16 | |
| mdbooth | lyarwood: https://review.openstack.org/#/c/623489/ | 16:17 |
| mdbooth | lyarwood: Just looking at the unit tests, but feel free to consider ^^^ anyway. | 16:17 |
| lyarwood | mdbooth: ack and ack looking | 16:20 |
| kashyap | BTW, sean-k-mooney: thanks for inadvertently reminding that this is a pending item a few weeks ago! Almost lost track of it: https://review.openstack.org/#/c/632507 | 16:24 |
| sean-k-mooney | kashyap oh the libvirt version bump ya | 16:26 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: implement reshaper for vgpu https://review.openstack.org/599208 | 16:31 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add functional test for libvirt vgpu reshape https://review.openstack.org/631559 | 16:31 |
| *** jaypipes has quit IRC | 16:36 | |
| *** jaypipes has joined #openstack-nova | 16:36 | |
| *** markvoelker has quit IRC | 16:44 | |
| *** macza has joined #openstack-nova | 16:47 | |
| *** dtantsur is now known as dtantsur|afk | 16:48 | |
| *** hamzy has quit IRC | 16:50 | |
| *** hongbin has quit IRC | 16:54 | |
| *** ttsiouts has quit IRC | 16:56 | |
| sean-k-mooney | so are we still going ahead with https://review.openstack.org/#/c/634949/ since the cinder volume test in tempest-full are continuosly failing. | 16:56 |
| *** ttsiouts has joined #openstack-nova | 16:56 | |
| *** pcaruana has quit IRC | 16:57 | |
| mriedem | what cinder volume tests? | 16:59 |
| mriedem | we did do https://review.openstack.org/#/c/634970/ to hopefully help with the tooz connection errors | 17:00 |
| *** tssurya has quit IRC | 17:01 | |
| sean-k-mooney | tempest.api.compute.volumes.test_attach_volume_negative.AttachVolumeNegativeTest.test_attach_attached_volume_to_same_server | 17:01 |
| *** wolverineav has joined #openstack-nova | 17:01 | |
| *** ttsiouts has quit IRC | 17:01 | |
| *** helenafm has quit IRC | 17:01 | |
| sean-k-mooney | i dont know if it sthe same two but i have notice 1-2 cinder volume attachment test filaing in a few reivews i looked at recently | 17:02 |
| sean-k-mooney | usually either with a timeout or sometime with Invalid volue errors | 17:03 |
| sean-k-mooney | like http://logs.openstack.org/15/620115/23/check/tempest-full/fcabb4b/testr_results.html.gz | 17:03 |
| smcginnis | mriedem: I haven't noticed that tooz issue anymore. Have you seen any since that change? | 17:03 |
| mriedem | smcginnis: http://status.openstack.org/elastic-recheck/#1810526 | 17:04 |
| mriedem | those could be stable branches, checking logstash | 17:05 |
| smcginnis | Grenade on the first one, so maybe? | 17:05 |
| mriedem | sean-k-mooney: you hit a nova bug http://logs.openstack.org/15/620115/23/check/tempest-full/fcabb4b/controller/logs/screen-n-cpu.txt.gz?level=TRACE#_Feb_19_14_49_49_277325 | 17:06 |
| mriedem | http://status.openstack.org/elastic-recheck/#1770211 | 17:06 |
| mriedem | WARNING nova.virt.block_device [None req-2c3d004a-05e7-43d3-af5e-ccac75bed5fd tempest-AttachVolumeNegativeTest-1375016298 tempest-AttachVolumeNegativeTest-1375016298] [instance: 4b50efcf-0d26-4b01-91f0-1b8b1e9eef0f] Guest refused to detach volume aea37477-6c0c-4727-8092-da3b3d2f7c5c: DeviceDetachFailed: Device detach failed for vdb: Unable to detach the device from the live config. | 17:06 |
| mriedem | i remember cfriesen asking about this still being an issue the other day | 17:06 |
| mriedem | smcginnis: yeah looks like it's hitting on grenade so it's just a stable branch issue with devstack at this poin, | 17:07 |
| mriedem | *point | 17:07 |
| dansmith | mriedem: I saw a ping from you fly by from last night.. can you link me again so I don't have to dig out mah logs? | 17:07 |
| * dansmith is lazy | 17:07 | |
| mriedem | i'll work on backporting those devstack / etcd changes | 17:07 |
| mriedem | dansmith: https://review.openstack.org/#/c/635315/1 | 17:07 |
| *** _fragatina has joined #openstack-nova | 17:09 | |
| dansmith | mriedem: nice | 17:10 |
| cfriesen | mriedem: smcginnis: I was hitting this:https://bugs.launchpad.net/nova/+bug/1815949 | 17:11 |
| openstack | Launchpad bug 1815949 in OpenStack Compute (nova) "missing special-case libvirt exception during device detach" [Medium,Confirmed] | 17:11 |
| smcginnis | Hmm, that's a new one to me. | 17:11 |
| sean-k-mooney | ok ya that makes sense. im pretty sure there are other voluem attachemtn failures like https://bugs.launchpad.net/cinder/+bug/1814916 too which are unrelated to tooz | 17:12 |
| mriedem | cfriesen: ok that looks different than the 'unable to detach from transient / live config' | 17:12 |
| openstack | Launchpad bug 1814916 in Cinder "MessagingTimeout in cinder-api during volume attachment update due to VolumeAttachmentNotFound in cinder-volume" [Medium,Confirmed] | 17:12 |
| mriedem | yeah i don't know what's up with that volume attachment not found one | 17:12 |
| mriedem | the api finds the record and then c-vol blows up b/c it's gone from the db, so clearly a race somewhere | 17:12 |
| mriedem | probably just need someone to trace requests in a log to see when the PUT request is made and when the DELETE request is made | 17:12 |
| cfriesen | mriedem: smcginnis: but after fixing that I'm hitting the "Guest refused to detach" issue. I'm guessing it's related to stalls we're seeing in the guest, but still digging into causes. | 17:12 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: WIP: Convert driver supported capabilities to compute node provider traits https://review.openstack.org/538498 | 17:14 |
| aspiers | mriedem, efried: I've just finished the first version of the tests which were missing for capabilities to traits: https://review.openstack.org/#/c/538498/12/nova/tests/functional/test_servers.py | 17:15 |
| mriedem | etcd changes for devstack backported https://review.openstack.org/#/q/topic:bug/1810526+(status:open+OR+status:merged) | 17:15 |
| aspiers | mriedem, efried: I'm sure you'll find plenty of things to improve, but hopefully this is a good base | 17:15 |
| aspiers | not sure if I went overkill on the tests for standard vs. custom traits, and capabilities vs. update_provider_tree | 17:16 |
| aspiers | mriedem: BTW I kept you as the author and added myself via Co-Authored-By - was that the right thing to do? | 17:22 |
| aspiers | not sure what the convention is here | 17:22 |
| mriedem | aspiers: yup | 17:24 |
| *** artom has quit IRC | 17:24 | |
| mriedem | more testing > less testing | 17:24 |
| aspiers | mriedem: also, should I put "related to blueprint expose-host-capabilities" in the commit message? | 17:24 |
| *** lpetrut has joined #openstack-nova | 17:27 | |
| mriedem | hmm, that's not approved https://blueprints.launchpad.net/nova/+spec/expose-host-capabilities but the change is essentially trying to solve that same problem | 17:32 |
| mriedem | so sure | 17:32 |
| *** ociuhandu_ has joined #openstack-nova | 17:33 | |
| mriedem | the spec for that bp predates traits https://review.openstack.org/#/c/222200/ | 17:33 |
| mriedem | so it was trying to solve it with something different | 17:33 |
| *** wolverineav has quit IRC | 17:34 | |
| *** ociuhandu has quit IRC | 17:36 | |
| *** eharney has quit IRC | 17:37 | |
| *** ociuhandu_ has quit IRC | 17:38 | |
| *** psachin has quit IRC | 17:39 | |
| *** lpetrut has quit IRC | 17:40 | |
| *** markvoelker has joined #openstack-nova | 17:41 | |
| *** agopi has joined #openstack-nova | 17:41 | |
| *** NewBruce has quit IRC | 17:42 | |
| *** mma has quit IRC | 17:42 | |
| sean-k-mooney | adrianc: o/ are you wokring on a new version of https://review.openstack.org/#/c/620115/ | 17:43 |
| *** NewBruce has joined #openstack-nova | 17:43 | |
| sean-k-mooney | adrianc: if not i might start adressing stephenfin nits after i get something to eat. | 17:44 |
| *** ccamacho has quit IRC | 17:46 | |
| *** ociuhandu has joined #openstack-nova | 17:48 | |
| *** ociuhandu has quit IRC | 17:52 | |
| *** derekh has quit IRC | 17:53 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance to make place for port healing https://review.openstack.org/637953 | 17:54 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance (2) https://review.openstack.org/637954 | 17:54 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.openstack.org/637955 | 17:54 |
| *** yan0s has quit IRC | 17:54 | |
| *** davidsha has quit IRC | 17:57 | |
| *** ociuhandu has joined #openstack-nova | 18:04 | |
| *** ociuhandu has quit IRC | 18:08 | |
| melwitt | mriedem: omg, thank you. I was completely baffled by the 0'ed out instance uuid and could not imagine how that could happen | 18:09 |
| *** mdbooth_ has joined #openstack-nova | 18:11 | |
| melwitt | alex_xu: by unrelated, I meant that project_only=True isn't related to the instance target. the only thing that project_only=True does is enforce the request context project, not the instance project. so I was thinking that changing to use instance target is an unrelated change from removing project_only=True. if we remove project_only=True without changing instance target, we get the same behavior as today except that users choose to | 18:12 |
| melwitt | enforce request context project via policy instead of hard-coded | 18:12 |
| *** markvoelker has quit IRC | 18:14 | |
| *** mdbooth has quit IRC | 18:14 | |
| efried | aspiers: Still around? | 18:16 |
| *** hamzy has joined #openstack-nova | 18:17 | |
| aspiers | efried: just got back | 18:20 |
| efried | aspiers: Sorry that took a little longer than expected (interrupted by internal work, among other things), but I got it figured out. Now I have to go around and fix all the test cases that call into the shimmed API. | 18:20 |
| aspiers | efried: nice work :) | 18:20 |
| efried | WIP incoming, lemme finish writing up the commit message. | 18:20 |
| aspiers | I bet whatever you changed would have taken me a week | 18:20 |
| aspiers | mriedem: OK thanks, I'll do that | 18:21 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: De-shim PlacementFixture https://review.openstack.org/637959 | 18:21 |
| efried | aspiers: ^ | 18:21 |
| aspiers | mriedem, melwitt: is it OK to reference 2 blueprints in a single commit message? | 18:21 |
| aspiers | efried: ack | 18:21 |
| efried | I originally wrote it on top of your patch, to make sure your test case worked, and it did. | 18:22 |
| efried | But this version will be lacking your delete helper. | 18:22 |
| efried | Once I've got it polished I'll rebase it under yours. | 18:22 |
| efried | or you can | 18:22 |
| aspiers | Sure, I can do that | 18:22 |
| aspiers | I have some other tweaks to go in mine anyway | 18:22 |
| melwitt | aspiers: I don't see why not. doing that would just put the link on both lp whiteboard AFAIK | 18:23 |
| aspiers | not to mention fixes for the glaring errors you and mriedem are about to uncover ;-) | 18:23 |
| aspiers | melwitt: cool thanks, that's what I expected | 18:23 |
| aspiers | woohoo, my version switcher patch landed on https://docs.openstack.org/ | 18:25 |
| aspiers | hopefully it doesn't break anything | 18:25 |
| aspiers | s/version/release/ | 18:25 |
| *** tssurya has joined #openstack-nova | 18:28 | |
| *** ociuhandu has joined #openstack-nova | 18:30 | |
| *** artom has joined #openstack-nova | 18:32 | |
| *** artom has quit IRC | 18:33 | |
| *** artom has joined #openstack-nova | 18:33 | |
| *** hongbin has joined #openstack-nova | 18:34 | |
| *** hongbin has joined #openstack-nova | 18:35 | |
| *** mvkr has quit IRC | 18:36 | |
| *** lpetrut has joined #openstack-nova | 18:39 | |
| openstackgerrit | Boris Bobrov proposed openstack/nova master: Fallback to the first element if no nodes match https://review.openstack.org/637965 | 18:40 |
| *** ccamacho has joined #openstack-nova | 18:42 | |
| *** wolverineav has joined #openstack-nova | 18:50 | |
| *** wolverineav has quit IRC | 18:50 | |
| *** wolverineav has joined #openstack-nova | 18:50 | |
| *** snevi has quit IRC | 18:53 | |
| *** gbarros has quit IRC | 19:00 | |
| *** pbing19 has quit IRC | 19:01 | |
| *** mvkr has joined #openstack-nova | 19:07 | |
| *** xek_ has joined #openstack-nova | 19:07 | |
| *** xek__ has quit IRC | 19:10 | |
| *** markvoelker has joined #openstack-nova | 19:11 | |
| *** xek_ has quit IRC | 19:16 | |
| *** panda is now known as panda|off | 19:17 | |
| *** lpetrut has quit IRC | 19:18 | |
| openstackgerrit | Merged openstack/nova master: api-ref: warn about changing/unsetting AZ name with instances https://review.openstack.org/635315 | 19:19 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add user_id field to InstanceMapping https://review.openstack.org/633350 | 19:29 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351 | 19:29 |
| *** sridharg has quit IRC | 19:29 | |
| *** eharney has joined #openstack-nova | 19:34 | |
| *** sdake has joined #openstack-nova | 19:35 | |
| openstackgerrit | Merged openstack/nova master: api-ref: mention policy defaults for aggregates https://review.openstack.org/635317 | 19:35 |
| efried | mriedem: easy +A if you please https://review.openstack.org/#/c/637657/ | 19:37 |
| *** jmlowe has joined #openstack-nova | 19:38 | |
| *** mgariepy has quit IRC | 19:40 | |
| *** markvoelker has quit IRC | 19:44 | |
| mriedem | +W | 19:45 |
| efried | thanks mriedem | 19:50 |
| *** sdake has quit IRC | 19:52 | |
| *** wolverineav has quit IRC | 19:53 | |
| *** wolverineav has joined #openstack-nova | 19:54 | |
| *** sdake has joined #openstack-nova | 19:57 | |
| efried | aspiers: I had to give up. Your fix is gateward. | 19:57 |
| *** sdake has quit IRC | 19:58 | |
| *** thgcorrea has quit IRC | 19:59 | |
| *** wolverineav has quit IRC | 20:00 | |
| *** openstackgerrit has quit IRC | 20:09 | |
| *** cdent has quit IRC | 20:24 | |
| *** openstackgerrit has joined #openstack-nova | 20:28 | |
| openstackgerrit | Merged openstack/nova master: Fix fake DELETE in PlacementFixture https://review.openstack.org/637657 | 20:28 |
| *** efried has quit IRC | 20:29 | |
| *** efried has joined #openstack-nova | 20:29 | |
| *** wolverineav has joined #openstack-nova | 20:31 | |
| *** tssurya has quit IRC | 20:32 | |
| *** ttsiouts has joined #openstack-nova | 20:36 | |
| *** wolverineav has quit IRC | 20:36 | |
| *** awaugama has quit IRC | 20:36 | |
| *** markvoelker has joined #openstack-nova | 20:41 | |
| openstackgerrit | Merged openstack/os-vif master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610068 | 20:42 |
| *** tbachman has quit IRC | 20:46 | |
| *** wolverineav has joined #openstack-nova | 20:50 | |
| *** wolverineav has quit IRC | 20:53 | |
| *** wolverineav has joined #openstack-nova | 20:55 | |
| *** erlon has quit IRC | 20:55 | |
| *** tesseract has quit IRC | 20:55 | |
| *** wolverineav has quit IRC | 20:55 | |
| *** wolverineav has joined #openstack-nova | 20:56 | |
| *** jmlowe has quit IRC | 20:57 | |
| *** igordc has joined #openstack-nova | 20:58 | |
| *** ttsiouts has quit IRC | 21:00 | |
| *** ttsiouts has joined #openstack-nova | 21:01 | |
| *** eharney has quit IRC | 21:03 | |
| *** ttsiouts has quit IRC | 21:05 | |
| mriedem | i wonder how many operators are trying to recover an instance from a failed resize confirm/revert where the instance is in ERROR status and they fixed something in the compute and just want to retry the confirm/revert operation, but can't b/c the API doesn't allow those operations on an instance in ERROR status. seems weird that the os-resetStatus server action API doesn't allow you to put an instance in 'resized' status agai | 21:07 |
| mriedem | rom error) | 21:07 |
| mriedem | dansmith: ever thunk on that?^ | 21:08 |
| dansmith | well, it would be pretty bad if you put it into resized status when it wasn't, | 21:08 |
| dansmith | and it'd be hard to tell when and when not to do something like that | 21:08 |
| mriedem | if you got through revert_resize on the dest but finish_revert_resize fails on the source, you can maybe hard reboot your way out of it | 21:09 |
| *** gbarros has joined #openstack-nova | 21:09 | |
| openstackgerrit | Boris Bobrov proposed openstack/nova master: Don't reference unassigned variable in xml matchers in test https://review.openstack.org/637965 | 21:09 |
| mriedem | if revert_resize on the dest fails, you're kind of stuck there now | 21:09 |
| mriedem | anywho | 21:09 |
| dansmith | right but is it realistic for an operator to know that it failed on finish_revert_resize? | 21:10 |
| dansmith | even if they fix something, | 21:10 |
| dansmith | they could reset into resized state from another place where they think it's likely to help and further break stuff | 21:10 |
| dansmith | I mean, I know what you're saying, but.. it's a dangerous tool | 21:10 |
| mriedem | sure, and i wouldn't expect most operators to know that unless they were pretty knowledgeable on low level nova | 21:10 |
| mriedem | which their time is probably just better spent on rebuilding the vm | 21:11 |
| artom | And, is it needed? I mean, if they have data they want to keep on a volume, they can just attach that to a new instance with the correct flavor? | 21:11 |
| mriedem | and writing an apology to the user | 21:11 |
| mriedem | artom: i'm thinking more about local storage, no volumes | 21:11 |
| artom | So actually, is a resize destructive in that respect? | 21:12 |
| mriedem | granted your data should be stored on a persistent volume | 21:12 |
| mriedem | no, the local disks are left intact on the source host when you resize | 21:12 |
| mriedem | they are destroyed when you confirm the resize to keep the instance on the dest host | 21:12 |
| mriedem | and re-used on the source if you revert | 21:12 |
| *** markvoelker has quit IRC | 21:13 | |
| artom | And your idea is - if the resize went to ERROR, rather than just reverting back to the source, allow them to force completion, so to speak? | 21:13 |
| mriedem | not force completion, retry | 21:14 |
| mriedem | but, | 21:14 |
| mriedem | that retry could fail if we got part way the first time | 21:14 |
| mriedem | so retrying isn't without risk either | 21:14 |
| mriedem | i.e. revert_resize on dest fails the 2nd time b/c we already deleted some stuff the first time | 21:14 |
| artom | Yeah... | 21:15 |
| artom | In that situation, what's wrong with going through the resize again, after reverting the failed attempt? | 21:15 |
| mriedem | i've just got some sticky logic in the cross-cell revert code where if something fails part way through it's not so good | 21:15 |
| mriedem | "reverting the failed attempt"? | 21:15 |
| mriedem | s/reverting/fixing/? | 21:16 |
| mnaser | maybe in an ideal world we can collect more of the cases where finish_revert_resize fails and test those out *before* starting to revert the resize | 21:16 |
| artom | Oh. You can't revert out of an ERROR, can you? | 21:16 |
| mriedem | you could reset status to active and try another resize | 21:16 |
| mriedem | no you can only confirm/revert a server in 'resized' status | 21:16 |
| mnaser | no you cant revert out of ERROR, only RESIZE_CONFIRM i think | 21:16 |
| mriedem | you can hard reboot / rebuild a server in ERROR | 21:16 |
| mnaser | tbh if you're going to hand a tool this dangerous, you might as well as have people login to their dbs and edit stuff manually | 21:17 |
| mnaser | but thats my drive-by 2 cents | 21:17 |
| artom | Which *they do*. | 21:17 |
| artom | Unfortunately. | 21:17 |
| artom | And not only that, but we help them do it. | 21:17 |
| mriedem | that kind of goes back to my original question - allowing only setting active or error in os-resetState - i wonder how many operators are manually changing status to something else to retry an operation | 21:17 |
| mnaser | wait os-resetState lets you do more than active and error? | 21:18 |
| mriedem | no | 21:18 |
| mnaser | oo | 21:18 |
| mriedem | in cinder it lets you reset volume status to just about any known volume status i think | 21:18 |
| mnaser | yeah | 21:18 |
| *** ralonsoh has quit IRC | 21:19 | |
| mnaser | tbh my workflow has always been "bring something back to as consistent of a state as it is" | 21:19 |
| mnaser | and then use api afterwards | 21:19 |
| * artom decides to read the cross-cell resize spec. | 21:20 | |
| artom | Whoa, "shards cells by hardware generation" is a thing? | 21:21 |
| *** whoami-rajat has quit IRC | 21:21 | |
| mriedem | you don't need to read the spec, i'm going to go back in my cave | 21:22 |
| artom | mriedem, just curious, and procrastinating this downstream thing :) | 21:23 |
| mriedem | feel free to read it if you want | 21:23 |
| mriedem | it is quite masterful in it's word count | 21:24 |
| artom | Yes. I'm a free man in a free country. | 21:24 |
| mriedem | sorry *its i know efried is watching | 21:24 |
| artom | Uh huh. "Masterful count" is exactly what I think of you ;) | 21:24 |
| *** wolverineav has quit IRC | 21:27 | |
| *** wolverineav has joined #openstack-nova | 21:28 | |
| mriedem | i guess in the case of normal resize failures, there is stuff in the compute on restart that tries to clean that up, | 21:29 |
| mriedem | which isn't as possible with cross-cell since it's orchestrated across 2 cells from the top | 21:29 |
| mriedem | but on revert i think the idea is basically, best effort cleanup from the target and make sure the instance is mapped back to the source so if there is an error the user can work with it there on the source with the original flavor, since they were trying to revert in the first place | 21:30 |
| *** xek has joined #openstack-nova | 21:31 | |
| artom | (This isn't really related or asked for, but I feel that if you're using cells to segregate hardware you're doing it wrong? Wouldn't that what hosts aggregates are for?) | 21:31 |
| mriedem | what if you have 10K old hosts and 10K new hosts? | 21:32 |
| *** gbarros has quit IRC | 21:32 | |
| mriedem | you want them all in the same cell with the same mq/db cluster? | 21:32 |
| mriedem | but 2 aggregates? | 21:32 |
| mriedem | you can certainly do aggregates, but cells is also for the scaling issue | 21:32 |
| mriedem | cern also segregates by hardware type i believe, | 21:33 |
| mriedem | and by vm/bm flavors | 21:33 |
| mriedem | lots of ways to slice it up | 21:33 |
| artom | Yeah, I'd understood that cells sharding was for scale | 21:33 |
| artom | So if you want to scale different hardware generations/types, it'd be cells for scale, and then in each cell aggregates of hardware | 21:34 |
| artom | So in your 10K example, it'd be 1K or whatever per cell, and 500/500 old/new hardware | 21:36 |
| artom | But I guess that ignore the flow of time | 21:36 |
| artom | You'll have set up your cells with old hardware, not necessarily leaving wiggling room to add new hardware | 21:36 |
| artom | Man, I'm really good at this procrastinating thing | 21:37 |
| *** _pewp_ has quit IRC | 21:37 | |
| *** _pewp_ has joined #openstack-nova | 21:38 | |
| *** hamzy has quit IRC | 21:41 | |
| * artom heads home | 21:43 | |
| *** wolverineav has quit IRC | 21:43 | |
| *** artom has quit IRC | 21:47 | |
| *** wolverineav has joined #openstack-nova | 21:47 | |
| *** hongbin has quit IRC | 21:49 | |
| *** sdake has joined #openstack-nova | 21:58 | |
| *** dave-mccowan has quit IRC | 22:07 | |
| *** ttsiouts has joined #openstack-nova | 22:07 | |
| *** sdake has quit IRC | 22:09 | |
| *** markvoelker has joined #openstack-nova | 22:10 | |
| *** ttsiouts has quit IRC | 22:12 | |
| *** xek_ has joined #openstack-nova | 22:16 | |
| *** gbarros has joined #openstack-nova | 22:18 | |
| *** xek has quit IRC | 22:18 | |
| *** xek_ has quit IRC | 22:21 | |
| *** rcernin has joined #openstack-nova | 22:26 | |
| *** gbarros has quit IRC | 22:27 | |
| *** gbarros has joined #openstack-nova | 22:29 | |
| openstackgerrit | sean mooney proposed openstack/os-vif master: remove brctl from vif_plug_ovs https://review.openstack.org/636821 | 22:30 |
| openstackgerrit | sean mooney proposed openstack/os-vif master: remove use of brctl from vif_plug_linux_bridge https://review.openstack.org/636822 | 22:30 |
| *** agopi has quit IRC | 22:32 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: De-shim PlacementFixture https://review.openstack.org/637959 | 22:41 |
| *** gbarros has quit IRC | 22:42 | |
| *** markvoelker has quit IRC | 22:44 | |
| *** tbachman has joined #openstack-nova | 22:47 | |
| *** tkajinam has joined #openstack-nova | 22:55 | |
| *** munimeha1 has quit IRC | 23:02 | |
| *** ccamacho has quit IRC | 23:13 | |
| *** ccamacho has joined #openstack-nova | 23:14 | |
| *** eharney has joined #openstack-nova | 23:26 | |
| *** ociuhandu has quit IRC | 23:30 | |
| *** ociuhandu_ has joined #openstack-nova | 23:30 | |
| *** imacdonn has joined #openstack-nova | 23:32 | |
| *** imacdonn_ has joined #openstack-nova | 23:32 | |
| *** imacdonn_ has quit IRC | 23:32 | |
| *** wolverineav has quit IRC | 23:34 | |
| *** wolverineav has joined #openstack-nova | 23:35 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.openstack.org/627892 | 23:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.openstack.org/631581 | 23:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.openstack.org/633853 | 23:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.openstack.org/621313 | 23:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293 | 23:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtDestTask https://review.openstack.org/627890 | 23:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.openstack.org/634832 | 23:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.openstack.org/637605 | 23:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.openstack.org/627891 | 23:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add finish_snapshot_based_resize_at_dest compute method https://review.openstack.org/635080 | 23:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.openstack.org/635646 | 23:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.openstack.org/635668 | 23:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.openstack.org/635684 | 23:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Filter duplicates from compute API get_migrations_sorted() https://review.openstack.org/636224 | 23:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize https://review.openstack.org/636253 | 23:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add confirm_snapshot_based_resize_at_source https://review.openstack.org/637058 | 23:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add ConfirmResizeTask https://review.openstack.org/637070 | 23:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add confirm_snapshot_based_resize conductor RPC method https://review.openstack.org/637075 | 23:38 |
| *** liuyulong has joined #openstack-nova | 23:40 | |
| *** wolverineav has quit IRC | 23:40 | |
| *** jmlowe has joined #openstack-nova | 23:40 | |
| *** markvoelker has joined #openstack-nova | 23:41 | |
| *** mriedem has quit IRC | 23:41 | |
| *** yaawang has quit IRC | 23:53 | |
| *** tbachman has quit IRC | 23:54 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
