| *** erlon has joined #openstack-nova | 00:07 | |
| *** itlinux_ has joined #openstack-nova | 00:12 | |
| *** itlinux has quit IRC | 00:13 | |
| *** gbarros has quit IRC | 00:20 | |
| *** gbarros has joined #openstack-nova | 00:22 | |
| *** markvoelker has joined #openstack-nova | 00:33 | |
| *** itlinux has joined #openstack-nova | 00:38 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Remove _legacy_dict methods https://review.openstack.org/636210 | 00:39 |
|---|---|---|
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add migration param to check_can_live_migrate_destination https://review.openstack.org/634605 | 00:39 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects to transmit NUMA config from dest to source https://review.openstack.org/634827 | 00:39 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.openstack.org/635669 | 00:39 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Use live_migration_claim() to check dest resources https://review.openstack.org/634606 | 00:39 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: Make dest send NUMAMigrateData to the source https://review.openstack.org/634828 | 00:39 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: update NUMA-related XML on the source https://review.openstack.org/635229 | 00:39 |
| *** itlinux_ has quit IRC | 00:40 | |
| *** ileixe has joined #openstack-nova | 00:47 | |
| *** sapd1 has joined #openstack-nova | 00:58 | |
| *** itlinux has quit IRC | 01:03 | |
| *** gbarros has quit IRC | 01:03 | |
| *** bhagyashris has joined #openstack-nova | 01:06 | |
| *** markvoelker has quit IRC | 01:07 | |
| *** moshele has quit IRC | 01:10 | |
| *** itlinux has joined #openstack-nova | 01:13 | |
| *** gbarros has joined #openstack-nova | 01:14 | |
| *** wolverineav has joined #openstack-nova | 01:15 | |
| *** mrjk has quit IRC | 01:19 | |
| *** wolverineav has quit IRC | 01:19 | |
| *** moshele has joined #openstack-nova | 01:26 | |
| *** wolverineav has joined #openstack-nova | 01:35 | |
| *** wolverineav has quit IRC | 01:38 | |
| *** itlinux has quit IRC | 01:38 | |
| *** moshele has quit IRC | 01:49 | |
| *** Dinesh_Bhor has joined #openstack-nova | 01:55 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add method to allow reset fields for root bdm in BDM obj https://review.openstack.org/614672 | 01:58 |
| *** yikun has joined #openstack-nova | 01:59 | |
| *** sdake has joined #openstack-nova | 02:00 | |
| *** cfriesen has joined #openstack-nova | 02:03 | |
| *** markvoelker has joined #openstack-nova | 02:04 | |
| *** tetsuro has joined #openstack-nova | 02:10 | |
| *** Dinesh_Bhor has quit IRC | 02:11 | |
| *** whoami-rajat has joined #openstack-nova | 02:13 | |
| *** sdake has quit IRC | 02:18 | |
| *** gbarros has quit IRC | 02:18 | |
| *** gbarros has joined #openstack-nova | 02:19 | |
| *** erlon has quit IRC | 02:19 | |
| *** gbarros has quit IRC | 02:19 | |
| *** sdake has joined #openstack-nova | 02:21 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:21 | |
| *** ileixe has quit IRC | 02:23 | |
| *** ileixe has joined #openstack-nova | 02:24 | |
| *** yedongcan has joined #openstack-nova | 02:26 | |
| *** mgoddard has quit IRC | 02:32 | |
| *** _alastor_ has joined #openstack-nova | 02:33 | |
| *** mgoddard has joined #openstack-nova | 02:34 | |
| *** markvoelker has quit IRC | 02:38 | |
| *** _alastor_ has quit IRC | 02:38 | |
| *** sdake has quit IRC | 02:44 | |
| *** psachin has joined #openstack-nova | 02:51 | |
| *** wolverineav has joined #openstack-nova | 03:05 | |
| *** sapd1 has quit IRC | 03:07 | |
| *** wolverineav has quit IRC | 03:09 | |
| *** hongbin has joined #openstack-nova | 03:10 | |
| *** janki has joined #openstack-nova | 03:21 | |
| *** sapd1 has joined #openstack-nova | 03:23 | |
| *** markvoelker has joined #openstack-nova | 03:34 | |
| *** udesale has joined #openstack-nova | 03:44 | |
| *** tetsuro has quit IRC | 04:01 | |
| *** tetsuro has joined #openstack-nova | 04:06 | |
| *** markvoelker has quit IRC | 04:06 | |
| *** tetsuro has quit IRC | 04:11 | |
| *** agopi has quit IRC | 04:15 | |
| *** _fragatina has quit IRC | 04:26 | |
| *** _fragatina has joined #openstack-nova | 04:26 | |
| *** lpetrut has joined #openstack-nova | 04:43 | |
| *** sapd1 has quit IRC | 04:48 | |
| *** sapd1 has joined #openstack-nova | 05:00 | |
| *** markvoelker has joined #openstack-nova | 05:03 | |
| *** lpetrut has quit IRC | 05:10 | |
| *** ircuser-1 has joined #openstack-nova | 05:15 | |
| *** markvoelker has quit IRC | 05:37 | |
| *** hongbin has quit IRC | 05:42 | |
| *** Luzi has joined #openstack-nova | 05:46 | |
| *** rchurch has quit IRC | 05:52 | |
| *** tkajinam_ has joined #openstack-nova | 05:54 | |
| *** tkajinam has quit IRC | 05:57 | |
| *** markvoelker has joined #openstack-nova | 06:34 | |
| *** cfriesen has quit IRC | 06:36 | |
| *** sdake has joined #openstack-nova | 06:37 | |
| *** belmoreira has joined #openstack-nova | 06:49 | |
| *** moshele has joined #openstack-nova | 06:52 | |
| *** xek has joined #openstack-nova | 06:52 | |
| *** markvoelker has quit IRC | 07:06 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750 | 07:06 |
| openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 07:09 |
| *** tkajinam_ has quit IRC | 07:10 | |
| *** slaweq has joined #openstack-nova | 07:10 | |
| *** tkajinam_ has joined #openstack-nova | 07:12 | |
| *** yedongcan has quit IRC | 07:14 | |
| *** tkajinam__ has joined #openstack-nova | 07:14 | |
| *** tkajinam_ has quit IRC | 07:17 | |
| *** dpawlik has joined #openstack-nova | 07:27 | |
| *** sdake has quit IRC | 07:30 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server subresouce toplogy API https://review.openstack.org/621476 | 07:32 |
| *** xek has quit IRC | 07:33 | |
| *** ileixe has quit IRC | 07:39 | |
| *** dtantsur|afk is now known as dtantsur | 07:42 | |
| *** pcaruana has joined #openstack-nova | 07:43 | |
| *** pbing19 has joined #openstack-nova | 07:46 | |
| *** ileixe has joined #openstack-nova | 07:47 | |
| *** tesseract has joined #openstack-nova | 07:52 | |
| *** markvoelker has joined #openstack-nova | 08:03 | |
| *** pbing19 has quit IRC | 08:04 | |
| *** awalende has joined #openstack-nova | 08:04 | |
| *** wolverineav has joined #openstack-nova | 08:05 | |
| *** awalende has quit IRC | 08:06 | |
| *** panda|off is now known as panda | 08:09 | |
| *** awalende has joined #openstack-nova | 08:09 | |
| *** jangutter has joined #openstack-nova | 08:10 | |
| *** egonzalez has quit IRC | 08:15 | |
| *** rpittau has joined #openstack-nova | 08:17 | |
| *** tssurya has joined #openstack-nova | 08:17 | |
| *** ShilpaSD has joined #openstack-nova | 08:18 | |
| *** ralonsoh has joined #openstack-nova | 08:19 | |
| *** helenafm has joined #openstack-nova | 08:24 | |
| *** tkajinam__ has quit IRC | 08:28 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add method to allow reset fields for root bdm in BDM obj https://review.openstack.org/614672 | 08:32 |
| *** egonzalez has joined #openstack-nova | 08:36 | |
| *** markvoelker has quit IRC | 08:37 | |
| *** xek has joined #openstack-nova | 08:37 | |
| openstackgerrit | Sagar Waghmare proposed openstack/nova stable/rocky: db sync prints stack-trace on invalid version https://review.openstack.org/637491 | 08:48 |
| *** pcaruana|afk| has joined #openstack-nova | 09:01 | |
| *** pcaruana has quit IRC | 09:02 | |
| *** pbing19 has joined #openstack-nova | 09:04 | |
| *** ccamacho has joined #openstack-nova | 09:13 | |
| *** sdake has joined #openstack-nova | 09:15 | |
| *** ttsiouts has joined #openstack-nova | 09:23 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750 | 09:33 |
| *** sapd1 has quit IRC | 09:33 | |
| *** markvoelker has joined #openstack-nova | 09:34 | |
| *** derekh has joined #openstack-nova | 09:37 | |
| *** trident has joined #openstack-nova | 09:38 | |
| *** tetsuro has joined #openstack-nova | 09:38 | |
| *** bhagyashris has quit IRC | 09:44 | |
| *** awalende has quit IRC | 09:46 | |
| *** awalende has joined #openstack-nova | 09:46 | |
| openstackgerrit | Lajos Katona proposed openstack/python-novaclient master: Add support for microversion v2.69 https://review.openstack.org/637234 | 09:47 |
| *** sapd1 has joined #openstack-nova | 09:49 | |
| *** awalende has quit IRC | 09:51 | |
| *** awalende has joined #openstack-nova | 09:56 | |
| *** awalende has quit IRC | 10:00 | |
| *** pcaruana|afk| has quit IRC | 10:01 | |
| *** pcaruana has joined #openstack-nova | 10:07 | |
| *** markvoelker has quit IRC | 10:07 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.69: Handles Down Cells Documentation https://review.openstack.org/635147 | 10:08 |
| *** xek has quit IRC | 10:09 | |
| *** ociuhandu has joined #openstack-nova | 10:14 | |
| *** xek has joined #openstack-nova | 10:18 | |
| *** ociuhandu has quit IRC | 10:20 | |
| *** xek has quit IRC | 10:24 | |
| *** xek has joined #openstack-nova | 10:27 | |
| *** ociuhandu has joined #openstack-nova | 10:30 | |
| *** xek has quit IRC | 10:34 | |
| *** tobias-urdin has joined #openstack-nova | 10:40 | |
| *** moshele has quit IRC | 10:50 | |
| *** cdent has joined #openstack-nova | 10:55 | |
| *** moshele has joined #openstack-nova | 10:57 | |
| *** wolverineav has quit IRC | 11:03 | |
| *** markvoelker has joined #openstack-nova | 11:04 | |
| *** tssurya has quit IRC | 11:16 | |
| *** awalende has joined #openstack-nova | 11:16 | |
| *** sdake has quit IRC | 11:16 | |
| *** takashin has joined #openstack-nova | 11:17 | |
| *** ileixe has quit IRC | 11:19 | |
| *** Dinesh_Bhor has quit IRC | 11:20 | |
| *** sdake has joined #openstack-nova | 11:21 | |
| *** erlon has joined #openstack-nova | 11:23 | |
| *** ttsiouts has quit IRC | 11:28 | |
| *** ttsiouts has joined #openstack-nova | 11:29 | |
| *** yan0s has joined #openstack-nova | 11:33 | |
| *** ttsiouts has quit IRC | 11:33 | |
| *** udesale has quit IRC | 11:33 | |
| *** udesale has joined #openstack-nova | 11:34 | |
| *** markvoelker has quit IRC | 11:37 | |
| *** tetsuro has quit IRC | 11:45 | |
| *** janki has quit IRC | 11:49 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750 | 11:51 |
| *** ttsiouts has joined #openstack-nova | 11:53 | |
| *** janki has joined #openstack-nova | 11:54 | |
| kashyap | stephenfin: On that serial console rat-hole, one quick heads-up: | 11:58 |
| kashyap | I noticed that, with 'virtlogd', zKVM now tries to open *duplicate* console with the _same_ log file: | 11:58 |
| kashyap | 2019-02-15 08:39:52.292+0000: 3015: error : | 11:58 |
| kashyap | virNetClientProgramDispatchError:177 : Cannot open log file: | 11:58 |
| kashyap | '/opt/stack/data/nova/instances/6cabfc83-8056-4282-9918-f4e349bb6169/console.log': | 11:58 |
| kashyap | Device or resource busy | 11:58 |
| kashyap | Because: | 11:59 |
| kashyap | [8 lines of paste] | 11:59 |
| kashyap | Feb 15 08:39:43.093482 ubuntu-xenial-s390x-cloud-zfwcec175-6757 nova-compute[18734]: <console type='pty'> | 11:59 |
| kashyap | Feb 15 08:39:43.093639 ubuntu-xenial-s390x-cloud-zfwcec175-6757 nova-compute[18734]: <log file='/opt/stack/data/nova/instances/35329c2e-d278-4629-87ad-08795d0a68c8/console.log' append='off'/> | 11:59 |
| kashyap | Feb 15 08:39:43.093782 ubuntu-xenial-s390x-cloud-zfwcec175-6757 nova-compute[18734]: <target type='sclplm' port='0'/> | 11:59 |
| kashyap | Feb 15 08:39:43.093922 ubuntu-xenial-s390x-cloud-zfwcec175-6757 nova-compute[18734]: </console> | 11:59 |
| kashyap | Feb 15 08:39:43.094057 ubuntu-xenial-s390x-cloud-zfwcec175-6757 nova-compute[18734]: <console type='pty'> | 11:59 |
| kashyap | Feb 15 08:39:43.094190 ubuntu-xenial-s390x-cloud-zfwcec175-6757 nova-compute[18734]: <log file='/opt/stack/data/nova/instances/35329c2e-d278-4629-87ad-08795d0a68c8/console.log' append='off'/> | 11:59 |
| kashyap | Feb 15 08:39:43.094328 ubuntu-xenial-s390x-cloud-zfwcec175-6757 nova-compute[18734]: <target type='sclp' port='1'/> | 11:59 |
| kashyap | Feb 15 08:39:43.094470 ubuntu-xenial-s390x-cloud-zfwcec175-6757 nova-compute[18734]: </console> | 11:59 |
| * kashyap uses pastebin normally; but ~8 lines is probably okay :-) | 11:59 | |
| *** tbachman has joined #openstack-nova | 12:00 | |
| kashyap | Actually, better seen on the pastebin (observe line-14 & line-18): http://paste.openstack.org/show/745255/ | 12:00 |
| kashyap | Anyway, I'll address this, and note it in the commit. | 12:00 |
| *** moshele has quit IRC | 12:02 | |
| *** moshele has joined #openstack-nova | 12:03 | |
| *** sdake has quit IRC | 12:12 | |
| *** sdake has joined #openstack-nova | 12:15 | |
| *** thgcorrea has joined #openstack-nova | 12:22 | |
| *** liuyulong_zzz is now known as liuyulong | 12:37 | |
| *** xek has joined #openstack-nova | 12:40 | |
| openstackgerrit | Chris Dent proposed openstack/nova stable/rocky: Lock detach_volume https://review.openstack.org/637534 | 12:43 |
| openstackgerrit | Chris Dent proposed openstack/nova stable/queens: Lock detach_volume https://review.openstack.org/637535 | 12:44 |
| openstackgerrit | Chris Dent proposed openstack/nova stable/pike: Lock detach_volume https://review.openstack.org/637536 | 12:44 |
| cdent | we'll see how that goes | 12:46 |
| *** xek_ has joined #openstack-nova | 12:47 | |
| *** xek has quit IRC | 12:47 | |
| *** tssurya has joined #openstack-nova | 12:54 | |
| *** moshele has quit IRC | 12:58 | |
| *** xek__ has joined #openstack-nova | 12:59 | |
| *** xek_ has quit IRC | 13:01 | |
| *** pbing19 has quit IRC | 13:03 | |
| *** xek__ has quit IRC | 13:06 | |
| *** xek__ has joined #openstack-nova | 13:06 | |
| *** janki has quit IRC | 13:06 | |
| *** irclogbot_2 has quit IRC | 13:08 | |
| *** irclogbot_2 has joined #openstack-nova | 13:09 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Calculate RequestGroup resource provider mapping https://review.openstack.org/616239 | 13:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fill the RequestGroup mapping during schedule https://review.openstack.org/619528 | 13:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Pass resource provider mapping to neutronv2 api https://review.openstack.org/616240 | 13:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Recalculate request group - RP mapping during re-schedule https://review.openstack.org/619529 | 13:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send RP uuid in the port binding https://review.openstack.org/569459 | 13:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request https://review.openstack.org/573317 | 13:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | 13:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310 | 13:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311 | 13:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | 13:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | 13:14 |
| *** eharney has joined #openstack-nova | 13:20 | |
| *** priteau has joined #openstack-nova | 13:26 | |
| *** sdake has quit IRC | 13:28 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Calculate RequestGroup resource provider mapping https://review.openstack.org/616239 | 13:32 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fill the RequestGroup mapping during schedule https://review.openstack.org/619528 | 13:32 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Pass resource provider mapping to neutronv2 api https://review.openstack.org/616240 | 13:32 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Recalculate request group - RP mapping during re-schedule https://review.openstack.org/619529 | 13:32 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send RP uuid in the port binding https://review.openstack.org/569459 | 13:32 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request https://review.openstack.org/573317 | 13:32 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | 13:32 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310 | 13:32 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311 | 13:32 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | 13:32 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | 13:33 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | 13:33 |
| *** _fragatina has quit IRC | 13:34 | |
| *** _fragatina has joined #openstack-nova | 13:34 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Stein" https://review.openstack.org/632507 | 13:36 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Rewrite _create_pty_device() to be clearer https://review.openstack.org/637152 | 13:36 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_PARALLELS_SET_ADMIN_PASSWD https://review.openstack.org/632514 | 13:36 |
| *** tbachman has quit IRC | 13:36 | |
| gibi | fried_rice, leakypipes: added the extra check for leftover allocations to https://review.openstack.org/#/c/616239 | 13:38 |
| *** tbachman has joined #openstack-nova | 13:38 | |
| leakypipes | gibi: ++ will review after my 9am appt. | 13:39 |
| *** leakypipes is now known as jaypipes | 13:39 | |
| *** kaisers has quit IRC | 13:42 | |
| *** avolkov has quit IRC | 13:42 | |
| gibi | jaypipes: thanks! | 13:43 |
| *** jmlowe has quit IRC | 13:43 | |
| *** mchlumsky has joined #openstack-nova | 13:43 | |
| *** priteau has quit IRC | 13:45 | |
| kashyap | gibi: fried_rice: Appreciate one more look on the above, when you get a few minutes. | 13:45 |
| kashyap | gibi: It was already ACKed, I fixed the issue discovered by zKVM CI | 13:45 |
| gibi | kashyap: looking | 13:45 |
| *** tbachman has quit IRC | 13:46 | |
| kashyap | gibi: Err, 1 sec, let me quickly respin -- I moved the code comment to the wrong function. | 13:47 |
| *** tetsuro has joined #openstack-nova | 13:48 | |
| *** kaisers has joined #openstack-nova | 13:49 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Stein" https://review.openstack.org/632507 | 13:50 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Rewrite _create_pty_device() to be clearer https://review.openstack.org/637152 | 13:50 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_PARALLELS_SET_ADMIN_PASSWD https://review.openstack.org/632514 | 13:50 |
| *** fried_rice is now known as efried | 13:50 | |
| *** mriedem has joined #openstack-nova | 13:50 | |
| efried | n-sch meeting in 9 minutes in #openstack-meeting-alt | 13:51 |
| kashyap | Done. | 13:51 |
| *** itlinux has joined #openstack-nova | 13:52 | |
| *** _fragatina has quit IRC | 13:53 | |
| *** _fragatina has joined #openstack-nova | 13:53 | |
| kashyap | gibi: ^ Thanks! (If you're deep in the middle of a different change, probably look at it later. The context-switch can be expensive here.) | 13:55 |
| gibi | kashyap: done | 13:56 |
| * gibi is a hostage on a 3 hours long meeting | 13:56 | |
| kashyap | That's fast. | 13:56 |
| kashyap | gibi: Wauw; that's crazy | 13:56 |
| *** sdake has joined #openstack-nova | 13:56 | |
| openstackgerrit | Surya Seetharaman proposed openstack/python-novaclient master: API microversion 2.69: Handles Down Cells https://review.openstack.org/579563 | 13:57 |
| kashyap | gibi: This will come in handy ;-) -- https://tobytripp.github.io/meeting-ticker/ | 13:57 |
| *** mchlumsky has quit IRC | 13:57 | |
| gibi | kashyap: thanks :D | 13:58 |
| *** cdent has quit IRC | 13:59 | |
| *** agopi has joined #openstack-nova | 13:59 | |
| *** cdent has joined #openstack-nova | 13:59 | |
| *** mchlumsky has joined #openstack-nova | 14:00 | |
| *** priteau has joined #openstack-nova | 14:03 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: API microversion 2.69: Handles Down Cells Documentation https://review.openstack.org/635147 | 14:03 |
| *** Luzi has quit IRC | 14:04 | |
| *** itlinux has quit IRC | 14:08 | |
| sean-k-mooney | general question is it leagal to delete an instance when it is building? | 14:10 |
| sean-k-mooney | if so we have a bug in our network cleanup logic which i need to go fix | 14:11 |
| *** itlinux has joined #openstack-nova | 14:11 | |
| sean-k-mooney | ill fix it regardless of they answer to my first question but im wondering if we expect you to be able to delete a currently building instance. | 14:12 |
| *** jroll has quit IRC | 14:13 | |
| sean-k-mooney | looking at https://developer.openstack.org/api-ref/compute/?expanded=delete-server-detail#delete-server it does not look like there is a precondition preventing deltion while it is spawning | 14:13 |
| *** elbragstad has joined #openstack-nova | 14:14 | |
| *** jroll has joined #openstack-nova | 14:14 | |
| efried | sean-k-mooney: I know a delete request is certainly accepted during spawn, and seems to delete the instance. | 14:14 |
| sean-k-mooney | efried: ya so https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2000-L2036 we dont clean up host networking if we raise exception.UnexpectedDeletingTaskStateError | 14:15 |
| efried | okay | 14:16 |
| sean-k-mooney | so between the time os-vif plugs the vif and the managner updates the db to set the stat to active if we recive a delete request we dont clean up properly | 14:16 |
| *** ttsiouts has quit IRC | 14:19 | |
| *** tbachman has joined #openstack-nova | 14:19 | |
| *** ttsiouts has joined #openstack-nova | 14:20 | |
| *** thgcorrea has quit IRC | 14:20 | |
| *** eharney has quit IRC | 14:23 | |
| *** ttsiouts has quit IRC | 14:23 | |
| *** ttsiouts has joined #openstack-nova | 14:23 | |
| *** elbragstad is now known as lbragstad | 14:24 | |
| *** psachin has quit IRC | 14:28 | |
| *** awalende has quit IRC | 14:33 | |
| dansmith | mriedem: tssurya: we should probably have some stuff in the docs around best practices for effectively tolerating down cells.. like db and mq timeout settings | 14:33 |
| *** awalende has joined #openstack-nova | 14:34 | |
| *** thgcorrea has joined #openstack-nova | 14:34 | |
| *** tacco has joined #openstack-nova | 14:35 | |
| *** bnemec-pto is now known as bnemec | 14:37 | |
| mriedem | dansmith: e.g. https://bugs.launchpad.net/nova/+bug/1815697 ? | 14:37 |
| openstack | Launchpad bug 1815697 in OpenStack Compute (nova) "[upgrade_levels]compute=auto grinds the API response times when a cell is down" [Medium,Confirmed] | 14:37 |
| dansmith | mriedem: yeah and that | 14:37 |
| dansmith | very op-focused docs | 14:37 |
| *** gbarros has joined #openstack-nova | 14:37 | |
| *** awalende has quit IRC | 14:38 | |
| mriedem | sure, that would go in https://docs.openstack.org/nova/latest/admin/ | 14:38 |
| mriedem | https://review.openstack.org/#/c/635147/ is already pretty big, so i'd suggest we split that off | 14:39 |
| dansmith | yep | 14:39 |
| NewBruce | sean-k-mooney wrt your open question above, i think there are a few paths that don’t clean up when an error occurs | 14:39 |
| NewBruce | for instance, the issue i’m debugging which we were discussing last week is one as well - | 14:40 |
| sean-k-mooney | NewBruce: yes in this case i dont think we ever call the drivers destroy or cleanup fucntions | 14:40 |
| NewBruce | yep, and in some cases it tends to leave allocations - which i suspect will eventually play havoc with the scheduler/placement | 14:41 |
| *** jmlowe has joined #openstack-nova | 14:41 | |
| NewBruce | def _update_port_with_migration_profile( | 14:41 |
| NewBruce | self, instance, port_id, port_profile, admin_client): | 14:41 |
| NewBruce | try: | 14:41 |
| NewBruce | updated_port = admin_client.update_port( | 14:41 |
| NewBruce | port_id, {'port': {BINDING_PROFILE: port_profile}}) | 14:41 |
| NewBruce | return updated_port | 14:41 |
| NewBruce | except Exception as ex: | 14:41 |
| NewBruce | with excutils.save_and_reraise_exception(): | 14:41 |
| NewBruce | LOG.error("Unable to update binding profile " | 14:41 |
| NewBruce | "for port: %(port)s due to failure: %(error)s", | 14:41 |
| NewBruce | {'port': port_id, 'error': ex}, | 14:41 |
| NewBruce | instance=instance) | 14:41 |
| sean-k-mooney | in this case the allcoation are being cleaned up but its not cleaning upu the network ports | 14:41 |
| sean-k-mooney | e.g. unplginning the vifs | 14:42 |
| NewBruce | Aha - ok | 14:42 |
| sean-k-mooney | im not sure if we are cleaning up disk image ectra either so i think just calling self.driver.cleanup would be the simplest solution | 14:42 |
| NewBruce | sean-k-mooney will you in the channel for a while? ill be back in a few hours and if possible would love to continue our chat from last week - ive got some extra debug info which i can’t make sense of | 14:43 |
| sean-k-mooney | yes ill be around for anohter few hours | 14:43 |
| *** mvkr has quit IRC | 14:46 | |
| *** priteau has quit IRC | 14:47 | |
| stephenfin | kashyap: Is there an open bug for s390x before this patch goes in so? https://review.openstack.org/#/c/632507/12 | 14:49 |
| *** tetsuro has quit IRC | 14:50 | |
| stephenfin | kashyap: i.e. if you have a new enough version of libvirt, you'll end up with the duplicate pty devices? | 14:50 |
| *** mlavalle has joined #openstack-nova | 14:53 | |
| *** moshele has joined #openstack-nova | 14:53 | |
| mriedem | dansmith: in addition to config i'd think you'd want to disable any down cells via the cli and sighup the scheduler service so we don't waste time trying to pull compute nodes from them for scheduling | 14:58 |
| mriedem | with that bug above i was wondering if filtering disabled cells could be more generally applied | 14:58 |
| dansmith | mriedem: yep, probs | 14:58 |
| mriedem | the min service version check specifically | 14:58 |
| *** sdake has quit IRC | 14:58 | |
| *** dave-mccowan has joined #openstack-nova | 14:58 | |
| *** priteau has joined #openstack-nova | 14:59 | |
| *** janki has joined #openstack-nova | 15:00 | |
| *** awaugama has joined #openstack-nova | 15:00 | |
| *** takashin has left #openstack-nova | 15:01 | |
| *** dave-mccowan has quit IRC | 15:03 | |
| kashyap | stephenfin: No open bug is required. | 15:03 |
| kashyap | Because: | 15:04 |
| kashyap | stephenfin: Scratch that; I need to determine if we really one. But having one is always useful, though. | 15:06 |
| stephenfin | kashyap: It's mostly because if there is a bug, it would be better fix that in a separate precursor patch so that we can backport that wholesale | 15:07 |
| kashyap | stephenfin: No, there is no pre-existing bug. I discovered this the hard way (from zKVM CI), after the version bump analysis | 15:08 |
| kashyap | stephenfin: I see what you mean, though -- I'd have _really_ preferred this to be a separate change ("one logical change per commit"). But I don't think we can do it in this instance - as it's tied to version bump :-( | 15:08 |
| kashyap | (Aside: Do we have any active s390x contributors?) | 15:09 |
| *** munimeha1 has joined #openstack-nova | 15:13 | |
| *** mvkr has joined #openstack-nova | 15:13 | |
| mriedem | no | 15:13 |
| kashyap | Nod. In this case, we're reasonably safe: I checked with the s390x maintainer (for 10-ish years) in QEMU, and she said what I'm doing is sane, FWIW. | 15:16 |
| kashyap | s/reasonably// :D ("Avoid tame, colorless, hesitating, noncommittal language.") | 15:17 |
| *** priteau has quit IRC | 15:18 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Ignore VolumeAttachmentNotFound exception in compute.manager https://review.openstack.org/637391 | 15:19 |
| mriedem | need another core on this api-ref change https://review.openstack.org/#/c/635315/ to unblock this code fix https://review.openstack.org/#/c/509206/ for the longstanding "don't allow az renames when the az has instances in it" | 15:19 |
| *** jmlowe has quit IRC | 15:20 | |
| *** jmlowe has joined #openstack-nova | 15:21 | |
| gibi | mriedem: I'm looking at the heal_allocation code and I'm wondering how to handle when more than on thing is missing | 15:26 |
| gibi | (e.g. project_id and some port allocation) from the instance allocation: | 15:26 |
| gibi | a) do a separate PUT /allocations/{instance.uuid} for each step | 15:26 |
| kashyap | mriedem: When you get a moment, on this: https://specs.openstack.org/openstack/nova-specs/specs/stein/approved/cpu-model-selection.html | 15:26 |
| *** jdillaman has joined #openstack-nova | 15:26 | |
| gibi | b) generate all the missing allocation of the instance and | 15:26 |
| gibi | do a single PUT /allocations/{instance.uuid} at the end | 15:26 |
| kashyap | mriedem: Do you know if Jack Ding / cfriesen et al are working on it? | 15:26 |
| gibi | #a) has the benefit to allow only healing project_id when there is no bandwidth inventory to heal the port allocations | 15:27 |
| gibi | #b) has the benefit of only calling PUT /allocations once | 15:27 |
| kashyap | gibi: Sorry for breaking your chat, didn't realize it for a moment. | 15:28 |
| gibi | kashyap: no worries I think we break each other chat :D | 15:28 |
| kashyap | (I know there is no 'mutex' on IRC, but still :-)) | 15:28 |
| kashyap | Matt: I ask because, there is a related blueprint I filed the other day: https://blueprints.launchpad.net/nova/+spec/cpu-selection-with-hypervisor-consideration | 15:28 |
| *** _alastor_ has joined #openstack-nova | 15:31 | |
| * kashyap wished we coordiated better on this (maybe on the list). Although I commented on Jack's spec when I saw it, but lost track of the newer comments and forgot to 'hit send' on my 'saved' Gerrit remarks. | 15:31 | |
| kashyap | Anyway, it can be worked out; as no one posted any code for it. | 15:32 |
| mriedem | kashyap: no https://blueprints.launchpad.net/nova/+spec/cpu-model-selection | 15:32 |
| mriedem | no patches proposed | 15:32 |
| kashyap | mriedem: Right, I saw that. | 15:33 |
| kashyap | But most important thing is to rip out existing two CPU-related APIs and use the more sensible APIs that take into account the hypervisor capabilities. | 15:33 |
| mriedem | gibi: i'm assuming (a) is less change in the heal_allocations code | 15:33 |
| *** _mlavalle_1 has joined #openstack-nova | 15:34 | |
| mriedem | gibi: for healing missing bw allocations i would hope most of that can be a separate private method that does the check and calculates the allocations to PUT | 15:34 |
| gibi | mriedem: (a) seems a bit less intrusive to the existing code yes | 15:34 |
| gibi | mriedem: yes, I will definitly separate out the bw healing to methos | 15:35 |
| gibi | methods | 15:35 |
| mriedem | gibi: so we already do at most 2 PUTs per instance right? | 15:35 |
| mriedem | first here https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L1892 | 15:35 |
| mriedem | second here https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L1912 | 15:35 |
| mriedem | the second is getting allocations from the flavor | 15:35 |
| mriedem | gibi: so i think for bw allocations, you add another private method and merge the results of scheduler_utils.resources_from_flavor before calling the 2nd PUT | 15:36 |
| *** mlavalle has quit IRC | 15:36 | |
| gibi | mriedem: if the code needs to create allocation then it is a single PUT | 15:37 |
| gibi | mriedem: also if there is allocation but no project_id then it is also a single PUT | 15:37 |
| *** itlinux has quit IRC | 15:37 | |
| gibi | mriedem: there is a return here https://github.com/openstack/nova/blob/e3c24da89aa3e6462f1b07e00659c87f252ba4ba/nova/cmd/manage.py#L1898 | 15:37 |
| mriedem | yeah that complicates things... | 15:38 |
| gibi | mriedem: so adding bw to both places means calling my new bw calculation function in both places | 15:39 |
| mriedem | or, get bw allocations first, then if allocations exist but don't have bw resources, skip that return statement and merge for the 2nd PUT | 15:39 |
| mriedem | well, | 15:40 |
| mriedem | i guess you don't want to have to do the work of calculating the bw allocations if you can determine the existing allocations have the bw resource classes | 15:40 |
| gibi | mriedem: I have to check each neutron port attached to the instance to see if there is resoruce_request in the port but no rp uuid in the binding | 15:41 |
| mriedem | yeah i guess the lack of bw in the existing allocatoins does'nt tell us if you need to heal them | 15:41 |
| *** udesale has quit IRC | 15:41 | |
| mriedem | because not all instances will have bw allocations | 15:41 |
| gibi | mriedem: yes | 15:41 |
| mriedem | so it sounds like you need to do that calculation up front anyway | 15:42 |
| gibi | mriedem: yeah, I can do the check and the calculation upfront and merge it to whatwhever PUT it is needed | 15:42 |
| mriedem | we may want an option on the command itself to skip that check | 15:43 |
| gibi | and introduce a new PUT branch to update the bw only, if other data doesn't triggered the PUT | 15:43 |
| mriedem | --skip-bw-allocations | 15:43 |
| gibi | mriedem: ack | 15:43 |
| mriedem | because if my cloud doesn't enable any of that via policy, i don't want this command to waste time spamming the neutron API to figure out that information | 15:43 |
| mriedem | note that this is another argument for stashing the port resource request information in the info_cache :) | 15:44 |
| mriedem | if it was in the info cache we wouldn't need to hit the neutron api for each instance here | 15:44 |
| gibi | mriedem: that cache could be stale when you turn on the policy :) | 15:44 |
| mriedem | that's what we have _heal_instance_info_cache in the compute for | 15:44 |
| mriedem | but sure, you could miss it | 15:45 |
| mriedem | you'd likely know if it's not cached based on some key missing from the cache | 15:45 |
| gibi | mriedem: I'm happy to add a flag to the CLI instead of a cache | 15:45 |
| mriedem | i.e. if 'resource_request' not in VIF - stale cache, vs vif['resource_request'] == None means not stale, but no resource request | 15:45 |
| *** sdake has joined #openstack-nova | 15:45 | |
| mriedem | yeah i know :) | 15:46 |
| mriedem | just saying | 15:46 |
| gibi | I hear you. and I still afaraid of cache for this | 15:46 |
| gibi | anyhow I will try to precreate the bw if needed and merge it in to the existing PUTs | 15:48 |
| *** itlinux has joined #openstack-nova | 15:50 | |
| *** itlinux has quit IRC | 15:51 | |
| *** wwriverrat has joined #openstack-nova | 15:56 | |
| *** itlinux has joined #openstack-nova | 16:04 | |
| *** itlinux has quit IRC | 16:06 | |
| *** gbarros has quit IRC | 16:06 | |
| *** itlinux has joined #openstack-nova | 16:07 | |
| *** itlinux has quit IRC | 16:08 | |
| *** janki has quit IRC | 16:08 | |
| *** pcaruana has quit IRC | 16:10 | |
| *** gbarros has joined #openstack-nova | 16:13 | |
| *** itlinux has joined #openstack-nova | 16:17 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add microversion to expose virtual device tags https://review.openstack.org/631948 | 16:24 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Omit needless check on 'CONF.serial_console' https://review.openstack.org/637578 | 16:27 |
| *** _mlavalle_1 has quit IRC | 16:28 | |
| *** mlavalle has joined #openstack-nova | 16:28 | |
| *** _alastor_ has quit IRC | 16:33 | |
| *** tbachman has quit IRC | 16:39 | |
| *** eharney has joined #openstack-nova | 16:40 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Add support for microversion 2.70 - expose device tags https://review.openstack.org/636779 | 16:44 |
| *** tbachman has joined #openstack-nova | 16:44 | |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Add requested_networks to RequestSpec https://review.openstack.org/570201 | 16:46 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Enable rebuild for instances in cell0 https://review.openstack.org/570203 | 16:46 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Introduce the PENDING instance state https://review.openstack.org/566473 | 16:47 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Allow rebuild for instances in PENDING state https://review.openstack.org/637585 | 16:47 |
| *** ttsiouts has quit IRC | 16:47 | |
| *** moshele has quit IRC | 16:47 | |
| *** ttsiouts has joined #openstack-nova | 16:48 | |
| zzzeek | jaypipes: https://stackoverflow.com/questions/54751671/can-two-innodb-update-statements-against-a-pk-index-deadlock-if-they-are-given-a | 16:49 |
| *** tssurya has quit IRC | 16:52 | |
| *** ttsiouts has quit IRC | 16:52 | |
| jaypipes | zzzeek: that's what we include the `WHERE id = ? AND version_id = <our expected version id>` in the WHERE statement. | 16:54 |
| jaypipes | *why* we include... sorry | 16:54 |
| zzzeek | jaypipes: yes, that's my versioning code so I know that part :) | 16:54 |
| zzzeek | jaypipes: in neutron I'm helping them with a case where they want to bump version ids without checking | 16:55 |
| zzzeek | jaypipes: and the approach of just emitting the UPDATE agaisnt PK with the versino_id=version_id+1 works. | 16:55 |
| zzzeek | jaypipes: I think that it will *never* fail, however even if it did produce a deadlock sometimes, it would be a lot less failure than it has now | 16:55 |
| jaypipes | zzzeek: they want to bump version codes without including the "AND version_id = <expected>" in the WHERE statement you mean? | 16:56 |
| zzzeek | jaypipes: yes, they want the number to increment and that's it | 16:56 |
| zzzeek | they dont care what it was previosuly | 16:56 |
| jaypipes | yeah, that's a recipe for disaster. | 16:56 |
| zzzeek | jaypipes: why | 16:56 |
| jaypipes | because it will produce excessive deadlocks, as you are showing here. | 16:56 |
| zzzeek | jaypipes: if you UPDATE against the PKs in the same order each time, it will not. also, this code previously used the "where verison_Id=<>" thing and it failed lots under stress test. now it does not fail at all | 16:57 |
| zzzeek | jaypipes: so, my assertion is, even if it does deadlock, MySQLs deadlocks are immediate and there should be a lot less of them compared to failed compare-and-swaps right now | 16:57 |
| *** panda is now known as panda|off | 16:58 | |
| zzzeek | jaypipes: obviosuly for galera multi master everything goes out the window :) | 16:58 |
| jaypipes | not really. | 16:58 |
| zzzeek | jaypipes: but this is mostly a question of, when MySQL emits UPDATE and we dont use ORDER BY (which is goofy), is it going to scan the rows from the index in the same way each time | 16:58 |
| jaypipes | zzzeek: are you asking if innodb is going to lock record 1, *then* record 2, regardless of if the WHERE statement says IN(1, 2) or IN(2, 1)? | 16:59 |
| zzzeek | jaypipes: yes | 16:59 |
| jaypipes | neither. | 16:59 |
| *** helenafm has quit IRC | 17:00 | |
| zzzeek | jaypipes: not exactly , the Q is, will it lock 1 and 2 in the *same* order as another UPDATE statement that refers to the same keys | 17:00 |
| zzzeek | i dont care what the order is, just that it is deterministic | 17:00 |
| jaypipes | there will always be a single lock (a gap lock of (inclusive_low=1, inclusive_high=2) | 17:00 |
| *** tbachman has quit IRC | 17:00 | |
| *** sdake has quit IRC | 17:00 | |
| jaypipes | it's not 2 locks. | 17:00 |
| jaypipes | it's one lock, evaluated atomically. | 17:01 |
| zzzeek | jaypipes: OK then what does https://dev.mysql.com/doc/refman/8.0/en/innodb-locking.html#innodb-gap-locks say: "Gap locking is not needed for statements that lock rows using a unique index to search for a unique row. " | 17:01 |
| zzzeek | jaypipes: I tried this without using the PK, and it gap locks | 17:01 |
| zzzeek | jaypipes: add the PK, and it row locks | 17:01 |
| *** jmlowe has quit IRC | 17:02 | |
| zzzeek | b.c. yes w a gap lock, its crazytown time if you have lots of rows | 17:02 |
| *** sdake has joined #openstack-nova | 17:05 | |
| jaypipes | zzzeek: can we back up a sec? I'm a little lost on what you're trying to do in Neutron land. could you link me to the code you are doing/reviewing? | 17:05 |
| zzzeek | jaypipes: sure it's https://review.openstack.org/#/c/635671/ didnt want to pull you into neutron | 17:06 |
| zzzeek | jaypipes: they were ready to add a whole new table and rewrite their whole versioning thing just so they can have incrementing version ids without checking for conflicts | 17:08 |
| zzzeek | jaypipes: as always, if this fails sometimes, it retries. it's not the end of the world. the current implementation fails and retries lots. | 17:08 |
| jaypipes | zzzeek: retries are natural and expected, yes | 17:13 |
| jaypipes | zzzeek: lemme read this patch first :) | 17:13 |
| zzzeek | jaypipes: im going to try the sleep() trick to see if i can get the two updates to interleave | 17:14 |
| *** rpittau has quit IRC | 17:16 | |
| *** rpittau has joined #openstack-nova | 17:19 | |
| *** yan0s has quit IRC | 17:21 | |
| *** jmlowe has joined #openstack-nova | 17:21 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: ironic: check fresh data when sync_power_state doesn't line up https://review.openstack.org/636699 | 17:22 |
| *** rpittau has quit IRC | 17:26 | |
| *** mvkr has quit IRC | 17:26 | |
| openstackgerrit | Maciej Kucia proposed openstack/nova master: SR-IOV passthrough: Check PF only if VF is enabled https://review.openstack.org/476642 | 17:28 |
| openstackgerrit | Merged openstack/nova master: create_veth_pair is unused, remove it. https://review.openstack.org/624226 | 17:28 |
| *** jmlowe has quit IRC | 17:31 | |
| *** mvkr has joined #openstack-nova | 17:31 | |
| *** moshele has joined #openstack-nova | 17:32 | |
| openstackgerrit | Elod Illes proposed openstack/nova stable/queens: Make service all-cells min version helper use scatter-gather https://review.openstack.org/637594 | 17:32 |
| *** moshele has quit IRC | 17:40 | |
| *** ttsiouts has joined #openstack-nova | 17:42 | |
| *** jmlowe has joined #openstack-nova | 17:45 | |
| *** _fragatina has quit IRC | 17:48 | |
| *** pbing19 has joined #openstack-nova | 17:50 | |
| *** idlemind has quit IRC | 17:52 | |
| *** priteau has joined #openstack-nova | 17:53 | |
| *** sapd1 has quit IRC | 17:59 | |
| jaypipes | zzzeek: hmm, neutron patch is a rabbithole for me... abstraction on top of abstraction. I'm afraid that I'm having a difficult time following what SQL statements would/will be produced at which events with this... | 17:59 |
| zzzeek | jaypipes: I know, neutron is a PITA | 18:00 |
| zzzeek | jaypipes: i never work on it because it is nonsensical | 18:00 |
| zzzeek | jaypipes: but i figured out enough what this does :) | 18:00 |
| openstackgerrit | Elod Illes proposed openstack/nova stable/queens: Make host_manager use scatter-gather and ignore down cells https://review.openstack.org/637599 | 18:00 |
| *** derekh has quit IRC | 18:02 | |
| jaypipes | zzzeek: this patch definitely fixes a number of deadlocks you are seeing, yes? | 18:02 |
| jaypipes | zzzeek: where specifically are those deadlocks being hit? (in the neutron code, that is...) | 18:03 |
| zzzeek | jaypipes: it fixes SQLAlchemy version id misses, not "deadlocks" in the literal sense | 18:04 |
| zzzeek | jaypipes: SQLAlchemy StaleDataErrors | 18:04 |
| zzzeek | jaypipes: they have this test case where they create 300 security group rules | 18:04 |
| zzzeek | jaypipes: and that incurs a versino bump on many related objects because their API requiers that the new number is exposed | 18:05 |
| zzzeek | jaypipes: so the version_id here is used for two purposes | 18:05 |
| zzzeek | jaypipes: so when they make these 300 rules they get a ton of StaleDataErrors on all the related objects, for which they are changing nothing except bumping the version id | 18:05 |
| jaypipes | zzzeek: wait, are you saying that updates of dependent objects cause the version to be incremented more than once? | 18:06 |
| zzzeek | jaypipes: this also incurs that an ORM lookup is happening, a flush, etc. which is all overhead too | 18:06 |
| zzzeek | jaypipes: no, when they have multiple transactions on concurrent API requests | 18:06 |
| zzzeek | jaypipes: look at feb 8 comments on the gerrit: "POST request response times for 300 security group rules creation http://paste.openstack.org/show/744727/ | 18:07 |
| zzzeek | script I used to create 300 security group rules asynchronously http://paste.openstack.org/show/744728/" | 18:07 |
| jaypipes | zzzeek: ok, creating 300 security group rules should increment the security group's version to 301, yes? | 18:08 |
| aspiers | Wow, plantuml is pretty cool. I was able to knock this up pretty quickly from a small text file: https://goo.gl/tPNAQK | 18:08 |
| zzzeek | jaypipes: i dunno. the person testing is saying he is getting the correct results though | 18:08 |
| zzzeek | yes 301 | 18:09 |
| zzzeek | Even the revision_number for security group updated properly when creating 300 security group rules MariaDB [neutron]> select * from standardattributes where id="2151"; +------+----------------+---------------------+---------------------+-------------+-----------------+ | id | resource_type | created_at | updated_at | description | revision_number | +------+----------------+---------------------+---------------------+-------------+ | 18:09 |
| zzzeek | -----------------+ | 2151 | securitygroups | 2019-02-08 09:07:15 | 2019-02-08 09:09:05 | | 301 | +------+----------------+---------------------+---------------------+-------------+-----------------+ | 18:09 |
| * zzzeek has to bbl | 18:09 | |
| *** xek__ has quit IRC | 18:18 | |
| *** xek__ has joined #openstack-nova | 18:19 | |
| *** xek__ has quit IRC | 18:19 | |
| *** xek__ has joined #openstack-nova | 18:20 | |
| *** ralonsoh has quit IRC | 18:21 | |
| *** xek__ has quit IRC | 18:24 | |
| *** gbarros has quit IRC | 18:24 | |
| *** xek__ has joined #openstack-nova | 18:24 | |
| *** ociuhandu_ has joined #openstack-nova | 18:24 | |
| *** tbachman has joined #openstack-nova | 18:25 | |
| *** ociuhandu has quit IRC | 18:28 | |
| *** ociuhandu_ has quit IRC | 18:29 | |
| *** sdake has quit IRC | 18:29 | |
| *** sdake_ has joined #openstack-nova | 18:29 | |
| *** xek__ has quit IRC | 18:30 | |
| *** ociuhandu has joined #openstack-nova | 18:40 | |
| mnaser | mriedem: we might want to ping the ML about the change we recently did with disallowing root_gb=0 flavors | 18:42 |
| mnaser | osa gates broke because i assume we created flavors which were using root_gb=0 | 18:43 |
| mriedem | we?!?! | 18:43 |
| mnaser | i can shoot an email if you weren't planning to | 18:43 |
| mriedem | go nuts | 18:43 |
| mriedem | i send enough "oh btw everything is going to be broken now" emails | 18:44 |
| mnaser | https://review.openstack.org/#/c/603910/ | 18:44 |
| mnaser | :D | 18:44 |
| mriedem | yeah i know | 18:44 |
| *** mvkr has quit IRC | 18:45 | |
| *** ociuhandu has quit IRC | 18:45 | |
| *** dtantsur is now known as dtantsur|afk | 18:47 | |
| *** gbarros has joined #openstack-nova | 18:48 | |
| openstackgerrit | Surya Seetharaman proposed openstack/python-novaclient master: API microversion 2.69: Handles Down Cells https://review.openstack.org/579563 | 18:59 |
| *** _fragatina has joined #openstack-nova | 19:00 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.openstack.org/627892 | 19:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.openstack.org/631581 | 19:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.openstack.org/633853 | 19:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.openstack.org/621313 | 19:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293 | 19:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtDestTask https://review.openstack.org/627890 | 19:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.openstack.org/634832 | 19:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.openstack.org/627891 | 19:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add finish_snapshot_based_resize_at_dest compute method https://review.openstack.org/635080 | 19:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.openstack.org/635646 | 19:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.openstack.org/635668 | 19:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.openstack.org/635684 | 19:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Filter duplicates from compute API get_migrations_sorted() https://review.openstack.org/636224 | 19:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize https://review.openstack.org/636253 | 19:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add confirm_snapshot_based_resize_at_source https://review.openstack.org/637058 | 19:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add ConfirmResizeTask https://review.openstack.org/637070 | 19:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add confirm_snapshot_based_resize conductor RPC method https://review.openstack.org/637075 | 19:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize from the API https://review.openstack.org/637316 | 19:03 |
| * cdent swoons | 19:04 | |
| mriedem | that's only about half the series at this point | 19:05 |
| mriedem | swoon away | 19:05 |
| * cdent takes a breath | 19:08 | |
| *** priteau has quit IRC | 19:25 | |
| *** moshele has joined #openstack-nova | 19:26 | |
| NewBruce | sean-k-mooney still here mate? | 19:36 |
| *** hongbin has joined #openstack-nova | 19:36 | |
| *** tesseract has quit IRC | 19:37 | |
| mordred | mriedem: did nova/devstack introduce a behavior change recentlyish? http://logs.openstack.org/63/637563/1/check/openstacksdk-functional-devstack-tips/f7e749c/testr_results.html.gz | 19:41 |
| mordred | mriedem: | 19:41 |
| mordred | openstack.exceptions.HttpException: HttpException: 403: Client Error for url: https://213.32.77.235/compute/v2.1/servers, Only volume-backed servers are allowed for flavors with zero disk. | 19:41 |
| dansmith | hah | 19:41 |
| dansmith | mordred: [10:42:42] <mnaser>mriedem: we might want to ping the ML about the change we recently did with disallowing root_gb=0 flavors | 19:42 |
| mordred | hahaha | 19:42 |
| dansmith | made it a whole hour | 19:42 |
| mnaser | mordred: http://lists.openstack.org/pipermail/openstack-discuss/2019-February/002842.html :D | 19:42 |
| *** hongbin has quit IRC | 19:43 | |
| mordred | mnaser: so - I might need to port that change to apply to non-tempest flavors I suppose? | 19:43 |
| mnaser | mordred: so whatever tests you were doing were trying to do a boot from volume using a flavor that has root_gb=0 | 19:44 |
| mnaser | i assume openstacksdk maybe is trying to create its own flavor? | 19:44 |
| mordred | not to my knowledge, no | 19:44 |
| mordred | we just use whatever flavor is there | 19:44 |
| mordred | but we don't install/run tempest, so I doubt lib/tempest flavors exist | 19:44 |
| mnaser | {"href": "https://213.32.77.235/compute/flavors/c1", "rel": "bookmark"}], "ram": 256, "OS-FLV-DISABLED:disabled": false, "os-flavor-access:is_public": true, "rxtx_factor": 1.0, "disk": 0, "id": "c1", "name": "cirros256", "vcpus": 1, "swap": "", "OS-FLV-EXT-DATA:ephemeral": 0} | 19:45 |
| mordred | mnaser: http://paste.openstack.org/raw/745281/ | 19:45 |
| mordred | mnaser: so I guess I just need to pick a different flavor | 19:46 |
| mnaser | we should probably fix what creates cirros256 | 19:46 |
| mnaser | did taht fail in nodepool, mordred ? | 19:47 |
| mnaser | no openstacksdk, hmm weird | 19:47 |
| mordred | mnaser: we pick the smallest flavor sorted by ram | 19:47 |
| mnaser | *something* creates that flavor.. | 19:48 |
| mordred | mnaser: so I think I need to add an 'if' for disk != 0 | 19:48 |
| mnaser | yeah if you're not doing bfv and the flavor has disk == 0 then it should not use that flavor | 19:48 |
| mnaser | but http://git.openstack.org/cgit/openstack-dev/devstack/tree/lib/nova#n1165 | 19:49 |
| cdent | devstack creates that flavor | 19:49 |
| cdent | jinx | 19:49 |
| mnaser | mordred: so i guess in openstacksdk world of things, it shouldn't pick a flavor that has disk_gb=0 when trying to bfv (as of train) | 19:49 |
| mordred | mnaser: https://review.openstack.org/637618 Make sure we pick flavors with disk <-- I think that should do it yeah? | 19:52 |
| mnaser | mordred: assuming python evaluates flavor.disk set to 0 as false then yes | 19:53 |
| mordred | mnaser: we'll find out! :) | 19:53 |
| mnaser | but i forget fundamental python rules | 19:53 |
| mnaser | we're supposed to be experts but half the tabs i open are "how the f does X language do switch cases" | 19:53 |
| *** sdake_ has quit IRC | 19:54 | |
| *** wolverineav has joined #openstack-nova | 19:58 | |
| *** thgcorrea has quit IRC | 20:00 | |
| *** mriedem has quit IRC | 20:03 | |
| *** mriedem has joined #openstack-nova | 20:04 | |
| *** jobewan has joined #openstack-nova | 20:05 | |
| *** wolverineav has quit IRC | 20:06 | |
| *** ttsiouts has quit IRC | 20:09 | |
| *** ttsiouts has joined #openstack-nova | 20:10 | |
| *** ttsiouts has quit IRC | 20:14 | |
| *** wolverineav has joined #openstack-nova | 20:16 | |
| *** gbarros has quit IRC | 20:17 | |
| *** awaugama has quit IRC | 20:20 | |
| *** awaugama has joined #openstack-nova | 20:20 | |
| *** whoami-rajat has quit IRC | 20:23 | |
| *** ttsiouts has joined #openstack-nova | 20:28 | |
| *** eharney has quit IRC | 20:29 | |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Introduce the PENDING instance state https://review.openstack.org/566473 | 20:36 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Allow rebuild for instances in PENDING state https://review.openstack.org/637585 | 20:36 |
| *** agopi has quit IRC | 20:37 | |
| openstackgerrit | Vlad Gusev proposed openstack/nova master: [WIP] libvirt: Add a default Virtio RNG device to guests https://review.openstack.org/616603 | 20:37 |
| openstackgerrit | Vlad Gusev proposed openstack/nova master: libvirt: Add a default Virtio RNG device to guests https://review.openstack.org/616603 | 20:38 |
| *** gbarros has joined #openstack-nova | 20:41 | |
| *** awaugama has quit IRC | 20:46 | |
| *** jmlowe has quit IRC | 20:56 | |
| mriedem | weird that we send the resize.revert.(start|end) notifications from the source host during finish_revert_resize which is half of the actual revert | 20:57 |
| mriedem | the start notification should happen on the dest host in revert_resize() | 20:57 |
| mriedem | must not be a big deal | 20:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add revert_snapshot_based_resize_at_dest compute method https://review.openstack.org/637630 | 21:03 |
| *** erlon has quit IRC | 21:04 | |
| *** ttsiouts has quit IRC | 21:07 | |
| *** ttsiouts has joined #openstack-nova | 21:08 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.openstack.org/635669 | 21:10 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Use live_migration_claim() to check dest resources https://review.openstack.org/634606 | 21:10 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: Make dest send NUMAMigrateData to the source https://review.openstack.org/634828 | 21:10 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: update NUMA-related XML on the source https://review.openstack.org/635229 | 21:10 |
| artom | ^^ It works. It actually works. | 21:10 |
| *** ttsiouts has quit IRC | 21:13 | |
| mriedem | it also seems weird that the migration.status is changed to 'reverted' on the dest host before the revert is actually done on the source host | 21:21 |
| cdent | this is what you get for looking under rocks | 21:24 |
| mriedem | yeah, tends to happen when you re-write something based on old gorp | 21:25 |
| *** wolverineav has quit IRC | 21:29 | |
| *** rcernin has joined #openstack-nova | 21:40 | |
| * cdent calls it a night to be fresh to look under rocks tomorrow | 21:42 | |
| cdent | goodnight | 21:42 |
| *** cdent has quit IRC | 21:42 | |
| *** ttsiouts has joined #openstack-nova | 21:43 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Lock detach_volume https://review.openstack.org/637534 | 21:44 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Restore connection_info after live migration rollback https://review.openstack.org/551349 | 21:51 |
| *** ttsiouts has quit IRC | 21:53 | |
| *** ttsiouts has joined #openstack-nova | 21:54 | |
| *** moshele has quit IRC | 21:54 | |
| *** ttsiouts has quit IRC | 21:59 | |
| *** gbarros has quit IRC | 22:04 | |
| *** wwriverrat has left #openstack-nova | 22:07 | |
| mriedem | huh, we don't call _update_scheduler_instance_info on finish_revert_resize - again, weird, since we've changed the instance.host | 22:11 |
| *** dave-mccowan has joined #openstack-nova | 22:16 | |
| *** dave-mccowan has quit IRC | 22:21 | |
| *** _fragatina has quit IRC | 22:25 | |
| *** _fragatina has joined #openstack-nova | 22:26 | |
| *** sdake has joined #openstack-nova | 22:27 | |
| *** sdake has quit IRC | 22:27 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Use migration_status during volume migrating and retyping https://review.openstack.org/637224 | 22:29 |
| *** _alastor_ has joined #openstack-nova | 22:32 | |
| *** jmlowe has joined #openstack-nova | 22:32 | |
| *** sdake has joined #openstack-nova | 22:33 | |
| *** mvkr has joined #openstack-nova | 22:36 | |
| *** _alastor_ has quit IRC | 22:36 | |
| *** eharney has joined #openstack-nova | 22:45 | |
| *** sdake has quit IRC | 22:46 | |
| *** sdake has joined #openstack-nova | 22:48 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add revert_snapshot_based_resize_at_dest compute method https://review.openstack.org/637630 | 22:54 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add finish_revert_snapshot_based_resize_at_source compute method https://review.openstack.org/637647 | 22:54 |
| *** pbing19 has quit IRC | 22:57 | |
| *** eharney has quit IRC | 22:58 | |
| *** tkajinam has joined #openstack-nova | 23:00 | |
| mriedem | dansmith: this is easy https://review.openstack.org/#/c/635315/ and unblocks a fix we've been talking about for a long time | 23:01 |
| *** mriedem has quit IRC | 23:03 | |
| *** dklyle has quit IRC | 23:03 | |
| *** munimeha1 has quit IRC | 23:12 | |
| *** mlavalle has quit IRC | 23:18 | |
| *** sdake has quit IRC | 23:24 | |
| *** sdake has joined #openstack-nova | 23:24 | |
| *** jobewan has quit IRC | 23:28 | |
| *** ociuhandu has joined #openstack-nova | 23:30 | |
| *** sdake has quit IRC | 23:32 | |
| *** ociuhandu has quit IRC | 23:35 | |
| *** gbarros has joined #openstack-nova | 23:41 | |
| *** agopi has joined #openstack-nova | 23:47 | |
| *** ttsiouts has joined #openstack-nova | 23:51 | |
| *** ttsiouts has quit IRC | 23:57 | |
| *** spsurya has quit IRC | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!