Wednesday, 2019-02-20

*** artom has joined #openstack-nova00:00
*** liuyulong has quit IRC00:04
*** wolverineav has joined #openstack-nova00:06
*** wolverineav has quit IRC00:10
*** markvoelker has quit IRC00:15
*** jobewan has quit IRC00:18
*** wolverineav has joined #openstack-nova00:19
*** itlinux has joined #openstack-nova00:21
*** wolverineav has quit IRC00:23
*** macza has quit IRC00:29
*** mlavalle has quit IRC00:32
*** lbragstad has quit IRC00:34
*** gbarros has joined #openstack-nova00:36
*** wolverineav has joined #openstack-nova00:37
*** gbarros has quit IRC00:39
*** gbarros has joined #openstack-nova00:49
*** ileixe has joined #openstack-nova00:53
openstackgerritsean mooney proposed openstack/os-vif master: make functional tests run on python 3  https://review.openstack.org/63805300:58
*** sdake has joined #openstack-nova00:59
*** tbachman has joined #openstack-nova01:01
openstackgerritsean mooney proposed openstack/os-vif master: make functional tests run on python 3  https://review.openstack.org/63805301:01
*** lbragstad has joined #openstack-nova01:01
*** wolverineav has quit IRC01:03
*** dave-mccowan has joined #openstack-nova01:06
*** wolverineav has joined #openstack-nova01:07
*** hongbin has joined #openstack-nova01:07
*** markvoelker has joined #openstack-nova01:12
*** wolverineav has quit IRC01:12
*** tiendc has joined #openstack-nova01:13
*** zhubx has joined #openstack-nova01:16
*** _fragatina has quit IRC01:21
*** wolverineav has joined #openstack-nova01:27
*** itlinux has quit IRC01:28
*** igordc has quit IRC01:30
*** wolverineav has quit IRC01:32
*** wolverineav has joined #openstack-nova01:40
openstackgerritMerged openstack/os-vif master: Add create_port field in VIFPortProfileOpenVSwitch profile  https://review.openstack.org/63606101:41
*** Dinesh_Bhor has joined #openstack-nova01:41
*** markvoelker has quit IRC01:44
*** wolverineav has quit IRC01:44
*** tetsuro has joined #openstack-nova01:50
openstackgerritsean mooney proposed openstack/os-vif master: modify functional base.py to allow using vscode  https://review.openstack.org/63805801:53
*** bhagyashris has joined #openstack-nova01:53
*** eharney has quit IRC02:08
*** itlinux has joined #openstack-nova02:09
*** hamzy has joined #openstack-nova02:13
*** igordc has joined #openstack-nova02:15
*** wolverineav has joined #openstack-nova02:17
*** wolverineav has quit IRC02:22
*** wolverineav has joined #openstack-nova02:25
openstackgerritMichael Still proposed openstack/nova master: Create specialist set_macaddr_and_vlan helper.  https://review.openstack.org/62422702:29
openstackgerritMichael Still proposed openstack/nova master: Move create_tap_dev into privsep.  https://review.openstack.org/62422802:29
openstackgerritMichael Still proposed openstack/nova master: Move set_vf_interface_vlan to be with its only caller.  https://review.openstack.org/62422902:29
openstackgerritMichael Still proposed openstack/nova master: Move DHCP releasing to privsep.  https://review.openstack.org/62423002:29
openstackgerritMichael Still proposed openstack/nova master: Convert additional IP management calls to privsep.  https://review.openstack.org/62423102:29
openstackgerritMichael Still proposed openstack/nova master: Move route management to privsep.  https://review.openstack.org/62423202:29
openstackgerritMichael Still proposed openstack/nova master: Move additional IP address management to privsep.  https://review.openstack.org/62459102:29
openstackgerritMichael Still proposed openstack/nova master: Move slight bonkers IP management to privsep.  https://review.openstack.org/62459202:29
openstackgerritMichael Still proposed openstack/nova master: Move arping to privsep.  https://review.openstack.org/62459302:29
openstackgerritMichael Still proposed openstack/nova master: Move cleaning conntrack to privsep.  https://review.openstack.org/62459402:29
openstackgerritMichael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement.  https://review.openstack.org/63543102:29
openstackgerritMichael Still proposed openstack/nova master: Move killing processes to privsep.  https://review.openstack.org/63543202:29
openstackgerritMichael Still proposed openstack/nova master: Move FP device creation and deletion to privsep.  https://review.openstack.org/63543302:29
openstackgerritMichael Still proposed openstack/nova master: Cleanup the exec_ebtables code a little.  https://review.openstack.org/63543402:29
openstackgerritMichael Still proposed openstack/nova master: Privsep the ebtables modification code.  https://review.openstack.org/63543502:29
openstackgerritMichael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep.  https://review.openstack.org/63543602:29
openstackgerritMichael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep.  https://review.openstack.org/63650802:29
*** wolverineav has quit IRC02:30
*** whoami-rajat has joined #openstack-nova02:31
*** sdake has quit IRC02:36
*** yaawang has joined #openstack-nova02:38
*** markvoelker has joined #openstack-nova02:41
*** Kunpeng has joined #openstack-nova02:43
*** macza has joined #openstack-nova02:52
*** macza has quit IRC02:57
*** psachin has joined #openstack-nova03:05
openstackgerritZhenyu Zheng proposed openstack/nova master: Add method to allow reset fields for root bdm in BDM obj  https://review.openstack.org/61467203:09
openstackgerritZhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported  https://review.openstack.org/61475003:10
*** markvoelker has quit IRC03:15
*** agopi has joined #openstack-nova03:16
*** hamzy has quit IRC03:20
openstackgerritYongli He proposed openstack/nova master: Adds the server group info into show server detail API.  https://review.openstack.org/62147403:34
*** itlinux has quit IRC03:45
*** udesale has joined #openstack-nova03:56
*** itlinux has joined #openstack-nova04:02
*** ileixe has quit IRC04:03
*** gbarros has quit IRC04:06
*** itlinux has quit IRC04:10
openstackgerritMerged openstack/os-vif master: Convert hardcoded regexes to raw strings for py36  https://review.openstack.org/63511104:12
*** itlinux has joined #openstack-nova04:12
*** markvoelker has joined #openstack-nova04:12
openstackgerritmelanie witt proposed openstack/nova master: WIP Add online data migration for populating user_id  https://review.openstack.org/63335104:14
openstackgerritmelanie witt proposed openstack/nova master: WIP Add get_counts() to InstanceMappingList  https://review.openstack.org/63807204:14
openstackgerritmelanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement  https://review.openstack.org/63807304:14
*** wolverineav has joined #openstack-nova04:15
*** hamzy has joined #openstack-nova04:16
*** itlinux has quit IRC04:18
*** janki has joined #openstack-nova04:22
*** itlinux has joined #openstack-nova04:23
*** sridharg has joined #openstack-nova04:26
*** itlinux has quit IRC04:28
*** dave-mccowan has quit IRC04:31
*** itlinux has joined #openstack-nova04:34
*** lbragstad_ has joined #openstack-nova04:36
*** lbragstad has quit IRC04:37
*** markvoelker has quit IRC04:44
openstackgerritMerged openstack/nova master: Drop the integrated-gate (py27) template  https://review.openstack.org/63494904:53
*** owalsh_ has joined #openstack-nova04:54
*** wolverineav has quit IRC04:55
*** owalsh has quit IRC04:57
*** ileixe has joined #openstack-nova04:59
openstackgerritBoxiang Zhu proposed openstack/nova master: Convert to raw format into rbd volume  https://review.openstack.org/63808005:02
*** hongbin has quit IRC05:04
*** igordc has quit IRC05:08
*** igordc has joined #openstack-nova05:20
*** lbragstad has joined #openstack-nova05:23
*** itlinux_ has joined #openstack-nova05:24
*** lbragstad_ has quit IRC05:25
*** itlinux has quit IRC05:27
*** lbragstad_ has joined #openstack-nova05:29
*** ociuhandu_ has quit IRC05:30
*** ociuhandu has joined #openstack-nova05:30
*** lbragstad has quit IRC05:31
*** pbing19 has joined #openstack-nova05:39
*** itlinux has joined #openstack-nova05:40
*** lbragstad has joined #openstack-nova05:41
*** markvoelker has joined #openstack-nova05:42
*** itlinux_ has quit IRC05:43
*** lbragstad_ has quit IRC05:43
*** _fragatina has joined #openstack-nova05:44
*** _fragatina has quit IRC05:45
*** _fragatina has joined #openstack-nova05:46
*** k4ch0 has joined #openstack-nova05:52
*** itlinux has quit IRC05:56
*** lbragstad_ has joined #openstack-nova05:57
*** tkajinam_ has joined #openstack-nova05:57
*** lbragstad has quit IRC05:58
*** tkajinam has quit IRC05:59
*** ratailor has joined #openstack-nova06:05
*** wolverineav has joined #openstack-nova06:07
*** k4ch0 has left #openstack-nova06:11
*** wolverineav has quit IRC06:11
*** markvoelker has quit IRC06:15
*** yaawang has quit IRC06:15
*** lbragstad has joined #openstack-nova06:20
*** lbragstad_ has quit IRC06:22
*** itlinux has joined #openstack-nova06:22
*** sdake has joined #openstack-nova06:26
*** sdake has quit IRC06:27
*** itlinux has quit IRC06:28
*** igordc has quit IRC06:31
*** itlinux has joined #openstack-nova06:32
*** pbing19 has quit IRC06:32
*** macza has joined #openstack-nova06:34
openstackgerritSundar Nadathur proposed openstack/nova master: Calculate RequestGroup resource provider mapping  https://review.openstack.org/61623906:36
openstackgerritSundar Nadathur proposed openstack/nova master: Fill the RequestGroup mapping during schedule  https://review.openstack.org/61952806:36
openstackgerritSundar Nadathur proposed openstack/nova master: ksa auth conf and client for cyborg access  https://review.openstack.org/63124206:36
*** macza has quit IRC06:38
openstackgerritSundar Nadathur proposed openstack/nova master: Calculate RequestGroup resource provider mapping  https://review.openstack.org/61623906:49
openstackgerritSundar Nadathur proposed openstack/nova master: Fill the RequestGroup mapping during schedule  https://review.openstack.org/61952806:49
openstackgerritSundar Nadathur proposed openstack/nova master: ksa auth conf and client for cyborg access  https://review.openstack.org/63124206:49
openstackgerritSundar Nadathur proposed openstack/nova master: Find the name of the device profile, if any, in flavor extra specs. Get its profile groups (equiv to flavor request groups) from Cyborg. Parse/validate them similar to extra_specs. Generate RequestGroup objects and add them to the request spec so that      https://review.openstack.org/63124306:49
openstackgerritYongli He proposed openstack/nova master: Add server subresouce topology API  https://review.openstack.org/62147606:50
*** itlinux has quit IRC06:50
*** itlinux has joined #openstack-nova06:52
*** Luzi has joined #openstack-nova06:52
*** _fragatina has quit IRC06:53
*** _fragatina has joined #openstack-nova06:54
*** itlinux has quit IRC06:57
openstackgerritSundar Nadathur proposed openstack/nova master: Calculate RequestGroup resource provider mapping  https://review.openstack.org/61623906:59
openstackgerritSundar Nadathur proposed openstack/nova master: Fill the RequestGroup mapping during schedule  https://review.openstack.org/61952806:59
openstackgerritSundar Nadathur proposed openstack/nova master: ksa auth conf and client for cyborg access  https://review.openstack.org/63124206:59
openstackgerritSundar Nadathur proposed openstack/nova master: WIP: Add Cyborg device profile groups to spec obj.  https://review.openstack.org/63124306:59
openstackgerritSundar Nadathur proposed openstack/nova master: Create and bind Cyborg ARQs.  https://review.openstack.org/63124406:59
*** _fragatina has quit IRC07:00
*** markvoelker has joined #openstack-nova07:01
*** itlinux has joined #openstack-nova07:03
alex_xumelwitt: I did a test on your patch. I create VM with admin user, then I switch to demo user, I still can show that VM.07:07
*** itlinux has quit IRC07:07
alex_xumelwitt: this because https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L425 the show API policy check without instance project id as target07:09
*** itlinux has joined #openstack-nova07:26
openstackgerritZhenyu Zheng proposed openstack/nova master: WIP detach root volume API changes  https://review.openstack.org/62398107:28
openstackgerritBoxiang Zhu proposed openstack/nova master: Convert to raw format into rbd volume  https://review.openstack.org/63808007:28
*** ccamacho has quit IRC07:29
*** ccamacho has joined #openstack-nova07:29
*** udesale has quit IRC07:34
*** udesale has joined #openstack-nova07:35
*** itlinux has quit IRC07:36
*** moshele has joined #openstack-nova07:40
*** ratailor_ has joined #openstack-nova07:40
*** ratailor has quit IRC07:43
*** tesseract has joined #openstack-nova07:56
melwittalex_xu: thank you for the example. I finally understand your point. sorry I didn't understand it previously07:57
alex_xumelwitt: np...you still wake up...07:58
melwittI kept thinking the policy project_id check would do it, but if there is no target, I'm not sure what it would be checking. so that is my bad07:58
melwittyeah, made a mistake of checking my zuul results before going to sleep :P07:58
Dinesh_BhorHow can I restrict the resize/migration of an instance to the same host-aggregate ?07:58
alex_xuhahaha07:58
*** pcaruana has joined #openstack-nova07:59
alex_xuDinesh_Bhor: for resize, you probably can choice a different flavor which with different aggregate metadata. probably no way for migration08:00
*** itlinux has joined #openstack-nova08:03
Dinesh_Bhoralex_xu: Okay, We actually have networks based on host-aggregates and we would like to restrict the VM's resize/migration to the same aggregate for security reasons.08:04
openstackgerritmelanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement  https://review.openstack.org/63807308:04
alex_xuDinesh_Bhor: ah, sorry, I misunderstand, you want it in the same agg.08:04
alex_xuDinesh_Bhor: I guess it should work as expected in the current implementation08:04
alex_xuif your flavor with aggregate metadata in the beginning. I guess you don't have that.08:05
Dinesh_Bhoralex_xu: yes, we don't have them08:06
*** awalende has joined #openstack-nova08:06
*** ralonsoh has joined #openstack-nova08:07
alex_xuDinesh_Bhor: the only way I have is using resize to update a flavor with agg metadat, then limited  into the same agg. otherwise I don't think we are any existed method to do that.08:07
Dinesh_Bhoralex_xu: okay, Thanks. I will check it08:08
*** jchhatbar has joined #openstack-nova08:09
openstackgerritYongli He proposed openstack/nova master: Adds the server group info into show server detail API.  https://review.openstack.org/62147408:09
*** jchhatbar has quit IRC08:10
*** jchhatbar has joined #openstack-nova08:11
*** rpittau has joined #openstack-nova08:11
*** janki has quit IRC08:11
*** pbing19 has joined #openstack-nova08:13
*** tkajinam_ has quit IRC08:14
*** lbragstad has quit IRC08:15
*** itlinux has quit IRC08:16
openstackgerritBalazs Gibizer proposed openstack/nova master: Calculate RequestGroup resource provider mapping  https://review.openstack.org/61623908:16
openstackgerritBalazs Gibizer proposed openstack/nova master: Fill the RequestGroup mapping during schedule  https://review.openstack.org/61952808:16
openstackgerritBalazs Gibizer proposed openstack/nova master: Pass resource provider mapping to neutronv2 api  https://review.openstack.org/61624008:16
openstackgerritBalazs Gibizer proposed openstack/nova master: Recalculate request group - RP mapping during re-schedule  https://review.openstack.org/61952908:16
openstackgerritBalazs Gibizer proposed openstack/nova master: Send RP uuid in the port binding  https://review.openstack.org/56945908:16
openstackgerritBalazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request  https://review.openstack.org/57331708:16
openstackgerritBalazs Gibizer proposed openstack/nova master: Remove port allocation during detach  https://review.openstack.org/62242108:16
openstackgerritBalazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest  https://review.openstack.org/62531008:16
openstackgerritBalazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist  https://review.openstack.org/62531108:16
openstackgerritBalazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF  https://review.openstack.org/62354308:17
openstackgerritBalazs Gibizer proposed openstack/nova master: Support server create with ports having resource request  https://review.openstack.org/63636008:17
openstackgerritBalazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance to make place for port healing  https://review.openstack.org/63795308:17
openstackgerritBalazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance (2)  https://review.openstack.org/63795408:17
openstackgerritBalazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations  https://review.openstack.org/63795508:17
*** yan0s has joined #openstack-nova08:21
*** ttsiouts has joined #openstack-nova08:22
*** tssurya has joined #openstack-nova08:22
*** itlinux has joined #openstack-nova08:23
*** pbing19 has quit IRC08:24
*** helenafm has joined #openstack-nova08:26
*** itlinux has quit IRC08:28
*** rcernin has quit IRC08:29
*** dtantsur|afk is now known as dtantsur08:34
bauzasgood morning Nova08:41
gibigood morning bauzas08:44
openstackgerritZhenyu Zheng proposed openstack/nova master: WIP detach root volume API changes  https://review.openstack.org/62398108:45
*** owalsh_ is now known as owalsh08:48
bauzasgibi: :-)08:51
*** pbing19 has joined #openstack-nova08:56
*** ociuhandu has quit IRC09:00
*** gibi has quit IRC09:00
*** tetsuro has quit IRC09:12
openstackgerritSilvan Kaiser proposed openstack/nova master: Exec systemd-run without --user flag in Quobyte driver  https://review.openstack.org/55419509:15
*** ociuhandu has joined #openstack-nova09:24
*** ociuhandu has quit IRC09:29
*** davidsha has joined #openstack-nova09:30
openstackgerritYongli He proposed openstack/nova master: Adds the server group info into show server detail API.  https://review.openstack.org/62147409:33
openstackgerritSilvan Kaiser proposed openstack/nova master: Added mount fstype based validation of Quobyte mounts  https://review.openstack.org/52224509:36
kaiserskaisers09:38
kaisers*dang* missed out on the hotkey09:39
kaisersstephenfin: Hi! Updated both CLs based on yesterdays feedback :)09:40
stephenfinack09:40
*** Dinesh_Bhor has quit IRC09:41
*** derekh has joined #openstack-nova09:45
*** panda|off is now known as panda09:46
kashyapgibi: The Zuul is -2 here because the parent patch is not merged yet? -- https://review.openstack.org/#/c/637152/09:48
*** cfriesen has quit IRC09:50
*** bhagyashris has quit IRC09:50
stephenfinkaisers: +2 on https://review.openstack.org/#/c/554195/ *but* I do have some comments that I'd really like to see addressed, if you have time. They're not blockers though09:51
kaisersstephenfin: can be solved, np09:55
*** ociuhandu has joined #openstack-nova09:57
openstackgerritLajos Katona proposed openstack/python-novaclient master: Add support for microversion v2.69  https://review.openstack.org/63723409:57
openstackgerritLajos Katona proposed openstack/python-novaclient master: Add support for microversion v2.70  https://review.openstack.org/63723409:58
stephenfinkaisers: Cool. Also +2 on https://review.openstack.org/#/c/522245/ with two nice-to-have but not blocking nits09:58
*** markvoelker has quit IRC10:01
*** markvoelker has joined #openstack-nova10:02
stephenfinHmm, no gibi. How odd10:05
*** mrch_ has joined #openstack-nova10:05
stephenfinbauzas: You're next in line. Could you push this trivial follow up patch through? https://review.openstack.org/#/c/63696710:06
stephenfinbauzas: Next in line for reviews and not for the throne, I'm afraid. They'd never accept a Frenchman for that10:06
*** markvoelker has quit IRC10:06
stephenfin...unless the alternative was Boris Johnson, maybe10:07
bauzasstephenfin: sorry I don't remember which trivial patch to push ? ;)10:07
bauzasand well, for the throne, we had some history here about kings...10:08
stephenfinMy policy on trivial patches is pro having it and pro pushing it10:09
kashyapstephenfin: Re-thinking is a bug really necessary here?: https://review.openstack.org/#/c/637578/1/nova/virt/libvirt/driver.py10:09
kashyaps/Re-thinking/Re-thinking,/10:10
bauzasstephenfin: ah sorry, I misunderstood the "this"10:10
bauzasstephenfin: but sure, yeah10:10
stephenfinkashyap: How so?10:11
kashyapstephenfin: This line: https://review.openstack.org/#/c/637578/1/nova/virt/libvirt/driver.py@496110:11
kashyapstephenfin: Where you guessed a bug might be useful10:11
stephenfinkashyap: I was referring to https://review.openstack.org/#/c/637578/1/nova/virt/libvirt/driver.py@495710:12
kashyapCorrect, I posted the wrong line10:12
stephenfinWhere we create a PTY device for non-QEMU/KVM, non-parallels hypervisors10:12
bauzasstephenfin: I just +1d because I have a question10:13
bauzas(even for a nit :p )10:13
kashyapstephenfin: Right, but the non-{QEMU/KVM, -Parellels} get a PTY device anyway.10:13
stephenfinkashyap: Not previously though, right? Previously the 'if CONF.serial_console.enabled:' line in '_create_pty_device' would have stopped that happening10:14
kashyapYou want to capture that the existing code didn't create a serial device?10:14
kashyapstephenfin: Previously too, according the existing table; and I checked with an s390x maintainer, too, FWIW10:14
stephenfinkashyap: Assuming _that_ is the incorrect behavior, yes10:15
kashyapHeh, what a maze; I'll see about what to file once I re-read the old code again.10:15
stephenfinkashyap: To be completely clear, I don't know if it should have one or not. I'm going on Georg's comments10:15
*** pbing19 has quit IRC10:15
kashyapstephenfin: Georg says it's OK to not file one.10:16
stephenfinWhat are the non-QEMU/KVM, non-Parallels libvirt drivers we support10:16
stephenfin*?10:16
kashyapstephenfin: zKVM10:16
kashyapMore accurately called "z/VM" I guess10:16
stephenfinbauzas: Replied, but the answer is here https://review.openstack.org/#/c/636627/1/nova/conf/base.py@2910:17
kashyapstephenfin: It is z/VM  (ignore the zKVM bit)10:17
stephenfinkashyap: I can get onboard with that, but I do think that we should have a test and call out the change in behavior in the commit message if there is no bug10:18
stephenfinOtherwise we've got a change in behavior with no indication to future reviewers of the patch as to why that change happened10:19
kashyapstephenfin: Yeah, that sounds reasonable.10:19
kashyapI'm all for capturing the intention of a change as clearly as we can :-)10:19
*** gokhani has quit IRC10:20
*** priteau has joined #openstack-nova10:22
*** priteau has quit IRC10:28
*** moshele has quit IRC10:28
*** wolverineav has joined #openstack-nova10:29
*** gibi has joined #openstack-nova10:32
*** wolverineav has quit IRC10:33
gibibauzas: could you look at pike backport please? https://review.openstack.org/#/c/603044 the original fix was merged on master when during the Queens cycle10:33
bauzasgibi: ack10:34
*** pbing19 has joined #openstack-nova10:34
openstackgerritLee Yarwood proposed openstack/nova master: compute: Reject resize requests when the source host is down  https://review.openstack.org/62348910:34
gibibauzas: thanks10:35
openstackgerritLee Yarwood proposed openstack/nova master: compute: Reject resize requests when the source host is down  https://review.openstack.org/62348910:35
lyarwoodmdbooth_: ^ dropped the ignore_forced_down stuff, lets see if anyone raises the LM use case I was talking about.10:35
bauzasgibi: I have multiple concerns with the backport10:37
gibibauzas: the new config options?10:38
bauzasgibi: lemme review a bit more before10:41
*** mdbooth_ is now known as mdbooth10:43
mdboothlyarwood: Yeah, that LM use case just sounds wrong to me. The other thing is that if a service is forced_down, anything which does a service check on it will return that it's down. That just seems really fragile to me, hence I wanted a functional test.10:45
mdbooth... if we were going to rely on it, that is.10:45
*** erlon has joined #openstack-nova10:50
*** ccamacho has quit IRC10:54
lyarwoodmdbooth: ack yeah that's fine and agreed it's odd that LM would even work with things forced_down tbh10:55
bauzasgibi: commented now10:57
*** ileixe has quit IRC10:59
gibibauzas: thanks11:00
*** moshele has joined #openstack-nova11:01
bauzasgibi: i could have proposed my own revision, but given it's a new backport contributor, I prefer him to amend himself and correctly expain the diffs11:01
gibiif the author doesn't fix what you asked then I can fixup that patch11:01
bauzasgibi: ok cool, just keep an eye then11:02
gibibauzas: agree with your strategy11:02
gibibauzas: I will check back in a week11:02
*** markvoelker has joined #openstack-nova11:03
*** ccamacho has joined #openstack-nova11:12
*** ttsiouts has quit IRC11:13
*** ttsiouts has joined #openstack-nova11:13
*** udesale has quit IRC11:14
*** ttsiouts has quit IRC11:18
*** ratailor_ has quit IRC11:23
*** thgcorrea has joined #openstack-nova11:27
*** markvoelker has quit IRC11:36
*** wolverineav has joined #openstack-nova11:37
*** sapd1 has quit IRC11:38
*** wolverineav has quit IRC11:41
*** awalende has quit IRC11:49
*** awalende has joined #openstack-nova11:50
*** awalende has quit IRC11:51
*** awalende has joined #openstack-nova11:51
*** sapd1 has joined #openstack-nova11:55
*** ttsiouts has joined #openstack-nova11:59
*** cdent has joined #openstack-nova12:04
*** erlon has quit IRC12:04
*** erlon has joined #openstack-nova12:06
*** erlon has quit IRC12:07
*** erlon_ has joined #openstack-nova12:07
*** erlon__ has joined #openstack-nova12:09
*** sapd1 has quit IRC12:10
*** erlon_ has quit IRC12:13
*** janki has joined #openstack-nova12:14
*** jchhatbar has quit IRC12:15
*** zhubx has quit IRC12:19
*** zhubx has joined #openstack-nova12:19
*** sapd1 has joined #openstack-nova12:22
*** macza has joined #openstack-nova12:31
*** markvoelker has joined #openstack-nova12:33
*** awalende has quit IRC12:34
*** awalende has joined #openstack-nova12:35
*** macza has quit IRC12:35
*** awalende has quit IRC12:36
*** Sundar has joined #openstack-nova12:36
*** awalende has joined #openstack-nova12:36
*** ondrejme has joined #openstack-nova12:36
*** tiendc has quit IRC12:38
SundarHi gibi, please ping me if you are around12:38
*** liuyulong has joined #openstack-nova12:43
gibiSundar: hi!12:44
gibiSundar: I also tried to talk to you in my morning12:45
gibiSundar: I saw that you updated the bottom of the bandwidth patch series12:45
gibiSundar: but I guess you used an old version of my patches12:45
openstackgerritSilvan Kaiser proposed openstack/nova master: Exec systemd-run without --user flag in Quobyte driver  https://review.openstack.org/55419512:48
*** rpittau has quit IRC12:49
Sundargibi: The patch series was rebased by Eric. It does seem like an older version. Sorry if it impacts your work.12:51
gibiSundar: I restored the latest content of my patches with an extra rebase couple of hours ago12:51
Sundargibi: I suppose the patch got updated after the rebase12:51
gibiSundar: so at the moment my patches are up-to-date12:51
gibiSundar: most probably I updated my patches after the last rebase of your patches12:52
*** sridharg has quit IRC12:52
gibiSundar: and when your patches was pushed up it changed my patche back to an old version12:52
Sundargibi: Any suggestions for keeping both in sync?12:55
Sundargibi: I mean, apart from manual rebasing periodically12:55
Sundargibi: Apologies again for using an older version12:57
openstackgerritSilvan Kaiser proposed openstack/nova master: Added mount fstype based validation of Quobyte mounts  https://review.openstack.org/52224512:58
gibiSundar: unfortunately if I push up a new version of the patches you are based on then you have to rebase yours top of my new version12:59
*** psachin has quit IRC13:01
kaisersstephenfin: ping :)13:01
Sundargibi: Got it. Could I ask you to review https://review.openstack.org/#/q/status:open+project:openstack/nova+bp/nova-cyborg-interaction? Your comments would be welcome!13:02
*** rpittau has joined #openstack-nova13:02
gibiSundar: I've added to my review queue13:03
*** psachin has joined #openstack-nova13:04
Sundargibi: Thank you. :) The only change I made to your patch (which has already been merged) is in https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L75, where I got it to return ident.13:04
*** markvoelker has quit IRC13:05
*** NewBruce has quit IRC13:08
*** NewBruce has joined #openstack-nova13:10
*** ivve has joined #openstack-nova13:10
gibiSundar: but now I don't see that change in your series13:11
kashyapHmm, seems like 'tox-py27' seem to randomly fail due to:13:13
kashyapsqlalchemy.exc.InterfaceError: (pymysql.err.InterfaceError) (0, '') (Background on this error at: http://sqlalche.me/e/rvf5)13:13
jaypipesam I the only person that thinks the phrase "tripleo standalone install" is an oxymoron?13:14
kashyapjaypipes: Heh, I guess that depends on what they mean by "standalone install"13:16
Sundargibi: I will take a look13:16
kashyapjaypipes: /me himself has never hands-on installed TripleO, though ...13:16
*** cdent_ has joined #openstack-nova13:22
*** cdent_ has quit IRC13:23
openstackgerritzhaixiaojun proposed openstack/nova master: When the flavor id is invalid, the message does not match the regular expression, missing the numbers from 0-9.  https://review.openstack.org/63815013:25
*** pbing19 has quit IRC13:28
*** mriedem has joined #openstack-nova13:28
jangutterkashyap, jaypipes: don't get me wrong, I love tripleo. It's also one of the most scarily self-referential things I've ever come across.13:29
mdboothsean-k-mooney: Through what's almost certainly a bug, but one which goes down a rabbit hole I'm not interested in right now, I've ended up with a port bound on a compute host which neutron doesn't think it's bound on, causing LM failure. What's the best way to kick it so I can get on with my day?13:30
jangutterjaypipes: I presume you're referring to tripleo-quickstart?13:31
openstackgerritMatt Riedemann proposed openstack/nova master: Check hosts have no instances for AZ rename  https://review.openstack.org/50920613:32
* mdbooth has been dreaming lately of a self-hosting openstack, where services run in the admin tenant of its own cloud. If you could sort out the bootstrapping, it's actually a really attractive proposition.13:32
*** agopi has quit IRC13:35
sean-k-mooneymdbooth: define bound. you could try a hard reboot but neutron is the souce of truth in this matter13:35
jaypipesjangutter: no, I'm referring to larsks's phrase "tripleo standalone install" in a recent ML post13:35
sean-k-mooneymdbooth: we recently merged a fix to prevent the network info cache form getting out of sync so that should fix nova db periodicaly13:36
mdboothsean-k-mooney: I suspect it's an agent issue. Bind fails on the destination. I just deleted the instance, though, so I'm guessing the mess is still there but as long as it doesn't affect me I don't care right now :)13:36
jangutterjaypipes: that sounds like a standalone networked computer in my mind.13:36
jaypipesI'm actually not sure what was meant.13:36
mdboothIt was a failed LM. LM failed because ssh keys weren't configured. Haven't looked , but presumably we created ports on the dest prior to LM, then didn't clean them up properly when it failed.13:37
mdboothSo second attempt to LM fails because port is already bound.13:37
jangutterjaypipes: reading the mail, I think this is "standalone" vs "integrating with an external ... " etc.13:38
larsksjaypipes: standalone tripleo: https://docs.openstack.org/tripleo-docs/latest/install/containers_deployment/standalone.html13:38
larsksSingle node tripleo deployment installed using the 'openstack tripleo deploy' command.13:39
jangutterlarsks: aaah, "standalone" vs "ha".13:39
jaypipesinteresting.13:39
*** gbarros has joined #openstack-nova13:39
larsksjangutter: not exactly.  "standalone" vs "multinode"13:39
jaypipesprobably better to call it "all-in-one" or "single-node", but ok13:40
larsksEh, I didn't name it :). But yes.13:40
jaypipes:)13:40
jaypipeslarsks: k, thx for the heads up. looks like this is relatively new functionality.13:40
larsksI think so. I believe it stems from wanting to handle underlcoud deployment the same way as overcloud deployment.13:41
jaypipesit's all a little too inception-y for me.13:41
jaypipesturtles all the way down ;)13:42
jangutterlarsks: and that's why I find tripleo so fascinating, going all in with self-referencing!13:42
jangutterlarsks: basically it's a scalability problem, where the problem is "how can I scale down to 1 node".13:42
openstackgerritBalazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance (2)  https://review.openstack.org/63795413:43
openstackgerritBalazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations  https://review.openstack.org/63795513:43
*** gbarros has quit IRC13:44
*** spsurya has joined #openstack-nova13:44
*** gbarros has joined #openstack-nova13:44
mdboothEurgh. I forgot about that weird F29 iscsi bug when I provisioned this devstack >:(13:44
stephenfinkaisers: sup?13:45
kaisersstephenfin: updates to both CLs13:46
kaisersstephenfin: mostly the open nits but check the is_sysd thing again, pls13:46
stephenfinack13:46
*** jmlowe has quit IRC13:47
sean-k-mooneylarsks: why does triplo build its docs like that. it makes them really hard to read givent tha that you have 3 or 4 release togehter with 2-3 distros13:47
larskssean-k-mooney: I have no idea.13:48
sean-k-mooneyif it wasnt for the fact i like stephenfin sanity it woul be neice if he had time to fix that...13:49
*** jchhatbar has joined #openstack-nova13:52
*** jchhatbar has quit IRC13:53
stephenfinsean-k-mooney: What about my sanity? :D13:54
*** jchhatbar has joined #openstack-nova13:54
*** janki has quit IRC13:54
sean-k-mooneystephenfin: im suggesting that it may be damaged if you were to undertake reworking all the tripplo docs to be readable13:55
stephenfinOh, yeah, feck that13:55
*** mlavalle has joined #openstack-nova14:00
janguttersean-k-mooney: once you get used to it, it's not so bad, but covering all the use cases you want to cover is going to drive you batty.14:00
*** markvoelker has joined #openstack-nova14:02
janguttersean-k-mooney: would be better if the "LIMIT ENVIRONMENT SPECIFIC CONTENT" bit worked....14:05
mriedemdansmith: down cells bp was technically dropped from runways yesterday. can we get the docs change merged since we can follow up with the admin guide stuff and because it's causing issues for other changes that need a new microversion (the rest api history doc means everyone has to rebase on this): https://review.openstack.org/#/c/635147/14:09
*** sdake has joined #openstack-nova14:10
*** agopi has joined #openstack-nova14:10
NewBrucehey sean-k-mooney!14:11
NewBrucehopefully i can be tied to the desk today! :)14:11
mriedemsean-k-mooney: adrianc: i'm pulling https://blueprints.launchpad.net/nova/+spec/libvirt-neutron-sriov-livemigration from runways14:13
*** _fragatina has joined #openstack-nova14:13
adriancmiredem: ill re-add to queue14:14
sean-k-mooneymriedem: ok.14:14
*** ttsiouts has quit IRC14:15
*** ttsiouts has joined #openstack-nova14:15
*** dave-mccowan has joined #openstack-nova14:16
*** sdake has quit IRC14:18
mriedemjackding: jroll: https://blueprints.launchpad.net/nova/+spec/flavor-extra-spec-image-property-validation and https://blueprints.launchpad.net/nova/+spec/ironic-conductor-groups are in runways now14:18
jrollthanks!14:19
NewBrucesean-k-mooney - to avoid cluttering the main chat here have dropped you full details in a DM14:22
*** HD|Laptop has joined #openstack-nova14:22
kaisersstephenfin: thnx for seeing this through to the current state14:23
sean-k-mooneyNewBruce: just finishing a code review but ill pop over in a miniute14:23
NewBruceno worries mate - working late tonight, so ill be here a while14:23
NewBrucehave been talking to mnaser about this as well14:23
mnaseri mean it is kindof a nova bug :)14:24
*** s10 has joined #openstack-nova14:28
*** jmlowe has joined #openstack-nova14:30
mriedemartom: replied to your questions about the tests in https://review.openstack.org/#/c/631948/14:30
*** eharney has joined #openstack-nova14:32
*** lbragstad has joined #openstack-nova14:32
dansmithmriedem: got it up now14:33
*** sdake has joined #openstack-nova14:34
*** priteau has joined #openstack-nova14:35
gibiefried, jaypipes: updated https://review.openstack.org/#/c/616239 based on what we agreed on Friday. If you could re-review that patch that would be awesome14:35
*** awalende has quit IRC14:35
openstackgerritSurya Seetharaman proposed openstack/nova master: API microversion 2.69: Handles Down Cells Documentation  https://review.openstack.org/63514714:36
openstackgerritSurya Seetharaman proposed openstack/nova master: [Doc Fix]Best practices for effectively tolerating down cells  https://review.openstack.org/63817314:36
*** markvoelker has quit IRC14:36
bauzasgibi: I need to jump on your b/w series14:36
bauzasgibi: later today14:36
*** awalende has joined #openstack-nova14:36
gibibauzas: thanks in advance14:37
*** lbragstad_ has joined #openstack-nova14:40
*** awalende has quit IRC14:41
*** lbragstad has quit IRC14:41
*** cfriesen has joined #openstack-nova14:48
*** jobewan has joined #openstack-nova14:52
*** lbragstad has joined #openstack-nova14:53
*** lbragstad_ has quit IRC14:54
*** lbragstad_ has joined #openstack-nova14:56
*** awaugama has joined #openstack-nova14:56
*** jackding has joined #openstack-nova14:57
*** sdake has quit IRC14:58
*** lbragstad has quit IRC14:58
*** lbragstad_ has quit IRC14:58
jackdingNeed another core to approve https://review.openstack.org/#/c/603844/. It's been too long.14:58
kashyapjackding: Hi, I have something unrelated to chat: CPU models15:00
efriedgibi: +215:00
*** lbragstad has joined #openstack-nova15:01
kashyapjackding: So I recall you filed this one: https://review.openstack.org/#/c/620959/ (Select cpu model from a list of cpu models)15:01
kashyapjackding: I thought you might be interested in this one: https://blueprints.launchpad.net/nova/+spec/cpu-selection-with-hypervisor-consideration15:02
*** efried is now known as efried_pto15:02
*** ysandeep has joined #openstack-nova15:03
gibiefried_pto: thanks15:04
kashyapI'll file a spec too.  In short, the core proposal here is to replace the existing two libvirt APIs with the "hypervisor-literate" APIs, which are far more useful.15:04
kashyapjackding: ^ It maps onto the comment I noted here: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3900,#L390915:05
ysandeep#openstack-nova A quick query, If my nova backend of compute nodes is ceph. And I evacuate instance.. Will my root disk of instance (rbd in ceph) will remain intact or the root disk will reimage(Old disk will be deleted and a new disk will be created from image)?15:07
*** NewBruce has quit IRC15:07
*** NewBruce has joined #openstack-nova15:08
mriedemysandeep: if you're evacuating to another compute host sharing the same ceph cluster the root disk should remain15:08
*** zhubx has quit IRC15:08
ysandeepmriedem, thank you so much .. Do you happen to have idea about - from which branch we have this feature?15:10
mriedemysandeep: that's been around a long time, that's why the evacuate api has an onSharedStorage parameter https://developer.openstack.org/api-ref/compute/?expanded=evacuate-server-evacuate-action-detail#evacuate-server-evacuate-action15:11
mriedemhaving said that, i'm sure there have been bug fixes over the years15:11
mriedemmdbooth probably knows best about that15:11
*** Luzi has quit IRC15:11
ysandeepmriedem, thank you soo much.. really appreciate your help..15:11
mriedemyw15:11
mdboothysandeep: It remains intact.15:11
*** lbragstad_ has joined #openstack-nova15:12
ysandeepmdbooth, thanks15:12
mdboothysandeep: Same for NFS.15:12
*** NewBruce has quit IRC15:12
openstackgerritAdrian Chiris proposed openstack/nova master: Add free for claimed, allocated devices  https://review.openstack.org/61612015:13
ysandeepmdbooth, thanks, i will test for nfs also15:13
openstackgerritAdrian Chiris proposed openstack/nova master: Allow per-port modification of vnic_type and profile  https://review.openstack.org/60736515:13
openstackgerritAdrian Chiris proposed openstack/nova master: Add get_instance_pci_request_from_vif  https://review.openstack.org/61992915:13
openstackgerritAdrian Chiris proposed openstack/nova master: SR-IOV Live migration indirect port support  https://review.openstack.org/62011515:13
openstackgerritAdrian Chiris proposed openstack/nova master: libvirt: auto detach/attach sriov ports on migration  https://review.openstack.org/62958915:13
*** wolverineav has joined #openstack-nova15:13
*** lbragstad has quit IRC15:13
jackdingkashyap: noted, thanks15:13
mdboothysandeep: Same for boot from volume too, fwiw.15:13
kashyapjackding: Just wanted to give a heads-up, so we don't duplicate efforts :-)15:14
*** pbing19 has joined #openstack-nova15:14
jackdingkashyap: sure thing.15:15
artommriedem, yep, saw that. I'll un-1 soon15:15
artomI also reviewed that series ass-backwards by looking at the top one first15:15
ysandeepmdbooth, yes i was aware for boot from volume(cinder volume) but I was not sure of nova disk(on cluster storage) and ephermal disk behavior15:15
*** NewBruce has joined #openstack-nova15:17
*** wolverineav has quit IRC15:18
*** lbragstad_ is now known as lbragstad15:18
*** NewBruce6 has joined #openstack-nova15:18
*** NewBruce has quit IRC15:18
*** jchhatbar has quit IRC15:19
*** NewBruce6 is now known as NewBruce15:20
*** moshele has quit IRC15:21
*** sapd1_x has joined #openstack-nova15:23
*** sapd1 has quit IRC15:23
*** markvoelker has joined #openstack-nova15:33
*** ysandeep has quit IRC15:38
mriedemtssurya: i'll poke on your novaclient change https://review.openstack.org/#/c/579563/ later this morning to try and sort out the test issue15:40
tssuryadansmith: feel free to author the documentation patch if its only those changes in your comments that need to change I can respin, but considering mriedem and you removed the votes I guess there are some obvious incorrect wordings15:40
dansmithtssurya: it's fine, just let me finish the call I'm on and then I'll push up a rev15:41
tssuryamriedem: yea thanks I am not sure why that address gets printed in the wrong order15:41
mriedemtssurya: my guess is something about dict hashseeds in py2715:41
tssuryamriedem: oh okay15:42
tssuryadansmith: thanks15:42
*** ivve has quit IRC15:52
jaypipesjackding: k, will review after gibi's patch.15:53
jackdingjaypipes: thanks15:53
*** rpittau has quit IRC15:55
*** rpittau_ has joined #openstack-nova15:55
*** rpittau_ is now known as rpittau15:57
*** ttsiouts has quit IRC15:58
*** ttsiouts has joined #openstack-nova15:59
*** ttsiouts has quit IRC16:03
*** NewBruce_ has joined #openstack-nova16:04
*** ttsiouts has joined #openstack-nova16:05
*** NewBruce_ has quit IRC16:05
tssuryamriedem: also here https://review.openstack.org/#/c/637217/ I am not entirely sure why we need to consider the non-zero standard classes in the extra_specs16:06
*** markvoelker has quit IRC16:06
mriedemi don't think we're going to16:07
tssuryaok good16:07
mriedemwe want to check if the standard resource class key exists in extra specs and if it's already 0, we consider that instance migrated16:08
mriedemif it's non-zero, then i guess we log a warning and still consider it migrated16:08
tssuryayea that's what I throught too, I was just reading jroll's and efried_pto's comments on it16:08
tssuryawhich implied otherwise16:08
tssuryaah a warning! ok then16:09
* jaypipes slaps gibi for making his brain hurt this morning...16:09
mriedemnote that on stable branches (at least stable/rocky) that calculation probably needs to account for report_ironic_standard_resource_class_inventory16:09
mriedemwhich makes it even more complicated16:09
tssuryayea saw that part :(16:10
gibijaypipes: it is not me it is the problem that is the source of the hurt :)16:12
openstackgerritmelanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement  https://review.openstack.org/63807316:13
*** igordc has joined #openstack-nova16:20
openstackgerritDan Smith proposed openstack/nova master: API microversion 2.69: Handles Down Cells Documentation  https://review.openstack.org/63514716:22
dansmithmriedem: tssurya see what you think of that ^16:22
dansmithI was tempted to rename it as well to just say "Handling partial infrastructure failures" or something16:22
tssuryadansmith: I don't mind at all :) feel free to change anything in that patch16:23
jaypipesgibi: :)16:25
openstackgerritMerged openstack/nova master: Address nits from I9e30a24a4c0640f282f507d0a96640d3cdefe43c  https://review.openstack.org/63696716:26
*** rpittau is now known as rpittau|sardegna16:28
*** wolverineav has joined #openstack-nova16:29
*** macza has joined #openstack-nova16:32
*** ttsiouts has quit IRC16:33
*** ttsiouts has joined #openstack-nova16:33
mriedemtssurya: i have the novaclient test sorting thing fixed16:34
*** yan0s has quit IRC16:34
mriedemi'll post that as a patch before yours in the series16:34
*** s10 has quit IRC16:34
openstackgerritBalazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations  https://review.openstack.org/63795516:34
openstackgerritBalazs Gibizer proposed openstack/nova master: cache neutron ports in heal allocation  https://review.openstack.org/63820716:34
*** ttsiouts has quit IRC16:38
*** hongbin has joined #openstack-nova16:38
*** tosky has joined #openstack-nova16:39
* gibi leaves for today16:39
*** pbing19 has quit IRC16:39
*** pbing19 has joined #openstack-nova16:39
melwittmriedem: we have an ironic driver fix proposed that adds a kwarg to the get_info() virt method. we wanted your opinion about whether it's backportable and if not, advice on another way to approach it https://review.openstack.org/63669916:43
*** gyee has joined #openstack-nova16:45
*** wolverineav has quit IRC16:49
*** wolverin_ has joined #openstack-nova16:49
*** wolverin_ has quit IRC16:53
*** helenafm has quit IRC16:54
*** HD|Laptop has quit IRC16:54
mriedemwell that's a backward incompatible change to any out of tree drivers on stable16:57
mriedemso it depends on if you care about that16:57
mriedemefried_pto probably cares about it16:57
openstackgerritMatt Riedemann proposed openstack/python-novaclient master: API microversion 2.69: Handles Down Cells  https://review.openstack.org/57956316:58
openstackgerritMatt Riedemann proposed openstack/python-novaclient master: Make Server.networks use a predictable sort order  https://review.openstack.org/63821416:58
melwitta new kwarg with a default value? I didn't think that's backward incompat16:59
tssuryamriedem: oh thanks a lot!17:01
tssuryaand as far as the host name being "host1" always its because the fake has that hardcoded17:01
tssuryaI can just change that if you want them to be unique17:01
mriedemmelwitt: if compute is passing use_cache=False to an out of tree driver that implements get_info(instance) but doesn't have that kwarg in the method signature, it's going to blow up17:02
melwittoh, right. urgh17:02
mriedemhttp://paste.openstack.org/show/745484/17:03
*** markvoelker has joined #openstack-nova17:03
mriedemso the worst that happens is out of tree drivers don't have the sync power states task working until they fix that17:04
*** psachin has quit IRC17:04
melwittjroll ^17:04
*** moshele has joined #openstack-nova17:05
jrollmelwitt: yep, that's correct, I just didn't know what the policy was given out of tree drivers are unsupported17:05
jrollI'm not sure there's a different approach we can take, am open to it though17:06
jrollother than reverting the thing that made the sync use the cache, and spamming ironic for that task17:06
mriedemi'm commenting17:07
mriedemcool your jets and hold your horses please17:07
mriedemoath can wait17:07
jrollit's not even for oath, larsks reported this bug and I hacked it up ¯\_(ツ)_/¯17:07
jrollbesides oath is dead, long live verizon media :P17:07
mriedemoh right17:07
*** tssurya has quit IRC17:07
mriedemvmg 4ever17:07
openstackgerritStephen Finucane proposed openstack/os-vif master: WIP: Add API docs for various VIF types  https://review.openstack.org/63700917:08
mriedemjroll: posted17:10
mriedemmy suggestion is handling a TypeError in this change if you're going to backport it, and in a follow up remove the TypeError handling17:10
*** pcaruana has quit IRC17:13
jrollmriedem: oh, that's a good idea, thanks. I'll update with that17:13
*** dtantsur is now known as dtantsur|afk17:14
*** _fragatina has quit IRC17:14
mdboothsean-k-mooney: That port binding error I mentioned this morning could be a more serious thing. I'm currently messing with LM and generating lots of LM failures, and in every case it's not possible to repeat the LM because:17:16
mdbooth$ openstack server migrate --live devstack-2.marston --block-migration test117:16
mdboothMigration pre-check error: Binding failed for port 48c1c3b8-be35-46a0-8df2-60495b4c6b9d, please check neutron logs for more information. (HTTP 400) (Request-ID: req-3217c16e-438a-4025-a462-8979fc97bd80)17:16
mriedemjroll: you may also want to take the opportunity to refresh the node_cache but that would be a follow up17:16
*** Sundar has quit IRC17:17
mriedemmdbooth: is the vif_type on the port binding "binding_failed" or "unbound"?17:17
*** davidsha has quit IRC17:17
*** moshele has quit IRC17:17
mriedemif so, we don't know how to translate that to an os-vif object to plug the vif on the dest host17:17
mriedemand it blows up17:17
jrollmriedem: eh, that's a bigger timesink that I'm not sure I want to do in the middle of that loop... though would help in the case of a whole rack getting unplugged or something17:18
mriedemmdbooth: semi related https://review.openstack.org/#/c/603844/17:18
mdboothmriedem: Well it remains bound on the source, so it looks normal I guess?17:18
mriedemmdbooth: if the vif_type in the port binding is busted, you might have to detach and re-attach the port to the server to fix it17:18
mriedemmdbooth: check the port binding details on the port in the neutron api17:19
mriedemyou probably have to be admin to get that field17:19
mriedembinding:vif_type is what you're looking for17:19
mdboothIt's 'ovs'17:19
mriedemoh huh17:19
mriedemwell actually,17:20
mriedemis this rocky?17:20
mdboothmriedem: This is a dark art to me, btw :)17:20
mdboothdevstack master17:20
mriedemthe port binding for the dest host will be on GET /ports/{port_id}/bindings/{dest_host}17:20
mriedemthe port binding details you're looking at on the port are likely the source host17:20
mriedemwhich is the 'active' binding17:20
mriedemthe dest host binding is the inactive one17:20
mriedemand it's what you're trying to plug17:21
mdboothAh, ok.17:21
mdboothNo cli for that?17:21
* mdbooth cracks open his curl17:21
sean-k-mooneymdbooth: it was in the spec but no17:21
mriedemunfortunately there is no api ref for the port bindings api yet17:21
mdboothI'm assuming if I look at the LM code in nova we're failing to clean that up17:22
sean-k-mooneymdbooth: to clean up a host binding?17:23
*** jackding has quit IRC17:23
mriedem_rollback_live_migration should delete inactive dest host port bindings17:23
sean-k-mooneymdbooth: i had tought we had code for that17:23
mriedemhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L695817:24
mriedemhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L701017:24
mriedemif we failed to cleanup the dest host port bindings where should be an error in the compute logs17:25
*** ircuser-1 has quit IRC17:26
mdboothHmm, nothing obvious17:27
mdboothAnyway, I'm going to have to shoot. I'll investigate properly in the morning, was just sharing in case sean-k-mooney had immediate insight.17:28
mdboothThanks for the help.17:28
mriedemdansmith: commented https://review.openstack.org/#/c/635147/17:30
*** markvoelker has quit IRC17:36
sean-k-mooney mdbooth i know that i have seen case where cleaning up the volume on a roleback fails and we raise an excpetion and dont then rollback the networking17:38
*** ociuhandu_ has joined #openstack-nova17:39
sean-k-mooneymdbooth: my guess is that is the most likely cause. for example if self.compute_rpcapi.remove_volume_connection rased an exception we would never call self.network_api.setup_networks_on_host17:39
sean-k-mooneymdbooth: we probaly should split _rollback_live_migration into several smaller fucntion and call them with a set fo try finally statement to ensure that all resouces that can be rolled back are17:40
sean-k-mooneymdbooth: ill be fixing stuff arount this code for something else next sprint so i might look at doing that change then.17:42
*** ociuhandu has quit IRC17:42
jaypipesgibi: still around?17:43
*** ociuhandu_ has quit IRC17:43
jaypipesgibi: on https://review.openstack.org/#/c/616239/ did we decide not to change anything for the group_policy_isolate=true?17:44
*** jaosorior has quit IRC17:49
*** jaosorior has joined #openstack-nova17:49
*** derekh has quit IRC17:50
*** ociuhandu has joined #openstack-nova17:54
*** ociuhandu has quit IRC17:58
*** thgcorrea has quit IRC17:59
*** panda is now known as panda|off17:59
*** wolverineav has joined #openstack-nova17:59
*** sdake has joined #openstack-nova18:03
*** ircuser-1 has joined #openstack-nova18:04
*** wolverineav has quit IRC18:04
*** cdent has quit IRC18:09
artomResizing to the same host is expected to work, right?18:11
openstackgerritDan Smith proposed openstack/nova master: API microversion 2.69: Handles Down Cells Documentation  https://review.openstack.org/63514718:11
artomI'm debugging an internal thing, and it looks like we're still asking Neutron to update the port bindings, even though nothing's changed.18:11
artomBleargh no, it's the revert.18:12
artomNever mind.18:12
*** _fragatina has joined #openstack-nova18:12
artomThanks for being my rubber duck.18:12
*** wolverineav has joined #openstack-nova18:12
sean-k-mooneysame host resize needs to be enable in the nova config i think but yes it should work18:13
sean-k-mooneyartom: by the way we do need to rebind on the neutron side as the operator could have changed the security group driver for instance so how we attach the instance to the netowrk backend could change18:15
*** wolverineav has quit IRC18:15
*** wolverineav has joined #openstack-nova18:15
sean-k-mooneyartom: this can happen for example if you did and inplace upgrade and then resize the vm18:15
artomsean-k-mooney, aha, ok18:16
sean-k-mooneynormally the changes would get picked up on the next hard reboot18:16
*** ociuhandu has joined #openstack-nova18:16
*** wolverineav has quit IRC18:16
sean-k-mooneyartom: but ya were you actully hittin an issue?18:16
artomsean-k-mooney, not 100% sure yet, but looks like it's Neutron18:17
artomWe ask for a thing, and timeout waiting for it18:17
*** wolverineav has joined #openstack-nova18:17
artomGrr, and I can't find the corresponding Neutron request18:18
*** wolverineav has quit IRC18:18
sean-k-mooneyoh is this the virtual interface thing we were talking about downstream earlier18:18
*** wolverineav has joined #openstack-nova18:18
artomYeah18:19
sean-k-mooneyartom: as i mentioned to mdbooth eariler if any of the storage cleanup code raises an exception in _rollback_live_migration its possible today that we will never call self.network_api.setup_network_on_host to rollback the network18:20
*** wolverineav has quit IRC18:20
sean-k-mooneyso if there is an exption earilier in the function https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6958 will not be called18:20
artomsean-k-mooney, no, I think we're reaching that part18:21
*** priteau has quit IRC18:21
artomAs I said, I see Nova making the Neutron request18:21
artomBut debug's not enabled, so I can't find that request arriving on the Neutron side18:21
artomI mean, maybe it doesn't?18:21
sean-k-mooneyyou shoudl see it in the neutron api log without debugging18:22
artomActually, debug *is* enabled18:22
sean-k-mooneyyou may not see al of the intermediate steps but the post to the port binding endoint should be there18:22
artomIt'll log the HTTP method, right?18:23
artomI'm casting a wide net and straight up grep -E '2019-02-14 18:50:5.*(PUT|POST)' -R `find . -wholename '*neutron/*.log'`18:23
sean-k-mooneyya and it should have the respocne code18:23
artomNothing.18:23
artomThat's weird though, 'cuz Nova would log a timeout18:25
*** wolverineav has joined #openstack-nova18:25
sean-k-mooneyso it timed out waiting for the network-vif-plugged event18:25
sean-k-mooneywhcich got raised as a VirtualInterfaceCreateExcetiopn.18:26
sean-k-mooneythe logs i have did not containt the neutron server logs18:27
artomsean-k-mooney, that might be why18:27
*** wolverineav has quit IRC18:30
*** markvoelker has joined #openstack-nova18:33
*** hongbin has quit IRC18:33
*** wolverineav has joined #openstack-nova18:34
*** ralonsoh has quit IRC18:34
*** cdent has joined #openstack-nova18:42
imacdonnIs it just me, or does this releasenote seem incomprehensive? I'm left wondering whether or not I should remove the consoleauth service, and under what circumstances the workaround is required. "A new check is added to the nova-status upgrade check CLI to check for use of the nova-consoleauth service to warn and provide additional instructions to set [workarounds]enable_consoleauth = True while performing a live/rolling upgrade."18:46
*** moshele has joined #openstack-nova18:56
*** sdake has quit IRC18:58
imacdonnI think it should say something like "The consoleauth service is deprecated, and should be disabled/removed, however, if there is a requirement to maintain support for existing console sessions through a live/rolling upgrade......"18:59
melwittconsoleauth strikes again19:00
melwittimacdonn: thanks for the feedback. I actually tried to explain it better in the latest updates to the releasenote and still missed the mark. I can propose another change19:01
melwittyou definitely need to enable the workaround if you're doing a live upgrade19:01
imacdonnyeah, seems we've been here before ;) At least removing the service seems to actually not generally break things this time ;)19:02
aspiersmelwitt: are release notes only for operator- / user-facing changes?19:02
aspiersjust wondering if I should add one for this new driver-capabilities-to-traits patch19:02
*** markvoelker has quit IRC19:06
* melwitt hides19:06
imacdonnheh19:06
melwittaspiers: yeah, anything users should know about a change. I don't think I've seen the driver capabilities to traits thing yet19:07
aspiersmelwitt: https://review.openstack.org/#/c/538498/1219:07
aspiersmelwitt: it's my rebase of an old patch from mriedem19:07
aspiersI'm currently fixing the test failures19:07
*** tesseract has quit IRC19:08
imacdonnaspiers: I guess my question (if I mattered) would be: who needs to know about this ?19:09
melwittaspiers: ok, I see. I think that would use a release note to let users know that driver capabilities will show up as custom traits in the placement API19:09
aspiersimacdonn: my question too ;-)19:10
aspiersmelwitt: OK thanks!19:10
melwittaspiers: as for who, I don't know exactly, but it's the kind of thing I could see a cloud monitoring system looking at, what driver capabilities exist on each compute host19:12
aspiersmelwitt: yup, makes sense19:12
imacdonnif there's a change to the way things appear through any published interface, I'd say it definitely should be a release-note.19:13
*** sdake has joined #openstack-nova19:13
aspiersyeah, I suppose just new traits appearing would be sufficient to justify documenting19:13
*** wolverineav has quit IRC19:15
*** marst has joined #openstack-nova19:17
imacdonntangentially related (to release notes), I found a typo in another one. I might submit a fix a bit later, if I get time, but if someone else wants to grab it, that'd be cool too. https://bugs.launchpad.net/nova/+bug/181683119:18
openstackLaunchpad bug 1816831 in OpenStack Compute (nova) "DOC: typo in add_initial_allocation_ratio releasenote" [Undecided,New]19:18
*** jaosorior has quit IRC19:18
*** jmlowe has quit IRC19:19
melwittthanks19:20
*** hongbin has joined #openstack-nova19:23
*** jaosorior has joined #openstack-nova19:28
*** jmlowe has joined #openstack-nova19:30
mriedemdansmith: +2 on that docs change19:33
dansmithmriedem: +W19:33
mriedemlet us never speak of this again19:34
dansmithI looked a the best practices one a bit, found one typo, but will look again when it gets respun19:34
openstackgerritMatt Riedemann proposed openstack/nova master: Fix typo in initial_disk_allocation_ratio release note  https://review.openstack.org/63824519:35
mriedemimacdonn: done - thanks for reporting that ^19:35
imacdonnmriedem: thanks!19:36
dansmith+W within one minute19:37
melwittwhew, what a sense of accomplishment19:37
aspiersalmost as towering an achievement as https://review.openstack.org/#/c/609777/19:39
melwittlol19:39
openstackgerritMatt Riedemann proposed openstack/python-novaclient master: Add support for microversion 2.70 - expose device tags  https://review.openstack.org/63677919:39
aspiersmelwitt: my finest hour19:39
artomaspiers, I'm grateful that your around19:46
* aspiers tears his eyes out19:46
*** wolverineav has joined #openstack-nova19:46
openstackgerritMatt Riedemann proposed openstack/nova master: Replace ansible --sudo with --become in live_migration/hooks scripts  https://review.openstack.org/63530819:48
*** sdake has quit IRC19:50
*** wolverineav has quit IRC19:51
*** wolverineav has joined #openstack-nova19:51
imacdonnartom: I see what you did there ;)19:52
*** jackding has joined #openstack-nova19:55
*** wolverineav has quit IRC19:59
*** wolverineav has joined #openstack-nova20:01
artomimacdonn, I no you did.20:02
imacdonn:)20:02
aspiersartom: stop teasing, its cruel20:03
*** markvoelker has joined #openstack-nova20:03
*** wolverineav has quit IRC20:05
*** jmlowe has quit IRC20:06
*** wolverineav has joined #openstack-nova20:06
*** jmlowe has joined #openstack-nova20:08
*** wolverineav has quit IRC20:11
aspiers;)20:18
*** markvoelker has quit IRC20:36
*** pbing19 has quit IRC20:39
*** wolverineav has joined #openstack-nova20:42
*** spsurya has quit IRC20:42
*** wolverineav has quit IRC20:46
*** eharney has quit IRC20:46
mriedemlow-hanging-fruit docs bug if someone wants it https://bugs.launchpad.net/nova/+bug/181685920:52
openstackLaunchpad bug 1816859 in OpenStack Compute (nova) "Server concepts in nova - automatic resize confirm is wrong in docs" [Medium,Triaged]20:52
*** jmlowe has quit IRC20:53
*** wolverineav has joined #openstack-nova20:54
openstackgerritAdam Spiers proposed openstack/nova master: Convert driver supported capabilities to compute node provider traits  https://review.openstack.org/53849820:54
openstackgerritAdam Spiers proposed openstack/nova master: Convert driver supported capabilities to compute node provider traits  https://review.openstack.org/53849820:59
*** eharney has joined #openstack-nova20:59
aspiersefried_pto, mriedem, melwitt: I think this is ready for serious consideration now ^^^21:00
aspiersI've fixed all the TODOs I can see, and (fingers crossed) the tests will pass21:00
aspierss/will/should/21:00
*** erlon__ has quit IRC21:01
*** ttsiouts has joined #openstack-nova21:01
melwittkewl21:04
mriedemaspiers: so is your sev stuff going to rebase on top of that or what?21:08
mriedembecause it refers to both a blueprint that's already complete and one that's not approved21:09
*** sdake has joined #openstack-nova21:11
openstackgerritMatt Riedemann proposed openstack/nova master: Confirm cross-cell resize while deleting a server  https://review.openstack.org/63826821:15
openstackgerritMatt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API  https://review.openstack.org/63826921:15
mriedemdansmith: ^ that's the end of the road, let's ship it21:15
*** eharney has quit IRC21:30
*** takamatsu_ has joined #openstack-nova21:31
*** takamatsu has quit IRC21:31
*** markvoelker has joined #openstack-nova21:33
*** wolverineav has quit IRC21:34
openstackgerritSundar Nadathur proposed openstack/nova master: ksa auth conf and client for cyborg access  https://review.openstack.org/63124221:34
*** wolverineav has joined #openstack-nova21:35
artommriedem, heads up, we're hitting something similar to https://bugs.launchpad.net/nova/+bug/1813789 in our CI, except with revert_resize rather than evacuate21:36
openstackLaunchpad bug 1813789 in OpenStack Compute (nova) "Evacuate test intermittently fails with network-vif-plugged timeout exception" [Medium,Confirmed]21:36
artomIe, listening too late for an event21:36
artomSo looks like I'm fixing both of those21:36
artomWould it make sense to file a different bug? Or just append to that one?21:37
sean-k-mooneyi would just use ^21:37
mriedemartom: that bug is f'ed21:37
mriedemi think we *are* registered to wait for the event21:38
mriedemand neutron isn't sending it21:38
*** sdake has quit IRC21:38
sean-k-mooneymriedem: in the down stream bug neutron is sending it before we register to recive it21:38
mriedemneed to figure out what is triggering the event then21:38
mriedembecause for evacuate,21:38
artommriedem, and that's what you describe in your bug as well21:38
mriedemthe driver.spawn() is registering the callback21:39
mriedemwhat might be sending the event is the port binding change21:39
*** READ10 has joined #openstack-nova21:39
*** wolverineav has quit IRC21:39
mriedemdoes that happen before driver.spawn (evacuate) and driver.finish_revert_migration?21:39
*** sdake has joined #openstack-nova21:39
sean-k-mooneymriedem: this is the downstream bug by the way https://bugzilla.redhat.com/show_bug.cgi?id=167868121:40
openstackbugzilla.redhat.com bug 1678681 in openstack-nova "REVERT_RESIZE stuck for 300s: "VirtualInterfaceCreateException: Virtual Interface creation failed" [Medium,Assigned] - Assigned to alifshit21:40
artommriedem, so, would it make sense to start listening immediately after calling Neutron?21:40
sean-k-mooneyartom: i would do it just before21:40
artomsean-k-mooney, heh, right, that makes more sense21:40
mriedemyou have to register the callback before21:40
artomHrmm, and we might not have the callback until we get to spawn()?21:41
mriedemsec21:41
mriedemartom: so for evacuate, this is what updates the port binding to point at the dest host https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L321221:42
mriedemthe driver spawn then happens here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L327621:42
mriedemso neutron likely doesn't send a 2nd network-vif-plugged event because it's already sending one for the port binding change21:43
mriedemthat's my guess anyway21:43
artom(mriedem, btw, I sill never stop being impressed by the speed at which you walk through code and paste the relevant bits in here)21:43
mriedemas for the revert resize,21:43
mriedemport binding changes back to the source here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L408921:43
mriedemand the guest is re-spawned (and vifs are plugged) here: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L410821:43
mriedemi'm fast on *this* because i've been in the bowels of it for 6 months21:44
artomSuperbowels21:45
artomOK, my eyes are glazing over.21:45
sean-k-mooney os with ml2 ovs. the network-vif-plugged events are sent by the nova ovs agent when it finishes wiring up the port21:45
artomWill pick up tomorrow.21:45
*** takamatsu_ has quit IRC21:45
sean-k-mooneyif we had not got to the point of cleaning up the ports on the souce node21:45
artommriedem's link will be in my IRC log for future consultation.21:45
* artom -> supper, kids, gym, sleep21:45
sean-k-mooneywhen we rebind to the source node it might send the network-vif-plugged event imiddately21:46
*** takamatsu has joined #openstack-nova21:46
*** wolverineav has joined #openstack-nova21:46
mriedemartom: no need https://bugs.launchpad.net/nova/+bug/1813789/comments/221:46
openstackLaunchpad bug 1813789 in OpenStack Compute (nova) "Evacuate test intermittently fails with network-vif-plugged timeout exception" [Medium,Confirmed]21:46
mriedemi put the notes in the bug21:46
artommriedem, cheers!21:47
*** sdake has quit IRC21:48
*** sdake has joined #openstack-nova21:49
mriedemwe also have the same issue in unshelve https://github.com/openstack/nova/blob/a4e6340bdcc2fda8fed41abc64ea554d9a8ab713/nova/compute/manager.py#L508721:50
openstackgerritMatt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API  https://review.openstack.org/63826921:51
*** sdake has quit IRC21:59
*** dave-mccowan has quit IRC22:01
*** sdake has joined #openstack-nova22:02
*** markvoelker has quit IRC22:07
*** wolverineav has quit IRC22:19
*** artom has quit IRC22:19
*** wolverineav has joined #openstack-nova22:20
*** wolverineav has quit IRC22:21
*** wolverineav has joined #openstack-nova22:23
*** artom has joined #openstack-nova22:24
*** moshele has quit IRC22:24
*** mriedem has quit IRC22:25
*** rcernin has joined #openstack-nova22:27
*** wolverineav has quit IRC22:28
*** awaugama has quit IRC22:30
*** moshele has joined #openstack-nova22:31
*** whoami-rajat has quit IRC22:31
*** wolverineav has joined #openstack-nova22:41
*** cdent has quit IRC22:44
*** wolverineav has quit IRC22:47
*** jmlowe has joined #openstack-nova22:47
*** wolverineav has joined #openstack-nova22:47
*** wolverineav has quit IRC22:48
*** wolverineav has joined #openstack-nova22:48
*** hongbin has quit IRC22:51
*** ttsiouts has quit IRC22:52
*** moshele has quit IRC22:53
*** tkajinam has joined #openstack-nova22:55
*** wolverineav has quit IRC23:00
*** wolverineav has joined #openstack-nova23:03
*** markvoelker has joined #openstack-nova23:03
*** rcernin has quit IRC23:06
*** rcernin has joined #openstack-nova23:08
*** wolverineav has quit IRC23:09
*** wolverineav has joined #openstack-nova23:09
*** mlavalle has quit IRC23:15
*** agopi has quit IRC23:17
*** wolverineav has quit IRC23:24
*** wolverineav has joined #openstack-nova23:29
*** mdbooth_ has joined #openstack-nova23:32
*** imacdonn has quit IRC23:32
*** imacdonn has joined #openstack-nova23:33
*** mdbooth has quit IRC23:33
*** wolverineav has quit IRC23:34
*** wolverineav has joined #openstack-nova23:34
*** markvoelker has quit IRC23:35
*** marst has quit IRC23:41
*** wolverineav has quit IRC23:46
*** wolverineav has joined #openstack-nova23:47
*** wolverineav has quit IRC23:48
*** wolverineav has joined #openstack-nova23:48
*** mriedem has joined #openstack-nova23:57
mriedemmdbooth_: for your morrow https://bugs.launchpad.net/nova/+bug/181693823:58
openstackLaunchpad bug 1816938 in OpenStack Compute (nova) "Misleading log message "Booting with blank volume" in nova-compute when booting from real volume" [Medium,Confirmed]23:58
aspiersmriedem: yes, I was planning to add SEV as a capabillity rather than a trait, since that's what efried_pto suggested: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-02-08.log.html#t2019-02-08T19:58:54 Are you saying that the caps-to-traits patch can't be merged without changing the bp pointers?23:58
mriedemaspiers: not necessarily23:58
mriedemif it's part of an existing approved blueprint then i would probably say it's related to that23:58
*** jobewan has quit IRC23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!