*** artom has joined #openstack-nova | 00:00 | |
*** liuyulong has quit IRC | 00:04 | |
*** wolverineav has joined #openstack-nova | 00:06 | |
*** wolverineav has quit IRC | 00:10 | |
*** markvoelker has quit IRC | 00:15 | |
*** jobewan has quit IRC | 00:18 | |
*** wolverineav has joined #openstack-nova | 00:19 | |
*** itlinux has joined #openstack-nova | 00:21 | |
*** wolverineav has quit IRC | 00:23 | |
*** macza has quit IRC | 00:29 | |
*** mlavalle has quit IRC | 00:32 | |
*** lbragstad has quit IRC | 00:34 | |
*** gbarros has joined #openstack-nova | 00:36 | |
*** wolverineav has joined #openstack-nova | 00:37 | |
*** gbarros has quit IRC | 00:39 | |
*** gbarros has joined #openstack-nova | 00:49 | |
*** ileixe has joined #openstack-nova | 00:53 | |
openstackgerrit | sean mooney proposed openstack/os-vif master: make functional tests run on python 3 https://review.openstack.org/638053 | 00:58 |
---|---|---|
*** sdake has joined #openstack-nova | 00:59 | |
*** tbachman has joined #openstack-nova | 01:01 | |
openstackgerrit | sean mooney proposed openstack/os-vif master: make functional tests run on python 3 https://review.openstack.org/638053 | 01:01 |
*** lbragstad has joined #openstack-nova | 01:01 | |
*** wolverineav has quit IRC | 01:03 | |
*** dave-mccowan has joined #openstack-nova | 01:06 | |
*** wolverineav has joined #openstack-nova | 01:07 | |
*** hongbin has joined #openstack-nova | 01:07 | |
*** markvoelker has joined #openstack-nova | 01:12 | |
*** wolverineav has quit IRC | 01:12 | |
*** tiendc has joined #openstack-nova | 01:13 | |
*** zhubx has joined #openstack-nova | 01:16 | |
*** _fragatina has quit IRC | 01:21 | |
*** wolverineav has joined #openstack-nova | 01:27 | |
*** itlinux has quit IRC | 01:28 | |
*** igordc has quit IRC | 01:30 | |
*** wolverineav has quit IRC | 01:32 | |
*** wolverineav has joined #openstack-nova | 01:40 | |
openstackgerrit | Merged openstack/os-vif master: Add create_port field in VIFPortProfileOpenVSwitch profile https://review.openstack.org/636061 | 01:41 |
*** Dinesh_Bhor has joined #openstack-nova | 01:41 | |
*** markvoelker has quit IRC | 01:44 | |
*** wolverineav has quit IRC | 01:44 | |
*** tetsuro has joined #openstack-nova | 01:50 | |
openstackgerrit | sean mooney proposed openstack/os-vif master: modify functional base.py to allow using vscode https://review.openstack.org/638058 | 01:53 |
*** bhagyashris has joined #openstack-nova | 01:53 | |
*** eharney has quit IRC | 02:08 | |
*** itlinux has joined #openstack-nova | 02:09 | |
*** hamzy has joined #openstack-nova | 02:13 | |
*** igordc has joined #openstack-nova | 02:15 | |
*** wolverineav has joined #openstack-nova | 02:17 | |
*** wolverineav has quit IRC | 02:22 | |
*** wolverineav has joined #openstack-nova | 02:25 | |
openstackgerrit | Michael Still proposed openstack/nova master: Create specialist set_macaddr_and_vlan helper. https://review.openstack.org/624227 | 02:29 |
openstackgerrit | Michael Still proposed openstack/nova master: Move create_tap_dev into privsep. https://review.openstack.org/624228 | 02:29 |
openstackgerrit | Michael Still proposed openstack/nova master: Move set_vf_interface_vlan to be with its only caller. https://review.openstack.org/624229 | 02:29 |
openstackgerrit | Michael Still proposed openstack/nova master: Move DHCP releasing to privsep. https://review.openstack.org/624230 | 02:29 |
openstackgerrit | Michael Still proposed openstack/nova master: Convert additional IP management calls to privsep. https://review.openstack.org/624231 | 02:29 |
openstackgerrit | Michael Still proposed openstack/nova master: Move route management to privsep. https://review.openstack.org/624232 | 02:29 |
openstackgerrit | Michael Still proposed openstack/nova master: Move additional IP address management to privsep. https://review.openstack.org/624591 | 02:29 |
openstackgerrit | Michael Still proposed openstack/nova master: Move slight bonkers IP management to privsep. https://review.openstack.org/624592 | 02:29 |
openstackgerrit | Michael Still proposed openstack/nova master: Move arping to privsep. https://review.openstack.org/624593 | 02:29 |
openstackgerrit | Michael Still proposed openstack/nova master: Move cleaning conntrack to privsep. https://review.openstack.org/624594 | 02:29 |
openstackgerrit | Michael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.openstack.org/635431 | 02:29 |
openstackgerrit | Michael Still proposed openstack/nova master: Move killing processes to privsep. https://review.openstack.org/635432 | 02:29 |
openstackgerrit | Michael Still proposed openstack/nova master: Move FP device creation and deletion to privsep. https://review.openstack.org/635433 | 02:29 |
openstackgerrit | Michael Still proposed openstack/nova master: Cleanup the exec_ebtables code a little. https://review.openstack.org/635434 | 02:29 |
openstackgerrit | Michael Still proposed openstack/nova master: Privsep the ebtables modification code. https://review.openstack.org/635435 | 02:29 |
openstackgerrit | Michael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.openstack.org/635436 | 02:29 |
openstackgerrit | Michael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.openstack.org/636508 | 02:29 |
*** wolverineav has quit IRC | 02:30 | |
*** whoami-rajat has joined #openstack-nova | 02:31 | |
*** sdake has quit IRC | 02:36 | |
*** yaawang has joined #openstack-nova | 02:38 | |
*** markvoelker has joined #openstack-nova | 02:41 | |
*** Kunpeng has joined #openstack-nova | 02:43 | |
*** macza has joined #openstack-nova | 02:52 | |
*** macza has quit IRC | 02:57 | |
*** psachin has joined #openstack-nova | 03:05 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add method to allow reset fields for root bdm in BDM obj https://review.openstack.org/614672 | 03:09 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750 | 03:10 |
*** markvoelker has quit IRC | 03:15 | |
*** agopi has joined #openstack-nova | 03:16 | |
*** hamzy has quit IRC | 03:20 | |
openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 03:34 |
*** itlinux has quit IRC | 03:45 | |
*** udesale has joined #openstack-nova | 03:56 | |
*** itlinux has joined #openstack-nova | 04:02 | |
*** ileixe has quit IRC | 04:03 | |
*** gbarros has quit IRC | 04:06 | |
*** itlinux has quit IRC | 04:10 | |
openstackgerrit | Merged openstack/os-vif master: Convert hardcoded regexes to raw strings for py36 https://review.openstack.org/635111 | 04:12 |
*** itlinux has joined #openstack-nova | 04:12 | |
*** markvoelker has joined #openstack-nova | 04:12 | |
openstackgerrit | melanie witt proposed openstack/nova master: WIP Add online data migration for populating user_id https://review.openstack.org/633351 | 04:14 |
openstackgerrit | melanie witt proposed openstack/nova master: WIP Add get_counts() to InstanceMappingList https://review.openstack.org/638072 | 04:14 |
openstackgerrit | melanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | 04:14 |
*** wolverineav has joined #openstack-nova | 04:15 | |
*** hamzy has joined #openstack-nova | 04:16 | |
*** itlinux has quit IRC | 04:18 | |
*** janki has joined #openstack-nova | 04:22 | |
*** itlinux has joined #openstack-nova | 04:23 | |
*** sridharg has joined #openstack-nova | 04:26 | |
*** itlinux has quit IRC | 04:28 | |
*** dave-mccowan has quit IRC | 04:31 | |
*** itlinux has joined #openstack-nova | 04:34 | |
*** lbragstad_ has joined #openstack-nova | 04:36 | |
*** lbragstad has quit IRC | 04:37 | |
*** markvoelker has quit IRC | 04:44 | |
openstackgerrit | Merged openstack/nova master: Drop the integrated-gate (py27) template https://review.openstack.org/634949 | 04:53 |
*** owalsh_ has joined #openstack-nova | 04:54 | |
*** wolverineav has quit IRC | 04:55 | |
*** owalsh has quit IRC | 04:57 | |
*** ileixe has joined #openstack-nova | 04:59 | |
openstackgerrit | Boxiang Zhu proposed openstack/nova master: Convert to raw format into rbd volume https://review.openstack.org/638080 | 05:02 |
*** hongbin has quit IRC | 05:04 | |
*** igordc has quit IRC | 05:08 | |
*** igordc has joined #openstack-nova | 05:20 | |
*** lbragstad has joined #openstack-nova | 05:23 | |
*** itlinux_ has joined #openstack-nova | 05:24 | |
*** lbragstad_ has quit IRC | 05:25 | |
*** itlinux has quit IRC | 05:27 | |
*** lbragstad_ has joined #openstack-nova | 05:29 | |
*** ociuhandu_ has quit IRC | 05:30 | |
*** ociuhandu has joined #openstack-nova | 05:30 | |
*** lbragstad has quit IRC | 05:31 | |
*** pbing19 has joined #openstack-nova | 05:39 | |
*** itlinux has joined #openstack-nova | 05:40 | |
*** lbragstad has joined #openstack-nova | 05:41 | |
*** markvoelker has joined #openstack-nova | 05:42 | |
*** itlinux_ has quit IRC | 05:43 | |
*** lbragstad_ has quit IRC | 05:43 | |
*** _fragatina has joined #openstack-nova | 05:44 | |
*** _fragatina has quit IRC | 05:45 | |
*** _fragatina has joined #openstack-nova | 05:46 | |
*** k4ch0 has joined #openstack-nova | 05:52 | |
*** itlinux has quit IRC | 05:56 | |
*** lbragstad_ has joined #openstack-nova | 05:57 | |
*** tkajinam_ has joined #openstack-nova | 05:57 | |
*** lbragstad has quit IRC | 05:58 | |
*** tkajinam has quit IRC | 05:59 | |
*** ratailor has joined #openstack-nova | 06:05 | |
*** wolverineav has joined #openstack-nova | 06:07 | |
*** k4ch0 has left #openstack-nova | 06:11 | |
*** wolverineav has quit IRC | 06:11 | |
*** markvoelker has quit IRC | 06:15 | |
*** yaawang has quit IRC | 06:15 | |
*** lbragstad has joined #openstack-nova | 06:20 | |
*** lbragstad_ has quit IRC | 06:22 | |
*** itlinux has joined #openstack-nova | 06:22 | |
*** sdake has joined #openstack-nova | 06:26 | |
*** sdake has quit IRC | 06:27 | |
*** itlinux has quit IRC | 06:28 | |
*** igordc has quit IRC | 06:31 | |
*** itlinux has joined #openstack-nova | 06:32 | |
*** pbing19 has quit IRC | 06:32 | |
*** macza has joined #openstack-nova | 06:34 | |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Calculate RequestGroup resource provider mapping https://review.openstack.org/616239 | 06:36 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Fill the RequestGroup mapping during schedule https://review.openstack.org/619528 | 06:36 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for cyborg access https://review.openstack.org/631242 | 06:36 |
*** macza has quit IRC | 06:38 | |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Calculate RequestGroup resource provider mapping https://review.openstack.org/616239 | 06:49 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Fill the RequestGroup mapping during schedule https://review.openstack.org/619528 | 06:49 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for cyborg access https://review.openstack.org/631242 | 06:49 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Find the name of the device profile, if any, in flavor extra specs. Get its profile groups (equiv to flavor request groups) from Cyborg. Parse/validate them similar to extra_specs. Generate RequestGroup objects and add them to the request spec so that https://review.openstack.org/631243 | 06:49 |
openstackgerrit | Yongli He proposed openstack/nova master: Add server subresouce topology API https://review.openstack.org/621476 | 06:50 |
*** itlinux has quit IRC | 06:50 | |
*** itlinux has joined #openstack-nova | 06:52 | |
*** Luzi has joined #openstack-nova | 06:52 | |
*** _fragatina has quit IRC | 06:53 | |
*** _fragatina has joined #openstack-nova | 06:54 | |
*** itlinux has quit IRC | 06:57 | |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Calculate RequestGroup resource provider mapping https://review.openstack.org/616239 | 06:59 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Fill the RequestGroup mapping during schedule https://review.openstack.org/619528 | 06:59 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for cyborg access https://review.openstack.org/631242 | 06:59 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Add Cyborg device profile groups to spec obj. https://review.openstack.org/631243 | 06:59 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Create and bind Cyborg ARQs. https://review.openstack.org/631244 | 06:59 |
*** _fragatina has quit IRC | 07:00 | |
*** markvoelker has joined #openstack-nova | 07:01 | |
*** itlinux has joined #openstack-nova | 07:03 | |
alex_xu | melwitt: I did a test on your patch. I create VM with admin user, then I switch to demo user, I still can show that VM. | 07:07 |
*** itlinux has quit IRC | 07:07 | |
alex_xu | melwitt: this because https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L425 the show API policy check without instance project id as target | 07:09 |
*** itlinux has joined #openstack-nova | 07:26 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: WIP detach root volume API changes https://review.openstack.org/623981 | 07:28 |
openstackgerrit | Boxiang Zhu proposed openstack/nova master: Convert to raw format into rbd volume https://review.openstack.org/638080 | 07:28 |
*** ccamacho has quit IRC | 07:29 | |
*** ccamacho has joined #openstack-nova | 07:29 | |
*** udesale has quit IRC | 07:34 | |
*** udesale has joined #openstack-nova | 07:35 | |
*** itlinux has quit IRC | 07:36 | |
*** moshele has joined #openstack-nova | 07:40 | |
*** ratailor_ has joined #openstack-nova | 07:40 | |
*** ratailor has quit IRC | 07:43 | |
*** tesseract has joined #openstack-nova | 07:56 | |
melwitt | alex_xu: thank you for the example. I finally understand your point. sorry I didn't understand it previously | 07:57 |
alex_xu | melwitt: np...you still wake up... | 07:58 |
melwitt | I kept thinking the policy project_id check would do it, but if there is no target, I'm not sure what it would be checking. so that is my bad | 07:58 |
melwitt | yeah, made a mistake of checking my zuul results before going to sleep :P | 07:58 |
Dinesh_Bhor | How can I restrict the resize/migration of an instance to the same host-aggregate ? | 07:58 |
alex_xu | hahaha | 07:58 |
*** pcaruana has joined #openstack-nova | 07:59 | |
alex_xu | Dinesh_Bhor: for resize, you probably can choice a different flavor which with different aggregate metadata. probably no way for migration | 08:00 |
*** itlinux has joined #openstack-nova | 08:03 | |
Dinesh_Bhor | alex_xu: Okay, We actually have networks based on host-aggregates and we would like to restrict the VM's resize/migration to the same aggregate for security reasons. | 08:04 |
openstackgerrit | melanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | 08:04 |
alex_xu | Dinesh_Bhor: ah, sorry, I misunderstand, you want it in the same agg. | 08:04 |
alex_xu | Dinesh_Bhor: I guess it should work as expected in the current implementation | 08:04 |
alex_xu | if your flavor with aggregate metadata in the beginning. I guess you don't have that. | 08:05 |
Dinesh_Bhor | alex_xu: yes, we don't have them | 08:06 |
*** awalende has joined #openstack-nova | 08:06 | |
*** ralonsoh has joined #openstack-nova | 08:07 | |
alex_xu | Dinesh_Bhor: the only way I have is using resize to update a flavor with agg metadat, then limited into the same agg. otherwise I don't think we are any existed method to do that. | 08:07 |
Dinesh_Bhor | alex_xu: okay, Thanks. I will check it | 08:08 |
*** jchhatbar has joined #openstack-nova | 08:09 | |
openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 08:09 |
*** jchhatbar has quit IRC | 08:10 | |
*** jchhatbar has joined #openstack-nova | 08:11 | |
*** rpittau has joined #openstack-nova | 08:11 | |
*** janki has quit IRC | 08:11 | |
*** pbing19 has joined #openstack-nova | 08:13 | |
*** tkajinam_ has quit IRC | 08:14 | |
*** lbragstad has quit IRC | 08:15 | |
*** itlinux has quit IRC | 08:16 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Calculate RequestGroup resource provider mapping https://review.openstack.org/616239 | 08:16 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fill the RequestGroup mapping during schedule https://review.openstack.org/619528 | 08:16 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Pass resource provider mapping to neutronv2 api https://review.openstack.org/616240 | 08:16 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Recalculate request group - RP mapping during re-schedule https://review.openstack.org/619529 | 08:16 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send RP uuid in the port binding https://review.openstack.org/569459 | 08:16 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request https://review.openstack.org/573317 | 08:16 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | 08:16 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310 | 08:16 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311 | 08:16 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | 08:17 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | 08:17 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance to make place for port healing https://review.openstack.org/637953 | 08:17 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance (2) https://review.openstack.org/637954 | 08:17 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.openstack.org/637955 | 08:17 |
*** yan0s has joined #openstack-nova | 08:21 | |
*** ttsiouts has joined #openstack-nova | 08:22 | |
*** tssurya has joined #openstack-nova | 08:22 | |
*** itlinux has joined #openstack-nova | 08:23 | |
*** pbing19 has quit IRC | 08:24 | |
*** helenafm has joined #openstack-nova | 08:26 | |
*** itlinux has quit IRC | 08:28 | |
*** rcernin has quit IRC | 08:29 | |
*** dtantsur|afk is now known as dtantsur | 08:34 | |
bauzas | good morning Nova | 08:41 |
gibi | good morning bauzas | 08:44 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: WIP detach root volume API changes https://review.openstack.org/623981 | 08:45 |
*** owalsh_ is now known as owalsh | 08:48 | |
bauzas | gibi: :-) | 08:51 |
*** pbing19 has joined #openstack-nova | 08:56 | |
*** ociuhandu has quit IRC | 09:00 | |
*** gibi has quit IRC | 09:00 | |
*** tetsuro has quit IRC | 09:12 | |
openstackgerrit | Silvan Kaiser proposed openstack/nova master: Exec systemd-run without --user flag in Quobyte driver https://review.openstack.org/554195 | 09:15 |
*** ociuhandu has joined #openstack-nova | 09:24 | |
*** ociuhandu has quit IRC | 09:29 | |
*** davidsha has joined #openstack-nova | 09:30 | |
openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 09:33 |
openstackgerrit | Silvan Kaiser proposed openstack/nova master: Added mount fstype based validation of Quobyte mounts https://review.openstack.org/522245 | 09:36 |
kaisers | kaisers | 09:38 |
kaisers | *dang* missed out on the hotkey | 09:39 |
kaisers | stephenfin: Hi! Updated both CLs based on yesterdays feedback :) | 09:40 |
stephenfin | ack | 09:40 |
*** Dinesh_Bhor has quit IRC | 09:41 | |
*** derekh has joined #openstack-nova | 09:45 | |
*** panda|off is now known as panda | 09:46 | |
kashyap | gibi: The Zuul is -2 here because the parent patch is not merged yet? -- https://review.openstack.org/#/c/637152/ | 09:48 |
*** cfriesen has quit IRC | 09:50 | |
*** bhagyashris has quit IRC | 09:50 | |
stephenfin | kaisers: +2 on https://review.openstack.org/#/c/554195/ *but* I do have some comments that I'd really like to see addressed, if you have time. They're not blockers though | 09:51 |
kaisers | stephenfin: can be solved, np | 09:55 |
*** ociuhandu has joined #openstack-nova | 09:57 | |
openstackgerrit | Lajos Katona proposed openstack/python-novaclient master: Add support for microversion v2.69 https://review.openstack.org/637234 | 09:57 |
openstackgerrit | Lajos Katona proposed openstack/python-novaclient master: Add support for microversion v2.70 https://review.openstack.org/637234 | 09:58 |
stephenfin | kaisers: Cool. Also +2 on https://review.openstack.org/#/c/522245/ with two nice-to-have but not blocking nits | 09:58 |
*** markvoelker has quit IRC | 10:01 | |
*** markvoelker has joined #openstack-nova | 10:02 | |
stephenfin | Hmm, no gibi. How odd | 10:05 |
*** mrch_ has joined #openstack-nova | 10:05 | |
stephenfin | bauzas: You're next in line. Could you push this trivial follow up patch through? https://review.openstack.org/#/c/636967 | 10:06 |
stephenfin | bauzas: Next in line for reviews and not for the throne, I'm afraid. They'd never accept a Frenchman for that | 10:06 |
*** markvoelker has quit IRC | 10:06 | |
stephenfin | ...unless the alternative was Boris Johnson, maybe | 10:07 |
bauzas | stephenfin: sorry I don't remember which trivial patch to push ? ;) | 10:07 |
bauzas | and well, for the throne, we had some history here about kings... | 10:08 |
stephenfin | My policy on trivial patches is pro having it and pro pushing it | 10:09 |
kashyap | stephenfin: Re-thinking is a bug really necessary here?: https://review.openstack.org/#/c/637578/1/nova/virt/libvirt/driver.py | 10:09 |
kashyap | s/Re-thinking/Re-thinking,/ | 10:10 |
bauzas | stephenfin: ah sorry, I misunderstood the "this" | 10:10 |
bauzas | stephenfin: but sure, yeah | 10:10 |
stephenfin | kashyap: How so? | 10:11 |
kashyap | stephenfin: This line: https://review.openstack.org/#/c/637578/1/nova/virt/libvirt/driver.py@4961 | 10:11 |
kashyap | stephenfin: Where you guessed a bug might be useful | 10:11 |
stephenfin | kashyap: I was referring to https://review.openstack.org/#/c/637578/1/nova/virt/libvirt/driver.py@4957 | 10:12 |
kashyap | Correct, I posted the wrong line | 10:12 |
stephenfin | Where we create a PTY device for non-QEMU/KVM, non-parallels hypervisors | 10:12 |
bauzas | stephenfin: I just +1d because I have a question | 10:13 |
bauzas | (even for a nit :p ) | 10:13 |
kashyap | stephenfin: Right, but the non-{QEMU/KVM, -Parellels} get a PTY device anyway. | 10:13 |
stephenfin | kashyap: Not previously though, right? Previously the 'if CONF.serial_console.enabled:' line in '_create_pty_device' would have stopped that happening | 10:14 |
kashyap | You want to capture that the existing code didn't create a serial device? | 10:14 |
kashyap | stephenfin: Previously too, according the existing table; and I checked with an s390x maintainer, too, FWIW | 10:14 |
stephenfin | kashyap: Assuming _that_ is the incorrect behavior, yes | 10:15 |
kashyap | Heh, what a maze; I'll see about what to file once I re-read the old code again. | 10:15 |
stephenfin | kashyap: To be completely clear, I don't know if it should have one or not. I'm going on Georg's comments | 10:15 |
*** pbing19 has quit IRC | 10:15 | |
kashyap | stephenfin: Georg says it's OK to not file one. | 10:16 |
stephenfin | What are the non-QEMU/KVM, non-Parallels libvirt drivers we support | 10:16 |
stephenfin | *? | 10:16 |
kashyap | stephenfin: zKVM | 10:16 |
kashyap | More accurately called "z/VM" I guess | 10:16 |
stephenfin | bauzas: Replied, but the answer is here https://review.openstack.org/#/c/636627/1/nova/conf/base.py@29 | 10:17 |
kashyap | stephenfin: It is z/VM (ignore the zKVM bit) | 10:17 |
stephenfin | kashyap: I can get onboard with that, but I do think that we should have a test and call out the change in behavior in the commit message if there is no bug | 10:18 |
stephenfin | Otherwise we've got a change in behavior with no indication to future reviewers of the patch as to why that change happened | 10:19 |
kashyap | stephenfin: Yeah, that sounds reasonable. | 10:19 |
kashyap | I'm all for capturing the intention of a change as clearly as we can :-) | 10:19 |
*** gokhani has quit IRC | 10:20 | |
*** priteau has joined #openstack-nova | 10:22 | |
*** priteau has quit IRC | 10:28 | |
*** moshele has quit IRC | 10:28 | |
*** wolverineav has joined #openstack-nova | 10:29 | |
*** gibi has joined #openstack-nova | 10:32 | |
*** wolverineav has quit IRC | 10:33 | |
gibi | bauzas: could you look at pike backport please? https://review.openstack.org/#/c/603044 the original fix was merged on master when during the Queens cycle | 10:33 |
bauzas | gibi: ack | 10:34 |
*** pbing19 has joined #openstack-nova | 10:34 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Reject resize requests when the source host is down https://review.openstack.org/623489 | 10:34 |
gibi | bauzas: thanks | 10:35 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Reject resize requests when the source host is down https://review.openstack.org/623489 | 10:35 |
lyarwood | mdbooth_: ^ dropped the ignore_forced_down stuff, lets see if anyone raises the LM use case I was talking about. | 10:35 |
bauzas | gibi: I have multiple concerns with the backport | 10:37 |
gibi | bauzas: the new config options? | 10:38 |
bauzas | gibi: lemme review a bit more before | 10:41 |
*** mdbooth_ is now known as mdbooth | 10:43 | |
mdbooth | lyarwood: Yeah, that LM use case just sounds wrong to me. The other thing is that if a service is forced_down, anything which does a service check on it will return that it's down. That just seems really fragile to me, hence I wanted a functional test. | 10:45 |
mdbooth | ... if we were going to rely on it, that is. | 10:45 |
*** erlon has joined #openstack-nova | 10:50 | |
*** ccamacho has quit IRC | 10:54 | |
lyarwood | mdbooth: ack yeah that's fine and agreed it's odd that LM would even work with things forced_down tbh | 10:55 |
bauzas | gibi: commented now | 10:57 |
*** ileixe has quit IRC | 10:59 | |
gibi | bauzas: thanks | 11:00 |
*** moshele has joined #openstack-nova | 11:01 | |
bauzas | gibi: i could have proposed my own revision, but given it's a new backport contributor, I prefer him to amend himself and correctly expain the diffs | 11:01 |
gibi | if the author doesn't fix what you asked then I can fixup that patch | 11:01 |
bauzas | gibi: ok cool, just keep an eye then | 11:02 |
gibi | bauzas: agree with your strategy | 11:02 |
gibi | bauzas: I will check back in a week | 11:02 |
*** markvoelker has joined #openstack-nova | 11:03 | |
*** ccamacho has joined #openstack-nova | 11:12 | |
*** ttsiouts has quit IRC | 11:13 | |
*** ttsiouts has joined #openstack-nova | 11:13 | |
*** udesale has quit IRC | 11:14 | |
*** ttsiouts has quit IRC | 11:18 | |
*** ratailor_ has quit IRC | 11:23 | |
*** thgcorrea has joined #openstack-nova | 11:27 | |
*** markvoelker has quit IRC | 11:36 | |
*** wolverineav has joined #openstack-nova | 11:37 | |
*** sapd1 has quit IRC | 11:38 | |
*** wolverineav has quit IRC | 11:41 | |
*** awalende has quit IRC | 11:49 | |
*** awalende has joined #openstack-nova | 11:50 | |
*** awalende has quit IRC | 11:51 | |
*** awalende has joined #openstack-nova | 11:51 | |
*** sapd1 has joined #openstack-nova | 11:55 | |
*** ttsiouts has joined #openstack-nova | 11:59 | |
*** cdent has joined #openstack-nova | 12:04 | |
*** erlon has quit IRC | 12:04 | |
*** erlon has joined #openstack-nova | 12:06 | |
*** erlon has quit IRC | 12:07 | |
*** erlon_ has joined #openstack-nova | 12:07 | |
*** erlon__ has joined #openstack-nova | 12:09 | |
*** sapd1 has quit IRC | 12:10 | |
*** erlon_ has quit IRC | 12:13 | |
*** janki has joined #openstack-nova | 12:14 | |
*** jchhatbar has quit IRC | 12:15 | |
*** zhubx has quit IRC | 12:19 | |
*** zhubx has joined #openstack-nova | 12:19 | |
*** sapd1 has joined #openstack-nova | 12:22 | |
*** macza has joined #openstack-nova | 12:31 | |
*** markvoelker has joined #openstack-nova | 12:33 | |
*** awalende has quit IRC | 12:34 | |
*** awalende has joined #openstack-nova | 12:35 | |
*** macza has quit IRC | 12:35 | |
*** awalende has quit IRC | 12:36 | |
*** Sundar has joined #openstack-nova | 12:36 | |
*** awalende has joined #openstack-nova | 12:36 | |
*** ondrejme has joined #openstack-nova | 12:36 | |
*** tiendc has quit IRC | 12:38 | |
Sundar | Hi gibi, please ping me if you are around | 12:38 |
*** liuyulong has joined #openstack-nova | 12:43 | |
gibi | Sundar: hi! | 12:44 |
gibi | Sundar: I also tried to talk to you in my morning | 12:45 |
gibi | Sundar: I saw that you updated the bottom of the bandwidth patch series | 12:45 |
gibi | Sundar: but I guess you used an old version of my patches | 12:45 |
openstackgerrit | Silvan Kaiser proposed openstack/nova master: Exec systemd-run without --user flag in Quobyte driver https://review.openstack.org/554195 | 12:48 |
*** rpittau has quit IRC | 12:49 | |
Sundar | gibi: The patch series was rebased by Eric. It does seem like an older version. Sorry if it impacts your work. | 12:51 |
gibi | Sundar: I restored the latest content of my patches with an extra rebase couple of hours ago | 12:51 |
Sundar | gibi: I suppose the patch got updated after the rebase | 12:51 |
gibi | Sundar: so at the moment my patches are up-to-date | 12:51 |
gibi | Sundar: most probably I updated my patches after the last rebase of your patches | 12:52 |
*** sridharg has quit IRC | 12:52 | |
gibi | Sundar: and when your patches was pushed up it changed my patche back to an old version | 12:52 |
Sundar | gibi: Any suggestions for keeping both in sync? | 12:55 |
Sundar | gibi: I mean, apart from manual rebasing periodically | 12:55 |
Sundar | gibi: Apologies again for using an older version | 12:57 |
openstackgerrit | Silvan Kaiser proposed openstack/nova master: Added mount fstype based validation of Quobyte mounts https://review.openstack.org/522245 | 12:58 |
gibi | Sundar: unfortunately if I push up a new version of the patches you are based on then you have to rebase yours top of my new version | 12:59 |
*** psachin has quit IRC | 13:01 | |
kaisers | stephenfin: ping :) | 13:01 |
Sundar | gibi: Got it. Could I ask you to review https://review.openstack.org/#/q/status:open+project:openstack/nova+bp/nova-cyborg-interaction? Your comments would be welcome! | 13:02 |
*** rpittau has joined #openstack-nova | 13:02 | |
gibi | Sundar: I've added to my review queue | 13:03 |
*** psachin has joined #openstack-nova | 13:04 | |
Sundar | gibi: Thank you. :) The only change I made to your patch (which has already been merged) is in https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L75, where I got it to return ident. | 13:04 |
*** markvoelker has quit IRC | 13:05 | |
*** NewBruce has quit IRC | 13:08 | |
*** NewBruce has joined #openstack-nova | 13:10 | |
*** ivve has joined #openstack-nova | 13:10 | |
gibi | Sundar: but now I don't see that change in your series | 13:11 |
kashyap | Hmm, seems like 'tox-py27' seem to randomly fail due to: | 13:13 |
kashyap | sqlalchemy.exc.InterfaceError: (pymysql.err.InterfaceError) (0, '') (Background on this error at: http://sqlalche.me/e/rvf5) | 13:13 |
jaypipes | am I the only person that thinks the phrase "tripleo standalone install" is an oxymoron? | 13:14 |
kashyap | jaypipes: Heh, I guess that depends on what they mean by "standalone install" | 13:16 |
Sundar | gibi: I will take a look | 13:16 |
kashyap | jaypipes: /me himself has never hands-on installed TripleO, though ... | 13:16 |
*** cdent_ has joined #openstack-nova | 13:22 | |
*** cdent_ has quit IRC | 13:23 | |
openstackgerrit | zhaixiaojun proposed openstack/nova master: When the flavor id is invalid, the message does not match the regular expression, missing the numbers from 0-9. https://review.openstack.org/638150 | 13:25 |
*** pbing19 has quit IRC | 13:28 | |
*** mriedem has joined #openstack-nova | 13:28 | |
jangutter | kashyap, jaypipes: don't get me wrong, I love tripleo. It's also one of the most scarily self-referential things I've ever come across. | 13:29 |
mdbooth | sean-k-mooney: Through what's almost certainly a bug, but one which goes down a rabbit hole I'm not interested in right now, I've ended up with a port bound on a compute host which neutron doesn't think it's bound on, causing LM failure. What's the best way to kick it so I can get on with my day? | 13:30 |
jangutter | jaypipes: I presume you're referring to tripleo-quickstart? | 13:31 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Check hosts have no instances for AZ rename https://review.openstack.org/509206 | 13:32 |
* mdbooth has been dreaming lately of a self-hosting openstack, where services run in the admin tenant of its own cloud. If you could sort out the bootstrapping, it's actually a really attractive proposition. | 13:32 | |
*** agopi has quit IRC | 13:35 | |
sean-k-mooney | mdbooth: define bound. you could try a hard reboot but neutron is the souce of truth in this matter | 13:35 |
jaypipes | jangutter: no, I'm referring to larsks's phrase "tripleo standalone install" in a recent ML post | 13:35 |
sean-k-mooney | mdbooth: we recently merged a fix to prevent the network info cache form getting out of sync so that should fix nova db periodicaly | 13:36 |
mdbooth | sean-k-mooney: I suspect it's an agent issue. Bind fails on the destination. I just deleted the instance, though, so I'm guessing the mess is still there but as long as it doesn't affect me I don't care right now :) | 13:36 |
jangutter | jaypipes: that sounds like a standalone networked computer in my mind. | 13:36 |
jaypipes | I'm actually not sure what was meant. | 13:36 |
mdbooth | It was a failed LM. LM failed because ssh keys weren't configured. Haven't looked , but presumably we created ports on the dest prior to LM, then didn't clean them up properly when it failed. | 13:37 |
mdbooth | So second attempt to LM fails because port is already bound. | 13:37 |
jangutter | jaypipes: reading the mail, I think this is "standalone" vs "integrating with an external ... " etc. | 13:38 |
larsks | jaypipes: standalone tripleo: https://docs.openstack.org/tripleo-docs/latest/install/containers_deployment/standalone.html | 13:38 |
larsks | Single node tripleo deployment installed using the 'openstack tripleo deploy' command. | 13:39 |
jangutter | larsks: aaah, "standalone" vs "ha". | 13:39 |
jaypipes | interesting. | 13:39 |
*** gbarros has joined #openstack-nova | 13:39 | |
larsks | jangutter: not exactly. "standalone" vs "multinode" | 13:39 |
jaypipes | probably better to call it "all-in-one" or "single-node", but ok | 13:40 |
larsks | Eh, I didn't name it :). But yes. | 13:40 |
jaypipes | :) | 13:40 |
jaypipes | larsks: k, thx for the heads up. looks like this is relatively new functionality. | 13:40 |
larsks | I think so. I believe it stems from wanting to handle underlcoud deployment the same way as overcloud deployment. | 13:41 |
jaypipes | it's all a little too inception-y for me. | 13:41 |
jaypipes | turtles all the way down ;) | 13:42 |
jangutter | larsks: and that's why I find tripleo so fascinating, going all in with self-referencing! | 13:42 |
jangutter | larsks: basically it's a scalability problem, where the problem is "how can I scale down to 1 node". | 13:42 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance (2) https://review.openstack.org/637954 | 13:43 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.openstack.org/637955 | 13:43 |
*** gbarros has quit IRC | 13:44 | |
*** spsurya has joined #openstack-nova | 13:44 | |
*** gbarros has joined #openstack-nova | 13:44 | |
mdbooth | Eurgh. I forgot about that weird F29 iscsi bug when I provisioned this devstack >:( | 13:44 |
stephenfin | kaisers: sup? | 13:45 |
kaisers | stephenfin: updates to both CLs | 13:46 |
kaisers | stephenfin: mostly the open nits but check the is_sysd thing again, pls | 13:46 |
stephenfin | ack | 13:46 |
*** jmlowe has quit IRC | 13:47 | |
sean-k-mooney | larsks: why does triplo build its docs like that. it makes them really hard to read givent tha that you have 3 or 4 release togehter with 2-3 distros | 13:47 |
larsks | sean-k-mooney: I have no idea. | 13:48 |
sean-k-mooney | if it wasnt for the fact i like stephenfin sanity it woul be neice if he had time to fix that... | 13:49 |
*** jchhatbar has joined #openstack-nova | 13:52 | |
*** jchhatbar has quit IRC | 13:53 | |
stephenfin | sean-k-mooney: What about my sanity? :D | 13:54 |
*** jchhatbar has joined #openstack-nova | 13:54 | |
*** janki has quit IRC | 13:54 | |
sean-k-mooney | stephenfin: im suggesting that it may be damaged if you were to undertake reworking all the tripplo docs to be readable | 13:55 |
stephenfin | Oh, yeah, feck that | 13:55 |
*** mlavalle has joined #openstack-nova | 14:00 | |
jangutter | sean-k-mooney: once you get used to it, it's not so bad, but covering all the use cases you want to cover is going to drive you batty. | 14:00 |
*** markvoelker has joined #openstack-nova | 14:02 | |
jangutter | sean-k-mooney: would be better if the "LIMIT ENVIRONMENT SPECIFIC CONTENT" bit worked.... | 14:05 |
mriedem | dansmith: down cells bp was technically dropped from runways yesterday. can we get the docs change merged since we can follow up with the admin guide stuff and because it's causing issues for other changes that need a new microversion (the rest api history doc means everyone has to rebase on this): https://review.openstack.org/#/c/635147/ | 14:09 |
*** sdake has joined #openstack-nova | 14:10 | |
*** agopi has joined #openstack-nova | 14:10 | |
NewBruce | hey sean-k-mooney! | 14:11 |
NewBruce | hopefully i can be tied to the desk today! :) | 14:11 |
mriedem | sean-k-mooney: adrianc: i'm pulling https://blueprints.launchpad.net/nova/+spec/libvirt-neutron-sriov-livemigration from runways | 14:13 |
*** _fragatina has joined #openstack-nova | 14:13 | |
adrianc | miredem: ill re-add to queue | 14:14 |
sean-k-mooney | mriedem: ok. | 14:14 |
*** ttsiouts has quit IRC | 14:15 | |
*** ttsiouts has joined #openstack-nova | 14:15 | |
*** dave-mccowan has joined #openstack-nova | 14:16 | |
*** sdake has quit IRC | 14:18 | |
mriedem | jackding: jroll: https://blueprints.launchpad.net/nova/+spec/flavor-extra-spec-image-property-validation and https://blueprints.launchpad.net/nova/+spec/ironic-conductor-groups are in runways now | 14:18 |
jroll | thanks! | 14:19 |
NewBruce | sean-k-mooney - to avoid cluttering the main chat here have dropped you full details in a DM | 14:22 |
*** HD|Laptop has joined #openstack-nova | 14:22 | |
kaisers | stephenfin: thnx for seeing this through to the current state | 14:23 |
sean-k-mooney | NewBruce: just finishing a code review but ill pop over in a miniute | 14:23 |
NewBruce | no worries mate - working late tonight, so ill be here a while | 14:23 |
NewBruce | have been talking to mnaser about this as well | 14:23 |
mnaser | i mean it is kindof a nova bug :) | 14:24 |
*** s10 has joined #openstack-nova | 14:28 | |
*** jmlowe has joined #openstack-nova | 14:30 | |
mriedem | artom: replied to your questions about the tests in https://review.openstack.org/#/c/631948/ | 14:30 |
*** eharney has joined #openstack-nova | 14:32 | |
*** lbragstad has joined #openstack-nova | 14:32 | |
dansmith | mriedem: got it up now | 14:33 |
*** sdake has joined #openstack-nova | 14:34 | |
*** priteau has joined #openstack-nova | 14:35 | |
gibi | efried, jaypipes: updated https://review.openstack.org/#/c/616239 based on what we agreed on Friday. If you could re-review that patch that would be awesome | 14:35 |
*** awalende has quit IRC | 14:35 | |
openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.69: Handles Down Cells Documentation https://review.openstack.org/635147 | 14:36 |
openstackgerrit | Surya Seetharaman proposed openstack/nova master: [Doc Fix]Best practices for effectively tolerating down cells https://review.openstack.org/638173 | 14:36 |
*** markvoelker has quit IRC | 14:36 | |
bauzas | gibi: I need to jump on your b/w series | 14:36 |
bauzas | gibi: later today | 14:36 |
*** awalende has joined #openstack-nova | 14:36 | |
gibi | bauzas: thanks in advance | 14:37 |
*** lbragstad_ has joined #openstack-nova | 14:40 | |
*** awalende has quit IRC | 14:41 | |
*** lbragstad has quit IRC | 14:41 | |
*** cfriesen has joined #openstack-nova | 14:48 | |
*** jobewan has joined #openstack-nova | 14:52 | |
*** lbragstad has joined #openstack-nova | 14:53 | |
*** lbragstad_ has quit IRC | 14:54 | |
*** lbragstad_ has joined #openstack-nova | 14:56 | |
*** awaugama has joined #openstack-nova | 14:56 | |
*** jackding has joined #openstack-nova | 14:57 | |
*** sdake has quit IRC | 14:58 | |
*** lbragstad has quit IRC | 14:58 | |
*** lbragstad_ has quit IRC | 14:58 | |
jackding | Need another core to approve https://review.openstack.org/#/c/603844/. It's been too long. | 14:58 |
kashyap | jackding: Hi, I have something unrelated to chat: CPU models | 15:00 |
efried | gibi: +2 | 15:00 |
*** lbragstad has joined #openstack-nova | 15:01 | |
kashyap | jackding: So I recall you filed this one: https://review.openstack.org/#/c/620959/ (Select cpu model from a list of cpu models) | 15:01 |
kashyap | jackding: I thought you might be interested in this one: https://blueprints.launchpad.net/nova/+spec/cpu-selection-with-hypervisor-consideration | 15:02 |
*** efried is now known as efried_pto | 15:02 | |
*** ysandeep has joined #openstack-nova | 15:03 | |
gibi | efried_pto: thanks | 15:04 |
kashyap | I'll file a spec too. In short, the core proposal here is to replace the existing two libvirt APIs with the "hypervisor-literate" APIs, which are far more useful. | 15:04 |
kashyap | jackding: ^ It maps onto the comment I noted here: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3900,#L3909 | 15:05 |
ysandeep | #openstack-nova A quick query, If my nova backend of compute nodes is ceph. And I evacuate instance.. Will my root disk of instance (rbd in ceph) will remain intact or the root disk will reimage(Old disk will be deleted and a new disk will be created from image)? | 15:07 |
*** NewBruce has quit IRC | 15:07 | |
*** NewBruce has joined #openstack-nova | 15:08 | |
mriedem | ysandeep: if you're evacuating to another compute host sharing the same ceph cluster the root disk should remain | 15:08 |
*** zhubx has quit IRC | 15:08 | |
ysandeep | mriedem, thank you so much .. Do you happen to have idea about - from which branch we have this feature? | 15:10 |
mriedem | ysandeep: that's been around a long time, that's why the evacuate api has an onSharedStorage parameter https://developer.openstack.org/api-ref/compute/?expanded=evacuate-server-evacuate-action-detail#evacuate-server-evacuate-action | 15:11 |
mriedem | having said that, i'm sure there have been bug fixes over the years | 15:11 |
mriedem | mdbooth probably knows best about that | 15:11 |
*** Luzi has quit IRC | 15:11 | |
ysandeep | mriedem, thank you soo much.. really appreciate your help.. | 15:11 |
mriedem | yw | 15:11 |
mdbooth | ysandeep: It remains intact. | 15:11 |
*** lbragstad_ has joined #openstack-nova | 15:12 | |
ysandeep | mdbooth, thanks | 15:12 |
mdbooth | ysandeep: Same for NFS. | 15:12 |
*** NewBruce has quit IRC | 15:12 | |
openstackgerrit | Adrian Chiris proposed openstack/nova master: Add free for claimed, allocated devices https://review.openstack.org/616120 | 15:13 |
ysandeep | mdbooth, thanks, i will test for nfs also | 15:13 |
openstackgerrit | Adrian Chiris proposed openstack/nova master: Allow per-port modification of vnic_type and profile https://review.openstack.org/607365 | 15:13 |
openstackgerrit | Adrian Chiris proposed openstack/nova master: Add get_instance_pci_request_from_vif https://review.openstack.org/619929 | 15:13 |
openstackgerrit | Adrian Chiris proposed openstack/nova master: SR-IOV Live migration indirect port support https://review.openstack.org/620115 | 15:13 |
openstackgerrit | Adrian Chiris proposed openstack/nova master: libvirt: auto detach/attach sriov ports on migration https://review.openstack.org/629589 | 15:13 |
*** wolverineav has joined #openstack-nova | 15:13 | |
*** lbragstad has quit IRC | 15:13 | |
jackding | kashyap: noted, thanks | 15:13 |
mdbooth | ysandeep: Same for boot from volume too, fwiw. | 15:13 |
kashyap | jackding: Just wanted to give a heads-up, so we don't duplicate efforts :-) | 15:14 |
*** pbing19 has joined #openstack-nova | 15:14 | |
jackding | kashyap: sure thing. | 15:15 |
artom | mriedem, yep, saw that. I'll un-1 soon | 15:15 |
artom | I also reviewed that series ass-backwards by looking at the top one first | 15:15 |
ysandeep | mdbooth, yes i was aware for boot from volume(cinder volume) but I was not sure of nova disk(on cluster storage) and ephermal disk behavior | 15:15 |
*** NewBruce has joined #openstack-nova | 15:17 | |
*** wolverineav has quit IRC | 15:18 | |
*** lbragstad_ is now known as lbragstad | 15:18 | |
*** NewBruce6 has joined #openstack-nova | 15:18 | |
*** NewBruce has quit IRC | 15:18 | |
*** jchhatbar has quit IRC | 15:19 | |
*** NewBruce6 is now known as NewBruce | 15:20 | |
*** moshele has quit IRC | 15:21 | |
*** sapd1_x has joined #openstack-nova | 15:23 | |
*** sapd1 has quit IRC | 15:23 | |
*** markvoelker has joined #openstack-nova | 15:33 | |
*** ysandeep has quit IRC | 15:38 | |
mriedem | tssurya: i'll poke on your novaclient change https://review.openstack.org/#/c/579563/ later this morning to try and sort out the test issue | 15:40 |
tssurya | dansmith: feel free to author the documentation patch if its only those changes in your comments that need to change I can respin, but considering mriedem and you removed the votes I guess there are some obvious incorrect wordings | 15:40 |
dansmith | tssurya: it's fine, just let me finish the call I'm on and then I'll push up a rev | 15:41 |
tssurya | mriedem: yea thanks I am not sure why that address gets printed in the wrong order | 15:41 |
mriedem | tssurya: my guess is something about dict hashseeds in py27 | 15:41 |
tssurya | mriedem: oh okay | 15:42 |
tssurya | dansmith: thanks | 15:42 |
*** ivve has quit IRC | 15:52 | |
jaypipes | jackding: k, will review after gibi's patch. | 15:53 |
jackding | jaypipes: thanks | 15:53 |
*** rpittau has quit IRC | 15:55 | |
*** rpittau_ has joined #openstack-nova | 15:55 | |
*** rpittau_ is now known as rpittau | 15:57 | |
*** ttsiouts has quit IRC | 15:58 | |
*** ttsiouts has joined #openstack-nova | 15:59 | |
*** ttsiouts has quit IRC | 16:03 | |
*** NewBruce_ has joined #openstack-nova | 16:04 | |
*** ttsiouts has joined #openstack-nova | 16:05 | |
*** NewBruce_ has quit IRC | 16:05 | |
tssurya | mriedem: also here https://review.openstack.org/#/c/637217/ I am not entirely sure why we need to consider the non-zero standard classes in the extra_specs | 16:06 |
*** markvoelker has quit IRC | 16:06 | |
mriedem | i don't think we're going to | 16:07 |
tssurya | ok good | 16:07 |
mriedem | we want to check if the standard resource class key exists in extra specs and if it's already 0, we consider that instance migrated | 16:08 |
mriedem | if it's non-zero, then i guess we log a warning and still consider it migrated | 16:08 |
tssurya | yea that's what I throught too, I was just reading jroll's and efried_pto's comments on it | 16:08 |
tssurya | which implied otherwise | 16:08 |
tssurya | ah a warning! ok then | 16:09 |
* jaypipes slaps gibi for making his brain hurt this morning... | 16:09 | |
mriedem | note that on stable branches (at least stable/rocky) that calculation probably needs to account for report_ironic_standard_resource_class_inventory | 16:09 |
mriedem | which makes it even more complicated | 16:09 |
tssurya | yea saw that part :( | 16:10 |
gibi | jaypipes: it is not me it is the problem that is the source of the hurt :) | 16:12 |
openstackgerrit | melanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | 16:13 |
*** igordc has joined #openstack-nova | 16:20 | |
openstackgerrit | Dan Smith proposed openstack/nova master: API microversion 2.69: Handles Down Cells Documentation https://review.openstack.org/635147 | 16:22 |
dansmith | mriedem: tssurya see what you think of that ^ | 16:22 |
dansmith | I was tempted to rename it as well to just say "Handling partial infrastructure failures" or something | 16:22 |
tssurya | dansmith: I don't mind at all :) feel free to change anything in that patch | 16:23 |
jaypipes | gibi: :) | 16:25 |
openstackgerrit | Merged openstack/nova master: Address nits from I9e30a24a4c0640f282f507d0a96640d3cdefe43c https://review.openstack.org/636967 | 16:26 |
*** rpittau is now known as rpittau|sardegna | 16:28 | |
*** wolverineav has joined #openstack-nova | 16:29 | |
*** macza has joined #openstack-nova | 16:32 | |
*** ttsiouts has quit IRC | 16:33 | |
*** ttsiouts has joined #openstack-nova | 16:33 | |
mriedem | tssurya: i have the novaclient test sorting thing fixed | 16:34 |
*** yan0s has quit IRC | 16:34 | |
mriedem | i'll post that as a patch before yours in the series | 16:34 |
*** s10 has quit IRC | 16:34 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.openstack.org/637955 | 16:34 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: cache neutron ports in heal allocation https://review.openstack.org/638207 | 16:34 |
*** ttsiouts has quit IRC | 16:38 | |
*** hongbin has joined #openstack-nova | 16:38 | |
*** tosky has joined #openstack-nova | 16:39 | |
* gibi leaves for today | 16:39 | |
*** pbing19 has quit IRC | 16:39 | |
*** pbing19 has joined #openstack-nova | 16:39 | |
melwitt | mriedem: we have an ironic driver fix proposed that adds a kwarg to the get_info() virt method. we wanted your opinion about whether it's backportable and if not, advice on another way to approach it https://review.openstack.org/636699 | 16:43 |
*** gyee has joined #openstack-nova | 16:45 | |
*** wolverineav has quit IRC | 16:49 | |
*** wolverin_ has joined #openstack-nova | 16:49 | |
*** wolverin_ has quit IRC | 16:53 | |
*** helenafm has quit IRC | 16:54 | |
*** HD|Laptop has quit IRC | 16:54 | |
mriedem | well that's a backward incompatible change to any out of tree drivers on stable | 16:57 |
mriedem | so it depends on if you care about that | 16:57 |
mriedem | efried_pto probably cares about it | 16:57 |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: API microversion 2.69: Handles Down Cells https://review.openstack.org/579563 | 16:58 |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Make Server.networks use a predictable sort order https://review.openstack.org/638214 | 16:58 |
melwitt | a new kwarg with a default value? I didn't think that's backward incompat | 16:59 |
tssurya | mriedem: oh thanks a lot! | 17:01 |
tssurya | and as far as the host name being "host1" always its because the fake has that hardcoded | 17:01 |
tssurya | I can just change that if you want them to be unique | 17:01 |
mriedem | melwitt: if compute is passing use_cache=False to an out of tree driver that implements get_info(instance) but doesn't have that kwarg in the method signature, it's going to blow up | 17:02 |
melwitt | oh, right. urgh | 17:02 |
mriedem | http://paste.openstack.org/show/745484/ | 17:03 |
*** markvoelker has joined #openstack-nova | 17:03 | |
mriedem | so the worst that happens is out of tree drivers don't have the sync power states task working until they fix that | 17:04 |
*** psachin has quit IRC | 17:04 | |
melwitt | jroll ^ | 17:04 |
*** moshele has joined #openstack-nova | 17:05 | |
jroll | melwitt: yep, that's correct, I just didn't know what the policy was given out of tree drivers are unsupported | 17:05 |
jroll | I'm not sure there's a different approach we can take, am open to it though | 17:06 |
jroll | other than reverting the thing that made the sync use the cache, and spamming ironic for that task | 17:06 |
mriedem | i'm commenting | 17:07 |
mriedem | cool your jets and hold your horses please | 17:07 |
mriedem | oath can wait | 17:07 |
jroll | it's not even for oath, larsks reported this bug and I hacked it up ¯\_(ツ)_/¯ | 17:07 |
jroll | besides oath is dead, long live verizon media :P | 17:07 |
mriedem | oh right | 17:07 |
*** tssurya has quit IRC | 17:07 | |
mriedem | vmg 4ever | 17:07 |
openstackgerrit | Stephen Finucane proposed openstack/os-vif master: WIP: Add API docs for various VIF types https://review.openstack.org/637009 | 17:08 |
mriedem | jroll: posted | 17:10 |
mriedem | my suggestion is handling a TypeError in this change if you're going to backport it, and in a follow up remove the TypeError handling | 17:10 |
*** pcaruana has quit IRC | 17:13 | |
jroll | mriedem: oh, that's a good idea, thanks. I'll update with that | 17:13 |
*** dtantsur is now known as dtantsur|afk | 17:14 | |
*** _fragatina has quit IRC | 17:14 | |
mdbooth | sean-k-mooney: That port binding error I mentioned this morning could be a more serious thing. I'm currently messing with LM and generating lots of LM failures, and in every case it's not possible to repeat the LM because: | 17:16 |
mdbooth | $ openstack server migrate --live devstack-2.marston --block-migration test1 | 17:16 |
mdbooth | Migration pre-check error: Binding failed for port 48c1c3b8-be35-46a0-8df2-60495b4c6b9d, please check neutron logs for more information. (HTTP 400) (Request-ID: req-3217c16e-438a-4025-a462-8979fc97bd80) | 17:16 |
mriedem | jroll: you may also want to take the opportunity to refresh the node_cache but that would be a follow up | 17:16 |
*** Sundar has quit IRC | 17:17 | |
mriedem | mdbooth: is the vif_type on the port binding "binding_failed" or "unbound"? | 17:17 |
*** davidsha has quit IRC | 17:17 | |
*** moshele has quit IRC | 17:17 | |
mriedem | if so, we don't know how to translate that to an os-vif object to plug the vif on the dest host | 17:17 |
mriedem | and it blows up | 17:17 |
jroll | mriedem: eh, that's a bigger timesink that I'm not sure I want to do in the middle of that loop... though would help in the case of a whole rack getting unplugged or something | 17:18 |
mriedem | mdbooth: semi related https://review.openstack.org/#/c/603844/ | 17:18 |
mdbooth | mriedem: Well it remains bound on the source, so it looks normal I guess? | 17:18 |
mriedem | mdbooth: if the vif_type in the port binding is busted, you might have to detach and re-attach the port to the server to fix it | 17:18 |
mriedem | mdbooth: check the port binding details on the port in the neutron api | 17:19 |
mriedem | you probably have to be admin to get that field | 17:19 |
mriedem | binding:vif_type is what you're looking for | 17:19 |
mdbooth | It's 'ovs' | 17:19 |
mriedem | oh huh | 17:19 |
mriedem | well actually, | 17:20 |
mriedem | is this rocky? | 17:20 |
mdbooth | mriedem: This is a dark art to me, btw :) | 17:20 |
mdbooth | devstack master | 17:20 |
mriedem | the port binding for the dest host will be on GET /ports/{port_id}/bindings/{dest_host} | 17:20 |
mriedem | the port binding details you're looking at on the port are likely the source host | 17:20 |
mriedem | which is the 'active' binding | 17:20 |
mriedem | the dest host binding is the inactive one | 17:20 |
mriedem | and it's what you're trying to plug | 17:21 |
mdbooth | Ah, ok. | 17:21 |
mdbooth | No cli for that? | 17:21 |
* mdbooth cracks open his curl | 17:21 | |
sean-k-mooney | mdbooth: it was in the spec but no | 17:21 |
mriedem | unfortunately there is no api ref for the port bindings api yet | 17:21 |
mdbooth | I'm assuming if I look at the LM code in nova we're failing to clean that up | 17:22 |
sean-k-mooney | mdbooth: to clean up a host binding? | 17:23 |
*** jackding has quit IRC | 17:23 | |
mriedem | _rollback_live_migration should delete inactive dest host port bindings | 17:23 |
sean-k-mooney | mdbooth: i had tought we had code for that | 17:23 |
mriedem | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6958 | 17:24 |
mriedem | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L7010 | 17:24 |
mriedem | if we failed to cleanup the dest host port bindings where should be an error in the compute logs | 17:25 |
*** ircuser-1 has quit IRC | 17:26 | |
mdbooth | Hmm, nothing obvious | 17:27 |
mdbooth | Anyway, I'm going to have to shoot. I'll investigate properly in the morning, was just sharing in case sean-k-mooney had immediate insight. | 17:28 |
mdbooth | Thanks for the help. | 17:28 |
mriedem | dansmith: commented https://review.openstack.org/#/c/635147/ | 17:30 |
*** markvoelker has quit IRC | 17:36 | |
sean-k-mooney | mdbooth i know that i have seen case where cleaning up the volume on a roleback fails and we raise an excpetion and dont then rollback the networking | 17:38 |
*** ociuhandu_ has joined #openstack-nova | 17:39 | |
sean-k-mooney | mdbooth: my guess is that is the most likely cause. for example if self.compute_rpcapi.remove_volume_connection rased an exception we would never call self.network_api.setup_networks_on_host | 17:39 |
sean-k-mooney | mdbooth: we probaly should split _rollback_live_migration into several smaller fucntion and call them with a set fo try finally statement to ensure that all resouces that can be rolled back are | 17:40 |
sean-k-mooney | mdbooth: ill be fixing stuff arount this code for something else next sprint so i might look at doing that change then. | 17:42 |
*** ociuhandu has quit IRC | 17:42 | |
jaypipes | gibi: still around? | 17:43 |
*** ociuhandu_ has quit IRC | 17:43 | |
jaypipes | gibi: on https://review.openstack.org/#/c/616239/ did we decide not to change anything for the group_policy_isolate=true? | 17:44 |
*** jaosorior has quit IRC | 17:49 | |
*** jaosorior has joined #openstack-nova | 17:49 | |
*** derekh has quit IRC | 17:50 | |
*** ociuhandu has joined #openstack-nova | 17:54 | |
*** ociuhandu has quit IRC | 17:58 | |
*** thgcorrea has quit IRC | 17:59 | |
*** panda is now known as panda|off | 17:59 | |
*** wolverineav has joined #openstack-nova | 17:59 | |
*** sdake has joined #openstack-nova | 18:03 | |
*** ircuser-1 has joined #openstack-nova | 18:04 | |
*** wolverineav has quit IRC | 18:04 | |
*** cdent has quit IRC | 18:09 | |
artom | Resizing to the same host is expected to work, right? | 18:11 |
openstackgerrit | Dan Smith proposed openstack/nova master: API microversion 2.69: Handles Down Cells Documentation https://review.openstack.org/635147 | 18:11 |
artom | I'm debugging an internal thing, and it looks like we're still asking Neutron to update the port bindings, even though nothing's changed. | 18:11 |
artom | Bleargh no, it's the revert. | 18:12 |
artom | Never mind. | 18:12 |
*** _fragatina has joined #openstack-nova | 18:12 | |
artom | Thanks for being my rubber duck. | 18:12 |
*** wolverineav has joined #openstack-nova | 18:12 | |
sean-k-mooney | same host resize needs to be enable in the nova config i think but yes it should work | 18:13 |
sean-k-mooney | artom: by the way we do need to rebind on the neutron side as the operator could have changed the security group driver for instance so how we attach the instance to the netowrk backend could change | 18:15 |
*** wolverineav has quit IRC | 18:15 | |
*** wolverineav has joined #openstack-nova | 18:15 | |
sean-k-mooney | artom: this can happen for example if you did and inplace upgrade and then resize the vm | 18:15 |
artom | sean-k-mooney, aha, ok | 18:16 |
sean-k-mooney | normally the changes would get picked up on the next hard reboot | 18:16 |
*** ociuhandu has joined #openstack-nova | 18:16 | |
*** wolverineav has quit IRC | 18:16 | |
sean-k-mooney | artom: but ya were you actully hittin an issue? | 18:16 |
artom | sean-k-mooney, not 100% sure yet, but looks like it's Neutron | 18:17 |
artom | We ask for a thing, and timeout waiting for it | 18:17 |
*** wolverineav has joined #openstack-nova | 18:17 | |
artom | Grr, and I can't find the corresponding Neutron request | 18:18 |
*** wolverineav has quit IRC | 18:18 | |
sean-k-mooney | oh is this the virtual interface thing we were talking about downstream earlier | 18:18 |
*** wolverineav has joined #openstack-nova | 18:18 | |
artom | Yeah | 18:19 |
sean-k-mooney | artom: as i mentioned to mdbooth eariler if any of the storage cleanup code raises an exception in _rollback_live_migration its possible today that we will never call self.network_api.setup_network_on_host to rollback the network | 18:20 |
*** wolverineav has quit IRC | 18:20 | |
sean-k-mooney | so if there is an exption earilier in the function https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6958 will not be called | 18:20 |
artom | sean-k-mooney, no, I think we're reaching that part | 18:21 |
*** priteau has quit IRC | 18:21 | |
artom | As I said, I see Nova making the Neutron request | 18:21 |
artom | But debug's not enabled, so I can't find that request arriving on the Neutron side | 18:21 |
artom | I mean, maybe it doesn't? | 18:21 |
sean-k-mooney | you shoudl see it in the neutron api log without debugging | 18:22 |
artom | Actually, debug *is* enabled | 18:22 |
sean-k-mooney | you may not see al of the intermediate steps but the post to the port binding endoint should be there | 18:22 |
artom | It'll log the HTTP method, right? | 18:23 |
artom | I'm casting a wide net and straight up grep -E '2019-02-14 18:50:5.*(PUT|POST)' -R `find . -wholename '*neutron/*.log'` | 18:23 |
sean-k-mooney | ya and it should have the respocne code | 18:23 |
artom | Nothing. | 18:23 |
artom | That's weird though, 'cuz Nova would log a timeout | 18:25 |
*** wolverineav has joined #openstack-nova | 18:25 | |
sean-k-mooney | so it timed out waiting for the network-vif-plugged event | 18:25 |
sean-k-mooney | whcich got raised as a VirtualInterfaceCreateExcetiopn. | 18:26 |
sean-k-mooney | the logs i have did not containt the neutron server logs | 18:27 |
artom | sean-k-mooney, that might be why | 18:27 |
*** wolverineav has quit IRC | 18:30 | |
*** markvoelker has joined #openstack-nova | 18:33 | |
*** hongbin has quit IRC | 18:33 | |
*** wolverineav has joined #openstack-nova | 18:34 | |
*** ralonsoh has quit IRC | 18:34 | |
*** cdent has joined #openstack-nova | 18:42 | |
imacdonn | Is it just me, or does this releasenote seem incomprehensive? I'm left wondering whether or not I should remove the consoleauth service, and under what circumstances the workaround is required. "A new check is added to the nova-status upgrade check CLI to check for use of the nova-consoleauth service to warn and provide additional instructions to set [workarounds]enable_consoleauth = True while performing a live/rolling upgrade." | 18:46 |
*** moshele has joined #openstack-nova | 18:56 | |
*** sdake has quit IRC | 18:58 | |
imacdonn | I think it should say something like "The consoleauth service is deprecated, and should be disabled/removed, however, if there is a requirement to maintain support for existing console sessions through a live/rolling upgrade......" | 18:59 |
melwitt | consoleauth strikes again | 19:00 |
melwitt | imacdonn: thanks for the feedback. I actually tried to explain it better in the latest updates to the releasenote and still missed the mark. I can propose another change | 19:01 |
melwitt | you definitely need to enable the workaround if you're doing a live upgrade | 19:01 |
imacdonn | yeah, seems we've been here before ;) At least removing the service seems to actually not generally break things this time ;) | 19:02 |
aspiers | melwitt: are release notes only for operator- / user-facing changes? | 19:02 |
aspiers | just wondering if I should add one for this new driver-capabilities-to-traits patch | 19:02 |
*** markvoelker has quit IRC | 19:06 | |
* melwitt hides | 19:06 | |
imacdonn | heh | 19:06 |
melwitt | aspiers: yeah, anything users should know about a change. I don't think I've seen the driver capabilities to traits thing yet | 19:07 |
aspiers | melwitt: https://review.openstack.org/#/c/538498/12 | 19:07 |
aspiers | melwitt: it's my rebase of an old patch from mriedem | 19:07 |
aspiers | I'm currently fixing the test failures | 19:07 |
*** tesseract has quit IRC | 19:08 | |
imacdonn | aspiers: I guess my question (if I mattered) would be: who needs to know about this ? | 19:09 |
melwitt | aspiers: ok, I see. I think that would use a release note to let users know that driver capabilities will show up as custom traits in the placement API | 19:09 |
aspiers | imacdonn: my question too ;-) | 19:10 |
aspiers | melwitt: OK thanks! | 19:10 |
melwitt | aspiers: as for who, I don't know exactly, but it's the kind of thing I could see a cloud monitoring system looking at, what driver capabilities exist on each compute host | 19:12 |
aspiers | melwitt: yup, makes sense | 19:12 |
imacdonn | if there's a change to the way things appear through any published interface, I'd say it definitely should be a release-note. | 19:13 |
*** sdake has joined #openstack-nova | 19:13 | |
aspiers | yeah, I suppose just new traits appearing would be sufficient to justify documenting | 19:13 |
*** wolverineav has quit IRC | 19:15 | |
*** marst has joined #openstack-nova | 19:17 | |
imacdonn | tangentially related (to release notes), I found a typo in another one. I might submit a fix a bit later, if I get time, but if someone else wants to grab it, that'd be cool too. https://bugs.launchpad.net/nova/+bug/1816831 | 19:18 |
openstack | Launchpad bug 1816831 in OpenStack Compute (nova) "DOC: typo in add_initial_allocation_ratio releasenote" [Undecided,New] | 19:18 |
*** jaosorior has quit IRC | 19:18 | |
*** jmlowe has quit IRC | 19:19 | |
melwitt | thanks | 19:20 |
*** hongbin has joined #openstack-nova | 19:23 | |
*** jaosorior has joined #openstack-nova | 19:28 | |
*** jmlowe has joined #openstack-nova | 19:30 | |
mriedem | dansmith: +2 on that docs change | 19:33 |
dansmith | mriedem: +W | 19:33 |
mriedem | let us never speak of this again | 19:34 |
dansmith | I looked a the best practices one a bit, found one typo, but will look again when it gets respun | 19:34 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix typo in initial_disk_allocation_ratio release note https://review.openstack.org/638245 | 19:35 |
mriedem | imacdonn: done - thanks for reporting that ^ | 19:35 |
imacdonn | mriedem: thanks! | 19:36 |
dansmith | +W within one minute | 19:37 |
melwitt | whew, what a sense of accomplishment | 19:37 |
aspiers | almost as towering an achievement as https://review.openstack.org/#/c/609777/ | 19:39 |
melwitt | lol | 19:39 |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Add support for microversion 2.70 - expose device tags https://review.openstack.org/636779 | 19:39 |
aspiers | melwitt: my finest hour | 19:39 |
artom | aspiers, I'm grateful that your around | 19:46 |
* aspiers tears his eyes out | 19:46 | |
*** wolverineav has joined #openstack-nova | 19:46 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Replace ansible --sudo with --become in live_migration/hooks scripts https://review.openstack.org/635308 | 19:48 |
*** sdake has quit IRC | 19:50 | |
*** wolverineav has quit IRC | 19:51 | |
*** wolverineav has joined #openstack-nova | 19:51 | |
imacdonn | artom: I see what you did there ;) | 19:52 |
*** jackding has joined #openstack-nova | 19:55 | |
*** wolverineav has quit IRC | 19:59 | |
*** wolverineav has joined #openstack-nova | 20:01 | |
artom | imacdonn, I no you did. | 20:02 |
imacdonn | :) | 20:02 |
aspiers | artom: stop teasing, its cruel | 20:03 |
*** markvoelker has joined #openstack-nova | 20:03 | |
*** wolverineav has quit IRC | 20:05 | |
*** jmlowe has quit IRC | 20:06 | |
*** wolverineav has joined #openstack-nova | 20:06 | |
*** jmlowe has joined #openstack-nova | 20:08 | |
*** wolverineav has quit IRC | 20:11 | |
aspiers | ;) | 20:18 |
*** markvoelker has quit IRC | 20:36 | |
*** pbing19 has quit IRC | 20:39 | |
*** wolverineav has joined #openstack-nova | 20:42 | |
*** spsurya has quit IRC | 20:42 | |
*** wolverineav has quit IRC | 20:46 | |
*** eharney has quit IRC | 20:46 | |
mriedem | low-hanging-fruit docs bug if someone wants it https://bugs.launchpad.net/nova/+bug/1816859 | 20:52 |
openstack | Launchpad bug 1816859 in OpenStack Compute (nova) "Server concepts in nova - automatic resize confirm is wrong in docs" [Medium,Triaged] | 20:52 |
*** jmlowe has quit IRC | 20:53 | |
*** wolverineav has joined #openstack-nova | 20:54 | |
openstackgerrit | Adam Spiers proposed openstack/nova master: Convert driver supported capabilities to compute node provider traits https://review.openstack.org/538498 | 20:54 |
openstackgerrit | Adam Spiers proposed openstack/nova master: Convert driver supported capabilities to compute node provider traits https://review.openstack.org/538498 | 20:59 |
*** eharney has joined #openstack-nova | 20:59 | |
aspiers | efried_pto, mriedem, melwitt: I think this is ready for serious consideration now ^^^ | 21:00 |
aspiers | I've fixed all the TODOs I can see, and (fingers crossed) the tests will pass | 21:00 |
aspiers | s/will/should/ | 21:00 |
*** erlon__ has quit IRC | 21:01 | |
*** ttsiouts has joined #openstack-nova | 21:01 | |
melwitt | kewl | 21:04 |
mriedem | aspiers: so is your sev stuff going to rebase on top of that or what? | 21:08 |
mriedem | because it refers to both a blueprint that's already complete and one that's not approved | 21:09 |
*** sdake has joined #openstack-nova | 21:11 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize while deleting a server https://review.openstack.org/638268 | 21:15 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.openstack.org/638269 | 21:15 |
mriedem | dansmith: ^ that's the end of the road, let's ship it | 21:15 |
*** eharney has quit IRC | 21:30 | |
*** takamatsu_ has joined #openstack-nova | 21:31 | |
*** takamatsu has quit IRC | 21:31 | |
*** markvoelker has joined #openstack-nova | 21:33 | |
*** wolverineav has quit IRC | 21:34 | |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for cyborg access https://review.openstack.org/631242 | 21:34 |
*** wolverineav has joined #openstack-nova | 21:35 | |
artom | mriedem, heads up, we're hitting something similar to https://bugs.launchpad.net/nova/+bug/1813789 in our CI, except with revert_resize rather than evacuate | 21:36 |
openstack | Launchpad bug 1813789 in OpenStack Compute (nova) "Evacuate test intermittently fails with network-vif-plugged timeout exception" [Medium,Confirmed] | 21:36 |
artom | Ie, listening too late for an event | 21:36 |
artom | So looks like I'm fixing both of those | 21:36 |
artom | Would it make sense to file a different bug? Or just append to that one? | 21:37 |
sean-k-mooney | i would just use ^ | 21:37 |
mriedem | artom: that bug is f'ed | 21:37 |
mriedem | i think we *are* registered to wait for the event | 21:38 |
mriedem | and neutron isn't sending it | 21:38 |
*** sdake has quit IRC | 21:38 | |
sean-k-mooney | mriedem: in the down stream bug neutron is sending it before we register to recive it | 21:38 |
mriedem | need to figure out what is triggering the event then | 21:38 |
mriedem | because for evacuate, | 21:38 |
artom | mriedem, and that's what you describe in your bug as well | 21:38 |
mriedem | the driver.spawn() is registering the callback | 21:39 |
mriedem | what might be sending the event is the port binding change | 21:39 |
*** READ10 has joined #openstack-nova | 21:39 | |
*** wolverineav has quit IRC | 21:39 | |
mriedem | does that happen before driver.spawn (evacuate) and driver.finish_revert_migration? | 21:39 |
*** sdake has joined #openstack-nova | 21:39 | |
sean-k-mooney | mriedem: this is the downstream bug by the way https://bugzilla.redhat.com/show_bug.cgi?id=1678681 | 21:40 |
openstack | bugzilla.redhat.com bug 1678681 in openstack-nova "REVERT_RESIZE stuck for 300s: "VirtualInterfaceCreateException: Virtual Interface creation failed" [Medium,Assigned] - Assigned to alifshit | 21:40 |
artom | mriedem, so, would it make sense to start listening immediately after calling Neutron? | 21:40 |
sean-k-mooney | artom: i would do it just before | 21:40 |
artom | sean-k-mooney, heh, right, that makes more sense | 21:40 |
mriedem | you have to register the callback before | 21:40 |
artom | Hrmm, and we might not have the callback until we get to spawn()? | 21:41 |
mriedem | sec | 21:41 |
mriedem | artom: so for evacuate, this is what updates the port binding to point at the dest host https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L3212 | 21:42 |
mriedem | the driver spawn then happens here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L3276 | 21:42 |
mriedem | so neutron likely doesn't send a 2nd network-vif-plugged event because it's already sending one for the port binding change | 21:43 |
mriedem | that's my guess anyway | 21:43 |
artom | (mriedem, btw, I sill never stop being impressed by the speed at which you walk through code and paste the relevant bits in here) | 21:43 |
mriedem | as for the revert resize, | 21:43 |
mriedem | port binding changes back to the source here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4089 | 21:43 |
mriedem | and the guest is re-spawned (and vifs are plugged) here: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4108 | 21:43 |
mriedem | i'm fast on *this* because i've been in the bowels of it for 6 months | 21:44 |
artom | Superbowels | 21:45 |
artom | OK, my eyes are glazing over. | 21:45 |
sean-k-mooney | os with ml2 ovs. the network-vif-plugged events are sent by the nova ovs agent when it finishes wiring up the port | 21:45 |
artom | Will pick up tomorrow. | 21:45 |
*** takamatsu_ has quit IRC | 21:45 | |
sean-k-mooney | if we had not got to the point of cleaning up the ports on the souce node | 21:45 |
artom | mriedem's link will be in my IRC log for future consultation. | 21:45 |
* artom -> supper, kids, gym, sleep | 21:45 | |
sean-k-mooney | when we rebind to the source node it might send the network-vif-plugged event imiddately | 21:46 |
*** takamatsu has joined #openstack-nova | 21:46 | |
*** wolverineav has joined #openstack-nova | 21:46 | |
mriedem | artom: no need https://bugs.launchpad.net/nova/+bug/1813789/comments/2 | 21:46 |
openstack | Launchpad bug 1813789 in OpenStack Compute (nova) "Evacuate test intermittently fails with network-vif-plugged timeout exception" [Medium,Confirmed] | 21:46 |
mriedem | i put the notes in the bug | 21:46 |
artom | mriedem, cheers! | 21:47 |
*** sdake has quit IRC | 21:48 | |
*** sdake has joined #openstack-nova | 21:49 | |
mriedem | we also have the same issue in unshelve https://github.com/openstack/nova/blob/a4e6340bdcc2fda8fed41abc64ea554d9a8ab713/nova/compute/manager.py#L5087 | 21:50 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.openstack.org/638269 | 21:51 |
*** sdake has quit IRC | 21:59 | |
*** dave-mccowan has quit IRC | 22:01 | |
*** sdake has joined #openstack-nova | 22:02 | |
*** markvoelker has quit IRC | 22:07 | |
*** wolverineav has quit IRC | 22:19 | |
*** artom has quit IRC | 22:19 | |
*** wolverineav has joined #openstack-nova | 22:20 | |
*** wolverineav has quit IRC | 22:21 | |
*** wolverineav has joined #openstack-nova | 22:23 | |
*** artom has joined #openstack-nova | 22:24 | |
*** moshele has quit IRC | 22:24 | |
*** mriedem has quit IRC | 22:25 | |
*** rcernin has joined #openstack-nova | 22:27 | |
*** wolverineav has quit IRC | 22:28 | |
*** awaugama has quit IRC | 22:30 | |
*** moshele has joined #openstack-nova | 22:31 | |
*** whoami-rajat has quit IRC | 22:31 | |
*** wolverineav has joined #openstack-nova | 22:41 | |
*** cdent has quit IRC | 22:44 | |
*** wolverineav has quit IRC | 22:47 | |
*** jmlowe has joined #openstack-nova | 22:47 | |
*** wolverineav has joined #openstack-nova | 22:47 | |
*** wolverineav has quit IRC | 22:48 | |
*** wolverineav has joined #openstack-nova | 22:48 | |
*** hongbin has quit IRC | 22:51 | |
*** ttsiouts has quit IRC | 22:52 | |
*** moshele has quit IRC | 22:53 | |
*** tkajinam has joined #openstack-nova | 22:55 | |
*** wolverineav has quit IRC | 23:00 | |
*** wolverineav has joined #openstack-nova | 23:03 | |
*** markvoelker has joined #openstack-nova | 23:03 | |
*** rcernin has quit IRC | 23:06 | |
*** rcernin has joined #openstack-nova | 23:08 | |
*** wolverineav has quit IRC | 23:09 | |
*** wolverineav has joined #openstack-nova | 23:09 | |
*** mlavalle has quit IRC | 23:15 | |
*** agopi has quit IRC | 23:17 | |
*** wolverineav has quit IRC | 23:24 | |
*** wolverineav has joined #openstack-nova | 23:29 | |
*** mdbooth_ has joined #openstack-nova | 23:32 | |
*** imacdonn has quit IRC | 23:32 | |
*** imacdonn has joined #openstack-nova | 23:33 | |
*** mdbooth has quit IRC | 23:33 | |
*** wolverineav has quit IRC | 23:34 | |
*** wolverineav has joined #openstack-nova | 23:34 | |
*** markvoelker has quit IRC | 23:35 | |
*** marst has quit IRC | 23:41 | |
*** wolverineav has quit IRC | 23:46 | |
*** wolverineav has joined #openstack-nova | 23:47 | |
*** wolverineav has quit IRC | 23:48 | |
*** wolverineav has joined #openstack-nova | 23:48 | |
*** mriedem has joined #openstack-nova | 23:57 | |
mriedem | mdbooth_: for your morrow https://bugs.launchpad.net/nova/+bug/1816938 | 23:58 |
openstack | Launchpad bug 1816938 in OpenStack Compute (nova) "Misleading log message "Booting with blank volume" in nova-compute when booting from real volume" [Medium,Confirmed] | 23:58 |
aspiers | mriedem: yes, I was planning to add SEV as a capabillity rather than a trait, since that's what efried_pto suggested: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-02-08.log.html#t2019-02-08T19:58:54 Are you saying that the caps-to-traits patch can't be merged without changing the bp pointers? | 23:58 |
mriedem | aspiers: not necessarily | 23:58 |
mriedem | if it's part of an existing approved blueprint then i would probably say it's related to that | 23:58 |
*** jobewan has quit IRC | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!