Wednesday, 2018-05-16

openstackgerritMerged openstack/nova master: Add retrying to requirements.txt  https://review.openstack.org/56869200:08
*** yamamoto has joined #openstack-nova00:13
*** Tom-Tom has joined #openstack-nova00:16
*** yamamoto has quit IRC00:17
*** Tom-Tom has quit IRC00:20
*** hiro-kobayashi has joined #openstack-nova00:23
*** stakeda has joined #openstack-nova00:24
*** dklyle has quit IRC00:24
*** Nel1x has joined #openstack-nova00:28
*** tbachman has quit IRC00:31
openstackgerritMerged openstack/nova master: Fix HTTP500 error of changes-since on v2.0 API  https://review.openstack.org/56791600:31
*** dklyle has joined #openstack-nova00:32
*** linhnm has joined #openstack-nova00:33
*** yamamoto has joined #openstack-nova00:33
*** Dinesh_Bhor has joined #openstack-nova00:37
*** yamamoto has quit IRC00:40
*** germs_ has quit IRC00:48
*** dklyle has quit IRC00:53
*** yamamoto has joined #openstack-nova00:56
*** hongbin has joined #openstack-nova00:57
*** dave-mcc_ has quit IRC00:59
*** baoli has joined #openstack-nova01:00
*** yamamoto has quit IRC01:00
*** zhaochao has joined #openstack-nova01:03
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi(N-R-P): support compute node resource provider update  https://review.openstack.org/52104101:04
*** baoli has quit IRC01:05
*** phuongnh has joined #openstack-nova01:10
*** tiendc has joined #openstack-nova01:11
*** yamamoto has joined #openstack-nova01:17
*** edmondsw has joined #openstack-nova01:18
*** dklyle has joined #openstack-nova01:20
*** edmondsw has quit IRC01:22
*** yamamoto has quit IRC01:23
*** mriedem_afk has quit IRC01:27
*** dklyle has quit IRC01:29
*** r-daneel has quit IRC01:30
*** gyee has quit IRC01:38
*** yamamoto has joined #openstack-nova01:39
*** yamamoto has quit IRC01:44
*** lei-zh has joined #openstack-nova01:53
*** gyankum has joined #openstack-nova01:55
openstackgerritTsuyoshi Nagata proposed openstack/nova master: nova improvement of maximum attach volumes more than 26 vols  https://review.openstack.org/56747201:58
*** hemna_ has quit IRC01:59
*** yamamoto has joined #openstack-nova02:00
*** bkopilov has quit IRC02:00
*** dave-mccowan has joined #openstack-nova02:01
*** Tom-Tom has joined #openstack-nova02:01
*** Tom-Tom has quit IRC02:01
*** Tom-Tom has joined #openstack-nova02:01
*** trungnv has quit IRC02:03
*** phuongnh has quit IRC02:03
*** annp has quit IRC02:03
*** phuongnh has joined #openstack-nova02:03
*** annp has joined #openstack-nova02:03
*** linhnm has quit IRC02:03
*** trungnv has joined #openstack-nova02:03
*** yamamoto has quit IRC02:05
*** andreas_s has joined #openstack-nova02:15
*** andreas_s has quit IRC02:19
*** gjayavelu has quit IRC02:20
*** yamamoto has joined #openstack-nova02:21
*** nicolasbock has quit IRC02:24
*** yamamoto has quit IRC02:28
*** dave-mccowan has quit IRC02:32
*** liverpooler has joined #openstack-nova02:36
*** vladikr has quit IRC02:36
*** vladikr has joined #openstack-nova02:37
*** dpawlik has joined #openstack-nova02:42
*** yamamoto has joined #openstack-nova02:44
*** dpawlik has quit IRC02:46
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support nested alloc cands with sharing providers  https://review.openstack.org/56750802:48
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return all resources in provider_summaries  https://review.openstack.org/55804502:48
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return all nested providers in tree  https://review.openstack.org/55948002:48
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add microversion for nested allocation candidate  https://review.openstack.org/56548702:48
*** yamamoto has quit IRC02:48
*** liverpooler has quit IRC02:49
*** psachin has joined #openstack-nova02:50
*** Nel1x has quit IRC02:51
openstackgerritVu Cong Tuan proposed openstack/nova stable/queens: Update auth_url in install docs  https://review.openstack.org/56873002:55
*** hongbin has quit IRC02:57
*** Tom-Tom has quit IRC02:57
*** Tom-Tom has joined #openstack-nova02:59
*** tuanla____ has joined #openstack-nova03:00
*** yamamoto has joined #openstack-nova03:04
alex_xumelwitt: for the usecase I said at https://review.openstack.org/#/c/509042/3/specs/rocky/approved/count-quota-usage-from-placement.rst@67, does make sense? should I submit another spec for that, or you think that can mix in the same spec.03:05
*** baoli has joined #openstack-nova03:07
melwittalex_xu: your use case is about counting usage for other resource classes right? is your use case specific about quotas or is it just being able to query placement for resource X usage, in general?03:09
melwittI think either way it will be a separate spec, because if you are thinking about adding quota for other types of resources, that would be a different spec03:09
*** yamamoto has quit IRC03:09
melwittand if you are thinking about adding other types of resources to the placement usages/ response, also would be a different spec. I'm not sure if placement already returns usages for all possible resources it finds scoped under project_id/user_id or if it only handles the standard VCPU, RAM, DISK at this time03:11
*** baoli has quit IRC03:12
alex_xumelwitt: it is about quota. the more specific usecase is ironic user wants to count the specific number of baremetal node, that can be done by the count the quota for a resource class like 'CUSTOM_RC_BAREMETAL_GOLD'.03:12
*** baoli has joined #openstack-nova03:12
alex_xumelwitt: good point on the usages/ response, I assume it will return all the resources, but really should check the code to ensure that.03:15
melwittalex_xu: I see. yeah, in that case I think it would need its own spec to describe the design of dynamic quota resources, because users would be creating custom resources and the quota to go along with them. and unfortunately I expect you might get stuck behind unified limits in keystone, for the ability to express the limits for custom resource classes03:15
melwittthe other tricky part will be where/how to enforce custom resource class quota in nova. will it just be at instance create time? will that limit check iterate over all custom resource class quotas? those things would have to be designed in the spec too03:17
openstackgerritjichenjc proposed openstack/nova master: WIP: Remove support for /os-fixed-ips REST API  https://review.openstack.org/56851603:17
*** Dinesh__Bhor has joined #openstack-nova03:18
alex_xumelwitt: I'm thinking based on the current nova quota, not sure whether I needn't depend on the keystone limits.03:19
melwittalex_xu: in case you haven't seen, here's the keystone spec about hierarchical unified limits https://review.openstack.org/54080303:20
alex_xuI althought the keystone limits is another big refactor, and no one drive it yet03:20
*** annp has quit IRC03:20
alex_xumelwitt: thanks, that is what i'm looking for!03:20
*** gyankum has quit IRC03:20
melwittalex_xu: yeah ... maybe not. but I'm thinking, if there needs to be an API to create a new quota limit on-the-fly, that's something totally new in nova, but it would fit in nicely in keystone unified limits, I think03:20
*** Dinesh_Bhor has quit IRC03:21
alex_xumelwitt: for the quota check, yes, it will check at instance create time, totally same with current quota check, inside it bascially, just create a countable resource dynamically03:21
melwittyeah. I'd have to think about it more but just imagining how we have the nova.conf => quota class => quota limit in DB thing03:22
alex_xumelwitt: for the API, i'm thinking reusing the update of os-quota-set API, but let me check the keystone limit proposal03:22
melwittwe have nova.conf options for instances quota, ram quota, cpu quota. they are all "hard-coded" in a way03:22
*** Zames has joined #openstack-nova03:23
*** bkopilov has joined #openstack-nova03:23
melwittso if you were to reuse os-quota-sets, that could work but you'd go out-of-sync with how the config option part works. maybe that's okay. just thinking aloud03:23
*** baoli has quit IRC03:24
*** Zames has quit IRC03:24
alex_xumelwitt: for those resource class quota, there is no default value for them. it all starts from the user create a quota for a specific resource class on a specific project by the nova api03:24
* melwitt nods03:24
alex_xumelwitt: but yes...that make me think, the operator only can set quota for a specific project. if there are many project, that will be pain, I need to think about it...03:25
melwittyeah, just some things to keep in mind03:25
*** yamamoto has joined #openstack-nova03:27
alex_xumelwitt: thanks for tips and thoughts, let me try to work out a spec03:27
melwittnp, good luck03:27
*** yamamoto has quit IRC03:32
*** rajinir has quit IRC03:39
*** takashin has joined #openstack-nova03:39
*** vladikr has quit IRC03:40
*** vladikr has joined #openstack-nova03:41
*** links has joined #openstack-nova03:41
*** fragatina has quit IRC03:46
*** yamamoto has joined #openstack-nova03:48
openstackgerritMatt Riedemann proposed openstack/nova master: Deprecate running API services under eventlet  https://review.openstack.org/54951003:48
openstackgerritMatt Riedemann proposed openstack/nova master: DNM: Test nova-api eventlet deprecation  https://review.openstack.org/54977003:48
*** janki has joined #openstack-nova03:49
*** tbachman has joined #openstack-nova03:50
*** vladikr has quit IRC03:50
*** vladikr has joined #openstack-nova03:51
*** yamamoto has quit IRC03:54
*** tbachman has quit IRC03:54
*** tbachman has joined #openstack-nova03:56
openstackgerritTsuyoshi Nagata proposed openstack/nova master: nova improvement of maximum attach volumes more than 26 vols  https://review.openstack.org/56747203:56
*** Tom-Tom has quit IRC03:57
*** Tom-Tom has joined #openstack-nova03:58
*** Tom-Tom has quit IRC04:02
*** gyankum has joined #openstack-nova04:10
*** yamamoto has joined #openstack-nova04:11
*** fragatina has joined #openstack-nova04:11
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add tests for _get_trees_matching_all() function  https://review.openstack.org/56873704:12
*** lei-zh has quit IRC04:12
*** yamamoto has quit IRC04:15
*** yamamoto has joined #openstack-nova04:16
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add tests for _get_trees_matching_all() function  https://review.openstack.org/56873704:19
*** vladikr has quit IRC04:22
*** vladikr has joined #openstack-nova04:23
*** edmondsw has joined #openstack-nova04:32
*** brad[] has quit IRC04:33
*** awaugama has quit IRC04:37
*** dtantsur|afk has quit IRC04:38
*** jaosorior has quit IRC04:40
*** jaosorior has joined #openstack-nova04:47
*** abhishekk has joined #openstack-nova04:48
*** tbachman has quit IRC04:52
*** tetsuro_ has joined #openstack-nova04:54
*** lpetrut has joined #openstack-nova04:54
*** jaosorior has quit IRC04:54
*** vladikr has quit IRC04:55
*** vladikr has joined #openstack-nova04:55
*** tetsuro_ has quit IRC04:55
openstackgerritTsuyoshi Nagata proposed openstack/nova master: nova improvement of maximum attach volumes more than 26 vols  https://review.openstack.org/56747204:56
*** Dinesh__Bhor has quit IRC05:00
*** vladikr has quit IRC05:00
*** vladikr has joined #openstack-nova05:01
*** jaosorior has joined #openstack-nova05:02
*** udesale has joined #openstack-nova05:11
*** lei-zh has joined #openstack-nova05:11
*** vladikr has quit IRC05:17
*** vladikr has joined #openstack-nova05:17
*** sapd has quit IRC05:17
*** lpetrut has quit IRC05:22
*** ratailor has joined #openstack-nova05:23
*** diga has joined #openstack-nova05:25
*** gjayavelu has joined #openstack-nova05:25
*** Tom-Tom has joined #openstack-nova05:25
*** Eran_Kuris has joined #openstack-nova05:31
*** diga has quit IRC05:32
*** Eran_Kuris has quit IRC05:32
*** annp has joined #openstack-nova05:34
*** shaohe_feng has joined #openstack-nova05:36
*** Dinesh_Bhor has joined #openstack-nova05:42
*** lpetrut has joined #openstack-nova05:43
openstackgerritTsuyoshi Nagata proposed openstack/nova master: nova improvement of maximum attach volumes more than 26 vols  https://review.openstack.org/56747205:44
*** sridharg has joined #openstack-nova05:45
*** Eran_Kuris has joined #openstack-nova05:46
openstackgerritNaichuan Sun proposed openstack/nova master: XenAPI: update the document related to vdi streaming  https://review.openstack.org/56844405:46
*** armaan has joined #openstack-nova05:47
*** lei-zh has quit IRC05:52
*** lei-zh has joined #openstack-nova05:52
*** s1061123_ has quit IRC05:53
*** s1061123 has joined #openstack-nova05:54
*** fragatina has quit IRC05:55
openstackgerritVishakha Agarwal proposed openstack/nova master: Re-using the code of os brick cinder  https://review.openstack.org/56570305:55
*** fragatina has joined #openstack-nova05:55
*** sapd has joined #openstack-nova05:56
*** psachin has quit IRC06:03
*** lucas-afk has quit IRC06:05
*** lucasagomes has joined #openstack-nova06:07
*** armaan has quit IRC06:10
*** armaan has joined #openstack-nova06:10
*** psachin has joined #openstack-nova06:11
*** shaohe_feng_ has joined #openstack-nova06:13
*** vladikr has quit IRC06:13
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi(N-R-P): support compute node resource provider update  https://review.openstack.org/52104106:13
*** vladikr has joined #openstack-nova06:13
*** andreas_s has joined #openstack-nova06:14
*** shaohe_feng has quit IRC06:15
*** shaohe_feng_ is now known as shaohe_feng06:15
*** sidx64 has joined #openstack-nova06:16
*** vladikr has quit IRC06:19
*** vladikr has joined #openstack-nova06:19
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (2)  https://review.openstack.org/56875706:23
*** sridharg has quit IRC06:23
*** markmc has quit IRC06:26
*** do3meli has joined #openstack-nova06:27
*** Dinesh__Bhor has joined #openstack-nova06:27
*** udesale has quit IRC06:27
*** Dinesh_Bhor has quit IRC06:28
*** sidx64 has quit IRC06:29
*** udesale has joined #openstack-nova06:29
*** sidx64 has joined #openstack-nova06:33
*** dpawlik has joined #openstack-nova06:34
*** ltomasbo` is now known as ltomasbo06:34
*** sidx64_ has joined #openstack-nova06:38
*** sidx64 has quit IRC06:40
*** sidx64 has joined #openstack-nova06:42
*** sidx64_ has quit IRC06:44
*** sar has joined #openstack-nova06:44
*** vladikr has quit IRC06:49
*** edmondsw has quit IRC06:49
*** vladikr has joined #openstack-nova06:49
openstackgerritMerged openstack/nova-specs master: Complex (Anti)-Affinity Policies  https://review.openstack.org/54692506:56
*** takashin has left #openstack-nova06:56
*** slaweq has quit IRC06:56
*** udesale has quit IRC06:58
*** slaweq has joined #openstack-nova06:58
*** tuanla____ has quit IRC07:04
*** trungnv has quit IRC07:04
*** tiendc has quit IRC07:04
*** phuongnh has quit IRC07:04
*** phuongnh has joined #openstack-nova07:04
*** tuanla____ has joined #openstack-nova07:04
*** tiendc has joined #openstack-nova07:04
*** trungnv has joined #openstack-nova07:05
*** vivsoni has quit IRC07:05
*** udesale has joined #openstack-nova07:07
*** ccamacho has joined #openstack-nova07:08
*** sidx64 has quit IRC07:08
*** rcernin has quit IRC07:10
*** sidx64 has joined #openstack-nova07:11
*** sridharg has joined #openstack-nova07:12
*** sridharg has quit IRC07:12
*** sridharg has joined #openstack-nova07:12
*** damien_r has joined #openstack-nova07:16
*** tesseract has joined #openstack-nova07:17
*** sidx64 has quit IRC07:17
*** udesale has quit IRC07:19
*** lei-zh has quit IRC07:20
*** lei-zh1 has joined #openstack-nova07:20
*** sidx64 has joined #openstack-nova07:20
*** sidx64 has quit IRC07:24
*** udesale has joined #openstack-nova07:24
*** yamamoto has quit IRC07:25
*** sidx64 has joined #openstack-nova07:25
*** sahid has joined #openstack-nova07:26
*** sidx64 has quit IRC07:32
*** lpetrut has quit IRC07:33
*** sidx64 has joined #openstack-nova07:35
*** avolkov has joined #openstack-nova07:35
*** bhagyashri_s has quit IRC07:36
*** bhagyashri_s has joined #openstack-nova07:37
*** aloga has joined #openstack-nova07:39
openstackgerritNguyen Hai proposed openstack/nova-specs master: Follow the new PTI for document build  https://review.openstack.org/55180207:39
*** AlexeyAbashkin has joined #openstack-nova07:42
*** moshele has joined #openstack-nova07:45
*** yamamoto has joined #openstack-nova07:45
*** alexchadin has joined #openstack-nova07:46
*** yamamoto has quit IRC07:47
*** yamamoto has joined #openstack-nova07:47
*** jpena|off is now known as jpena07:50
*** jaypipes has quit IRC07:50
*** jaypipes has joined #openstack-nova07:51
*** amoralej|off is now known as amoralej07:53
*** mikal_ has joined #openstack-nova07:57
*** vladikr has quit IRC07:57
*** vladikr has joined #openstack-nova07:57
*** mikal has quit IRC07:59
*** dims has quit IRC07:59
openstackgerritChen Hanxiao proposed openstack/nova master: libvirt: guest: introduce blockStats instead of domain.blockStats  https://review.openstack.org/52683308:01
openstackgerritNaichuan Sun proposed openstack/nova master: XenAPI: update the document related to vdi streaming  https://review.openstack.org/56844408:01
*** dims has joined #openstack-nova08:02
*** mdbooth has joined #openstack-nova08:02
*** mgoddard has joined #openstack-nova08:03
openstackgerritTsuyoshi Nagata proposed openstack/nova master: nova improvement of maximum attach volumes more than 26 vols  https://review.openstack.org/56747208:03
*** mdnadeem has joined #openstack-nova08:04
*** vladikr has quit IRC08:04
*** vladikr has joined #openstack-nova08:05
*** armaan has quit IRC08:06
*** armaan has joined #openstack-nova08:07
*** sridharg has quit IRC08:07
*** dims has quit IRC08:07
*** dims has joined #openstack-nova08:07
*** dineshbhor__ has joined #openstack-nova08:09
*** armaan has quit IRC08:11
*** Dinesh__Bhor has quit IRC08:11
*** armaan has joined #openstack-nova08:11
*** gjayavelu has quit IRC08:14
*** tssurya has joined #openstack-nova08:15
*** edmondsw has joined #openstack-nova08:20
*** lpetrut has joined #openstack-nova08:21
*** markmc has joined #openstack-nova08:21
*** sidx64 has quit IRC08:21
*** edmondsw has quit IRC08:25
*** lpetrut has quit IRC08:25
*** jmccarthy has joined #openstack-nova08:27
*** sidx64 has joined #openstack-nova08:28
*** sidx64 has quit IRC08:29
*** sidx64 has joined #openstack-nova08:30
*** sidx64 has quit IRC08:31
*** sridharg has joined #openstack-nova08:32
*** ragiman has joined #openstack-nova08:32
*** sridhargaddam has joined #openstack-nova08:35
*** sar has quit IRC08:36
*** sridharg has quit IRC08:36
*** sar has joined #openstack-nova08:38
openstackgerritVladyslav Drok proposed openstack/nova-specs master: Allow having placement inventories with reserved value equal to total  https://review.openstack.org/56861308:39
*** derekh has joined #openstack-nova08:41
*** vladikr has quit IRC08:42
*** Tom-Tom has quit IRC08:42
*** vladikr has joined #openstack-nova08:42
*** sidx64 has joined #openstack-nova08:43
*** Tom-Tom has joined #openstack-nova08:43
*** Tom-Tom has quit IRC08:43
*** Tom-Tom has joined #openstack-nova08:43
openstackgerritBalazs Gibizer proposed openstack/nova stable/queens: placement: Fix HTTP error generation  https://review.openstack.org/56878408:45
*** wolverineav has joined #openstack-nova08:46
*** alexchadin has quit IRC08:51
openstackgerritSurya Seetharaman proposed openstack/nova stable/queens: POC: Filter/ignore NotSupportedWarning ['use_tpool'] in nova-manage  https://review.openstack.org/56878508:51
*** alexchadin has joined #openstack-nova08:51
*** cdent has joined #openstack-nova08:57
*** diga has joined #openstack-nova08:58
*** gjayavelu has joined #openstack-nova09:00
*** hiro-kobayashi has quit IRC09:01
*** abhishekk is now known as abhishekk|meetin09:04
*** links has quit IRC09:07
*** jistr has quit IRC09:09
*** jistr has joined #openstack-nova09:12
*** johanssone has joined #openstack-nova09:16
*** alexchadin has quit IRC09:18
*** sidx64 has quit IRC09:18
*** alexchadin has joined #openstack-nova09:21
*** sidx64 has joined #openstack-nova09:23
*** links has joined #openstack-nova09:23
*** sidx64 has quit IRC09:25
*** vladikr has quit IRC09:26
*** vladikr has joined #openstack-nova09:27
*** sidx64 has joined #openstack-nova09:30
*** sar has quit IRC09:32
*** vladikr has quit IRC09:32
*** vladikr has joined #openstack-nova09:32
*** sar has joined #openstack-nova09:35
*** diga has quit IRC09:35
*** sidx64 has quit IRC09:40
*** dtantsur has joined #openstack-nova09:43
*** issp has joined #openstack-nova09:47
*** vladikr has quit IRC09:48
*** vladikr has joined #openstack-nova09:49
*** issp has quit IRC09:49
*** ispp has joined #openstack-nova09:49
*** sidx64 has joined #openstack-nova09:50
*** ispp has left #openstack-nova09:50
*** issp has joined #openstack-nova09:50
*** issp has quit IRC09:50
*** ispp has joined #openstack-nova09:51
*** ispp has quit IRC09:51
*** ispp has joined #openstack-nova09:52
*** dineshbhor__ has quit IRC09:54
*** dpawlik has quit IRC09:56
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: WIP: Microversion 2.63 - Use new format policy in server group  https://review.openstack.org/56753409:56
*** dpawlik has joined #openstack-nova09:57
isppHello, Im debugging a warning Im seeing in Neutron , it seems the warning comes from this line https://gitlab.cern.ch/cloud-infrastructure/nova/blob/cern-queens/nova/network/neutronv2/api.py#L211910:00
ispp  Requesting floatingips to Neutron, in neutron I see " No controller found for: floatingips - returning response code 404: PecanNotFound" do you know if is there any bug open or is just an isolated issue? Anyway I don't know if there is a fix directly in neutron to avoid to touch nova10:00
isppSorry wrong link10:01
*** sidx64 has quit IRC10:02
isppThis is the link https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L210710:02
*** Guest17713 has quit IRC10:03
*** bkopilov has quit IRC10:05
*** vladikr has quit IRC10:06
*** edmondsw has joined #openstack-nova10:08
*** vladikr has joined #openstack-nova10:09
*** sidx64 has joined #openstack-nova10:09
*** sapd has quit IRC10:10
*** lei-zh1 has quit IRC10:11
*** sapd has joined #openstack-nova10:11
*** edmondsw has quit IRC10:13
*** wolverineav has quit IRC10:17
*** wolverineav has joined #openstack-nova10:18
*** alexchad_ has joined #openstack-nova10:21
*** phuongnh has quit IRC10:21
*** wolverineav has quit IRC10:23
*** alexchadin has quit IRC10:24
*** obre has quit IRC10:25
*** abhishekk|meetin is now known as abhishekk10:25
*** obre has joined #openstack-nova10:25
*** obre has quit IRC10:28
*** obre has joined #openstack-nova10:28
*** corvus has quit IRC10:29
*** corvus has joined #openstack-nova10:30
*** jmccarthy has quit IRC10:32
*** nicolasbock has joined #openstack-nova10:32
*** Guest17713 has joined #openstack-nova10:32
*** Guest17713 has quit IRC10:37
*** yassine has joined #openstack-nova10:37
*** yassine is now known as Guest3721110:37
*** abhishekk has quit IRC10:40
*** dave-mccowan has joined #openstack-nova10:42
*** links has quit IRC10:44
*** cdent has quit IRC10:51
*** Tom-Tom has quit IRC10:52
*** Tom-Tom has joined #openstack-nova10:53
*** pooja_jadhav has quit IRC10:54
*** nicolasbock has quit IRC10:54
*** Tom-Tom_ has joined #openstack-nova10:55
*** Tom-Tom has quit IRC10:57
*** links has joined #openstack-nova10:58
*** Tom-Tom has joined #openstack-nova10:58
*** Tom-Tom_ has quit IRC11:00
*** sidx64 has quit IRC11:02
*** janki has quit IRC11:03
*** ispp has quit IRC11:04
*** lucasagomes is now known as lucas-hungry11:04
*** sridhargaddam is now known as sridharg11:04
*** sidx64 has joined #openstack-nova11:04
*** ispp has joined #openstack-nova11:06
*** alexchad_ has quit IRC11:06
*** nicolasbock has joined #openstack-nova11:10
*** Shilpa has quit IRC11:22
*** jaosorior has quit IRC11:23
*** armaan has quit IRC11:26
*** armaan has joined #openstack-nova11:27
*** jmccarthy has joined #openstack-nova11:28
*** janki has joined #openstack-nova11:31
*** janki has quit IRC11:32
*** janki has joined #openstack-nova11:32
*** blkart has quit IRC11:32
*** cdent has joined #openstack-nova11:33
*** cdent has left #openstack-nova11:33
*** Guest37211 has quit IRC11:34
*** tuanla____ has quit IRC11:39
*** jaosorior has joined #openstack-nova11:42
*** jpena is now known as jpena|lunch11:47
*** mdbooth has quit IRC11:47
*** Guest37211 has joined #openstack-nova11:48
*** mdbooth has joined #openstack-nova11:50
*** pooja_jadhav has joined #openstack-nova11:54
*** bhagyashri_s has quit IRC11:55
*** edmondsw has joined #openstack-nova11:57
*** alexchadin has joined #openstack-nova11:57
*** wolverineav has joined #openstack-nova12:00
*** edmondsw has quit IRC12:01
*** ispp has quit IRC12:03
*** mriedem has joined #openstack-nova12:05
*** Tom-Tom has quit IRC12:06
*** Tom-Tom has joined #openstack-nova12:07
*** amoralej is now known as amoralej|lunch12:07
*** edmondsw has joined #openstack-nova12:07
*** edmondsw has quit IRC12:07
*** lucas-hungry is now known as lucasagomes12:09
*** Tom-Tom has quit IRC12:11
openstackgerritEric Fried proposed openstack/nova master: Granular requests to get_allocation_candidates  https://review.openstack.org/51581112:14
*** ispp has joined #openstack-nova12:14
*** jmccarthy has left #openstack-nova12:15
mriedemmdbooth: any chance https://blueprints.launchpad.net/nova/+spec/local-disk-serial-numbers will be updated today? if not, i'll drop it from the runway12:16
mriedemi've moved the zvm driver series out of the runway and moved https://blueprints.launchpad.net/nova/+spec/granular-placement-policy into a slot12:19
*** hshiina is now known as hshiina|afk12:21
mriedemalex_xu: can you proxy for lei zhang and say that https://review.openstack.org/#/c/560317/ is ready to go into a runway slot?12:21
mdboothmriedem: Definitely not :( Meetings.12:21
mriedemmdbooth: ok, dropped it from the runway slot; time to have a meeting about how you're in too many meetings.12:21
mriedemalex_xu: a bit worried that https://review.openstack.org/#/c/560317/ isn't getting attention from the author since the last -1 was from may 7, over a week and a half ago12:22
*** sidx64 has quit IRC12:22
mriedemnaichuans: is https://blueprints.launchpad.net/nova/+spec/vgpu-rocky ready to go into a runway slot for the xenapi changes?12:23
mriedemstarting at https://review.openstack.org/#/c/520313/12:24
alex_xumriedem: yea, I will reach him soon12:25
alex_xuvery soon by wechat :)12:26
*** sidx64 has joined #openstack-nova12:26
alex_xumriedem: I think his patch has a dependence12:26
mriedemalex_xu: ok i guess let me know if i should put that into a runway slot today, otherwise i'll put the xenapi vgpu n-r-p series in there12:26
mriedemalex_xu: efried commented that the code should be using update_provider_tree https://review.openstack.org/#/c/560317/2/nova/virt/driver.py@168412:27
mriedembut i thought that was ready12:27
*** mdbooth has quit IRC12:28
efriedmriedem: Sorry, refreshing my memory.12:28
alex_xumriedem:, yes, one of patch for the update_provider_tree, but trying to figure out which one is the dependence12:28
*** bhagyashris has joined #openstack-nova12:28
efriedmriedem: IIRC, the spec doesn't say anything about a new driver method, so it's still reasonably okay without a delta.  Let me confirm that.12:28
mriedemhttps://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/report-cpu-features-as-traits.html#work-items12:29
mriedem"Implement an interface which returns a list of traits for the CPU features in each virt driver."12:29
mriedemthat should be update_provider_tree12:29
mriedemwhich is what the 2nd work item says :)12:30
efriedmriedem: Yeah, and L114.12:30
*** dklyle has joined #openstack-nova12:30
efriedmriedem: So yeah, my -1 on the patch stands firm12:30
*** Tom-Tom has joined #openstack-nova12:32
alex_xuefried: it should be calle dby the update_provider_tree, is there anyone work on the update_provider_tree for libvirt driver?12:32
efriedalex_xu: I started this series, which bhagyashris is working on finishing up: https://review.openstack.org/#/c/560444/12:33
efriedalex_xu: bhagyashris is having trouble with the functional testing.  I've got it on my backlog to help out there, but haven't gotten to it yet.12:33
*** dpawlik has quit IRC12:34
mriedemok so i'll skip the cpu features bp this time for a runway slot since it's not ready12:34
alex_xuefried: got it, thanks12:34
alex_xumriedem: yea, thanks, let us skip this time12:34
*** sambetts|afk is now known as sambetts12:34
*** liverpooler has joined #openstack-nova12:35
*** sapcc-bot4 has quit IRC12:35
*** lei-zh has joined #openstack-nova12:35
mriedemnaichuans: i've put https://blueprints.launchpad.net/nova/+spec/vgpu-rocky into a runway slot for the xenapi driver changes12:35
mriedemhttps://etherpad.openstack.org/p/nova-runways-rocky12:35
efriedalex_xu: If you wanted to help with that, it would be welcomed.  Here's the test case bhagyashris has so far: http://paste.openstack.org/raw/720752/ (test_servers.py)12:35
*** sapcc-bot5 has joined #openstack-nova12:35
mriedemdansmith: we have a few new runway entries so should probably update the channel topic12:35
*** sidx64 has quit IRC12:35
*** edmondsw has joined #openstack-nova12:36
*** Tom-Tom has quit IRC12:36
bhagyashrisefried: Hi, i will push the patch soon12:37
efriedbhagyashris: Okay.  Sorry I haven't gotten to that yet.  Have you made progress?12:38
*** dklyle has quit IRC12:39
*** sidx64 has joined #openstack-nova12:39
*** armaan has quit IRC12:41
*** armaan has joined #openstack-nova12:42
*** jpena|lunch is now known as jpena12:43
*** pchavva has joined #openstack-nova12:44
alex_xubhagyashris: let me know if you still have question12:46
*** r-daneel has joined #openstack-nova12:47
bhagyashrisefried: no issue yes12:50
efriedgreat12:50
bhagyashrisalex_xu: thank you :)12:50
*** armaan has quit IRC12:50
*** armaan has joined #openstack-nova12:50
openstackgerritMatt Riedemann proposed openstack/nova master: Implement granular policy rules for placement  https://review.openstack.org/52442512:54
openstackgerritMatt Riedemann proposed openstack/nova master: Add granular policy rules for /resource_classes*  https://review.openstack.org/56557812:54
openstackgerritMatt Riedemann proposed openstack/nova master: Add granular policy rules for resource providers inventories  https://review.openstack.org/56866612:54
openstackgerritMatt Riedemann proposed openstack/nova master: Add granular policy rules for usages  https://review.openstack.org/56870612:54
*** sidx64 has quit IRC12:56
*** felipemonteiro has joined #openstack-nova12:59
*** sidx64 has joined #openstack-nova13:00
*** tiendc has quit IRC13:01
openstackgerritEric Fried proposed openstack/nova master: Use placement.inventory.inuse in report client  https://review.openstack.org/56863913:01
*** ratailor has quit IRC13:01
*** felipemonteiro has quit IRC13:03
openstackgerritEric Fried proposed openstack/nova master: Use GET.get instead of GET.getall in alloc-cands  https://review.openstack.org/56871313:05
openstackgerritBalazs Gibizer proposed openstack/nova master: Add requested_resources field to RequestSpec  https://review.openstack.org/56726713:06
openstackgerritBalazs Gibizer proposed openstack/nova master: Transfer port.resource_request to the scheduler  https://review.openstack.org/56726813:06
openstackgerritBalazs Gibizer proposed openstack/nova master: Make placement.lib.RequestGroup a versioned object  https://review.openstack.org/56884013:06
*** derekh has quit IRC13:12
*** derekh has joined #openstack-nova13:12
*** r-daneel_ has joined #openstack-nova13:15
*** r-daneel has quit IRC13:16
*** r-daneel_ is now known as r-daneel13:16
*** Eran_Kuris has quit IRC13:18
openstackgerritVladyslav Drok proposed openstack/nova-specs master: Allow having placement inventories with reserved value equal to total  https://review.openstack.org/56861313:18
openstackgerritMatt Riedemann proposed openstack/nova master: Deduplicate config/policy reference docs from main index  https://review.openstack.org/56484613:23
openstackgerritMatt Riedemann proposed openstack/nova master: Implement granular policy rules for placement  https://review.openstack.org/52442513:23
openstackgerritMatt Riedemann proposed openstack/nova master: Add granular policy rules for /resource_classes*  https://review.openstack.org/56557813:23
openstackgerritMatt Riedemann proposed openstack/nova master: Add granular policy rules for resource providers inventories  https://review.openstack.org/56866613:23
openstackgerritMatt Riedemann proposed openstack/nova master: Add granular policy rules for usages  https://review.openstack.org/56870613:23
*** brad[] has joined #openstack-nova13:23
openstackgerritMatt Riedemann proposed openstack/nova master: Cleanup ugly stub in TestLocalDeleteAllocations  https://review.openstack.org/56199713:24
*** amoralej|lunch is now known as amoralej13:26
*** esberglu has joined #openstack-nova13:26
openstackgerritBalazs Gibizer proposed openstack/nova master: Make placement.lib.RequestGroup a versioned object  https://review.openstack.org/56884013:27
openstackgerritBalazs Gibizer proposed openstack/nova master: Add requested_resources field to RequestSpec  https://review.openstack.org/56726713:27
openstackgerritBalazs Gibizer proposed openstack/nova master: Transfer port.resource_request to the scheduler  https://review.openstack.org/56726813:27
*** lei-zh has quit IRC13:28
*** lyan has joined #openstack-nova13:31
*** mdbooth has joined #openstack-nova13:32
*** tbachman has joined #openstack-nova13:33
*** awaugama has joined #openstack-nova13:34
*** alexchad_ has joined #openstack-nova13:36
*** alexchadin has quit IRC13:38
*** eharney has joined #openstack-nova13:39
*** baoli has joined #openstack-nova13:40
dansmithjaypipes: on this: https://review.openstack.org/#/c/568613/513:44
jaypipesdansmith: yes?13:45
dansmithjaypipes: isn't not allowing reserved=total just a bug? I feel like maybe we don't need the whole microversion dance13:45
dansmithlike someone did < instead of <= in some code somewhere?13:45
jaypipesdansmith: I feel the same way.13:45
dansmithjaypipes: does anyone not feel that way?13:45
mriedemlyarwood: you +2ed the ocata backport but not the pike one :) https://review.openstack.org/#/c/568369/13:45
dansmithmy feeling is that there is no client that would depend on total=reserved returning a 40013:46
mriedemdansmith: i brought it up when it was being discussed,13:46
mriedembecause no one knew why the capacity check was that way13:46
*** ivve has quit IRC13:47
*** bkopilov has joined #openstack-nova13:47
mriedemand its a behavior change in the api, so you kind of need to know when you can make that kind of request and expect it to be ok13:47
lyarwoodmriedem: appears I closed the tab before gerrit actually updated the review, noice!13:47
dansmithmriedem: but microversions aren't for providing bug-for-bug compatibility right? that's why we don't do one to fix a 500?13:48
mriedemthis isn't a 50013:48
dansmithI know13:48
dansmithbut really, if we do it and get a 400, we can fall back to the same behavior as today13:48
dansmithI dunno, this just seems overkill to me13:48
mriedemi don't think i ever said i was going to block this when we talked about it in -placement weeks ago,13:49
mriedemi -2ed the change this week because there is a spec up,13:49
mriedemif people don't care about the api behavior change, then whatever13:49
dansmithI would think that if this is a bug, with no microversion, that we'd backport the fix as .. a fix13:50
mriedemmeh - this doesn't even fix any real problem right now does it?13:50
mriedemthe actual bug was already fixed some other way is my understanding13:51
dansmithjust MHO, I'm not strongly against a microversion I guess, I just .. I dunno.13:51
dansmithit fixes some logic that prevents nova from setting total=reserved when that should be totally legit13:51
dansmithI dunno, I don't want to argue about it, but I definitely think total=reserved should be legit13:52
mriedemso instead of doing ^ it deletes the node inventory right?13:52
dansmithand should have always been legit13:52
mriedemduring cleaning13:52
dansmithit doesn't now,13:52
dansmithit just punts13:52
dansmithwell, wait,13:52
*** mvk has quit IRC13:52
dansmithit doesn't if there are no nodes, that's the failure/startup case I guess13:52
dansmithso maybe it's still deleting inventory currently I guess13:52
mriedemmy understanding is we worked around the problem by deleting the inventory during cleaning13:52
dansmithyeah, probably, I'm confusing the startup zero-day or ironic-is-down case, but anyway13:53
mriedemi tend to think if this isn't needed to actually fix anything, and it's a behavior change, then it's a microversion13:53
dansmithfrom the placement point of view,13:53
dansmithI feel like it's a fix to a piece of logic that was wrong13:53
dansmithsure, nova could continue to do the thing it does today to work around it, but13:54
dansmithanyway, whatever, I'd rather just get it done regardless13:54
*** udesale_ has joined #openstack-nova13:55
*** sar has quit IRC13:55
mriedemdo what y'all want, i will step aside on this one13:55
*** rmart04 has joined #openstack-nova13:57
dansmithno, it's not that big of a deal, we've got a spec, let's just roll13:57
dansmithgetting it working is the important thing13:57
*** udesale has quit IRC13:58
openstackgerritVladyslav Drok proposed openstack/nova-specs master: Allow having placement inventories with reserved value equal to total  https://review.openstack.org/56861314:00
BobBallmriedem / naichuans: Naichuan is on PRC time but yes, the XenAPI bits of the vgpu-rocky series are definitely ready for a runway slot.14:01
dansmithvdrok: see my latest feedback on your spec? if it's not clear, I can just tweak the wording myself so we can land that14:05
mriedemBobBall: yeah it's in the runway now,14:05
vdrokdansmith: yeah just noticed that, I'll add a couple sentences there, thank you14:05
mriedemi know they are in china, just dropping pings here for later reading14:05
mriedemBobBall: but thanks for following up14:06
dansmithvdrok: cool14:06
*** nicolasbock has quit IRC14:06
*** moshele has quit IRC14:07
BobBallmriedem: Thanks :) I was in a nice 2 hour meeting so didn't see the message until late14:07
*** rajinir has joined #openstack-nova14:07
openstackgerritVladyslav Drok proposed openstack/nova-specs master: Allow having placement inventories with reserved value equal to total  https://review.openstack.org/56861314:09
*** gyankum has quit IRC14:09
*** mlavalle has joined #openstack-nova14:10
dansmithmriedem: so, how is the virt driver going to know if it should return no inventory or reserved=total?14:12
dansmithor I guess we'll just require the new microversion and fail if not14:13
dansmithso nevermind14:13
mriedemyar14:13
dansmithmriedem: jaypipes: let's get this over with: https://review.openstack.org/#/c/568613/714:16
jaypipesdansmith: I'll let mriedem do that. I'm supportive of it.14:17
mriedemwill look in a bit14:18
*** r-daneel has quit IRC14:20
mriedemrandom question,14:21
mriedemon the rare days that the sun comes up here, at 6am or so, i find myself waking up early, and not wanting to get in the shower right away because everyone else is still sleeping, so i go unshowered until like mid morning, is that a normal work-from-home trajectory when summer starts?14:22
stephenfinefried: No idea what's going on here, I'm afraid. Might be worth reaching out to infra about that https://review.openstack.org/#/c/568065/14:22
efriedmriedem: How often do you shave?14:23
mriedemhells bells,14:23
mriedemyou know i'm a baby face right?14:23
mriedemtwice per week tops14:23
efriedWell, I didn't want to be impolite.14:23
*** nicolasbock has joined #openstack-nova14:23
mriedemi will shave once the teenage mustache is pronounced14:23
efriedHaving surprisingly little trouble picturing you with peachfuzz moustache.14:24
mriedemand to keep up appearances with the mom that's at the same bus stop14:24
stephenfinAnyone wanna fix an annoying warning/broken test? https://review.openstack.org/#/c/568532/14:24
*** felipemonteiro has joined #openstack-nova14:25
mriedemefried: i guess that's the pattern, whether or not my wife is at work in the morning and i have to go to the bus stop14:25
efriedmriedem: My perspective on showering is different.  I usually only shower after I train.  Which is around 8x/week these days.  But some days I don't train until evening, so showering first thing in the morning isn't a thing for me.14:25
mriedemproblem solved14:25
stephenfinefried: 8 times??14:25
efriedstephenfin: Yeah, 2x T & Th, Saturday is my day off.14:26
*** germs has joined #openstack-nova14:27
*** germs has quit IRC14:27
*** germs has joined #openstack-nova14:27
*** mvk has joined #openstack-nova14:29
*** Tom-Tom has joined #openstack-nova14:29
mriedemdansmith: vdrok: jaypipes: +W14:29
jaypipesthx14:30
dansmithwhere's the code patch for it?14:30
vdrokThank you folks for reviewing this so fast!14:30
mriedemhttps://review.openstack.org/#/c/564838/14:31
*** germs has quit IRC14:32
bauzasmriedem: if you wanna know my life, I take shower before kids wake up, or then I'm done14:36
bauzasmriedem: and given I need to taxi them to the school every morning, I guess other parents wouldn't like that14:36
bauzassmelling is not an option14:36
*** r-daneel has joined #openstack-nova14:38
*** felipemonteiro_ has joined #openstack-nova14:41
*** felipemonteiro has quit IRC14:44
*** Alexey_Abashkin has joined #openstack-nova14:44
*** felipemonteiro has joined #openstack-nova14:44
openstackgerritMerged openstack/nova master: Move image conversion to privsep.  https://review.openstack.org/55443714:45
openstackgerritMerged openstack/nova master: We don't need utils.trycmd any more.  https://review.openstack.org/55443914:45
*** AlexeyAbashkin has quit IRC14:46
*** Alexey_Abashkin is now known as AlexeyAbashkin14:46
*** felipemonteiro_ has quit IRC14:46
*** gbarros has joined #openstack-nova14:47
*** armaan has quit IRC14:47
mriedemi forgot about this until last night, but shall we deprecate running api services with eventlet? https://review.openstack.org/#/c/549510/14:48
openstackgerritMerged openstack/nova-specs master: Allow having placement inventories with reserved value equal to total  https://review.openstack.org/56861314:52
*** dklyle has joined #openstack-nova14:53
openstackgerritStephen Finucane proposed openstack/nova-specs master: Rename spec to match blueprint  https://review.openstack.org/56887014:56
*** sidx64 has quit IRC14:57
*** ispp has quit IRC14:57
*** links has quit IRC14:58
bauzasmriedem: please, yes15:00
bauzas+215:00
bauzaswe already signaled since pike, so let's send another batsignal now15:01
*** sidx64 has joined #openstack-nova15:02
*** sridharg has quit IRC15:03
*** hongbin has joined #openstack-nova15:04
openstackgerritStephen Finucane proposed openstack/nova master: Simplify instance name generation  https://review.openstack.org/51657315:05
*** ispp has joined #openstack-nova15:05
*** dklyle has quit IRC15:12
openstackgerritEric Fried proposed openstack/nova master: Debug logs for allocation_candidates filters  https://review.openstack.org/56871215:15
jrollefried: what do you train for? running or?15:16
*** wwriverrat has joined #openstack-nova15:16
efriedjroll: I own & run a Brazilian jiu jitsu school15:17
jrollah, neat :)15:17
*** dklyle has joined #openstack-nova15:18
efried7 of those 8 are me leading class (and sparring with my students).  The last one is me going to my mothership to receive instruction.15:18
*** dklyle has quit IRC15:24
*** dklyle has joined #openstack-nova15:26
*** ispp has quit IRC15:27
openstackgerritMatt Riedemann proposed openstack/nova master: Remove deprecated monkey_patch config options  https://review.openstack.org/56888015:29
*** hemna_ has joined #openstack-nova15:29
*** andreas_s has quit IRC15:30
*** andreas_s has joined #openstack-nova15:30
*** dklyle has quit IRC15:31
*** gyankum has joined #openstack-nova15:39
openstackgerritMatt Riedemann proposed openstack/nova master: Remove deprecated monkey_patch config options  https://review.openstack.org/56888015:40
*** hemna_ has quit IRC15:42
*** hemna_ has joined #openstack-nova15:43
*** andreas_s has quit IRC15:44
openstackgerritMerged openstack/nova master: PowerVM Driver: Snapshot  https://review.openstack.org/54302315:47
*** andreas_s has joined #openstack-nova15:49
mriedemefried: maybe you have input on this? https://review.openstack.org/#/c/549053/15:49
efriedmriedem: I was going to let esberglu answer.  If that doesn't happen fairly soon, I'll jump in.15:50
openstackgerritZack Cornelius proposed openstack/nova master: Implement file backed memory for instances in libvirt  https://review.openstack.org/56787615:50
efriedmriedem: Big picture, we do use some of those capability bits to set the respective ones on the driver itself - they're different depending on which disk driver you're using - and others internally to figure out whether we can do certain things.15:51
openstackgerritZack Cornelius proposed openstack/nova-specs master: Libvirt file backed memory  https://review.openstack.org/56370415:51
*** rmart04 has quit IRC15:52
efriedmriedem: But I haven't dug in to see whether that logic truly exists yet in the in-tree incarnation.15:53
*** janki has quit IRC15:53
mriedemi just figured if you have an abc parent class with methods/properties that by default raise NotImplementedError, those should be marked as abstract methods/properties15:53
* mriedem tends to think like java interfaces and ABCs15:54
*** sidx64 has quit IRC15:54
*** damien_r has quit IRC15:54
mriedemi.e. i think the point is that the subclass won't instantiate unless it implements those methods15:54
openstackgerritBalazs Gibizer proposed openstack/nova master: Add request_spec.RequestGroup versioned object  https://review.openstack.org/56884015:56
openstackgerritBalazs Gibizer proposed openstack/nova master: Add requested_resources field to RequestSpec  https://review.openstack.org/56726715:56
openstackgerritBalazs Gibizer proposed openstack/nova master: Transfer port.resource_request to the scheduler  https://review.openstack.org/56726815:56
mriedemlbragstad: policy question for you on https://review.openstack.org/#/c/568706/4/nova/api/openstack/placement/handlers/usage.py@93 - this api is defined as https://developer.openstack.org/api-ref/placement/#list-usages15:56
mriedemand takes a required project_id query string parameter15:56
mriedemright now our default rule uses check string role:admin15:57
mriedembut thinking about admin_or_owner, would it make more sense if the target to the policy check is the project_id from the query param?15:57
*** fragatina has quit IRC15:57
mriedemnote placement doesn't have an admin_or_owner rule defined because most resources in placement don't have projects/users associated with them15:58
*** andreas_s has quit IRC15:58
lbragstadmriedem: so - it's safe to assume placement is mostly made up of system level resources?15:58
mriedemor, i haven't gotten to the ones yet that do, like https://developer.openstack.org/api-ref/placement/#list-allocations15:58
mriedemwell, usages and allocations are per-consumer15:58
mriedemand a consumer for now has a project/user (instance records, migrations, etc)15:58
lbragstadthat makes sense15:59
mriedemi think a volume in cinder at some point would be a resource provider consumer15:59
lbragstadbut usages and allocations are per project in some cases and per user in others, right?15:59
lbragstad(e.g. a user can have 5 ssh keys)16:00
mriedemwell, we always create them using the instance.project_id and instance.user_id i think16:00
lbragstadah16:00
mriedemexcept i'm not sure if we pass user_id in all cases, sec16:00
efriedmriedem: oh, the abstract business, okay.  Yeah, I understand, and yeah, abc is kind of a retrofit in python, not really any different behavior-wise from raising NotImplementedError.  But we can probably clean that up if it's a thing for you.16:00
lbragstadok - i always thought that project_id was safe to assume in all cases (since pretty much everything requires a project scoped token today)16:01
*** do3meli has quit IRC16:01
*** andreas_s has joined #openstack-nova16:01
*** ragiman has quit IRC16:01
mriedemyes we always pass project_id,16:02
gibimelwitt: I cannot make it to the tomorrow's nova team meeting so I cannot chair it.16:02
mriedemand during scheduling we always pass user_id too, i just knew we had something different about how nova does that https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L84216:02
melwittgibi: k, np. thanks for the heads up16:02
*** udesale_ has quit IRC16:02
mriedemlbragstad: yeah so allocations will have project_id and user_id, and /usages response is built based on the allocations data i believe16:03
lbragstadmriedem: so - based on the fact that project_id is always required when calling list-usages, i think it's safe to say that is a project-specific API16:03
lbragstad(not sure if that was your question)16:03
lbragstadbut i would set scope_types on that to be project specific16:03
* mriedem reads https://docs.openstack.org/oslo.policy/latest/user/usage.html?highlight=scope_types#setting-scope16:04
lbragstadso - that's interesting thoguh16:04
lbragstadif a system administrator wants to set the usage of a project, should they be able to?16:05
lbragstada project administrator should be able to set the usage of _their_ project16:05
lbragstadso, in the second case, you'd need to make sure context.project_id and query_param.project_id match16:05
*** itlinux has joined #openstack-nova16:05
lbragstadotherwise, if you just base things on the role assignment, you might open yourself up to allowing them to set usage for projects they have no authorization on16:06
*** sahid has quit IRC16:06
openstackgerritVladyslav Drok proposed openstack/nova master: Placement: allow to set reserved value equal to total for inventory  https://review.openstack.org/56483816:06
lbragstadthe check for system administrators is a bit more loose16:06
efriedmriedem: Do you need to remove the comment at the top of nova/debugger.py?16:06
*** andreas_s has quit IRC16:06
lbragstadif context.system_scope and context.role == policy.check_str then update the usage with the project id in the query parameter16:07
mriedemlbragstad: the usages stuff is all read-only, like a view table kind of, but yeah admins could change usage by modifying allocations for a given project/user16:07
*** mdbooth has quit IRC16:07
*** alexchad_ has quit IRC16:07
lbragstadmriedem: imo (which could be wrong), the ability to set that kind of stuff should be system administrator territy16:08
lbragstadterritory*16:08
mriedemefried: this? # NOTE(markmc): this is imported before monkey patching in nova.cmd16:08
mriedem# so we avoid extra imports here16:08
mriedemefried: that's talking about eventlet monkey patching16:08
efriedmriedem: Yes.  Wasn't sure if that referred to the same monkey patching you're axing.16:08
efriedokay, cool.16:08
mriedemnot "hack features into nova"16:08
openstackgerritVladyslav Drok proposed openstack/nova master: Placement: allow to set reserved value equal to total for inventory  https://review.openstack.org/56483816:08
mriedemnova/cmd/__init__.py monkey patches eventlet16:08
mriedemer whatever, you get it16:09
efried+A16:09
*** jmlowe has quit IRC16:09
mriedemrhNKA16:09
mriedemHA16:09
mriedem*thanks16:09
mriedemlbragstad: ok, you've gone over my head, but i haven't gotten to POST and PUT for allocations yet16:10
mriedemalso, where are scope types defined? keystone?16:10
*** efried is now known as efried_rollin16:10
lbragstadthey are defined at the service16:10
lbragstadtechnically in the policy rules16:10
mriedemusing a config option?16:10
mriedemoh16:10
mriedemhttps://docs.openstack.org/oslo.policy/latest/user/usage.html?highlight=scope_types#setting-scope doesn't tell me anything about that16:11
lbragstadbut they should correspond to the different token scopes you can get from keystone16:11
lbragstad" During enforcement, the information in scope_types is compared to the scope of the token used in the request."16:11
mriedemand the token scopes from keystone, are those a finite hard-coded list or per deployment?16:11
lbragstadnope - a project scoped token and a system scoped token should exist in every deployment16:11
mriedemright, let me ask this way: if i set scope_types on a rule in code, how do i know what a valid scope type is? foo bar baz?!16:12
mriedemis that doc'ed somewhere?16:12
*** fragatina has joined #openstack-nova16:12
* lbragstad digs16:12
mriedemhttps://docs.openstack.org/keystoneauth/latest/api/keystoneauth1.access.html?highlight=scope#keystoneauth1.access.access.AccessInfo.scoped16:13
lbragstadhttp://specs.openstack.org/openstack/oslo-specs/specs/queens/include-scope-in-policy.html16:13
*** andreas_s has joined #openstack-nova16:13
*** edmondsw has quit IRC16:15
mriedemso looks like scope_types can include project, system, domain, trust, right?16:15
lbragstadtechnically - trust's are useless without projects and must include a project, so trust-scoped tokens are essentially project scoped16:16
lbragstad(the usability is weird...)16:16
lbragstadideally, just 'project' and 'system' for now16:16
lbragstad*maybe* 'domain' in the future16:16
mriedemso would it be fair to put something into either https://docs.openstack.org/oslo.policy/latest/user/usage.html?highlight=scope_types#setting-scope or the "enforce_scope" config option help saying, "these are the valid scope types and what they mean"?16:17
mriedemor at least link to some other doc that defines the valid scope types16:17
lbragstad++16:17
lbragstadyeah - that was probably an oversight on my part16:17
lbragstadand probably a doc bug16:18
mriedemi can report it, but where? oslo.policy?16:18
*** andreas_s has quit IRC16:18
lbragstadyeah - oslo.policy16:18
*** edmondsw_ has joined #openstack-nova16:18
lbragstadsince projects will probably see if there before they dig into keystone docs if they're using DocumentedRuleDefault or RuleDefault objects16:19
mriedemyeah16:19
mriedemhttps://bugs.launchpad.net/oslo.policy/+bug/177162116:19
openstackLaunchpad bug 1771621 in oslo.policy "Documentation for scope_types doesn't mention what the valid scope types are" [Undecided,New]16:19
lbragstadsweet - i can get that fixed today16:20
mriedemso if i set scope_types=['project'] for /usages, that means a system-scope token or a token scoped to the project in the target for the check has access?16:20
mriedemi'm trying to think about admin_or_owner terms here16:21
lbragstadyeah - scope_types handles that mapping16:21
mriedembut that also means the project_id from the query param needs to be in the target to the enforce() call?16:21
lbragstadif you set 'project' as a scope type for a policy, the policy engine will make sure the token used to make that request is project-scoped16:21
mriedembecause if i'm using a token from project A and doing GET /usages?project_id=B16:21
mriedemi shouldn't be able to right?16:22
openstackgerritStephen Finucane proposed openstack/nova-specs master: Add 'numa-aware-vswitches' spec  https://review.openstack.org/54129016:22
lbragstadcorrect, that would be a violation of the authorization we have with project role assignments16:22
mriedemok, because the way i have the check for that right now is it just passes in the user request context,16:22
mriedemso it's going to say, "you have a token for project A and you're checking project A, so sure, lgtm"16:22
mriedemright?16:22
lbragstadyes.. that's what you need, but sometimes it's easier to just ask oslo.policy to check that the token is scoped to the proper entity and leave the context.project_id == query_param.project_id check to the nova code16:23
*** edmondsw_ has quit IRC16:23
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: DiskAdapter parent class  https://review.openstack.org/54905316:24
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk  https://review.openstack.org/54930016:24
lbragstadoslo.policy should make sure the token used matches the scope_types and that the check_str passes16:24
mriedem"leave the context.project_id == query_param.project_id check to the nova code"16:24
esberglumriedem: Added the abstract tags and responded to your other comments ^16:24
mriedemi don't know that we explicitly do that in our apis16:24
lbragstadright... and that's fine16:24
mriedemwe probably do enforce that in things like DB APIs that query based on the context16:25
lbragstadbecause openstack always kinda operated like that16:25
mriedemmodel_query16:25
mriedemesberglu: thanks16:25
*** zhaochao has quit IRC16:25
lbragstadideally, in the future, you might want to consider a layer that does some validation like that16:25
stephenfinmriedem, dansmith: Posted updates to that numa-aware-vswitch spec. Think I might need some input regarding how I'm storing the information for use in the scheduler and resource tracker16:25
lbragstadmaking sure the resource controlled by nova falls within the authorization context set by the token16:25
mriedemstephenfin: we might want to jump on a hangout for that16:25
mriedemneed to understand your work items to know how we should store data and pass it around16:26
stephenfinmriedem, dansmith: It's probably best to look at what I have done and suggest why I shouldn't have done that https://review.openstack.org/#/c/564449/3 https://review.openstack.org/#/c/564452/316:26
stephenfinmriedem: Yeah, that wouldn't be a bad idea. I can't do this evening though :(16:26
mriedemstephenfin: tomorrow morning after the nova meeting?16:27
mriedemwell, evening for you16:27
*** germs has joined #openstack-nova16:28
*** germs has quit IRC16:28
*** germs has joined #openstack-nova16:28
stephenfinmriedem: dansmith and I have our team meeting then. I can do any time before16:28
dansmithI can't do before16:28
dansmithbut could do after-after16:28
mriedemi'm free tomorrow, depends on stephen's hard drop everything and leave the office time :)16:28
stephenfinHeh, and I can't do after-after (tag rugby game to play)16:28
mriedemsee!16:28
*** gyee has joined #openstack-nova16:29
dansmithwe'll all also be in YVR16:29
stephenfinaaaand I'm gone to Vancouver Friday AM16:29
mriedemstephenfin, see, you need to start a family, give up on friends, and confine yourself to your desk16:29
stephenfindansmith: That would work. Don't imagine it'll take long16:29
mriedemstart working on your sweet sweet paunch16:29
mriedemyeah we can punt to YVR...16:29
*** mdnadeem_ has joined #openstack-nova16:30
*** moshele has joined #openstack-nova16:30
stephenfinAye, but if efried_rollin can fit in 8 sessions a week, I should probably try fit in a tag game16:30
stephenfinmriedem: Sweet16:30
* stephenfin also rolls16:30
*** felipemonteiro has quit IRC16:31
*** mdnadeem has quit IRC16:31
*** fragatina has quit IRC16:32
*** germs has quit IRC16:32
mriedemefried_rollin: esberglu: +2 on https://review.openstack.org/#/c/549053/16:34
*** itlinux has quit IRC16:36
esberglumriedem: ack, tx for review16:36
cfriesenstephenfin: tag rugby?  that's not as much fun. :)16:36
*** ccamacho has quit IRC16:37
*** felipemonteiro has joined #openstack-nova16:38
openstackgerritMatt Riedemann proposed openstack/nova master: Add granular policy rules for usages  https://review.openstack.org/56870616:39
*** tssurya has quit IRC16:42
*** felipemonteiro has quit IRC16:45
*** links has joined #openstack-nova16:54
*** felipemonteiro has joined #openstack-nova16:56
*** fragatina has joined #openstack-nova16:58
*** fragatina has quit IRC16:58
*** dtantsur is now known as dtantsur|afk16:58
*** mdnadeem_ has quit IRC16:59
lbragstadmriedem: let me know if this helps https://review.openstack.org/#/c/568901/17:00
*** fragatina has joined #openstack-nova17:01
*** derekh has quit IRC17:01
lbragstadit's rough - but it might also be beneficial to add in a section on how the service is responsible for checking the scope of the resource in the request against the token being used, and how that differs from the scope_types check17:02
*** fragatina has quit IRC17:02
*** fragatina has joined #openstack-nova17:02
*** felipemonteiro has quit IRC17:03
*** felipemonteiro has joined #openstack-nova17:04
*** ralonsoh has joined #openstack-nova17:04
*** ralonsoh has quit IRC17:04
*** germs has joined #openstack-nova17:04
*** germs has quit IRC17:04
*** germs has joined #openstack-nova17:04
*** mgoddard has quit IRC17:04
*** germs has quit IRC17:04
*** germs has joined #openstack-nova17:05
*** germs has quit IRC17:05
*** germs has joined #openstack-nova17:05
*** germs has quit IRC17:05
*** germs has joined #openstack-nova17:06
*** germs has quit IRC17:06
*** yamamoto has quit IRC17:07
*** germs has joined #openstack-nova17:07
*** yamamoto has joined #openstack-nova17:08
mriedemlbragstad: thanks, in a tab, will look in a bit17:09
lbragstad[m]mriedem: cool, thanks for bringing it up17:10
*** jpena is now known as jpena|off17:11
*** itlinux has joined #openstack-nova17:12
*** psachin has quit IRC17:14
*** gjayavelu has quit IRC17:16
*** links has quit IRC17:16
*** AlexeyAbashkin has quit IRC17:16
*** gbarros has quit IRC17:17
*** amoralej is now known as amoralej|off17:25
*** tesseract has quit IRC17:27
*** mvk has quit IRC17:27
*** imacdonn has quit IRC17:30
*** imacdonn has joined #openstack-nova17:31
*** gbarros has joined #openstack-nova17:34
*** mgoddard has joined #openstack-nova17:45
melwittdansmith: would you please update the topic with the new runways https://etherpad.openstack.org/p/nova-runways-rocky17:48
mriedemjaypipes: dansmith: i went over the mirror aggregates to placement change https://review.openstack.org/#/c/553597/ - think we just need to determine what to do about safe_connect usage in there and how idempotent we should be17:48
melwitt*channel topic17:48
dansmithyeah sorry17:48
*** ChanServ sets mode: +o dansmith17:48
melwittthanks mriedem for swarpping the runways17:48
melwittswapping17:49
mriedemnp17:49
dansmithum which is the powervm one?17:49
dansmithlooks like multiple specs17:49
dansmithbut just powervm-localdisk now?17:49
melwittit's multiple blueprints. they used to be in one and were asked to split them into specless bps, IIRC17:50
melwittone for each parity thing. so it's a little weird17:50
jaypipesthx mriedem17:50
*** dansmith changes topic to "Current runways: powervm-localdisk / granular-placement-policy / vgpu-rocky -- This channel is for Nova development. For support of Nova deployments, please use #openstack."17:50
*** ChanServ sets mode: -o dansmith17:51
mriedemi'll also push a docs change for the rocky requirement in nova-api to have placement configured for things like local delete and deleting compute services17:51
mriedemthose are idempotent today but you'll get warnings in the logs if placement isn't configured for nova-api17:52
melwittoh and powervm-vscsi is blocked on CI coverage so powervm-localdisk is the only one left17:53
melwittderp17:53
mriedemesberglu: powervm ci seems to be unwell http://184.172.12.213/00/549300/27/check/nova-in-tree-pvm/03c26c0/logs/console.txt.gz17:58
*** lyan has quit IRC17:58
mriedemm echo 'Didn'\''t find service registered by hostname after 60 seconds'17:58
mriedemi believe that timeout is configurable now if you need to bump it17:59
*** jmlowe has joined #openstack-nova17:59
mriedemhttp://git.openstack.org/cgit/openstack-dev/devstack/tree/lib/nova#n106617:59
openstackgerritMatt Riedemann proposed openstack/nova master: Use RequestSpec.user_id in scheduler.utils.claim_resources  https://review.openstack.org/56891718:02
*** gabor_antal has quit IRC18:04
esberglumriedem: Not a timeout, legit failure for the service to come up http://184.172.12.213/53/549053/18/check/nova-in-tree-pvm/9c1c445/logs/n-cpu.txt.gz18:06
mriedemoh nice18:07
esberglumriedem: I thought https://review.openstack.org/#/c/549053/18/nova/virt/powervm/disk/driver.py@64 should make @abstractproperty accessible?18:07
esbergluWhat am I missing18:07
mriedem@abc.abstractproperty18:07
mriedemhttps://docs.python.org/2/library/abc.html#abc.abstractproperty18:07
mriedemi think anyway18:07
*** moshele has quit IRC18:08
esberglumriedem: I guess I misunderstood add_metaclass. New patch incoming18:08
mriedemyeah unit tests and pep8 failed in https://review.openstack.org/#/c/549053/18:09
*** felipemonteiro has quit IRC18:10
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: DiskAdapter parent class  https://review.openstack.org/54905318:14
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk  https://review.openstack.org/54930018:14
*** vladikr is now known as vladikr_brb18:19
*** sambetts is now known as sambetts|afk18:19
*** gjayavelu has joined #openstack-nova18:20
openstackgerritMatt Riedemann proposed openstack/nova master: Update nova-status and docs for required placement 1.24  https://review.openstack.org/56892318:23
*** gyankum has quit IRC18:24
openstackgerritMatt Riedemann proposed openstack/nova master: Update nova-status and docs for required placement 1.24  https://review.openstack.org/56892318:25
openstackgerritMatt Riedemann proposed openstack/nova master: Update placement upgrade docs for nova-api dependency on placement  https://review.openstack.org/56892518:31
mriedemesberglu: hmm http://logs.openstack.org/53/549053/19/check/openstack-tox-py27/c882f7f/testr_results.html.gz18:33
esberglumriedem: Guess it's time to figure out why I can't run tox locally18:33
mriedemself.st_adpt = disk_dvr.DiskAdapter(None, None)18:34
mriedemyour test is trying to instantiate the abc18:34
*** felipemonteiro has joined #openstack-nova18:35
mriedemso either just leave that in the test for SSPDiskAdapter,18:36
mriedemor make a little fake DiskAdapter subclass for your generic base class tests?18:36
*** tojuvone has quit IRC18:46
*** tojuvone has joined #openstack-nova18:46
*** jmlowe has quit IRC18:47
openstackgerritMerged openstack/nova master: Debug logs for allocation_candidates filters  https://review.openstack.org/56871218:54
*** edmondsw has joined #openstack-nova18:57
*** jmlowe has joined #openstack-nova18:59
dansmithmriedem: melwitt: cells meeting? I've got nothing and tssurya isn't around19:00
*** moshele has joined #openstack-nova19:00
melwittI don't have anything either19:00
mriedemnope19:01
dansmithwoot19:01
*** tbachman_ has joined #openstack-nova19:05
*** fragatin_ has joined #openstack-nova19:05
*** tbachman has quit IRC19:05
*** tbachman_ is now known as tbachman19:05
*** fragatin_ has quit IRC19:07
*** fragatin_ has joined #openstack-nova19:07
*** fragatina has quit IRC19:07
*** fragatin_ has quit IRC19:09
*** mriedem1 has joined #openstack-nova19:09
*** mriedem has quit IRC19:11
*** eharney_ has joined #openstack-nova19:12
*** eharney has quit IRC19:12
*** fragatina has joined #openstack-nova19:13
*** gbarros has quit IRC19:14
*** tbachman has quit IRC19:14
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Add additional information for z/VM spec.  https://review.openstack.org/56215419:14
mriedem1dansmith: +2 on ^ - barring some english / grammar stuff in there, it sounds like that reflects the ML thread which i think you know more about than i do19:15
*** mriedem1 is now known as mriedem19:15
*** dklyle has joined #openstack-nova19:18
*** mvk has joined #openstack-nova19:22
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: DiskAdapter parent class  https://review.openstack.org/54905319:39
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk  https://review.openstack.org/54930019:39
*** efried_rollin is now known as efried19:42
*** mgoddard has quit IRC19:43
mriedemcan we remove the 'build_instance' hook yet? https://github.com/openstack/nova/blob/7bdb7dbbddf9fcb4284d490bf315d6756f4015e7/nova/compute/manager.py#L220919:44
mriedemhooks have been officially deprecated for a couple of years now19:44
mriedemLOG.warning(_LW("Hooks are deprecated as of Nova 13.0 and "19:45
mriedem                                "will be removed in a future release"))19:45
mriedemthe issue being, because _do_build_and_run_instance has the hook, we return the build_results enum, which means when we are checking to see if the compute should be auto-disabled due to consecutive failures, we don't have any context on why the build failed https://github.com/openstack/nova/blob/7bdb7dbbddf9fcb4284d490bf315d6756f4015e7/nova/compute/manager.py#L167919:46
mriedemdansmith: ^19:46
*** yamamoto has quit IRC19:46
mriedemif we get a BuildAbortException from the bowels https://github.com/openstack/nova/blob/7bdb7dbbddf9fcb4284d490bf315d6756f4015e7/nova/compute/manager.py#L1903 we just return the 'failed' enum and consider everything fatal / misconfig even if it's not19:47
mriedem13.0 is mitaka19:48
dansmithI'm missing what the linkage with the hook is19:48
dansmith(but of course I'm fine with removing)19:48
*** david-lyle has joined #openstack-nova19:49
*** yamamoto has joined #openstack-nova19:49
dansmithmriedem: ^19:49
*** yamamoto has quit IRC19:51
mriedemhttps://bugs.launchpad.net/nova/+bug/174210219:51
openstackLaunchpad bug 1742102 in OpenStack Compute (nova) "Simple user can disable compute" [High,Confirmed] - Assigned to jichenjc (jichenjc)19:51
mriedemsee the 2nd to last comment there19:51
*** yamamoto has joined #openstack-nova19:51
*** yamamoto has quit IRC19:51
*** dklyle has quit IRC19:51
*** wolverineav has quit IRC19:52
*** slaweq has quit IRC19:52
*** slaweq has joined #openstack-nova19:52
mriedemtrying to determine context on what happens when we call _build_failed()19:52
dansmithmriedem: sorry I19:52
dansmitham totally missing what hooks has to do with anything19:52
mriedemif it's volume overquota, we don't need to count that against consecutive build failures19:52
dansmithI get that19:53
mriedemthis is where we call _build_failed() to see if we disable the service https://github.com/openstack/nova/blob/7bdb7dbbddf9fcb4284d490bf315d6756f4015e7/nova/compute/manager.py#L220919:53
mriedemat that point, we have 0 context on the actual exception that occurred19:53
mriedemso if i wanted to inspect the BuildAbortException let's say to see if it was a volume overquota issue, i can't do that19:53
dansmithwhat does that have to do with hooks?19:54
mriedemi can't do that because, except for one base64 decode error exception, _do_build_and_run_instance doesn't raise exceptions19:54
mriedem_do_build_and_run_instance only returns build_results.* enums which are there for hooks19:54
mriedemhttps://github.com/openstack/nova/blob/7bdb7dbbddf9fcb4284d490bf315d6756f4015e7/nova/compute/manager.py#L220919:54
mriedemat least that's my understanding,19:55
mriedemso what i want is for _do_build_and_run_instance to raise it's actual failure,19:55
mriedemso we can inspect it up the stack in _build_failed()19:55
dansmithyou know you're not actually linking me to _do_build_and_run_instance right?19:55
mriedemwhich means breaking the "return build_results.FAILED" contract in _do_build_and_run_instance which is there for hooks19:55
mriedemsorry, https://github.com/openstack/nova/blob/7bdb7dbbddf9fcb4284d490bf315d6756f4015e7/nova/compute/manager.py#L178819:55
mriedemthis is where we call _build_failed() https://github.com/openstack/nova/blob/7bdb7dbbddf9fcb4284d490bf315d6756f4015e7/nova/compute/manager.py#L175219:56
*** eharney_ is now known as eharney19:56
dansmithsee, I never connected hooks with those build result values19:57
*** slaweq_ has joined #openstack-nova19:57
*** slaweq has quit IRC19:57
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: DiskAdapter parent class  https://review.openstack.org/54905319:58
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk  https://review.openstack.org/54930019:58
dansmithmriedem: what makes you think that those are there for the hooks? git history?19:58
dansmiththat said, I don't care at all about breaking that contract as you know, nor removing it19:58
dansmithhowever,19:58
mriedemi think that's what alaski told me they were for years ago when i asked19:58
dansmithI'm not sure that unwinding all of that is a huge benefit,19:58
dansmithand I'd say we just need another build result that is, like you said "failed, but not my fault"19:59
dansmiththat's kindof a large change to alter all that exception handling19:59
dansmithnot that it's great, but I just wouldn't want to go refactoring it myself19:59
dansmithhttps://review.openstack.org/#/c/106482/20:00
dansmithso that's why I guess, but I had never made that connection20:00
*** sapd_ has joined #openstack-nova20:00
*** jmlowe has quit IRC20:00
*** fanzhang has quit IRC20:01
*** gjayavel_ has joined #openstack-nova20:01
dansmiththat is a lot more recent than I would have thought20:01
*** fanzhang has joined #openstack-nova20:01
mriedemyeah, kilo20:01
mriedemall the andrews were in on that one20:01
mriedemok so i'll hack something nasty up quick and see what it looks like using the existing build_results gorp with a new enum20:02
dansmiththat was basically 2015, mitaka was early 201620:02
*** gjayavelu has quit IRC20:03
*** sapd has quit IRC20:03
mriedemgerrit says it's in kilo-eol20:05
dansmithI know, it was deprecated in mitaka right?20:06
*** tbachman has joined #openstack-nova20:09
*** pchavva has quit IRC20:10
*** liverpooler has quit IRC20:11
*** tssurya has joined #openstack-nova20:11
*** yamamoto has joined #openstack-nova20:11
mriedemhooks in general were deprecated in mitaka20:13
mriedemhttps://github.com/openstack/nova/commit/7be56442703d071c9256267abb8acfabae642a1a20:14
mriedemvia mr dague20:14
mriedemwhen he was on the "burn all extension points with fire" crusade20:14
*** andreas_s has joined #openstack-nova20:15
dansmithyeah20:16
*** yamamoto has quit IRC20:16
*** moshele has quit IRC20:17
*** andreas_s has quit IRC20:19
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Don't count volume over quota when disabling compute  https://review.openstack.org/56895320:21
mriedemdansmith: ok here is the hack a mole WIP ^20:21
dansmithcommented20:24
dansmiththere are other things, like failing to verify an image signature20:25
dansmithwhich probably shouldn't count20:25
dansmithsince you could probably make that happen externally20:25
*** gbarros has joined #openstack-nova20:26
mriedemoh there are a buttload of things20:26
mriedemthere was one i saw earlier about hitting a compute with device tags but the virt driver doesn't support devices tags (so anything besides libvirt, hyperv and xen)20:27
dansmithhrm yeah20:27
mriedemmultiattach is in the same boat20:27
mriedemthat's why we added a policy rule on the cinder side to disable being able to make those types of volumes20:27
mriedemif you're purely non-libvirt20:27
mriedemor hell, if you're not using any of the supported volume types for multiattach, which in queens was only 3 out of like the 400 available cinder backends20:28
mriedemmnaser: how much do you hate this? https://review.openstack.org/#/c/568953/ - realizing we should still be doing a volume quota check in conductor, but that could still pass during a race20:34
*** yamamoto has joined #openstack-nova20:34
mriedemdansmith: you didn't pick up on the name of my villian in the commit message20:34
*** osnaya has joined #openstack-nova20:34
dansmithmriedem: heh, didn't even read the commit message20:35
melwittI liked it20:35
osnayaQuestion on openstack snapshot --> Is VMS (Virtual Machine Streaming) implemented in Openstack already? Is it used underneath when a snapshot and volume snapshot created?20:37
osnayawhen you take snapshot of a live VM?20:38
osnayaIs VMS (virtual machine streaming) implemented in Pike release?20:38
*** yamamoto has quit IRC20:40
mriedemjaypipes: if you have the number to Florida Man, i think i might have found him a soul mate across the boarder https://theconcourse.deadspin.com/woman-furiously-shits-on-floor-of-tim-hortons-throws-i-1826082960#_ga=2.237274304.1540633067.1526503254-529658380.152105107420:41
mriedemosnaya: the libvirt driver supports live snapshot but you have to set a config option to enable it because it's shown to be unreliable at load with older versions of libvirt20:42
mriedemosnaya: https://docs.openstack.org/nova/pike/configuration/config.html#workarounds.disable_libvirt_livesnapshot20:43
*** osnaya has quit IRC20:43
mriedembye!20:43
*** moshele has joined #openstack-nova20:44
melwittmriedem: what do you mean by "we should still be doing a volume quota check in conductor, but that could still pass during a race"? if we had a check in conductor, it could pass during a race?20:44
*** gbarros has quit IRC20:45
mriedemmelwitt: yes20:46
melwittoh, because volumes are created by compute. okay20:46
mriedemlet's say i have volume quota of 10 (default) and spawn 10 instances in 10 separate requests20:46
*** moshele has quit IRC20:46
mriedemright, not min_count=10 in a single request20:46
mriedemconductor would see usage as 0 for all 10 requests20:47
melwittyeah, I didn't know or forgot that volumes are created by compute20:47
mriedemyup - we should eventually create them in conductor but...20:47
mriedemjust like we should create ports in conductor20:47
melwittgotcha, yeah20:47
mriedemcreating volumes in conductor would also get rid of the cross_az_attach up-call i think20:47
melwittI wonder why we don't do them even earlier in the api, before conductor, that would make it so we don't get ERROR state for a quota fail20:48
mriedembecause if cross_az_attach=False, and boot from volume with an existing volume, conductor can tell the scheduler we need a host in that az or fail; if nova is going to create the volume, we can create the volume in the az of the host that the scheduler picked20:49
mriedemi used to think about creating volumes in the api, not sure why we wouldn't, we already reserve pre-existing volumes in the api20:49
mriedemwe don't create ports in the api though20:49
mriedemi think the argument against doing it in the api is it blocks the response20:49
melwittah, okay. wonder if we could just volume-update for the az case. but yeah, just thinking20:50
dansmithmriedem: yeah and volume create can be really slow20:50
mriedemvolume create is a 20220:50
mriedemso nova-api would volume create, get 202 and continue to conductor20:50
dansmithplus you want to be able to do it closer to scheduling or when you know where the instance is going to be right?20:50
mriedemif we did it in the api20:50
dansmithmriedem: right you could and poll later I guess20:50
mriedemyeah we'd still do the poll for available status in compute i think20:50
mriedembut we could catch volume over quota and az cross attach issues much earlier20:51
mriedemi think we need to do it closer to scheduling to know which az the volume and instance have to be in if cross_az_attach=False20:51
melwittyeah, I was thinking if we could do a "volume update" to set the az after a volume is created but maybe that's not a thing20:52
mriedemthat's not a thing20:52
mriedemthat would require a volume migration at least20:52
melwittguess it wouldn't be if their scheduling works like ours20:52
melwittyeah20:52
mriedemright20:52
mriedemi've only ever heard of i think 2 people that use cross_az_attach=True, and sam at nectar is always the one to reply to my questions about it in the ML20:53
*** wolverineav has joined #openstack-nova20:54
mriedemreminds me i never finished up the change for https://bugs.launchpad.net/nova/+bug/169484420:54
openstackLaunchpad bug 1694844 in OpenStack Compute (nova) "Boot from volume fails when cross_az_attach=False and volume is provided to nova without an AZ for the instance" [Medium,In progress] - Assigned to Matt Riedemann (mriedem)20:54
*** yamamoto has joined #openstack-nova20:55
*** sean-k-mooney has quit IRC20:58
*** slaweq_ has quit IRC20:59
*** slaweq has joined #openstack-nova20:59
*** yamamoto has quit IRC21:02
*** avolkov has quit IRC21:13
*** itlinux has quit IRC21:13
*** hemna_ has quit IRC21:18
*** yamamoto has joined #openstack-nova21:18
*** yamamoto has quit IRC21:23
*** sean-k-mooney has joined #openstack-nova21:25
*** tssurya has quit IRC21:27
*** dave-mccowan has quit IRC21:32
*** slaweq has quit IRC21:33
*** slaweq has joined #openstack-nova21:34
*** yamamoto has joined #openstack-nova21:39
openstackgerritMatt Riedemann proposed openstack/osc-placement master: Resource class set (v1.7)  https://review.openstack.org/51464421:39
openstackgerritMatt Riedemann proposed openstack/osc-placement master: Usages per project and user (v1.8, v1.9)  https://review.openstack.org/51464621:39
openstackgerritMatt Riedemann proposed openstack/osc-placement master: CLI allocation candidates (v1.10)  https://review.openstack.org/51464721:39
openstackgerritMatt Riedemann proposed openstack/osc-placement master: New dict format of allocations (v1.11, v1.12)  https://review.openstack.org/54281921:39
openstackgerritMatt Riedemann proposed openstack/osc-placement master: Transactionally update allocations (v1.13)  https://review.openstack.org/54667421:39
openstackgerritMatt Riedemann proposed openstack/osc-placement master: Add nested resource providers (v1.14)  https://review.openstack.org/54667521:39
openstackgerritMatt Riedemann proposed openstack/osc-placement master: Limit allocation candidates (v1.15, v1.16)  https://review.openstack.org/54804321:39
openstackgerritMatt Riedemann proposed openstack/osc-placement master: Allocation candidates parameter: required (v1.17)  https://review.openstack.org/54832621:39
openstackgerritMatt Riedemann proposed openstack/nova master: Drop API compat handling for old compute error cases  https://review.openstack.org/54625621:41
openstackgerritVladyslav Drok proposed openstack/nova master: ironic: Report resources as reserved when needed  https://review.openstack.org/51792121:41
*** dave-mccowan has joined #openstack-nova21:41
openstackgerritVladyslav Drok proposed openstack/nova master: ironic: Report resources as reserved when needed  https://review.openstack.org/51792121:41
*** mriedem is now known as mriedem_afk21:41
*** yamamoto has quit IRC21:46
*** dave-mcc_ has joined #openstack-nova21:47
*** esberglu has quit IRC21:48
*** dave-mccowan has quit IRC21:48
*** esberglu has joined #openstack-nova21:48
*** itlinux has joined #openstack-nova21:51
*** esberglu has quit IRC21:53
openstackgerritEric Fried proposed openstack/nova master: Update nova-status and docs for required placement 1.24  https://review.openstack.org/56892321:54
openstackgerritEric Fried proposed openstack/nova master: Enforce placement minimum in nova.cmd.status  https://review.openstack.org/56896521:54
*** takashin has joined #openstack-nova21:55
openstackgerritTakashi NATSUME proposed openstack/nova-specs master: Abort Cold Migration  https://review.openstack.org/33473221:57
*** vladikr_brb is now known as vladikr22:00
*** baoli has quit IRC22:03
*** baoli has joined #openstack-nova22:03
*** wolverineav has quit IRC22:05
*** burt has quit IRC22:06
*** hemna_ has joined #openstack-nova22:06
*** baoli has quit IRC22:07
*** zcorneli has joined #openstack-nova22:11
*** mchlumsky has quit IRC22:13
*** rnoriega has quit IRC22:16
*** markmc has quit IRC22:16
*** kashyap has quit IRC22:16
*** weshay has quit IRC22:17
*** mlavalle has quit IRC22:19
*** slaweq has quit IRC22:21
*** weshay has joined #openstack-nova22:22
*** yamamoto has joined #openstack-nova22:22
*** rcernin has joined #openstack-nova22:25
*** hongbin has quit IRC22:25
*** weshay has quit IRC22:26
*** rajinir has quit IRC22:28
*** yamamoto has quit IRC22:29
*** andreaf has quit IRC22:29
*** andreaf has joined #openstack-nova22:29
*** itlinux has quit IRC22:33
*** weshay has joined #openstack-nova22:34
*** felipemonteiro has quit IRC22:37
*** rnoriega has joined #openstack-nova22:37
openstackgerritMerged openstack/nova master: Remove deprecated monkey_patch config options  https://review.openstack.org/56888022:38
*** esberglu has joined #openstack-nova22:38
*** esberglu has quit IRC22:38
*** markmc has joined #openstack-nova22:41
*** kashyap has joined #openstack-nova22:42
*** yamamoto has joined #openstack-nova22:45
*** jmlowe has joined #openstack-nova22:49
*** edmondsw has quit IRC22:50
*** yamamoto has quit IRC22:51
*** felipemonteiro has joined #openstack-nova22:59
*** takashin has left #openstack-nova23:01
*** takashin has joined #openstack-nova23:02
*** yamamoto has joined #openstack-nova23:08
*** slaweq has joined #openstack-nova23:10
*** edmondsw has joined #openstack-nova23:11
*** yamamoto has quit IRC23:12
*** slaweq has quit IRC23:15
*** rnoriega has quit IRC23:16
*** markmc has quit IRC23:17
*** weshay has quit IRC23:17
*** kashyap has quit IRC23:18
*** hemna_ has quit IRC23:18
*** hemna_ has joined #openstack-nova23:19
*** kashyap has joined #openstack-nova23:20
*** rnoriega has joined #openstack-nova23:21
*** weshay has joined #openstack-nova23:21
*** markmc has joined #openstack-nova23:24
*** yamamoto has joined #openstack-nova23:29
melwittnaichuans: hi, fyi your blueprint vgpu-rocky has been added to a review runway today. please let us know if the next two weeks are not a good time for active review23:30
*** germs has quit IRC23:33
*** yamamoto has quit IRC23:33
*** germs has joined #openstack-nova23:35
*** germs has quit IRC23:35
*** germs has joined #openstack-nova23:35
openstackgerritTakashi NATSUME proposed openstack/nova master: Fix auth_url example in hypervisor-hyper-v.rst  https://review.openstack.org/56898323:40
*** moshele has joined #openstack-nova23:44
*** felipemonteiro has quit IRC23:48
*** yamamoto has joined #openstack-nova23:49
*** yamamoto has quit IRC23:56
*** tbachman has quit IRC23:58
*** baoli has joined #openstack-nova23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!