Thursday, 2018-05-17

*** tbachman has joined #openstack-nova00:02
*** felipemonteiro has joined #openstack-nova00:05
*** baoli has quit IRC00:08
*** baoli has joined #openstack-nova00:09
*** tetsuro has joined #openstack-nova00:10
openstackgerritDavid Bingham proposed openstack/nova master: Adding apply_cells to nova-manage to enable automated cells_v2 configuration.  https://review.openstack.org/56898700:11
*** yamamoto has joined #openstack-nova00:12
*** baoli has quit IRC00:14
*** felipemonteiro has quit IRC00:14
*** mriedem_afk has quit IRC00:15
openstackgerritEric Berglund proposed openstack/nova master: PowerVM snapshot cleanup  https://review.openstack.org/56898800:15
*** yamamoto has quit IRC00:16
*** liuzz has quit IRC00:17
*** liuzz has joined #openstack-nova00:19
*** gjayavel_ has quit IRC00:28
*** r-daneel has quit IRC00:29
*** Dinesh_Bhor has joined #openstack-nova00:31
*** yamamoto has joined #openstack-nova00:33
*** hiro-kobayashi has joined #openstack-nova00:34
*** david-lyle has quit IRC00:34
openstackgerritDavid Bingham proposed openstack/nova master: Adding apply_cells to nova-manage to enable automated cells_v2 configuration.  https://review.openstack.org/56898700:34
*** dpawlik has joined #openstack-nova00:35
openstackgerritTakashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller  https://review.openstack.org/34728900:35
*** yamamoto has quit IRC00:37
*** dpawlik has quit IRC00:40
openstackgerritMerged openstack/nova master: Add tests for alloc_cands with member_of  https://review.openstack.org/56139900:49
naichuansmelwitt: It OK for me to have a review. Thanks you very much00:52
*** annp has quit IRC00:53
*** trungnv has quit IRC00:53
*** annp has joined #openstack-nova00:53
*** yamamoto has joined #openstack-nova00:54
*** trungnv has joined #openstack-nova00:54
openstackgerritMerged openstack/nova master: Fix member_of with sharing providers  https://review.openstack.org/56140000:55
openstackgerritMerged openstack/nova master: Expand member_of functional test cases  https://review.openstack.org/56601100:56
melwittnaichuans: cool, thanks00:56
naichuansNp00:57
*** yamamoto has quit IRC01:00
*** phuongnh has joined #openstack-nova01:02
*** baoli has joined #openstack-nova01:05
*** tiendc has joined #openstack-nova01:06
openstackgerritNakanishi Tomotaka proposed openstack/nova master: Test Compute API in multiple cells  https://review.openstack.org/53411601:08
*** hongbin has joined #openstack-nova01:09
*** zhaochao has joined #openstack-nova01:10
*** slaweq has joined #openstack-nova01:11
*** slaweq has quit IRC01:15
*** fragatina has quit IRC01:16
*** yamamoto has joined #openstack-nova01:16
*** fragatina has joined #openstack-nova01:18
*** Nel1x has joined #openstack-nova01:19
*** fragatina has quit IRC01:19
*** liverpooler has joined #openstack-nova01:19
*** edmondsw has quit IRC01:19
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi(N-R-P): support compute node resource provider update  https://review.openstack.org/52104101:20
*** yamamoto has quit IRC01:20
*** tbachman has quit IRC01:21
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi(N-R-P): support compute node resource provider update  https://review.openstack.org/52104101:23
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi(N-R-P): support compute node resource provider update  https://review.openstack.org/52104101:25
*** hemna_ has quit IRC01:32
*** markvoelker_ has quit IRC01:34
*** markvoelker has joined #openstack-nova01:38
*** yamamoto has joined #openstack-nova01:38
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return nested providers in get_by_request  https://review.openstack.org/56711301:40
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add traits check in nested provider candidates  https://review.openstack.org/56715001:40
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support nested alloc cands with sharing providers  https://review.openstack.org/56750801:40
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return all resources in provider_summaries  https://review.openstack.org/55804501:40
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return all nested providers in tree  https://review.openstack.org/55948001:40
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add microversion for nested allocation candidate  https://review.openstack.org/56548701:40
*** namnh has joined #openstack-nova01:40
*** yamamoto has quit IRC01:44
*** lei-zh has joined #openstack-nova01:49
*** abalutoiu__ has joined #openstack-nova01:51
*** fragatin_ has joined #openstack-nova01:52
*** abalutoiu_ has quit IRC01:54
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add tests for _get_trees_matching_all() function  https://review.openstack.org/56873701:56
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return nested providers in get_by_request  https://review.openstack.org/56711301:56
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add traits check in nested provider candidates  https://review.openstack.org/56715001:56
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support nested alloc cands with sharing providers  https://review.openstack.org/56750801:56
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return all resources in provider_summaries  https://review.openstack.org/55804501:56
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return all nested providers in tree  https://review.openstack.org/55948001:57
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add microversion for nested allocation candidate  https://review.openstack.org/56548701:57
*** abalutoiu_ has joined #openstack-nova01:57
*** owalsh_ has joined #openstack-nova01:58
*** yamamoto has joined #openstack-nova02:00
*** abalutoiu__ has quit IRC02:00
*** owalsh has quit IRC02:02
*** itlinux has joined #openstack-nova02:02
*** yamamoto has quit IRC02:05
*** Dinesh_Bhor has quit IRC02:09
*** Dinesh_Bhor has joined #openstack-nova02:11
openstackgerritNaichuan Sun proposed openstack/nova master: XenAPI: update the document related to vdi streaming  https://review.openstack.org/56844402:19
*** yamamoto has joined #openstack-nova02:21
*** moshele has quit IRC02:24
*** yamamoto has quit IRC02:25
*** takashin has left #openstack-nova02:30
*** itlinux has quit IRC02:30
*** moshele has joined #openstack-nova02:32
*** Tom-Tom has quit IRC02:36
*** Tom-Tom has joined #openstack-nova02:37
*** moshele has quit IRC02:37
*** itlinux has joined #openstack-nova02:38
*** lbragstad has quit IRC02:39
*** Tom-Tom has quit IRC02:41
*** yamamoto has joined #openstack-nova02:41
*** Nel1x has quit IRC02:45
*** itlinux has quit IRC02:46
*** liverpooler has quit IRC02:46
*** yamamoto has quit IRC02:48
*** masber has quit IRC02:49
*** baoli has quit IRC02:51
*** Zames has joined #openstack-nova02:51
*** baoli has joined #openstack-nova02:51
*** dave-mcc_ has quit IRC02:52
*** masber has joined #openstack-nova02:52
*** Zames has quit IRC02:54
*** awaugama has quit IRC02:54
*** gbarros has joined #openstack-nova02:55
*** baoli has quit IRC02:56
*** hongbin has quit IRC02:56
*** bkopilov has quit IRC02:57
*** Tom-Tom has joined #openstack-nova02:58
*** Tom-Tom_ has joined #openstack-nova02:58
*** Tom-Tom has quit IRC02:58
*** psachin has joined #openstack-nova02:59
*** edmondsw has joined #openstack-nova02:59
*** yamamoto has joined #openstack-nova03:04
*** edmondsw has quit IRC03:04
*** Zames has joined #openstack-nova03:05
*** itlinux has joined #openstack-nova03:08
*** Zames has quit IRC03:08
*** yamamoto has quit IRC03:08
*** bkopilov has joined #openstack-nova03:10
*** slaweq has joined #openstack-nova03:11
*** eharney has quit IRC03:14
*** slaweq has quit IRC03:16
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver  https://review.openstack.org/52338703:17
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver  https://review.openstack.org/52765803:17
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add snapshot function  https://review.openstack.org/53424003:17
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add power actions  https://review.openstack.org/54334003:17
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add get console output  https://review.openstack.org/54334403:17
*** hongbin has joined #openstack-nova03:17
*** zcorneli has quit IRC03:20
*** baoli has joined #openstack-nova03:22
*** nicolasbock has quit IRC03:23
openstackgerritJiaJunsu proposed openstack/nova master: Remove args(os=False) in monkey_patch  https://review.openstack.org/56899903:23
*** yamamoto has joined #openstack-nova03:25
*** bkopilov has quit IRC03:29
*** yamamoto has quit IRC03:29
*** baoli has quit IRC03:30
*** itlinux has quit IRC03:34
*** sapcc-bot6 has joined #openstack-nova03:40
*** sapcc-bot5 has quit IRC03:41
openstackgerritJiaJunsu proposed openstack/nova master: Remove args(os=False) in monkey_patch  https://review.openstack.org/56899903:45
*** hongbin has quit IRC03:47
*** yamamoto has joined #openstack-nova03:47
*** udesale has joined #openstack-nova03:49
*** gbarros has quit IRC03:51
*** yamamoto has quit IRC03:53
*** vladikr has quit IRC03:56
*** masuberu has joined #openstack-nova03:56
*** vladikr has joined #openstack-nova03:56
*** gyankum has joined #openstack-nova03:59
*** masber has quit IRC04:00
*** masber has joined #openstack-nova04:02
*** masuberu has quit IRC04:05
*** yamamoto has joined #openstack-nova04:08
*** udesale has quit IRC04:10
*** lei-zh has quit IRC04:10
*** germs has quit IRC04:10
*** janki has joined #openstack-nova04:12
*** yamamoto has quit IRC04:13
*** udesale has joined #openstack-nova04:13
*** yamamoto has joined #openstack-nova04:14
*** links has joined #openstack-nova04:24
*** gyee has quit IRC04:26
*** gongysh has joined #openstack-nova04:32
*** udesale has quit IRC04:36
*** udesale has joined #openstack-nova04:37
*** tbachman_ has joined #openstack-nova04:37
*** sridharg has joined #openstack-nova04:38
openstackgerritAlex Xu proposed openstack/nova-specs master: Count quota based on resource class  https://review.openstack.org/56901104:46
alex_xumelwitt: jaypipes jroll, here is a start for quota on rc https://review.openstack.org/#/c/569011/04:47
*** edmondsw has joined #openstack-nova04:48
*** vladikr has quit IRC04:50
*** vladikr has joined #openstack-nova04:50
alex_xuKevin_Zheng: ^ also for you guys care about keystone limits I guess04:51
*** edmondsw has quit IRC04:53
*** Dinesh__Bhor has joined #openstack-nova04:59
*** Dinesh_Bhor has quit IRC04:59
*** ratailor has joined #openstack-nova05:01
*** slaweq has joined #openstack-nova05:11
*** bkopilov has joined #openstack-nova05:13
*** vladikr has quit IRC05:14
*** vladikr has joined #openstack-nova05:14
*** slaweq has quit IRC05:15
*** udesale has quit IRC05:20
*** udesale has joined #openstack-nova05:21
*** lei-zh has joined #openstack-nova05:22
*** yamamoto has quit IRC05:24
*** yamamoto has joined #openstack-nova05:25
*** udesale has quit IRC05:26
*** yamamoto_ has joined #openstack-nova05:28
*** tbachman_ has quit IRC05:28
*** yamamoto has quit IRC05:32
*** blkart has joined #openstack-nova05:36
*** Tom-Tom_ has quit IRC05:36
*** udesale has joined #openstack-nova05:43
*** slaweq has joined #openstack-nova05:47
*** liuzz has quit IRC05:47
*** liuzz has joined #openstack-nova05:48
*** vivsoni has joined #openstack-nova05:51
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add traits check in nested provider candidates  https://review.openstack.org/56715005:51
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support nested alloc cands with sharing providers  https://review.openstack.org/56750805:51
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return all resources in provider_summaries  https://review.openstack.org/55804505:51
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return all nested providers in tree  https://review.openstack.org/55948005:51
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add microversion for nested allocation candidate  https://review.openstack.org/56548705:51
*** slaweq has quit IRC05:51
*** penick has quit IRC05:53
*** bhujay has joined #openstack-nova05:55
*** penick has joined #openstack-nova05:58
*** vladikr has quit IRC06:02
*** vladikr has joined #openstack-nova06:03
*** slaweq has joined #openstack-nova06:11
*** armaan has joined #openstack-nova06:12
*** liuzz_ has joined #openstack-nova06:15
*** slaweq has quit IRC06:16
*** liuzz has quit IRC06:16
*** Dinesh__Bhor has quit IRC06:17
*** Dinesh__Bhor has joined #openstack-nova06:17
openstackgerritjichenjc proposed openstack/nova master: WIP: raise exception early  https://review.openstack.org/56902406:18
*** trinaths has joined #openstack-nova06:19
openstackgerritjichenjc proposed openstack/nova master: WIP: raise correct exception  https://review.openstack.org/56902606:19
*** liuzz_ has quit IRC06:20
*** vladikr has quit IRC06:20
*** vladikr has joined #openstack-nova06:21
*** liuzz has joined #openstack-nova06:21
*** trinaths has quit IRC06:22
*** liuzz has quit IRC06:23
*** liuzz has joined #openstack-nova06:25
*** gongysh has quit IRC06:25
*** vladikr has quit IRC06:31
*** gjayavelu has joined #openstack-nova06:31
*** sidx64 has joined #openstack-nova06:31
*** vladikr has joined #openstack-nova06:31
*** liuzz_ has joined #openstack-nova06:32
*** liuzz has quit IRC06:33
*** sidx64_ has joined #openstack-nova06:39
*** sidx64 has quit IRC06:41
*** sidx64 has joined #openstack-nova06:42
*** do3meli has joined #openstack-nova06:43
*** sidx64_ has quit IRC06:44
*** mdnadeem has joined #openstack-nova06:48
*** tssurya has joined #openstack-nova06:49
*** hiro-kobayashi has quit IRC06:54
*** gongysh has joined #openstack-nova06:55
*** ispp has joined #openstack-nova06:59
*** tesseract has joined #openstack-nova07:01
*** sahid has joined #openstack-nova07:01
*** vladikr has quit IRC07:01
*** vladikr has joined #openstack-nova07:02
*** Dinesh__Bhor has quit IRC07:02
*** ccamacho has joined #openstack-nova07:03
*** slaweq has joined #openstack-nova07:08
openstackgerritBhagyashri Shewale proposed openstack/nova master: libvirt: get_inventory => update_provider_tree  https://review.openstack.org/56044407:15
openstackgerritBhagyashri Shewale proposed openstack/nova master: libvirt: Don't report DISK_GB if sharing  https://review.openstack.org/56045907:15
*** ispp has quit IRC07:17
*** dpawlik has joined #openstack-nova07:24
*** sridharg has quit IRC07:25
*** hamdyk has joined #openstack-nova07:27
*** gongysh has quit IRC07:27
*** ispp has joined #openstack-nova07:30
*** damien_r has joined #openstack-nova07:37
*** lei-zh has quit IRC07:39
*** lei-zh has joined #openstack-nova07:40
Kevin_Zhengalex_xu: Thanks for the info, we were talk about it this morning, but I didn't have time to check the details yet.07:41
alex_xuKevin_Zheng: cool07:42
*** alexchadin has joined #openstack-nova07:44
*** jpena|off is now known as jpena07:46
*** AlexeyAbashkin has joined #openstack-nova07:47
*** ispp has quit IRC07:54
openstackgerritJiaJunsu proposed openstack/nova master: Fakelibvirt migrateToURI3 should provide args according to libvirt doc  https://review.openstack.org/56904707:54
*** amoralej|off is now known as amoralej07:54
hamdykHi, I need an os-brick release with few commits related to NVMeOF, how can I do that ?07:55
openstackgerritBalazs Gibizer proposed openstack/osc-placement master: Fix error message asserts in functional test  https://review.openstack.org/56904807:55
*** ragiman has joined #openstack-nova07:58
*** mgoddard has joined #openstack-nova08:05
*** yamamoto_ has quit IRC08:10
*** avolkov has joined #openstack-nova08:10
*** yamamoto has joined #openstack-nova08:10
*** rcernin has quit IRC08:12
*** alexchad_ has joined #openstack-nova08:16
*** gongysh has joined #openstack-nova08:18
*** alexchadin has quit IRC08:18
*** ispp has joined #openstack-nova08:20
openstackgerritSurya Seetharaman proposed openstack/nova master: [WIP] Make _instances_cores_ram_count() be smart about cells  https://review.openstack.org/56905508:21
*** edmondsw has joined #openstack-nova08:24
*** gjayavelu has quit IRC08:26
*** dtantsur|afk is now known as dtantsur08:26
*** edmondsw has quit IRC08:29
*** tianhui_ has joined #openstack-nova08:30
openstackgerritTakashi NATSUME proposed openstack/nova master: Add the guideline to write API reference  https://review.openstack.org/56905808:30
*** tianhui has quit IRC08:32
*** links has quit IRC08:32
openstackgerritTakashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller  https://review.openstack.org/34728908:33
*** gyankum has quit IRC08:33
*** bhujay has quit IRC08:36
*** Guest37211 has quit IRC08:37
*** mdnadeem has quit IRC08:37
*** lei-zh has quit IRC08:38
*** mdnadeem has joined #openstack-nova08:40
*** wolverineav has joined #openstack-nova08:40
*** yamamoto_ has joined #openstack-nova08:41
*** alexchadin has joined #openstack-nova08:42
*** tianhui has joined #openstack-nova08:44
*** alexchad_ has quit IRC08:44
*** tianhui_ has quit IRC08:45
*** yamamoto has quit IRC08:45
*** owalsh_ is now known as owalsh08:48
*** links has joined #openstack-nova08:49
openstackgerritSurya Seetharaman proposed openstack/nova master: Metadata-API fails to retrieve avz for instances created before Pike  https://review.openstack.org/56787808:50
*** Guest37211 has joined #openstack-nova08:50
*** derekh has joined #openstack-nova08:51
gibiDoes somebody has an idea why the ovo hash differs for the same ovo between py27 and py35 env? https://review.openstack.org/#/c/56884008:58
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Skip fetching the virtual size of block devices  https://review.openstack.org/56906208:58
*** Zames has joined #openstack-nova08:58
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Skip fetching the virtual size of block devices  https://review.openstack.org/56906208:59
openstackgerritChris Dent proposed openstack/nova master: Optional separate database for placement API  https://review.openstack.org/36276609:00
openstackgerritChris Dent proposed openstack/nova master: Isolate placement database config  https://review.openstack.org/54143509:00
openstackgerritChris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process  https://review.openstack.org/55385709:00
*** bhujay has joined #openstack-nova09:01
*** Zames has quit IRC09:02
*** mdbooth has joined #openstack-nova09:04
*** gyankum has joined #openstack-nova09:04
openstackgerritChris Dent proposed openstack/nova master: WIP: Add PLACEMENT_DB_ENABLED=True to the nova-next job  https://review.openstack.org/56406709:05
*** lei-zh has joined #openstack-nova09:05
*** alexchad_ has joined #openstack-nova09:08
*** wolverineav has quit IRC09:08
*** wolverineav has joined #openstack-nova09:08
*** gyankum has quit IRC09:08
*** gongysh has quit IRC09:09
*** alexchadin has quit IRC09:10
openstackgerritTetsuro Nakamura proposed openstack/nova master: Test alloc_cands with indirectly sharing RPs  https://review.openstack.org/51960109:11
*** wolverineav has quit IRC09:13
openstackgerritsahid proposed openstack/nova master: pci: don't consider case when match tags specs  https://review.openstack.org/56580809:14
openstackgerritsahid proposed openstack/nova master: network: update pci request spec to handle trusted tags  https://review.openstack.org/45882009:14
openstackgerritsahid proposed openstack/nova master: libvirt: configure trust mode for vfs  https://review.openstack.org/45851409:14
openstackgerritsahid proposed openstack/nova master: libvirt:  add vf_trusted field for network metadata  https://review.openstack.org/56634309:14
openstackgerritsahid proposed openstack/nova master: metadata: add vf_trusted field to device metadata  https://review.openstack.org/56634409:14
*** sidx64 has quit IRC09:14
*** ispp has quit IRC09:15
*** gongysh has joined #openstack-nova09:17
*** sidx64 has joined #openstack-nova09:17
*** alexchadin has joined #openstack-nova09:19
*** alexcha__ has joined #openstack-nova09:20
*** dims has quit IRC09:20
*** alexchad_ has quit IRC09:22
*** gongysh has quit IRC09:24
openstackgerritsahid proposed openstack/nova master: libvirt: Improve 'qemu-img convert' performance  https://review.openstack.org/52206709:24
*** alexchadin has quit IRC09:24
*** sahid has quit IRC09:35
*** gyankum has joined #openstack-nova09:46
*** xinliang has quit IRC09:46
*** Zames has joined #openstack-nova09:46
*** Zames has quit IRC09:48
*** moshele has joined #openstack-nova09:50
*** gyankum has quit IRC09:50
*** mdnadeem has quit IRC09:52
*** AlexeyAbashkin has quit IRC09:53
*** moshele has quit IRC09:54
*** gyankum has joined #openstack-nova09:56
*** Zames has joined #openstack-nova09:58
*** xinliang has joined #openstack-nova09:59
*** namnh has quit IRC10:00
*** ispp has joined #openstack-nova10:01
*** Zames has quit IRC10:02
*** dims has joined #openstack-nova10:07
*** lei-zh has quit IRC10:12
*** edmondsw has joined #openstack-nova10:13
*** sahid has joined #openstack-nova10:14
*** annp has quit IRC10:15
*** edmondsw has quit IRC10:17
*** dims has quit IRC10:17
*** nicolasbock has joined #openstack-nova10:30
*** ispp has quit IRC10:40
*** zhaochao has quit IRC10:41
*** hoonetorg has quit IRC10:43
*** tetsuro has quit IRC10:44
*** tetsuro has joined #openstack-nova10:45
*** tetsuro has quit IRC10:45
*** Zames has joined #openstack-nova10:46
*** zhaochao has joined #openstack-nova10:47
*** armaan has quit IRC10:48
*** armaan has joined #openstack-nova10:49
*** ykarel has joined #openstack-nova10:49
*** Zames has quit IRC10:50
*** edmondsw has joined #openstack-nova10:52
*** bkopilov has quit IRC10:54
*** AlexeyAbashkin has joined #openstack-nova10:54
*** jpena is now known as jpena|lunch10:59
*** mdbooth has quit IRC11:00
*** hoonetorg has joined #openstack-nova11:00
*** jaosorior has quit IRC11:01
*** cdent has joined #openstack-nova11:01
*** jaosorior has joined #openstack-nova11:05
*** mdbooth has joined #openstack-nova11:07
*** dave-mccowan has joined #openstack-nova11:09
*** gyan_ has joined #openstack-nova11:14
*** gyankum has quit IRC11:16
*** links has quit IRC11:16
*** alexcha__ has quit IRC11:17
*** alexchadin has joined #openstack-nova11:17
*** alexchadin has quit IRC11:18
*** alexchadin has joined #openstack-nova11:18
*** alexchadin has quit IRC11:18
*** alexchadin has joined #openstack-nova11:19
*** tssurya has quit IRC11:19
*** alexchadin has quit IRC11:19
*** alexchadin has joined #openstack-nova11:20
*** mdnadeem has joined #openstack-nova11:20
*** alexchadin has quit IRC11:20
*** armaan has quit IRC11:23
*** armaan has joined #openstack-nova11:23
*** phuongnh has quit IRC11:28
*** psachin has quit IRC11:28
*** links has joined #openstack-nova11:29
*** ispp has joined #openstack-nova11:30
*** yamamoto_ has quit IRC11:30
openstackgerritVishakha Agarwal proposed openstack/python-novaclient master: No requirement of –all-tenants while listing servers  https://review.openstack.org/56909011:31
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Microversion 2.63 - Use new format policy in server group  https://review.openstack.org/56753411:32
openstackgerritVishakha Agarwal proposed openstack/python-novaclient master: No requirement of –all-tenants while listing servers  https://review.openstack.org/56909011:32
*** lbragstad has joined #openstack-nova11:33
*** wolverineav has joined #openstack-nova11:36
*** psachin has joined #openstack-nova11:37
*** vladikr has quit IRC11:38
*** vladikr has joined #openstack-nova11:39
*** sidx64 has quit IRC11:40
*** moshele has joined #openstack-nova11:40
*** stakeda has quit IRC11:42
*** bhagyashri_s has joined #openstack-nova11:42
*** bhagyashri_s has quit IRC11:43
*** tssurya has joined #openstack-nova11:44
*** tiendc has quit IRC11:44
*** bhagyashri_s has joined #openstack-nova11:44
gibifound the reason of the different hash in https://review.openstack.org/#/c/568840 opened a bug https://bugs.launchpad.net/oslo.versionedobjects/+bug/177180411:45
openstackLaunchpad bug 1771804 in oslo.versionedobjects "ObjectVersionChecker.get_hash generates unstable has for set() default value between py27 and py35" [Undecided,New]11:45
*** bhagyashri_s has quit IRC11:45
*** bhagyashris has quit IRC11:46
*** bhagyashri_s has joined #openstack-nova11:46
*** yamamoto has joined #openstack-nova11:47
*** amoralej is now known as amoralej|lunch11:47
*** sidx64 has joined #openstack-nova11:47
*** pooja-jadhav has joined #openstack-nova11:48
*** pooja_jadhav has quit IRC11:50
*** mmehan has joined #openstack-nova11:51
*** vivsoni has quit IRC11:52
*** udesale has quit IRC11:53
*** vivsoni has joined #openstack-nova11:53
*** mriedem has joined #openstack-nova11:57
*** liuzz_ has quit IRC11:57
*** alexchadin has joined #openstack-nova11:58
*** hamdyk has quit IRC12:00
*** pooja_jadhav has joined #openstack-nova12:02
*** bhagyashris_ has joined #openstack-nova12:03
*** cdent has quit IRC12:03
*** alexchadin has quit IRC12:04
*** pooja-jadhav has quit IRC12:06
*** wolverineav has quit IRC12:06
*** bhagyashri_s has quit IRC12:06
*** wolverineav has joined #openstack-nova12:06
*** liverpooler has joined #openstack-nova12:08
*** moshele has quit IRC12:10
*** jaosorior has quit IRC12:12
*** eharney has joined #openstack-nova12:12
*** bhagyashri_s has joined #openstack-nova12:15
*** abhishekk has joined #openstack-nova12:16
*** bhagyashris_ has quit IRC12:18
*** alexchadin has joined #openstack-nova12:19
*** jaosorior has joined #openstack-nova12:19
*** ispp has quit IRC12:23
*** belmoreira has joined #openstack-nova12:24
*** moshele has joined #openstack-nova12:24
*** jpena|lunch is now known as jpena12:24
mriedemefried: mostly small things inline https://review.openstack.org/#/c/549300/12:25
*** ispp has joined #openstack-nova12:25
*** bhagyashris has joined #openstack-nova12:25
mriedemtell esberglu to get up12:25
*** bkopilov has joined #openstack-nova12:26
*** bhagyashri_s has quit IRC12:28
openstackgerritBalazs Gibizer proposed openstack/nova master: Add request_spec.RequestGroup versioned object  https://review.openstack.org/56884012:30
openstackgerritBalazs Gibizer proposed openstack/nova master: Add requested_resources field to RequestSpec  https://review.openstack.org/56726712:30
openstackgerritBalazs Gibizer proposed openstack/nova master: Transfer port.resource_request to the scheduler  https://review.openstack.org/56726812:30
mriedemgibi: is this now the 2nd changed error message in the placement api in about a week that has broken osc-placement functional tests? https://review.openstack.org/#/c/56904812:30
*** lyan has joined #openstack-nova12:31
belmoreiraHi mriedem. I'm trying to find how to use a custom resource class for a compute node (not ironic). Can't find any info. Do you have any pointer?12:31
gibimriedem: yes, unfortunately12:32
mriedembelmoreira: yeah https://docs.openstack.org/osc-placement/latest/index.html12:33
*** mdnadeem has quit IRC12:33
*** pchavva has joined #openstack-nova12:33
mriedemopenstack resource class create - to create your custom resource class12:33
gibimriedem: and it seems that the fix https://review.openstack.org/#/c/569048 shows a race condition as well12:33
mriedemopenstack resource provider list - to find your compute node resource provider12:33
mriedembelmoreira: and then you want to set that custom resource class inventory on the compute node resource provider? use https://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-inventory-set12:33
mriedemor actually https://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-inventory-class-set is probably easier12:34
*** sapd_ has quit IRC12:34
mriedemopenstack resource provider inventory set - makes you specify the full inventory with the changes, since it's a full overwrite12:34
mriedemopenstack resource provider class set - just modifies the inventory for the specified class12:34
*** sapd_ has joined #openstack-nova12:34
mriedemgibi: yeah i was wondering why the osc-placement functional test was still failng12:34
*** cdent has joined #openstack-nova12:35
*** sapd_ has quit IRC12:35
*** sapd_ has joined #openstack-nova12:35
*** sapd_ has quit IRC12:36
*** sapd_ has joined #openstack-nova12:36
mriedemgibi: are you sure that https://review.openstack.org/#/c/569048/ ran against the merged nova change?12:36
belmoreiramriedem: thanks. This will be always defined with placement API. There isn't the option for the compute_node advertise the custom resource classes that it supports?12:36
gibimriedem: the nova patch merged yesterday, I pushed the fix for osc_placement today12:37
*** mmehan has quit IRC12:37
gibimriedem: so I assume12:37
mriedembelmoreira: the compute node doesn't make up custom resource classes on the fly randomly :)12:38
mriedemthe compute node will report standard resource classes12:38
gibimriedem: and the osc_placement test fails differently with the fix than before12:38
mriedemgibi: it looks like assertCommandFailed might just be doing a prefix vs assertIn check?12:38
mriedembecause you got HTTP 404 back12:39
mriedemhttp://logs.openstack.org/48/569048/1/check/osc-placement-dsvm-functional/2800b3e/job-output.txt.gz#_2018-05-17_08_20_04_90092612:39
mriedembelmoreira: we plan on reporting compute driver capabilities as standard traits on the compute node provider, see https://review.openstack.org/#/c/538498/12:39
mriedembelmoreira: so we can report things like, "does this compute node support device tags, does this compute note support multiattach volumes, etc"12:39
*** armaan has quit IRC12:40
mriedemthose are being defined here https://github.com/openstack/os-traits/tree/master/os_traits/compute12:40
gibimriedem: ahh. I've just realized that it fails in cleanup not in the test itself http://logs.openstack.org/48/569048/1/check/osc-placement-dsvm-functional/2800b3e/job-output.txt.gz#_2018-05-17_08_20_04_88009212:40
mriedemi just need to cleanup that patch and get on the update_provider_tree() train12:40
mriedemgibi: aha12:40
*** armaan has joined #openstack-nova12:41
gibimriedem: so the test deletes the trait, then fails to clean up as that want to delete the trait again12:41
mriedemgibi: ah yes https://review.openstack.org/#/c/569048/1/osc_placement/tests/functional/base.py@21212:41
mriedemif 'not found' not in err_message:12:41
mriedemjust need to fix that12:41
*** bhagyashri_s has joined #openstack-nova12:41
gibimriedem: good point12:41
mriedemif if 'not found' not in err_message or 'HTTP 404' in err_message:12:41
*** pooja_jadhav has quit IRC12:41
*** alexchadin has quit IRC12:42
gibimriedem: I missed that12:42
mriedemto support old and new placement12:42
mriedemer or 'HTTP 404' not in err_message:12:42
gibimriedem: even better point to support old and new placement12:42
*** bhagyashris has quit IRC12:42
mriedemgibi: want to fix that quick and then i'll rebase avolkov's series12:42
mriedembelmoreira: does that help you out?12:42
*** pooja_jadhav has joined #openstack-nova12:42
gibimriedem: I'm doing it as we speak12:42
*** moshele has quit IRC12:43
*** dims has joined #openstack-nova12:43
belmoreiramriedem traits would do the trick as well. What I was thinking is an option to specify "custom" traits/resource classes per host.12:44
belmoreirareport compute_driver capabilities is good but we may want to use different properties as well12:45
*** moshele has joined #openstack-nova12:48
*** bhagyashri_s has quit IRC12:48
gibimriedem: both the old and the new error message contains HTTP 404, so we dont need the ORed conditional12:48
gibistack@ubuntu:~/osc-placement$ openstack trait delete ALMA --os-placement-api-version 1.612:48
gibiNo such trait(s): ALMA. (HTTP 404)12:48
mriedembelmoreira: you can do that yourself12:49
mriedembelmoreira: you mean you want to set a config option for nova to proxy all of that information for you?12:49
*** pooja-jadhav has joined #openstack-nova12:49
*** bhagyashri_s has joined #openstack-nova12:49
gibistack@ubuntu:~/nova$ openstack trait delete ALMA --os-placement-api-version 1.612:50
gibiNot found (HTTP 404)12:50
mriedembelmoreira: the beauty of custom resource classes and traits and placement is that it's external to nova, so you don't need to proxy stuff through nova and add the complexity / bottleneck there12:50
mriedemgibi: cool12:50
openstackgerritBalazs Gibizer proposed openstack/osc-placement master: Fix error message asserts in functional test  https://review.openstack.org/56904812:51
gibimriedem: ^^ here it is12:51
mriedemyup, watching zuul12:51
*** pooja_jadhav has quit IRC12:52
*** belmoreira has quit IRC12:52
*** yamamoto has quit IRC12:52
*** bhagyashris_ has joined #openstack-nova12:53
mriedemtssurya: i guess belmiro didn't like that answer?12:54
*** gyan_ has quit IRC12:54
tssuryamriedem: I am sure that's not the case :D12:55
mriedemhe hates me now doesn't he12:55
tssuryahaha12:55
mriedemI BLEW IT12:55
mriedemtssurya: btw, got any cells v2 upgrade news?12:55
*** bhagyashri_s has quit IRC12:55
jrollalex_xu: thanks12:56
*** jmlowe has quit IRC12:56
tssuryamriedem: its actually okay..12:57
tssuryawe are just trying to understand what is taking time in the scheduler12:57
tssuryaI mean what takes most of the time in the path of the scheduling12:57
mriedemmy guess would be that it's pulling more compute node records from the db than it used to do with the per-cell scheduler12:58
*** ispp has quit IRC12:58
tssuryaand what's more weird is, how do I test exactly this scatter-gather versus normal sequential querying ?12:58
gibimriedem: the lates ps of the osc_placement fix still failing the functional test locally :/12:58
tssuryalike the time taken12:58
mriedemso if you have 50 cells with 200 computes, before the top level scheduler would pick a cell and that would pull at most 200 compute nodes, right? but now it could be pulling at most 10K compute nodes12:59
tssuryamriedem: we use dan's pre-placement filter to ensure we don't pull that much12:59
mriedemtssurya: hmmm, we could add some debug logging to the scatter gather routine to log how long an operation took per cell...12:59
tssuryamriedem: that is what I did, but it gives weird times,13:00
tssuryanot convincing ones13:00
mriedemis the time being spent in pulling the compute nodes from the cells or from the filters?13:01
tssuryamriedem: filters don't seem to take much time, pulling computes (the query directly done on the DB is very fast, however logging the scatter-gather routine gives weird longer times)13:02
tssuryawhat is taking time is in the select destinations13:02
tssuryaI am working on it now to narrow it down further13:02
mriedemalso, do you know if you're hitting the same compute nodes for concurrent requests (packing)? just wondering if you're getting 409s from placement when trying to allocate resources against a target node13:02
gibimriedem: ohh, there is an upper() call on the message somewhere as  {{{err_message:no such trait(s): custom_fake_hw_gpu_class_264c6d7df889415ea5d3b428d7a4a2fc. (http 404)}}}13:02
mriedemtssurya: hmm, might be the alternate selection code?13:03
tssuryamriedem: yea I am right at that point now13:03
tssuryawill see in prod if that's the one13:04
*** moshele has quit IRC13:04
openstackgerritBalazs Gibizer proposed openstack/osc-placement master: Fix error message asserts in functional test  https://review.openstack.org/56904813:04
mriedemthat will add more time compared to before queens because we are trying to now find up to max_attempts alternate hosts in the same cell, and that means running those alternates through the filters again13:05
tssuryamriedem: oh right!13:05
*** amoralej|lunch is now known as amoralej13:05
mriedemand that's per instance13:05
mriedemso if you do server multicreate in a single request with like 10 instances and max_attempts is 3, we are trying to find i think 30 hosts13:06
tssuryamriedem: hmm yea, will know if this is the one taking time, will check the logs13:07
tssuryameanwhile mriedem I have another issue : http://logs.openstack.org/71/568271/2/check/tempest-full-py3/7142c54/testr_results.html.gz , not sure on how to fix this13:07
gibimriedem: ps 3 passes the functional locally13:08
tssuryait totally depends on if the host runs both cell and super conductors or runs one of them13:08
*** links has quit IRC13:09
* tssurya goes to check if alternate host path is the one taking the time or not.13:09
*** alexchadin has joined #openstack-nova13:09
openstackgerritNguyen Hai proposed openstack/nova-specs master: Follow the new PTI for document build  https://review.openstack.org/55180213:09
mriedemtssurya: hmm, the cell conductor should be reporting into the cell1 database13:11
mriedemthis is n-super-cond: http://logs.openstack.org/71/568271/2/check/tempest-full-py3/7142c54/controller/logs/screen-n-super-cond.txt.gz#_May_17_08_20_09_13387313:12
mriedemhttp://logs.openstack.org/71/568271/2/check/tempest-full-py3/7142c54/controller/logs/etc/nova/nova_conf.txt.gz13:12
mriedemwhich is in cell013:12
mriedem[database] connection = mysql+pymysql://root:secretdatabase@127.0.0.1/nova_cell0?charset=utf813:12
mriedemthe cell conductor is using the nova cell1 config13:13
mriedemhttp://logs.openstack.org/71/568271/2/check/tempest-full-py3/7142c54/controller/logs/screen-n-cond-cell1.txt.gz#_May_17_08_20_10_14554113:13
mriedemhttp://logs.openstack.org/71/568271/2/check/tempest-full-py3/7142c54/controller/logs/etc/nova/nova_cell1_conf.txt.gz13:13
mriedem[database] connection = mysql+pymysql://root:secretdatabase@127.0.0.1/nova_cell1?charset=utf813:13
*** yamamoto has joined #openstack-nova13:13
mriedemtssurya: it's a buggy test http://git.openstack.org/cgit/openstack/tempest/tree/tempest/api/compute/admin/test_services.py#n6113:14
mriedemit randomly picks the first service from the list and then looks that up by host and binary13:14
tssuryamriedem: yea!13:15
mriedemit's a single node devstack, so the host is going to be the same13:15
mriedemso tempest needs to just not ever use conductor here13:15
mriedemi'll report a tempest bug13:15
*** armaan has quit IRC13:15
tssuryamriedem: awesome thanks,13:15
*** armaan has joined #openstack-nova13:15
mriedemhttps://bugs.launchpad.net/tempest/+bug/177181713:17
openstackLaunchpad bug 1771817 in tempest "test_get_service_by_service_and_host_name intermittently fails if it tries to use nova-conductor on a single node devstack" [Undecided,New]13:17
mriedemwe should just delete that test from tempest, i'll ask the qa team13:17
*** mchlumsky has joined #openstack-nova13:17
*** yamamoto has quit IRC13:18
tssuryamriedem: ack13:19
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object and api models.  https://review.openstack.org/56337513:20
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Microversion 2.63 - Use new format policy in server group  https://review.openstack.org/56753413:21
*** burt has joined #openstack-nova13:23
*** yamamoto has joined #openstack-nova13:23
*** ratailor has quit IRC13:26
*** baoli has joined #openstack-nova13:28
*** yikun__ has joined #openstack-nova13:29
*** gongysh has joined #openstack-nova13:29
*** mdnadeem has joined #openstack-nova13:29
*** sambetts|afk is now known as sambetts13:29
*** belmoreira has joined #openstack-nova13:31
Kevin_Zhengmriedem: I was thinking about count services matches the condition before assert13:31
belmoreiramriedem sorry I needed to leave for few minutes13:31
*** baoli has quit IRC13:32
*** pchavva has quit IRC13:32
openstackgerritsahid proposed openstack/nova master: libvirt: Improve 'qemu-img convert' performance  https://review.openstack.org/52206713:32
*** baoli has joined #openstack-nova13:32
*** esberglu has joined #openstack-nova13:32
belmoreiramriedem If "colour" is a property that we would like to consider during scheduling how this should be defined?13:33
*** munishmehan has joined #openstack-nova13:36
dansmithbelmoreira: a property of what?13:36
mriedemKevin_Zheng: we do'nt need to do that13:37
mriedemKevin_Zheng: https://review.openstack.org/56911213:37
mriedemdansmith: of the compute node,13:37
mriedemhe wants to put a custom resource class or trait on the compute node resource provider13:37
*** takashin has joined #openstack-nova13:37
mriedembelmoreira: traits-based scheduling13:37
*** mmehan has joined #openstack-nova13:38
dansmithmriedem: ah13:38
mriedembelmoreira: see required traits here https://docs.openstack.org/nova/latest/user/flavors.html#extra-specs13:38
mriedembelmoreira: you put a trait on the compute node resource provider (via osc-placement or REST API or whatever) and then put that required trait in a flavor13:38
mriedemand then that flavor must land on a compute node with that trait13:38
*** jmlowe has joined #openstack-nova13:38
*** felipemonteiro has joined #openstack-nova13:39
openstackgerritMatt Riedemann proposed openstack/nova master: Make nova service-list use scatter-gather routine  https://review.openstack.org/56827113:39
belmoreiramriedem: I understand that. What I was thinking is if the compute node can it self advertise the trait13:39
*** sdake_ is now known as sdake13:39
mriedembelmoreira: as i said earlier, the compute node can report standard traits that it knows about,13:39
mriedemfor custom stuff, you can do that outside of nova-compute needing to report it for you by proxy13:40
Kevin_Zhengmriedem: if that is the case, then most of the tests can be removed?13:40
*** ratailor has joined #openstack-nova13:40
*** munishmehan has quit IRC13:40
efriedbelmoreira: The virt driver can set any traits it wants.  But one would have to make a case for a given trait being a sensible thing for the virt driver to set.13:41
mriedemKevin_Zheng: i'm starting small13:41
openstackgerritsahid proposed openstack/os-vif stable/pike: ovs-hybrid: should permanently keep MAC entries  https://review.openstack.org/50573113:41
*** ratailor has quit IRC13:41
belmoreirathe use case is when deploying a set of nodes with different custom traits all of this needs to be setup up using tha placement api. It would be easier to include them in a nova config option. This case is much easier to handle with a configuration management tool13:41
Kevin_Zhengmriedem: :)13:42
efriedbelmoreira: In Dublin we agreed that there would be a certain set of traits that the compute service "owns" - has the authority to set/unset on the providers it owns - and anything outside of that circle could be set externally via direct placement API access (via osc or whatever).13:42
belmoreiraefried mriedem thanks for the clarification13:43
efriedbelmoreira: You're suggesting a config option like13:43
efriedcompute_provider_additional_traits = CUSTOM_FOO, CUSTOM_BAR13:43
efried?13:43
mriedemyes, and i don't think we should do that13:44
belmoreiraefried yes13:44
dansmithyou'd have to have a negative as well so you could ever remove traits you had previously set13:44
mriedemit makes nova a proxy,13:44
dansmithmriedem: agree13:44
mriedemand blocks everyone on nova supporting this thing13:44
mriedemwhen you can already do it external to nova13:44
efriedbelmoreira: yes, I agree with mriedem and dansmith.13:44
mriedemi already don't really care for the ironic trait proxy stuff we do13:44
belmoreiramy issue is how to manage all this things at scale13:45
efriedbelmoreira: You would be editing config files, one per host, in any case.13:45
mriedemyour config mgmt tool is already doing the logic to put the custom traits in the specific compute host config file yes?13:45
efriedbelmoreira: Rather than doing that, run a placement CLI once per host.13:45
belmoreiraa configuration management tool doing API calls doesn't looks good to me13:45
mriedemwhy can't that same code just put the traits in placement once nova-compute is running and the rp is registered?13:45
*** felipemonteiro has quit IRC13:46
mriedembelmoreira: how do you create keystone endpoints?13:46
mriedemand users/projects13:46
efriedAre you equating "API calls" with invoking CLIs?13:46
mriedemopenstack-ansible does all of this quite a bit i think13:47
mriedemthat's how they do the cells v2 setup13:47
mriedemit's really the only way since we don't have rest apis for cell and host mappings13:47
belmoreiramriedem is true for keystone. We built our own machinery to create/delete projects. And the experience is not great13:47
belmoreiraefried: no. The problem is given credentials to a configuration management tool to populate these properties13:49
belmoreirachanging configuration files is much easier and less worrying13:50
*** ispp has joined #openstack-nova13:50
*** tetsuro has joined #openstack-nova13:51
*** zhaochao has quit IRC13:51
*** gbarros has joined #openstack-nova13:52
openstackgerritMatt Riedemann proposed openstack/osc-placement master: Fix error message asserts in functional test  https://review.openstack.org/56904813:54
openstackgerritMatt Riedemann proposed openstack/osc-placement master: Resource class set (v1.7)  https://review.openstack.org/51464413:54
openstackgerritMatt Riedemann proposed openstack/osc-placement master: Usages per project and user (v1.8, v1.9)  https://review.openstack.org/51464613:54
openstackgerritMatt Riedemann proposed openstack/osc-placement master: CLI allocation candidates (v1.10)  https://review.openstack.org/51464713:54
openstackgerritMatt Riedemann proposed openstack/osc-placement master: New dict format of allocations (v1.11, v1.12)  https://review.openstack.org/54281913:54
openstackgerritMatt Riedemann proposed openstack/osc-placement master: Transactionally update allocations (v1.13)  https://review.openstack.org/54667413:54
openstackgerritMatt Riedemann proposed openstack/osc-placement master: Add nested resource providers (v1.14)  https://review.openstack.org/54667513:54
openstackgerritMatt Riedemann proposed openstack/osc-placement master: Limit allocation candidates (v1.15, v1.16)  https://review.openstack.org/54804313:54
openstackgerritMatt Riedemann proposed openstack/osc-placement master: Allocation candidates parameter: required (v1.17)  https://review.openstack.org/54832613:54
mriedemgibi: https://review.openstack.org/#/c/514644/ should be ready to go now13:54
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object and api models.  https://review.openstack.org/56337513:55
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object  https://review.openstack.org/56340113:55
*** armaan has quit IRC13:56
*** armaan has joined #openstack-nova13:57
gibimriedem: done13:57
mriedemyay13:57
melwittnova meeting in 3 min13:57
*** tbachman has joined #openstack-nova13:58
*** artom has quit IRC13:59
*** mlavalle has joined #openstack-nova13:59
*** armaan has quit IRC14:00
*** belmorei_ has joined #openstack-nova14:00
*** armaan has joined #openstack-nova14:00
*** abhishekk_ has joined #openstack-nova14:01
*** ccamacho has quit IRC14:01
*** belmoreira has quit IRC14:01
*** ccamacho has joined #openstack-nova14:02
*** abhishekk has quit IRC14:04
*** abhishekk_ is now known as abhishekk14:04
openstackgerritSylvain Bauza proposed openstack/nova-specs master: Proposes Multiple GPU types  https://review.openstack.org/55706514:09
*** armaan has quit IRC14:15
*** armaan has joined #openstack-nova14:15
*** sidx64 has quit IRC14:16
*** johanssone has quit IRC14:16
mriedemtssurya: check the max_attempts config option, if it's 1 then we shouldn't be calculating alternate hosts in the scheduler14:17
mriedemand belmorei_ said in boston that cern doesn't do retries14:17
dansmithmriedem: well, let me just hand you my thunder then14:17
mriedemtssurya: dansmith reminded me that max_attempts=1 means no retries and dansmith reminded me that belmorei_ said in boston that cern doesn't do retries14:18
dansmithhaha14:18
*** sidx64 has joined #openstack-nova14:20
belmorei_mriedem: correct :) we have max_attempts=114:20
*** sidx64 has quit IRC14:21
dansmithso if it's trying to get alternates in that case, it's probably a bug14:21
mriedemyeah need to figure that part out, although i thought edleafe added unit tests for that scenario to assert that we didn't try calculating alternates if max_attempest=114:22
mriedemtempest on the brain14:22
dansmithah,14:23
dansmithmax_attempts grabs one alternate it looks like14:23
dansmithinstead of max_attempts-1 ?14:23
*** sidx64 has joined #openstack-nova14:23
dansmithhttps://github.com/openstack/nova/blob/master/nova/scheduler/filter_scheduler.py#L161-L16114:24
*** hemna_ has joined #openstack-nova14:24
edleafenum_alts = CONF.scheduler.max_attempts if return_alternates else 014:24
edleafeso yeah, it will return 1 alternate with max_attempts=114:24
dansmithwhich is wrong14:24
mriedemarvindn05: how are you coming on that traits-in-images + rebuild patch?14:25
dansmithwe also would do too much extra work if num_alts is zero14:25
dansmithbelmorei_: tssurya: if you can confirm that with max_attempts the scheduler is asking for one extra alternate that would be good14:26
dansmithwould mean about an exact doubling of placement and filter load I guess14:26
mriedemshouldn't be any more placement load,14:26
mriedemjust filtering14:26
mriedemthe alternates are pulled from the compute node list we get after placement allocation candidates are retrieved14:26
dansmithit asks placement again doesn't it?14:26
mriedemnot for new allocation candidates14:27
edleafealternates only get re-filtered when building > 1 instance per request14:27
mriedemor it shouldn't...14:27
belmorei_dansmith: will do14:27
dansmithmriedem: okay14:27
*** moshele has joined #openstack-nova14:27
*** hamzy_ has joined #openstack-nova14:28
mriedemthere are some unit tests setting max_attempts to 1 but i'm having a hard time seeing what they assert14:29
*** hamzy has quit IRC14:29
mriedemprobably just need a simple tests where max_attempts=1, single instance in the request, and make sure we don't mess with alternate calculation14:29
mriedem*test14:29
openstackgerritStephen Finucane proposed openstack/nova-specs master: Rename spec to match blueprint  https://review.openstack.org/56887014:29
openstackgerritDan Smith proposed openstack/nova master: WIP: Fix interpretation of max_attempts for scheduling alternates  https://review.openstack.org/56912714:29
mriedemdansmith: want to keep this backport train a comin https://review.openstack.org/#/c/568369/14:29
dansmithbelmorei_: tssurya ^ is what I expect we'll do14:29
dansmith*we'll need14:30
belmorei_this is an interesting issue. We get in average 20s for scheduling... We are debugging and let you know when we have more info14:30
dansmith20s to schedule one? that's.. uh, terrible14:30
*** tetsuro has quit IRC14:31
*** ispp has quit IRC14:31
*** ispp has joined #openstack-nova14:32
melwittyeah ...14:33
*** jaypipes has quit IRC14:34
openstackgerritEric Fried proposed openstack/nova master: libvirt: get_inventory => update_provider_tree  https://review.openstack.org/56044414:37
openstackgerritEric Fried proposed openstack/nova master: libvirt: Don't report DISK_GB if sharing  https://review.openstack.org/56045914:37
openstackgerritEric Fried proposed openstack/nova master: WIP: Normalize inventory from update_provider_tree  https://review.openstack.org/56913214:37
efriedbhagyashris_: ^14:37
dansmithbelmorei_: tssurya: something else to maybe look at.. by default we ask for 1000 placement results on each schedule, which is probably insane14:42
dansmithyou might try tweaking down max_placement_results to see if that makes a difference14:43
dansmithdepending on where you see the hotspot is14:43
*** ykarel is now known as ykarel|away14:43
belmorei_in our case that shouldn't happen because we use the request_filter14:43
*** hamzy_ is now known as hamzy14:43
dansmithwhat do you mean?14:44
dansmithyou mean because you're limiting to a cell with only 200 hosts?14:44
belmorei_the request_filter to use placement_aggregates14:44
dansmithyeah, okay14:44
dansmithwell, still, on an empty cell you'd get back the whole cell, but fair enough14:45
mriedemare the compute node resource providers in placement within aggregates?14:45
dansmithmriedem: I think that's the implication :)14:45
mriedemin other words, are you getting back 200 allocation candidates or 10K?14:45
mriedemsure but have they asserted that's all linked up properly14:45
dansmithof they didn't, they would get back zero14:45
mriedemsorry, i mean 1K14:45
dansmithunless they set required=false14:45
belmorei_depends in the project... but should get in average less than 20014:46
mriedembecause we'd say give me allocation candidates that are a member of this aggregate, and if the rp isn't in that aggregate we'd get back 0, right14:46
dansmithmriedem: yeah14:46
*** ykarel|away has quit IRC14:49
*** abhishekk has quit IRC14:50
*** dklyle has joined #openstack-nova14:54
openstackgerritMerged openstack/osc-placement master: Fix error message asserts in functional test  https://review.openstack.org/56904814:57
*** yamamoto has quit IRC14:58
*** artom has joined #openstack-nova15:00
melwittlyarwood: thanks for jumping on https://bugs.launchpad.net/nova/+bug/177170015:01
openstackLaunchpad bug 1771700 in OpenStack Compute (nova) "nova-lvm tempest job failing with InvalidDiskInfo" [High,In progress] - Assigned to Lee Yarwood (lyarwood)15:01
lyarwoodmelwitt: well, sorry for breaking nova-lvm ^_^15:01
melwittmriedem: lyarwood had an idea of running the nova-lvm job non-voting on nova/virt/libvirt/* changes. what do you think?15:02
melwittno worries15:02
mriedemwhy non-voting?15:03
mriedemi think it is stable otherwise15:03
*** yikun_ has joined #openstack-nova15:04
mriedemwe just don't gate on it because it's not a highly deployed image backend15:04
melwittI dunno. voting then?15:04
mriedemwe also had a raw imagebackend job at one point15:04
*** sidx64 has quit IRC15:04
mriedemor maybe that was just a dnm patch i had...15:04
mriedemlet's see how it looks on lee's fix first15:05
*** takashin has left #openstack-nova15:05
mriedem1 hour and 20 minutes...15:05
mriedembut it passes15:05
mriedemmaybe we should just run the nova-lvm job on compute api tests15:05
mriedemnon-voting to start15:05
mriedemand only on libvirt changes15:05
melwittI think that would be helpful15:06
*** yikun__ has quit IRC15:07
openstackgerritMerged openstack/osc-placement master: Resource class set (v1.7)  https://review.openstack.org/51464415:07
*** fragatin_ has quit IRC15:08
openstackgerritMatt Riedemann proposed openstack/nova master: DNM: test raw image live migration with vfat config drive  https://review.openstack.org/56786015:09
mriedemlyarwood: let's make sure we don't regress the raw + vfat config drive + live migration case :) ^15:09
*** ykarel|away has joined #openstack-nova15:09
*** fragatina has joined #openstack-nova15:10
*** eharney has quit IRC15:10
lyarwoodmriedem: thanks, I'd like to get off of this regression merry-go-round eventually :)15:11
*** AlexeyAbashkin has quit IRC15:12
openstackgerritMatt Riedemann proposed openstack/nova master: Deduplicate config/policy reference docs from main index  https://review.openstack.org/56484615:12
openstackgerritMatt Riedemann proposed openstack/nova master: Implement granular policy rules for placement  https://review.openstack.org/52442515:12
openstackgerritMatt Riedemann proposed openstack/nova master: Add granular policy rules for /resource_classes*  https://review.openstack.org/56557815:12
openstackgerritMatt Riedemann proposed openstack/nova master: Add granular policy rules for resource providers inventories  https://review.openstack.org/56866615:12
openstackgerritMatt Riedemann proposed openstack/nova master: Add granular policy rules for usages  https://review.openstack.org/56870615:12
mriedemlyarwood: job security!15:12
mriedemper my comments in https://review.openstack.org/#/c/567860/ i'd also like to diversify the live migration tests we run15:13
mriedemto mix up the image format15:13
mriedemand to use config drive15:13
mriedemwe already run the nova-live-migration job and the neutron-tempest-multinode-full job runs live migration,15:14
mriedemso we can make nova-live-migration run with force_config_drive=True,15:14
mriedemand nova-live-migration runs with 2 image formats today, first is default (qcow2) and 2nd is rbd, we could change that first run to be raw15:15
*** eharney has joined #openstack-nova15:15
mriedemand then neutron-tempest-multinode-full would test qcow2 (default) with no config drive (default)15:15
*** AlexeyAbashkin has joined #openstack-nova15:15
mriedemwe still wouldn't have vfat config drive format testing, but i suspect we can remove the vfat config_drive_format option/workaround15:15
mriedemi think that was for old versions of libvirt and we now require a minimum that has that fixed15:16
*** pchavva has joined #openstack-nova15:17
*** yamamoto has joined #openstack-nova15:19
*** jpena is now known as jpena|off15:22
*** yamamoto has quit IRC15:23
*** cz2 has quit IRC15:24
openstackgerritMatt Riedemann proposed openstack/nova master: Make nova-lvm run in check on libvirt changes and compute API tests  https://review.openstack.org/56914915:25
mriedemmelwitt: lyarwood: ^15:25
openstackgerritMatt Riedemann proposed openstack/nova master: Make nova-lvm run in check on libvirt changes and compute API tests  https://review.openstack.org/56914915:25
lyarwoodmriedem: ack thanks!15:25
*** ragiman has quit IRC15:25
*** gbarros has quit IRC15:29
*** ispp has quit IRC15:31
*** jpena|off is now known as jpena15:33
*** germs has joined #openstack-nova15:34
*** germs has quit IRC15:34
*** germs has joined #openstack-nova15:34
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: Skip fetching the virtual size of block devices  https://review.openstack.org/56906215:34
openstackgerritMatt Riedemann proposed openstack/nova master: Make nova-lvm run in check on libvirt changes and compute API tests  https://review.openstack.org/56914915:34
openstackgerritMatt Riedemann proposed openstack/nova master: DNM: test raw image live migration with vfat config drive  https://review.openstack.org/56786015:35
*** ispp has joined #openstack-nova15:37
*** throwsb1 has joined #openstack-nova15:37
*** damien_r has quit IRC15:37
*** damien_r has joined #openstack-nova15:37
*** germs has quit IRC15:39
*** yamamoto has joined #openstack-nova15:40
*** germs has joined #openstack-nova15:40
*** germs has quit IRC15:40
*** eharney has quit IRC15:41
*** gyee has joined #openstack-nova15:41
*** germs has joined #openstack-nova15:41
*** germs has quit IRC15:41
*** germs has joined #openstack-nova15:41
*** ispp has quit IRC15:41
openstackgerritMerged openstack/nova master: Fix auth_url example in hypervisor-hyper-v.rst  https://review.openstack.org/56898315:42
*** dklyle has quit IRC15:43
*** gongysh has quit IRC15:44
*** yamamoto has quit IRC15:45
*** gbarros has joined #openstack-nova15:46
mriedemtssurya: do you need to rebase https://review.openstack.org/#/c/567878/ on top of https://review.openstack.org/#/c/568271/ or just wait for https://review.openstack.org/569112/ ?15:47
openstackgerritChris Dent proposed openstack/nova master: Optional separate database for placement API  https://review.openstack.org/36276615:47
*** dklyle has joined #openstack-nova15:48
*** lucasagomes is now known as lucas-afk15:48
*** alexchadin has quit IRC15:50
*** armaan has quit IRC15:50
*** armaan has joined #openstack-nova15:51
*** cz2 has joined #openstack-nova15:52
openstackgerritChris Dent proposed openstack/nova master: Isolate placement database config  https://review.openstack.org/54143515:56
openstackgerritChris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process  https://review.openstack.org/55385715:56
*** germs has quit IRC15:57
*** germs has joined #openstack-nova15:58
*** germs has quit IRC15:58
*** germs has joined #openstack-nova15:58
*** germs has quit IRC15:58
openstackgerritChris Dent proposed openstack/nova master: WIP: Add PLACEMENT_DB_ENABLED=True to the nova-next job  https://review.openstack.org/56406715:59
*** damien_r has quit IRC15:59
openstackgerritMerged openstack/nova master: Deprecate running API services under eventlet  https://review.openstack.org/54951015:59
*** germs has joined #openstack-nova15:59
*** germs has quit IRC15:59
*** germs has joined #openstack-nova15:59
openstackgerritMerged openstack/nova master: Simplify BDM boot index checking  https://review.openstack.org/56448016:01
*** yamamoto has joined #openstack-nova16:01
*** felipemonteiro has joined #openstack-nova16:02
*** yamamoto has quit IRC16:06
*** chyka has joined #openstack-nova16:10
*** felipemonteiro has quit IRC16:12
*** wwriverrat has quit IRC16:12
*** do3meli has quit IRC16:13
melwittmriedem: do you see any issue with us increasing the max number of allowed attached volumes per instance from 26 to 1024? I was thinking to approve this specless bp https://blueprints.launchpad.net/nova/+spec/nova-improvement-of-maximum-attach-volumes-more-than-26-vols16:13
mriedemi am not the person to ask about that...16:14
mriedemshould ask kvm people16:14
mriedemlike kashyap re danpb16:14
melwittI already talked to danpb about it and he suggested 1024 as the new max16:15
mriedembecause of the default fd?16:15
melwittwas just thinking to ask you since you've worked on the multi-attach stuff16:15
mriedemer ulimit used to default to 102416:15
mriedemmultiattach volumes are >1 instance to the same volume,16:16
mriedemnot >1 volumes to the same instance16:16
mriedemdefault quota on volumes is 10 anyway16:16
*** burt has quit IRC16:16
mriedemso a normal tenant is going to have at most 10 volumes attached to a server16:16
mriedemif you're using powervm, i think you get up to like 256 or something16:16
mriedemefried: ^16:16
melwittoh, right. okay16:16
mriedembecause powervm just f'ing loves volumes16:17
mriedemalso,16:17
mriedemthis reminds me,16:17
melwittpicked 1024 arbitrarily based on the field tests described here https://rwmj.wordpress.com/2017/04/25/how-many-disks-can-you-add-to-a-virtual-linux-machine/16:17
mriedemIa34d06429c1f8f0a8259616bcba0c349c4c9aa3316:18
melwittdanpb suggested 100016:18
mriedemhttps://review.openstack.org/#/c/366955/16:18
mriedemdepending on how many volumes you try to attach in a single request, you could blow out the build requests table16:18
efriedI'm asking Gerald whether 1024 is enough for us.16:18
mriedemso would 1024 BDMs in a single bfv request get stored in MediumText?16:18
melwitthm16:18
mriedemMediumText is pretty damn big so i assume yes16:19
mriedem(11:44:41 AM) burgerk: mriedem: broke at ~ 80 volumes, want to go up to 12816:19
mriedemso powervm was using 128 in that case16:19
efriedokay.16:20
*** moshele has quit IRC16:20
melwittokay, so increasing the max is cool, it might be that 1024 is too high16:21
mriedemMEDIUMTEXT             [CHARACTER SET charset_name]             [COLLATE             collation_name]                        A TEXT column with a maximum             length of 16,777,215 (224 −             1) characters. The effective maximum length is less if the             value contains multibyte characters. Each             MEDIUMTEXT value is stored             using a 3-byte length prefix that indicates the number of16:21
mriedem        bytes in the value.16:21
mriedemidk16:21
mriedemsomeone should test it16:21
mriedemi don't want to guess wtf would happen if someone tries to boot from volume with 1024 volumes16:21
*** yamamoto has joined #openstack-nova16:21
mriedemTsuyoshi Nagata should test that16:22
melwittI'll ask16:22
mriedemwhat is even the practical application of this?16:22
* mriedem goes back inside from telling kids to get off his lawn16:23
openstackgerritMerged openstack/nova master: Skip ServerActionsTestJSON.test_rebuild_server for cells v1 job  https://review.openstack.org/56725616:23
openstackgerritMerged openstack/nova master: Remove mox in libvirt/test_driver.py (1)  https://review.openstack.org/56655516:23
openstackgerritMerged openstack/nova stable/pike: libvirt: Report the virtual size of RAW disks  https://review.openstack.org/56836916:23
dansmithmriedem: I bet it is "because kvm can do it and nova can't"16:24
openstackgerritMerged openstack/nova master: Remove mox in test_live_migrate.py  https://review.openstack.org/56465616:24
dansmithnot for any real reason16:24
openstackgerritMerged openstack/nova master: PowerVM Driver: DiskAdapter parent class  https://review.openstack.org/54905316:24
mriedemNFV something or other16:24
dansmithor "because kvm can do it and nova won't let you"16:24
*** burt has joined #openstack-nova16:24
mriedemin today's modern high-demand enterprise telco world, 26 volumes is for babies16:24
melwittI had thought it was something to do with people attaching a lot of volumes for HA or something?16:24
mriedemthat's a hell of a lot of HA :)16:25
melwittI remember it was mentioned in the nova/cinder session at the PTG in the context of the bulk volume create/attach discussion16:25
mriedemthis needs to be....super fucking redundant16:25
mriedemall i took out of that discussion was,16:25
mriedem"the storage backend allows it, so we want to make the software do it"16:25
mriedem"because the admin can attach 500 volumes in 2 hours rather than 10, but they'll never touch this thing again after that"16:26
mriedemso i'm kind of -1 on this blueprint just based on the "why?"16:26
*** yamamoto has quit IRC16:26
dansmithyar16:26
mriedemwhere is ken'ichi when i want to praise him16:27
melwittokay. I thought it had been discussed in the past that some people attach a lot of volumes for an HA use case16:28
mriedemidk maybe, that's certainly an argument for volume multiattach16:28
mriedembut that's not attaching >1 volume to an instance16:28
melwittand maybe 1024 is too high but I was thinking it didn't sound unreasonable to increase it > 26 for such a use case16:28
mriedemand i don't see how 1024 is sane HA16:28
mriedemsure, i mean maybe 128 like the powervm thing16:29
mriedembut need to actually justify why we should make this change16:29
mriedemnot just because we can16:29
melwittyeah, I think the point of the blueprint is > 26 and we were trying to find a reasonable max16:29
mriedemsure, that's just not the first question i'd ask16:29
mriedemi want shelve to send me an email when it's done16:30
mriedemnot because i need it, just because i can make it happen16:30
mriedemi actually think we've had that blueprint...the email thing anyway16:30
melwittokay, considering we've raised it to 128 for powervm and 256 for virtio-scsi, I didn't think we needed to ask about > 26 for this case as to why. others are attaching a lot more devices than 2616:30
dansmithmriedem: melwitt one way to look at it is 1024 is probably more than you could expect reasonable throughput from any of them on, given the number of host threads you'd need for them16:31
melwittsure ... I'm sorry I picked 1024, I didn't know it would be way too high. they didn't ask for 1024, they actually started with MAX_INT and I wanted to lower it to something more reasonable16:33
*** sambetts is now known as sambetts|afk16:33
dansmithtbh, I don't think it matters that much.. if it's not a big change, then whatever, but the justification can't be "because this is a legit real-world use case"16:34
*** tesseract has quit IRC16:38
melwittokay, I'll ask them to lower the proposed max and re-ask how many volumes they need to attach for their use case16:38
*** bhujay has quit IRC16:39
*** mdnadeem has quit IRC16:41
edleafedansmith: your change https://review.openstack.org/#/c/569127/ is failing unit tests due to the one-off change. Want me to fix it?16:41
*** dklyle has quit IRC16:42
*** yamamoto has joined #openstack-nova16:42
dansmithedleafe: ah, I figured it would.. I can do it16:42
edleafedansmith: ok16:42
dansmithglad we have coverage on that16:42
*** mdnadeem has joined #openstack-nova16:43
belmorei_dansmith: me and tssurya were debugging the scheduler time. It's related with https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L77216:45
belmorei_creating a dict with all instances info per host16:46
dansmithper host we're considering each time we run through yeah?16:48
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk  https://review.openstack.org/54930016:48
belmorei_yeah16:48
*** claudiub has joined #openstack-nova16:48
*** yamamoto has quit IRC16:49
dansmithbelmorei_: what is the slow part exactly? it looks like it's hitting a cell db once per host instead of grabbing a bunch at a time maybe?16:49
melwittI've actually seen that complaint before and I don't understand how compute isn't sending updates to the scheduler. or does that not happen anymore because of placement?16:49
mriedemit does16:49
dansmithmelwitt: that would be an upcall16:49
mriedemif configured to do so16:49
dansmithright16:50
melwittI see16:50
mriedemit's an rpc cast from all computes to the scheduler topic16:50
mriedemit's only used for the affinity filters16:50
mriedemtrack_instance_changes or something like that16:50
dansmithyeah, and what I'm not getting is why this would be different for them in the new arrangement,m16:50
mriedemhttps://docs.openstack.org/nova/latest/configuration/config.html#filter_scheduler.track_instance_changes16:50
dansmithbecause they're only considering hosts from one cell at this point anyway16:50
mriedemdansmith: i'm wondering the same16:50
melwittyeah. lemme see if I can find the bug I'm thinking of16:51
bauzasis someone able to tell me how to simply just associate an instance and a floating IP, without going thru the list of ports ?16:51
bauzaswe had that in the past, but we removed that here16:52
melwittthis one https://bugs.launchpad.net/nova/+bug/173746516:52
openstackLaunchpad bug 1737465 in OpenStack Compute (nova) "[cellv2] the performance issue of cellv2 when creating 500 instances concurrently" [Undecided,Confirmed] - Assigned to Jiang (jiangpf)16:52
belmorei_dansmith not following... hosts from one cell?16:52
mriedembauzas: I CAN16:52
mriedembauzas: https://docs.openstack.org/python-openstackclient/pike/cli/command-objects/floating-ip.html#floating-ip-set16:52
mriedemget the port id from the instance16:52
mriedemthen associate the port to hte floating ip16:52
bauzasmriedem: port is required16:52
mriedemor create the floating ip with the port16:52
dansmithbelmorei_: that code should be building a dict of host info, but only from the list of uuids that we got back from placement, which should be only one cell, and only the subset of those that are candidates16:52
mriedembauzas: yes the port is what links the instance to the floating ip16:53
bauzasmriedem: so I need to openstack port list before16:53
bauzasI was thinking we could somehow magically avoid one roundtrip16:53
*** hongbin has joined #openstack-nova16:53
bauzaswith openstack CLI doing that in secret for me16:53
mriedemyou can do it on a single command line if you want...16:53
bauzasawk my love16:53
mriedemno16:53
mriedemNO16:53
mriedemPORT1=$(openstack port list --device-id $SERVER1 -c ID -f value)16:54
mriedemFLOATINGIP1=$(openstack floating ip create --port $PORT1 public -c floating_ip_address -f value)16:54
mriedemdo that in a single line16:54
bauzasmeh16:54
belmorei_dansmith: yes, but takes a lot of time even for 200 nodes16:54
mriedemthen $$$ me16:54
mriedembauzas: meh?16:54
dansmithbelmorei_: but it should have been doing that before in the same way in the cell scheduler I mean16:54
bauzasmriedem: yeah, meh.16:54
mriedembauzas: see channel topic16:54
bauzasmriedem: hahah16:54
mriedemlove my idea or get out16:54
dansmithmriedem: nice16:54
bauzasanyway, you're right16:54
bauzasthat's not a dev call :p16:55
bauzasmriedem: FWIW, you were confused with the status of libvirt vGPUs16:55
bauzasmriedem: the branch is up for reviews, and I just updated the spec16:55
dansmithbelmorei_: maybe it was taking just as long before in the cell, but it wasn't as obvious because it was spread out?16:55
openstackgerritEric Berglund proposed openstack/nova master: PowerVM snapshot cleanup  https://review.openstack.org/56898816:55
melwittdansmith: what do you mean by "cell scheduler"?16:56
dansmithbelmorei_: or did you have track_instance_changes enabled? I wouldn't think affinity would work with cellsv1 so I would have assumed no16:56
bauzasmriedem: jay had some concerns with traits, but I think we should do that in a separate spec16:56
dansmithmelwitt: in cellsv1 there is a scheduler in the cell16:56
belmorei_dansmith: maybe16:56
belmorei_dansmith: track_instance_changes is enabled16:56
melwittokay. well, with cells v1, wouldn't compute be reporting updates to the scheduler and then it wouldn't build that dict?16:56
mriedembelmorei_: was it disabled when you were doing cells v1?16:56
dansmithmelwitt: that's what I just said above16:56
bauzasmelwitt: dansmith: catching up the convo, what's the problem with computes updating the scheduler ?16:56
dansmithbut I thought we still had to hit the db once per host even with that enbabled16:57
bauzasthere is a fanout upcall16:57
melwitt? so doesn't that make it obvious why it was fast with cells v1 and slow with cells v2?16:57
melwittbecause with cells v2 it's building the dict every time in the absence of updates? I'm confused16:57
dansmithmelwitt: I had asked him if they had it enabled16:57
dansmithmelwitt: affinity doesn't work with cellsv1 so I would have expected they didn't have that enabled16:57
dansmith(afaik)16:57
melwittokay, I see16:58
*** sidx64 has joined #openstack-nova16:58
dansmithand, I thought we still hit the db once per host even with it enabled for the compute info, but not for the instance info part16:58
*** amoralej is now known as amoralej|off16:58
dansmithso I wouldn't expect a lage difference16:58
melwittit probably works for them by way of patches, maybe16:58
dansmith*large16:58
dansmithwell, then they're cheating :)16:58
melwittwhat's the compute info part?16:59
melwittthe normal host states stuff?17:00
dansmithyeah17:00
*** mdnadeem has quit IRC17:00
belmorei_ok, we will continue to dig on this17:01
belmorei_thanks17:01
belmorei_I'm leaving now17:01
*** jpena is now known as jpena|off17:01
mriedemrandom thinking out loud, i think the instance info list only uses the uuid from the instances for the affinity filters,17:01
melwittbelmorei_: seeya next week17:02
*** belmorei_ has quit IRC17:02
mriedemwe could probably use placement to just pull uuids of consumers that have allocations on a given node and replace that17:02
*** ccamacho has quit IRC17:02
mriedemwould be a lot fast17:02
mriedem*faster17:02
dansmithwell, it depends on which piece of his linked function is taking a while17:02
dansmithwe do hit the db for the hosts every time,17:02
dansmithbut the instance list is the thing we would skip with track_changes17:02
dansmithso yeah, maybe it's just that17:02
mriedemhttps://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L753 could also avoid some default joins...17:03
dansmithstill once call to placement per instance would be not great17:03
dansmither per compute17:03
mriedemi meant per compute17:03
mriedemright now it looks like this does a full instance list per host including default joined tables17:03
mriedemwhich is i think info_cache and security_groups17:03
mriedemand all the affinity filters care about is the uuid17:03
dansmithyeah probably17:03
melwittgood find17:04
*** AlexeyAbashkin has quit IRC17:04
mriedemhttps://blueprints.launchpad.net/nova/+spec/put-host-manager-instance-info-on-a-diet17:04
*** dtantsur is now known as dtantsur|afk17:04
mriedemmaybe i should have worked on this blueprint some more17:04
*** ykarel|away has quit IRC17:05
*** yamamoto has joined #openstack-nova17:05
dansmithit would be even better to just have a single db call that would take the compute uuids, and return a dict of {host: [uuid, ]}17:05
*** derekh has quit IRC17:05
dansmithalthough it does have a full instance object in the result there.. are we sure that's not used?17:05
mriedempretty sure, read that blueprint17:05
*** mgoddard has quit IRC17:06
mriedemit used to also pull the instance.instance_type_id for the TypeAffinityFilter, but we removed that filter17:06
*** tssurya has quit IRC17:06
mriedems/pull/use/17:06
dansmithyeah, but any filter out there that expects a full list of instances in the host state will care17:06
mriedemsure, but.17:06
mriedemf'em17:06
dansmithwe could put fake things in there that would lazy-load if they touch them :)17:07
dansmithbut okay yeah, that bp text makes sense17:08
mriedemso if you have a filter that cares about the network info cache, and we stop auto-joining on that by default, you'd start lazy-loading and see a perf hit during scheduling17:08
dansmith(he says noting he's the approver)17:08
dansmithyeah17:08
dansmithmakes it look like their fault though! :)17:08
mriedembut at that point, you either (1) live with it (2) fork the host manager code (3) upstream your filter17:08
*** ykarel has joined #openstack-nova17:09
dansmithit'd be nice to get some clarification from them that this is indeed where their hotspot is (grabbing that large instance list)17:09
*** yamamoto has quit IRC17:10
mriedemyeah and they are both gone now17:10
mriedemtired of our antics17:10
openstackgerritMatt Riedemann proposed openstack/nova master: Update instance.availability_zone during live migration  https://review.openstack.org/56770117:11
melwittdid y'all look at the bug I linked earlier? https://bugs.launchpad.net/nova/+bug/173746517:14
openstackLaunchpad bug 1737465 in OpenStack Compute (nova) "[cellv2] the performance issue of cellv2 when creating 500 instances concurrently" [Undecided,Confirmed] - Assigned to Jiang (jiangpf)17:14
dansmithyeah17:14
dansmithI'm sure it's the same thing, but I can't really make sense of most of the text in there17:15
melwittokay, I was thinking they're hitting the same thing in _get_instance_info and that's doing the instance list, it doesn't do anything else17:16
melwittyeah, it's not easy to read but they did point out it was the call to _get_instance_info where they get the slowdown17:16
dansmithyeah, that's why I say I'm sure it's the same17:17
mriedem"Because cellv2 have disable instance info cache." - i assume that means they disabled track_instance_changes17:17
melwittyeah, me too. so you're thinking there could possibly be something else in _get_instance_info that could cause a slowdown other than the instance list, when you said it would be good if they could clarify?17:17
dansmithno, I'm just saying it would be good to clarify, since he linked at a rather high-up spot17:18
*** sidx64_ has joined #openstack-nova17:18
melwittmriedem: I think it means because the upcall is disallowed by default, yeah?17:18
*** mdbooth has quit IRC17:18
melwittdansmith: oh, okay17:18
mriedemmelwitt: no17:18
mriedemtrack_instance_changes is on by default,17:18
mriedemif he's using devstack, then yes that upcall is disabled17:19
mriedemhttps://docs.openstack.org/nova/latest/configuration/config.html#workarounds.disable_group_policy_check_upcall is not disabled by default though17:19
melwittbut with cells v2 it won't cache it, because the upcall is disabled by default, right? oh nevermind17:19
mriedemso out of the box brand new install that's not devstack is going to be doing the rpc blast upcall17:19
mriedemno17:19
mriedemhas nothing to do with cells v217:19
*** sidx64 has quit IRC17:20
melwittyeah, I was thinking maybe that upcall was disabled by default because of cells v2. but it's not17:21
dansmithit just won't ever make it to the scheduler17:21
mriedemif you're doing split MQ17:21
mriedemi'd be kind of surprised if someone was following that setup if they didn't know what they were doing17:21
melwittohh...17:21
openstackgerritMatt Riedemann proposed openstack/nova master: Metadata-API fails to retrieve avz for instances created before Pike  https://review.openstack.org/56787817:24
*** ykarel_ has joined #openstack-nova17:25
*** yamamoto has joined #openstack-nova17:26
*** ykarel has quit IRC17:27
*** janki has quit IRC17:29
*** ykarel_ has quit IRC17:30
*** yamamoto has quit IRC17:30
*** imacdonn has quit IRC17:31
*** imacdonn has joined #openstack-nova17:31
dansmithedleafe: hmm, so I'm a bit confused actually17:32
*** udesale has joined #openstack-nova17:32
*** udesale has quit IRC17:33
*** ykarel has joined #openstack-nova17:33
*** psachin has quit IRC17:37
*** ivve has joined #openstack-nova17:41
*** gjayavelu has joined #openstack-nova17:44
edleafedansmith: do tell17:45
dansmithedleafe: something is off by one, one way or the other and I'm not sure I get it17:46
*** mgoddard has joined #openstack-nova17:46
dansmitheither the test is wrong or needs some other tweak, or17:46
dansmithsomething17:46
edleafeI have a few minutes - let me look17:46
dansmithedleafe: anyway, I've been working on it in parallel to other things and I think I've confused myself out of the way17:46
dansmithso yeah, maybe you should look without me telling you what I'm confused about :)17:46
*** sidx64_ has quit IRC17:46
edleafeI'd much rather confuse myself :)17:47
*** yamamoto has joined #openstack-nova17:48
*** tomtom001 has quit IRC17:52
*** moshele has joined #openstack-nova17:53
*** yamamoto has quit IRC17:53
*** tomtom001 has joined #openstack-nova17:54
*** felipemonteiro has joined #openstack-nova17:54
edleafedansmith: Looks like this needs to be adjusted, too: https://github.com/openstack/nova/blob/master/nova/scheduler/filter_scheduler.py#L36717:56
dansmithedleafe: yeah, I did that17:56
dansmithand I can make the tests pass at that point,17:56
dansmithbut ...isn't that just subtracting one from A and adding it to B?17:56
edleafenope17:56
dansmithwell, assuming you mean changing >= to >17:57
edleafebefore your change, "num_alts" really was the total returned17:57
edleafenot the number of alternates17:57
edleafechange that line to:  >= num_alts + 117:58
edleafethe '1' is the 'selected' in 'selected_plus_alts'17:58
*** links has joined #openstack-nova17:58
*** ykarel has quit IRC17:59
dansmithah, heh, that actually makes it click17:59
dansmithchanging it to >, which is what I did felt wrong17:59
dansmithbut leaving >= and putting the +1 makes it logically make sense to me17:59
edleafeyeah17:59
edleafeI'm re-running the unit tests18:00
edleafeI can push that assuming that the tests pass18:00
dansmithalright18:00
mriedemmelwitt: +2 on lyarwood's nova-lvm fix https://review.openstack.org/#/c/569062/18:02
edleafedansmith: should that patch still be a WIP?18:07
dansmithedleafe: nah I just WIP'd it because no tests18:07
edleafek18:08
openstackgerritMatt Riedemann proposed openstack/nova master: Fakelibvirt migrateToURI3 should provide args according to libvirt doc  https://review.openstack.org/56904718:08
openstackgerritEd Leafe proposed openstack/nova master: Fix interpretation of max_attempts for scheduling alternates  https://review.openstack.org/56912718:08
edleafedansmith: Done ^^18:09
*** tomtom001 has quit IRC18:09
*** yamamoto has joined #openstack-nova18:09
melwittmriedem: you don't want to wait for lyarwood's test additions?18:09
dansmithedleafe: cool18:10
mriedemunit test?18:10
mriedemwas he going to add one?18:10
melwitton the review he said "nova-lvm is looking good so I'll respin with tests later today."18:11
mriedemyeah, ok18:11
edleafemriedem: the tests already covered that18:11
edleafethat's why they broke when he made the change18:11
dansmithedleafe: well, they did, but we probably need one to make sure that we're doing the different thing18:12
dansmithI'm not sure where that should go really though18:12
*** tomtom001 has joined #openstack-nova18:12
mriedemedleafe: ?18:13
mriedemedleafe: the lvm thing?18:13
dansmithmriedem: oh we thought you were talking about the alternates thing18:13
*** yamamoto has quit IRC18:13
dansmithedleafe: we probably just need to validate that max_attempts=1 gets you 1 result18:14
mriedemno i don't talk about that18:14
edleafedansmith: does this test satisfy? https://github.com/openstack/nova/blob/master/nova/tests/unit/scheduler/test_filter_scheduler.py#L915-L91718:22
dansmithedleafe: no, because the essential change is that max_attempts=1 should end up with zero alternates to filter18:23
edleafeok, let me add that18:25
*** eharney has joined #openstack-nova18:27
*** yamamoto has joined #openstack-nova18:30
*** yamamoto has quit IRC18:34
*** links has quit IRC18:35
openstackgerritEd Leafe proposed openstack/nova master: Fix interpretation of max_attempts for scheduling alternates  https://review.openstack.org/56912718:38
edleafedansmith: ^^ now with shiny new unit test18:38
openstackgerritMatt Riedemann proposed openstack/nova master: Avoid unnecessary joins in HostManager._get_instances_by_host  https://review.openstack.org/56921818:42
dansmithedleafe: I forgot about how that one test has num_alternates=018:44
dansmithwhich is kiiinda the same thing18:44
openstackgerritMatt Riedemann proposed openstack/nova master: Avoid unnecessary joins in HostManager._get_instances_by_host  https://review.openstack.org/56921818:44
mriedemdansmith: melwitt: ^ the small optimization noted earlier18:44
*** damien_r has joined #openstack-nova18:51
*** yamamoto has joined #openstack-nova18:51
dansmithedleafe: you know, actually I think what we probably want is to mock out the interface between _schedule() and _get_alternate_hosts() and make sure that num_alts out and in from those (respectively) includes the new offset18:55
*** yamamoto has quit IRC18:55
dansmithedleafe: because testing them together just hides that we made a change, which is why that new unit test is kinda forced18:55
dansmithedleafe: I'm happy to do that if you want18:55
dansmith...if you agree18:55
*** dklyle has joined #openstack-nova18:56
melwittmriedem: ack18:57
*** chyka has quit IRC19:00
*** eharney has quit IRC19:00
*** felipemonteiro__ has joined #openstack-nova19:04
edleafedansmith: go for it. I have meetings for the next two hours19:06
edleafedansmith: and looking at the code, it *was* working correctly, just poorly named. If we had simply changed 'num_alts' to 'num_returned', it would have continued to work, and made more sense to someone reading it19:07
*** felipemonteiro has quit IRC19:08
*** damien_r has quit IRC19:09
*** agomerz has joined #openstack-nova19:10
*** agomerz has quit IRC19:11
*** agomerz has joined #openstack-nova19:11
*** yamamoto has joined #openstack-nova19:12
*** chyka has joined #openstack-nova19:13
*** yamamoto has quit IRC19:16
*** moshele has quit IRC19:19
*** moshele has joined #openstack-nova19:21
openstackgerritEric Fried proposed openstack/nova master: Normalize inventory from update_provider_tree  https://review.openstack.org/56913219:22
openstackgerritEric Fried proposed openstack/nova master: libvirt: get_inventory => update_provider_tree  https://review.openstack.org/56044419:22
openstackgerritEric Fried proposed openstack/nova master: libvirt: Don't report DISK_GB if sharing  https://review.openstack.org/56045919:22
openstackgerritEric Fried proposed openstack/nova master: ProviderTree.has_inventory_changed for new fields  https://review.openstack.org/56922819:22
efriededleafe, cdent, dansmith: y'all may want to take a look at these ^19:22
efriedthe bottom two anyway (which are intended to fix tempest on the top two)19:22
efriedbhagyashris_: FYI, hoping those bottom two patches clear up the tempest failures.19:24
efriedbhagyashris_: We were running out of hosts in tempest because we were no longer setting allocation ratios.  I imagine the 16.0 allocation ratio on VCPU was what was killing us.19:24
*** eharney has joined #openstack-nova19:25
*** jmlowe has quit IRC19:27
*** dtantsur|afk has quit IRC19:29
*** yamamoto has joined #openstack-nova19:32
cdentseems sane, efried, left a query on the second one19:33
*** slaweq has quit IRC19:34
efriedcdent: Thanks.  Seems like we're reworking the allocation ratio thing - but I think it still is (or can be) driven from conf and/or via the compute node record, and the virt still doesn't necessarily have access to the information.19:34
efriedcdent: I really wanted to catch Jay to get the skinny on that, but he seems to be out today.19:34
*** slaweq has joined #openstack-nova19:35
efriedcdent: As it stands, if the virt driver thinks it knows better, it can set those and _normalize... won't overwrite them.19:35
cdentYeah, that was the source of my confusion: given _now_, what you've got seems right19:35
efriedGlad we agree on that.19:36
*** dtantsur has joined #openstack-nova19:36
efriedAnd I don't know what all the future is supposed to hold for this.  So _now_ is about all I can account for...19:36
*** yamamoto has quit IRC19:37
cdentIndeed19:37
* cdent goes to pack19:37
efriedSee you in 'couver.19:38
*** felipemonteiro__ has quit IRC19:39
efriedmriedem: I caught up with Gerald.  He cited a customer scenario with 500 volumes on an instance.  So 1024 seems like a safe and relatively future-proof number.19:39
*** felipemonteiro has joined #openstack-nova19:39
*** dtantsur has quit IRC19:40
*** sidx64 has joined #openstack-nova19:48
*** moshele has quit IRC19:50
*** dtantsur has joined #openstack-nova19:51
dansmithefried: um, I had already provided a customer scenario with 600, although no other detail, so clearly 1024 makes sense in a real-world situation19:52
efrieddansmith: Okay, I didn't follow that conversation to its end.  Just got an answer so thought I would post it.19:52
*** sidx64 has quit IRC19:52
*** yamamoto has joined #openstack-nova19:53
dansmithefried: how is "some customer wants to use 500" a reasonable argument? I guess my overt sarcasm wasn't overt enough19:53
efriednow you've lost me.19:54
dansmithefried: I want to hear the *reason* for wanting to use 500 volumes on a single guest, not just that someone thinks it's a good idea19:55
efriedYou mean we should require said customers to give justification that we agree with, as opposed to letting us tell them how many volumes they should be using instead?19:55
efriedyeah, got it.19:55
dansmiththe bug/bp being filed seems to indicate that someone somewhere wants to do it19:56
efriedIn this case, the customer is using IBMi and has 16 FC adapters and is doing huge striping to get desired performance.19:56
dansmithhah, I was going to say raid0ing of 1GB volumes19:56
*** avolkov has quit IRC19:56
*** jmlowe has joined #openstack-nova19:57
*** yamamoto has quit IRC19:59
openstackgerritMerged openstack/nova master: Deduplicate config/policy reference docs from main index  https://review.openstack.org/56484620:07
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Trim the fat on HostState.instances  https://review.openstack.org/56924720:09
mriedemi thorougly enjoy what you have to say for this new config option if you enable it20:10
mriedem^20:10
cdentstriping across 500 volumes sounds kind of fun. Like: whatever they are doing, they must think it is pretty serious. Thus: fun.20:10
dansmithmore fun for the operator that gave a tenant 500 volume quota and realized they attached them all to a single instance to hack around performance limits20:11
*** tssurya has joined #openstack-nova20:11
efriedmriedem: Fast-approved20:14
mriedemha20:14
*** wolverineav has quit IRC20:16
*** yamamoto has joined #openstack-nova20:16
tssuryamriedem: sorry was afk, but thanks for fixing the nits in both the patches20:17
dansmithmriedem: you really want to provide a workaround knob for that?20:19
*** sahid has quit IRC20:20
mriedemdansmith: as in just let it break?20:20
dansmithyeah20:20
*** yamamoto has quit IRC20:20
dansmithI mean, I appreciate the care, but..20:20
mriedemi didn't see any HostInstance.instances usage in the huawei product code but...20:21
dansmithalso,20:21
dansmithif we change how we do that query, we could populate the id field, which would make it actually lazy-load the things they want20:21
dansmithright now it will fail with20:21
dansmith"orphaned object" errors20:21
dansmithor make instance lazy-load by uuid if it doesn'talready20:22
* dansmith checks20:22
*** jmlowe has quit IRC20:22
artomOr just outright own the full thing and change the object to be a list of instance UUIDs?20:22
artomNot sure how that would work for backwards compatibility tho20:22
mriedemso first fellas, WIP clearly20:23
dansmithoh it does load by uuid, so make the context right and it will lazy-load20:23
dansmithmriedem: I know, I'm just asking :)20:23
mriedemsecond, yeah long term i want to do away with the dict and just make HostState.instances a list of uuids20:23
artommriedem, too bad, you gave me an excuse to procrastinate real work. Fell the full wrath of my nitpicking.20:23
mriedemdansmith: so {uuid: objects.Instance(cctxt, uuid=uuid)}?20:23
dansmithmriedem: yup20:23
mriedemi fell it real good20:23
dansmithmriedem: then you can just not do the conf option, it'll be slow if they touch it, and we can remove it later20:24
mriedemdansmith: yeah that's agood point20:24
mriedemdamn good point20:24
dansmithmriedem: snarky comments still required though20:24
dansmith# NOTE(mriedem): Set the timer on this bomb and walk out casually20:25
mriedemdansmith: setting the context on the instance object won't lazy-load all fields20:31
mriedemjust those in INSTANCE_OPTIONAL_ATTRS20:31
dansmithshould call _load_generic, which will do anything20:31
*** fragatina has quit IRC20:32
mriedemif attrname not in INSTANCE_OPTIONAL_ATTRS:20:32
mriedemraise exception.ObjectActionError(20:32
dansmithoh, heh,20:32
dansmithI dunno why we did that20:32
mriedemso now my filter on instance.default_ephemeral_device no longer works20:32
dansmithbecause load_generic will do it20:32
*** moshele has joined #openstack-nova20:33
dansmithit's from 2013, nuke it20:33
dansmithit looks like that was just trying to make it not do an empty load for something it wasn't going to be able to satisfy,20:34
dansmithsince it was trying to figure out what to put in extra_attrs20:34
*** tssurya has quit IRC20:35
dansmithand that was before we had load_generic20:35
dansmithso when we added the generic thing we probably just didn't remove the thing at the top to let you use it for anything20:35
dansmithwe should also have that fill in any field it gets that isn't already set,20:36
dansmithso you don't load the instance twice for two regular fields20:36
dansmithI can make those changes in one patch if you want20:36
mriedem"we should also have that fill in any field it gets that isn't already set," - i believe it will do that for all non-joined fields anyway20:36
mriedembecause it just does a normal get and load from db20:36
dansmithload_generic won't,20:36
*** yamamoto has joined #openstack-nova20:37
dansmithit will only copy over the one thing you asked for20:37
mriedemoh i see20:37
mriedemif instance.obj_attr_is_set(attrname):20:37
mriedem            self[attrname] = instance[attrname]20:37
openstackgerritMerged openstack/nova master: Cleanup ugly stub in TestLocalDeleteAllocations  https://review.openstack.org/56199720:37
dansmithyeah20:37
dansmithI mean,20:37
dansmithit nicely punishes them hard,20:37
dansmithbut probably not the best thing to do :P20:37
mriedemi just sent to the ML btw20:38
mriedemefried: http://lists.openstack.org/pipermail/openstack-dev/2018-May/130624.html20:38
efriedmriedem: ack20:38
*** Guest37211 has quit IRC20:39
mriedemalso related, we probably no longer need to default join on security_groups since that would only ever be populated for nova-network20:39
*** ccamacho has joined #openstack-nova20:40
mriedemdansmith: if you want, what i do need right now is to handle the NOTE in InstanceList.v20:40
mriedem*get_uuids_by_host20:40
dansmithhah20:41
*** yamamoto has quit IRC20:41
dansmithyeah I can do that too20:41
dansmiththere has to be some animated gif that applies well to that20:41
mriedemi've been meaning to do that since https://review.openstack.org/#/c/563234/1/nova/api/openstack/compute/services.py@22220:42
dansmithooh, yessss, I made unit tests fail with infinite recursion20:42
*** pchavva has quit IRC20:43
dansmithheh, instance will trigger a double lazy load on itself apparently, which I uncovered by removing this check20:47
dansmiththat's nice20:47
mriedemyou also have a note in that exact code20:48
mriedemabout recursion20:48
edmondswany stable cores around to review https://review.openstack.org/#/c/567599 ?20:48
dansmithI know20:48
edmondswbeen out there a while, and it's an easy review20:49
*** artom has quit IRC20:50
*** throwsb1 has quit IRC20:53
openstackgerritMerged openstack/nova master: Remove mox in test_xenapi.py (3)  https://review.openstack.org/56464520:56
*** Guest37211 has joined #openstack-nova20:56
*** yamamoto has joined #openstack-nova20:59
*** fragatina has joined #openstack-nova20:59
*** fragatina has quit IRC21:01
*** fragatina has joined #openstack-nova21:02
*** dtantsur has quit IRC21:02
*** dtantsur has joined #openstack-nova21:03
*** fragatina has quit IRC21:03
*** yamamoto has quit IRC21:04
*** fragatina has joined #openstack-nova21:04
*** wolverineav has joined #openstack-nova21:07
dansmithmriedem: funny thing happened on the way to the forum: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L2596-L260721:11
mriedemedmondsw: easy for me to -121:12
mriedemha21:14
edmondswesberglu ^21:14
mriedemdansmith: one difference with that,21:14
mriedemthe project_only=False kwarg to model_query21:14
dansmithaww21:14
mriedemyup21:14
dansmithwell, I'll show you21:15
dansmither,21:16
dansmithproject_only=False by default on mode_query21:16
*** esberglu has quit IRC21:16
edmondswmriedem this fixes a PowerVM CI breakage. If we regressed, the PowerVM CI would blow up. And the regression would have to be a change in powervm code, so reviewers better be checking the powervm ci. Is that not sufficient?21:17
openstackgerritMatt Riedemann proposed openstack/nova master: Trim the fat on HostState.instances  https://review.openstack.org/56924721:17
mriedemdamn you smith21:18
mriedemedmondsw: it'll be a cold day in hell before i...21:20
openstackgerritEric Fried proposed openstack/nova-specs master: update add-consumer-generation to focus on API  https://review.openstack.org/56556521:20
efriedmriedem: ^21:20
*** yamamoto has joined #openstack-nova21:20
efriedand dansmith ^21:21
openstackgerritMerged openstack/nova master: Remove unnecessary 'to_primitive' call  https://review.openstack.org/56853221:21
openstackgerritMerged openstack/nova master: Fakelibvirt migrateToURI3 should provide args according to libvirt doc  https://review.openstack.org/56904721:21
*** yamamoto has quit IRC21:26
mriedemefried: left a comment also21:27
*** felipemonteiro has quit IRC21:28
*** felipemonteiro has joined #openstack-nova21:28
*** felipemonteiro has quit IRC21:28
*** felipemonteiro has joined #openstack-nova21:28
openstackgerritDan Smith proposed openstack/nova master: Make instance able to lazy-load almost everything  https://review.openstack.org/56926721:30
openstackgerritDan Smith proposed openstack/nova master: Expose instance_get_all_uuids_by_host() from DB API and use it  https://review.openstack.org/56926821:30
*** agomerz has quit IRC21:31
dansmithmriedem: ^21:31
dansmithmriedem: we had pretty anal testing of the load behaviors for various special cases,21:33
dansmithso keeping those tests unchanged and allowing the new case makes me fairly confident in that21:34
*** hemna_ has quit IRC21:34
efrieddansmith: The "sentinel proj/user conf option" business was your idea, right?  You wanna post a delta on the spec accordingly?21:35
efriedMaybe if we get enough hands on this spec, there'll be nobody left to approve it.21:35
dansmithefried: (a) I don't like calling it a sentinel, but (b) I really wish we could just update the spec afterwards, because we've already wandered around a bunch of times21:35
efrieddansmith: But Matt will make fun of your haircut if we do that.21:36
dansmithif people really need it then I will, but..21:36
efriedmriedem: your call ^21:36
dansmithmaybe I should so I can put "it's not an effing senintel people" in bold21:36
dansmiththat spec will be really yelly at that point21:37
dansmiththe angst is well codified21:37
*** fragatina has quit IRC21:39
*** mgoddard has quit IRC21:40
*** yamamoto has joined #openstack-nova21:43
mriedemsince i haven't gotten into the code yeah i'd like that21:43
*** hughsaunders has quit IRC21:44
*** edmondsw has quit IRC21:46
efriedEither of y'all have any idea how allocation_ratio values are ending up 0.0 here?  http://logs.openstack.org/32/569132/2/check/openstack-tox-py35/0ad1d4e/testr_results.html.gz21:46
*** fragatina has joined #openstack-nova21:46
*** wolverineav has quit IRC21:46
efriedthis test passes for me locally.21:47
*** hughsaunders has joined #openstack-nova21:47
*** yamamoto has quit IRC21:49
*** takashin has joined #openstack-nova21:49
efriedokay, I think I figured it out.  There's another test *somewhere* stomping on those values.  Just gotta track it down...21:49
*** lyan has quit IRC21:51
*** chyka_ has joined #openstack-nova21:52
*** chyka has quit IRC21:56
mriedem"gifts-for-mriedem"21:56
mriedemthat's nice21:56
*** chyka_ has quit IRC21:57
*** eharney has quit IRC21:57
*** burt has quit IRC21:58
dansmithheh21:59
*** wolverineav has joined #openstack-nova22:00
*** agomerz has joined #openstack-nova22:01
openstackgerritDan Smith proposed openstack/nova master: Fix interpretation of max_attempts for scheduling alternates  https://review.openstack.org/56912722:02
*** rcernin has joined #openstack-nova22:04
*** hemna_ has joined #openstack-nova22:05
mriedemdansmith: you missed a question i had in the earlier PS in ^22:05
dansmithapparently I broke unit tests on that base one22:05
*** yamamoto has joined #openstack-nova22:05
mriedemthere might still be an optimization to be made in the multicreate case22:05
dansmithmriedem: I thought you were answering your own question below22:06
dansmithlet me re-read22:06
dansmithoh, I see because we're weighing there between them22:06
dansmither, re-weighing I should say22:08
*** baoli has quit IRC22:09
dansmithI guess I'm not sure why we need to re-weigh there22:10
mriedemper the comment,22:10
*** baoli has joined #openstack-nova22:10
mriedemwe "claim" from the selected hosts before we start looking for alternates22:10
*** yamamoto has quit IRC22:10
dansmithright22:10
mriedemso we want to cleanup the alternate hosts before selecting them22:10
dansmithdoes re-filtering dump out the ones we've claimed or something?22:10
mriedemit might22:10
mriedemif they were filled up22:10
dansmithoh, I see, I thought that was handled by consume?22:12
dansmithotherwise it's no different for the primaries if we have a lot of those22:13
dansmithor..22:13
dansmithis that why we stripe across hosts when doing num_instances>1?22:13
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in test_conductor.py (1)  https://review.openstack.org/56465822:13
dansmithoh jeez, I'm failing like all the functional tests22:13
mriedemhttps://www.youtube.com/watch?v=gGrNAB45CtY22:14
*** baoli has quit IRC22:14
openstackgerritMatt Riedemann proposed openstack/nova master: Trim the fat on HostState.instances  https://review.openstack.org/56924722:15
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in test_conductor.py (2)  https://review.openstack.org/56465922:15
*** felipemonteiro has quit IRC22:20
*** hemna_ has quit IRC22:24
*** hemna_ has joined #openstack-nova22:24
openstackgerritDan Smith proposed openstack/nova master: Make instance able to lazy-load almost everything  https://review.openstack.org/56926722:24
openstackgerritDan Smith proposed openstack/nova master: Expose instance_get_all_uuids_by_host() from DB API and use it  https://review.openstack.org/56926822:24
*** yamamoto has joined #openstack-nova22:26
*** chyka has joined #openstack-nova22:28
openstackgerritTakashi NATSUME proposed openstack/nova stable/queens: Fix auth_url example in hypervisor-hyper-v.rst  https://review.openstack.org/56928422:29
*** wolverineav has quit IRC22:29
*** yamamoto has quit IRC22:31
*** chyka has quit IRC22:32
*** mriedem is now known as mriedem_afk22:36
*** threestrands has joined #openstack-nova22:37
*** mriedem_afk has quit IRC22:38
openstackgerritEric Fried proposed openstack/nova master: Normalize inventory from update_provider_tree  https://review.openstack.org/56913222:40
openstackgerritEric Fried proposed openstack/nova master: libvirt: get_inventory => update_provider_tree  https://review.openstack.org/56044422:40
openstackgerritEric Fried proposed openstack/nova master: libvirt: Don't report DISK_GB if sharing  https://review.openstack.org/56045922:40
*** gjayavelu has quit IRC22:40
*** gjayavelu has joined #openstack-nova22:40
*** hongbin has quit IRC22:40
*** slaweq has quit IRC22:44
*** slaweq has joined #openstack-nova22:44
openstackgerritMerged openstack/nova stable/queens: Stringify instance UUID  https://review.openstack.org/56759922:46
*** yamamoto has joined #openstack-nova22:47
*** d34dh0r53 has quit IRC22:47
*** d34dh0r53 has joined #openstack-nova22:47
*** yamamoto has quit IRC22:51
*** mmehan has quit IRC22:51
*** claudiub has quit IRC22:52
*** cdent has quit IRC22:54
*** moshele has quit IRC22:55
*** moshele has joined #openstack-nova22:59
openstackgerritDan Smith proposed openstack/nova master: Fix interpretation of max_attempts for scheduling alternates  https://review.openstack.org/56912723:03
*** edmondsw has joined #openstack-nova23:03
*** yamamoto has joined #openstack-nova23:07
*** edmondsw has quit IRC23:08
*** yamamoto has quit IRC23:12
*** moshele has quit IRC23:23
*** artom has joined #openstack-nova23:24
*** baoli has joined #openstack-nova23:25
*** baoli has quit IRC23:25
*** yamamoto has joined #openstack-nova23:28
openstackgerritMatt Riedemann proposed openstack/nova master: Avoid unnecessary joins in HostManager._get_instances_by_host  https://review.openstack.org/56921823:31
openstackgerritMatt Riedemann proposed openstack/nova master: Trim the fat on HostState.instances  https://review.openstack.org/56924723:31
*** yamamoto has quit IRC23:32
openstackgerritMatt Riedemann proposed openstack/nova master: Trim the fat on HostState.instances  https://review.openstack.org/56924723:33
*** mlavalle has quit IRC23:35
openstackgerritMatt Riedemann proposed openstack/nova master: Make nova-lvm run in check on libvirt changes and compute API tests  https://review.openstack.org/56914923:41
*** edmondsw has joined #openstack-nova23:46
*** tetsuro has joined #openstack-nova23:47
*** yamamoto has joined #openstack-nova23:50
*** yamamoto has quit IRC23:55

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!