Wednesday, 2018-05-09

*** hshiina2 has joined #openstack-nova00:00
*** hshiina|afk has quit IRC00:04
*** mingyu has quit IRC00:05
*** bkopilov__ has joined #openstack-nova00:06
*** bkopilov_ has joined #openstack-nova00:06
openstackgerritArtom Lifshitz proposed openstack/nova master: Service version check for NUMA live migration  https://review.openstack.org/56672300:08
*** mingyu has joined #openstack-nova00:09
*** mingyu has quit IRC00:11
*** fragatina has quit IRC00:12
*** takashin has joined #openstack-nova00:17
*** MasterofJOKers has quit IRC00:17
*** dgonzalez has quit IRC00:17
*** dgonzalez has joined #openstack-nova00:17
*** MasterofJOKers has joined #openstack-nova00:18
*** ebbex has quit IRC00:18
*** ebbex has joined #openstack-nova00:20
*** Swami_ has quit IRC00:21
*** Swami has quit IRC00:21
*** yingjun has joined #openstack-nova00:23
*** tuanla____ has joined #openstack-nova00:36
*** gyee has quit IRC00:36
openstackgerritArtom Lifshitz proposed openstack/nova master: Service version check for NUMA live migration  https://review.openstack.org/56672300:38
*** Nel1x has joined #openstack-nova00:40
*** Dinesh_Bhor has joined #openstack-nova00:42
*** mriedem has quit IRC00:44
*** harlowja has quit IRC00:51
openstackgerritfupingxie proposed openstack/nova master: Update the parameter explain when update a volume attachment  https://review.openstack.org/56518100:52
*** andreas_s has joined #openstack-nova00:54
*** tiendc has joined #openstack-nova00:57
*** nicolasbock has quit IRC00:57
*** andreas_s has quit IRC00:58
*** phuongnh has joined #openstack-nova01:01
*** felipemonteiro__ has joined #openstack-nova01:08
*** gjayavelu has quit IRC01:10
*** tuanla____ has quit IRC01:12
*** trungnv has quit IRC01:12
*** tuanla____ has joined #openstack-nova01:12
*** trungnv has joined #openstack-nova01:13
*** hshiina has joined #openstack-nova01:13
*** armaan has quit IRC01:15
*** hshiina2 has quit IRC01:16
*** armaan has joined #openstack-nova01:16
openstackgerritArtom Lifshitz proposed openstack/nova master: WIP: Service version check for NUMA live migration  https://review.openstack.org/56672301:18
*** username_ has joined #openstack-nova01:22
openstackgerritMerged openstack/nova master: Convert fping API to processutils.execute()  https://review.openstack.org/56414401:22
*** username_ is now known as username__01:23
*** felipemonteiro__ has quit IRC01:27
*** zhaochao has joined #openstack-nova01:28
*** hongbin has joined #openstack-nova01:37
*** gongysh has joined #openstack-nova01:37
*** zcorneli has quit IRC01:40
*** hongbin_ has joined #openstack-nova01:44
*** hongbin has quit IRC01:45
*** lei-zh has joined #openstack-nova01:46
*** psachin` has joined #openstack-nova02:10
*** yamamoto has joined #openstack-nova02:20
*** tiendc has quit IRC02:20
*** tiendc has joined #openstack-nova02:21
*** yamamoto has quit IRC02:24
*** psachin` has quit IRC02:26
takashin02:35
*** username__ has quit IRC02:35
*** yamamoto has joined #openstack-nova02:37
*** psachin has joined #openstack-nova02:42
openstackgerritfupingxie proposed openstack/nova master: Update the parameter explain when update a volume attachment  https://review.openstack.org/56518102:44
*** vladikr has quit IRC02:44
*** vladikr has joined #openstack-nova02:45
*** fragatina has joined #openstack-nova02:55
*** fragatina has quit IRC02:55
*** fragatina has joined #openstack-nova02:56
*** fragatina has quit IRC02:57
*** fragatina has joined #openstack-nova02:57
*** lei-zh has quit IRC03:03
*** lei-zh has joined #openstack-nova03:03
*** rcernin has quit IRC03:14
*** slaweq has joined #openstack-nova03:16
*** slaweq has quit IRC03:20
*** vivsoni has quit IRC03:25
*** vivsoni has joined #openstack-nova03:25
*** andreas_s has joined #openstack-nova03:28
*** tuanla____ has quit IRC03:29
*** takashin has quit IRC03:29
*** tuanla____ has joined #openstack-nova03:30
*** yamamoto has quit IRC03:31
*** andreas_s has quit IRC03:32
*** udesale has joined #openstack-nova03:36
*** threestrands has joined #openstack-nova03:38
*** hiro-kobayashi has joined #openstack-nova03:41
*** links has joined #openstack-nova03:42
*** yamamoto has joined #openstack-nova03:44
*** gyan_ has joined #openstack-nova03:44
*** hongbin_ has quit IRC03:46
*** dave-mccowan has quit IRC03:48
*** wolverineav has joined #openstack-nova03:58
*** udesale has quit IRC04:00
*** udesale has joined #openstack-nova04:01
*** Nel1x has quit IRC04:08
*** janki has joined #openstack-nova04:10
openstackgerritMerged openstack/nova master: Add docs for hw_video:ram_max_mb flavor extra spec  https://review.openstack.org/56707004:11
*** yingjun has quit IRC04:15
*** cburgess_ has quit IRC04:16
*** vladikr has quit IRC04:16
*** vladikr has joined #openstack-nova04:16
*** amotoki has joined #openstack-nova04:19
*** vladikr has quit IRC04:24
*** vladikr has joined #openstack-nova04:25
*** cburgess has joined #openstack-nova04:26
*** udesale_ has joined #openstack-nova04:36
*** gongysh has quit IRC04:36
*** sridharg has joined #openstack-nova04:38
*** udesale has quit IRC04:39
*** ratailor has joined #openstack-nova04:42
*** Shilpa has joined #openstack-nova04:44
openstackgerritJake Yip proposed openstack/nova master: Add --before to nova-manage db archive_deleted_rows  https://review.openstack.org/55675104:44
*** Shilpa has quit IRC04:45
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return nested providers in get_by_request  https://review.openstack.org/56711304:46
openstackgerritMichael Still proposed openstack/nova master: Move image conversion to privsep.  https://review.openstack.org/55443704:50
openstackgerritMichael Still proposed openstack/nova master: We don't need utils.trycmd any more.  https://review.openstack.org/55443904:50
openstackgerritMichael Still proposed openstack/nova master: We no longer need rootwrap.  https://review.openstack.org/55443804:50
*** takashin has joined #openstack-nova04:50
openstackgerritMerged openstack/nova master: log stale allocations as WARNING instead of DEBUG  https://review.openstack.org/56496404:51
openstackgerritMichael Still proposed openstack/nova master: Move IVS VIF plugging into the new utilities module.  https://review.openstack.org/55755204:54
openstackgerritMichael Still proposed openstack/nova master: Move create_tap_dev to the new utility module.  https://review.openstack.org/55783504:54
openstackgerritMichael Still proposed openstack/nova master: Move set_vf_interface_vlan to the new utility module.  https://review.openstack.org/55848704:54
*** abhishekk has joined #openstack-nova04:55
openstackgerritMerged openstack/nova master: Convert xenapi's xvp console to processutils.  https://review.openstack.org/56414504:57
*** Dinesh_Bhor has quit IRC05:00
*** Dinesh_Bhor has joined #openstack-nova05:03
openstackgerritTakahito Hirose proposed openstack/python-novaclient master: api_version decorator becomes an error in Python 3.5.0.  https://review.openstack.org/56470205:04
*** tomtom001 has quit IRC05:05
*** tomtom001 has joined #openstack-nova05:06
*** lei-zh has quit IRC05:07
*** slaweq has joined #openstack-nova05:11
*** yamamoto has quit IRC05:15
*** slaweq has quit IRC05:16
*** gongysh has joined #openstack-nova05:18
*** yamamoto has joined #openstack-nova05:20
*** udesale_ has quit IRC05:22
*** abhishekk has quit IRC05:31
*** Swami has joined #openstack-nova05:32
*** Swami_ has joined #openstack-nova05:32
*** hoonetorg has quit IRC05:33
*** yikun__ has quit IRC05:33
*** yikun__ has joined #openstack-nova05:34
*** moshele has joined #openstack-nova05:34
*** Eran_Kuris has joined #openstack-nova05:35
*** gongysh has quit IRC05:37
*** rajinir has quit IRC05:38
*** fnordahl has quit IRC05:40
*** lei-zh has joined #openstack-nova05:41
*** ratailor has quit IRC05:41
*** fnordahl has joined #openstack-nova05:42
*** hoonetorg has joined #openstack-nova05:44
*** tssurya has joined #openstack-nova05:46
*** evin has quit IRC05:47
*** yingjun has joined #openstack-nova05:48
*** udesale_ has joined #openstack-nova05:51
*** udesale_ has quit IRC05:53
*** udesale has joined #openstack-nova05:53
*** threestrands has quit IRC05:54
*** ratailor has joined #openstack-nova05:55
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return nested providers in get_by_request  https://review.openstack.org/56711305:56
*** pcaruana has joined #openstack-nova05:57
*** bhujay has joined #openstack-nova05:59
*** vladikr has quit IRC06:02
*** vladikr has joined #openstack-nova06:02
*** ratailor has quit IRC06:05
*** ratailor_ has joined #openstack-nova06:05
*** armaan has quit IRC06:05
*** armaan has joined #openstack-nova06:05
*** vladikr has quit IRC06:08
*** vladikr has joined #openstack-nova06:08
*** Swami has quit IRC06:13
*** Swami_ has quit IRC06:13
*** armaan_ has joined #openstack-nova06:13
*** evin has joined #openstack-nova06:15
*** armaan has quit IRC06:16
*** vladikr has quit IRC06:16
*** Dinesh_Bhor has quit IRC06:16
*** vladikr has joined #openstack-nova06:16
*** Dinesh_Bhor has joined #openstack-nova06:18
*** annp has joined #openstack-nova06:22
*** gbarros has joined #openstack-nova06:22
*** tianhui_ has joined #openstack-nova06:24
*** andreas_s has joined #openstack-nova06:25
*** andreas_s has quit IRC06:25
*** andreas_s has joined #openstack-nova06:25
*** tianhui has quit IRC06:26
*** lei-zh has quit IRC06:28
*** lei-zh1 has joined #openstack-nova06:28
*** MasterofJOKers_ has joined #openstack-nova06:33
*** armaan_ has quit IRC06:33
*** armaan has joined #openstack-nova06:34
*** MasterofJOKers has quit IRC06:34
*** MasterofJOKers_ is now known as MasterofJOKers06:34
*** jaosorior has joined #openstack-nova06:34
*** ccamacho has quit IRC06:38
*** brault has joined #openstack-nova06:38
*** ccamacho has joined #openstack-nova06:39
*** gbarros has quit IRC06:49
*** slaweq has joined #openstack-nova06:51
*** yikun__ has quit IRC06:56
*** yikun__ has joined #openstack-nova06:56
*** yingjun has quit IRC06:56
*** wolverineav has quit IRC06:58
*** wolverineav has joined #openstack-nova06:58
openstackgerritMerged openstack/nova master: Remove IronicHostManager and baremetal scheduling options  https://review.openstack.org/56580507:01
*** wolverineav has quit IRC07:03
*** yingjun has joined #openstack-nova07:03
*** wolverineav has joined #openstack-nova07:04
*** ratailor__ has joined #openstack-nova07:08
*** wolverineav has quit IRC07:10
*** yamamoto_ has joined #openstack-nova07:10
*** ratailor_ has quit IRC07:10
*** yamamoto has quit IRC07:10
*** lei-zh1 has quit IRC07:10
*** lei-zh1 has joined #openstack-nova07:11
*** ratailor_ has joined #openstack-nova07:15
*** alexchadin has joined #openstack-nova07:16
*** ratailor__ has quit IRC07:17
*** gjayavelu has joined #openstack-nova07:19
*** moshele has quit IRC07:20
*** lei-zh1 has quit IRC07:21
*** tbachman has quit IRC07:21
*** lei-zh1 has joined #openstack-nova07:22
*** tesseract has joined #openstack-nova07:22
*** wolverineav has joined #openstack-nova07:22
openstackgerritfupingxie proposed openstack/nova master: Update the parameter explain when update a volume attachment  https://review.openstack.org/56518107:23
*** tbachman has joined #openstack-nova07:24
*** moshele has joined #openstack-nova07:24
*** moshele has quit IRC07:25
*** yamamoto_ has quit IRC07:29
*** yamamoto has joined #openstack-nova07:30
*** bertys____ has joined #openstack-nova07:31
*** masber has quit IRC07:36
*** amoralej|off is now known as amoralej07:36
*** mgoddard has joined #openstack-nova07:36
*** ragiman has joined #openstack-nova07:39
*** abhishekk has joined #openstack-nova07:40
*** alexchadin has quit IRC07:41
*** mdnadeem has joined #openstack-nova07:41
*** mdnadeem has quit IRC07:41
*** alexchadin has joined #openstack-nova07:42
*** jangutter has joined #openstack-nova07:48
*** armaan has quit IRC07:50
*** armaan has joined #openstack-nova07:51
*** jpena|off is now known as jpena07:51
openstackgerritsahid proposed openstack/nova master: compute: introduce cpu_shared_set option  https://review.openstack.org/56191207:52
openstackgerritsahid proposed openstack/nova master: libvirt: always pass emulator threads policy  https://review.openstack.org/56191307:52
openstackgerritsahid proposed openstack/nova master: libvirt: place emulator threads on CONF.cpu_shared_set  https://review.openstack.org/51089707:52
*** dtantsur|afk is now known as dtantsur07:53
*** gjayavelu has quit IRC07:57
*** hiro-kobayashi has quit IRC08:00
*** namnh has joined #openstack-nova08:02
*** takashin has left #openstack-nova08:03
*** armaan has quit IRC08:05
*** armaan has joined #openstack-nova08:06
*** yingjun has quit IRC08:07
*** liuzz_ has quit IRC08:07
*** mdbooth has joined #openstack-nova08:11
*** mdnadeem has joined #openstack-nova08:12
*** liuzz has joined #openstack-nova08:13
*** yamamoto has quit IRC08:15
*** yamamoto has joined #openstack-nova08:17
*** dougsz has joined #openstack-nova08:17
*** wolverineav has quit IRC08:18
openstackgerritJan Gutter proposed openstack/nova master: Add plumbing for Contrail/Tungsten Fabric offloads  https://review.openstack.org/56714708:20
openstackgerritJan Gutter proposed openstack/nova-specs master: Spec to implement vRouter HW offloads  https://review.openstack.org/56714808:22
stephenfinjaypipes: By mechanisms, I was referring to the various ways of a network can be configured and segmented, either L2 or L3. Local means connectivity is only on a single host https://gist.github.com/bonclay7/458b353f997e05db374d08:26
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return nested providers in get_by_request  https://review.openstack.org/56711308:26
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add traits check in nested provider cadidates  https://review.openstack.org/56715008:26
openstackgerritTetsuro Nakamura proposed openstack/nova master: Fix broken allocation candidates with traits  https://review.openstack.org/56715108:26
stephenfinjaypipes: Also https://ask.openstack.org/en/question/51388/08:28
tetsuro^ jauypipes, efried, bauzas: started nested allocation candidates branch in a different way.08:28
*** udesale_ has joined #openstack-nova08:28
*** udesale has quit IRC08:28
*** sridharg has quit IRC08:29
*** sridharg has joined #openstack-nova08:31
kashyapstephenfin: Hey, when you can, see what's wrong with my test here: https://review.openstack.org/#/c/565242/5/nova/tests/unit/virt/libvirt/test_driver.py08:31
*** lucas-bbl is now known as lucasagomes08:31
*** vladikr has quit IRC08:32
*** vladikr has joined #openstack-nova08:33
openstackgerritMerged openstack/nova master: Remove unused methods in nova/compute/utils.py  https://review.openstack.org/56685508:33
*** lpetrut has joined #openstack-nova08:33
* stephenfin looks08:33
*** jmccarthy has joined #openstack-nova08:35
*** edmondsw has joined #openstack-nova08:35
*** bkopilov__ has quit IRC08:35
kashyapMerci!08:36
*** bkopilov_ has quit IRC08:36
kashyapstephenfin: It is mostly just me not being good with the unit tests.  The change is quite simple, if you see the commit message.08:36
kashyap(And the driver.py code)08:36
*** jaosorior has quit IRC08:36
*** andreas_s has quit IRC08:38
*** liuzz_ has joined #openstack-nova08:39
*** derekh has joined #openstack-nova08:40
*** edmondsw has quit IRC08:40
*** andreas_s has joined #openstack-nova08:40
*** jaosorior has joined #openstack-nova08:41
*** liuzz has quit IRC08:42
*** yingjun has joined #openstack-nova08:43
*** hshiina is now known as hshiina|afk08:49
openstackgerritMerged openstack/nova master: Convert certificate generation to processutils.  https://review.openstack.org/56414608:49
*** bkopilov has joined #openstack-nova08:50
*** wolverineav has joined #openstack-nova08:50
*** bkopilov_ has joined #openstack-nova08:50
*** tomtom001 has quit IRC08:51
*** tomtom001 has joined #openstack-nova08:52
*** yamamoto has quit IRC08:55
*** gyankum has joined #openstack-nova08:55
*** alexchadin has quit IRC08:55
*** nicolasbock has joined #openstack-nova08:56
*** udesale_ has quit IRC08:59
*** udesale_ has joined #openstack-nova08:59
*** udesale_ has quit IRC09:00
*** udesale has joined #openstack-nova09:00
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add tests for sharing rps in test_common_rc()  https://review.openstack.org/56684209:09
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add tests for alloc cands with poor local disk  https://review.openstack.org/56684209:11
*** tetsuro has left #openstack-nova09:11
stephenfinkashyap: Done09:11
kashyapstephenfin: Thanks; will look09:11
*** yamamoto has joined #openstack-nova09:11
kashyapstephenfin: About actually being supported by the processor or not change.  I first thought to remove it completely because, regardless of it, it's useless09:12
kashyapBut ...09:12
kashyapSince the first change is to deprecate the support, I should retain it09:13
stephenfinkashyap: No, you can remove it but call that out and fix the test accordingly09:15
*** wolverineav has quit IRC09:15
stephenfinNo point keeping dead code around09:15
kashyapstephenfin: Right.  So the plan is: Deprecate it in Rocky; delete support for it in Stein.09:16
*** wolverineav has joined #openstack-nova09:16
kashyapI have it locally as you indicated09:16
* kashyap goes to fix...09:19
*** wolverineav has quit IRC09:20
openstackgerritlei zhang proposed openstack/python-novaclient master: Fix the incorrect cirros default password  https://review.openstack.org/56717009:24
openstackgerritjichenjc proposed openstack/nova master: [Doc]Link policies file into api  https://review.openstack.org/56150309:28
kashyapstephenfin: With the 'assert_has_calls', you meant:09:30
kashyap            mock_warn.assert_has_calls([09:30
kashyap                mock.call(...),09:30
kashyap                mock.call(...),09:30
kashyap            ])09:30
kashyap?09:30
stephenfinyup09:30
kashyapMaybe I should consider that.09:31
openstackgerritjichenjc proposed openstack/nova master: Enhance api-guide general info some updates  https://review.openstack.org/56177309:31
*** Dinesh_Bhor has quit IRC09:32
openstackgerritChris Dent proposed openstack/nova master: Optional separate database for placement API  https://review.openstack.org/36276609:37
openstackgerritChris Dent proposed openstack/nova master: Isolate placement database config  https://review.openstack.org/54143509:37
openstackgerritChris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process  https://review.openstack.org/55385709:37
openstackgerritChris Dent proposed openstack/nova master: WIP: Add PLACEMENT_DB_ENABLED=True to the nova-next job  https://review.openstack.org/56406709:37
*** yingjun has quit IRC09:42
*** ratailor__ has joined #openstack-nova09:44
openstackgerritjichenjc proposed openstack/nova master: [doc] Add soft_deleted flag  https://review.openstack.org/56289709:44
*** ratailor_ has quit IRC09:47
openstackgerritJan Gutter proposed openstack/nova stable/queens: Add plumbing for Contrail/Tungsten Fabric offloads  https://review.openstack.org/56717709:53
liuzz_hello everyone, Who can help me? i want to create a new role and only allow it to manage keystone resource, can't manager other reources(instances, volumes, ...),What should I do?09:59
*** tbachman has quit IRC10:00
kashyapstephenfin: How about I just assert that the warning has happened N number of times for each event?10:01
kashyapLike: self.assertEquals(N, mock_warn.call_count)10:01
*** tbachman has joined #openstack-nova10:03
stephenfinI'm not sure. I'd just do what you've done there10:03
kashyapNo problem; I'll tinker a bit10:03
kashyap(Calling the exact warning message isn't nice.)10:04
kashyapAnyhow, disregard me for now10:04
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Deprecate support for monitoring Intel CMT `perf` events  https://review.openstack.org/56524210:06
*** lei-zh1 has quit IRC10:06
*** ragiman has quit IRC10:14
*** ragiman has joined #openstack-nova10:14
*** cdent has joined #openstack-nova10:26
openstackgerritStephen Finucane proposed openstack/nova master: Simplify instance name generation  https://review.openstack.org/51657310:26
*** namnh has quit IRC10:28
openstackgerritStephen Finucane proposed openstack/nova master: tox: Add mypy target  https://review.openstack.org/53822110:29
openstackgerritStephen Finucane proposed openstack/nova master: tox: Store list of converted files  https://review.openstack.org/53822210:29
openstackgerritStephen Finucane proposed openstack/nova master: mypy: Add type annotations to 'nova.pci'  https://review.openstack.org/53822410:29
openstackgerritStephen Finucane proposed openstack/nova master: zuul: Add 'mypy' job  https://review.openstack.org/53916810:29
openstackgerritChris Dent proposed openstack/nova master: VMware: Live migration of instances  https://review.openstack.org/27011610:31
cdentjohnthetubaguy: there's a spec and real ci behind that ^ now10:32
cdent(it's got your -2 on it)10:32
*** annp has quit IRC10:33
*** wolverineav has joined #openstack-nova10:34
*** abhishekk has quit IRC10:36
andreas_smelwitt: Hi, I'm facing an issue with the following devstack patch you commited a few days ago: https://github.com/openstack-dev/devstack/commit/12579c3db7b28381c8ec97945aa23ee02d54d22b10:37
stephenfinbauzas: If you're about today, could you take a look at https://review.openstack.org/#/c/541290/ ?10:38
andreas_smelwitt: It seems like this patch is moving the console configurtion (vnc, spice, serial) from nova.conf into the nova-cell config10:38
andreas_smelwitt: but the n-cpu systemd service is not consuming the nova_cell config - with the result, that the console setting is being ignored10:39
stephenfinandreas_s: I was thinking the exact same thing but chose to ignore my intuition https://review.openstack.org/#/c/550141/1/10:40
stephenfin(vs. https://review.openstack.org/#/c/550141/2/)10:41
andreas_sstephenfin: ah good to know10:41
andreas_sstephenfin: but the challenge is still that devstack seems to specify the cell_config file as input parameter to configure_console_proxies, doesn't it?10:43
andreas_sat least in our thirdparty CI the config landed in the cell config file: http://sng01.objectstorage.softlayer.net/v1/AUTH_1940ea10-6e82-4501-b2f9-eb236510e575/ibmzkvmci/production/510897/13/check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x/3e67649/logs/etc/nova/10:43
stephenfinandreas_s: Yup. I'm still trying to figure out which specific setting the conductors (which I think are the only services to use those files) need configured10:44
*** priteau has joined #openstack-nova10:45
stephenfinbecause I thought most/all of them are only used by nova-compute10:45
*** hjensas|afk is now known as hjensas10:45
andreas_syeah, nova-compute needs this config in definitively!10:45
*** tbachman has quit IRC10:47
stephenfinandreas_s: I'd file a bug, personally. I'll take a look at it after lunch and see if we can come up with something10:47
jmccarthymriedem: Thanks for the update on https://review.openstack.org/#/c/566367 ! I tested this out, and patchest2 worked great for me10:49
andreas_sstephenfin: that would be great. thanks. Can you subscribe me to this bug once opened (andreas scheuring)? thx. If you need any more input, let know...10:49
*** yamamoto has quit IRC10:49
stephenfinandreas_s: "I would file a bug, personally", e.g. I suggest _you_ file a bug :)10:50
stephenfinI could do it, but you probably have the most context10:50
stephenfinand logs10:50
andreas_sok, will do10:50
andreas_sstephenfin: just was not sure how to interpret "I would" ;)10:50
stephenfinThat's an Irish'ism. Sorry :)10:51
*** yamamoto has joined #openstack-nova10:51
andreas_shehe, enjoy your lunch!10:51
openstackgerritMerged openstack/nova master: Remove [scheduler]/host_manager config option  https://review.openstack.org/56580610:53
*** mgoddard_ has joined #openstack-nova10:54
*** derekh_ has joined #openstack-nova10:54
*** derekh has quit IRC10:54
*** slaweq has quit IRC10:54
*** slaweq_ has joined #openstack-nova10:56
*** andreas_s_ has joined #openstack-nova10:56
*** mgoddard has quit IRC10:56
*** mgoddard_ is now known as mgoddard10:56
*** psachin` has joined #openstack-nova10:56
*** andreas_s has quit IRC10:57
*** psachin has quit IRC10:57
*** mchlumsky_ has joined #openstack-nova10:59
*** RaoulHC has joined #openstack-nova10:59
*** slaweq has joined #openstack-nova10:59
*** andreas_s has joined #openstack-nova10:59
*** slaweq_ has quit IRC10:59
*** mchlumsky has quit IRC10:59
*** lyarwood has quit IRC11:00
*** lyarwood has joined #openstack-nova11:01
*** andreas_s_ has quit IRC11:01
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Deprecate support for monitoring Intel CMT `perf` events  https://review.openstack.org/56524211:02
openstackgerritRajat Sharma proposed openstack/nova master: Imposing restrictions on resource providers create uuid  https://review.openstack.org/56719111:04
andreas_sstephenfin, melwitt: opened the bug against devstack: https://bugs.launchpad.net/devstack/+bug/177014311:06
openstackLaunchpad bug 1770143 in devstack "Nova Console setup broken" [Undecided,New]11:06
*** lucasagomes is now known as lucas-hungry11:06
ShilpaSDdansmith: hi11:11
*** yamamoto has quit IRC11:25
openstackgerritNaichuan Sun proposed openstack/nova master: XenAPI: deprecate the config for image handler class path  https://review.openstack.org/49720111:29
*** sridharg has quit IRC11:30
*** yamamoto has joined #openstack-nova11:31
*** yamamoto has quit IRC11:32
*** sridharg has joined #openstack-nova11:34
*** Nel1x has joined #openstack-nova11:37
*** armaan has quit IRC11:41
*** armaan has joined #openstack-nova11:41
*** phuongnh has quit IRC11:42
*** jpena is now known as jpena|lunch11:44
*** ratailor__ has quit IRC11:47
*** tiendc has quit IRC11:52
*** hemna_ has quit IRC11:53
*** blkart has quit IRC11:54
*** bhujay has quit IRC11:55
*** yamamoto has joined #openstack-nova11:58
*** bertys____ has quit IRC12:02
*** pchavva has joined #openstack-nova12:06
*** lucas-hungry is now known as lucasagomes12:07
openstackgerritChris Dent proposed openstack/nova master: Optional separate database for placement API  https://review.openstack.org/36276612:09
openstackgerritChris Dent proposed openstack/nova master: Isolate placement database config  https://review.openstack.org/54143512:09
openstackgerritChris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process  https://review.openstack.org/55385712:09
openstackgerritChris Dent proposed openstack/nova master: WIP: Add PLACEMENT_DB_ENABLED=True to the nova-next job  https://review.openstack.org/56406712:10
*** edmondsw has joined #openstack-nova12:10
*** tbachman has joined #openstack-nova12:16
*** armaan has quit IRC12:16
openstackgerritBalazs Gibizer proposed openstack/nova master: Followup for multiple member_of qparams support  https://review.openstack.org/56720912:19
*** jmlowe has quit IRC12:20
*** pcaruana has quit IRC12:21
*** Nel1x has quit IRC12:28
*** armaan has joined #openstack-nova12:30
openstackgerritRadoslav Gerganov proposed openstack/nova stable/queens: Handle PortNotFoundClient exception when getting ports  https://review.openstack.org/56721112:30
*** janki has quit IRC12:30
*** janki has joined #openstack-nova12:31
*** yingjun has joined #openstack-nova12:36
*** yamamoto has quit IRC12:39
openstackgerritJan Gutter proposed openstack/nova-specs master: Spec to implement vRouter HW offloads  https://review.openstack.org/56714812:41
*** lyan has joined #openstack-nova12:42
*** lyan is now known as Guest5391612:42
*** yamamoto has joined #openstack-nova12:44
*** dave-mccowan has joined #openstack-nova12:44
*** yamamoto has quit IRC12:45
*** vladikr has quit IRC12:48
*** vladikr has joined #openstack-nova12:48
*** jpena|lunch is now known as jpena12:49
*** gyan_ has quit IRC12:51
*** gyankum has quit IRC12:51
*** tuanla____ has quit IRC12:52
*** lpetrut has quit IRC12:53
*** armaan has quit IRC12:54
*** amoralej is now known as amoralej|lunch12:58
*** andreas_s has quit IRC13:00
*** andreas_s has joined #openstack-nova13:00
mdboothefried: Morning! https://review.openstack.org/#/c/564017/13:01
mdboothThat's causing me a problem, and I considering proposing a revert. However, I think it only exists due to bad naming.13:01
efriedmdbooth: stand by.13:02
*** jmlowe has joined #openstack-nova13:02
efriedmdbooth: Okay, do tell.13:02
mdboothefried: I see you proposed it because of the loop in the ironic driver13:02
efriedmdbooth: Well, actually because of [2] (in the commit message), but [1] was a good excuse.13:03
mdboothefried: Sec, lemme check 213:03
openstackgerritAditya Vaja proposed openstack/nova master: remove IVS plug/unplug as they're moved to separate plugin  https://review.openstack.org/53437113:03
*** andreas_s has quit IRC13:03
efriedmdbooth: TL;DR, we were checking for volume-ness in a different (and apparently wrong13:03
efried) way in the powervm driver.13:03
*** andreas_s has joined #openstack-nova13:04
mdboothefried: Thing is, the ironic driver doesn't need that check13:04
efriedmdbooth: mriedem pointed out that we should be using is_volume... which led us to find out that it didn't exist.13:04
efriedmdbooth: Well, is the new version of the check doing something the old one wasn't?13:04
mdboothBecause, confusingly, block_device_info_get_mapping() should actually be called block_device_info_get_volumes()13:04
*** psachin` has quit IRC13:04
efriedmdbooth: I.e. did we break something afresh, or just leave something that (we didn't know) was broken before?13:04
*** sapd has quit IRC13:05
mdboothIf it was called *_get_volumes(), it would be obvious that an is_volume call was redundant subsequently13:05
jaypipesstephenfin: yes, sorry, I understand the differences between gre, vlan, vxlan, local, etc. what I'm wondering about is why you used the term "mechanism". Is that because of the use of "mechanism driver" to describe the implementation module that Neutron uses under the hood for constructing a particular network?13:05
mdboothWhere's _vol_drv_iter() called in your patch?13:06
stephenfinjaypipes: I think I saw it used in documentation somewhere and couldn't think of a better term :)13:06
mdboothefried: Where I'm going with that is... are you sure they aren't all volumes anyway? And if they're not, why not just get the volumes in the first place?13:07
*** liuzz_ has quit IRC13:08
jaypipesstephenfin: the reason I asked is because neither of those pages mentions the term "mechanism", and it seems to me (I may very well be wrong) that you are conflating two things (segmentation protocol and whether overlapping IP address ranges can occur on the network)13:08
*** lpetrut has joined #openstack-nova13:09
mdboothefried: Ah, yes. You're doing the same thing.13:09
mdboothefried: So, they're all volumes.13:09
efriedmdbooth: So let's back up just for a sec.13:09
mdboothHave a look in driver.get_block_device_info(), which is what generates that data13:09
*** cdent has quit IRC13:09
mdboothSee:13:09
mdbooth        'block_device_mapping':13:09
mdbooth            virt_block_device.convert_all_volumes(*block_device_mapping)13:09
efriedmdbooth: 1) Is there actually a problem here, or just some redundancy? and 2) was anything actually broken (or changed at all) by the patch you referenced?13:09
mdbooth'block_device_mapping' should really be called 'volumes'13:10
*** liverpooler has joined #openstack-nova13:10
stephenfinjaypipes: Hmm, protocol would probably have done. I definitely saw 'mechanism' used somewhere but of course I can't find where now13:10
mdboothWell, the change is redundant, but due to bad naming that's not at all obvious.13:11
efriedmdbooth: It is my understanding that there is quite a lot of horribleness in the bdm code that could be improved upon.13:11
jaypipesstephenfin: no worries, it's not a huge deal really.13:11
mdboothThe issue is that you added is_volume, which is a property, to the inherited list13:11
efriedmdbooth: The change itself is (was intended to be) a no-op. It was only supposed to get rid of the need to ask that @property through a private member of the outer bdm.13:11
stephenfinjaypipes: I don't think I'm conflating those things. The main difference is whether it's an L2 network (uses physnets) or L3 network (uses a tunnel endpoint). tbh, the whole section on tenant networks and provider networks could be dropped13:12
mdboothSo it breaks when something attempts to write to it13:12
efriedmdbooth: Write to what, .is_volume ?13:12
mdboothYeah13:12
stephenfinI'll probably do that as a follow-up. At this point I just want to get the spec in so I can grab a runway :)13:12
efriedmdbooth: Who was doing that, and where?13:12
efriedand why?13:12
efriedand based on what source info, if not _bdm_obj.is_volume itself?13:13
efriedmdbooth: sounds like we need a fup to remove... whatever that was.13:13
*** mriedem has joined #openstack-nova13:13
efriedmriedem: see email13:13
mdboothefried: Let me reload that context, but it broke my patch https://review.openstack.org/#/c/528362/13:13
mdboothefried: I believe the issue is due to something iterating over properties to initialise the object13:13
mdboothLet me just remind myself...13:14
mriedemnothing like an immediate pounce13:14
efriedmriedem: No hurry, just responding to your question about the granular bp13:14
*** derekh_ has quit IRC13:14
efriedI suppose I didn't need to pounce for that.  Sorry.13:14
ShilpaSDstephenfin: Hi13:14
efriedmdbooth: Okay, so it kicked your patch out of the gate, didn't like melt CERNs supercollider, that's a relief anyway.13:14
mdboothefried: My patch is more important than somebody's magnet set.13:15
efriedclearly13:15
*** andreas_s has quit IRC13:16
jaypipesstephenfin: understood.13:17
*** tbachman has quit IRC13:18
mdboothefried: Ok, so I think I can unpick this from my end.13:25
mdboothefried: However, the point about is_volume being redundant in that context still stands13:25
efriedmdbooth: Okay.  From what I've been able to tell so far, it's not clear that we should be setting things on _bdm_obj rather than on the outer object itself.13:25
mdboothWhich, as I say, would be obvious if we called 'block_device_mappings' 'volumes'13:25
mriedemlyarwood: can you poke this regression fix for queens? https://review.openstack.org/#/c/564461/ we're going to do a release soon for another regression fix13:26
efriedmdbooth: I'll be on the lookout for that review :)13:26
mriedemthis one https://review.openstack.org/#/q/If9e1581db9c1ae14340b787d03c815d243d5a50c13:26
mdboothefried: Meh, I can't be arsed renaming things I'm not actively hitting. It's painful and nobody cares.13:26
lyarwoodmriedem: yeah np, looking now13:27
efriedmdbooth: Just so.  Also, that's a slippery slope, as I mentioned before.  Once we start "fixing" the block device code, there'll be no stopping.13:27
*** andreas_s_ has joined #openstack-nova13:28
*** andreas_s_ has quit IRC13:28
jmccarthymriedem: Morning ! I checked this out and it worked out great https://review.openstack.org/#/c/566367 !13:28
*** andreas_s_ has joined #openstack-nova13:29
*** mingyu has joined #openstack-nova13:29
*** andreas_s_ has quit IRC13:31
*** andreas_s_ has joined #openstack-nova13:31
*** amoralej|lunch is now known as amoralej13:31
openstackgerritJay Pipes proposed openstack/nova master: add consumer.generation/create missing consumers  https://review.openstack.org/55795813:32
openstackgerritJay Pipes proposed openstack/nova master: placement: add Project, User and Consumer objects  https://review.openstack.org/56540313:32
openstackgerritJay Pipes proposed openstack/nova master: Add create() methods to Project, User and Consumer  https://review.openstack.org/56540413:32
openstackgerritJay Pipes proposed openstack/nova master: move consumer ensure to API layer  https://review.openstack.org/56540513:32
openstackgerritJay Pipes proposed openstack/nova master: rework allocation handler _allocations_dict()  https://review.openstack.org/56540713:32
openstackgerritJay Pipes proposed openstack/nova master: Add a microversion for consumer generation support  https://review.openstack.org/56560413:32
mdboothefried: Added a comment to the PowerVM patch. Not really worth a -1, tbh, but I figure somebody's going to have to touch it anyway.13:33
lyarwoodmriedem: right, so this is a stable/queens cherry-pick of a revert of a bugfix that only ever landed on master, fun.13:34
*** felipemonteiro__ has joined #openstack-nova13:34
*** armaan has joined #openstack-nova13:34
lyarwoodmriedem: it's valid as bugfix on stable/queens AFAICT, do we have enough time to drop the `This reverts commit` line?13:35
mriedemlyarwood: which one? https://review.openstack.org/#/c/564461/ ?13:36
mriedemit's not really a revert, it's a redo13:36
mriedemjmccarthy: great, thanks13:37
lyarwoodmriedem: yeah the revert line just confused me13:37
mriedemjaypipes: i think you have some context on this https://review.openstack.org/#/c/56636713:37
mriedemwould be good to get that fixed since we backported the regression to ocata13:37
mriedemlyarwood: right, so we revert the one workaround hack to remove the instance dir after the by_name init thing13:37
mriedembecause if we don't do that hack, we don't need to remove the dir, and that was the original bug anyway13:38
mriedemlyarwood: https://review.openstack.org/#/c/524208/ landed when queens was master13:39
lyarwoodmriedem: right, ignore me, the fscking gerrit UI didn't list it as in Queens13:39
*** cdent has joined #openstack-nova13:39
mriedem"included in" dropdown13:39
mriedemis what i check13:39
mriedemlyarwood: you and mdbooth might also be interested in https://review.openstack.org/#/c/56636713:39
lyarwoodmriedem: yeah it didn't display correctly, checked it again and there it is13:39
mriedemdealing with libvirt imagebackend fun13:39
* lyarwood should really double check with git directly next time13:40
*** pcaruana has joined #openstack-nova13:40
efriedmdbooth: ack, and thanks.13:42
*** jaosorior has quit IRC13:43
*** mriedem1 has joined #openstack-nova13:43
*** mriedem has quit IRC13:46
*** yamamoto has joined #openstack-nova13:46
*** mriedem1 is now known as mriedem13:46
mdboothmriedem: Somebody should clean that thing up ;)13:46
*** jaosorior has joined #openstack-nova13:50
*** hongbin has joined #openstack-nova13:52
openstackgerritMatt Riedemann proposed openstack/nova master: Fix detach_volume calls when rolling back a failed attach  https://review.openstack.org/56321313:52
mriedemefried: gibi: test fixed, ^ - nice catch gibi13:52
mriedemthat's one that also needs to go back to queens as a regression fix13:52
*** andreas_s_ has quit IRC13:53
*** felipemonteiro_ has joined #openstack-nova13:53
mriedemdansmith: can you hit this queens backport? https://review.openstack.org/#/c/564461/13:53
*** andreas_s has joined #openstack-nova13:53
dansmithmriedem: yeah13:54
mriedemthanks13:54
*** evin has quit IRC13:55
kashyapMatt, when you can: https://review.openstack.org/#/c/565242/  ("libvirt: Deprecate support for monitoring Intel CMT `perf` events")13:55
kashyapThe unit test is "fixed", but in the most robust way.13:55
kashyap(But that's dead code anyway, and we will remove it in Stein.)13:55
kashyapIf there are any better ways I can rewrite the new unit test, welcome.13:55
*** yamamoto has quit IRC13:56
*** felipemonteiro__ has quit IRC13:56
mriedemlyarwood: this would also be good for cern https://review.openstack.org/#/c/566288/13:57
*** esberglu has joined #openstack-nova13:58
jaypipesmriedem: sure thing. gimme a few, though. trying to rebase a nasty.14:00
gibimriedem: +2+A on https://review.openstack.org/56321314:00
*** awaugama has joined #openstack-nova14:01
*** andreas_s has quit IRC14:02
*** lpetrut has quit IRC14:02
*** mlavalle has joined #openstack-nova14:02
*** pcaruana has quit IRC14:05
mriedemgibi: thanks14:06
*** andreas_s has joined #openstack-nova14:07
wolverineavmriedem: i've updated the patch with changes as suggested (https://review.openstack.org/#/c/534371/) please take a look when you have a moment :)14:08
*** andreas_s has quit IRC14:08
*** pcaruana has joined #openstack-nova14:08
*** lpetrut has joined #openstack-nova14:08
*** andreas_s has joined #openstack-nova14:08
mriedemdansmith: pretty sure this is going to be a no-no backport given the object version changes yeah? https://review.openstack.org/#/c/563797/14:08
*** burt has joined #openstack-nova14:10
mriedemwolverineav: ack, lgtm, just waiting on zuul14:10
mriedemactually +2; stephenfin - mind hitting https://review.openstack.org/#/c/534371/ again?14:11
wolverineavmriedem: thanks! i wanted to proactively get that looked at. its been in review quite some time.14:11
* stephenfin clicks14:11
mriedemwolverineav: yup, i know, thanks for your patience14:11
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Fix detach_volume calls when rolling back a failed attach  https://review.openstack.org/56723214:11
mriedemlyarwood: dansmith: ^ we'll want to get that in the queens release we do this week14:12
dansmithmriedem: yeah, if it had been done non-remotable it would have been okay, but..14:12
dansmithmriedem: okay doesn't look like the master one has landed yet14:13
mriedemdansmith: re that pike list_hosts one, -2 since they still have the nova-manage host list command in pike14:15
mriedemso they can just run that with --config-file pointed at the cell db14:15
*** mingyu has quit IRC14:15
dansmithack14:16
*** lpetrut has quit IRC14:18
openstackgerritMatthew Booth proposed openstack/nova master: Expose driver_block_device fields consistently  https://review.openstack.org/52836214:19
openstackgerritMatthew Booth proposed openstack/nova master: Add DriverLocalImageBlockDevice  https://review.openstack.org/52634714:19
*** mingyu has joined #openstack-nova14:19
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Unmap compute nodes when deleting host mappings in delete cell operation  https://review.openstack.org/55382914:21
dansmithmriedem: melwitt tssurya: Do we have content for a cells meeting today? I got feedback on my patches to work on, which was my only thing. tssurya said maybe belmiro would have some things to discuss this week I think?14:22
mriedemlyarwood: are you still working on this pike backport? https://review.openstack.org/#/c/561015/14:23
*** eharney has quit IRC14:24
mriedemdansmith: i don't really have anything; i created a todo for myself to write some kind of functional regression test for https://bugs.launchpad.net/nova/+bug/1746863 - separate from the one i think mel was going to write14:24
openstackLaunchpad bug 1746863 in OpenStack Compute (nova) "scheduler affinity doesn't work with multiple cells" [High,In progress] - Assigned to melanie witt (melwitt)14:24
mriedemfor a separate but related bug we talked about the other day14:24
dansmithack14:24
lyarwoodmriedem: nope that dropped off my list, I can take another look at it in the next hour or so14:24
mriedem"TODO: We need a new bug and test for the multi-cell affinity scenario  where two instances are scheduled at the same time in the same affinity  group. We need 2 cells with 1 host each, with exactly enough capacity to  fit just one instance so that placement will fail the first request and  throw it into the other host in the other cell. The late affinity check  in the compute won't fail because it can't see the other member14:24
mriedemhe  other cell, so it will think it's fine. "14:24
*** pcaruana has quit IRC14:25
mriedemgetting ^ to not be racy will probably be the hard part14:25
mriedemdansmith: https://review.openstack.org/#/c/553829/ is pike and cells related if you want to put that through14:26
mriedemmelwitt: i've gone through open queens, pike and ocata changes and added what i think we should target for a release this week on all 3 branches https://etherpad.openstack.org/p/nova-stable-branch-status14:26
*** pcaruana has joined #openstack-nova14:26
mdboothjaypipes: https://review.openstack.org/#/c/529029/11/nova/virt/driver.py14:28
efriedmdbooth: Did you reverse the order of those patches?14:29
mdboothjaypipes: So, I agree with the confusing naming. How about I rename *_get_root_device() to *_get_root_device_name() ?14:29
mdboothefried: Yep14:29
efriedmdbooth: Then your commit message is no longer correct :(14:29
*** andreas_s has quit IRC14:30
mdboothefried: Which one?14:30
jaypipesmdbooth: ++14:30
efriedmdbooth: https://review.openstack.org/#/c/526347/ says "a subsequent change will..."14:31
*** andreas_s has joined #openstack-nova14:31
mdboothjaypipes: K. Separate patch to come before.14:31
openstackgerritChris Dent proposed openstack/nova master: VMware: Live migration of instances  https://review.openstack.org/27011614:31
*** derekh has joined #openstack-nova14:31
efriedmdbooth: when in fact it is the prior14:31
efriedmdbooth: I don't care, just happened to notice.14:31
mdboothefried: Ah, I didn't reorder that patch14:31
mdboothI believe that's still correct.14:31
efriedokay14:31
efriedI didn't dig14:31
tssuryadansmith: nah, we can skip :) I don't think belmiro is joining today14:34
dansmithokay cool14:34
*** andreas_s_ has joined #openstack-nova14:34
*** felipemonteiro__ has joined #openstack-nova14:34
*** andreas_s has quit IRC14:36
mriedemefried: melwitt: mtreinish: f yeah e-r is commenting again https://review.openstack.org/#/c/567211/14:36
efriedmriedem: woot14:37
*** felipemonteiro_ has quit IRC14:37
*** germs has joined #openstack-nova14:37
*** germs has quit IRC14:37
*** germs has joined #openstack-nova14:37
efriedmriedem: what was the problem/solution?14:37
*** r-daneel has joined #openstack-nova14:37
*** evin has joined #openstack-nova14:37
mriedemefried: https://review.openstack.org/#/c/567058/ and https://review.openstack.org/#/c/567068/14:38
*** andreas_s_ has quit IRC14:38
*** reshift has joined #openstack-nova14:39
efriedheh, so no CI for elastic recheck?14:39
mtreinishmriedem: cool14:39
mriedemefried: there is, but that part of the code is kind of tricky14:40
mriedemthe function takes a specific change, patchset, and build name/id,14:40
mriedemand the logs are gone after 10 days14:40
mriedemso not sure how you're going to reliably test for that14:40
mtreinishefried: the ci there doesn't check the bot actually sending messages. (it's complex) Mostly we validate the individual pieces work and that the queries are valid (although that looks like it's failing)14:40
*** r-daneel_ has joined #openstack-nova14:41
reshiftHi, does the nova python client have any methods to search servers for a metadata key or value?14:41
openstackgerritEric Fried proposed openstack/nova master: [doc] Add soft_deleted flag  https://review.openstack.org/56289714:41
*** jaosorior has quit IRC14:41
*** r-daneel has quit IRC14:42
*** r-daneel_ is now known as r-daneel14:42
mriedemreshift: the REST API doesn't support that so i don't think the client does either14:42
openstackgerritArtom Lifshitz proposed openstack/nova master: Add InstanceNUMATopology to LibvirtLiveMigrateData  https://review.openstack.org/56639814:43
openstackgerritArtom Lifshitz proposed openstack/nova master: WIP: Service version check for NUMA live migration  https://review.openstack.org/56672314:43
openstackgerritArtom Lifshitz proposed openstack/nova master: WIP: NUMA-aware live migration  https://review.openstack.org/56724214:43
reshiftok, thanks14:43
mriedemreshift: see https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L30114:43
mriedemthere is https://developer.openstack.org/api-ref/compute/#server-metadata-servers-metadata but (1) you'd need to hit that for all servers and (2) it doesn't have filter params14:43
reshiftI think I might try using tags instead14:44
mriedemreshift: i was just going to say, you can filter servers on tags14:44
mriedemif that works for you14:44
*** gbarros has joined #openstack-nova14:44
*** andreas_s has joined #openstack-nova14:44
*** germs has quit IRC14:46
*** udesale has quit IRC14:46
*** germs has joined #openstack-nova14:46
*** germs has quit IRC14:46
*** germs has joined #openstack-nova14:46
*** janki has quit IRC14:46
*** jdillaman has quit IRC14:48
*** gbarros has quit IRC14:49
*** andreas_s has quit IRC14:49
*** gbarros has joined #openstack-nova14:49
*** hemna_ has joined #openstack-nova14:53
efriedmdbooth: I don't see how convert_all_volumes filters down to only volumes.14:53
efriedrather, how it filters anything.14:53
*** felipemonteiro__ has quit IRC14:55
*** felipemonteiro_ has joined #openstack-nova14:55
mdboothefried: Those functions are weird14:56
openstackgerritMichael Bayer proposed openstack/nova master: Add connection_parameters to list of items copied from database  https://review.openstack.org/56724814:57
mdboothefried: So, it's a concatenation of volume, snapshot, image, and blank, all of which are volume types14:57
mdboothefried: Each of those functions individually works by calling <class>._transform on everything in the list, and those of the wrong type raise an error14:58
mdboothIt's obtuse, but the result is that they're all volumes.14:58
efriedmdbooth: Noted.  The obtuseness, and the cheapness of the is_volume check, would have me preferring to leave it in even if redundant.14:59
mdboothefried: The *implementation* is obtuse, however the intent is very clear14:59
mdboothIt's called 'convert_all_volumes', and it returns only volumes15:00
mdboothIn my view, the is_volume test adds confusion, because it sets an expectation that the input might be something other than volumes15:00
mdboothI'd rename 'bdms' to 'volumes'15:01
*** andreas_s has joined #openstack-nova15:01
efriedesberglu: If you're following this, it'd be your action ^15:01
*** jdillaman has joined #openstack-nova15:02
*** gbarros has quit IRC15:03
mdboothI wonder, however, if it's possible to have a volume bdm with no connection_info. I guess you'd have that at least briefly before attach?15:03
*** edmondsw has quit IRC15:04
*** lpetrut has joined #openstack-nova15:05
zzzeekjaypipes melwitt hurry i need you to drop everything and attend to my personal nova issue15:05
*** andreas_s has quit IRC15:06
*** gyankum has joined #openstack-nova15:08
*** gyan_ has joined #openstack-nova15:08
*** yingjun has quit IRC15:10
openstackgerritMerged openstack/python-novaclient master: Fix the incorrect cirros default password  https://review.openstack.org/56717015:13
jaypipeszzzeek: how may I assist you, fine sir?15:15
*** felipemonteiro_ has quit IRC15:16
zzzeekjaypipes: more "I added an option to oslo.db" pain: https://review.openstack.org/#/c/567248/15:16
*** felipemonteiro_ has joined #openstack-nova15:16
zzzeekjaypipes: i want to put up the backports for this15:17
*** mingyu has quit IRC15:18
openstackgerritMatt Riedemann proposed openstack/nova master: Skip ServerActionsTestJSON.test_rebuild_server for cells v1 job  https://review.openstack.org/56725615:18
*** fragatina has quit IRC15:20
*** zhaochao has quit IRC15:21
*** eharney has joined #openstack-nova15:22
openstackgerritStephen Finucane proposed openstack/nova master: Simplify instance name generation  https://review.openstack.org/51657315:22
openstackgerritStephen Finucane proposed openstack/nova master: Remove '_apply_instance_name_template'  https://review.openstack.org/56725715:22
*** eharney has quit IRC15:22
*** tbachman has joined #openstack-nova15:23
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Remove usage of migrateToURI2() API  https://review.openstack.org/56725815:23
*** jmccarthy has quit IRC15:24
kashyapmdbooth: ^ You might be interested in the above change.  As I've see you fiddle with migration parameters of libvirt migrate API :-)15:24
kashyapNo urgency at all.  This can wait.15:24
*** yingjun has joined #openstack-nova15:25
kashyaps/see/seen/15:25
*** links has quit IRC15:25
*** armaan has quit IRC15:25
*** jmccarthy has joined #openstack-nova15:25
*** armaan has joined #openstack-nova15:26
*** derekh has quit IRC15:26
*** tbachman_ has joined #openstack-nova15:26
*** rajinir has joined #openstack-nova15:26
*** tbachman has quit IRC15:27
*** tbachman_ is now known as tbachman15:27
*** sridharg has quit IRC15:30
mriedemstephenfin: why do we need this? https://review.openstack.org/#/c/567257/ - looks like you're just taking a separate method and munging it back into where it's called from15:30
mriedemwell, not where it's called from, but close15:30
stephenfinIt makes the follow up way easier to parse, in my mind at least https://review.openstack.org/#/c/516573/15:31
stephenfin(follow up to https://review.openstack.org/#/c/499612/)15:31
openstackgerritDan Smith proposed openstack/nova master: Add CellMapping.get_by_project_id() query method  https://review.openstack.org/50900215:33
openstackgerritDan Smith proposed openstack/nova master: Make get_instance_objects_sorted() be smart about cells  https://review.openstack.org/50900315:33
mriedemstephenfin: left some comments, the commit message clearly needs more context15:34
openstackgerritLee Yarwood proposed openstack/nova stable/pike: Skip placement on rebuild in same host  https://review.openstack.org/56101515:34
*** germs has quit IRC15:36
*** germs has joined #openstack-nova15:37
*** dpawlik_ has quit IRC15:37
*** gyee has joined #openstack-nova15:38
*** evin has quit IRC15:42
openstackgerritMerged openstack/nova stable/queens: Fix dropped check for boot_index 0 in _validate_bdm  https://review.openstack.org/56446115:42
*** yingjun has quit IRC15:43
openstackgerritStephen Finucane proposed openstack/nova master: Remove '_apply_instance_name_template'  https://review.openstack.org/56725715:43
openstackgerritStephen Finucane proposed openstack/nova master: Simplify instance name generation  https://review.openstack.org/51657315:43
*** dpawlik has joined #openstack-nova15:44
*** ragiman has quit IRC15:44
*** reshift has quit IRC15:49
openstackgerritBalazs Gibizer proposed openstack/nova master: add resource_requests field to RequestSpec  https://review.openstack.org/56726715:52
stephenfinAnyone have any idea why this change could be causing Tempest to fail? https://review.openstack.org/#/c/564444/ http://logs.openstack.org/44/564444/2/check/tempest-full/762ada1/testr_results.html.gz15:52
openstackgerritBalazs Gibizer proposed openstack/nova master: transfer port.resource_request to the scheduler  https://review.openstack.org/56726815:52
stephenfinThe only functional thing I've changed is that we now fetch physnet information for any network IDs we passed in network requests - not just port IDs. Can't reproduce locally though :/15:53
openstackgerritArtom Lifshitz proposed openstack/nova stable/pike: log stale allocations as WARNING instead of DEBUG  https://review.openstack.org/56727115:55
openstackgerritArtom Lifshitz proposed openstack/nova stable/queens: log stale allocations as WARNING instead of DEBUG  https://review.openstack.org/56727315:55
openstackgerritArtom Lifshitz proposed openstack/nova stable/pike: log stale allocations as WARNING instead of DEBUG  https://review.openstack.org/56727115:56
gibistephenfin: now you include the meta network 'auto' to the query http://logs.openstack.org/44/564444/2/check/tempest-full/762ada1/controller/logs/screen-n-api.txt.gz?level=ERROR#_May_07_16_24_34_42321915:57
stephenfingibi: Dang it. Thanks! I've been trying to suss that all day and couldn't find the required log 😅15:59
lbragstadjaypipes: re: the scope type patches for nova, i reworked the ksm (gating) and the oslo.context patches (still in review) - hopefully they're a bit more clear from a consuming service perspective15:59
lbragstadoslo.context patch - https://review.openstack.org/#/c/530509/15:59
mdboothdansmith: I think the explanation you requested is better in a class docstring rather than the commit message. That ok with you?16:00
mdboothMeans we can find it later without git spelunking.16:00
dansmithsure16:00
mriedemstephenfin: the NetworkRequest(List) has helper methods to determine if it's an auto-allocate request16:01
*** mingyu has joined #openstack-nova16:03
artommriedem, to be honest I just mechanically did the backport since our downstream bug was against 12 (https://bugzilla.redhat.com/show_bug.cgi?id=1572836 FWIW)16:05
openstackgerritMerged openstack/nova master: Followup for multiple member_of qparams support  https://review.openstack.org/56720916:05
openstackbugzilla.redhat.com bug 1572836 in openstack-nova "nova-compute should log messages about stale resource allocations at warning priority" [Medium,Post] - Assigned to alifshit16:05
mriedemartom: see my comments when i merged the change on master16:05
mriedemartom: queens and rocky shouldn't be hitting that code so warning is ok, and we can't rely on ocata/pike computes to heal the allocations,16:06
mriedembut that gets fuzzy when you're in pike and could have ocata computes, and we also fixed a bunch of places post-pike GA that didn't cleanup allocations on failure,16:06
mriedemso from that bz, it's possible they hit one of those places that are now fixed16:06
artommriedem, dammit, I was hoping I wouldn't have to use my brain for this one ;)16:07
mriedemdefer your brain to dansmith16:07
mriedemhe knows that code well16:07
artomI... I can't tell if you're serious or just messing with Dan :/16:08
openstackgerritArtom Lifshitz proposed openstack/nova master: Do not use SameHostFilter in API sample tests  https://review.openstack.org/56303716:11
mriedemartom: i'm phoning a friend16:12
dansmithmriedem: I think warning on pike is reasonable, and I think that's where we hit it downstream.. they didn't realize things had gotten legit out of sync because they had debug off16:13
dansmithwhen they turned debug on, we realized some instances had allocations on three computes because of legit leaks16:13
mriedemwas this pike 16.0.0 GA?16:13
artomdansmith, wait, was that the juicy backported you mentioned in internal IRC?16:13
dansmithI think we made it debug initially because we were pretty sure we'd log that a lot16:14
dansmithartom: no16:14
dansmithbut since we've seen it in the wild, it probably needs to be more visible16:14
dansmithmriedem: it was whatever our build is based on16:14
dansmithmriedem: are you asking if it was something past GA because of backports?16:14
mriedemwe fixed a lot of leaky allocation stuff post pike GA,16:15
dansmithmriedem: the actual leakage happened some time in the past, they don't know when, but noticed it when computes were refusing to schedule the last bit of resource, which turned out to be because of some stale allocations16:15
dansmithright16:15
*** phuongnh has joined #openstack-nova16:15
mriedemso i'm wondering if the customer hit this on 16.0.0 GA before we fixed the leaks16:15
dansmithentirely possible16:15
dansmithcould also have been from ocata, or during/around the upgrade16:15
mriedemi realize the leaks could have been from GA, even if we stopped the leaks later16:15
dansmithyeah16:16
dansmithit wasn't very acute, so I don't think they're just leaking like crazy right now16:16
dansmithit was just "hmm, this should fit, help us figure out why not"16:16
openstackgerritMatthew Booth proposed openstack/nova master: Add DriverLocalImageBlockDevice  https://review.openstack.org/52634716:16
openstackgerritMatthew Booth proposed openstack/nova master: Add local_root to block_device_info  https://review.openstack.org/52902916:16
mriedemgiven we should have fixed those leaks now in pike, if we do hit this, my comment from the change on master probably applies16:16
openstackgerritMatthew Booth proposed openstack/nova master: Rename block_device_info_get_root_device  https://review.openstack.org/56727716:16
mriedemi.e. we shouldn't hit this, so if we are leaking, we f'ed up and warning is probably ok16:16
dansmithyes16:16
*** r-daneel has quit IRC16:18
*** phuongnh has quit IRC16:19
*** Phuongnh has joined #openstack-nova16:20
*** lpetrut has quit IRC16:25
mriedemartom: ok +2 on queens, +1 on pike16:27
*** hamzy has quit IRC16:28
artommriedem, dansmith, thank you gentlemen16:32
*** udesale has joined #openstack-nova16:32
*** gyankum has quit IRC16:33
*** imacdonn has quit IRC16:34
*** imacdonn has joined #openstack-nova16:34
*** gyan_ has quit IRC16:34
*** lpetrut has joined #openstack-nova16:34
openstackgerritDan Smith proposed openstack/nova master: Add CellMapping.get_by_project_id() query method  https://review.openstack.org/50900216:39
openstackgerritDan Smith proposed openstack/nova master: Make get_instance_objects_sorted() be smart about cells  https://review.openstack.org/50900316:39
*** lucasagomes is now known as lucas-afk16:39
*** masber has joined #openstack-nova16:40
*** tssurya has quit IRC16:40
*** Phuongnh has quit IRC16:42
*** mingyu has quit IRC16:52
*** r-daneel has joined #openstack-nova16:54
*** gbarros has joined #openstack-nova16:55
*** Swami has joined #openstack-nova16:55
*** armaan has quit IRC16:55
*** armaan has joined #openstack-nova16:55
*** dougsz has quit IRC16:57
*** mingyu has joined #openstack-nova16:57
*** evin has joined #openstack-nova16:58
*** trozet has joined #openstack-nova16:59
*** lpetrut has quit IRC17:00
mdboothmriedem: If you get a sec could you check I haven't misrepresented you in my response to jaypipes here: https://review.openstack.org/#/c/528363/15/nova/virt/block_device.py ?17:01
*** lpetrut has joined #openstack-nova17:01
*** mgoddard has quit IRC17:04
mriedemreplied17:04
mriedemi really need to be reviewing that series given my somewhat grossly intimate relationship with that code now17:05
mriedemwhich i plan on making my afternoon17:06
mriedemmdbooth: the entire goal of that series is to get a serial value in the non-volume block devices right? since we only have serial == volume id today, so for the non-volumes we'll use the bdm.uuid17:08
mriedemand the 20 patch refactor series is because that's how you roll :)17:08
mriedemno offense, i know this code is horrible17:08
*** mingyu has quit IRC17:09
*** fragatina has joined #openstack-nova17:09
melwittmriedem: cool, thanks for the etherpad for the stable release needs17:11
*** RaoulHC has quit IRC17:14
openstackgerritJay Pipes proposed openstack/nova master: rework how we pass candidate request information  https://review.openstack.org/56616617:14
*** tesseract has quit IRC17:15
*** mdnadeem has quit IRC17:16
openstackgerritJay Pipes proposed openstack/nova master: rework how we pass candidate request information  https://review.openstack.org/56616617:16
*** jpena is now known as jpena|off17:17
*** trozet has quit IRC17:17
*** aloga has quit IRC17:19
openstackgerritMerged openstack/nova master: Fix detach_volume calls when rolling back a failed attach  https://review.openstack.org/56321317:22
*** mgoddard has joined #openstack-nova17:23
*** mingyu has joined #openstack-nova17:24
*** hamzy has joined #openstack-nova17:27
*** gouthamr has quit IRC17:27
*** mchlumsky_ has quit IRC17:35
*** gbarros has quit IRC17:36
*** mchlumsky has joined #openstack-nova17:37
*** germs has quit IRC17:37
*** eharney has joined #openstack-nova17:38
*** germs has joined #openstack-nova17:38
*** germs has quit IRC17:38
*** germs has joined #openstack-nova17:38
*** elod has quit IRC17:39
*** mchlumsky has quit IRC17:41
*** mchlumsky has joined #openstack-nova17:43
mriedemdansmith: lyarwood: https://review.openstack.org/#/c/567232/ should be good to go now - change on master just merged17:47
*** gjayavelu has joined #openstack-nova17:47
*** mingyu has quit IRC17:47
*** eharney has quit IRC17:48
*** udesale has quit IRC17:50
*** janki has joined #openstack-nova17:52
jmccarthyHmm trying to setup an encrypted volume, anyone know where does it come up with this device name ?  /dev/disk/by-id/scsi-360014057e4c08a456174ed99b53aa5d6  (paste.openstack.org/show/720695/)18:00
*** armaan has quit IRC18:00
jmccarthyIt all goes wrong after this, and I can't find that device anywhere ..18:00
mriedemjmccarthy: os-brick library18:00
*** armaan has joined #openstack-nova18:00
*** bkopilov has quit IRC18:01
*** eharney has joined #openstack-nova18:01
*** bkopilov_ has quit IRC18:02
jmccarthymriedem: Hmm ok and it's making it up ? Should I be able to 'see' it someplace ?18:02
mriedemlyarwood: is your guy for encrypted volume stuff in os-brick18:02
jmccarthymriedem: kk !18:03
lyarwoodjmccarthy: what are you trying to find, the original volume on the compute host?18:03
jmccarthylyarwood: I'm just trying to find where it's going wrong, I can attach unencrpyted, but not encrypted volumes paste.openstack.org/show/720695/18:04
jmccarthyIt goes wrong after here - as this device can't be found anywhere ? Or I'm looking in wrong places18:04
* lyarwood looks18:04
lyarwoodjmccarthy: paste.openstack.org isn't working for me, can you use https://paste.fedoraproject.org/18:05
jmccarthylyarwood: https://paste.fedoraproject.org/paste/nL0L92U4ArsPfyVkgQlX-Q18:06
jmccarthyIt's brief .. but in the case where it works, I'm pretty sure I find that device under /dev/disk/by-id on the compute host18:07
*** r-daneel has quit IRC18:07
lyarwoodjmccarthy: yeah that's expected the first time you attach the volume18:07
*** r-daneel has joined #openstack-nova18:07
lyarwoodjmccarthy: well, with the older flow where os-brick formats the volume18:07
jmccarthyThat's expected to return 1 is it ?18:07
jmccarthylyarwood: It's expected to return 1 I mean is it ?18:08
jmccarthylyarwood: Ok let me try and attach it again18:08
lyarwoodjmccarthy: yeah I think so, 0 is the device is encrypted already, 1 if it isn't18:08
mriedemmdbooth: https://review.openstack.org/#/c/528362/14/nova/tests/unit/virt/test_block_device.py@28318:09
mriedemam i missing something?18:09
jmccarthylyarwood: Ok my bad, I assumed that was the start of where my attach failed18:09
*** germs has quit IRC18:09
jmccarthylyarwood: I'll look at logs more, it's going wrong but I'm doing a bad job at figuring why lol18:10
*** germs has joined #openstack-nova18:10
*** germs has quit IRC18:10
*** germs has joined #openstack-nova18:10
*** mdbooth has quit IRC18:10
lyarwoodjmccarthy: np, it's an odd flow tbh, feel free to throw another pastebin my way if you want a hand :)18:10
jmccarthylyarwood: Ok thanks ! Will do :)18:11
*** germs has quit IRC18:12
*** eharney has quit IRC18:13
*** germs has joined #openstack-nova18:13
*** germs has quit IRC18:13
*** germs has joined #openstack-nova18:13
*** janki has quit IRC18:13
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Add missing encryption_secret_uuid tests  https://review.openstack.org/54067918:13
*** bkopilov has joined #openstack-nova18:14
jmccarthylyarwood: Maybe this is where I'm going wrong ? https://paste.fedoraproject.org/paste/oSRFKMBJiuCEifxfLXUxhg the volume says it's attaching for a short time, and then just goes back to available18:15
lyarwoodjhesketh: yeah it's disconnecting after the libvirt failure to attach the disk to the domain18:16
*** tssurya has joined #openstack-nova18:16
*** germs has quit IRC18:17
*** armaan has quit IRC18:17
*** germs has joined #openstack-nova18:17
*** germs has quit IRC18:17
*** germs has joined #openstack-nova18:17
*** armaan has joined #openstack-nova18:17
*** armaan has quit IRC18:18
*** eharney has joined #openstack-nova18:18
lyarwoodjmccarthy: can you pastebin the entire req-138f35c8-ed21-4430-bf68-525574657926 flow ?18:18
*** armaan has joined #openstack-nova18:18
jmccarthylyarwood: Sure - let me get that together18:19
*** dklyle has joined #openstack-nova18:19
*** mvenesio has quit IRC18:20
*** mdnadeem has joined #openstack-nova18:20
*** dklyle has quit IRC18:21
*** mvenesio has joined #openstack-nova18:21
*** germs has quit IRC18:21
jmccarthylyarwood: I think this is all of it ? https://paste.fedoraproject.org/paste/6sdkA90XTlkpftZL5j5D~w18:24
*** bkopilov has quit IRC18:24
*** dklyle has joined #openstack-nova18:25
*** mvenesio has quit IRC18:25
lyarwoodjmccarthy: odd, which version of Nova is this?18:28
jmccarthylyarwood: This is a kolla deploy, queens18:29
lyarwoodattach device xml: <disk type="block" device="disk"> is wrong18:29
*** bkopilov_ has joined #openstack-nova18:29
jmccarthylyarwood: Ok let me check that a bit more - I do have one setup that is working and one that isn't - I just can't see wtf is going on18:30
jmccarthylyarwood: Great - Ok, I'll go try and see what is the deal with that - thanks !18:30
lyarwoodjmccarthy: can you just double check that line and make sure it wasn't cut off in your terminal etc18:32
jmccarthylyarwood: One sec18:32
*** mgoddard has quit IRC18:32
jmccarthylyarwood: Ok sorry - part of that bit was missed - this ? https://paste.fedoraproject.org/paste/jR3KP6NlhvTjQZrTl~yK~w18:34
lyarwoodjmccarthy: yeah that's better18:34
lyarwoodjmccarthy: okay so the XML looks good18:34
lyarwoodjmccarthy: are you using fixed_key in nova.conf?18:35
jmccarthylyarwood: Nope - should I be ? I'm going by this here: https://docs.openstack.org/cinder/queens/configuration/block-storage/volume-encryption.html18:36
jmccarthylyarwood: I'm pretty sure they are both configured the same, but setup1 works and setup2 doesn't - I have the logs I'm just going crosseyed with where it's going wrong18:36
lyarwoodjmccarthy: is it the same key in both envs?18:37
lyarwoodjmccarthy: and is the key the same in nova.conf and cinder.conf?18:37
lyarwoodah sorry that doc is using barbican18:37
jmccarthylyarwood: the setups are not connected to each other at all as such, just in the same lab18:38
*** bkopilov has joined #openstack-nova18:38
jmccarthylyarwood: nothing is shared18:38
lyarwoodjmccarthy: kk can you do a cinder show of the volume?18:38
*** mdnadeem has quit IRC18:39
jmccarthylyarwood: Should be this here: https://paste.fedoraproject.org/paste/SQ5quYSt8wKOV~-eTqLNMA18:40
jmccarthylyarwood: I have gone through this a few times, I think the logs aligh with where it's at atm18:40
jmccarthylyarwood: * s/aligh/align18:40
jmccarthylyarwood: maybe the log I sent earlier doesn't make senses .. it was grepped on req-138f35c8-ed21-4430-bf68-52557465792618:42
lyarwoodjmccarthy: yeah there's an underlying libvirt issue here with the attach, I'm just trying to rule out some older known issues with passphrase length etc, for example https://bugzilla.redhat.com/show_bug.cgi?id=144729718:43
openstackbugzilla.redhat.com bug 1447297 in libvirt "Unable to use LUKS passphrase that is exactly 16 bytes long" [Unspecified,Closed: errata] - Assigned to pkrempa18:43
*** gjayavelu has quit IRC18:43
lyarwoodjmccarthy: final ask, `openstack volume type show luks` just to confirm the key_size18:44
lyarwood^ I think that's the correct command at least18:44
lyarwoodhttps://docs.openstack.org/python-openstackclient/pike/cli/command-objects/volume-type.html#volume-type-show yeah it is18:45
lyarwoodopenstack volume type show --encryption-type luks18:45
jmccarthylyarwood: https://paste.fedoraproject.org/paste/34qbpIwDx867wt66JCnUlA18:47
lyarwoodjmccarthy: yeah 256 should be fine, odd.18:48
jmccarthylyarwood: I should be lioadm for the scsi_helper I think it is, right ?18:48
lyarwoodjmccarthy: is the same version of libvirt installed in both envs?18:48
lyarwoodjmccarthy: that really depends on the underlying env but that isn't the issue here18:49
*** dtantsur is now known as dtantsur|afk18:49
lyarwoodjmccarthy: we can see the raw volume, crypsetup is able to format it etc18:49
lyarwoodjmccarthy: libvirt just borks when you try to attach it to the instance18:49
jmccarthylyarwood: I should have maybe mentioned earlier :/ one is tgdadm I think ? vs lioadm18:50
jmccarthylyarwood: Should be same version, have to confirm18:50
lyarwoodjmccarthy: I still can't see how that could cause this failure tbh18:51
*** mvenesio has joined #openstack-nova18:51
jmccarthylyarwood: virsh --version says 3.9.0 on both18:52
jmccarthylyarwood: I know ?18:54
lyarwoodjmccarthy: kk, I'm out of ideas on the OpenStack / Nova side tbh, do you have libvirtd logs?18:54
lyarwoodjmccarthy: I need to drop in 5 btw before my wife kills me18:54
jmccarthylyarwood: Oh I did earlier lemme check again - they didn't say much - it's all good I'm fading also - I'll step through them tomorrow18:55
jmccarthylyarwood: Just more of this here `error : qemuMonitorJSONCheckError:389 : internal error: unable to execute QEMU command 'device_add': Property 'virtio-blk-device.drive' can't find value 'drive-virtio-disk1'`18:56
jmccarthylyarwood: Ok maybe I can get some more debug log out of that18:56
jmccarthylyarwood: Thanks for the help ! I thought maybe it was something obvious I was just missing, but I guess not18:56
lyarwoodjmccarthy: yeah increase the logging there and it might shed some light, iirc I've seen this before when the passphrase wouldn't unlock the volume, I just can't see how that's possible with the current flow tbh.18:57
* lyarwood drops \o_18:58
jmccarthylyarwood: o/18:58
jmccarthylyarwood: \o lol18:58
jmccarthyZzz18:58
*** gouthamr has joined #openstack-nova18:59
*** jmccarthy has left #openstack-nova18:59
*** mvenesio has quit IRC19:00
*** hamzy has quit IRC19:01
*** wolverineav has quit IRC19:01
*** elod has joined #openstack-nova19:02
*** wolverineav has joined #openstack-nova19:02
*** pchavva has quit IRC19:03
*** wolverineav has quit IRC19:06
*** r-daneel_ has joined #openstack-nova19:11
*** r-daneel has quit IRC19:11
*** r-daneel_ is now known as r-daneel19:11
*** felipemonteiro__ has joined #openstack-nova19:11
*** mvk has quit IRC19:13
*** gouthamr has quit IRC19:13
*** felipemonteiro_ has quit IRC19:15
*** ociuhandu has joined #openstack-nova19:16
*** gouthamr has joined #openstack-nova19:17
*** hamzy has joined #openstack-nova19:18
*** fragatina has quit IRC19:19
*** links has joined #openstack-nova19:22
*** ociuhandu has quit IRC19:27
*** dklyle has quit IRC19:40
*** links has quit IRC19:45
*** cdent has quit IRC19:45
*** awaugama has quit IRC19:47
*** wolverineav has joined #openstack-nova19:50
openstackgerritDan Smith proposed openstack/nova master: Make get_instance_objects_sorted() be smart about cells  https://review.openstack.org/50900319:53
*** wolverineav has quit IRC19:54
*** edmondsw has joined #openstack-nova19:54
mriedemdansmith: on this heal allocations CLI, i'm currently pulling instaces per cell and filtering by task_state=None since we don't want to mess with instances that are going through some task state transition,19:55
dansmithyeah19:55
mriedemhowever, for the purpose of reporting why we didn't create allocations for a given instance (like we do if it didn't have a host, e.g. shelved offloaded),19:55
mriedemi'm thinking about removing that filter so we can just check instance.task_state in code and if not None, we log something and continue19:55
mriedembecause it would be weird to say we healed all instances when we don't know that we actually got all instances in a cell19:56
dansmithokay19:56
dansmithin many cases the instances with a task state outstanding will be a fraction of the total19:57
dansmithnot all cases, but probably reasonable as long as you're batching19:57
*** jmlowe has quit IRC19:58
mriedemby default we pull 50 instances per iteration19:58
dansmithyeah, I mean I was stating that you were batching, not asking19:59
esbergluefried: melwitt: mriedem: I've enabled run_validation and added scenario testing in PowerVM CI. This should unblock these three in the runway queue20:01
esbergluSnapshot: https://review.openstack.org/#/c/543023/20:01
esbergluLocaldisk: https://review.openstack.org/#/c/549053/ & https://review.openstack.org/#/c/549300/20:01
esbergluvSCSI is still blocked due to lack of CI, I have noted that on the etherpad20:01
dansmithI thought it was going to make the runs take a long time?20:02
mriedem++lib/tempest:configure_tempest:429        [m iniset /opt/stack/tempest/etc/tempest.conf validation run_validation True20:02
openstackgerritJay Pipes proposed openstack/nova master: add consumer.generation/create missing consumers  https://review.openstack.org/55795820:04
openstackgerritJay Pipes proposed openstack/nova master: placement: add Project, User and Consumer objects  https://review.openstack.org/56540320:04
mriedemlooks like most of the scenario tests are skipped which is what we talked about http://184.172.12.213/23/543023/20/check/nova-in-tree-pvm/ab0b59a/powervm_os_ci.html20:04
openstackgerritJay Pipes proposed openstack/nova master: Add create() methods to Project, User and Consumer  https://review.openstack.org/56540420:04
openstackgerritJay Pipes proposed openstack/nova master: move consumer ensure to API layer  https://review.openstack.org/56540520:04
openstackgerritJay Pipes proposed openstack/nova master: rework allocation handler _allocations_dict()  https://review.openstack.org/56540720:04
openstackgerritJay Pipes proposed openstack/nova master: Add a microversion for consumer generation support  https://review.openstack.org/56560420:04
esberglumriedem: Most of the scenario tests require floating ips and/or volume support which we don't have. I've enabled test_server_basic_ops which is the test specifically called out as blocking20:05
mriedemesberglu: dansmith: melwitt: yeah tempest.scenario.test_server_basic_ops.TestServerBasicOps.test_server_basic_ops is what we wanted20:05
mriedemyup20:05
mriedemlgtm20:05
mriedemtest_server_basic_ops does ssh20:05
esberglumriedem: Yep20:05
mriedemhttps://github.com/openstack/tempest/blob/8d3f0bec6e5e7f396ca1ae9c89978e88ae4f6aeb/tempest/scenario/test_server_basic_ops.py#L3020:05
*** EranBD has joined #openstack-nova20:06
esbergludansmith: test_server_basic_ops is takes a long time, but with tempest concurrency it doesn't actually do much to overall run time20:06
mriedem2018-05-09 12:32:43.192 23165 DEBUG tempest [-] compute-feature-enabled.config_drive = True log_opt_values /usr/local/lib/python2.7/dist-packages/oslo_config/cfg.py:290820:06
dansmithwell, right, it takes longer on other platforms too, but I thought that was the reason given for not enabling it20:06
mriedemthe volume stuff takes 10 minutes for them20:07
mriedemand they don't have a good way to cleanup volume things in their backing storage20:07
dansmithI don't understand what that means20:07
melwittwhich part of the log shows the pass/fail status of each test? I see in the console.txt it shows "will run" or "skip"20:08
dansmithnor how it would be different for someone real trying to do this20:08
mriedemmelwitt: http://184.172.12.213/23/543023/20/check/nova-in-tree-pvm/ab0b59a/powervm_os_ci.html20:08
esberglumelwitt: powervm_os_ci.html in the top level dir20:08
melwittah, thanks20:08
esbergludansmith: test_server_basic_ops doesn't do much to overall runtime. But running all of the volume scenario tests will20:09
mriedemvolume storage isn't on a local disk, i think is the main difference20:09
esbergluPlus the cleanup issue mriedem mentioned20:09
esbergluI'm working on a vSCSI CI job that can be run on demand20:09
dansmithright, I don't understand the cleanup issue specifically20:09
mriedemit can't handle the number of concurrent volume creates and deletes is my understanding20:10
mriedembecause it's enterprise storage :)20:10
dansmithlol20:10
mriedemi remember when i was running powerkvm ci and we had a similar setup,20:11
mriedemit was bricked at least once per week, and that was serial runs twice per day20:11
dansmiththe original powervm ci was similar IIRC20:11
mriedem*powerkvm ci for the ibm distro thing, not pkvm that ibm ltc runs20:11
esbergluouch20:11
mriedemgranted our cleanup bash scripts probably sucked20:12
mriedemand i didn't know enough VIOS CLI to do much good,20:12
mriedembut i remember having to sametime the lab admin once a week who eventually gave me creds to the IMM to just reboot the thing20:12
mriedemi think he eventually pre-empted my sametimes because he knew we were breaking it20:13
*** lpetrut has quit IRC20:14
mriedemlooking at these times, it's not much difference20:14
mriedemIBM PowerVM CI (1 rechecks)1:33 PMnova-out-of-tree-pvmSUCCESS in 1h 27m 36snova-in-tree-pvmSUCCESS in 1h 31m 07s20:14
mriedemefried: i think you can drop the -2 on this now https://review.openstack.org/#/c/543023/20:15
*** zcorneli has joined #openstack-nova20:15
efriedmriedem: Done.20:15
*** zcorneli has quit IRC20:17
*** germs has joined #openstack-nova20:18
*** zcorneli has joined #openstack-nova20:18
*** zcorneli has quit IRC20:21
*** zcorneli has joined #openstack-nova20:21
*** awaugama has joined #openstack-nova20:22
*** germs has quit IRC20:22
*** germs has joined #openstack-nova20:27
*** germs has quit IRC20:27
*** germs has joined #openstack-nova20:27
*** germs has quit IRC20:27
*** vladikr has quit IRC20:28
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk  https://review.openstack.org/54930020:36
*** vladikr has joined #openstack-nova20:40
openstackgerritMatt Riedemann proposed openstack/nova master: Add nova-manage placement heal_allocations CLI  https://review.openstack.org/56588620:40
*** dklyle has joined #openstack-nova20:48
openstackgerritMatt Riedemann proposed openstack/nova master: Deduplicate config/policy reference docs from main index  https://review.openstack.org/56484620:53
openstackgerritMatt Riedemann proposed openstack/nova master: Implement granular policy rules for placement  https://review.openstack.org/52442520:53
openstackgerritMatt Riedemann proposed openstack/nova master: Add granular policy rules for /resource_classes*  https://review.openstack.org/56557820:53
openstackgerritMatt Riedemann proposed openstack/nova master: Cleanup placement policy generator docs  https://review.openstack.org/56522520:53
*** jmlowe has joined #openstack-nova20:53
*** tbachman has quit IRC20:53
*** pcaruana has quit IRC20:59
*** hamzy has quit IRC21:01
openstackgerritMatt Riedemann proposed openstack/nova master: Implement granular policy rules for placement  https://review.openstack.org/52442521:01
openstackgerritMatt Riedemann proposed openstack/nova master: Add granular policy rules for /resource_classes*  https://review.openstack.org/56557821:01
*** mvenesio has joined #openstack-nova21:10
*** gabor_antal has quit IRC21:10
*** gabor_antal has joined #openstack-nova21:10
*** hamzy has joined #openstack-nova21:11
*** Guest53916 has quit IRC21:13
*** vladikr has quit IRC21:13
*** hamzy has quit IRC21:15
*** gouthamr has quit IRC21:16
*** dave-mccowan has quit IRC21:17
*** gabor_antal has quit IRC21:20
*** dave-mccowan has joined #openstack-nova21:22
*** gabor_antal has joined #openstack-nova21:22
*** mvenesio has quit IRC21:24
*** fragatina has joined #openstack-nova21:26
*** fragatina has quit IRC21:26
*** vladikr has joined #openstack-nova21:27
*** fragatina has joined #openstack-nova21:27
efriedmriedem: Is there any exception to the rule of proposing a thing in master and then backporting it?  I.e. any exception process by which we can propose directly to stable without a corresponding master patch?21:27
edmondswif a bug only exists in a stable branch, then it'd be silly to merge something in master just to backport it to stable21:27
edmondswand then revert master21:28
edmondswso there must be cases where we make changes directly in a stable branch21:28
*** hamzy_ has joined #openstack-nova21:29
*** hamzy_ is now known as hamzy21:30
mriedemefried: yes if the bug doesn't exist in master for the most part21:39
efriedmriedem: Okay, cool.  edmondsw esberglu ^21:39
*** jmlowe has quit IRC21:39
mriedemhttps://docs.openstack.org/project-team-guide/stable-branches.html#appropriate-fixes21:39
efriedmriedem: We fixed it in pypowervm 1.1.15 which is now minimum in master nova, but we can't backport the req bump to stable, so we have to do a workaround in nova.21:39
*** gouthamr has joined #openstack-nova21:42
*** awaugama has quit IRC21:42
mriedemmelwitt: you can post backports for this now https://review.openstack.org/#/c/555945/21:48
mriedemefried: i thought the breaking oslo lib change was reverted and blacklisted on stable?21:49
efriedmriedem: It wasn't reverted exactly; and the way in which it was "fixed" doesn't actually fix us.  esberglu is posting the workaround; that commit message will have more details.21:50
efriedgory, gruesome details.21:50
mriedemawesome21:53
mriedemi'm going to delegate to tonyb and bauzas21:53
efriedmriedem: No worries, I was tapping you as the resident process nazi^Wguru to see if it was even legal to skip master.21:54
* mriedem wonders how efried knew i had that new stylish stache21:55
efrieddrone cameras, baby.21:55
*** gouthamr has quit IRC21:59
mriedemzzzeek: ever seen "2018-05-09 16:29:33.278 11031 ERROR nova.api.openstack.extensions DBError: (pymysql.err.InternalError) (1, u"Can't create/write to file '/tmp/#sql_4038_1.MAI' (Errcode: 2)")" ?21:59
mriedemin RHOSP 1121:59
zzzeekmriedem: there's a lot of files in /tmp/ and /tmp/ can run out of space or have fs problems21:59
zzzeekmriedem: it also does this trick where it unlinks the file before using it22:00
zzzeekso you can't see them with ls22:00
openstackgerritMerged openstack/nova stable/pike: Unmap compute nodes when deleting host mappings in delete cell operation  https://review.openstack.org/55382922:01
openstackgerritMerged openstack/nova master: Expose driver_block_device fields consistently  https://review.openstack.org/52836222:01
mriedemok; was just doing bug triage and someone reported that when listing instances22:01
openstackgerritMerged openstack/nova stable/queens: Fix detach_volume calls when rolling back a failed attach  https://review.openstack.org/56723222:01
openstackgerritMerged openstack/nova stable/queens: log stale allocations as WARNING instead of DEBUG  https://review.openstack.org/56727322:01
mriedemi'll leave that info, thanks22:01
zzzeekmriedem: i should find the command we used to see them, it was someting unpleasant22:04
zzzeekoh it was lsof22:04
zzzeekbut , you see the same files over and over again22:04
openstackgerritMoshe Levi proposed openstack/nova master: Adding NVMEoF for libvirt driver  https://review.openstack.org/48264022:04
zzzeekmriedem: https://dev.mysql.com/doc/refman/8.0/en/temporary-files.html  "MySQL arranges that temporary files are removed if mysqld is terminated. On platforms that support it (such as Unix), this is done by unlinking the file after opening it. The disadvantage of this is that the name does not appear in directory listings and you do not see a big temporary file that fills up the file system in which the temporary file directory is22:06
zzzeeklocated. (In such cases, lsof +L1 may be helpful in identifying large files associated with mysqld.) "22:06
*** felipemonteiro__ has quit IRC22:06
mriedemjroll: https://bugs.launchpad.net/nova/+bug/1769817 if you have any insight into that22:07
openstackLaunchpad bug 1769817 in OpenStack Compute (nova) "Ironic serial console doesn't get disabled when instance is deleted" [Undecided,Confirmed]22:07
*** gbarros has joined #openstack-nova22:10
*** slaweq has quit IRC22:10
*** esberglu has quit IRC22:10
*** slaweq has joined #openstack-nova22:10
*** zigo has quit IRC22:11
*** zigo has joined #openstack-nova22:11
*** gouthamr has joined #openstack-nova22:14
*** liverpooler has quit IRC22:15
*** mlavalle has quit IRC22:19
*** tbachman has joined #openstack-nova22:19
mriedemjesus just triaged 2 separate duplicate bugs for this https://review.openstack.org/#/c/564336/ - people must really be getting screwed on that; dansmith - probably good to ^ get in22:20
mriedemerr https://review.openstack.org/#/c/564336/22:20
*** gbarros has quit IRC22:21
*** priteau has quit IRC22:22
*** tbachman has quit IRC22:25
*** vladikr has quit IRC22:26
mriedemdoes this ring a bell? https://bugs.launchpad.net/nova/+bug/176902522:29
openstackLaunchpad bug 1769025 in OpenStack Compute (nova) "OrphanedObjectError: Cannot call obj_load_attr on orphaned Instance object error is thrown for ironic deploy in Pike" [Undecided,New]22:29
mriedemthat's on pike22:29
*** oomichi has joined #openstack-nova22:30
*** mvk has joined #openstack-nova22:32
*** threestrands has joined #openstack-nova22:33
openstackgerritJay Pipes proposed openstack/nova master: Add a microversion for consumer generation support  https://review.openstack.org/56560422:35
*** threestrands_ has joined #openstack-nova22:36
*** threestrands_ has joined #openstack-nova22:36
*** vladikr has joined #openstack-nova22:38
*** threestrands has quit IRC22:38
*** hamzy has quit IRC22:39
mriedemooo upcalls https://bugs.launchpad.net/nova/+bug/176887622:39
openstackLaunchpad bug 1768876 in OpenStack Compute (nova) "Old instances can get AVZ from metadata" [Undecided,New] - Assigned to Surya Seetharaman (tssurya)22:39
mriedemso apparently the metadata-api used to do an up-call to the API DB to get the AZ for an instance, but in pike we started storing the AZ directly on the instance rather than the dumb default 'nova' AZ,22:41
mriedembut for any instances created before pike, they aren't going to have that, so they needed the up-call22:41
*** r-daneel has quit IRC22:43
*** hongbin has quit IRC22:43
openstackgerritEric Fried proposed openstack/nova master: DNM: Granular requests to get_allocation_candidates  https://review.openstack.org/51581122:43
*** vladikr has quit IRC22:45
*** EranBD has quit IRC22:47
openstackgerritMerged openstack/nova stable/queens: Make association_refresh configurable  https://review.openstack.org/56628822:48
*** gouthamr has quit IRC22:52
*** gouthamr has joined #openstack-nova22:55
*** dklyle has quit IRC22:57
*** andreas_s has joined #openstack-nova22:57
*** vladikr has joined #openstack-nova22:58
mriedemmelwitt: everything is ready for queens except https://review.openstack.org/#/c/566367/ which is still on master23:00
mriedemwill redouble my bugging efforts in the wee morn23:00
mriedemsame for pike and ocata actually23:00
*** andreas_s has quit IRC23:01
*** mriedem has quit IRC23:02
tonybefried, esberglu: Add me as a reviewer on the patch and I'll review it with my stable hat23:02
*** edmondsw has quit IRC23:10
*** edmondsw has joined #openstack-nova23:11
*** edmondsw has quit IRC23:15
openstackgerritMerged openstack/nova master: Remove mox in test_xenapi.py (1)  https://review.openstack.org/56463923:25
*** moshele has joined #openstack-nova23:35
*** takashin has joined #openstack-nova23:42
*** hshiina|afk has quit IRC23:45
*** stakeda has joined #openstack-nova23:45
*** lpetrut has joined #openstack-nova23:47
*** Swami has quit IRC23:49
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in test_xenapi.py (2)  https://review.openstack.org/56464323:51
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in test_xenapi.py (3)  https://review.openstack.org/56464523:51
*** lpetrut has quit IRC23:52

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!