Thursday, 2018-05-10

*** gyee has quit IRC00:08
*** dklyle has joined #openstack-nova00:12
*** gbarros has joined #openstack-nova00:13
*** edmondsw has joined #openstack-nova00:13
*** dklyle has quit IRC00:14
*** dklyle has joined #openstack-nova00:14
*** tbachman has joined #openstack-nova00:15
*** gbarros has quit IRC00:15
*** edmondsw has quit IRC00:18
*** yingjun has joined #openstack-nova00:24
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return nested providers in get_by_request  https://review.openstack.org/56711300:29
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add traits check in nested provider cadidates  https://review.openstack.org/56715000:29
openstackgerritTetsuro Nakamura proposed openstack/nova master: Fix broken allocation candidates with traits  https://review.openstack.org/56715100:29
*** yingjun has quit IRC00:30
*** tssurya has quit IRC00:30
*** yingjun has joined #openstack-nova00:36
*** Dinesh_Bhor has joined #openstack-nova00:36
*** liuzz has joined #openstack-nova00:41
*** mikal_ has joined #openstack-nova00:45
*** Dinesh_Bhor has quit IRC00:45
*** oomichi has quit IRC00:47
*** hiro-kobayashi has joined #openstack-nova00:48
*** mikal has quit IRC00:49
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add traits check in nested provider cadidates  https://review.openstack.org/56715000:56
openstackgerritTetsuro Nakamura proposed openstack/nova master: Fix broken allocation candidates with traits  https://review.openstack.org/56715100:56
*** Dinesh_Bhor has joined #openstack-nova01:00
*** jmlowe has joined #openstack-nova01:01
*** hshiina has joined #openstack-nova01:06
*** moshele has quit IRC01:11
*** zhaochao has joined #openstack-nova01:12
*** sq4ind has quit IRC01:13
*** sapd has joined #openstack-nova01:24
*** phuongnh has joined #openstack-nova01:27
openstackgerritMerged openstack/nova master: Convert configdrive to use processutils.  https://review.openstack.org/56572301:30
*** Nel1x has joined #openstack-nova01:34
*** hongbin_ has joined #openstack-nova01:39
openstackgerritErik Olof Gunnar Andersson proposed openstack/nova master: Remove remaning log translation in scheduler  https://review.openstack.org/56745501:43
*** lei-zh has joined #openstack-nova01:50
*** edmondsw has joined #openstack-nova02:01
*** nicolasbock has quit IRC02:01
*** liverpooler has joined #openstack-nova02:03
*** tiendc has joined #openstack-nova02:04
*** edmondsw has quit IRC02:06
*** wwriverrat has quit IRC02:10
*** tinwood has quit IRC02:10
*** wwriverrat has joined #openstack-nova02:12
*** tinwood has joined #openstack-nova02:12
*** mdnadeem has joined #openstack-nova02:18
*** links has joined #openstack-nova02:28
*** andreas_s_ has joined #openstack-nova02:33
*** andreas_s_ has quit IRC02:37
*** sq4ind has joined #openstack-nova02:39
*** liverpooler has quit IRC02:43
*** psachin` has joined #openstack-nova02:45
*** yamamoto has joined #openstack-nova02:55
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver  https://review.openstack.org/52338702:56
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver  https://review.openstack.org/52765802:56
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add snapshot function  https://review.openstack.org/53424002:56
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add power actions  https://review.openstack.org/54334002:56
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add get console output  https://review.openstack.org/54334402:56
openstackgerritMerged openstack/nova master: Add tests for alloc cands with poor local disk  https://review.openstack.org/56684202:56
*** vladikr has quit IRC03:00
*** vladikr has joined #openstack-nova03:01
*** vladikr has quit IRC03:10
*** tiendc has quit IRC03:10
*** vladikr has joined #openstack-nova03:10
*** tiendc has joined #openstack-nova03:12
*** dave-mccowan has quit IRC03:27
*** annp has joined #openstack-nova03:32
*** takashin has quit IRC03:33
*** annp has quit IRC03:36
*** annp has joined #openstack-nova03:37
*** annp_ has joined #openstack-nova03:37
*** annp_ has quit IRC03:38
*** annp has quit IRC03:38
*** hongbin_ has quit IRC03:40
*** links has quit IRC03:43
*** lpetrut has joined #openstack-nova03:44
*** edmondsw has joined #openstack-nova03:50
*** edmondsw has quit IRC03:54
*** fragatina has quit IRC03:55
*** fragatina has joined #openstack-nova03:56
*** gyankum has joined #openstack-nova03:56
*** gyan_ has joined #openstack-nova03:56
*** fragatina has quit IRC04:00
*** yingjun has quit IRC04:10
*** wwriverrat has quit IRC04:11
*** takashin has joined #openstack-nova04:16
*** lpetrut has quit IRC04:24
*** mdnadeem has quit IRC04:24
*** Nel1x has quit IRC04:25
*** udesale has joined #openstack-nova04:27
*** moshele has joined #openstack-nova04:30
*** moshele has quit IRC04:33
*** mdnadeem has joined #openstack-nova04:35
*** hamzy has joined #openstack-nova04:38
openstackgerritMerged openstack/nova master: Migrate tempest-dsvm-multinode-live-migration job in-tree  https://review.openstack.org/55594504:39
*** wolverineav has joined #openstack-nova04:43
*** links has joined #openstack-nova04:49
*** mdnadeem has quit IRC04:53
*** moshele has joined #openstack-nova04:54
*** mdnadeem has joined #openstack-nova04:55
*** Dinesh_Bhor has quit IRC05:00
*** moshele has quit IRC05:01
*** ratailor has joined #openstack-nova05:03
*** janki has joined #openstack-nova05:03
*** rcernin has joined #openstack-nova05:05
*** rmk has quit IRC05:05
*** abhishekk has joined #openstack-nova05:08
*** yamamoto has quit IRC05:09
*** yamamoto has joined #openstack-nova05:10
*** wolverineav has quit IRC05:10
*** wolverineav has joined #openstack-nova05:11
*** wolverineav has quit IRC05:13
*** wolverin_ has joined #openstack-nova05:13
*** wolverin_ has quit IRC05:15
*** wolverineav has joined #openstack-nova05:15
*** mdnadeem_ has joined #openstack-nova05:17
*** ccamacho has quit IRC05:17
*** suresh12 has joined #openstack-nova05:19
*** mdnadeem has quit IRC05:20
*** ratailor_ has joined #openstack-nova05:21
*** fragatina has joined #openstack-nova05:22
*** fragatina has quit IRC05:23
*** fragatina has joined #openstack-nova05:23
*** ratailor has quit IRC05:25
*** lei-zh has quit IRC05:28
*** lei-zh has joined #openstack-nova05:30
*** Roamer` has quit IRC05:33
*** tbachman_ has joined #openstack-nova05:33
*** tbachman has quit IRC05:36
*** tbachman_ is now known as tbachman05:36
*** trinaths has joined #openstack-nova05:37
*** rm_work has quit IRC05:37
*** rm_work has joined #openstack-nova05:37
*** edmondsw has joined #openstack-nova05:38
*** trinaths has quit IRC05:38
*** yingjun has joined #openstack-nova05:40
*** edmondsw has quit IRC05:42
openstackgerritTsuyoshi Nagata proposed openstack/nova master: nova improvement of maximum attach volumes more than 26 vols  https://review.openstack.org/56747205:45
*** suresh12 has quit IRC05:47
*** Dinesh_Bhor has joined #openstack-nova05:48
*** mdnadeem_ has quit IRC05:52
*** moshele has joined #openstack-nova05:52
*** wolverin_ has joined #openstack-nova05:56
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver  https://review.openstack.org/52338705:57
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver  https://review.openstack.org/52765805:57
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add snapshot function  https://review.openstack.org/53424005:57
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add power actions  https://review.openstack.org/54334005:57
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add get console output  https://review.openstack.org/54334405:57
*** ratailor__ has joined #openstack-nova05:57
*** swamireddy has quit IRC05:58
*** jhesketh has quit IRC05:58
*** wolverineav has quit IRC05:58
*** Guest83896 has quit IRC05:58
*** hjensas has quit IRC05:58
*** ratailor_ has quit IRC06:00
*** markmcclain has quit IRC06:00
*** markmcclain has joined #openstack-nova06:00
*** xinliang has joined #openstack-nova06:03
*** mdnadeem_ has joined #openstack-nova06:04
*** rajinir has quit IRC06:05
*** avolkov has joined #openstack-nova06:07
*** Tom-Tom has joined #openstack-nova06:10
*** yingjun has quit IRC06:11
*** wolverin_ has quit IRC06:12
*** ccamacho has joined #openstack-nova06:14
*** fragatin_ has joined #openstack-nova06:17
*** trinaths has joined #openstack-nova06:18
*** fragati__ has joined #openstack-nova06:18
openstackgerritHamdy Khader proposed openstack/nova master: Adding NVMEoF for libvirt driver  https://review.openstack.org/48264006:19
*** fragatina has quit IRC06:20
*** armaan has quit IRC06:20
*** armaan has joined #openstack-nova06:21
*** fragatin_ has quit IRC06:21
*** fragati__ has quit IRC06:27
*** trinaths has quit IRC06:36
*** trungnv has quit IRC06:38
*** trungnv has joined #openstack-nova06:38
*** phuongnh has quit IRC06:39
*** phuongnh has joined #openstack-nova06:40
openstackgerritVishakha Agarwal proposed openstack/nova master: Re-using the code of os brick cinder  https://review.openstack.org/56570306:41
*** trinaths has joined #openstack-nova06:43
*** sridharg has joined #openstack-nova06:47
*** trungnv has quit IRC06:49
*** trungnv has joined #openstack-nova06:49
*** lpetrut has joined #openstack-nova06:49
*** yamamoto has quit IRC06:49
*** andreas_s has joined #openstack-nova06:49
*** pcaruana has joined #openstack-nova06:51
*** mdnadeem_ has quit IRC06:52
*** andreas_s has quit IRC06:54
*** slaweq has quit IRC06:55
*** slaweq has joined #openstack-nova06:55
*** wolverineav has joined #openstack-nova06:55
*** Dinesh_Bhor has quit IRC06:58
*** threestrands_ has quit IRC06:58
*** yamamoto has joined #openstack-nova06:59
*** annp has joined #openstack-nova07:00
*** Dinesh_Bhor has joined #openstack-nova07:04
*** annp has quit IRC07:07
*** MrWatson has quit IRC07:10
*** NostawRm has joined #openstack-nova07:10
*** wolverineav has quit IRC07:10
*** mdnadeem_ has joined #openstack-nova07:10
*** bswrchrd has quit IRC07:11
*** bswrchrd has joined #openstack-nova07:11
openstackgerritjichenjc proposed openstack/nova master: Avoid live migrate to same host  https://review.openstack.org/54268907:16
*** aloga has joined #openstack-nova07:21
*** armaan has quit IRC07:22
*** armaan has joined #openstack-nova07:22
*** Tom-Tom has quit IRC07:23
*** tesseract has joined #openstack-nova07:24
*** zcorneli has quit IRC07:25
*** jangutter has quit IRC07:25
*** edmondsw has joined #openstack-nova07:26
*** edmondsw has quit IRC07:30
*** trungnv has quit IRC07:32
*** trungnv has joined #openstack-nova07:32
*** wolverineav has joined #openstack-nova07:34
openstackgerritNaichuan Sun proposed openstack/nova master: XenAPI: deprecate the config for image handler class path  https://review.openstack.org/49720107:36
*** jpena|off is now known as jpena07:40
*** wolverineav has quit IRC07:41
*** armaan has quit IRC07:44
*** armaan has joined #openstack-nova07:44
*** suresh12 has joined #openstack-nova07:48
*** annp has joined #openstack-nova07:48
*** suresh12 has quit IRC07:52
openstackgerritNaichuan Sun proposed openstack/nova master: XenAPI: deprecate the config for image handler class path  https://review.openstack.org/49720107:55
*** lucas-afk is now known as lucasagomes07:55
*** annp has quit IRC07:57
*** jangutter has joined #openstack-nova07:58
*** mgoddard has joined #openstack-nova08:00
*** vivsoni has quit IRC08:02
*** jmccarthy has joined #openstack-nova08:04
*** toabctl has quit IRC08:04
*** rmart04 has joined #openstack-nova08:05
*** annp has joined #openstack-nova08:06
*** toabctl has joined #openstack-nova08:08
*** Tom-Tom has joined #openstack-nova08:10
*** dougsz has joined #openstack-nova08:10
openstackgerritTsuyoshi Nagata proposed openstack/nova master: fix against pep8  https://review.openstack.org/56750208:11
openstackgerritRadoslav Gerganov proposed openstack/nova master: Add random sleep between retry calls to placement  https://review.openstack.org/56750608:20
*** imacdonn has quit IRC08:23
*** imacdonn has joined #openstack-nova08:23
*** ratailor__ has quit IRC08:25
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return nested providers in get_by_request  https://review.openstack.org/56711308:25
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add traits check in nested provider cadidates  https://review.openstack.org/56715008:25
openstackgerritTetsuro Nakamura proposed openstack/nova master: Fix broken allocation candidates with traits  https://review.openstack.org/56715108:25
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support nested alloc cands with sharing providers  https://review.openstack.org/56750808:25
*** swamireddy has joined #openstack-nova08:29
*** jhesketh has joined #openstack-nova08:29
*** avolkov has quit IRC08:30
*** yingjun has joined #openstack-nova08:30
*** tiendc has quit IRC08:31
*** zhaochao has quit IRC08:34
*** lbragstad[m] has quit IRC08:36
*** vivsoni has joined #openstack-nova08:36
*** sean-k-mooney[m] has quit IRC08:36
*** Kevin_Zheng has quit IRC08:43
*** Kevin_Zheng has joined #openstack-nova08:43
*** derekh has joined #openstack-nova08:45
*** hiro-kobayashi has quit IRC08:47
*** swamireddy has quit IRC08:47
*** jhesketh has quit IRC08:47
*** udesale has quit IRC08:47
*** udesale has joined #openstack-nova08:47
*** andreas_s has joined #openstack-nova08:48
openstackgerritMartin Midolesov proposed openstack/nova master: vmware:Validation video ram against the max video ram allowed.  https://review.openstack.org/56419308:51
*** mdbooth has joined #openstack-nova08:54
*** hiro-kobayashi has joined #openstack-nova08:54
*** guest___ has joined #openstack-nova08:57
openstackgerritjichenjc proposed openstack/nova master: Avoid warning log when image not exist  https://review.openstack.org/56752208:57
guest___hi08:57
guest___can someone help me with GPU?08:57
guest___virtualization?08:57
*** trinaths has quit IRC09:01
openstackgerritNaichuan Sun proposed openstack/nova master: XenAPI: deprecate the config for image handler class path  https://review.openstack.org/49720109:03
*** swamireddy has joined #openstack-nova09:06
*** jhesketh has joined #openstack-nova09:06
*** johnthetubaguy has quit IRC09:09
*** johnthetubaguy has joined #openstack-nova09:10
*** edmondsw has joined #openstack-nova09:14
moshelestephenfin: hi09:14
stephenfinmoshele: o/09:14
moshelestephenfin: how are you? long time since we talked :)09:15
stephenfinCan't complain. Keeping busy :)09:15
moshelestephenfin: the nvme stuff was merged in cinder last night https://review.openstack.org/#/c/505556/ can you review the nova side https://review.openstack.org/#/c/482640/ ?09:16
stephenfinI sure can09:17
moshelestephenfin: thank :) are you going to summit ?09:17
stephenfinYup! Got a talk on NUMA fun (which I really need to finish). You?09:18
moshelestephenfin: me too, so I will see you there. I need to catch up on nova project :)09:19
*** edmondsw has quit IRC09:19
openstackgerritTsuyoshi Nagata proposed openstack/nova master: nova improvement of maximum attach volumes more than 26 vols  https://review.openstack.org/56747209:24
*** hiro-kobayashi has quit IRC09:25
*** trinaths has joined #openstack-nova09:27
*** wolverineav has joined #openstack-nova09:28
*** lbragstad[m] has joined #openstack-nova09:30
*** udesale has quit IRC09:31
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add rules column to instance_group_policy table.  https://review.openstack.org/56083209:31
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add policy to InstacenGroup object and api models.  https://review.openstack.org/56337509:31
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object  https://review.openstack.org/56340109:31
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: WIP: Microversion 2.63 - Use new format policy in server group  https://review.openstack.org/56753409:31
*** yingjun has quit IRC09:36
*** cdent has joined #openstack-nova09:40
*** stakeda has quit IRC09:42
*** masayukig has joined #openstack-nova09:43
guest___hi guys09:44
*** wolverineav has quit IRC09:48
*** lei-zh has quit IRC09:51
*** tbachman_ has joined #openstack-nova10:07
*** tbachman has quit IRC10:08
*** tbachman_ is now known as tbachman10:08
*** yamamoto has quit IRC10:10
*** RaoulHC has joined #openstack-nova10:10
openstackgerritNaichuan Sun proposed openstack/nova master: XenAPI: define a new image handler to use vdi streaming  https://review.openstack.org/48647510:12
*** sean-k-mooney[m] has joined #openstack-nova10:13
openstackgerritMartin Midolesov proposed openstack/nova master: vmware:Validation video ram against the max video ram allowed.  https://review.openstack.org/56419310:13
*** yamamoto has joined #openstack-nova10:17
*** tbachman_ has joined #openstack-nova10:18
*** tbachman has quit IRC10:19
*** tbachman_ is now known as tbachman10:19
openstackgerritNaichuan Sun proposed openstack/nova master: XenAPI: define a new image handler to use vdi streaming  https://review.openstack.org/48647510:22
openstackgerritNaichuan Sun proposed openstack/nova master: XenAPI: document change for supporting image handler  https://review.openstack.org/56307710:25
*** udesale has joined #openstack-nova10:27
*** udesale has quit IRC10:28
*** udesale has joined #openstack-nova10:28
openstackgerritMerged openstack/nova master: remove IVS plug/unplug as they're moved to separate plugin  https://review.openstack.org/53437110:29
*** armaan has quit IRC10:29
*** armaan has joined #openstack-nova10:32
*** Dinesh_Bhor has quit IRC10:33
*** sean-k-mooney has quit IRC10:37
*** abhishekk has quit IRC10:43
*** evin has quit IRC10:48
*** mvenesio has joined #openstack-nova10:50
*** eharney has quit IRC10:50
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in test_compute_api.py (2)  https://review.openstack.org/56755710:52
*** vladikr has quit IRC10:54
*** vladikr has joined #openstack-nova10:55
*** jmlowe has quit IRC10:57
*** tbachman has quit IRC11:00
*** takashin has left #openstack-nova11:00
*** edmondsw has joined #openstack-nova11:02
*** elod has quit IRC11:05
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: WIP: Microversion 2.63 - Use new format policy in server group  https://review.openstack.org/56753411:05
*** elod has joined #openstack-nova11:05
*** edmondsw has quit IRC11:07
*** lucasagomes is now known as lucas-hungry11:09
openstackgerritChris Dent proposed openstack/nova master: VMware: Live migration of instances  https://review.openstack.org/27011611:11
*** nicolasbock has joined #openstack-nova11:12
*** yikun__ has quit IRC11:16
*** Nel1x has joined #openstack-nova11:17
*** udesale_ has joined #openstack-nova11:18
*** udesale_ has quit IRC11:18
*** udesale_ has joined #openstack-nova11:18
*** udesale_ has quit IRC11:18
*** udesale_ has joined #openstack-nova11:19
*** udesale has quit IRC11:21
*** bkopilov_ has quit IRC11:22
*** bkopilov has quit IRC11:23
*** yamamoto has quit IRC11:23
*** eharney has joined #openstack-nova11:27
*** Tom-Tom has quit IRC11:29
*** Tom-Tom has joined #openstack-nova11:29
*** rcernin has quit IRC11:31
*** jchhatbar has joined #openstack-nova11:34
*** Tom-Tom has quit IRC11:34
*** Nel1x has quit IRC11:35
*** janki has quit IRC11:35
*** bkopilov_ has joined #openstack-nova11:35
*** bkopilov has joined #openstack-nova11:36
*** jchhatba_ has joined #openstack-nova11:38
*** jchhatbar has quit IRC11:41
*** mvenesio has quit IRC11:41
*** cdent has quit IRC11:42
*** mvenesio has joined #openstack-nova11:42
*** StevenK_ has joined #openstack-nova11:44
*** StevenK has quit IRC11:44
*** StevenK_ is now known as StevenK11:44
*** armaan has quit IRC11:44
*** armaan has joined #openstack-nova11:45
*** yamamoto has joined #openstack-nova11:47
*** jchhatba_ has quit IRC11:51
*** cdent has joined #openstack-nova11:51
*** bhujay has joined #openstack-nova11:52
bhagyashri_scdent: Hi, I am trying to write the functional test case for change https://review.openstack.org/#/c/560459 . I have written functinal test for the change # link http://paste.openstack.org/show/720747/ in /nova/tests/functional/test_servers.py11:55
*** lucas-hungry is now known as lucasagomes11:56
cdenthi bhagyashri_s. is it not doing what you want?11:56
*** wolverineav has joined #openstack-nova11:57
cdentbhagyashri_s: for what you are trying to test, a functional test in test_servers is probably not what you want12:02
*** sambetts|afk is now known as sambetts12:02
cdentbecause what you're trying to test is that the virt driver is creating the right data (in the ProviderTree), not create resource providers12:03
cdentbhagyashri_s: basically what Eric says in his comment12:03
*** StevenK has quit IRC12:04
*** jpena is now known as jpena|lunch12:06
*** phuongnh has quit IRC12:10
bhagyashri_scdent: Firstly the change is regarding the shared resource provider thing . When user configure the shared resource provider then at that time the DISK_GB inventory should report from shared rp and not from the compute node rp12:10
*** amoralej is now known as amoralej|lunch12:10
bhagyashri_scdent: and for that libvirt driver update_provider_tree() removes the DISK_GB inventory from the cn rp if the shared rp is configure12:11
* cdent nods12:12
cdentso in your test you should need to create a server. instead you just need to confirm that the correct resource providers and inventory are created12:12
cdentsorry: shouldn't need!12:12
*** mvk has quit IRC12:14
bhagyashri_scdent so in my functional test case i am trying to update by calling the resource tackers update_provider_tree which basically updates the inventory internally using def _update() method which calls the drivers update_provider_tree() method and in my test case how should i instantiate the LibvirtDriver12:14
*** StevenK has joined #openstack-nova12:16
openstackgerritPetersingh Anburaj proposed openstack/nova master: Making consistent used of GiB and MiB in Doc  https://review.openstack.org/55998512:17
*** tbachman has joined #openstack-nova12:17
cdentbhagyashri_s It sounds like you are trying to test from too high a level. Maybe try: Set up the sharing resource provider and put it an aggregate. Then create a ProviderTree representing a compute node, put it in aggregate too, then pass that to the method on the virt driver and make sure that the provider tree that comes back doesn't have local disk. I'm not sure of the setup you'll need to do for that, without doing a12:18
cdentmore digging12:18
cdentif/when efried comes back you might check with him, but the virt drivers are an area I've done very little work with12:19
*** tssurya has joined #openstack-nova12:21
*** pchavva has joined #openstack-nova12:22
openstackgerritNguyen Hai proposed openstack/nova-specs master: Follow the new PTI for document build  https://review.openstack.org/55180212:23
jrollsomeone wake up mriedem before I forget to tell him a thing :P12:23
*** mvenesio has quit IRC12:23
*** felipemonteiro has joined #openstack-nova12:23
*** mvenesio has joined #openstack-nova12:24
cdentdestroy all irc12:25
*** felipemonteiro_ has joined #openstack-nova12:27
efriedō/12:27
bhagyashri_scdent: ok ty12:27
efriedreading back...12:27
*** AlexeyAbashkin has joined #openstack-nova12:28
*** felipemonteiro has quit IRC12:29
efriedcdent, bhagyashri_s: Yes we want a unit test, but we also want a functional test.  The functional test should do just what your paste shows.  When we talked about this a couple of days ago, I offered to help you debug it IF you posted your WIP test case to the change set so I could download it and be at the same baseline, rather than copy/pasting from pastebin and trying to figure out where to put it and how to run it.12:33
*** Roamer` has joined #openstack-nova12:36
*** AlexeyAbashkin has quit IRC12:37
*** lyan has joined #openstack-nova12:37
bhagyashri_sefried: because of some environmental issue  iam not able to push patches so just paste the code in paste.openstack.org12:37
*** lyan is now known as Guest8172212:38
*** evin has joined #openstack-nova12:38
*** trinaths has quit IRC12:39
bhagyashri_sefried: once it will resolved i will push it, I catch the issue in my functional test case, as the change is in libvirt code so through the functional test case the driver is not loaded and that's why the inventory is not properly updated so my doubt is how i will initiate the driver so that it report the correct inventory if the shared resource provider is configured12:42
bhagyashri_sefried: sorry for inconvenience i am not able to push the patch12:43
bauzasFWIW, folks I'm on PTO till end of the week12:43
bauzascall it May-hem12:43
efriedbhagyashri_s: okay, can you pastebin the whole file including imports and tell me the path where you put it?12:44
bauzasefried: jaypipes: cdent: I'm on slides mode for my YVR talk but something came out of my mind. Do we plan to have quota resources using Placement resource classes ?12:47
*** liverpooler has joined #openstack-nova12:47
bauzasefried: jaypipes: cdent: for example, we now have VGPU RC12:47
*** AlexeyAbashkin has joined #openstack-nova12:47
bauzasefried: jaypipes: cdent: I guess operators would love to get quotas for vGPUs12:47
bauzasso, how to help them ?12:47
efriedI still don't know what a quota is12:47
*** AlexeyAbashkin has quit IRC12:48
bauzasefried: it's old story12:48
bauzasefried: https://docs.openstack.org/nova/pike/admin/quotas.html12:48
bhagyashri_sefried: #link http://paste.openstack.org/show/720752/ path: nova/tests/functional/test_servers.py12:48
*** janki has joined #openstack-nova12:49
*** diga has joined #openstack-nova12:49
bauzasefried: and https://docs.openstack.org/nova/latest/user/quotas.html12:50
*** edmondsw_ has joined #openstack-nova12:51
*** liverpooler has quit IRC12:51
*** liverpooler has joined #openstack-nova12:52
openstackgerritHironori Shiina proposed openstack/nova master: ironic: Support resize and cold migration  https://review.openstack.org/50067712:53
*** bswrchrd has quit IRC12:55
*** hshiina is now known as hshiina|afk12:58
*** bhujay has quit IRC13:02
*** pcaruana|afk| has joined #openstack-nova13:03
*** NotPcaruana has joined #openstack-nova13:04
*** vladikr has quit IRC13:05
*** gyankum has quit IRC13:05
*** gyan_ has quit IRC13:05
openstackgerritLee Yarwood proposed openstack/nova master: Rename parameters in call() of nova/image/glance.py  https://review.openstack.org/50853313:05
*** vladikr has joined #openstack-nova13:05
*** avolkov has joined #openstack-nova13:08
*** tssurya has quit IRC13:16
moshelemelwitt: hi, the cinder changes for nvmeof is merged in cinder so can you review the nova change https://review.openstack.org/#/c/482640/13:17
*** tssurya has joined #openstack-nova13:17
efriedbauzas: So you're thinking about implementing quotas in placement, such that a user and/or project ID is allowed only a certain amount of a given resource class?13:21
bauzasefried: well, yes13:22
efriedbauzas: It seems like a reasonable idea.  I don't recall having heard of any plans along those lines, but that doesn't mean it's not on the radar for someone.13:22
efriedbauzas: queue it up for Denver?13:22
bauzasefried: my point is about the fact we created a new resource class, VGPU13:23
bauzasefried: now the scheduler verifies it13:23
jaypipesbauzas: that's a good discussion. I'd like to have melwitt in it, though.13:23
efriedagree13:23
jaypipesbauzas: shall we wait for her?13:23
bauzasjaypipes: sure, but I'm in vacations atm :)13:23
bauzasin the beach :)13:23
*** psachin` has quit IRC13:23
bauzasso when she's here, not sure I'll be here too :p13:24
*** abhishekk has joined #openstack-nova13:24
bauzasbut anyway13:24
bauzasnothing really important atm13:24
bauzasit's more for my talk13:24
jaypipesbauzas: alex_xu was also working on quotas and placement things13:24
bauzasgtk13:24
bauzasAFAIK, we don't support custom quotas, right?13:24
jaypipesbauzas: I'm not sure any more.13:26
bauzasyup13:26
bauzasit was possible previously13:26
bauzasbut when we provided the quotas for cells v2, then we stopped that13:26
bauzasthat's what I remember at least13:26
jaypipesbauzas: right. I was under the impression that we (nova) would start using the placement API for various usage queries. but I don't think that's been done yet.13:31
*** jistr is now known as jistr|mtg13:32
*** vladikr has quit IRC13:32
*** vladikr has joined #openstack-nova13:33
*** tssurya has quit IRC13:34
*** NotPcaruana has quit IRC13:34
*** pcaruana|afk| has quit IRC13:34
jaypipesKevin_Zheng: lmao 'All of a sudden, everyone uses the word "granular"'13:35
jaypipesefried: ^13:36
*** mriedem has joined #openstack-nova13:37
mriedemstephenfin: bauzas: can one of you take a look at this? https://review.openstack.org/#/c/566367/ needs a final +2 and then we need to backport it through to ocata13:38
bauzasmriedem: I'm on PTO today and tomorrow, but see if I can help13:38
*** dklyle has quit IRC13:40
*** moshele has quit IRC13:40
jrolljaypipes: bauzas: yeah, I know it's on alex_xu's list to do quotas on resource classes, not sure if he has anything proposed upstream yet13:43
stephenfinmriedem: Sure13:43
openstackgerritStephen Finucane proposed openstack/nova master: objects: Add NUMANetworkInfo object  https://review.openstack.org/56443913:43
openstackgerritStephen Finucane proposed openstack/nova master: conf: Add '[neutron] physnets' and related options  https://review.openstack.org/56444013:43
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Start populating NUMACell.network_info field  https://review.openstack.org/56444113:43
openstackgerritStephen Finucane proposed openstack/nova master: objects: Add NetworkRequest.physnet, tunnelled  https://review.openstack.org/56444213:43
openstackgerritStephen Finucane proposed openstack/nova master: network: Unchain _get_phynet_info from _get_port_vnic_info  https://review.openstack.org/56444313:44
openstackgerritStephen Finucane proposed openstack/nova master: network: Add 'populate_networks' to network API  https://review.openstack.org/56444413:44
openstackgerritStephen Finucane proposed openstack/nova master: network: Add '_get_network_tunnel_status'  https://review.openstack.org/56444513:44
openstackgerritStephen Finucane proposed openstack/nova master: db: Add network_requests to instance_extra  https://review.openstack.org/56444613:44
openstackgerritStephen Finucane proposed openstack/nova master: objects: Add Instance.network_requests  https://review.openstack.org/56444713:44
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Start accounting for network requests  https://review.openstack.org/56444813:44
openstackgerritStephen Finucane proposed openstack/nova master: rt: Start utilizing Instance.network_requests  https://review.openstack.org/56444913:44
openstackgerritStephen Finucane proposed openstack/nova master: objects: Add RequestSpec.requested_networks  https://review.openstack.org/56445013:44
openstackgerritStephen Finucane proposed openstack/nova master: api: Remove unnecessary default parameter  https://review.openstack.org/56445113:44
openstackgerritStephen Finucane proposed openstack/nova master: scheduler: Start utilizing network_requests  https://review.openstack.org/56445213:44
jaypipesjroll: last I heard, he was focusing on quota-by-aggregate and ran into a number of issues...13:44
jrolljaypipes: yar, he's working through it13:44
jaypipesjroll: sorry, had to wait until stephenfin's patch-cloud passed.13:44
jrollheh13:44
stephenfin☁ ☁ ☁13:44
jaypipeswhich reminds me I need to complete reviews on those. :)13:44
stephenfinjaypipes: Would be appreciated. Fixed the Tempest issue (thanks gibi/mriedem) and addressed what comments were there so far13:45
jaypipesgibi: I've read your ML post about the instance migration UUID thing three times and looked at the map_instances() function. and I still don't get it :(13:45
stephenfinjaypipes: we're using a munged UUID as a marker so we catch batch up the migrations13:46
*** links has quit IRC13:46
*** eharney has quit IRC13:46
*** andreas_s has quit IRC13:47
stephenfincos it's munged, it's not a valid UUID and oslo.whatever complains13:47
*** andreas_s has joined #openstack-nova13:47
*** tssurya has joined #openstack-nova13:47
jaypipesstephenfin: right, but I don't understand why we're doing the replace('-','') thing at all13:47
stephenfinedleafe tried to fix it before but dansmith found the solution distressing13:47
*** jpena|lunch is now known as jpena13:47
stephenfinbecause there's a UNIQUE constraint on that column13:47
stephenfinif we didn't do that, it would clash with the instance (or whatever that UUID is taken from)13:48
jaypipesstephenfin: ok, but why are we changing it?13:48
jaypipesstephenfin: ah... so all migrations have the same uuid?13:48
*** eharney has joined #openstack-nova13:48
stephenfinjaypipes: My memory on this is hazy but I don't think that's it13:49
stephenfinThe revert of the edleafe's solution is here 9038738d0134c0a1d59757ed3205d84f7641686913:49
stephenfin(commit ID)13:49
tssuryajaypipes: we use this as a marker for nova-manage map_instances13:49
jaypipesstephenfin: k, thx for the commit ID. I'll look it up and see if I can understand the problem better.13:51
stephenfinOh, yeah, now I remember13:51
stephenfinSo we store a special string for InstanceMappingList.project_id13:51
stephenfinand then for the UUID value, we store the list of the last InstanceMappingList that we processed13:51
*** mlavalle has joined #openstack-nova13:52
stephenfinbut munged, so it won't conflict with that InstanceMappingList's UUID13:52
dansmithI haven't read the thread,13:52
*** mvk has joined #openstack-nova13:52
dansmithbut we can't change this unless you provide a migration path for people that might be in the middle of the process when they apply the patch13:52
*** andreas_s has quit IRC13:53
dansmithand if this is just because of the damn o.vo UUIDField warning (which I didn't want in the first place) I think it's not worth a change13:53
*** mrf has joined #openstack-nova13:55
mrfHi,13:55
mrfAfter a Resize i got Instance at Error with the next drop in nova-compute:  InstanceNotFound: Instance 299fd82f-f081-4c81-8226-70d208f10a8f could not be found. any ideas?13:55
*** hongbin has joined #openstack-nova13:55
*** armaan has quit IRC14:01
*** armaan has joined #openstack-nova14:02
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Explain how the marker works for instance-cell mapping  https://review.openstack.org/56759714:05
*** tbachman has quit IRC14:05
stephenfingibi, dansmith: ^14:05
mriedembauzas: fyi in case you haven't seen this yet https://openstack-in-production.blogspot.com/2018/05/introducing-gpus-to-cern-cloud.html14:08
*** tetsuro has joined #openstack-nova14:08
*** awaugama has joined #openstack-nova14:08
*** r-daneel has joined #openstack-nova14:08
bauzasmriedem: just discussed on twitter with tim14:08
bauzasbut thanks14:09
*** esberglu has joined #openstack-nova14:09
*** yamamoto has quit IRC14:10
openstackgerritEric Berglund proposed openstack/nova stable/queens: Stringify instance UUID  https://review.openstack.org/56759914:13
tetsurojaypipes, efried: Could you have a look at https://review.openstack.org/#/c/567113/5, if you have time?14:13
*** jistr|mtg is now known as jistr14:17
*** lpetrut has quit IRC14:20
*** andreas_s has joined #openstack-nova14:22
*** tetsuro has quit IRC14:22
*** rajinir has joined #openstack-nova14:23
*** andreas_s has quit IRC14:27
*** edmondsw_ is now known as edmondsw14:28
*** cdent has quit IRC14:34
*** diga has quit IRC14:34
*** ccamacho1 has joined #openstack-nova14:35
*** ccamacho has quit IRC14:35
*** cdent has joined #openstack-nova14:35
*** dklyle has joined #openstack-nova14:36
mriedemdansmith: question in https://review.openstack.org/#/c/509003/ about how the cell_mappings kwarg gets through to the DB API query method, i.e. why you need to do this https://review.openstack.org/#/c/509003/12/nova/tests/unit/api/openstack/fakes.py14:42
mriedemotherwise the rest are nits which can be deal with in a follow up14:42
mriedem*dealt14:42
*** sean-k-mooney has joined #openstack-nova14:42
dansmithack, will look in a bit14:43
sean-k-mooneyi have an interesting (annoying) issue with my teams openstack devcluster ... what does the value of the deleted column in the nova.instnaces table mean?14:46
dansmithsean-k-mooney: deleted=id means the instance is deleted14:46
dansmithdeleted=0 means it's not14:46
sean-k-mooneydansmith: thanks. i have an instance that shows up in opentack server list but cant be found when i do a openstack server delete or nova force-delete14:47
sean-k-mooneydansmith: that was exactly what i was looking for ill see if that "deletes it"14:47
dansmithmaybe it's missing a mapping?14:47
sean-k-mooneydansmith: or when my database crashed because the binary logs filled up the disk it currupted the entries...14:48
dansmithor that :)14:48
sean-k-mooneydansmith: it was mapped in the nova_api db. i tried deleteing it from there to see if it would be enough but it looks like i have to remove it from the cell0 db too or at least mark it as deleted14:49
dansmithyeah, list will still find it without a mapping unless it's actually deleted14:49
*** ccamacho1 has quit IRC14:50
sean-k-mooneydansmith: its currently messsing with my nodepool deployment because it keeps trying to delete it and cant hence my db hacking14:50
dansmithack14:50
*** felipemonteiro_ has quit IRC14:50
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Migrate tempest-dsvm-multinode-live-migration job in-tree  https://review.openstack.org/56761214:51
*** mingyu has joined #openstack-nova14:53
*** lpetrut has joined #openstack-nova14:54
jrollmriedem: fyi, https://review.openstack.org/56757714:55
jrollthanks for pointing me at that bug, is not good14:55
*** janki has quit IRC14:56
openstackgerritEric Berglund proposed openstack/nova stable/queens: Stringify instance UUID  https://review.openstack.org/56759914:56
mriedemjroll: ok, are there also going to need to be nova changes?14:57
jrollmriedem: not in our driver, I'm not sure what you all do / need to do to shut down the connection on instance destroy14:57
mriedemjroll: that reply is confusing14:59
jrolllemme try again14:59
tssuryamriedem: thanks for triaging https://bugs.launchpad.net/nova/+bug/1768876 , shall I go ahead with the migration tool then for populating the ones that are missing?14:59
mriedemif there is nothing to do in the ironic driver, then i don't think there is anything to change in nova14:59
mriedemtssurya: i was just going to ask you about that,14:59
openstackLaunchpad bug 1768876 in OpenStack Compute (nova) queens "metadata-api fails to get availability zone for instances created before pike" [High,Triaged]15:00
mriedemtssurya: it will require some thought, because i'm not sure what got put into instance.availability_zone before that change in pike,15:00
*** mvenesio has quit IRC15:00
mriedemi.e. is it None if the user doesn't specify an AZ when creating the instance? or does it default to 'nova'?15:00
tssuryawasn't it None ?15:00
jrollmriedem: the driver gives back some console URL, right? and nova's proxy thing connects to it? does that connection need to be closed or do we just let it die? if it needs to be closed, does nova do that already? (I guess this is outside the scope of the bug, but could be an improvement)15:00
mriedemi'm not sure, but it will matter if we add an online data migration routine since we'll need to know which instances need to be migrated15:00
tssuryamriedem: yea, I will try to dig more into the tree then15:01
mriedemjroll: not sure, probably a good question for melwitt15:01
jrollmriedem: ok, I'm sure it isn't urgent anyway. can mark that closes-bug instead if you like, but gonna wait for some reviews/CI results first15:02
*** andreas_s has joined #openstack-nova15:02
*** abhishekk has quit IRC15:02
mriedemi'll mark invalid for nova,15:03
mriedemand just point to the SB entry15:03
*** jmlowe has joined #openstack-nova15:03
jrollwfm15:04
mriedemunrelated, but looks like issues in storyboard aren't found via google search?15:04
jrollno clue15:05
*** mgoddard has quit IRC15:05
jrollthat would be sad15:05
mriedemlike, trump level sad?15:05
mriedemhash tag sad?!15:05
jrollSAD!15:06
*** andreas_s has quit IRC15:07
*** janki has joined #openstack-nova15:07
artomMALA!15:09
*** mgoddard has joined #openstack-nova15:09
artomMake Launchpad Great Again!15:09
melwittjroll: the driver hands back a URL essentially that points at the console proxy. then the end user visits it and that initiates the connection to the proxy. AFAIK it's closed when the end user closes the console. I'm not aware that nova ever does anything to close it15:09
melwittI like launchpad fine, never understood to push for storyboard15:10
jrollmelwitt: ok cool, thanks15:10
artomNIH?15:10
mriedemmelwitt: shhh15:10
mriedemshort answer on SB indexing in google is no15:11
mriedemnot yet15:11
mriedemsee -dev for details15:11
*** yamamoto has joined #openstack-nova15:11
melwittmriedem: I didn't think we'd need a blueprint for this https://blueprints.launchpad.net/nova/+spec/add-documentation-rules-api-ref ?15:13
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Migrate tempest-dsvm-multinode-live-migration job in-tree  https://review.openstack.org/56761715:15
mriedemmelwitt: ha no15:15
*** david-lyle has joined #openstack-nova15:17
*** david-lyle has quit IRC15:18
*** amoralej|lunch is now known as amoralej15:18
openstackgerritMatt Riedemann proposed openstack/nova stable/ocata: Migrate tempest-dsvm-multinode-live-migration job in-tree  https://review.openstack.org/56761915:18
*** yamamoto has quit IRC15:19
*** sridharg has quit IRC15:19
mriedemmelwitt: just leave a comment that you don't need a blueprint to write contributor docs and mark the bp obsolete since that's as close to invalid as we get in launchpad15:19
*** jogo has quit IRC15:19
*** armaan has quit IRC15:20
melwittmriedem: k thanks15:20
mriedemi also don't really want to review said contributor doc additions, but...15:20
*** armaan has joined #openstack-nova15:20
mriedemsimply linking from the contributor docs to the api-ref wiki would be good enough IMO15:20
*** _pewp_ has quit IRC15:22
melwittokay, I'll suggest that on the bp15:24
*** shaohe_feng has quit IRC15:24
*** alex_xu has quit IRC15:24
*** lpetrut has quit IRC15:27
*** dklyle has quit IRC15:28
*** NostawRm has quit IRC15:28
*** NostawRm has joined #openstack-nova15:28
*** wwriverrat has joined #openstack-nova15:30
*** suresh12 has joined #openstack-nova15:32
*** dklyle has joined #openstack-nova15:33
*** wwriverrat has quit IRC15:35
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: libvirt: check image type before removing snapshots in _cleanup_resize  https://review.openstack.org/56762315:39
mdboothmriedem: Thanks for the review, btw. Working on addressing your comments, without embarking on another big cleanup.15:39
mriedemmdbooth: np; i thought i had figured out why the compute manager test in the 3rd or 4th patch in the series was failing (due to the fake driver wanting legacy bdms) but that didn't fix it locally for me15:40
*** moshele has joined #openstack-nova15:41
mdboothYeah, I got to the bottom of that. It's an annoying testing artifact.15:41
*** wwriverrat has joined #openstack-nova15:42
mdboothThe initializer pre-populates the dict subclass with a bunch of fields. This isn't required in the new class as it has only proxy fields, and can't be done for all proxied fields because is_volume is a property and isn't writable.15:43
dansmithmriedem: that stub_instance thing is because of a failure, not because I was being overly thorough :)15:43
mdboothAnyway, I'll come up with something. Thanks again.15:43
dansmithmriedem: I'll remove and run tests to highlight which one it was15:43
*** jogo has joined #openstack-nova15:44
dansmithI think it's probably fping or something, which mocks something with the stub_instance that would have shadowed the inner call we make with cell_mappings15:44
mriedemdansmith: ok, as noted i didn't run all tests, just a sample, but anyway15:44
dansmithmriedem: yup15:44
mriedemdansmith: do you plan on doing a cleanup followup? otherwise i'm happy to.15:45
mdboothI suspect I'm going to end up with some test-only code in block_device.py, though, because the tests need some way to serialise a whole object for comparison, whereas runtime code just accesses fields by name.15:45
mriedemsince they're my nits15:45
dansmithmriedem: I haven't looked at all your comments, but if there are legit ones I'll do it yeah15:45
mriedemmdbooth: we shouldn't need test-only code in block_device.py. if we need special serialize code for those types of objects, surely we could house that in test utils separately15:46
mriedeme.g. we have special comparison methods for versioned objects15:46
mdboothmriedem: It might come to that, but that's a bit of big cleanup I was hoping to avoid.15:46
mdboothI think I'd end up having to poke a bunch of block_device tests.15:47
mdboothBut yeah, that was my first thought.15:47
mriedemok i guess i don't know the root issue and what the fix would be to understand why a lot of stuff would have to change just for comparing local image bdms15:47
*** suresh12 has quit IRC15:48
mdboothWell, there's already a bunch of test-only code in that module as it happens, it's just not obvious that it's test only.15:48
mdboothI guess I could sneak it in :)15:49
*** lpetrut has joined #openstack-nova15:49
mdboothBasically anything which calls self.update() in _transform for a proxy attribute is test-only.15:50
mdboothBut... I really don't want to clean it all up right now :)15:50
mriedemok, so can't you follow suit for the new local image bdm?15:50
mdboothmriedem: I can, yes, but I was going to be honest and mark it as test-only :)15:52
mriedemhttps://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L226 and https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L242 could clearly be changed to just use self._fields to avoid the duplicatoin15:52
*** pcaruana has quit IRC15:52
dansmithmriedem: 8 fails: https://pastebin.com/jUSj03qW15:52
mdboothmriedem: Yep.15:52
mriedemgd fping15:53
dansmithikr15:53
mriedemdansmith: looks like it's time i delete that code which i've been meaning to anyway15:53
dansmith\o/15:53
mriedemas a start for the nova-net REST API delete pattern15:53
mriedemwill do that in a bit15:53
* mriedem realizes some stole the pen from his office and will pay dearly15:54
mriedem*someone15:54
mriedemmtreinish: fyi, tox -e py27 -- <foo> doesn't work in nova in stable/pike,15:55
mriedemi think because of ostestr?15:55
mriedemor our tox.ini isn't passing the regex through properly15:55
mtreinishmriedem: yeah I think someone bumped constraints on pike to pull in os-testr 1.0.0 which broke the loophole nova was using for that (that was the thing mikal was complaining about in denver)15:56
mriedemhttps://github.com/openstack/nova/commit/bb7628fdf3b7481a0ca487cf6ede0babc4890ac5#diff-b91f3d5bd63fcd17221b267e851608e8 is in pike15:56
mtreinishI'm not sure why that was bumped on a stable branch though, but I've been pinged by a few people because of things that broke because of it15:56
mtreinishmriedem: in the short term just do tox -epy27 -- --regex <foo>15:57
mriedemdoing that now15:57
mriedemthat doesn't seem to work15:58
mriedemunless my regex is wrong15:58
mriedemtox -e py27 -- --regex test_cleanup_resize_not_same_host15:59
mtreinishoh, it's probably the quotes around posargs in the tox.ini16:00
mtreinishit probably is treating it as a single parameter with a space instead of a flag16:00
mriedemf it, zuul can tell me if i screwed up16:00
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: libvirt: check image type before removing snapshots in _cleanup_resize  https://review.openstack.org/56762516:00
*** rmart04 has quit IRC16:02
*** _pewp_ has joined #openstack-nova16:04
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: libvirt: check image type before removing snapshots in _cleanup_resize  https://review.openstack.org/56762516:06
mriedemcfriesen_: i know you're using postgres, have you ever hit the issue described here? https://groups.google.com/forum/#!topic/sqlalchemy/sRgvpjUkzPU16:07
mriedemlooks like eventlet shenanigans with pg and sqla16:07
cfriesen_on a call, will take a look in a bit16:08
*** germs has joined #openstack-nova16:10
*** germs has quit IRC16:10
*** germs has joined #openstack-nova16:10
*** mdnadeem_ has quit IRC16:11
*** gyee has joined #openstack-nova16:13
openstackgerritMatt Riedemann proposed openstack/nova stable/ocata: libvirt: check image type before removing snapshots in _cleanup_resize  https://review.openstack.org/56763016:17
*** sambetts is now known as sambetts|afk16:21
tssuryamriedem: looks like the avz setting if its not specified by the user depends on CONF.default_schedule_zone (https://github.com/openstack/nova/blob/23fce8c13f8347a8ad862ab38ae9d8259db21349/nova/compute/api.py#L487)16:22
*** nicolasbock has quit IRC16:22
mriedemtssurya: ok which defaults to None https://docs.openstack.org/nova/pike/configuration/config.html#DEFAULT.default_schedule_zone16:22
tssuryamriedem: yes,16:23
mriedemso, i kind of wonder how we didn't break the meaning / contract of None with the change in pike to always set AZ16:23
mriedem"* None, which means that the instance can move from one availability zone to     another during its lifetime if it is moved from one compute node to another."16:23
*** nicolasbock has joined #openstack-nova16:24
mriedemi.e. before the change in pike, i could create an instance w/o specifying AZ and freely migrate to any compute node, but now if randomly land in AZ1, i'm bound to AZ1 even though i never specified that16:25
mriedemwhich also likely means operators are going to use the force flag when live migrating those types of instances16:25
*** fragatin_ has joined #openstack-nova16:25
tssuryamriedem: uh-huh, I see16:26
mriedemwell, i assume that's true anyway, i haven't tried it, but it should be easy to reproduce with a functional test16:26
mriedemcreate 2 computes in separate AZs, create the instance w/o specifying AZ, and then live migrate it and see if scheduling fails16:27
mriedemif that works in ocata but not > ocata then we regressed16:27
tssuryamriedem: ack, I will look into this16:27
*** mvenesio has joined #openstack-nova16:28
*** suresh12 has joined #openstack-nova16:29
*** masayuki- has joined #openstack-nova16:29
*** tbachman has joined #openstack-nova16:29
*** pcaruana has joined #openstack-nova16:36
openstackgerritMatt Riedemann proposed openstack/nova master: Move create_tap_dev to the new utility module.  https://review.openstack.org/55783516:37
openstackgerritMatt Riedemann proposed openstack/nova master: Move set_vf_interface_vlan to the new utility module.  https://review.openstack.org/55848716:37
mriedemefried: i cleaned those up so tests pass now ^16:38
openstackgerritDan Smith proposed openstack/nova master: Address feedback from instance_list smart-cell behavior  https://review.openstack.org/56764316:38
dansmithmriedem: ^16:38
efriedmriedem: ack16:39
*** mvk has quit IRC16:41
*** suresh12 has quit IRC16:43
efriedmriedem: It doesn't look like you actually fixed https://review.openstack.org/#/c/557835/8/nova/tests/unit/network/test_utils.py16:43
efriedmriedem: Unless I'm missing something obvious, you added the import but didn't change the offending references.16:43
efriedSo now you'll fail pep8 *and* py27/35 :)16:44
*** pcaruana has quit IRC16:44
mriedemyou're blind16:44
mriedemeverything passed locally16:44
efriedmriedem: sorry, I'm blind, ignore me.16:44
mriedemefried: no joke https://review.openstack.org/#/c/558487/16:46
mriedemsahid would be PISSED!16:46
mriedemapparently that doesn't have any tests?16:47
mriedemhttps://github.com/openstack/nova/commit/27614dc595d0fac2e57300c85bb34da266849a4616:47
efriedmriedem: I clearly looked into it https://review.openstack.org/#/c/558487/2/nova/network/linux_net.py@a181316:48
efriedmriedem: Why doesn't my comment show up with yours?  Seems like a gerrit ui bug.16:48
sean-k-mooneymriedem: we should proably port that to os-vif at some point rather then doing it in the libvirt vif.py16:48
mriedemsean-k-mooney: yes, both jaypipes and i asked for that in the original patch16:48
efriedanyway, IIRC what I discovered was that that method had been removed somewhere else.16:48
mriedemso in his first change, he means to move create_tap_dev, but also moved the trusted vf tests, and then in the 2nd patch deletes the trusted_vf code but not the tests....16:49
sean-k-mooneymriedem: adding a new pluging wont be two hard ill open a bug for it to track it. we also need to move a few others16:50
efriedand yeah, I see that method in master.16:50
mriedemwhich is also what was causing the pep8/unit test failures16:50
mriedemso i'll fix this up16:50
*** vladikr has quit IRC16:57
*** eharney_ has joined #openstack-nova16:57
*** vladikr has joined #openstack-nova16:57
*** dougsz has quit IRC16:59
openstackgerritDan Smith proposed openstack/nova master: Address feedback from instance_list smart-cell behavior  https://review.openstack.org/56764316:59
*** mdbooth has quit IRC17:00
*** derekh has quit IRC17:00
*** lucasagomes is now known as lucas-afk17:00
*** eharney has quit IRC17:01
*** edmondsw has quit IRC17:02
*** mrf has quit IRC17:02
*** andreas_s has joined #openstack-nova17:03
*** edmondsw has joined #openstack-nova17:03
*** moshele has quit IRC17:04
*** mgoddard has quit IRC17:07
*** andreas_s has quit IRC17:07
openstackgerritMatt Riedemann proposed openstack/nova master: Move create_tap_dev to the new utility module.  https://review.openstack.org/55783517:08
openstackgerritMatt Riedemann proposed openstack/nova master: Move set_vf_interface_vlan to the new utility module.  https://review.openstack.org/55848717:08
mriedemefried: ok those 2 should be golden now17:09
efriedmriedem: ack17:10
*** david-lyle has joined #openstack-nova17:11
*** udesale_ has quit IRC17:12
*** suresh12 has joined #openstack-nova17:13
*** suresh12 has quit IRC17:13
*** suresh12 has joined #openstack-nova17:13
*** dklyle has quit IRC17:14
*** david-lyle has quit IRC17:15
*** dklyle_ has joined #openstack-nova17:15
*** eharney_ is now known as eharney17:15
*** felipemonteiro has joined #openstack-nova17:17
*** suresh12 has quit IRC17:18
*** felipemonteiro_ has joined #openstack-nova17:20
efriedmriedem: +2 on the first one, but didn't +W it - question inline.  Can you confirm that that test case was added as part of this patch?17:21
efried(I don't see it in master or in the base)17:21
cfriesen_mriedem: regarding the DB thing.  Doesn't ring a bell, but I'm pretty sure we take down the DB, then switch the VIP, then bring up the DB again on the new side.17:22
*** felipemonteiro has quit IRC17:24
cfriesen_cfriesen: we use shared storage rather than a master/slave postgres setup17:24
cfriesen_mriedem: ^   (apparently I like talking to myself)17:25
*** cfriesen_ is now known as cfriesen17:25
*** jmccarthy has left #openstack-nova17:29
cfriesenis there a reason why we default to "novalocal" as the dhcp_domain even when using neutron?  It means the hostname retrieved via metadata has ".novalocal" appended to it by default.17:32
openstackgerritEric Fried proposed openstack/nova master: Add tests for alloc_cands with member_of  https://review.openstack.org/56139917:36
mriedemcfriesen: ack17:40
mriedemcfriesen: https://www.openstack.org/summit/vancouver-2018/summit-schedule/events/21754/novaneutron-ops-cross-project-session17:41
*** mgoddard has joined #openstack-nova17:42
*** suresh12 has joined #openstack-nova17:44
*** Tom-Tom has joined #openstack-nova17:45
*** Tom-Tom has quit IRC17:45
*** suresh12 has quit IRC17:45
*** suresh12 has joined #openstack-nova17:45
*** dklyle_ has quit IRC17:46
*** janki has quit IRC17:48
mriedemefried: yes it's new and it also looks wrong17:49
mriedembecause ex.assert_has_calls(calls) looks like the wrong assertion, since execute should have been called twice17:50
mriedemso that should have probably been ex.return_value.assert_has_calls17:50
mriedemoh nvm, that's on set_device_mtu which is unrelated17:52
*** rcernin has joined #openstack-nova17:52
efriedmriedem: ... yeah.17:52
efriedso like, where tf did this test case come from?17:52
efriedIt's not wrong, it's just... random.17:52
mriedemprobably rebase damage from I9872056c440a706b89dd51d3b9f2418951723efa17:53
mriedemyeah it was dropped here https://review.openstack.org/#/c/557543/1/nova/tests/unit/network/test_linux_net.py17:53
mriedemi'll update17:54
efriedmriedem: Yup, I see it.17:54
efriedmriedem: No need to update, what are you going to do, split it into a separate patch?17:54
mriedemyeah17:54
efriedmriedem: Okay.  FWIW I'd be fine just commenting in the review that it was accidentally dropped in a bad rebase, add that link ^, and be done.17:55
efriedbut if you prefer splitting, soit.17:55
*** zcorneli has joined #openstack-nova17:56
*** suresh12_ has joined #openstack-nova17:57
openstackgerritAlvaro Lopez Garcia proposed openstack/nova master: Ensure that periodic reclaim cleans DB deleted instances  https://review.openstack.org/32325017:57
openstackgerritMatt Riedemann proposed openstack/nova master: Move create_tap_dev to the new utility module.  https://review.openstack.org/55783517:57
openstackgerritMatt Riedemann proposed openstack/nova master: Move set_vf_interface_vlan to the new utility module.  https://review.openstack.org/55848717:57
openstackgerritMatt Riedemann proposed openstack/nova master: Add test_set_device_mtu_default back in  https://review.openstack.org/56765917:57
*** dklyle_ has joined #openstack-nova17:58
*** wolverineav has quit IRC17:58
efriedmriedem: +2 all the way up.  Don't know if you still feel good about approving the bottom one...17:58
mriedemi feel great17:58
*** wolverineav has joined #openstack-nova17:59
mriedemyou could also just fast approve https://review.openstack.org/#/c/567659/17:59
mriedemit's just adding a unit test back in17:59
efriedmriedem: done.18:00
*** mdnadeem_ has joined #openstack-nova18:00
*** suresh12 has quit IRC18:00
*** lpetrut has quit IRC18:02
*** wolverineav has quit IRC18:03
*** armaan has quit IRC18:04
*** armaan has joined #openstack-nova18:04
*** oomichi has joined #openstack-nova18:04
*** lpetrut has joined #openstack-nova18:05
*** tesseract-RH has joined #openstack-nova18:08
*** moshele has joined #openstack-nova18:08
*** tesseract has quit IRC18:09
*** tesseract-RH has quit IRC18:11
*** tesseract has joined #openstack-nova18:11
*** clutchbeyers has joined #openstack-nova18:11
*** moshele has quit IRC18:12
clutchbeyersThis is a post-newton question: Does anyone know if we set availability_zone in spec_obj on vm provision if the user does not select an availability_zone?18:13
clutchbeyersset in the db after launch*18:14
*** liuzz_ has joined #openstack-nova18:15
*** masuberu has joined #openstack-nova18:16
*** liuzz has quit IRC18:17
*** masber has quit IRC18:19
*** tbachman has quit IRC18:19
*** mingyu has quit IRC18:20
*** bandini has quit IRC18:20
*** mingyu has joined #openstack-nova18:21
*** bandini has joined #openstack-nova18:22
*** moshele has joined #openstack-nova18:22
*** jpena is now known as jpena|off18:25
*** mingyu has quit IRC18:25
*** amoralej is now known as amoralej|lunch18:26
*** amoralej|lunch is now known as amoralej|off18:26
mriedemclutchbeyers: i know that starting in pike we set the instance.availability_zone based on the compute host that was selected by the scheduler https://review.openstack.org/#/c/446053/ - not sure if that extends to the request spec18:28
mriedemthe request spec is really about what the user requested18:28
mriedemso i don't think setting reqspec.az if the user didn't request one would be correct there18:29
melwittbefore that change, instance.availability_zone used to get set to the "default availability zone" if one wasn't requested at boot time18:31
*** fragatin_ has quit IRC18:31
*** mgoddard has quit IRC18:33
mriedemmelwitt: i know, see https://bugs.launchpad.net/nova/+bug/176887618:36
openstackLaunchpad bug 1768876 in OpenStack Compute (nova) queens "metadata-api fails to get availability zone for instances created before pike" [High,Triaged]18:36
efriedmriedem, melwitt: Do y'all have a problem if I fast-approve takashin's mox removal patches?  They're test-only; if they pass zuul they clearly work; and I'd like to save other reviewers the pain of combing over these (they're pretty tedious).18:36
melwittefried: passing zuul is the easy part -- reviewing to ensure test coverage is not lost isn't. so I've not thought of them as easy, one person reviews18:37
melwittbut that's just MHO18:37
efriedmelwitt: roger that.  YHO is what I was asking for.  Will leave them for other cores to scrutinize.18:38
*** RaoulHC has quit IRC18:38
melwittmriedem: guh, another regression18:39
openstackgerritMerged openstack/nova master: Add CellMapping.get_by_project_id() query method  https://review.openstack.org/50900218:40
*** jmccarthy has joined #openstack-nova18:41
*** mdnadeem_ has quit IRC18:46
openstackgerritDan Smith proposed openstack/nova master: Change the field type of InstanceMapping.instance_uuid  https://review.openstack.org/56766918:47
*** tesseract has quit IRC18:49
*** rcernin has quit IRC18:50
*** felipemonteiro__ has joined #openstack-nova18:51
*** felipemonteiro_ has quit IRC18:51
arvindn05mriedem: good call on checking for scheduling volume backed instances18:51
clutchbeyersthanks for that explanation. we have a use-case where whatever az the scheduler chooses, we do not want a resize to migrate across az's. Sounds like the team has made the decision to keep that logic, and I support that. We can fork our own logic for that18:52
arvindn05for volume back instances the volume meta data is provided as image meta data. see https://github.com/openstack/nova/blob/master/nova/compute/api.py#L106018:52
mriedemclutchbeyers: if you look at my comments in https://bugs.launchpad.net/nova/+bug/1768876 - starting in pike you can't migrate across az's18:53
openstackLaunchpad bug 1768876 in OpenStack Compute (nova) queens "metadata-api fails to get availability zone for instances created before pike" [High,Triaged]18:53
mriedemwhich is actually a regression18:53
jmccarthymriedem: You about ? Trying to get 'test_cleanup_resize_not_same_host' to pass locally with tox, I don't really know this area - any hints how to resolve this conflict ? https://paste.fedoraproject.org/paste/ntZxhXGlWmzNiL--RZU~Ww18:53
mriedemjmccarthy: see my backports?18:53
mriedemhttps://review.openstack.org/#/q/Ib10081150e125961cba19cfa821bddfac461440818:53
*** fragatina has joined #openstack-nova18:54
*** fragatina has quit IRC18:54
jmccarthymriedem: Oh ! Ok cool lemme check that out18:54
mriedemarvindn05: i could be wrong but i don't think that actually gets stored in the RequestSpec.image field18:54
*** fragatina has joined #openstack-nova18:55
jmccarthymreidem: Perfect - Thanks again ! Quite what to do there was giving me a headache lol18:55
arvindn05from what i saw...the volume meta data is treated exactly the same  as image meta data,...the requestSpec.image has volume meta data in the case18:55
mriedemarvindn05: i'm not so sure https://github.com/openstack/nova/commit/0a7427dc58eeb271646a962604106e0e84b870b618:56
arvindn05the only difference is that for volume backed instance the "id" field in the RequestSpec.image is not present...18:56
mriedembut i don't know what you're seeing18:56
mriedemoh that might be true18:56
arvindn05yup...the code there looks at the id field as well to determine...so looks like its consistent18:57
mriedemoh i guess we use boot_meta here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L88218:57
mriedemhttps://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L13218:58
arvindn05now the only question is should we honor that metadata for volume boot?18:58
mriedemidk18:59
arvindn05https://blueprints.launchpad.net/python-cinderclient/+spec/support-modify-volume-image-metadata an old blueprint discussion19:00
mriedemi'm not sure how much precedent we have for honoring image meta during scheduling that comes from a volume19:00
arvindn0520:32:54 <DuncanT> fmaldonado_: volume glance meta is for all of the same things glance properties are for19:00
arvindn05it seems that within the code, the volume meta data is treated exactly the same as image meta data...so i am leaning towards leaving it this way and adding few more unit and functional test cases19:01
*** tssurya has quit IRC19:03
clutchbeyersmriedem: thats great to hear on the cross-az migration, we handle that in newton by use of the nova filters and extra specs that dont allow things to cross. But our specific use case is in the resize. If one spawns an instance without giving it an az, a resize will cold migrate (shutdown) and treat it like a new vm spin up and select another az with new flavors. Are you saying this behavior also does not allow for cross-19:04
*** felipemonteiro_ has joined #openstack-nova19:04
mriedemclutchbeyers: the change in pike would apply to any move operation through the scheduler,19:05
mriedemso resize, live migrate, unshelve and evacuate19:05
*** felipemonteiro__ has quit IRC19:07
clutchbeyersmriedem: thank you for the clarification!19:09
*** rmk has joined #openstack-nova19:09
*** rmk has quit IRC19:09
*** rmk has joined #openstack-nova19:09
*** rcernin has joined #openstack-nova19:09
mriedemclutchbeyers: note that we could consider this a regression in pike. it's in your favor i guess, but depending on how we handle this bug we might change it back.19:10
mriedemdansmith: maybe something we need to put in your forum session on cells...19:11
*** jmccarthy has left #openstack-nova19:12
dansmithmriedem: I'm not sure what you're saying is a regression19:13
dansmithor what it has to do with cells19:13
dansmiththat you can't migrate across az boundaries/19:13
*** mvk has joined #openstack-nova19:13
mriedemdansmith: https://bugs.launchpad.net/nova/+bug/176887619:13
openstackLaunchpad bug 1768876 in OpenStack Compute (nova) queens "metadata-api fails to get availability zone for instances created before pike" [High,Triaged]19:13
clutchbeyersmriedem: it my honest opinion, if a tenant does not specify an az on vm provision, then they arent too concnered about controlling their fault domain. So when they do decide to resize and it moves to another az, they theoretically shouldn't care19:14
clutchbeyersBut for those that specifically call out an az, they have a fault domain architecture in mind and wouldnt want to disrupt that19:14
*** felipemonteiro_ has quit IRC19:14
dansmithmriedem: okay,  I think we talked about that in dublin, about potentially just forcing instance.az to whatever we chose if you didn't ask for one, keeping you in whatever az you happened to land in19:14
*** felipemonteiro_ has joined #openstack-nova19:14
melwittI think that's what the original behavior was -- only allows migrating across AZ if none was selected deliberately19:15
dansmithmelwitt: you mean only keeps you in your az if you asked for one initially19:15
clutchbeyersthere is some assumptions being made there with how the tenant is designing their app/fault tolerance19:15
*** rcernin has quit IRC19:15
melwittdansmith: yeah19:16
dansmithclutchbeyers: I totally agree that if you asked for one, you shouldn't be migrated out of it19:16
dansmithI get that mriedem's metadata thing is a regression,19:17
dansmithI'm missing what, if any, scheduler behavior regressed19:17
mriedemdansmith: i don't remember talking about this specifically in dublin,19:17
mriedemthe only AZ thing I remember talking about wrt cells was the cross_az_attach volume upcall thing19:17
*** pchavva has quit IRC19:17
mriedemdansmith: what i'm pointing out in this comment https://bugs.launchpad.net/nova/+bug/1768876/comments/419:18
openstackLaunchpad bug 1768876 in OpenStack Compute (nova) queens "metadata-api fails to get availability zone for instances created before pike" [High,Triaged]19:18
dansmithI'm pretty sure it was dublin, with bauzas and I19:18
mriedemi need to test it still to confirm it is a regression19:18
*** zcorneli_ has joined #openstack-nova19:18
dansmithokay, I'm confused because I thought the second part of your comment (that an instance would be confined to whatever AZ it landed in) wasn't yet the case, but we considered doing that19:19
dansmithin the dublin discussion where we were talking about how to handle instance.az when az wasn't requested19:20
*** zcorneli has quit IRC19:20
mriedemmaybe we were talking about that in the context of volume cross_az_attach?19:21
dansmithI dunno, I thought not, but I don't see it on the etherpad19:21
dansmithI _know_ I've had a convo with bauzas about this in the not too distant past19:22
dansmithmaybe the az discussion there is merging together in my head19:22
mriedemmaybe related to the ops list thread on not allowing deleting/renaming an AZ that has instances in it?19:22
openstackgerritJay Pipes proposed openstack/nova master: placement: always create consumer records  https://review.openstack.org/56767819:23
dansmiththis was face-to-face or face-to-screen19:23
dansmithwith bazuas19:23
dansmithmriedem: what change in pike do you think is making us keep things in the same az?19:24
*** tbachman has joined #openstack-nova19:24
mriedemhttps://review.openstack.org/#/c/446053/19:24
dansmithah, yeah19:25
mriedemif the instance.availability_zone was set based on CONF.default_availability_zone when the user didn't request one specifically, before that change, and that defaults to None, i believe that means the instance could freely move between AZs19:25
mriedemanyway, i can write a simple functional test to try this once i get this 'remove fping' patch up19:25
dansmithyeah, so, this is the change I was talking about,19:25
dansmithwhich is probably when I was talking to bauzas about it (before writing this)19:25
dansmithI just forgot that we had made it19:26
mriedemheh, time flies :)19:26
dansmithapparently19:26
mriedemi don't think i was aware of this change either until yesterday19:26
openstackgerritMatt Riedemann proposed openstack/nova master: Remove support for /os-fping REST API  https://review.openstack.org/56768219:26
melwittI just checked and the default is 'nova', not None. not sure if that makes a difference19:26
mriedemmelwitt: not for CONF.default_availability_zone19:27
mriedemthere are 2 "default" AZ options19:27
dansmithso, going back to my "up for debate" comment above,19:27
mriedemone for the user's instance and one for the scheduler19:27
melwittthat's what I'm looking at?19:27
dansmithwhat's the actual problem with keeping it where it is?19:27
*** mingyu has joined #openstack-nova19:27
melwittdefault_schedule_zone is the None one19:27
melwitt(has no default)19:27
openstackgerritJay Pipes proposed openstack/nova master: placement: always create consumer records  https://review.openstack.org/56767819:28
mriedemi always have to read this again https://docs.openstack.org/nova/latest/user/aggregates.html#availability-zones-azs19:28
*** moshele has quit IRC19:28
*** eharney has quit IRC19:29
mriedemmelwitt: oh that must have changed,19:29
mriedemsee pike19:29
mriedemhttps://docs.openstack.org/nova/pike/configuration/config.html19:29
mriedemoh nvm it didn't change https://docs.openstack.org/nova/pike/configuration/config.html#DEFAULT.default_availability_zone19:29
mriedemwtf my eyes19:29
*** wolverineav has joined #openstack-nova19:29
melwitttbh the only reason I remember the 'nova' availability zone being default is from using devstack19:30
dansmith[12:27:34]  <dansmith>what's the actual problem with keeping it where it is?19:30
mriedemoh my comment in the bug is wrong19:30
mriedemdefault_schedule_zone is for instances19:30
mriedemdefault_availability_zone is for compute services19:30
mriedemdansmith: i don't know that there is,19:31
mriedemexcept it's a behavior change19:31
mriedembut,19:31
mriedem(2:11:06 PM) mriedem: dansmith: maybe something we need to put in your forum session on cells...19:31
melwittdansmith: the concern is if that broke the original behavior of letting an instance move across AZs if someone didn't specify an AZ to begin with, if they don't care about AZ19:31
mriedem:)19:31
melwittbut we're not 100% sure yet if that behavior changed, mriedem is gonna test it out in a func test19:31
mriedemmaybe it's just an FYI to operators at this point, idk19:31
*** suresh12_ has quit IRC19:31
dansmithno I think it did change19:31
dansmithbut Idon't think it's user-visible19:32
dansmithwhat I do think makes more sense about the new behavior,19:32
melwittit only would be if all the compute hosts in the same AZ are at capacity and there are free ones in another AZ, right?19:32
dansmithis that if I boot an instance, ssh in, check the AZ that it's in, and then boot an instance in another az to make sure I have separation,19:32
dansmiththen something moves my instance into the same az and I'm surprised19:32
melwittand they're stuck because it won't let the AZ be crossed19:32
dansmithwhich won't happen now19:32
dansmithmelwitt: yeah but they have no idea if there is space in the cloud, or in their az19:33
mriedemone fear i have is operators will rely on the force flag for live migrate or evacuate to bypass the scheduler now to move the instance into another compute just because that other compute is in another AZ,19:33
mriedembut idk19:34
melwittyeah, not until they contact support I guess, and admin can see the migration should be able to work and it doesn't19:34
mriedemif only we could force a cold migration to bypass the scheduler.... :)19:34
dansmithmriedem: fair point, but not super strong, IMHO19:34
mriedemdansmith: agree it's not strong19:34
mriedemif you have 10 computes in AZ1 and 10 in AZ2, then just pick one of the ones that's already in the same AZ19:35
mriedemalso, kablam https://review.openstack.org/56768219:35
*** tssurya has joined #openstack-nova19:37
*** mlavalle has quit IRC19:37
openstackgerritArvind Nadendla proposed openstack/nova master: update scheduler to use image-traits  https://review.openstack.org/56059619:38
*** mlavalle has joined #openstack-nova19:39
*** sv1_X has joined #openstack-nova19:40
clutchbeyersmriedem: cold migrations bypassing the scheduler was a joke right? :)19:40
*** tidwellr has joined #openstack-nova19:41
*** tssurya has quit IRC19:41
*** oomichi has quit IRC19:42
mriedemclutchbeyers: L645 https://etherpad.openstack.org/p/nova-ptg-rocky19:42
mriedemoh the -5 didn't make it into the notes19:43
*** lpetrut has quit IRC19:43
*** tssurya has joined #openstack-nova19:44
*** hoonetorg has quit IRC19:46
*** wolverineav has quit IRC19:48
*** wolverineav has joined #openstack-nova19:49
*** Ahud07 has joined #openstack-nova19:50
melwittdansmith: I was just reading the ML thread about the map_instances marker thing, and I think what takashin was suggesting is to print the next marker before returning 1, and then let that be passed as a starting point when the command is run again https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L119319:50
*** dklyle_ is now known as dklyle19:50
melwittwould that not work for some reason?19:51
*** wolverineav has quit IRC19:53
*** Ahud07 has left #openstack-nova19:55
*** wolverineav has joined #openstack-nova19:56
edleafemelwitt: if the batches were all done in a row, it might. But there could be long gaps of time between batches, so the marker needs to be stored19:57
*** tidwellr has quit IRC19:58
melwittI see19:58
*** felipemonteiro__ has joined #openstack-nova19:59
*** eharney has joined #openstack-nova20:00
*** hoonetorg has joined #openstack-nova20:00
*** wolverineav has quit IRC20:00
*** felipemonteiro_ has quit IRC20:02
*** sv1_X has quit IRC20:03
openstackgerritArvind Nadendla proposed openstack/nova master: update scheduler to use image-traits  https://review.openstack.org/56059620:07
*** burt has quit IRC20:07
dansmithmelwitt: yeah I know he was talking about that and I agree with edleafe that it's not a great solution20:07
dansmithmelwitt: the bit I'm not sure about was the "it could be exposed accidentally through the api" part20:07
*** burt has joined #openstack-nova20:08
melwittokay, I think I missed the "exposed accidentally through the api" part20:09
melwittI didn't see anyone mention something like that20:09
dansmithhe said "in some compute rest apis, it returns the marker"20:10
melwittI think he means like in instance list, it returns the marker if there's additional pages available20:10
*** liverpooler has quit IRC20:10
melwittlike if you have > 1000 (api max limit) instances in the list, it will give you a "next marker" so you can query again and pass the marker to get the next page20:11
dansmithyou mean you think he's offering the REST API's pagination as an example that could be used for the cli to be user-supplied-marker behavior?20:11
melwittthat's what I think he was saying, yeah. if doing it similar to that could avoid storing the marker20:12
dansmithI guess I can see it being read like that, but to me it sounded like he was saying it's bad to store it in-band because there's a way you can see it externally20:12
melwittif map_instances hands you back the next marker, says "I did a batch but there's more" and you can call again and give the marker and it does the next batch20:12
dansmithI understand how the user could supply a marker, yeah20:14
dansmithI just think that's fairly terrible UX for a CLI, especially a chatty one that has all kinds of other crap going to stdio like python warnings20:15
*** burt has quit IRC20:15
melwittoh, hm. yeah, I guess if I re-read it and connect the 3rd paragraph to the 2nd, it could sound that way. but I thought he was stating it's not ideal to store the marker and then next gave a suggestion on how we could avoid storing it20:15
dansmithI'll send another clarification mail20:16
arvindn05efried: gibi: mriedem: updated the code review for https://review.openstack.org/560596 - "update scheduler to use image-traits"20:16
melwittyeah, maybe it doesn't fit in so well for the CLI, but it's an interesting idea. probably the only way to avoid having to store a marker record20:16
efriedarvindn05: ack20:17
arvindn05efried: ty...hopefully the final PS for this change :)20:19
efriedarvindn05: Hah!20:19
efriedarvindn05: You've just karmically guaranteed that won't be the case!20:19
dansmithmelwitt: it's what we had before we replaced it with this, because it was annoying20:19
dansmithhttps://review.openstack.org/#/c/301916/20:20
melwittah, okay20:20
mriedemfwiw,20:20
arvindn05efried: lol...well to job security then...hehe20:20
efried:)20:20
mriedemthe new heal_allocations CLI i added has a note in there about taking a marker from the user, and dumping out the last instance processed so the next run can start from the marker rather than process a bunch of instances already healed20:20
*** armaan has quit IRC20:21
dansmithmriedem: we have all these other instances where we're able to keep track of things for the admin, it feels pretty sucky to go back to "you must have a mouse and a scratch pad to use this thing" experience20:22
dansmithdiscovery hosts, instance mapping, reqspec fixup20:22
*** armaan has joined #openstack-nova20:22
melwittthat's a really old change too, I somehow stayed blissfully unaware of how the map_instances CLI worked historically20:22
dansmithall keep track of it for you because we're talking about potentially an ass-ton of 50-item iterations20:22
mriedemi didn't realize we had a marker for the reqspec data migration20:23
dansmithyup20:23
dansmithit wasn't as controversial because it wasn't fighting a UC field20:23
dansmithbut it worked basically the same way20:23
mriedemi'm not even sure where i'd store the marker in my case20:24
mriedemi'm iterating the instances table per cell20:24
dansmithyeah, I understand yours is a little less obvious, but these all have reasonable places20:24
mriedemand we can't put a fake instance in the instaces db20:24
mriedem*table20:24
dansmithwe could have a scratch pad table we use for this kind of thing.. just "varchar(255) key, text value"20:25
dansmithno index, never expect to have much data in there,20:25
dansmithjust some context for things like this20:25
mriedemwell, i thought about system_metadata,20:25
mriedembecause i could query for a specific system_metadata with a marker key, get that instance, delete the marker entry and continue, but it's not great20:26
dansmithyou could yeah, but it could be a little racy with things potentially loading/saving that instance for other things maybe20:26
dansmithalthough you're just doing active things, so..20:26
*** armaan has quit IRC20:27
dansmithI would like to circle back,20:27
dansmithand point out that the only reason we're discussing this is because we emit a few warnings during unit tests :)20:27
mriedemthat's not why i'm talking about it,20:30
mriedemi don't care about the map_instances thing20:30
*** oomichi has joined #openstack-nova20:30
efriedarvindn05: I was totally going to let the typos slide, but that last docstring is wrong enough to warrant a respin.20:30
efriedarvindn05: karma ^^20:30
melwittit's true that the unit test warnings drew attention to the marker-record-storing pattern. but I think lots of people have been unaware of that pattern and it's pretty surprising, or at least it was to me the first time I learned about it20:31
arvindn05arvindn05: ...good catches...will fix ASAP20:31
dansmith...because it has just been working? :)20:31
openstackgerritMatt Riedemann proposed openstack/nova master: Add contributor docs on deprecating and removing compute REST APIs  https://review.openstack.org/56768720:32
melwittyep, I guess so. no problems, no eyeballs drawn to it20:32
*** moshele has joined #openstack-nova20:32
*** moshele has quit IRC20:34
mriedemdansmith: want to hit these backports https://review.openstack.org/#/q/Idea86d6bb648b1e6fef8813dbe569724ce81a750 - then we can safely remove the legacy live migration job from project-config and openstack-zuul-jobs20:35
mriedemdansmith: shouldn't require 2 +2s i don't think20:35
dansmithOMG YES20:35
dansmith<-- loves hitting backports20:35
mriedemotherwise right now we're getting hit on master b/c we're running 2 live migration jbos20:35
* melwitt picks up more baskets of backports to offer dansmith 20:35
mriedemit will take that as (1) serious and (2) literal20:35
dansmithmriedem: hah20:35
* dansmith scowls at melwitt 20:36
melwitt:D20:36
mriedemi've been holding https://review.openstack.org/#/q/Ib10081150e125961cba19cfa821bddfac461440820:36
mriedemthen we can do a (sweet) release20:36
mriedemthis is ready too https://review.openstack.org/#/c/567271/20:36
openstackgerritMerged openstack/nova master: Remove mox in test_compute_api.py (1)  https://review.openstack.org/56441520:39
*** takashin has joined #openstack-nova20:40
mriedemoomichi: ha https://review.openstack.org/#/c/564415/3/nova/tests/unit/compute/test_compute_api.py@101320:40
mriedemoomichi: check out the vmware virt driver unit tests at some point20:40
oomichimriedem: hehe, more longer ? :)20:41
openstackgerritMerged openstack/nova master: libvirt: check image type before removing snapshots in _cleanup_resize  https://review.openstack.org/56636720:43
mriedemok now i can bug dan about those backports20:44
*** trozet has joined #openstack-nova20:44
melwittnova meeting in 15 minutes20:45
openstackgerritJay Pipes proposed openstack/nova master: placement: always create consumer records  https://review.openstack.org/56767820:48
*** clutchbeyers has quit IRC20:50
oomichimriedem: btw where does 410 come from ?   related to https://review.openstack.org/#/c/56768720:52
oomichi410 means http410 status code20:52
*** mvenesio has quit IRC20:53
openstackgerritArvind Nadendla proposed openstack/nova master: update scheduler to use image-traits  https://review.openstack.org/56059620:53
mriedemhttps://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html20:54
arvindn05efried: not going to say anything...but new PS uploaded :)20:54
efriedlooking now20:54
mriedemoomichi: "The requested resource is no longer available at the server and no    forwarding address is known. This condition is expected to be    considered permanent."20:54
efriedarvindn05: +2 from me.  Now you have to get by mriedem...20:55
arvindn05nice...thanks for the quick turnaround efried20:55
oomichimriedem: I didn't see http410 case and api-wg guideline doesn't mention about http410 case, so I was curious about that20:57
mriedemoomichi: it's what we used when we removed os-cloudpipe and os-certificates, and it makes more sense then 40420:58
mriedem*than20:58
mriedem404 is what we used for capping / deprecating with microversions20:58
mriedemtechnically we also use 404 when a route is not found20:58
oomichimriedem: yeah, 404 is my base thinking. Nice to have conversation widely20:59
mriedemoomichi: feel free to bring it up in the ML thread21:00
mriedembut at this point it would be weird to use 410 for those other removed apis but 404 for fping21:00
mriedemIMO21:00
*** felipemonteiro__ has quit IRC21:00
oomichiOK, let me do that21:01
*** felipemonteiro has joined #openstack-nova21:02
mriedemsean-k-mooney: this is for you https://bugs.launchpad.net/nova/+bug/177037821:07
openstackLaunchpad bug 1770378 in OpenStack Compute (nova) "windows can‘t start when use vhostuser interface" [Undecided,New]21:07
mriedemsean-k-mooney: i noticed that we have 0 docs in nova or neutron on using vhostuser for networking21:08
mriedemis that somewhere else?21:08
*** slaweq has quit IRC21:09
mriedemoh hmm here it is https://docs.openstack.org/neutron/latest/contributor/internals/ovs_vhostuser.html21:09
sean-k-mooneymriedem:  stephen added docs to the networking guide21:09
mriedemright but https://docs.openstack.org/neutron/latest/search.html?q=vhostuser21:10
*** slaweq has joined #openstack-nova21:10
mriedemoh b/c it's vhost-user21:10
sean-k-mooneymriedem:  this is where the docs used to be https://docs.openstack.org/neutron/pike/admin/config-ovs-dpdk.html21:12
sean-k-mooneyanyway regarding the bug you should be able to run windows guest on vhost-user ports however i do remember issues in the past due to virtio diriver versions21:13
*** awaugama has quit IRC21:13
sean-k-mooneymriedem: this might be the fix for the issue http://dpdk.org/dev/patchwork/patch/15541/21:14
*** edmondsw has quit IRC21:14
*** edmondsw has joined #openstack-nova21:15
*** wolverineav has joined #openstack-nova21:16
*** felipemonteiro has quit IRC21:17
*** hemna_ has quit IRC21:18
*** vladikr has quit IRC21:18
*** edmondsw has quit IRC21:19
*** avolkov has quit IRC21:21
*** moshele has joined #openstack-nova21:22
*** felipemonteiro has joined #openstack-nova21:23
*** slaweq has quit IRC21:24
*** slaweq has joined #openstack-nova21:25
*** slaweq has quit IRC21:30
*** vladikr has joined #openstack-nova21:31
*** liverpooler has joined #openstack-nova21:37
*** eharney has quit IRC21:39
*** dave-mccowan has joined #openstack-nova21:39
mnasermriedem: https://review.openstack.org/#/c/565611/ ok for me to merge this or wait till https://review.openstack.org/#/q/Idea86d6bb648b1e6fef8813dbe569724ce81a750 is in?21:41
sean-k-mooneymriedem: i have responded to https://bugs.launchpad.net/nova/+bug/1770378 and set it to incomplete until they respond with the version of ovs and dpdk they are using21:41
openstackLaunchpad bug 1770378 in OpenStack Compute (nova) "windows can‘t start when use vhostuser interface" [Undecided,Incomplete]21:41
*** felipemonteiro has quit IRC21:44
*** felipemonteiro has joined #openstack-nova21:46
openstackgerritMerged openstack/nova master: Move create_tap_dev to the new utility module.  https://review.openstack.org/55783521:48
*** cfriesen has quit IRC21:49
mriedemtakashin: this is the event https://www.openstack.org/summit/vancouver-2018/summit-schedule/events/21749/missing-features-in-openstack-for-public-clouds21:50
takashinmriedem: Thanks. I will attend it.21:50
mriedemhttps://etherpad.openstack.org/p/YVR-publiccloud-wg-brainstorming21:51
mriedemthat's the only etherpad i'm aware of right now21:51
mriedemsean-k-mooney: thanks for commenting on that vhostuser bug21:53
mriedemmnaser: that's good to go now21:53
mnasermriedem: +w :)21:53
*** cfriesen has joined #openstack-nova21:58
mriedemmelwitt: i saw this in triage today https://bugs.launchpad.net/nova/+bug/177034822:03
openstackLaunchpad bug 1770348 in OpenStack Compute (nova) "Unable to access console via dashboard" [Undecided,Incomplete]22:03
mriedemmnaser: thanks22:03
openstackgerritHongbin Lu proposed openstack/nova-specs master: Choose default network on ambiguity  https://review.openstack.org/52024722:06
*** ivve has quit IRC22:09
*** hemna_ has joined #openstack-nova22:10
*** slaweq has joined #openstack-nova22:11
*** felipemonteiro has quit IRC22:14
*** slaweq has quit IRC22:16
melwittmriedem: looking22:16
openstackgerritMerged openstack/nova stable/queens: Migrate tempest-dsvm-multinode-live-migration job in-tree  https://review.openstack.org/56761222:16
openstackgerritMerged openstack/nova stable/ocata: Migrate tempest-dsvm-multinode-live-migration job in-tree  https://review.openstack.org/56761922:16
*** esberglu has quit IRC22:19
openstackgerritMerged openstack/nova stable/pike: log stale allocations as WARNING instead of DEBUG  https://review.openstack.org/56727122:21
openstackgerritHongbin Lu proposed openstack/nova-specs master: Choose default network on ambiguity  https://review.openstack.org/52024722:25
melwittmriedem: that would have been my first question too, whether they're using devstack or a real deployment. what's probably wrong is they need to pass the cell nova.conf to the console proxy service instead of the old global nova.conf22:28
*** wolverineav has quit IRC22:29
melwittI'm thinking maybe I need to make the release note better to call that out22:29
*** mrf has joined #openstack-nova22:31
mrfHi22:31
mrfdoes images_rbd_pool at nova.conf support multiple pools?22:31
openstackgerritMerged openstack/nova master: Make get_instance_objects_sorted() be smart about cells  https://review.openstack.org/50900322:31
melwittmrf: I don't believe so. mnaser could you confirm? ^22:33
openstackgerritMatt Riedemann proposed openstack/nova master: Add nova-slow job  https://review.openstack.org/56769722:33
mriedemthere's your slow job22:33
mnasermriedem: it does not unfortunately, it can only use a single rbd image backend22:33
mnasererr22:33
mnasermrf: ** ^22:33
*** esberglu has joined #openstack-nova22:33
melwittmriedem: awesome thanks22:33
*** esberglu has quit IRC22:33
melwittwznoinsk: ^22:33
mriedemok stable backports for this https://review.openstack.org/#/q/Ib10081150e125961cba19cfa821bddfac4614408 are ready22:36
mriedembut probably no one around22:36
mriedemoh tonyb mtreinish ^ :)22:39
*** cfriesen has quit IRC22:41
*** tbachman has quit IRC22:41
*** tbachman has joined #openstack-nova22:41
*** tssurya_ has joined #openstack-nova22:42
*** jaypipes_ has joined #openstack-nova22:42
*** wwriverrat_ has joined #openstack-nova22:42
*** tssurya has quit IRC22:42
*** wwriverrat has quit IRC22:42
*** jaypipes has quit IRC22:42
*** wwriverrat_ is now known as wwriverrat22:42
mrfmmm i got a trouble with 2 computes nodes , maybe some could help each one got diferent images_rbd_pool22:42
*** vdrok has quit IRC22:42
*** dulek has quit IRC22:42
mrfand now i cant migrate instances beetween them22:43
*** vdrok has joined #openstack-nova22:43
tonybmriedem: Thanks, I'll review them after this meeting22:45
*** Guest81722 has quit IRC22:46
*** dulek has joined #openstack-nova22:46
*** jaypipes__ has joined #openstack-nova22:48
*** jaypipes_ has quit IRC22:49
*** nicolasbock has quit IRC22:50
*** nicolasbock has joined #openstack-nova22:50
*** vladikr has quit IRC22:50
*** cfriesen has joined #openstack-nova22:51
*** cdent has quit IRC22:51
*** bandini has quit IRC22:54
*** hongbin has quit IRC22:55
*** cfriesen has quit IRC22:55
*** cfriesen_ has joined #openstack-nova22:55
*** bandini has joined #openstack-nova22:57
openstackgerritTakashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data  https://review.openstack.org/40751423:02
openstackgerritTakashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller  https://review.openstack.org/34728923:03
*** vladikr has joined #openstack-nova23:04
openstackgerritmelanie witt proposed openstack/nova master: Avoid warning log when image not exist  https://review.openstack.org/56752223:06
mriedemAHA!23:17
melwittwhat23:17
mriedemhttps://github.com/openstack/nova/blob/master/nova/scheduler/filters/availability_zone_filter.py#L4323:18
mrfO_O23:18
mriedemwe don't have a regression23:18
*** moshele has quit IRC23:18
mriedemif you didn't request an az on server create, the az filter doesn't take the current instance az into account23:18
melwittwell I'll be23:18
*** liverpooler has quit IRC23:18
mriedemand clutchbeyers already left23:19
melwittdisaster averted23:19
*** tssurya_ has quit IRC23:20
mriedemwe still have the up-call and data migration to deal with :)23:25
mriedemwe still have a regression since pike, just an easier one to deal with23:26
*** germs has quit IRC23:26
mriedemwill push up this functional test since i bothered writing it, and then i'm off23:26
*** germs has joined #openstack-nova23:27
*** germs has quit IRC23:27
*** germs has joined #openstack-nova23:27
melwitt:( wah wah23:29
melwittthanks mriedem23:29
openstackgerritMatt Riedemann proposed openstack/nova master: Add implicit instance AZ + live migration test  https://review.openstack.org/56770123:30
mrf mmm i got a trouble with 2 computes nodes , maybe some could help each one got diferent images_rbd_pool, looking virshdump it point to rbd pool, can it be manually change the xmlfile to the new pool and them move the object at ceph level?23:30
melwittmrf: maybe. you could try asking an advance ceph operator like mnaser or ask on the openstack-operators mailing list where people can respond23:32
*** mriedem has quit IRC23:32
mrfthank so much23:33
melwittgood luck23:34
*** mlavalle has quit IRC23:34
openstackgerritTsuyoshi Nagata proposed openstack/nova master: nova improvement of maximum attach volumes more than 26 vols  https://review.openstack.org/56747223:37
*** yamamoto has joined #openstack-nova23:37
*** liuzz has joined #openstack-nova23:40
*** liuzz_ has quit IRC23:40
*** liverpooler has joined #openstack-nova23:42
*** yamamoto has quit IRC23:42
*** rajinir has quit IRC23:43
mrfWhy instance migration with blockmigration is not supported in a stopped vm? Cannot 'os-migrateLive' instance af02564c-8579-4226-96b7-99e3b650c06b while it is in vm_state stopped (HTTP 409) (Request-ID: req-aee842d9-593b-43fc-9487-e5eb191bc732)23:43
melwittmrf: just a guess, but I think the instance has to be running in order to do a live migration. that is, libvirt must need the instance running in order to do it23:48
mrfyes but if i want only migrate storage of instance23:49
mrfstate can me started or stopped23:49
mrfsimilar to other hypervisors like xenserver, hyperv, vmware23:49
mrfyou can do a storage migration without know if machine is live or stopped23:49
mrfblock-migration must not depend of machine state23:50
melwittmaybe you want regular cold migration then? https://developer.openstack.org/api-ref/compute/#migrate-server-migrate-action23:51
mrfit drops : [root@controller ~(keystone_admin)]# openstack server migrate --block-migration  af02564c-8579-4226-96b7-99e3b650c06b23:54
mrf--live must be specified if --block-migration or --disk-overcommit is specified23:54
melwittI think you don't need to pass --block-migration for a cold migrate23:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!