Tuesday, 2018-05-08

*** hemna_ has quit IRC00:08
*** takashin has joined #openstack-nova00:09
*** fragatina has quit IRC00:12
*** fragatina has joined #openstack-nova00:15
*** fragatina has quit IRC00:19
*** Dinesh_Bhor has joined #openstack-nova00:19
*** Bonjourm8 has quit IRC00:23
*** mingyu_ has joined #openstack-nova00:24
*** mingyu has quit IRC00:26
*** suresh12 has quit IRC00:37
*** suresh12 has joined #openstack-nova00:38
*** felipemonteiro__ has joined #openstack-nova00:39
*** hoangcx has joined #openstack-nova00:41
*** hiro-kobayashi has joined #openstack-nova00:47
*** Nel1x has quit IRC00:48
*** tuanla____ has joined #openstack-nova00:57
*** phuongnh has joined #openstack-nova01:00
*** gjayavelu has quit IRC01:02
*** Nel1x has joined #openstack-nova01:03
*** dpawlik has joined #openstack-nova01:06
*** zhaochao has joined #openstack-nova01:07
*** mlavalle has quit IRC01:08
*** vish_18 has quit IRC01:08
*** dpawlik has quit IRC01:11
*** hoangcx has quit IRC01:13
*** hoangcx has joined #openstack-nova01:13
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in test_xenapi.py (1)  https://review.openstack.org/56463901:13
*** trungnv has quit IRC01:14
*** trungnv has joined #openstack-nova01:14
*** Nel1x has quit IRC01:20
*** tiendc has joined #openstack-nova01:21
openstackgerritMerged openstack/nova master: Proxy is_volume through DriverBlockDevice  https://review.openstack.org/56401701:27
*** suresh12 has quit IRC01:31
*** Bonjourm8 has joined #openstack-nova01:31
*** Nel1x has joined #openstack-nova01:34
*** arvindn05 has quit IRC01:35
*** felipemonteiro__ has quit IRC01:35
*** bkopilov_ has quit IRC01:35
*** bkopilov__ has quit IRC01:35
*** arvindn05 has joined #openstack-nova01:40
*** sapd has joined #openstack-nova01:40
*** carl_baldwin_ has quit IRC01:55
*** lei-zh has joined #openstack-nova01:56
*** hongbin has joined #openstack-nova02:02
*** namnh has joined #openstack-nova02:05
*** Bonjourm8 has quit IRC02:11
*** psachin` has joined #openstack-nova02:13
*** yamamoto has joined #openstack-nova02:17
*** dave-mccowan has quit IRC02:20
*** yamamoto has quit IRC02:22
*** brault has joined #openstack-nova02:31
*** lei-zh has quit IRC02:33
*** lei-zh has joined #openstack-nova02:34
*** brault has quit IRC02:36
*** suresh12 has joined #openstack-nova02:36
*** gjayavelu has joined #openstack-nova02:36
*** hongbin_ has joined #openstack-nova02:37
*** felipemonteiro__ has joined #openstack-nova02:39
*** hongbin has quit IRC02:40
*** suresh12 has quit IRC02:40
*** esberglu has joined #openstack-nova02:48
*** esberglu has quit IRC02:48
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in test_xenapi.py (2)  https://review.openstack.org/56464302:52
openstackgerritkarim proposed openstack/nova master: Pushing image traits to ironic node  https://review.openstack.org/56562002:53
*** bkopilov_ has joined #openstack-nova02:55
*** bkopilov__ has joined #openstack-nova02:56
*** felipemonteiro__ has quit IRC02:58
*** fragatina has joined #openstack-nova02:58
*** hoangcx has quit IRC03:03
*** yamamoto has joined #openstack-nova03:04
*** hoangcx has joined #openstack-nova03:05
*** hoangcx has quit IRC03:05
*** dpawlik has joined #openstack-nova03:07
*** gcb has joined #openstack-nova03:08
*** hoangcx_ has joined #openstack-nova03:08
*** hoangcx_ has quit IRC03:09
*** dpawlik has quit IRC03:12
*** hemna_ has joined #openstack-nova03:14
*** fragatina has quit IRC03:20
*** takashin has quit IRC03:25
*** dpawlik has joined #openstack-nova03:26
*** dpawlik has quit IRC03:31
*** yamamoto has quit IRC03:31
*** nicolasbock has quit IRC03:40
*** gyankum has joined #openstack-nova03:41
*** lpetrut has joined #openstack-nova03:43
*** takashin has joined #openstack-nova03:46
*** sridharg has joined #openstack-nova03:48
*** sapd has quit IRC03:48
*** gyee has quit IRC03:48
*** janki has joined #openstack-nova03:50
*** tuanla____ has quit IRC03:50
*** tuanla____ has joined #openstack-nova03:51
*** udesale has joined #openstack-nova03:54
*** hongbin_ has quit IRC03:55
*** suresh12 has joined #openstack-nova04:01
*** namnh has quit IRC04:01
*** tiendc has quit IRC04:01
*** tiendc has joined #openstack-nova04:01
*** namnh has joined #openstack-nova04:01
*** fragatina has joined #openstack-nova04:03
*** fragatina has quit IRC04:04
*** fragatina has joined #openstack-nova04:04
*** mingyu_ has quit IRC04:06
*** gbarros has joined #openstack-nova04:14
*** lpetrut has quit IRC04:15
*** gyee has joined #openstack-nova04:17
*** lei-zh has quit IRC04:17
*** moshele has joined #openstack-nova04:18
openstackgerritMerged openstack/nova master: Deprecate the nova-consoleauth service  https://review.openstack.org/56536704:21
*** moshele has quit IRC04:22
*** gyee has quit IRC04:24
*** gjayavelu has quit IRC04:31
*** links has joined #openstack-nova04:38
*** vivsoni__ has quit IRC04:41
*** vivsoni has joined #openstack-nova04:42
*** abhishekk has joined #openstack-nova04:43
*** ratailor has joined #openstack-nova04:49
*** claudiub has joined #openstack-nova04:53
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in test_xenapi.py (3)  https://review.openstack.org/56464504:53
*** suresh12 has quit IRC04:58
*** Zames_ has joined #openstack-nova04:59
*** Dinesh__Bhor has joined #openstack-nova05:01
*** Dinesh_Bhor has quit IRC05:02
*** Zames_ has quit IRC05:02
*** yamamoto has joined #openstack-nova05:06
*** lei-zh has joined #openstack-nova05:07
*** mingyu has joined #openstack-nova05:11
*** lpetrut has joined #openstack-nova05:13
*** hemna_ has quit IRC05:15
*** ratailor has quit IRC05:17
openstackgerritMerged openstack/nova master: Give volume DriverBlockDevice classes a common prefix  https://review.openstack.org/52634605:17
*** ratailor has joined #openstack-nova05:21
*** lpetrut has quit IRC05:24
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in test_conductor.py (1)  https://review.openstack.org/56465805:24
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in test_conductor.py (2)  https://review.openstack.org/56465905:25
*** Eran_Kuris has joined #openstack-nova05:27
*** dpawlik has joined #openstack-nova05:27
*** Nel1x has quit IRC05:27
*** dpawlik has quit IRC05:32
*** trinaths has joined #openstack-nova05:40
*** ccamacho has joined #openstack-nova05:41
openstackgerritjichenjc proposed openstack/nova master: [doc] merge quota document  https://review.openstack.org/56678305:46
*** ratailor_ has joined #openstack-nova05:50
*** ratailor has quit IRC05:52
*** kaisers1 has quit IRC05:54
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in tests/unit/api/openstack/compute  https://review.openstack.org/56652805:54
*** gbarros has quit IRC05:57
*** markvoelker has quit IRC06:01
*** pcaruana has joined #openstack-nova06:01
*** tssurya has joined #openstack-nova06:03
*** armaan has joined #openstack-nova06:07
*** moshele has joined #openstack-nova06:09
*** lpetrut has joined #openstack-nova06:10
*** kaisers1 has joined #openstack-nova06:11
*** armaan has quit IRC06:11
*** armaan has joined #openstack-nova06:12
*** wolverineav has joined #openstack-nova06:13
openstackgerritSurya Seetharaman proposed openstack/nova master: [WIP] Add queued for delete to instance_mappings table.  https://review.openstack.org/56678806:13
*** Dinesh__Bhor has quit IRC06:14
*** dineshbhor__ has joined #openstack-nova06:14
*** dineshbhor__ has quit IRC06:15
*** Dinesh_Bhor has joined #openstack-nova06:16
*** penick has quit IRC06:17
*** evin has joined #openstack-nova06:17
*** ratailor_ has quit IRC06:19
*** udesale has quit IRC06:23
*** annp has joined #openstack-nova06:23
*** udesale has joined #openstack-nova06:23
*** armaan has quit IRC06:24
*** armaan has joined #openstack-nova06:25
*** liuzz_ has joined #openstack-nova06:29
*** liuzz has quit IRC06:29
*** brault has joined #openstack-nova06:32
*** rajinir has quit IRC06:35
*** penick has joined #openstack-nova06:36
*** brault has quit IRC06:36
*** andreas_s has joined #openstack-nova06:37
*** mingyu_ has joined #openstack-nova06:37
*** mingyu has quit IRC06:37
*** alexchadin has joined #openstack-nova06:39
*** bhujay has joined #openstack-nova06:42
*** mingyu_ has quit IRC06:42
*** gjayavelu has joined #openstack-nova06:43
*** moshele has quit IRC06:44
*** kaisers1 has quit IRC06:45
*** markvoelker has joined #openstack-nova07:01
*** dpawlik has joined #openstack-nova07:02
*** brault has joined #openstack-nova07:02
*** brault has quit IRC07:04
*** brault has joined #openstack-nova07:04
openstackgerritSurya Seetharaman proposed openstack/nova master: [WIP/POC] Add queued_for_delete field to InstanceMapping object  https://review.openstack.org/56679507:06
*** alexchad_ has joined #openstack-nova07:08
*** rcernin has quit IRC07:08
*** alexchadin has quit IRC07:10
*** sapd has joined #openstack-nova07:11
*** zhuli has quit IRC07:12
*** zhuli_ has joined #openstack-nova07:13
*** gjayavelu has quit IRC07:13
openstackgerritSurya Seetharaman proposed openstack/nova master: [WIP/POC] Add queued_for_delete field to InstanceMapping object  https://review.openstack.org/56679507:14
*** armaan has quit IRC07:14
*** udesale has quit IRC07:15
*** udesale has joined #openstack-nova07:15
*** trinaths has quit IRC07:15
*** claudiub|2 has joined #openstack-nova07:19
*** avolkov has joined #openstack-nova07:21
*** kaisers1 has joined #openstack-nova07:22
*** claudiub has quit IRC07:22
*** udesale_ has joined #openstack-nova07:34
openstackgerritTetsuro Nakamura proposed openstack/nova master: Consider nested RPs in get_all_with_shared  https://review.openstack.org/55645007:35
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support shared and nested allocation candidates  https://review.openstack.org/55651407:35
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support nested alloc cands without shared RPs  https://review.openstack.org/56184207:35
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return all resources in provider_summaries  https://review.openstack.org/55804507:35
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return all nested providers in tree  https://review.openstack.org/55948007:35
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return resource providers without inventories  https://review.openstack.org/55955407:35
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support nested allocation candidates in placement  https://review.openstack.org/56548707:35
*** amoralej|off is now known as amoralej07:35
*** markvoelker has quit IRC07:36
*** suresh12 has joined #openstack-nova07:37
*** udesale has quit IRC07:37
*** suresh12 has quit IRC07:41
*** gcb has quit IRC07:41
*** alexchad_ has quit IRC07:48
*** jpena|off is now known as jpena07:52
*** yamamoto has quit IRC07:56
*** kashyap` is now known as kashyap07:57
kashyapdansmith: Sorry, had to be AFK a bit early last evening.  Just catching up with the scroll07:58
*** gongysh has joined #openstack-nova08:02
kashyapdansmith: melwitt: Okido, let's go with the exhibit (a) which is: "deprecate in Rocky and hard-fail in Stein"08:02
*** yamamoto has joined #openstack-nova08:03
*** lpetrut has quit IRC08:05
*** jmccarthy has joined #openstack-nova08:07
*** mdnadeem has joined #openstack-nova08:13
*** lucas-pto is now known as lucasagomes08:16
*** hiro-kobayashi has quit IRC08:22
*** dtantsur|afk is now known as dtantsur08:27
*** ralonsoh has joined #openstack-nova08:29
openstackgerritSurya Seetharaman proposed openstack/nova master: [WIP/POC] Updating queued_for_delete from instance_destroy()  https://review.openstack.org/56681308:29
*** markvoelker has joined #openstack-nova08:33
*** ratailor has joined #openstack-nova08:34
*** nsingh has joined #openstack-nova08:38
*** ShilpaSD has joined #openstack-nova08:38
*** claudiub has joined #openstack-nova08:39
*** stakeda_ has joined #openstack-nova08:39
*** ratailor_ has joined #openstack-nova08:39
*** vivsoni_ has joined #openstack-nova08:39
*** ratailor has quit IRC08:40
*** yamamoto_ has joined #openstack-nova08:40
*** jmccarthy has quit IRC08:40
*** bandini has quit IRC08:40
*** zigo_ has quit IRC08:40
*** stakeda has quit IRC08:41
*** gryf has quit IRC08:41
*** lyarwood has quit IRC08:41
*** jmccarthy has joined #openstack-nova08:41
*** lyarwood has joined #openstack-nova08:41
*** gryf has joined #openstack-nova08:41
*** yamamoto has quit IRC08:41
*** niraj_singh has quit IRC08:41
*** linkmark has quit IRC08:41
*** bandini has joined #openstack-nova08:41
*** claudiub|2 has quit IRC08:41
*** vivsoni has quit IRC08:41
*** linkmark has joined #openstack-nova08:42
*** Shilpa has quit IRC08:42
*** alexchadin has joined #openstack-nova08:44
*** derekh has joined #openstack-nova08:44
*** zigo has joined #openstack-nova08:45
kashyapbauzas: When you are about, can you merge this simple Ocata backport?  Already has a +2 from Sean McGinnis: https://review.openstack.org/#/c/565672/08:45
kashyapbauzas: (Pinging you, as you ACKed the other branch backports)08:46
kashyapOr even lyarwood ^08:46
kashyapThat's the outstanding backport for that bug.08:46
*** yamamoto_ has quit IRC08:56
lyarwoodkashyap: looking08:56
lyarwoodkashyap: done08:57
kashyaplyarwood: Splendid!08:57
kashyapThank you08:58
*** Zames_ has joined #openstack-nova08:58
*** jmccarthy has quit IRC09:01
*** armaan has joined #openstack-nova09:01
*** hiro-kobayashi has joined #openstack-nova09:01
*** Zames_ has quit IRC09:02
*** lpetrut has joined #openstack-nova09:03
*** mdbooth has joined #openstack-nova09:05
*** jmccarthy has joined #openstack-nova09:05
*** markvoelker has quit IRC09:07
*** armaan has quit IRC09:08
*** yamamoto has joined #openstack-nova09:08
*** gaoyan has joined #openstack-nova09:11
*** goutham has joined #openstack-nova09:13
*** goutham has left #openstack-nova09:13
openstackgerritTheodoros Tsioutsias proposed openstack/nova-specs master: Add PENDING vm state  https://review.openstack.org/55421209:13
*** lpetrut has quit IRC09:14
openstackgerritTetsuro Nakamura proposed openstack/nova master: Consider nested RPs in get_all_with_shared  https://review.openstack.org/55645009:16
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support shared and nested allocation candidates  https://review.openstack.org/55651409:16
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support nested alloc cands without shared RPs  https://review.openstack.org/56184209:16
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return all resources in provider_summaries  https://review.openstack.org/55804509:16
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return all nested providers in tree  https://review.openstack.org/55948009:16
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return resource providers without inventories  https://review.openstack.org/55955409:16
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support nested allocation candidates in placement  https://review.openstack.org/56548709:16
*** moshele has joined #openstack-nova09:16
*** claudiub|2 has joined #openstack-nova09:19
*** moshele has quit IRC09:20
*** abhishekk has quit IRC09:20
*** gongysh has quit IRC09:21
*** moshele has joined #openstack-nova09:21
*** abhishekk has joined #openstack-nova09:21
*** sambetts|afk is now known as sambetts09:22
*** claudiub has quit IRC09:22
openstackgerritVishakha Agarwal proposed openstack/nova master: Re-using the code of os brick cinder  https://review.openstack.org/56570309:23
*** wolverineav has quit IRC09:30
*** wolverineav has joined #openstack-nova09:30
*** lei-zh has quit IRC09:32
*** Zames_ has joined #openstack-nova09:33
*** Dinesh_Bhor has quit IRC09:33
*** mingyu has joined #openstack-nova09:33
*** wolverineav has quit IRC09:35
*** mingyu has quit IRC09:35
*** mingyu_ has joined #openstack-nova09:35
*** Zames_ has quit IRC09:35
*** bkopilov__ has quit IRC09:39
*** bkopilov_ has quit IRC09:39
*** ragiman has joined #openstack-nova09:42
jmccarthymriedem: jgwentworth: Thanks for your help :) I tested the review, and in my setup it fixed the issue - https://review.openstack.org/#/c/56636709:44
*** gongysh has joined #openstack-nova09:44
*** Zames_ has joined #openstack-nova09:56
*** hiro-kobayashi has quit IRC09:57
*** Zames_ has quit IRC09:57
*** udesale_ has quit IRC09:59
*** mgoddard has joined #openstack-nova09:59
*** Zames_ has joined #openstack-nova10:02
*** armaan has joined #openstack-nova10:04
*** markvoelker has joined #openstack-nova10:04
*** Zames_ has quit IRC10:04
*** alexchadin has quit IRC10:09
*** abhishekk has quit IRC10:10
*** tetsuro has joined #openstack-nova10:13
*** yamamoto has quit IRC10:15
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add tests for sharing rps in test_common_rc()  https://review.openstack.org/56684210:17
tetsuroefried, jaypipes, bauzas: ^ found a new bug in sharing case. might be related to https://review.openstack.org/#/c/560459/3?10:19
*** mingyu_ has quit IRC10:19
*** ratailor__ has joined #openstack-nova10:19
*** yamamoto has joined #openstack-nova10:20
*** ratailor_ has quit IRC10:22
*** udesale has joined #openstack-nova10:27
*** udesale has quit IRC10:27
*** udesale has joined #openstack-nova10:28
*** gaoyan has quit IRC10:29
*** rcernin has joined #openstack-nova10:35
*** nicolasbock has joined #openstack-nova10:36
*** namnh has quit IRC10:36
*** markvoelker has quit IRC10:38
*** tuanla_____ has joined #openstack-nova10:40
openstackgerritMerged openstack/nova stable/ocata: libvirt: Make `cpu_model_extra_flags` case-insensitive for real  https://review.openstack.org/56567210:40
*** tuanla____ has quit IRC10:42
*** elod has quit IRC10:47
*** yamamoto has quit IRC10:48
*** elod has joined #openstack-nova10:49
openstackgerritBalazs Gibizer proposed openstack/osc-placement master: Fix error message in test assert  https://review.openstack.org/56569410:50
openstackgerritBalazs Gibizer proposed openstack/osc-placement master: Fix error message in test assert  https://review.openstack.org/56569410:51
openstackgerritStephen Finucane proposed openstack/nova master: conf: Add three new '[libvirt] live_migration_*' options  https://review.openstack.org/45657110:52
openstackgerritStephen Finucane proposed openstack/nova master: conf: Gather 'live_migration_scheme', 'live_migration_inbound_addr'  https://review.openstack.org/45657210:52
openstackgerritStephen Finucane proposed openstack/nova master: conf: Convert 'live_migration_inbound_addr' to HostAddressOpt  https://review.openstack.org/45657310:52
stephenfinowalsh: ^10:52
owalshstephenfin: ack, thanks10:53
*** alexchadin has joined #openstack-nova10:55
*** stakeda_ has quit IRC10:55
*** ragiman has quit IRC10:58
openstackgerritTheodoros Tsioutsias proposed openstack/nova master: Add scheduling notification  https://review.openstack.org/56647010:59
*** takashin has left #openstack-nova11:01
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove unused methods in nova/compute/utils.py  https://review.openstack.org/56685511:02
*** wolverineav has joined #openstack-nova11:03
*** amoralej is now known as amoralej|lunch11:04
openstackgerritStephen Finucane proposed openstack/nova master: conf: Use new-style choice values  https://review.openstack.org/53092411:06
*** gongysh has quit IRC11:06
*** moshele has quit IRC11:12
*** ragiman has joined #openstack-nova11:12
*** phuongnh has quit IRC11:14
*** tuanla_____ has quit IRC11:15
*** lucasagomes is now known as lucas-hungry11:20
*** mrjk_ has quit IRC11:27
*** mrjk_ has joined #openstack-nova11:28
*** claudiub has joined #openstack-nova11:28
tetsuroHmm... this makes me change my mind that this is a good opportunity to rework the allocation candidates logic in a totally different way. So it is fair that you ask that if we can amend nested alloc cands series without considering the existing path for sharing providers.11:30
*** tiendc has quit IRC11:31
*** claudiub|2 has quit IRC11:31
*** markvoelker has joined #openstack-nova11:34
*** yamamoto has joined #openstack-nova11:37
artomsean-k-m1, sean-k-mooney[m], one of you around? Have some questions about the Intel NFV CI11:43
*** mingyu has joined #openstack-nova11:46
*** jpena is now known as jpena|lunch11:46
*** sean-k-m1 is now known as sean-k-mooney11:50
sean-k-mooneyartom: hi11:50
artomsean-k-mooney, heya - live migration with NUMA (either pinning or actual NUMA topologies) can be tested in the Intel NFV CI, right?11:51
sean-k-mooneysorry i have been on vacation since last tuseday. my mum ha a minor operation so i was being a good son and makeing her tea and mining the house all week11:51
artomsean-k-mooney, awww :)11:51
sean-k-mooneyartom: so yes nfv ci11:51
artomHope she's doing well11:52
sean-k-mooneyartom: she is doing fine. am yes you could test numa + livemigration in the intel nfv ci but i think the livemigration tests are not in cluded in teh tempest regex in the multinode job11:53
theanalystt11:53
*** annp has quit IRC11:53
artomsean-k-mooney, could you point me to the code?11:54
artomhttps://github.com/openstack/intel-nfv-ci-tests I assume11:55
sean-k-mooneyartom: the ci is currently configured using an internal git repo but im going to take a look at the tempest.conf11:55
* artom went looking for himself like a big boy :)11:55
sean-k-mooneyartom: that is a part of it but not the ci config11:55
sean-k-mooneyartom: that host our tempest plugin11:55
*** pchavva has joined #openstack-nova11:55
*** sridharg has quit IRC11:56
sean-k-mooneyartom: tempest-dsvm-intel-nfv-xenial/ uses that plugin but its not multinode11:56
artomsean-k-mooney, does it go through gerrit? My plan is to write a live migration NUMA test (unless those already exist? A quick look at the code doesn't turn anything up), and make it Depends-On: my own patches for that11:56
*** sridharg has joined #openstack-nova11:57
sean-k-mooneyartom: the statdard livemigration test would partly test this. the tempest-dsvm-ovsdpdk-nfv-networking-xenial replaces the default flvors with ones that use cpu pinning + hugepages + 2 numa nodes11:57
sean-k-mooneyartom: this is one of the tempest.confs from a run on the ci http://52.27.155.124/portland/2018-04-27/553072/6/check/tempest-dsvm-ovsdpdk-nfv-networking-xenial/ff9bb78/logs/tempest_conf.txt.gz11:58
sean-k-mooneyso yes live_migration = False is set11:59
sean-k-mooneywe could modify that via a patch to networking-ovs-dpdk to enable livemigration via its devstack plugin.11:59
artomsean-k-mooney, so at least as a first step I could need to get live_migration set to True?11:59
artom*would need12:00
sean-k-mooneyartom: yep, we could also do that via changing the internal repo but i dont have access to it because i dont know where it is now12:00
*** andreas_s has quit IRC12:01
artomsean-k-mooney, heh, are the contacts listed on https://wiki.openstack.org/wiki/ThirdPartySystems/Intel_NFV_CI still good?12:01
sean-k-mooneynetworking-ovs-dpdk however i have full contol over. yes the contacts are correct12:01
*** lyan has joined #openstack-nova12:01
*** lyan is now known as Guest8799712:02
artomsean-k-mooney, wait, so which one do you *not* have access to?12:02
*** andreas_s_ has joined #openstack-nova12:02
*** andreas_s_ has quit IRC12:02
*** andreas_s_ has joined #openstack-nova12:02
sean-k-mooneyartom: i do not have acess to the zuul 2.5 configure repo that stores the job config. i am the maintainer of networking-ovs-dpdk and have full aceess to modify the job via that repo using the devstack plugin12:03
artomsean-k-mooney, ah, gotcha12:04
artomAnd those are both internal Intel, right?12:04
sean-k-mooneynetworking-ovs-dpdk is hosted by openstack infra but is not technically part of openstack. https://github.com/openstack/networking-ovs-dpdk12:05
*** mriedem has joined #openstack-nova12:05
sean-k-mooneyartom: we should be able to use the test-config section of the devstack plugin to enable live migration https://github.com/openstack-dev/devstack/blob/master/doc/source/plugins.rst#pluginsh-contract12:05
artomAlso, http://52.27.155.124/portland/2018-04-20/563037/2/check/tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial/3e525a4/logs/tempest_conf.txt.gz seems to enable live_migration?12:05
artomWhich woujld12:06
artomWhich wou45ld12:06
artomWhich would make sense since it's multinode, and the other one isn't12:06
sean-k-mooneytempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial used to be the same job just run against neutron12:06
sean-k-mooneysorry yes i ment tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial12:07
artom(Excuse the random characters, daughter decided my laptop is a toy)12:07
sean-k-mooneyartom: no worries12:07
sean-k-mooneystill more understandable then my spelling at times12:08
*** markvoelker has quit IRC12:08
*** edmondsw has joined #openstack-nova12:08
*** ragiman has quit IRC12:09
sean-k-mooneyartom: do you know if devstack-gate sets any env varibles that  we could use to enable "ci testing" config changes within the devstack plugin.12:11
artomsean-k-mooney, I'm not sure I understand the question12:11
*** andreas_s_ has quit IRC12:12
sean-k-mooneywell if we add the sections to enable livemirgation in the networking-ovs-dpdk devstack plugin i am wondering is there a way to enable it automatically in a ci env and not on a normal install12:13
*** andreas_s has joined #openstack-nova12:13
sean-k-mooneyif we are just setting tempest settings then there is no real harm always doing it i was just wondering if there was a way to detect that we are running in a ci12:14
*** andreas_s has quit IRC12:14
mriedemsean-k-mooney: https://github.com/openstack-infra/devstack-gate/blob/b3da8a393c68cc62924ee2f752f442d5c85ea8ed/devstack-vm-gate.sh#L56612:15
*** markvoelker has joined #openstack-nova12:15
*** andreas_s_ has joined #openstack-nova12:15
mriedemall non-grenade multinode jobs run live migration by default12:15
*** andreas_s_ has quit IRC12:15
*** ratailor__ has quit IRC12:15
mriedemgrenade doesn't because grenade by default only runs smoke tests, and live migration tests aren't smoke tests12:15
*** andreas_s_ has joined #openstack-nova12:16
mriedemwe do have a grenade job specifically that tests just live migration back and forth from n-1 to n and back12:16
artommriedem, I suppose I could just test numa-aware live migration with cpu pinning since we don't need special hardware for that, but there'd be no way to assert anything about the instance XML, which is kinda what we want12:17
sean-k-mooneymriedem: ah you are right looking at http://52.27.155.124/portland/2018-04-27/553072/6/check/tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial/943bdb9/logs/tempest_conf.txt.gz livemigration is turned on the quest then is why is it not running those tests12:17
*** amoralej|lunch is now known as amoralej12:18
mriedemsean-k-mooney: blacklist?12:18
sean-k-mooneymriedem: proably ill have to look into that12:18
mriedem[[ ^(?!.*(?:tempest\.scenario\.test_network_advanced_server_ops\.TestNetworkAdvancedServerOps\.test_server_connectivity_suspend_resume.*)|(?:tempest\.scenario\.test_network_advanced_server_ops\.TestNetworkAdvancedServerOps\.test_server_connectivity_pause_unpause.*)|(?:.*\.admin\.test_live_migration.*)|(?:.*\.TestNetworkAdvancedServerOps.test_server_connectivity_cold_migration_revert.*)|(?:.*\.TestNetworkAdvancedServerOps.test12:18
mriedemver_connectivity_cold_migration.*)|(?:.*\.TestNetworkAdvancedServerOps.test_server_connectivity_resize.*)|(?:.*\.TestNetworkBasicOps\.test_update_router_admin_state.*)|(?:.*\.TestNetworkBasicOps\.test_network_basic_op.*)|(?:.*\.TestNetworkBasicOps\.test_update_instance_port_admin_state.*))((?:tempest\.scenario\.test_network_basic_ops.*)|(?:tempest\.scenario\.test_network_advanced_server_ops.*)|(?:tempest\.api\.compute\.admin\12:18
mriedemt_live_migration.*)|(?:tempest\.api\.network.*)).*$ != '' ]]12:18
mriedemyes it's blacklisted live migration12:19
sean-k-mooneyartom: you need a multi numa host vm as we have a restiction in the libvirt drivver that maps each guest numa node to a different host numa node12:19
artomWhich makes sense, because it's broken12:19
sean-k-mooneyartom: actully the reson the multinode job was created was to test livemigration12:19
artomBut... we know it doens't work :)12:19
mriedemartom: what do you need to get out of the instance xml?12:19
mriedemthe numa config?12:20
sean-k-mooneyartom: it was turned off temporaly feburay last year and then the ci moved team and i guess it never got turned back on12:20
artommriedem, yeah12:20
artomsean-k-mooney, how did it ever pass before?12:20
mriedemartom: we have the instance diagnostics api...12:20
sean-k-mooneyartom: livemigration works it just does not respect pinning after12:20
artomsean-k-mooney, ah, indeed12:20
sean-k-mooneye.g. the vm will actully livemigrate we just broke all SLAs12:21
*** mdbooth has quit IRC12:21
mriedemartom: you could potentially add a numa_details field to the instance diagnostics response and use that for validating things in tempest (likely a tempest plugin)12:21
artommriedem, I don't think those are enough12:21
sean-k-mooneymriedem: the issue with multi numa testing in the upstream ci is we cannot spawn a 2 numa node guest on a host with 1 numa node12:22
sean-k-mooneyusing the libvirt driver12:22
*** dave-mccowan has joined #openstack-nova12:22
sean-k-mooneythat is a limitaion that i personally think should never have been there but that is a different issue12:22
*** ragiman has joined #openstack-nova12:23
artomsean-k-mooney, so is the intel CI multi-physical-node? Or multinode on VMs, so we can't have VMs with more than 1 node?12:23
artommriedem, would it really be a plugin at that point though? If it's 100% through the API, it's legit tempest12:24
*** dave-mcc_ has joined #openstack-nova12:24
sean-k-mooneyartom: mriedem: all the host vms for the intel nfv ci have 2 numa nodes to allow numa testing, the phyical hosts have 2-4 numa nodes dending on the server the nodepool vm lands on12:24
*** lucas-hungry is now known as lucasagomes12:24
mriedemartom: meaning, it's only compute api12:24
mriedemthere isn't a real need to make all other projects gate on a numa test in the common tempest repo12:25
artommriedem, so how does it work currently for nova-only tempest tests?12:25
*** bkopilov_ has joined #openstack-nova12:25
mriedemthose are legacy12:26
mriedemand some are interop tests12:26
mriedemthe real basic stuff is interop12:26
artommriedem, oh, they're not accepting new tests that are single-service?12:26
mriedemdepends12:26
artomChrist, it's getting less useful by the minute12:26
artom(Sorry tempest folks!)12:26
*** dave-mccowan has quit IRC12:26
mriedemi just know that over time, single service, non-interop tests were supposed to be moved into the project tree or a tempest plugin for that repo12:27
mriedemmost other projects already have tempest plugins, i know cinder and neutron have had their own for a long time12:27
artomI suppose it kinda make sense...12:27
*** bkopilov__ has joined #openstack-nova12:27
artomKeep the "useful to everyone" stuff in-tree, the rest can be out of scope in plugins12:28
artomAnyways12:28
artomSo, I think first step for me is to get live migration re-enabled in the intel NFV CI12:28
mriedemi'm no QA gate keeper, but just don't be surprised if that's what they tell you12:28
artomThey'll pass, sortof12:29
sean-k-mooneyartom: do you want to test multi numa guests or just guest with a numa topology12:29
artomsean-k-mooney, uh, there's a difference?12:29
sean-k-mooneyartom: hw:numa_nodes=1 should work in the upstream ci12:29
artomAh, in that sense12:29
artomHrmm12:29
artomTrue, true12:29
artommriedem, well, in the short term at least, nothing would stop me from proposing a patch to show the test passing12:30
sean-k-mooneyartom: cpu pinning will not work in the upstream ci however which is that the feature you really want to test?12:30
artomAnd it it gets -2, then we can think about plugins12:30
artomsean-k-mooney, well, everything, ideally12:31
artomEven hugepages12:31
artomI'm not writing any new NUMA code12:31
artomJust calling the old one when live migrating12:31
*** alexchadin has quit IRC12:31
artomSo technically just showing that it gets called for 1 NUMA-ish thing (and does the right thing) would be enough12:31
artomBut... the more coverage the better12:31
mriedemmelwitt: fyi i've marked https://blueprints.launchpad.net/nova/+spec/convert-consoles-to-objects complete12:31
mriedemartom: sure12:31
*** jmlowe has joined #openstack-nova12:32
mriedemartom: also, a new test would get by the intel 3rd party ci blacklist which is currently based on test names12:32
artommriedem, oh, hah, ineed. Sneaky :D12:32
mriedemso you'll probably have to do something like have your nova series, and then have a DNM nova patch on top that depends on the tempest change,12:33
*** alexchadin has joined #openstack-nova12:33
mriedembecause the intel CI runs on nova changes, but probably not tempest changes12:33
sean-k-mooneyi have to run to a meeting but ill be back in an hour or 212:33
artommriedem, yep, and a patch to the intel CI plugin that does stuff like check instance XML12:34
*** claudiub has quit IRC12:34
artommriedem, Or. Or! A patch to nova that adds what I need to the diagnostics API12:34
artomNot sure what would be simpler.12:34
mriedemhypervisor-specific stuff in tempest sucks,12:34
mriedemwhich is why i suggested adding a new field to the diagnostics api12:35
mriedemalternatively,12:35
mriedemdoes any of this numa stuff for the guest get modeled in placement?12:35
mriedemas a consumed resource?12:35
alex_xu+12:35
artommriedem, some of it, I think? But allocations are still on the compute via resource tracker, I believe12:35
mriedemalex likes it12:35
mriedemthe numa resource allocations would be on numa resource providers in the compute node provider tree12:36
mriedembut given an instance (consumer) uuid, you can get it's resource class allocations against which providers in placement12:36
mriedemso your test could assert that the instance has NUMA resource class allocations12:36
alex_xumriedem: my daugther just smash my keyboard...12:36
efriednice find tetsuro12:37
mriedemha, lot of that going on today12:37
artomalex_xu, she clearly didn't smash hard enough since we can all read what you're typing12:37
mriedemartom: but i don't think the numa stuff is done, or close(?)12:37
artommriedem, I'm not sure placement would be enough, since we would ideally check specific CPUs, not just quantities12:37
artomAnd pinning can't be checked at all12:38
mriedemartom: i'm not sure if there is a placement solution in the works for that yet or not, but in that case you could just hack up the diagnostics api12:38
artommriedem, placement is a pool I swim in, but I still breath through a snorkel, so I don't know what liquid surrounds me12:38
artomAt some point I will need to grow gills to breath through the placement pool fluid12:39
alex_xuartom: yea, a little hulk12:39
* artom thinks he has what he needs - time to drive kiddos to daycare12:40
*** jmccarthy has quit IRC12:42
*** jmccarthy1 has joined #openstack-nova12:42
*** jmccarthy1 has left #openstack-nova12:43
*** jmccarthy has joined #openstack-nova12:43
openstackgerritTakahito Hirose proposed openstack/python-novaclient master: api_version decorator becomes an error in Python 3.5.0.  https://review.openstack.org/56470212:44
*** mdbooth has joined #openstack-nova12:46
*** openstackgerrit has quit IRC12:49
*** gyankum has quit IRC12:53
*** jpena|lunch is now known as jpena12:57
*** wznoinsk has joined #openstack-nova13:03
*** brault has quit IRC13:04
*** armaan has quit IRC13:05
*** armaan has joined #openstack-nova13:06
*** claudiub has joined #openstack-nova13:09
*** mvenesio has joined #openstack-nova13:13
*** bswrchrd has joined #openstack-nova13:14
*** yamamoto has quit IRC13:16
*** yamamoto has joined #openstack-nova13:16
*** openstackgerrit has joined #openstack-nova13:16
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Deprecate support for monitoring Intel CMT `perf` events  https://review.openstack.org/56524213:16
kashyapmriedem: When you get a minute, I read the scrollback from yesterday here, and went with the: "deprecate in Rocky and hard-fail in Stein"13:17
*** moshele has joined #openstack-nova13:18
*** yingjun has joined #openstack-nova13:19
kashyapI don't think I got the "assert_called_once_with" quite right here: https://review.openstack.org/#/c/565242/5/nova/tests/unit/virt/libvirt/test_driver.py@662313:19
*** dklyle has quit IRC13:19
wznoinskmriedem, hi13:20
zzzeekjaypipes: what would cause lock wait timeout exceeded for an INSERT?13:20
jaypipeszzzeek: another thread executing LOCK TABLES <table>?13:21
zzzeekjaypipes: just that?  nothing more subtle?  ceilometer is doing it13:21
* zzzeek greps the source, sigh13:22
jaypipeszzzeek: got a log output or something more for me? :)13:22
zzzeekjaypipes: i have the error message and the query id have to spend time looking for the logs.13:22
*** armaan has quit IRC13:23
zzzeekjaypipes: but there's nothing like, the "auto increment" feature or somethign locks13:23
jaypipeszzzeek: the only other thing I can think of would be threads attempting to execute huge transactions.13:23
jaypipeszzzeek: all concurrently13:23
*** mingyu has quit IRC13:23
zzzeekjaypipes: right and then innodb locks ...a set of potential rows?13:23
*** armaan has joined #openstack-nova13:23
jaypipeszzzeek: no, autoinc won't produce that lock wait timeout generally, unless like I said, you have multiple threads simultaneously attempting to commit huge transactions (with thousands or tens of thousands of data modifications in each trx)13:24
jaypipeszzzeek: yes, innodb will do its gap locks if the PK isn't autoinc.13:25
zzzeekjaypipes: ok but in that csae, what is the lock that the INSERT is waiting for?  OK gap locks.  got it13:25
jaypipeszzzeek: but again... you need some serious concurrency and huge trx to see this impact IME13:25
*** nsingh has left #openstack-nova13:25
*** eharney has joined #openstack-nova13:25
zzzeekjaypipes: this is a load test13:25
*** liverpooler has joined #openstack-nova13:25
BlackDexHello there. Does queens support active/active rw in multiple instance using ceph storage and the correct kvm version13:25
BlackDex?13:25
jaypipeszzzeek: my guess would be ceilometer is attempting to commit batches of record changes. maybe try reducing the length of time between those commits?13:26
zzzeekjaypipes: I dont even know wehre ceilometer's database code is13:26
jaypipeszzzeek: what version?13:26
zzzeekmaster13:26
jaypipeszzzeek: lemme grep and see.13:27
jaypipeszzzeek: been a very long time since I looked at ceilometer.13:27
zzzeekjaypipes: $ find ceilometer/ -name "*.py" -exec grep -l sql {} \;13:27
zzzeek[classic@photon2 ceilometer]$13:27
zzzeekzero13:27
zzzeekthey've hidden it13:27
*** claudiub has quit IRC13:28
jaypipeszzzeek: gnocchi is now the backend data storage for meters, though, right?13:28
*** felipemonteiro__ has joined #openstack-nova13:28
zzzeekthat's pretty impressive the string "sql" does not appear in their source base at all13:28
jaypipeszzzeek: ceilometer is just the polling thing right?13:28
zzzeekjaypipes: right.  but the log is the "ceilometer agent-notification"13:28
jaypipeszzzeek: https://github.com/openstack/ceilometer/blob/master/ceilometer/gnocchi_client.py13:28
*** gongysh has joined #openstack-nova13:28
zzzeekjaypipes: table name is "event"13:30
zzzeekjaypipes: isn't that the old mysql driver?13:30
jaypipeszzzeek: no idea :(13:30
zzzeekjaypipes: ok13:30
*** moshele has quit IRC13:31
*** bswrchrd has quit IRC13:32
*** bswrchrd has joined #openstack-nova13:32
*** burt has joined #openstack-nova13:32
*** burt has quit IRC13:33
jaypipeszzzeek: is this happening in like a tempest run or something? or is this in a prod env?13:33
jaypipeszzzeek: https://github.com/openstack/ceilometer/blob/master/ceilometer/polling/manager.py#L46 <-- maybe try setting that to False and seeing if lock wait timeouts go down (due to smaller trx sizes)13:33
zzzeekjaypipes: top seekrit :)13:33
* jaypipes grasping at straws here, though... doesn't know ceilomer.13:33
*** burt has joined #openstack-nova13:33
zzzeekjaypipes: dont worry, you've been a great help :)13:34
*** yingjun has quit IRC13:34
zzzeekjaypipes: the issue here is writing to an "event" table and I think that is the ancient mysql backend13:34
*** rmart04 has joined #openstack-nova13:34
jaypipeszzzeek: yeah, sounds like it.13:34
*** felipemonteiro_ has joined #openstack-nova13:36
*** dtantsur is now known as dtantsur|bbl13:36
jaypipeszzzeek: you sure this is master? https://github.com/openstack/ceilometer/commit/9323f07f977f320882f8b536c3b54835274826fc13:36
zzzeekjaypipes: in the error I'm seeing?  it is purportedly at least queens13:37
*** ralonsoh has quit IRC13:37
*** burt has quit IRC13:37
*** burt has joined #openstack-nova13:38
jaypipeszzzeek: I think you may need to reach out to jd__.13:39
zzzeekjaypipes: yep13:39
*** felipemonteiro__ has quit IRC13:39
*** burt has quit IRC13:39
*** burt has joined #openstack-nova13:40
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove 'NUMATopologyLimits.obj_from_db_obj'  https://review.openstack.org/53741213:40
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove legacy '_to_dict' functions  https://review.openstack.org/53741313:40
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove legacy '_from_dict' functions  https://review.openstack.org/53741413:40
*** mlavalle has joined #openstack-nova13:40
*** Bonjourm8 has joined #openstack-nova13:41
*** Bonjourm8 has quit IRC13:42
*** yingjun has joined #openstack-nova13:44
*** yingjun has quit IRC13:45
*** yingjun has joined #openstack-nova13:46
*** yingjun has quit IRC13:46
*** yingjun has joined #openstack-nova13:47
*** yingjun has quit IRC13:48
*** yingjun has joined #openstack-nova13:49
*** amotoki has quit IRC13:51
artomdansmith, is there a trick in func tests to start a compute service with a specific version? I *could* mock object.Service.get_by_compute_host, which is what I want to return an "older" Service, but then it messes up other stuff that calls it13:58
*** hongbin has joined #openstack-nova13:59
*** ccamacho has quit IRC14:00
*** ccamacho1 has joined #openstack-nova14:00
*** ccamacho1 has quit IRC14:00
*** ccamacho has joined #openstack-nova14:00
*** awaugama has joined #openstack-nova14:00
*** esberglu has joined #openstack-nova14:00
*** awaugama has quit IRC14:01
*** awaugama has joined #openstack-nova14:01
*** dpawlik_ has joined #openstack-nova14:03
*** kosamara has quit IRC14:03
*** tianhui has joined #openstack-nova14:03
*** wwriverrat_ has joined #openstack-nova14:03
*** alexchadin has quit IRC14:03
*** lbragstad has quit IRC14:05
*** mriedem has quit IRC14:05
*** dpawlik has quit IRC14:05
*** wwriverrat has quit IRC14:05
*** wwriverrat_ is now known as wwriverrat14:05
*** lbragstad has joined #openstack-nova14:05
*** tianhui_ has quit IRC14:05
*** armaan has quit IRC14:07
*** armaan has joined #openstack-nova14:07
*** psachin` has quit IRC14:07
*** moshele has joined #openstack-nova14:09
kashyapCany unit test experts comment on what I can do differenlty here: https://review.openstack.org/#/c/565242/5/nova/tests/unit/virt/libvirt/test_driver.py@662314:11
kashyapWhen I assert that, I get a: "AssertionError: Expected 'warning' to be called once. Called 4 times."14:12
dansmithartom: yeah, that'd be failure-prone.. I'd just start it and then update its record manually14:13
dansmithalso, mocks in functional tests aren't good14:13
artomdansmith, yeah...14:14
*** moshele has quit IRC14:14
artomdansmith, if you're up for it I can WIP-up what I got and you can give early feedback?14:14
dansmithartom: okay14:14
artomI'm basing it on existing tests, so...14:14
*** mingyu has joined #openstack-nova14:14
openstackgerritArtom Lifshitz proposed openstack/nova master: WIP: Service version check for NUMA live migration  https://review.openstack.org/56672314:15
artomdansmith, ^^14:15
*** yamamoto has quit IRC14:16
dansmithartom: you want me to comment about the mock then?14:17
artomI want you to be happy :)14:17
artomdansmith, in seriousness though, just... if I'm way off base, let me know so I can adjust my approach right away, instead of going down this rabbit hole14:17
*** hamzy has quit IRC14:18
*** hamzy has joined #openstack-nova14:18
*** moshele has joined #openstack-nova14:19
dansmithartom: just commented what I said above but with pseudocode14:19
dansmithdoes that make sense?14:19
*** yamamoto has joined #openstack-nova14:19
kashyapCan anyone remind me again, mentioning text like these in Config file help is OK, right?14:20
kashyap    "Note that support for Intel CMT events (`cmt`, `mbmbt`, `mbml`) is deprecated in Nova, and will be removed in "Stein" release."14:20
kashyapBecause the config file help text is per release, it is okay...14:20
openstackgerritJulia Kreger proposed openstack/nova master: ironic: add instance_uuid before any other spawn activity  https://review.openstack.org/56372214:20
artomdansmith, ah, yeah, that's probably smarter. Cheers!14:20
artomkashyap, you can iterate through the calls to see what they were, maybe something else is logging at warn level that you haven't considered?14:21
kashyapartom: This is purely help text.  All I am asking is, is it okay to call out future release names like what I noted above is okay in the help text14:22
*** mriedem has joined #openstack-nova14:22
artomkashyap, I was answered your earlier question about the calls assetion :)14:22
artom*answering14:23
artom*asserting14:23
kashyapartom: Aaah, darn.  My memory is like a gold fish14:23
* artom is becoming sean-k-mooney14:23
artomkashyap, https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.mock_calls14:23
kashyapartom: It is the specific warning: https://review.openstack.org/#/c/565242/5/nova/tests/unit/virt/libvirt/test_driver.py@662314:23
kashyapOn that line14:23
artomkashyap, yeah, and as a debugging aid I'm suggesting you examine what the calls were14:24
kashyapWhich should log this: https://review.openstack.org/#/c/565242/5/nova/virt/libvirt/driver.py@479914:24
kashyapartom: Yep, digging...Thx for the (non-null) pointer14:24
jrollkashyap: if there's other warn calls happening, you could also do mock_warn.assert_has_calls([mock.call('Monitoring...')])14:24
artomkashyap, I'm thinking something else called LOG.warning somewhere along that test's execution14:25
kashyapjroll: I don't think it's other warn calls, because I was calling it with a specific warning message14:25
*** armaan has quit IRC14:25
artomIf those were legit calls, you can adjust your tests to only assert on the call you care about14:25
kashyapjroll: But let me try your trick.14:25
jrollkashyap: what artom said :)14:25
artomIf they weren't legit, you fix your code :)14:25
jroll++14:26
*** armaan has joined #openstack-nova14:26
* kashyap looks14:26
kashyapThx for the comments, folks14:26
artomBtw, asserting on *log messages* is horrible testing practive14:27
artom*practice14:27
artomI know Nova is side-effect land, so we don't have much choice14:27
artomBut in an ideal world, we'd be asserting stuff on output, given a certain input14:27
kashyapartom: I was actually asked to do it.  I firt did the self.assertTrue(mock_warn.called)14:27
kashyapAnd the libvirt driver at least doesn't do a lot of those.  Only 3 or so of them -- asserting on log message.14:28
artomkashyap, yeah, I fully understand the reality of what we're working on14:28
kashyapAnd if it's any consolation, this warning will be removed in the next release.14:28
*** moshele has quit IRC14:29
*** mchlumsky has joined #openstack-nova14:30
*** Nil_ has joined #openstack-nova14:33
openstackgerritMerged openstack/nova master: Changing scheduler sync event from INFO to DEBUG  https://review.openstack.org/56639214:34
*** Eran_Kuris has quit IRC14:38
*** dklyle has joined #openstack-nova14:42
*** wwriverrat has quit IRC14:43
*** rcernin has quit IRC14:47
*** rajinir has joined #openstack-nova14:49
*** ragiman has quit IRC14:50
*** yingjun has quit IRC14:51
*** sapd1 has joined #openstack-nova14:52
*** udesale has quit IRC14:53
*** hemna_ has joined #openstack-nova14:55
*** r-daneel has joined #openstack-nova14:55
jmccarthymriedem: Thanks again for the help, this experimental review did the trick for me https://review.openstack.org/#/c/56636714:58
*** gongysh has quit IRC14:59
*** gyankum has joined #openstack-nova15:00
*** rmart04 has quit IRC15:01
mriedemjmccarthy: np, thanks for verifying it15:05
kashyapjroll: Your trick tells me my assertion was not even in the call list.  ("not all found in call list").15:06
jrollinteresting15:06
*** jungleboyj has joined #openstack-nova15:07
* kashyap dukes around a bit more15:07
*** r-daneel has quit IRC15:08
*** links has quit IRC15:08
mriedemjmccarthy: just tested mel's suggestion in there, i'll get that patch updated later today15:21
*** bhujay has quit IRC15:21
jmccarthymriedem: Ah ok cool - I can give that a whirl also to confirm (but probably not till later)15:22
*** andreas_s_ has quit IRC15:25
*** andreas_s has joined #openstack-nova15:26
*** zcorneli has joined #openstack-nova15:26
*** felipemonteiro has joined #openstack-nova15:30
*** felipemonteiro__ has joined #openstack-nova15:31
*** gjayavelu has joined #openstack-nova15:31
*** felipemonteiro_ has quit IRC15:32
*** felipemonteiro has quit IRC15:35
*** andreas_s has quit IRC15:35
*** andreas_s has joined #openstack-nova15:40
*** lucasagomes is now known as lucas-bbl15:42
*** burt has quit IRC15:42
*** burt has joined #openstack-nova15:42
openstackgerritEric Fried proposed openstack/nova master: Use query_parameters in granular gabbit  https://review.openstack.org/56692715:46
openstackgerritAditya Vaja proposed openstack/nova master: remove IVS plug/unplug as they're moved to separate plugin  https://review.openstack.org/53437115:48
*** ccamacho has quit IRC15:49
*** zhaochao has quit IRC15:50
*** gyan_ has joined #openstack-nova15:51
stephenfinjaypipes, bauzas, sean-k-mooney: Fancy taking another swing at https://review.openstack.org/#/c/541290/ today?15:52
*** andreas_s has quit IRC15:53
jaypipesstephenfin: ack, will do. sorry, was swamped with other stuff yesterday and didn't get to that.15:53
stephenfinno worries :) /me is going through bandwidth-resource-provider again atm15:54
*** gyankum has quit IRC15:54
openstackgerritBrianna Poulos proposed openstack/nova master: Add notification support for trusted_certs  https://review.openstack.org/56326915:55
*** cdent has joined #openstack-nova15:58
*** gjayavelu has quit IRC16:00
*** edmondsw has quit IRC16:00
*** cfriesen_ has quit IRC16:01
*** cfriesen_ has joined #openstack-nova16:01
*** bpoulos has joined #openstack-nova16:01
*** edmondsw has joined #openstack-nova16:01
openstackgerritMatt Riedemann proposed openstack/nova master: Wait for network-vif-plugged before starting live migration  https://review.openstack.org/55800116:01
openstackgerritMatt Riedemann proposed openstack/nova master: Add check if neutron "binding-extended" extension is available  https://review.openstack.org/52354816:01
openstackgerritMatt Riedemann proposed openstack/nova master: Add "bind_ports_to_host" neutron API method  https://review.openstack.org/52360416:01
openstackgerritMatt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method  https://review.openstack.org/55217016:01
openstackgerritMatt Riedemann proposed openstack/nova master: Add "activate_port_binding" neutron API method  https://review.openstack.org/55594716:01
openstackgerritMatt Riedemann proposed openstack/nova master: Delete port bindings in setup_networks_on_host if teardown=True  https://review.openstack.org/55633316:01
openstackgerritMatt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron  https://review.openstack.org/55633416:01
openstackgerritMatt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration  https://review.openstack.org/51542316:01
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: use dest host vif migrate details for live migration  https://review.openstack.org/55137016:01
openstackgerritMatt Riedemann proposed openstack/nova master: Annotate flows and handle PortBindingDeletionFailed in ComputeManager  https://review.openstack.org/55137116:01
openstackgerritMatt Riedemann proposed openstack/nova master: Port binding based on events during live migration  https://review.openstack.org/43487016:01
*** janki has quit IRC16:01
openstackgerritMatt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate  https://review.openstack.org/52253716:01
openstackgerritMatt Riedemann proposed openstack/nova master: Add VIFMigrateData.get_dest_vif  https://review.openstack.org/56693116:01
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: factor out pre_live_migration plug_vifs call  https://review.openstack.org/56693216:01
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: use dest host port bindings during pre_live_migration  https://review.openstack.org/56693316:01
*** zcorneli has quit IRC16:03
*** dtantsur|bbl is now known as dtantsur16:04
*** gyee has joined #openstack-nova16:04
*** bhujay has joined #openstack-nova16:05
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: use dest host vif migrate details for live migration  https://review.openstack.org/55137016:07
openstackgerritMatt Riedemann proposed openstack/nova master: Annotate flows and handle PortBindingDeletionFailed in ComputeManager  https://review.openstack.org/55137116:07
openstackgerritMatt Riedemann proposed openstack/nova master: Port binding based on events during live migration  https://review.openstack.org/43487016:07
openstackgerritMatt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate  https://review.openstack.org/52253716:07
openstackgerritMatt Riedemann proposed openstack/nova master: DNM: test live_migration_wait_for_vif_plug=True  https://review.openstack.org/55800616:07
*** cfriesen_ has quit IRC16:08
*** wwriverrat has joined #openstack-nova16:09
*** andreas_s has joined #openstack-nova16:16
*** moshele has joined #openstack-nova16:17
*** harlowja has joined #openstack-nova16:17
*** cfriesen_ has joined #openstack-nova16:19
*** yamamoto has quit IRC16:21
*** andreas_s has quit IRC16:25
*** andreas_s has joined #openstack-nova16:25
*** ccamacho has joined #openstack-nova16:28
*** gjayavelu has joined #openstack-nova16:30
*** imacdonn has joined #openstack-nova16:34
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove 'NUMATopologyLimits.obj_from_db_obj'  https://review.openstack.org/53741216:35
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove legacy '_to_dict' functions  https://review.openstack.org/53741316:35
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove legacy '_from_dict' functions  https://review.openstack.org/53741416:35
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: check image type before removing snapshots in _cleanup_resize  https://review.openstack.org/56636716:36
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: remove old rbd snapshot removal error handling  https://review.openstack.org/56636916:36
*** fragatina has quit IRC16:36
*** gjayavelu has quit IRC16:36
openstackgerritArtom Lifshitz proposed openstack/nova master: Add InstanceNUMATopology to LibvirtLiveMigrateData  https://review.openstack.org/56639816:37
openstackgerritArtom Lifshitz proposed openstack/nova master: Service version check for NUMA live migration  https://review.openstack.org/56672316:37
*** andreas_s has quit IRC16:38
*** jmccarthy has left #openstack-nova16:39
*** yamamoto has joined #openstack-nova16:39
*** jmccarthy has joined #openstack-nova16:39
*** jmccarthy has left #openstack-nova16:39
*** Guest47185 has quit IRC16:41
*** dklyle has quit IRC16:48
*** EmilienM is now known as EmilienM_PTO16:49
*** mingyu has quit IRC16:49
*** mingyu has joined #openstack-nova16:49
*** gyan_ has quit IRC16:52
*** sapd1 has quit IRC16:53
openstackgerritEric Fried proposed openstack/nova master: placement: Granular GET /allocation_candidates  https://review.openstack.org/51775716:54
*** derekh has quit IRC16:57
*** ccamacho has quit IRC16:58
*** ccamacho has joined #openstack-nova16:58
openstackgerritMerged openstack/nova master: libvirt: Fix misleading debug msg "Instance is running"  https://review.openstack.org/56523417:01
*** sambetts is now known as sambetts|afk17:02
*** dklyle has joined #openstack-nova17:04
*** mgoddard has quit IRC17:04
*** jpena is now known as jpena|off17:08
*** gjayavelu has joined #openstack-nova17:08
*** zcorneli has joined #openstack-nova17:09
*** fragatina has joined #openstack-nova17:09
*** yamamoto has quit IRC17:10
openstackgerritDan Smith proposed openstack/nova master: WIP: Use oslo.messaging per-call monitoring  https://review.openstack.org/56669617:11
*** zcorneli has quit IRC17:13
*** zcorneli has joined #openstack-nova17:16
*** gyee has quit IRC17:17
*** cfriesen_ has quit IRC17:20
*** gjayavelu has quit IRC17:23
*** slaweq has quit IRC17:25
*** slaweq has joined #openstack-nova17:26
*** hamzy has quit IRC17:28
*** mdnadeem has quit IRC17:29
openstackgerritMerged openstack/nova-specs master: Network bandwidth resource provider  https://review.openstack.org/50230617:30
gibi\o/ ^^17:30
*** harlowja has quit IRC17:31
*** slaweq has quit IRC17:31
*** mdbooth has quit IRC17:36
efriedmriedem: In ocata and/or pike, in a bfv situation, is/was there a bug where the scheduler would require the host to have localdisk inventory in the amount requested by the flavor, even though it wasn't ultimately allocated/consumed?17:37
*** dklyle has quit IRC17:37
*** bhujay has quit IRC17:39
*** slaweq has joined #openstack-nova17:41
*** cdent has quit IRC17:42
*** slaweq has quit IRC17:45
*** amoralej is now known as amoralej|off17:46
*** tssurya has quit IRC17:50
*** jlvillal is now known as jlvacation17:51
*** r-daneel has joined #openstack-nova17:52
*** gjayavelu has joined #openstack-nova17:56
mriedemefried: https://bugs.launchpad.net/nova/+bug/1469179 ?17:57
openstackLaunchpad bug 1469179 in OpenStack Compute (nova) "instance.root_gb should be 0 for volume-backed instances" [Medium,In progress] - Assigned to Dan Smith (danms)17:57
*** felipemonteiro__ has quit IRC18:10
*** felipemonteiro__ has joined #openstack-nova18:10
*** yamamoto has joined #openstack-nova18:11
*** dtantsur is now known as dtantsur|afk18:19
*** gyee has joined #openstack-nova18:19
*** hamzy has joined #openstack-nova18:20
*** Bonjourm8 has joined #openstack-nova18:20
*** yamamoto has quit IRC18:21
*** cfriesen_ has joined #openstack-nova18:21
efriedThanks mriedem18:23
*** harlowja has joined #openstack-nova18:25
*** jaosorior has quit IRC18:26
*** sridharg has quit IRC18:29
*** strigazi has quit IRC18:30
*** strigazi has joined #openstack-nova18:31
*** psachin` has joined #openstack-nova18:33
*** pchavva has quit IRC18:39
*** Swami has joined #openstack-nova18:39
*** tssurya has joined #openstack-nova18:42
dansmithtssurya: have you looked over this yet? https://review.openstack.org/#/c/509003/18:44
dansmithmriedem: melwitt: do you both agree that having a config flag for gating that ^ vs. just hitting all cells is a good idea?18:44
tssuryadansmith: oops, not yet, will review now18:44
dansmithtssurya: okay I want to make sure it will work for you18:44
*** Swami has quit IRC18:45
mriedemumm,18:47
mriedemsince most people aren't >1 cell yet, that adds an extra db hit to every GET /servers operation right?18:47
*** openstackgerrit has quit IRC18:49
dansmithyeah, which is why I think it probably needs a config knob18:50
dansmithit should be a huge benefit to cern, but not most people18:51
tssuryadansmith: this works for us since we have a lot of cells, but I think from a developer perspective we wouldn't want to retrieve the mappings every time , so I vote for a config option -> same logic in us doing refresh handler for disable cells to maintain the cache.18:51
*** Bonjourm8 has quit IRC18:52
dansmithaye18:52
jaypipesdansmith: my thought was that such an option could easily be added if it becomes an issue later.19:00
mriedemdansmith: well, you could create 1000 fake instances and compare the average time to list them either way and see if the extra join is a noticeable impact19:01
dansmithmriedem: extra join?19:02
mriedeminstance mappings -> cell mappings19:02
jaypipesmriedem: it's not a join. just an extra query against instance_mappings IIRC19:02
mriedemthe upfront extra join to filter cell mappings based on project_id19:02
dansmithit's a whole extra hit, not just a join19:02
mriedemthe "new extra db kerfuffle"19:02
dansmithI prefer to just make it default to continue using the cache, and let people like cern opt into this behavior19:03
melwittmriedem: sweet, thanks for closing out the bp19:09
*** dklyle has joined #openstack-nova19:09
jaypipesstephenfin: still around?19:10
*** Swami has joined #openstack-nova19:10
*** Swami_ has joined #openstack-nova19:10
jaypipesstephenfin: what precisely do you mean by "mechanisms" in "Like provider networks, tenant networks can use one of five mechanisms: *flat*, *VLAN*, *local*, *VXLAN*, or *GRE*."? In particular, what is "local mechanism"?19:11
melwittdansmith: config option sounds okay ... the only bad side is, yet-another-config-option. and I'm thinking how can we group cells-related options, CONF.cells is already taken by cells v119:12
jaypipesmelwitt: CONF.cern? ;)19:13
mriedemCONF.api.something19:13
melwittheh19:13
mriedemCONF.api.multicell_project_per_cell19:13
tssuryajaypipes: :P19:13
jaypipestssurya: :)19:13
*** dave-mcc_ has quit IRC19:14
mriedemfortunately we already have a project_id index in the instance_mappings table19:15
mriedemthis unblocks osc-placement if someone wants to give the +W https://review.openstack.org/#/c/565694/19:17
jaypipesmriedem: done19:19
mriedemthanks19:19
*** dave-mccowan has joined #openstack-nova19:19
*** david-lyle has joined #openstack-nova19:27
arvindn05mriedem: quick question on your comment for https://review.openstack.org/#/c/560596 - update scheduler to use image-traits19:30
*** psachin` has quit IRC19:30
arvindn05>>have a functional test for a volume-backed instance to show that we don't consider the required image traits19:30
arvindn05for volume backed instance, there is no image right? so where do the image traits come in?19:30
arvindn05tests for launching volume backed instance should already capture this case correct?19:31
*** tbachman has joined #openstack-nova19:33
*** openstackgerrit has joined #openstack-nova19:33
openstackgerritChris Dent proposed openstack/nova master: Optional separate database for placement API  https://review.openstack.org/36276619:33
openstackgerritChris Dent proposed openstack/nova master: Isolate placement database config  https://review.openstack.org/54143519:33
openstackgerritChris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process  https://review.openstack.org/55385719:33
openstackgerritChris Dent proposed openstack/nova master: WIP: Add PLACEMENT_DB_ENABLED=True to the nova-next job  https://review.openstack.org/56406719:34
mriedemarvindn05: the root volume has an image in it19:35
mriedemwhich could have required traits,19:35
mriedembut yes that doesn't get put into the request spec so we don't filter on the image traits for volume-backed instances19:35
arvindn05mriedem: ahh..ok..dont know a lot about volume backed instances19:36
mriedemarvindn05: a test could be that i have a single compute and an image with a required trait CUSTOM_FOO, and the compute doesn't have that trait. trying to create a server with just the image fails with novalidhost, but trying to create a volume-backed instance using that image passes because we don't filter on the image required traits in that case19:36
arvindn05i am guessing this should be in a single method? because the first part of the test is already part of the current functional test, but we will need to duplicate so we dont get intermittent success/failures?19:38
arvindn05or i can just create a test for volume backed instance case and use an image with trait and prove that it does not throw novalidhost19:40
*** slaweq has joined #openstack-nova19:41
mriedemtest_image_traits_based_scheduling_no_valid_host already tests the first thing i said, right19:41
arvindn05mriedem: is this a good example of how i can create a volume backed instance https://github.com/openstack/nova/blob/master/nova/tests/functional/test_servers.py#L133019:41
mriedemso you'd basically copy test_image_traits_based_scheduling_no_valid_host but _create_server_with_traits would include block_device_mapping_v219:41
mriedemyes and no,19:42
*** awaugama has quit IRC19:42
mriedemthat relies on https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L1323 to boot from an existing bootable volume in the fixture19:42
mriedemso for your test, the image 155d900f-4e14-4e4c-a73d-069cbf4541e6 would need to have the required trait on it19:43
mriedemsee https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L140919:43
mriedemi think you get the idea though19:44
mriedemand it's something that will need to be in whatever image property documentation exists for required traits19:44
*** bpoulos has quit IRC19:45
arvindn05yup...we have a patch for all the documentation...will handle it as part of that19:45
*** slaweq has quit IRC19:45
openstackgerritMerged openstack/osc-placement master: Fix error message in test assert  https://review.openstack.org/56569419:49
*** moshele has quit IRC19:51
efriedmelwitt: Is there a bug for the intermittent nova-next failure?19:51
melwittefried: there was this one from yesterday https://launchpad.net/bugs/176928619:52
openstackLaunchpad bug 1769286 in devstack "NoVNCConsoleTestJSON.test_novnc intermittently fails with: SecurityProxyNegotiationFailed: Failed to negotiate security type with server: No compute auth available: No matching auth scheme: allowed types: 'AuthType.NONE', desired types: '19'" [High,Fix released] - Assigned to melanie witt (melwitt)19:52
melwittefried: are you seeing new failures?19:53
efriedmelwitt: Hum, okay, so this is not the same one: http://logs.openstack.org/57/517757/38/check/nova-next/4d5fdba/job-output.txt.gz#_2018-05-08_18_40_52_20520319:53
mriedemthat's not vnc19:53
mriedemand is a known latent bug19:53
mriedemhttp://status.openstack.org/elastic-recheck/#173219919:53
efriedmriedem: Thanks.  I knew there's no way it could have anything to do with my 1.3KLOC patch.19:54
melwitt:)19:54
melwittis e-r working these days? I feel like it's been at least a year since I saw it comment on any review19:54
efriedI thought once something was registered with elastic-recheck it posted comments to the gerrit review...19:54
efriedyeah, what melwitt said.19:54
arvindn05mriedem: Can i add a IMAGE_WITH_TRAITS_BACKED_VOL to CinderFixture for adding the unit test? or is there a different approach i should take...19:55
arvindn05*CinderFixtureNewAttachFlow19:57
*** wolverineav has quit IRC19:58
*** wolverineav has joined #openstack-nova19:58
melwittI remember asking about this VolumePathsNotFound during extend_volume http://logs.openstack.org/57/517757/38/check/nova-next/4d5fdba/logs/screen-n-cpu.txt.gz?level=TRACE#_May_08_18_35_13_576026 in the cinder channel awhile back, but no one had any ideas. it looks like something to do with iscsiadm not able to find or read the session19:59
*** munimeha has joined #openstack-nova20:00
melwittand I had no idea what that means or what could cause it20:00
*** wolverineav has quit IRC20:03
mriedemelastic-recheck used to not comment on changes because we'd hit a 15 minute timeout to process logs20:05
melwittI've asked in -infra20:05
melwittlooks like anytime indexing is behind, it won't comment as it won't want to post stale info http://status.openstack.org/elastic-recheck/20:05
melwittmaybe it's perpetually behind20:06
mriedemarvindn05: the fixture is using a "real" image in the fake image service registry, so you could just update that image with required traits https://github.com/openstack/nova/blob/master/nova/tests/unit/image/fake.py#L4420:06
mriedemin your test, like you're doing in setUp for the other image20:07
*** esberglu has quit IRC20:07
*** avolkov has quit IRC20:10
arvindn05cool...one other question though i am looking at https://developer.openstack.org/api-ref/block-storage/v3/#list-accessible-volumes-with-details20:11
arvindn05"volume_image_metadata": {20:12
arvindn05    "kernel_id": "8a55f5f1-78f7-4477-8168-977d8519342c",20:12
arvindn05    "image_id": "b48c53e1-9a96-4a5a-a630-2e74ec54ddcc",20:12
arvindn05    ....20:12
arvindn05},20:12
arvindn05does volume image metadata ever even contain the image meta props like hw_architecture etc?20:12
arvindn05if the image meta data for a volume is just the image attributes rather than any of the standard fields of ImageMetaProps then again the test may not make sense20:13
mriedemthe volume's volume_image_metadata is a copy of the image metadata from the image or snapshot used to create the volume20:15
mriedemso if we ever wanted/needed to actually filter volume-backed instances based on image metadata, we can totally do that by getting the image meta via the volume_image_metadata, we just don't do that today20:16
mriedemhttp://git.openstack.org/cgit/openstack/cinder/tree/cinder/volume/flows/manager/create_volume.py#n55920:17
arvindn05so if i have an image with trait:foo, then for a volume based on that image the meta data would look like below20:19
arvindn05"volume_image_metadata": {20:19
arvindn05    "image_id": "b48c53e1-9a96-4a5a-a630-2e74ec54ddcc",20:19
arvindn05    "trait:foo" "required"20:19
arvindn05    ....20:19
arvindn05},20:19
arvindn05or would the trait:foo field be missing and looked up when the image is loaded with the ID20:19
*** esberglu has joined #openstack-nova20:19
mriedemarvindn05: maybe you should fire up a devstack and test this out for yourself20:19
arvindn05if its the above with trait:foo being part of volume_image_metadata then i would need to add to CinderFixtureNewAttachFlow else i can do your suggestion of updating the image directly20:20
*** pcaruana has quit IRC20:21
mriedemhttps://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L1409 is not attempting to be an exhaustive list of what goes into volume_image_metadata for the cinder fixture20:21
arvindn05mriedem: havent worked with cinder before...so trying to cover the bases...will update my devstack to have cinder and try out as well20:21
arvindn05yea...if you knew off the top of the head if volume_image_metadata enumerates all ImageMetaProps(if defined on the image) that would help me get a headstart with the test20:23
*** dklyle has quit IRC20:32
*** edmondsw has quit IRC20:33
openstackgerritMatt Riedemann proposed openstack/python-novaclient master: Fix the policy argument in server-group-create  https://review.openstack.org/56469920:37
*** hemna_ has quit IRC20:41
*** ttsiouts_ has joined #openstack-nova20:46
*** slaweq has joined #openstack-nova20:49
*** andreas_s has joined #openstack-nova20:52
openstackgerritkarim proposed openstack/nova master: Pushing image traits to ironic node  https://review.openstack.org/56562020:55
*** andreas_s has quit IRC20:57
openstackgerritEric Fried proposed openstack/nova master: Use .. deprecated:: theme for deprecations  https://review.openstack.org/56582220:58
*** tssurya has quit IRC20:59
mriedemmelwitt: i don't know if this is a bug fix or a feature or what https://review.openstack.org/#/c/564193/21:05
* melwitt looks21:06
openstackgerritMerged openstack/nova master: Bump pypowervm minimum to 1.1.15  https://review.openstack.org/56427621:06
openstackgerritArtom Lifshitz proposed openstack/nova master: Service version check for NUMA live migration  https://review.openstack.org/56672321:08
melwittmriedem: yeah, looks like a driver parity thing. not sure if it's a feature either, not an expert on what image meta props really are21:08
mriedemyeah it's adding support for hw_video_ram to the vmware driver21:10
mriedemso not a bug21:11
mriedemthe commit message totally makes it sound like it's fixing something, but it's not21:11
mriedem"fix this new thing that i'm adding"21:11
melwittyeah, agreed. good doc finds in your comment21:12
*** hemna_ has joined #openstack-nova21:13
*** felipemonteiro_ has joined #openstack-nova21:13
melwittwe usually do blueprints for driver parity things but this is indeed a lot smaller than most of the parity things we usually see. kind of more along the lines of adding the aarch64 support stuff maybe?21:13
melwittso maybe don't need a blueprint but do need release note and doc update at a minimum21:16
mriedemyeah i don't think we need a blueprint either21:17
mriedemjust reno and doc updates21:17
*** felipemonteiro__ has quit IRC21:17
melwitt++21:17
melwittlooks like the doc update would be in glance though21:18
mriedemfor the image properties one yeah,21:18
mriedembut we should also document the flavor extra spec in our docs21:18
melwittyeah -- just not sure it has to fall on their change though, since it's currently undocumented even for the libvirt driver21:19
mriedemmelwitt: ok, i'll do them a solid and push a patch below theirs that adds the flavor extra spec doc, and they can then update it21:20
melwittsounds super21:20
*** swamireddy has quit IRC21:20
*** liverpooler has quit IRC21:22
*** david-lyle has quit IRC21:23
openstackgerritMerged openstack/nova master: Remove stale pip-missing-reqs tox test  https://review.openstack.org/56553521:32
*** dhellmann has left #openstack-nova21:37
*** felipemonteiro__ has joined #openstack-nova21:38
*** felipemonteiro_ has quit IRC21:38
openstackgerritMatt Riedemann proposed openstack/nova master: doc: Don't confuse CPU pinning/NUMA as Hyper-V only  https://review.openstack.org/56194921:40
mriedemstephenfin: we need to get -W working in the docs builds again ^21:40
*** markvoelker_ has joined #openstack-nova21:41
*** markvoelker has quit IRC21:42
*** ttsiouts_ has quit IRC21:48
*** hjensas is now known as hjensas|afk21:49
openstackgerritMatt Riedemann proposed openstack/nova master: Use .. deprecated:: theme for deprecations  https://review.openstack.org/56582221:50
openstackgerritMerged openstack/nova master: placement: Object changes for granular  https://review.openstack.org/56435121:51
sean-k-mooneymriedem: huh when did they make that a config option on the host instead of using the there custom extra spec option21:51
mriedemsean-k-mooney: context?21:51
sean-k-mooneyhyperv numa affinity21:52
mriedemthat's a question for claudiu21:52
mriedemor git blame21:52
sean-k-mooneyhyperv used (like 4/5 releases ago) have a addtion hw:somting extra spec that allowed you to set the numa affinity of the guest memory21:53
sean-k-mooneyi went looking for it simi recently but could not find it so i assumed it was removed but i guest its now a host config option21:54
mriedemdansmith: i left comments in https://review.openstack.org/#/c/509002/ but didn't want to -121:55
sean-k-mooneymriedem: ah it was hw:numa_mempolicy=preferred|strict  http://git.openstack.org/cgit/openstack/nova-specs/tree/specs/liberty/approved/hyper-v-vnuma-enable.rst#n7821:57
sean-k-mooneyah it looks like they did not complete the spec until ocata and that extra spec got lost along the way.  that is a shame i wanted to add that to the libvirt driver at some point.22:01
*** burt has quit IRC22:01
dansmithmriedem: ack, thanks22:04
arvindn05mriedem: FYI tested with image backed volume the image meta data needs to be part of the volume_image_metadata...so will need to modify the fixture..will write the funtional test with that in mind :)22:09
arvindn05"volume_image_metadata": {22:09
arvindn05    "image_id": "39f216fd-ebba-4a6a-b741-c83cd02a00ec",22:09
arvindn05    "trait:CUSTOM_TRUSTED": "required",22:09
arvindn05    ...22:09
arvindn05}22:09
*** esberglu has quit IRC22:12
openstackgerritMatt Riedemann proposed openstack/nova master: vmware:Validation video ram against the max video ram allowed.  https://review.openstack.org/56419322:17
openstackgerritMatt Riedemann proposed openstack/nova master: Add docs for hw_video:ram_max_mb flavor extra spec  https://review.openstack.org/56707022:17
*** Guest87997 has quit IRC22:21
*** rcernin has joined #openstack-nova22:25
*** yassine has joined #openstack-nova22:28
*** yassine is now known as Guest8389622:29
openstackgerritMerged openstack/osc-placement master: RP delete inventories (v1.5)  https://review.openstack.org/51464222:29
*** felipemonteiro_ has joined #openstack-nova22:34
*** felipemonteiro__ has quit IRC22:37
*** Guest83896 has quit IRC22:37
melwittmriedem: I dunno if you saw my reply yesterday about the stable releases. I was thinking maybe we just do the releases after we get the regression fixes we know about in? what was your thought on it? do you think we should go ahead and flush the stable review queues too?22:38
*** hongbin has quit IRC22:48
*** Guest83896 has joined #openstack-nova22:52
*** moshele has joined #openstack-nova22:55
*** slaweq has quit IRC22:57
*** swamireddy has joined #openstack-nova22:59
*** felipemonteiro__ has joined #openstack-nova23:04
*** felipemonteiro_ has quit IRC23:04
openstackgerritMerged openstack/nova master: Handle PortNotFoundClient exception when getting ports  https://review.openstack.org/56518323:09
melwittinteresting, this old experimental queue job failing because it wants to install the liberty cloud archive which isn't supported on xenial http://logs.openstack.org/37/554437/18/experimental/legacy-tempest-dsvm-nova-libvirt-kvm-apr/e50a428/logs/devstacklog.txt.gz#_2018-05-08_22_58_11_82823:12
*** felipemonteiro__ has quit IRC23:14
openstackgerritMerged openstack/python-novaclient master: Fix the policy argument in server-group-create  https://review.openstack.org/56469923:18
*** vivsoni has joined #openstack-nova23:21
*** vivsoni_ has quit IRC23:24
*** r-daneel has quit IRC23:26
*** munimeha has quit IRC23:30
*** bkopilov_ has quit IRC23:31
*** bkopilov__ has quit IRC23:32
*** abalutoiu_ has quit IRC23:41
*** bkopilov__ has joined #openstack-nova23:44
*** mlavalle has quit IRC23:44
*** bkopilov_ has joined #openstack-nova23:44
openstackgerritMerged openstack/nova master: placement: Granular GET /allocation_candidates  https://review.openstack.org/51775723:47
openstackgerritMerged openstack/nova master: doc: Don't confuse CPU pinning/NUMA as Hyper-V only  https://review.openstack.org/56194923:47
openstackgerritMerged openstack/nova master: Use .. deprecated:: theme for deprecations  https://review.openstack.org/56582223:47
*** moshele has quit IRC23:50
*** bkopilov__ has quit IRC23:52
*** bkopilov_ has quit IRC23:52
mriedemmelwitt: didn't see it, but these are the regressions i had in mind: https://review.openstack.org/#/c/564461/ https://review.openstack.org/#/c/566367/ https://review.openstack.org/#/c/563213/23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!