Wednesday, 2018-02-21

smcginnisOnly let's me download. Doing that now.00:01
mriedemhttps://www.youtube.com/watch?v=ykGe7GiF9yk00:01
mriedemtry that instead00:01
*** yamamoto has joined #openstack-nova00:02
melwittit worked for me after I downloaded it00:03
melwittyoutube gives me this error "This video is unavailable."00:04
mriedemmaybe b/c it's private? let me log out and try00:04
melwittyeah, I tried it in a non-logged-in window00:04
mriedemah yeah, sec00:04
melwittyep working now on youtube00:06
melwitt*two thumbs up*00:06
mriedemyeah i just made it public00:06
mriedemaudio chops a bit in places but it was kind of a pain in the ass so don't really care to re-record00:06
*** yamamoto has quit IRC00:07
mriedemeh it's pretty annoying00:11
* mriedem hangs head in shame00:11
* mriedem goes to eat00:12
*** openstackstatus has quit IRC00:12
*** openstackstatus has joined #openstack-nova00:14
*** ChanServ sets mode: +v openstackstatus00:14
*** hongbin has quit IRC00:16
*** tetsuro has joined #openstack-nova00:21
*** mriedem has quit IRC00:21
*** AlexeyAbashkin has joined #openstack-nova00:23
*** Zames has joined #openstack-nova00:24
tetsurojaypipes, cfriesen: I have updated the spec. Could you have a look on https://review.openstack.org/#/c/543805/, again ?00:25
*** AlexeyAbashkin has quit IRC00:27
*** Zames has quit IRC00:28
*** acormier has joined #openstack-nova00:30
*** lbragstad has quit IRC00:32
*** openstackgerrit has joined #openstack-nova00:32
openstackgerritNakanishi Tomotaka proposed openstack/nova master: Test Compute API in multiple cells  https://review.openstack.org/53411600:32
tetsuromelwitt: thank you for reviewing on https://review.openstack.org/#/c/531347/00:33
tetsuroIn fact, I at first create a virt_type field in https://review.openstack.org/#/c/531327/.00:33
tetsuroBut in openstack if you set virt_type=qemu to that host, that host doesn’t have capability of building VMs with KVM.00:33
tetsuroSo, I come to think the patch above is more correct way to correct this.00:33
jaypipestetsuro: yep. will do shortly.00:33
tetsurojaypipes: thanks00:34
*** mlavalle has quit IRC00:35
*** jgriffith has quit IRC00:35
*** acormier has quit IRC00:35
*** chyka has quit IRC00:36
*** chyka has joined #openstack-nova00:37
*** jgriffith has joined #openstack-nova00:37
tetsuromelwitt, mriedeman: been wondering https://review.openstack.org/#/c/531347/ have any impact on https://review.openstack.org/#/c/538498/ (I will have a look from now), too.00:40
*** chyka has quit IRC00:41
*** Zames has joined #openstack-nova00:45
*** Zames has quit IRC00:47
*** acormier has joined #openstack-nova00:58
*** yamamoto has joined #openstack-nova01:03
*** dave-mccowan has joined #openstack-nova01:05
*** tiendc has joined #openstack-nova01:07
*** yamamoto has quit IRC01:08
*** slaweq has joined #openstack-nova01:17
*** tiendc has quit IRC01:17
*** tiendc has joined #openstack-nova01:19
*** slaweq has quit IRC01:21
*** acormier has quit IRC01:22
*** acormier has joined #openstack-nova01:22
*** takashin has quit IRC01:23
*** hshiina has joined #openstack-nova01:28
*** stakeda has joined #openstack-nova01:31
*** acormier has quit IRC01:35
*** rcernin has quit IRC01:36
*** rcernin has joined #openstack-nova01:36
*** rcernin has quit IRC01:42
*** rcernin has joined #openstack-nova01:43
*** takashin has joined #openstack-nova01:47
*** sapd has joined #openstack-nova01:51
*** rcernin has quit IRC01:53
*** rcernin has joined #openstack-nova01:53
*** Zames has joined #openstack-nova01:53
*** slaweq has joined #openstack-nova01:54
*** slaweq has quit IRC01:59
*** salv-orl_ has joined #openstack-nova02:03
*** yamamoto has joined #openstack-nova02:04
*** salv-orlando has quit IRC02:07
*** hongbin has joined #openstack-nova02:08
*** yamamoto has quit IRC02:09
*** yamahata has quit IRC02:15
*** phuongnh has joined #openstack-nova02:21
*** hiro-kobayashi has joined #openstack-nova02:24
*** annp has joined #openstack-nova02:28
*** harlowja_ has quit IRC02:28
*** Zames has quit IRC02:40
openstackgerritMohammed Naser proposed openstack/nova master: Add functional test for deleting BFV server with old attach flow  https://review.openstack.org/54631502:45
openstackgerritMohammed Naser proposed openstack/nova master: Check if attachment_id exists before deleting it  https://review.openstack.org/54639802:45
*** links has joined #openstack-nova02:49
*** Zames has joined #openstack-nova02:55
*** slaweq has joined #openstack-nova02:58
*** Zames has quit IRC03:00
*** slaweq has quit IRC03:03
*** yamamoto has joined #openstack-nova03:06
*** yamamoto has quit IRC03:11
*** akki__ has quit IRC03:16
openstackgerritMerged openstack/nova master: Clean up ports and volumes when deleting ERROR instance  https://review.openstack.org/34061403:17
*** AlexeyAbashkin has joined #openstack-nova03:23
*** AlexeyAbashkin has quit IRC03:27
*** takashin has quit IRC03:27
*** sree_ has joined #openstack-nova03:29
*** sree_ is now known as Guest3192203:30
*** udesale has joined #openstack-nova03:36
*** abhishekk has joined #openstack-nova03:37
*** udesale has quit IRC03:38
*** liverpooler has joined #openstack-nova03:39
*** udesale has joined #openstack-nova03:39
*** lbragstad has joined #openstack-nova03:43
openstackgerritTakashi NATSUME proposed openstack/nova-specs master: Add force flag in cold migration  https://review.openstack.org/54648203:44
*** abhishekk has quit IRC03:46
*** abhishekk has joined #openstack-nova03:47
*** liverpooler has quit IRC03:48
*** slaweq has joined #openstack-nova03:54
*** udesale has quit IRC03:55
*** yamahata has joined #openstack-nova03:59
*** slaweq has quit IRC03:59
*** abhishekk has quit IRC04:01
*** larsks has joined #openstack-nova04:03
*** gongysh has joined #openstack-nova04:05
*** yamamoto has joined #openstack-nova04:07
openstackgerritTakashi NATSUME proposed openstack/nova-specs master: Change a validation in creating a server group  https://review.openstack.org/54648404:10
*** takashin has joined #openstack-nova04:10
*** slaweq has joined #openstack-nova04:13
*** yamamoto has quit IRC04:13
*** masahisa has quit IRC04:15
*** masahisa has joined #openstack-nova04:16
*** slaweq has quit IRC04:17
*** AlexeyAbashkin has joined #openstack-nova04:22
*** annp has quit IRC04:23
*** tiendc has quit IRC04:23
*** phuongnh has quit IRC04:23
*** phuongnh has joined #openstack-nova04:23
*** tiendc has joined #openstack-nova04:23
*** annp has joined #openstack-nova04:23
*** AlexeyAbashkin has quit IRC04:26
*** psachin`` has joined #openstack-nova04:34
*** dave-mccowan has quit IRC04:34
*** acormier has joined #openstack-nova04:36
*** esberglu has quit IRC04:37
*** acormier has quit IRC04:40
*** hongbin has quit IRC04:56
*** abhishekk has joined #openstack-nova05:03
*** yamamoto has joined #openstack-nova05:04
*** psachin`` has quit IRC05:05
*** mdnadeem has joined #openstack-nova05:06
*** moshele has joined #openstack-nova05:08
*** fragatina has joined #openstack-nova05:10
*** udesale has joined #openstack-nova05:14
*** moshele has quit IRC05:15
*** masahisa has quit IRC05:24
*** gyee has quit IRC05:27
*** trinaths has joined #openstack-nova05:27
*** lbragstad has quit IRC05:28
*** slaweq has joined #openstack-nova05:30
*** claudiub has joined #openstack-nova05:32
*** slaweq has quit IRC05:34
*** sridharg has joined #openstack-nova05:35
*** takashin has left #openstack-nova05:40
*** janki has joined #openstack-nova05:42
openstackgerritMerged openstack/nova master: Add functional recreate test of deleting a BFV server pre-scheduling  https://review.openstack.org/54512305:43
*** damien_r has quit IRC05:44
*** lpetrut has joined #openstack-nova05:48
openstackgerritTakashi NATSUME proposed openstack/nova master: [placement] api-ref: Fix a missing response code  https://review.openstack.org/54649405:48
*** yamamoto has quit IRC05:51
*** vladikr_ has quit IRC05:54
*** gongysh has quit IRC05:54
*** Dinesh_Bhor has joined #openstack-nova05:57
*** damien_r has joined #openstack-nova05:58
*** vivsoni_ has joined #openstack-nova06:02
*** yamamoto has joined #openstack-nova06:02
*** vivsoni has quit IRC06:02
*** Dinesh__Bhor has joined #openstack-nova06:03
*** moshele has joined #openstack-nova06:04
*** sidx64 has joined #openstack-nova06:04
*** Dinesh__Bhor has quit IRC06:05
*** Dinesh_Bhor has quit IRC06:06
openstackgerritMerged openstack/nova master: Detach volumes when deleting a BFV server pre-scheduling  https://review.openstack.org/54513206:06
*** vladikr_ has joined #openstack-nova06:07
*** vivsoni_ has quit IRC06:10
*** vivsoni has joined #openstack-nova06:11
*** vladikr_ has quit IRC06:16
*** Dinesh__Bhor has joined #openstack-nova06:18
*** psachin`` has joined #openstack-nova06:22
*** Dinesh__Bhor has quit IRC06:25
openstackgerritSilvan Kaiser proposed openstack/nova master: [WIP] Added Qemu libquobyte Support to the Quobyte Driver  https://review.openstack.org/54650006:26
*** vladikr_ has joined #openstack-nova06:29
*** Zames has joined #openstack-nova06:31
*** vladikr_ has quit IRC06:37
*** Eran_Kuris has joined #openstack-nova06:37
*** Dinesh__Bhor has joined #openstack-nova06:38
*** Zames has quit IRC06:42
*** Dinesh__Bhor has quit IRC06:44
*** Dinesh__Bhor has joined #openstack-nova06:46
*** vladikr_ has joined #openstack-nova06:48
*** lpetrut has quit IRC06:48
*** udesale_ has joined #openstack-nova06:54
*** udesale_ has quit IRC06:56
*** udesale_ has joined #openstack-nova06:56
*** udesale has quit IRC06:58
*** Dinesh__Bhor has quit IRC06:58
*** Dinesh__Bhor has joined #openstack-nova06:59
*** hiro-kobayashi has quit IRC07:01
*** udesale_ has quit IRC07:02
*** udesale has joined #openstack-nova07:02
*** kholkina_ has joined #openstack-nova07:11
*** yangyape_ has quit IRC07:11
*** yangyapeng has joined #openstack-nova07:12
*** chyka has joined #openstack-nova07:13
*** Dinesh__Bhor has quit IRC07:17
*** yangyapeng has quit IRC07:17
*** chyka has quit IRC07:18
*** andreas_s has joined #openstack-nova07:18
*** rcernin has quit IRC07:21
*** Dinesh__Bhor has joined #openstack-nova07:28
*** sahid has joined #openstack-nova07:31
*** yamahata has quit IRC07:34
*** sidx64 has quit IRC07:34
*** sidx64 has joined #openstack-nova07:36
*** slaweq has joined #openstack-nova07:38
*** fragatina has quit IRC07:41
*** udesale_ has joined #openstack-nova07:43
*** udesale has quit IRC07:44
*** hoonetorg has quit IRC07:46
*** ragiman has joined #openstack-nova07:46
*** pcaruana has joined #openstack-nova07:47
*** fragatina has joined #openstack-nova07:50
*** psachin`` has quit IRC07:54
*** alexchadin has joined #openstack-nova07:54
*** fragatina has quit IRC07:54
*** lpetrut has joined #openstack-nova07:56
*** psachin has joined #openstack-nova07:57
*** Hazelesque has quit IRC07:57
*** sidx64 has quit IRC07:58
*** Hazelesque has joined #openstack-nova07:59
*** hoonetorg has joined #openstack-nova08:00
*** sidx64 has joined #openstack-nova08:00
*** Dinesh__Bhor has quit IRC08:03
*** fragatina has joined #openstack-nova08:06
*** Dinesh__Bhor has joined #openstack-nova08:07
*** amoralej|off is now known as amoralej08:08
*** fragatina has quit IRC08:08
*** tssurya has joined #openstack-nova08:09
*** fragatina has joined #openstack-nova08:09
*** udesale_ is now known as udesale08:09
*** damien_r has quit IRC08:10
*** fragatina has quit IRC08:13
*** Dinesh__Bhor has quit IRC08:14
*** masahisa has joined #openstack-nova08:15
*** Dinesh__Bhor has joined #openstack-nova08:16
*** sapd_ has joined #openstack-nova08:17
*** sapd_ has quit IRC08:17
*** ccamacho has joined #openstack-nova08:19
*** sidx64 has quit IRC08:19
*** AlexeyAbashkin has joined #openstack-nova08:22
*** Dinesh__Bhor has quit IRC08:22
*** slaweq_ has joined #openstack-nova08:23
*** Dinesh__Bhor has joined #openstack-nova08:23
openstackgerritHamdy Khader proposed openstack/nova master: Adding NVMEoF for libvirt driver  https://review.openstack.org/48264008:24
*** sshwarts has joined #openstack-nova08:25
*** Zames has joined #openstack-nova08:26
*** Dinesh__Bhor has quit IRC08:27
*** slaweq_ has quit IRC08:28
*** Dinesh__Bhor has joined #openstack-nova08:32
*** tesseract has joined #openstack-nova08:34
*** Eran_Kuris has quit IRC08:37
*** yamahata has joined #openstack-nova08:37
*** Eran_Kuris has joined #openstack-nova08:39
*** rmart04 has joined #openstack-nova08:40
*** psachin has quit IRC08:40
*** abhishekk is now known as abhishekk|away08:46
*** jehane has joined #openstack-nova08:48
*** alexchadin has quit IRC08:50
*** alexchadin has joined #openstack-nova08:51
*** psachin has joined #openstack-nova08:51
jehaneHi, I have a question about CPU-Pinning08:51
jehaneI have setup some flavors enabled for CPU Pinning and they work fine08:51
jehaneBut when I create a flavor using more ressources than a nova cell, it never work ( error : no ressources available when I try to launch the instance)08:52
jehanedo you think I miss something when setting up CPU Pinning or is it normal ?08:53
jehane(not nova cell, NUMA Cell sorry)08:53
*** ralonsoh has joined #openstack-nova08:53
*** jpena|off is now known as jpena08:53
*** Zames has quit IRC08:59
*** moshele has quit IRC08:59
*** trinaths has quit IRC08:59
*** trinaths has joined #openstack-nova09:02
tetsurojehane: it is normal because with pinning feature, the host’s NUMA Cell architecture is reflected to instance NUMA Cell architecture.09:11
tetsurojethane: see https://docs.openstack.org/nova/latest/user/flavors.html#extra-specs-numa-topology and try  openstack flavor set FLAVOR-NAME --property hw:numa_nodes=209:11
openstackgerritNguyen Hung Phuong proposed openstack/python-novaclient master: Clean imports in code  https://review.openstack.org/54654309:11
*** tetsuro has left #openstack-nova09:11
*** sidx64 has joined #openstack-nova09:12
*** hamzy_ has joined #openstack-nova09:17
*** Zames has joined #openstack-nova09:18
*** hamzy has quit IRC09:19
*** mgoddard_ has joined #openstack-nova09:19
*** cdent has joined #openstack-nova09:22
*** stvnoyes has joined #openstack-nova09:23
jehanethanks09:24
*** vipuls has quit IRC09:31
*** Zames has quit IRC09:33
*** vipul has joined #openstack-nova09:33
*** derekh has joined #openstack-nova09:39
*** trozet has quit IRC09:45
*** Dinesh__Bhor has quit IRC09:46
*** trozet has joined #openstack-nova09:46
*** alexchadin has quit IRC09:50
*** alexchadin has joined #openstack-nova09:50
*** Zames has joined #openstack-nova09:52
*** abhishekk|away is now known as abhishekk09:55
*** cgoncalves has quit IRC09:57
openstackgerritsahid proposed openstack/nova-specs master: update: introducing isolate emulthreads on host  https://review.openstack.org/51118809:59
*** dtantsur|afk is now known as dtantsur10:02
*** pcaruana has quit IRC10:05
*** sridharg has quit IRC10:10
openstackgerritsahid proposed openstack/nova-specs master: libvirt: add support for virtio-net rx/tx queue sizes  https://review.openstack.org/53960510:10
*** pcaruana has joined #openstack-nova10:20
*** yamahata has quit IRC10:22
*** annp has quit IRC10:25
*** Guest31922 has quit IRC10:26
*** sidx64 has quit IRC10:26
*** abhishekk has quit IRC10:26
*** stakeda has quit IRC10:26
*** sree_ has joined #openstack-nova10:27
*** sree_ is now known as Guest9536210:27
*** sidx64 has joined #openstack-nova10:30
*** Guest95362 has quit IRC10:31
*** sidx64 has quit IRC10:31
*** priteau has joined #openstack-nova10:34
*** sidx64 has joined #openstack-nova10:34
*** Zames has quit IRC10:36
*** acormier has joined #openstack-nova10:37
sahidsean-k-mooney: any idea whether we should fix it or not? https://bugs.launchpad.net/nova/+bug/167062810:37
openstackLaunchpad bug 1670628 in OpenStack Compute (nova) "nova-compute will try to re-plug the vif even if it exists for vhostuser port." [Undecided,Opinion]10:37
*** acormier has quit IRC10:41
*** sidx64 has quit IRC10:46
*** alexchadin has quit IRC10:48
*** sidx64 has joined #openstack-nova10:49
*** sridharg has joined #openstack-nova10:55
*** Zames has joined #openstack-nova11:02
*** phuongnh has quit IRC11:04
*** manjeets has quit IRC11:05
*** manjeets has joined #openstack-nova11:06
openstackgerritRajesh Tailor proposed openstack/nova master: Reset instance status on invalid host  https://review.openstack.org/40100911:09
*** Zames has quit IRC11:10
*** tiendc has quit IRC11:12
*** pcaruana has quit IRC11:19
openstackgerritShoham Peller proposed openstack/nova master: Handle spawning error on unshelving  https://review.openstack.org/37800911:23
*** acormier has joined #openstack-nova11:25
*** acormier has quit IRC11:26
*** acormier has joined #openstack-nova11:26
*** acormier has quit IRC11:27
*** acormier has joined #openstack-nova11:27
*** Zames has joined #openstack-nova11:29
openstackgerritShoham Peller proposed openstack/nova master: Handle spawning error on unshelving  https://review.openstack.org/37800911:31
*** acormier has quit IRC11:32
*** moshele has joined #openstack-nova11:32
*** pcaruana has joined #openstack-nova11:33
*** Lingwu has quit IRC11:33
*** moshele has quit IRC11:35
*** Lingwu has joined #openstack-nova11:36
*** moshele has joined #openstack-nova11:38
*** udesale has quit IRC11:39
*** yamamoto has quit IRC11:41
*** Zames has quit IRC11:44
*** cdent has quit IRC11:51
*** alexchadin has joined #openstack-nova11:56
*** sahid has quit IRC11:57
*** ragiman has quit IRC11:58
*** janki has quit IRC12:07
*** sahid has joined #openstack-nova12:07
*** gongysh has joined #openstack-nova12:12
*** gongysh has quit IRC12:13
*** acormier has joined #openstack-nova12:16
*** jmlowe has quit IRC12:18
*** jmlowe has joined #openstack-nova12:18
*** ericyoung has quit IRC12:19
*** mgagne has quit IRC12:19
sean-k-mooneysahid: just looking now12:19
*** d34dh0r53 has quit IRC12:20
*** toan has quit IRC12:20
*** ericyoung has joined #openstack-nova12:20
sean-k-mooneysahid: first taught is that restarting nova-compute should not result in plug being called but still reading12:20
*** evrardjp has quit IRC12:22
*** McNinja_ has quit IRC12:22
*** fnordahl has quit IRC12:22
*** fnordahl has joined #openstack-nova12:23
*** acormier has quit IRC12:23
sahidsean-k-mooney: that it's too big change, we don't know the impact12:24
sahidcurrently we know that, deleting the port is affecting dpdkvhostuser12:24
sean-k-mooneysahid: but that is a bug in its own right plug is only ment to be called on boot or interface attach12:24
sahidit depends on the vif type12:25
sean-k-mooneyrestarting the nova-compute agent should never effect the vm datapath12:25
*** acormier has joined #openstack-nova12:25
sahidi have no idea why we have this code in nova to call plug vifs for all instanes after a restart12:25
sean-k-mooneyin its current form upgrading the nova compute deamon on a host with ovs-dpdk will breack connectivity12:25
sahidthe point i'm not going to remove that since i do not know the impact12:25
*** evrardjp has joined #openstack-nova12:26
*** d34dh0r53 has joined #openstack-nova12:26
sahidit's something that can be work for a long term perspective12:26
sean-k-mooneythe code in os-vif was written that way to allow ports to be moved to different bridge fov the vlan aware vms spec12:26
sean-k-mooneythats why its not jsut add-port --may-exists and instead we do a del-port followed by add-port in a singel transaction12:27
*** toan has joined #openstack-nova12:27
sahidyes but that is not going to work for a type dpdkvhostuser12:27
*** moshele has quit IRC12:28
sahidthe instance is going to lost the connecctivity if we delete the socket12:28
sean-k-mooneyit should as ovs used to do this atomically and not remove and read the port ovs was already in the desired state12:28
sahidnot sure i understand what you are saying12:29
*** moshele has joined #openstack-nova12:29
sahiddo you understand the issue here?12:29
sean-k-mooneywell the socket is not useed for vm traffic but ovs  is not ment to be deleting the socket in this case.12:29
sean-k-mooneysahid: yes i understand the issue but not why its happening12:29
sean-k-mooneyone of the requirement i had for our ovs team when vhost-user was added was that doing a del-port followed by add port of the same port in a trasaction would not impact the datapath and become a noop12:30
sahidi see your point now12:31
*** sridharg has quit IRC12:32
sean-k-mooneywe could try chainging to ovs-vsctl add-port --may-exist instead but not sure if that will prevent changing neuton port into trunk ports introduced in the vlan aware vms specs12:33
sean-k-mooneythat is the only thing i can think of that could be effect by that change and it would resolve the issue12:33
sean-k-mooneywe do have patchs form rodolfo that may or may not have merged that uses the python ovs client lib which may not have this issue also12:34
sahidsean-k-mooney: in your idea this issue is only for dpdkvhostuser or so you think we have the same for dpdkvhostuserclient?12:34
sean-k-mooneyi think we have the same issue for dpdkvhostuserclient but vhost reconnect is masking it.12:35
sean-k-mooneydpdkvhostuser dose not suppport recoonect so it needs a vm reboot to fix12:35
*** sidx64 has quit IRC12:35
sean-k-mooneyfor dpdkvhostuserclient the unix socket is created by qemu so it is definetly not deleted12:36
sahidso this issue does not exist for dpdkvhostuserclient12:36
*** sridharg has joined #openstack-nova12:36
*** mgagne has joined #openstack-nova12:36
*** trinaths has quit IRC12:36
*** mgagne is now known as Guest2094612:36
sean-k-mooneysahid: i cant say 100% with out testing but i think it would be significatly less likely to happen12:37
sahidthat is also my thinking12:37
sahidso i don't know whether we really want to fix that12:37
sahidstarts to ocata we are using dpdkvhostuserclient12:37
sahidand i think dpdkvhostuser is deprecated, right?12:37
sean-k-mooneysahid: well we are using dpdkvhostuserclient if ovs is new enough12:38
sean-k-mooneydpdkvhostuser is not but dpdkvhostcuse was and has been removed12:38
sean-k-mooneydpdkvhostuser is just not recommended but no one has pushed for removal/deprecation yet as far as i know12:38
sahidoh yes we are looking at the capabilities to know which one to user12:39
sahiduse12:39
*** McNinja has joined #openstack-nova12:39
sahidok so let fix it12:39
*** jpena is now known as jpena|lunch12:39
sean-k-mooneyfor ovs-vsctl its should be a 2 line fix. want me to trow up a patch12:39
*** acormier has quit IRC12:40
*** acormier has joined #openstack-nova12:40
sahidno worries i will do i have also a env to test it12:40
sahidsean-k-mooney: will ping you when it's sent upstrea12:41
*** yamamoto has joined #openstack-nova12:42
sean-k-mooneycool it should just be changing "'--if-exists', 'del-port', dev, '--','add-port'" -> "'add-port','--may-exist'" https://github.com/openstack/os-vif/blob/master/vif_plug_ovs/linux_net.py#L68 and maybe updating some unit tests12:42
*** acormier has quit IRC12:42
sean-k-mooneyactully the --may-exists possibly goes before add-port but youll figure it out12:43
openstackgerritSurya Seetharaman proposed openstack/nova master: Unmap compute nodes when deleting host mappings in delete cell operation  https://review.openstack.org/54296412:44
*** BryanS68 has joined #openstack-nova12:45
*** sidx64 has joined #openstack-nova12:47
*** melwitt has quit IRC12:47
*** sidx64 has quit IRC12:48
*** yamamoto has quit IRC12:49
*** yamamoto has joined #openstack-nova12:51
*** sidx64 has joined #openstack-nova12:52
*** melwitt has joined #openstack-nova12:52
*** acormier has joined #openstack-nova12:59
*** sidx64 has quit IRC12:59
*** sidx64 has joined #openstack-nova13:00
*** vladikr_ has quit IRC13:04
*** weshay_PTO is now known as weshay13:04
*** BryanS68 has quit IRC13:06
*** ansiwen has quit IRC13:06
*** mdbooth has quit IRC13:06
*** BryanS68 has joined #openstack-nova13:06
*** sidx64 has quit IRC13:08
*** dave-mccowan has joined #openstack-nova13:09
*** mdbooth has joined #openstack-nova13:11
*** ansiwen has joined #openstack-nova13:11
openstackgerritsahid proposed openstack/os-vif master: ovs: do not delete port if already exists  https://review.openstack.org/54658813:15
*** ratailor has joined #openstack-nova13:16
*** pchavva1 has joined #openstack-nova13:18
sahidsean-k-mooney: ^ i still need to test it but if you want to have a llok13:20
*** janki has joined #openstack-nova13:21
*** alexchadin has quit IRC13:27
*** amoralej is now known as amoralej|lunch13:28
*** alexchadin has joined #openstack-nova13:28
*** cdent has joined #openstack-nova13:32
*** alexchadin has quit IRC13:35
*** liverpooler has joined #openstack-nova13:40
*** jpena|lunch is now known as jpena13:44
*** Eran_Kuris has quit IRC13:46
openstackgerritShoham Peller proposed openstack/nova master: Handle spawning error on unshelving  https://review.openstack.org/37800913:46
*** ratailor has quit IRC13:49
*** hshiina is now known as hshiina|afk13:50
*** tylerderosagrund has joined #openstack-nova13:52
*** tylerderosagrund has joined #openstack-nova13:52
*** efried is now known as efried_omalley13:53
*** acormier has quit IRC13:53
*** tylerderosagrund has quit IRC13:53
*** danpawlik has quit IRC13:53
*** psachin has quit IRC13:54
*** tylerderosagrund has joined #openstack-nova13:55
*** tylerderosagrund has joined #openstack-nova13:55
*** tylerderosagrund is now known as tylerdero13:55
*** tbachman has joined #openstack-nova13:56
*** alexchadin has joined #openstack-nova13:57
*** tylerdero is now known as tylerderosagrund13:57
*** mriedem has joined #openstack-nova13:58
*** Eran_Kuris has joined #openstack-nova14:01
*** amoralej|lunch is now known as amoralej14:01
*** lyan has joined #openstack-nova14:02
*** sahid has quit IRC14:06
*** sahid has joined #openstack-nova14:07
*** moshele has quit IRC14:09
*** bhujay has joined #openstack-nova14:13
*** lbragstad has joined #openstack-nova14:15
openstackgerritKashyap Chamarthy proposed openstack/nova master: [WIP] libvirt: Allow to specify granular CPU feature flags  https://review.openstack.org/53438414:15
*** srf has joined #openstack-nova14:17
mriedemmnaser: some comments / thoughts in https://review.openstack.org/#/c/546398/14:20
*** jackie-truong has joined #openstack-nova14:23
mnasermriedem: if i bdm.attachment_id = None .. that means that i can drop 'attachment_id' in bdm ?14:24
mnaserand i can change the test to make sure that i always get an attachment that is =None i guess?14:24
mnaserthat does feel like a much cleaner fix because then we won't carry the extra cruft of an issue that exists in the old flow of attachment which will one day disappear14:25
mriedemmnaser: i think that is true...14:26
mnasermriedem: i have a functional test so ill make the change and see if it does address it14:26
mriedemthe only time we do a local delete in the api and the bdm.attachment_id wouldn't be set is this pre-scheduling thing where we delete the instance via the build_request14:27
mnasermriedem: and if i understand correctly, the bdms we get from the build_request are not persisted in db so they don't have an attachment_id14:27
mriedemif the bdm does exist in a cell database, when the api loads it out, it will set bdm.attachment_id b/c of whatever is in the db record14:27
*** hshiina|afk has quit IRC14:27
mriedemthey aren't persisted in a cell block_device_mappings table,14:28
mriedemthey are serialized as a json blob (like the instance) and stored in the nova_api.build_requests table14:28
mnasergotcha14:28
mriedemwhich means, when we load them into the object, we don't set any default field values from the actual db record14:28
sahidmriedem: any chance you ack this: https://review.openstack.org/#/c/515008/ ?14:28
mriedemlike if we load up a bdm record created 3 years ago, the attachment_id entry will be null and we'll set that on the object14:28
*** esberglu has joined #openstack-nova14:29
mnasermriedem: ok, so but if we did change the behaviour to set a default value, i assume that would involve bumping the object version which wouldn't make it very backportable14:29
*** links has quit IRC14:29
mriedemmnaser: no i'm not suggesting we change the object at all14:29
mnasermriedem: oh i know, i'm just thinking out loud14:29
mriedemok14:29
mnasertrying to understand nova's codebase a tad bit more14:29
*** mdnadeem has quit IRC14:29
mnaseranyways im going to test out your idea and see if it passes locally14:30
*** sahid has quit IRC14:30
*** tbachman has quit IRC14:31
*** sree_ has joined #openstack-nova14:31
*** sree_ is now known as Guest4446714:31
*** tylerderosagrund has quit IRC14:33
*** tylerderosagrund has joined #openstack-nova14:34
efried_omalleyYe gods, even reading just the *titles* of 882 summit talks is a labor of hours.14:34
sean-k-mooneysahid: im not sure if the intel nfv ci is triggering on os-vif. it should be triggering on any change to nova,neutron,os-vif,networking-ovs-dpdk and devstack but if it is that will do some validation of https://review.openstack.org/#/c/546588/14:35
openstackgerritRajesh Tailor proposed openstack/nova master: Reset instance status on invalid host  https://review.openstack.org/40100914:37
*** psachin has joined #openstack-nova14:37
sean-k-mooneysahid: zuul seams to be happy with it so that is a good sign.14:37
mriedemlyarwood: since sahid left, question in https://review.openstack.org/#/c/515008/14:38
*** srf has quit IRC14:38
*** jackie-truong has quit IRC14:39
mriedemlyarwood: i mean, i guess the patch is ok in that if one thing fails the user has to retry (either updating the guest xml or the disconnect from the host) and either thing is now idempotent14:40
mriedemjust seems like you'd want to try the cleanup thing that's more likely to fail first14:40
dansmithmriedem: trivial review to correct a stack trace in logs that confused multiple support people: https://review.openstack.org/#/c/546423/14:41
jaypipesefried_omalley: I can shortcut that for you. "Edge", "NFV", "Hyperconverged", "Kubernetes". Rinse and repeat.14:42
mriedemdansmith: timely given i'm asking about https://review.openstack.org/#/c/515008/14:42
dansmithhah14:42
efried_omalleyjaypipes: Yeah, would be nice to have a list of checkboxes like Amazon does, where I could exclude those terms and filter down to the 20 or so talks that might interest me.14:43
* jaypipes goes back to listening to Jefferson Airplane and imagining he lived in a world before clouds.14:43
dansmithjaypipes: lol14:44
dansmithjaypipes: early or late?14:44
jaypipesdansmith: early of course.14:44
dansmithjaypipes: good, just checking.14:44
*** eharney has joined #openstack-nova14:44
jaypipesdansmith: you know... pre-cloud.14:44
mnaserwow i just realized this bug has 3 paths, < BFV_RESERVE_MIN_COMPUTE_VERSION --> _check_attach (reserves), >= BFV_RESERVE_MIN_COMPUTE_VERSION -> _check_attach_and_reserve_volume (can reserve if cinder version is too old), >= CINDER_V3_ATTACH_MIN_COMPUTE_VERSION -> _check_attach_and_reserve_volume (will create attachment)14:45
dansmithjaypipes: even the ultra-modern starship days were pre-cloud, so I had to ask14:45
* mnaser sighs14:45
sean-k-mooneyjaypipes: im trying to think of something you missed but yep i think those 4 buzz words some it up well maybe add "serverless" of "FaaS"14:45
mnaserso we reserve a volume in the _check_attach_and_reserve_volume path too14:45
mnaser(or we could)14:45
mnaserOH and also if the cinder api doesn't support attachments it will reserve too14:46
*** cfriesen has quit IRC14:46
jaypipessean-k-mooney: I think you meant "FaaD".14:46
* lyarwood catches up14:51
dansmithmriedem: I think I answered your question on that patch14:51
*** jackie-truong has joined #openstack-nova14:52
lyarwoodmriedem: https://review.openstack.org/#/c/515008/13/nova/virt/libvirt/driver.py@1555 - otherwise we'd likely see QEMU getting into D state if the instance attempts to write to the underlying storage after we've disconnected it from the compute14:52
dansmithlyarwood: if it even lets us disconnect14:53
*** sahid has joined #openstack-nova14:53
lyarwoodright14:53
dansmithI would expect it to always fail,14:53
dansmithunless we're echoing into sdX/delete in sysfs14:53
*** Eran_Kuris has quit IRC14:53
*** felipemonteiro has joined #openstack-nova14:53
lyarwoodyeah there are some backends in os-brick that force things to disconnect like that14:53
dansmithack14:53
dansmiththen that would be like bad and stuff :D14:54
mriedemok +2 on sahid's14:54
mriedem-1 on dansmith's14:54
dansmithmriedem: raising from there isn't putting the instance into error state,14:55
dansmithbut you're saying it does get a fault?14:55
mriedemi never said it would be put into error state14:55
mriedembut yes there is (1) a fault recorded and (2) the instance action event record is marked as failed14:55
mriedemwhich are ways for an api user to track the detach volume operation in nova14:55
dansmithI know you didn't, but I thought we didn't record a fault unless we put it into error state14:55
mriedemnope14:55
*** bhujay has quit IRC14:55
mriedemit's anytime a compute manager method raises an unhandled exception14:56
*** alexchadin has quit IRC14:56
dansmithokay, so the two people that hit this yesterday weren't looking at faults14:56
dansmithit just never happened,14:56
dansmithand then they saw the trace in the log14:56
*** fragatina has joined #openstack-nova14:56
openstackgerritsahid proposed openstack/nova stable/queens: libvirt: disconnect volume from host during detach  https://review.openstack.org/54665514:57
mriedemfrom what i'm reading in the bug, they are just saying, 'don't traceback, give me a useful message'14:57
dansmithright14:57
mriedemyour patch is doing the useful message, but then saying the detach was successful14:57
mriedemby returning14:57
*** awaugama has joined #openstack-nova14:58
dansmithmriedem: returning isn't saying it's successful because the volume is still attached, but I see your point14:58
mriedemwell, success as in masking the failure14:58
dansmithhaving to poll the volume status and then poll instance faults if it doesn't detach in a while is obscure14:58
mriedemthey can poll the action record14:59
mriedemmore than the fault14:59
mriedemif the action fails, check the fault for why14:59
dansmithit's just not what people do I think14:59
mriedemalthough we also store that in the instance action event record, but you can only see the traceback there (like a fault) if you're an admin14:59
dansmiththey do a thing, they expect it to work14:59
mriedemsure, but you see that with this patch, we fail, and return, we don't record a fault or say the action failed via the instance action record15:00
mriedemwhereas before we would15:00
mriedemif the bug is just "don't log a traceback because that's not helpful" we can handle that15:00
dansmithno, I get that this removes a fault that was being added before15:00
dansmithI'm not arguing against fixing that,15:01
dansmithI'm just ruminating about two separate support engineers (and me) not even thinking about polling for the action or fault15:01
dansmithI guess this also deletes the bdm if we don't raise15:02
mriedemwhich then means you can't try to detach it again..15:02
dansmithyeah15:02
mriedemlyarwood would say you'd be proper fucked15:03
mriedemi assume15:03
lyarwoodrather15:04
dansmithhmm, we have no tests for that driver_detach method?15:05
mriedemin DriverVolumeBlockDevice?15:06
dansmithyeah15:06
mriedemthey'd likely be in nova.tests.unit.virt.test_block_device, which is mox city15:06
dansmithright, but I don't see any15:06
*** felipemonteiro has quit IRC15:06
mriedemcould also be some tests in the old nova.tests.unit.compute.test_compute that didn't get ported,15:06
mriedemthat driver_detach code used to live in the compute manager15:07
mriedemlyarwood moved it over15:07
mriedemnot sure all the tests made the journey15:07
dansmithgrep driver_detach -r nova/tests/unit/virt/15:07
dansmithreturns nothing15:07
mriedemb/c it's a compute manager thing15:07
mriedemit's not a virt driver thing15:07
dansmitheh?15:07
mriedemit's like everything else in nova.virt.block_device,15:07
mriedemit's an extension of the compute manager15:07
dansmithtest_block_device is in there15:07
*** srf has joined #openstack-nova15:08
*** psachin has quit IRC15:08
*** cfriesen has joined #openstack-nova15:08
dansmith# TODO(lyarwood): Test DriverVolumeBlockDevice.driver_detach in15:08
mriedemi know, it's called that because that's what ndipanov called the driver-view bdm wrapper object things or whatever15:08
mriedembingo15:08
dansmithI see no unmocked calls of it in compute/ either15:08
*** burt has joined #openstack-nova15:08
*** tbachman has joined #openstack-nova15:09
mriedemyou can be the first one15:09
*** psachin has joined #openstack-nova15:10
dansmithand I shall15:10
*** moshele has joined #openstack-nova15:12
*** edleafe has quit IRC15:12
openstackgerritSurya Seetharaman proposed openstack/nova master: Purge comp_node and res_prvdr records during deletion of cells/hosts  https://review.openstack.org/54666015:12
*** tylerderosagrund has quit IRC15:12
*** edleafe has joined #openstack-nova15:13
*** tylerderosagrund has joined #openstack-nova15:13
*** tylerderosagrund has quit IRC15:13
*** tylerderosagrund has joined #openstack-nova15:13
mriedemjaypipes: dansmith: bauzas: i assume you all would be very much -1 on this also https://review.openstack.org/#/c/546482/15:14
*** acormier has joined #openstack-nova15:14
mriedemi'm actually pretty annoyed that's being proposed given it was already discussed in queens and we said no15:14
mriedemhttp://lists.openstack.org/pipermail/openstack-dev/2017-August/121654.html15:14
*** felipemonteiro has joined #openstack-nova15:14
*** dklyle has joined #openstack-nova15:15
*** jackie-truong has quit IRC15:15
*** jogo has quit IRC15:16
*** amodi has joined #openstack-nova15:16
*** david-lyle has quit IRC15:16
*** tidwellr has joined #openstack-nova15:18
mriedemanyone ever used SimpleScreenRecord in ubuntu?15:20
mriedem*SimpleScreenRecorder15:20
*** slaweq has quit IRC15:20
*** slaweq has joined #openstack-nova15:21
*** mlavalle has joined #openstack-nova15:24
*** yamahata has joined #openstack-nova15:24
*** Guest44467 has quit IRC15:25
*** slaweq has quit IRC15:26
*** psachin has quit IRC15:26
*** itlinux has joined #openstack-nova15:26
openstackgerritDan Smith proposed openstack/nova master: Avoid exploding if guest refuses to detach a volume  https://review.openstack.org/54642315:27
*** moshele has quit IRC15:27
* cdent wants a nova explode command15:27
dansmithmriedem: I haven't but sdague was using some broadcast studio thing to do some of that which might be useful15:28
*** psachin has joined #openstack-nova15:28
mriedemthe audio on this demo i did is super choppy,15:28
sean-k-mooneymriedem: the force flag for cold migrate?  can you rememebr why the instance had to be migrated to a specic host in this case and not jsut any other host15:28
mriedemso figured i need to play around with compression levels15:28
*** psachin has quit IRC15:29
mriedemsean-k-mooney: his spec says, 'because the scheduler kicked out the target host the admin requested'15:29
sean-k-mooneydansmith: probaly obs (open broadcasting studio)15:29
mriedemthe scheduler is likely kicking it out for good reason, force is a bad idea15:29
dansmithsean-k-mooney: yeah, sounds right15:29
mriedemhttps://obsproject.com/download ?15:29
sean-k-mooneymriedem: yep15:30
openstackgerritDan Smith proposed openstack/nova master: Avoid exploding if guest refuses to detach a volume  https://review.openstack.org/54642315:30
sean-k-mooneymriedem: its inteaded for live stream to things like twitch or youtube but it support local recoding too15:30
*** ccamacho has quit IRC15:31
mriedemok cool, if i can't figure out the audio issues on SSR i'll try this out15:31
dansmithmriedem: you just need to narrate over your existing video, right?15:31
dansmithyou can just record yourself to an audio file while watching the video and then mux in the audio with something like avidemux215:32
kashyapOr you can add subtitles file, if you have the patience15:32
*** yangyapeng has joined #openstack-nova15:32
openstackgerritMohammed Naser proposed openstack/nova master: Check if attachment_id exists before deleting it  https://review.openstack.org/54639815:33
sean-k-mooneydansmith: im guessing mriedem is also would prefer not to have to do any video editing. but ya you could use audacity to recored audio the mux them together as dan said15:33
mnasermriedem: ^ much cleaner fix, thats for your suggestions15:33
sean-k-mooney* as you said15:33
dansmithsean-k-mooney: I think he already has a video that demos what he wants, is my point15:33
mnaseroh i saw some comments you left after, let me address them15:33
mriedemi'd prefer to not have to do the audio separately,15:34
mriedemthe actual demo itself isn't hard to run through15:34
mriedemanyway, this will be my day now..15:34
sean-k-mooneymnaser: so ya back to the force cold migration i agree if the schduler elminated the node it should not be ignored or bad things can happen. the use case was for maintenance however so i dont know why you could not disable the host you wanted to do mantenance on then just migrate there instance to any other nodes15:35
mnasermriedem: ^ :)15:35
mnaserthat's probably for ya15:36
sean-k-mooneymnaser: hehe ya sorry15:39
sean-k-mooneyi asked the question in the spec. but i dont think there is a good answer/justificaiton for why you should bypass the schduler.15:39
*** kholkina_ has quit IRC15:42
*** tidwellr has quit IRC15:43
mriedemdansmith: one nit on that patch, let's throw the volume_id into the warning message, then i'm +215:44
*** jehane has left #openstack-nova15:45
openstackgerritMohammed Naser proposed openstack/nova master: Ensure attachment_id always exists for block device mapping  https://review.openstack.org/54639815:46
openstackgerritDan Smith proposed openstack/nova master: Avoid exploding if guest refuses to detach a volume  https://review.openstack.org/54642315:47
mnaserthere.. that should be it .. for now :>15:47
dansmithmriedem: ^15:47
*** tidwellr has joined #openstack-nova15:49
cfriesenmriedem: given your comment about the force flag for evacuate and live migrate...do we want to deprecate that?  :)  Or is that just a case of it being stuck with it since we'll have to keep the code around until/unless we bump the minimum API version?15:51
*** tbachman has quit IRC15:54
*** r-daneel has joined #openstack-nova15:54
*** ratailor has joined #openstack-nova15:55
*** yamamoto has quit IRC15:55
mriedemmnaser: ok +2 on that, with some musing comments in there for order of fixes15:56
mriedemcfriesen: the latter15:56
*** sridharg has quit IRC15:57
*** tbachman has joined #openstack-nova15:59
mnasermriedem: cool, thanks, once this merges ill reorder to get this fix in stable/pike just before yours so functional tests pass for all patches :>16:00
*** r-daneel_ has joined #openstack-nova16:01
*** artom has joined #openstack-nova16:02
*** r-daneel has quit IRC16:02
*** r-daneel_ is now known as r-daneel16:02
mriedemmnaser: sounds good, and that also takes care of my 'window of failure' worry in there16:03
mnasermriedem: oh you're right16:03
mriedemso yeah we likely want your fix here before my fix in the series of backports16:05
openstackgerritBence Romsics proposed openstack/osc-placement master: WIP skip (v1.13)  https://review.openstack.org/54667416:05
openstackgerritBence Romsics proposed openstack/osc-placement master: Add nested resource providers (v1.14)  https://review.openstack.org/54667516:05
*** pchavva1 is now known as pchavva16:06
*** felipemonteiro has quit IRC16:07
*** felipemonteiro has joined #openstack-nova16:07
*** janki has quit IRC16:09
*** amodi has quit IRC16:10
*** manjeets has quit IRC16:11
*** jogo has joined #openstack-nova16:13
*** hongbin has joined #openstack-nova16:14
*** pcaruana has quit IRC16:16
*** openstackgerrit has quit IRC16:19
*** tbachman has quit IRC16:21
*** openstackgerrit has joined #openstack-nova16:21
openstackgerritSurya Seetharaman proposed openstack/nova-specs master: Support disabling a cell  https://review.openstack.org/54668416:21
*** slaweq has joined #openstack-nova16:26
*** slaweq has quit IRC16:26
*** kukacz_ has joined #openstack-nova16:26
*** slaweq has joined #openstack-nova16:26
*** slaweq has quit IRC16:27
*** slaweq has joined #openstack-nova16:27
*** tbachman has joined #openstack-nova16:28
*** amodi has joined #openstack-nova16:28
*** kukacz_ is now known as kukacz16:29
*** sree_ has joined #openstack-nova16:31
*** sree_ is now known as Guest4169116:31
*** slaweq has quit IRC16:31
*** slaweq has joined #openstack-nova16:33
*** AlexeyAbashkin has quit IRC16:35
*** Guest41691 has quit IRC16:35
efried_omalleyEric Fried proposed openstack-infra/project-config master: Regex gerritbot notifications: #openstack-nova  https://review.openstack.org/54668916:36
mriedemildikov: think i resolved my audio problems16:37
*** tbachman has quit IRC16:37
ildikovmriedem: \o/ :)16:37
ildikovmriedem: I saw your mail, but couldn't get there yet to answer16:37
*** slaweq has quit IRC16:38
ildikovI wasn't sure whether that's the mic or the tool that you're using that messed the audio up16:38
mriedemit's the tool,16:38
mriedemi think i used the wrong compression settings16:38
*** slaweq has joined #openstack-nova16:38
ildikovit really would've been perfect if that's ok... :/16:38
mriedemoh i know16:39
*** yamahata has quit IRC16:39
ildikov;)16:39
ildikovcompression settings make sense16:39
mriedemi also realized it chopped of the left side of the screen where some of the command output is, which is not real useful in a demo16:39
mriedem*off16:39
ildikovoh; ok, I admit, I listened to the whole thing, but didn't always watch...16:40
*** moshele has joined #openstack-nova16:41
openstackgerritEric Berglund proposed openstack/nova master: Add check for redundant import aliases  https://review.openstack.org/54399516:42
*** r-daneel_ has joined #openstack-nova16:43
*** r-daneel has quit IRC16:44
*** r-daneel_ is now known as r-daneel16:44
*** slaweq has quit IRC16:44
*** slaweq has joined #openstack-nova16:44
*** slaweq has quit IRC16:44
*** john51 has quit IRC16:45
*** slaweq has joined #openstack-nova16:45
*** andreas_s has quit IRC16:46
*** srf has quit IRC16:48
*** tbachman has joined #openstack-nova16:48
*** john51 has joined #openstack-nova16:49
*** salv-orl_ has quit IRC16:49
*** slaweq has quit IRC16:50
*** salv-orlando has joined #openstack-nova16:50
*** tbachman_ has joined #openstack-nova16:51
jaypipesdoude: finally reviewed that patch. +2 from me, but question for you on there.16:52
cfriesenhas anyone ever seen a problem detaching a volume when shutting down an instance that results in a virDomainDetachDeviceFlags() failure with 'libvirtError: invalid argument: no target device vdd\n'16:52
doudeok jaypipes, thanks for your review. I'll try to answer your question16:53
*** tbachman has quit IRC16:53
*** tbachman_ is now known as tbachman16:53
*** salv-orlando has quit IRC16:54
*** sahid has quit IRC16:55
*** yamamoto has joined #openstack-nova16:56
*** moshele has quit IRC16:56
*** chyka has joined #openstack-nova17:00
*** sridharg has joined #openstack-nova17:01
jaypipesmriedem, dansmith, bauzas, melwitt: are we ready to pull the trigger on efried_omalley's https://review.openstack.org/#/c/540111/ update provider tree spec?17:02
*** yamamoto has quit IRC17:02
mriedemi'm +1 on it, wouldn't mind more feedback17:03
*** gyee has joined #openstack-nova17:04
openstackgerritMarcin Juszkiewicz proposed openstack/nova master: Allow to configure amount of PCIe ports  https://review.openstack.org/54503417:06
hrwjaypipes: thanks for review. all changes done17:07
*** dklyle has quit IRC17:08
jaypipeshrw: reviewed again.17:11
hrwops ;D17:12
jaypipes:)17:12
hrwside effect of working on patches during evening instead of morning17:13
jaypipesheh, understood.17:13
hrwjaypipes: all IntOpt options defaults to 0 - that's why I went that way17:13
*** felipemonteiro_ has joined #openstack-nova17:14
hrwjaypipes: as 'to 0 not to None'17:14
*** yamahata has joined #openstack-nova17:15
*** felipemonteiro has quit IRC17:16
jaypipeshrw: but if someone wanted to prevent *any* PCIe ports from being created, how would they indicate to actually create *0* ports?17:16
hrwjaypipes: if you want q35 you need to have pcie ports. if you do not set value then you will get them from libvirt17:17
hrwjaypipes: when you boot pcie machine (x86/q35, aarch64/virt) nowadays Nova adds video/disk/network/balloon/usb and gives it to libvirt. libvirt adds pcie ports and spawns guest.17:18
hrwjaypipes: my patch without num_pcie_ports set keeps current setup17:18
jaypipeshrw: yes, I understand that. but I'm asking how a user might ask for 0 PCIe ports to be created.17:19
hrwjaypipes: if you set it to "2" then resulting VM will probably do not work. if you set to 20 then you will get 10-15 free slots17:19
hrwjaypipes: 0 pcie ports == unbootable machine17:19
hrwunless all you want is uefi shell on serial port17:19
hrwand if you want such setup then nova is at least one layer too high17:20
hrwjaypipes: I probably should expand option's comment17:21
*** ratailor has quit IRC17:22
*** BryanS68 has quit IRC17:26
*** BryanS68 has joined #openstack-nova17:27
*** dikonoor has joined #openstack-nova17:27
*** imacdonn has quit IRC17:27
*** imacdonn has joined #openstack-nova17:27
*** BryanS68 has quit IRC17:28
*** BryanS68 has joined #openstack-nova17:29
*** rmart04 has quit IRC17:30
*** moshele has joined #openstack-nova17:30
melwittmriedem: I added https://bugs.launchpad.net/nova/+bug/1750084 to the rc todos etherpad because it was tagged as queens-rc-potential, fyi17:33
openstackLaunchpad bug 1750084 in OpenStack Compute (nova) "Report client associations include non-sharing providers" [Undecided,In progress] - Assigned to Eric Fried (efried)17:33
mriedemefried_omalley: why is that rc potential?17:35
efried_omalleymriedem: Because it hits on every update_compute_node, and in situations where you have big aggregates, you'll be wiring and caching a lot of unnecessary data.17:36
efried_omalleymriedem: I suppose if we make the argument that people aren't going to be using aggregates in Q, we don't need it.17:36
efried_omalleyBut that discussion needed to happen, hence "potential" :)17:36
mriedemthe only case i know of where people might use aggregates in placement is routed networks via neutron uses them17:37
efried_omalleyHow big can those get?17:37
mriedemidk17:37
efried_omalleyFor each aggregate-associated provider, we get the provider record, its inventory, its traits, and its aggregates (just the UUIDs, not associated providers).17:38
hrwjaypipes: need to do some testing and then will push update to config stuff17:38
openstackgerritDan Smith proposed openstack/nova master: Avoid exploding if guest refuses to detach a volume  https://review.openstack.org/54642317:38
efried_omalleySo that's four unnecessary API calls, and caching the concomitant data, per non-sharing aggregate-associated provider.17:38
mriedemefried_omalley: so if i'm working on my local CN1 and it's shared via aggregate to another provider SSP, it's also going to pull down anything related to SSP?17:41
efried_omalleyYes.17:41
*** dikonoor has quit IRC17:41
mriedemand anything that is also related to SSP?17:41
*** david-lyle has joined #openstack-nova17:41
mriedemanything else i mean, like if CN2 is also shared with SSP?17:41
efried_omalleyYes, with the bug, it'll also pull down CN2-CN999 if they're in the same aggregate as CN117:41
openstackgerritMarcin Juszkiewicz proposed openstack/nova master: Allow to configure amount of PCIe ports  https://review.openstack.org/54503417:41
mriedemffs17:41
mriedemwell then i guess it is probably worth doing an RC317:42
hrwjaypipes: config part left17:42
efried_omalleyDid I drop the ball here?  Was I supposed to tag it sooner?  Or manually alert someone to look at it?17:42
mriedemRC2 was friday so you wouldn't have had time anyway17:43
*** BryanS68 has quit IRC17:44
efried_omalleywhen did I tag it?17:44
mriedemyou created the bug on saturday17:44
mriedemanyway, i'm going to be busy for the next hour or so17:44
mriedemso someone else is going to have to dig into it from the core team17:45
*** itlinux has quit IRC17:46
*** openstackgerrit has quit IRC17:48
*** tbachman has quit IRC17:48
*** moshele has quit IRC17:49
*** openstackgerrit has joined #openstack-nova17:50
openstackgerritJay Pipes proposed openstack/os-traits master: Add compute capabilities traits  https://review.openstack.org/54671317:50
jaypipesmriedem: ^17:50
*** tbachman has joined #openstack-nova17:51
*** mgoddard_ has quit IRC17:53
*** moshele has joined #openstack-nova17:53
*** tbachman_ has joined #openstack-nova17:55
*** tbachman has quit IRC17:56
*** tbachman_ is now known as tbachman17:56
*** AlexeyAbashkin has joined #openstack-nova17:57
*** Swami has joined #openstack-nova17:58
*** yamamoto has joined #openstack-nova17:58
*** ccamacho has joined #openstack-nova17:59
*** derekh has quit IRC18:00
*** AlexeyAbashkin has quit IRC18:01
*** mlavalle has quit IRC18:02
*** mlavalle has joined #openstack-nova18:02
melwittdansmith: you're familiar with the placement provider tree stuff right? if so, it would be good if you could review this bug fix from efried_omalley https://review.openstack.org/54549418:03
*** yamamoto has quit IRC18:04
*** ccamacho has quit IRC18:06
melwittit's a candidate for rc318:06
dansmithI'm not really, but I'll try to look in a sec18:07
kukaczhi, what determines where nova instance configdrive is stored? is it tied to image storage backend as set in `images_type` in nova-compute.conf?18:08
*** ralonsoh has quit IRC18:09
melwittdansmith: noted. thanks18:09
dansmithmelwitt: ah, this isn't specifically tree related stuff18:10
*** tidwellr has quit IRC18:10
*** BryanS68 has joined #openstack-nova18:11
*** tidwellr has joined #openstack-nova18:11
melwittthe other rc3 candidate is https://review.openstack.org/#/c/545478 which is a simple one to handle specific multiattach exceptions in compute/api18:11
dansmithmelwitt: that one is just to avoid raising InvalidBDMVolume for those cases?18:12
dansmithare those caught in the api layer and handled differently?18:12
melwittyes18:12
melwittyeah, catch them and reraise them instead of letting it fall through to Exception where it raises a generic unhelpful InvalidBDMVolume18:13
dansmithjebus that's a huge list of exceptions caught around create_server18:14
dansmithoof18:14
*** felipemonteiro_ has quit IRC18:14
*** dtantsur is now known as dtantsur|afk18:15
melwittdansmith: which? that there will be 4 now?18:17
dansmithmelwitt: no, where it's caught in the api: https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L576-L62518:17
*** jpena is now known as jpena|off18:18
melwittoh, yes. that's an epic list18:18
*** sshwarts has quit IRC18:19
melwittmriedem: both rc3 changes are traveling gateward. I'll propose the release patch when I know which hash to use18:21
*** ccamacho has joined #openstack-nova18:23
*** tesseract has quit IRC18:25
*** moshele has quit IRC18:28
cdentjohnthetubaguy: is this permanently dead, or may come back to life? https://review.openstack.org/#/c/438640/ (spot instances). Or is blazar taking its place, or maybe preemptible as cern's doing it? http://openstack-in-production.blogspot.co.uk/2018/02/maximizing-resource-utilization-with.html18:30
*** r-daneel_ has joined #openstack-nova18:31
*** tbachman has quit IRC18:31
openstackgerritmelanie witt proposed openstack/nova stable/queens: Fix error handling in compute API for multiattach errors  https://review.openstack.org/54672918:31
*** r-daneel has quit IRC18:32
*** r-daneel_ is now known as r-daneel18:32
melwittefried_omalley: do you want to propose the backport for your bug fix to stable/queens?18:34
*** edleafe- has joined #openstack-nova18:34
efried_omalleymelwitt: I'd be happy to.  Did we decide it's backport-worthy?18:34
melwittI think it has to be if it's for queens rc318:34
melwittbacking up, yes, based on what you and mriedem said about the severity earlier I think we should18:36
efried_omalleymelwitt: Roger wilco, stand by.18:36
melwittthanks18:36
efried_omalleymelwitt: Quit standing by.  Gonna be a manual one.18:39
melwittah, bummer. good luck18:39
*** moshele has joined #openstack-nova18:39
efried_omalleyahjeez, it's because of all our diligent work getting contexts passed around everywhere.18:44
efried_omalleysome of which is in Q, some not.18:44
*** moshele has quit IRC18:45
*** tssurya has quit IRC18:45
efried_omalley...which would have to be redone if we plan to merge https://review.openstack.org/#/q/project:openstack/nova+topic:bug/1734625+branch:stable/queens  --  mriedem, melwitt thoughts?18:55
openstackgerritEric Fried proposed openstack/nova stable/queens: Only pull associated *sharing* providers  https://review.openstack.org/54674018:56
efried_omalleymelwitt: ^18:56
melwittefried_omalley: can we just backport more things to stable/queens to provide the needed base? or is it more than a few patches?18:56
efried_omalleymelwitt: See commit message.18:57
efried_omalleyThe additonal backport would be smallish.18:57
efried_omalleyBut I've already done the un-rebase :)18:57
efried_omalleymelwitt: So it's your call, o great and powerful.18:57
melwittokay. I think we'd usually just pull in the prereq patches too, assuming they meet stable branch requirements. I'd like mriedem's recommendation when he's around18:59
*** edleafe| has joined #openstack-nova19:00
*** yamamoto has joined #openstack-nova19:00
melwittwe've got some time before the changes on master merge anyway19:00
cdentefried_omalley: is the blocker still the context stuff? having the rest of that is a useful backport19:01
efried_omalleycdent: Not a blocker, but yes.19:01
*** andreas_s has joined #openstack-nova19:02
*** edleafe- has quit IRC19:02
*** salv-orlando has joined #openstack-nova19:03
*** yamamoto has quit IRC19:06
*** andreas_s has quit IRC19:07
*** tbachman has joined #openstack-nova19:11
cdentedleafe, efried_omalley, jaypipes: I'm going off-grid as much as possible until sunday evening shortly. Anything I should attend before I do?19:13
efried_omalleycdent: I think you've +1ed all the stuff I care about :)19:14
efried_omalleySo yeah, quick, go offline before you change your mind about any of it.19:14
cdentoh, that's just my efried+1 bot, not me19:14
*** esberglu has quit IRC19:19
*** itlinux has joined #openstack-nova19:19
*** AlexeyAbashkin has joined #openstack-nova19:21
efried_omalleyI need to let ubuntu upgrade a bunch of software.  So I may not be back.  Wish me luck.19:22
*** efried_omalley has quit IRC19:23
mriedemok so what's going on? we need https://review.openstack.org/#/q/project:openstack/nova+topic:bug/1734625+branch:stable/queens to make the backport of https://review.openstack.org/545494 clean?19:25
*** AlexeyAbashkin has quit IRC19:25
mriedemwe could take those for rc3, they are just large and i figured they weren't super high priority for an RC19:27
*** sridharg has quit IRC19:28
openstackgerritMohammed Naser proposed openstack/nova master: Ensure attachment_id always exists for block device mapping  https://review.openstack.org/54639819:29
melwittyeah. backport was messy/manual because that refactor isn't in stable/queens19:29
jaypipescdent: nope, see you in Dublin19:29
*** slaweq has joined #openstack-nova19:30
cdent19:30
*** ccamacho has quit IRC19:32
*** felipemonteiro has joined #openstack-nova19:33
ingy19:35
*** efried has joined #openstack-nova19:37
*** salv-orlando has quit IRC19:38
*** salv-orlando has joined #openstack-nova19:39
openstackgerritHongbin Lu proposed openstack/nova master: Skip placement on rebuild in same host  https://review.openstack.org/54635719:40
*** lbragstad has quit IRC19:40
efriedwoot19:40
*** salv-orlando has quit IRC19:43
*** esberglu has joined #openstack-nova19:43
*** esberglu has quit IRC19:44
*** esberglu has joined #openstack-nova19:44
openstackgerritHongbin Lu proposed openstack/nova master: Handle IpAddressAlreadyAllocated exception  https://review.openstack.org/53553219:45
*** tssurya has joined #openstack-nova19:52
*** fragatina has quit IRC19:53
melwittefried, mriedem: upon looking at the backport now I think it's good as-is19:53
edleafecdent: we got it.19:54
*** felipemonteiro has quit IRC19:54
*** felipemonteiro has joined #openstack-nova19:58
*** tidwellr has quit IRC20:00
*** tidwellr has joined #openstack-nova20:02
*** lbragstad has joined #openstack-nova20:02
*** yamamoto has joined #openstack-nova20:02
*** felipemonteiro has quit IRC20:06
*** yamamoto has quit IRC20:07
*** amoralej is now known as amoralej|off20:10
*** Nasir has joined #openstack-nova20:10
NasirHi i needed assistance trying to figure out why I cannot retrieve the serial console of my ironic/baremetal instance from nova, even though its configured properly in ironic20:10
*** psachin has joined #openstack-nova20:11
NasirThis is what i see when i try to do "nova get-serial-console <instance_uuid> 'https://thepasteb.in/p/pghQLXy7ZkmHR20:12
Nasirhttps://thepasteb.in/p/NxhVxv9661JiN20:13
*** amodi has quit IRC20:15
*** felipemonteiro has joined #openstack-nova20:16
NasirCan anyone assist please ? Thanks20:18
*** eharney has quit IRC20:19
*** edleafe| has quit IRC20:26
*** amodi has joined #openstack-nova20:29
*** lbragstad has quit IRC20:29
*** edleafe- has joined #openstack-nova20:29
*** lbragstad has joined #openstack-nova20:29
melwittNasir: this is a nova development channel, please see topic20:29
*** lbragstad has quit IRC20:29
mnasermelwitt: just fyi https://review.openstack.org/#/c/546689/ -- this okay with you? :)20:30
*** lbragstad has joined #openstack-nova20:30
*** edleafe- has quit IRC20:31
melwittmnaser: looks cool to me20:32
*** lbragstad has quit IRC20:32
mriedemmelwitt: this is also going to be in RC3 https://review.openstack.org/#/c/533212/20:32
mriedemsince it's a regression due to privsep20:32
mnasermelwitt: perfect ty, +A'd20:33
*** psachin has quit IRC20:33
melwittmriedem: okay, thanks20:33
*** lbragstad has joined #openstack-nova20:33
*** hongbin has quit IRC20:33
*** Nasir has quit IRC20:35
*** awaugama has quit IRC20:35
openstackgerritEric Berglund proposed openstack/nova master: Add check for redundant import aliases  https://review.openstack.org/54399520:37
*** psachin has joined #openstack-nova20:39
*** salv-orlando has joined #openstack-nova20:39
*** cdent has quit IRC20:41
*** belmoreira has joined #openstack-nova20:43
*** salv-orlando has quit IRC20:44
dansmithbelmoreira: since you're around I assume you folks have stuff to discuss this week?20:45
*** acormier has quit IRC20:46
belmoreiradansmith tssurya upload a new spec and we would like to have your thoughts about it20:47
melwittI think tssurya added something to the agenda but I haven't looked at it yet20:47
*** moshele has joined #openstack-nova20:47
dansmithorly20:47
tssuryadansmith, melwitt : https://review.openstack.org/#/c/546684/20:47
tssuryamelwitt : I just updated the bugs/ reviews we have on the agenda :D20:48
melwitttssurya: a-ha, thank you20:48
dansmithtssurya: belmoreira: makes sense I think20:49
belmoreiradansmith this was something missing in cellsV1 and we and at least rackspace have hacks for it20:50
*** felipemonteiro has quit IRC20:51
*** priteau has quit IRC20:52
melwittagreed that a feature for disabling a cell makes sense20:52
*** psachin has quit IRC20:52
belmoreiradansmith melwitt great, we can then continue the discussion in the spec20:52
dansmithtssurya: it's against the rules to approve a spec on revision 1, so I have noted a few nits for you to address :)20:53
*** BryanS68 has quit IRC20:54
tssuryadansmith: hehe, noted, thanks!20:54
dansmithheh20:54
dansmithbelmoreira: in case it's not obvious, we're glad you brought tssurya to us20:55
belmoreira:)20:55
melwitt++20:55
*** BryanS68 has joined #openstack-nova20:55
*** psachin has joined #openstack-nova20:56
tssuryadansmith , melwitt : wow, thanks :D truly honoured20:56
belmoreiradansmith thanks for all the work in the placement filtering. Do you think it will be easy to backport to Pike?20:56
melwitttssurya: and thank you for all the great work20:56
dansmithbelmoreira: it's not backportable upstream for sure.. I think pike lacks the placement aggregate stuff that will be needed to make it actually work20:57
tssuryamelwitt : couldn't have done it without the cells team ;)20:57
belmoreiradansmith I was not asking for the upstream backport. But I would like/need to backport it for us20:58
dansmithbelmoreira: the actual filter mechanism should apply back that far I think, so if you'd be willing to run a newer placement with the newer support it has then it's probably not too bad yeah20:58
*** lyan has quit IRC20:59
belmoreiraCurrently I started collecting data about the scheduling time (I'm running local placement). I would like to see the impact when starting consolidating placement in only one instance20:59
*** dave-mccowan has quit IRC21:00
belmoreiraI will let you the numbers21:00
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Update plugs Contrail methods to work with privsep  https://review.openstack.org/54677821:01
dansmithbelmoreira: cool21:01
melwittfyi I've added the cells review links to the priorities etherpad https://etherpad.openstack.org/p/rocky-nova-priorities-tracking21:01
tssuryamelwitt : thank you21:02
*** tidwellr has quit IRC21:02
*** tidwellr has joined #openstack-nova21:02
*** salv-orlando has joined #openstack-nova21:03
*** openstackgerrit has quit IRC21:03
*** yamamoto has joined #openstack-nova21:04
mriedemefried: do you see any issues with including these in RC3? https://review.openstack.org/#/q/project:openstack/nova+topic:bug/1734625+branch:stable/queens21:04
*** lpetrut has quit IRC21:06
*** moshele has quit IRC21:08
*** yamamoto has quit IRC21:09
*** felipemonteiro has joined #openstack-nova21:13
*** felipemonteiro has quit IRC21:17
*** tylerderosagrund has quit IRC21:28
efriedmriedem: No.  Go for it.21:32
efriedmriedem: But they'll have to be rebased.21:32
efriedThe alternative is to rebase https://review.openstack.org/#/c/546740/ on top of them instead.21:32
efriedwhich will make the cherry-pick clean.21:33
efriedI think21:33
*** pooja_jadhav has quit IRC21:35
*** belmoreira has quit IRC21:37
*** takashin has joined #openstack-nova21:40
melwittsmcginnis is already in the March spirit :)21:41
* smcginnis bangs head on desk21:42
*** bhagyashris has quit IRC21:44
*** pchavva has quit IRC21:46
mriedemefried: that's why i'm asking,21:47
mriedemif you put yours on top21:47
mriedemefried: i didn't include those request id backports since they were large and didn't think we needed them for an RC21:48
mriedemnow if it helps with conflicts both ways, we might as well21:48
efriedmriedem: The existing cherry-pick is already proposed, and it reads pretty clean.  So it's more work, not less, to backport the global_id stuff.21:48
*** eharney has joined #openstack-nova21:49
efriedmriedem: It may make subsequent backports easier.21:49
efriedmriedem: It will make this cherry-pick cleaner (possibly zero-conflict)21:49
efriedmriedem: But it'll be work to get that done.21:49
efriedmriedem: Which I'm happy to do if you wish it to be so.21:49
*** moshele has joined #openstack-nova21:49
*** psachin has quit IRC21:50
melwittwhich additional backports would the global_id patches help?21:50
*** moshele has quit IRC21:50
melwittbecause I agree, the one that's already proposed reads clean to me too21:50
mriedemif it's not clean on top of https://review.openstack.org/#/q/project:openstack/nova+topic:bug/1734625+branch:stable/queens then nvm21:51
mriedemwe can just go with what's there, that's fine21:51
mriedemhttps://review.openstack.org/#/q/project:openstack/nova+topic:bug/1734625+branch:stable/queens is just more LOC than i'm comfortable with for an RC when it's not something that is required21:51
melwittbut if not having global_id patches dominos into making other things difficult too, then we bring in global_id patches21:51
*** fragatina has joined #openstack-nova21:54
*** BryanS68 has quit IRC21:56
*** BryanS68 has joined #openstack-nova21:57
mriedemdansmith: want to get this for RC3? https://review.openstack.org/#/c/546729/21:57
mriedemand https://review.openstack.org/#/c/546778/21:58
efriedmelwitt: Depends how many backport-worthy bugs we find in the report client.21:58
efriedConsidering the amount of change it saw in Q....21:58
*** pchavva has joined #openstack-nova21:58
melwittyeah. I'd say since we don't know yet and you already dealt with the conflicts and it looks clean now, just go with what we have and we'll burn the other bridge when we get to it21:59
*** acormier has joined #openstack-nova21:59
*** openstackgerrit has joined #openstack-nova22:00
openstackgerritEric Berglund proposed openstack/nova master: Add check for redundant import aliases  https://review.openstack.org/54399522:00
efriedmelwitt: Dig22:02
*** tidwellr has quit IRC22:02
*** tidwellr has joined #openstack-nova22:02
openstackgerritMerged openstack/nova master: Only pull associated *sharing* providers  https://review.openstack.org/54549422:03
*** acormier has quit IRC22:03
openstackgerritMerged openstack/nova master: Fix error handling in compute API for multiattach errors  https://review.openstack.org/54547822:05
*** yamamoto has joined #openstack-nova22:05
openstackgerritMerged openstack/nova master: Avoid exploding if guest refuses to detach a volume  https://review.openstack.org/54642322:05
mriedemdansmith: i'm +2 on the backport for efried's fix https://review.openstack.org/#/c/546740/ - do we want to hack in the (cherry picked from x) thing?22:08
mriedemoh nvm it's higher up22:09
efriedyuh22:09
efriedgit review complained about it not being at the bottom for some reason.  Possibly because of the conflicts section?  Dunno.22:09
*** yamamoto has quit IRC22:10
*** pchavva has quit IRC22:10
mriedemmelwitt: in case you haven't seen https://review.openstack.org/#/c/546315/ and the one after it22:10
mriedemmnaser found some problems after working on those local delete backports22:10
mriedemi kind of sort of wonder if we should get those into rc3 as well22:14
mriedemhttps://review.openstack.org/#/q/topic:bug/1404867+status:open+branch:stable/queens plus the 2 on master22:15
mriedemmaybe that's too much22:15
mnasermriedem: part of me says - this bug existed for a long time so it's not exactly affecting this release - the other part says it might manifest itself much more after an upgrade where all computes end up being a minimum of pike22:17
mnaserif the computes were behind and are being updated *just enough* to upgrade api, then it'll happen22:18
mriedemright that's my worry, any bfv with an existing volume where you have at least 1 pike compute, and scheduling fails, and you orphan the volume when deleting the instance22:21
mriedemless of an issue in pike where you might have 1 ocata compute so we don't reserve the volume in the api,22:22
*** tidwellr has quit IRC22:22
mriedemmore of an issue in pike and queens where the computes would be new enough to reserve the volume in the api22:22
mriedem*more of an issue in queens22:22
melwitthm, sounds like we should include it then. the patches are small22:24
openstackgerritEric Berglund proposed openstack/nova master: Add check for redundant import aliases  https://review.openstack.org/54399522:26
*** itlinux has quit IRC22:29
mriedemexcept your big one22:29
openstackgerritTakashi NATSUME proposed openstack/nova master: Transform live_migration_post_dest notification  https://review.openstack.org/46978422:30
melwittme? no22:30
mriedemok i'll hit these queens ones and let dansmith make a call22:31
*** acormier has joined #openstack-nova22:31
*** rcernin has joined #openstack-nova22:32
*** acormier has quit IRC22:32
*** acormier has joined #openstack-nova22:33
openstackgerritTakashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller  https://review.openstack.org/34728922:33
melwittwas just kidding on that. I had thought the others had already gone to stable/queens22:34
*** salv-orlando has quit IRC22:34
*** salv-orlando has joined #openstack-nova22:34
*** yamamoto has joined #openstack-nova22:35
mriedemdone https://review.openstack.org/#/q/topic:bug/1404867+status:open+branch:stable/queens22:35
mriedemhttps://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/queens+label:Code-Review=222:36
*** tylerder_ has joined #openstack-nova22:37
openstackgerritTakashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data  https://review.openstack.org/40751422:37
melwittthanks. dansmith ^ if you think those are cool for rc322:37
* melwitt will bbiab22:38
*** Zames has joined #openstack-nova22:38
*** tbachman has quit IRC22:38
openstackgerritMerged openstack/nova master: Update plugs Contrail methods to work with privsep  https://review.openstack.org/53321222:38
*** salv-orlando has quit IRC22:39
mriedemwill likely need a +2/+W from dan on the backport for ^ as well22:39
dansmithsorry I had a thing22:40
* dansmith reads22:40
*** r-daneel has quit IRC22:40
dansmithmriedem: so just the stable/queens list from above?22:41
*** tylerder_ has quit IRC22:41
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2)  https://review.openstack.org/43060822:43
*** tidwellr has joined #openstack-nova22:43
dansmithmriedem: need someone else for that backport of mine I guess22:44
mnasermriedem: idk if we want to land those other last 2 on top for rc322:44
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2)  https://review.openstack.org/45948322:46
*** lbragstad has quit IRC22:47
*** lbragstad has joined #openstack-nova22:47
mriedemmnaser: we do22:48
*** wolverineav has joined #openstack-nova22:48
openstackgerritTakashi NATSUME proposed openstack/nova-specs master: Abort Cold Migration  https://review.openstack.org/33473222:48
mriedemdansmith: need this one also https://review.openstack.org/#/c/546778/22:48
mriedemdansmith: you'll likely need to just approve that one,22:48
mriedemconsider my stable core backport as a +222:49
mriedemmnaser: mel approved https://review.openstack.org/#/c/546315/ and the one after it so can you backport those to queens also so we can get them into rc3?22:49
dansmithmriedem: ack22:51
wolverineavhey, mriedem stephenfin, just a quick heads-up on the IVS vif change https://review.openstack.org/#/c/534371/ i've addressed the comments. let me know if any further changes are required :)22:51
*** salv-orlando has joined #openstack-nova22:53
*** tssurya has quit IRC22:54
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Microversion 2.61 - List/Show all server migration types  https://review.openstack.org/43083922:55
mnasermriedem: I’ll do that right now22:55
openstackgerritTakashi NATSUME proposed openstack/nova master: Transform servergroup.addmember notification  https://review.openstack.org/54110122:56
*** Zames has quit IRC22:57
*** liverpooler has quit IRC23:04
*** andreas_s has joined #openstack-nova23:04
*** tylerderosagrund has joined #openstack-nova23:07
openstackgerritMohammed Naser proposed openstack/nova stable/queens: Add functional test for deleting BFV server with old attach flow  https://review.openstack.org/54680323:07
openstackgerritMohammed Naser proposed openstack/nova stable/queens: Ensure attachment_id always exists for block device mapping  https://review.openstack.org/54680423:07
*** yamamoto has quit IRC23:08
*** larsks has left #openstack-nova23:08
mnaserdansmith: mriedem ^23:08
mnaserill do the pike one but that's not a big priority i guess23:09
*** andreas_s has quit IRC23:09
dansmithmoar?23:09
dansmithI'm going off mriedem's judgment for these attachment things23:10
mnaserdansmith: yeah it was a corner case we discovered upon backporting to pike that we fixed23:10
*** tylerderosagrund has quit IRC23:12
*** tbachman has joined #openstack-nova23:14
*** mlavalle has quit IRC23:16
*** tbachman has quit IRC23:18
*** acormier has quit IRC23:19
*** tbachman has joined #openstack-nova23:22
mnasermriedem: i think i will have to squash https://review.openstack.org/#/c/546398 + https://review.openstack.org/#/c/545132 in the stable/pike backport.  if i put 546398 first, the integration test for the fix fails (because early-delete patch is not there).  if i put 545132 before, the patch doesn't pass because 546398 is not there to make it do the right thing(tm)23:25
mnaseris that ok?23:25
mriedemmnaser: dansmith: +2 on those backports also23:25
mnaserunless you have other suggestions23:26
mriedemmnaser: ok, sounds like we have to do that, i can't think of fancy ways around that23:26
mnaserok ill propose a squashed commit in that case23:27
mriedemdansmith: all yours https://review.openstack.org/#/q/topic:bug/1750666+status:open+branch:stable/queens23:27
*** salv-orlando has quit IRC23:32
*** salv-orlando has joined #openstack-nova23:33
melwittone thing I was thinking about that's weird is a lot of those fixes are for bfv, but we've a regression since ocata with bfv + configdrive https://bugs.launchpad.net/nova/+bug/172958423:33
openstackLaunchpad bug 1729584 in OpenStack Compute (nova) "boot from volume + configdrive broken (regression)" [High,In progress] - Assigned to Jay Pipes (jaypipes)23:33
melwittmnaser: have yall run into that at all ^23:33
melwitt?23:34
mriedemmelwitt: squeeky wheel gets the grease23:35
melwittyup ... I admit I keep forgetting about that one too with all of the whirlwind of other stuff23:35
mnasermelwitt: checking23:35
openstackgerritMohammed Naser proposed openstack/nova stable/pike: Drop extra loop which modifies Cinder volume status  https://review.openstack.org/54621823:36
openstackgerritMohammed Naser proposed openstack/nova stable/pike: Store block device mappings in cell0  https://review.openstack.org/54621923:36
openstackgerritMohammed Naser proposed openstack/nova stable/pike: Add functional tests to ensure BDM removal on delete  https://review.openstack.org/54622023:36
openstackgerritMohammed Naser proposed openstack/nova stable/pike: Clean up ports and volumes when deleting ERROR instance  https://review.openstack.org/54622123:36
openstackgerritMohammed Naser proposed openstack/nova stable/pike: Ensure attachment_id always exists for block device mapping  https://review.openstack.org/54627523:36
openstackgerritMohammed Naser proposed openstack/nova stable/pike: Add functional test for deleting BFV server with old attach flow  https://review.openstack.org/54681223:36
mnaserbtw not sure if this is how to properly squash things but yeah https://review.openstack.org/#/c/54627523:36
mnaserand now reading23:37
*** salv-orlando has quit IRC23:37
openstackgerritEric Berglund proposed openstack/nova master: WIP: PowerVM Driver: Network interface attach/detach  https://review.openstack.org/54681323:37
mnasermelwitt: two things, we don't have configdrive by default + that issue seems to be happening when using virtio-scsi23:38
*** acormier has joined #openstack-nova23:38
mnaseri remember another issue of someone who had a similar issue a while back in the openstack canada group23:38
melwittokay, right ... so it's more niche23:39
melwittso not as hot as these other bugs23:39
mnaseryeah, you have to be using virtio-scsi (which i believe you have to set an image flag for that) and config drive23:39
melwittanyway, I gotta take care of that bug and hopefully backport it to ocata where it broke before ocata goes away23:40
melwittyeah23:40
*** acormier has quit IRC23:40
*** acormier has joined #openstack-nova23:40
*** hshiina has joined #openstack-nova23:41
*** acormier has quit IRC23:41
mnaseri posted a message in the openstack canada slack group to see who was the one who hit it23:41
*** acormier has joined #openstack-nova23:41
*** BryanS68 has quit IRC23:43
mnasermelwitt: fyi https://bugs.launchpad.net/nova/+bug/168611623:43
openstackLaunchpad bug 1686116 in OpenStack Compute (nova) ocata "domain xml not well defined when using virtio-scsi disk bus" [Medium,Fix committed] - Assigned to sahid (sahid-ferdjaoui)23:43
mnaser"This issue was fixed in the openstack/nova 15.0.7 release."23:44
efriedjaypipes: yt?23:44
mnaserwhich is the exact release that jaypipes mentioned affected him23:44
mnaserso that might be an interesting review to look at23:44
*** gjayavelu has joined #openstack-nova23:49
*** moshele has joined #openstack-nova23:53
*** mriedem has quit IRC23:54
*** chyka has quit IRC23:55
*** chyka has joined #openstack-nova23:56
*** mriedem has joined #openstack-nova23:56
mriedemjgriffith: smcginnis: stvnoyes: ildikov: finally got it https://youtu.be/hZg6wqxdEHk23:57
*** acormier has quit IRC23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!