| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Filter Resource Provider List for Traits https://review.openstack.org/546009 | 00:00 |
|---|---|---|
| efried | edleafe, mriedem, melwitt, jaypipes, cdent: ^ | 00:00 |
| melwitt | mnaser: the only thing I know of is the hypervisor-stats type of things e.g. https://docs.openstack.org/nova/pike/admin/common/nova-show-usage-statistics-for-hosts-instances.html | 00:04 |
| melwitt | mnaser: but you may be able to use something like this to dig deeper https://github.com/rogerhu/gdb-heap | 00:04 |
| mnaser | melwitt: looks like a bunch of reading but i'll look into it because it seems a bit (very) high | 00:05 |
| mnaser | melwitt: thank you for that information | 00:05 |
| melwitt | the only other thing could be a GMR (guru meditation report) | 00:08 |
| melwitt | I'm not sure that would help too much https://docs.openstack.org/nova/latest/reference/gmr.html | 00:09 |
| mmedvede | mriedem: ok, I'll change that | 00:10 |
| melwitt | but it should be simple to try, send USR2 to the nova-compute pid | 00:10 |
| *** liverpooler has joined #openstack-nova | 00:20 | |
| *** masber has joined #openstack-nova | 00:21 | |
| *** AlexeyAbashkin has joined #openstack-nova | 00:24 | |
| *** slaweq has joined #openstack-nova | 00:27 | |
| *** AlexeyAbashkin has quit IRC | 00:28 | |
| *** itlinux has joined #openstack-nova | 00:29 | |
| *** dave-mccowan has joined #openstack-nova | 00:30 | |
| *** slaweq has quit IRC | 00:32 | |
| *** tbachman has quit IRC | 00:37 | |
| openstackgerrit | Merged openstack/nova master: Fix PatternPropertiesTestCase for py 3.6 https://review.openstack.org/545798 | 00:39 |
| openstackgerrit | Merged openstack/nova master: Do not multiply megabytes with 1024 to get gigabytes. https://review.openstack.org/536335 | 00:39 |
| *** awaugama has quit IRC | 00:42 | |
| openstackgerrit | Merged openstack/nova master: libvirt: add Linux distribution guest only description for inject_xxx options https://review.openstack.org/528441 | 00:42 |
| *** lbragstad has quit IRC | 00:43 | |
| *** priteau has joined #openstack-nova | 00:47 | |
| *** vladikr has quit IRC | 00:49 | |
| openstackgerrit | Merged openstack/nova master: Update docstring for get_traits virt driver method https://review.openstack.org/539505 | 00:51 |
| openstackgerrit | Merged openstack/nova master: Add resource_class to fields in ironic node cache https://review.openstack.org/539506 | 00:51 |
| openstackgerrit | Merged openstack/nova master: trivial: Don't use 'Test' prefix for non-TestCase classes https://review.openstack.org/539251 | 00:52 |
| *** priteau has quit IRC | 00:52 | |
| *** dave-mccowan has quit IRC | 00:53 | |
| *** liverpooler has quit IRC | 00:54 | |
| *** elmaciej has quit IRC | 00:58 | |
| openstackgerrit | Merged openstack/nova master: trivial: Resolve "X is renamed to Y" warnings https://review.openstack.org/539252 | 01:02 |
| openstackgerrit | Merged openstack/nova master: Don't modify objects directly https://review.openstack.org/539253 | 01:02 |
| tetsuro | could anyone review https://review.openstack.org/#/c/531347/? It got one +2 a month ago. | 01:04 |
| *** stakeda has joined #openstack-nova | 01:05 | |
| *** tbachman has joined #openstack-nova | 01:07 | |
| *** acormier_ has quit IRC | 01:08 | |
| *** claudiub has quit IRC | 01:08 | |
| *** acormier has joined #openstack-nova | 01:09 | |
| *** chyka_ has joined #openstack-nova | 01:13 | |
| *** acormier has quit IRC | 01:13 | |
| *** acormier has joined #openstack-nova | 01:14 | |
| *** acormier has quit IRC | 01:14 | |
| *** acormier has joined #openstack-nova | 01:15 | |
| *** chyka has quit IRC | 01:16 | |
| *** hiro-kobayashi has joined #openstack-nova | 01:17 | |
| *** dave-mccowan has joined #openstack-nova | 01:17 | |
| *** andreas_s has joined #openstack-nova | 01:28 | |
| *** dave-mccowan has quit IRC | 01:29 | |
| *** andreas_s has quit IRC | 01:33 | |
| mriedem | melwitt: yeah i guess, i probably hadn't noticed that when rebasing it last time | 01:35 |
| mriedem | mnaser: my guess would be any caching done in the nova.compute.manager.resource_tracker | 01:36 |
| mriedem | mnaser: we cache some placement-related stuff in there now | 01:36 |
| mriedem | but it shouldn't be much.. | 01:36 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L133 | 01:37 |
| melwitt | mriedem: okay, just wanted to confirm whether there's more to do on that patch before I +W | 01:37 |
| mriedem | melwitt: as far as i know, not tracking the created snapshots and cleaning them up is latent behavior | 01:37 |
| melwitt | mriedem: that's what it looked like to me too | 01:38 |
| mriedem | mnaser: and the RT has an in-memory report client that has a cache of its own https://github.com/openstack/nova/blob/stable/pike/nova/scheduler/client/report.py#L233 | 01:38 |
| *** chyka_ has quit IRC | 01:49 | |
| *** chyka has joined #openstack-nova | 01:50 | |
| openstackgerrit | Merged openstack/nova master: Remove unused method _parse_node_instance_info https://review.openstack.org/539507 | 01:51 |
| *** chyka has quit IRC | 01:55 | |
| *** mriedem has quit IRC | 01:59 | |
| *** esberglu has quit IRC | 02:04 | |
| *** esberglu has joined #openstack-nova | 02:04 | |
| *** toabctl has quit IRC | 02:05 | |
| *** jafeha has joined #openstack-nova | 02:08 | |
| *** esberglu has quit IRC | 02:09 | |
| *** jafeha__ has quit IRC | 02:10 | |
| openstackgerrit | Merged openstack/nova master: Add the ability to get absolute limits from Cinder https://review.openstack.org/520122 | 02:12 |
| *** vladikr has joined #openstack-nova | 02:13 | |
| *** vishwanathj has joined #openstack-nova | 02:20 | |
| *** salv-orlando has joined #openstack-nova | 02:27 | |
| *** salv-orl_ has quit IRC | 02:30 | |
| *** esberglu has joined #openstack-nova | 02:31 | |
| tetsuro | melwitt: responsed on https://review.openstack.org/#/c/531328/4, thank you for the review. | 02:38 |
| *** esberglu has quit IRC | 02:39 | |
| *** esberglu has joined #openstack-nova | 02:40 | |
| *** esberglu has quit IRC | 02:44 | |
| *** yangyapeng has quit IRC | 02:47 | |
| *** yangyapeng has joined #openstack-nova | 02:47 | |
| *** harlowja has quit IRC | 02:52 | |
| *** yangyape_ has joined #openstack-nova | 03:00 | |
| *** yangyapeng has quit IRC | 03:01 | |
| *** lbragstad has joined #openstack-nova | 03:01 | |
| *** bkopilov has quit IRC | 03:08 | |
| *** liverpooler has joined #openstack-nova | 03:08 | |
| *** dave-mccowan has joined #openstack-nova | 03:10 | |
| *** hongbin has joined #openstack-nova | 03:10 | |
| *** yamahata has quit IRC | 03:17 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform aggregate.update_metadata notification https://review.openstack.org/460625 | 03:18 |
| *** AlexeyAbashkin has joined #openstack-nova | 03:24 | |
| *** AlexeyAbashkin has quit IRC | 03:29 | |
| *** andreas_s has joined #openstack-nova | 03:29 | |
| *** janki has joined #openstack-nova | 03:33 | |
| *** liverpooler has quit IRC | 03:33 | |
| *** andreas_s has quit IRC | 03:34 | |
| *** stakeda has quit IRC | 03:45 | |
| *** slaweq has joined #openstack-nova | 03:48 | |
| *** acormier has quit IRC | 03:50 | |
| *** esberglu has joined #openstack-nova | 03:51 | |
| *** slaweq has quit IRC | 03:53 | |
| *** esberglu has quit IRC | 03:56 | |
| *** janki has quit IRC | 03:56 | |
| *** janki has joined #openstack-nova | 03:57 | |
| *** Dinesh_Bhor has joined #openstack-nova | 03:59 | |
| *** slaweq has joined #openstack-nova | 04:01 | |
| *** jafeha__ has joined #openstack-nova | 04:03 | |
| *** jafeha has quit IRC | 04:04 | |
| *** slaweq has quit IRC | 04:05 | |
| *** chyka has joined #openstack-nova | 04:06 | |
| *** chyka has quit IRC | 04:10 | |
| *** udesale has joined #openstack-nova | 04:13 | |
| *** tetsuro has left #openstack-nova | 04:14 | |
| *** links has joined #openstack-nova | 04:21 | |
| *** lbragstad has quit IRC | 04:26 | |
| *** janki has quit IRC | 04:27 | |
| *** janki has joined #openstack-nova | 04:28 | |
| *** yamamoto has joined #openstack-nova | 04:34 | |
| *** bnemec-pto has quit IRC | 04:36 | |
| *** slaweq has joined #openstack-nova | 04:38 | |
| *** ying_zuo has left #openstack-nova | 04:38 | |
| *** bkopilov has joined #openstack-nova | 04:40 | |
| *** abhishekk has joined #openstack-nova | 04:41 | |
| *** psachin has joined #openstack-nova | 04:41 | |
| *** slaweq has quit IRC | 04:43 | |
| *** esberglu has joined #openstack-nova | 04:48 | |
| *** esberglu has quit IRC | 04:52 | |
| *** harlowja has joined #openstack-nova | 04:54 | |
| *** sree_ has joined #openstack-nova | 04:54 | |
| *** sree_ is now known as Guest742 | 04:55 | |
| *** moshele has joined #openstack-nova | 04:57 | |
| *** vivsoni has quit IRC | 05:00 | |
| *** hongbin has quit IRC | 05:01 | |
| *** dave-mccowan has quit IRC | 05:02 | |
| *** masahisa has quit IRC | 05:02 | |
| *** trinaths has joined #openstack-nova | 05:04 | |
| *** ratailor has joined #openstack-nova | 05:06 | |
| *** slaweq has joined #openstack-nova | 05:09 | |
| *** slaweq has quit IRC | 05:14 | |
| *** lpetrut has joined #openstack-nova | 05:33 | |
| openstackgerrit | Rajesh Tailor proposed openstack/nova master: Return 400 when compute host is not found https://review.openstack.org/447355 | 05:50 |
| openstackgerrit | Rajesh Tailor proposed openstack/nova master: Return 400 when compute host is not found https://review.openstack.org/447355 | 05:55 |
| openstackgerrit | Rajesh Tailor proposed openstack/nova master: Return 400 when compute host is not found https://review.openstack.org/447355 | 05:59 |
| *** lpetrut has quit IRC | 06:01 | |
| *** slaweq has joined #openstack-nova | 06:03 | |
| *** claudiub has joined #openstack-nova | 06:04 | |
| *** ircuser-1 has quit IRC | 06:05 | |
| *** slaweq has quit IRC | 06:08 | |
| *** toabctl has joined #openstack-nova | 06:08 | |
| *** mdrabe has quit IRC | 06:11 | |
| *** mdrabe has joined #openstack-nova | 06:13 | |
| *** kholkina has joined #openstack-nova | 06:16 | |
| *** Dinesh_Bhor has quit IRC | 06:16 | |
| *** Dinesh_Bhor has joined #openstack-nova | 06:19 | |
| *** lpetrut has joined #openstack-nova | 06:19 | |
| *** priteau has joined #openstack-nova | 06:23 | |
| *** yamamoto has quit IRC | 06:23 | |
| *** vladikr has quit IRC | 06:26 | |
| *** priteau has quit IRC | 06:26 | |
| *** bnemec has joined #openstack-nova | 06:28 | |
| *** bnemec is now known as bnemec-pto | 06:29 | |
| *** lpetrut has quit IRC | 06:30 | |
| *** yamamoto has joined #openstack-nova | 06:33 | |
| *** sridharg has joined #openstack-nova | 06:35 | |
| *** vladikr has joined #openstack-nova | 06:38 | |
| *** vladikr has quit IRC | 06:44 | |
| *** jafeha__ is now known as jafeha | 06:45 | |
| *** hiro-kobayashi has quit IRC | 06:46 | |
| *** acormier has joined #openstack-nova | 06:51 | |
| *** chyka has joined #openstack-nova | 06:55 | |
| *** acormier has quit IRC | 06:55 | |
| *** vladikr has joined #openstack-nova | 06:57 | |
| *** chyka has quit IRC | 06:59 | |
| *** elmaciej has joined #openstack-nova | 07:08 | |
| *** lpetrut has joined #openstack-nova | 07:09 | |
| *** threestrands has quit IRC | 07:10 | |
| *** akki__ has joined #openstack-nova | 07:10 | |
| *** harlowja has quit IRC | 07:10 | |
| akki__ | Hello, I have a running OpenStack setup on which I was able to launch VMs. But I want to move to use LXC instantiation. So, for that, I have installed nova-compute-lxd on my current setup of OpenStack with basic services installed in it. I have installed nova-compute-lxd on my compute node (Ubuntu 16.04), changed the virt-type to 'lxc' in my nova.conf and then restarted the nova-compute service. | 07:12 |
| akki__ | After this, I launched an instance and it failed after some time and gives the following error: [Error: No valid host was found. There are not enough hosts available.]. Could you please guide what else is required to launch container on OpenStack setup? What configurations will I need to configure LXD and my nova user to see the LXD daemon. I am new to this, every help appreciated. | 07:12 |
| *** rcernin has quit IRC | 07:12 | |
| *** janki has quit IRC | 07:20 | |
| *** andreas_s has joined #openstack-nova | 07:20 | |
| *** lpetrut has quit IRC | 07:23 | |
| *** trinaths has quit IRC | 07:31 | |
| *** Dinesh_Bhor has quit IRC | 07:35 | |
| *** pcaruana has joined #openstack-nova | 07:35 | |
| *** masahisa has joined #openstack-nova | 07:38 | |
| *** alexchadin has joined #openstack-nova | 07:42 | |
| *** yamamoto has quit IRC | 07:42 | |
| *** alex___ has joined #openstack-nova | 07:43 | |
| *** yamamoto has joined #openstack-nova | 07:43 | |
| *** alex___ is now known as fusmu | 07:43 | |
| *** slaweq has joined #openstack-nova | 07:44 | |
| *** slaweq has quit IRC | 07:45 | |
| *** yamamoto has quit IRC | 07:46 | |
| *** sshwarts has joined #openstack-nova | 07:50 | |
| *** yamamoto has joined #openstack-nova | 07:50 | |
| *** AlexeyAbashkin has joined #openstack-nova | 07:53 | |
| *** slaweq has joined #openstack-nova | 07:54 | |
| *** yamamoto has quit IRC | 07:59 | |
| *** sahid has joined #openstack-nova | 08:03 | |
| *** ttsiouts has quit IRC | 08:07 | |
| *** ttsiouts has joined #openstack-nova | 08:08 | |
| *** yangyape_ has quit IRC | 08:10 | |
| *** tetsuro has joined #openstack-nova | 08:10 | |
| *** yangyapeng has joined #openstack-nova | 08:17 | |
| *** Dinesh_Bhor has joined #openstack-nova | 08:20 | |
| *** tesseract has joined #openstack-nova | 08:20 | |
| *** hoonetorg has quit IRC | 08:24 | |
| *** alexchadin has quit IRC | 08:24 | |
| *** alexchadin has joined #openstack-nova | 08:24 | |
| *** yangyapeng has quit IRC | 08:27 | |
| *** damien_r has joined #openstack-nova | 08:27 | |
| *** yamamoto has joined #openstack-nova | 08:31 | |
| *** ragiman has joined #openstack-nova | 08:31 | |
| *** fusmu has quit IRC | 08:32 | |
| *** fusmu_ has joined #openstack-nova | 08:32 | |
| *** ccamacho has joined #openstack-nova | 08:34 | |
| *** masahisa has quit IRC | 08:36 | |
| *** Dinesh_Bhor has quit IRC | 08:37 | |
| *** yangyapeng has joined #openstack-nova | 08:38 | |
| *** Dinesh_Bhor has joined #openstack-nova | 08:38 | |
| *** hoonetorg has joined #openstack-nova | 08:41 | |
| *** elmaciej has quit IRC | 08:42 | |
| *** chyka has joined #openstack-nova | 08:44 | |
| *** yasemin has quit IRC | 08:45 | |
| *** jpena|off is now known as jpena | 08:46 | |
| *** dtantsur|afk is now known as dtantsur | 08:47 | |
| *** chyka has quit IRC | 08:49 | |
| *** yangyape_ has joined #openstack-nova | 08:49 | |
| *** yangyapeng has quit IRC | 08:50 | |
| *** amoralej|off is now known as amoralej | 08:52 | |
| *** yamamoto_ has joined #openstack-nova | 08:54 | |
| *** cdent has joined #openstack-nova | 08:56 | |
| *** priteau has joined #openstack-nova | 08:56 | |
| *** hiro-kobayashi has joined #openstack-nova | 08:57 | |
| *** yamamoto has quit IRC | 08:58 | |
| hrw | morning | 09:00 |
| *** lpetrut has joined #openstack-nova | 09:05 | |
| *** tetsuro has left #openstack-nova | 09:10 | |
| *** stvnoyes has joined #openstack-nova | 09:11 | |
| openstackgerrit | Mark Goddard proposed openstack/nova stable/queens: Add resource_class to fields in ironic node cache https://review.openstack.org/546085 | 09:13 |
| *** psachin has quit IRC | 09:19 | |
| *** slaweq_ has joined #openstack-nova | 09:22 | |
| *** slaweq_ has quit IRC | 09:26 | |
| openstackgerrit | Dinesh Bhor proposed openstack/nova-specs master: Strict isolation of group of hosts for images https://review.openstack.org/381912 | 09:29 |
| *** mgoddard_ has joined #openstack-nova | 09:30 | |
| lyarwood | mdbooth: https://review.openstack.org/#/c/543569/ - would you mind taking a look at this change for https://bugs.launchpad.net/nova/+bug/1739593 | 09:34 |
| openstack | Launchpad bug 1739593 in OpenStack Security Advisory "Swapping encrypted volumes can lead to data loss and a possible compute host DOS attack (CVE-2017-18191)" [Undecided,Incomplete] | 09:34 |
| * lyarwood grabs more coffee | 09:35 | |
| openstackgerrit | Merged openstack/nova master: Test websocketproxy with TLS in the nova-next job https://review.openstack.org/513160 | 09:39 |
| *** tssurya has joined #openstack-nova | 09:40 | |
| *** Dinesh_Bhor has quit IRC | 09:40 | |
| *** derekh has joined #openstack-nova | 09:41 | |
| *** trinaths has joined #openstack-nova | 09:50 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove unused LOG variables https://review.openstack.org/546097 | 09:58 |
| kashyap | Hi, can someone point to PTG Nova agenda etherpad? | 09:59 |
| cdent | kashyap: https://etherpad.openstack.org/p/nova-ptg-rocky | 09:59 |
| kashyap | cdent: Thank you | 09:59 |
| *** hiro-kobayashi has quit IRC | 09:59 | |
| * kashyap wanted to note a topic before he forgets | 09:59 | |
| bauzas | meh, LP timeout :( | 10:01 |
| bauzas | hello folks, btw. | 10:01 |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Use nova.db.api directly https://review.openstack.org/543262 | 10:01 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Move db MAX constants to own file https://review.openstack.org/543469 | 10:01 |
| cdent | brb | 10:03 |
| *** cdent has quit IRC | 10:03 | |
| *** cdent has joined #openstack-nova | 10:03 | |
| *** Guest742 has quit IRC | 10:12 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Extending delete_cell --force to delete instance_mappings https://review.openstack.org/540073 | 10:19 |
| *** alexchadin has quit IRC | 10:27 | |
| * hrw -> backlog to check for on-irc comments to https://review.openstack.org/#/c/545034/ patch before pushing new update | 10:28 | |
| bauzas | mdbooth: others, I need to disappear, but I'm tempted to set https://bugs.launchpad.net/nova/+bug/1740025 as Wontfix | 10:34 |
| openstack | Launchpad bug 1740025 in OpenStack Compute (nova) "LVM Sparse Volumes broken" [Undecided,New] | 10:34 |
| bauzas | agreed ? | 10:34 |
| mdbooth | bauzas: Reading | 10:35 |
| *** abhishekk has quit IRC | 10:35 | |
| mdbooth | bauzas: Why wontfix? | 10:36 |
| mdbooth | I recall there being severe problems with sparse lvm | 10:36 |
| mdbooth | Not the specifics, though | 10:37 |
| bauzas | mdbooth: because it looks like a feature | 10:38 |
| bauzas | mdbooth: tbc, you can do thin provisioning with Cinder | 10:39 |
| kashyap | I don't know, would you want the reporter to do the whole spec dance? | 10:39 |
| bauzas | but here, the reporter only uses raw LVM | 10:39 |
| kashyap | It's okay to flesh out the details on the bug, without hurrying to close it | 10:39 |
| mdbooth | bauzas: It reads like a bug to me. | 10:39 |
| kashyap | Yeah, to me too. | 10:39 |
| bauzas | so, in case you create LVM volumes having X size | 10:40 |
| bauzas | then, meh | 10:40 |
| mdbooth | Sparse LVM is a thing, and if we were using it correctly, I would expect the scenario described to work. | 10:40 |
| bauzas | mdbooth: why can't the reporter create LVs that are more than 64MB ? | 10:40 |
| bauzas | that's something I don't understand | 10:41 |
| mdbooth | bauzas: I'm guessing because we didn't create the sparse lv correctly. | 10:41 |
| mdbooth | bauzas: As I said, though, I'm pretty sure I recall severe problems in our implementation of sparse lvm. | 10:41 |
| lyarwood | yeah that's not up to the user, n-cpu is creating the lv's | 10:41 |
| bauzas | ah ok | 10:41 |
| mdbooth | severe == How could it ever possibly have worked | 10:41 |
| bauzas | so when nova creates the lv, it asks for a size | 10:41 |
| bauzas | that's not the image | 10:41 |
| bauzas | meh | 10:41 |
| mdbooth | bauzas: It's like creating a sparse file, except lvm | 10:42 |
| bauzas | and then tries to thin provision by itself, while cinder can do that far better | 10:42 |
| mdbooth | It creates a sparse block device, which only allocated blocks from the lvm block pool when they're used | 10:42 |
| mdbooth | Or it's supposed to, anyway | 10:42 |
| bauzas | looks to me we barely support it | 10:42 |
| mdbooth | bauzas: Right. | 10:42 |
| bauzas | yeah I understand the purpose of sparse LVs | 10:42 |
| mdbooth | bauzas: I'm not convinced this has ever worked. However, I'm pretty sure that it was intended to work. | 10:42 |
| bauzas | exactly | 10:43 |
| bauzas | hence the Wontfix | 10:43 |
| bauzas | we never tested that, right? | 10:43 |
| mdbooth | Meh, still sounds like a bug to me. | 10:43 |
| bauzas | some obscure blueprint that implemented in 2012 to make people happy | 10:43 |
| bauzas | without having decent testing | 10:43 |
| bauzas | call it tech debt | 10:43 |
| *** rajinir has quit IRC | 10:43 | |
| mdbooth | If we mark this wontfix, we should officially deprecate the feature instead. | 10:43 |
| bauzas | that's right | 10:43 |
| * mdbooth would be +1 on that, btw | 10:43 | |
| *** jamespage has quit IRC | 10:43 | |
| bauzas | I need to go to the gym, but I'll consider all the options before replying to the bug | 10:44 |
| mdbooth | bauzas: KK. Enjoy! | 10:44 |
| bauzas | mdbooth: yeah, we can have volume-backed instances by cinder, right? | 10:44 |
| mdbooth | bauzas: And don't forget I'll be Wattbiking in Dublin next week if you want to join me :) | 10:44 |
| bauzas | mdbooth: if so, you can do thin provisioning with cinder | 10:44 |
| kashyap | mdbooth: What _is_ Wattbiking? /me looks up | 10:44 |
| lyarwood | bauzas: yeah but not using local disks as PVs as this is doing | 10:45 |
| kashyap | Ah, indoor bike trainers | 10:45 |
| mdbooth | bauzas: Yes, I'm sure this is much better handled by cinder. | 10:45 |
| bauzas | mdbooth: this is what I'm doing https://vimeo.com/8178409 | 10:45 |
| * bauzas bails out | 10:45 | |
| *** rajinir has joined #openstack-nova | 10:46 | |
| *** jamespage has joined #openstack-nova | 10:46 | |
| *** rmart04 has joined #openstack-nova | 10:46 | |
| kashyap | Bail out whom? | 10:47 |
| * kashyap is joking; but language nit-pick: https://www.merriam-webster.com/dictionary/bailout | 10:47 | |
| *** alexchadin has joined #openstack-nova | 10:49 | |
| *** mvk_ has quit IRC | 10:53 | |
| *** dtantsur is now known as dtantsur|brb | 10:54 | |
| *** mdnadeem has joined #openstack-nova | 10:56 | |
| *** psachin has joined #openstack-nova | 10:57 | |
| *** sahid_ has joined #openstack-nova | 10:58 | |
| *** fusmu_ has quit IRC | 10:59 | |
| *** alexchadin has quit IRC | 10:59 | |
| *** sahid has quit IRC | 11:01 | |
| *** tetsuro has joined #openstack-nova | 11:02 | |
| mdbooth | kashyap: See the second definition of bail out in that list | 11:04 |
| kashyap | I saw that... | 11:04 |
| kashyap | The parachute thing, right? | 11:04 |
| kashyap | No | 11:04 |
| kashyap | "to abandon a harmful or difficult situation;" | 11:05 |
| kashyap | :P | 11:05 |
| kashyap | mdbooth: I doubt bauzas mean't that. Haha | 11:05 |
| kashyap | (I'd guess, he'd be surprised to learn that.) | 11:05 |
| mdbooth | Not used literally, it seems appropriate in context | 11:05 |
| kashyap | s/mean't/meant/ | 11:05 |
| kashyap | Yeah, true. | 11:06 |
| *** lucas-afk is now known as lucasagomes | 11:13 | |
| *** doude has joined #openstack-nova | 11:16 | |
| *** bkopilov has quit IRC | 11:18 | |
| *** takashin has left #openstack-nova | 11:19 | |
| *** takashin has joined #openstack-nova | 11:20 | |
| *** ralonsoh has joined #openstack-nova | 11:20 | |
| *** ratailor has quit IRC | 11:29 | |
| openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: Allow to configure amount of PCIe ports https://review.openstack.org/545034 | 11:33 |
| *** takashin has left #openstack-nova | 11:37 | |
| *** udesale has quit IRC | 11:43 | |
| *** psachin` has joined #openstack-nova | 11:43 | |
| *** psachin has quit IRC | 11:44 | |
| *** trinaths has quit IRC | 11:53 | |
| *** sree_ has joined #openstack-nova | 11:54 | |
| *** sree_ is now known as Guest99467 | 11:54 | |
| *** tbachman has quit IRC | 11:55 | |
| *** tbachman has joined #openstack-nova | 11:56 | |
| *** acormier has joined #openstack-nova | 12:06 | |
| *** acormier has quit IRC | 12:06 | |
| *** acormier has joined #openstack-nova | 12:07 | |
| *** sahid_ has quit IRC | 12:09 | |
| *** frickler has quit IRC | 12:09 | |
| *** alexchadin has joined #openstack-nova | 12:10 | |
| *** yamamoto_ has quit IRC | 12:13 | |
| *** alexchadin has quit IRC | 12:16 | |
| *** frickler has joined #openstack-nova | 12:16 | |
| *** alexchadin has joined #openstack-nova | 12:16 | |
| *** chyka has joined #openstack-nova | 12:25 | |
| *** yamamoto has joined #openstack-nova | 12:28 | |
| *** chyka has quit IRC | 12:30 | |
| *** frickler has quit IRC | 12:31 | |
| *** yamamoto has quit IRC | 12:31 | |
| *** yamamoto has joined #openstack-nova | 12:31 | |
| *** yamamoto has quit IRC | 12:31 | |
| *** tetsuro has quit IRC | 12:35 | |
| *** yamamoto has joined #openstack-nova | 12:36 | |
| *** acormier has quit IRC | 12:37 | |
| *** acormier has joined #openstack-nova | 12:37 | |
| *** acormier has quit IRC | 12:42 | |
| *** Guest99467 has quit IRC | 12:42 | |
| *** frickler has joined #openstack-nova | 12:44 | |
| *** jpena is now known as jpena|lunch | 12:44 | |
| *** bnemec-pto has quit IRC | 12:49 | |
| *** vivsoni has joined #openstack-nova | 12:49 | |
| *** bnemec has joined #openstack-nova | 12:51 | |
| *** bkopilov has joined #openstack-nova | 12:52 | |
| *** alexchadin has quit IRC | 12:53 | |
| *** psachin`` has joined #openstack-nova | 13:00 | |
| *** psachin` has quit IRC | 13:01 | |
| *** toabctl has quit IRC | 13:02 | |
| *** liverpooler has joined #openstack-nova | 13:02 | |
| *** masahisa has joined #openstack-nova | 13:03 | |
| *** tbachman has joined #openstack-nova | 13:09 | |
| *** tbachman_ has joined #openstack-nova | 13:11 | |
| *** salv-orlando has quit IRC | 13:12 | |
| *** salv-orlando has joined #openstack-nova | 13:12 | |
| *** tbachman has quit IRC | 13:13 | |
| *** tbachman_ is now known as tbachman | 13:13 | |
| *** masahisa has quit IRC | 13:13 | |
| *** alexchadin has joined #openstack-nova | 13:15 | |
| *** psachin`` has quit IRC | 13:16 | |
| *** chyka has joined #openstack-nova | 13:17 | |
| *** salv-orlando has quit IRC | 13:17 | |
| *** tbachman_ has joined #openstack-nova | 13:20 | |
| *** chyka has quit IRC | 13:22 | |
| *** Jams_ has joined #openstack-nova | 13:22 | |
| *** tbachman has quit IRC | 13:22 | |
| *** tbachman_ is now known as tbachman | 13:22 | |
| *** acormier has joined #openstack-nova | 13:22 | |
| *** toabctl has joined #openstack-nova | 13:23 | |
| *** pchavva has joined #openstack-nova | 13:24 | |
| *** Jams_ has quit IRC | 13:26 | |
| *** acormier has quit IRC | 13:27 | |
| openstackgerrit | Bence Romsics proposed openstack/osc-placement master: RP list: member_of and resources parameters (v1.3, v1.4) https://review.openstack.org/511183 | 13:30 |
| openstackgerrit | Bence Romsics proposed openstack/osc-placement master: RP delete inventories (v1.5) https://review.openstack.org/514642 | 13:30 |
| openstackgerrit | Bence Romsics proposed openstack/osc-placement master: CLI for traits (v1.6) https://review.openstack.org/514643 | 13:30 |
| openstackgerrit | Bence Romsics proposed openstack/osc-placement master: Resource class set (v1.7) https://review.openstack.org/514644 | 13:30 |
| openstackgerrit | Bence Romsics proposed openstack/osc-placement master: Usages per project and user (v1.8, v1.9) https://review.openstack.org/514646 | 13:30 |
| openstackgerrit | Bence Romsics proposed openstack/osc-placement master: CLI allocation candidates (v1.10) https://review.openstack.org/514647 | 13:30 |
| openstackgerrit | Bence Romsics proposed openstack/osc-placement master: New dict format of allocations (v1.11, v1.12) https://review.openstack.org/542819 | 13:30 |
| *** dtantsur|brb is now known as dtantsur | 13:32 | |
| *** pchavva1 has joined #openstack-nova | 13:35 | |
| *** pchavva has quit IRC | 13:39 | |
| *** amoralej is now known as amoralej|lunch | 13:43 | |
| *** mriedem has joined #openstack-nova | 13:44 | |
| *** jpena|lunch is now known as jpena | 13:44 | |
| openstackgerrit | Elod Illes proposed openstack/nova master: Functional test: cold migrate to compute down https://review.openstack.org/496280 | 13:46 |
| openstackgerrit | Elod Illes proposed openstack/nova master: Functional test: evacuate with no compute https://review.openstack.org/498482 | 13:46 |
| *** rmart04 has quit IRC | 13:47 | |
| *** esberglu has joined #openstack-nova | 13:48 | |
| *** liverpooler has quit IRC | 13:50 | |
| *** chyka has joined #openstack-nova | 13:50 | |
| *** kholkina has quit IRC | 13:52 | |
| *** kholkina has joined #openstack-nova | 13:53 | |
| *** chyka has quit IRC | 13:55 | |
| *** sree_ has joined #openstack-nova | 13:58 | |
| *** sree_ is now known as Guest68511 | 13:58 | |
| *** dave-mccowan has joined #openstack-nova | 13:59 | |
| *** rmcall has joined #openstack-nova | 14:00 | |
| *** moshele has quit IRC | 14:05 | |
| *** rmcall has quit IRC | 14:08 | |
| *** abhishekk has joined #openstack-nova | 14:09 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Add the ability to get absolute limits from Cinder https://review.openstack.org/546157 | 14:10 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Check quota before creating volume snapshots https://review.openstack.org/546158 | 14:10 |
| *** sidx64 has joined #openstack-nova | 14:11 | |
| mriedem | claudiub: can you get these backports? https://review.openstack.org/#/q/topic:bug/1746032+status:open | 14:12 |
| *** yamamoto has quit IRC | 14:12 | |
| *** links has quit IRC | 14:15 | |
| *** eharney has quit IRC | 14:20 | |
| *** Guest68511 has quit IRC | 14:27 | |
| *** tbachman has quit IRC | 14:29 | |
| *** lbragstad has joined #openstack-nova | 14:29 | |
| *** tbachman has joined #openstack-nova | 14:29 | |
| *** tbachman_ has joined #openstack-nova | 14:33 | |
| *** tbachman has quit IRC | 14:33 | |
| *** tbachman_ is now known as tbachman | 14:33 | |
| *** amoralej|lunch is now known as amoralej | 14:37 | |
| *** david-lyle has quit IRC | 14:38 | |
| *** salv-orlando has joined #openstack-nova | 14:40 | |
| jaypipes | is it Friday yet? | 14:44 |
| *** alexchadin has quit IRC | 14:45 | |
| dansmith | no | 14:45 |
| dansmith | I can tell because I'm not in a big metal tube with sick people and crying children | 14:45 |
| efried | ^ | 14:46 |
| efried | Anybody got advice for what a guy can do with a 7h layover in NYC? | 14:46 |
| *** liverpooler has joined #openstack-nova | 14:46 | |
| efried | Noting that both the guy in question and his spouse pretty much loathe NYC | 14:47 |
| jaypipes | efried: which airport? | 14:47 |
| *** sahid has joined #openstack-nova | 14:48 | |
| efried | jaypipes: NYC | 14:48 |
| efried | is that an airport? | 14:49 |
| jroll | likely JFK | 14:51 |
| * efried looks at itinerary again. | 14:51 | |
| mriedem | you can forget about it | 14:52 |
| *** awaugama has joined #openstack-nova | 14:52 | |
| efried | Oh, it is JFK | 14:52 |
| mriedem | need another core on https://review.openstack.org/#/c/340614/ - it's not as scary as it looks | 14:52 |
| *** acormier has joined #openstack-nova | 14:52 | |
| * jroll recommends beer | 14:52 | |
| mriedem | ^ has to go back to ocata before eol | 14:52 |
| efried | I thought NYC wasn't an airport. Knew about JFK and LGA... | 14:52 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Convert driver supported capabilities to compute node provider traits https://review.openstack.org/538498 | 14:53 |
| *** yamamoto has joined #openstack-nova | 14:53 | |
| mriedem | my flight to amsterdam is half empty | 14:53 |
| efried | Some might say half full. | 14:54 |
| efried | Interesting inversion of the usual optimist/pessimist viewpoints, that. | 14:54 |
| mriedem | in the case of a flight, i want it to be half empty | 14:54 |
| efried | exactly | 14:54 |
| mriedem | because 'half full' makes me think it's more full than empty, which is the opposite of what i want to be the case | 14:54 |
| hrw | efried: and EWR? | 14:54 |
| *** hoonetorg has quit IRC | 14:54 | |
| jaypipes | efried: when is your JFK layover? | 14:55 |
| efried | EWR is in NJ, nah? | 14:55 |
| *** salv-orlando has quit IRC | 14:55 | |
| jaypipes | efried: yes, that's Newark | 14:55 |
| hrw | efried: ah,yes | 14:55 |
| efried | jaypipes: 1030-1730 | 14:55 |
| *** salv-orlando has joined #openstack-nova | 14:56 | |
| tssurya | dansmith: when you get time could you please circle around https://review.openstack.org/#/c/540073/ and https://review.openstack.org/#/c/542964/ ; just to see if you are happy so that I can move to putting the patch of purging the compute_nodes, resource_providers on top of these (so that its more clean). | 14:56 |
| *** udesale has joined #openstack-nova | 14:56 | |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: disconnect volume from host during detach https://review.openstack.org/515008 | 14:56 |
| openstackgerrit | sahid proposed openstack/nova master: hardware: only take into account small pages https://review.openstack.org/532168 | 14:57 |
| *** lyan has joined #openstack-nova | 14:57 | |
| dansmith | tssurya: yep | 14:57 |
| tssurya | dansmith: thank you | 14:57 |
| jaypipes | efried: you could prolly uber into downtown Brooklyn for a nice little lunch. | 14:57 |
| jaypipes | efried: and go shopping if you fancy that | 14:57 |
| mnaser | my flight to dublin is packed | 14:58 |
| * mnaser wonders if he'll see other people who are heading to the ptg in there | 14:58 | |
| dansmith | mine as well | 14:59 |
| jaypipes | mnaser: from where? | 14:59 |
| mnaser | jaypipes: connecting here and there but jfk => dublin | 14:59 |
| jaypipes | mnaser: same flight as efried? :) | 14:59 |
| *** salv-orlando has quit IRC | 15:00 | |
| jaypipes | mnaser: I'm taking the DUB -> JFK flight back. but taking the ATL -> AMS -> DUB flight over. | 15:00 |
| * efried EI0104 | 15:00 | |
| mnaser | Delta 44 leaving at 9:50 pm and getting there at 9:20 am next day | 15:00 |
| efried | so nope | 15:00 |
| mnaser | 5am arrival | 15:00 |
| mnaser | brave | 15:00 |
| jaypipes | mnaser: yeah, I'm on the Delta flight 45 coming back :) | 15:00 |
| mnaser | jaypipes: hah, i'm on that flight. leaving at 11am and arrivng at 1:50 on saturday | 15:01 |
| jaypipes | mnaser: yup! | 15:01 |
| jaypipes | mnaser: sweet. we can hack together. | 15:01 |
| *** yasemin has joined #openstack-nova | 15:02 | |
| *** trinaths has joined #openstack-nova | 15:02 | |
| mriedem | jaypipes: smcginnis and i are on delta 45 on the way back too | 15:02 |
| mriedem | it's going to be a party | 15:02 |
| jaypipes | mriedem: nice. :) | 15:02 |
| jaypipes | I smell a carpool from the Croke Park hotel. | 15:02 |
| mnaser | lol, let's all get a row of seats, someone mirror a couple repos locally | 15:02 |
| mnaser | :p | 15:02 |
| jaypipes | I'm in 15G. | 15:02 |
| jaypipes | come at me. | 15:02 |
| *** lucasagomes is now known as lucas-hungry | 15:02 | |
| mriedem | 19E | 15:03 |
| mriedem | within shouting distance | 15:03 |
| mnaser | 26A | 15:03 |
| mnaser | lol | 15:03 |
| jaypipes | damn it. | 15:03 |
| mriedem | "hey jay! hey jay!" | 15:03 |
| * jaypipes charges noise-canceling headphones | 15:03 | |
| mnaser | 19D is free if someone wants to bother mriedem | 15:03 |
| mriedem | we can synchronize watching the notebook at the same time | 15:03 |
| mnaser | :P | 15:03 |
| jaypipes | lmao | 15:04 |
| dansmith | so glad I'm not on that flight | 15:04 |
| jaypipes | heh | 15:04 |
| smcginnis | 16F. I can throw things over the seat at jaypipes | 15:04 |
| jaypipes | I'm glad I already had the flu... | 15:04 |
| jaypipes | smcginnis: sweet :) | 15:04 |
| sean-k-mooney | im not sure its a good think to have so many nova people on one plane | 15:05 |
| * mnaser goes to pull a server from the datacenter to bring as check in baggage | 15:05 | |
| mnaser | we'll plug it in and have devstack vms for everyone | 15:05 |
| dansmith | so glad I'm not on that flight | 15:06 |
| mnaser | <insert building clouds in the cloud jokes> | 15:06 |
| dansmith | although maybe the screaming 1U fans will drown out the kid | 15:06 |
| *** moshele has joined #openstack-nova | 15:06 | |
| *** eharney has joined #openstack-nova | 15:06 | |
| *** r-daneel has joined #openstack-nova | 15:07 | |
| cdent | https://youtu.be/B3lsJmwNO40?t=40 | 15:07 |
| dansmith | tssurya: your second one needs to be rebased on the first right? | 15:08 |
| jaypipes | mnaser: lol, that's awesome :) | 15:08 |
| jaypipes | dansmith: yeah, my thoughts precisely. | 15:08 |
| tssurya | dansmith: no I guess they are independent changes ? | 15:09 |
| mnaser | this needs backporting eventually so i'd love some extra eyes on it, it should be ready for final review - https://review.openstack.org/#/c/340614/ :> | 15:09 |
| mriedem | already fished for that one | 15:10 |
| tssurya | dansmith: the new change I will have using --force depends on these | 15:10 |
| dansmith | tssurya: they're independent, but they will conflict.. i.e. if the first one merges, the second one can't until you rebase, | 15:10 |
| dansmith | so if you rebase now, then both can land | 15:10 |
| dansmith | you don't have to, it'll just be better if you do.. your call :) | 15:11 |
| tssurya | dansmith : oh okay, yes will rebase the second | 15:11 |
| *** dtantsur is now known as dtantsur|brb | 15:11 | |
| *** moshele has quit IRC | 15:11 | |
| *** trinaths has quit IRC | 15:12 | |
| *** tidwellr has joined #openstack-nova | 15:13 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Unmap compute nodes when deleting host mappings in delete cell operation https://review.openstack.org/542964 | 15:13 |
| *** vladikr has quit IRC | 15:13 | |
| *** moshele has joined #openstack-nova | 15:13 | |
| *** amodi has joined #openstack-nova | 15:14 | |
| *** itlinux has quit IRC | 15:16 | |
| bauzas | heh, hoping that flights won't have problems, or nova would miss lots of people :p | 15:17 |
| *** sree_ has joined #openstack-nova | 15:19 | |
| *** sree_ is now known as Guest4403 | 15:19 | |
| jaypipes | mnaser: damn. 2.5 year old patch. | 15:19 |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP: experment with setting placement error codes https://review.openstack.org/546177 | 15:20 |
| mnaser | jaypipes: it bit us a few days ago and the work to make it functional and tested was done with help of melwitt and mriedem (you can look at some of the patches before which already merged) | 15:21 |
| *** mlavalle has joined #openstack-nova | 15:21 | |
| *** moshele has quit IRC | 15:21 | |
| *** slaweq has quit IRC | 15:23 | |
| *** slaweq has joined #openstack-nova | 15:24 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP: experiment with setting placement error codes https://review.openstack.org/546177 | 15:25 |
| *** hoonetorg has joined #openstack-nova | 15:25 | |
| mnaser | bauzas: thank you for the reviews | 15:26 |
| bauzas | np, here to help | 15:26 |
| *** vladikr has joined #openstack-nova | 15:26 | |
| bauzas | damn, I found the perfect opportunity for bringing a Chartreuse bottle with me if I buy it at my local airport, but since I'll be connecting thru LHR, there are chances that customs would take it there | 15:27 |
| *** slaweq has quit IRC | 15:28 | |
| mnaser | mriedem: can i update the commit message if you're busy to https://review.openstack.org/#/c/545132 so that we can merge it (server => volume)? | 15:28 |
| mriedem | mnaser: i can update it quick | 15:30 |
| mriedem | we'll lose mel's +2 | 15:30 |
| jaypipes | mriedem, dansmith, bauzas, melwitt: I'm good with efried's https://review.openstack.org/#/c/546009/. seems like a very simple API enhancement that will yield positive performance impacts. | 15:31 |
| mnaser | mriedem: always bothered me that updating commit messages drops +2's but ehh.. if you think its fine and can convince someone to review and +A then even better :p | 15:31 |
| mnaser | i just want to follow the patch through gates and get it backported (hopefully cleanly) | 15:32 |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP: experiment with setting placement error codes https://review.openstack.org/546177 | 15:33 |
| *** mdnadeem has quit IRC | 15:33 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Clean up ports and volumes when deleting ERROR instance https://review.openstack.org/340614 | 15:33 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional recreate test of deleting a BFV server pre-scheduling https://review.openstack.org/545123 | 15:33 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Detach volumes when deleting a BFV server pre-scheduling https://review.openstack.org/545132 | 15:33 |
| mriedem | ah shit | 15:34 |
| mriedem | bauzas: ^ can you re-approve those bottom 2? | 15:34 |
| efried | mriedem: Dangit, where's that placement doc with the "creating a new microversion" checklist? | 15:34 |
| *** cfriesen has joined #openstack-nova | 15:34 | |
| mriedem | https://docs.openstack.org/nova/latest/search.html | 15:34 |
| bauzas | mriedem: sure thing | 15:35 |
| cdent | efried: this one? https://docs.openstack.org/nova/latest/contributor/placement.html | 15:35 |
| efried | cdent, mriedem: yup, thank you. | 15:35 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Unmap compute nodes when deleting host mappings in delete cell operation https://review.openstack.org/542964 | 15:36 |
| bauzas | mriedem: considering https://bugs.launchpad.net/nova/+bug/1740025 | 15:36 |
| openstack | Launchpad bug 1740025 in OpenStack Compute (nova) "LVM Sparse Volumes broken" [Undecided,New] | 15:36 |
| bauzas | WDYT about deprecating the LVM sparse stuff ? | 15:36 |
| efried | cdent: I wouldn't be offended if that linked off of either/both of https://developer.openstack.org/api-ref/placement/ https://docs.openstack.org/nova/latest/user/placement.html | 15:37 |
| efried | certainly the latter | 15:37 |
| mriedem | bauzas: don't know anything about it, but i think cfriesen does | 15:37 |
| mriedem | efried: user docs don't really need to link to dev docs | 15:38 |
| efried | Guess it depends on your definition of "user". | 15:38 |
| mriedem | user != contributor writing code etc | 15:38 |
| mriedem | imo | 15:38 |
| efried | I would think there's enough crossover that such a link wouldn't hurt. | 15:38 |
| efried | but whatevs. Now it's permanently open in a tab for me, so I don't care anymore. | 15:39 |
| cdent | A "if you're curious about this stuff, seem dev notes" kind of link on the user might be useful for some (but could also confuse some) but having it on the api-ref: meh | 15:39 |
| dansmith | mriedem: can you drop your -1 on this at least? https://review.openstack.org/#/c/543580/ | 15:39 |
| mriedem | or just https://docs.openstack.org/nova/latest/contributor/ | 15:39 |
| mriedem | dansmith: that's the least i can do | 15:40 |
| mriedem | dansmith: so those grenade results were just due to old setup? | 15:40 |
| bauzas | mriedem: okay, fair enough | 15:40 |
| dansmith | mriedem: yeah, from doing a pike->master upgrade | 15:40 |
| bauzas | mriedem: the problem I see with LVM sparse LVs is that I guess nothing was checked | 15:41 |
| dansmith | mriedem: the auto selection was choosing the right version, and master was rightly saying "I don't speak that version, yo" | 15:41 |
| mriedem | hmm | 15:41 |
| mriedem | with that 90s rap slang? | 15:41 |
| dansmith | mriedem: obviously | 15:41 |
| mriedem | ok; it's in a tab | 15:42 |
| dansmith | mriedem: "this is how we dooooo, RPC versioning" | 15:42 |
| *** kholkina_ has joined #openstack-nova | 15:42 | |
| mriedem | oh btw you might want to punch any red hat infra people about https://review.openstack.org/#/c/546183/ | 15:42 |
| mriedem | because it turns out we have http://grafana.openstack.org/dashboard/db/ceph-failure-rate | 15:42 |
| mriedem | but it's been broken since october | 15:42 |
| *** kholkina has quit IRC | 15:43 | |
| dansmith | mriedem: I was taught not to punch people | 15:43 |
| mriedem | wet willy some red hat infra people | 15:43 |
| dansmith | mriedem: unless they were wrong or said something I didn't like | 15:43 |
| dansmith | hah, eww | 15:43 |
| *** kholkina_ has quit IRC | 15:47 | |
| *** salv-orlando has joined #openstack-nova | 15:47 | |
| hrw | https://marcin.juszkiewicz.com.pl/2018/02/19/hotplug-in-vm-easy-to-say/ - a story about https://review.openstack.org/#/c/545034/ patch (which waits for reviewers) | 15:47 |
| *** david-lyle has joined #openstack-nova | 15:47 | |
| bauzas | mriedem: okay, so I did set Wontfix for https://bugs.launchpad.net/nova/+bug/1740025 given my last comment | 15:50 |
| openstack | Launchpad bug 1740025 in OpenStack Compute (nova) "LVM Sparse Volumes broken" [Undecided,Won't fix] | 15:50 |
| mriedem | bauzas: if the fix is to deprecate the sparse_logical_volumes option, then it shouldn't really be 'wont fix' | 15:54 |
| *** Guest72183 has quit IRC | 15:54 | |
| mriedem | unless you're just gonna related-bug that thing | 15:54 |
| bauzas | mriedem: I'll deprecate the conf opt by passing a related-bug, yes | 15:55 |
| bauzas | Wontfix is exactly for like "sorry, we know it doesn't work, but we don't plan to fix it" | 15:55 |
| bauzas | and that bug is the exact reason why we should deprecate that option | 15:55 |
| mriedem | bauzas: did you take a look at https://review.openstack.org/#/c/545132/ ? | 15:56 |
| mriedem | you +W'ed the regression recreate test | 15:56 |
| *** ingy has quit IRC | 15:56 | |
| mriedem | mnaser: you should be able to start backports for that series | 15:56 |
| *** trinaths has joined #openstack-nova | 15:57 | |
| bauzas | mriedem: not yet, because I need to think about it | 16:01 |
| *** takedakn has joined #openstack-nova | 16:02 | |
| bauzas | ie. if the call is made in the right place | 16:02 |
| bauzas | and if we're not missing anything | 16:02 |
| bauzas | the change itself is easy to review | 16:02 |
| *** slaweq has joined #openstack-nova | 16:03 | |
| mnaser | mriedem: i'll start doing that | 16:04 |
| bauzas | mgoddard: saw your comment on https://bugs.launchpad.net/nova/+bug/1739735 looks like it's a new feature, right? | 16:05 |
| openstack | Launchpad bug 1739735 in OpenStack Compute (nova) "boot baremetal server which has multi-interface will randomly choose baremetal server interface" [Undecided,New] | 16:05 |
| *** takedakn has quit IRC | 16:05 | |
| *** afazekas is now known as afazekas|air | 16:05 | |
| *** itlinux has joined #openstack-nova | 16:06 | |
| *** dtantsur|brb is now known as dtantsur | 16:06 | |
| *** sshwarts has quit IRC | 16:06 | |
| cfriesen | mriedem: bauzas: I haven't used the LVM sparse stuff, we do use thinly-provisioned LVM internally. | 16:08 |
| bauzas | heh | 16:08 |
| bauzas | I'm pretty sure that if you used it, you'd discovered problems: p | 16:09 |
| bauzas | it's a canary in a coal mine :p | 16:09 |
| bauzas | artom: around ? | 16:10 |
| bauzas | artom: do you think that https://bugs.launchpad.net/nova/+bug/1739735 is solvable by http://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/virt-device-tagged-attach-detach.html ? | 16:10 |
| openstack | Launchpad bug 1739735 in OpenStack Compute (nova) "boot baremetal server which has multi-interface will randomly choose baremetal server interface" [Undecided,New] | 16:10 |
| bauzas | artom: ie. using the ironic driver | 16:10 |
| mriedem | dansmith: in https://review.openstack.org/#/c/543580/ - why do you remove defaults for kwargs in some methods but not others? | 16:10 |
| *** burt has joined #openstack-nova | 16:10 | |
| dansmith | mriedem: because those are things that were added as optional just for compatibility when adding a new param that really should be passed all the time | 16:11 |
| cfriesen | bauzas: we have internal patches to add support for thin lvm to nova. also to enable cold-migration and resize for LVM-backed instances | 16:11 |
| dansmith | mriedem: if it was a thing we added in 4.x and expect to always pass, but made it optional so the tests would pass without having to touch it, I made it required here and fixed up the tests | 16:12 |
| dansmith | mriedem: or at least, that was the intent | 16:12 |
| bauzas | cfriesen: see https://bugs.launchpad.net/nova/+bug/1740025/comments/3 | 16:12 |
| openstack | Launchpad bug 1740025 in OpenStack Compute (nova) "LVM Sparse Volumes broken" [Undecided,Won't fix] | 16:12 |
| bauzas | cfriesen: I seriously consider deprecating that possibility | 16:12 |
| bauzas | at least the config option | 16:12 |
| mriedem | dansmith: hmm, well not all are like that, like rebuild_instance shouldn't require host/node | 16:13 |
| dansmith | mriedem: which line? | 16:13 |
| mriedem | https://review.openstack.org/#/c/543580/1/nova/compute/rpcapi.py@721 | 16:13 |
| *** ccamacho has quit IRC | 16:13 | |
| bauzas | jroll: trying to get Ironic's eyes for https://bugs.launchpad.net/nova/+bug/1739735 | 16:14 |
| openstack | Launchpad bug 1739735 in OpenStack Compute (nova) "boot baremetal server which has multi-interface will randomly choose baremetal server interface" [Undecided,New] | 16:14 |
| cfriesen | bauzas: I'd be fine with that. :) One main reason we added support for thin volumes was that zeroing out the volumes was incredibly disk-intensive. By using thin we only zero out the blocks as they are allocated. | 16:14 |
| mriedem | dansmith: nvm, | 16:14 |
| mriedem | i was thinking of the conductor / compute task rpcapi | 16:14 |
| bauzas | cfriesen: cool | 16:14 |
| mriedem | conductor will always pass host/node to the compute rebuild_instance | 16:14 |
| jroll | bauzas: will look / pass along | 16:14 |
| *** hongbin has joined #openstack-nova | 16:14 | |
| bauzas | jroll: mgoddard provided a comment | 16:14 |
| mriedem | even if it's just None | 16:15 |
| bauzas | jroll: but I'm unclear if/how that makes that bug fixable | 16:15 |
| *** links has joined #openstack-nova | 16:15 | |
| dansmith | mriedem: it's just super hard to reason about a lot of these calls where everything is optional, except not really | 16:15 |
| jroll | bauzas: will look / pass along, I'm in the middle of something | 16:15 |
| bauzas | jroll: FWIW, we also have http://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/virt-device-tagged-attach-detach.html that helps setting network devices | 16:15 |
| dansmith | mriedem: so later when you start depending on a parameter that has been required for three years, and some random unit test fails.. | 16:15 |
| *** yamahata has joined #openstack-nova | 16:15 | |
| bauzas | jroll: np, take your time | 16:15 |
| bauzas | jroll: if you could just comment that bug, that'd be awesome | 16:15 |
| bauzas | because I'm blind for triaging it :) | 16:16 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/queens: Drop extra loop which modifies Cinder volume status https://review.openstack.org/546200 | 16:16 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/queens: Store block device mappings in cell0 https://review.openstack.org/546201 | 16:16 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/queens: Add functional tests to ensure BDM removal on delete https://review.openstack.org/546202 | 16:16 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/queens: Clean up ports and volumes when deleting ERROR instance https://review.openstack.org/546203 | 16:16 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/queens: Add functional recreate test of deleting a BFV server pre-scheduling https://review.openstack.org/546204 | 16:16 |
| *** pcaruana has quit IRC | 16:21 | |
| *** vladikr_ has joined #openstack-nova | 16:21 | |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Drop extra loop which modifies Cinder volume status https://review.openstack.org/546218 | 16:22 |
| jroll | bauzas: commented - bug is "this is not deterministic", mgoddard's comment shows the tools to make it deterministic :) | 16:23 |
| bauzas | jroll: ta | 16:23 |
| bauzas | yeah, I understood the problem | 16:23 |
| bauzas | it's not deterministic | 16:23 |
| *** vladikr has quit IRC | 16:23 | |
| bauzas | but that's also why we have http://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/virt-device-tagged-attach-detach.html | 16:23 |
| *** lucas-hungry is now known as lucasagomes | 16:24 | |
| jroll | bauzas: I feel like I would need to read a lot of words to understand if that helps us :) | 16:24 |
| *** acormier has quit IRC | 16:25 | |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Store block device mappings in cell0 https://review.openstack.org/546219 | 16:25 |
| *** acormier has joined #openstack-nova | 16:25 | |
| cdent | mriedem: if you want to restore https://review.openstack.org/#/c/418393/ I've got something to push there | 16:25 |
| bauzas | jroll: anyway => Wontfix | 16:25 |
| mriedem | cdent: done | 16:25 |
| *** slaweq_ has joined #openstack-nova | 16:25 | |
| cdent | thanks | 16:26 |
| openstackgerrit | Chris Dent proposed openstack/nova-specs master: Provide error codes for placement API https://review.openstack.org/418393 | 16:26 |
| *** AlexeyAbashkin has quit IRC | 16:26 | |
| *** Guest4403 has quit IRC | 16:26 | |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Add functional tests to ensure BDM removal on delete https://review.openstack.org/546220 | 16:26 |
| *** sidx64 has quit IRC | 16:27 | |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Clean up ports and volumes when deleting ERROR instance https://review.openstack.org/546221 | 16:30 |
| *** salladi has joined #openstack-nova | 16:30 | |
| *** ragiman has quit IRC | 16:30 | |
| *** slaweq_ has quit IRC | 16:30 | |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Add functional recreate test of deleting a BFV server pre-scheduling https://review.openstack.org/546222 | 16:31 |
| *** tidwellr has quit IRC | 16:31 | |
| mnaser | well, that was fun, now onto the one which will be the most fun, ocata. | 16:31 |
| zigo | When building nova in Sid with Python 3.6, I get this unit test error: http://paste.openstack.org/show/678793/ | 16:31 |
| zigo | Has this been reported already? | 16:31 |
| *** tidwellr has joined #openstack-nova | 16:32 | |
| *** stvnoyes has quit IRC | 16:33 | |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/ocata: Drop extra loop which modifies Cinder volume status https://review.openstack.org/546223 | 16:33 |
| *** yassine has joined #openstack-nova | 16:35 | |
| cdent | zigo: yes, and fixed, one sec, I'll get you some links | 16:35 |
| *** yassine is now known as Guest87022 | 16:35 | |
| cdent | zigo: https://review.openstack.org/#/c/545798/ has links to bugs etc | 16:35 |
| *** udesale has quit IRC | 16:36 | |
| artom | bauzas, hey | 16:36 |
| bauzas | artom: no worries, we closed the bug | 16:36 |
| * bauzas is calling it a day FWIW | 16:36 | |
| artom | bauzas, aha, I see | 16:36 |
| artom | bauzas, byez | 16:37 |
| *** sapcc-bot has quit IRC | 16:37 | |
| *** sapcc-bot has joined #openstack-nova | 16:37 | |
| bauzas | mriedem, melwitt, others : I won't be around tomorrow (PTO for skiing), so see you on Thursday for those that aren't yet flighting :) | 16:38 |
| bauzas | flying* even | 16:38 |
| bauzas | man, my English hurts | 16:38 |
| bauzas | \o | 16:38 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/ocata: Store block device mappings in cell0 https://review.openstack.org/546226 | 16:38 |
| *** yamamoto has quit IRC | 16:38 | |
| bauzas | mnaser: I'll review your stable changes once I'm back on Thursday | 16:39 |
| mnaser | bauzas: no worries. i'll get them all in and make sure they pass CI.. i think some might need some test changes because some function signatures are different | 16:39 |
| mriedem | dansmith: checking my understanding here https://review.openstack.org/#/c/543580/1/nova/compute/rpcapi.py@a1265 - we have some REST API handler code for compat exceptions raised from the compute rpcapi client; but we can't remove that handling in the api in queens because we could still have queens computes sending those errors? | 16:40 |
| dansmith | mriedem: s/queens/rocky? | 16:40 |
| mriedem | i'm lost | 16:41 |
| dansmith | mriedem: anything queens could handle, but was being compat for pike should be remove-able in rocky | 16:41 |
| mriedem | some of these are compat for things added in queens | 16:41 |
| mriedem | like the multiattach exception in reserve_block_device_name | 16:41 |
| dansmith | compat for pike.5 right? | 16:42 |
| dansmith | meaning, | 16:42 |
| mriedem | https://review.openstack.org/#/c/543580/1/nova/compute/rpcapi.py@a1044 | 16:42 |
| dansmith | queens could handle it | 16:42 |
| dansmith | but something between pike and queens could not | 16:42 |
| dansmith | right, so you can't handle 4.x clients at all anymore in rocky after this, | 16:42 |
| dansmith | but all queens (release) nodes can, and that's as far back as this supports | 16:42 |
| dansmith | if you tried to pin to 4.15 in that case, you'd get the failure we saw in the early grenade run anyway, well before you got to this point | 16:43 |
| mriedem | so i can't upgrade my api to rocky until all of my computes have been upgraded to queens right? | 16:43 |
| dansmith | right, but that's the case anyway, per the rules | 16:43 |
| mriedem | well, | 16:44 |
| mriedem | we've had compat code in the api for lots of different cases | 16:44 |
| mriedem | which is why i was wondering about this | 16:44 |
| mriedem | the api has code to handle mixed version computes | 16:44 |
| dansmith | right, but once that gap is more than N-1 it's technically out of scope, | 16:44 |
| dansmith | even if we leave it for longer | 16:44 |
| dansmith | if we really need to be defensive in the api about something, we should probably be looking at service version, | 16:45 |
| dansmith | but we can't just look for those forever, which is why we have rules about the gaps | 16:45 |
| *** yamamoto has joined #openstack-nova | 16:45 | |
| mriedem | i don't know if that rule is written down anywhere | 16:46 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/ocata: Add functional tests to ensure BDM removal on delete https://review.openstack.org/546227 | 16:46 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/ocata: Clean up ports and volumes when deleting ERROR instance https://review.openstack.org/546228 | 16:46 |
| mriedem | which is a question that gets asked every 6 months or so | 16:46 |
| *** andreas_s has quit IRC | 16:46 | |
| dansmith | the rule that we only support N-1? | 16:46 |
| *** gyee has joined #openstack-nova | 16:46 | |
| mriedem | in other words, | 16:46 |
| mriedem | i think one could upgrade the api to queens while they have pike computes and it's fine, but when they upgrade the api to rocky, their computes have to all be queens | 16:46 |
| mriedem | so it's a bit different behavior | 16:46 |
| mriedem | but then multinode grenade wouldn't work...so that doesn't make sense | 16:47 |
| sean-k-mooney | QQ anyone know if the regex support in the pci whitelist allow negation? basical i want to say whitlist vf where vendor_id=x product_id=y and pci_adress is not z | 16:47 |
| cfriesen | what's the criteria for when we expect to create a Migration record on a rebuild? | 16:47 |
| mriedem | cfriesen: a rebuild isn't a migration so never | 16:48 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/ocata: Add functional recreate test of deleting a BFV server pre-scheduling https://review.openstack.org/546230 | 16:48 |
| cfriesen | mriedem: what about evacuate or rebuild-to-new-server? | 16:49 |
| mriedem | dansmith: here is an example of one of these things that i'd like to remove from the api https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L1138 | 16:49 |
| mriedem | cfriesen: the api creates the migration record for evacuate | 16:49 |
| mriedem | cfriesen: you could just look at the code | 16:49 |
| * mnaser exhales | 16:49 | |
| mnaser | i'm sure i messed up a conflict somewhere, i have to | 16:49 |
| cfriesen | I am, but it wasn't obvious who was creating it...the ComputeManager code just does a "look it up if it exists and log if it doesn't" | 16:50 |
| dansmith | mriedem: yeah, so if your api is on rocky past this commit, you (obviously) can't hit that, nor can you detect that it won't be supported unless you go by service version | 16:50 |
| cfriesen | or rather, that's the ConductorManager code | 16:50 |
| *** yamamoto has quit IRC | 16:50 | |
| dansmith | mriedem: if you have configured your upgrade_levels to attempt to allow talking to older than queens nodes, you would have failed to start the api service entirely because rpc client setup will fail | 16:50 |
| *** sree_ has joined #openstack-nova | 16:51 | |
| *** sree_ is now known as Guest64887 | 16:51 | |
| *** amodi has quit IRC | 16:53 | |
| *** yamamoto has joined #openstack-nova | 16:55 | |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Add functional tests to ensure BDM removal on delete https://review.openstack.org/546220 | 16:55 |
| *** ingy has joined #openstack-nova | 16:55 | |
| *** r-daneel has quit IRC | 16:55 | |
| *** chyka has joined #openstack-nova | 16:55 | |
| mriedem | dansmith: so wondering if we should have an upgrade release note saying you can do rolling upgrades of your computes, but don't upgrade your api until all computes are at least rocky | 16:56 |
| dansmith | mriedem: well, I don't think that we do because I feel like that is the rule, so calling it out makes this sound special when it's really not | 16:56 |
| dansmith | mriedem: I'd rather clarify it in the docs somewhere if you think that's necessary | 16:57 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/ocata: Add functional tests to ensure BDM removal on delete https://review.openstack.org/546227 | 16:57 |
| doude | Hi jaypipes, could you have a look to that fix https://review.openstack.org/#/c/533212/ ? It's about a bug appeared when Contrail VIF vrouter plugging was moved under privsep. Not sure you are the person I should ping for that but I don't know how to proceed now. I proposed the fix mid-January and I think I'll miss the Queens release :( | 16:57 |
| dansmith | we've had other cases before where if you spanned the N-1 gap you'd have much less obvious issues, and certainly the last rpc bump was the same | 16:57 |
| mriedem | dansmith: i don't think https://docs.openstack.org/nova/latest/user/upgrade.html#rolling-upgrade-process is very clear about it | 16:58 |
| mriedem | 3rd bullet under #2 | 16:59 |
| *** yamamoto has quit IRC | 16:59 | |
| mriedem | if i'm reading that correctly, it's saying bring down the control plane services, with nova-api last (ok), but then the next bullet is talking about rolling through the computes | 16:59 |
| dansmith | mriedem: "This results in a condition where both old (N) and new (N+1) nova-compute services co-exist for a certain time period." | 17:00 |
| dansmith | that's all that promises | 17:00 |
| dansmith | but, if it's not clear, let's be clear about it | 17:00 |
| dansmith | but I really don't want to get into the habit of trying to call out problematic releases more than others so that people think if it's not called out for a given release then they should expect it to work | 17:01 |
| mriedem | that's fine, | 17:01 |
| *** itlinux has quit IRC | 17:02 | |
| mriedem | but then i need to understand if what some of the api compat code was doing via the compute rpcapi client was wrong, so we don't continue that pattern | 17:02 |
| mriedem | because it's in several different compute rpcapi methods | 17:02 |
| *** tidwellr has quit IRC | 17:02 | |
| dansmith | mriedem: I don't think it's wrong, | 17:02 |
| *** tidwellr has joined #openstack-nova | 17:02 | |
| dansmith | mriedem: at some point the api needs to assume it can make a call and it will work | 17:03 |
| mriedem | ok, so that means, any of these compat checks in compute rpcapi made *before* queens are OK to remove | 17:03 |
| dansmith | if the operator has set up something wrong or created some unsupportable scenario, a 5xx error code from the api is correct rihgt? | 17:03 |
| *** slaweq has quit IRC | 17:03 | |
| dansmith | I think any that were made *in* queens are good to remove | 17:03 |
| dansmith | we can't detect or honor any of them made for scenarios before 5.0 | 17:04 |
| dansmith | (in or before, in case it's not clear) | 17:04 |
| mriedem | yeah, so then what the api could gracefully handle in queens, it cannot in rocky | 17:04 |
| dansmith | right | 17:04 |
| mriedem | but, | 17:04 |
| *** itlinux has joined #openstack-nova | 17:04 | |
| cfriesen | In stable/pike if we do a rebuild-to-same-node with a new image, it results in ComputeManager.rebuild_instance() being called with "scheduled_node=<hostname>" and "recreate=False". This results in a new Claim, which seems wrong since we're not changing the flavor and that claim could fail if the compute node is already full. | 17:05 |
| mriedem | we don't explicitly say the api can do that | 17:05 |
| mriedem | is what you're saying, right? | 17:05 |
| *** stvnoyes has joined #openstack-nova | 17:05 | |
| mriedem | you can have N control services and N and N-1 compute services, fin. | 17:05 |
| dansmith | mriedem: we've said the api can be one rev newer than the computes, so our api code needs to handle the case where some computes don't support a function because they're N-1, and we do | 17:05 |
| mriedem | no guarantees that the API will support the N-1 computes | 17:06 |
| dansmith | as of this moment, api code for rocky can't have any computes that don't support things | 17:06 |
| dansmith | no, we guarantee the api will support N-1 computes | 17:06 |
| dansmith | but not N-2 | 17:06 |
| dansmith | and at the moment, N-1 computes can do all the things of the N ones, so no checks are needed | 17:06 |
| *** artom has quit IRC | 17:09 | |
| *** Guest64887 has quit IRC | 17:09 | |
| *** tbachman has quit IRC | 17:10 | |
| *** moshele has joined #openstack-nova | 17:11 | |
| mriedem | cfriesen: that's a regression | 17:12 |
| mriedem | yet another one | 17:12 |
| dansmith | gawd | 17:12 |
| *** sree_ has joined #openstack-nova | 17:12 | |
| *** r-daneel has joined #openstack-nova | 17:13 | |
| *** sree_ is now known as Guest35518 | 17:13 | |
| mriedem | i don't know why this isn't just "if recreate: | 17:13 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2866 | 17:13 |
| mriedem | recreate == evacuate == always do a claim | 17:13 |
| mriedem | this is stale: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2854 | 17:14 |
| mriedem | since the new crap to consult the scheduler if the image changes | 17:14 |
| *** tbachman has joined #openstack-nova | 17:14 | |
| mriedem | cfriesen: open a bug | 17:15 |
| mriedem | it's a regression from I11746d1ea996a0f18b7c54b4c9c21df58cc4714b | 17:16 |
| cfriesen | mriedem: will do | 17:16 |
| *** amodi has joined #openstack-nova | 17:18 | |
| *** Guest35518 has quit IRC | 17:20 | |
| cfriesen | mriedem: https://bugs.launchpad.net/nova/+bug/1750618 | 17:20 |
| openstack | Launchpad bug 1750618 in OpenStack Compute (nova) "rebuild to same host with a different image results in erroneously doing a Claim" [Undecided,New] | 17:20 |
| mriedem | cfriesen: are you going to post a patch? | 17:21 |
| mriedem | i think it's just changing that one line | 17:21 |
| cfriesen | just change it to only check "recreate" and ignore "scheduled_node"? yeah, I can post that | 17:22 |
| cfriesen | I guess we'd need a new unit test? | 17:23 |
| *** harlowja has joined #openstack-nova | 17:23 | |
| cfriesen | or a tweak to one of the existing ones to check if we're doing a real claim | 17:23 |
| mriedem | i guess, there might already be one that has to change, | 17:23 |
| mriedem | the problem here isn't in unit tests, | 17:23 |
| mriedem | the problem is the fact that rebuild/evacuate is so tightly coupled between api, conductor and compute, and what the assumptions are between all of them about what the other is doing | 17:24 |
| cfriesen | fair enough | 17:24 |
| mriedem | so changing anything in one breaks the others | 17:24 |
| mriedem | a solid test would be a functional rebuild test with a new image that asserts that we never do a claim | 17:24 |
| mriedem | i know we have functional tests that do a rebuild with a new image, | 17:24 |
| mriedem | but it's using the fake driver so likely the claim stuff was never a problem | 17:25 |
| mriedem | there might be a way to poison the claim such that if it's called, it will fail | 17:25 |
| *** moshele has quit IRC | 17:25 | |
| openstackgerrit | Merged openstack/nova master: Check quota before creating volume snapshots https://review.openstack.org/520158 | 17:25 |
| *** trinaths has quit IRC | 17:26 | |
| *** imacdonn has joined #openstack-nova | 17:27 | |
| mriedem | cfriesen: functional test 'test_rebuild_with_new_image' should probably be tweaked | 17:27 |
| mriedem | such that if nova.compute.resource_tracker.ResourceTracker.rebuild_claim is called, it blows up | 17:27 |
| cfriesen | will take a look. | 17:28 |
| *** lpetrut has quit IRC | 17:30 | |
| mriedem | bauzas: melwitt was +2 on https://review.openstack.org/#/c/545132/ before i updated the commit message, can you just proxy her +2 and approve so we can do backports? | 17:30 |
| dansmith | jaypipes: cdent which of you was going to work on the placement api change to allow passing aggregates? | 17:33 |
| cfriesen | mriedem: for the rebuild-on-same-host-with-different-image case, if it runs through the scheduler could it fail due to placement if there isn't room for another one of itself on its current compute node? | 17:33 |
| *** slaweq has joined #openstack-nova | 17:34 | |
| mriedem | cfriesen: we don't claim in that case | 17:35 |
| cdent | dansmith: I probably _can_ do it, but I haven't made plans to do it | 17:35 |
| mriedem | although i guess it's possible that placement could return 0 allocation candidates and we'd get a novalidhost | 17:35 |
| dansmith | cdent: _would_ you do it? :) | 17:36 |
| cfriesen | mriedem: yeah, that's what I was thinking | 17:36 |
| cfriesen | mriedem: we need to validate the image properties of the new image against the current host though | 17:36 |
| *** pcaruana has joined #openstack-nova | 17:36 | |
| cdent | dansmith: I'm on the phone, so don't want to make promises, but if it needs someone it can probalby be me | 17:37 |
| *** links has quit IRC | 17:37 | |
| edleafe | dansmith: cdent: I may also have bandwidth for that | 17:37 |
| dansmith | edleafe: that'd be cool | 17:38 |
| *** slaweq has quit IRC | 17:39 | |
| mriedem | cfriesen: as far as i can tell, we don't do any manipulation of the request spec for rebuild with a new image such that we try to fake out placement to not try and double allocate the vcpu/memory_mb/disk_gb | 17:40 |
| mriedem | we do tell the scheduler exactly which host/node we want, and we tell some filters to not run on it again, | 17:40 |
| mriedem | but if placement doesn't return the source host then we'll have novalidhost and we can't rebuild with the new image | 17:41 |
| *** Jams_ has joined #openstack-nova | 17:42 | |
| mriedem | if placement does return the node we want, we don't double the allocations in placement, but we do attempt a claim on the compute as you found out | 17:42 |
| *** derekh has quit IRC | 17:42 | |
| *** elod has quit IRC | 17:43 | |
| mriedem | if the node is full, we likely won't even get to the compute to attempt the faulty claim... | 17:43 |
| mriedem | b/c placement would have filtered it out | 17:43 |
| cfriesen | before placement did the "_nova_check_type" flag tell us to skip over the resource filters? | 17:44 |
| cdent | dansmith, edleafe: sorry wasn't really paying attention, which thing is this that needs a doer? | 17:44 |
| mriedem | cfriesen: that flag was added long after placement was used in the scheduler, | 17:44 |
| cdent | but am off phone now | 17:45 |
| cfriesen | ah, okay | 17:45 |
| mriedem | but yes that flag is used to tell which scheduler filters to run, and to not make a claim in placement | 17:45 |
| mriedem | but it doesn't say 'don't use placement at all' | 17:45 |
| cfriesen | open another bug? | 17:45 |
| mriedem | request_is_rebuild could probably be used to completely bypass placement and just pull the compute node record from the db | 17:45 |
| dansmith | cdent: the member_of aggregate add to allocation_candidates api | 17:46 |
| mriedem | cfriesen: idk | 17:46 |
| jaypipes | doude: is this something that only recently started failing? I'm struggling to pinpoint when the privsep (which from what I can tell has used msgpack for a while) started failing | 17:46 |
| mriedem | cfriesen: after working on and breaking and regressing and trying to fix this rebuild with new image + scheduler thing for like the last 4 months, i don't really have any stomach for it anymore | 17:46 |
| mriedem | cfriesen: if you want to report a bug just so it's tracked as a known issue, sure | 17:47 |
| cdent | dansmith: thanks. edleafe and I will wrestle for it in dublin | 17:47 |
| dansmith | jaypipes: it'd be after mikal privsep'd the libvirt driver recently | 17:47 |
| dansmith | cdent: rock on | 17:47 |
| cfriesen | mriedem: yeah, that's what I was thinking. we have a customer that'll probably end up complaining about it in a year or so when they get to pike | 17:48 |
| dansmith | jaypipes: I'm sure we have no real tests for that code and that driver, so it popped up when we released queens and someone tried it | 17:48 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Drop API compat handling for old compute error cases https://review.openstack.org/546256 | 17:49 |
| mriedem | cfriesen: it's not just pike | 17:49 |
| mriedem | cfriesen: that original regression was for a cve, | 17:50 |
| mriedem | that went back to newton upstream, | 17:50 |
| mriedem | and further downstream | 17:50 |
| mriedem | depending on how long you support old relases | 17:50 |
| mriedem | *releases | 17:50 |
| mriedem | it's the cve that keeps on giving | 17:50 |
| mriedem | i guess the only difference with pike would be placement.. | 17:50 |
| mriedem | in the scheduler i mean | 17:50 |
| openstackgerrit | Chris Dent proposed openstack/nova-specs master: Provide error codes for placement API https://review.openstack.org/418393 | 17:52 |
| *** slaweq has joined #openstack-nova | 17:52 | |
| *** sahid has quit IRC | 17:52 | |
| cfriesen | mriedem: right, just saw your comment. will have to see if we've backported the bug. | 17:53 |
| mriedem | i'm going to go eat my feelings | 17:53 |
| sean-k-mooney | anyone know if there is documentation on what constitutes a minimal legal virt driver implementation? | 17:54 |
| penick | As well you should. | 17:54 |
| cfriesen | mriedem: just for info, the placement issue is https://bugs.launchpad.net/nova/+bug/1750623 | 17:55 |
| openstack | Launchpad bug 1750623 in OpenStack Compute (nova) "rebuild to same host with different image shouldn't check with placement" [Undecided,New] | 17:55 |
| *** yamamoto has joined #openstack-nova | 17:55 | |
| sean-k-mooney | cfriesen: rebuilds on the same host are disabled by default correct so that bug will only be present if they are enabled? | 17:56 |
| *** salladi has quit IRC | 17:56 | |
| *** slaweq has quit IRC | 17:57 | |
| *** AlexeyAbashkin has joined #openstack-nova | 17:57 | |
| cfriesen | sean-k-mooney: are you thinking resize? | 17:57 |
| sean-k-mooney | cfriesen: yes i am | 17:57 |
| sean-k-mooney | specifcially https://docs.openstack.org/nova/queens/configuration/config.html#DEFAULT.allow_resize_to_same_host | 17:58 |
| sean-k-mooney | but i guess there is not the same option for rebuild | 17:58 |
| cfriesen | "rebuild" is by definition on same host, otherwise it's an evacuate | 17:58 |
| sean-k-mooney | cfriesen: evacuate is a livemigration but yes rebild make sense on the same host as less work to do | 17:59 |
| sean-k-mooney | a rebuild to another host would still be valid | 17:59 |
| cfriesen | "nova evacuate" is not a migration, the host is already dead. really it should be called "resuscitate" | 18:00 |
| sean-k-mooney | cfriesen: no you can evacuate hosts that are not dead for maintneance | 18:00 |
| sean-k-mooney | at least via horizon | 18:00 |
| *** Jams_ has quit IRC | 18:01 | |
| *** yamamoto has quit IRC | 18:01 | |
| *** AlexeyAbashkin has quit IRC | 18:02 | |
| cfriesen | sean-k-mooney: that's not the nova evacuate API though. | 18:02 |
| cfriesen | sean-k-mooney: that's "nova host-evacuate" or "nova host-evacuate-live", which is done on the client side just to confuse things. | 18:02 |
| sean-k-mooney | cfriesen: are you sure because i was pretty sure evacuate was ment to livemigrate off all instances on a singel host | 18:03 |
| dansmith | sean-k-mooney: yes | 18:03 |
| *** mgoddard_ has quit IRC | 18:03 | |
| *** Zames has joined #openstack-nova | 18:03 | |
| dansmith | sean-k-mooney: http://www.danplanet.com/blog/2016/03/03/evacuate-in-nova-one-command-to-confuse-us-all/ | 18:03 |
| *** openstackgerrit has quit IRC | 18:03 | |
| cfriesen | so dan, when do we rename evacuate to "resuscitate"? | 18:04 |
| dansmith | if horizon has an evacuate button, I don't know what it does, but I would have assumed it is actually evacuate | 18:04 |
| sean-k-mooney | dansmith: looks like the have renamed the horizon option to migrate host | 18:04 |
| dansmith | cfriesen: the complication is that if you have instances on shared storage, evacuate is not resuscitate | 18:04 |
| dansmith | or recreate | 18:04 |
| dansmith | cfriesen: evacuate is the worst possible name, but changing it also brings confusion, IMHO | 18:05 |
| cfriesen | dansmith: we're bringing instances back from the dead, so I think resuscitate works. if they've got shared storage they keep what they had, if not they get new rootfs | 18:06 |
| sean-k-mooney | dansmith: so the evacuate option in old horizon now migrate host is only available when you mark a host as down but that does not mean nova-compute and all the vms on that host are dead. it just means the api introduces for the opnfv guest to aministativly set the host down has been called | 18:07 |
| dansmith | it's no different from start from the user's perspective if they don't know what happend :) | 18:07 |
| dansmith | cfriesen: that said, I don't want to change it now because of the confusion factor, so I shan't agree on naming | 18:07 |
| cfriesen | fair enough | 18:07 |
| dansmith | sean-k-mooney: that would be real nova evacuate if the host has to be marked as down | 18:07 |
| sean-k-mooney | dansmith: i think the horizon nameing is confusing thing more because i dont know if they ment the same thing and nova evacuate or not | 18:07 |
| dansmith | sean-k-mooney: and that means we reconstruct the instance, not migrate it | 18:08 |
| sean-k-mooney | dansmith: but horizon in pike at least renamed that button form evacuate to migrate host | 18:08 |
| cfriesen | sean-k-mooney: In pike at least, horizon lets you disable the service and then call "migrate host". I'm pretty sure this is just disabling it, not administratively setting it as "down". | 18:08 |
| *** dklyle has joined #openstack-nova | 18:08 | |
| dansmith | yeah marked as down and disabled are different | 18:09 |
| cfriesen | sean-k-mooney: yep, just confirmed this with pike. it's still up but disabled | 18:09 |
| sean-k-mooney | cfriesen: yes so does migrate host via horixon actully migrate or does it do nova evacuate | 18:09 |
| cfriesen | migrate (or live-migrate, not sure). not evacuate | 18:09 |
| cfriesen | it's probably calling the same code as "nova host-evacuate" or "nova host-evacuate-live" | 18:10 |
| sean-k-mooney | cfriesen: ok because before pike that button was called evacuate hence my confution | 18:10 |
| *** lpetrut has joined #openstack-nova | 18:10 | |
| *** Zames has quit IRC | 18:10 | |
| cfriesen | yeah, horizon used the real logical meaning of evacuate, while nova didn't. | 18:11 |
| sean-k-mooney | anyway didnt mean to distract. | 18:11 |
| sean-k-mooney | dansmith: thanks for the blog post i think i have read it before you ill add it back to my book marks. | 18:11 |
| *** david-lyle has quit IRC | 18:12 | |
| cfriesen | anyone seen this running tox? "src/pcremodule.c:32:18: fatal error: pcre.h: No such file or directory" | 18:12 |
| *** AlexeyAbashkin has joined #openstack-nova | 18:13 | |
| jaypipes | cfriesen: yes. install libpcre-dev | 18:13 |
| jaypipes | cfriesen: should be fixed in the latest bin requirements thing, actually. | 18:14 |
| jaypipes | cfriesen: or libpcre3-dev... can't remember. | 18:14 |
| jaypipes | or pcre-devel on RH distros or something like that.. | 18:14 |
| sean-k-mooney | cfriesen: jaypipes https://stackoverflow.com/a/22559967 | 18:14 |
| *** sree_ has joined #openstack-nova | 18:15 | |
| cfriesen | pcre-devel looks promising | 18:15 |
| *** sree_ is now known as Guest4317 | 18:15 | |
| sean-k-mooney | looks like its libpcre3-dev on ubuntu and pcre-devel on centos | 18:15 |
| *** efried has quit IRC | 18:15 | |
| *** efried has joined #openstack-nova | 18:15 | |
| *** pcaruana has quit IRC | 18:16 | |
| *** AlexeyAbashkin has quit IRC | 18:17 | |
| sean-k-mooney | cfriesen: i think the new requirement is comming from whereto which pulls in python-pcre | 18:18 |
| *** slaweq has joined #openstack-nova | 18:18 | |
| efried | cfriesen: Yeah, you need a n... what sean-k-mooney said | 18:18 |
| *** jpena is now known as jpena|off | 18:18 | |
| efried | cfriesen: I think you need to install libpcre3-dev | 18:18 |
| *** Guest4317 has quit IRC | 18:19 | |
| sean-k-mooney | cfriesen: also be aware python-pcre does not appear to work on 32bit systmes. i was causeing mriedem dev enviroment to explode be case an enum value was more then could fit in 32Bits | 18:19 |
| *** slaweq has quit IRC | 18:23 | |
| *** harlowja has quit IRC | 18:23 | |
| *** moshele has joined #openstack-nova | 18:24 | |
| *** vivsoni_ has joined #openstack-nova | 18:24 | |
| cfriesen | installed the new package, things are working now. | 18:24 |
| cfriesen | who develops on 32-bit anymore? :) | 18:24 |
| *** vivsoni has quit IRC | 18:24 | |
| jroll | <mriedem> this is a 32 bit vm i guess, so that's my problem | 18:26 |
| jroll | that guy does :P | 18:26 |
| * dansmith stares at mriedem's bloodied corpse under that bus | 18:27 | |
| TheJulia | heh | 18:29 |
| sean-k-mooney | well all i know is nova is not tested in the gate with a 32bit os so even if it works as far as im concerend its broken untill the ci says otherwise | 18:29 |
| sean-k-mooney | is the fake driver https://github.com/openstack/nova/blob/master/nova/virt/fake.py the minimal working example of a virt driver? | 18:32 |
| *** sridharg has quit IRC | 18:36 | |
| mriedem | didn't realize it was a 32bit image | 18:39 |
| mriedem | oops | 18:39 |
| *** moshele has quit IRC | 18:40 | |
| mriedem | it's a snow day here today and the family in the house is driving me a little crazy | 18:41 |
| cfriesen | mine are home all week, school's on break | 18:41 |
| *** mgoddard_ has joined #openstack-nova | 18:41 | |
| *** vivsoni has joined #openstack-nova | 18:41 | |
| sean-k-mooney | cfriesen: so you looking forward to the week away next week then | 18:42 |
| *** vivsoni_ has quit IRC | 18:42 | |
| doude | jaypipes: thanks for your attention. It started failing since begining of November with patch https://review.openstack.org/#/c/515916/ | 18:42 |
| *** eandersson has quit IRC | 18:43 | |
| sean-k-mooney | doude: any chance we could move contrial to an os-vif plugin in the future | 18:44 |
| *** hamzy has quit IRC | 18:44 | |
| sean-k-mooney | doude: it would avoid having to make that type of change in the nova tree in the future | 18:45 |
| *** tesseract has quit IRC | 18:45 | |
| doude | yes we already started the work for the dpdk case with VhostHostUser type https://github.com/openstack/nova/commit/1ba834c0e48c85bf84ff3ec62fce0d5cb5c39c6d#diff-f78fb1f9dab4cca6e24c53779de7cfcf thanks to mhenkel | 18:45 |
| doude | but still need to do the work for the TAP VIF type | 18:45 |
| sean-k-mooney | doude: ah cool | 18:46 |
| doude | I plane to work on it for R | 18:46 |
| mnaser | mriedem: if you have a few minutes .. i think the fix should not be backported to stable/ocata because the bug doesn't exist there. the commit which "introduced" this bug is https://github.com/openstack/nova/commit/63805735c25a54ad1b9b97e05080c1a6153d8e22 | 18:46 |
| mnaser | which was in pike, before that, the api layer never did a reserve on the volume, the compute would do it | 18:46 |
| mnaser | and because of this, the delete will always clean it up because the detach will happen inside the compute | 18:47 |
| mriedem | and if we failed in scheduling, the volume isn't reserved via the api anyway | 18:47 |
| mriedem | works for me | 18:47 |
| mnaser | okay cool ill drop them | 18:47 |
| mnaser | ill add a note to teh bug | 18:48 |
| *** hamzy has joined #openstack-nova | 18:48 | |
| *** tssurya has quit IRC | 18:48 | |
| mriedem | mnaser: thanks | 18:50 |
| *** openstackgerrit has joined #openstack-nova | 18:50 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Only attempt a rebuild claim for an evacuation to a new host https://review.openstack.org/546268 | 18:50 |
| mriedem | cfriesen: ^ easy peasy | 18:50 |
| mnaser | dropped and added a note to the bug .. now to check why the patches didn't pass | 18:51 |
| *** dklyle has quit IRC | 18:53 | |
| mriedem | mnaser: actually there is another case which could have happened in ocata, | 18:54 |
| mriedem | mnaser: bfv where nova creates the volume and attaches it, then driver.spawn fails, the compute puts the instance into ERROR state and resets the host/node to None | 18:55 |
| mriedem | so if you go to delete the instance, instance.host is None but you could have a volume attached | 18:55 |
| *** stvnoyes has quit IRC | 18:55 | |
| *** harlowja has joined #openstack-nova | 18:55 | |
| mriedem | mnaser: however, that's also being handled compute-side with this https://review.openstack.org/#/c/545087/ | 18:55 |
| mnaser | fun times.. | 18:57 |
| *** felipemonteiro has joined #openstack-nova | 18:57 | |
| sean-k-mooney | mriedem: ya that was/is an annowing edge case as you end up with a load of volumes if spawning fails often enven if you asked for the volume to be delted when the vm is deleted | 18:57 |
| *** yamamoto has joined #openstack-nova | 18:57 | |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Filter Resource Provider List for Traits https://review.openstack.org/546009 | 18:57 |
| efried | cdent, jaypipes, edleafe: Fixed that to do 400s on invalid traits ^ | 18:57 |
| cdent | roger | 18:58 |
| *** harlowja_ has joined #openstack-nova | 18:59 | |
| *** david-lyle has joined #openstack-nova | 18:59 | |
| edleafe | efried: ack | 18:59 |
| *** harlowja has quit IRC | 18:59 | |
| * efried makes a note to use IRC nicks 'roger' and 'ack' when he wants to feel important. | 19:00 | |
| sean-k-mooney | efried: is the only difference eventually between /allocation_candidates and /resource_providers going to be that allocation candidate support checking for avilable capasity to claim resouces form the resouce providers | 19:01 |
| efried | sean-k-mooney: No, I think there's lots of differences. | 19:01 |
| *** yamamoto has quit IRC | 19:02 | |
| efried | sean-k-mooney: GET /resource_providers actually already supports capacity filtering | 19:02 |
| edleafe | efried: https://www.youtube.com/watch?v=galB-OUPfBg | 19:02 |
| efried | sean-k-mooney: But there's a lot it doesn't do. | 19:02 |
| efried | Before I clicked, I *knew* it had to be an Airplane scene. | 19:02 |
| edleafe | efried: but of course! | 19:03 |
| sean-k-mooney | efried: yes but if we continue adding stuff form /allocation_candidates to /resource_providers in the future for parity could the eventually converge | 19:03 |
| sean-k-mooney | efried: im not saying we want to do that but they do similar things | 19:03 |
| mriedem | mnaser: https://review.openstack.org/#/c/545132/ is now approved if you want to backport that also | 19:03 |
| efried | sean-k-mooney: GET /resource_providers will never do the stuff where we consider groups of multiple providers collectively providing a set of resources. | 19:04 |
| efried | sean-k-mooney: ...for most values of "never" | 19:04 |
| *** david-lyle has quit IRC | 19:04 | |
| *** david-lyle has joined #openstack-nova | 19:04 | |
| efried | sean-k-mooney: Granular resources/traits syntax won't be applied to GET /resource_providers | 19:04 |
| sean-k-mooney | :) well i think /resource_providers is actully almost a subset of /allocation_candidates but ya thats fine as i said they proably should remain seperate but just wondering what the delta was at this point | 19:05 |
| cfriesen | mriedem: cool...I was just starting to look at how to make the functional test change. | 19:05 |
| efried | sean-k-mooney: Yeah, they definitely need to remain separate. And I suspect they'll continue to diverge, though as we can see here, certain enhancements can be applied to both. | 19:06 |
| sean-k-mooney | efried: ya required traits definetly makes sense to be able to use to filter /resource_providers | 19:07 |
| efried | Yay, another +1! | 19:07 |
| efried | You win some, you lose some (/me laments Resource Class Affinity) | 19:08 |
| sean-k-mooney | efried: by the way this will work for custom_ traits too right not just traits in os-traits | 19:08 |
| efried | sean-k-mooney: Fo sho. | 19:08 |
| efried | Anything in the Trait database. | 19:08 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Drop extra loop which modifies Cinder volume status https://review.openstack.org/546218 | 19:08 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Store block device mappings in cell0 https://review.openstack.org/546219 | 19:08 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Add functional tests to ensure BDM removal on delete https://review.openstack.org/546220 | 19:08 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Clean up ports and volumes when deleting ERROR instance https://review.openstack.org/546221 | 19:08 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Add functional recreate test of deleting a BFV server pre-scheduling https://review.openstack.org/546222 | 19:08 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Detach volumes when deleting a BFV server pre-scheduling https://review.openstack.org/546275 | 19:08 |
| mnaser | (i dun goof'd the first set because i cherry pick'd the wrong functional test, oops.) | 19:09 |
| sean-k-mooney | cool just checking as i was reading the 400 error bit i assumed the db statement covered them | 19:09 |
| sean-k-mooney | efried: just one observation. required for /resource_providers will work differently then required for /allocation_candidates as the later with out granular requests looks at the union of all traits in the tree not just on an indivigual resouce provider | 19:12 |
| cfriesen | mriedem: the test_rebuild_with_new_image() testcase is still failing. I've patched nova/compute/manager.py and restarted devstack@n-cpu.service, am I missing something? | 19:12 |
| sean-k-mooney | efried: they are two different apis however so that should be fine | 19:12 |
| efried | sean-k-mooney: In fact in more than just the tree - in the tree plus any sharing providers it's considering for the request. | 19:13 |
| sean-k-mooney | efried: yep | 19:13 |
| efried | sean-k-mooney: And yes, a valid observation. Same applies to ?resources= | 19:13 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/queens: Drop extra loop which modifies Cinder volume status https://review.openstack.org/546200 | 19:14 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/queens: Store block device mappings in cell0 https://review.openstack.org/546201 | 19:14 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/queens: Add functional tests to ensure BDM removal on delete https://review.openstack.org/546202 | 19:14 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/queens: Clean up ports and volumes when deleting ERROR instance https://review.openstack.org/546203 | 19:14 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/queens: Add functional recreate test of deleting a BFV server pre-scheduling https://review.openstack.org/546204 | 19:14 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/queens: Detach volumes when deleting a BFV server pre-scheduling https://review.openstack.org/546277 | 19:14 |
| *** felipemonteiro has quit IRC | 19:14 | |
| mnaser | someone teach me git at the ptg, thanks | 19:14 |
| mnaser | but at least gerrit can tell its a rebase so it didnt lose the +verified | 19:14 |
| mriedem | mnaser: git review -R -y | 19:18 |
| mriedem | cfriesen: not sure what you mean, the functional test passes for me | 19:18 |
| mriedem | remove the code fix and the test fails as expected | 19:19 |
| *** hamzy has quit IRC | 19:19 | |
| edleafe | mnaser: I always liked this talk: https://www.youtube.com/watch?v=yCh6TSLIQBQ | 19:21 |
| mnaser | edleafe: cool, i'll give it a listen tonight | 19:23 |
| cfriesen | mriedem: my bad, I had "if recreate is not None" in the test | 19:25 |
| *** hamzy has joined #openstack-nova | 19:25 | |
| cfriesen | all is good now | 19:26 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add AggregateList.get_by_metadata() query method https://review.openstack.org/544728 | 19:26 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add aggregates list to Destination object https://review.openstack.org/544729 | 19:26 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add request filter functionality to scheduler https://review.openstack.org/544730 | 19:26 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002 | 19:26 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement https://review.openstack.org/546282 | 19:26 |
| *** jackie-truong has joined #openstack-nova | 19:27 | |
| *** felipemonteiro has joined #openstack-nova | 19:28 | |
| *** cdent has quit IRC | 19:29 | |
| *** artom has joined #openstack-nova | 19:30 | |
| *** slaweq has joined #openstack-nova | 19:31 | |
| *** mgoddard_ has quit IRC | 19:31 | |
| *** slaweq_ has joined #openstack-nova | 19:34 | |
| *** yamahata has quit IRC | 19:35 | |
| *** slaweq has quit IRC | 19:36 | |
| *** abhishekk has quit IRC | 19:37 | |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Clean up ports and volumes when deleting ERROR instance https://review.openstack.org/546221 | 19:39 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Add functional recreate test of deleting a BFV server pre-scheduling https://review.openstack.org/546222 | 19:39 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Detach volumes when deleting a BFV server pre-scheduling https://review.openstack.org/546275 | 19:39 |
| *** salv-orlando has quit IRC | 19:39 | |
| *** salv-orlando has joined #openstack-nova | 19:40 | |
| *** jackie-truong has quit IRC | 19:41 | |
| *** moshele has joined #openstack-nova | 19:42 | |
| *** slaweq_ has quit IRC | 19:43 | |
| *** salv-orlando has quit IRC | 19:44 | |
| *** dtantsur is now known as dtantsur|afk | 19:46 | |
| *** amoralej is now known as amoralej|off | 19:47 | |
| *** pchavva1 has quit IRC | 19:47 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add AggregateList.get_by_metadata() query method https://review.openstack.org/544728 | 19:48 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add aggregates list to Destination object https://review.openstack.org/544729 | 19:48 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add request filter functionality to scheduler https://review.openstack.org/544730 | 19:48 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002 | 19:48 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement https://review.openstack.org/546282 | 19:48 |
| *** pchavva1 has joined #openstack-nova | 19:51 | |
| *** moshele has quit IRC | 19:52 | |
| *** dave-mccowan has quit IRC | 19:57 | |
| *** yamamoto has joined #openstack-nova | 19:58 | |
| *** jroll has quit IRC | 19:58 | |
| *** ralonsoh has quit IRC | 20:00 | |
| *** yamamoto has quit IRC | 20:02 | |
| *** larsks has quit IRC | 20:04 | |
| *** lucasagomes is now known as lucas-pto | 20:05 | |
| *** jroll has joined #openstack-nova | 20:07 | |
| *** tssurya has joined #openstack-nova | 20:08 | |
| *** slaweq has joined #openstack-nova | 20:10 | |
| *** yamahata has joined #openstack-nova | 20:11 | |
| mnaser | mriedem: https://review.openstack.org/#/c/545123/ has coverage case using new attach flow but not with the old one, so it fails in stable/pike. would you like me to update it to use the old flow fixture? | 20:14 |
| *** slaweq has quit IRC | 20:14 | |
| mnaser | i don't think we have to do it for queens or master, because technically we can only have compute releases that are behind by one version | 20:14 |
| mnaser | or actually that might be unrelated. regardless, i'm open to hearing the options | 20:15 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002 | 20:18 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement https://review.openstack.org/546282 | 20:18 |
| dansmith | ah jeez | 20:18 |
| * dansmith is not on his game today | 20:18 | |
| *** moshele has joined #openstack-nova | 20:19 | |
| *** mgoddard_ has joined #openstack-nova | 20:19 | |
| *** bnemec is now known as bnemec-pto | 20:19 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add AggregateList.get_by_metadata() query method https://review.openstack.org/544728 | 20:20 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add aggregates list to Destination object https://review.openstack.org/544729 | 20:20 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add request filter functionality to scheduler https://review.openstack.org/544730 | 20:20 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002 | 20:20 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement https://review.openstack.org/546282 | 20:20 |
| *** lpetrut has quit IRC | 20:20 | |
| *** slaweq has joined #openstack-nova | 20:22 | |
| *** AlexeyAbashkin has joined #openstack-nova | 20:23 | |
| *** moshele has quit IRC | 20:23 | |
| mriedem | mnaser: yeah need to use the CinderFixture in pike | 20:25 |
| mriedem | mnaser: i realized that would be the case | 20:25 |
| openstackgerrit | Merged openstack/nova stable/pike: Rollback instance.image_ref on failed rebuild https://review.openstack.org/539003 | 20:26 |
| mriedem | dansmith: you've gone full bore on converting all of the post-placement filters to pre-placement filters haven't you :) | 20:26 |
| mnaser | mriedem: ok ill change it up to use cinderfixture and modify the code (as it would depend on if volume_id in self.reserved_volumes) | 20:26 |
| mriedem | mnaser: thanks | 20:26 |
| *** cfriesen has quit IRC | 20:27 | |
| dansmith | mriedem: no, I just wanted another example | 20:27 |
| *** AlexeyAbashkin has quit IRC | 20:27 | |
| mriedem | guh why doesn't ctrl+c work inside a cirros shell | 20:27 |
| *** mgoddard_ has quit IRC | 20:27 | |
| *** eharney has quit IRC | 20:28 | |
| *** cfriesen has joined #openstack-nova | 20:28 | |
| *** eharney has joined #openstack-nova | 20:30 | |
| *** ircuser-1 has joined #openstack-nova | 20:33 | |
| *** lpetrut has joined #openstack-nova | 20:34 | |
| *** dave-mccowan has joined #openstack-nova | 20:36 | |
| *** awaugama has quit IRC | 20:37 | |
| *** pcaruana has joined #openstack-nova | 20:40 | |
| *** artom has quit IRC | 20:40 | |
| *** salv-orlando has joined #openstack-nova | 20:40 | |
| *** tbachman has quit IRC | 20:40 | |
| *** artom has joined #openstack-nova | 20:42 | |
| mriedem | woot got this multiattach demo working | 20:42 |
| mriedem | mounting and umounting like a mothertrucker | 20:43 |
| smcginnis | mriedem: Are you recording a demo? | 20:45 |
| *** salv-orlando has quit IRC | 20:45 | |
| mriedem | that's the plan | 20:48 |
| mriedem | finally got the run through working | 20:48 |
| smcginnis | mriedem: Nice! | 20:48 |
| mriedem | https://docs.google.com/presentation/d/1bp7IwEubvXqQf7mUE3nlUNW_T04L4c1-AMXELZ45jgg/edit?usp=sharing | 20:49 |
| mriedem | also uses device tags | 20:50 |
| mriedem | artom: ^ | 20:50 |
| mriedem | and shows how to boot with multiple volumes using device tags, then mount the config drive in the guest to read the disk device tags from metadata | 20:50 |
| mriedem | throughout this whole thing i've found a new appreciation for openstackclient and the unified CLI, and ability to print out specific columns and parse the results for storing into local shell variables | 20:51 |
| mriedem | which is really really nice | 20:51 |
| mriedem | so much so that i think we should seriously think about deprecating the nova CLI | 20:52 |
| mriedem | melwitt: ^ might be a topic, albeit old, for the ptg | 20:52 |
| mriedem | except for things that we can't do in osc (yet) | 20:52 |
| artom | mriedem, noice | 20:53 |
| *** felipemonteiro_ has joined #openstack-nova | 20:53 | |
| mriedem | one thing osc doesn't do is the super complicated --block-device params that nova boot does | 20:53 |
| mriedem | for specifying things like bootindex and tags | 20:53 |
| melwitt | mriedem: yeah. that's a tough one because we'll need to do an audit on what all osc doesn't do. I learned the hard way the other day that you can't boot from volume in osc with one command anymore | 20:54 |
| artom | Does it do microversions yet? | 20:54 |
| melwitt | no, it does not | 20:54 |
| mriedem | well, it does | 20:54 |
| * artom swears he saw some microversion code in there | 20:54 | |
| mriedem | but not by default, you have to opt in | 20:54 |
| melwitt | well, it passes them through if specified manually | 20:54 |
| mriedem | right | 20:54 |
| mriedem | so i have been doing; | 20:54 |
| melwitt | but it doesn't do any discovery | 20:54 |
| mriedem | export OS_COMPUTE_API_VERSION=2.60 | 20:54 |
| mriedem | melwitt: you can bfv with osc by doing: openstack server create --flavor 1 --volume <volume name or id> myserver | 20:55 |
| melwitt | that's if the volume has already been created by you earlier | 20:55 |
| melwitt | you have to do two steps | 20:55 |
| melwitt | you can't bfv from image with one command | 20:55 |
| mriedem | there is a --block-device option to server create | 20:55 |
| melwitt | anymore | 20:55 |
| melwitt | that doesn't work anymore | 20:55 |
| *** elod has joined #openstack-nova | 20:56 | |
| mriedem | but it's a bit limited, i think it only allows source volume or snapshot? | 20:56 |
| *** dave-mccowan has quit IRC | 20:56 | |
| mriedem | so yeah, the osc --block-device param is definitely less robust than the nova boot one | 20:56 |
| melwitt | yeah, maybe. I was trying to do from image | 20:56 |
| mriedem | but to be fair, | 20:56 |
| mriedem | every time i need to use nova boot --block-device, | 20:56 |
| mriedem | i have to parse the help first | 20:56 |
| *** felipemonteiro has quit IRC | 20:56 | |
| melwitt | yeah. we'd just have to turn our attention to making sure commands like those can be one step and keep them working | 20:58 |
| melwitt | long ago I wondered if we could make the novaclient stuff be an osc plugin, that way we can take care of the test coverage/regression coverage for our commands | 20:59 |
| *** yamamoto has joined #openstack-nova | 20:59 | |
| *** r-daneel_ has joined #openstack-nova | 20:59 | |
| *** elod has quit IRC | 20:59 | |
| melwitt | in our tree | 21:00 |
| *** r-daneel has quit IRC | 21:00 | |
| *** r-daneel_ is now known as r-daneel | 21:00 | |
| mriedem | there are a lot of easy low hanging CLIs we could deprecate though b/c they have coverage in osc, | 21:00 |
| mriedem | like create snapshot image, add/remove volume/interface, etc | 21:00 |
| mriedem | the more exotic server create stuff would yeah be a wip | 21:00 |
| mriedem | i was also watching an older k8s talk where everything was a single command line and realized they kind of figured that out from the beginning, | 21:01 |
| mriedem | so people new to k8s don't have to figure out you need 6 different client libs installed to do something | 21:01 |
| *** priteau has quit IRC | 21:02 | |
| *** salv-orlando has joined #openstack-nova | 21:03 | |
| *** yamamoto has quit IRC | 21:03 | |
| mnaser | mriedem: the bug that keeps on giving. when changing to the old fixture, https://github.com/openstack/nova/blob/stable/pike/nova/compute/api.py#L2008 checks for an attachment_id, but it doesn't have one from the fixtures.. sooo "Ignoring volume cleanup failure due to Object action obj_load_attr failed because: attribute attachment_id not lazy-loadable" | 21:04 |
| *** felipemonteiro_ has quit IRC | 21:04 | |
| mnaser | (therefore the functional test fails and the volume is still 'reserved' because it doesn't go into the 'else' codepath and detach) | 21:05 |
| *** felipemonteiro has joined #openstack-nova | 21:05 | |
| mriedem | mnaser: hmm, it wouldn't come from the fixture, | 21:06 |
| mriedem | it should just be default to None in the DB | 21:06 |
| mriedem | i mean, we create the bdm in cell0 | 21:06 |
| *** owalsh has quit IRC | 21:06 | |
| mriedem | so when it's read back out, that should be null | 21:06 |
| *** jackie-truong has joined #openstack-nova | 21:06 | |
| mnaser | maybe not in this case | 21:07 |
| mnaser | because you pass it the bdms not from db | 21:07 |
| *** felipemonteiro_ has joined #openstack-nova | 21:07 | |
| *** sidx64 has joined #openstack-nova | 21:07 | |
| mriedem | oh i know what it is, | 21:07 |
| mriedem | the bdms in the build request | 21:07 |
| mriedem | those don't have the attachment_id | 21:08 |
| mnaser | yeah | 21:08 |
| mnaser | `build_req.block_device_mappings` is whats passed | 21:08 |
| *** FL1SK has joined #openstack-nova | 21:08 | |
| mriedem | yeah, crap | 21:08 |
| mnaser | that change hasnt merged yet | 21:08 |
| mnaser | if you want to abandon and restore | 21:08 |
| mnaser | https://review.openstack.org/#/c/545132/ | 21:08 |
| mriedem | well, it's not a problem in master or queens... | 21:09 |
| *** moshele has joined #openstack-nova | 21:09 | |
| mnaser | what's happening differently here if you dont mind me asking? | 21:09 |
| *** felipemonteiro has quit IRC | 21:09 | |
| *** liverpooler has quit IRC | 21:11 | |
| mriedem | mnaser: we don't have https://github.com/openstack/nova/blob/stable/queens/nova/compute/api.py#L3765 in pike | 21:11 |
| *** elod has joined #openstack-nova | 21:11 | |
| mnaser | ahhh i see | 21:11 |
| mnaser | the attachments are created in db there | 21:11 |
| *** owalsh has joined #openstack-nova | 21:11 | |
| mriedem | well, they bdm.attachment_id field is set | 21:11 |
| mnaser | because the bdm is saved into db, i see | 21:11 |
| mriedem | and the bdm is then later stored in the build request | 21:11 |
| mriedem | so this is also a problem in queens if you have pike computes | 21:12 |
| mriedem | it's really a different bug | 21:12 |
| mriedem | so in the delete code, we need logic like, "if 'attachment_id' in bdm and bdm.attachment_id:" | 21:12 |
| mriedem | mnaser: feel like opening a new bug? | 21:12 |
| *** moshele has quit IRC | 21:12 | |
| mnaser | mriedem: sure, ill do that | 21:13 |
| mnaser | i'll reorder the backports so that fix comes right before the one that enables the functional test once it goes in master so it can pass | 21:14 |
| mriedem | yeah i should have also added the recreate for the older cinder fixture as well, but was lazy | 21:14 |
| mriedem | i guess can do that as part of the new bug fix | 21:14 |
| mnaser | i already have it so ill reuse it | 21:15 |
| mriedem | cool | 21:15 |
| *** elod has quit IRC | 21:15 | |
| *** tssurya has quit IRC | 21:16 | |
| *** tssurya has joined #openstack-nova | 21:18 | |
| *** tssurya has quit IRC | 21:18 | |
| *** tssurya has joined #openstack-nova | 21:18 | |
| mnaser | https://bugs.launchpad.net/nova/+bug/1750666 probably not the best description but feel free to edit it, ill push up something | 21:20 |
| openstack | Launchpad bug 1750666 in OpenStack Compute (nova) "Deleting an instance before scheduling with BFV fails to detach volume" [Undecided,New] | 21:20 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Add functional recreate test of deleting a BFV server pre-scheduling https://review.openstack.org/546222 | 21:20 |
| mnaser | gah | 21:21 |
| *** AlexeyAbashkin has joined #openstack-nova | 21:23 | |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Add functional recreate test of deleting a BFV server pre-scheduling https://review.openstack.org/546222 | 21:26 |
| cfriesen | mriedem: does osc support automatic block live migration yet? last I checked you had to manually specify block migration | 21:27 |
| *** AlexeyAbashkin has quit IRC | 21:27 | |
| *** moshele has joined #openstack-nova | 21:28 | |
| mnaser | if i do git-review -d <change>, commit on top and git review .. will that prevent messing up the stack (or should i use -R ?) | 21:29 |
| mnaser | the commit IDs match so i think i should be ok? | 21:30 |
| *** jackie-truong has quit IRC | 21:30 | |
| dansmith | mnaser: depends | 21:30 |
| dansmith | mnaser: you mean commit --amend? | 21:30 |
| mnaser | nope, a seperate commit on top | 21:30 |
| dansmith | that will create a new change, on top of the one you downloaded | 21:31 |
| dansmith | if that's what you want then that's fine | 21:31 |
| zigo | I got a weirdo Python 3 issue when generating Nova sphinx doc, can someone have a look? I tried to fix it for a long time and didn't succeed: http://paste.openstack.org/show/679271/ | 21:31 |
| *** moshele has quit IRC | 21:31 | |
| dansmith | but without -R it will/may rebase both when it submits | 21:31 |
| mnaser | dansmith: yes, dont want to touch the changes below, but want to build on top of them | 21:31 |
| dansmith | then yes, but I would use -R if you really want to avoid disturbing the one below | 21:31 |
| zigo | The same passes in Py 2.7. | 21:31 |
| mnaser | ok i'll do that, thank you dansmith | 21:31 |
| dansmith | np | 21:32 |
| zigo | It probably is an issue in blockdiag itself though... | 21:32 |
| zigo | Everything else (ie: all Nova unit tests) pass in Py 3.6. | 21:34 |
| zigo | Should I file a bug? | 21:35 |
| melwitt | zigo: yeah, filing a bug would help. are you trying to run the tox 'docs' target or? | 21:36 |
| zigo | melwitt: No, I'm building the Nova Debian package for Queens. | 21:37 |
| zigo | No tox when doing packaging. | 21:37 |
| melwitt | actually I see the 'docs' target is pinned to python 2.7, probably because of the bug you're hitting | 21:37 |
| *** pcaruana has quit IRC | 21:37 | |
| zigo | melwitt: PYTHONPATH=. python3 -m sphinx -b html doc/source $(CURDIR)/debian/nova-doc/usr/share/doc/nova-doc/html | 21:37 |
| zigo | That's what I run. | 21:37 |
| zigo | melwitt: Well, I do need the docs to also pass in Py3, since I'll be removing all traces of Py 2.7 in the Debian packages. | 21:38 |
| * zigo goes to file a bug | 21:38 | |
| zigo | Worst case, I'll remove the block dragram from the doc that is crashing sphinx. | 21:39 |
| zigo | I'd of course prefer not to do that. | 21:39 |
| melwitt | yeah ... based on the "basepython = python2.7" for docs in tox.ini, it's known not to build under py3 but I don't know why. I'd want to get stephenfin to look at it but he's out on PTO this week | 21:39 |
| zigo | melwitt: No worries! :) | 21:42 |
| * zigo investigate removing the block diagram from Nova's doc. | 21:42 | |
| zigo | https://bugs.launchpad.net/nova/+bug/1750672 | 21:42 |
| openstack | Launchpad bug 1750672 in OpenStack Compute (nova) "failure to generate Nova's doc in Python 3.6" [Undecided,New] | 21:42 |
| melwitt | thanks | 21:47 |
| *** artom has quit IRC | 21:50 | |
| mriedem | cfriesen: don't know, it might assume you have to specify that, but you could open a bug and say if microversion >= x, don't require some option | 21:51 |
| mriedem | cfriesen: melwitt: so there will definitely need to be some currency stuff like that in osc, like this https://review.openstack.org/#/c/546176/ | 21:51 |
| mriedem | but it's pretty simple for most of it | 21:51 |
| mriedem | oops wrong patch | 21:52 |
| mriedem | https://review.openstack.org/#/c/545946/ | 21:52 |
| openstackgerrit | Mohammed Naser proposed openstack/nova master: Add functional test for deleting BFV server with old attach flow https://review.openstack.org/546315 | 21:52 |
| *** slaweq_ has joined #openstack-nova | 21:52 | |
| *** pchavva1 has quit IRC | 21:53 | |
| openstackgerrit | Mohammed Naser proposed openstack/nova master: Add functional test for deleting BFV server with old attach flow https://review.openstack.org/546315 | 21:54 |
| mnaser | aaand thats a step 1 | 21:54 |
| melwitt | mriedem: okay, that's cool. what about the auto-discover-latest behavior of the CLI? from what I understand, that's not something they wanted to allow in osc | 21:54 |
| mriedem | melwitt: that doesn't exist in osc | 21:56 |
| mriedem | or most CLIs besides nova's | 21:56 |
| mriedem | i.e. cinder CLI doesn't do that either | 21:56 |
| melwitt | I know | 21:57 |
| melwitt | but I thought we would want to keep that, I've never understood how it's useful for a CLI to default to the lowest microversion | 21:57 |
| *** slaweq_ has quit IRC | 21:57 | |
| *** sidx64 has quit IRC | 21:58 | |
| melwitt | and I thought we discussed it in a forum session about osc last time, but I don't remember if we got any consensus or next steps about it | 21:59 |
| zigo | melwitt: Here's the line that crashes everything: https://salsa.debian.org/openstack-team/services/nova/blob/debian/queens/debian/patches/remove-crashing-blockdiag-doc-line.patch | 21:59 |
| *** yamamoto has joined #openstack-nova | 22:00 | |
| melwitt | zigo: huh. interesting | 22:00 |
| cfriesen | melwitt: yeah, I remember some discussion too. I pinged the OSC folks about microversion stuff but they basically said they had a plan and didn't seem to want any help with it. | 22:00 |
| mriedem | melwitt: it was discussed in the user session in boston | 22:01 |
| mriedem | and i think the consensus was "we should be consistent" but no decisive answer on which consistency is best | 22:01 |
| mriedem | i can't remember which specific session now https://wiki.openstack.org/wiki/Forum/Boston2017 | 22:03 |
| melwitt | okay. agreed on consistency. we'll need to re-sync with the osc team on that if we're going to get serious about deprecating the nova CLI | 22:03 |
| jroll | melwitt: fwiw, the only explanation for defaulting CLIs to the lowest microversion that I've heard is so that new versions don't break bash scripts | 22:03 |
| jroll | as if it's a bash sdk >.> | 22:03 |
| mriedem | and we've asserted the CLI isn't an SDK | 22:03 |
| mriedem | but the python API binding code is, so that's why that's opt-in | 22:04 |
| melwitt | right | 22:04 |
| *** yamamoto has quit IRC | 22:04 | |
| jroll | for some definition of "we" :) | 22:04 |
| mriedem | we == nova in this case | 22:04 |
| melwitt | I don't think a bash sdk is a good idea for anyone | 22:04 |
| mriedem | for our CLI | 22:04 |
| jroll | right | 22:04 |
| cfriesen | jroll: if you want that you can explicitly specify the API version in your bash script | 22:04 |
| jroll | cfriesen: no I don't want that at all, just providing the anecdata that I have :)( | 22:05 |
| cfriesen | "you" generally, not specifically | 22:05 |
| cfriesen | :) | 22:05 |
| jroll | right | 22:05 |
| mriedem | well i can't find the etherpad, but i remember the discussion | 22:06 |
| mriedem | i'm pretty sure it was boston | 22:06 |
| mriedem | clarkb or mordred might remember | 22:06 |
| melwitt | I had thought it got talked about more recently too, but maybe I'm thinking of boston and not realizing it | 22:08 |
| * mordred waves | 22:08 | |
| mriedem | mordred: do you remember talking about standardizing CLIs at the forum in boston? | 22:09 |
| mordred | dtantsur|afk has been working on a spec/document on the topic - I expect us to all sit down and alk about it some time next week | 22:09 |
| mriedem | like the auto-discover microversion behavior | 22:09 |
| mriedem | ? | 22:09 |
| mordred | sorry - dtantsur has been working on aspec about sdks/libraries and microversions - not on cli things | 22:10 |
| mordred | but I'd very much like for us to come to a shared understanding and consensus - and to make sure that whatever needs to be done to deprecate the nova cli is done - and will happily sign up to help work on that goal | 22:11 |
| openstackgerrit | Hongbin Lu proposed openstack/nova master: [WIP] Skip placement on rebuild in same host https://review.openstack.org/546357 | 22:13 |
| *** jdurgin has joined #openstack-nova | 22:13 | |
| * mordred is also on a plane right now with TERRIBLE wifi - so can't offer a *ton* of useful info right now, but will circle back with you as soon as he has better internet | 22:14 | |
| openstackgerrit | Mohammed Naser proposed openstack/nova master: Add functional test for deleting BFV server with old attach flow https://review.openstack.org/546315 | 22:17 |
| openstackgerrit | Mohammed Naser proposed openstack/nova master: Check if attachment_id exists before deleting it https://review.openstack.org/546398 | 22:17 |
| mnaser | mriedem: ^ that should fix it | 22:18 |
| mnaser | (functional and unit tests passed locally, but didn't run the whole suite) | 22:18 |
| *** r-daneel has quit IRC | 22:22 | |
| *** r-daneel has joined #openstack-nova | 22:22 | |
| *** threestrands has joined #openstack-nova | 22:23 | |
| mriedem | ok | 22:24 |
| openstackgerrit | Matthew Edmonds proposed openstack/nova-specs master: PowerVM Virt Integration (Rocky) https://review.openstack.org/545111 | 22:31 |
| *** rcernin has joined #openstack-nova | 22:33 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Avoid exploding if guest refuses to detach a volume https://review.openstack.org/546423 | 22:44 |
| *** eharney has quit IRC | 22:45 | |
| *** tssurya has quit IRC | 22:46 | |
| *** itlinux has quit IRC | 22:49 | |
| *** Zames has joined #openstack-nova | 22:52 | |
| melwitt | dansmith: your review would be appreciated on the bug we looked at last week about saving the admin password in sysmeta for the libvirt driver https://review.openstack.org/#/c/543032 | 22:54 |
| melwitt | I tested the patch with devstack and found it works | 22:55 |
| *** lyan has quit IRC | 22:55 | |
| *** felipemonteiro_ has quit IRC | 22:57 | |
| *** amodi has quit IRC | 22:57 | |
| melwitt | we don't have tempest coverage enabled of 'change password' in the gate because of the qemu guest agent requirement. I have a tempest patch up to add coverage for anyone who *can* run with [compute-feature-enabled]change_password = True but I haven't double-checked that it works in my devstack env yet https://review.openstack.org/#/c/543029/ | 22:59 |
| *** slaweq has quit IRC | 23:00 | |
| *** slaweq has joined #openstack-nova | 23:00 | |
| *** yamamoto has joined #openstack-nova | 23:00 | |
| *** jmlowe has quit IRC | 23:01 | |
| *** openstackgerrit has quit IRC | 23:04 | |
| *** sapcc-bot has quit IRC | 23:04 | |
| *** burt has quit IRC | 23:04 | |
| *** sapcc-bot has joined #openstack-nova | 23:04 | |
| *** slaweq has quit IRC | 23:06 | |
| *** liusheng has quit IRC | 23:06 | |
| *** liusheng has joined #openstack-nova | 23:06 | |
| *** yamamoto has quit IRC | 23:06 | |
| *** tidwellr has quit IRC | 23:09 | |
| *** lpetrut has quit IRC | 23:11 | |
| *** NostawRm has quit IRC | 23:15 | |
| *** jmlowe has joined #openstack-nova | 23:19 | |
| *** NostawRm has joined #openstack-nova | 23:19 | |
| *** takashin has joined #openstack-nova | 23:23 | |
| *** AlexeyAbashkin has joined #openstack-nova | 23:23 | |
| *** AlexeyAbashkin has quit IRC | 23:27 | |
| *** Zames has quit IRC | 23:32 | |
| *** r-daneel has quit IRC | 23:34 | |
| *** r-daneel has joined #openstack-nova | 23:35 | |
| *** acormier has quit IRC | 23:35 | |
| *** claudiub has quit IRC | 23:36 | |
| *** Zames has joined #openstack-nova | 23:40 | |
| mriedem | smcginnis: are you able to get this? https://drive.google.com/open?id=1jGiBLcaefpcAz66Camlcffeb4H9EkLtE | 23:42 |
| mriedem | melwitt: dansmith: ^ ? audio is a bit quiet but otherwise it seems fine | 23:44 |
| melwitt | what is that? | 23:46 |
| mriedem | demo | 23:46 |
| melwitt | ah, cool | 23:46 |
| *** Tahvok has quit IRC | 23:46 | |
| *** Tahvok has joined #openstack-nova | 23:47 | |
| melwitt | yeah, I can see it. agree the audio is pretty quiet | 23:48 |
| *** Zames has quit IRC | 23:49 | |
| *** r-daneel has quit IRC | 23:50 | |
| *** masahisa has joined #openstack-nova | 23:52 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!