| *** Alex_Staf has quit IRC | 00:02 | |
| *** lbragstad has joined #openstack-nova | 00:06 | |
| *** mriedem has quit IRC | 00:06 | |
| openstackgerrit | melanie witt proposed openstack/nova master: qemu-img do not use cache=none if no O_DIRECT support https://review.openstack.org/523554 | 00:12 |
|---|---|---|
| *** yamamoto has joined #openstack-nova | 00:12 | |
| *** hongbin has quit IRC | 00:13 | |
| *** penick has quit IRC | 00:13 | |
| *** slaweq has joined #openstack-nova | 00:13 | |
| *** thorst has joined #openstack-nova | 00:16 | |
| *** slaweq has quit IRC | 00:18 | |
| *** thorst has quit IRC | 00:21 | |
| *** yamamoto has quit IRC | 00:31 | |
| *** salv-orl_ has quit IRC | 00:38 | |
| *** salv-orlando has joined #openstack-nova | 00:38 | |
| *** penick has joined #openstack-nova | 00:38 | |
| *** liverpooler has quit IRC | 00:42 | |
| *** liverpooler has joined #openstack-nova | 00:42 | |
| *** salv-orlando has quit IRC | 00:43 | |
| *** sdague has quit IRC | 00:44 | |
| *** yyys has joined #openstack-nova | 00:44 | |
| *** mlavalle has quit IRC | 00:46 | |
| *** penick has quit IRC | 00:47 | |
| *** chyka has quit IRC | 00:47 | |
| *** thorst has joined #openstack-nova | 00:49 | |
| *** awaugama has joined #openstack-nova | 00:50 | |
| *** thorst has quit IRC | 00:54 | |
| *** vishwanathj has joined #openstack-nova | 00:57 | |
| openstackgerrit | Merged openstack/nova master: PowerVM Driver: config drive https://review.openstack.org/409404 | 00:57 |
| openstackgerrit | Merged openstack/nova master: Save updated libvirt domain XML after swapping volume https://review.openstack.org/498983 | 00:57 |
| *** thorst has joined #openstack-nova | 00:58 | |
| *** moshele has quit IRC | 00:59 | |
| *** thorst has quit IRC | 00:59 | |
| *** huanxie has joined #openstack-nova | 01:03 | |
| *** thorst has joined #openstack-nova | 01:06 | |
| *** gbarros has joined #openstack-nova | 01:14 | |
| openstackgerrit | Wangpan proposed openstack/nova master: Handle ImageInUse exception during instance backup https://review.openstack.org/523395 | 01:17 |
| *** yamamoto has joined #openstack-nova | 01:20 | |
| *** thorst has quit IRC | 01:21 | |
| *** Swami has quit IRC | 01:22 | |
| *** takashin has quit IRC | 01:23 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi:(WIP:need ut) Get vgpu info from `allocations` https://review.openstack.org/521717 | 01:25 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and changes-since for instance-actions https://review.openstack.org/326326 | 01:26 |
| *** nicolasbock has quit IRC | 01:30 | |
| openstackgerrit | Rong Han proposed openstack/nova stable/pike: Fix incorrect known vcpuset when CPUPinningUnknown raised https://review.openstack.org/523644 | 01:38 |
| *** salv-orlando has joined #openstack-nova | 01:39 | |
| *** hongbin has joined #openstack-nova | 01:40 | |
| *** gmann_afk is now known as gmann | 01:41 | |
| *** salv-orlando has quit IRC | 01:44 | |
| *** cheneydc has joined #openstack-nova | 01:47 | |
| *** gongysh has joined #openstack-nova | 01:48 | |
| *** thorst has joined #openstack-nova | 01:51 | |
| *** awaugama has quit IRC | 01:51 | |
| *** purplerbot has quit IRC | 01:56 | |
| *** purplerbot has joined #openstack-nova | 01:56 | |
| *** vladikr has joined #openstack-nova | 01:57 | |
| *** thorst has quit IRC | 01:57 | |
| *** Guest97530 has quit IRC | 01:57 | |
| *** sree has joined #openstack-nova | 01:58 | |
| *** yangyapeng has joined #openstack-nova | 01:59 | |
| *** annp has joined #openstack-nova | 01:59 | |
| *** thorst has joined #openstack-nova | 02:00 | |
| *** sree has quit IRC | 02:02 | |
| *** hamzy has joined #openstack-nova | 02:03 | |
| *** thorst has quit IRC | 02:05 | |
| *** gongysh has quit IRC | 02:07 | |
| *** yamamoto has quit IRC | 02:07 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add instance action record for shelve_offload instances https://review.openstack.org/523653 | 02:07 |
| *** phuongnh has joined #openstack-nova | 02:09 | |
| *** takashin has joined #openstack-nova | 02:10 | |
| *** Apoorva_ has joined #openstack-nova | 02:16 | |
| *** gongysh has joined #openstack-nova | 02:16 | |
| *** chyka has joined #openstack-nova | 02:17 | |
| *** Apoorva has quit IRC | 02:19 | |
| *** Apoorva_ has quit IRC | 02:20 | |
| *** chyka has quit IRC | 02:21 | |
| openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/523562 | 02:22 |
| *** yamamoto has joined #openstack-nova | 02:23 | |
| *** vladikr has quit IRC | 02:31 | |
| *** tbachman has quit IRC | 02:35 | |
| *** salv-orlando has joined #openstack-nova | 02:40 | |
| *** dave-mccowan has quit IRC | 02:42 | |
| *** Delair has joined #openstack-nova | 02:43 | |
| Delair | Hi All .. Is it normal in openstack newton that if you delete project, your VMs will still reside in the compute? Is there a workaround where you delete project and it will delete VM automatically | 02:44 |
| *** salv-orlando has quit IRC | 02:45 | |
| *** gbarros has quit IRC | 02:47 | |
| *** gongysh has quit IRC | 02:48 | |
| *** vladikr has joined #openstack-nova | 02:51 | |
| *** suresh12 has quit IRC | 02:54 | |
| *** suresh12 has joined #openstack-nova | 03:01 | |
| *** gongysh has joined #openstack-nova | 03:01 | |
| *** diga has joined #openstack-nova | 03:02 | |
| *** yamahata has quit IRC | 03:02 | |
| openstackgerrit | Kevin Zhao proposed openstack/os-traits master: Add AArch64 CPU traits https://review.openstack.org/523665 | 03:04 |
| *** cheneydc has quit IRC | 03:04 | |
| *** threestrands has joined #openstack-nova | 03:05 | |
| *** thorst has joined #openstack-nova | 03:05 | |
| *** suresh12 has quit IRC | 03:05 | |
| *** thorst has quit IRC | 03:10 | |
| *** vladikr has quit IRC | 03:13 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and changes-since for instance-actions https://review.openstack.org/326326 | 03:13 |
| *** tbachman has joined #openstack-nova | 03:14 | |
| *** abhishekk has joined #openstack-nova | 03:17 | |
| *** litao__ has joined #openstack-nova | 03:18 | |
| *** yamamoto has quit IRC | 03:18 | |
| *** hahaps_ has quit IRC | 03:21 | |
| *** sree has joined #openstack-nova | 03:27 | |
| *** jichen has joined #openstack-nova | 03:30 | |
| *** sapd_ has quit IRC | 03:33 | |
| *** sapd_ has joined #openstack-nova | 03:36 | |
| *** thorst has joined #openstack-nova | 03:36 | |
| *** Apoorva has joined #openstack-nova | 03:37 | |
| larsks | Delair: you might want to look at https://github.com/openstack/ospurge | 03:38 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: [WIP] Add cross cells support for InstanceActionAPI https://review.openstack.org/523674 | 03:40 |
| *** thorst has quit IRC | 03:40 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add instance action record for backup instances https://review.openstack.org/523676 | 03:41 |
| *** links has joined #openstack-nova | 03:42 | |
| *** gongysh has quit IRC | 03:42 | |
| alex_xu | efried: I will check that, to find out which code fix that bug, that really surprise me... | 03:42 |
| *** takashin has quit IRC | 03:43 | |
| *** suresh12 has joined #openstack-nova | 03:45 | |
| *** jaianshu has joined #openstack-nova | 03:48 | |
| *** suresh12 has quit IRC | 03:49 | |
| *** mdnadeem has joined #openstack-nova | 04:00 | |
| *** adisky_ has joined #openstack-nova | 04:00 | |
| openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: provide VGPU_DISPLAY_HEAD inventory in compute node https://review.openstack.org/523342 | 04:10 |
| *** fragatina has quit IRC | 04:11 | |
| *** fragatina has joined #openstack-nova | 04:12 | |
| *** thorst has joined #openstack-nova | 04:12 | |
| *** fragatin_ has joined #openstack-nova | 04:14 | |
| *** slaweq has joined #openstack-nova | 04:15 | |
| *** fragatina has quit IRC | 04:16 | |
| *** thorst has quit IRC | 04:17 | |
| *** fragatin_ has quit IRC | 04:19 | |
| *** slaweq has quit IRC | 04:19 | |
| *** TuanLA has joined #openstack-nova | 04:28 | |
| *** threestrands has quit IRC | 04:29 | |
| *** markvoelker has quit IRC | 04:30 | |
| *** ijw has joined #openstack-nova | 04:32 | |
| *** hshiina has joined #openstack-nova | 04:33 | |
| openstackgerrit | zhongshengping proposed openstack/nova master: Fix project_domain_name and user_domain_name in doc https://review.openstack.org/523686 | 04:33 |
| *** tbachman has quit IRC | 04:33 | |
| *** janki has joined #openstack-nova | 04:33 | |
| *** yamamoto has joined #openstack-nova | 04:36 | |
| *** ijw has quit IRC | 04:36 | |
| *** threestrands has joined #openstack-nova | 04:41 | |
| *** threestrands has quit IRC | 04:41 | |
| *** threestrands has joined #openstack-nova | 04:41 | |
| *** salv-orlando has joined #openstack-nova | 04:42 | |
| *** gouthamr has quit IRC | 04:43 | |
| *** thorst has joined #openstack-nova | 04:44 | |
| *** yangyapeng has quit IRC | 04:45 | |
| *** yangyapeng has joined #openstack-nova | 04:46 | |
| *** yamamoto has quit IRC | 04:46 | |
| *** salv-orlando has quit IRC | 04:46 | |
| *** fragatina has joined #openstack-nova | 04:47 | |
| *** fragatina has quit IRC | 04:48 | |
| *** fragatina has joined #openstack-nova | 04:48 | |
| *** thorst has quit IRC | 04:49 | |
| *** yangyapeng has quit IRC | 04:54 | |
| *** yangyapeng has joined #openstack-nova | 04:54 | |
| *** tbachman has joined #openstack-nova | 04:56 | |
| *** eharney has quit IRC | 05:00 | |
| *** tetsuro_ has joined #openstack-nova | 05:02 | |
| *** ratailor has joined #openstack-nova | 05:03 | |
| *** yamamoto has joined #openstack-nova | 05:09 | |
| openstackgerrit | Alex Xu proposed openstack/nova master: Remove the objects which related to the old v2 API implementation https://review.openstack.org/519997 | 05:15 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Remove the objects for describing the extension for v2.1 API https://review.openstack.org/519998 | 05:15 |
| *** dklyle has quit IRC | 05:15 | |
| alex_xu | oomichi_afk: gmann ^ just updated | 05:16 |
| *** hongbin has quit IRC | 05:16 | |
| *** thorst has joined #openstack-nova | 05:21 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 05:22 |
| *** janki has quit IRC | 05:23 | |
| *** Delair has quit IRC | 05:24 | |
| *** thorst has quit IRC | 05:26 | |
| *** armax has quit IRC | 05:28 | |
| *** thorst has joined #openstack-nova | 05:29 | |
| *** markvoelker has joined #openstack-nova | 05:30 | |
| *** yamamoto has quit IRC | 05:31 | |
| *** armax has joined #openstack-nova | 05:31 | |
| *** armax has quit IRC | 05:31 | |
| *** threestrands has quit IRC | 05:32 | |
| *** thorst has quit IRC | 05:34 | |
| *** gongysh has joined #openstack-nova | 05:36 | |
| *** chyka has joined #openstack-nova | 05:36 | |
| *** takashin has joined #openstack-nova | 05:39 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 05:40 |
| *** chyka has quit IRC | 05:41 | |
| *** yamamoto has joined #openstack-nova | 05:43 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | 05:46 |
| *** gouthamr has joined #openstack-nova | 05:46 | |
| *** tbachman has quit IRC | 05:49 | |
| *** Apoorva has quit IRC | 05:53 | |
| *** yamamoto has quit IRC | 05:56 | |
| *** thorst has joined #openstack-nova | 05:57 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483 | 05:58 |
| *** yamamoto has joined #openstack-nova | 06:01 | |
| *** yamamoto has quit IRC | 06:01 | |
| *** thorst has quit IRC | 06:03 | |
| *** gouthamr has quit IRC | 06:04 | |
| *** gongysh has quit IRC | 06:04 | |
| gmann | alex_xu: thanks , ll check | 06:05 |
| *** Kvisle has quit IRC | 06:06 | |
| *** Kvisle has joined #openstack-nova | 06:07 | |
| *** yamahata has joined #openstack-nova | 06:09 | |
| *** alex_xu has quit IRC | 06:10 | |
| *** udesale has joined #openstack-nova | 06:10 | |
| *** alex_xu has joined #openstack-nova | 06:11 | |
| *** sapd_ has quit IRC | 06:16 | |
| *** sapd_ has joined #openstack-nova | 06:16 | |
| *** slaweq has joined #openstack-nova | 06:17 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Fix getting placement request ID https://review.openstack.org/523606 | 06:18 |
| *** janki has joined #openstack-nova | 06:19 | |
| *** suresh12 has joined #openstack-nova | 06:19 | |
| *** gongysh has joined #openstack-nova | 06:23 | |
| *** salv-orlando has joined #openstack-nova | 06:25 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: [WIP] Add cross cells support for InstanceActionAPI https://review.openstack.org/523674 | 06:26 |
| *** gongysh has quit IRC | 06:26 | |
| *** thorst has joined #openstack-nova | 06:29 | |
| *** thorst has quit IRC | 06:34 | |
| *** slaweq has quit IRC | 06:35 | |
| *** slaweq has joined #openstack-nova | 06:35 | |
| *** lpetrut has joined #openstack-nova | 06:38 | |
| *** sree_ has joined #openstack-nova | 06:38 | |
| *** sree_ is now known as Guest24904 | 06:38 | |
| *** slaweq has quit IRC | 06:40 | |
| openstackgerrit | Merged openstack/nova master: PowerVM support matrix update https://review.openstack.org/523140 | 06:41 |
| *** sree has quit IRC | 06:42 | |
| *** Alex_Staf has joined #openstack-nova | 06:43 | |
| *** sree has joined #openstack-nova | 06:43 | |
| *** Guest24904 has quit IRC | 06:46 | |
| *** qsyqian has joined #openstack-nova | 06:50 | |
| *** esberglu has quit IRC | 06:54 | |
| *** yamamoto has joined #openstack-nova | 06:56 | |
| *** yamamoto has quit IRC | 07:01 | |
| *** sridharg has joined #openstack-nova | 07:02 | |
| *** thorst has joined #openstack-nova | 07:07 | |
| openstackgerrit | Chen Hanxiao proposed openstack/python-novaclient master: inject file: add description of injecting multiple files. https://review.openstack.org/515655 | 07:08 |
| *** Alex_Staf has quit IRC | 07:09 | |
| *** thorst has quit IRC | 07:11 | |
| *** moshele has joined #openstack-nova | 07:13 | |
| *** Oku_OS-away is now known as Oku_OS | 07:15 | |
| *** sree has quit IRC | 07:17 | |
| *** sree has joined #openstack-nova | 07:18 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313 | 07:20 |
| *** damien_r has joined #openstack-nova | 07:21 | |
| *** sree has quit IRC | 07:22 | |
| *** diga has quit IRC | 07:22 | |
| *** ragiman has joined #openstack-nova | 07:30 | |
| *** jaosorior has quit IRC | 07:33 | |
| *** sree has joined #openstack-nova | 07:34 | |
| *** damien_r has quit IRC | 07:34 | |
| *** jaosorior has joined #openstack-nova | 07:35 | |
| *** lpetrut has quit IRC | 07:37 | |
| *** alexchadin has joined #openstack-nova | 07:39 | |
| *** sree has quit IRC | 07:39 | |
| *** sree has joined #openstack-nova | 07:40 | |
| *** maciejjozefczyk has quit IRC | 07:41 | |
| *** thorst has joined #openstack-nova | 07:42 | |
| *** rcernin has quit IRC | 07:43 | |
| *** thorst has quit IRC | 07:46 | |
| *** AlexeyAbashkin has joined #openstack-nova | 07:47 | |
| *** sahid has joined #openstack-nova | 07:51 | |
| *** lpetrut has joined #openstack-nova | 07:53 | |
| *** lpetrut has quit IRC | 07:54 | |
| *** suresh12 has quit IRC | 08:00 | |
| *** sshwarts has joined #openstack-nova | 08:01 | |
| *** takashin has left #openstack-nova | 08:03 | |
| *** pcaruana has joined #openstack-nova | 08:04 | |
| *** cfriesen has quit IRC | 08:11 | |
| openstackgerrit | jichenjc proposed openstack/nova master: [placement]Enhance doc for placement allocation list https://review.openstack.org/511715 | 08:11 |
| *** claudiub|2 has joined #openstack-nova | 08:14 | |
| *** damien_r has joined #openstack-nova | 08:14 | |
| openstackgerrit | jichenjc proposed openstack/nova master: check query param for server groups function https://review.openstack.org/500347 | 08:15 |
| *** thorst has joined #openstack-nova | 08:21 | |
| *** rmart04 has joined #openstack-nova | 08:21 | |
| *** maciejjozefczyk has joined #openstack-nova | 08:22 | |
| openstackgerrit | licanwei proposed openstack/nova master: Make nova-manage syncing all cells databases https://review.openstack.org/519275 | 08:25 |
| *** thorst has quit IRC | 08:26 | |
| *** sridharg has quit IRC | 08:26 | |
| kalyan | Hi All, is openstack/libvirt usb passthrough has a limitation USB protocol <=2.0 ?? | 08:30 |
| kalyan | could someone please correct me on this and provide some information to achieve the same if possible | 08:31 |
| kalyan | thanks in advance! :) | 08:31 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add instance action record for backup instances https://review.openstack.org/523676 | 08:38 |
| *** Alex_Staf has joined #openstack-nova | 08:39 | |
| *** rcernin has joined #openstack-nova | 08:39 | |
| *** jpena|off is now known as jpena | 08:48 | |
| *** ralonsoh has joined #openstack-nova | 08:49 | |
| *** thorst has joined #openstack-nova | 08:54 | |
| *** Tom-Tom has joined #openstack-nova | 08:56 | |
| *** liuyulong has joined #openstack-nova | 08:56 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 08:57 |
| *** thorst has quit IRC | 08:59 | |
| *** alexchadin has quit IRC | 09:00 | |
| *** liuzz has quit IRC | 09:03 | |
| *** spectr has joined #openstack-nova | 09:03 | |
| *** tetsuro_ has quit IRC | 09:04 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/523765 | 09:08 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/520478 | 09:14 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add instance action record for backup instances https://review.openstack.org/523676 | 09:14 |
| *** sridharg has joined #openstack-nova | 09:15 | |
| *** Tom-Tom has quit IRC | 09:20 | |
| *** Tom-Tom has joined #openstack-nova | 09:21 | |
| *** sree_ has joined #openstack-nova | 09:22 | |
| *** sree_ is now known as Guest65189 | 09:22 | |
| *** sree has quit IRC | 09:23 | |
| *** thorst has joined #openstack-nova | 09:24 | |
| *** hoangcx has joined #openstack-nova | 09:24 | |
| *** lucas-afk is now known as lucasagomes | 09:25 | |
| *** hoangcx has quit IRC | 09:25 | |
| *** Tom-Tom has quit IRC | 09:26 | |
| *** dtantsur|afk is now known as dtantsur | 09:26 | |
| *** hoangcx has joined #openstack-nova | 09:26 | |
| *** thorst has quit IRC | 09:29 | |
| *** hoangcx has quit IRC | 09:30 | |
| *** moshele has quit IRC | 09:31 | |
| openstackgerrit | Erik Berg proposed openstack/nova master: Cell_v2: unique constraint on database_connection mapping https://review.openstack.org/523817 | 09:32 |
| *** qsyqian has quit IRC | 09:33 | |
| *** vks1 has joined #openstack-nova | 09:38 | |
| *** gcb has joined #openstack-nova | 09:39 | |
| *** gmann is now known as gmann_afk | 09:39 | |
| *** yamamoto has joined #openstack-nova | 09:41 | |
| *** derekh has joined #openstack-nova | 09:43 | |
| *** hoangcx has joined #openstack-nova | 09:45 | |
| *** qsyqian has joined #openstack-nova | 09:45 | |
| *** qsyqian has quit IRC | 09:50 | |
| openstackgerrit | Chen Hanxiao proposed openstack/nova master: libvirt: throw NotImplementedError if qga is not responsive when setting password https://review.openstack.org/523828 | 09:50 |
| *** Guest65189 has quit IRC | 09:51 | |
| *** sree has joined #openstack-nova | 09:51 | |
| *** thorst has joined #openstack-nova | 09:55 | |
| *** slaweq has joined #openstack-nova | 09:55 | |
| *** alexchadin has joined #openstack-nova | 09:57 | |
| *** thorst has quit IRC | 09:59 | |
| *** slaweq has quit IRC | 10:00 | |
| *** sree has quit IRC | 10:00 | |
| *** suresh12 has joined #openstack-nova | 10:01 | |
| *** annp has quit IRC | 10:02 | |
| *** jaianshu has quit IRC | 10:03 | |
| *** qsyqian has joined #openstack-nova | 10:03 | |
| *** suresh12 has quit IRC | 10:05 | |
| *** TuanLA has quit IRC | 10:05 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: POC: tests: autospecs all the mock.patch usages https://review.openstack.org/470775 | 10:10 |
| *** yamahata has quit IRC | 10:13 | |
| *** sambetts|afk is now known as sambetts | 10:26 | |
| *** AlexeyAbashkin has quit IRC | 10:28 | |
| *** liuzz has joined #openstack-nova | 10:28 | |
| *** thorst has joined #openstack-nova | 10:31 | |
| *** spectr has quit IRC | 10:33 | |
| *** thorst has quit IRC | 10:36 | |
| *** qsyqian has quit IRC | 10:36 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: update_cell allows more than once cell to have the same db/transport url https://review.openstack.org/518556 | 10:42 |
| *** phuongnh has quit IRC | 10:46 | |
| *** jichen has quit IRC | 10:49 | |
| *** Laurene has joined #openstack-nova | 10:49 | |
| *** alexchadin has quit IRC | 10:50 | |
| *** gszasz has joined #openstack-nova | 10:55 | |
| *** mvk has quit IRC | 10:56 | |
| *** alexchadin has joined #openstack-nova | 10:58 | |
| *** mvk has joined #openstack-nova | 10:58 | |
| *** abhishekk has quit IRC | 11:01 | |
| *** qsyqian has joined #openstack-nova | 11:02 | |
| *** gcb has quit IRC | 11:05 | |
| *** yamamoto has quit IRC | 11:06 | |
| *** thorst has joined #openstack-nova | 11:08 | |
| *** slaweq has joined #openstack-nova | 11:10 | |
| *** yamamoto has joined #openstack-nova | 11:10 | |
| *** moshele has joined #openstack-nova | 11:11 | |
| *** thorst has quit IRC | 11:13 | |
| *** slaweq has quit IRC | 11:19 | |
| *** AlexeyAbashkin has joined #openstack-nova | 11:19 | |
| *** slaweq has joined #openstack-nova | 11:19 | |
| *** adisky_ has quit IRC | 11:21 | |
| *** AlexeyAbashkin has quit IRC | 11:23 | |
| *** erlon has joined #openstack-nova | 11:23 | |
| *** yamamoto has quit IRC | 11:24 | |
| *** slaweq has quit IRC | 11:24 | |
| *** Laurene has quit IRC | 11:26 | |
| *** AlexeyAbashkin has joined #openstack-nova | 11:27 | |
| *** sdague has joined #openstack-nova | 11:27 | |
| *** alexchadin has quit IRC | 11:30 | |
| *** thorst has joined #openstack-nova | 11:30 | |
| *** sree has joined #openstack-nova | 11:31 | |
| *** edand has joined #openstack-nova | 11:32 | |
| *** thorst has quit IRC | 11:32 | |
| *** sree has quit IRC | 11:36 | |
| openstackgerrit | Erik Berg proposed openstack/nova master: Cool, wasn't sure about wether the transport_url needed to be unique aswell. The more you know :) https://review.openstack.org/523849 | 11:40 |
| *** mvk has quit IRC | 11:47 | |
| *** vks1 has quit IRC | 11:50 | |
| *** mdnadeem has quit IRC | 11:58 | |
| *** chyka has joined #openstack-nova | 11:58 | |
| *** lucasagomes is now known as lucas-hungry | 12:00 | |
| *** chyka has quit IRC | 12:02 | |
| *** thorst has joined #openstack-nova | 12:03 | |
| *** moshele has quit IRC | 12:06 | |
| *** Tahvok has joined #openstack-nova | 12:06 | |
| *** moshele has joined #openstack-nova | 12:07 | |
| *** thorst has quit IRC | 12:07 | |
| *** qsyqian has quit IRC | 12:09 | |
| *** ratailor has quit IRC | 12:10 | |
| *** slaweq has joined #openstack-nova | 12:10 | |
| *** tetsuro has joined #openstack-nova | 12:10 | |
| *** smatzek has joined #openstack-nova | 12:11 | |
| *** litao__ has quit IRC | 12:15 | |
| *** moshele has quit IRC | 12:17 | |
| *** thorst has joined #openstack-nova | 12:18 | |
| *** liverpooler has quit IRC | 12:18 | |
| *** mvk has joined #openstack-nova | 12:19 | |
| *** eharney has joined #openstack-nova | 12:20 | |
| *** slaweq has quit IRC | 12:21 | |
| *** thorst has quit IRC | 12:24 | |
| *** yamamoto has joined #openstack-nova | 12:24 | |
| *** yamamoto has quit IRC | 12:31 | |
| *** Tahvok has quit IRC | 12:32 | |
| *** yamamoto has joined #openstack-nova | 12:34 | |
| *** nicolasbock has joined #openstack-nova | 12:36 | |
| *** slaweq has joined #openstack-nova | 12:39 | |
| *** threestrands has joined #openstack-nova | 12:42 | |
| *** threestrands has quit IRC | 12:42 | |
| *** threestrands has joined #openstack-nova | 12:42 | |
| *** slaweq has quit IRC | 12:44 | |
| *** dtantsur is now known as dtantsur|brb | 12:47 | |
| *** psachin has joined #openstack-nova | 12:48 | |
| *** hshiina has quit IRC | 12:52 | |
| *** thorst has joined #openstack-nova | 12:55 | |
| *** threestrands has quit IRC | 13:01 | |
| *** vladikr has joined #openstack-nova | 13:03 | |
| *** yamamoto has quit IRC | 13:04 | |
| *** eharney has quit IRC | 13:07 | |
| *** yamamoto has joined #openstack-nova | 13:08 | |
| *** lucas-hungry is now known as lucasagomes | 13:08 | |
| *** yamamoto has quit IRC | 13:08 | |
| *** yamamoto has joined #openstack-nova | 13:09 | |
| *** yamamoto has quit IRC | 13:09 | |
| *** tetsuro has quit IRC | 13:10 | |
| *** moshele has joined #openstack-nova | 13:12 | |
| *** jaypipes has joined #openstack-nova | 13:12 | |
| *** yamamoto has joined #openstack-nova | 13:14 | |
| *** slaweq has joined #openstack-nova | 13:15 | |
| jaypipes | *yawn* | 13:15 |
| jaypipes | morning supernovas | 13:15 |
| *** pchavva has joined #openstack-nova | 13:16 | |
| *** alexchadin has joined #openstack-nova | 13:18 | |
| *** yamamoto has quit IRC | 13:19 | |
| *** markvoelker has quit IRC | 13:19 | |
| *** markvoelker has joined #openstack-nova | 13:19 | |
| *** vks1 has joined #openstack-nova | 13:19 | |
| *** liuyulong has quit IRC | 13:21 | |
| *** links has quit IRC | 13:21 | |
| *** liverpooler has joined #openstack-nova | 13:26 | |
| bauzas | jaypipes: morning | 13:28 |
| *** edmondsw has joined #openstack-nova | 13:32 | |
| *** liverpooler has quit IRC | 13:32 | |
| *** liverpooler has joined #openstack-nova | 13:32 | |
| *** udesale has quit IRC | 13:33 | |
| *** sree has joined #openstack-nova | 13:36 | |
| *** dave-mccowan has joined #openstack-nova | 13:36 | |
| *** zhurong has joined #openstack-nova | 13:38 | |
| *** artom has quit IRC | 13:39 | |
| *** moshele has quit IRC | 13:39 | |
| *** sree has quit IRC | 13:40 | |
| *** openstackstatus has quit IRC | 13:43 | |
| *** openstack has joined #openstack-nova | 13:44 | |
| *** ChanServ sets mode: +o openstack | 13:44 | |
| *** lyan has joined #openstack-nova | 13:47 | |
| *** yangyapeng has quit IRC | 13:50 | |
| *** mriedem has joined #openstack-nova | 13:51 | |
| *** eharney has joined #openstack-nova | 13:54 | |
| mriedem | lucasagomes: you should take a look at this change https://review.openstack.org/#/c/523559/ | 13:54 |
| *** zhurong has quit IRC | 13:56 | |
| *** zhurong has joined #openstack-nova | 13:58 | |
| efried | jaypipes Looks like some microversion digits were missed in the rebase. | 13:59 |
| jaypipes | efried: lemme look... | 13:59 |
| efried | jaypipes I can take care of it - I have some work to do on the series anyway. | 13:59 |
| lucasagomes | mriedem, hi there! I will take a look, although, I haven't been involved with ironic for awhile. It might be better to get some of the #openstack-ironic folks to take a look as well | 13:59 |
| *** toure_biab is now known as toure | 13:59 | |
| efried | jaypipes As long as you don't have local changes? | 14:00 |
| jaypipes | efried: go for it. | 14:00 |
| efried | rgr | 14:00 |
| *** awaugama has joined #openstack-nova | 14:00 | |
| *** udesale has joined #openstack-nova | 14:01 | |
| *** READ10 has joined #openstack-nova | 14:04 | |
| *** gbarros has joined #openstack-nova | 14:05 | |
| *** cdent has joined #openstack-nova | 14:10 | |
| lucasagomes | mriedem, posted a question re using task_state + vm_state to determine if the rebuild failed or not | 14:11 |
| mriedem | lucasagomes: heh, did you see my comment in the code? | 14:12 |
| mriedem | basically the same idea | 14:12 |
| lucasagomes | mriedem, oh, I looked at the wrong column ahah oh right | 14:13 |
| lucasagomes | yeah i think that would be more flexible | 14:13 |
| lucasagomes | if it works | 14:13 |
| *** yamamoto has joined #openstack-nova | 14:14 | |
| *** yamamoto has quit IRC | 14:15 | |
| lucasagomes | replied to your comment basically agreeing with the task_state + vm_state idea :-) | 14:15 |
| *** yamamoto has joined #openstack-nova | 14:15 | |
| *** yamamoto has quit IRC | 14:15 | |
| *** slaweq has quit IRC | 14:17 | |
| *** moshele has joined #openstack-nova | 14:18 | |
| *** yikun has quit IRC | 14:18 | |
| *** yikun has joined #openstack-nova | 14:19 | |
| *** edand has quit IRC | 14:23 | |
| *** dtantsur|brb is now known as dtantsur | 14:24 | |
| stephenfin | jaypipes: I've a question on https://github.com/openstack/nova/commit/15ac5b688bf6d91ac42ca33860d187d80289d82d | 14:25 |
| jaypipes | stephenfin: yessir? | 14:25 |
| stephenfin | jaypipes: That contains an online data migration. Would I need to run the `nova-manage db online_data_migrations` command for that to take place, or should it happen any time? | 14:25 |
| stephenfin | I'd thought the UUID field would be populated any time I loaded an object from the DB, but then I saw that command | 14:26 |
| *** rcernin has quit IRC | 14:27 | |
| *** cfriesen has joined #openstack-nova | 14:27 | |
| *** psachin has quit IRC | 14:28 | |
| *** smatzek has quit IRC | 14:29 | |
| *** smatzek has joined #openstack-nova | 14:30 | |
| *** esberglu has joined #openstack-nova | 14:31 | |
| jaypipes | stephenfin: there's no nova-manage db stuff in that patch. | 14:32 |
| jaypipes | stephenfin: all data migrations are done upon load/save of the PciDevice object | 14:32 |
| *** tbachman has joined #openstack-nova | 14:33 | |
| jaypipes | stephenfin: one might make an argument that there *should* have been a corresponding patch that added a nova-manage online data migration (that read in PciDevice objects in batches) | 14:34 |
| *** smatzek has quit IRC | 14:34 | |
| *** moshele has quit IRC | 14:35 | |
| *** yamamoto has joined #openstack-nova | 14:36 | |
| *** andreas_s has joined #openstack-nova | 14:39 | |
| mriedem | that's what we did when we added the uuid column to compute_nodes, services and migrations tables | 14:39 |
| mriedem | you could still add one... | 14:40 |
| *** mdnadeem has joined #openstack-nova | 14:40 | |
| *** hongbin has joined #openstack-nova | 14:40 | |
| *** yamamoto has quit IRC | 14:41 | |
| jaypipes | mriedem: ack | 14:42 |
| jaypipes | mriedem: would need to be done before the PCI device manager is integrated with placement. | 14:42 |
| *** burt has joined #openstack-nova | 14:42 | |
| stephenfin | jaypipes, mriedem: I can do that today | 14:42 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: Provide VGPU inventory for a single GPU type https://review.openstack.org/514763 | 14:42 |
| stephenfin | jaypipes: In the interim, I think there's a bug with that patch. See here | 14:43 |
| stephenfin | https://bugzilla.redhat.com/show_bug.cgi?id=1516952 | 14:43 |
| openstack | bugzilla.redhat.com bug 1516952 in openstack-nova "Cannot boot vm with sriov port after upgrade OSP11 to OSP12" [Urgent,New] - Assigned to eglynn | 14:46 |
| *** zhurong has quit IRC | 14:46 | |
| mriedem | i see the problem | 14:46 |
| mriedem | _from_db_object isn't handling the uuid column properly | 14:46 |
| *** READ10 has quit IRC | 14:46 | |
| *** zhurong has joined #openstack-nova | 14:46 | |
| mriedem | https://review.openstack.org/#/c/469147/2/nova/objects/pci_device.py@194 | 14:46 |
| mriedem | there should be a skip in there | 14:46 |
| mriedem | if key not in ('extra_info', 'uuid'): | 14:46 |
| *** openstack has quit IRC | 14:46 | |
| *** openstack has joined #openstack-nova | 14:48 | |
| *** ChanServ sets mode: +o openstack | 14:48 | |
| mriedem | stephenfin: i updated https://bugzilla.redhat.com/show_bug.cgi?id=1516952 - open an lp bug and i'll push a fix | 14:48 |
| jaypipes | dansmith: because we can't make them not-nullable until the fields are populated with something. | 14:50 |
| dansmith | jaypipes: so leave them unset? a nullable field means it can be set to None, and that's extremely wrong for an id, IMHO | 14:50 |
| jaypipes | dansmith: it gets set to a non-null value right after there.. | 14:50 |
| stephenfin | Couldn't we just move that non-null setting to the top of the function? | 14:50 |
| stephenfin | then we don't need to skip anything | 14:50 |
| jaypipes | dansmith: and then when the version of the object goes to the next major version, we change nullable to False and remove the data migration. | 14:50 |
| dansmith | okay I'm not sure what you're saying, you want to make it null so that a generic loop can set it to none for a few cycles? | 14:50 |
| *** zhurong has quit IRC | 14:50 | |
| dansmith | -2 on that :) | 14:50 |
| mriedem | fwiw we've only ever bumped the major version on an object before, it doesn't happen really | 14:51 |
| mriedem | Instance is the only one | 14:51 |
| jaypipes | yes, I've complained about that before... | 14:51 |
| dansmith | jaypipes: so do the work to bump.. it's not very fun :) | 14:51 |
| *** andreas_s has quit IRC | 14:51 | |
| *** coreywright has quit IRC | 14:52 | |
| *** andreas_s has joined #openstack-nova | 14:52 | |
| jaypipes | well, sounds like I'm in the minority here, stephenfin, so just add a conditional in that setattr loop to check for whether db_dev['uuid'] is None and if so, don't set obj.uuid to None. | 14:52 |
| *** alexchadin has quit IRC | 14:52 | |
| mriedem | i've got a patch local | 14:52 |
| mriedem | just need an lp bug | 14:53 |
| *** gbarros has quit IRC | 14:53 | |
| jaypipes | dansmith: do we have a good guide to doing that work? | 14:53 |
| openstack | bugzilla.redhat.com bug 1516952 in openstack-nova "Cannot boot vm with sriov port after upgrade OSP11 to OSP12" [Urgent,New] - Assigned to eglynn | 14:54 |
| stephenfin | mriedem: https://bugs.launchpad.net/nova/+bug/1735188 | 14:54 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1735189 | 14:54 |
| mriedem | you beat me | 14:54 |
| stephenfin | Ha! | 14:54 |
| stephenfin | so close | 14:54 |
| *** andreas__ has joined #openstack-nova | 14:54 | |
| dansmith | jaypipes: nope, it also takes work to put that together and nobody else has ever asked to do it. Happy to help with that, but like many other things, I'd value this well below a lot of the other things we've got going on at the moment | 14:55 |
| openstack | Launchpad bug 1735188 in OpenStack Compute (nova) "PciDevice UUID field not populated" [Undecided,New] | 14:55 |
| openstack | Launchpad bug 1735189 in OpenStack Compute (nova) "ValueError: Field `uuid' cannot be None in PciDevice._from_db_object" [Undecided,New] | 14:55 |
| jaypipes | dansmith: ack. maybe a weekend project for me around the holidays. | 14:55 |
| dansmith | jaypipes: you are a sick, sick man | 14:55 |
| jaypipes | heh | 14:56 |
| *** andrea___ has joined #openstack-nova | 14:56 | |
| *** andreas_s has quit IRC | 14:56 | |
| *** edand has joined #openstack-nova | 14:58 | |
| *** gbarros has joined #openstack-nova | 14:58 | |
| *** andreas__ has quit IRC | 14:59 | |
| mdbooth | Oh, dear. I poked something apparently innocuous, and it broke archive_deleted_rows() | 14:59 |
| mdbooth | I don't even know where I am any more | 14:59 |
| *** andreas_s has joined #openstack-nova | 14:59 | |
| *** cdent has quit IRC | 14:59 | |
| *** yangyapeng has joined #openstack-nova | 15:00 | |
| *** andrea___ has quit IRC | 15:01 | |
| mdbooth | Was I supposed to update the shadow table explicitly when I added a column? | 15:01 |
| *** salv-orl_ has joined #openstack-nova | 15:02 | |
| mdbooth | Ah, ha, it seems yes | 15:02 |
| jaypipes | mdbooth: yep | 15:02 |
| *** edand has quit IRC | 15:02 | |
| *** salv-orlando has quit IRC | 15:03 | |
| *** suresh12 has joined #openstack-nova | 15:03 | |
| *** andreas_s has quit IRC | 15:04 | |
| *** coreywright has joined #openstack-nova | 15:04 | |
| *** marst has joined #openstack-nova | 15:06 | |
| *** yamamoto has joined #openstack-nova | 15:06 | |
| *** andreas_s has joined #openstack-nova | 15:06 | |
| bauzas | jaypipes: reviewing https://review.openstack.org/#/c/377138/62/nova/db/sqlalchemy/api_models.py | 15:06 |
| bauzas | jaypipes: SQLA does ON DELETE CASCADE when you provide a FK ? | 15:07 |
| *** mlavalle has joined #openstack-nova | 15:07 | |
| mriedem | we don't do cascading deletes | 15:07 |
| *** suresh12 has quit IRC | 15:07 | |
| *** yamamoto has quit IRC | 15:07 | |
| *** yamamoto has joined #openstack-nova | 15:08 | |
| *** yamamoto has quit IRC | 15:08 | |
| mriedem | https://github.com/zzzeek/sqlalchemy/blob/rel_1_1_15/lib/sqlalchemy/sql/schema.py#L1514 | 15:09 |
| mriedem | ondelete=None | 15:09 |
| mriedem | https://github.com/zzzeek/sqlalchemy/blob/rel_1_1_15/lib/sqlalchemy/sql/schema.py#L1544 | 15:09 |
| jaypipes | bauzas: no | 15:09 |
| bauzas | jaypipes: so say you delete the root RP | 15:10 |
| bauzas | jaypipes: should we delete the children too ? | 15:10 |
| *** janki has quit IRC | 15:10 | |
| mriedem | which is part of the reason archive_deleted_rows used to always barf when we'd order the deletes incorrectly | 15:10 |
| bauzas | AFAIK, yes, right? | 15:10 |
| jaypipes | bauzas: we do. | 15:10 |
| *** janki has joined #openstack-nova | 15:10 | |
| bauzas | jaypipes: well, looking at https://review.openstack.org/#/c/377138/62/nova/objects/resource_provider.py@823 and below | 15:10 |
| *** andreas_s has quit IRC | 15:11 | |
| bauzas | jaypipes: I don't see where we're deleting the children | 15:11 |
| jaypipes | bauzas: we're not. we're *preventing* parents from being deleted if children exist. | 15:11 |
| bauzas | jaypipes: that I saw | 15:12 |
| bauzas | it's the first conditional | 15:12 |
| jaypipes | bauzas: we require that callers delete children before parents. | 15:12 |
| *** smatzek has joined #openstack-nova | 15:12 | |
| bauzas | wait | 15:12 |
| mriedem | this is a head scratcher https://github.com/openstack/nova/blob/master/nova/objects/pci_device.py#L249-L251 | 15:12 |
| mriedem | if True | 15:12 |
| jaypipes | bauzas: it's the second conditional, too... an IntegrityError will be raised if the DELETE on the parent ends up violating the foreign key constraint on parent_provider_id | 15:13 |
| *** psachin has joined #openstack-nova | 15:13 | |
| bauzas | jaypipes: oh right, the first conditional says "if children existing, then return no" | 15:13 |
| bauzas | man, when I looked at the comment, I readed too fast and I saw "do a quick check to see if the provider *has* a parent" in my mind | 15:14 |
| bauzas | grmblbl has != id | 15:14 |
| bauzas | is | 15:14 |
| * bauzas goes back to the 3rd grade | 15:15 | |
| *** yamahata has joined #openstack-nova | 15:17 | |
| bauzas | jaypipes: that said, a question, I guess we don't accept to delete a root RP if it has children because... it could be a problem for allocations ? | 15:18 |
| bauzas | or, because it's racy ? | 15:18 |
| bauzas | I mean, why aren't we supporting that ? | 15:18 |
| mriedem | bauzas: dansmith: vladikr: i'm looking at https://review.openstack.org/#/c/249015/ and https://review.openstack.org/#/c/373519/ and trying to figure out why we have https://github.com/openstack/nova/blob/master/nova/objects/pci_device.py#L249-L251 which is always True at this point | 15:18 |
| mriedem | so we are always saving off extra_info regardless of it changing | 15:19 |
| jaypipes | bauzas: no, it just makes our lives easier/safer to say callers need to handle removing children before parents. | 15:19 |
| bauzas | ok | 15:19 |
| bauzas | jaypipes: fair enoguh | 15:19 |
| bauzas | we could have imagined a way to walk on the tree and delete all the allocations/inventories before deleting straight the root RP and cascading the delete, but fine by me | 15:20 |
| bauzas | it's just that's it would mean a synchronous section | 15:20 |
| bauzas | which could be big for a 3-depth RP tree | 15:20 |
| bauzas | so I'm fine with the direction | 15:20 |
| bauzas | mriedem: looking | 15:20 |
| dansmith | mriedem: hmm | 15:21 |
| bauzas | mriedem: I'd call it "tech debt" | 15:21 |
| bauzas | probably one adding the conditional and the other doing the dict amendment | 15:21 |
| * bauzas git blames | 15:21 | |
| efried | jaypipes I'm thinking to do a refactor of ProviderTree to hide everything within _Provider as you mentioned a couple weeks ago. Then I'll put the uuid_set() change on top of that. | 15:21 |
| mriedem | already did the git blame, those are the two changes | 15:21 |
| bauzas | oh heh https://github.com/openstack/nova/blame/master/nova/objects/pci_device.py#L249-L251 | 15:21 |
| dansmith | mriedem: looks like just refactoring right? | 15:22 |
| mriedem | yes the latter change dropped some oneline migration code for extra_info | 15:22 |
| efried | jaypipes At a glance, there's nothing pending in the nrp series that touches ProviderTree before uuid_set(), so I was just gonna pell that outta there and start a new series on master tip. | 15:22 |
| dansmith | mriedem: used to be possible to not have that set, but not anymore? | 15:22 |
| mriedem | *online | 15:22 |
| efried | jaypipes That work for you? | 15:22 |
| efried | s/pell/peel/ | 15:22 |
| dansmith | mriedem: yeah | 15:22 |
| *** gouthamr has joined #openstack-nova | 15:22 | |
| *** toure has quit IRC | 15:23 | |
| bauzas | yeah, when looking at the change, we had some conditionals that we removed | 15:23 |
| bauzas | so probably just a nit | 15:23 |
| bauzas | now we always have that key | 15:23 |
| jaypipes | efried: yep, exactly what I was thinking. | 15:27 |
| efried | jaypipes k, on it | 15:28 |
| *** tlbr has joined #openstack-nova | 15:28 | |
| *** Alex_Staf has quit IRC | 15:28 | |
| mriedem | bauzas: dansmith: so i think we can remove https://github.com/openstack/nova/blob/master/nova/objects/pci_device.py#L249 | 15:28 |
| mriedem | yes? | 15:28 |
| dansmith | mriedem: if True: return "yes" | 15:29 |
| bauzas | mriedem: I think it's harmless indeed | 15:29 |
| bauzas | but you know, I'm not a libvirt expert :D | 15:30 |
| *** ragiman has quit IRC | 15:30 | |
| mriedem | what could possibly go wrong with upgrading nova with existing pci device records | 15:30 |
| *** cdent has joined #openstack-nova | 15:32 | |
| *** sridharg has quit IRC | 15:32 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Save updated libvirt domain XML after swapping volume https://review.openstack.org/523910 | 15:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Save updated libvirt domain XML after swapping volume https://review.openstack.org/523911 | 15:35 |
| *** Tahvok has joined #openstack-nova | 15:35 | |
| *** psachin has quit IRC | 15:37 | |
| bauzas | jaypipes: just did +2 on that change but I have an open question that is non blocking the merge https://review.openstack.org/#/c/377138/62/nova/objects/resource_provider.py | 15:42 |
| bauzas | https://review.openstack.org/#/c/377138/62/nova/objects/resource_provider.py@698 rather | 15:42 |
| bauzas | it's about deleting the records without touching how we track the updates | 15:42 |
| bauzas | again, totally unrelated, but I feel we should just say all the fields are good for updates ? | 15:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix ValueError when loading old pci device record https://review.openstack.org/523914 | 15:43 |
| mriedem | stephenfin: dansmith: lyarwood: ^ | 15:43 |
| bauzas | jaypipes: or a .delete() followed by a .create() would only persist the only touched fields | 15:43 |
| stephenfin | mriedem: Out of curiosity, why not just move the 'if db_dev['uuid'] is None:' block to the top? Seems it would fix the issue in the same manner with less LOC? | 15:45 |
| *** artom has joined #openstack-nova | 15:45 | |
| *** rmart04 has quit IRC | 15:45 | |
| mriedem | stephenfin: because then you call save() which triggers another round trip through _from_db_object before you load up the other fields | 15:46 |
| stephenfin | wait - that would cause a read of None from db_dev. nvm me | 15:46 |
| stephenfin | Also that | 15:46 |
| *** moshele has joined #openstack-nova | 15:46 | |
| *** Sukhdev has joined #openstack-nova | 15:47 | |
| *** tidwellr_ has joined #openstack-nova | 15:48 | |
| *** tidwellr has quit IRC | 15:48 | |
| *** Apoorva has joined #openstack-nova | 15:48 | |
| *** gbarros_ has joined #openstack-nova | 15:49 | |
| *** janki has quit IRC | 15:50 | |
| *** gbarros has quit IRC | 15:50 | |
| mriedem | stephenfin: replied, but no | 15:51 |
| mriedem | we can't 2.0 until we have a way to force the records are migrated, | 15:51 |
| mriedem | and we can't really force that w/o having a cli hook to run the online data migraiton, | 15:51 |
| mriedem | which we don't have, which you pointed out when we started talking about this | 15:51 |
| mriedem | if you want to talk web2.0 then i'm game | 15:52 |
| stephenfin | ++ makes sense to me. Thanks for the info | 15:52 |
| Tengu | (14 | 15:52 |
| Tengu | woops. | 15:52 |
| efried | jaypipes I think we're still going to need a way to return the data about a provider from ProviderTree (xen already asked for a name-to-uuid mapping). Should we simply make ProviderTree.find() return a *copy* of the provider (so updating it locally is a no-op)? | 15:54 |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: POC: tests: autospecs all the mock.patch usages https://review.openstack.org/470775 | 15:54 |
| jaypipes | bauzas: not sure I'm following you on your review comment "shouldn't we reset the changes when we call the deletion ? That makes sense to me given after the deletion, all the fields are now all non-persisted (or all of them needing to be persisted, rather)" | 15:54 |
| efried | jaypipes The alternative is to have ProviderTree.name_for(uuid), .parent_for(name_or_uuid), .inventory_for(name_or_uuid) etc. | 15:54 |
| cdent | I see you baby, rebasing that code, rebasing that code. | 15:55 |
| jaypipes | efried: I'd have to see where the xen folks are trying to do things. | 15:55 |
| mriedem | this isn't quite right either https://github.com/openstack/nova/blob/master/nova/objects/pci_device.py#L247 | 15:55 |
| mriedem | setting self.uuid in save() does'nt get it into the updates dict wihch is passed to db.pci_device_update | 15:56 |
| bauzas | jaypipes: I have to bail out, but I can explain later | 15:56 |
| jaypipes | mriedem: sure it does... | 15:56 |
| mriedem | so save() will call _from_db_object which will do the uuid migration and call save() again | 15:56 |
| mriedem | jaypipes: how? | 15:56 |
| mriedem | oh obj_get_changes | 15:56 |
| mriedem | nvm | 15:56 |
| jaypipes | mriedem: obj_get_changes() will pick up that uuid.. | 15:56 |
| jaypipes | bauzas: k | 15:56 |
| bauzas | jaypipes: basically, I imagine a case where I create the object, save the object in DB, modify a field, deletes the record in DB, and then recreate it in the DB | 15:57 |
| jaypipes | bauzas: I don't imagine that case :) | 15:57 |
| bauzas | when I recreate in DB, the updates would only be that field | 15:57 |
| bauzas | so we would only persist that field | 15:57 |
| *** suresh12 has joined #openstack-nova | 15:57 | |
| bauzas | again, it's unrelated to your change, so not a big deal for now | 15:57 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: WIP: PowerVM Driver: SEA https://review.openstack.org/523216 | 15:58 |
| *** edmondsw_ has joined #openstack-nova | 16:00 | |
| mriedem | dansmith: on that cve errata, i'm thinking we maybe don't need to hold things up for https://review.openstack.org/#/c/521391/ which was the lesser regression; w/o that fix, we'll always run through the scheduler for rebuild of a volume-backed instance even if the image isn't changing, but with your change for RUN_ON_REBUILD, we shouldn't actually fail in the scheduler if the image is the same (unless the admin does something | 16:00 |
| mriedem | onfig like changes isolated_images), so it's just an efficiency thing | 16:00 |
| mriedem | still needs to be fixed, but i'm not sure that tristanC should hold up on the errata for it | 16:00 |
| dansmith | mriedem: makes sense | 16:01 |
| mriedem | since we're going to release your RUN_ON_REBUILD fix for newton before eol, we should still probably try to get that fixed and backported as well, since the regression was backported to newton also | 16:01 |
| *** psachin has joined #openstack-nova | 16:03 | |
| *** edmondsw has quit IRC | 16:03 | |
| *** edmondsw_ is now known as edmondsw | 16:03 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove vestigial extra_info update in PciDevice.save() https://review.openstack.org/523919 | 16:04 |
| dansmith | mriedem: why aren't you using is_volume_backed from compute utils? | 16:04 |
| mriedem | dansmith: because we already have the stuff in scope for doing the same thing | 16:04 |
| mriedem | the root_bdm | 16:04 |
| dansmith | mriedem: yeah, just seems wrong to not use the util in case there's another detail we add later | 16:05 |
| *** artom_ has joined #openstack-nova | 16:05 | |
| dansmith | but whatever | 16:05 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 16:07 |
| *** artom has quit IRC | 16:07 | |
| openstackgerrit | Ed Leafe proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | 16:07 |
| edleafe | jaypipes: efried: ^^ Just fixed commit messages | 16:08 |
| *** psachin has quit IRC | 16:08 | |
| jaypipes | efried: ^^ | 16:08 |
| jaypipes | oops, sorry | 16:08 |
| efried | ack | 16:08 |
| *** yamamoto has joined #openstack-nova | 16:08 | |
| efried | jaypipes ack | 16:08 |
| *** psachin has joined #openstack-nova | 16:10 | |
| *** imacdonn has quit IRC | 16:11 | |
| *** imacdonn has joined #openstack-nova | 16:11 | |
| mriedem | oomichi_afk: i've got some issues with the functional tests in https://review.openstack.org/#/c/408964/ which can be cleaned up separately, but +2 on that one if you want to review it again | 16:15 |
| *** tidwellr_ has quit IRC | 16:15 | |
| *** tidwellr has joined #openstack-nova | 16:16 | |
| *** yamamoto has quit IRC | 16:17 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Object changes to support last-modified headers https://review.openstack.org/521639 | 16:20 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Add cache headers to placement api requests https://review.openstack.org/521640 | 16:20 |
| cdent | ^ rebase wars | 16:20 |
| *** AlexeyAbashkin has quit IRC | 16:23 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 16:24 |
| *** psachin has quit IRC | 16:31 | |
| *** moshele has quit IRC | 16:33 | |
| *** psachin has joined #openstack-nova | 16:39 | |
| *** moshele has joined #openstack-nova | 16:44 | |
| *** psachin has quit IRC | 16:45 | |
| *** vks1 has quit IRC | 16:48 | |
| *** moshele has quit IRC | 16:49 | |
| *** eharney has quit IRC | 16:50 | |
| *** damien_r has quit IRC | 16:52 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Enable limiting GET /allocation_candidates https://review.openstack.org/513526 | 16:53 |
| *** eharney has joined #openstack-nova | 16:54 | |
| cdent | sigh, at microversin wars with myself | 16:56 |
| *** fragatina has quit IRC | 16:57 | |
| *** udesale has quit IRC | 17:00 | |
| *** weshay is now known as weshay_mtg | 17:00 | |
| *** chyka has joined #openstack-nova | 17:01 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Make _Provider really private https://review.openstack.org/523932 | 17:01 |
| efried | jaypipes ^ | 17:01 |
| efried | jaypipes I didn't try to anticipate getters of _Provider attributes; we can add those as demand arises. | 17:01 |
| *** penick has joined #openstack-nova | 17:01 | |
| *** moshele has joined #openstack-nova | 17:03 | |
| *** suresh12 has quit IRC | 17:05 | |
| *** lucasagomes is now known as lucas-afk | 17:06 | |
| *** Sukhdev has quit IRC | 17:06 | |
| *** sree has joined #openstack-nova | 17:07 | |
| *** sree has quit IRC | 17:12 | |
| *** suresh12 has joined #openstack-nova | 17:15 | |
| *** moshele has quit IRC | 17:17 | |
| *** tidwellr has quit IRC | 17:18 | |
| *** tidwellr has joined #openstack-nova | 17:19 | |
| *** suresh12 has quit IRC | 17:20 | |
| *** fragatina has joined #openstack-nova | 17:20 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Make _Provider really private https://review.openstack.org/523932 | 17:21 |
| openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.uuid_set() https://review.openstack.org/520243 | 17:21 |
| efried | jaypipes And there's uuid_set peeled out and modified as you suggested ^ | 17:21 |
| efried | (plus a silly UT fix on the base) | 17:22 |
| *** efried is now known as efried_rollin | 17:22 | |
| *** moshele has joined #openstack-nova | 17:22 | |
| artom_ | mriedem, is the topic set right for this series? https://review.openstack.org/#/c/521200/ | 17:22 |
| artom_ | I feel like bug/1732947 is the most obvious one | 17:22 |
| artom_ | But I'd like to have related/1664931 somewhere, to keep track of all the changes that are happening because of that initial CVE fix | 17:23 |
| *** suresh12 has joined #openstack-nova | 17:23 | |
| artom_ | Hell, even create a (really weird) blueprint | 17:23 |
| mriedem | artom_: the topic is set to the change on top | 17:23 |
| mriedem | which is a different bug | 17:23 |
| mriedem | track it in bug 1664931? | 17:24 |
| openstack | bug 1664931 in nova (Ubuntu) "[OSSA-2017-005] nova rebuild ignores all image properties and scheduler filters (CVE-2017-16239)" [Undecided,New] https://launchpad.net/bugs/1664931 | 17:24 |
| artom_ | mriedem, I thought they were related? | 17:24 |
| mriedem | bug 1732947 was a regression introduced by the fix for bug 1664931 | 17:24 |
| openstack | bug 1732947 in OpenStack Compute (nova) "volume-backed instance rebuild with no image change is still going through scheduler" [High,In progress] https://launchpad.net/bugs/1732947 - Assigned to Matt Riedemann (mriedem) | 17:25 |
| *** Apoorva has quit IRC | 17:25 | |
| artom_ | mriedem, right, that's what I meant | 17:25 |
| artom_ | Ah, so only the first 2 changes in that series are fixes for 1664931 regressions? | 17:25 |
| mriedem | melwitt: dansmith: are you aware of any functional test examples where we have multiple cells and a compute in each cell, and where fake.set_nodes works? i'm hitting something weird when trying to do a cold migration across 2 cells to assert it fails and hitting some weird stuff when i use fake.set_nodes | 17:26 |
| mriedem | artom_: yes, the last change is a different bug | 17:27 |
| dansmith | mriedem: no, but let me say it'd be nice if we could fix up that weird fake node behavior | 17:27 |
| artom_ | mriedem, aha, thanks :) | 17:27 |
| mriedem | could be related to the cells db fixture stuff being wonky | 17:27 |
| * artom_ is having trouble keeping it all straight in his head | 17:27 | |
| dansmith | we basically work around it in all the tests that need that | 17:27 |
| *** artom_ is now known as artom | 17:27 | |
| *** priteau has joined #openstack-nova | 17:27 | |
| mriedem | artom: create an etherpad? | 17:27 |
| artom | mriedem, yeah, not a bad idea | 17:28 |
| artom | It's still a lot of clicking and checking branches, change IDs and topics | 17:28 |
| artom | Since some (all?) of those got backported | 17:28 |
| melwitt | mriedem: it might be related to the wonkiness I intended to fix with https://review.openstack.org/#/c/508432 | 17:29 |
| melwitt | because without that fix, every compute will write to the same cell db | 17:29 |
| mriedem | i was going to see if putting your patch under this change fixes it | 17:30 |
| melwitt | yeah, I think it would be worth trying but I'm not 100% it will solve your problem. what I'm thinking of is where compute services need to write records and they don't do it in a cell-aware way | 17:31 |
| dansmith | yeah, any periodic will do the wrong thing I think | 17:31 |
| *** vivsoni_ has joined #openstack-nova | 17:31 | |
| melwitt | right | 17:31 |
| melwitt | and during compute start | 17:32 |
| dansmith | I think we need a more fundamental change before we can really be clean there | 17:32 |
| melwitt | but I dunno what problem mriedem is hitting | 17:32 |
| mriedem | i'll push it up in a sec | 17:32 |
| *** suresh12 has quit IRC | 17:32 | |
| *** suresh12 has joined #openstack-nova | 17:33 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 17:33 |
| *** gszasz has quit IRC | 17:33 | |
| mriedem | melwitt: this https://review.openstack.org/#/c/408964/111/nova/tests/functional/test_servers.py@3029 | 17:33 |
| mriedem | so takashi has this test_migrate_server_to_host_in_different_cell test, | 17:34 |
| mriedem | which creates 1 host in different cells, | 17:34 |
| mriedem | creates a server on one of the hosts and tries to force the migration to the other host in the other cell, which should fail | 17:34 |
| mriedem | b/c no cross-cell migration | 17:34 |
| melwitt | yeah, the compute node records won't go in the right db without my patch I think | 17:35 |
| mriedem | it does fail with NoValidHost, but i wanted to test how good the test was, so i pulled it down and changed is so that both hosts would be in the same cell, and the test passed | 17:35 |
| melwitt | they'll all go in the same cell, the default cell1 | 17:35 |
| mriedem | ok | 17:35 |
| *** moshele has quit IRC | 17:35 | |
| mriedem | so i found that if there is more than one host in a cell, like ServerTestV256RescheduleTestCase, then fake.set_nodes has to be used | 17:35 |
| mriedem | but when i tried to use fake.set_nodes on hosts in different cells, things would fail | 17:35 |
| dansmith | if the periodic runs to update the nodes, it'll put them back in the wrong cell though right? | 17:36 |
| dansmith | er, create duplicates in the wrong cell I mean | 17:36 |
| *** ralonsoh has quit IRC | 17:36 | |
| melwitt | I have seen that before doing single cell functional testing with multiple computes, that set_nodes is needed to have the scheduler consider both computes | 17:36 |
| mriedem | all of our server moving tests in nova.tests.functional.test_servers create 2 computes in the same cell and have to use fake.set_nodes | 17:36 |
| mriedem | but we don't have any multi-cell functional tests like that | 17:37 |
| mriedem | this is really just a negative test, but i wanted to make sure it was actually failing for the right reasons | 17:37 |
| melwitt | mriedem: it's not the set_nodes thing but the ComputeNode record itself that you'd want to target to separate cells and set_nodes won't do that. set_nodes doesn't write the compute node record | 17:37 |
| mriedem | since you can't actually tell what the novalidhost was for on the api caller side | 17:37 |
| melwitt | the compute node record is written by the fake compute service starting up | 17:37 |
| mriedem | i'll pull your change down and put this on top and use fake.set_nodes and see what happens | 17:37 |
| melwitt | okay | 17:38 |
| *** gbarros has joined #openstack-nova | 17:38 | |
| *** gbarros_ has quit IRC | 17:38 | |
| dansmith | melwitt: won't your patch result in compute node records written into cell0 (which should never happen) if the periodic runs? | 17:39 |
| *** mdnadeem has quit IRC | 17:40 | |
| *** vks1 has joined #openstack-nova | 17:40 | |
| dansmith | the resource tracker update periodic that creates and destroys compute nodes on the fly for things like ironic | 17:40 |
| melwitt | dansmith: I think I make the db association when the fake service is created and wrapped all the service calls so that the periodics would run in the right cell. but let me look again, it's been a long time | 17:40 |
| dansmith | it'll find that virt reports a compute node that it doesn't find in the database and create it | 17:40 |
| dansmith | hmm, not sure how you could do that for periodics that run later | 17:41 |
| mriedem | still fails | 17:42 |
| melwitt | dansmith: I think periodics are run by the service, so I did this https://review.openstack.org/#/c/508432/9/nova/test.py to target them to the associated cell | 17:42 |
| dansmith | oh you patch periodic_tasks | 17:42 |
| dansmith | not sure that's enough necessarily, | 17:43 |
| dansmith | because anything that stores a context somewhere might not actually make that call in that path | 17:43 |
| melwitt | it's better than what we have :P but yeah, I have been wanting people to review it to see what gaps could be addressed | 17:43 |
| dansmith | well, it's not if we end up with spurious failures when we get unlucky and run a periodic in the middle of a slow test run | 17:44 |
| *** sree has joined #openstack-nova | 17:44 | |
| mriedem | i left comments on the fixture patch | 17:44 |
| melwitt | dansmith: what do you mean by "anything that stores a context somewhere"? the periodics in the compute service all use an anonymous admin context | 17:44 |
| *** suresh12 has quit IRC | 17:44 | |
| dansmith | melwitt: well, if something like RT has a context stored somewhere | 17:45 |
| *** sridharg has joined #openstack-nova | 17:45 | |
| *** suresh12 has joined #openstack-nova | 17:45 | |
| melwitt | dansmith: sure. I couldn't think of if/how it could be bullet-proofed | 17:46 |
| dansmith | I think the thing we really should be doing is just make the compute manager grab a context on service start, | 17:46 |
| dansmith | and wipe through compute/* and make sure nothing ever calls get_admin_context() or context.RequestContext() in there | 17:46 |
| dansmith | sort of how we banned db access | 17:46 |
| melwitt | yeah, that would be nicer | 17:47 |
| dansmith | I think that also, | 17:47 |
| melwitt | still, that doesn't stop anyone from doing something else, which is what you were pointing out | 17:47 |
| dansmith | someone with "security" in their title would like to see that we can't just call foo.get_admin_credentials() anywhere | 17:47 |
| mriedem | i think mikal is now head of security at aptira | 17:48 |
| mriedem | securinaut or something | 17:48 |
| dansmith | melwitt: well, it does if we actually clean that up to the point of making sure it won't work, like the db stuff | 17:48 |
| *** sree has quit IRC | 17:48 | |
| *** sambetts is now known as sambetts|afk | 17:48 | |
| melwitt | one thing I realized just now is, a context is handed off when the periodic tasks are kicked off once, and it reuses that. it's just that in the service code it uses get_admin_context for that | 17:48 |
| melwitt | periodic_tasks is called once during service.start | 17:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix ValueError when loading old pci device record https://review.openstack.org/523914 | 17:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove vestigial extra_info update in PciDevice.save() https://review.openstack.org/523919 | 17:50 |
| dansmith | yeah, but your wrapping of it ensures that anyway | 17:50 |
| *** derekh has quit IRC | 17:51 | |
| melwitt | but I thought you were saying "what if compute manager uses a different context" and it can't | 17:51 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Enable limiting GET /allocation_candidates https://review.openstack.org/513526 | 17:51 |
| melwitt | https://github.com/openstack/nova/blob/master/nova/service.py#L294-L295 | 17:51 |
| dansmith | melwitt: I'm saying if we have another context we got from not the periodic one we were handed, not in the scope of the periodic itself | 17:51 |
| dansmith | we have contexts everywhere, on every object, etc | 17:51 |
| dansmith | I thought we actually stored on in the RT too but I don't think we do | 17:51 |
| melwitt | okay, yeah I thought you were talking only about periodics | 17:52 |
| dansmith | ah in the claim we do, that's probably what I'm thinking of | 17:52 |
| dansmith | melwitt: I mean a periodic that accesses one created outside the scope of the periodic, like claim for example | 17:52 |
| melwitt | oh, I see | 17:52 |
| melwitt | yeah | 17:52 |
| *** sree has joined #openstack-nova | 17:55 | |
| melwitt | mriedem: I think you might have to not do your own _setup_compute_service | 17:57 |
| *** suresh12 has quit IRC | 17:58 | |
| cdent | jaypipes, efried_rollin : is n-r-p stack clean and reviewable? Last I checked last night might rebase was in progress. | 17:58 |
| *** sree has quit IRC | 17:59 | |
| *** salv-orl_ has quit IRC | 17:59 | |
| *** salv-orlando has joined #openstack-nova | 17:59 | |
| *** salv-orlando has quit IRC | 17:59 | |
| *** penick has quit IRC | 18:00 | |
| *** thorst has quit IRC | 18:00 | |
| *** moshele has joined #openstack-nova | 18:00 | |
| *** penick has joined #openstack-nova | 18:01 | |
| *** salv-orlando has joined #openstack-nova | 18:03 | |
| *** sshwarts has quit IRC | 18:04 | |
| *** thorst has joined #openstack-nova | 18:06 | |
| *** penick has quit IRC | 18:06 | |
| openstackgerrit | melanie witt proposed openstack/nova master: qemu-img do not use cache=none if no O_DIRECT support https://review.openstack.org/523554 | 18:07 |
| *** Apoorva has joined #openstack-nova | 18:07 | |
| *** Apoorva has quit IRC | 18:08 | |
| *** Apoorva has joined #openstack-nova | 18:08 | |
| *** yamahata has quit IRC | 18:09 | |
| *** dtantsur is now known as dtantsur|afk | 18:10 | |
| *** moshele has quit IRC | 18:10 | |
| *** thorst has quit IRC | 18:11 | |
| dansmith | stephenfin: https://review.openstack.org/#/c/523914 | 18:12 |
| melwitt | mriedem: I pulled down your patch to see if I can find anything | 18:13 |
| mriedem | dansmith: that root_bdm thing with using compute_utils.is_volume_backed opens up some funny doors | 18:15 |
| mriedem | probably nothing we'd ever hit in real life | 18:16 |
| dansmith | mriedem: yeah? | 18:16 |
| mriedem | is_volume_backed_instance returns True if there is no root bdm but the image_ref is '' | 18:16 |
| mriedem | so "volume_id = root_bdm.volume_id" could result in a NoneType | 18:16 |
| *** jpena is now known as jpena|away | 18:17 | |
| mriedem | nova.tests.unit.compute.test_compute.ComputeAPITestCase.test_rebuild_no_image apparently tickles that path | 18:17 |
| mriedem | in that case i guess i just log an error or something, not sure | 18:17 |
| mriedem | shouldn't really happen | 18:18 |
| *** thorst has joined #openstack-nova | 18:18 | |
| *** tidwellr_ has joined #openstack-nova | 18:20 | |
| *** tidwellr has quit IRC | 18:20 | |
| *** thorst has quit IRC | 18:22 | |
| *** READ10 has joined #openstack-nova | 18:28 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Refactor encryptor attach and detach calls https://review.openstack.org/460243 | 18:29 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Introduce disk encryption config classes https://review.openstack.org/464008 | 18:29 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Use QEMU's native LUKS support https://review.openstack.org/523958 | 18:29 |
| *** artom has quit IRC | 18:30 | |
| *** artom has joined #openstack-nova | 18:30 | |
| *** vks1 has quit IRC | 18:30 | |
| *** vivsoni_ has quit IRC | 18:32 | |
| *** salv-orlando has quit IRC | 18:36 | |
| *** mvk has quit IRC | 18:36 | |
| *** phuongnh has joined #openstack-nova | 18:36 | |
| *** salv-orlando has joined #openstack-nova | 18:36 | |
| openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/523765 | 18:37 |
| *** Alex_Staf has joined #openstack-nova | 18:38 | |
| *** INeedaUUID has joined #openstack-nova | 18:38 | |
| INeedaUUID | Hi everyone. Can anyone tell me how best to modify a systems' uuid using openstack methods? | 18:38 |
| INeedaUUID | Does openstack support this? (I know it's a stupid request, but an application depends on them being set) | 18:39 |
| INeedaUUID | Ocata/KVM | 18:39 |
| jaypipes | cdent: efried_rollin is currently rebasing./ | 18:39 |
| jaypipes | cdent: ooh, hold up, he may have pushed a fresh series. | 18:40 |
| *** thorst has joined #openstack-nova | 18:40 | |
| *** thorst has quit IRC | 18:40 | |
| *** thorst has joined #openstack-nova | 18:40 | |
| *** salv-orlando has quit IRC | 18:41 | |
| *** tssurya_ has joined #openstack-nova | 18:42 | |
| *** weshay_mtg is now known as weshay | 18:42 | |
| *** suresh12 has joined #openstack-nova | 18:43 | |
| *** yamahata has joined #openstack-nova | 18:45 | |
| *** david-lyle has joined #openstack-nova | 18:45 | |
| mriedem | gdi, that moment when you rebase a series and forget git add / git rebase --continue on the last change, and did git commit -a --amend instead, thus squashing the last change and ruining everything | 18:45 |
| *** READ10 has quit IRC | 18:46 | |
| *** suresh12 has quit IRC | 18:47 | |
| mriedem | INeedaUUID: no you can't specify the uuid that gets used with the vm | 18:47 |
| INeedaUUID | mriedem: Is there not a workaround at all? | 18:47 |
| *** suresh12 has joined #openstack-nova | 18:47 | |
| mriedem | no | 18:47 |
| INeedaUUID | What about modifying from virsh? | 18:48 |
| mriedem | let me guess, you're doing some kind of instance HA | 18:48 |
| INeedaUUID | actually, no. It's to do with a 3rd party application and the VERY stupid way it licences. | 18:48 |
| mriedem | anything you do to a vm via virsh out of band from nova will likely break nova's ability to do things with that vm | 18:48 |
| INeedaUUID | I thought that. But I will need to try. :-( | 18:49 |
| mriedem | pass metadata through to the guest and have the 3rd party app pull from that | 18:49 |
| dansmith | presumably the app is unchangeable | 18:50 |
| dansmith | getting the uuid from smbios, | 18:50 |
| dansmith | so metadata won't help even if hacked | 18:50 |
| INeedaUUID | dansmith: is correct. Unchangable. | 18:50 |
| dansmith | your options are: | 18:51 |
| INeedaUUID | It's crap, I know it is. But... It's essential. | 18:51 |
| dansmith | 1. lots of scary nova db surgery. don't even tell us about it | 18:51 |
| dansmith | 2. wrap your application in something that fools it | 18:51 |
| dansmith | 3. Get a new application | 18:51 |
| dansmith | I suggest 3, I would do 2, please don't do 1 | 18:52 |
| *** penick has joined #openstack-nova | 18:53 | |
| INeedaUUID | The requirements suggest exactly the opposite of the numbers you propose. But I apprieciate the honesty. It is what it is. | 18:53 |
| INeedaUUID | 3. not an option (don't ask why) | 18:53 |
| dansmith | not an accident :) | 18:53 |
| dansmith | I'm sure | 18:54 |
| INeedaUUID | 2. Not sure if I can do this. Can I have the system uuid somehow I wonder? | 18:54 |
| dansmith | windows or linux guest? | 18:54 |
| INeedaUUID | 1. I'm too stupid, but given the lack of options, it's a few sleepless nights. | 18:54 |
| *** david-lyle has quit IRC | 18:54 | |
| INeedaUUID | linux | 18:54 |
| dansmith | LD_PRELOAD | 18:55 |
| INeedaUUID | If this is an option, I will make this work! :-D | 18:56 |
| cdent | dansmith: you’re potentially a freakin’ genius | 18:56 |
| dansmith | o.O | 18:56 |
| jaypipes | INeedaUUID: is this a telco VNF vendor by any chance? | 18:57 |
| dansmith | gawd jaypipes, there _are_ other closed-source stupid-licensed industries out there | 18:59 |
| *** tidwellr_ has quit IRC | 18:59 | |
| *** Sukhdev has joined #openstack-nova | 18:59 | |
| dansmith | why you always pickin' on those lovable telco people? | 18:59 |
| dansmith | (just kidding, I'm _sure_ that's what this is) | 18:59 |
| jaypipes | dansmith: just a wild guess. ;) | 18:59 |
| mriedem | that reminds me, | 19:00 |
| mriedem | jaypipes: did i tell you how 2 different groups of people approached me about their worries about deprecating the ability to do file injection? | 19:00 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add regression test for rebuilding a volume-backed server https://review.openstack.org/521200 | 19:00 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Get original image_id from volume for volume-backed instance rebuild https://review.openstack.org/521391 | 19:00 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fail fast if changing image on a volume-backed server rebuild https://review.openstack.org/520660 | 19:00 |
| mriedem | at the summit | 19:00 |
| *** tidwellr has joined #openstack-nova | 19:00 | |
| mriedem | verizon and ericsson | 19:00 |
| dansmith | only two? | 19:00 |
| jaypipes | mriedem: yeah, only two? | 19:00 |
| INeedaUUID | jaypipes: I could tell you. But then i'd have to murder you. | 19:01 |
| dansmith | two seems like a mandate to me | 19:01 |
| mriedem | well, most people only say things 3 years after the change is merged | 19:01 |
| mriedem | mikal told the verizon guys that their vnf vendor was "shit" in his aussy words and that they should talk to him | 19:01 |
| jaypipes | mriedem: also, it's probably all rooted in the same dependency on a specific particular vendor VNF or MANO system that requires file injection (and stuff like multi-attach boot-from-volume | 19:01 |
| *** david-lyle has joined #openstack-nova | 19:01 | |
| *** david-lyle has quit IRC | 19:02 | |
| mriedem | multiattach bfv is the bees knees | 19:02 |
| mriedem | i wonder how rebuild is going to handle that... | 19:02 |
| dansmith | probably as well as it handles everything else | 19:03 |
| dansmith | by opening security holes, leaking resource accounting, and destroying data | 19:03 |
| jaypipes | luckily that shotgun I ordered through the mail should be here by the time multi-attach bfv rolls into Nova. | 19:03 |
| dansmith | jaypipes: you're welcome, from america | 19:03 |
| jaypipes | murka | 19:03 |
| mriedem | dansmith: ok i did the deeds in https://review.openstack.org/#/c/521391/3/nova/compute/api.py | 19:03 |
| mriedem | if i can't find a root bdm and image_ref is '', i just log an error and keep trucking | 19:04 |
| mriedem | i don't know if that case is some scary pre-bdmv1 stuff or what, it predates me | 19:04 |
| dansmith | I don't understand where that's ever going to happen | 19:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fail fast if changing image on a volume-backed server rebuild https://review.openstack.org/520660 | 19:06 |
| mriedem | i don't either | 19:06 |
| mriedem | which is why i just log an error and punt | 19:06 |
| dansmith | but you don't punt, | 19:06 |
| *** Oku_OS is now known as Oku_OS-away | 19:06 | |
| dansmith | you set it to None, which causes the need for that extra else and then kick the can to the next thing in line | 19:06 |
| *** tssurya_ has quit IRC | 19:06 | |
| dansmith | why not just dump ass right there and stop? | 19:06 |
| *** tssurya_ has joined #openstack-nova | 19:07 | |
| mriedem | we could, but what do we raise? it's a 500 if we raise i think | 19:07 |
| dansmith | is that less right than logging an error and saying "this is just going to break in the next service down" ? | 19:07 |
| mriedem | at this point it would run through the scheduler with the provided image | 19:08 |
| mriedem | which is basically what this was trying to fix - not doing that if the image doesn't change | 19:08 |
| mriedem | the final patch in that series will fail though | 19:08 |
| mriedem | i'm cool with a 500 if there isn't a root_bdm | 19:08 |
| dansmith | if we run the scheduler and instance.image_ref is falsey it'll be happy? | 19:09 |
| *** mvk has joined #openstack-nova | 19:09 | |
| *** slaweq has joined #openstack-nova | 19:10 | |
| mriedem | we'd run the scheduler on the new image provided to rebuild | 19:10 |
| mriedem | well, new or the same as the original | 19:10 |
| dansmith | oh, I see | 19:11 |
| dansmith | still, I dunno | 19:11 |
| dansmith | seems dumb to me | 19:11 |
| mriedem | there is this no_device flag on the bdmv1 stuff, i don't know what that does | 19:11 |
| dansmith | heh | 19:11 |
| mriedem | like, i don't know if there is a way to tell the api not to create you any bdms but still give you a volume-backed instance | 19:11 |
| *** sridharg has quit IRC | 19:11 | |
| *** tssurya_ has quit IRC | 19:12 | |
| *** hemna_ has quit IRC | 19:13 | |
| *** phuongnh has quit IRC | 19:15 | |
| *** slaweq has quit IRC | 19:17 | |
| *** slaweq has joined #openstack-nova | 19:18 | |
| *** david-lyle has joined #openstack-nova | 19:21 | |
| *** slaweq has quit IRC | 19:22 | |
| *** smatzek has quit IRC | 19:32 | |
| *** tidwellr has quit IRC | 19:32 | |
| *** ociuhandu has joined #openstack-nova | 19:32 | |
| *** david-lyle has quit IRC | 19:34 | |
| *** david-lyle has joined #openstack-nova | 19:35 | |
| *** ociuhandu has quit IRC | 19:36 | |
| *** salv-orlando has joined #openstack-nova | 19:37 | |
| *** damien_r has joined #openstack-nova | 19:38 | |
| *** tidwellr has joined #openstack-nova | 19:38 | |
| *** smatzek has joined #openstack-nova | 19:38 | |
| *** smatzek_ has joined #openstack-nova | 19:41 | |
| *** salv-orlando has quit IRC | 19:42 | |
| *** smatzek has quit IRC | 19:43 | |
| *** amodi has joined #openstack-nova | 19:43 | |
| *** Alex_Staf has quit IRC | 19:45 | |
| *** smatzek_ has quit IRC | 19:46 | |
| *** smatzek has joined #openstack-nova | 19:46 | |
| *** tidwellr has quit IRC | 19:48 | |
| *** jpena|away is now known as jpena|off | 19:48 | |
| *** jose-phi_ has quit IRC | 19:49 | |
| *** linkmark has joined #openstack-nova | 19:50 | |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_certs object https://review.openstack.org/489408 | 19:50 |
| *** smatzek_ has joined #openstack-nova | 19:51 | |
| *** smatzek has quit IRC | 19:51 | |
| *** david-lyle has quit IRC | 19:53 | |
| openstackgerrit | Merged openstack/nova master: placement: add nested resource providers https://review.openstack.org/377138 | 19:55 |
| *** moshele has joined #openstack-nova | 19:55 | |
| edleafe | ^^ woo hoo! | 19:55 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Raise specific exception when swapping migration allocations fails https://review.openstack.org/517004 | 20:01 |
| *** david-lyle has joined #openstack-nova | 20:04 | |
| openstackgerrit | Merged openstack/nova master: Remove deprecated TrustedFilter https://review.openstack.org/506864 | 20:05 |
| openstackgerrit | Merged openstack/nova master: libvirt: do unicode conversion for error messages. https://review.openstack.org/517555 | 20:05 |
| efried_rollin | cdent jaypipes I'm not rebasing nrp at the moment. I just peeled out one of the changes. Since the first one merged, the bottom three should currently be clean and reviewable. I wouldn't go above that. | 20:07 |
| *** efried_rollin is now known as efried | 20:07 | |
| *** tidwellr has joined #openstack-nova | 20:08 | |
| openstackgerrit | melanie witt proposed openstack/nova master: qemu-img do not use cache=none if no O_DIRECT support https://review.openstack.org/523554 | 20:09 |
| *** AlexeyAbashkin has joined #openstack-nova | 20:14 | |
| *** suresh12 has quit IRC | 20:15 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: Add PowerVM to compute_driver options https://review.openstack.org/523978 | 20:18 |
| *** spectr has joined #openstack-nova | 20:18 | |
| *** AlexeyAbashkin has quit IRC | 20:18 | |
| *** suresh12 has joined #openstack-nova | 20:19 | |
| *** spectr has quit IRC | 20:20 | |
| *** slaweq has joined #openstack-nova | 20:21 | |
| *** smatzek_ has quit IRC | 20:21 | |
| *** suresh12 has quit IRC | 20:21 | |
| *** smatzek has joined #openstack-nova | 20:22 | |
| *** smatzek has quit IRC | 20:24 | |
| cdent | efried: thanks for the info. will try to get some reviewing in before I stop today | 20:26 |
| *** Sukhdev has quit IRC | 20:26 | |
| *** smatzek has joined #openstack-nova | 20:26 | |
| *** salv-orlando has joined #openstack-nova | 20:27 | |
| *** tidwellr has quit IRC | 20:27 | |
| *** tidwellr has joined #openstack-nova | 20:28 | |
| *** smatzek has quit IRC | 20:28 | |
| *** jaypipes has quit IRC | 20:29 | |
| *** smatzek has joined #openstack-nova | 20:29 | |
| *** smatzek has quit IRC | 20:30 | |
| *** Alex_Staf has joined #openstack-nova | 20:31 | |
| *** moshele has quit IRC | 20:32 | |
| *** smatzek_ has joined #openstack-nova | 20:33 | |
| *** READ10 has joined #openstack-nova | 20:35 | |
| *** smatzek__ has joined #openstack-nova | 20:35 | |
| *** smatzek__ has quit IRC | 20:35 | |
| mriedem | anyone else noticing a spike in cellsv1 job failures? | 20:35 |
| mriedem | http://logs.openstack.org/10/523910/1/check/legacy-tempest-dsvm-cells/76a0551/logs/screen-n-sch.txt.gz#_Nov_29_16_05_42_186316 | 20:35 |
| *** smatzek__ has joined #openstack-nova | 20:35 | |
| *** penick has quit IRC | 20:35 | |
| * dansmith runs | 20:36 | |
| *** smatzek_ has quit IRC | 20:37 | |
| dansmith | that filter isn't on by default, right? are we forcing it on? | 20:37 |
| mriedem | it's enabled in devstack | 20:37 |
| dansmith | oh | 20:38 |
| *** tidwellr has quit IRC | 20:38 | |
| mriedem | this isn't a new test and logstash is not showing me a bunch of failures, so maybe just very random | 20:38 |
| *** tidwellr has joined #openstack-nova | 20:38 | |
| dansmith | and the test isn't requesting samehost= ? | 20:38 |
| mriedem | it is | 20:39 |
| mriedem | and it's a single node job | 20:39 |
| mriedem | separate requests though, | 20:39 |
| mriedem | so the HostState might not have the previous host tracked in memory when the 2nd request comes in? | 20:39 |
| dansmith | idk | 20:40 |
| dansmith | I mean, | 20:40 |
| *** artom has quit IRC | 20:40 | |
| dansmith | if it's requesting a samehost then that has to be why | 20:40 |
| dansmith | it's pretty simple | 20:40 |
| efried | cdent You got a handle on how API fixtures are working in the functional test suites? | 20:40 |
| mriedem | it's doing same_host on 'dad917c1-11bf-4aa1-9c3b-c864cdbc97c6' | 20:41 |
| mriedem | http://logs.openstack.org/10/523910/1/check/legacy-tempest-dsvm-cells/76a0551/logs/screen-n-sch.txt.gz#_Nov_29_16_05_42_182254 | 20:41 |
| *** tssurya_ has joined #openstack-nova | 20:42 | |
| cdent | efried: nova api fixtures? slightly. I made some adjustments to them recently. What’s up? | 20:42 |
| mriedem | and when we request with the same_host, the HostState is tracking c9115b21-9355-4d1b-b797-62d2db7ca1ac and f5cb92ec-0474-4f4f-a1de-1d303e67e5f0 | 20:42 |
| *** suresh12 has joined #openstack-nova | 20:42 | |
| mriedem | we don't update the HostState with that instance until later http://logs.openstack.org/10/523910/1/check/legacy-tempest-dsvm-cells/76a0551/logs/screen-n-sch.txt.gz#_Nov_29_16_06_17_769927 | 20:43 |
| mriedem | which is...odd | 20:43 |
| mriedem | i thought we always updated the host state after we've "claimed" an instance on that host | 20:43 |
| mriedem | edleafe: ^ | 20:43 |
| *** david-lyle has quit IRC | 20:45 | |
| edleafe | mriedem: https://github.com/openstack/nova/blob/master/nova/scheduler/filter_scheduler.py#L255 | 20:46 |
| edleafe | mriedem: is this running filter_scheduler? | 20:47 |
| *** threestrands has joined #openstack-nova | 20:47 | |
| *** threestrands has quit IRC | 20:47 | |
| *** threestrands has joined #openstack-nova | 20:47 | |
| mriedem | i guess _locked_consume_from_request doesn't actually add the "consumed" instance to it's list of running instances on that host | 20:47 |
| mriedem | edleafe: yes | 20:47 |
| mriedem | it has to wait for the track_instance_changes stuff from the compute to send an rpc message to the scheduler that the instance actually landed there? | 20:47 |
| dansmith | mriedem: how many times have you seen this? | 20:47 |
| mriedem | dansmith: just now | 20:47 |
| dansmith | I thought you said logstash isn't crying? | 20:47 |
| mriedem | it's not | 20:47 |
| dansmith | okay | 20:47 |
| mriedem | so, probably totally latent | 20:47 |
| mriedem | and just running on a slow node or something | 20:47 |
| mriedem | it just seems odd that we update the HostState in memory to consume resources from the request spec, but we don't actually count that instance as tracked on the chosen host at the same time | 20:48 |
| mriedem | like, i get we might rebuild and the instance will end up on another host, but then the consumed resources on that HostState object are also wrong in that case | 20:48 |
| mriedem | until they sync up | 20:48 |
| *** Alex_Staf has quit IRC | 20:49 | |
| *** gbarros has quit IRC | 20:51 | |
| mriedem | edleafe: yeah i'm surprised we don't call something like this during that "consume_from_request" call https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L767 | 20:52 |
| mriedem | we "consume" the resources but we don't track that instance against that host until it syncs up from the compute | 20:52 |
| dansmith | well, that's the classic scheduler race right? | 20:53 |
| mriedem | which, in superconductor separated cells v2 world, we can't rely on b/c the computes can't cast to the scheduler | 20:53 |
| dansmith | we consume in the num_instances loop, | 20:53 |
| *** erlon has quit IRC | 20:53 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: Add PowerVM to compute_driver options https://review.openstack.org/523978 | 20:53 |
| dansmith | but until it hits the compute it's still unclaimed | 20:53 |
| dansmith | but placement claims should be sealing that off for everything now | 20:54 |
| mriedem | sure, but the resource claim isn't the problem here, it's really the affinity stuff | 20:54 |
| mriedem | which we know is still a gap | 20:54 |
| dansmith | ah right | 20:54 |
| mriedem | which now that i'm thinking about this, | 20:55 |
| mriedem | i thought within a single request, we tracked which instances landed on which hosts so the affinity filters would work (within the same request) | 20:55 |
| mriedem | but now i can't find where that happens | 20:55 |
| melwitt | cells meeting in 4 minutes? | 20:57 |
| dansmith | yep | 20:57 |
| melwitt | cool | 20:57 |
| *** salv-orlando has quit IRC | 20:58 | |
| *** crlb has quit IRC | 21:00 | |
| *** pcaruana has quit IRC | 21:00 | |
| *** salv-orlando has joined #openstack-nova | 21:04 | |
| *** david-lyle has joined #openstack-nova | 21:04 | |
| *** moshele has joined #openstack-nova | 21:04 | |
| *** liverpooler has quit IRC | 21:08 | |
| *** damien_r1 has joined #openstack-nova | 21:10 | |
| *** penick has joined #openstack-nova | 21:11 | |
| *** damien_r has quit IRC | 21:11 | |
| *** gbarros has joined #openstack-nova | 21:12 | |
| *** lyan has quit IRC | 21:13 | |
| *** smatzek__ has quit IRC | 21:18 | |
| *** lyan has joined #openstack-nova | 21:19 | |
| *** sahid has quit IRC | 21:21 | |
| dansmith | mriedem: so, yesterday I was thinking that this would be easier than what we do for instances because we don't have variable sort keys and such | 21:23 |
| dansmith | and it is a little, | 21:23 |
| dansmith | but the local/global marker thing still needs to happen, AFAIK, which makes it more similar I guess | 21:23 |
| * cdent writes new job description: resolve merge conflicts | 21:24 | |
| dansmith | it's quite unfortunate that we have to be able to do this tbh.. listing migrations per instance is a lot easier obviously | 21:24 |
| dansmith | in general, I think that it's a good idea for us to try to avoid adding more operations that list multiple things that are not scoped to an instance, as that's kindof nova's primary key | 21:25 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_certs object https://review.openstack.org/489408 | 21:25 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 21:25 |
| mriedem | well, listing things across cells is fine, like services and compute nodes | 21:26 |
| mriedem | it's the paging that is killing this | 21:27 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 21:27 |
| dansmith | right, but services and compute nodes scale with nodes, | 21:27 |
| dansmith | migrations scale with instances | 21:27 |
| dansmith | listing bdms would be similarly painful, for example | 21:27 |
| mriedem | yeah, we should have far fewer migrations than instances or bdms, but yeah - but that's also why they have this spec, to page across a large number of migrations | 21:28 |
| mriedem | anyway, maybe his older PS was more correct https://review.openstack.org/#/c/517273/21/nova/compute/migration_list.py | 21:29 |
| dansmith | I dunno, over time you probably end up with more migrations than instances, no? | 21:29 |
| mriedem | because it was doing local marker stuff | 21:29 |
| mriedem | we delete migrations when we delete instances | 21:29 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 21:29 |
| dansmith | sure, but if you've got like 40% pets, and they all move a couple times a year for maintenance, | 21:29 |
| dansmith | you're over that limit | 21:29 |
| mriedem | good poitn | 21:30 |
| mriedem | *point | 21:30 |
| dansmith | and if you have, gasp, 95% pets... | 21:30 |
| dansmith | but surely nobody.... :D | 21:30 |
| mriedem | i'd be willing to best most of huawei public cloud's customers are running pets | 21:30 |
| mriedem | enterprise nfv pets | 21:30 |
| dansmith | exactly | 21:30 |
| mriedem | *bet | 21:30 |
| dansmith | I expect most people that want this are running north of 90% :) | 21:30 |
| *** READ10 has quit IRC | 21:30 | |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 21:31 |
| *** lyan has quit IRC | 21:33 | |
| *** penick has quit IRC | 21:42 | |
| *** damien_r1 has quit IRC | 21:42 | |
| melwitt | mriedem: did you want me to fix the thing I found in one of the volume update backports? https://review.openstack.org/#/c/523911 | 21:43 |
| mriedem | yeah | 21:44 |
| melwitt | k, doing | 21:44 |
| *** gbarros has quit IRC | 21:44 | |
| oomichi_afk | alex_xu: nice work, +2 for both | 21:47 |
| *** oomichi_afk is now known as oomichi | 21:48 | |
| oomichi | alex_xu: gmann_afk: happy to see your feedback on https://review.openstack.org/#/c/523194 | 21:49 |
| *** tidwellr has quit IRC | 21:50 | |
| *** tidwellr has joined #openstack-nova | 21:51 | |
| *** oomichi is now known as oomichi_afk | 21:51 | |
| *** edmondsw has quit IRC | 21:51 | |
| *** edmondsw has joined #openstack-nova | 21:53 | |
| mriedem | melwitt: a couple of questions in your quota dead code removal patch https://review.openstack.org/#/c/511689/ | 21:54 |
| melwitt | mriedem: cool, thanks for looking | 21:54 |
| *** penick has joined #openstack-nova | 21:55 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | 21:57 |
| openstackgerrit | melanie witt proposed openstack/nova stable/ocata: Save updated libvirt domain XML after swapping volume https://review.openstack.org/523911 | 21:57 |
| *** edmondsw has quit IRC | 21:58 | |
| *** takashin has joined #openstack-nova | 21:58 | |
| *** Apoorva_ has joined #openstack-nova | 22:02 | |
| *** rcernin has joined #openstack-nova | 22:03 | |
| *** cdent has quit IRC | 22:03 | |
| *** suresh12 has quit IRC | 22:04 | |
| *** eharney has quit IRC | 22:05 | |
| *** Apoorva has quit IRC | 22:05 | |
| *** suresh12 has joined #openstack-nova | 22:09 | |
| *** lyan has joined #openstack-nova | 22:10 | |
| *** pchavva has quit IRC | 22:11 | |
| *** jmlowe has quit IRC | 22:16 | |
| *** thorst has quit IRC | 22:19 | |
| melwitt | mriedem: replied. I can push a new rev if you don't find any other issues with it | 22:25 |
| *** ejat has quit IRC | 22:25 | |
| *** ejat has joined #openstack-nova | 22:26 | |
| *** ejat has quit IRC | 22:26 | |
| *** ejat has joined #openstack-nova | 22:26 | |
| mriedem | melwitt: replied, +W, just deal with the other cleanup in a follow up | 22:30 |
| melwitt | mriedem: k, thanks | 22:30 |
| *** jmlowe has joined #openstack-nova | 22:31 | |
| *** tidwellr has quit IRC | 22:32 | |
| *** edmondsw has joined #openstack-nova | 22:32 | |
| *** slaweq has quit IRC | 22:32 | |
| openstackgerrit | melanie witt proposed openstack/nova master: qemu-img do not use cache=none if no O_DIRECT support https://review.openstack.org/523554 | 22:33 |
| *** penick has quit IRC | 22:34 | |
| melwitt | I've had to fix that a billion times because that direct io test function tries to create a file to check something, but the file create fails in CI but not locally | 22:34 |
| *** slaweq has joined #openstack-nova | 22:34 | |
| *** edmondsw has quit IRC | 22:37 | |
| mgagne | I'm reading https://docs.openstack.org/nova/pike/user/placement.html#ocata-15-0-0 | 22:38 |
| mgagne | what does "Users of CellsV1 will need to deploy a placement per cell, matching the scope and cardinality of the regular nova-scheduler process." mean? | 22:38 |
| *** slaweq has quit IRC | 22:39 | |
| *** burt has quit IRC | 22:40 | |
| mriedem | mgagne: means you'd have a placement service running per child cell, like the nova-scheduler process using the FilterScheduler (not the cell scheduler at the top api cell); that's what belmiro is doing at CERN, but I think you could also do a global placement (like keystone), which is what smorrison at NeCTAR is planning on doing. | 22:42 |
| mriedem | i can't exactly remember why belmiro was going to do it per-cell to start, because he was also going to run into some service catalog entry issues with that, and maybe have to put the per-cell placement endpoints in per-cell regions in the catalog | 22:43 |
| *** lyan has quit IRC | 22:43 | |
| mgagne | ok, what I'm wondering is: isn't placement a HTTP api? if so, how do I declare it in the catalog if catalog is cell agnostic? I also couldn't find (when I checked) a way to override the placement API url in the config. | 22:43 |
| mriedem | right, i think that's what belmiro ran into and was going to have to do some funny stuff with regions in the catalog | 22:44 |
| mgagne | right... imo, the upgrade note suggests a solution which isn't really possible without thinking outside the box or something | 22:44 |
| mriedem | there isn't an option to override the endpoint url for placement in nova.conf | 22:44 |
| mgagne | there is not | 22:44 |
| mriedem | mgagne: yeah, i think that was written before belmiro started looking at doing that | 22:44 |
| mriedem | dansmith: tssurya_: do you remember why belmiro decided to do a per-cell placement service rather than a global one? | 22:45 |
| mriedem | mgagne: would probaly be good if we could start an etherpad or get a ML thread started with notes from belmiro and smorrison about what they are doing | 22:45 |
| mriedem | i could start that if you want | 22:45 |
| mgagne | sure, I'm trying to understand what I need to do for newton and I keep reading stuff I don't fully understand or I don't know how it can technically be doable | 22:47 |
| mriedem | yeah let me start an etherpad for notes | 22:48 |
| *** edmondsw has joined #openstack-nova | 22:48 | |
| mgagne | so if the recommended way to run placement api is globally, I don't understand why upgrade notes suggest something else | 22:49 |
| INeedaUUID | dansmith: Ohhh. You're gonna hate what I did to sort changing the uuids. | 22:49 |
| *** thorst has joined #openstack-nova | 22:50 | |
| INeedaUUID | You're gonna tel me it's not a good idea. So happy for you to facepalm and tell me i'm stupid. | 22:50 |
| mriedem | mgagne: i think that was written before we released the catalog issue | 22:51 |
| mgagne | would there be a way to update the document? | 22:52 |
| mriedem | yeah | 22:53 |
| openstackgerrit | Merged openstack/nova master: Add 'all_tenants' for GET sec group api ref https://review.openstack.org/522910 | 22:53 |
| mgagne | also, is the placement api supposed to be available to the end user? if so, for what purpose? | 22:53 |
| *** thorst has quit IRC | 22:55 | |
| mriedem | no, it's admin-only | 22:55 |
| *** esberglu has quit IRC | 22:55 | |
| *** penick has joined #openstack-nova | 22:55 | |
| mriedem | i think i remember why belmiro was doing per-cell, it's because then the per-child cell scheduler is only asking placement for hosts in that cell, so it's a perf thing in the scheduler | 22:56 |
| mriedem | because cellA scheduler doesn't need to wittle out computes from cellB | 22:56 |
| mriedem | https://etherpad.openstack.org/p/cellsv1-to-v2-migration | 22:56 |
| *** thorst has joined #openstack-nova | 22:56 | |
| openstackgerrit | Merged openstack/nova master: Remove unnecessary self.flags and ConfPatcher https://review.openstack.org/522993 | 22:57 |
| mgagne | "no way to override the placement endpoint URL in nova.conf per child cell before Queens" interesting. so it's now possible | 22:58 |
| mriedem | mgagne: yeah, i forgot that with the keystoneauth adapter stuff that efried worked on, we now have an endpoint_override option for [placement] in nova.conf | 22:58 |
| mriedem | in queens | 22:58 |
| mgagne | good stuff, we heavily rely on endpoint override. and no, we don't care about DNS split view, not gonna happen for us. ;) | 22:59 |
| mriedem | that's part of the point of https://specs.openstack.org/openstack/nova-specs/specs/queens/approved/use-ksa-adapter-for-endpoints.html | 23:00 |
| mriedem | consistent configuration of all of the services that nova talks to | 23:00 |
| mgagne | super good news! | 23:01 |
| *** thorst has quit IRC | 23:01 | |
| mgagne | I was a bit worried because I keep reading on the list that DNS split view is the (only) way to go. and everything else is "garbage" or a state of the art solution. | 23:02 |
| *** Apoorva_ has quit IRC | 23:03 | |
| *** Apoorva has joined #openstack-nova | 23:04 | |
| *** penick has quit IRC | 23:04 | |
| mriedem | dansmith: melwitt: tssurya_: fyi https://etherpad.openstack.org/p/cellsv1-to-v2-migration | 23:04 |
| mgagne | how don't know how to work that question: When should you move to cellsv2? Maybe based on multiple use cases: you current have no cells. you have only one cell, you have multiple cells. You need X features which is only available in release Y. etc. | 23:05 |
| mgagne | and eventually: how | 23:05 |
| mriedem | dansmith did a talk about that question in sydney | 23:09 |
| mriedem | i'll link in the video | 23:09 |
| mriedem | takashin: hey, i'm trying to fix https://review.openstack.org/#/c/408964/ | 23:09 |
| *** penick has joined #openstack-nova | 23:09 | |
| mriedem | takashin: i think the multi-cell functional test is intermittently failing | 23:09 |
| *** gibi has quit IRC | 23:10 | |
| *** hoonetorg has joined #openstack-nova | 23:10 | |
| mriedem | mgagne: https://www.openstack.org/videos/sydney-2017/adding-cellsv2-to-your-existing-nova-deployment | 23:10 |
| *** gszasz has joined #openstack-nova | 23:11 | |
| melwitt | mriedem: if we have a nova change that depends on an os-brick fix, and we get a new os-brick release and it's in our requirements.txt, how would that work for a backport? | 23:11 |
| melwitt | are we able to bump requirements.txt os-brick version on a stable branch or? | 23:11 |
| mriedem | melwitt: this is your crazy newton hard reboot thing isn't it | 23:11 |
| mriedem | melwitt: no | 23:11 |
| mriedem | not on stable | 23:11 |
| mriedem | melwitt: you can do whatever you want downstream of course | 23:12 |
| melwitt | yes ... it's the compute host reboot thing | 23:12 |
| mriedem | melwitt: but upstream it would likely mean somehow patching in the os-brick changes to nova stable | 23:12 |
| melwitt | yeah, I know. just trying to think how we could fix this up for upstream ppl too | 23:12 |
| *** jmlowe has quit IRC | 23:13 | |
| mgagne | ok, now I have some talks to watch | 23:14 |
| melwitt | I had been thinking, what if I backport the os-brick changes to their stable branches but I wasn't sure if that can map to our stable branches | 23:14 |
| *** AlexeyAbashkin has joined #openstack-nova | 23:14 | |
| *** AlexeyAbashkin has quit IRC | 23:19 | |
| *** INeedaUUID has quit IRC | 23:19 | |
| mgagne | mriedem: ok, so lets say you are running cellsv1 mitaka with multiple cells, your objective is to get to Pike with cellsv2 and with your cells intact. what's the plan? is that possible? | 23:20 |
| mgagne | because that's my biggest concern and nowhere I can read about how to make it happen. | 23:21 |
| *** jmlowe has joined #openstack-nova | 23:21 | |
| *** salv-orlando has quit IRC | 23:22 | |
| mriedem | melwitt: you could backport the os-brick changes to stable, and release a patch .z release of os-brick on stable, you just can't bump the minimum required version of os-brick in g-r on stalbe | 23:22 |
| mriedem | upper-constraints can be updated on stable though if needed | 23:22 |
| *** salv-orlando has joined #openstack-nova | 23:22 | |
| mriedem | mgagne: i think that's what belmiro is working on as well, moving from mitaka with multiple child cells to v2 | 23:23 |
| mriedem | i'm not sure if his goal is pike, or just ocata | 23:23 |
| mgagne | well, at this point, as long as I can get to Pike or a place where cells aren't a concern anymore, I'm fine. | 23:24 |
| mgagne | it's just that it looks like I won't be able to skip releases like I did before due to online data migration | 23:24 |
| melwitt | mriedem: yeah, okay. that's along the lines of what I was thinking. because basically, without the os-brick fix, the nova fix doesn't fully work. we'd have to handle the volume detach exit code in the libvirt driver to fix it on stable if there's no way to get it from a stable branch os-brick | 23:24 |
| mriedem | melwitt: i'd just backport the brick stuff, release a .z on stable, bump upper-constraints and then if anyone needs the fix for libvirt in nova on stable, they have to pick up the updated os-brick | 23:25 |
| *** mlavalle has quit IRC | 23:25 | |
| mriedem | we just won't force it via g-r | 23:25 |
| *** linkmark has quit IRC | 23:25 | |
| mriedem | mgagne: i don't think you've been able to skip the online data migrations since kilo | 23:26 |
| mriedem | or shouldn't have | 23:26 |
| mgagne | well, I upgraded from kilo to mitaka just fine =) | 23:26 |
| mriedem | we've put in blocker schema migrations if you haven't completed the online data migrations | 23:26 |
| mriedem | sure, maybe you just didn't need to migrate any of that stuff | 23:26 |
| *** salv-orlando has quit IRC | 23:27 | |
| mgagne | well, there is a glitch with cellsv1 where service rpc version is checked in database and since you aren't running conductor or scheduler in API, migration fails. I just commented that part. | 23:27 |
| mriedem | i might have been thinking of this https://github.com/openstack/nova/blob/stable/newton/nova/db/sqlalchemy/migrate_repo/versions/330_enforce_mitaka_online_migrations.py | 23:27 |
| mriedem | newton schema migration requires that you have done the mitaka online data migrations | 23:27 |
| mgagne | yes, I'm not there yet :P | 23:28 |
| mriedem | "there is a glitch with cellsv1 where service rpc version is checked in database and since you aren't running conductor or scheduler in API, migration fails. I just commented that part." | 23:29 |
| mriedem | where does that happen? | 23:29 |
| melwitt | mriedem: just to clarify, if someone installs nova ocata, they will be prevented from installing the latest os-brick because of upper-constraints? or no? trying to understand the difference between them updating to a os-brick .z release vs just pulling the latest os-brick | 23:29 |
| mriedem | that does remind me of something i think i've talked with dansmith about before which i don't think we're handling yet, maybe we are, but when the api checks the minimum compute service version, i don't know if it's iterating all cells | 23:29 |
| mriedem | melwitt: totally depends on how nova is installed | 23:30 |
| mgagne | will need to check | 23:30 |
| mriedem | if you're pip installing into a tox venv from the nova git repo, then sure :) | 23:30 |
| mriedem | but i doubt most people are doing that | 23:30 |
| melwitt | mriedem: :\ okay. I was thinking whether going through all the .z release stuff helps much or not | 23:30 |
| mriedem | fedora rpm specs null out the requirements.txt so that the rpms are just installed from the versions in the rpm spec fedora says is good | 23:30 |
| *** ijw has joined #openstack-nova | 23:31 | |
| dansmith | mriedem: it is iterating | 23:31 |
| *** priteau has quit IRC | 23:31 | |
| melwitt | I see | 23:31 |
| *** gmann_afk is now known as gmann | 23:31 | |
| mriedem | get_minimum_version_all_cells is | 23:31 |
| *** priteau has joined #openstack-nova | 23:31 | |
| mriedem | dansmith: looks like we only use that in one place, server create for device tagging, | 23:32 |
| mriedem | but, | 23:32 |
| dansmith | hmm, actually | 23:32 |
| mriedem | anything else acting on an instance would be scoped to the cell that instance is in, so min service version checks scoped to that cell would be fine | 23:33 |
| dansmith | now that you mention it, | 23:33 |
| *** penick has quit IRC | 23:33 | |
| mriedem | i'm thinking about your conductor migration allocation min service versoin check | 23:33 |
| mriedem | when we do that, the context should be targeted to the cell that the instance was pulled from | 23:34 |
| dansmith | the problem is we cache it in places | 23:34 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/conductor/tasks/migrate.py#L148 | 23:34 |
| mriedem | oh hmm | 23:35 |
| dansmith | https://github.com/openstack/nova/blob/master/nova/objects/service.py#L396 | 23:35 |
| mriedem | so min compute in cell1 might be 22 and 23 in cell2 | 23:35 |
| mriedem | and if we cached 23, we could f up cell1 | 23:35 |
| mriedem | ? | 23:35 |
| *** thorst has joined #openstack-nova | 23:35 | |
| dansmith | I was going to say we iterate it where we need it and otherwise it's scoped per instance, but.... | 23:35 |
| mriedem | yeah we cache in the api, compute, conductor and scheduler services | 23:36 |
| mriedem | compute is probably fine right? it's scoped to a cell anyway | 23:36 |
| mriedem | but api/scheduler/conductor could be a problem | 23:36 |
| *** priteau has quit IRC | 23:36 | |
| dansmith | right "inside the cell things" are fine | 23:36 |
| dansmith | man I wish we had the CellMapping in the context so we could make the cache just use that to key | 23:37 |
| mgagne | so I can't find the exact cause but I think it was looking for service entries in the API cell database and didn't exclude deleted rows. | 23:38 |
| dansmith | mgagne: I have no doubt that none of this works the way it should for cellsv1 | 23:38 |
| dansmith | mixed-version computes I mean | 23:39 |
| mgagne | or could be with the online migration | 23:39 |
| mriedem | services entries are in the cell dbs | 23:39 |
| mriedem | not the api db | 23:39 |
| mgagne | here https://github.com/openstack/nova/blob/mitaka-eol/nova/objects/pci_device.py#L118-L127 | 23:40 |
| mgagne | if no conductor service is found, the value returned fails the check | 23:40 |
| mgagne | well, maybe I shouldn't have run the online migration in the API cell? ¯\_(ツ)_/¯ | 23:40 |
| *** thorst has quit IRC | 23:41 | |
| mriedem | hm | 23:41 |
| *** ijw has quit IRC | 23:41 | |
| mriedem | dansmith: we create the api/scheduler/conductor services in the cell0 db don't we? | 23:42 |
| dansmith | yup | 23:42 |
| dansmith | I mean, in devstack | 23:42 |
| mriedem | right | 23:42 |
| *** gszasz has quit IRC | 23:43 | |
| mriedem | yeah http://logs.openstack.org/87/523187/2/check/legacy-tempest-dsvm-neutron-full/6b78222/logs/etc/nova/nova.conf.txt.gz | 23:43 |
| mriedem | [database] connection = mysql+pymysql://root:secretmysql@127.0.0.1/nova_cell0?charset=utf8 | 23:43 |
| dansmith | dude, passwords! | 23:43 |
| *** ijw has joined #openstack-nova | 23:44 | |
| *** tetsuro has joined #openstack-nova | 23:44 | |
| mriedem | mgagne: i wonder if you had this fix before you upgraded https://review.openstack.org/#/q/Ic96a5eb3728f97a3c35d2c5121e6fdcd4fd1c70b | 23:46 |
| mriedem | https://review.openstack.org/#/c/438632/ | 23:46 |
| mgagne | yes | 23:46 |
| mgagne | but if no entry is found, I think it returns 0 ou None and it fails | 23:47 |
| *** gibi has joined #openstack-nova | 23:47 | |
| mriedem | yeah you're right https://github.com/openstack/nova/blob/master/nova/objects/service.py#L431-L434 | 23:47 |
| mgagne | but I don't know if I had to run the migration in api cell or not | 23:48 |
| *** tesseract has joined #openstack-nova | 23:48 | |
| mgagne | if i shouldn't, well I think the migration script should have told me: hey, this is an api cell, you shouldn't do that. But I understand that cellsv1 isn't fully tested so yea, what can you do =) | 23:48 |
| *** tesseract has quit IRC | 23:49 | |
| *** marst has quit IRC | 23:49 | |
| mriedem | https://github.com/openstack/nova/commit/50355c4595e08f293f610da32247e405b20c1c5b | 23:49 |
| mriedem | yeah my guess is there was no consideration for cells v1 when that was written in mitaka | 23:49 |
| mriedem | and we don't have grenade (upgrade) ci jobs for cellsv1 | 23:49 |
| *** suresh12 has quit IRC | 23:50 | |
| mriedem | cellsv1 upgrade testing was usually literally alaski or johnthetubaguy saying something broke at rax | 23:50 |
| mgagne | ok, that's fine, mitaka migration is behind us. but I guess same migration will fail again with newton if I try to run it in api cell. | 23:50 |
| mriedem | that code was dropped in newton | 23:50 |
| mriedem | because we have that schema migration blocker in newton | 23:50 |
| mriedem | https://github.com/openstack/nova/blob/stable/newton/nova/db/sqlalchemy/migrate_repo/versions/330_enforce_mitaka_online_migrations.py | 23:50 |
| mriedem | but ^ assumes the child cell db | 23:51 |
| mriedem | so nova-manage db sync | 23:51 |
| mriedem | not nova-manage api_db sync | 23:51 |
| mgagne | that's a fun one: "until all records have been migrated". Ok, let's run that migration then! oh way, code is gone. what now? /sad panda | 23:51 |
| mriedem | so you should be fine | 23:51 |
| *** suresh12 has joined #openstack-nova | 23:52 | |
| mgagne | but then, you will say there is an upgrade readiness check now you can run | 23:52 |
| mgagne | which I'm fine with. ;) | 23:52 |
| mriedem | nova-status was added in ocata | 23:52 |
| mriedem | and checked for things like making sure placement was deployed and cellsv2 mappings existed | 23:53 |
| mgagne | yea, I had a lot of "fun" when it complained about the online migration and old code was gone. had to find a copy in a different environment and rsync that thing. | 23:53 |
| mriedem | i thought people stood up a separate env to run the db sync on the new code before upgrading the old code that's actually running? | 23:54 |
| mgagne | I guess I'm not in that ideal world yet :P | 23:54 |
| mriedem | you can also run the online data migrations from the old mitaka code before upgrading to newton, and run them after upgrading to newton if yo uwant | 23:55 |
| mgagne | usually I stop all services, upgrade package, run db sync, start service. | 23:55 |
| mgagne | but if I forgot to run online migration and db sync fails, I'm screwed because I already upgraded the packages. but my bad for not checking if all online migration ran properly before the upgrade. | 23:56 |
| mgagne | sure but I wasn't prepared for that maneuver | 23:56 |
| *** suresh12 has quit IRC | 23:57 | |
| mriedem | mgagne: even with that blocker migration script in newton, we didn't delete the cold that allows you to run the online data migrations from mitaka https://github.com/openstack/nova/blob/stable/newton/nova/cmd/manage.py#L787 | 23:58 |
| mriedem | so, we didn't hose you there | 23:58 |
| mriedem | we just said, you can't continue until you do your homework from mitaka | 23:58 |
| mgagne | very much appreciated =) | 23:58 |
| mriedem | pretty sure that's standard operating procedure | 23:59 |
| mriedem | in queens we still have online data migration code from newton | 23:59 |
| mriedem | we only remove it if we're at least n+1 and someone gets around to caring | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!