| mriedem | e.g. https://review.openstack.org/#/c/517158/ | 00:00 |
|---|---|---|
| mriedem | mgagne: btw, that's another reason people can't/shoudn't literally skip through releases for upgrades | 00:01 |
| *** sdague has quit IRC | 00:01 | |
| *** suresh12 has joined #openstack-nova | 00:01 | |
| mgagne | mriedem: I can't afford to not skip versions ;) | 00:02 |
| mriedem | fast forwarding through versions is fine | 00:02 |
| *** yamamoto has joined #openstack-nova | 00:02 | |
| mriedem | but you have to run the data migratoins | 00:02 |
| mriedem | per release | 00:02 |
| mriedem | same issues with dropping config options after n+1 | 00:02 |
| mgagne | yes, but with cells, I'm not sure if I will be able to skip anymore, too many unknown for now | 00:03 |
| *** david-lyle has quit IRC | 00:03 | |
| *** dklyle has joined #openstack-nova | 00:03 | |
| mgagne | mriedem: configs are fine, we have funky stuff in puppet to support multiple versions | 00:03 |
| mriedem | like aliases? | 00:03 |
| *** slaweq has joined #openstack-nova | 00:04 | |
| mgagne | very funky stuff: https://gist.github.com/mgagne/7146424416eda597563c4018ce50cf97 | 00:06 |
| mgagne | copied as-is so you can see our mess | 00:06 |
| mgagne | this class is included in our main nova.pp which does the main configuration | 00:06 |
| *** thorst has joined #openstack-nova | 00:07 | |
| *** david-lyle has joined #openstack-nova | 00:07 | |
| mgagne | so I just make it so puppet-nova for newton works with mitaka. and I do the same with other services/modules | 00:08 |
| *** dklyle has quit IRC | 00:08 | |
| *** hongbin has quit IRC | 00:08 | |
| tssurya_ | mriedem : actually belmiro is currently on newton, moving to ocata (which would be only for a short duration), but main goal is pike. | 00:08 |
| *** slaweq has quit IRC | 00:09 | |
| *** Sukhdev has joined #openstack-nova | 00:09 | |
| tssurya_ | mridem, dansmith : http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2017-10-24.log.html#t2017-10-24T13:12:39 , the conversation you guys had regarding placement, | 00:09 |
| mriedem | tssurya_: thanks, put that into https://etherpad.openstack.org/p/cellsv1-to-v2-migration | 00:10 |
| tssurya_ | mriedem : sure ! | 00:10 |
| *** Sukhdev has quit IRC | 00:10 | |
| *** thorst has quit IRC | 00:11 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 00:14 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add multi-cell negative test for cold migration with target host https://review.openstack.org/524027 | 00:14 |
| *** moshele has quit IRC | 00:14 | |
| *** edmondsw has quit IRC | 00:15 | |
| mgagne | mriedem: ok so if you run Cellsv1, you should run placement per cell otherwise nova-scheduler in cell *could* pickup hosts from a different cell? | 00:16 |
| dansmith | it will | 00:16 |
| dansmith | and will have to filter them out | 00:17 |
| mgagne | "and will have to filter them out" how? | 00:17 |
| mriedem | the scheduler does a db query to the compute_nodes table per cell | 00:17 |
| dansmith | by the ones it has host state for | 00:17 |
| *** Sukhdev has joined #openstack-nova | 00:17 | |
| mriedem | 1. scheduler asks placement for resource providers (compute nodes) for a given request (flavor) | 00:17 |
| mriedem | 2. scheduler queries the cell db for the compute nodes by the list of uuids from placement | 00:18 |
| mriedem | 3. scheduler converts those compute nodes to HostState objects and those go through the enabled filters | 00:18 |
| mgagne | does it mean UUID returned by 2) from placement would be filtered by the ones found in compute nodes in cell db? | 00:18 |
| *** tssurya_ has quit IRC | 00:19 | |
| mriedem | yeah https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L628 | 00:19 |
| mriedem | starts here https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L645 | 00:19 |
| *** ijw has quit IRC | 00:20 | |
| mriedem | although, that's pike+ | 00:20 |
| mriedem | https://github.com/openstack/nova/commit/d1de5385233ce4379b17a7404557c6724dc37cd4 | 00:20 |
| *** threestrands has quit IRC | 00:21 | |
| *** yangyapeng has quit IRC | 00:22 | |
| *** ijw has joined #openstack-nova | 00:22 | |
| mgagne | I'm more concerned about cellsv1, I feel like linked commit is for cellsv2 where scheduling happens in api/top cell? Or am I mistaken? | 00:23 |
| *** salv-orlando has joined #openstack-nova | 00:23 | |
| mriedem | with cells v2 yeah there is just a flat scheduler | 00:23 |
| mriedem | which is multi-cell aware starting in pike | 00:23 |
| *** thorst has joined #openstack-nova | 00:25 | |
| mriedem | my brain is getting fried and i can already hear my wife getting mad because i'm in my office after 6pm, | 00:25 |
| mriedem | but i'm not sure if https://review.openstack.org/#/c/436648/ makes a significant difference in the decision to run per-cell placement or not in ocata | 00:25 |
| mriedem | because the nova-scheduler in each cell in ocata would only query computes from the cell db it's configured for | 00:25 |
| mriedem | so placement might say there are 1000 computes that could satisfy a request, but only 100 of those might be in the cell db that that cell knows about | 00:26 |
| mriedem | which is this https://github.com/openstack/nova/blob/stable/ocata/nova/scheduler/host_manager.py#L579 | 00:26 |
| mriedem | so i think global placement is still ok in ocata (still not sure why belmiro wanted per-cell placement, would have to read the notes again) | 00:26 |
| *** salv-orlando has quit IRC | 00:27 | |
| mgagne | alright, I guess it addresses my concern. would need to test for sure but I get the idea | 00:28 |
| mriedem | i put more notes about this in https://etherpad.openstack.org/p/cellsv1-to-v2-migration | 00:29 |
| mriedem | would need dansmith to confirm my thinking, but i think global placement would be fine | 00:29 |
| *** dklyle has joined #openstack-nova | 00:29 | |
| dansmith | we get the host list from placement in ocata IIRC, so I think its' the same as pike | 00:29 |
| mriedem | given that plus the catalog issue, i think global placement would be the way to go unless i'm missing something | 00:30 |
| *** david-lyle has quit IRC | 00:30 | |
| dansmith | but I am also rather fried for the day | 00:30 |
| mriedem | right, we get the host list from placement in ocata, | 00:30 |
| mriedem | and then get the compute nodes from the uuids placement returned https://etherpad.openstack.org/p/cellsv1-to-v2-migration | 00:30 |
| mriedem | oops | 00:30 |
| mriedem | https://github.com/openstack/nova/blob/stable/ocata/nova/scheduler/host_manager.py#L579 | 00:30 |
| mriedem | which in ocata are just for the cell that the scheduler has access to | 00:30 |
| mriedem | but, that's fine, it's just an IN query | 00:30 |
| mriedem | yo'ud get the subset that the child cell db knows about | 00:30 |
| mriedem | the inefficiency would be on the placement side | 00:31 |
| dansmith | it's still going to return all the nodes in the system from the placement call | 00:31 |
| dansmith | and make a massive SQL query | 00:31 |
| mriedem | that's no different in pike though | 00:31 |
| dansmith | that's what I said | 00:31 |
| mriedem | heh, yeah | 00:31 |
| mriedem | well, shit, let's just add a cell mapping to placement, i'm sure cdent and edleafe and jaypipes would be on board with that | 00:32 |
| * dansmith pulls the pin from the grenade and stares into mriedem's eyes with that "your move" look | 00:32 | |
| mriedem | with a grenade, we're both going to die right? | 00:32 |
| mriedem | in close proximity | 00:32 |
| *** chyka has quit IRC | 00:32 | |
| dansmith | if I let go | 00:33 |
| dansmith | that's the idea | 00:33 |
| mgagne | can those details be added to the etherpad? like you should be running global placement. it will return all UUIDs of all compute nodes but scheduler will filter them out. And there are plans to optimize that. | 00:33 |
| mriedem | mgagne: i added something along those lines in the pros/cons sections for global vs local placement | 00:33 |
| mriedem | might not be coherent at this point | 00:33 |
| mgagne | ok, I didn't fully understand what it meant ^^' | 00:33 |
| mriedem | dansmith: i just like the idea of saying we should do that and watching heads explode | 00:34 |
| mriedem | mgagne: probably need some kind of summary section | 00:35 |
| mgagne | yea | 00:35 |
| mgagne | perfect | 00:35 |
| mgagne | I think we should make it clear which use case is addressed: placement with cellsv1 vs cellsv2 | 00:36 |
| mgagne | I think the summary section is good. does it apply to newton too? | 00:38 |
| mriedem | newton scheduler didn't talk to placement | 00:38 |
| mriedem | i think, have to check | 00:38 |
| mgagne | oooooh | 00:38 |
| mgagne | so... | 00:38 |
| mgagne | placement in newton, compute reports resources but nothing is consuming from placement? | 00:39 |
| * dansmith wonders if he should hand this live grenade to mriedem's wife | 00:39 | |
| mriedem | mgagne: correct | 00:39 |
| mgagne | holy cow | 00:39 |
| mriedem | https://docs.openstack.org/releasenotes/nova/ocata.html | 00:39 |
| mriedem | "The Nova FilterScheduler driver is now able to make scheduling decisions based on the new Placement RESTful API endpoint that becomes mandatory in Ocata. " | 00:39 |
| mriedem | and in ocata, the scheduler only starts asking placement once all compute are upgraded | 00:40 |
| mriedem | knowing they are reporting in to placement | 00:40 |
| mgagne | well, if i'm upgrading to newton, I might not read ocata release notes (yet) =) | 00:40 |
| mriedem | mgagne: it's done that way for rolling upgrades | 00:40 |
| mriedem | that's why we do a min service version check | 00:40 |
| mgagne | awesome news then | 00:40 |
| mriedem | dansmith: yeah she poked her head in here about 2 minutes after i said htat | 00:41 |
| mgagne | finally understood something today :D | 00:41 |
| dansmith | mriedem: mmhmm, I can hear her from oregon | 00:41 |
| mriedem | mgagne: https://github.com/openstack/nova/blob/stable/ocata/nova/scheduler/filter_scheduler.py#L169 | 00:41 |
| *** Sukhdev has quit IRC | 00:41 | |
| mriedem | she sent our daughter in to yell at me | 00:42 |
| mriedem | so ttyl | 00:42 |
| mgagne | I'm off for today too, have a good one. thanks for all the explanations! | 00:42 |
| *** yamamoto has quit IRC | 00:45 | |
| *** Sukhdev has joined #openstack-nova | 00:52 | |
| *** yangyapeng has joined #openstack-nova | 00:55 | |
| *** david-lyle has joined #openstack-nova | 00:55 | |
| *** dklyle has quit IRC | 00:55 | |
| *** yangyapeng has quit IRC | 00:59 | |
| *** ijw has quit IRC | 00:59 | |
| *** jose-phillips has joined #openstack-nova | 01:00 | |
| *** david-lyle has quit IRC | 01:01 | |
| *** jichen has joined #openstack-nova | 01:03 | |
| *** yangyapeng has joined #openstack-nova | 01:04 | |
| openstackgerrit | Jackie Truong proposed openstack/python-novaclient master: Microversion 2.56 - Add trusted_image_certificates https://review.openstack.org/500396 | 01:04 |
| *** thorst has quit IRC | 01:05 | |
| openstackgerrit | Jackie Truong proposed openstack/python-novaclient master: Microversion 2.56 - Add trusted_image_certificates https://review.openstack.org/500396 | 01:08 |
| *** links has joined #openstack-nova | 01:09 | |
| *** liverpooler has joined #openstack-nova | 01:13 | |
| *** smatzek has joined #openstack-nova | 01:19 | |
| *** mriedem has quit IRC | 01:21 | |
| *** nicolasbock has quit IRC | 01:22 | |
| *** mriedem has joined #openstack-nova | 01:23 | |
| *** smatzek has quit IRC | 01:24 | |
| *** salv-orlando has joined #openstack-nova | 01:24 | |
| *** yamamoto has joined #openstack-nova | 01:24 | |
| *** edmondsw has joined #openstack-nova | 01:24 | |
| *** gbarros has joined #openstack-nova | 01:25 | |
| *** armax has quit IRC | 01:26 | |
| *** salv-orlando has quit IRC | 01:29 | |
| *** edmondsw has quit IRC | 01:29 | |
| Kevin_Zheng | mriedem, Hi, what is the -1 for in https://review.openstack.org/#/c/523653/ ? I saw that you are suggesting to make change on manager.py in a follow up patch | 01:30 |
| mriedem | not a follow up patch, | 01:30 |
| mriedem | a preceeding patch | 01:30 |
| mriedem | your patch introduces a bug | 01:30 |
| Kevin_Zheng | Ah, OK, got it. | 01:32 |
| *** priteau has joined #openstack-nova | 01:32 | |
| *** thorst has joined #openstack-nova | 01:34 | |
| *** thorst has quit IRC | 01:34 | |
| *** priteau has quit IRC | 01:37 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Assert that we restrict cold migrations to the same cell https://review.openstack.org/524035 | 01:37 |
| mriedem | takashin: i split this test out into it's own patch https://review.openstack.org/#/c/524027/ | 01:38 |
| mriedem | and added this https://review.openstack.org/#/c/524035/1 | 01:38 |
| *** sree has joined #openstack-nova | 01:40 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 01:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add multi-cell negative test for cold migration with target host https://review.openstack.org/524027 | 01:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Assert that we restrict cold migrations to the same cell https://review.openstack.org/524035 | 01:44 |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 01:45 |
| *** sree has quit IRC | 01:46 | |
| *** Apoorva has quit IRC | 01:51 | |
| *** Apoorva has joined #openstack-nova | 01:52 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 01:56 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add multi-cell negative test for cold migration with target host https://review.openstack.org/524027 | 01:56 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Assert that we restrict cold migrations to the same cell https://review.openstack.org/524035 | 01:56 |
| *** annp has joined #openstack-nova | 01:56 | |
| *** litao__ has joined #openstack-nova | 01:56 | |
| *** Apoorva has quit IRC | 01:57 | |
| *** claudiub|2 has quit IRC | 02:00 | |
| *** coreywright has quit IRC | 02:00 | |
| openstackgerrit | Andreas Karis proposed openstack/nova master: Fixes 'Not enough available memory' log message https://review.openstack.org/524038 | 02:00 |
| Kevin_Zheng | mriedem: for your comment on https://review.openstack.org/#/c/523653/ , we have a instance uuid lock here, if directly call _shelve_offload_instance might be a problem ? https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4637 | 02:01 |
| mriedem | Kevin_Zheng: that was added for a race tempest was hitting https://github.com/openstack/nova/commit/e285eb1a382e6d3ce1cc596eeb5cecb3b165a228 | 02:03 |
| mriedem | Kevin_Zheng: you could do the same instance lock in the periodic task when calling _shelve_offload_instance | 02:03 |
| Kevin_Zheng | Ah, right, I'm so stupid... | 02:04 |
| *** namnh has joined #openstack-nova | 02:11 | |
| *** mriedem has quit IRC | 02:11 | |
| *** Apoorva has joined #openstack-nova | 02:14 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Fix foreign key constraint error https://review.openstack.org/516880 | 02:16 |
| *** dave-mccowan has quit IRC | 02:18 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 02:19 |
| *** coreywright has joined #openstack-nova | 02:19 | |
| *** phuongnh has joined #openstack-nova | 02:21 | |
| *** yamamoto has quit IRC | 02:22 | |
| *** yamamoto has joined #openstack-nova | 02:24 | |
| *** salv-orlando has joined #openstack-nova | 02:24 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: XenAPI: Don't use nicira-iface-id for XenServer VIF https://review.openstack.org/451641 | 02:25 |
| *** tbachman has quit IRC | 02:25 | |
| *** vks1 has joined #openstack-nova | 02:26 | |
| *** salv-orlando has quit IRC | 02:29 | |
| *** hongbin has joined #openstack-nova | 02:32 | |
| *** gbarros has quit IRC | 02:39 | |
| *** yamamoto has quit IRC | 02:40 | |
| *** gcb has joined #openstack-nova | 02:40 | |
| *** vivsoni has quit IRC | 02:41 | |
| *** vivsoni has joined #openstack-nova | 02:41 | |
| *** liverpooler has quit IRC | 02:43 | |
| *** Apoorva_ has joined #openstack-nova | 02:44 | |
| *** dave-mccowan has joined #openstack-nova | 02:45 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Modify _poll_shelved_instances periodic task call _shelve_offload_instance() https://review.openstack.org/524047 | 02:46 |
| *** zhurong has joined #openstack-nova | 02:46 | |
| *** Apoorva has quit IRC | 02:47 | |
| *** yamahata has quit IRC | 02:54 | |
| *** tbachman has joined #openstack-nova | 02:54 | |
| *** yamamoto has joined #openstack-nova | 02:54 | |
| *** threestrands has joined #openstack-nova | 02:55 | |
| *** diga has joined #openstack-nova | 02:55 | |
| *** thorst has joined #openstack-nova | 02:59 | |
| *** Apoorva_ has quit IRC | 03:01 | |
| *** Apoorva has joined #openstack-nova | 03:01 | |
| *** trungnv has quit IRC | 03:03 | |
| *** masber has joined #openstack-nova | 03:03 | |
| *** trungnv has joined #openstack-nova | 03:04 | |
| *** yamamoto has quit IRC | 03:05 | |
| *** Apoorva has quit IRC | 03:06 | |
| *** Sukhdev has quit IRC | 03:07 | |
| *** masuberu has quit IRC | 03:07 | |
| *** tbachman has quit IRC | 03:08 | |
| *** fragatina has quit IRC | 03:09 | |
| *** fragatina has joined #openstack-nova | 03:09 | |
| *** fragatin_ has joined #openstack-nova | 03:12 | |
| *** edmondsw has joined #openstack-nova | 03:13 | |
| *** bkopilov has quit IRC | 03:13 | |
| *** fragatina has quit IRC | 03:14 | |
| *** fragatin_ has quit IRC | 03:16 | |
| *** edmondsw has quit IRC | 03:17 | |
| *** fragatina has joined #openstack-nova | 03:19 | |
| *** vladikr has quit IRC | 03:23 | |
| *** vladikr has joined #openstack-nova | 03:23 | |
| *** fragatina has quit IRC | 03:24 | |
| *** abhishekk has joined #openstack-nova | 03:25 | |
| *** gcb has quit IRC | 03:25 | |
| *** salv-orlando has joined #openstack-nova | 03:25 | |
| *** gcb has joined #openstack-nova | 03:26 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Modify _poll_shelved_instances periodic task call _shelve_offload_instance() https://review.openstack.org/524047 | 03:26 |
| *** gbarros has joined #openstack-nova | 03:28 | |
| *** salv-orlando has quit IRC | 03:30 | |
| *** masber has quit IRC | 03:30 | |
| *** priteau has joined #openstack-nova | 03:33 | |
| *** masber has joined #openstack-nova | 03:34 | |
| *** awaugama has quit IRC | 03:35 | |
| *** priteau has quit IRC | 03:38 | |
| *** amodi has quit IRC | 03:39 | |
| *** thorst has quit IRC | 03:46 | |
| *** zhurong has quit IRC | 03:46 | |
| *** kalyan has quit IRC | 03:52 | |
| *** tetsuro_ has joined #openstack-nova | 03:54 | |
| *** tetsuro_ has quit IRC | 03:55 | |
| *** sridharg has joined #openstack-nova | 03:57 | |
| *** yingjun has joined #openstack-nova | 03:57 | |
| *** tbachman has joined #openstack-nova | 04:00 | |
| *** diga has quit IRC | 04:07 | |
| *** dave-mccowan has quit IRC | 04:07 | |
| *** gcb has quit IRC | 04:09 | |
| *** sree has joined #openstack-nova | 04:11 | |
| *** AlexeyAbashkin has joined #openstack-nova | 04:15 | |
| *** Apoorva has joined #openstack-nova | 04:16 | |
| *** thorst has joined #openstack-nova | 04:16 | |
| *** hongbin has quit IRC | 04:20 | |
| *** AlexeyAbashkin has quit IRC | 04:20 | |
| *** psachin has joined #openstack-nova | 04:20 | |
| *** mdnadeem has joined #openstack-nova | 04:21 | |
| *** udesale has joined #openstack-nova | 04:21 | |
| *** thorst has quit IRC | 04:22 | |
| *** thorst has joined #openstack-nova | 04:25 | |
| *** gbarros has quit IRC | 04:25 | |
| *** yamahata has joined #openstack-nova | 04:25 | |
| *** salv-orlando has joined #openstack-nova | 04:26 | |
| *** thorst has quit IRC | 04:29 | |
| *** bkopilov has joined #openstack-nova | 04:30 | |
| *** salv-orlando has quit IRC | 04:30 | |
| *** priteau has joined #openstack-nova | 04:37 | |
| *** Jeffrey4l has quit IRC | 04:42 | |
| *** priteau has quit IRC | 04:43 | |
| *** thorst has joined #openstack-nova | 04:55 | |
| *** Sukhdev has joined #openstack-nova | 04:57 | |
| *** thorst has quit IRC | 04:57 | |
| *** suresh12 has quit IRC | 04:57 | |
| *** ratailor has joined #openstack-nova | 04:59 | |
| *** xinliang has quit IRC | 05:00 | |
| *** xinliang has joined #openstack-nova | 05:01 | |
| *** Jeffrey4l has joined #openstack-nova | 05:04 | |
| *** suresh12 has joined #openstack-nova | 05:06 | |
| *** suresh12 has quit IRC | 05:07 | |
| *** suresh12 has joined #openstack-nova | 05:07 | |
| *** janki has joined #openstack-nova | 05:21 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 05:23 |
| *** Sukhdev has quit IRC | 05:25 | |
| *** fragatina has joined #openstack-nova | 05:26 | |
| *** fragatina has quit IRC | 05:27 | |
| *** fragatina has joined #openstack-nova | 05:27 | |
| *** salv-orlando has joined #openstack-nova | 05:27 | |
| *** chyka has joined #openstack-nova | 05:27 | |
| *** tetsuro has quit IRC | 05:27 | |
| *** fragatina has quit IRC | 05:28 | |
| *** fragatina has joined #openstack-nova | 05:29 | |
| *** thorst has joined #openstack-nova | 05:31 | |
| *** armax has joined #openstack-nova | 05:31 | |
| *** salv-orlando has quit IRC | 05:32 | |
| *** chyka has quit IRC | 05:32 | |
| *** thorst has quit IRC | 05:35 | |
| *** yamamoto has joined #openstack-nova | 05:39 | |
| *** yamamoto has quit IRC | 05:43 | |
| *** moshele has joined #openstack-nova | 05:43 | |
| *** moshele has quit IRC | 05:45 | |
| *** moshele has joined #openstack-nova | 05:46 | |
| *** mikal has quit IRC | 05:47 | |
| *** yamamoto has joined #openstack-nova | 05:53 | |
| *** suresh12 has quit IRC | 05:54 | |
| *** mikal has joined #openstack-nova | 05:55 | |
| *** yamamoto has quit IRC | 05:57 | |
| *** udesale__ has joined #openstack-nova | 06:01 | |
| *** udesale has quit IRC | 06:04 | |
| *** pcaruana has joined #openstack-nova | 06:05 | |
| *** mikal_ has joined #openstack-nova | 06:06 | |
| *** armax has quit IRC | 06:07 | |
| *** mdnadeem_ has joined #openstack-nova | 06:07 | |
| *** thorst has joined #openstack-nova | 06:07 | |
| *** mdnadeem has quit IRC | 06:09 | |
| *** mikal has quit IRC | 06:10 | |
| *** vks1 has quit IRC | 06:10 | |
| *** armax has joined #openstack-nova | 06:10 | |
| *** diga has joined #openstack-nova | 06:12 | |
| *** tbachman has quit IRC | 06:12 | |
| *** thorst has quit IRC | 06:12 | |
| *** salv-orlando has joined #openstack-nova | 06:12 | |
| *** cfriesen has quit IRC | 06:13 | |
| *** Apoorva has quit IRC | 06:14 | |
| *** pcaruana has quit IRC | 06:16 | |
| *** suresh12 has joined #openstack-nova | 06:16 | |
| *** Alex_Staf has joined #openstack-nova | 06:20 | |
| *** suresh12 has quit IRC | 06:21 | |
| *** vks1 has joined #openstack-nova | 06:25 | |
| *** moshele has quit IRC | 06:31 | |
| *** yamamoto has joined #openstack-nova | 06:31 | |
| *** moshele has joined #openstack-nova | 06:31 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Modify _poll_shelved_instances periodic task call _shelve_offload_instance() https://review.openstack.org/524047 | 06:36 |
| *** armax has quit IRC | 06:40 | |
| *** xinliang has quit IRC | 06:41 | |
| *** damien_r has joined #openstack-nova | 06:42 | |
| *** masuberu has joined #openstack-nova | 06:42 | |
| *** yamamoto has quit IRC | 06:43 | |
| *** mikal_ has quit IRC | 06:45 | |
| *** masber has quit IRC | 06:46 | |
| *** thorst has joined #openstack-nova | 06:46 | |
| *** mikal has joined #openstack-nova | 06:47 | |
| *** armax has joined #openstack-nova | 06:48 | |
| *** andreas_s has joined #openstack-nova | 06:49 | |
| *** edmondsw has joined #openstack-nova | 06:49 | |
| *** threestrands has quit IRC | 06:50 | |
| *** vladikr has quit IRC | 06:50 | |
| *** vladikr has joined #openstack-nova | 06:51 | |
| *** thorst has quit IRC | 06:51 | |
| *** xinliang has joined #openstack-nova | 06:54 | |
| *** edmondsw has quit IRC | 06:54 | |
| *** yamamoto has joined #openstack-nova | 06:59 | |
| *** damien_r has quit IRC | 07:02 | |
| *** lei-zh has joined #openstack-nova | 07:02 | |
| *** Guest72929 has joined #openstack-nova | 07:03 | |
| Guest72929 | >>> youtube.com/watch?v=X8qL6cAI0zQ | 07:03 |
| *** edand has joined #openstack-nova | 07:05 | |
| *** yamamoto has quit IRC | 07:06 | |
| *** sshwarts has joined #openstack-nova | 07:06 | |
| *** Guest72929 has quit IRC | 07:08 | |
| *** lajoskatona has joined #openstack-nova | 07:11 | |
| *** armax has quit IRC | 07:11 | |
| *** andreas_s has quit IRC | 07:12 | |
| *** andreas_s has joined #openstack-nova | 07:13 | |
| *** Alex_Staf has quit IRC | 07:13 | |
| *** andreas_s has quit IRC | 07:14 | |
| *** andreas_s has joined #openstack-nova | 07:14 | |
| *** Oku_OS-away is now known as Oku_OS | 07:18 | |
| *** vivsoni has quit IRC | 07:19 | |
| *** david-lyle has joined #openstack-nova | 07:19 | |
| *** vivsoni has joined #openstack-nova | 07:19 | |
| *** edand_ has joined #openstack-nova | 07:20 | |
| *** rcernin has quit IRC | 07:20 | |
| *** thorst has joined #openstack-nova | 07:20 | |
| *** gouthamr has quit IRC | 07:20 | |
| *** lei-zh has quit IRC | 07:22 | |
| *** lei-zh has joined #openstack-nova | 07:23 | |
| *** edand has quit IRC | 07:23 | |
| *** diga has quit IRC | 07:25 | |
| *** thorst has quit IRC | 07:25 | |
| *** damien_r has joined #openstack-nova | 07:26 | |
| *** damien_r has quit IRC | 07:27 | |
| *** ijw has joined #openstack-nova | 07:28 | |
| *** cheneydc has joined #openstack-nova | 07:33 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Fix an error message in API validation https://review.openstack.org/524088 | 07:34 |
| *** andreas_s has quit IRC | 07:36 | |
| *** andreas_s has joined #openstack-nova | 07:37 | |
| *** mdnadeem_ has quit IRC | 07:37 | |
| *** markvoelker has quit IRC | 07:37 | |
| openstackgerrit | Merged openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 07:38 |
| *** udesale has joined #openstack-nova | 07:38 | |
| *** andreas_s has quit IRC | 07:38 | |
| *** yamahata has quit IRC | 07:38 | |
| *** andreas_s has joined #openstack-nova | 07:39 | |
| *** udesale__ has quit IRC | 07:39 | |
| *** fragatina has quit IRC | 07:41 | |
| *** mdnadeem has joined #openstack-nova | 07:44 | |
| *** cheneydc has quit IRC | 07:48 | |
| *** sahid has joined #openstack-nova | 07:49 | |
| *** yamamoto has joined #openstack-nova | 07:49 | |
| *** yamamoto has quit IRC | 07:51 | |
| *** thorst has joined #openstack-nova | 07:52 | |
| *** ralonsoh has joined #openstack-nova | 07:53 | |
| *** pcaruana has joined #openstack-nova | 07:55 | |
| *** thorst has quit IRC | 07:57 | |
| *** yamamoto has joined #openstack-nova | 07:57 | |
| *** aloga has quit IRC | 08:03 | |
| *** aloga has joined #openstack-nova | 08:03 | |
| *** ijw has quit IRC | 08:04 | |
| *** ijw has joined #openstack-nova | 08:05 | |
| *** slaweq has joined #openstack-nova | 08:06 | |
| *** AlexeyAbashkin has joined #openstack-nova | 08:06 | |
| *** TuanLA has joined #openstack-nova | 08:07 | |
| *** rcernin has joined #openstack-nova | 08:07 | |
| *** ijw has quit IRC | 08:09 | |
| *** hoonetorg has quit IRC | 08:11 | |
| *** edand__ has joined #openstack-nova | 08:12 | |
| *** jaosorior has quit IRC | 08:13 | |
| *** edand_ has quit IRC | 08:16 | |
| *** alexchadin has joined #openstack-nova | 08:17 | |
| *** claudiub has joined #openstack-nova | 08:22 | |
| *** hoonetorg has joined #openstack-nova | 08:25 | |
| *** hoonetorg has quit IRC | 08:26 | |
| *** sree_ has joined #openstack-nova | 08:26 | |
| *** sree_ is now known as Guest88184 | 08:26 | |
| *** hoonetorg has joined #openstack-nova | 08:27 | |
| *** thorst has joined #openstack-nova | 08:27 | |
| *** slaweq has quit IRC | 08:27 | |
| *** sree has quit IRC | 08:28 | |
| *** slaweq has joined #openstack-nova | 08:31 | |
| *** thorst has quit IRC | 08:32 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add functional tests for traits API https://review.openstack.org/524094 | 08:32 |
| *** ragiman has joined #openstack-nova | 08:33 | |
| *** yamamoto has quit IRC | 08:33 | |
| *** jaosorior has joined #openstack-nova | 08:34 | |
| *** ttsiouts has quit IRC | 08:34 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514 | 08:34 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [cellv2] Improve getting BDMs in multiple cells https://review.openstack.org/521400 | 08:35 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix missing marker functions https://review.openstack.org/514579 | 08:35 |
| *** alexchadin has quit IRC | 08:36 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add a warning in 'nova-manage cell_v2 delete_cell' https://review.openstack.org/513771 | 08:36 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Fix format in placement API ref https://review.openstack.org/521483 | 08:36 |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.56 - Enable cold migration with target host https://review.openstack.org/406707 | 08:37 |
| *** damien_r has joined #openstack-nova | 08:37 | |
| *** edmondsw has joined #openstack-nova | 08:38 | |
| *** markvoelker has joined #openstack-nova | 08:38 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | 08:38 |
| *** priteau has joined #openstack-nova | 08:40 | |
| *** yamamoto has joined #openstack-nova | 08:40 | |
| *** gmann is now known as gmann_afk | 08:41 | |
| *** slaweq has quit IRC | 08:41 | |
| *** AlexeyAbashkin has quit IRC | 08:41 | |
| *** edmondsw has quit IRC | 08:42 | |
| *** AlexeyAbashkin has joined #openstack-nova | 08:42 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904 | 08:42 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Implement query param schema for migration index https://review.openstack.org/518644 | 08:42 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Extract SortContext/SortWrapper of instance_list into utils https://review.openstack.org/518871 | 08:42 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273 | 08:42 |
| *** slaweq has joined #openstack-nova | 08:44 | |
| *** jpena|off is now known as jpena | 08:44 | |
| *** yamamoto has quit IRC | 08:44 | |
| *** priteau has quit IRC | 08:45 | |
| *** alexchadin has joined #openstack-nova | 08:49 | |
| *** Alex_Staf has joined #openstack-nova | 09:00 | |
| *** thorst has joined #openstack-nova | 09:00 | |
| *** chyka has joined #openstack-nova | 09:03 | |
| *** yamamoto has joined #openstack-nova | 09:04 | |
| *** thorst has quit IRC | 09:05 | |
| *** ttsiouts has joined #openstack-nova | 09:07 | |
| *** adisky_ has joined #openstack-nova | 09:08 | |
| *** chyka has quit IRC | 09:08 | |
| *** belmoreira has joined #openstack-nova | 09:13 | |
| *** yamamoto has quit IRC | 09:19 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | 09:21 |
| *** namnh has quit IRC | 09:21 | |
| *** sree has joined #openstack-nova | 09:28 | |
| *** andreas_s has quit IRC | 09:29 | |
| *** andreas_s has joined #openstack-nova | 09:29 | |
| *** cdent has joined #openstack-nova | 09:29 | |
| *** Guest88184 has quit IRC | 09:30 | |
| *** udesale has quit IRC | 09:31 | |
| *** udesale has joined #openstack-nova | 09:31 | |
| *** thorst has joined #openstack-nova | 09:32 | |
| *** andreas_s has quit IRC | 09:34 | |
| *** takashin has left #openstack-nova | 09:35 | |
| *** andreas_s has joined #openstack-nova | 09:35 | |
| *** alexchad_ has joined #openstack-nova | 09:36 | |
| openstackgerrit | Chen Hanxiao proposed openstack/nova master: libvirt: throw NotImplementedError if qga is not responsive when setting password https://review.openstack.org/523828 | 09:36 |
| *** thorst has quit IRC | 09:37 | |
| *** yingjun has quit IRC | 09:38 | |
| *** asettle_ has joined #openstack-nova | 09:38 | |
| *** EmilienM_ has joined #openstack-nova | 09:39 | |
| *** _pewp_ has quit IRC | 09:39 | |
| *** asettle has quit IRC | 09:39 | |
| *** alexchadin has quit IRC | 09:39 | |
| *** EmilienM has quit IRC | 09:39 | |
| *** dr_gogeta86 has quit IRC | 09:39 | |
| *** andymccr has quit IRC | 09:39 | |
| *** pcaruana has quit IRC | 09:39 | |
| *** anthonyper has quit IRC | 09:39 | |
| *** stelucz has quit IRC | 09:39 | |
| *** dr_gogeta86_ has joined #openstack-nova | 09:39 | |
| *** anthonyper_ has joined #openstack-nova | 09:39 | |
| *** _pewp_ has joined #openstack-nova | 09:39 | |
| *** stelucz has joined #openstack-nova | 09:39 | |
| *** andreas_s has quit IRC | 09:39 | |
| *** anthonyper_ is now known as anthonyper | 09:40 | |
| *** lucas-afk is now known as lucasagomes | 09:40 | |
| *** pcaruana has joined #openstack-nova | 09:40 | |
| *** EmilienM_ is now known as EmilienM | 09:40 | |
| *** andymccr has joined #openstack-nova | 09:40 | |
| *** jichen has quit IRC | 09:40 | |
| *** EmilienM has quit IRC | 09:41 | |
| *** EmilienM has joined #openstack-nova | 09:41 | |
| *** john51 has quit IRC | 09:41 | |
| *** john51 has joined #openstack-nova | 09:42 | |
| *** purplerbot has quit IRC | 09:42 | |
| *** david-lyle has quit IRC | 09:46 | |
| openstackgerrit | Merged openstack/nova master: XenAPI: resolve VBD unplug failure with VM_MISSING_PV_DRIVERS error https://review.openstack.org/514902 | 09:46 |
| *** lei-zh has quit IRC | 09:48 | |
| ebbex | nova-compute[5505]: 2017-11-30 09:14:28.222 5505 WARNING os_brick.initiator.connectors.iscsi [req-e7903a5a-325e-4a69-9bd7-f6ea60d02c36 a4401f306bfc4d4eaa35fa8a61037268 9fd9ce5c36694a99824c50806496b581 - default default] Could not find the iSCSI Initiator File /etc/iscsi/initiatorname.iscsi: ProcessExecutionError: Unexpect | 09:54 |
| ebbex | ed error while running command. | 09:54 |
| ebbex | Command: cat /etc/iscsi/initiatorname.iscsi | 09:54 |
| ebbex | What is that warning/error, and why is it even running? | 09:55 |
| *** TuanLA has quit IRC | 09:58 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Update Instance action's updated_at when action event updated. https://review.openstack.org/507473 | 10:00 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and changes-since for instance-actions https://review.openstack.org/326326 | 10:00 |
| *** purplerbot has joined #openstack-nova | 10:03 | |
| *** danpawlik_ has joined #openstack-nova | 10:03 | |
| *** belmoreira has quit IRC | 10:03 | |
| *** migi_ has joined #openstack-nova | 10:04 | |
| *** ttsiouts has quit IRC | 10:04 | |
| *** sshwarts_ has joined #openstack-nova | 10:04 | |
| *** stephenfin has left #openstack-nova | 10:04 | |
| *** stephenfin has joined #openstack-nova | 10:04 | |
| *** ttsiouts has joined #openstack-nova | 10:06 | |
| *** belmoreira has joined #openstack-nova | 10:07 | |
| *** anthonyper has quit IRC | 10:08 | |
| *** MasterofJOKers has quit IRC | 10:09 | |
| *** MasterofJOKers has joined #openstack-nova | 10:09 | |
| *** sshwarts has quit IRC | 10:09 | |
| *** danpawlik has quit IRC | 10:09 | |
| *** hieulq has quit IRC | 10:09 | |
| *** Kevin_Zheng has quit IRC | 10:09 | |
| *** fmccrthy has quit IRC | 10:09 | |
| *** fyxim has quit IRC | 10:09 | |
| *** zhenguo has quit IRC | 10:09 | |
| *** dgonzalez has quit IRC | 10:09 | |
| *** khappone has quit IRC | 10:09 | |
| *** dtantsur|afk has quit IRC | 10:09 | |
| *** raorn has quit IRC | 10:09 | |
| *** tommylikehu has quit IRC | 10:09 | |
| *** migi has quit IRC | 10:09 | |
| *** sgordon has quit IRC | 10:09 | |
| *** sree has quit IRC | 10:10 | |
| *** damien_r has quit IRC | 10:11 | |
| *** anthonyper has joined #openstack-nova | 10:11 | |
| stephenfin | bauzas: Could you sanity check this for me? I really don't understand the problem they're trying to solve https://review.openstack.org/#/c/523828/ | 10:11 |
| stephenfin | Just a quick gawk is fine ;) | 10:12 |
| *** damien_r has joined #openstack-nova | 10:12 | |
| *** sree has joined #openstack-nova | 10:12 | |
| *** dtantsur has joined #openstack-nova | 10:15 | |
| *** hieulq has joined #openstack-nova | 10:15 | |
| *** Kevin_Zheng has joined #openstack-nova | 10:15 | |
| *** fyxim has joined #openstack-nova | 10:15 | |
| *** fmccrthy has joined #openstack-nova | 10:15 | |
| *** zhenguo has joined #openstack-nova | 10:15 | |
| *** dgonzalez has joined #openstack-nova | 10:15 | |
| *** khappone has joined #openstack-nova | 10:15 | |
| *** raorn has joined #openstack-nova | 10:15 | |
| *** tommylikehu has joined #openstack-nova | 10:15 | |
| *** sgordon has joined #openstack-nova | 10:15 | |
| *** tommylikehu has quit IRC | 10:15 | |
| *** dtantsur has quit IRC | 10:15 | |
| *** dtantsur has joined #openstack-nova | 10:15 | |
| *** trungnv has quit IRC | 10:15 | |
| *** tommylikehu has joined #openstack-nova | 10:15 | |
| *** udesale has quit IRC | 10:16 | |
| *** sree has quit IRC | 10:16 | |
| *** MasterofJOKers has quit IRC | 10:17 | |
| *** MasterofJOKers has joined #openstack-nova | 10:20 | |
| bauzas | stephenfin: roger, man | 10:21 |
| *** moshele has quit IRC | 10:21 | |
| bauzas | stephenfin: FWIW, "gawk" has a very different meaning for me given I was an operator before :p | 10:21 |
| *** annp has quit IRC | 10:23 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and changes-since for instance-actions https://review.openstack.org/326326 | 10:28 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Object changes to support last-modified headers https://review.openstack.org/521639 | 10:32 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Add cache headers to placement api requests https://review.openstack.org/521640 | 10:32 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Remove unused global variables https://review.openstack.org/524126 | 10:34 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add uuid field to BlockDeviceMapping https://review.openstack.org/524127 | 10:34 |
| *** salv-orlando has quit IRC | 10:36 | |
| *** tetsuro has joined #openstack-nova | 10:37 | |
| stephenfin | bauzas: And, dare I say, what would that other meaning be? :D | 10:38 |
| stephenfin | *dare I ask | 10:38 |
| * gibi guessing that it is the GNU AWK | 10:39 | |
| * stephenfin has managed to mostly avoid awk, sed, perl et al and would like things to stay that way | 10:40 | |
| stephenfin | mostly... | 10:40 |
| *** phuongnh has quit IRC | 10:43 | |
| *** hoangcx has quit IRC | 10:43 | |
| *** phuongnh has joined #openstack-nova | 10:44 | |
| cdent | stephenfin: you haven’t lived if you haven’t written a thousand character one liner using all three of those | 10:44 |
| *** hoangcx has joined #openstack-nova | 10:44 | |
| gibi | we should really organize hackfests where we rewrite parts of nova in perl just for the fun | 10:44 |
| cdent | \o/ | 10:44 |
| *** abhishekk has quit IRC | 10:44 | |
| *** derekh has joined #openstack-nova | 10:45 | |
| stephenfin | gibi: Then we revisit it in six months. The person that can understand what they previously wrote wins a big prize | 10:45 |
| *** thorst has joined #openstack-nova | 10:45 | |
| * stephenfin understands that not many people would win prizes | 10:46 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: update_cell allows more than once cell to have the same db/transport url https://review.openstack.org/518556 | 10:46 |
| gibi | stephenfin: sure, we can even say that who understands after 6 months can be a core automatically... if he still wants :) | 10:47 |
| *** damien_r has left #openstack-nova | 10:47 | |
| *** salv-orlando has joined #openstack-nova | 10:48 | |
| *** masuberu has quit IRC | 10:49 | |
| *** moshele has joined #openstack-nova | 10:49 | |
| *** thorst has quit IRC | 10:50 | |
| *** andreas_s has joined #openstack-nova | 10:52 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | 10:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce framework for RFB authentication https://review.openstack.org/345397 | 10:54 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce the VeNCrypt RFB authentication scheme https://review.openstack.org/345398 | 10:54 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: Provide an RFB security proxy implementation https://review.openstack.org/345399 | 10:54 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Document TLS security setup for noVNC proxy https://review.openstack.org/500544 | 10:54 |
| *** Guest8268 has quit IRC | 10:55 | |
| *** gszasz has joined #openstack-nova | 10:57 | |
| *** jmlowe has quit IRC | 11:01 | |
| *** sdague has joined #openstack-nova | 11:02 | |
| *** cdent has quit IRC | 11:04 | |
| *** efried has quit IRC | 11:10 | |
| *** Dave has quit IRC | 11:12 | |
| *** phuongnh has quit IRC | 11:12 | |
| *** gszasz is now known as gszasz|lunch | 11:14 | |
| *** efried has joined #openstack-nova | 11:14 | |
| *** Dave has joined #openstack-nova | 11:15 | |
| *** salv-orlando has quit IRC | 11:18 | |
| *** bkopilov has quit IRC | 11:22 | |
| *** priteau has joined #openstack-nova | 11:23 | |
| *** thorst has joined #openstack-nova | 11:24 | |
| *** gongysh has joined #openstack-nova | 11:24 | |
| *** takedakn has joined #openstack-nova | 11:25 | |
| *** mvk has quit IRC | 11:25 | |
| *** thorst has quit IRC | 11:28 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 11:32 |
| *** salv-orlando has joined #openstack-nova | 11:32 | |
| *** ratailor has quit IRC | 11:32 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | 11:33 |
| *** cdent has joined #openstack-nova | 11:35 | |
| *** sree has joined #openstack-nova | 11:45 | |
| *** sridharg has quit IRC | 11:47 | |
| *** alexchad_ has quit IRC | 11:47 | |
| *** udesale has joined #openstack-nova | 11:47 | |
| *** alexchadin has joined #openstack-nova | 11:47 | |
| *** sree has quit IRC | 11:50 | |
| *** sridharg has joined #openstack-nova | 11:50 | |
| *** rcernin has quit IRC | 11:52 | |
| *** edand__ has quit IRC | 11:52 | |
| *** gszasz|lunch is now known as gszasz | 11:53 | |
| *** nicolasbock has joined #openstack-nova | 11:55 | |
| *** thorst has joined #openstack-nova | 11:55 | |
| nsingh | efried: just i wanted to know waht is difference between creating httpClient and sessionClient? i tried but didn't find much on this. | 11:56 |
| *** edand__ has joined #openstack-nova | 11:57 | |
| *** jpena is now known as jpena|lunch | 11:59 | |
| nsingh | efried: is there any doc or something that can help. | 12:00 |
| *** thorst has quit IRC | 12:01 | |
| *** alexchadin has quit IRC | 12:01 | |
| *** dave-mccowan has joined #openstack-nova | 12:07 | |
| *** takedakn has quit IRC | 12:07 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273 | 12:08 |
| *** qsyqian has joined #openstack-nova | 12:08 | |
| *** andreas_s has quit IRC | 12:09 | |
| *** qsyqian_ has joined #openstack-nova | 12:09 | |
| *** edand_ has joined #openstack-nova | 12:09 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | 12:09 |
| *** andreas_s has joined #openstack-nova | 12:09 | |
| *** edand__ has quit IRC | 12:10 | |
| *** edand__ has joined #openstack-nova | 12:11 | |
| *** andreas_s has quit IRC | 12:13 | |
| *** edmondsw has joined #openstack-nova | 12:14 | |
| *** mvk has joined #openstack-nova | 12:14 | |
| *** edand_ has quit IRC | 12:14 | |
| *** tetsuro has quit IRC | 12:15 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Fix an error message in API validation https://review.openstack.org/524088 | 12:16 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514 | 12:16 |
| *** alexchadin has joined #openstack-nova | 12:19 | |
| *** eharney has joined #openstack-nova | 12:19 | |
| *** yingjun has joined #openstack-nova | 12:19 | |
| *** andreas_s has joined #openstack-nova | 12:20 | |
| *** edmondsw has quit IRC | 12:20 | |
| qsyqian_ | i meet the error like this: "# nova evacuate sqian | 12:20 |
| qsyqian_ | ERROR (TypeError): evacuate() takes at least 2 arguments (3 given)" . the openstack version is newton. anyone who knows why? | 12:20 |
| openstackgerrit | Merged openstack/nova master: Fix ValueError when loading old pci device record https://review.openstack.org/523914 | 12:21 |
| *** takedakn has joined #openstack-nova | 12:22 | |
| *** takedakn has quit IRC | 12:23 | |
| *** qsyqian has quit IRC | 12:24 | |
| *** andreas_s has quit IRC | 12:25 | |
| *** jchhatbar has joined #openstack-nova | 12:26 | |
| *** jchhatbar has quit IRC | 12:26 | |
| *** janki has quit IRC | 12:26 | |
| *** jchhatbar has joined #openstack-nova | 12:26 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: Fix ValueError when loading old pci device record https://review.openstack.org/524157 | 12:26 |
| lyarwood | stephenfin: ^ | 12:26 |
| *** andreas_s has joined #openstack-nova | 12:26 | |
| *** lucasagomes is now known as lucas-hungry | 12:30 | |
| *** belmoreira has quit IRC | 12:33 | |
| *** chyka has joined #openstack-nova | 12:34 | |
| *** AJaeger has joined #openstack-nova | 12:35 | |
| AJaeger | nova cores, please review https://review.openstack.org/520373 to update relesaenotes to allow infra to improve the job. | 12:36 |
| *** alexchadin has quit IRC | 12:37 | |
| *** yamamoto has joined #openstack-nova | 12:37 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483 | 12:37 |
| *** alexchadin has joined #openstack-nova | 12:38 | |
| *** sree has joined #openstack-nova | 12:38 | |
| *** chyka has quit IRC | 12:38 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.57 - List/Show all server migration types https://review.openstack.org/430839 | 12:39 |
| *** andreas_s has quit IRC | 12:41 | |
| *** vladikr has quit IRC | 12:43 | |
| *** vladikr has joined #openstack-nova | 12:43 | |
| *** inara has quit IRC | 12:44 | |
| *** andreas_s has joined #openstack-nova | 12:46 | |
| *** inara has joined #openstack-nova | 12:46 | |
| *** cdent has quit IRC | 12:46 | |
| efried | nsingh Where are you seeing these terms? | 12:47 |
| *** knsahm has joined #openstack-nova | 12:48 | |
| knsahm | after upgrading newton to ocata i cannot create instance snapshots | 12:49 |
| *** andreas_s has quit IRC | 12:49 | |
| knsahm | is see this error in nova-api.log: | 12:49 |
| knsahm | ERROR nova.api.openstack.extensions Unauthorized: The request you have made requires authentication. (HTTP 401) | 12:49 |
| *** andreas_s has joined #openstack-nova | 12:49 | |
| knsahm | NFO nova.api.openstack.wsgi [req-ec42f6ad-1e3e-4f7b-a3f6-c813ae94b9c9 c756af2957c4447eafc4cef39cdb79e5 469dc3d300df4d41aaea00db572043ae - default default] HTTP exception thrown: Unexpected API Error. Please report this at http://bugs.launchpad.net/nova/ and attach the Nova API log if possible. | 12:50 |
| knsahm | <class 'cinderclient.exceptions.Unauthorized'> | 12:50 |
| nsingh | efried: in pyhton-glanceclient. | 12:50 |
| knsahm | does anybody know this problem? | 12:50 |
| efried | nsingh Ohh, right. I remember seeing this, but I don't remember exactly what the deal was. One of them was old and no longer used for most deployments. | 12:51 |
| nsingh | efried: i think we are using sessionClilent now. | 12:52 |
| *** belmoreira has joined #openstack-nova | 12:53 | |
| *** smatzek has joined #openstack-nova | 12:56 | |
| *** jpena|lunch is now known as jpena | 12:56 | |
| nsingh | knsahm: have you checked you nova-api log? | 12:57 |
| *** bkopilov has joined #openstack-nova | 12:57 | |
| *** qsyqian_ has quit IRC | 12:58 | |
| knsahm | nsingh: yes, i see this error line | 13:00 |
| knsahm | DEBUG cinderclient.v3.client [req-ec42f6ad-1e3e-4f7b-a3f6-c813ae94b9c9 c756af2957c4447eafc4cef39cdb79e5 469dc3d300df4d41aaea00db572043ae - default default] RESP: [401] Date: Thu, 30 Nov 2017 12:44:55 GMT Server: Apache/2.4.18 (Ubuntu) x-openstack-request-id: req-cd8c8f15-37d1-41be-ad3e-ec1cdbe9ab87 WWW-Authenticate: Keystone uri='https://keystone:5000/' Content-Length: 114 Content-Type: application/json | 13:01 |
| knsahm | RESP BODY: {"error": {"message": "The request you have made requires authentication.", "code": 401, "title": "Unauthorized"}} | 13:01 |
| knsahm | _http_log_response /usr/lib/python2.7/dist-packages/keystoneauth1/session.py:395 | 13:01 |
| knsahm | 2017-11-30 12:44:55.281 77 ERROR nova.api.openstack.extensions [req-ec42f6ad-1e3e-4f7b-a3f6-c813ae94b9c9 c756af2957c4447eafc4cef39cdb79e5 469dc3d300df4d41aaea00db572043ae - default default] Unexpected exception in API method | 13:01 |
| knsahm | i can create snapshots by using the openstackcli | 13:02 |
| nsingh | knsahm: i think your token is expired. | 13:02 |
| nsingh | knsahm: Run command "openstack token issue" | 13:03 |
| knsahm | | expires | 2017-12-01T13:03:44+0000 | 13:03 |
| *** yamamoto has quit IRC | 13:04 | |
| *** yamamoto has joined #openstack-nova | 13:05 | |
| *** thorst has joined #openstack-nova | 13:05 | |
| knsahm | i've refreshed my session | 13:06 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add uuid field to BlockDeviceMapping https://review.openstack.org/524127 | 13:07 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: DriverBlockDevice: make subclasses inherit _proxy_as_attr https://review.openstack.org/524167 | 13:07 |
| knsahm | the problem still exists | 13:07 |
| *** READ10 has joined #openstack-nova | 13:13 | |
| *** dtantsur is now known as dtantsur|brb | 13:13 | |
| *** edmondsw has joined #openstack-nova | 13:18 | |
| *** jmlowe has joined #openstack-nova | 13:19 | |
| *** jchhatbar has quit IRC | 13:20 | |
| *** liverpooler has joined #openstack-nova | 13:20 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/pike: Add 'delete_host' command in 'nova-manage cell_v2' https://review.openstack.org/513717 | 13:23 |
| *** markvoelker has quit IRC | 13:23 | |
| *** markvoelker has joined #openstack-nova | 13:24 | |
| *** yassine has joined #openstack-nova | 13:24 | |
| *** yassine is now known as Guest10816 | 13:24 | |
| *** moshele has quit IRC | 13:25 | |
| *** vks1 has quit IRC | 13:26 | |
| *** yangyapeng has quit IRC | 13:26 | |
| *** yangyapeng has joined #openstack-nova | 13:27 | |
| *** Tom-Tom has joined #openstack-nova | 13:29 | |
| *** sambetts|afk is now known as sambetts | 13:29 | |
| *** kashyap has quit IRC | 13:31 | |
| *** pchavva has joined #openstack-nova | 13:31 | |
| *** kashyap has joined #openstack-nova | 13:31 | |
| gibi | the weekly nova meeting will start in less than 30 minutes on #openstack-meeting | 13:33 |
| *** vks1 has joined #openstack-nova | 13:34 | |
| jangutter | gibi: didn't you know? perl is a write-only language. | 13:35 |
| *** yangyapeng has quit IRC | 13:36 | |
| efried | Only for those who don't know Perl | 13:36 |
| gibi | readable only if the author did not know Perl well enough | 13:37 |
| *** artom has joined #openstack-nova | 13:37 | |
| jangutter | I love that both opposing perspectives apply equally well! | 13:38 |
| *** lucas-hungry is now known as lucasagomes | 13:39 | |
| *** lyan has joined #openstack-nova | 13:40 | |
| *** tetsuro has joined #openstack-nova | 13:41 | |
| *** alexchadin has quit IRC | 13:41 | |
| *** alexchadin has joined #openstack-nova | 13:41 | |
| *** moshele has joined #openstack-nova | 13:42 | |
| *** edand_ has joined #openstack-nova | 13:45 | |
| *** alexchadin has quit IRC | 13:47 | |
| *** mriedem has joined #openstack-nova | 13:47 | |
| *** alexchadin has joined #openstack-nova | 13:48 | |
| *** abhishekk has joined #openstack-nova | 13:48 | |
| *** edand__ has quit IRC | 13:48 | |
| *** takashin has joined #openstack-nova | 13:52 | |
| *** sree has quit IRC | 13:52 | |
| *** sree has joined #openstack-nova | 13:53 | |
| mriedem | takashin: i think i might know why this randomly fails https://review.openstack.org/#/c/524027/ | 13:53 |
| *** links has quit IRC | 13:54 | |
| *** janki has joined #openstack-nova | 13:55 | |
| takashin | mriedem: I don't know it. | 13:56 |
| mriedem | i left a comment in there | 13:57 |
| *** sree has quit IRC | 13:57 | |
| takashin | mriedem: I will check it. | 13:58 |
| *** tssurya_ has joined #openstack-nova | 13:59 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Make _Provider really private https://review.openstack.org/523932 | 13:59 |
| openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.uuid_set() https://review.openstack.org/520243 | 13:59 |
| *** gmann_afk is now known as gmann | 14:00 | |
| *** gongysh has quit IRC | 14:02 | |
| *** andreas_s has quit IRC | 14:02 | |
| *** andreas_s has joined #openstack-nova | 14:02 | |
| *** andreas_s has quit IRC | 14:03 | |
| *** andreas_s has joined #openstack-nova | 14:04 | |
| gmann | alex_xu: gibi: stephenfin oomichi_afk can u check this, it is good to go now - https://review.openstack.org/#/c/500347/12 | 14:05 |
| *** cdent has joined #openstack-nova | 14:06 | |
| *** andreas_s has quit IRC | 14:08 | |
| *** gbarros has joined #openstack-nova | 14:14 | |
| *** andreas_s has joined #openstack-nova | 14:15 | |
| *** yyys has quit IRC | 14:16 | |
| *** mdnadeem has quit IRC | 14:16 | |
| *** andreas_s has quit IRC | 14:18 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Assert that we restrict cold migrations to the same cell https://review.openstack.org/524035 | 14:18 |
| mriedem | edleafe: before sydney we glanced at the conductor changes and had mentioned something about how we thought we should do something differently in there, which would require changes to the selection object, but i can't remember the details off hand atm, but that's what i'm referring to, and i haven't been back to the conductor changes in the series yet to see what you have changed | 14:19 |
| *** jaypipes has joined #openstack-nova | 14:19 | |
| gmann | jaypipes: for you - https://review.openstack.org/#/c/500347/12 | 14:20 |
| jaypipes | gmann: ah, that's the one from Kevin Chen, yeah? | 14:20 |
| gmann | yea | 14:20 |
| jaypipes | gmann: you happy with that one now> | 14:20 |
| jaypipes | ? | 14:20 |
| jaypipes | k | 14:21 |
| gmann | yea it looks good, m +1 | 14:21 |
| edleafe | mriedem: the only thing I remember was the two RPC params instead of one | 14:21 |
| *** janki has quit IRC | 14:21 | |
| jaypipes | gmann: +2 | 14:22 |
| *** janki has joined #openstack-nova | 14:22 | |
| gmann | jaypipes: thanks | 14:22 |
| jaypipes | gmann: np :) | 14:22 |
| edleafe | mriedem: nothing about the Selection object | 14:22 |
| *** janki has quit IRC | 14:22 | |
| *** janki has joined #openstack-nova | 14:22 | |
| edleafe | mriedem: and if something *does* come up, it can be addressed in a subsequent patch, no? | 14:23 |
| *** andreas_s has joined #openstack-nova | 14:24 | |
| *** jmlowe has quit IRC | 14:24 | |
| *** alexchadin has quit IRC | 14:24 | |
| mriedem | edleafe: referring to this https://review.openstack.org/#/c/511358/24/nova/conductor/manager.py@587 | 14:26 |
| mriedem | i'm sorry this isn't all wrapped up already, sydney happened and dan and i have been dealing with cve fallout before sydney and after, draining time and energy on much else | 14:28 |
| *** tbachman has joined #openstack-nova | 14:28 | |
| edleafe | mriedem: ah, that was changed the day you mentioned it. | 14:28 |
| edleafe | it no longer relies on the emptiness of the allocation_request field | 14:29 |
| *** esberglu has joined #openstack-nova | 14:33 | |
| efried | jaypipes I'd like to fix https://bugs.launchpad.net/nova/+bug/1735430 pretty quick here, would like to discuss possibilities. | 14:37 |
| openstack | Launchpad bug 1735430 in OpenStack Compute (nova) "Report client doesn't handle RP create conflict (409) properly" [Undecided,New] | 14:37 |
| jaypipes | efried: ok dokey | 14:38 |
| jaypipes | efried: wouldn't it be nice if we had error *codes*? :( | 14:38 |
| *** Tom-Tom has quit IRC | 14:38 | |
| efried | jaypipes Like in the body of the response? | 14:38 |
| jaypipes | efried: ya | 14:39 |
| *** Tom-Tom has joined #openstack-nova | 14:39 | |
| jaypipes | efried: so you could distinguish between bad name and bad UUID... for example | 14:39 |
| efried | jaypipes Is there a reason we don't do that? | 14:39 |
| jaypipes | efried: just never did it. I blame cdent. | 14:39 |
| cdent | jaypipes: hah, I validated the api guideline that says it should happen | 14:39 |
| cdent | I blame jaypipes | 14:39 |
| efried | Okay, if there's no reason we're avoiding it, we could get started on that as a long-term solution. | 14:40 |
| jaypipes | cdent: :) | 14:40 |
| *** gmann is now known as gmann_afk | 14:40 | |
| gibi | gmann: looking... | 14:40 |
| jaypipes | efried: ack, though there are more pressing concerns at this point, no? | 14:40 |
| efried | In the meantime: in PS2 I actually made us raise an exception: https://review.openstack.org/#/c/523932/2 | 14:40 |
| cdent | efried: I think it was mostly just a kind of distraction in the early days and then forgotten | 14:40 |
| cdent | however, it wouldn't make any difference in this bug | 14:40 |
| efried | jaypipes That broke a functional test that runs _init_compute_host twice. cdent was helping me look at that last night. | 14:41 |
| cdent | the 409 is the same in either case: uniqueness is violated and we require uniqueness. the bug isn't so much the response code as the return of None | 14:41 |
| jaypipes | efried: sorry, I didn't mean the bug wasn't pressing. I meant reworking things so we have proper error codes. | 14:41 |
| jaypipes | efried: as opposed to grepping through an error string | 14:41 |
| efried | jaypipes Yeah, I'm with you. | 14:41 |
| efried | jaypipes Hold on, are you saying we could grep the error string? | 14:42 |
| efried | as an interim solution? | 14:42 |
| *** dtantsur|brb is now known as dtantsur | 14:42 | |
| * efried shudders | 14:42 | |
| jaypipes | efried: we've already done that in a couple places, yeah. | 14:42 |
| *** Swami has joined #openstack-nova | 14:42 | |
| cdent | the error string doesn't matter in this bug | 14:42 |
| cdent | or rather the fact that we hide the error response in the expection message made it hard to debug | 14:43 |
| jaypipes | cdent: well, the whole "the error is saying I used a bad UUID, when I actually used a bad name" is problematic. | 14:43 |
| jaypipes | cdent: since they both have the same error message | 14:43 |
| cdent | that's a different bug: | 14:43 |
| jaypipes | cdent: ack | 14:43 |
| *** Tom-Tom has quit IRC | 14:43 | |
| cdent | https://bugs.launchpad.net/nova/+bug/1735405 | 14:43 |
| openstack | Launchpad bug 1735405 in OpenStack Compute (nova) "Error message from placement when creating resource provider uses ambiguous identifier" [Undecided,New] | 14:43 |
| efried | So let's say we do grep the error string - how would report client react that would be appropriate here? | 14:43 |
| jaypipes | ok, agreed, diff bug | 14:43 |
| cdent | the db duplicate response message does include which columns were duplicated | 14:43 |
| cdent | I changed that some months ago | 14:44 |
| cdent | but we hide that in the report client, and shouldn't | 14:44 |
| jaypipes | efried: raise an exception back to the caller. | 14:44 |
| jaypipes | cdent: gotcha | 14:44 |
| * cdent is still confused | 14:44 | |
| cdent | why do we need to grep the error response? | 14:44 |
| cdent | if uniqueness fails, uniqueness fails | 14:44 |
| cdent | you can only get a 409 from post to /resource_providers for uniqueness fails | 14:44 |
| jaypipes | cdent: in order to log an appropriate message, that's all | 14:45 |
| *** yingjun has quit IRC | 14:45 | |
| jaypipes | cdent: it's just misleading to write an error saying bad UUID, when it was the name that was problematic | 14:45 |
| cdent | pass on the response's error message, no need to parse it, just use it | 14:45 |
| *** cfriesen has joined #openstack-nova | 14:45 | |
| jaypipes | cdent: sure, can do that | 14:45 |
| efried | Hold on | 14:46 |
| efried | I don't agree | 14:46 |
| efried | Right now we assume it's UUID conflict, so we GET the provider by UUID and return it (or None) | 14:46 |
| *** amodi has joined #openstack-nova | 14:46 | |
| cdent | the code is incomplete | 14:47 |
| efried | Right | 14:47 |
| cdent | if we want to assume that a 409 _could_ be "another thread created" | 14:47 |
| cdent | then yes, parsing it required | 14:47 |
| cdent | (or adding more detailed error codes, eventually) | 14:47 |
| *** mlavalle has joined #openstack-nova | 14:48 | |
| gibi | gmann_afk: +W | 14:48 |
| cdent | but, then we have 409 meaning potentially 3 things: uuid uniqueness violation (good luck!), name uniqueness violation, concurrent violation | 14:49 |
| cdent | and while telling some of those apart is gravy, the uuid ones, unclear | 14:50 |
| jaypipes | cdent: right. thus the need for more specific error codification. | 14:50 |
| cdent | right, but even with better error codification how do you distinguish conficts 1 and 3? | 14:50 |
| bauzas | oh shit, DST shift impact :( | 14:50 |
| bauzas | mriedem: ^ | 14:50 |
| *** armax has joined #openstack-nova | 14:50 | |
| efried | cdent We have to assume #1 doesn't happen. | 14:50 |
| efried | Or rather, assume the risk | 14:51 |
| * cdent continues to feel like name uniqueness may have been a mistake | 14:51 | |
| * cdent watches the ship on the horizon | 14:51 | |
| efried | Realistically, we don't get to that point if there's a UUID "conflict" - we would have just returned that provider from the first GET in _ensure_resource_provider. | 14:51 |
| mriedem | bauzas: ? | 14:51 |
| cdent | brb | 14:52 |
| mriedem | sdague: i think you will enjoy this https://review.openstack.org/#/c/507693/ | 14:52 |
| efried | cdent jaypipes IMO the first thing we should do is the simplest: raise exceptions instead of returning None in those various paths. | 14:53 |
| efried | Today that 404 will be indicating name conflict 99% of the time. | 14:54 |
| efried | The only excepton would be concurrent create-followed-by-delete. So I'd even go so far as to say 99.99999% | 14:55 |
| cdent | efried: yeah, I agree None is not right | 14:55 |
| jaypipes | efried: go for it. | 14:55 |
| cdent | you'll have to have the fun of figuring out what's up with the api_samples test :( | 14:55 |
| efried | Exactly. jaypipes it looks like this: http://logs.openstack.org/32/523932/2/check/openstack-tox-functional/05f8149/testr_results.html.gz | 14:55 |
| *** awaugama has joined #openstack-nova | 14:56 | |
| *** suresh12 has joined #openstack-nova | 14:56 | |
| efried | It happens because those test cases are starting the fake compute host twice. Each one seems to be getting its own database. But still just one placement service. | 14:56 |
| sdague | mriedem: nice, those test cleanups are especially nice | 14:56 |
| efried | We create ComputeNode with a name and let the DB assign its UUID. Then we push that guy to placement. So the second time around, it has a different UUID. | 14:57 |
| cdent | efried: i don't think "own database" is the right analysis. something else is going on, like the second node (not host), clobbering the first | 14:57 |
| *** abhishekk has quit IRC | 14:57 | |
| efried | cdent Okay. FWIW, I pdb'd it, and the compute host definitely ain't there the second time around. | 14:57 |
| *** lajoskatona has quit IRC | 14:58 | |
| efried | I don't really have context on how these fixtures do their business. Who would be an expert there? | 14:58 |
| *** suresh12_ has joined #openstack-nova | 14:59 | |
| *** suresh12 has quit IRC | 14:59 | |
| cdent | sdague might have some insight into efried's problem? | 14:59 |
| * cdent meets | 14:59 | |
| *** hongbin has joined #openstack-nova | 14:59 | |
| *** yamahata has joined #openstack-nova | 15:00 | |
| *** tetsuro has quit IRC | 15:01 | |
| mriedem | efried: same cell? | 15:01 |
| mriedem | i.e. it's a single-cell test right? | 15:02 |
| takashin | nova-specs cores, would you take a look at a patch to create specs directory for Rocky https://review.openstack.org/#/c/514101/ ? | 15:02 |
| mriedem | could be an issue with not using fake.set_nodes() and fake.restore_nodes | 15:02 |
| efried | mriedem I don't know that answer. | 15:02 |
| efried | mriedem http://logs.openstack.org/32/523932/2/check/openstack-tox-functional/05f8149/testr_results.html.gz | 15:02 |
| *** tetsuro has joined #openstack-nova | 15:05 | |
| openstackgerrit | Jackie Truong proposed openstack/python-novaclient master: Microversion 2.56 - Add trusted_image_certificates https://review.openstack.org/500396 | 15:05 |
| takashin | a patch to create specs directory for Rocky https://review.openstack.org/#/c/514101/ | 15:06 |
| *** takashin has left #openstack-nova | 15:09 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Simplify BDM boot index checking https://review.openstack.org/524208 | 15:09 |
| sdague | what's up? | 15:10 |
| sdague | efried: can you summarize the issue, maybe I can help | 15:10 |
| *** Shanatics has joined #openstack-nova | 15:10 | |
| efried | sdague If report client tries to ensure a RP exists, and gets any error, it returns None (rather than raising an exception) but nobody is checking for that. | 15:11 |
| mriedem | efried: these are a single cell test, using the SingleCellSimple | 15:11 |
| efried | sdague In this test: http://logs.openstack.org/32/523932/2/check/openstack-tox-functional/05f8149/testr_results.html.gz we're hitting that code path | 15:11 |
| mriedem | efried: looking at HypervisorsSampleJson233Tests, it's creating a 2nd service | 15:12 |
| mriedem | but not setting unique nodes | 15:12 |
| efried | sdague As long as we keep the `return None` in there, the test works; but if I raise an exception, the test fails because, as mriedem is saying, it's creating a second service, which creates a second ComputeNode with the same name but different UUID. | 15:12 |
| mriedem | _IntegratedTestBase, the base class, creates a compute service, and the HypervisorsSampleJson test creates a compute service, but i think they have the same node name | 15:12 |
| efried | sdague When we try to create that in placement, we get that 409 because the *name* conflicts. | 15:13 |
| sdague | mriedem: yeh, that's probably something we should prevent on the test side | 15:13 |
| efried | mriedem Yes, they're both called fake-mini. | 15:13 |
| mriedem | so you need to put this in HypervisorsSampleJson when creating the 2nd service: | 15:13 |
| mriedem | fake.set_nodes(['host1']) | 15:13 |
| mriedem | self.addCleanup(fake.restore_nodes) | 15:13 |
| efried | I'm confused as to why it's not `host1` | 15:13 |
| *** udesale has quit IRC | 15:13 | |
| mdbooth | stephenfin: How sure are you of assert(), btw? | 15:13 |
| mriedem | efried: because the fake driver is pullin the node name from CONF.host | 15:13 |
| mriedem | if you don't use fake.set_nodes | 15:13 |
| *** udesale has joined #openstack-nova | 15:14 | |
| stephenfin | mdbooth: Not hugely sure. I just recall being told not to use it at some point in the past | 15:14 |
| efried | But as far as I can see, CONF.host *should* be `host1` and `host2` | 15:14 |
| *** udesale has quit IRC | 15:14 | |
| mdbooth | stephenfin: I think I'm using it correctly in that patch, but there may be practical considerations. e.g. if we disable it in CI. | 15:14 |
| mriedem | efried: ala https://github.com/openstack/nova/blob/master/nova/tests/functional/test_servers.py#L1283 | 15:14 |
| mdbooth | If it's disabled in production, we don't really care. | 15:15 |
| efried | mriedem Okay, thanks, trying... | 15:15 |
| cdent | efried: I can't remember, is the rp ending up named fake-mini or 'host?' ? | 15:15 |
| efried | cdent fake-mini | 15:16 |
| *** yingjun has joined #openstack-nova | 15:16 | |
| *** litao__ has quit IRC | 15:16 | |
| mdbooth | mriedem: Do you happen to remember, btw: all(el + 1 == l[i + 1] for i, el in enumerate(l[:-1])) ? | 15:16 |
| mriedem | melwitt: so i've got this code now http://paste.openstack.org/show/627877/ | 15:16 |
| mdbooth | You chose to add a comment to it for some reason :) | 15:16 |
| mriedem | melwitt: which fails with this http://paste.openstack.org/show/627878/ | 15:16 |
| mriedem | so i'm creating host2 in cell2 but when i try to pull host2 out of cell2, it's not found | 15:16 |
| mriedem | i'm assuming that's because of the CellDatabase fixture defaulting to cell1 | 15:17 |
| mriedem | which is weird since i'm targeting the context specifically to cell2 | 15:17 |
| mriedem | but i can replay this on top of your fixture cleanup patch and see if that fixes it | 15:17 |
| *** marst has joined #openstack-nova | 15:17 | |
| mriedem | mdbooth: ? | 15:18 |
| mriedem | mdbooth: if i added a comment it's because i oculdn't understand ndipanov's code and had to figure it out at one point, and left a comment for posterity | 15:18 |
| *** tidwellr has joined #openstack-nova | 15:18 | |
| mdbooth | mriedem: Not important. I was doing something else and came across it. It made my head hurt :) I submitted this throw-away: https://review.openstack.org/#/c/524208/ | 15:19 |
| *** jmlowe has joined #openstack-nova | 15:19 | |
| mdbooth | I assume this was very X of this patch for some large value of X, and this complexity made sense at some version <X | 15:20 |
| mdbooth | s/very/version/ | 15:20 |
| mdbooth | I was actually trying to work out where we set the boot index of a root disk to 0 if it wasn't done explicitly in the api call | 15:21 |
| mdbooth | still haven't found it | 15:21 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add instance action record for shelve_offload instances https://review.openstack.org/523653 | 15:21 |
| openstackgerrit | Merged openstack/nova stable/pike: Set regex flag on ostestr command for osprofiler tests https://review.openstack.org/510226 | 15:23 |
| mriedem | melwitt: that didn't seem to fix it, still can't find host2 in cell2 | 15:23 |
| *** tidwellr has quit IRC | 15:23 | |
| *** rodolof has joined #openstack-nova | 15:23 | |
| tetsuro | Hi all, I'd like you to review https://review.openstack.org/#/c/465160/ | 15:24 |
| tetsuro | Currently, VM with NUMA goes into a silent error if the virt_type doesn't support it. | 15:26 |
| tetsuro | So, this patch is to raise an error explicitly if NUMA Topology not supported, | 15:26 |
| *** gouthamr has joined #openstack-nova | 15:26 | |
| *** tidwellr has joined #openstack-nova | 15:28 | |
| -openstackstatus- NOTICE: if you receieved a result of "RETRY_LIMIT" after 14:15 UTC, it was likely due to an error since corrected. please "recheck" | 15:38 | |
| *** tetsuro has quit IRC | 15:41 | |
| *** tetsuro has joined #openstack-nova | 15:41 | |
| *** nikhil has joined #openstack-nova | 15:42 | |
| *** tetsuro has quit IRC | 15:42 | |
| *** moshele has quit IRC | 15:46 | |
| *** edand_ has quit IRC | 15:48 | |
| mriedem | 2017-11-30 10:47:07,831 ERROR [nova.tests.functional.test_servers] Failed to find host host2 in cell cell2 | 15:49 |
| mriedem | 2017-11-30 10:47:07,834 ERROR [nova.tests.functional.test_servers] Found host host2 in other cell cell1 | 15:49 |
| *** yamamoto has quit IRC | 15:49 | |
| mriedem | yeah, so for whatever reason, even if i create host2 in cell2, it only ever comes back from cell1 | 15:49 |
| *** janki has quit IRC | 15:49 | |
| dansmith | mriedem: I commented on that migration sorting deal | 15:50 |
| *** yamamoto has joined #openstack-nova | 15:50 | |
| dansmith | I think I deserve a cookie and a nap now | 15:51 |
| *** mdnadeem has joined #openstack-nova | 15:51 | |
| *** slaweq has quit IRC | 15:52 | |
| mriedem | heh, thanks, looking | 15:52 |
| mriedem | i did lose some sleep over this last night | 15:52 |
| mriedem | this and that god forsaken stray cat | 15:52 |
| dansmith | hehe | 15:53 |
| *** tbachman has quit IRC | 15:55 | |
| *** tbachman has joined #openstack-nova | 15:55 | |
| mriedem | dansmith: replied, | 16:00 |
| mriedem | this doesn't deal with the global/local marker issue either, | 16:00 |
| efried | mriedem Thanks for the pointer. After adding in the suggested code and finding & fixing the template files, I got the tests passing. <== cdent jaypipes sdague FYI | 16:00 |
| mriedem | but i'm admittedly a bit lost on the local marker logic and how that all works | 16:00 |
| mriedem | dansmith: i mentioned the cell-encoded marker idea too, but not entirely sure how we can use that to fix the local marker thing | 16:00 |
| *** sshwarts_ has quit IRC | 16:00 | |
| mriedem | if you look at PS21, he had a near exact copy of the instance list stuff with the global/local marker | 16:01 |
| dansmith | mriedem: right, which is what I called out with him using the marker uuid in all the cells | 16:01 |
| ildikov | mriedem: meeting on #openstack-meeting-cp if you have a few minutes | 16:02 |
| mriedem | ildikov: you must have missed my o/ | 16:03 |
| ildikov | mriedem: you must've done it while I was typing here :) | 16:03 |
| dansmith | mriedem: the cell encoding in the marker could help in a few cases: | 16:04 |
| dansmith | mriedem: if we encode the cell, then we can avoid looking in all cells for the marker uuid as the first step | 16:04 |
| mriedem | yup, i at least understand that part so far | 16:04 |
| dansmith | mriedem: if we encoded the cell *and* the value we're sorting on of the marker, then we could find the marker in each cell to restart the sort from without having to first look up the global marker in the cell it came from | 16:05 |
| dansmith | but I think you said none of those are options without retooling the api stuff anyway, | 16:05 |
| dansmith | so probably not worth it | 16:05 |
| mdbooth | mriedem: In response, I could change the change id of my patch if you like? | 16:06 |
| dansmith | I was hoping to not have to use the full instance_list approach if we had a much limited set of sort criteria and stuff, | 16:06 |
| dansmith | but if we're going to implement the full keys/dirs approach at the bottom, then maybe we need to | 16:06 |
| mdbooth | I'd forgotten it, tbh, but my patch is a whole lot more thorough. It deals with the transition to mandatory bdm uuid explicitly. | 16:07 |
| mriedem | mdbooth: ? just cleanup dan's old patches | 16:07 |
| dansmith | I hate to complicate the instance_list stuff by genericifying the bits we can do, especially if this is the only thing we'll ever need to use it for | 16:07 |
| mriedem | mdbooth: adding uuids to things is a pretty standard formula now, we've done it in several other objects and talbes | 16:07 |
| mriedem | *tables | 16:07 |
| mriedem | so i'm not sure what more needs to be done | 16:07 |
| dansmith | mdbooth: you can't add the unique constraint in that migration, AFAIK | 16:07 |
| mdbooth | mriedem: Right, I cribbed off the migration uuid patch. | 16:08 |
| mriedem | bdm.uuid must start as nullable | 16:08 |
| mdbooth | mriedem: However, dansmith 's patch is way older than that | 16:08 |
| mriedem | it can't be that far of | 16:08 |
| mriedem | *off | 16:08 |
| mriedem | because dan wrote the migration one, and the services one was based on the aggregates and compute nodes ones, which dan wrote as well | 16:08 |
| mdbooth | mriedem: Yes, it does. However my patch ensures that uuid is always set on read | 16:08 |
| mdbooth | Seriously, some bits of my patch are very similar to the old patch | 16:08 |
| mdbooth | Some are cribbed off the newer stuff | 16:09 |
| mdbooth | It amounts to the same thing | 16:09 |
| dansmith | mdbooth: I thought you forgot about the old patch? :) | 16:09 |
| *** knsahm has quit IRC | 16:09 | |
| mdbooth | dansmith: I did :) | 16:09 |
| dansmith | anyway, keeping the same review is important for historyand context, IMHO | 16:09 |
| mdbooth | I didn't forget about migration uuid, though | 16:09 |
| mriedem | mdbooth: that was commented in here yes https://review.openstack.org/#/c/242603/23/nova/objects/block_device.py | 16:09 |
| mdbooth | Most of the changes in there are pretty obvious, though | 16:10 |
| mriedem | mdbooth: it's just a matter of cleaning up those old patches a bit | 16:10 |
| mriedem | there are other reviews that have referenced those at this point, so i'd prefer to use those | 16:10 |
| mriedem | plus, original author and all that | 16:10 |
| *** imacdonn has quit IRC | 16:11 | |
| *** gongysh has joined #openstack-nova | 16:11 | |
| *** imacdonn has joined #openstack-nova | 16:11 | |
| *** gongysh has quit IRC | 16:12 | |
| mriedem | dansmith: "but if we're going to implement the full keys/dirs approach at the bottom, then maybe we need to" yeah that's where i'm at | 16:12 |
| mriedem | i.e., | 16:12 |
| mriedem | is it easier to just copy the instance_list stuff, or retool the marker encoding behavior for this api | 16:13 |
| dansmith | well, there's three options I think: | 16:13 |
| mdbooth | dansmith: Anyway, I would fix up the old patch by writing my patch instead. All the obvious bits are identical, and all the extra bits are required but not present in the older patch. | 16:13 |
| dansmith | 1. retool instance_list to be usable by migrations | 16:13 |
| dansmith | 2. Copy and modify | 16:13 |
| dansmith | 3. Implement something limited from that approach that is slimmer and specific to migrations | 16:14 |
| mdbooth | dansmith: Some bits of it are very similar, but we've written way more similar patches before :) | 16:14 |
| mdbooth | I forgot about it. However, the work's now done. | 16:14 |
| openstackgerrit | melanie witt proposed openstack/nova master: Remove old-style quotas code https://review.openstack.org/511689 | 16:14 |
| openstackgerrit | melanie witt proposed openstack/nova master: Follow up on removing old-style quotas code https://review.openstack.org/524234 | 16:14 |
| mdbooth | I can either throw the work away, or... not the work away. | 16:14 |
| dansmith | huh? | 16:15 |
| dansmith | my patch has history back to 2015 on it.. I just think it makes sense to do the uuid field and object change in that review so we keep that context | 16:15 |
| dansmith | not sure why we wouldn't | 16:15 |
| dansmith | I think that's all mriedem is saying, and I agree | 16:15 |
| mdbooth | Ok, but those parts of my patch are so similar to your patch... | 16:16 |
| mdbooth | What do you want me to do? | 16:16 |
| mdbooth | Rebase my patch on your patch and subtract the older work? | 16:16 |
| dansmith | your patch also puts the full online migration change in with the schema change, which just makes it bigger | 16:16 |
| mdbooth | dansmith: There's a reason for that. | 16:17 |
| *** coreywright has quit IRC | 16:17 | |
| mdbooth | Although I could split it. | 16:17 |
| dansmith | what's the reason? | 16:17 |
| mdbooth | I was thinking that you'd want to run the online migration asap after the schema change, because it's more efficient. | 16:17 |
| dansmith | but that doesn't fit the way we do these, | 16:18 |
| dansmith | because you have to be able to apply the schema change before rolling any code | 16:18 |
| mdbooth | I can split it, it's no hassle. | 16:18 |
| dansmith | if you land that schema change before any code to handle it, | 16:18 |
| dansmith | then it kinda self-tests that you haven't broken anything | 16:18 |
| dansmith | we've done a lot of these | 16:18 |
| melwitt | mriedem: that's really weird what you're seeing in that func test. I'm gonna look into it more today. yesterday I didn't find what's going wrong yet | 16:18 |
| melwitt | (what's going wrong with CellDatabases) | 16:18 |
| mdbooth | dansmith: I'm talking about efficiency on a large deployment | 16:18 |
| dansmith | um, me too? | 16:19 |
| mdbooth | You run the schema change, you roll the code, then you want to run the online migration asap | 16:19 |
| mdbooth | But you don't have to, it's just more efficient if you do | 16:19 |
| mdbooth | Anyway, I can split that out | 16:19 |
| dansmith | how does that affect whether the patch is large or small? | 16:19 |
| mdbooth | My change also makes the field non nullable in the object | 16:20 |
| mriedem | umm | 16:20 |
| dansmith | what does that, or the other things have to do with re-using the review for context? | 16:20 |
| mriedem | https://review.openstack.org/#/c/242603/23/nova/objects/block_device.py is already non-nullable | 16:20 |
| mriedem | mdbooth: seriously just invest the time on splitting up your duplicate change and just rebase and address gaps in the older patches | 16:21 |
| mdbooth | mriedem: Ok. It does seem like a bunch of busy work for little gain, though. | 16:21 |
| mdbooth | I just forgot about the old review. | 16:21 |
| mdbooth | I'm going to have to reconcile any minor changes with a bunch of code I've already written and tested. | 16:22 |
| mriedem | how about i take over dan's patches then | 16:22 |
| mriedem | will everyone be happy with that solution? | 16:22 |
| dansmith | mriedem: so I'm going to try to strip out the instanceness of the list routines and see how bad that is in order to make a call on the migration stuff | 16:23 |
| mdbooth | mriedem: No, because I'm working on this actively right now, including a ton of follow-on | 16:23 |
| mdbooth | If anybody's going to do the busy work, it needs to be me | 16:23 |
| mdbooth | It's just a pita | 16:23 |
| *** andreas_s has quit IRC | 16:24 | |
| *** phuongnh has joined #openstack-nova | 16:27 | |
| *** coreywright has joined #openstack-nova | 16:29 | |
| AJaeger | nova cores, please review https://review.openstack.org/520373 to update relesaenotes to allow infra to improve the job | 16:33 |
| * cdent gives AJaeger a cookie for persistence | 16:33 | |
| AJaeger | yummy | 16:34 |
| *** burt has joined #openstack-nova | 16:34 | |
| *** cdent has quit IRC | 16:34 | |
| *** rodolof has quit IRC | 16:35 | |
| *** rodolof has joined #openstack-nova | 16:36 | |
| mriedem | melwitt: i was doing something wrong in my assertion code | 16:37 |
| mriedem | i wasn't using the targeted context to query the compute nodes out of the cell | 16:37 |
| mriedem | seeing if that changes tihngs | 16:37 |
| *** belmoreira has quit IRC | 16:37 | |
| stephenfin | AJaeger: -1 for use of double quotes ;) | 16:38 |
| *** andreas_s has joined #openstack-nova | 16:38 | |
| stephenfin | AJaeger: I kid. +2 | 16:38 |
| AJaeger | stephenfin: ;9 | 16:38 |
| *** cdent has joined #openstack-nova | 16:39 | |
| *** chyka has joined #openstack-nova | 16:39 | |
| mriedem | nope still fails | 16:40 |
| mriedem | host2 shows up in cell1 | 16:40 |
| melwitt | sad town :( | 16:41 |
| mriedem | looking at CellDatabasesTestCase i'm not sure why this doesn't work | 16:41 |
| mriedem | except, | 16:41 |
| mriedem | when the compute node record is created, it's via the start of the service, | 16:42 |
| mriedem | which has an untargeted context, | 16:42 |
| *** thorst has quit IRC | 16:42 | |
| mriedem | so it's going to create the service/computenode in the default context, which is cell1 | 16:42 |
| mriedem | so i guess that's why | 16:42 |
| *** thorst has joined #openstack-nova | 16:42 | |
| *** moshele has joined #openstack-nova | 16:42 | |
| mriedem | to hack around this, i'd have to create the compute node records in the cells before actually starting the services | 16:42 |
| mriedem | or allow temporarily mutating the default context in the CellDatabase fixture | 16:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Nix log translations from scheduler.client.report https://review.openstack.org/524245 | 16:43 |
| melwitt | well, what I did in my patch is wrap the Service class and target the context during start | 16:43 |
| melwitt | if that's not working then I messed up what I tried to do | 16:44 |
| *** thorst has quit IRC | 16:44 | |
| *** moshele has quit IRC | 16:45 | |
| *** yingjun has quit IRC | 16:46 | |
| kashyap | dansmith: When you get a moment, maybe you'd know top off your head -- during 'evacuate', certainly CPU model compatibility is checked before an instance is moved away, yes? | 16:46 |
| * kashyap goes to read code; | 16:46 | |
| mriedem | kashyap: would depend on the scheduler filters | 16:46 |
| dansmith | kashyap: if we run the scheduler then I assume so | 16:46 |
| dansmith | if a host is provided, I don't think so | 16:46 |
| mriedem | unless, of course, you specify a host with the force option | 16:46 |
| mriedem | then we bypass the scheduler altogether | 16:47 |
| * kashyap realizes "evacuate" is just "'rebuild' but with a more reassuring word" | 16:47 | |
| mriedem | it's not the same | 16:47 |
| *** andreas_s has quit IRC | 16:47 | |
| kashyap | mriedem: Yep, scheduler filters is what I was going toc heck | 16:47 |
| mriedem | evacuate is a move | 16:47 |
| mriedem | rebuild is not | 16:47 |
| * kashyap fires up - http://www.danplanet.com/blog/2016/03/03/evacuate-in-nova-one-command-to-confuse-us-all/ | 16:47 | |
| mriedem | you can evacuate with a target host and if you don't specify the force flag, we'll validate that host against the scheduler filters, | 16:47 |
| mriedem | if you specify a host + force, we don't run through the scheduler filters | 16:47 |
| mriedem | because you've decided you want to shoot yourself in the foot | 16:47 |
| mriedem | and we hand you the gun to do that | 16:48 |
| kashyap | dansmith: mriedem: Do you have a pointer to the relevant Scheduler code? libvirt / QEMU has reworked how CPU models are detected, so I'm trying to investigate what action items are there on the Nova side | 16:48 |
| kashyap | mriedem: Heh, noted | 16:48 |
| *** damien_r has joined #openstack-nova | 16:48 | |
| mriedem | if you rebuild (not evacuate) with a new image, well, then it depends on which roll of the cve dice you've landed on | 16:48 |
| mriedem | kashyap: the compute capabilities filter | 16:49 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/scheduler/filters/compute_capabilities_filter.py | 16:49 |
| *** AJaeger has left #openstack-nova | 16:49 | |
| mriedem | i think anyway | 16:49 |
| mriedem | i'm not super well versed in the details of what all the filters do | 16:49 |
| mriedem | bauzas would know | 16:49 |
| * kashyap clicks | 16:50 | |
| kashyap | Wauw, thanks for the super quick response | 16:50 |
| kashyap | dansmith: Yes, good point on the "if you provide a host, then no checks are performed" | 16:50 |
| kashyap | Because, well, if you're providing a target host yourself, then you're expected to keep an eye on CPU comapt | 16:50 |
| kashyap | s/comapt/compat/ | 16:51 |
| *** Apoorva has joined #openstack-nova | 16:51 | |
| *** Alex_Staf has quit IRC | 16:51 | |
| *** Apoorva has quit IRC | 16:53 | |
| *** Apoorva has joined #openstack-nova | 16:55 | |
| kashyap | mriedem: I think the scenario where one would "specify a host + force" is the admin damn sure knows about his target host, and wants to avoid extra checks? | 16:55 |
| *** Apoorva has quit IRC | 16:55 | |
| * kashyap thinks so; can't see any other reason | 16:56 | |
| mriedem | wants to avoid the scheduler kicking out the specified host, yes | 16:56 |
| edleafe | kashyap: yes, that was the idea | 16:56 |
| edleafe | "I'm the admin, dammit!" | 16:56 |
| mriedem | i.e. i know this instance doesn't fit on this host, but i'm going to shove it in there anyway | 16:56 |
| kashyap | edleafe: Thanks, noted. | 16:56 |
| *** fragatina has joined #openstack-nova | 16:56 | |
| kashyap | bauzas: When you're about, I don't see CPU-compat related checks in the 'compute_capabilities_filter.py' -- https://github.com/openstack/nova/blob/master/nova/scheduler/filters/compute_capabilities_filter.py | 16:57 |
| mriedem | kashyap: that's because the filter is generic | 16:57 |
| mriedem | stats = getattr(host_state, 'stats', {}) | 16:58 |
| mriedem | that stats stuff is put on the compute node down in the resource tracker / claim code | 16:58 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L561 | 16:58 |
| * kashyap clicks | 16:58 | |
| *** david-lyle has joined #openstack-nova | 16:59 | |
| mriedem | the cpu stats comes off the driver here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L7380 | 17:00 |
| kashyap | Yeah, that I have open | 17:00 |
| mriedem | although that might be a different thing, | 17:00 |
| *** ragiman has quit IRC | 17:00 | |
| mriedem | for the cpu monitor stuff | 17:00 |
| kashyap | Thanks for the precise pointers | 17:00 |
| kashyap | mriedem: Aside, do you know top off your head, where is the Git repo for this file? -- https://docs.openstack.org/nova/pike/configuration/config.html) | 17:01 |
| *** AlexeyAbashkin has quit IRC | 17:01 | |
| mriedem | nova | 17:01 |
| mriedem | https://docs.openstack.org/nova/pike/configuration/sample-config.html | 17:01 |
| *** fragatina has quit IRC | 17:01 | |
| *** dtantsur is now known as dtantsur|afk | 17:03 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Genericify the instance_list stuff https://review.openstack.org/524253 | 17:04 |
| dansmith | mriedem: see if you don't not hate this ^ | 17:04 |
| kashyap | mriedem: Thanks. (So, it's this - ./doc/source/configuration/sample-config.rst) | 17:04 |
| dansmith | mriedem: seems to work and be fairly straightforward actually | 17:04 |
| dansmith | mriedem: I need to do a lot of cleanup and fixing the docs of course | 17:04 |
| dansmith | but if you like that I will do that post haste and then we can ask the migration dudes to base on that | 17:04 |
| dansmith | mriedem: look at the InstanceLister class for the things you have to implement in order to be cross-cell-listable | 17:05 |
| *** jmlowe has quit IRC | 17:06 | |
| *** pcaruana has quit IRC | 17:08 | |
| mriedem | dansmith: i like it | 17:08 |
| *** yamahata has quit IRC | 17:08 | |
| mriedem | yeah it delegates the db / object calls to the subclass impl | 17:08 |
| mriedem | which is nice | 17:08 |
| dansmith | right | 17:08 |
| mriedem | only suggestion was using an abc at the top | 17:08 |
| dansmith | might even be easier to digest if you're looking at it cold | 17:08 |
| dansmith | I KNEW you were going to say that | 17:08 |
| dansmith | almost put a comment like "Yes matt, I know" | 17:09 |
| mriedem | that would be a fun easter egg | 17:09 |
| mriedem | kashyap: looking at the libvirt driver i don't see that it returns 'stats' from get_available_resources | 17:10 |
| mriedem | so i'm not really sure how that would work with the compute caps filter | 17:10 |
| kashyap | Hmm | 17:10 |
| *** kmalloc has quit IRC | 17:11 | |
| * kashyap guesses mriedem was looking here for the return - https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L7380 | 17:11 | |
| mriedem | might be the cpu_info or supported_instances fields | 17:12 |
| mriedem | those get put on the compute node record, which is the HostState object (wrapper) in the scheduler filter | 17:12 |
| mriedem | no https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L7380 is for the cpu monitor metric stuff i think | 17:12 |
| mriedem | which is a weigher | 17:12 |
| mriedem | i think | 17:12 |
| *** Swami has quit IRC | 17:12 | |
| mriedem | i think you're looking for the cpu_info field on the compute node | 17:12 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L5826 | 17:13 |
| * kashyap clicks | 17:13 | |
| kashyap | Thanks for clarifying; I think that looks like it. | 17:14 |
| kashyap | mriedem: dansmith: Speaking of Easter eggs, try this one -- https://unix.stackexchange.com/questions/405783/why-does-man-print-gimme-gimme-gimme-at-0030 | 17:15 |
| kashyap | :-) | 17:15 |
| kashyap | It actually broke a _real_ use-case | 17:15 |
| kashyap | But the 'man' authors were graceful enough to immediately admit that it wasn't supposed to affect error-scenarios, and fixed it right away. | 17:16 |
| kashyap | (While still retaining the easter egg.) | 17:16 |
| kashyap | (However, no one complained about that bug for _6_ years. So, it's edge case.) | 17:17 |
| * kashyap stops going off-topic | 17:17 | |
| openstackgerrit | Merged openstack/nova master: check query param for server groups function https://review.openstack.org/500347 | 17:18 |
| *** psachin has quit IRC | 17:18 | |
| *** lucasagomes is now known as lucas-afk | 17:21 | |
| *** eharney has quit IRC | 17:24 | |
| *** jlvacation is now known as jlvillal | 17:25 | |
| *** fragatina has joined #openstack-nova | 17:26 | |
| *** damien_r has quit IRC | 17:28 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285 | 17:29 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: libvirt: Allow multiple volume attachments https://review.openstack.org/267587 | 17:29 |
| *** Oku_OS is now known as Oku_OS-away | 17:29 | |
| *** tssurya_ has quit IRC | 17:31 | |
| cfriesen | melwitt: (or anyone else) has bug 1469179 been fixed with placement/resource_providers? | 17:31 |
| openstack | bug 1469179 in OpenStack Compute (nova) "instance.root_gb should be 0 for volume-backed instances" [Medium,In progress] https://launchpad.net/bugs/1469179 - Assigned to melanie witt (melwitt) | 17:31 |
| *** jmlowe has joined #openstack-nova | 17:31 | |
| *** penick has joined #openstack-nova | 17:31 | |
| melwitt | cfriesen: not yet. at the ptg when we discussed placement priorities, other items were more pressing, like alternate hosts and nested resource providers. so shared storage got bumped to rocky | 17:34 |
| *** phuongnh has quit IRC | 17:36 | |
| mriedem | melwitt: i've got a workaround for the compute node create / cell issue | 17:39 |
| mriedem | pushing up shortly | 17:39 |
| mriedem | it's uber hacky, but... | 17:39 |
| mriedem | it's also pretty simple | 17:39 |
| *** suresh12_ has quit IRC | 17:39 | |
| melwitt | okay, thanks. that'll help me determine what's wrong unless it's the periodic task thing from the fixture review | 17:40 |
| openstackgerrit | Andreas Karis proposed openstack/nova master: Fixes 'Not enough available memory' log message https://review.openstack.org/524038 | 17:41 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Proper error handling by _ensure_resource_provider https://review.openstack.org/524263 | 17:42 |
| mriedem | this isn't a periodic task issue | 17:42 |
| efried | cdent jaypipes --^ | 17:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add multi-cell negative test for cold migration with target host https://review.openstack.org/524027 | 17:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Workaround CellDatabase fixture limitation when creating computes https://review.openstack.org/524264 | 17:43 |
| mriedem | melwitt: dansmith: ^ | 17:43 |
| cdent | thanks efried | 17:43 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Genericify the instance_list stuff https://review.openstack.org/524253 | 17:44 |
| dansmith | mriedem: melwitt: ^ | 17:44 |
| cfriesen | melwitt: okay, thanks. For the two patches that are up for review, are there problems with them or are they basically functional? | 17:44 |
| melwitt | cfriesen: some people prefer not to take the cruft that will have to be removed later, when resource providers work is going on and the bug/limitation has always been there | 17:46 |
| efried | jaypipes Want me to address https://review.openstack.org/#/c/377215/ ? | 17:47 |
| melwitt | other than that, the patches are basically functional (though in merge conflict right now) and don't pollute any database records with root_gb=0 | 17:47 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add multi-cell negative test for cold migration with target host https://review.openstack.org/524027 | 17:47 |
| cfriesen | melwitt: I'm just wondering about taking it as a local patch...we previously had fixed it a different way in Newton | 17:47 |
| cfriesen | melwitt: I expect we'll pull them in and try them out. | 17:48 |
| *** mvk has quit IRC | 17:48 | |
| mriedem | dansmith: ack, will hit that after lunch | 17:49 |
| melwitt | mriedem: it pains me how similar that is to what I'm trying to do with my patch. I just don't get what I missed yet | 17:49 |
| *** yangyapeng has joined #openstack-nova | 17:49 | |
| *** derekh has quit IRC | 17:49 | |
| mriedem | ease that pain with pills | 17:50 |
| dansmith | mriedem: I'm thinking I need to follow up with a split of that file into the generic listing infrastructure, and the instance part of that so that the migration dudes can do the same | 17:50 |
| *** Apoorva has joined #openstack-nova | 17:50 | |
| mriedem | yeah, so instance_list is the instance-specific impl, and we'd have migration_list with that specific impl | 17:50 |
| mriedem | and some generic module in between | 17:51 |
| mriedem | not sure what that would be called? multi_cell_list? | 17:51 |
| dansmith | yep something liket hat | 17:51 |
| *** yamahata has joined #openstack-nova | 17:51 | |
| dansmith | sound good? | 17:51 |
| mriedem | yeah | 17:51 |
| *** nikhil has quit IRC | 17:51 | |
| openstackgerrit | Merged openstack/nova master: Remove setting of version/release from releasenotes https://review.openstack.org/520373 | 17:52 |
| jaypipes | efried: I can do that. are there any of your changes you haven't pushed? | 17:52 |
| *** mdnadeem has quit IRC | 17:52 | |
| *** Guest10816 has quit IRC | 17:53 | |
| jaypipes | efried: in particular, I'll rebase through 520246, so make sure I don't overwrite any of your work... | 17:53 |
| efried | jaypipes No, but note that I want to break away the stuff above | 17:53 |
| efried | jaypipes Sorry, redo: No, don't rebase that far up. | 17:53 |
| efried | I'm breaking off the subseries starting at uuid_set() | 17:53 |
| jaypipes | efried: where should I go to. | 17:53 |
| jaypipes | ok. | 17:53 |
| jaypipes | no prob. gimme a few minutes | 17:54 |
| *** yangyapeng has quit IRC | 17:54 | |
| efried | So just rebase from https://review.openstack.org/#/c/385693/ (which needs a rebase onto its predecessor too) | 17:54 |
| efried | jaypipes ^ | 17:54 |
| jaypipes | ya | 17:55 |
| *** gbarros has quit IRC | 17:55 | |
| *** fragatina has quit IRC | 17:57 | |
| *** fragatina has joined #openstack-nova | 18:01 | |
| cdent | efried: left some questions on that bug fix, looks mostly good, but I’m curious about some bits | 18:01 |
| efried | cdent Ack, thanks for the review. Looking... | 18:01 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Split instance_list into instance and multi_cell https://review.openstack.org/524302 | 18:04 |
| *** Apoorva_ has joined #openstack-nova | 18:04 | |
| *** Apoorva has quit IRC | 18:07 | |
| *** moshele has joined #openstack-nova | 18:07 | |
| mgagne | mriedem: so I reread the placement documentation and it's kind of clear already what you need to do. There are some details which need to be updated such as mention of cellsv1. I will pass through the doc again and see if it's clearer for me now. | 18:07 |
| *** thorst has joined #openstack-nova | 18:08 | |
| *** Apoorva_ has quit IRC | 18:09 | |
| *** Apoorva has joined #openstack-nova | 18:09 | |
| *** vks1 has quit IRC | 18:10 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215 | 18:10 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | 18:10 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 18:10 |
| jaypipes | efried: done | 18:10 |
| efried | jaypipes Cool mon. | 18:11 |
| openstackgerrit | melanie witt proposed openstack/nova master: Improve the CellDatabases test fixture and usage https://review.openstack.org/508432 | 18:13 |
| openstackgerrit | melanie witt proposed openstack/nova master: WIP Store a RequestContext on service to reuse for periodic tasks https://review.openstack.org/524306 | 18:13 |
| melwitt | mriedem: the test in https://review.openstack.org/#/c/524027 passes with the above ^ | 18:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Proper error handling by _ensure_resource_provider https://review.openstack.org/524263 | 18:16 |
| efried | cdent Not sure if I addressed your concerns here ^ | 18:16 |
| * cdent looks | 18:17 | |
| efried | cdent I wouldn't think it necessary to say, "Exceptions raised from here may be caught, logged, or ignored by callers as appropriate" | 18:17 |
| *** ralonsoh has quit IRC | 18:18 | |
| efried | cdent Really just brings things more in line with other methods in SRC, like _update_inventory_attempt which may raise InventoryInUse | 18:19 |
| melwitt | mriedem: *reading the commit message* so your test doesn't always fail though? trying to confirm if the test passing means the issue in my patch was addressed by the latest changes I tried | 18:19 |
| *** gbarros has joined #openstack-nova | 18:19 | |
| cdent | efried: that wasn’t quite what I meant. You’re obliged, as someone who has introduced a new situation, where exceptions are now raising that weren’t before, to make sure they don’t break other stuff. That can be as simple as identifying the loop where all Exceptions are handled in the scheduler or the resource trackers servers. | 18:20 |
| efried | cdent OIC. Not enough to pass the CI? | 18:20 |
| cdent | We’ve established over and over that CI isn’t covering lots of stuff, especially in the resource tracker | 18:21 |
| cdent | It’s very likely, however, that this _is_ covered, by the kinds of loops that I mention above, but if you don’t say that in your commit message, then reviewers have doubt and we want to minimize that doubt | 18:21 |
| efried | cdent I was being mostly ironical. I'll dig into it. Thanks. | 18:22 |
| *** Shanatics has quit IRC | 18:22 | |
| * cdent proves again that he has no sense of humor | 18:22 | |
| efried | cdent AFAICT, it all percolates up to this catch-all, which... ignores it https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L7105 | 18:26 |
| cdent | i assumed it would be something like that, and logging and ignoring is what I would expect: it’s a long running process that’s not allowed to die | 18:27 |
| cdent | but if for some reason that was some subclass of Exception, then there would be a chance your new exception would fall through and boom | 18:28 |
| *** jpena is now known as jpena|off | 18:29 | |
| *** moshele has quit IRC | 18:29 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Proper error handling by _ensure_resource_provider https://review.openstack.org/524263 | 18:30 |
| efried | cdent Added more words ^ | 18:30 |
| * cdent loves words | 18:31 | |
| * edleafe will buy cdent a dictionary for his birthday | 18:31 | |
| *** eharney has joined #openstack-nova | 18:34 | |
| *** erlon has joined #openstack-nova | 18:38 | |
| mriedem | melwitt: it was failing | 18:39 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove workaround for bug #1709118 https://review.openstack.org/524316 | 18:45 |
| openstack | bug 1709118 in OpenStack Compute (nova) "_ContextAuthPlugin needs a refresh" [Low,Confirmed] https://launchpad.net/bugs/1709118 | 18:45 |
| *** openstackgerrit has quit IRC | 18:48 | |
| *** pcaruana has joined #openstack-nova | 18:50 | |
| *** slaweq has joined #openstack-nova | 18:51 | |
| *** sshwarts has joined #openstack-nova | 18:51 | |
| *** suresh12 has joined #openstack-nova | 18:51 | |
| *** slaweq has quit IRC | 18:53 | |
| *** slaweq has joined #openstack-nova | 18:54 | |
| mriedem | dansmith: comments in https://review.openstack.org/#/c/524253/2 | 18:54 |
| mriedem | just nits, tests are passing, looks good otherwise | 18:54 |
| *** suresh12 has quit IRC | 18:56 | |
| melwitt | mriedem: hm, so that points to it being related to the periodic task bug dansmith found in my patch. but the initial write of the compute node record doesn't happen via periodic task, it happens through the pre_start_hook() call in Service. so I'm not sure why fixing the periodic task helps | 18:57 |
| dansmith | mriedem: see my reply real quick | 18:58 |
| *** suresh12_ has joined #openstack-nova | 18:58 | |
| *** slaweq has quit IRC | 18:58 | |
| dansmith | melwitt: a periodic would create another record in cell0 if it runs | 18:58 |
| dansmith | that was my point | 18:59 |
| *** mvk has joined #openstack-nova | 18:59 | |
| melwitt | dansmith: right ... trying to think how that could mess up mriedem's test though, where it got ComputeHostNotFound | 18:59 |
| melwitt | like wouldn't it find the original record that was written via pre_start_hook() | 18:59 |
| dansmith | melwitt: ack, okay, I haven't looked at his thing so I dunno | 19:00 |
| dansmith | just commenting from the sidelines | 19:00 |
| melwitt | ack :) | 19:00 |
| mriedem | dansmith: done | 19:01 |
| melwitt | fixing the periodic task thing (by storing it on Service) made the test pass but why O.o | 19:02 |
| dansmith | mriedem: cool, see the split above it? | 19:02 |
| *** moshele has joined #openstack-nova | 19:03 | |
| mriedem | yeah, just haven't reviewed it yet | 19:03 |
| *** derekh has joined #openstack-nova | 19:04 | |
| *** tidwellr has quit IRC | 19:05 | |
| dansmith | gahd dammit | 19:05 |
| dansmith | making changes to a file underneath a rename is annoying :) | 19:05 |
| *** tidwellr has joined #openstack-nova | 19:05 | |
| mriedem | cdent: easy cleanup if you want to respin this https://review.openstack.org/#/c/484667/ | 19:08 |
| mriedem | then i'd fast approve | 19:08 |
| cdent | cool, thanks, will get it in a couple minutes, rado’s usually gone by now | 19:08 |
| *** openstackgerrit has joined #openstack-nova | 19:09 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Genericify the instance_list stuff https://review.openstack.org/524253 | 19:09 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Split instance_list into instance and multi_cell https://review.openstack.org/524302 | 19:09 |
| openstackgerrit | Merged openstack/nova-specs master: Create specs directory for Rocky https://review.openstack.org/514101 | 19:10 |
| cfriesen | melwitt: do you know if anyone has considered adding a "list all tenants with modified quotas" and "list all users in a tenant with modified quotas" APIs? As it is there's no way to get that information without polling *all* the users/tenants. | 19:10 |
| melwitt | cfriesen: I'm not aware of anyone bringing that up before, no | 19:11 |
| cfriesen | melwitt: I'm looking at kingbird (which replicates quotas in a multi-cloud environment) and they literally have to poll everything. | 19:12 |
| cfriesen | also, it looks like the quota usage (and the "limits" API) doesn't report keypair usage, so they have to manually count them per user. | 19:12 |
| melwitt | I see. ironically when I implemented counting quotas I had to set in_use = 0 for keypairs to keep the same behavior. I was thinking we might have to microversion to change that or otherwise signal it | 19:14 |
| *** READ10 has quit IRC | 19:15 | |
| melwitt | so yeah, there are probably many improvements that could happen with the APIs. one thing to consider is that the keystone team is looking to add quota limits to keystone. which would make things separated where you'd have to query keystone for limits and nova for usage | 19:17 |
| *** felipemonteiro has joined #openstack-nova | 19:17 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Use oslo_db Session in resource_provider.py https://review.openstack.org/523192 | 19:22 |
| *** damien_r has joined #openstack-nova | 19:23 | |
| *** vivsoni has quit IRC | 19:23 | |
| jaypipes | efried: are you currently working on https://review.openstack.org/#/c/517119/? | 19:23 |
| *** vivsoni has joined #openstack-nova | 19:23 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: VMware: Handle concurrent registrations of the VC extension https://review.openstack.org/484667 | 19:24 |
| cdent | mriedem: ^ thanks | 19:25 |
| cfriesen | melwitt: do you know what the timeline is on the keystone quotas? If it's going to be a while I might have to propose an API change. | 19:27 |
| mriedem | cdent: thanks - i was coding that in the comment out of memory, does it actualy pass the test? | 19:27 |
| cdent | yes | 19:27 |
| mriedem | cool | 19:27 |
| efried | jaypipes No | 19:27 |
| cdent | and I went to look at the excutils code just to make sure it made sense (because it was new to me) and your example matched the docstring’s example | 19:28 |
| jaypipes | efried: k, I'm going to pull and work on that then | 19:28 |
| melwitt | cfriesen: you'll want to ask lbragstad about it as he's in the know about keystone timelines | 19:28 |
| efried | jaypipes Cool beans. | 19:28 |
| cdent | efried, jaypipes : is there a new stable review-entry point for n-r-p? | 19:28 |
| jaypipes | cdent: unfortunately not. | 19:29 |
| efried | cdent I thought it was here: https://review.openstack.org/#/c/377215/ | 19:29 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215 | 19:29 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | 19:29 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 19:29 |
| efried | cdent The bottom three patches | 19:29 |
| lbragstad | cfriesen: we're in the process of firming up the specification for unified limits https://review.openstack.org/#/c/455709/ (wxy_ is actively responding to comments and making updates) | 19:29 |
| efried | Oh, just updated | 19:29 |
| jaypipes | cdent: I just addressed that microversion.py rebase flub, nothing more. | 19:30 |
| cdent | roger | 19:30 |
| *** adisky_ has quit IRC | 19:30 | |
| lbragstad | cfriesen: wxy_ also has an early implementation proposed for review | 19:30 |
| lbragstad | cfriesen: https://review.openstack.org/#/q/status:open+project:openstack/keystone+branch:master+topic:bp/unified-limits | 19:30 |
| cdent | I think my best plan is perhaps to be done with openstack for today | 19:31 |
| cdent | have fun everyone | 19:31 |
| *** cdent has quit IRC | 19:31 | |
| lbragstad | cfriesen: specification freeze for keystone is next week - so we're trying to get the details ironed out this week and next (all feedback welcome!) | 19:32 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: handle traits with sharing providers https://review.openstack.org/517119 | 19:33 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Test alloc_cands with non overlapping sharing RPs https://review.openstack.org/519380 | 19:33 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Test alloc_cands with one RP shared between two RPs https://review.openstack.org/519617 | 19:33 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Test allocation candidates: multiple aggregates https://review.openstack.org/518633 | 19:33 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Test helper: validate provider summaries https://review.openstack.org/518982 | 19:33 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Fix accumulated nits in refactor series https://review.openstack.org/521189 | 19:33 |
| jaypipes | efried: rebased and fixed conflicts up to ^ | 19:33 |
| jaypipes | efried: I stopped there because I don't know which of alex and tetsuro's add func tests patches are duplicated and which are real. | 19:34 |
| efried | jaypipes ack | 19:35 |
| *** moshele has quit IRC | 19:35 | |
| *** penick has quit IRC | 19:36 | |
| *** sridharg has quit IRC | 19:36 | |
| *** penick has joined #openstack-nova | 19:39 | |
| *** sahid has quit IRC | 19:44 | |
| *** yangyapeng has joined #openstack-nova | 19:45 | |
| *** yangyapeng has quit IRC | 19:50 | |
| *** AlexeyAbashkin has joined #openstack-nova | 19:52 | |
| melwitt | mriedem: turns out your test just always passes locally for me (on top of my celldatabases patch) even without the periodic task fix. so something must be afoot if you're getting a different result locally than me | 19:56 |
| mriedem | melwitt: at some point i rebased out your change since it wasn't fixing stuff, that's when i started writing that workaround in start_service | 19:58 |
| melwitt | oh, okay | 19:59 |
| *** AlexeyAbashkin has quit IRC | 19:59 | |
| *** smatzek has quit IRC | 20:00 | |
| *** smatzek has joined #openstack-nova | 20:00 | |
| *** smatzek has quit IRC | 20:01 | |
| melwitt | if you still had my change when you fixed the wrong assert you mentioned earlier and it didn't pass, then that's really unexpected | 20:01 |
| *** tidwellr has quit IRC | 20:03 | |
| *** tidwellr has joined #openstack-nova | 20:04 | |
| mriedem | unrelated, but if you use gerrit-dash-creator for your nova review dashboard, it's been fixed for zuul https://github.com/openstack/gerrit-dash-creator/blob/master/dashboards/nova.dash | 20:04 |
| mriedem | i was wondering why my dashboard was showing me changes with a -2 as ready for final +2 | 20:04 |
| openstackgerrit | Jackie Truong proposed openstack/python-novaclient master: Microversion 2.57 - Add trusted_image_certificates https://review.openstack.org/500396 | 20:05 |
| melwitt | but I need to re-create my dashboard right? my old dashboard doesn't work anymore | 20:05 |
| mriedem | correct | 20:05 |
| mriedem | you have to git clone gerrit-dash-creator | 20:06 |
| mriedem | and then: tox -e venv -- gerrit-dash-creator dashboards/nova.dash | 20:06 |
| melwitt | okay, thanks | 20:06 |
| mriedem | i put the url in a shortener and then put that in my gerrit settings | 20:06 |
| *** kmalloc has joined #openstack-nova | 20:07 | |
| mriedem | efried: seen this https://review.openstack.org/#/c/521764/ ? | 20:07 |
| melwitt | sweet. good tips | 20:07 |
| *** liverpooler has quit IRC | 20:07 | |
| *** Guest10816 has joined #openstack-nova | 20:09 | |
| *** AlexeyAbashkin has joined #openstack-nova | 20:12 | |
| *** AlexeyAbashkin has quit IRC | 20:17 | |
| openstackgerrit | Mike Lowe proposed openstack/nova master: live-mig: keep disk device address same https://review.openstack.org/518022 | 20:18 |
| *** damien_r has left #openstack-nova | 20:22 | |
| *** penick has quit IRC | 20:24 | |
| *** sree has joined #openstack-nova | 20:25 | |
| mriedem | dansmith: melwitt: cellsv2 thingamajig https://review.openstack.org/#/c/521837/5 | 20:28 |
| mriedem | ux stuff | 20:28 |
| *** sree has quit IRC | 20:29 | |
| *** slaweq has joined #openstack-nova | 20:32 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update description of Rebuild in server_concepts.rst https://review.openstack.org/522086 | 20:32 |
| *** Apoorva_ has joined #openstack-nova | 20:32 | |
| *** gszasz has quit IRC | 20:32 | |
| *** slaweq has quit IRC | 20:34 | |
| *** slaweq has joined #openstack-nova | 20:34 | |
| *** penick has joined #openstack-nova | 20:35 | |
| *** Apoorva has quit IRC | 20:36 | |
| *** tidwellr has quit IRC | 20:38 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: [placement]Enhance doc for placement allocation list https://review.openstack.org/511715 | 20:41 |
| *** lyan has quit IRC | 20:42 | |
| *** awaugama has quit IRC | 20:46 | |
| *** penick has quit IRC | 20:47 | |
| *** lyan has joined #openstack-nova | 20:47 | |
| *** penick has joined #openstack-nova | 20:47 | |
| openstackgerrit | Merged openstack/os-traits master: Updated from global requirements https://review.openstack.org/520477 | 20:49 |
| *** penick has quit IRC | 20:50 | |
| efried | mriedem Nope, hadn't seen it. Thanks for the pointer. | 20:50 |
| *** derekh has quit IRC | 20:52 | |
| melwitt | mriedem: yeah, seems like it would be uncool of us to remove 'nova-manage host list' before we have another way to list hosts in a cell, even though it's deprecated | 20:52 |
| *** rwellum has joined #openstack-nova | 20:53 | |
| melwitt | I was thinking discover_hosts had a --dry-run mode that just shows the hosts. but looks like not | 20:54 |
| efried | jaypipes Care to eyeball https://review.openstack.org/#/c/524263/ ? Looks like we may want to backport it (mriedem?) | 20:54 |
| mriedem | discover_hosts is idempotent so that's the fallback | 20:54 |
| melwitt | although I guess a dry run would only show unmapped hosts | 20:54 |
| melwitt | or does it show all? | 20:55 |
| mriedem | efried: yes i think we probably want to backport that | 20:55 |
| *** pcaruana has quit IRC | 20:55 | |
| *** penick has joined #openstack-nova | 20:55 | |
| mriedem | i marked the bug as affecting stable | 20:55 |
| efried | mriedem Should we tag the bug with placement, or is that only for stuff on the server side of placement? | 20:55 |
| melwitt | I wouldn't be surprised if ppl would like to be able to see what it's going to map before it maps it | 20:55 |
| mriedem | efried: not sure if that matters | 20:55 |
| efried | ight | 20:55 |
| rwellum | Hi folks. I'm seeing an issue with Pike nova, I assume it's my setup - but wondering if I could get a few pointers what to debug? This is running on kolla containers I should add. https://www.irccloud.com/pastebin/WH8k1XV3/ - looks like a database sync issue? | 21:02 |
| mriedem | rwellum: yes, | 21:02 |
| mriedem | it's looking in the cell0 database for the compute_nodes table, | 21:03 |
| mriedem | so you must not have run 'nova-manage db sync' yet | 21:03 |
| mriedem | after creating the nova_cell0 database | 21:03 |
| *** Apoorva_ has quit IRC | 21:03 | |
| *** Apoorva has joined #openstack-nova | 21:04 | |
| rwellum | And that should be run on presumably one of the nova containers | 21:06 |
| mriedem | shrug, i've never used kolla | 21:08 |
| mriedem | i think they are in #openstack-kolla | 21:08 |
| rwellum | Yeah I'm there :) Just not sure who should execute the sync. | 21:09 |
| rwellum | But thanks this is really helpful | 21:09 |
| openstackgerrit | Merged openstack/os-vif master: Updated from global requirements https://review.openstack.org/520478 | 21:09 |
| *** threestrands has joined #openstack-nova | 21:12 | |
| *** threestrands has quit IRC | 21:12 | |
| *** threestrands has joined #openstack-nova | 21:12 | |
| *** gbarros has quit IRC | 21:14 | |
| jaypipes | efried: I'm kind of annoyed right now... I can't figure out for the life of me why https://review.openstack.org/#/c/384807/77//COMMIT_MSG changed back from 1.14 to 1.13... | 21:16 |
| *** gbarros has joined #openstack-nova | 21:16 | |
| *** gbarros has quit IRC | 21:17 | |
| efried | jaypipes Probably you had PS74 locally. edleafe published PS75 with that being the only change. | 21:18 |
| jaypipes | efried: but I pulled a fresh branch before I did anything. | 21:18 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | 21:18 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 21:18 |
| jaypipes | efried: whatevs, I've fixed it.. | 21:18 |
| efried | jaypipes ack | 21:18 |
| efried | jaypipes +1. Ship it! | 21:19 |
| rwellum | mriedem: that indeed fixed the database sync error! However I still am getting 'No valid host was found. There are not enough hosts available' | 21:19 |
| mriedem | rwellum: have you created cell1 and discovered hosts? | 21:19 |
| mriedem | rwellum: i thought kolla automated all of this? | 21:20 |
| dansmith | I thought kolla was just containers of stuff | 21:20 |
| mriedem | i thought there was an ansible part to kolla for actually deploying openstack in those containers | 21:23 |
| rwellum | Yeah kolla is just the images and some config built into the image. I'm orchestrating with kolla-kubernetes. Works with ocata btw. | 21:23 |
| mriedem | clearly this isn't the place to ask about wtf kolla is or does :) | 21:23 |
| mriedem | i remember the kolla guys asking about the cellsv2 discover_hosts stuff in pike | 21:24 |
| rwellum | Yeah my bad. More wanted to know where to start with with a generic error like the above. | 21:24 |
| mriedem | so that is automated somewhere in the kolla stadium | 21:24 |
| *** pcaruana has joined #openstack-nova | 21:24 | |
| rwellum | I'll try to find who did it. There's only a few of them. | 21:24 |
| mriedem | http://git.openstack.org/cgit/openstack/kolla-ansible/ ? | 21:25 |
| mriedem | http://git.openstack.org/cgit/openstack/kolla-ansible/tree/ansible/roles/nova/tasks/simple_cell_setup.yml ? | 21:25 |
| mriedem | https://review.openstack.org/#/c/456920/ is the change i remember | 21:26 |
| mriedem | i think | 21:26 |
| openstackgerrit | melanie witt proposed openstack/nova master: Improve the CellDatabases test fixture and usage https://review.openstack.org/508432 | 21:26 |
| mriedem | eduardo is definitely the person to ask | 21:26 |
| mriedem | rwellum: ^ | 21:26 |
| rwellum | ty mriedem | 21:27 |
| *** Apoorva_ has joined #openstack-nova | 21:29 | |
| *** Apoorva has quit IRC | 21:32 | |
| rwellum | mriedem: our code (not ansible - kubernetes) is calling: "nova-manage cell_v2 simple_cell_setup" | 21:33 |
| mriedem | rwellum: probably want to read through this then https://docs.openstack.org/nova/latest/user/cells.html#step-by-step-for-common-use-cases | 21:35 |
| *** dave-mccowan has quit IRC | 21:35 | |
| *** sree has joined #openstack-nova | 21:35 | |
| *** lyan has quit IRC | 21:36 | |
| rwellum | perfect thanks. | 21:37 |
| *** pcaruana has quit IRC | 21:39 | |
| *** sree has quit IRC | 21:40 | |
| *** esberglu has quit IRC | 21:43 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle spawning error on unshelving https://review.openstack.org/378009 | 21:49 |
| mriedem | dansmith: +2 on the generic lister split | 21:53 |
| *** gyee has quit IRC | 21:54 | |
| dansmith | mriedem: thanks, did you comment on the migration stuff or should I? | 21:54 |
| mriedem | hmm, the bottom patch failed tests http://logs.openstack.org/53/524253/3/check/openstack-tox-py27/540f78a/testr_results.html.gz | 21:54 |
| mriedem | but those look unrelated | 21:54 |
| mriedem | dansmith: i haven't yet | 21:54 |
| dansmith | I rechecked because yeah | 21:55 |
| *** esberglu has joined #openstack-nova | 21:55 | |
| dansmith | okay I commented on the one you suggested rolling back to PS21 | 21:56 |
| *** rodolof has quit IRC | 21:56 | |
| *** pchavva has quit IRC | 21:56 | |
| *** gszasz has joined #openstack-nova | 21:58 | |
| mriedem | thanks | 21:58 |
| *** hemna_ has joined #openstack-nova | 22:04 | |
| *** Apoorva_ has quit IRC | 22:08 | |
| *** pchavva has joined #openstack-nova | 22:08 | |
| *** Apoorva has joined #openstack-nova | 22:09 | |
| *** priteau has quit IRC | 22:13 | |
| *** rcernin has joined #openstack-nova | 22:18 | |
| *** marst has quit IRC | 22:19 | |
| *** rcernin has quit IRC | 22:21 | |
| *** rcernin has joined #openstack-nova | 22:21 | |
| *** gszasz has quit IRC | 22:22 | |
| *** pchavva has quit IRC | 22:23 | |
| *** edmondsw has quit IRC | 22:24 | |
| *** edmondsw has joined #openstack-nova | 22:24 | |
| *** edmondsw has quit IRC | 22:25 | |
| mriedem | efried: with the ksa adapter stuff, just to check my understanding, valid_interfaces defaults to (internal, public) and iterates through them when trying to find the endpoint? | 22:26 |
| efried | mriedem yes | 22:27 |
| mriedem | cool | 22:27 |
| *** edmondsw_ has joined #openstack-nova | 22:27 | |
| mriedem | was making sure i was explaining that correctly here https://review.openstack.org/#/c/513243/2 | 22:27 |
| efried | mriedem lgtm | 22:29 |
| mriedem | wordsmithing that a bit | 22:30 |
| mriedem | in the commit message | 22:31 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Downgrade log for keystone verify client fail https://review.openstack.org/513243 | 22:31 |
| mriedem | efried: see if ^ makes sense | 22:31 |
| *** edmondsw_ has quit IRC | 22:31 | |
| mriedem | hmm now that i think about it, | 22:32 |
| efried | mriedem Hum, I don't think "like there isn't a keystone v3 endpoint" is right - that would have been covered by the previous except | 22:32 |
| mriedem | your change should go on top of chen's | 22:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Use ksa adapter for keystone conf & requests https://review.openstack.org/507693 | 22:33 |
| mriedem | i rebased your ksa adapter change on top of his, so we can backport his w/o weirdness | 22:33 |
| efried | Dang, mine was so close to merging :) | 22:33 |
| mriedem | you going to hold this up on the "like there isn't a keystone v3 endpoint" thing or should we just shoot the moon? | 22:34 |
| mriedem | else i'll get sdague to +W | 22:35 |
| *** erlon has quit IRC | 22:35 | |
| mgagne | is the 'admin' role hardcoded in the placement api (in newton)? :O https://github.com/openstack/nova/blob/stable/newton/nova/api/openstack/placement/handler.py#L153 | 22:38 |
| mriedem | see the TODO in there | 22:39 |
| mgagne | yea, got fixed in ocata | 22:39 |
| melwitt | mriedem: I'm requesting a g-r bump for the crazy compute host reboot thing https://review.openstack.org/#/c/524413 | 22:39 |
| mgagne | but we no longer have an "admin" role in our setup :-/ | 22:39 |
| mriedem | melwitt: on master? | 22:40 |
| melwitt | mriedem: yeah | 22:40 |
| mriedem | melwitt: i thought your issue was in newton? | 22:40 |
| melwitt | it is, but it's still broken on master | 22:40 |
| mriedem | mgagne: this? https://github.com/openstack/nova/commit/cb9300fd37225c0b744f1f85e4c3bb940e402a8b | 22:41 |
| melwitt | the instance can 'nova start' after a compute host reboot, but the volume isn't readable. I tested it with devstack | 22:41 |
| melwitt | *the encrypted volume isn't readable | 22:41 |
| mgagne | mriedem: now it's hardcoded at line 39 of nova/api/openstack/placement/policy.py | 22:41 |
| mriedem | sdague: https://review.openstack.org/#/c/513243/ and then we can backport | 22:42 |
| mriedem | ah i see | 22:42 |
| mriedem | forgot all about the policy stuff for placement | 22:43 |
| *** felipemonteiro has quit IRC | 22:44 | |
| mgagne | I'll see what I can hack on my side to get passed that, maybe just load the role name from nova.conf so I don't have to include nova.policy in there. and way for official fix later | 22:47 |
| *** READ10 has joined #openstack-nova | 22:52 | |
| mriedem | i hope lbragstad doesn't find out we haven't satisfied the queens community goal for policy in code for placement... | 22:54 |
| lbragstad | mriedem: looks like you register at least one rule | 22:56 |
| lbragstad | https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/policy.py#L45 | 22:56 |
| *** jmlowe has quit IRC | 22:58 | |
| *** slaweq has quit IRC | 23:02 | |
| *** felipemonteiro has joined #openstack-nova | 23:02 | |
| *** slaweq has joined #openstack-nova | 23:02 | |
| mgagne | local patch I will try to apply and use: https://gist.github.com/mgagne/b43c1e085c1f1d50bebc054a7d387688 | 23:05 |
| *** slaweq has quit IRC | 23:07 | |
| *** gbarros has joined #openstack-nova | 23:08 | |
| mgagne | and now I'm off, gonna check on Monday and report back on my experience with placement api =) | 23:09 |
| *** jmlowe has joined #openstack-nova | 23:09 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: General policy sample file for placement https://review.openstack.org/524425 | 23:10 |
| mriedem | mgagne: starting stuff here ^ but i don't plan on working on this really | 23:10 |
| mgagne | will try to see if I get time to check/review, if I have a workaround, I might not make it a priority though =) | 23:11 |
| *** AlexeyAbashkin has joined #openstack-nova | 23:12 | |
| lbragstad | mgagne: if you need help with the policy-in-code bits, let me know | 23:13 |
| mriedem | i don't think he's planning on writing the code :) | 23:14 |
| mgagne | lbragstad: thanks for the offer. I'm working with old code for now so I don't know yet how relevant my findings will be. will check against master and report back accordingly | 23:14 |
| *** jdurgin has quit IRC | 23:14 | |
| *** amodi has quit IRC | 23:15 | |
| *** Apoorva has quit IRC | 23:16 | |
| *** AlexeyAbashkin has quit IRC | 23:16 | |
| *** bnemec has quit IRC | 23:22 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514 | 23:31 |
| *** suresh12_ has quit IRC | 23:32 | |
| *** itlinux has joined #openstack-nova | 23:35 | |
| *** jdurgin has joined #openstack-nova | 23:36 | |
| *** felipemonteiro has quit IRC | 23:38 | |
| *** READ10 has quit IRC | 23:39 | |
| *** thorst has quit IRC | 23:41 | |
| *** salv-orlando has quit IRC | 23:41 | |
| *** Apoorva has joined #openstack-nova | 23:45 | |
| *** READ10 has joined #openstack-nova | 23:45 | |
| efried | mriedem No, not going to hold it up for that. | 23:46 |
| *** penick_ has joined #openstack-nova | 23:47 | |
| *** penick has quit IRC | 23:49 | |
| *** Guest10816 has quit IRC | 23:51 | |
| *** Apoorva_ has joined #openstack-nova | 23:53 | |
| *** moshele has joined #openstack-nova | 23:54 | |
| *** hemna_ has quit IRC | 23:54 | |
| *** felipemonteiro has joined #openstack-nova | 23:56 | |
| *** itlinux has quit IRC | 23:56 | |
| *** Apoorva has quit IRC | 23:56 | |
| *** felipemonteiro_ has joined #openstack-nova | 23:57 | |
| *** Apoorva_ has quit IRC | 23:57 | |
| *** Apoorva has joined #openstack-nova | 23:57 | |
| *** chyka_ has joined #openstack-nova | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!