| *** ijw has quit IRC | 00:02 | |
| *** ankit_ has quit IRC | 00:05 | |
| *** penick has quit IRC | 00:05 | |
| *** gbarros has joined #openstack-nova | 00:05 | |
| *** tetsuro has joined #openstack-nova | 00:09 | |
| *** lei-zh has joined #openstack-nova | 00:10 | |
| *** salv-orlando has quit IRC | 00:12 | |
| *** salv-orlando has joined #openstack-nova | 00:13 | |
| tonyb | export COMPUTE_API_VERSION=1.1 | 00:13 |
|---|---|---|
| tonyb | is that ^^ even valid? I though 2.1 was the functional minimum or am I confused? | 00:14 |
| artom | tonyb, I don't think that's valid | 00:15 |
| artom | I noticed that as well in the stuff we ship in OSP by default | 00:16 |
| artom | Somehow it ends up settling on latest, though, so I didn't dig further | 00:16 |
| artom | But it's definitely weird | 00:16 |
| *** AlexeyAbashkin has joined #openstack-nova | 00:17 | |
| *** salv-orlando has quit IRC | 00:17 | |
| *** AlexeyAbashkin has quit IRC | 00:21 | |
| *** gbarros has quit IRC | 00:23 | |
| tonyb | artom: I'm preety sure the version negotiation decides '1.1' isn't valid and defaults to latest. | 00:24 |
| tonyb | artom: something to fix in queens | 00:25 |
| *** ijw has joined #openstack-nova | 00:30 | |
| *** hongbin has quit IRC | 00:33 | |
| *** gbarros has joined #openstack-nova | 00:36 | |
| *** jmlowe has quit IRC | 00:39 | |
| *** jichen has joined #openstack-nova | 00:44 | |
| *** jmlowe has joined #openstack-nova | 00:46 | |
| *** Kevin_Zheng has joined #openstack-nova | 00:46 | |
| *** trinaths has joined #openstack-nova | 00:50 | |
| *** gbarros has quit IRC | 00:52 | |
| *** dklyle has quit IRC | 00:54 | |
| *** jichen has quit IRC | 01:01 | |
| *** MikeG451 has quit IRC | 01:01 | |
| *** david-lyle has joined #openstack-nova | 01:01 | |
| *** phuongnh has joined #openstack-nova | 01:06 | |
| *** suresh12 has quit IRC | 01:07 | |
| *** qsyqian has joined #openstack-nova | 01:07 | |
| *** zhouyaguo has joined #openstack-nova | 01:09 | |
| *** jaypipes has quit IRC | 01:10 | |
| *** liverpooler has joined #openstack-nova | 01:11 | |
| *** zhouyaguo has quit IRC | 01:12 | |
| *** salv-orlando has joined #openstack-nova | 01:14 | |
| *** yangyapeng has joined #openstack-nova | 01:15 | |
| *** yangyapeng has quit IRC | 01:16 | |
| *** yangyapeng has joined #openstack-nova | 01:16 | |
| openstackgerrit | Li Xipeng proposed openstack/nova master: Fix bug as BDM failed when booting from volume https://review.openstack.org/522486 | 01:17 |
| *** salv-orlando has quit IRC | 01:19 | |
| *** jose-phi_ has joined #openstack-nova | 01:20 | |
| *** jose-phillips has quit IRC | 01:21 | |
| openstackgerrit | Eli Qiao proposed openstack/nova master: Api-guide: Add Block Device Mapping https://review.openstack.org/522084 | 01:22 |
| *** armax has quit IRC | 01:27 | |
| *** chyka_ has quit IRC | 01:29 | |
| *** suresh12 has joined #openstack-nova | 01:30 | |
| *** suresh12 has quit IRC | 01:35 | |
| *** dave-mccowan has joined #openstack-nova | 01:36 | |
| *** fragatin_ is now known as fragatina | 01:46 | |
| *** esberglu has joined #openstack-nova | 01:46 | |
| *** sdague has quit IRC | 01:47 | |
| *** mriedem has joined #openstack-nova | 01:48 | |
| *** esberglu has quit IRC | 01:50 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Refined fix for validating image on rebuild https://review.openstack.org/523212 | 01:52 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Add regression test for rebuild with new image doubling allocations https://review.openstack.org/523213 | 01:52 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Fix doubling allocations on rebuild https://review.openstack.org/523214 | 01:52 |
| *** trinaths has left #openstack-nova | 01:55 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Add regression test for rebuild with new image doubling allocations https://review.openstack.org/523213 | 01:56 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Fix doubling allocations on rebuild https://review.openstack.org/523214 | 01:56 |
| *** cheneydc has joined #openstack-nova | 02:00 | |
| *** suresh12 has joined #openstack-nova | 02:06 | |
| *** cheneydc has quit IRC | 02:07 | |
| *** tidwellr has joined #openstack-nova | 02:09 | |
| *** annp has joined #openstack-nova | 02:10 | |
| *** chyka has joined #openstack-nova | 02:13 | |
| *** salv-orlando has joined #openstack-nova | 02:15 | |
| *** AlexeyAbashkin has joined #openstack-nova | 02:16 | |
| *** chyka has quit IRC | 02:18 | |
| *** zhurong has joined #openstack-nova | 02:18 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add x-openstack-request-id in API ref https://review.openstack.org/523007 | 02:21 |
| *** salv-orlando has quit IRC | 02:21 | |
| *** AlexeyAbashkin has quit IRC | 02:21 | |
| *** Apoorva_ has joined #openstack-nova | 02:21 | |
| *** yamamoto has joined #openstack-nova | 02:22 | |
| *** Apoorva has quit IRC | 02:25 | |
| *** Apoorva_ has quit IRC | 02:25 | |
| *** hongbin has joined #openstack-nova | 02:27 | |
| *** gcb has joined #openstack-nova | 02:27 | |
| *** lei-zh has quit IRC | 02:27 | |
| *** lei-zh has joined #openstack-nova | 02:28 | |
| *** takashin has joined #openstack-nova | 02:31 | |
| *** esberglu has joined #openstack-nova | 02:36 | |
| *** esberglu has quit IRC | 02:36 | |
| *** esberglu has joined #openstack-nova | 02:37 | |
| *** erlon has quit IRC | 02:41 | |
| *** esberglu has quit IRC | 02:41 | |
| *** qsyqian has quit IRC | 02:44 | |
| *** suresh12 has quit IRC | 02:53 | |
| *** yamahata has quit IRC | 02:53 | |
| *** gyee_ has quit IRC | 02:55 | |
| *** qsyqian has joined #openstack-nova | 02:57 | |
| *** ijw has quit IRC | 02:59 | |
| *** fragatina has quit IRC | 02:59 | |
| *** fragatina has joined #openstack-nova | 03:00 | |
| *** ijw has joined #openstack-nova | 03:02 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Implement query param schema for migration index https://review.openstack.org/518644 | 03:02 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Extract SortContext/SortWrapper of instance_list into utils https://review.openstack.org/518871 | 03:04 |
| *** fragatina has quit IRC | 03:04 | |
| *** dave-mccowan has quit IRC | 03:12 | |
| *** dave-mccowan has joined #openstack-nova | 03:12 | |
| *** dave-mcc_ has joined #openstack-nova | 03:16 | |
| *** salv-orlando has joined #openstack-nova | 03:17 | |
| *** dave-mccowan has quit IRC | 03:18 | |
| *** tbachman has quit IRC | 03:22 | |
| *** ijw has quit IRC | 03:23 | |
| *** salv-orlando has quit IRC | 03:23 | |
| *** abhishekk has joined #openstack-nova | 03:26 | |
| *** sree has joined #openstack-nova | 03:32 | |
| openstackgerrit | Guoqiang Ding proposed openstack/nova master: Update the documentation links https://review.openstack.org/523288 | 03:33 |
| *** ijw has joined #openstack-nova | 03:34 | |
| *** armax has joined #openstack-nova | 03:34 | |
| *** links has joined #openstack-nova | 03:39 | |
| *** sree has quit IRC | 03:43 | |
| *** diga has joined #openstack-nova | 03:45 | |
| openstackgerrit | Merged openstack/nova master: Refined fix for validating image on rebuild https://review.openstack.org/521186 | 03:48 |
| *** sree has joined #openstack-nova | 03:49 | |
| *** yamamoto has quit IRC | 03:51 | |
| *** tbachman has joined #openstack-nova | 03:51 | |
| *** yamamoto has joined #openstack-nova | 03:53 | |
| *** yamamoto has quit IRC | 03:53 | |
| *** yamamoto has joined #openstack-nova | 03:54 | |
| *** yamamoto has quit IRC | 03:55 | |
| *** sree has quit IRC | 03:59 | |
| *** lei-zh has quit IRC | 04:03 | |
| *** yamamoto has joined #openstack-nova | 04:05 | |
| *** ijw has quit IRC | 04:08 | |
| *** ratailor has joined #openstack-nova | 04:10 | |
| *** udesale has joined #openstack-nova | 04:14 | |
| *** mdnadeem has joined #openstack-nova | 04:15 | |
| *** AlexeyAbashkin has joined #openstack-nova | 04:16 | |
| *** salv-orlando has joined #openstack-nova | 04:19 | |
| *** chyka has joined #openstack-nova | 04:21 | |
| *** AlexeyAbashkin has quit IRC | 04:21 | |
| *** sridharg has joined #openstack-nova | 04:24 | |
| *** salv-orlando has quit IRC | 04:25 | |
| *** chyka has quit IRC | 04:26 | |
| *** zhurong has quit IRC | 04:30 | |
| *** gouthamr has quit IRC | 04:31 | |
| *** hongbin has quit IRC | 04:32 | |
| *** liverpooler has quit IRC | 04:36 | |
| *** psachin has joined #openstack-nova | 04:37 | |
| *** takashin has left #openstack-nova | 04:39 | |
| *** tidwellr has quit IRC | 04:41 | |
| *** tidwellr has joined #openstack-nova | 04:41 | |
| *** dave-mcc_ has quit IRC | 04:42 | |
| *** yamamoto has quit IRC | 04:43 | |
| *** sree has joined #openstack-nova | 04:46 | |
| *** tbachman has quit IRC | 04:46 | |
| *** suresh12 has joined #openstack-nova | 04:53 | |
| *** tbachman has joined #openstack-nova | 04:53 | |
| *** yamamoto has joined #openstack-nova | 04:54 | |
| *** yamamoto has quit IRC | 04:54 | |
| *** yamamoto has joined #openstack-nova | 04:54 | |
| *** lei-zh has joined #openstack-nova | 05:05 | |
| *** janki has joined #openstack-nova | 05:07 | |
| *** threestrands has quit IRC | 05:10 | |
| *** threestrands has joined #openstack-nova | 05:10 | |
| *** threestrands has quit IRC | 05:10 | |
| *** threestrands has joined #openstack-nova | 05:10 | |
| *** coreywright has quit IRC | 05:11 | |
| *** claudiub|2 has joined #openstack-nova | 05:11 | |
| *** threestrands has quit IRC | 05:12 | |
| *** tidwellr has quit IRC | 05:12 | |
| *** threestrands has joined #openstack-nova | 05:12 | |
| *** threestrands has quit IRC | 05:12 | |
| *** threestrands has joined #openstack-nova | 05:12 | |
| *** tidwellr has joined #openstack-nova | 05:12 | |
| *** tidwellr has joined #openstack-nova | 05:13 | |
| *** coreywright has joined #openstack-nova | 05:16 | |
| *** tidwellr has quit IRC | 05:18 | |
| *** salv-orlando has joined #openstack-nova | 05:20 | |
| *** brault has quit IRC | 05:21 | |
| *** brault has joined #openstack-nova | 05:22 | |
| *** salv-orlando has quit IRC | 05:27 | |
| *** slaweq has joined #openstack-nova | 05:31 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix 'all_tenants' & 'all_projects' type in api-ref https://review.openstack.org/522918 | 05:34 |
| *** slaweq has quit IRC | 05:35 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add 'all_tenants' for GET sec group api ref https://review.openstack.org/522910 | 05:37 |
| *** esberglu has joined #openstack-nova | 05:37 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix 'all_tenants' & 'all_projects' type in api-ref https://review.openstack.org/522918 | 05:38 |
| *** esberglu has quit IRC | 05:41 | |
| *** lei-zh has quit IRC | 05:45 | |
| *** lei-zh has joined #openstack-nova | 05:46 | |
| *** kalyan has joined #openstack-nova | 05:53 | |
| *** armax has quit IRC | 05:58 | |
| *** tbachman has quit IRC | 05:58 | |
| *** fragatina has joined #openstack-nova | 06:00 | |
| *** armax has joined #openstack-nova | 06:01 | |
| *** claudiub|2 has quit IRC | 06:01 | |
| *** armax has quit IRC | 06:02 | |
| *** fragatina has quit IRC | 06:05 | |
| *** pcaruana has joined #openstack-nova | 06:06 | |
| *** pcaruana has quit IRC | 06:06 | |
| *** zhurong has joined #openstack-nova | 06:06 | |
| *** lei-zh has quit IRC | 06:07 | |
| *** lei-zh has joined #openstack-nova | 06:07 | |
| *** lei-zh has quit IRC | 06:10 | |
| *** huanxie has joined #openstack-nova | 06:12 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Extract SortContext/SortWrapper of instance_list into utils https://review.openstack.org/518871 | 06:14 |
| *** karthiks has joined #openstack-nova | 06:14 | |
| *** esberglu has joined #openstack-nova | 06:15 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273 | 06:16 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Implement query param schema for migration index https://review.openstack.org/518644 | 06:18 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Extract SortContext/SortWrapper of instance_list into utils https://review.openstack.org/518871 | 06:18 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273 | 06:19 |
| *** esberglu has quit IRC | 06:20 | |
| *** fragatina has joined #openstack-nova | 06:21 | |
| *** lpetrut has joined #openstack-nova | 06:22 | |
| *** salv-orlando has joined #openstack-nova | 06:22 | |
| *** salv-orlando has quit IRC | 06:28 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: check query param for server groups function https://review.openstack.org/500347 | 06:33 |
| *** qsyqian_ has joined #openstack-nova | 06:34 | |
| *** fragatina has quit IRC | 06:34 | |
| *** fragatina has joined #openstack-nova | 06:34 | |
| *** diga has quit IRC | 06:38 | |
| *** qsyqian_ has quit IRC | 06:38 | |
| *** qsyqian has quit IRC | 06:38 | |
| *** fragatina has quit IRC | 06:38 | |
| *** tojuvone has quit IRC | 06:39 | |
| *** bkopilov has joined #openstack-nova | 06:42 | |
| *** fragatina has joined #openstack-nova | 06:43 | |
| *** xinliang has quit IRC | 06:46 | |
| *** salv-orlando has joined #openstack-nova | 06:49 | |
| *** salv-orlando has quit IRC | 06:50 | |
| *** salv-orlando has joined #openstack-nova | 06:50 | |
| *** liuzz has joined #openstack-nova | 06:53 | |
| openstackgerrit | xulei proposed openstack/nova master: correct the resource provider log when return 409 https://review.openstack.org/521764 | 06:55 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273 | 06:58 |
| *** xinliang has joined #openstack-nova | 07:00 | |
| *** mriedem has quit IRC | 07:00 | |
| *** threestrands has quit IRC | 07:04 | |
| *** edand has joined #openstack-nova | 07:05 | |
| *** zhurong has quit IRC | 07:05 | |
| *** fragatina has quit IRC | 07:06 | |
| *** namnh has joined #openstack-nova | 07:06 | |
| *** fragatina has joined #openstack-nova | 07:07 | |
| *** josecastroleon has joined #openstack-nova | 07:08 | |
| *** suresh12 has quit IRC | 07:10 | |
| *** yamahata has joined #openstack-nova | 07:11 | |
| *** fragatina has quit IRC | 07:11 | |
| *** suresh12 has joined #openstack-nova | 07:13 | |
| *** Oku_OS-away is now known as Oku_OS | 07:14 | |
| *** slaweq has joined #openstack-nova | 07:17 | |
| *** suresh12 has quit IRC | 07:17 | |
| *** spectr has joined #openstack-nova | 07:18 | |
| *** edand has quit IRC | 07:20 | |
| *** spectr has quit IRC | 07:21 | |
| *** diga has joined #openstack-nova | 07:22 | |
| *** moshele has joined #openstack-nova | 07:23 | |
| *** slaweq has quit IRC | 07:25 | |
| *** sree_ has joined #openstack-nova | 07:28 | |
| *** claudiub|2 has joined #openstack-nova | 07:28 | |
| *** sree_ is now known as Guest79701 | 07:28 | |
| *** danpawlik has quit IRC | 07:29 | |
| *** sree has quit IRC | 07:31 | |
| *** gszasz has joined #openstack-nova | 07:34 | |
| *** fragatina has joined #openstack-nova | 07:39 | |
| *** slaweq has joined #openstack-nova | 07:44 | |
| *** Alex_Staf has quit IRC | 07:48 | |
| *** AlexeyAbashkin has joined #openstack-nova | 07:52 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273 | 07:52 |
| *** rcernin has quit IRC | 07:53 | |
| *** andreas_s has joined #openstack-nova | 07:58 | |
| openstackgerrit | Hamdy Khader proposed openstack/nova master: Adding NVMEoF for libvirt driver https://review.openstack.org/482640 | 07:59 |
| *** andreas_s has quit IRC | 08:08 | |
| *** ratailor has quit IRC | 08:09 | |
| *** trungnv has quit IRC | 08:18 | |
| *** trungnv has joined #openstack-nova | 08:18 | |
| *** lpetrut has quit IRC | 08:18 | |
| *** ralonsoh has joined #openstack-nova | 08:18 | |
| *** hieulq has quit IRC | 08:20 | |
| *** damien_r has joined #openstack-nova | 08:20 | |
| *** hieulq has joined #openstack-nova | 08:20 | |
| *** danpawlik has joined #openstack-nova | 08:22 | |
| *** danpawlik has quit IRC | 08:23 | |
| *** danpawlik has joined #openstack-nova | 08:24 | |
| *** slaweq_ has joined #openstack-nova | 08:24 | |
| *** lpetrut has joined #openstack-nova | 08:25 | |
| *** danpawlik has quit IRC | 08:26 | |
| *** ragiman has joined #openstack-nova | 08:28 | |
| *** pcaruana has joined #openstack-nova | 08:28 | |
| *** danpawlik has joined #openstack-nova | 08:29 | |
| *** slaweq_ has quit IRC | 08:29 | |
| openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: get vGPU stats from hypervisor https://review.openstack.org/512965 | 08:30 |
| openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: provide vGPU inventory in compute node https://review.openstack.org/516217 | 08:30 |
| openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: create vGPU for instance https://review.openstack.org/516899 | 08:30 |
| openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: provide VGPU_DISPLAY_HEAD inventory in compute node https://review.openstack.org/523342 | 08:30 |
| *** alexchadin has joined #openstack-nova | 08:31 | |
| openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: provide VGPU_DISPLAY_HEAD inventory in compute node https://review.openstack.org/523342 | 08:37 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | 08:39 |
| *** ratailor has joined #openstack-nova | 08:48 | |
| *** AlexeyAbashkin has quit IRC | 08:48 | |
| *** damien_r has quit IRC | 08:51 | |
| *** AlexeyAbashkin has joined #openstack-nova | 08:51 | |
| *** sahid has joined #openstack-nova | 08:51 | |
| *** damien_r has joined #openstack-nova | 08:51 | |
| *** gmann is now known as gmann_afk | 08:53 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add instance action record for lock/unlock instances https://review.openstack.org/523353 | 08:54 |
| *** cdent has joined #openstack-nova | 08:57 | |
| *** vladikr has quit IRC | 08:57 | |
| *** vladikr has joined #openstack-nova | 09:00 | |
| *** priteau has joined #openstack-nova | 09:01 | |
| openstackgerrit | Hamdy Khader proposed openstack/nova master: Adding NVMEoF for libvirt driver https://review.openstack.org/482640 | 09:02 |
| *** stvnoyes has quit IRC | 09:02 | |
| *** stvnoyes has joined #openstack-nova | 09:02 | |
| *** yamamoto has quit IRC | 09:04 | |
| *** yamamoto has joined #openstack-nova | 09:05 | |
| *** jpena|off is now known as jpena | 09:09 | |
| *** yamamoto has quit IRC | 09:11 | |
| *** lucas-afk is now known as lucasagomes | 09:19 | |
| *** zhurong has joined #openstack-nova | 09:20 | |
| *** sbezverk has quit IRC | 09:22 | |
| alex_xu | cdent: good morning, I have a confuse on this patch https://review.openstack.org/#/c/510626, looks like we just ignore the 'generation' parameter from the request, is it on purpose? or I missed something | 09:22 |
| cdent | yes, it is ignored on purpose. the idead is that when you do a GET the generation is included, so if you want to PUT that back you don’t have to worry about removing the generation | 09:23 |
| cdent | there’s more in the linked spec | 09:23 |
| *** moshele has quit IRC | 09:24 | |
| *** moshele has joined #openstack-nova | 09:24 | |
| *** moshele has quit IRC | 09:25 | |
| *** moshele_ has joined #openstack-nova | 09:26 | |
| *** moshele_ has quit IRC | 09:26 | |
| *** moshele has joined #openstack-nova | 09:26 | |
| alex_xu | cdent: ah, thanks | 09:27 |
| openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: update the picture in Xen hypervisor document https://review.openstack.org/523360 | 09:30 |
| *** jichen has joined #openstack-nova | 09:30 | |
| openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: update the picture in Xen hypervisor document https://review.openstack.org/523360 | 09:32 |
| *** salv-orlando has quit IRC | 09:33 | |
| *** salv-orlando has joined #openstack-nova | 09:33 | |
| openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: update the picture in Xen hypervisor document https://review.openstack.org/523360 | 09:37 |
| *** salv-orlando has quit IRC | 09:38 | |
| *** ociuhandu has joined #openstack-nova | 09:43 | |
| *** lpetrut has quit IRC | 09:44 | |
| *** ociuhandu has quit IRC | 09:46 | |
| *** derekh has joined #openstack-nova | 09:46 | |
| *** openstackgerrit has quit IRC | 09:48 | |
| *** diga has quit IRC | 09:49 | |
| *** Alex_Staf has joined #openstack-nova | 09:52 | |
| *** erlon has joined #openstack-nova | 09:55 | |
| *** rcernin has joined #openstack-nova | 09:55 | |
| *** chyka has joined #openstack-nova | 09:57 | |
| *** chyka has quit IRC | 10:02 | |
| *** sdatko has quit IRC | 10:06 | |
| *** diga has joined #openstack-nova | 10:06 | |
| *** yamahata has quit IRC | 10:07 | |
| *** namnh has quit IRC | 10:07 | |
| *** openstackgerrit has joined #openstack-nova | 10:08 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: POC: tests: autospecs all the mock.patch usages https://review.openstack.org/470775 | 10:08 |
| *** sambetts|afk is now known as sambetts | 10:11 | |
| *** yamamoto has joined #openstack-nova | 10:14 | |
| *** yamamoto has quit IRC | 10:19 | |
| *** zhurong has quit IRC | 10:19 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and changes-since for instance-actions https://review.openstack.org/326326 | 10:20 |
| *** sdague has joined #openstack-nova | 10:22 | |
| *** alexchadin has quit IRC | 10:28 | |
| *** gcb has quit IRC | 10:28 | |
| *** rmart04 has joined #openstack-nova | 10:29 | |
| *** phuongnh has quit IRC | 10:30 | |
| *** kalyan has quit IRC | 10:33 | |
| *** lpetrut has joined #openstack-nova | 10:35 | |
| *** huanxie has quit IRC | 10:36 | |
| *** kalyan has joined #openstack-nova | 10:37 | |
| *** slaweq_ has joined #openstack-nova | 10:37 | |
| *** saop has joined #openstack-nova | 10:40 | |
| saop | Hello all | 10:40 |
| nkorabli | Hey | 10:41 |
| *** jaianshu_ has joined #openstack-nova | 10:41 | |
| saop | I have openstack pike, and i tried to provision one instance with nova using libvirt driver | 10:41 |
| *** slaweq_ has quit IRC | 10:42 | |
| saop | I got error regarding "VirtualInterfaceCreateException: Virtual Interface creation failed" | 10:42 |
| saop | My dhcp is right and everything seems fine | 10:42 |
| saop | any idea what's the problem? | 10:43 |
| *** ArchiFleKs has quit IRC | 10:45 | |
| *** esberglu has joined #openstack-nova | 10:46 | |
| *** alexchadin has joined #openstack-nova | 10:51 | |
| *** esberglu has quit IRC | 10:51 | |
| *** udesale has quit IRC | 10:55 | |
| nkorabli | I'm not an expert on that, sorry.. | 10:56 |
| *** abhishekk has quit IRC | 10:57 | |
| openstackgerrit | xulei proposed openstack/nova master: correct the resource provider log when return 409 https://review.openstack.org/521764 | 10:58 |
| *** salv-orlando has joined #openstack-nova | 11:01 | |
| *** cdent has quit IRC | 11:01 | |
| *** annp has quit IRC | 11:03 | |
| nsingh | i am facing an issue ref: http://paste.openstack.org/show/627553/. any help? | 11:03 |
| openstackgerrit | Huang Rui proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387 | 11:06 |
| *** salv-orlando has quit IRC | 11:07 | |
| *** salv-orlando has joined #openstack-nova | 11:08 | |
| openstackgerrit | Merged openstack/nova master: [placement] Symmetric GET and PUT /allocations/{consumer_uuid} https://review.openstack.org/510626 | 11:09 |
| *** salv-orlando has quit IRC | 11:13 | |
| *** salv-orlando has joined #openstack-nova | 11:14 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add instance action record for lock/unlock instances https://review.openstack.org/523353 | 11:24 |
| *** nkorabli has quit IRC | 11:27 | |
| *** Mahesh has joined #openstack-nova | 11:27 | |
| *** nkorabli has joined #openstack-nova | 11:27 | |
| *** nkorabli has quit IRC | 11:32 | |
| *** diga has quit IRC | 11:35 | |
| *** mdnadeem has quit IRC | 11:38 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Extract instance allocation removal code https://review.openstack.org/513041 | 11:38 |
| *** chyka has joined #openstack-nova | 11:47 | |
| *** mhenkel has quit IRC | 11:50 | |
| *** chyka has quit IRC | 11:51 | |
| *** efried has quit IRC | 11:54 | |
| *** Guest79701 has quit IRC | 11:54 | |
| *** mhenkel has joined #openstack-nova | 11:54 | |
| *** mdnadeem has joined #openstack-nova | 11:55 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and changes-since for instance-actions https://review.openstack.org/326326 | 11:56 |
| openstackgerrit | Wangpan proposed openstack/nova master: Handle ImageInUse exception during instance backup https://review.openstack.org/523395 | 11:56 |
| *** linpopilan has quit IRC | 11:58 | |
| *** ratailor has quit IRC | 11:59 | |
| *** bkopilov has quit IRC | 12:01 | |
| *** psachin has quit IRC | 12:01 | |
| *** sree has joined #openstack-nova | 12:02 | |
| *** sapd_ has quit IRC | 12:03 | |
| *** sapd__ has joined #openstack-nova | 12:03 | |
| *** efried has joined #openstack-nova | 12:07 | |
| *** sree has quit IRC | 12:07 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Enable limiting GET /allocation_candidates https://review.openstack.org/513526 | 12:09 |
| ebbex | /os-simple-tenant-usage/{tenant_id} , should that query return duplicates in "server_usages": [] ? | 12:12 |
| efried | nsingh Still around? | 12:15 |
| nsingh | yes | 12:15 |
| efried | nsingh What's the config group? | 12:16 |
| nsingh | u mean in cinder? | 12:17 |
| efried | Wherever the mystery session conf options are showing up | 12:18 |
| efried | alex_xu yt? | 12:18 |
| *** yamamoto has joined #openstack-nova | 12:18 | |
| *** takedakn has joined #openstack-nova | 12:18 | |
| nsingh | it is showing the config group that i have provided as parameter. | 12:19 |
| efried | alex_xu FYI, I'm in the middle of porting those two test cases over. If they pass, I'll just slap 'em on top of the series. If they don't... | 12:19 |
| efried | nsingh I don't understand. | 12:20 |
| efried | nsingh What's the name of the conf group? | 12:20 |
| nsingh | glance | 12:21 |
| efried | nsingh And in which process are these options showing up? | 12:21 |
| *** yamamoto has quit IRC | 12:22 | |
| *** takedakn has quit IRC | 12:23 | |
| *** sree has joined #openstack-nova | 12:23 | |
| nsingh | when i went inside https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/loading/session.py#L225 (kwargs.setdefault('insecure', c.insecure)) | 12:23 |
| *** udesale has joined #openstack-nova | 12:23 | |
| efried | nsingh Which openstack service process are you in? c-api? n-cpu? etc. | 12:23 |
| nsingh | c-api | 12:24 |
| efried | okay, stand by... | 12:24 |
| *** jaianshu__ has joined #openstack-nova | 12:25 | |
| *** jaianshu__ has quit IRC | 12:25 | |
| nsingh | insecure cafile certfile keyfile timeout -- are these options are added in the opt list of group at the time of service start? sorry another question. | 12:25 |
| nsingh | https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/loading/session.py#L180 | 12:26 |
| *** sree has quit IRC | 12:27 | |
| *** jaianshu_ has quit IRC | 12:28 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] POST /allocations to set allocations for >1 consumers https://review.openstack.org/500073 | 12:31 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Fix GET PUT /allocations nits https://review.openstack.org/523401 | 12:31 |
| efried | nsingh Yes, if they're registered via that call. Can you tell me the command line for your c-api process? | 12:33 |
| *** esberglu has joined #openstack-nova | 12:34 | |
| *** saop has quit IRC | 12:35 | |
| *** jaianshu has joined #openstack-nova | 12:36 | |
| efried | nsingh systemctl status should show it. | 12:36 |
| nsingh | are you asking about logs ? | 12:37 |
| nsingh | ok | 12:37 |
| nsingh | http://paste.openstack.org/show/627566/ | 12:38 |
| *** esberglu has quit IRC | 12:39 | |
| efried | nsingh Can you paste me that cinder-api-uwsgi.ini? | 12:42 |
| *** lpetrut has quit IRC | 12:42 | |
| nsingh | http://paste.openstack.org/show/627569/ | 12:43 |
| *** nkorabli has joined #openstack-nova | 12:44 | |
| openstackgerrit | Wangpan proposed openstack/nova master: Handle ImageInUse exception during instance backup https://review.openstack.org/523395 | 12:45 |
| *** tetsuro has quit IRC | 12:47 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP: [placement] use global conf with auth token middleware https://review.openstack.org/523403 | 12:48 |
| *** Mahesh has quit IRC | 12:50 | |
| *** nkorabli has quit IRC | 12:51 | |
| *** yangyapeng has quit IRC | 12:56 | |
| jaianshu | Hello everyone | 12:59 |
| jaianshu | i'm getting error in spawning vm on stable/pike " Failed to allocate the network(s), not rescheduling." | 13:00 |
| nsingh | efried: still there? | 13:00 |
| jaianshu | n-cpu.log - http://paste.openstack.org/show/627576/ | 13:00 |
| jaianshu | any ideas? | 13:01 |
| efried | nsingh Yes, sorry, looking at cinder-wsgi... | 13:01 |
| nsingh | efried: ooh thanks | 13:02 |
| *** smatzek has joined #openstack-nova | 13:02 | |
| *** dtantsur|afk is now known as dtantsur | 13:02 | |
| *** jpena is now known as jpena|lunch | 13:02 | |
| *** cdent has joined #openstack-nova | 13:03 | |
| cdent | efried: what’s the emoji for :kid with fingers in ears saying la la la la la la over and over: ? | 13:03 |
| *** sree has joined #openstack-nova | 13:04 | |
| efried | cdent I can think of a couple of finger emojis | 13:04 |
| cdent | heh | 13:04 |
| *** dave-mccowan has joined #openstack-nova | 13:05 | |
| *** mdnadeem has quit IRC | 13:06 | |
| *** liverpooler has joined #openstack-nova | 13:06 | |
| kalyan | jaianshu: virtual interface creation failed...could you please check if vif plugin entries present in the nova.conf | 13:07 |
| efried | nsingh To make sure I understand, we're saying is that your c-api process is registering ksa auth opts in the [glance] conf section, right? | 13:08 |
| nsingh | efried: yes | 13:08 |
| *** sree has quit IRC | 13:08 | |
| cdent | hurrah it is microversion merge conflict day! | 13:09 |
| jaianshu | kalyan: i have these 2 entries for vif-plugin in nova.conf - vif_plugging_timeout=10 | 13:09 |
| jaianshu | and vif_plugging_is_fatal=False | 13:09 |
| *** slaweq_ has joined #openstack-nova | 13:10 | |
| openstackgerrit | jichenjc proposed openstack/nova master: check query param for server groups function https://review.openstack.org/500347 | 13:10 |
| *** ijw has joined #openstack-nova | 13:11 | |
| efried | nsingh Okay; I can't see how that's happening. Normally it would be via keystoneauth1.loading.register_auth_conf_options, but I don't see anywhere in cinder that's being done for a [glance] section, directly or indirectly. Perhaps someone in #openstack-cinder could shed some light on that. | 13:11 |
| nsingh | efried: ok is it done for any section? | 13:12 |
| efried | nsingh Not that I can see. | 13:12 |
| nsingh | efried: ok thank you for help. :) | 13:13 |
| efried | nsingh Good luck. | 13:13 |
| nsingh | efried: And your suggestion about cinder to nova interaction that i asked earlier works. So thank you for that also. | 13:14 |
| efried | nsingh Oh, great to hear. | 13:14 |
| *** slaweq_ has quit IRC | 13:14 | |
| efried | nsingh Which one was it? | 13:14 |
| *** lucasagomes is now known as lucas-hungry | 13:14 | |
| *** jichen has quit IRC | 13:14 | |
| nsingh | efried: you replied me on mail. | 13:15 |
| efried | nsingh Right, and I suggested three or four things - which one was the right one? | 13:15 |
| *** ijw has quit IRC | 13:15 | |
| nsingh | efried: n-cpu was pointing to nova-cpu.conf and i add sevice user configuration in nova.conf | 13:16 |
| efried | nsingh Okay, cool. | 13:16 |
| efried | nsingh I got burned by that a few months ago. | 13:16 |
| nsingh | efried: oohh.. | 13:16 |
| *** links has quit IRC | 13:16 | |
| *** nkorabli has joined #openstack-nova | 13:18 | |
| *** pchavva has joined #openstack-nova | 13:21 | |
| *** nkorabli has quit IRC | 13:21 | |
| *** mdnadeem has joined #openstack-nova | 13:22 | |
| *** edmondsw has joined #openstack-nova | 13:22 | |
| *** sree has joined #openstack-nova | 13:24 | |
| *** pchavva has quit IRC | 13:27 | |
| *** READ10 has joined #openstack-nova | 13:27 | |
| *** abalutoiu has joined #openstack-nova | 13:27 | |
| *** bkopilov has joined #openstack-nova | 13:28 | |
| *** sree has quit IRC | 13:29 | |
| *** esberglu has joined #openstack-nova | 13:29 | |
| *** esberglu has quit IRC | 13:29 | |
| *** esberglu has joined #openstack-nova | 13:29 | |
| *** esberglu has quit IRC | 13:29 | |
| *** esberglu has joined #openstack-nova | 13:30 | |
| *** sree has joined #openstack-nova | 13:30 | |
| *** jaypipes has joined #openstack-nova | 13:31 | |
| *** yangyapeng has joined #openstack-nova | 13:32 | |
| *** mriedem has joined #openstack-nova | 13:32 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Object changes to support last-modified headers https://review.openstack.org/521639 | 13:34 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Add cache headers to placement api requests https://review.openstack.org/521640 | 13:34 |
| *** sree has quit IRC | 13:35 | |
| *** esberglu has quit IRC | 13:35 | |
| *** yangyapeng has quit IRC | 13:37 | |
| mriedem | bauzas: can you take a look at https://review.openstack.org/#/c/521391/ and the patch below it? those have to get backported through to newton and i was holding up the backports until i got some core review | 13:42 |
| *** pchavva has joined #openstack-nova | 13:42 | |
| *** sree has joined #openstack-nova | 13:43 | |
| *** lyan has joined #openstack-nova | 13:50 | |
| mriedem | alex_xu: do you know if @wsgi.action('migrate') ensures that a cold migration request will have a 'migrate' key in the request body even if the value for that key is null? we don't actually care about the value | 13:51 |
| *** peter-hamilton has joined #openstack-nova | 13:52 | |
| mriedem | my guess is we wouldn't route properly if the request body didn't have the 'migrate' key in it | 13:53 |
| *** tbachman has joined #openstack-nova | 13:54 | |
| jianghuaw_ | jaypipes, bauzas: are you around? | 13:56 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use ksa adapter for keystone conf & requests https://review.openstack.org/507693 | 13:57 |
| *** salv-orlando has quit IRC | 13:57 | |
| *** jaianshu has quit IRC | 13:58 | |
| ildikov | mriedem: hi :) | 14:00 |
| ildikov | mriedem: I hope you had a great Turkey weekend :) | 14:00 |
| *** esberglu has joined #openstack-nova | 14:00 | |
| *** yamahata has joined #openstack-nova | 14:00 | |
| jaypipes | jianghuaw_: I am indeed. | 14:00 |
| moshele | jaypipes: hi can you +W review https://review.openstack.org/#/c/519066/ Rabi Mishra for heat team tested and it pass their test | 14:00 |
| ildikov | mriedem: so I think it's time now to do my regular "pretty please speech" for review: https://review.openstack.org/#/c/330285/ | 14:00 |
| jianghuaw_ | jaypipes, hi Jay. I posted a patch to create inventory data for VGPU_DISPLAY_HEAD. But later I realized there would be a problem. | 14:00 |
| jianghuaw_ | https://review.openstack.org/#/c/523342/2/nova/virt/xenapi/driver.py@477 | 14:01 |
| ildikov | johnthetubaguy: same pretty please goes to you too ^^ | 14:01 |
| jaypipes | moshele: done | 14:01 |
| jianghuaw_ | jaypipes, The vgpu display heads is not independent resources. When it consuming VGPUs, it also consumes display heads. | 14:01 |
| moshele | jaypipes: cool thanks :) | 14:01 |
| jaypipes | jianghuaw_: is there a specific relationship between the quantities? for example, does 1 VGPU means 1 display head will be consumed? | 14:02 |
| jaypipes | jianghuaw_: or is it dependent on the vGPU type? | 14:02 |
| efried | sdague Would you please have a look at https://review.openstack.org/#/c/409404/ when you get a chance? | 14:05 |
| jaypipes | efried: I'm rebasing the series from review 520246. just making sure you've no local changes? | 14:05 |
| efried | jaypipes No yet. Go for it. | 14:06 |
| jaypipes | rock on. | 14:06 |
| *** thorst has joined #openstack-nova | 14:06 | |
| efried | And thanks as always for checking | 14:06 |
| jianghuaw_ | jaypipes, sorry. I just got a network disconnection. | 14:06 |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP: [placement] use global conf with auth token middleware https://review.openstack.org/523403 | 14:06 |
| jaypipes | jianghuaw_: I'll repeat... | 14:06 |
| jianghuaw_ | jaypipes, yes. it depends on the vGPU type. | 14:06 |
| jaypipes | jianghuaw_: is there a specific relationship between the quantities? for example, does 1 VGPU means 1 display head will be consumed? | 14:07 |
| jaypipes | jianghuaw_: or is it dependent on the vGPU type? | 14:07 |
| *** lucas-hungry is now known as lucasagomes | 14:07 | |
| jianghuaw_ | For example: There each vGPU supports 2 display heads and total vGPU is 5; then initially the available vGPUs amount is 5; and available amount of display heads is 10 | 14:07 |
| jaypipes | jianghuaw_: ok. so what is the problem with ensuring the flavor requests both VGPU and display head resources? | 14:07 |
| jianghuaw_ | After we boot an instance with one VGPU. The available display heads will also be reduce to 8. But placement doesn’t know of the change on display heads if we don’t specify VGPU_DISPLAY_HEAD in the request spec. | 14:07 |
| jianghuaw_ | if we specify both VGPU and display_heads, it should work. | 14:08 |
| jaypipes | jianghuaw_: is there a reason we can't specify display heads in the flavor? | 14:08 |
| jianghuaw_ | But I think we should allow flavor to only request VGPU. | 14:08 |
| *** jpena|lunch is now known as jpena|off | 14:08 | |
| jianghuaw_ | as the display heads is optional. | 14:08 |
| efried | jianghuaw_ That's what I was going to suggest. | 14:08 |
| efried | jianghuaw_ Is it always a certain number of display heads for a given type of vGPU? | 14:09 |
| jianghuaw_ | yes. it is. | 14:09 |
| *** gbarros has joined #openstack-nova | 14:09 | |
| efried | jianghuaw_ And is it possible to do requests in such a way that you run out of display heads before you run out of VGPUs? | 14:09 |
| jianghuaw_ | the amount of display heads is determined by the vgpu type. | 14:09 |
| jianghuaw_ | shouldn't. | 14:10 |
| efried | jianghuaw_ Then yeah, I say leave display heads out of the picture entirely. Don't register them as resources, and don't include them in the flavor. | 14:10 |
| *** jmlowe has quit IRC | 14:10 | |
| sdague | efried: +A | 14:11 |
| efried | sdague Thanks! | 14:11 |
| sdague | and +2 on the config matrix update | 14:11 |
| efried | sdague Cool. | 14:12 |
| jianghuaw_ | efried, but I guess some customers may want to request vGPU with needed heads. | 14:12 |
| *** abhishekk has joined #openstack-nova | 14:13 | |
| *** pcaruana has quit IRC | 14:13 | |
| jianghuaw_ | jaypipes, efried: I'm feeling the display heads somehow looks like a trait. | 14:14 |
| jaypipes | jianghuaw_: it's not :) it's a consumable resource | 14:15 |
| efried | Unless it's like DUAL_DISPLAY_HEAD_CAPABLE :) | 14:15 |
| jianghuaw_ | jaypipes, but it does have problem if we allow having display head as optional. | 14:16 |
| edleafe | jianghuaw_: can you request a vGPU *without* consuming a display head? | 14:16 |
| jaypipes | jianghuaw_: why is that? wouldn't you just have a flavor that doesn't have display heads? | 14:16 |
| *** pcaruana has joined #openstack-nova | 14:17 | |
| jianghuaw_ | efried, some vGPU types don't support display heads. | 14:17 |
| jianghuaw_ | As some vGPUs don't support display heads. so the display heads' inv may be empty. So we should allow the flavor without specifying display heads. | 14:19 |
| efried | jianghuaw_ In those cases, it makes sense. Where I think we're having issues is this idea that, by requesting a certain type of vGPU, we might "automatically" consume some number of display heads. We can't do that if we're inventorying the display heads. | 14:20 |
| jianghuaw_ | But it's still possible to allocate a vGPU which support display heads it only request some kind of vGPU. | 14:20 |
| efried | jianghuaw_ Let me ask it this way: In these cases where certain vGPU types support consuming display heads, is it possible to request a vGPU *without* consuming display heads? | 14:21 |
| *** yamamoto has joined #openstack-nova | 14:21 | |
| jianghuaw_ | efried, yes. that's exactly the problem I met. | 14:21 |
| edleafe | efried: jinx-ish | 14:22 |
| efried | jianghuaw_ If they need to be inventoried as separate resources, then they need to be requested as separate resources. | 14:22 |
| jaypipes | efried: +1 | 14:23 |
| efried | jianghuaw_ And it sounds like we may have cases where a particular flavor setup is simply invalid: If there's a vGPU type that *must* consume display heads, your flavor *must* request the appropriate number of vGPUs *and* display heads. Otherwise it's bogus. | 14:24 |
| bauzas | jianghuaw_: sorry was afk | 14:25 |
| jianghuaw_ | bauzas, hi. no worries. | 14:25 |
| bauzas | oh, you're discussing about display heads ? | 14:25 |
| jianghuaw_ | bauzas, yes. | 14:25 |
| bauzas | ok | 14:25 |
| mriedem | esberglu: efried: why are evacuate and rebuild marked as missing in here? https://review.openstack.org/#/c/523140/ | 14:25 |
| mriedem | nova-compute has a default rebuild impl if the virt driver doesn't implement it's own | 14:26 |
| bauzas | so, the point is that given some VGPU types don't provide display heads, then the inventory for them would be none | 14:26 |
| bauzas | so, when asking for display heads, the placement API wouldn't provide the computes having them | 14:27 |
| jianghuaw_ | yes. I think we have cases that the vGPUs don't support display heads co-exist with vGPU not supporting it. | 14:27 |
| bauzas | then, the scheduler would allocate a claim only for the computes supporting them | 14:27 |
| efried | mriedem We have logic to make sure devices are re-attached in the proper order on rebuild. That logic isn't in the in-tree driver yet. So a rebuild *might* work with the default impl, but it might not. | 14:27 |
| jianghuaw_ | that's why I'm thinking we should allow flavors which don't request display heads. | 14:28 |
| bauzas | jianghuaw_: see the problem ? | 14:28 |
| bauzas | right | 14:28 |
| mriedem | efried: that's why it was marked 'unknown' | 14:28 |
| mriedem | efried: i don't think libvirt ensures devices are re-attached in the same order on rebuild either | 14:29 |
| mriedem | that's why mdbooth had the bdm metadata stuff for awhile | 14:29 |
| mriedem | *i think* | 14:29 |
| *** janki has quit IRC | 14:29 | |
| mdbooth | efried: They are definitely *not* reattached in the same order in all circumstances | 14:30 |
| jianghuaw_ | bauzas, It's possible to allocate vGPUs which actually supports display heads for those flavors not requesting display heads. | 14:30 |
| *** smatzek has quit IRC | 14:30 | |
| efried | mdbooth Yeah, so in PowerVM, we guarantee that. | 14:30 |
| jianghuaw_ | as the resource provider have inventory for VGPU which can meet the request. | 14:30 |
| *** smatzek has joined #openstack-nova | 14:31 | |
| mdbooth | efried: It would be nice. | 14:31 |
| mdbooth | efried: Is your scheme reproducible? | 14:31 |
| efried | mriedem Yeah, I confirmed by looking at our OOT driver - there's a bunch of special stuff we do in spawn for the rebuild case that we haven't ported in yet. So we want to declare that we *don't* support rebuild in the in-tree driver yet. | 14:31 |
| *** slaweq has quit IRC | 14:31 | |
| bauzas | jianghuaw_: the problem I see is that if you provide a flavor asking for both VGPUs *and* heads, then the scheduler will ask placement for *both* | 14:31 |
| mdbooth | efried: i.e. Could the libvirt driver use it? | 14:32 |
| *** slaweq has joined #openstack-nova | 14:32 | |
| *** alexchadin has quit IRC | 14:32 | |
| efried | mdbooth Bunch of caveats, but I think the concept might be portable. | 14:32 |
| bauzas | jianghuaw_: AFAIR, we had a spec for modifying the placement call to ask for some resource classes not mandatory | 14:32 |
| bauzas | efried: jaypipes: is it, right? | 14:32 |
| efried | bauzas Not for Q | 14:33 |
| mdbooth | The issue the libvirt driver has is the interaction between dynamic and 'static' disks | 14:33 |
| bauzas | efried: yup, I know | 14:33 |
| bauzas | efried: I was more commenting about the fact we discussed that | 14:33 |
| efried | bauzas The one I remember was for "preferred traits", not for optional resource classes. | 14:33 |
| bauzas | yeah that | 14:33 |
| mdbooth | So if you have an instance with a root disk and a config disk, then you attach a volume, you'll have root disk, config disk, volume | 14:33 |
| mdbooth | But in rebuild we always put the config disk last | 14:33 |
| *** yamamoto has quit IRC | 14:33 | |
| mdbooth | So on rebuild you'll have root disk, volume, config disk | 14:33 |
| jianghuaw_ | bauzas, I think this case makes sense. What I'm think is that a flavor is asking only VGPU, but it placement may return RPs which contains display heads also. | 14:33 |
| mdbooth | And in fact we have no way of knowing what the previous order was | 14:34 |
| jianghuaw_ | it will result into the display heads leaking. | 14:34 |
| bauzas | jianghuaw_: right | 14:34 |
| bauzas | what do you mean by leaking ? | 14:34 |
| *** eharney has quit IRC | 14:34 | |
| efried | mdbooth For us, the dev order is determined by which virtual "slot" the disk is attached via. So we maintain a cache of which devices are associated with which slots, and then we make sure to restore that on rebuild. | 14:34 |
| bauzas | jianghuaw_: that's depending on the virt driver, right ? | 14:34 |
| mdbooth | efried: Right. Where do you store the cache, though? | 14:35 |
| *** smatzek has quit IRC | 14:35 | |
| efried | mdbooth In our case, in order to support that, the user has to set up swift :$ | 14:35 |
| mdbooth | Ah... | 14:35 |
| efried | indeeed. | 14:35 |
| jianghuaw_ | bauzas, I mean it automatically consumed display heads. but placement don't it. | 14:35 |
| mdbooth | See, I actually think there's a lot of merit in having persistent driver state | 14:35 |
| mdbooth | I think it should be local to the hypervisor, though | 14:36 |
| efried | mdbooth We don't go crazy with persistent state, for sure. We save these slot mappings, and we save the partition's NVRAM. | 14:36 |
| *** slaweq has quit IRC | 14:36 | |
| jianghuaw_ | bauzas, don't it => doesn't know of it. | 14:36 |
| mdbooth | efried: Definitely in favour of the concept. | 14:37 |
| efried | mdbooth I have to say, our implementation ain't pretty. | 14:37 |
| jianghuaw_ | bauzas, virt driver can only stop a booting by checking the resoureces in the allocation. | 14:38 |
| *** maciejjozefczyk has quit IRC | 14:38 | |
| efried | mdbooth It was one of these rush jobs where we realized the problem (devices attached out of order) late in a cycle, and threw together a solution at the last minute. | 14:38 |
| mdbooth | efried: Out of curiosity, why did you consider it a sufficiently big problem for a big rush job? | 14:38 |
| jianghuaw_ | bauzas, or is there a way to correct the allocation if the allocated vGPU also supports display heads? | 14:39 |
| mdbooth | Device ordering is also inconsistent in a Linux guest OS | 14:39 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] re-use existing conf with auth token middleware https://review.openstack.org/523403 | 14:39 |
| *** sree_ has joined #openstack-nova | 14:39 | |
| efried | mdbooth I don't remember all the reasons, but e.g. maybe you don't boot. | 14:39 |
| efried | mdbooth Or possibly worse, boot to the wrong disk. | 14:39 |
| *** sree_ is now known as Guest97530 | 14:39 | |
| *** sree has quit IRC | 14:40 | |
| *** armax has joined #openstack-nova | 14:40 | |
| efried | mdbooth Also could have something to do with applications in guests referring to devices by name - and if that name changes, you're kaput. | 14:41 |
| mdbooth | efried: That last point isn't fixed by consistent device ordering | 14:41 |
| efried | mdbooth Keep in mind we're running not just Linux, but also AIX and IBMi. | 14:41 |
| mdbooth | Because as I say, Linux itself is also non-deterministic | 14:41 |
| mdbooth | The first should be handled by the hypervisor specifying a boot order for its BIOS/UEFI | 14:42 |
| mdbooth | Or whatever hopefully much better boot solution is in Power :) | 14:43 |
| efried | mdbooth That's exactly the point: The boot list is specified based on hardware addresses, which are discovered based on slots. | 14:43 |
| *** lpetrut has joined #openstack-nova | 14:44 | |
| efried | mdbooth The big conceptual divide here is that PowerVM has a real hypervisor and the guests are real partitions. | 14:45 |
| *** jdillaman has joined #openstack-nova | 14:45 | |
| jianghuaw_ | bauzas, I think efried's opinion is that we shouldn't make inventory for VGPU_DISPLAY_HEAD as that's possible to be consumed automatically by requesting VGPU. | 14:46 |
| *** gbarros has quit IRC | 14:46 | |
| efried | jianghuaw_ Only if display heads are *only* consumed automatically by requesting VGPU | 14:46 |
| edleafe | jianghuaw_: if it can't be consumed independently, and is always consumed automatically, then it shouldn't be tracked as inventory. | 14:47 |
| efried | jianghuaw_ If it's possible to request them separately, then you need to inventory them separately; and then have extra logic in scenarios where it would happen automatically such that, if the flavor doesn't request the appropriate number of each, you throw an error. | 14:47 |
| bauzas | jianghuaw_: I agree with him | 14:47 |
| bauzas | jianghuaw_: until we have a way to track optional resources classes, we shouldn't be providing inventories for display heads IMHO | 14:48 |
| bauzas | and just do the display head consumption solely in the virt driver, if you can | 14:48 |
| bauzas | tbh, libvirt doesn't support that yet, so I don't give a bit of that :p | 14:48 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Refined fix for validating image on rebuild https://review.openstack.org/523427 | 14:49 |
| jianghuaw_ | bauzas, efried Ok. Agreed. I will drop that patch for inventoring display heads. | 14:50 |
| jianghuaw_ | Per my understand, the display heads will always be consumed automatically as long as the VGPUs supporting display heads. | 14:51 |
| *** salv-orlando has joined #openstack-nova | 14:51 | |
| *** brault has quit IRC | 14:51 | |
| jianghuaw_ | Actually different vGPU types may support different display heads. And users may need some vGPUs which support specified amount of display heads. That's why I said it seems somehow traits for the vGPUs. | 14:53 |
| efried | jianghuaw_ Yes, that sounds like it might be suitable for traits. | 14:54 |
| jianghuaw_ | efried, but jaypipes seems don't agree ^ :-) | 14:55 |
| *** brault has joined #openstack-nova | 14:55 | |
| bauzas | jianghuaw_: well, requesting a display head is not quantitative | 14:55 |
| efried | jianghuaw_ It depends whether it can be consumed independently, or is always tied to the VGPU. | 14:55 |
| efried | Which I'm still not clear on. | 14:55 |
| *** salv-orl_ has joined #openstack-nova | 14:56 | |
| jianghuaw_ | efried, yes, it's always tied to VGPU. | 14:56 |
| *** mlavalle has joined #openstack-nova | 14:56 | |
| efried | Okay. If it is *always* the case that requesting a specific VGPU results in a specific number (possibly zero) of display heads being consumed, then there's no reason to inventory separately. | 14:56 |
| efried | jianghuaw_ And how does the user specify which type of VGPU they're getting? | 14:57 |
| bauzas | by the trait | 14:58 |
| jianghuaw_ | yes, by traits. | 14:58 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Nits from Ic3ab7d60e4ac12b767fe70bef97b327545a86e74 https://review.openstack.org/523432 | 14:58 |
| bauzas | given we don't support traits yet, we only ask for the operator to provide *one* type | 14:58 |
| efried | So a given trait is in fact overloading more than one aspect of the VGPU's characteristics. | 14:58 |
| bauzas | well | 14:59 |
| efried | In other words, by saying I need a VGPU of type X, I'm also implicitly stating that I'm going to get two display heads (or whatever) | 14:59 |
| bauzas | that is a correct assumption to me | 14:59 |
| *** salv-orlando has quit IRC | 14:59 | |
| efried | Okay. Then if that correlation always holds true | 14:59 |
| *** yamamoto has joined #openstack-nova | 15:00 | |
| efried | that is, a given VGPU type always maps to a given number of display heads | 15:00 |
| jianghuaw_ | the plan is to associate traits like display_solutions; supported features after we support traits. | 15:00 |
| bauzas | efried: see the spec | 15:00 |
| bauzas | there are some examples | 15:00 |
| efried | then you shouldn't have inventory for the display heads. | 15:00 |
| bauzas | I agree | 15:00 |
| bauzas | if that's correlated | 15:00 |
| *** awaugama has joined #openstack-nova | 15:00 | |
| efried | And there's even no need for extra traits - though those could be included and it wouldn't hurt anything. | 15:01 |
| *** abhishekk has quit IRC | 15:01 | |
| bauzas | tbh, I haven't thought that much on that problem, since libvirt doesn't return the heads :p | 15:01 |
| bauzas | (yet) | 15:01 |
| jianghuaw_ | efried, the display heads is one factor can be used to determine a vGPU type. | 15:02 |
| efried | jianghuaw_ Ah, okay, if you want to be able to go in the other direction, then it makes sense. | 15:02 |
| *** hongbin has joined #openstack-nova | 15:02 | |
| efried | jianghuaw_ I can imagine that you don't want to be getting particular about VGPU types; rather, you want to be enumerating capabilities of each type, so that the scheduler could conceivably pick one of any number of types as long as they fit the capabilities you request. | 15:03 |
| mriedem | gibi: replied in https://review.openstack.org/#/c/523353/ and explained the issue | 15:03 |
| jianghuaw_ | But the possible value is a continuous number which makes it more like quantitative. | 15:03 |
| *** smatzek has joined #openstack-nova | 15:03 | |
| *** udesale has quit IRC | 15:03 | |
| gibi | mriedem: looking | 15:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/newton: Refined fix for validating image on rebuild https://review.openstack.org/523434 | 15:04 |
| mriedem | instance actions/events are mythical beasts | 15:04 |
| mriedem | easily broken | 15:04 |
| mriedem | rarely tested | 15:05 |
| *** damien_r has quit IRC | 15:05 | |
| jianghuaw_ | efried, yes. That's also the result of the discussion with jaypipes to use capabilities instead of specifying vGPU type. | 15:05 |
| efried | jianghuaw_ But a small number of discrete possible values | 15:05 |
| mriedem | dansmith: i've got those backports all up now https://review.openstack.org/#/q/I1a46ef1503be2febcd20f4594f44344d05525446 | 15:05 |
| efried | jianghuaw_ Like 1, 2, 4, 8 | 15:05 |
| jianghuaw_ | efried, indeed. | 15:05 |
| gibi | mriedem: thanks, I | 15:05 |
| gibi | mriedem: thanks, I'm +2 now | 15:05 |
| *** damien_r has joined #openstack-nova | 15:06 | |
| jianghuaw_ | efried, it looks like you agree with me to make it as traits. right? | 15:06 |
| efried | jianghuaw_ With the caveat that I don't fully understand the different ways you can request/configure these things, yes, I believe I agree. | 15:06 |
| mriedem | sdague: could use some review on https://review.openstack.org/#/c/521391/ which is a fix for a regression introduced by a recent cve fix, so it's going to have to be backported through to newton - there is a regression test patch underneath it | 15:07 |
| *** liusheng has quit IRC | 15:07 | |
| openstackgerrit | jiangpf proposed openstack/nova master: Encode libvirt domain XML in UTF-8 https://review.openstack.org/522161 | 15:07 |
| efried | jianghuaw_ A given VGPU type will only ever have *one* of the traits (e.g. SINGLE_DISPLAY_HEAD_CAPABLE, DUAL_DISPLAY_HEAD_CAPABLE, QUAD_DISPLAY_HEAD_CAPABLE) right? | 15:07 |
| mriedem | sdague: actually that regression test might be busted now, checking | 15:08 |
| jianghuaw_ | efried, at the moment I see the possible number is 1, 2, 4, 8 | 15:08 |
| efried | jianghuaw_ Okay; the question remains: a given VGPU type will *always* and *only* consume *one* of those numbers of display heads? | 15:09 |
| jianghuaw_ | correct. | 15:10 |
| *** marst has joined #openstack-nova | 15:10 | |
| efried | Then yes, I think it's appropriate *not* to inventory display heads separately, and I think it's okay to have those be traits. | 15:10 |
| *** yamamoto has quit IRC | 15:10 | |
| dansmith | mriedem: ack | 15:11 |
| efried | Now if I want a VGPU with four display heads, I request resources=VGPU:1&required=QUAD_DISPLAY_HEAD_CAPABLE | 15:11 |
| jianghuaw_ | efried, yeah. That's what I was thinking:-) | 15:11 |
| efried | jaypipes Does this seem sane to you ^^ | 15:12 |
| jaypipes | gimme a minute, folks. trying to finish rebasing n-r-p | 15:12 |
| jaypipes | ok, final tests running now... lemme read back, sorry | 15:13 |
| efried | jaypipes Summary: A given VGPU type will *always* have a certain number of display heads. So display heads as traits (SINGLE_DISPLAY_HEAD_CAPABLE, DUAL_DISPLAY_HEAD_CAPABLE, etc.) and a RP of VGPUs (presumably the pGPU) would only ever have one of those traits. | 15:13 |
| jianghuaw_ | efried, thanks for the summary. | 15:13 |
| jaypipes | efried: if the display head is *consumed* by a request, it needs to be a resource class, not a trait. | 15:14 |
| efried | jaypipes The issue is that the number of display heads are always correlated exactly with the VGPU type. | 15:15 |
| jianghuaw_ | jaypipes, the display heads will always be consumed automatically when requesting VGPU. | 15:15 |
| jaypipes | efried: I don't see any issue with that. (plus, I guarantee you nvidia and intel will end up changing that in the future. it's what they do. ALL THE TIME. | 15:15 |
| alex_xu | mriedem: yea, you are right, without 'migrate' key, it won't route to that action | 15:16 |
| *** mdnadeem has quit IRC | 15:16 | |
| bauzas | jaypipes: the problem here is that display heads are correlated by the number of VGPUs and their types | 15:16 |
| bauzas | oh man | 15:16 |
| jaypipes | bauzas: I don't see a problem? | 15:16 |
| jaypipes | bauzas: set the amount of VGPU and display head resources in the flavor correctly, no? | 15:16 |
| *** moshele has quit IRC | 15:16 | |
| bauzas | jaypipes: once we have traits, it's doable | 15:16 |
| jaypipes | bauzas: traits have nothing to do with this. | 15:17 |
| bauzas | jaypipes: for the moment, the user has no clue about which type he will get | 15:17 |
| alex_xu | efried: you mean you are working on the two testcases in this patch https://review.openstack.org/498737 ? | 15:17 |
| bauzas | hence how many heads he could get | 15:17 |
| efried | alex_xu Yes | 15:17 |
| jaypipes | bauzas: it's not the user. it's the deployer/admin that needs to set shit up. | 15:17 |
| alex_xu | efried: cool, thanks | 15:17 |
| efried | alex_xu The first one is ported over, and passing. Working on the second one... | 15:17 |
| bauzas | jaypipes: I don't disagree | 15:17 |
| bauzas | jaypipes: the operator provides which supported types the compute should provide | 15:18 |
| bauzas | so the VGPUs will depend on thaty | 15:18 |
| bauzas | and the heads | 15:18 |
| alex_xu | efried: I ported the first one on Monday, but interupt by other works... so nvm, thanks for porting those | 15:18 |
| bauzas | but then, if the user wants a specific GRID-K5000, then the operator will set the flavor with a trait | 15:19 |
| jaypipes | bauzas: correct. if the virt driver (Xen, libvirt, whatevs) wants to do some fancy-pants discovery on startup of nova-compute and ensure that inventory counts are proper for the types of GPUs found on the host, cool with me. But it's the deployer's responsibility to create flavors that make sense for these related resources. | 15:19 |
| bauzas | anyway, I need to go | 15:19 |
| bauzas | disappearing for 20 mins | 15:19 |
| bauzas | -ish | 15:20 |
| *** clayton has quit IRC | 15:20 | |
| jianghuaw_ | jaypipes, as the display heads are optional (we have to allow that as the vGPU may not support display heads). If the flavor has resources=VGPU:1; then placement may return resource providers which have display heads. In that case, the display heads are consumed automatically. | 15:20 |
| jianghuaw_ | That's the problem. | 15:20 |
| bauzas | jaypipes: one last thing, libvirt doesn't support display heads yet | 15:20 |
| bauzas | :p | 15:20 |
| efried | jaypipes Here's the counterexample: One pGPU provides VGPU types that always allocate four display heads, so it exposes inventory of VGPU:2,DISPLAY_HEAD:8. Some other pGPU always allocates two display heads, so it exposes inventory of VGPU:2,DISPLAY_HEAD:4. In my flavor, I request VGPU:1,DISPLAY_HEAD:2. Scheduler happily schedules me to that first one, and allocates usage of 2 display heads. But we actually consume four. | 15:20 |
| bauzas | (so I'm not fully on track with that) | 15:20 |
| jaypipes | jianghuaw_: no, nothing should be "consumed automatically". that's the problem. :) | 15:20 |
| dansmith | mriedem: are you not going to +2 this? https://review.openstack.org/#/c/521662/ | 15:21 |
| jianghuaw_ | jaypipes, agreed. but the problem is how to avoid that case. | 15:21 |
| *** artom has quit IRC | 15:21 | |
| *** clayton has joined #openstack-nova | 15:21 | |
| jaypipes | efried: that is what min_unit, max_unit, and step_size are for. | 15:21 |
| efried | Hum, yeah, I guess that would work. | 15:22 |
| efried | But | 15:22 |
| efried | We still have the problem of when I request VGPU:1 and no display heads. | 15:22 |
| jianghuaw_ | jaypipes, but how about if flavor only has resources=VGPU:1? | 15:22 |
| efried | jinx | 15:22 |
| jianghuaw_ | it doesn't request display heads. | 15:22 |
| efried | Scheduler will happily schedule me to either one of those guys above, and not create a usage for display heads, even though they got consumed. | 15:23 |
| jianghuaw_ | so it consumes a vGPU. But we know any consuming vGPU result also result the available display heads be reduced also. | 15:23 |
| efried | (Because there's another RP somewhere whose vGPUs don't have display heads, and that's where I meant to go.) | 15:23 |
| jianghuaw_ | efried, ack | 15:24 |
| efried | (Or actually I didn't care whether I went there or not; but if I got onto the display-heads-havin' RPs, I have to consume its display heads) | 15:24 |
| *** artom has joined #openstack-nova | 15:25 | |
| jaypipes | jianghuaw_, efried: this is the same problem that stephenfin and snikitin's "PCI affinity scheduling policies" thing is about... | 15:25 |
| *** gbarros has joined #openstack-nova | 15:25 | |
| jianghuaw_ | jaypipes, is there solution for that problem already? | 15:26 |
| stephenfin | pretty much, yeah | 15:26 |
| jaypipes | jianghuaw_, efried: I think in that scenario, I would just say the flavor must always request a display head, regardless of if the user ends up using one. | 15:26 |
| openstackgerrit | Merged openstack/nova master: Update document related to host aggregate https://review.openstack.org/514499 | 15:26 |
| efried | jaypipes That would make it impossible to use vGPUs that don't have display heads. | 15:26 |
| stephenfin | jianghuaw_: https://review.openstack.org/#/c/390520/ | 15:27 |
| jaypipes | jianghuaw_: the "solution" is very specific to PCI, involves (yet another) configuration option/metadata key/value pair, and generally is going to make long-term porting of the PCIPassthroughFilter impossible. but yeah... | 15:27 |
| jianghuaw_ | jaypipes, so making display heads as mandatory as long as it request vGPU? | 15:27 |
| jaypipes | jianghuaw_: IFF the compute hosts' pGPUs do not have the ability to only serve up a vGPU without a display head. | 15:27 |
| jianghuaw_ | stephenfin, jaypipes thanks. looking at the patch. | 15:27 |
| *** gbarros has quit IRC | 15:28 | |
| artom | mriedem, oh, you've proposed the upstream rebuild CVE backports, thanks :) | 15:28 |
| *** jmlowe has joined #openstack-nova | 15:28 | |
| *** janki has joined #openstack-nova | 15:28 | |
| *** gbarros has joined #openstack-nova | 15:29 | |
| jianghuaw_ | jaypipes, but we do have cases where vGPUs don't support a display head. which means no inventory for display heads. | 15:29 |
| jaypipes | jianghuaw_: bottom line for me on this is that I do not think this use case is particularly high priority, and given that there is a solution of "just have the flavor always request a display head (or >1 display head) if the underlying hardware always requires a display head, I don't want to add in any sort of trait hack here. | 15:29 |
| *** jmlowe has quit IRC | 15:30 | |
| openstackgerrit | Merged openstack/nova master: Add instance action record for attach/detach/swap volumes https://review.openstack.org/517205 | 15:32 |
| jaypipes | jianghuaw_: in that scenario, what about just attaching a custom trait CUSTOM_NO_DISPLAY_HEAD to the flavor that doesn't want a display head and attach the same trait to the resource providers representing those pGPUs? | 15:32 |
| jaypipes | jianghuaw_: that way, we're not using any standard traits for things that are quantitative and you can still have the scheduler and placement service do what they're good at without any additional hacks. | 15:32 |
| jaypipes | jianghuaw_: in that way, all the requests for vGPU with no need for display head support will go to those hosts and all other requests for vGPUs *with* display head support will go to the other hosts that have inventory of both VGPU and VGPU_DISPLAY_HEAD | 15:34 |
| jianghuaw_ | jaypipes, hmmm. It should work. | 15:34 |
| *** sapd__ has quit IRC | 15:34 | |
| *** sapd_ has joined #openstack-nova | 15:34 | |
| jaypipes | jianghuaw_: I'm fine using custom traits for something like that. it's just that I am strongly against using standard traits for things that are, in essence, quantities of some class of resource (like the proposed SINGLE_DISPLAY_HEAD_CAPABLE thing above) | 15:34 |
| jianghuaw_ | jaypipes, another option is to making display head default as 1. If there is no display heads return from hypervisor. | 15:35 |
| jaypipes | jianghuaw_: you mean "fake out" the inventory counts for VGPU_DISPLAY_HEADS for these hosts? | 15:35 |
| jianghuaw_ | jaypipes, yes. | 15:36 |
| jaypipes | jianghuaw_: nah, I'd prefer not to do that. otherwise, we'll go down the route of cdent and his "infinite inventories" :P | 15:36 |
| * cdent shakes tiny fist | 15:37 | |
| jianghuaw_ | jaypipes, ok. Let's forget it:-) | 15:37 |
| cdent | all my best ideas, like sands in the hourglass | 15:37 |
| jaypipes | hehe | 15:38 |
| *** gbarros has quit IRC | 15:38 | |
| jaypipes | jianghuaw_: no, in all seriousness, I think the custom trait CUSTOM_NO_DISPLAY_HEAD is the right approach to solve that remaining use case. | 15:38 |
| *** slaweq has joined #openstack-nova | 15:38 | |
| *** gbarros has joined #openstack-nova | 15:39 | |
| jianghuaw_ | jaypipes, I think the above approaching by using custom traits actually strongly depends on the administrators to do right thing to set the flavors. I means it make break thing if someone wrongly created a flavor only request VGPU and don't have CUSTOM_NO_DISPLAY_HEAD. | 15:40 |
| *** suresh12 has joined #openstack-nova | 15:41 | |
| jaypipes | jianghuaw_: that's a tradeoff I'm willing to make. | 15:41 |
| jianghuaw_ | jaypipes, got it. So we should record that in the document. | 15:42 |
| *** slaweq has quit IRC | 15:43 | |
| jianghuaw_ | let's go with that approach. | 15:43 |
| jaypipes | jianghuaw_: yeah. I think a "how to use vGPUs with OpenStack" article/tutorial/reference would be extremely useful. | 15:43 |
| *** dklyle has joined #openstack-nova | 15:43 | |
| jianghuaw_ | jaypipes, thanks very much.j | 15:43 |
| jaypipes | jianghuaw_: any time :) | 15:43 |
| *** yamahata__ has joined #openstack-nova | 15:44 | |
| jianghuaw_ | efried, bauzas: thank you also for the discussion and advices. | 15:44 |
| efried | jianghuaw_ Cool, good luck. | 15:45 |
| *** gouthamr has joined #openstack-nova | 15:45 | |
| *** suresh12 has quit IRC | 15:45 | |
| *** isq_ has quit IRC | 15:45 | |
| *** slaweq has joined #openstack-nova | 15:45 | |
| openstackgerrit | Merged openstack/nova master: Don't overwrite binding-profile https://review.openstack.org/519066 | 15:45 |
| jianghuaw_ | efried, :-) | 15:46 |
| efried | alex_xu FYI, both of those tests pass on top of the stack; and I don't think we actually have other tests that match them exactly; and even if we did, I'm not opposed to having some duplication there. | 15:46 |
| *** yamamoto has joined #openstack-nova | 15:46 | |
| efried | alex_xu Not sure exactly how/where to propose the code, though. | 15:46 |
| *** ijw has joined #openstack-nova | 15:46 | |
| *** david-lyle has quit IRC | 15:46 | |
| efried | alex_xu I guess we should propose the code under https://review.openstack.org/#/c/498737/ and abandon https://review.openstack.org/#/c/480379/ | 15:48 |
| efried | alex_xu But I'm not sure which patch to declare as having fixed bug #1731072 | 15:49 |
| openstack | bug 1731072 in OpenStack Compute (nova) "AllocationCandidates.get_by_filters returns garbage with multiple aggregates" [Medium,Confirmed] https://launchpad.net/bugs/1731072 | 15:49 |
| efried | oh, I guess that bug isn't fully fixed anyway, so we can just leave that alone. | 15:49 |
| efried | Okay, I've answered all my questions :) | 15:49 |
| *** nicolasbock has joined #openstack-nova | 15:49 | |
| efried | jaypipes mriedem FYI ^^ | 15:49 |
| *** slaweq has quit IRC | 15:50 | |
| efried | Dangit, wrong bug. Should have been bug #1702420 -- which is indeed fixed now. | 15:50 |
| openstack | bug 1702420 in OpenStack Compute (nova) "The AllocationCandidates.get_by_filters returned wrong combination of AllocationRequests" [High,In progress] https://launchpad.net/bugs/1702420 - Assigned to Alex Xu (xuhj) | 15:50 |
| *** ijw has quit IRC | 15:50 | |
| jaypipes | efried: now as in now or now as in "will be shortly once some patch is merged"? | 15:51 |
| jianghuaw_ | bauzas, Please check the above discussion after you come back. Hope you also agree with the approach: 1. always requesting display heads for VGPUs which have display heads; 2. use custom traits e.g. CUSTOM_NO_DISPLAY_HEAD for those cases where display head is not supported. | 15:51 |
| efried | jaypipes The latter. I'm rebasing https://review.openstack.org/#/c/498737/ on top of the series formerly known as The Big Refactor. | 15:52 |
| *** yamamoto has quit IRC | 15:52 | |
| *** gbarros has quit IRC | 15:52 | |
| jianghuaw_ | bauzas, and don't forget to review my vGPU patches. Thanks:-) | 15:52 |
| jaypipes | efried: gotcha. | 15:52 |
| jaypipes | efried: I'm focused on n-r-p right now. | 15:52 |
| efried | jaypipes Oh, actually, since the refactors are merged at this point, it may be fixed at master. I can check that quick... | 15:53 |
| *** gbarros has joined #openstack-nova | 15:53 | |
| *** masuberu has joined #openstack-nova | 16:01 | |
| *** lyan has quit IRC | 16:01 | |
| *** lyan has joined #openstack-nova | 16:02 | |
| *** rmart04 has quit IRC | 16:04 | |
| *** masber has quit IRC | 16:05 | |
| efried | jaypipes Well, my port relies on some of the test helpers, so for that reason alone it won't work until later in the series. IMO not worth the trouble of retrofitting the tests to pre-helper and then having to rebase. | 16:05 |
| *** maciejjozefczyk has joined #openstack-nova | 16:05 | |
| jaypipes | efried: ack | 16:05 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: func tests for multiple shared RPs https://review.openstack.org/498737 | 16:06 |
| efried | jaypipes alex_xu ^ | 16:06 |
| *** lpetrut has quit IRC | 16:06 | |
| *** lpetrut has joined #openstack-nova | 16:06 | |
| *** sbezverk has joined #openstack-nova | 16:07 | |
| efried | alex_xu FYI I closed https://bugs.launchpad.net/nova/+bug/1702420 | 16:07 |
| openstack | Launchpad bug 1702420 in OpenStack Compute (nova) "The AllocationCandidates.get_by_filters returned wrong combination of AllocationRequests" [High,Fix released] - Assigned to Alex Xu (xuhj) | 16:07 |
| *** masuberu has quit IRC | 16:08 | |
| *** masuberu has joined #openstack-nova | 16:08 | |
| *** imacdonn has joined #openstack-nova | 16:11 | |
| *** eharney has joined #openstack-nova | 16:14 | |
| *** josecastroleon has quit IRC | 16:15 | |
| *** shaner has quit IRC | 16:16 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate instance.create notification samples https://review.openstack.org/523456 | 16:19 |
| *** tidwellr has joined #openstack-nova | 16:23 | |
| *** vladikr has quit IRC | 16:24 | |
| *** lpetrut has quit IRC | 16:28 | |
| *** gbarros has quit IRC | 16:28 | |
| *** salv-orlando has joined #openstack-nova | 16:28 | |
| *** salv-orl_ has quit IRC | 16:31 | |
| *** shaner has joined #openstack-nova | 16:31 | |
| *** yamamoto has joined #openstack-nova | 16:31 | |
| *** tidwellr has quit IRC | 16:32 | |
| *** tidwellr has joined #openstack-nova | 16:35 | |
| *** Oku_OS is now known as Oku_OS-away | 16:35 | |
| *** yamamoto has quit IRC | 16:36 | |
| *** jmlowe has joined #openstack-nova | 16:38 | |
| Anticimex | hello, operator here | 16:40 |
| Anticimex | was there ever progress on https://specs.openstack.org/openstack/nova-specs/specs/mitaka/approved/detach-boot-volume.html since M? | 16:40 |
| Anticimex | we just ran into that as a little nasty bug that made us sad | 16:40 |
| cdent | mriedem: is there a reasonable way to do a test for this or is tempest sufficient? tempest happily blows up when it is wrong (see previous patchsets in the series): https://review.openstack.org/#/c/523403/ | 16:41 |
| *** salv-orlando has quit IRC | 16:42 | |
| *** salv-orlando has joined #openstack-nova | 16:42 | |
| *** lpetrut has joined #openstack-nova | 16:43 | |
| *** slaweq has joined #openstack-nova | 16:43 | |
| jaypipes | Anticimex: what precisely is the use case for attaching/detaching a boot volume? I've read that spec and each use case just describes a poorly-architected legacy application that relies on the infrastructure to do all of its disaster recovery, backup, and HA. | 16:45 |
| *** slaweq_ has joined #openstack-nova | 16:45 | |
| *** salv-orlando has quit IRC | 16:46 | |
| *** kenperkins has joined #openstack-nova | 16:47 | |
| *** slaweq has quit IRC | 16:48 | |
| *** AlexeyAbashkin has quit IRC | 16:49 | |
| *** suresh12 has joined #openstack-nova | 16:52 | |
| mriedem | cdent: i'm lost re https://review.openstack.org/#/c/523403/ | 16:55 |
| mriedem | which other patch in the series? | 16:55 |
| cdent | sorry, not series, same change: ps1 and p2 have failures (but I may have knocked them out before they got a chance to report) | 16:56 |
| *** chyka has joined #openstack-nova | 16:56 | |
| cdent | mriedem: my words are a bit broken today, too many of them | 16:56 |
| cdent | mriedem: the short form of my question is: since that didn’t have test coverage (besides tempest) before, is it okay without additional tests? | 16:57 |
| *** damien_r has quit IRC | 16:59 | |
| mriedem | might not be bad to have a simple test that mocks out filter_factory and uses autospec to make sure what we're passing to that method is actually in the library | 16:59 |
| *** damien_r has joined #openstack-nova | 16:59 | |
| efried | jaypipes Series starting at https://review.openstack.org/#/c/517119/ needs a rebase. Want me to hit it? Or mebbe we wait until some more stuff merges? | 17:00 |
| jaypipes | efried: wait on that. | 17:00 |
| efried | jaypipes K. Need to address gibi's -1 too. | 17:00 |
| jaypipes | efried: yeah. | 17:01 |
| jaypipes | efried: still running tests on the n-r-p series... and I'll need to rebase and bump the microversion yet again once cdent's latest patch merges. | 17:01 |
| efried | jaypipes Right. Is there anywhere I can actually be useful at this point? | 17:01 |
| jaypipes | efried: can you bake cookies (chocolate chip) and send them my way? :) | 17:02 |
| jaypipes | efried: no, in all seriousness, reviewing edleafe's series on alternate hosts if you haven't yet will be good. | 17:02 |
| efried | jaypipes Sorry, my wife is the baker. She's out til late tonight. I make a mean curry, though. | 17:03 |
| efried | jaypipes Okay, I've been deliberately avoiding that one for lack of context, but I guess I'll have to dig in at some point. | 17:03 |
| jaypipes | efried: ooh, I love curry. | 17:03 |
| jaypipes | efried: doesn't ship well, though. | 17:03 |
| Anticimex | jaypipes: resize boot volume, ie make it larger | 17:03 |
| jaypipes | efried: also ask dansmith to point you at patches he'd like reeviewed. | 17:04 |
| *** ragiman has quit IRC | 17:04 | |
| efried | dansmith ^ | 17:04 |
| dansmith | we're waiting on me for all my patches currently I think | 17:04 |
| jaypipes | Anticimex: just stop the instance, resize the volume, and boot. | 17:04 |
| *** liusheng has joined #openstack-nova | 17:04 | |
| efried | k, just let me know. | 17:04 |
| edleafe | jaypipes: will have patch addressing your concerns on https://review.openstack.org/#/c/510159/ soon | 17:04 |
| Anticimex | jaypipes: can't while it's attached | 17:05 |
| Anticimex | .oO though that may have been fixed in ocata or something for ceph iirc | 17:05 |
| jaypipes | Anticimex: stop the instance, resize the volume, and start the instance. | 17:05 |
| jaypipes | edleafe: coo, thanks man | 17:05 |
| jaypipes | Anticimex: terminate the instance, not stop it. | 17:06 |
| jaypipes | Anticimex: I mean, if it's boot from volume, you're not losing anything. | 17:06 |
| mriedem | you can resize an attached volume starting in pike | 17:06 |
| mriedem | for libvirt + iscsi/fc | 17:06 |
| Anticimex | jaypipes: no only cumbersome to retype all things, but that's indeed the workaround | 17:06 |
| jaypipes | Anticimex: unless of course, it's a legacy application that relies on a) IP addresses not changing, b) infrastructure for doing disaster recovery, c) infrastructure for doing HA, etc | 17:07 |
| Anticimex | but resize while attached (& stopped) is ok here | 17:07 |
| mriedem | https://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/nova-support-attached-volume-extend.html | 17:07 |
| jaypipes | mriedem: bfv though? | 17:07 |
| mriedem | jaypipes: not sure about bfv | 17:07 |
| Anticimex | mriedem: ack | 17:07 |
| jaypipes | right... it's always the problem with bfv :) | 17:07 |
| mriedem | the tempest test is not bfv | 17:07 |
| cdent | efried: I’d totally dig on some curry please | 17:08 |
| *** moshele has joined #openstack-nova | 17:08 | |
| * efried starts a list | 17:08 | |
| *** sahid has quit IRC | 17:09 | |
| *** ijw has joined #openstack-nova | 17:09 | |
| Anticimex | jaypipes: it is however legacy workload indeed | 17:10 |
| *** penick has joined #openstack-nova | 17:10 | |
| Anticimex | but that wasn't the problem, the problem was the workflow for the resize (grow). but if this works in pike or queens if i got mriedem right, i guess that's always something | 17:11 |
| jaypipes | Anticimex: by legacy, I'm referring to an application that doesn't have the ability to separate its application state from the persistent user data. In other words, an application that can be inserted in an image/ephemeral boot disk and have its user data written to a persistent volume. | 17:11 |
| *** moshele has quit IRC | 17:12 | |
| Anticimex | yeah, it's not capable of that | 17:12 |
| jaypipes | Anticimex: I'd try it out if you can. Hopefully that would be a workaround solution until you can convince the application authors to provide a way to configure data to be written to a filesystem/DB separate from the boot partition. | 17:13 |
| jaypipes | Anticimex: i.e. not on C:\ in a Windows image. ;) | 17:13 |
| Anticimex | it would be nice yeah but not really applicable | 17:13 |
| Anticimex | since it is a ton of C:'s coming in from a customers deprecated local dc | 17:14 |
| Anticimex | :) | 17:14 |
| jaypipes | ya | 17:14 |
| jaypipes | I hear ya. | 17:14 |
| Anticimex | "we'll make it work" | 17:14 |
| jaypipes | :) said the sales guy. | 17:14 |
| Anticimex | just have those +2 coming ;-) | 17:14 |
| Anticimex | hehe yeah | 17:14 |
| jaypipes | :) | 17:14 |
| Anticimex | thx jay, afk | 17:14 |
| jaypipes | ciao | 17:15 |
| *** jmlowe has quit IRC | 17:15 | |
| *** yamamoto has joined #openstack-nova | 17:16 | |
| *** shaner has quit IRC | 17:19 | |
| *** suresh12 has quit IRC | 17:20 | |
| *** cdent has quit IRC | 17:20 | |
| *** shaner has joined #openstack-nova | 17:21 | |
| *** cdent has joined #openstack-nova | 17:21 | |
| *** yamamoto has quit IRC | 17:21 | |
| *** suresh12 has joined #openstack-nova | 17:21 | |
| *** gbarros has joined #openstack-nova | 17:25 | |
| *** suresh12 has quit IRC | 17:26 | |
| *** tidwellr has quit IRC | 17:29 | |
| *** damien_r has quit IRC | 17:34 | |
| *** Alex_Staf has quit IRC | 17:37 | |
| *** Apoorva has joined #openstack-nova | 17:40 | |
| *** Apoorva has quit IRC | 17:40 | |
| *** Apoorva has joined #openstack-nova | 17:41 | |
| *** gbarros has quit IRC | 17:41 | |
| *** fragatina has quit IRC | 17:43 | |
| *** tidwellr has joined #openstack-nova | 17:43 | |
| *** gbarros has joined #openstack-nova | 17:44 | |
| *** lpetrut has quit IRC | 17:45 | |
| *** yamahata has quit IRC | 17:47 | |
| *** pprokop has joined #openstack-nova | 17:49 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add regression test for rebuilding a volume-backed server https://review.openstack.org/521200 | 17:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Get original image_id from volume for volume-backed instance rebuild https://review.openstack.org/521391 | 17:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fail fast if changing image on a volume-backed server rebuild https://review.openstack.org/520660 | 17:50 |
| mriedem | dansmith: i had to update the regression test at the bottom of this series because of the new RUN_ON_REBUILD=False for the ComputeFilter ^ using the super fun IsolatedHostsFilter now | 17:50 |
| *** dtantsur is now known as dtantsur|afk | 17:50 | |
| *** sambetts is now known as sambetts|afk | 17:50 | |
| mriedem | the bottom 2 changes in that series are linked to https://review.openstack.org/#/c/521186/ | 17:50 |
| mriedem | linked in that the cve fix introduced that regression | 17:51 |
| *** burt has joined #openstack-nova | 17:51 | |
| mriedem | Kevin_Zheng: did i answer your -1 on https://review.openstack.org/#/c/520660/ ? | 17:51 |
| *** burt is now known as Guest94580 | 17:51 | |
| mriedem | melwitt: i think this simple ironic bp patch is ready to go https://review.openstack.org/#/c/503088/ | 17:51 |
| *** Guest94580 has quit IRC | 17:52 | |
| mriedem | sdague: this is an easy one for the ksa adapter stuff https://review.openstack.org/#/c/507693/ | 17:52 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239 | 17:52 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Refactor the code to check for sufficient hosts https://review.openstack.org/520242 | 17:52 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854 | 17:52 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Modify select_destinations() to return objects and alts https://review.openstack.org/510159 | 17:52 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/516707 | 17:52 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357 | 17:52 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358 | 17:52 |
| melwitt | mriedem: ack, will look | 17:52 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Move the to_dict() method to the Selection object https://review.openstack.org/523492 | 17:52 |
| mriedem | melwitt: it'd also be good if you could help review ed's alternate hosts series above | 17:52 |
| mriedem | since that's related to cells v2 stuff | 17:52 |
| melwitt | sure thing | 17:53 |
| mriedem | thanks | 17:53 |
| *** pcaruana has quit IRC | 17:53 | |
| *** moshele has joined #openstack-nova | 17:55 | |
| *** thorst has quit IRC | 17:57 | |
| *** thorst has joined #openstack-nova | 17:58 | |
| *** jamesdenton has joined #openstack-nova | 18:00 | |
| *** moshele has quit IRC | 18:01 | |
| *** yamamoto has joined #openstack-nova | 18:01 | |
| *** josecastroleon has joined #openstack-nova | 18:02 | |
| *** thorst has quit IRC | 18:02 | |
| *** derekh has quit IRC | 18:04 | |
| *** jmlowe has joined #openstack-nova | 18:05 | |
| *** yamamoto has quit IRC | 18:06 | |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Move the to_dict() method to the Selection object https://review.openstack.org/523492 | 18:06 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Modify select_destinations() to return objects and alts https://review.openstack.org/510159 | 18:06 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/516707 | 18:06 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357 | 18:06 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358 | 18:06 |
| *** Swami has joined #openstack-nova | 18:09 | |
| *** thorst has joined #openstack-nova | 18:10 | |
| *** suresh12 has joined #openstack-nova | 18:11 | |
| *** ralonsoh has quit IRC | 18:11 | |
| *** gbarros has quit IRC | 18:11 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix NoneType error when [service_user] is misconfigured https://review.openstack.org/521947 | 18:13 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix NoneType error when [service_user] is misconfigured https://review.openstack.org/521947 | 18:14 |
| efried | ah, seriously? | 18:14 |
| *** thorst has quit IRC | 18:14 | |
| efried | mriedem ^ | 18:14 |
| mriedem | we are sympatico | 18:16 |
| efried | mriedem Want me to unwind mine? | 18:16 |
| mriedem | sure | 18:16 |
| jaypipes | efried: FYI, still running tests on the n-r-p series after rebasing. (had to run tests for all 12 patches separately of course...) | 18:16 |
| efried | jaypipes Of course. | 18:16 |
| *** yamamoto has joined #openstack-nova | 18:18 | |
| *** yamamoto has quit IRC | 18:18 | |
| *** fragatina has joined #openstack-nova | 18:19 | |
| efried | mriedem Is there an easy way to revert to a prior patch set? | 18:20 |
| jaypipes | efried: rm -rf / | 18:20 |
| jaypipes | :P | 18:21 |
| *** gbarros has joined #openstack-nova | 18:21 | |
| mriedem | efried: not sure of an easy way | 18:21 |
| clarkb | efried: git review -d 123456,2 && git commit --amend # make some change to the commit message because gerrit (though new gerrit may not have this restriction any longer) && git review | 18:22 |
| efried | clarkb Cool, thanks. | 18:22 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix NoneType error when [service_user] is misconfigured https://review.openstack.org/521947 | 18:22 |
| clarkb | gerrit in the past has refused to accept old identical patchsets, I think ti may not refuse those anymore so you don't need to make changes but I haven't tested it | 18:22 |
| melwitt | cool, I learned a thing. I wondered if there was a way to pull a specific rev using git review -d | 18:22 |
| efried | clarkb No, it did refuse. | 18:22 |
| *** yamahata has joined #openstack-nova | 18:23 | |
| efried | Trivial change to the commit message worked. Thanks for that. | 18:23 |
| *** lucasagomes is now known as lucas-afk | 18:23 | |
| efried | mriedem done, sorry about that. | 18:23 |
| *** jmlowe has quit IRC | 18:25 | |
| *** penick has quit IRC | 18:25 | |
| *** liverpooler has quit IRC | 18:25 | |
| mriedem | np | 18:27 |
| *** stvnoyes has quit IRC | 18:27 | |
| *** liverpooler has joined #openstack-nova | 18:28 | |
| *** jmlowe has joined #openstack-nova | 18:28 | |
| melwitt | mriedem: if we have a change that introduces a new config option but it's not useful until patch 3 in the series, is it okay to delay the reno until patch 3? example: https://review.openstack.org/#/c/345397/26/nova/conf/vnc.py | 18:30 |
| melwitt | I'm thinking that makes sense (to reno the conf option when the feature represented in the series fully lands) | 18:34 |
| *** penick has joined #openstack-nova | 18:34 | |
| *** thorst has joined #openstack-nova | 18:34 | |
| *** moshele has joined #openstack-nova | 18:35 | |
| *** stvnoyes has joined #openstack-nova | 18:35 | |
| *** AlexeyAbashkin has joined #openstack-nova | 18:35 | |
| *** josecastroleon has quit IRC | 18:36 | |
| *** thorst has quit IRC | 18:37 | |
| *** thorst has joined #openstack-nova | 18:38 | |
| *** AlexeyAbashkin has quit IRC | 18:40 | |
| *** adisky_ has quit IRC | 18:43 | |
| melwitt | would anyone be willing to review this libvirt driver bug fix to save the guest XML after a volume update? has one +2 https://review.openstack.org/#/c/498983 | 18:46 |
| zigo | melwitt: Hi ! I believe I know how to write the fix for my O_DIRECT issue! :) | 18:47 |
| zigo | melwitt: There's even a facility in nova to actually test for O_DIRECT support, but it's simply not used ... :P | 18:48 |
| melwitt | zigo: I've seen the test for O_DIRECT support in the driver but wasn't sure how to apply it in the fail case you hit. if you could propose a patch, that would be sweet | 18:49 |
| zigo | Please let me write it, that'd be my first patch in Nova, and that will make me very proud !!! :) | 18:49 |
| melwitt | zigo: yup, have at it. ping me whenever you post it and I'll review it | 18:49 |
| zigo | Cheers. | 18:49 |
| * zigo is cloning the tree, and it's taking forever with my slow far away mountains ADSL... | 18:50 | |
| *** penick has quit IRC | 18:52 | |
| *** suresh12 has quit IRC | 18:53 | |
| *** suresh12 has joined #openstack-nova | 18:54 | |
| *** AlexeyAbashkin has joined #openstack-nova | 18:56 | |
| openstackgerrit | Merged openstack/nova master: Implement query param schema for sec group APIs https://review.openstack.org/521353 | 18:56 |
| openstackgerrit | Merged openstack/nova master: Add instance action record for lock/unlock instances https://review.openstack.org/523353 | 18:57 |
| openstackgerrit | Merged openstack/nova master: Add regression test for rebuild with new image doubling allocations https://review.openstack.org/521153 | 18:57 |
| mriedem | melwitt: if the config option isn't used until later in the series, why isn't it just introduced later in the series, when it's used? | 18:57 |
| *** cdent has quit IRC | 18:57 | |
| melwitt | mriedem: I think it's because in the series, patch 1 adds a base class (that uses the config option to iterate through choices), patch 2 adds one auth implementation, patch 3 adds another (and the final) auth implementation, each of which is one of the config option choices | 18:59 |
| zigo | melwitt: How can I import nova.virt.libvirt.driver.LibvirtDriver.disk_cachemode() ? It's not ok to just import it as it's a driver, right? | 19:00 |
| mriedem | sdague: you might have input here https://bugs.launchpad.net/nova/+bug/1734698 | 19:00 |
| openstack | Launchpad bug 1734698 in OpenStack Compute (nova) "Squash database patches" [Undecided,Invalid] | 19:00 |
| *** penick has joined #openstack-nova | 19:01 | |
| *** moshele has quit IRC | 19:01 | |
| melwitt | mriedem: er, sorry, patch 2 adds an impl, patch 3 does something else. let me look deeper into this first | 19:01 |
| openstackgerrit | Merged openstack/nova master: [placement] POST /allocations to set allocations for >1 consumers https://review.openstack.org/500073 | 19:01 |
| openstackgerrit | Merged openstack/nova master: [placement] Fix GET PUT /allocations nits https://review.openstack.org/523401 | 19:01 |
| melwitt | zigo: where do you want to import it? just thinking ahead on whether it might need to be moved to utils to do what you want to do | 19:03 |
| *** AlexeyAbashkin has quit IRC | 19:04 | |
| melwitt | because we don't want to import any driver stuff into imagebackend or images | 19:05 |
| efried | jaypipes Here's a scenario: One or more sharing RPs (MISC_SHARES_VIA_AGGREGATE) in an aggregate. But that aggregate does *not* contain any non-sharing RPs. Would it be correct to say that we should *never* get allocation candidates including any RP in that aggregate? | 19:05 |
| *** janki has quit IRC | 19:05 | |
| zigo | melwitt: In nova/virt/images.py there's def _convert_image(source, dest, in_format, out_format, run_as_root):. There, there is cmd = ('qemu-img', 'convert', '-t', 'none', '-O', out_format). | 19:08 |
| zigo | 'none' needs to be replaced by a call to that function. | 19:08 |
| openstackgerrit | Merged openstack/nova master: [placement] Clean up TODOs in allocations.yaml gabbit https://review.openstack.org/513057 | 19:09 |
| openstackgerrit | Merged openstack/nova master: Update the documentation links https://review.openstack.org/523288 | 19:09 |
| jaypipes | efried: wouldn't it depend on the request? I mean, if the request is only for resources that are being shared by those providers, then why wouldn't those providers be returned in allocation candidates? (note: the scheduler would throw those providers away since they wouldn't match a compute node UUID, but that's not the point, right?) | 19:10 |
| efried | jaypipes That's indeed not the point. Hum, I guess it's legit... | 19:11 |
| melwitt | zigo: ah, gotcha. hmm ... yeah, so virt/images.py is not *supposed* to be libvirt-specific but it obviously is. and as you can tell from the layout, we've got separation between the driver and image related code. so we wouldn't want to import from the libvirt driver there. so I'm thinking what's the least ugly way we could do this ... | 19:12 |
| efried | jaypipes Is _get_all_with_shared supposed to return only non-sharing RPs? | 19:12 |
| jaypipes | efried: it was supposed to, yeah. but alex_xu (and you, right?) pointed out that wasn't actually the case. | 19:13 |
| *** rtjure has joined #openstack-nova | 19:13 | |
| jaypipes | efried: and upon further thought, decided to leave it as it was, returning both sharing and non-sharing. | 19:13 |
| *** sridharg has quit IRC | 19:13 | |
| jaypipes | efried: and leave it up to callers to choose to ignore sharing-only allocation requests. | 19:13 |
| efried | jaypipes Hell, I don't know anymore. | 19:15 |
| mriedem | dansmith: this is a fun bug https://bugs.launchpad.net/nova/+bug/1734504 | 19:15 |
| openstack | Launchpad bug 1734504 in OpenStack Compute (nova) "User can't know which flavor used for resize by the result of "nova migration-list"" [Low,Triaged] | 19:15 |
| dansmith | hmm, doesn't look fun | 19:16 |
| mriedem | apparently we leak internal flavor primary keys out of the os-migrations REST API | 19:16 |
| mriedem | which, whatever, we leak them out, big whoop, but they have no meaning at all to an end user since they aren't the flavorid | 19:16 |
| mriedem | good times | 19:16 |
| mriedem | and the columns on the migrations table that stores those ids is an integer column so we can't store string flavorid in there anyway :) | 19:17 |
| efried | jaypipes Is there any meaning to MISC_SHARES_VIA_AGGREGATE if that's the case? | 19:17 |
| *** salv-orlando has joined #openstack-nova | 19:17 | |
| efried | jaypipes What semantic does it provide beyond just being associated with a given aggregate? | 19:17 |
| jaypipes | efried: it says "I share my inventory with any provider in any aggregate I'm associated with" | 19:18 |
| *** yamamoto has joined #openstack-nova | 19:18 | |
| *** rtjure has quit IRC | 19:18 | |
| mriedem | as far as i can tell, there is no reason that we even store the flavor.id on the migration record *except* to return it out of the API | 19:18 |
| mriedem | nothing else in the code depends on it | 19:19 |
| dansmith | "no reason to store it other than to return the wrong thing out of the API" <-- FTFY | 19:19 |
| mriedem | yes correct | 19:19 |
| dansmith | \o/ | 19:19 |
| melwitt | zigo: okay, after looking through the code, what I'll guess is a decent way to try first is, move the static _supports_direct_io function into nova/utils.py and make it public, then call that in both the libvirt driver and virt/images.py to find out how to set cachemode | 19:20 |
| *** claudiub|2 has quit IRC | 19:20 | |
| efried | jaypipes Are we allowed to have more than one non-MISC_SHARES_VIA_AGGREGATE in a given aggregate? I mean, nothing stops us from doing that; but what does it mean? | 19:20 |
| melwitt | because AFAICT, the test for direct io support is just a linux thing, not specific to libvirt | 19:20 |
| jaypipes | efried: aggregates don't have traits. only providers have traits. | 19:22 |
| jaypipes | efried: aggregates are simply groups of providers, nothing more. | 19:22 |
| efried | jaypipes I understand that. Rephrase: Are we allowed to have more than one RP without the MISC_SHARES_VIA_AGGREGATE trait in a given aggregate? I mean, nothing stops us from doing that; but what does it mean? | 19:23 |
| jaypipes | efried: are you asking whether it's allowed to have >1 provider sharing the same resource class to other providers in its aggregates? | 19:23 |
| efried | no | 19:23 |
| efried | jaypipes In today's terms: Am I allowed to have more than one "compute node" in the same aggregate? | 19:23 |
| jaypipes | efried: *most* providers in an aggregate will *not* have the MISC_SHARES_VIA_AGGREGATE trait. | 19:23 |
| jaypipes | efried: for instance, compute node providers won't (typically) have that trait. | 19:24 |
| mriedem | how bad would an alter table be on the migrations table to change old/new_instance_type from an integer to a varchar(64)? | 19:24 |
| jaypipes | efried: yes, it's totally expected to have >1 compute node in an aggregate | 19:24 |
| mriedem | with say 100k entries | 19:24 |
| jaypipes | mriedem: less than a couple seconds. | 19:24 |
| mriedem | and, | 19:24 |
| dansmith | we should just add the column, not change it | 19:24 |
| dansmith | per normal and then backfill the data | 19:24 |
| mriedem | yeah that was the other option i was thinking of | 19:25 |
| mriedem | i don't know that we could even reliably backfill it | 19:25 |
| dansmith | there's no reason to change it unless we're going to rewrite the contents and that would be ungoodly | 19:25 |
| dansmith | likely not, and it'd require details from the api database | 19:25 |
| mriedem | yup, and, flavor 1 might no longer exist | 19:25 |
| dansmith | is it majorly problematic that the user can't see what the resize actually was? | 19:26 |
| dansmith | I mean, it's the migrations api, mostly about moves anyway right? | 19:26 |
| mriedem | it's all about moves | 19:26 |
| mriedem | admin-only by default | 19:26 |
| mriedem | if we added a new column, the api could just check that first, and if not set (old record), we fallback to the existing broken field | 19:27 |
| *** yamamoto has quit IRC | 19:28 | |
| dansmith | and that's just empty for non-resize moves? | 19:28 |
| mriedem | no, | 19:28 |
| mriedem | it's just equal for everything else | 19:28 |
| mriedem | :) | 19:28 |
| openstackgerrit | Ian Wienand proposed openstack/nova stable/newton: [DNM] Testing d-g automatic -eol tag detection https://review.openstack.org/523509 | 19:29 |
| mriedem | https://github.com/openstack/nova/blob/5b5b5c8df316e4c26b853c80ae8f8ea91f9c05c0/nova/conductor/tasks/migrate.py#L180-L181 | 19:29 |
| dansmith | I just don't see the point I guess | 19:29 |
| mriedem | sure, but, | 19:29 |
| mriedem | it's also dumb | 19:29 |
| dansmith | flavorid doesn't really get you the info you need either | 19:30 |
| mriedem | not if the flavor is deleted | 19:30 |
| mriedem | i agree | 19:30 |
| dansmith | so if you want to do this, we should go all overkill and store the actual flavors | 19:30 |
| dansmith | really fatten out our database | 19:30 |
| mriedem | so we could microversion the fields out of the response | 19:30 |
| mriedem | database, singular? | 19:30 |
| dansmith | yuup | 19:30 |
| dansmith | and/or always return zero there | 19:30 |
| dansmith | heh | 19:30 |
| *** priteau has quit IRC | 19:30 | |
| *** ijw has quit IRC | 19:33 | |
| efried | jaypipes Am I missing something or are these identical? https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L1074-L1091 | 19:34 |
| efried | (other than the name of the alias) | 19:34 |
| zigo | melwitt: Ok, thanks. | 19:35 |
| melwitt | zigo: let me know if you have any questions or if something wasn't clear | 19:35 |
| zigo | I'll do that later on (when my kids sleep...:) | 19:35 |
| melwitt | heh, k | 19:35 |
| jaypipes | efried: nope, you're not missing anything. for explanation of why that's needed, see the comments above about "butterfly join" | 19:37 |
| *** sdague has quit IRC | 19:37 | |
| efried | jaypipes Yeah, totally confused by all of that at the moment. | 19:37 |
| jaypipes | efried: https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L890-L949 | 19:37 |
| *** links has joined #openstack-nova | 19:38 | |
| efried | jaypipes Is there some reason we need two copies of that dict? | 19:38 |
| jaypipes | efried: I'd be happy to walk you through it in a hangout if you need. | 19:39 |
| jaypipes | efried: it's two separate sets of aliased tables. not the same dict. | 19:39 |
| efried | jaypipes Hum, yeah. | 19:39 |
| efried | jaypipes A walkthrough would be great, though I don't think my brain can handle it now. I'll take you up on it at some point when I'm feeling smarter. | 19:39 |
| jaypipes | efried: np, happy to do that. | 19:39 |
| efried | thanks | 19:40 |
| *** stvnoyes has quit IRC | 19:40 | |
| jaypipes | efried: sharing providers are the bane of my existence. | 19:40 |
| efried | Surely not the *only* bane. | 19:41 |
| jaypipes | efried: heh | 19:41 |
| *** links has quit IRC | 19:42 | |
| jaypipes | efried: just completed the last of the test runs on n-r-p series. just in time to need to rebase and bump to 1.14 instead of 1.13... | 19:43 |
| efried | jaypipes Fun day. | 19:43 |
| edleafe | efried: if you ever need a sanity check on differences, try https://www.diffchecker.com | 19:43 |
| edleafe | Really helpful when comparing expected vs. actual in tests | 19:44 |
| efried | edleafe Nice, thanks! | 19:44 |
| openstackgerrit | Merged openstack/nova master: Regenerate and pass configdrive when rebuild Ironic nodes https://review.openstack.org/503088 | 19:44 |
| jaypipes | efried: actually... if you are looking for something to do... | 19:49 |
| efried | jaypipes Tell me. I think I could just about handle a deep rebase right now. | 19:49 |
| jaypipes | efried: if you wouldn't mind fixing those little issues you found on https://review.openstack.org/#/c/523192/, that would be super useful since I'm currently rebasing again the n-r-p series. | 19:50 |
| efried | ight | 19:50 |
| jaypipes | efried: since that's an important bug. | 19:50 |
| efried | lemme propose this ksa release and I'll hit that... | 19:50 |
| jaypipes | efried: and will make mriedem happy. | 19:50 |
| jaypipes | ++ | 19:50 |
| jaypipes | thanks much | 19:50 |
| *** gouthamr_ has joined #openstack-nova | 19:53 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove deprecated TrustedFilter https://review.openstack.org/506864 | 19:54 |
| *** kenperkins has quit IRC | 19:56 | |
| *** gouthamr has quit IRC | 19:56 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use oslo_db Session in resource_provider.py https://review.openstack.org/523192 | 19:58 |
| efried | jaypipes ^ -- though I doubt mriedem was witholding his +2 for those issues. | 19:58 |
| mriedem | i'm withholding my +2 for other reasons | 19:59 |
| efried | at least this way we get more test runs. | 19:59 |
| efried | mriedem Care to comment? | 19:59 |
| mriedem | i will leave you in suspense | 20:00 |
| *** amodi has joined #openstack-nova | 20:01 | |
| openstackgerrit | Merged openstack/nova master: Remove 'nova-manage quota refresh' command https://review.openstack.org/521829 | 20:02 |
| *** stvnoyes has joined #openstack-nova | 20:02 | |
| efried | jaypipes https://bugs.launchpad.net/nova/+bug/1731668 got reassigned to me, and I can't seem to punt it back to you. Why is that? | 20:05 |
| openstack | Launchpad bug 1731668 in OpenStack Compute (nova) "placement: claim allocations fails with IndexError in _ensure_lookup_table_entry" [High,In progress] - Assigned to Eric Fried (efried) | 20:05 |
| mriedem | efried: are you on the nova bug team? | 20:05 |
| efried | mriedem How would I know? | 20:05 |
| mriedem | https://launchpad.net/~nova-bugs | 20:05 |
| efried | Sorry, I didn't mean that to sound rude | 20:06 |
| efried | I literally meant, how would I know if that's the case? | 20:06 |
| * mriedem puts down the knife | 20:06 | |
| mriedem | should show your membership in there somewhere | 20:06 |
| mriedem | or under your launchpad profile | 20:06 |
| mriedem | https://launchpad.net/~efried/+participation | 20:06 |
| mriedem | so no | 20:06 |
| mriedem | so join the nova bug team | 20:06 |
| efried | ight | 20:06 |
| * efried reads the rules right quick | 20:07 | |
| mriedem | there are no rules | 20:07 |
| *** suresh12 has quit IRC | 20:08 | |
| efried | There's a busted link at https://wiki.openstack.org/wiki/Nova/BugTriage | 20:08 |
| mriedem | wikis are free to update | 20:08 |
| mriedem | but you mean http://138.197.2.61/ yes? | 20:09 |
| efried | yeah | 20:09 |
| efried | I wouldn't know what to update it to. | 20:09 |
| mriedem | let me see if i can find it | 20:09 |
| mriedem | http://45.55.105.55:3000/dashboard/db/openstack-bugs | 20:10 |
| mriedem | 45.55.105.55:8082/bugs-dashboard.html | 20:10 |
| mriedem | http://45.55.105.55:8082/bugs-dashboard.html | 20:10 |
| mriedem | might be dead at this point since markus_z was maintaining that | 20:11 |
| *** suresh12 has joined #openstack-nova | 20:11 | |
| efried | Fix Committed and Fix Released -- this is no longer accurate: https://wiki.openstack.org/wiki/Bugs ? | 20:13 |
| efried | Cause we mark Fix Released as soon as it's in master; and we don't use Fix Committed at all - right? | 20:13 |
| mriedem | once something is merged on master it's marked fix released | 20:14 |
| mriedem | i think things get marked fix committed on stable branches | 20:14 |
| *** lpetrut has joined #openstack-nova | 20:14 | |
| mriedem | there is no auto-release of those for stable releases i don't think, although dhelmann used to run a script for that | 20:14 |
| mriedem | idk anymore | 20:14 |
| mriedem | nor is there a proposed/* branch anymore | 20:14 |
| efried | Since it's OpenStack-wide, I'll refrain from editing that page; long as I have some understanding of what the real deal is. | 20:15 |
| efried | Mebbe I'll mention it to dhellmann | 20:16 |
| mriedem | bauzas and stephenfin gave a talk at the summit about bug triage | 20:16 |
| mriedem | you can blast them with your questions | 20:16 |
| *** eharney has quit IRC | 20:19 | |
| *** pcaruana has joined #openstack-nova | 20:21 | |
| *** tidwellr has quit IRC | 20:21 | |
| *** tidwellr has joined #openstack-nova | 20:21 | |
| *** sahid has joined #openstack-nova | 20:22 | |
| *** sahid has quit IRC | 20:23 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix some incorrect option references for scheduler filters https://review.openstack.org/521645 | 20:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Deprecate the IronicHostManager https://review.openstack.org/521648 | 20:23 |
| openstackgerrit | Merged openstack/nova master: libvirt: remove extraneous retry assignment in cleanup method https://review.openstack.org/409199 | 20:26 |
| *** suresh12 has quit IRC | 20:26 | |
| *** esberglu has quit IRC | 20:27 | |
| *** awaugama has quit IRC | 20:33 | |
| *** READ10 has quit IRC | 20:37 | |
| *** suresh12 has joined #openstack-nova | 20:39 | |
| *** kenperkins has joined #openstack-nova | 20:39 | |
| *** esberglu has joined #openstack-nova | 20:40 | |
| mriedem | efried: jaypipes: maybe you guys can confirm the issue i raised in this osc-placement allocations patch https://review.openstack.org/#/c/457534/10 | 20:47 |
| mriedem | but looking at how PUT /allocations/{consumer_id} works before 1.12, we can get some weird behavior | 20:47 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: add nested resource providers https://review.openstack.org/377138 | 20:48 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215 | 20:48 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | 20:48 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 20:48 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: ProviderTree.uuid_set() https://review.openstack.org/520243 | 20:48 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Scheduler set_inventory_for_provider does nested https://review.openstack.org/520643 | 20:48 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: SchedulerReportClient._get_providers_in_tree https://review.openstack.org/520663 | 20:48 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: SchedulerReportClient._get_providers_in_aggregates https://review.openstack.org/521097 | 20:48 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: ProviderTree.populate_from_iterable https://review.openstack.org/520756 | 20:48 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Scheduler[Report]Client.get_provider_tree https://review.openstack.org/521098 | 20:48 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: WIP: ComputeDriver.update_provider_tree() https://review.openstack.org/521187 | 20:48 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 20:48 |
| jaypipes | mriedem: gonna take a break for a bit, but will look at that later. | 20:48 |
| mriedem | smoke'em if you got'em | 20:49 |
| melwitt | mriedem: about the console TLS series, you might have you skim it to see what I mean. it's an effort to break the work into chunks. an already merged patch added a base class for a SecurityProxy. the first unmerged patch in the series lays some groundwork by adding a base class and a None auth scheme. the second patch adds a vencrypt auth scheme, and the final patch adds a RFBSecurityProxy which actually does the encryption | 20:49 |
| efried | mriedem ack; but sounds like it oughtta be solved in the CLI - not a bug in the placement API? | 20:49 |
| mriedem | efried: that's what i said, i think it's a limitation in the api until 1.12 and we have to handle it in the cli | 20:50 |
| *** priteau has joined #openstack-nova | 20:50 | |
| melwitt | mriedem: so I'm not seeing a better way to do the reno except at the end https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/websocket-proxy-to-host-security | 20:50 |
| mriedem | melwitt: well, we could just hold off on approving the first unmerged patch with the new option until people are happy with the entire series | 20:50 |
| efried | mriedem rgr. Though "limitation" might be a bit strong. | 20:50 |
| melwitt | mriedem: okay, that works | 20:50 |
| *** edmondsw_ has joined #openstack-nova | 20:52 | |
| *** edmondsw has quit IRC | 20:56 | |
| *** kenperkins has quit IRC | 20:58 | |
| *** kenperkins has joined #openstack-nova | 21:00 | |
| openstackgerrit | Merged openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | 21:00 |
| *** penick has quit IRC | 21:03 | |
| *** thorst has quit IRC | 21:03 | |
| *** moshele has joined #openstack-nova | 21:04 | |
| *** Alex_Staf has joined #openstack-nova | 21:08 | |
| *** flanders_ has joined #openstack-nova | 21:08 | |
| *** gbarros has quit IRC | 21:12 | |
| *** awaugama has joined #openstack-nova | 21:15 | |
| *** stvnoyes has quit IRC | 21:15 | |
| *** armax has quit IRC | 21:17 | |
| *** penick has joined #openstack-nova | 21:20 | |
| *** gbarros has joined #openstack-nova | 21:21 | |
| *** gszasz has quit IRC | 21:21 | |
| *** gouthamr_ is now known as gouthamr | 21:21 | |
| *** pcaruana has quit IRC | 21:21 | |
| *** smatzek has quit IRC | 21:22 | |
| *** kenperkins has quit IRC | 21:24 | |
| melwitt | weird, yet another time when it says merge conflict and I rebase locally but there was no conflict ... | 21:25 |
| *** edmondsw_ is now known as edmondsw | 21:27 | |
| melwitt | mriedem: should I just try the rebase button on https://review.openstack.org/#/c/498983 ? it says merge conflict but there's no conflict to resolve when I pull it down and rebase locally | 21:27 |
| mriedem | sure | 21:28 |
| melwitt | k, trying that now | 21:29 |
| openstackgerrit | melanie witt proposed openstack/nova master: Save updated libvirt domain XML after swapping volume https://review.openstack.org/498983 | 21:29 |
| *** thorst has joined #openstack-nova | 21:30 | |
| *** rcernin has quit IRC | 21:33 | |
| *** liverpooler has quit IRC | 21:37 | |
| *** liverpooler has joined #openstack-nova | 21:38 | |
| *** pchavva has quit IRC | 21:42 | |
| *** toure is now known as toure_biab | 21:42 | |
| *** openstackstatus has quit IRC | 21:42 | |
| *** openstack has joined #openstack-nova | 21:44 | |
| *** ChanServ sets mode: +o openstack | 21:44 | |
| *** erlon has quit IRC | 21:44 | |
| penick | Hey folks, we're gearing up to replace our quota by flavor (and az) patches with something we could actually upstream. At the moment (based on hazy recollection of conversations at the summit) the direction i'm heading in is to do quota by custom resource class, wherein a resource class could be a combination of AZ and Flavor. Does that sound sane? | 21:44 |
| mriedem | mlavalle: is this the neutron port binding extension that i'd want for the live migration thingy? http://paste.openstack.org/show/627643/ | 21:45 |
| penick | Wanted to see if anyone had some input before we started working on the spec. | 21:45 |
| melwitt | penick: I think what we discussed was leveraging the quota class facility we already have and adding the ability to tag flavors with a quota class | 21:45 |
| *** kenperkins has joined #openstack-nova | 21:47 | |
| penick | melwitt: ah, I also have to do quota by flavor and AZ as well. Can I make that work using quota classes too? | 21:47 |
| mriedem | mlavalle: i'm guessing it's not, since it looks like that extension is just an indication of the binding:profile stuff on the port, i.e. https://developer.openstack.org/api-ref/network/v2/index.html#port-binding-extended-attributes | 21:47 |
| mlavalle | mriedem: it's not | 21:48 |
| mlavalle | that is the existing extension | 21:48 |
| *** moshele has quit IRC | 21:48 | |
| *** amodi has quit IRC | 21:48 | |
| melwitt | penick: this gives a high level view of what quota classes are https://docs.openstack.org/nova/pike/user/quotas.html so it's already possible to set quota on a per class basis i.e. "openstack quota set --class myclass --instances 5" | 21:49 |
| melwitt | it's just that currently there is no way to specify a quota class with any one request. rackspace used to do it via their own custom paste middleware, IIRC | 21:49 |
| *** hamzy has quit IRC | 21:50 | |
| penick | oh ok, I didn't realize that it could be custom resource classes too, not just the typical resources like instances, ram, etc | 21:51 |
| mriedem | not the same thing | 21:52 |
| mriedem | resource classes are a placement concept | 21:52 |
| melwitt | as for AZ, I guess to do it that way there would need to be a way to tag an AZ with a quota class | 21:52 |
| mriedem | quota classes are a nova concept | 21:52 |
| gryf | quota class is different thing | 21:52 |
| mriedem | placement doesn't have any concept of quota | 21:52 |
| penick | Ah, that makes sense. | 21:53 |
| mriedem | we've talked about replacing nova's quota calculation code using the consumer allocation / resource class stuff in placement at some point, but there are issues | 21:53 |
| mriedem | because the quota usage in nova is also tracked via allocatoins in placemetn for things like vcpu/memory_mb/disk_gb | 21:53 |
| melwitt | yeah. a quota class is a logical grouping of quotas. like you could create a 'dev class' that has certain quota limits and you could create a different 'prod class' that has different quota limits | 21:54 |
| mriedem | penick: you could start with a backlog spec to document the problem and use case | 21:54 |
| mriedem | w/o getting into design or implementation details | 21:54 |
| mriedem | note that today you can create any number of custom quota classes in nova, but the only one that the code actually gives 2 shits about is the 'default' quota class | 21:55 |
| *** slaweq_ has quit IRC | 21:55 | |
| mriedem | ala https://review.openstack.org/#/c/411035/ | 21:55 |
| melwitt | they've proposed a spec about it in the past, it got gridlocked on the implementation details | 21:55 |
| mriedem | they = yahoo, past = juno? | 21:55 |
| *** slaweq has joined #openstack-nova | 21:56 | |
| mriedem | and was it the same guy that was doing the zookeeper spec that gridlocked for 3 years? | 21:56 |
| melwitt | I was thinking a reasonable way to actually get it done would be to use quota classes and provide a way to tag flavor with a quota class | 21:56 |
| mriedem | or tooz or kazoo or whatever it was | 21:56 |
| melwitt | mriedem: yes | 21:56 |
| *** slaweq_ has joined #openstack-nova | 21:56 | |
| *** thorst has quit IRC | 21:56 | |
| penick | heh | 21:57 |
| *** slaweq_ has quit IRC | 21:57 | |
| mriedem | welp, i'd dig up the old spec i guess because i'm not familiar with the use case / problem description | 21:57 |
| mriedem | and i'm sure that predated anything with placement | 21:57 |
| mriedem | *plus* no chance for queens, so you'd have to tee this up for discussion in dublin | 21:57 |
| *** slaweq_ has joined #openstack-nova | 21:57 | |
| melwitt | mriedem: this is the old spec https://review.openstack.org/#/c/206160/ | 21:58 |
| melwitt | it was agreed to be a reasonable use case, just that all of the implementation ideas were pretty hairy | 21:59 |
| mriedem | anything involving AZs is going to be hairy as hell | 21:59 |
| mriedem | or quotas | 21:59 |
| mriedem | is there some way we can work boot from volume into this? | 21:59 |
| penick | You bet your ass we can | 21:59 |
| melwitt | being able to tag a flavor with a quota class would get us quota by flavor at least, and the same use case has come up in the preemptable instances discussions | 21:59 |
| *** slaweq has quit IRC | 22:00 | |
| *** ijw has joined #openstack-nova | 22:01 | |
| melwitt | that is, for preemptable instances, you could have a quota class 'preemtable' which is unlimited quota and tag preemptable instance flavors with that class. so that users booting preemptable instances don't use up their quota when they boot them | 22:01 |
| *** armax has joined #openstack-nova | 22:02 | |
| mriedem | mlavalle: ok so i'm looking for the "binding-extended" extension per https://review.openstack.org/#/c/484389/8/neutron_lib/api/definitions/portbindings_extended.py | 22:02 |
| *** kenperkins has quit IRC | 22:02 | |
| mriedem | mlavalle: i'm looking at starting to build up the nova patches for this thing, and part of that is just asking neutron if the api extension is even available to do the deed | 22:03 |
| *** slaweq_ has quit IRC | 22:03 | |
| *** slaweq has joined #openstack-nova | 22:04 | |
| *** slaweq has quit IRC | 22:04 | |
| mlavalle | mriedem: that is the extension definition. as far as the implementation, I am working on it | 22:05 |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: Remove unnecessary spaces on JSON samples https://review.openstack.org/523543 | 22:06 |
| *** hemna_ has joined #openstack-nova | 22:06 | |
| penick | So If I want to limit tenant $foo to 10 instances of flavor $bar, and I want to limit tenant $baz to 20 instances of flavor bar, i'd create 2 quota classes, one for tenant $foo, one for tenant $baz, then tag flavor $bar with both quota classes? | 22:06 |
| *** peter-hamilton has quit IRC | 22:07 | |
| *** ijw has quit IRC | 22:07 | |
| penick | is that how the flow would go? Assuming I could tag a flavor with the quota class | 22:09 |
| melwitt | penick: hm, no. what I was saying would only work to have 1 set of quotas for a flavor if every tenant gets the same quotas for that flavor | 22:09 |
| penick | oh, crud | 22:09 |
| *** ijw has joined #openstack-nova | 22:09 | |
| melwitt | basically, you'd need a quota class per unique set of quota limits | 22:10 |
| melwitt | I would think to a large extent many tenants would be able to use the same class? | 22:11 |
| penick | i'm checking the DB on one of our prod clusters right now.. | 22:12 |
| mriedem | if we ever get limits information from keystone, doesn't that kind of throw a wrench into all of this? | 22:12 |
| melwitt | what I mean is, you would only need one class per tenant/flavor if they were all literally different | 22:12 |
| mriedem | because that's the eventual replacement for quota classes in nova | 22:12 |
| melwitt | it would throw a wrench if we won't have quota classes in keystone | 22:13 |
| *** tidwellr has quit IRC | 22:14 | |
| *** slaweq has joined #openstack-nova | 22:14 | |
| *** tidwellr has joined #openstack-nova | 22:15 | |
| *** ijw has quit IRC | 22:15 | |
| penick | Ok, so i'll need to assume one class per tenant and flavor | 22:16 |
| melwitt | hang on, let me look at this again real quick. | 22:16 |
| penick | mriedem are limits definitely moving to keystone? Because i've heard talk about that for a year or two..and nothing's happened. | 22:16 |
| dansmith | well, people keep getting laid off | 22:16 |
| dansmith | kinda gets in the way of progress | 22:17 |
| mriedem | someone from huawei was supposedly working on picking up that spec in keystone, but last i heard in sydney it was dropped in lbragstad's lap, and he's trying to move the rbac stuff forward | 22:17 |
| lbragstad | we do have a new owner for that work | 22:18 |
| lbragstad | https://review.openstack.org/#/c/455709/ | 22:18 |
| *** tidwellr has quit IRC | 22:19 | |
| lbragstad | which is still under sdague's name but wxy is picking it up | 22:19 |
| *** gbarros has quit IRC | 22:19 | |
| lbragstad | so if there is anything nova needs out of that interface from keystone, let us know | 22:20 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add check if neutron "binding-extended" extension is available https://review.openstack.org/523548 | 22:21 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add check if neutron "binding-extended" extension is available https://review.openstack.org/523548 | 22:22 |
| penick | if Keystone is going to be able to land the limits api in queens, will Nova move to use it for Rocky? | 22:22 |
| lbragstad | yeah - that's the idea | 22:22 |
| *** rcernin has joined #openstack-nova | 22:23 | |
| *** priteau has quit IRC | 22:23 | |
| lbragstad | but there are other things that playing into it too, which sean was really driving in Boston (like what enforcement models to use) | 22:23 |
| lbragstad | we're not quite sure how that's going to get applied as the service yet | 22:23 |
| *** thorst has joined #openstack-nova | 22:27 | |
| *** moshele has joined #openstack-nova | 22:28 | |
| melwitt | penick: I looked through the code again and indeed quota classes are not per tenant. so it won't be as simple as what I thought earlier | 22:30 |
| penick | melwitt: dang | 22:30 |
| *** thorst has quit IRC | 22:31 | |
| *** jaypipes has quit IRC | 22:35 | |
| *** Alex_Staf has quit IRC | 22:36 | |
| *** awaugama has quit IRC | 22:36 | |
| *** edmondsw has quit IRC | 22:36 | |
| *** thorst has joined #openstack-nova | 22:38 | |
| *** edmondsw has joined #openstack-nova | 22:39 | |
| *** penick has quit IRC | 22:40 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add check if neutron "binding-extended" extension is available https://review.openstack.org/523548 | 22:40 |
| *** thorst has quit IRC | 22:42 | |
| *** abalutoiu has quit IRC | 22:42 | |
| openstackgerrit | Thomas Goirand proposed openstack/nova master: qemu-img do not use cache=none if no O_DIRECT support https://review.openstack.org/523554 | 22:43 |
| *** edmondsw has quit IRC | 22:43 | |
| zigo | melwitt: ^ | 22:45 |
| melwitt | cool, looking | 22:46 |
| openstackgerrit | Mathieu Gagné proposed openstack/nova master: Fix rebuild of baremetal instance when vm_state is ERROR https://review.openstack.org/523559 | 22:51 |
| mriedem | efried: can i make simple rest calls like post() from a ksa adapter object? | 22:53 |
| mriedem | mgagne: broken already :) | 22:53 |
| mgagne | mriedem: what's broken? | 22:54 |
| mriedem | mgagne: oh nvm, was thinking the rebuild + config drive thing | 22:54 |
| mgagne | mriedem: hehe, we have a theme this month: rebuilding stuff =) | 22:54 |
| dansmith | and re-rebuilding | 22:55 |
| mgagne | that one had an interesting side effect: rebuild is actually happening on Ironic side but Nova stays in ERROR while rebuild continues | 22:55 |
| *** marst has quit IRC | 22:56 | |
| mriedem | efried: nvm, answer is yes, that's exactly how it's used for the placement client in SchedulerReportClient | 22:57 |
| melwitt | zigo: reviewed, couple of minor things and need unit tests. looks clean tho | 22:59 |
| efried | mriedem Yuh | 23:00 |
| *** suresh12 has quit IRC | 23:01 | |
| *** Alex_Staf has joined #openstack-nova | 23:01 | |
| *** ijw has joined #openstack-nova | 23:03 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/523562 | 23:07 |
| *** ijw has quit IRC | 23:08 | |
| zigo | mtreinish: Thanks, though I'm not sure what kind of unit tests you think I should write. | 23:10 |
| openstackgerrit | Thomas Goirand proposed openstack/nova master: qemu-img do not use cache=none if no O_DIRECT support https://review.openstack.org/523554 | 23:11 |
| zigo | mtreinish: sorry wrong person. | 23:12 |
| zigo | melwitt: I'm not sure how the unit tests you're recommending should look like. | 23:13 |
| melwitt | zigo: I attempted to explain in my comment. basically you'd mock supports_direct_io and utils.execute via decorators, and in one test make supports_direct_io return True and then verify that utils.execute was called with '-t none' and vice versa for it returning False | 23:16 |
| *** lbragstad has quit IRC | 23:17 | |
| *** lyan has quit IRC | 23:18 | |
| *** edmondsw has joined #openstack-nova | 23:18 | |
| melwitt | zigo: if you don't have time to give it a try or otherwise don't want to, I can write the tests and add them to your patch as a co-author if that's okay with you | 23:19 |
| zigo | melwitt: It'd be great if you did so, yes. | 23:19 |
| zigo | Thanks. | 23:19 |
| melwitt | k, np | 23:20 |
| *** edmondsw has quit IRC | 23:23 | |
| *** lbragstad has joined #openstack-nova | 23:24 | |
| *** suresh12 has joined #openstack-nova | 23:25 | |
| *** lpetrut has quit IRC | 23:25 | |
| *** penick has joined #openstack-nova | 23:27 | |
| *** flanders_ has quit IRC | 23:27 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add code to bind a port against a dest host during live migration https://review.openstack.org/523604 | 23:29 |
| mriedem | mlavalle: ^ | 23:29 |
| mriedem | it's a start | 23:29 |
| mlavalle | mriedem: thanks :-) | 23:30 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Fix getting placement reuest ID https://review.openstack.org/523606 | 23:33 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Fix getting placement reuest ID https://review.openstack.org/523606 | 23:33 |
| *** salv-orl_ has joined #openstack-nova | 23:37 | |
| *** salv-orlando has quit IRC | 23:40 | |
| *** slaweq has quit IRC | 23:40 | |
| *** slaweq has joined #openstack-nova | 23:41 | |
| *** slaweq has quit IRC | 23:45 | |
| *** thorst has joined #openstack-nova | 23:46 | |
| *** thorst has quit IRC | 23:50 | |
| *** takashin has joined #openstack-nova | 23:53 | |
| *** lbragstad has quit IRC | 23:56 | |
| openstackgerrit | Mathieu Gagné proposed openstack/nova master: Fix rebuild of baremetal instance when vm_state is ERROR https://review.openstack.org/523559 | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!