| *** code-R has quit IRC | 00:00 | |
| *** diogogmt has quit IRC | 00:00 | |
| jaypipes | dansmith: hrmmm.. | 00:00 |
|---|---|---|
| jaypipes | dansmith: yeah, gertty sync problem. pushed now. | 00:01 |
| dansmith | thanks | 00:01 |
| jaypipes | dansmith: guh, still pushing. | 00:01 |
| *** TravT has joined #openstack-nova | 00:01 | |
| *** moshele has joined #openstack-nova | 00:02 | |
| *** thumpba has joined #openstack-nova | 00:03 | |
| mriedem | sfinucan: or is that because we need https://review.openstack.org/#/c/337108/ stacked on top which is passing intel nfv ci? | 00:03 |
| *** shaohe_feng has quit IRC | 00:04 | |
| jaypipes | dansmith: now done syncing.. | 00:04 |
| jaypipes | dansmith: please see my concern on https://review.openstack.org/#/c/314782/28 btw. | 00:04 |
| *** shaohe_feng has joined #openstack-nova | 00:04 | |
| *** code-R_ has quit IRC | 00:05 | |
| *** code-R has joined #openstack-nova | 00:05 | |
| dansmith | jaypipes: replying | 00:06 |
| jaypipes | dansmith: baited breath. | 00:07 |
| *** sameo has quit IRC | 00:07 | |
| dansmith | jaypipes: replied | 00:10 |
| *** TravT has quit IRC | 00:10 | |
| *** mtanino has quit IRC | 00:11 | |
| *** thumpba has quit IRC | 00:12 | |
| openstackgerrit | Jay Pipes proposed openstack/nova: rt: refactor test_dupe_filter unit test https://review.openstack.org/350319 | 00:12 |
| jaypipes | dansmith: ahhhhhh | 00:13 |
| jaypipes | dansmith: I totally friggin missed that... | 00:13 |
| dansmith | I forgive you :) | 00:13 |
| *** thumpba has joined #openstack-nova | 00:14 | |
| *** thumpba has quit IRC | 00:14 | |
| *** shaohe_feng has quit IRC | 00:14 | |
| *** shaohe_feng has joined #openstack-nova | 00:14 | |
| jaypipes | dansmith: approved and wallaby'd. and gertty-sync'd. | 00:15 |
| mriedem | Yingxin: do you still need this or can it be abandoned? https://review.openstack.org/#/c/306301/ | 00:15 |
| dansmith | jaypipes: thankyasir | 00:15 |
| *** TravT has joined #openstack-nova | 00:15 | |
| jaypipes | dansmith: for you? any time. | 00:16 |
| * dansmith sets his alarm for 2am EDT Sunday to ask jaypipes for a review | 00:17 | |
| jaypipes | dansmith: review bait: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:rt-unit-tests | 00:17 |
| mriedem | oh wow we're using cascading deletes now? | 00:17 |
| jaypipes | mriedem: erm, no :) | 00:17 |
| dansmith | jaypipes: I've been waiting for that to be unblocked, so yeah, cool | 00:17 |
| mriedem | then what is https://review.openstack.org/#/c/314781/26/nova/db/sqlalchemy/api_models.py ? | 00:17 |
| *** devkulkarni1 has quit IRC | 00:17 | |
| jaypipes | mriedem: see my comment in there :) | 00:18 |
| jaypipes | that apparently gertty duplicated... | 00:18 |
| mriedem | yeah it's not used | 00:18 |
| dansmith | yeah, sofrware-level cascade | 00:18 |
| dansmith | er, software | 00:18 |
| jaypipes | dansmith: not even :) | 00:18 |
| jaypipes | dansmith: since you use query().filter().delete() it won't even be in use. | 00:19 |
| dansmith | you mean doffm :) | 00:19 |
| jaypipes | dansmith: yeah, the doffster. | 00:19 |
| dansmith | I thought this would in fact generate the deletes for us | 00:19 |
| dansmith | but I guess not since I had to do them manually.. I just remembered that | 00:19 |
| *** TravT has quit IRC | 00:19 | |
| mriedem | we should just remove that in a follow up | 00:19 |
| mriedem | to avoid confusion | 00:19 |
| dansmith | sure | 00:20 |
| *** jwcroppe_ has joined #openstack-nova | 00:20 | |
| *** jwcroppe has quit IRC | 00:22 | |
| *** ssurana has quit IRC | 00:23 | |
| *** shaohe_feng has quit IRC | 00:24 | |
| *** TravT has joined #openstack-nova | 00:25 | |
| *** shaohe_feng has joined #openstack-nova | 00:25 | |
| *** browne has quit IRC | 00:28 | |
| *** jwcroppe has joined #openstack-nova | 00:28 | |
| *** jwcroppe_ has quit IRC | 00:31 | |
| *** thorst has joined #openstack-nova | 00:31 | |
| *** rfolco_ has joined #openstack-nova | 00:32 | |
| *** rfolco_ has quit IRC | 00:32 | |
| *** baoli has joined #openstack-nova | 00:33 | |
| *** kaisers_ has joined #openstack-nova | 00:34 | |
| *** shaohe_feng has quit IRC | 00:35 | |
| *** shaohe_feng has joined #openstack-nova | 00:35 | |
| *** TravT has quit IRC | 00:38 | |
| *** kaisers_ has quit IRC | 00:38 | |
| *** thorst_ has joined #openstack-nova | 00:39 | |
| openstackgerrit | Jay Pipes proposed openstack/nova: rt: refactor test_dupe_filter unit test https://review.openstack.org/350319 | 00:39 |
| openstackgerrit | Jay Pipes proposed openstack/nova: rt: Refactor test_dupe_filter unit test https://review.openstack.org/350319 | 00:39 |
| *** hoangcx has joined #openstack-nova | 00:40 | |
| *** thorst has quit IRC | 00:41 | |
| *** thorst_ is now known as thorst | 00:41 | |
| *** TravT has joined #openstack-nova | 00:43 | |
| *** hoangcx2 has quit IRC | 00:43 | |
| *** baoli has quit IRC | 00:45 | |
| *** shaohe_feng has quit IRC | 00:45 | |
| *** shaohe_feng has joined #openstack-nova | 00:45 | |
| *** gongysh has joined #openstack-nova | 00:49 | |
| *** gongysh_ has joined #openstack-nova | 00:51 | |
| *** code-R has quit IRC | 00:54 | |
| *** shaohe_feng has quit IRC | 00:55 | |
| *** shaohe_feng has joined #openstack-nova | 00:55 | |
| *** TravT has quit IRC | 00:56 | |
| *** sdake has quit IRC | 00:57 | |
| *** sdake has joined #openstack-nova | 00:59 | |
| *** TravT has joined #openstack-nova | 01:01 | |
| *** phuongnh has joined #openstack-nova | 01:01 | |
| *** code-R has joined #openstack-nova | 01:02 | |
| *** shaohe_feng has quit IRC | 01:05 | |
| *** shaohe_feng has joined #openstack-nova | 01:06 | |
| *** diogogmt has joined #openstack-nova | 01:09 | |
| mriedem | oomichi: does this make sense? | 01:10 |
| mriedem | コンサートで | 01:10 |
| oomichi | mriedem: わかんない | 01:11 |
| oomichi | mriedem: I cannot understand :) | 01:11 |
| mriedem | heh | 01:12 |
| mriedem | that's what google told me the translation for 'in concert' was | 01:12 |
| *** Sukhdev has quit IRC | 01:12 | |
| oomichi | mriedem: yeah, I can see. but cannot see the meaning | 01:12 |
| mriedem | jointly | 01:12 |
| oomichi | mriedem: that is stylish English for me | 01:12 |
| *** Apoorva has quit IRC | 01:12 | |
| mriedem | i copied that line from sdague's spec so that's why | 01:12 |
| mriedem | he's fancy pants | 01:12 |
| oomichi | mriedem: I know, sdague's English is always stylish | 01:13 |
| *** TravT has quit IRC | 01:14 | |
| *** shaohe_feng has quit IRC | 01:16 | |
| *** shaohe_feng has joined #openstack-nova | 01:16 | |
| Yingxin | mriedem: I can abandon that | 01:16 |
| *** mriedem has quit IRC | 01:19 | |
| eliqiao | oomichi when you say stylish , does that mean 流行する ? | 01:21 |
| *** akshai has joined #openstack-nova | 01:23 | |
| *** Apoorva has joined #openstack-nova | 01:23 | |
| *** dimtruck is now known as zz_dimtruck | 01:23 | |
| oomichi | eliqiao: I am using stylish as good-looking or Foppery ;) | 01:24 |
| oomichi | eliqiao: yea, almost same as the above JP lang | 01:24 |
| *** browne has joined #openstack-nova | 01:25 | |
| eliqiao | oomichi: haha, get it. :) , OpenStack is so international. | 01:25 |
| *** shaohe_feng has quit IRC | 01:26 | |
| *** shaohe_feng has joined #openstack-nova | 01:27 | |
| *** delattec has quit IRC | 01:28 | |
| Qiming | hi, can someone tell me if nova emits a notification when a nova-compute service is down (could be any reason)? | 01:31 |
| *** tangchen has quit IRC | 01:33 | |
| *** akshai has quit IRC | 01:35 | |
| *** shaohe_feng has quit IRC | 01:36 | |
| openstackgerrit | Fang He proposed openstack/nova: use the HostPortGroupSpec.vswitchName instead of HostPortGroup.vswitch.split https://review.openstack.org/350335 | 01:37 |
| *** shaohe_feng has joined #openstack-nova | 01:37 | |
| *** stewie925_ has quit IRC | 01:38 | |
| *** tangchen has joined #openstack-nova | 01:39 | |
| *** Apoorva_ has joined #openstack-nova | 01:40 | |
| *** TravT has joined #openstack-nova | 01:43 | |
| *** sdake has quit IRC | 01:44 | |
| *** Apoorva has quit IRC | 01:44 | |
| *** EinstCrazy has joined #openstack-nova | 01:44 | |
| *** browne has quit IRC | 01:44 | |
| *** Apoorva_ has quit IRC | 01:44 | |
| *** shaohe_feng has quit IRC | 01:46 | |
| *** shaohe_feng has joined #openstack-nova | 01:47 | |
| *** thorst has quit IRC | 01:47 | |
| *** TravT has quit IRC | 01:47 | |
| *** thorst has joined #openstack-nova | 01:48 | |
| *** oomichi has quit IRC | 01:48 | |
| *** baoli has joined #openstack-nova | 01:49 | |
| *** burt has quit IRC | 01:51 | |
| *** TravT has joined #openstack-nova | 01:52 | |
| *** thorst has quit IRC | 01:56 | |
| *** shaohe_feng has quit IRC | 01:57 | |
| *** chenfan has quit IRC | 01:57 | |
| *** unicell1 has quit IRC | 01:57 | |
| *** shaohe_feng has joined #openstack-nova | 01:57 | |
| *** zz_dimtruck is now known as dimtruck | 01:58 | |
| *** TravT has quit IRC | 02:01 | |
| *** yb has joined #openstack-nova | 02:04 | |
| *** yb has left #openstack-nova | 02:05 | |
| *** TravT has joined #openstack-nova | 02:05 | |
| *** shaohe_feng has quit IRC | 02:07 | |
| *** shaohe_feng has joined #openstack-nova | 02:08 | |
| *** chenfan has joined #openstack-nova | 02:09 | |
| *** kenperkins has quit IRC | 02:11 | |
| openstackgerrit | Tina Kevin proposed openstack/nova-specs: Add allocation ratio to hypervisor-show https://review.openstack.org/350344 | 02:17 |
| *** zerda2 has joined #openstack-nova | 02:17 | |
| *** shaohe_feng has quit IRC | 02:17 | |
| *** shaohe_feng has joined #openstack-nova | 02:18 | |
| *** TravT has quit IRC | 02:18 | |
| *** yb has joined #openstack-nova | 02:18 | |
| *** coolsvap has joined #openstack-nova | 02:19 | |
| *** rrecio_ has quit IRC | 02:19 | |
| *** TravT has joined #openstack-nova | 02:19 | |
| openstackgerrit | Tina Kevin proposed openstack/nova-specs: Add allocation ratio to hypervisor-show https://review.openstack.org/350348 | 02:21 |
| *** moshele has quit IRC | 02:22 | |
| *** kaisers_ has joined #openstack-nova | 02:23 | |
| *** TravT has quit IRC | 02:24 | |
| *** kaisers_ has quit IRC | 02:27 | |
| *** shaohe_feng has quit IRC | 02:27 | |
| *** shaohe_feng has joined #openstack-nova | 02:28 | |
| *** TravT has joined #openstack-nova | 02:28 | |
| *** yamahata has quit IRC | 02:28 | |
| *** code-R has quit IRC | 02:36 | |
| *** shaohe_feng has quit IRC | 02:38 | |
| *** shaohe_feng has joined #openstack-nova | 02:39 | |
| *** markvoelker has joined #openstack-nova | 02:39 | |
| *** dave-mccowan has joined #openstack-nova | 02:41 | |
| *** shaohe_feng has quit IRC | 02:48 | |
| *** shaohe_feng has joined #openstack-nova | 02:49 | |
| *** thorst has joined #openstack-nova | 02:54 | |
| *** TravT has quit IRC | 02:54 | |
| *** TravT has joined #openstack-nova | 02:54 | |
| *** TravT has quit IRC | 02:55 | |
| *** takashin has joined #openstack-nova | 02:56 | |
| *** pwnall has quit IRC | 02:57 | |
| *** gjayavelu has quit IRC | 02:58 | |
| *** shaohe_feng has quit IRC | 02:58 | |
| *** hemanthm|afk is now known as hemanthm | 02:59 | |
| *** shaohe_feng has joined #openstack-nova | 03:01 | |
| *** thorst has quit IRC | 03:02 | |
| *** code-R has joined #openstack-nova | 03:03 | |
| *** oanson has joined #openstack-nova | 03:03 | |
| *** rama_y has quit IRC | 03:04 | |
| *** dave-mccowan has quit IRC | 03:08 | |
| *** shaohe_feng has quit IRC | 03:08 | |
| *** shaohe_feng has joined #openstack-nova | 03:09 | |
| *** oanson has quit IRC | 03:11 | |
| *** code-R has quit IRC | 03:14 | |
| *** gongysh has quit IRC | 03:14 | |
| *** code-R has joined #openstack-nova | 03:14 | |
| *** shaohe_feng has quit IRC | 03:19 | |
| *** shaohe_feng has joined #openstack-nova | 03:20 | |
| *** dimtruck is now known as zz_dimtruck | 03:26 | |
| *** zz_dimtruck is now known as dimtruck | 03:26 | |
| *** Nakato has quit IRC | 03:27 | |
| *** shaohe_feng has quit IRC | 03:29 | |
| *** devkulkarni1 has joined #openstack-nova | 03:29 | |
| *** shaohe_feng has joined #openstack-nova | 03:30 | |
| *** Nakato has joined #openstack-nova | 03:32 | |
| *** dimtruck is now known as zz_dimtruck | 03:35 | |
| *** shaohe_feng has quit IRC | 03:39 | |
| *** shaohe_feng has joined #openstack-nova | 03:40 | |
| *** code-R has quit IRC | 03:41 | |
| *** code-R has joined #openstack-nova | 03:41 | |
| *** annp has joined #openstack-nova | 03:42 | |
| *** nkrinner_afk is now known as nkrinner | 03:47 | |
| *** gjayavelu has joined #openstack-nova | 03:48 | |
| *** ayoung has quit IRC | 03:48 | |
| *** shaohe_feng has quit IRC | 03:49 | |
| *** shaohe_feng has joined #openstack-nova | 03:50 | |
| *** sdake has joined #openstack-nova | 03:50 | |
| *** kevinz has joined #openstack-nova | 03:51 | |
| *** devkulkarni1 has quit IRC | 03:53 | |
| *** devkulkarni1 has joined #openstack-nova | 03:53 | |
| *** sdake_ has joined #openstack-nova | 03:54 | |
| *** markvoelker has quit IRC | 03:55 | |
| *** sdake has quit IRC | 03:58 | |
| *** thorst has joined #openstack-nova | 03:59 | |
| *** shaohe_feng has quit IRC | 04:00 | |
| *** shaohe_feng has joined #openstack-nova | 04:01 | |
| *** sdake_ has quit IRC | 04:05 | |
| *** thorst has quit IRC | 04:06 | |
| *** shaohe_feng has quit IRC | 04:10 | |
| *** links has joined #openstack-nova | 04:10 | |
| *** shaohe_feng has joined #openstack-nova | 04:11 | |
| *** Sukhdev has joined #openstack-nova | 04:13 | |
| *** ratailor has joined #openstack-nova | 04:15 | |
| *** jdillaman has quit IRC | 04:18 | |
| *** amotoki has joined #openstack-nova | 04:20 | |
| *** shaohe_feng has quit IRC | 04:20 | |
| *** shaohe_feng has joined #openstack-nova | 04:21 | |
| *** kaisers_ has joined #openstack-nova | 04:23 | |
| *** kaisers_ has quit IRC | 04:23 | |
| *** unicell has joined #openstack-nova | 04:24 | |
| *** devkulkarni1 has quit IRC | 04:27 | |
| *** unicell has quit IRC | 04:28 | |
| *** unicell has joined #openstack-nova | 04:28 | |
| *** shaohe_feng has quit IRC | 04:30 | |
| *** shaohe_feng has joined #openstack-nova | 04:31 | |
| *** markvoelker has joined #openstack-nova | 04:33 | |
| *** flwang has quit IRC | 04:35 | |
| *** markvoelker has quit IRC | 04:39 | |
| *** shaohe_feng has quit IRC | 04:41 | |
| *** shaohe_feng has joined #openstack-nova | 04:41 | |
| *** dikonoor has joined #openstack-nova | 04:45 | |
| *** TravT has joined #openstack-nova | 04:49 | |
| *** shaohe_feng has quit IRC | 04:51 | |
| *** shaohe_feng has joined #openstack-nova | 04:52 | |
| *** TravT has quit IRC | 04:58 | |
| *** shaohe_feng has quit IRC | 05:01 | |
| *** rfolco has joined #openstack-nova | 05:02 | |
| *** shaohe_feng has joined #openstack-nova | 05:02 | |
| *** TravT has joined #openstack-nova | 05:02 | |
| *** jaosorior has joined #openstack-nova | 05:03 | |
| openstackgerrit | Anush Krishnamurthy proposed openstack/nova: Improve help text of image_file_url https://review.openstack.org/332492 | 05:03 |
| *** haleyb has quit IRC | 05:03 | |
| *** thorst has joined #openstack-nova | 05:04 | |
| *** yamahata has joined #openstack-nova | 05:06 | |
| *** rfolco has quit IRC | 05:06 | |
| *** ihrachys has joined #openstack-nova | 05:08 | |
| openstackgerrit | Anush Krishnamurthy proposed openstack/nova: Update tags for Image file url from filesystems config option https://review.openstack.org/350379 | 05:09 |
| *** thorst has quit IRC | 05:11 | |
| *** gcb has quit IRC | 05:11 | |
| *** shaohe_feng has quit IRC | 05:11 | |
| *** gcb has joined #openstack-nova | 05:12 | |
| *** TravT has quit IRC | 05:12 | |
| *** pbandark has joined #openstack-nova | 05:12 | |
| *** shaohe_feng has joined #openstack-nova | 05:14 | |
| *** irenab has joined #openstack-nova | 05:16 | |
| *** ihrachys has quit IRC | 05:17 | |
| *** yamahata has quit IRC | 05:19 | |
| *** shaohe_feng has quit IRC | 05:22 | |
| *** shaohe_feng has joined #openstack-nova | 05:24 | |
| *** oanson has joined #openstack-nova | 05:26 | |
| *** armax has quit IRC | 05:28 | |
| *** markvoelker has joined #openstack-nova | 05:28 | |
| *** diga has joined #openstack-nova | 05:28 | |
| *** liverpooler has joined #openstack-nova | 05:28 | |
| *** rcernin has joined #openstack-nova | 05:28 | |
| *** unicell has quit IRC | 05:29 | |
| *** unicell has joined #openstack-nova | 05:30 | |
| *** liverpooler has quit IRC | 05:30 | |
| *** liverpooler has joined #openstack-nova | 05:31 | |
| *** rtheis has quit IRC | 05:32 | |
| *** shaohe_feng has quit IRC | 05:32 | |
| *** rtheis has joined #openstack-nova | 05:32 | |
| *** markvoelker has quit IRC | 05:33 | |
| *** shaohe_feng has joined #openstack-nova | 05:33 | |
| *** ecelik has joined #openstack-nova | 05:41 | |
| *** rama_y has joined #openstack-nova | 05:42 | |
| *** shaohe_feng has quit IRC | 05:42 | |
| *** shaohe_feng has joined #openstack-nova | 05:43 | |
| *** chandankumar has joined #openstack-nova | 05:43 | |
| *** jdillaman has joined #openstack-nova | 05:44 | |
| *** fragatina has joined #openstack-nova | 05:45 | |
| *** ihrachys has joined #openstack-nova | 05:46 | |
| *** hshiina has joined #openstack-nova | 05:49 | |
| *** fragatina has quit IRC | 05:51 | |
| *** fragatina has joined #openstack-nova | 05:52 | |
| *** shaohe_feng has quit IRC | 05:52 | |
| *** shaohe_feng has joined #openstack-nova | 05:53 | |
| *** Sukhdev has quit IRC | 05:55 | |
| openstackgerrit | melanie witt proposed openstack/nova: Make InstanceGroup object favor the API database https://review.openstack.org/330995 | 05:56 |
| openstackgerrit | melanie witt proposed openstack/nova: Add online migration to move instance groups to API database https://review.openstack.org/333098 | 05:56 |
| *** haleyb has joined #openstack-nova | 05:56 | |
| *** ihrachys has quit IRC | 05:58 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/os-vif: Trivial: clean up oslo-incubator related stuff https://review.openstack.org/350386 | 05:59 |
| *** rama_y has quit IRC | 06:00 | |
| *** ekuris_ has joined #openstack-nova | 06:02 | |
| *** shaohe_feng has quit IRC | 06:03 | |
| *** shaohe_feng has joined #openstack-nova | 06:03 | |
| *** mjura has joined #openstack-nova | 06:04 | |
| *** sdake has joined #openstack-nova | 06:07 | |
| *** sdake has quit IRC | 06:07 | |
| *** sdake has joined #openstack-nova | 06:07 | |
| *** tiendc has joined #openstack-nova | 06:07 | |
| *** thorst has joined #openstack-nova | 06:09 | |
| *** code-R has quit IRC | 06:11 | |
| *** code-R has joined #openstack-nova | 06:12 | |
| *** mjura has quit IRC | 06:12 | |
| *** mjura has joined #openstack-nova | 06:13 | |
| *** shaohe_feng has quit IRC | 06:13 | |
| *** karthiks|afk is now known as karthiks | 06:13 | |
| *** shaohe_feng has joined #openstack-nova | 06:13 | |
| *** thorst has quit IRC | 06:16 | |
| *** sudipto has joined #openstack-nova | 06:17 | |
| *** TravT has joined #openstack-nova | 06:17 | |
| *** rfolco has joined #openstack-nova | 06:18 | |
| *** lpetrut has joined #openstack-nova | 06:19 | |
| *** markvoelker has joined #openstack-nova | 06:22 | |
| *** sdake has quit IRC | 06:23 | |
| *** shaohe_feng has quit IRC | 06:23 | |
| *** rfolco has quit IRC | 06:24 | |
| *** shaohe_feng has joined #openstack-nova | 06:24 | |
| *** diana_clarke has joined #openstack-nova | 06:26 | |
| *** markvoelker has quit IRC | 06:26 | |
| *** TravT has quit IRC | 06:27 | |
| *** TravT has joined #openstack-nova | 06:31 | |
| *** code-R has quit IRC | 06:32 | |
| *** code-R has joined #openstack-nova | 06:32 | |
| *** diana_clarke has quit IRC | 06:33 | |
| *** shaohe_feng has quit IRC | 06:33 | |
| *** shaohe_feng has joined #openstack-nova | 06:34 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Strict ImageRef validation to UUID only https://review.openstack.org/338802 | 06:35 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Strict ImageRef validation to UUID only https://review.openstack.org/338802 | 06:38 |
| *** ddeja|away is now known as ddeja | 06:39 | |
| *** TravT has quit IRC | 06:40 | |
| *** belmoreira has joined #openstack-nova | 06:42 | |
| *** shaohe_feng has quit IRC | 06:44 | |
| *** shaohe_feng has joined #openstack-nova | 06:44 | |
| *** tesseract- has joined #openstack-nova | 06:45 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Strict ImageRef validation to UUID only https://review.openstack.org/338802 | 06:47 |
| *** moshele has joined #openstack-nova | 06:47 | |
| *** shaohe_feng has quit IRC | 06:54 | |
| *** sridharg has joined #openstack-nova | 06:54 | |
| *** shaohe_feng has joined #openstack-nova | 06:55 | |
| *** thorst has joined #openstack-nova | 06:55 | |
| *** annp has quit IRC | 06:59 | |
| *** tangchen has quit IRC | 07:00 | |
| *** tangchen_ has quit IRC | 07:00 | |
| *** ddeja has left #openstack-nova | 07:01 | |
| *** thorst has quit IRC | 07:03 | |
| *** shaohe_feng has quit IRC | 07:04 | |
| *** shaohe_feng has joined #openstack-nova | 07:05 | |
| *** ihrachys has joined #openstack-nova | 07:14 | |
| *** shaohe_feng has quit IRC | 07:14 | |
| *** jaosorior is now known as jaosorior_brb | 07:15 | |
| *** shaohe_feng has joined #openstack-nova | 07:15 | |
| *** markvoelker has joined #openstack-nova | 07:16 | |
| *** itoader has joined #openstack-nova | 07:17 | |
| openstackgerrit | Paul Carlton proposed openstack/nova-specs: Use libvirt storage pools https://review.openstack.org/310505 | 07:18 |
| *** code-R has quit IRC | 07:20 | |
| *** pcaruana has joined #openstack-nova | 07:21 | |
| *** markvoelker has quit IRC | 07:21 | |
| *** cfriesen_ has quit IRC | 07:21 | |
| openstackgerrit | Paul Carlton proposed openstack/nova-specs: Migrate libvirt volumes https://review.openstack.org/310538 | 07:22 |
| *** links has quit IRC | 07:23 | |
| *** dikonoor has quit IRC | 07:23 | |
| *** jlanoux has joined #openstack-nova | 07:24 | |
| *** ratailor has quit IRC | 07:24 | |
| *** jlanoux has quit IRC | 07:24 | |
| *** shaohe_feng has quit IRC | 07:25 | |
| *** ratailor has joined #openstack-nova | 07:25 | |
| *** paul-carlton2 has joined #openstack-nova | 07:25 | |
| tdurakov | hi folks | 07:25 |
| *** shaohe_feng has joined #openstack-nova | 07:26 | |
| *** jlanoux has joined #openstack-nova | 07:26 | |
| tdurakov | while checking logs for ci job, found that there are lots of warnings from privsep | 07:26 |
| tdurakov | is it something know | 07:26 |
| tdurakov | http://logs.openstack.org/66/329466/4/check/gate-tempest-dsvm-multinode-live-migration/586c6be/logs/subnode-2/screen-n-cpu.txt.gz?level=WARNING | 07:26 |
| *** code-R has joined #openstack-nova | 07:28 | |
| *** ekarlso has quit IRC | 07:29 | |
| *** tiendc has quit IRC | 07:30 | |
| *** TravT has joined #openstack-nova | 07:30 | |
| *** shaohe_feng has quit IRC | 07:35 | |
| *** shaohe_feng has joined #openstack-nova | 07:36 | |
| *** lpetrut has quit IRC | 07:36 | |
| *** links has joined #openstack-nova | 07:36 | |
| *** ekarlso has joined #openstack-nova | 07:37 | |
| *** claudiub has joined #openstack-nova | 07:37 | |
| *** dikonoor has joined #openstack-nova | 07:37 | |
| *** TravT has quit IRC | 07:39 | |
| *** Oku_OS-away is now known as Oku_OS | 07:41 | |
| *** TravT has joined #openstack-nova | 07:44 | |
| *** shaohe_feng has quit IRC | 07:45 | |
| *** shaohe_feng has joined #openstack-nova | 07:46 | |
| *** lpetrut has joined #openstack-nova | 07:46 | |
| *** danpb has joined #openstack-nova | 07:51 | |
| *** itoader has quit IRC | 07:53 | |
| *** TravT has quit IRC | 07:53 | |
| *** markus_z has joined #openstack-nova | 07:54 | |
| *** shaohe_feng has quit IRC | 07:55 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Fix an error in archiving 'migrations' table https://review.openstack.org/323684 | 07:56 |
| *** shaohe_feng has joined #openstack-nova | 07:56 | |
| *** daemontool has joined #openstack-nova | 07:57 | |
| *** TravT has joined #openstack-nova | 07:58 | |
| *** jistr is now known as jistr|training | 07:59 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** amotoki has quit IRC | 08:00 | |
| *** thorst has joined #openstack-nova | 08:01 | |
| *** zzzeek has joined #openstack-nova | 08:02 | |
| *** takashin has left #openstack-nova | 08:03 | |
| *** paul-carlton2 has quit IRC | 08:03 | |
| *** amotoki has joined #openstack-nova | 08:04 | |
| *** lpetrut has quit IRC | 08:04 | |
| *** amotoki has quit IRC | 08:05 | |
| *** shaohe_feng has quit IRC | 08:06 | |
| *** shaohe_feng has joined #openstack-nova | 08:07 | |
| *** coolsvap is now known as coolsvap_ | 08:08 | |
| *** thorst has quit IRC | 08:08 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c https://review.openstack.org/303345 | 08:10 |
| *** markvoelker has joined #openstack-nova | 08:10 | |
| *** jaosorior_brb has quit IRC | 08:12 | |
| *** jaosorior_brb has joined #openstack-nova | 08:13 | |
| *** gjayavelu has quit IRC | 08:14 | |
| *** gjayavelu has joined #openstack-nova | 08:14 | |
| *** TravT has quit IRC | 08:14 | |
| *** markvoelker has quit IRC | 08:14 | |
| *** shaohe_feng has quit IRC | 08:16 | |
| *** amotoki has joined #openstack-nova | 08:17 | |
| *** shaohe_feng has joined #openstack-nova | 08:17 | |
| *** amotoki_ has joined #openstack-nova | 08:18 | |
| *** gjayavelu has quit IRC | 08:19 | |
| *** TravT has joined #openstack-nova | 08:19 | |
| *** amotoki has quit IRC | 08:21 | |
| *** code-R has quit IRC | 08:22 | |
| *** yassine has joined #openstack-nova | 08:23 | |
| *** jaosorior_brb is now known as jaosorior | 08:23 | |
| *** yassine is now known as yassou | 08:23 | |
| *** shaohe_feng has quit IRC | 08:26 | |
| *** baoli has quit IRC | 08:27 | |
| *** paul-carlton2 has joined #openstack-nova | 08:28 | |
| *** shaohe_feng has joined #openstack-nova | 08:29 | |
| *** amotoki_ has quit IRC | 08:29 | |
| *** paul-carlton has joined #openstack-nova | 08:30 | |
| johnthetubaguy | tdurakov: wow, thats a lot. I thought there was a patch to fix that in priv sep, but I could be wrong, maybe we need another patch too | 08:30 |
| danpb | johnthetubaguy: a patch to fix what ? | 08:31 |
| johnthetubaguy | tdurakov: here it is: https://review.openstack.org/#/c/350415/ | 08:32 |
| johnthetubaguy | danpb: all the privsep logs being warning, rather than the correct log level, or debug, or something | 08:32 |
| johnthetubaguy | tdurakov: it follows on from this one: https://review.openstack.org/#/c/339275/ | 08:33 |
| *** shaohe_feng has quit IRC | 08:36 | |
| *** TravT has quit IRC | 08:37 | |
| openstackgerrit | Béla Vancsics proposed openstack/nova: Reduce code duplication and complexity https://review.openstack.org/342187 | 08:37 |
| *** shaohe_feng has joined #openstack-nova | 08:37 | |
| *** gb21 has joined #openstack-nova | 08:40 | |
| *** TravT has joined #openstack-nova | 08:42 | |
| *** RuiChen has joined #openstack-nova | 08:43 | |
| gibi | johnthetubaguy: hi! I've checked the possibility of setUpClass usage for the notification testing. | 08:43 |
| gibi | johnthetubaguy: the biggest problem with it that nova base TestCase class build on setUp | 08:44 |
| *** amotoki has joined #openstack-nova | 08:45 | |
| gibi | johnthetubaguy: if we want to have all the environment set up at setUpClass time then we have to move lot of set up from setUp to setUpClass in TestCase as well | 08:45 |
| gibi | johnthetubaguy: but that will affect all the test in nova | 08:45 |
| gibi | johnthetubaguy: I left some details in the review | 08:46 |
| johnthetubaguy | gibi: hmm, thats odd, what did you need access to? | 08:46 |
| *** shaohe_feng has quit IRC | 08:47 | |
| *** shaohe_feng has joined #openstack-nova | 08:47 | |
| johnthetubaguy | gibi: do you have a link to the review handy? | 08:48 |
| *** gb21 has quit IRC | 08:48 | |
| gibi | johnthetubaguy: I need all the set up to be able to boot an instance | 08:48 |
| gibi | johnthetubaguy: https://review.openstack.org/#/c/342944/ | 08:48 |
| *** priteau has joined #openstack-nova | 08:48 | |
| *** gb21 has joined #openstack-nova | 08:48 | |
| gibi | johnthetubaguy: e.g starting up nova services | 08:49 |
| openstackgerrit | Andrey Volkov proposed openstack/python-novaclient: Add support for microversion 2.33 https://review.openstack.org/349547 | 08:49 |
| johnthetubaguy | gibi: oops, true | 08:49 |
| gibi | johnthetubaguy: also fixtures does not play well with setUpClass | 08:49 |
| *** jistr|training is now known as jistr | 08:49 | |
| johnthetubaguy | yeah, its a little bit of an anti-pattern I guess, so that makes sense | 08:50 |
| johnthetubaguy | gibi: thanks for looking, it probably means what you have is the best option | 08:50 |
| gibi | johnthetubaguy: If we want to spare some (e.g a lot of :)) instance boots in the test then we can do what I propose quite easly but doing that via setUpClass needs a lot more effort | 08:51 |
| johnthetubaguy | gibi: +1 | 08:52 |
| gibi | johnthetubaguy: thanks for the review | 08:52 |
| *** amotoki has quit IRC | 08:53 | |
| johnthetubaguy | gibi: sorry for the wild goose chase there, it was educational at least | 08:53 |
| gibi | johnthetubaguy: no problem, I also learned a good lesson during the investigation | 08:53 |
| *** eliqiao has quit IRC | 08:54 | |
| gibi | johnthetubaguy: there are some other improvements proposed in the notification area, if you have some review bandwidth | 08:54 |
| *** ihrachys has quit IRC | 08:54 | |
| gibi | johnthetubaguy: https://review.openstack.org/#/c/341422/ reservation_id handling cleanup in the sample test | 08:54 |
| gibi | johnthetubaguy: https://review.openstack.org/#/c/344170/ doc generation improvement | 08:54 |
| *** code-R has joined #openstack-nova | 08:54 | |
| *** eliqiao has joined #openstack-nova | 08:55 | |
| kaisers | mdbooth: Hi! Regarding your questions i'm trying to answer in order: | 08:55 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Fix python35 job failures https://review.openstack.org/344151 | 08:55 |
| *** TravT has quit IRC | 08:56 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Fix python35 job failures https://review.openstack.org/344151 | 08:57 |
| mdbooth | kaisers: Thanks. What TZ are you in, btw? | 08:57 |
| *** shaohe_feng has quit IRC | 08:57 | |
| *** shaohe_feng has joined #openstack-nova | 08:58 | |
| tdurakov | johnthetubaguy: I see thanks, so are folks going to merge these loging improvements into privsep? | 08:58 |
| mdbooth | kaisers: Regarding the revert, I've proposed this: https://review.openstack.org/#/c/349541/ | 08:58 |
| *** code-R has quit IRC | 08:59 | |
| johnthetubaguy | tdurakov: hopefully, looks like angus uploaded the fix he wanted doing, so that should mean we are closer now | 08:59 |
| mdbooth | kaisers: Quobyte CI doesn't seem to have voted on it yet, though, which is annoying :/ | 08:59 |
| *** hshiina has quit IRC | 09:00 | |
| *** TravT has joined #openstack-nova | 09:00 | |
| tdurakov | johnthetubaguy: hope so:) | 09:00 |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Use fake_imagebackend in functional https://review.openstack.org/345553 | 09:01 |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Remove some unnecessary mocking in test_driver https://review.openstack.org/333979 | 09:01 |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Create console.log consistently https://review.openstack.org/349541 | 09:01 |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Improve mocking of imagebackend disks https://review.openstack.org/333242 | 09:01 |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Pass object to _create_images_and_backing in test https://review.openstack.org/333243 | 09:01 |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Reset can_fallocate in test setUp() https://review.openstack.org/344168 | 09:01 |
| *** amotoki has joined #openstack-nova | 09:02 | |
| *** rmart04 has joined #openstack-nova | 09:03 | |
| kaisers | mdbooth: qemu is running with nova:cinder in our systems, the CI uses ubuntu:ubuntu in a devstack env. | 09:04 |
| *** markvoelker has joined #openstack-nova | 09:04 | |
| *** gb21 has quit IRC | 09:05 | |
| *** thorst has joined #openstack-nova | 09:06 | |
| mdbooth | kaisers: Why do nova and cinder require the same write permissions? Is cinder touching the nova instances directory at any point? | 09:06 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif: Updated from global requirements https://review.openstack.org/339919 | 09:06 |
| mdbooth | kaisers: Incidentally, I just pushed https://review.openstack.org/#/c/349541/ to the front of my queue because it was causing me problems locally. If you could run it against your CI that would be great. | 09:07 |
| kaisers | mdbooth: regarding same instance storage: Quobyte is a shared file system, volumes are provided in Nova by mounting the Quobyte Cinder volume on a given compute host. Does that answer your question? | 09:07 |
| *** shaohe_feng has quit IRC | 09:07 | |
| mdbooth | kaisers: Where are they mounted? | 09:08 |
| *** shaohe_feng has joined #openstack-nova | 09:08 | |
| *** roeyc has joined #openstack-nova | 09:08 | |
| kaisers | mdbooth: Why console.log is created with root:root ownership despite qemu running as non-root i did not understand, too. I'm happy for ideas on this. | 09:08 |
| mdbooth | kaisers: It's created by libvirt, which is running as root. | 09:09 |
| *** markvoelker has quit IRC | 09:09 | |
| mdbooth | libvirt expects to change its ownership when it launches. | 09:09 |
| mdbooth | As danpb mentioned, I suspect this model is broken in other cases, btw. | 09:09 |
| *** TravT has quit IRC | 09:10 | |
| mdbooth | I'd want to go audit the nova driver to see everywhere to do stuff as root. | 09:10 |
| *** gb21 has joined #openstack-nova | 09:10 | |
| mdbooth | The Quobyte CI setup just sounds fragile to me. If I were you I'd invest some time in making the change danpb suggests to tell libvirt to leave the quobyte volumes alone. | 09:11 |
| kaisers | danpb: mriedem: i saw your pointer to the Quobyte CI/driver topic, thanks for that. I opened a ticket to provide a place where to discuss / improve this: https://bugs.launchpad.net/nova/+bug/1609298 | 09:11 |
| openstack | Launchpad bug 1609298 in OpenStack Compute (nova) "libvirt should not require dynamic_ownership off for secure Cinder/Quobyte settings" [Undecided,New] | 09:11 |
| danpb | kaisers: why does the CI system turn off dynamic_ownership is the biggest question - that is certainly the wrong thing to do | 09:11 |
| danpb | kashyap: if quobyte requires that its voliumes are not chown'd, then we should use a <seclabel> to stop it, never dynamic_ownership | 09:12 |
| *** annp has joined #openstack-nova | 09:12 | |
| *** annp_ has joined #openstack-nova | 09:13 | |
| danpb | mdbooth: i'm looking at your change here https://review.openstack.org/#/c/333243/17/nova/tests/unit/virt/libvirt/test_driver.py | 09:13 |
| pkholkin | mriedem: Hi Matt, could you please look this patch with tests https://review.openstack.org/347462 | 09:13 |
| danpb | mdbooth: and struggling to understand how the hell tests currently succeeed !??! | 09:13 |
| *** thorst has quit IRC | 09:13 | |
| *** annp has left #openstack-nova | 09:13 | |
| *** annp_ has quit IRC | 09:14 | |
| mdbooth | danpb: Could well be because it's not really testing anything | 09:14 |
| danpb | mdbooth: afaict, _fetch_isntance_kerneLramdisk will call utils.get_instance_path which calls instance.name | 09:14 |
| danpb | which will break when given a dict | 09:14 |
| *** TravT has joined #openstack-nova | 09:14 | |
| mdbooth | utils != utils | 09:14 |
| mdbooth | utils == fake_utils | 09:14 |
| mdbooth | iirc | 09:14 |
| danpb | oh wait, no, its mocked out the _fetch_instancE_kernel_ramdisk method entirely | 09:14 |
| kaisers | mdbooth: mriedem: danpb: I just worked through the irc history, just catching up with the lower end now, sorry. I'm in TZ UTC+2. | 09:14 |
| mdbooth | danpb: Or that. We over-mock all over the place :/ | 09:15 |
| kaisers | mdbooth: yep, i saw you're new change, will check this | 09:15 |
| danpb | and god i hate that fake_libvirt_Utils even exists | 09:15 |
| *** EinstCrazy has quit IRC | 09:15 | |
| danpb | we should kill that someday and just have tests mockk out the individual utils methods that are relevant to them | 09:15 |
| mdbooth | kaisers: I'd work backwards if I were you :) If you go backwards you'll find where people answered their own previous questions. | 09:15 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Fix python35 job failures https://review.openstack.org/344151 | 09:16 |
| *** EinstCrazy has joined #openstack-nova | 09:16 | |
| mdbooth | danpb: Some of these tests are really dumb, basically pro-forma. | 09:16 |
| mdbooth | danpb: Incidentally, chances are I had to make that change because I removed some mocking and hit the actual error. | 09:17 |
| *** shaohe_feng has quit IRC | 09:17 | |
| *** shaohe_feng has joined #openstack-nova | 09:18 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Fix python35 job failures https://review.openstack.org/344151 | 09:18 |
| kaisers | mdbooth: yep, in hindsight probably better. :) | 09:18 |
| mdbooth | kaisers: Thanks for poking the CI. Any idea what its response time is like right now? | 09:20 |
| kaisers | mdbooth: ~1h | 09:20 |
| mdbooth | kaisers: Awesome, thanks. | 09:20 |
| *** xinliang has quit IRC | 09:21 | |
| kaisers | danpb: reason for dynamic_ownership=0 is described in https://bugs.launchpad.net/nova/+bug/1609298 , pls ping me if i can provide further info | 09:22 |
| openstack | Launchpad bug 1609298 in OpenStack Compute (nova) "libvirt should not require dynamic_ownership off for secure Cinder/Quobyte settings" [Undecided,New] | 09:22 |
| *** null0 has joined #openstack-nova | 09:23 | |
| *** TravT has quit IRC | 09:23 | |
| *** tangchen has joined #openstack-nova | 09:24 | |
| kaisers | mdbooth: Regarding where the volumes are mounted: The Nova driver mounts a Quobyte volume containing the Cinder volume files at a configurable mount point in the local file system, when running instances of a Quobyte based Cinder volume. | 09:25 |
| *** gb21 has quit IRC | 09:25 | |
| kaisers | mdbooth: please note that there's a difference between a Quobyte volume, which is a volume in Quobyte, and a Cinder volume which is in essence an image file on a Quobyte volume in our drivers. | 09:26 |
| *** lpetrut has joined #openstack-nova | 09:26 | |
| *** shaohe_feng has quit IRC | 09:28 | |
| mdbooth | kaisers: Got it, thanks. | 09:28 |
| *** shaohe_feng has joined #openstack-nova | 09:28 | |
| mdbooth | kaisers: I think that answers my main concern. From the original bug report I had (fortunately erroneously) understood that cinder was writing to files owned by Nova. | 09:29 |
| openstackgerrit | Gleb Stepanov proposed openstack/nova: Skip malformed cookies https://review.openstack.org/346090 | 09:29 |
| mdbooth | IIUC it's not doing that. It just needs to be able to write to cinder volumes with common ownership. | 09:29 |
| kaisers | mdbooth: ah, ok. No, cinder (driver) does not touch those. | 09:30 |
| kaisers | mdbooth: Makes me think where i can clarify the env better in the tickets... | 09:31 |
| *** null0 has quit IRC | 09:33 | |
| kaisers | mdbooth: correct (regarding your last question), Nova needs to be able to write to the cinder volume files. | 09:36 |
| *** shaohe_feng has quit IRC | 09:38 | |
| *** shaohe_feng has joined #openstack-nova | 09:39 | |
| openstackgerrit | Gleb Stepanov proposed openstack/nova: [WIP] Init allocated ports set https://review.openstack.org/347479 | 09:40 |
| openstackgerrit | Pawel Koniszewski proposed openstack/nova: [libvirt] Remove live_migration_flag & block_migration_flag https://review.openstack.org/334860 | 09:41 |
| openstackgerrit | Pawel Koniszewski proposed openstack/nova: Change default value of live_migration_tunnelled to False https://review.openstack.org/350480 | 09:41 |
| lpetrut | Hi, any chance anyone could take a look over this patch, updating the HyperV live migrate data object? https://review.openstack.org/#/c/347435/3 We need this in order to fix our issues regarding shared storage. This is part of a series, fixing our issues on this matter. | 09:44 |
| *** xinliang has joined #openstack-nova | 09:44 | |
| *** Qiming has quit IRC | 09:46 | |
| *** roeyc has quit IRC | 09:47 | |
| *** shaohe_feng has quit IRC | 09:48 | |
| *** code-R has joined #openstack-nova | 09:49 | |
| *** shaohe_feng has joined #openstack-nova | 09:49 | |
| *** Qiming has joined #openstack-nova | 09:50 | |
| *** edand has joined #openstack-nova | 09:51 | |
| *** TravT has joined #openstack-nova | 09:51 | |
| *** code-R has quit IRC | 09:53 | |
| tdurakov | danpb: hey, are you around? | 09:55 |
| *** TravT has quit IRC | 09:56 | |
| *** yamahata has joined #openstack-nova | 09:56 | |
| tdurakov | danpb, pkoniszewski https://review.openstack.org/#/c/350480/1 - do you think it's worth to log warning for operator that there is no tunneled flag any more, or it's enough to have release notes? | 09:56 |
| pkoniszewski | tdurakov: i don't think that warning is required there, reno might be | 09:56 |
| danpb | yeah certainly no warning is appropriate | 09:57 |
| openstackgerrit | xiexs proposed openstack/nova-specs: Make API errors conform to API-WG schema https://review.openstack.org/307675 | 09:57 |
| tdurakov | pkoniszewski, danpb kk, than only reno is needed | 09:57 |
| *** Jaison has joined #openstack-nova | 09:58 | |
| *** markvoelker has joined #openstack-nova | 09:58 | |
| *** shaohe_feng has quit IRC | 09:58 | |
| *** links has quit IRC | 09:59 | |
| *** shaohe_feng has joined #openstack-nova | 09:59 | |
| openstackgerrit | Pawel Koniszewski proposed openstack/nova: Change default value of live_migration_tunnelled to False https://review.openstack.org/350480 | 10:00 |
| *** fwiesel has joined #openstack-nova | 10:00 | |
| openstackgerrit | Pawel Koniszewski proposed openstack/nova: [libvirt] Remove live_migration_flag & block_migration_flag https://review.openstack.org/334860 | 10:01 |
| *** chenfei has quit IRC | 10:02 | |
| *** chenfei has joined #openstack-nova | 10:02 | |
| *** fwiesel is now known as fabianw | 10:03 | |
| *** markvoelker has quit IRC | 10:04 | |
| *** TravT has joined #openstack-nova | 10:05 | |
| fabianw | Hi, is anyone knowledgeable about the "nova.virt.vmwareapi.vm_util.get_vmdk_info" here? I'm curious, how it is supposed to work. As I understand it, it is trying to get the root-disk based on the VMDK name | 10:07 |
| fabianw | Which a) fails for me right now, and b) I am not sure how it is supposed to work, since the vcenter renames the files practically at will | 10:08 |
| *** shaohe_feng has quit IRC | 10:09 | |
| *** fragatina has quit IRC | 10:09 | |
| *** shaohe_feng has joined #openstack-nova | 10:09 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c https://review.openstack.org/303345 | 10:10 |
| openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova: Ensure that periodic reclaim cleans DB deleted instances https://review.openstack.org/323250 | 10:10 |
| *** yamahata has quit IRC | 10:11 | |
| *** thorst has joined #openstack-nova | 10:11 | |
| *** ManishD has joined #openstack-nova | 10:12 | |
| *** Wenzhi has quit IRC | 10:12 | |
| *** Qiming has quit IRC | 10:12 | |
| *** chenfei has quit IRC | 10:12 | |
| *** bhagyashris has joined #openstack-nova | 10:12 | |
| *** Wenzhi has joined #openstack-nova | 10:13 | |
| *** kevinz has quit IRC | 10:13 | |
| *** TravT has quit IRC | 10:14 | |
| ManishD | HI, I am running into one case:-- 1. Attach FC and ICSI volume to single instance (same instance) -- Successful 2. Detach ICSI volume -- Successful 3. Reattach ICSI volume -- Error :- 24 - iSCSI login failed due to authorization failure | 10:15 |
| *** serverascode has quit IRC | 10:15 | |
| ManishD | please can someone help | 10:15 |
| *** bhagyashri has quit IRC | 10:16 | |
| *** Dinesh_Bhor has quit IRC | 10:16 | |
| *** serverascode has joined #openstack-nova | 10:16 | |
| *** Dinesh_Bhor has joined #openstack-nova | 10:17 | |
| *** Qiming has joined #openstack-nova | 10:17 | |
| *** thorst has quit IRC | 10:18 | |
| *** gb21 has joined #openstack-nova | 10:18 | |
| *** chenfei has joined #openstack-nova | 10:18 | |
| *** TravT has joined #openstack-nova | 10:18 | |
| paul-carlton2 | danpb, looking at your comments on storage pools spec and thinking I may have missed something with live migration. I think the problem is it is not nova but libvirt/qemu that creates the instance on the target by copying the domain.xml from the source, nova just creates items like underlay files for qcow2 disks etc | 10:19 |
| *** shaohe_feng has quit IRC | 10:19 | |
| paul-carlton2 | danpb, I was thinking live migration could be used to create a new instance on the target with new disk layout | 10:20 |
| *** shaohe_feng has joined #openstack-nova | 10:20 | |
| tdurakov | danpb could you please take a look, when have time https://review.openstack.org/#/c/348284/ | 10:20 |
| *** rfolco has joined #openstack-nova | 10:20 | |
| paul-carlton2 | danpb, I can investigate this further to see if there is anyway to get the target instance created with new disk locations | 10:21 |
| tdurakov | danpb: oh, already, will update it soon) | 10:21 |
| danpb | paul-carlton2: if you have NFS for the instances directory there's no point at which you create new disk on the target | 10:21 |
| danpb | paul-carlton2: as the disks already exist | 10:21 |
| danpb | if you don't have shared storage, then nova could update the libvirt xml to point to the new location | 10:22 |
| paul-carlton2 | danpb, agreed, but in the non shared case | 10:22 |
| danpb | we have to assume some people will have NFS though | 10:22 |
| paul-carlton2 | danpb, that is what I was hoping | 10:22 |
| danpb | tdurakov: err i already commented on it and its not been addressed | 10:23 |
| paul-carlton2 | danpb, if the disks are shared via NFS live migration will detect this and not copy the disks which means live migration won't ffer an opportunity to move the disk? | 10:24 |
| danpb | paul-carlton2: exactly | 10:24 |
| paul-carlton2 | danbp but we could still fix up the instance xml on the target and copy the disk to the new location before letting the target instance be created? | 10:25 |
| *** rfolco has quit IRC | 10:25 | |
| danpb | paul-carlton2: the whole point of NFS is that you're not copying disk images | 10:26 |
| *** hoangcx has quit IRC | 10:27 | |
| danpb | and iirc nova will refuse to let you request block migration if using nfs, as that would ordinarily cause corruption as the target overwrote the existing image | 10:28 |
| paul-carlton2 | danpb, agreed, but as a special case if the live migration detects it is migrating and old style instance it could use 'mv' to rename the file, the source would continue to access it via the existing open and the target would open it in the new location because we changed its xml to say find this disk here? | 10:29 |
| *** shaohe_feng has quit IRC | 10:29 | |
| *** amotoki has quit IRC | 10:30 | |
| *** shaohe_feng has joined #openstack-nova | 10:30 | |
| *** rodrigods has quit IRC | 10:30 | |
| *** rodrigods has joined #openstack-nova | 10:30 | |
| *** TravT has quit IRC | 10:32 | |
| danpb | paul-carlton2: you'd need logic to move it back to the orginal location on migration failure too | 10:34 |
| paul-carlton2 | danpb, agreed, I'll update spec and will try this out to verify there are no hidden issues | 10:35 |
| danpb | paul-carlton2: also what happens if you have a vm running on new nova, and live migration wants to move it to an old nova with old layout | 10:35 |
| danpb | afaik, we have to cope with live migration in both directions | 10:36 |
| danpb | likewise if guest state is saved on a new node, and resumed on an old node, we're doomed | 10:36 |
| paul-carlton2 | danpb, new to old would not be allowed, I came across this in my implementation of live migration of rescued instances | 10:36 |
| danpb | because the old node won't have the disk in the right location for the saved xml state | 10:37 |
| danpb | paul-carlton2: i don't think we can simply rule out new to old in that way | 10:37 |
| danpb | its a pretty significant restriction on deployments during process of updating their compute nods | 10:38 |
| paul-carlton2 | danpb, I got feed back that all compute nodes need to be at same level before live migration would be allowed if I recall correctly, I'll check | 10:38 |
| *** chenfan has quit IRC | 10:38 | |
| danpb | anyway this is all stuff needed in the spec | 10:38 |
| paul-carlton2 | danpb, I agreed I had code to detect the version of the target node but was told to remove it | 10:38 |
| *** amotoki has joined #openstack-nova | 10:39 | |
| *** EinstCrazy has quit IRC | 10:39 | |
| *** EinstCrazy has joined #openstack-nova | 10:39 | |
| danpb | paul-carlton2: wasn't that related to RPC API versions | 10:39 |
| *** shaohe_feng has quit IRC | 10:39 | |
| paul-carlton2 | danpb, agreed, need to update it but first we need to agree on if new to old support is required, I think not | 10:40 |
| johnthetubaguy | mikal: did you see the questions for you here: https://review.openstack.org/#/c/334956 | 10:40 |
| *** shaohe_feng has joined #openstack-nova | 10:40 | |
| *** amotoki has quit IRC | 10:41 | |
| johnthetubaguy | paul-carlton2: folks do use live-migrate to perform the upgrade of their nodes, so we certainly need old -> new, it seems a shame to break the reverse if we don't have to I guess | 10:41 |
| paul-carlton2 | danpb, yep, I was getting RPC API version of target host and making sure it was at the level needed to support new feature with out worrying that other hosts in the clouds might not yet be updated but I was advised to simply check for minimum version of all comoute nodes and prevent live migration of rescused instances till that was at the right level, I wasn't happy but accepted the guidance | 10:42 |
| danpb | new -> old is pretty critical in the early stages of upgrade process where the number new nods is tiny compared to number of old nodes | 10:42 |
| *** code-R has joined #openstack-nova | 10:43 | |
| paul-carlton2 | johnthetubaguy, old to new is alway supported | 10:43 |
| danpb | paul-carlton2: i think that's a different scenario becasue migration os rescued instances is a new feature | 10:43 |
| danpb | paul-carlton2 ie you were not breaking an existing scenario - you were simply not adding a new scenario | 10:43 |
| johnthetubaguy | paul-carlton2: there was a test in the grenade multi-node job that mriedman created as a temporary thing that did a move old to new and new to old, we might be able to add that properly now, but tdurakov might have more details on that | 10:43 |
| johnthetubaguy | ah... | 10:43 |
| johnthetubaguy | yeah, we did say, migration of rescued things is a new feature | 10:44 |
| *** EinstCrazy has quit IRC | 10:44 | |
| johnthetubaguy | so for simplicity, you only allow the new feature once all nodes are upgraded | 10:44 |
| danpb | with the movement of disk image locations, you would be breaking existing valid feature | 10:44 |
| johnthetubaguy | I admit that doesn't help with the upgrade till a cycle later, which does suck a bit | 10:44 |
| danpb | so that would basically imply you would have to add code for the new disk layout in ocata, but not actually use that code until Pxxxx | 10:45 |
| johnthetubaguy | well you use the code once the upgrade is complete, i.e. its tested in the gate right away? | 10:46 |
| paul-carlton2 | johnthetubaguy, danpb I think it is reasonable to disallow new to old, surely all compute nodes should be updated within a short period? | 10:46 |
| johnthetubaguy | paul-carlton2: short might be a week I guess? | 10:46 |
| danpb | paul-carlton2: depends on the scale of your deployment - i could easily imagine it taking weeks or more | 10:46 |
| paul-carlton2 | I played with this for live migration of rescued instances and found that I could detect the RPC API level of the specific target node | 10:47 |
| *** code-R has quit IRC | 10:47 | |
| paul-carlton2 | and prevent migration to that node. | 10:47 |
| *** eliqiao has quit IRC | 10:47 | |
| johnthetubaguy | danpb I don't get the comment about having to wait till Pxxx, am I missing something? | 10:47 |
| danpb | johnthetubaguy: if you start using the new disk layout on a new VM on a Ocata node, that'd prevent it being live migrated to an Newton node | 10:48 |
| danpb | johnthetubaguy: so if you add support for the new layout in Ocata, but don't actually start launching VMS with the new layout until P | 10:48 |
| paul-carlton2 | If the node is up it should be upgraded by deployment tooling within a few hours, if it is down when it restarts nova compute has to be upgrade before it can rejoin | 10:49 |
| danpb | johnthetubaguy: then you preserve the ability to live migration from Ocata to Newton | 10:49 |
| *** Jaison has quit IRC | 10:49 | |
| danpb | johnthetubaguy: and also enable migration from Pxxxx to Ocata (both support new layout) | 10:49 |
| *** shaohe_feng has quit IRC | 10:50 | |
| *** shaohe_feng has joined #openstack-nova | 10:50 | |
| paul-carlton2 | I'm reasonably happy with an approach that implements this across two releases but still contend that as mentioned above new to old scenario can be blocked without operational issues | 10:51 |
| *** eliqiao has joined #openstack-nova | 10:51 | |
| johnthetubaguy | danpb: ah, gotcha. so I guess post live-migrate you would get the new disk layout? | 10:51 |
| *** gongysh_ has quit IRC | 10:52 | |
| johnthetubaguy | we could just only start using the new layout post upgrade, and support old a new layouts for a little bit? | 10:52 |
| *** chenfan has joined #openstack-nova | 10:52 | |
| johnthetubaguy | so create new VMs with old layouts until the upgrade completes | 10:52 |
| *** links has joined #openstack-nova | 10:53 | |
| danpb | johnthetubaguy: yeah, i guess you could do that - we'd need to have some config option to say whether to use the new layout | 10:53 |
| johnthetubaguy | we can detect that, using min_service version | 10:53 |
| danpb | oh, i guess we could do that | 10:54 |
| danpb | this would also solve the save/restore problem | 10:54 |
| paul-carlton2 | danpb, johnthetubaguy, my point is we can prevent new to old migrations, most of the cloud should be upgraded within hours, what scenario am I missing? | 10:54 |
| danpb | paul-carlton2: no, we absolutely cannot assumed every compute node is upgraded with hours | 10:55 |
| *** sdague has joined #openstack-nova | 10:55 | |
| johnthetubaguy | yeah, within hours isn't a reasonable assumption, sadly | 10:55 |
| danpb | we have to assume it can be spread over weeeks | 10:55 |
| *** zerda2 has quit IRC | 10:55 | |
| johnthetubaguy | live-migrates put a large load on the system, so you need to stagger them | 10:55 |
| paul-carlton2 | danpb, johnthetubaguy , ok | 10:56 |
| danpb | it can also kill VM performance while going on | 10:56 |
| danpb | so some places may need to get end user buyin to schedule migration at a specific convenient time | 10:56 |
| paul-carlton2 | danpb, surely we can have saved instances that remain saved for months, thus preventing us turning on new format? | 10:56 |
| danpb | paul-carlton2: you would still need code to re-write the XML before restoring them | 10:57 |
| *** dikonoor has quit IRC | 10:57 | |
| danpb | it just avoids possibility of new VMs with new layout being restored on old nodes, if we wait for min_service cap | 10:57 |
| paul-carlton2 | danpb agreed, that is not a problem | 10:57 |
| paul-carlton2 | danpb, you mean a saved instance might be cold migrated from new to old? | 10:58 |
| paul-carlton2 | danpb does cold migration actually copy the qemu save file? | 10:59 |
| *** shaohe_feng has quit IRC | 11:00 | |
| danpb | paul-carlton2: i don't think it copies the qemu save file, but the save file could be on nfs | 11:00 |
| paul-carlton2 | danpb, If we need to support live and cold migration from new to old I need to think about this some more. | 11:01 |
| *** shaohe_feng has joined #openstack-nova | 11:01 | |
| gcb | johnthetubaguy, I just saw you approved https://review.openstack.org/325761 . In fact, there is a series of checking config options in tests https://review.openstack.org/#/q/topic:bug/1517839+status:open+project:openstack/nova | 11:02 |
| paul-carlton2 | danpb, I think it is doable, possibly with a two step upgrade, do we support upgrade from N to N+2, ie Mitka to Ocata? | 11:02 |
| gcb | they are in a stack, and enforce type check in the last commit , So would be nic if you can review others when you'r free. :-) | 11:04 |
| *** gszasz has joined #openstack-nova | 11:04 | |
| danpb | paul-carlton2: we only ever allow N to N+1 | 11:04 |
| *** kolesovdv has joined #openstack-nova | 11:04 | |
| paul-carlton2 | danpb, good then we could implement code in Ocata to support all this but not use the new format unless the operator sets a flag to say use it in which case they are saying new to old is not an issue because they have all nodes on Ocata? | 11:06 |
| johnthetubaguy | gcb: ah, cool, I didn't got digging very far, just trying to kill off changes waiting for another +2, will put those on my list of later | 11:07 |
| paul-carlton2 | danpb, in P we'd remove the flag and the new format would become the default, because Ocata code would know how to support new format to old | 11:08 |
| danpb | paul-carlton2: as johnthetubaguy said, we don't need a flag | 11:08 |
| gcb | johnthetubaguy, thanks | 11:08 |
| danpb | paul-carlton2: we can look to see if the min api version is older than Ocata, and if it is, then assume we have to continue using old layout | 11:08 |
| paul-carlton2 | danpb, you mean check min version on every instance create, rebuild etc and use new format if it is Ocata? | 11:09 |
| danpb | yes | 11:10 |
| *** shaohe_feng has quit IRC | 11:10 | |
| *** sameo has joined #openstack-nova | 11:10 | |
| danpb | nb, this would imply 2 live migrations of each VM before they use the new layout | 11:10 |
| danpb | after first live migration from Newton to Ocata they'll still be using old layout | 11:11 |
| *** shaohe_feng has joined #openstack-nova | 11:11 | |
| danpb | after second live migration from Ocata to Ocata, they'll be using new layout (assuming all Newton nodes have been killed at that point) | 11:11 |
| johnthetubaguy | yeah, that sounds right | 11:11 |
| *** roeyc has joined #openstack-nova | 11:12 | |
| johnthetubaguy | I don't think we can assume people use live-migrate to do upgrade, so there will be older instances around using the old layout, basically for ever | 11:12 |
| paul-carlton2 | danpb, johnthetubaguy surely if you live migrate an instance after min version reaches Ocata then it will upgrader to new format? | 11:12 |
| *** roeyc has quit IRC | 11:13 | |
| johnthetubaguy | yeah, thats when you to Ocata to Ocata though, or Ocata to P | 11:13 |
| johnthetubaguy | oh, hang on, yeah | 11:13 |
| paul-carlton2 | danpb, johnthetubaguy, the old format needs to be supported till every instances has been rebuit, hard rebooted or live migrated | 11:14 |
| johnthetubaguy | it would be Newton to Newton that starting changing things, if we merge it in Newton | 11:14 |
| johnthetubaguy | paul-carlton2: right, which is basically until the end of time | 11:14 |
| paul-carlton2 | johnthetubaguy, we won't get this into Newton now | 11:14 |
| *** diga has quit IRC | 11:14 | |
| paul-carlton2 | johnthetubaguy, my proposal was we enforce an end date, maybe Q but maybe that won't fly? | 11:16 |
| *** thorst has joined #openstack-nova | 11:16 | |
| danpb | Newton is out of the question - we're not getting any of this into that | 11:17 |
| *** gb21 has quit IRC | 11:17 | |
| paul-carlton2 | danpb, johnthetubaguy I was thinking we'd provide a utility to identify instances still using the legacy disk layout so that operators can live migrate their instances before moving to Q or whatever the cutoff is | 11:18 |
| danpb | paul-carlton2: if we can make live migration do the right thing with conversions, then we can be fairly aggresive with removing code for old layout - Q would be reasonable | 11:18 |
| paul-carlton2 | danpb, agreed | 11:18 |
| danpb | paul-carlton2: if on the other hand we require a cold reboot, then we'd have to keep the old code around for many many many releases | 11:18 |
| paul-carlton2 | danpb, agreed, we can't enforce instance restart, I know an MOD Tandem system that they did not reboot for 14 years! | 11:20 |
| *** abalutoiu has joined #openstack-nova | 11:20 | |
| *** shaohe_feng has quit IRC | 11:20 | |
| *** lucasagomes is now known as lucas-hungry | 11:21 | |
| *** rfolco has joined #openstack-nova | 11:22 | |
| paul-carlton2 | danpb, johnthetubaguy will update spec and do some testing to make we can implement it so live migration does old to new conversion for all scenarios | 11:22 |
| johnthetubaguy | yeah, I would just make it start doing the conversions only once min_version reaches the point we add the new layout support, I guess? | 11:23 |
| *** gb21 has joined #openstack-nova | 11:23 | |
| *** shaohe_feng has joined #openstack-nova | 11:24 | |
| *** roeyc has joined #openstack-nova | 11:25 | |
| *** thorst has quit IRC | 11:25 | |
| *** rfolco has quit IRC | 11:26 | |
| *** bvanhav has joined #openstack-nova | 11:27 | |
| aloga | paul-carlton2, johnthetubaguy, danpb: a couple of commends regarding the previous discussion, from an ops point of view :) | 11:28 |
| *** ManishD has quit IRC | 11:28 | |
| aloga | paul-carlton2, johnthetubaguy, danpb: you cannot assume that the upgrade from N to N+1 is done in hours, I would say that weeks is a much more reasonable timeframe | 11:28 |
| johnthetubaguy | aloga: agreed, thats certainly what I am seeing as an operator | 11:29 |
| johnthetubaguy | aloga: well, if you include live-migrate | 11:29 |
| aloga | paul-carlton2, johnthetubaguy, danpb: and the same goes for the migration/reboot/whatever | 11:29 |
| johnthetubaguy | without live-migrate, I think we are doing around 1k nodes per hour ish, last time I checked | 11:30 |
| aloga | I mean, sometines you cannot simply restart a VM, as the workload can be lost (for instance MPI computing requiring coordination between nodes) | 11:30 |
| johnthetubaguy | aloga: so we can never restart a VM | 11:31 |
| openstackgerrit | Pavel Kholkin proposed openstack/nova: removed db_exc.DBDuplicateEntry in bw_usage_update https://review.openstack.org/250807 | 11:31 |
| *** shaohe_feng has quit IRC | 11:31 | |
| aloga | or long-running VMs | 11:31 |
| *** edand has quit IRC | 11:31 | |
| *** shaohe_feng has joined #openstack-nova | 11:32 | |
| aloga | johnthetubaguy: well, we're not a commercial site, so we can reboot things without losing money | 11:32 |
| johnthetubaguy | yeah, it varies | 11:32 |
| aloga | johnthetubaguy: but sometimes, critial computations cannot be stopped in several days | 11:32 |
| johnthetubaguy | as a service provider, its basically never, unless the sky is falling down | 11:32 |
| aloga | johnthetubaguy: indeed | 11:32 |
| aloga | I do not know if stablishing a timeframe for the migration could be reasonable for other folks | 11:34 |
| aloga | for us it would be OK, assuming that it is large enough :) | 11:34 |
| * johnthetubaguy goes for lunch | 11:36 | |
| aloga | johnthetubaguy: enjoy | 11:36 |
| *** code-R has joined #openstack-nova | 11:37 | |
| *** fabianw has quit IRC | 11:37 | |
| *** sudipto has quit IRC | 11:40 | |
| *** thorst has joined #openstack-nova | 11:41 | |
| *** shaohe_feng has quit IRC | 11:41 | |
| *** shaohe_feng has joined #openstack-nova | 11:42 | |
| *** code-R has quit IRC | 11:42 | |
| tdurakov | mdbooth: hey, are you around? | 11:43 |
| mdbooth | tdurakov: Yup. | 11:44 |
| andreykurilin | johnthetubaguy: hi! Can you put your +2 for https://review.openstack.org/#/c/344151/ ? :) it is about py35 support in novaclient | 11:44 |
| *** smatzek has joined #openstack-nova | 11:45 | |
| *** hshiina has joined #openstack-nova | 11:45 | |
| jroll | jaypipes: dansmith: given the networking feature is bumping the minimum anyway, are we good on https://review.openstack.org/#/c/345082/ then? | 11:45 |
| tdurakov | mdbooth: got question on this(want to be sure I understand this change properly) https://review.openstack.org/#/c/344168/6 why you change order of calls only for EncryptedLvmTestCase, while there are several classes that also inherits from _ImageTestCase ? | 11:45 |
| *** coolsvap_ is now known as coolsvap | 11:45 | |
| mdbooth | tdurakov: TBH, this will have been simply a case of me attempting to boil slightly less ocean. | 11:46 |
| mdbooth | I'll have spotted the test failure, and fixed it locally. | 11:46 |
| mdbooth | I don't think I spent a week deliberating on this one. | 11:46 |
| tdurakov | mdbooth: ok, so the bug you trying to fix affects only EncryptedLvmTestCase, right? | 11:47 |
| danpb | tdurakov: the other test clases already have the call in the correct order | 11:47 |
| danpb | EncryptedLvmTestCase was the only one that was in a different order | 11:48 |
| tdurakov | danpb: ok | 11:48 |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Set enforce_type=True in method flags https://review.openstack.org/325743 | 11:48 |
| *** shaohe_feng has quit IRC | 11:51 | |
| *** shaohe_feng has joined #openstack-nova | 11:52 | |
| *** markvoelker has joined #openstack-nova | 11:52 | |
| openstackgerrit | Andrey Volkov proposed openstack/python-novaclient: Add support for microversion 2.33 https://review.openstack.org/349547 | 11:53 |
| *** shaohe_feng has quit IRC | 12:01 | |
| *** shaohe_feng has joined #openstack-nova | 12:02 | |
| *** phuongnh has quit IRC | 12:03 | |
| *** TravT has joined #openstack-nova | 12:05 | |
| mdbooth | johnthetubaguy: https://review.openstack.org/#/c/334956/ So my poor gerrit-fu may mean that you missed my response to jaypipes, because I put it in the wrong place :) | 12:06 |
| mdbooth | It's a top-level comment | 12:06 |
| *** ducttape_ has joined #openstack-nova | 12:06 | |
| mdbooth | I have no idea why I did that, btw. | 12:07 |
| * mdbooth cuts/pastes to the right place. | 12:07 | |
| *** shaohe_feng has quit IRC | 12:12 | |
| *** shaohe_feng has joined #openstack-nova | 12:13 | |
| *** xyang1 has joined #openstack-nova | 12:16 | |
| *** gb21 has quit IRC | 12:19 | |
| *** edmondsw has joined #openstack-nova | 12:19 | |
| kaisers | danpb: Regarding https://bugs.launchpad.net/nova/+bug/1609298 : what type & mode would that seclabel require? I'm not familiar with seclabels but i'll create a change for inserting it as proposed. | 12:20 |
| openstack | Launchpad bug 1609298 in OpenStack Compute (nova) "libvirt should not require dynamic_ownership off for secure Cinder/Quobyte settings" [Undecided,New] | 12:20 |
| *** shaohe_feng has quit IRC | 12:22 | |
| *** takedakn has joined #openstack-nova | 12:22 | |
| *** shaohe_feng has joined #openstack-nova | 12:22 | |
| *** TravT has quit IRC | 12:23 | |
| openstackgerrit | Hironori Shiina proposed openstack/nova: ironic: Cleanup instance information when spawn fails https://review.openstack.org/341253 | 12:23 |
| *** jamesdenton has joined #openstack-nova | 12:25 | |
| *** fwiesel has joined #openstack-nova | 12:25 | |
| danpb | kaisers: iirc, you'll need <seclabel type="dac" relabel="no"> inside the <source> element for the <disk> | 12:25 |
| *** fwiesel has quit IRC | 12:25 | |
| *** rfolco has joined #openstack-nova | 12:25 | |
| *** baoli has joined #openstack-nova | 12:26 | |
| *** fabianw has joined #openstack-nova | 12:27 | |
| *** baoli_ has joined #openstack-nova | 12:27 | |
| *** fabianw has quit IRC | 12:27 | |
| *** TravT has joined #openstack-nova | 12:28 | |
| *** baoli has quit IRC | 12:30 | |
| kaisers | danpb: thnx! | 12:31 |
| *** hoangcx has joined #openstack-nova | 12:31 | |
| *** shaohe_feng has quit IRC | 12:32 | |
| *** shaohe_feng has joined #openstack-nova | 12:33 | |
| *** daemontool_ has joined #openstack-nova | 12:35 | |
| openstackgerrit | Alex Szarka proposed openstack/nova: Recover instances when physical data is missing https://review.openstack.org/322341 | 12:36 |
| *** sdake has joined #openstack-nova | 12:37 | |
| *** daemontool has quit IRC | 12:37 | |
| johnthetubaguy | mdbooth: ah, I think I get you, I am really not that familiar with that bit of the imagecache code | 12:38 |
| openstackgerrit | Alex Szarka proposed openstack/nova: Recover instances when physical data is missing https://review.openstack.org/322341 | 12:39 |
| *** c64cosmin has joined #openstack-nova | 12:39 | |
| *** ljxiash has joined #openstack-nova | 12:41 | |
| openstackgerrit | Alex Szarka proposed openstack/nova: Recover instances when physical data is missing https://review.openstack.org/322341 | 12:41 |
| *** shaohe_feng has quit IRC | 12:42 | |
| *** lucas-hungry is now known as lucasagomes | 12:43 | |
| *** shaohe_feng has joined #openstack-nova | 12:43 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova-specs: Reproposes the Hyper-V Cluster spec to Ocata https://review.openstack.org/350559 | 12:46 |
| *** ratailor has quit IRC | 12:47 | |
| alex_xu | nova api subteam meeting in 10 mins at #openstack-meeting-4 | 12:50 |
| alex_xu | \o/ yeah, i sent reminder on time | 12:50 |
| *** annegentle has joined #openstack-nova | 12:52 | |
| *** jamesdenton has quit IRC | 12:52 | |
| *** shaohe_feng has quit IRC | 12:53 | |
| *** shaohe_feng has joined #openstack-nova | 12:54 | |
| sdague | o/ | 12:59 |
| *** gmann_ has joined #openstack-nova | 12:59 | |
| *** annegentle has quit IRC | 13:00 | |
| mdbooth | johnthetubaguy: I don't think anybody is :) That's why I try to submit mini patch series every time I think I understand a little of it. | 13:00 |
| mdbooth | kswiatek: I just got here: http://paste.openstack.org/show/547756/ | 13:02 |
| *** rlrossit has joined #openstack-nova | 13:02 | |
| mdbooth | I think something like that would allow you to do what melwitt was asking for | 13:02 |
| mdbooth | That basically mocks the entirety of the external libraries | 13:02 |
| *** itoader has joined #openstack-nova | 13:03 | |
| *** burgerk has joined #openstack-nova | 13:03 | |
| * kashyap vaguely recalls that there was a spec submitted to allow for applying IO disk limits via QEMU IO throttling infrastructure ('block_set_io_throttle'). Wonder if it's just my imagination... | 13:03 | |
| mdbooth | And has the client return a list of values we'd be interested in testing the filtering of | 13:03 |
| *** shaohe_feng has quit IRC | 13:03 | |
| *** shaohe_feng has joined #openstack-nova | 13:04 | |
| mdbooth | kswiatek: It also doesn't mock any of RBDDriver, which melwitt was keen on | 13:04 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova-specs: Re-re-propose ironic-multiple-compute-hosts https://review.openstack.org/350283 | 13:06 |
| jroll | dansmith: ^ updated, replied to comments | 13:06 |
| *** mriedem has joined #openstack-nova | 13:06 | |
| mdbooth | kswiatek: What problem did you hit when you tried to mock rados? | 13:08 |
| *** diogogmt has quit IRC | 13:09 | |
| kswiatek | hi, I need help with testing patch: https://review.openstack.org/#/c/314928/ | 13:09 |
| *** tblakeslee has joined #openstack-nova | 13:10 | |
| mdbooth | kswiatek: ^^^ You mentioned you hit a problem when you tried to mock rados | 13:10 |
| *** dave-mccowan has joined #openstack-nova | 13:10 | |
| mdbooth | Did you see the above pastebin, btw? | 13:10 |
| *** diogogmt has joined #openstack-nova | 13:10 | |
| doffm | dansmith, alaski: Thanks for working on those aggregate changes. I feel pretty guilty for not being able to see it through. | 13:10 |
| kswiatek | sorry didn't saw i had scrolled window up :) | 13:10 |
| *** sudipto has joined #openstack-nova | 13:11 | |
| *** ducttape_ has quit IRC | 13:11 | |
| *** mdrabe has joined #openstack-nova | 13:12 | |
| kswiatek | when I mocked rado (like was mocked in other test) i get error in line: ret = self.librbd.rbd_list(ioctx.io, byref(c_names), byref(size)) in rbd.py | 13:12 |
| kswiatek | ctypes.ArgumentError: argument 1: <type 'exceptions.TypeError'>: Don't know how to convert parameter 1 | 13:13 |
| kswiatek | mdbooth i tried your solution | 13:13 |
| kswiatek | try* | 13:13 |
| *** kolesovdv has quit IRC | 13:13 | |
| *** shaohe_feng has quit IRC | 13:13 | |
| *** TravT has quit IRC | 13:14 | |
| *** shaohe_feng has joined #openstack-nova | 13:14 | |
| *** agireud has quit IRC | 13:14 | |
| mriedem | easy fix to get neutronclient 5.0 going in u-c https://review.openstack.org/#/c/349297/ | 13:15 |
| mdbooth | kswiatek: What line of the test is that stack trace in? | 13:15 |
| mdbooth | I guess it would be in the cleanup call... | 13:15 |
| mdbooth | Is it during _destroy_volume? | 13:16 |
| *** ljxiash has quit IRC | 13:16 | |
| mdbooth | The above little test runs to completion for me | 13:16 |
| mdbooth | Obviously it doesn't actually test anything :) | 13:16 |
| mdbooth | But I stuck a probe in to make sure the volume list is being returned int he right place in cleanup_volumes | 13:17 |
| *** agireud has joined #openstack-nova | 13:17 | |
| mdbooth | kswiatek: Pastebin a stack trace for me | 13:18 |
| *** ljxiash has joined #openstack-nova | 13:18 | |
| *** burgerk has quit IRC | 13:18 | |
| kswiatek | my error was while executing this line in rbd_utils.py: volumes = rbd.RBD().list(client.ioctx) | 13:18 |
| *** ihrachys has joined #openstack-nova | 13:18 | |
| *** TravT has joined #openstack-nova | 13:18 | |
| mdbooth | kswiatek: Ok, that suggests it's not mocked | 13:18 |
| mdbooth | That line definitely wfm | 13:18 |
| openstackgerrit | Joshua Hesketh proposed openstack/nova: Filter for ironic uuid https://review.openstack.org/343413 | 13:19 |
| *** markvoelker has quit IRC | 13:19 | |
| mdbooth | My test fragment mocks the whole rbd library, so that shouldn't be able to raise an exception, because it shouldn't be running any code | 13:19 |
| kswiatek | http://paste.openstack.org/show/547764/ | 13:20 |
| mdbooth | kswiatek: Can you pastebin the test function which resulted in that? | 13:20 |
| *** cleong has joined #openstack-nova | 13:20 | |
| mdbooth | Is it literally what I posted? | 13:20 |
| kswiatek | I just run code with your code and waiting for result | 13:21 |
| kswiatek | no | 13:21 |
| kswiatek | it's my previous code :) | 13:21 |
| mdbooth | Ok, pastebin what you ran | 13:21 |
| mdbooth | Ah... | 13:21 |
| mdbooth | So, yeah. You need to mock those libraries, otherwise it's going to fail. | 13:21 |
| mdbooth | We don't want it actually attempting to do real ceph stuff. | 13:21 |
| mdbooth | You asked about what ioctx should be | 13:23 |
| *** ljxiash has quit IRC | 13:23 | |
| mdbooth | The real answer is it's not at all important to the test, so we should sweep it under the carpet :) | 13:23 |
| openstackgerrit | Joshua Hesketh proposed openstack/nova: Filter for ironic uuid https://review.openstack.org/343413 | 13:23 |
| *** shaohe_feng has quit IRC | 13:23 | |
| *** shaohe_feng has joined #openstack-nova | 13:24 | |
| kswiatek | your code seems working | 13:26 |
| *** roeyc has quit IRC | 13:27 | |
| *** TravT has quit IRC | 13:27 | |
| kswiatek | i mean no error, so what's left is to check if it clean what it should (or don't clean) | 13:27 |
| *** jwcroppe has quit IRC | 13:28 | |
| mdbooth | kswiatek: That snippet is just a demo of some mocking. | 13:28 |
| *** fragatina has joined #openstack-nova | 13:28 | |
| mdbooth | You need to write the actual test :) | 13:28 |
| *** takedakn has quit IRC | 13:28 | |
| *** ihrachys has quit IRC | 13:29 | |
| *** nkrinner is now known as nkrinner_afk | 13:29 | |
| mdbooth | So you'll want the volume list to be something sensible, then assert that _destroy_volume was called as expected based on the filter we passed it. | 13:29 |
| *** ljxiash has joined #openstack-nova | 13:31 | |
| *** belmoreira has quit IRC | 13:31 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova: Ironic: enable multitenant networking https://review.openstack.org/297895 | 13:31 |
| *** ljxiash has quit IRC | 13:32 | |
| jroll | jaypipes: mriedem: ^ updated depends-on for the ironicclient bump | 13:32 |
| *** tonytan4ever has joined #openstack-nova | 13:32 | |
| *** ljxiash has joined #openstack-nova | 13:32 | |
| *** ttx has quit IRC | 13:32 | |
| *** ttx has joined #openstack-nova | 13:33 | |
| *** roeyc has joined #openstack-nova | 13:33 | |
| *** diogogmt has quit IRC | 13:33 | |
| *** ttx has quit IRC | 13:33 | |
| *** shaohe_feng has quit IRC | 13:34 | |
| *** ttx has joined #openstack-nova | 13:34 | |
| *** shaohe_feng has joined #openstack-nova | 13:34 | |
| *** ttx has quit IRC | 13:35 | |
| *** ttx has joined #openstack-nova | 13:36 | |
| mriedem | jroll: thanks | 13:37 |
| *** hoangcx has quit IRC | 13:37 | |
| *** hwoarang has quit IRC | 13:37 | |
| jroll | np | 13:39 |
| *** TravT has joined #openstack-nova | 13:41 | |
| *** jwcroppe has joined #openstack-nova | 13:42 | |
| *** shaohe_feng has quit IRC | 13:44 | |
| openstackgerrit | Anush Krishnamurthy proposed openstack/nova: Improve help text of image_file_url https://review.openstack.org/332492 | 13:44 |
| *** shaohe_feng has joined #openstack-nova | 13:45 | |
| dansmith | jroll: if you remove that one thing about testing with services down, I'll +2 that spec | 13:46 |
| *** markvoelker has joined #openstack-nova | 13:46 | |
| jroll | dansmith: sure | 13:47 |
| jroll | dansmith: "I wonder, could we mitigate that by starting a new compute service in disabled mode" <- sounds right | 13:47 |
| dansmith | jroll: cool | 13:47 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova-specs: Re-re-propose ironic-multiple-compute-hosts https://review.openstack.org/350283 | 13:48 |
| jroll | there you are sir, thanks | 13:48 |
| *** sudipto has quit IRC | 13:50 | |
| *** zz_dimtruck is now known as dimtruck | 13:50 | |
| *** fragatina has quit IRC | 13:51 | |
| openstackgerrit | Daniel Berrange proposed openstack/nova: network: introduce helper APIs for dealing with os-vif objects https://review.openstack.org/269672 | 13:52 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: convert over to use os-vif for Linux Bridge & OVS https://review.openstack.org/350595 | 13:52 |
| *** hwoarang has joined #openstack-nova | 13:52 | |
| mriedem | danpb: good call on splitting that change up :) | 13:52 |
| *** devkulkarni1 has joined #openstack-nova | 13:53 | |
| *** eharney has joined #openstack-nova | 13:54 | |
| *** ecelik has quit IRC | 13:54 | |
| *** shaohe_feng has quit IRC | 13:54 | |
| *** akshai has joined #openstack-nova | 13:54 | |
| *** TravT has quit IRC | 13:55 | |
| *** shaohe_feng has joined #openstack-nova | 13:55 | |
| *** achinm has joined #openstack-nova | 13:55 | |
| *** burgerk has joined #openstack-nova | 13:57 | |
| dansmith | mriedem: when were you going to do a mitaka release? | 13:59 |
| *** TravT has joined #openstack-nova | 14:00 | |
| openstackgerrit | Paul Carlton proposed openstack/nova-specs: Use libvirt storage pools https://review.openstack.org/310505 | 14:00 |
| *** fragatina has joined #openstack-nova | 14:00 | |
| *** krot_sickleave is now known as krotscheck | 14:00 | |
| *** c64cosmin has quit IRC | 14:00 | |
| *** anush_ has joined #openstack-nova | 14:00 | |
| *** akshai has quit IRC | 14:00 | |
| gmann_ | sdague: alex_xu mriedem johnthetubaguy do we need to backport imageRef bug to mitaka/liberty ? | 14:01 |
| *** tongli has joined #openstack-nova | 14:01 | |
| gmann_ | if we are fixing this as bug, may be in mitaka also make sense | 14:01 |
| mriedem | dansmith: soon grasshopper | 14:01 |
| bhagyashris | mriedem: Hi, could you please review the patch https://review.openstack.org/#/c/320787/ | 14:02 |
| *** akshai has joined #openstack-nova | 14:02 | |
| mriedem | dansmith: have some stuff queued up first this morning, but wanted to see what was flushed through last night too | 14:02 |
| lyarwood | mriedem: can you take another look at https://review.openstack.org/#/c/349897/ for stable/mitaka now that I've dropped the rootwrap changes? | 14:02 |
| dansmith | mriedem: I think we should get that crypto fix from lyarwood in there.. it's simple but completely breaks encrypted volumes for people with real setups | 14:02 |
| sdague | gmann_: no, because it's tweaking the image API. Which we can accept as part of moving to glance v2 for the backend, but I don't think we should force earlier | 14:02 |
| mriedem | lyarwood: dansmith: i see how it is, the double team | 14:02 |
| dansmith | mriedem: you know you like it | 14:03 |
| dansmith | mriedem: I've spent the last two days watching this unfold and lyarwood swoops in with a fix, so.. :) | 14:03 |
| mriedem | i can't say the image i'm thinking in my head | 14:03 |
| *** eharney_ has joined #openstack-nova | 14:04 | |
| mriedem | well, the fix was in master | 14:04 |
| mriedem | lyarwood swooped in with hitting a backport button in gerrit | 14:04 |
| gmann_ | sdague: ah nice point. glance v2 not there. | 14:04 |
| lyarwood | mriedem: well that and I had to type stable/mitaka | 14:04 |
| *** eharney has quit IRC | 14:04 | |
| *** shaohe_feng has quit IRC | 14:04 | |
| *** tongli has quit IRC | 14:04 | |
| *** tongli has joined #openstack-nova | 14:05 | |
| mriedem | lyarwood: dansmith: so i brought the rootwrap thing up on the original change in master and was somehow sold on that not being an issue for upgrades, but i'd have to go back and look at the reasoning | 14:05 |
| dansmith | mriedem: I know, I meant swooped in with a pointer to the fix | 14:05 |
| *** shaohe_feng has joined #openstack-nova | 14:05 | |
| dansmith | mriedem: it's easy to drop that from the backport, and I think that's fine.. the backport makes it more specific, which is probably not a problem for upgrades anyway, | 14:05 |
| *** jwcroppe has quit IRC | 14:05 | |
| dansmith | but there's really no reason to include it, IMHO | 14:05 |
| *** ducttape_ has joined #openstack-nova | 14:06 | |
| dansmith | it's a minor tightening on a system that already lets us run dd unrestricted, so.. | 14:06 |
| mriedem | yeah it goes from wildcard to specific'ish | 14:06 |
| dansmith | we could easily have to backport something that requires it to go back to wildcard and then be screwed | 14:06 |
| dansmith | so I'd just leave it out, personally | 14:06 |
| mriedem | i'm fine with that approach | 14:06 |
| mriedem | lyarwood: just leave a note in the commit message about the deviation from the original fix and why | 14:07 |
| mriedem | and then i think i'm happy | 14:07 |
| mriedem | well, as happy as i can be | 14:07 |
| *** cfriesen_ has joined #openstack-nova | 14:07 | |
| vladikr | any chance someone could please look this spec, https://review.openstack.org/#/c/350211 - has been resubmitted yesterday, it was previously approved for Newton | 14:08 |
| lyarwood | mriedem: thanks, will do. | 14:08 |
| mriedem | gmann_: no on backporting the imageref thing to liberty | 14:08 |
| vladikr | hope it wont miss the freeze tomorrow | 14:08 |
| mriedem | gmann_: it's a latent bug, changes api behavior, and isn't critical/security related | 14:08 |
| mriedem | vladikr: we aren't really opening up reviews en masse for ocata | 14:09 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Strict ImageRef validation to UUID only https://review.openstack.org/338802 | 14:10 |
| gmann_ | mriedem: yea, true. | 14:12 |
| *** ayoung has joined #openstack-nova | 14:12 | |
| jaypipes | jroll: will re-review the resource_class patch shortly. | 14:13 |
| jroll | thanks jaypipes | 14:13 |
| *** TravT has quit IRC | 14:13 | |
| jaypipes | jroll: let's definitely get that done today :) | 14:13 |
| jroll | dansmith: random question, are o.vo fields singletons shared between instances of an object? | 14:13 |
| jroll | dansmith: context, we're hacking default to be calculated at object init >.> | 14:14 |
| dansmith | jroll: no | 14:14 |
| kswiatek | mdbooth: you mean volume with instance.uuid which will pass condition and execute destroy_volume? and assert that destroy_volume will be called? | 14:14 |
| dansmith | jroll: oh, you mean between instances of a single class definition? | 14:14 |
| dansmith | jroll: fields = {} is on the class not the instance | 14:15 |
| *** shaohe_feng has quit IRC | 14:15 | |
| dansmith | jroll: so there is one instance of the field per class | 14:15 |
| mdbooth | kswiatek: Yeah. It should destroy the correct volumes, and no others. | 14:15 |
| jroll | dansmith: yeah, between two instances of Node() - if I modify node_instance.fields['foo']._default, should that change it for a second instance? | 14:15 |
| *** shaohe_feng has joined #openstack-nova | 14:15 | |
| dansmith | jroll: yeah, because it's on the class | 14:15 |
| jroll | dansmith: aha, so I think the answer is yes | 14:15 |
| jroll | damn | 14:15 |
| dansmith | jroll: that's kindof the point, right? if you have two instances of the same object that don't share the same set of fields, then it's hard to argue that they're compatible :) | 14:16 |
| jroll | dansmith: right, yeah | 14:17 |
| *** oanson has quit IRC | 14:17 | |
| mriedem | gmann_: you should also update the api-ref for imageRef | 14:17 |
| mriedem | since it says " The image reference, as a UUID or full URL, for the image to use for your server instance." | 14:17 |
| *** mlavalle has joined #openstack-nova | 14:18 | |
| *** amotoki has joined #openstack-nova | 14:18 | |
| *** TravT has joined #openstack-nova | 14:18 | |
| mriedem | alex_xu: did you guys talk about the bug for restricting sort_keys when listing instances? | 14:19 |
| openstackgerrit | Lee Yarwood proposed openstack/nova: block_device: Make refresh_conn_infos py3 compatible https://review.openstack.org/342111 | 14:19 |
| gmann_ | mriedem: ah, yea that should be update. | 14:20 |
| *** siva_krish has joined #openstack-nova | 14:21 | |
| alex_xu | mriedem: sorry, we didn't get chance | 14:21 |
| *** cdelatte has joined #openstack-nova | 14:21 | |
| alex_xu | mriedem: we want to remove the sort_keys? | 14:23 |
| mriedem | alex_xu: https://bugs.launchpad.net/nova/+bug/1609039 | 14:23 |
| openstack | Launchpad bug 1609039 in OpenStack Compute (nova) "Should not be able to sort instances based on joined tables" [High,Triaged] | 14:23 |
| mriedem | we want to restrict sorting on joined tables | 14:23 |
| *** links has quit IRC | 14:23 | |
| mriedem | when listing instances | 14:23 |
| *** claudiub has quit IRC | 14:24 | |
| mriedem | i'm not sure what the best way to implement that is, whitelist via jsonschema in the api or just check in the db api for sort_keys that are on joined columns | 14:24 |
| sdague | mriedem: jsonschema doesn't apply to parameters | 14:24 |
| *** siva_krish has quit IRC | 14:24 | |
| mriedem | that settles that then | 14:24 |
| alex_xu | mriedem: I can take at look at that bug | 14:25 |
| sdague | we don't have a validation mechanism for parameters yet... which we should | 14:25 |
| alex_xu | yes | 14:25 |
| *** shaohe_feng has quit IRC | 14:25 | |
| *** jaosorior has quit IRC | 14:25 | |
| mriedem | i wasn't crazy about doing jsonschema validation on this anyway | 14:25 |
| mriedem | b/c if a new column is added to the instance table that's not a joined column you'd have to update the schema and microversion it | 14:25 |
| mriedem | maybe that's actually desirable, idk | 14:26 |
| *** shaohe_feng has joined #openstack-nova | 14:26 | |
| tdurakov | mriedem, alex_xu hi folks, read this thread http://lists.openstack.org/pipermail/openstack-dev/2016-August/100606.html - I'd prefer to not bump microversion for this honestly, but what I'm concerned more, is whetherit's ok to allow such resizes? do we have enough code on compute.manager side to perform this? | 14:26 |
| *** siva_krish has joined #openstack-nova | 14:26 | |
| sdague | mriedem: well, sorting by any collumn that doesn't have an index on it, is basically a DOS vector | 14:26 |
| sdague | so I do think the allowed sort columns should be explicit | 14:26 |
| *** unicell1 has joined #openstack-nova | 14:27 | |
| mriedem | alright maybe comment that in the bug so we don't lose it | 14:27 |
| mriedem | i have to run to a meeting | 14:27 |
| *** ekuris_ has quit IRC | 14:27 | |
| kswiatek | mdbooth: something like this: http://paste.openstack.org/show/547785/ | 14:28 |
| *** gszasz has quit IRC | 14:28 | |
| *** yamahata has joined #openstack-nova | 14:28 | |
| *** unicell has quit IRC | 14:29 | |
| mdbooth | kswiatek: Yep, but with more representative volume names. | 14:29 |
| kswiatek | :) ok | 14:29 |
| mdbooth | I can't remember exactly how rbd names them | 14:29 |
| mdbooth | But I think it's like <uuid>_<name> | 14:29 |
| mdbooth | Anyway, we should ensure that data is representative | 14:30 |
| alex_xu | tdurakov: emm...basically that is the patch https://review.openstack.org/#/c/334747/ want to resolve | 14:30 |
| kswiatek | ok | 14:30 |
| tdurakov | alex_xu: yes, I saw it | 14:30 |
| alex_xu | tdurakov: at least, when I review the code, it looks like ok allow the resize | 14:30 |
| tdurakov | alex_xu: tbh, I'd solve this problem with another approach | 14:31 |
| *** gszasz has joined #openstack-nova | 14:31 | |
| *** ihrachys has joined #openstack-nova | 14:31 | |
| tdurakov | if smth fails during resize, do rolback, not just change instance state | 14:31 |
| *** TravT has quit IRC | 14:32 | |
| tdurakov | also why not to wrap finish resize the same way, so instance will moved to active state, as it's done on source node | 14:32 |
| alex_xu | tdurakov: yea, i see your point now, when I review I remember I think about that case, but I can't remember the detail now... | 14:33 |
| *** siva_krish has quit IRC | 14:33 | |
| tdurakov | alex_xu: from my sight this should be internal thing, from operator/user it's no matter where it's failed, so let's just not expose that at all | 14:33 |
| tdurakov | mriedem: what do you think^ | 14:34 |
| *** shaohe_feng has quit IRC | 14:35 | |
| *** shaohe_feng has joined #openstack-nova | 14:36 | |
| alex_xu | tdurakov: yea, i understand your point and agree, but i remember I say no to that way when i review, but i can't remember the detail now. I will try to revisit that code again. | 14:36 |
| tdurakov | alex_xu: yes, please:) | 14:37 |
| *** code-R has joined #openstack-nova | 14:37 | |
| alex_xu | tdurakov: you can write your comment on the patch, i will try to revisit it tomorrow. | 14:37 |
| *** jlanoux has quit IRC | 14:37 | |
| tdurakov | alex_xu: sure, will do this. will be waiting for your feedback on that approach | 14:38 |
| alex_xu | tdurakov: yea, thanks | 14:38 |
| *** burgerk has quit IRC | 14:38 | |
| *** slucidi has quit IRC | 14:38 | |
| *** burt has joined #openstack-nova | 14:38 | |
| *** achinm has quit IRC | 14:38 | |
| *** code-R_ has joined #openstack-nova | 14:38 | |
| alex_xu | see you tomorrow nova... | 14:39 |
| *** efried has joined #openstack-nova | 14:40 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Strict ImageRef validation to UUID only https://review.openstack.org/338802 | 14:40 |
| *** mtanino has joined #openstack-nova | 14:40 | |
| *** diogogmt has joined #openstack-nova | 14:40 | |
| kswiatek | mdbooth; last thing, quite silly, random names hardcode or generate? | 14:40 |
| *** amotoki has quit IRC | 14:40 | |
| *** TravT has joined #openstack-nova | 14:41 | |
| mdbooth | kswiatek: I'd use the uuids module for instance uuid. For the name component, use a couple of real names. e.g. 'disk' and 'disk.swap' | 14:41 |
| kswiatek | ok thanks | 14:41 |
| *** code-R has quit IRC | 14:41 | |
| mdbooth | kswiatek: But check what the actual format is, because I haven't. | 14:42 |
| *** burgerk has joined #openstack-nova | 14:43 | |
| *** chenfan_ has joined #openstack-nova | 14:44 | |
| *** chandankumar has quit IRC | 14:44 | |
| *** gmann_ has quit IRC | 14:44 | |
| *** Swami has joined #openstack-nova | 14:45 | |
| *** TravT has quit IRC | 14:45 | |
| *** amotoki has joined #openstack-nova | 14:45 | |
| *** shaohe_feng has quit IRC | 14:45 | |
| *** toabctl has quit IRC | 14:46 | |
| *** TravT has joined #openstack-nova | 14:46 | |
| *** shaohe_feng has joined #openstack-nova | 14:46 | |
| *** kenperkins has joined #openstack-nova | 14:46 | |
| *** toabctl has joined #openstack-nova | 14:47 | |
| *** annegentle has joined #openstack-nova | 14:47 | |
| *** hieulq_ has joined #openstack-nova | 14:47 | |
| *** knikolla has joined #openstack-nova | 14:47 | |
| *** code-R_ has quit IRC | 14:48 | |
| *** code-R has joined #openstack-nova | 14:48 | |
| *** fragatina has quit IRC | 14:49 | |
| *** TravT_ has joined #openstack-nova | 14:49 | |
| *** fragatina has joined #openstack-nova | 14:49 | |
| *** TravT has quit IRC | 14:50 | |
| *** TravT_ is now known as TravT | 14:51 | |
| *** eharney_ is now known as eharney | 14:51 | |
| *** mdrabe has quit IRC | 14:53 | |
| *** tjones has joined #openstack-nova | 14:54 | |
| *** shaohe_feng has quit IRC | 14:56 | |
| *** shaohe_feng has joined #openstack-nova | 14:56 | |
| *** siva_krish has joined #openstack-nova | 14:58 | |
| *** mdrabe has joined #openstack-nova | 15:01 | |
| *** gszasz has quit IRC | 15:02 | |
| *** fragatina has quit IRC | 15:02 | |
| dansmith | jaypipes: FYI, I'm fixing that rt unit test series for the pep8 fail and the useless code gibi pointed out | 15:03 |
| *** hieulq__ has joined #openstack-nova | 15:05 | |
| *** nkrinner_afk has quit IRC | 15:05 | |
| openstackgerrit | Dan Smith proposed openstack/nova: rt: Remove duplicate unit test for missing mig ctx https://review.openstack.org/350293 | 15:05 |
| openstackgerrit | Dan Smith proposed openstack/nova: rt: Refactor resize claim abort unit test https://review.openstack.org/350292 | 15:05 |
| openstackgerrit | Dan Smith proposed openstack/nova: rt: Refactor test_dupe_filter unit test https://review.openstack.org/350319 | 15:05 |
| openstackgerrit | Dan Smith proposed openstack/nova: rt: Refactor resize_claim unit test https://review.openstack.org/349746 | 15:05 |
| *** jlanoux has joined #openstack-nova | 15:06 | |
| *** shaohe_feng has quit IRC | 15:06 | |
| *** amotoki has quit IRC | 15:06 | |
| *** shaohe_feng has joined #openstack-nova | 15:06 | |
| *** mjura has quit IRC | 15:06 | |
| *** hieulq_ has quit IRC | 15:07 | |
| jaypipes | dansmith: cool, thx. btw, that useless code was just copy/pasted from the original :) | 15:07 |
| dansmith | jaypipes: okay I didn't realize, but since this was a cleanup, seems okay to fix right? | 15:08 |
| jaypipes | dansmith: oh, absolutely, and I appreciate it! | 15:08 |
| *** akshai has quit IRC | 15:09 | |
| kswiatek | mdbooth: one more thing: commit changes one by one, or change everything form comments and then commit? | 15:09 |
| *** rama_y has joined #openstack-nova | 15:09 | |
| mdbooth | kswiatek: Not sure I understand. There should only be a single resulting change. | 15:10 |
| *** chenfan_ has quit IRC | 15:10 | |
| kswiatek | ok | 15:11 |
| *** rrecio has joined #openstack-nova | 15:11 | |
| *** siva_krish has quit IRC | 15:12 | |
| *** gszasz has joined #openstack-nova | 15:14 | |
| mriedem | tdurakov: i tend to agree with you and alaski (who commented in the change) that if we can rollback we should just do that automatically | 15:14 |
| *** dimtruck is now known as zz_dimtruck | 15:15 | |
| *** zz_dimtruck is now known as dimtruck | 15:16 | |
| *** chenfan_ has joined #openstack-nova | 15:16 | |
| dansmith | jaypipes: oops, forgot to remove your datetime import on that last one, so re-pushing in a sec | 15:16 |
| *** shaohe_feng has quit IRC | 15:16 | |
| *** nkrinner_afk has joined #openstack-nova | 15:17 | |
| dansmith | oh, nm, it's used for a timedelta, so.. it's good | 15:17 |
| *** shaohe_feng has joined #openstack-nova | 15:17 | |
| mriedem | mikal: since you were on the change on master maybe you want to hit the backport https://review.openstack.org/#/c/349986/ | 15:17 |
| mriedem | dansmith: https://review.openstack.org/#/c/314207/ | 15:17 |
| mriedem | and https://review.openstack.org/#/c/304746/ | 15:17 |
| mriedem | or johnthetubaguy ^ | 15:18 |
| *** akshai has joined #openstack-nova | 15:18 | |
| *** priteau has quit IRC | 15:19 | |
| *** paul-carlton2 has quit IRC | 15:20 | |
| *** READ10 has joined #openstack-nova | 15:20 | |
| mriedem | mdbooth: on https://review.openstack.org/#/c/329930/ i'm pretty sure the bdm.save() actually happens in the virt driver | 15:20 |
| mriedem | when prepping block devices | 15:20 |
| mriedem | mdbooth: it doesn't hurt to add the save(), but i'm assuming that was the thought process | 15:21 |
| mdbooth | mriedem: IIRC I couldn't immediately see where it was called, and it wasn't documented that it was called elsewhere | 15:21 |
| mriedem | in driver_block_device.attach_block_devices | 15:21 |
| mdbooth | I'm engaged in a war on non-local context | 15:22 |
| mriedem | via the @update_db decorator or whatever | 15:22 |
| mriedem | mdbooth: yeah i understand | 15:22 |
| mdbooth | Will update_db do it? | 15:22 |
| mdbooth | It'll flush the sqla object, but without the save() does the change get pushed there? | 15:22 |
| *** amotoki has joined #openstack-nova | 15:22 | |
| *** markus_z has quit IRC | 15:22 | |
| mriedem | yes i believe it happens indirectly | 15:23 |
| *** sheel has joined #openstack-nova | 15:23 | |
| mriedem | the DriverBlockDevice is created from the bdm object after that field is set, | 15:23 |
| mriedem | then we call attach which has the update_db decorator | 15:23 |
| *** chandankumar has joined #openstack-nova | 15:24 | |
| *** dave-mccowan has quit IRC | 15:24 | |
| mriedem | it's totally tight coupling and you wouldn't know if you didn't memorize that entire code flow | 15:24 |
| *** hoangcx has joined #openstack-nova | 15:24 | |
| dansmith | yeah, it's the terribles | 15:24 |
| *** dimtruck is now known as zz_dimtruck | 15:25 | |
| *** shaohe_feng has quit IRC | 15:26 | |
| *** shaohe_feng has joined #openstack-nova | 15:27 | |
| *** ihrachys has quit IRC | 15:29 | |
| *** ihrachys has joined #openstack-nova | 15:30 | |
| *** roeyc has quit IRC | 15:31 | |
| moshele | jaypipes: reminder for pci reviews https://review.openstack.org/#/c/328983/ , https://review.openstack.org/#/c/347444/ https://review.openstack.org/#/c/347558/, thanks in advance :) | 15:31 |
| johnthetubaguy | mdbooth: mriedem: dansmith: I keep thinking about attaching the BDM to the instance, and start using instance.save() to save it, we seem to fetch BDM so many times during the boot process to double check things, and save it only some times, its so dam confusing. Is that a crazy thought? | 15:31 |
| jaypipes | moshele: you got it. will do shortly. | 15:32 |
| mdbooth | johnthetubaguy: Makes sense to me. For the persistent instance metadata stuff I'll want to maintain the ability to poke them individually via DriverBlockDevice, though. | 15:33 |
| mriedem | johnthetubaguy: idk, a bdm doesn't need an instance_uuid set right away | 15:33 |
| mriedem | and i don't know what changes with multiattach | 15:34 |
| mriedem | or i forget rather | 15:34 |
| johnthetubaguy | well multiattach just has a bdm for each attachment, I assumed, but I don't remember either | 15:34 |
| johnthetubaguy | yeah, it feels like a the request_spec could store the details for a bdm without a uuid, to some extent, so we can then always set the uuid on a bdm | 15:35 |
| *** sridharg has quit IRC | 15:36 | |
| johnthetubaguy | maybe thats the bit I never understood actually, a bdm without the instance_uuid set | 15:36 |
| andreykurilin | mriedem: https://review.openstack.org/344151 +6, -5 change and py35 is green in novaclient :) | 15:36 |
| mdbooth | johnthetubaguy: Isn't it just a quirk of how they're created in api? | 15:36 |
| * mdbooth digs the code out again. | 15:37 | |
| *** shaohe_feng has quit IRC | 15:37 | |
| johnthetubaguy | mdbooth: that was my hope | 15:37 |
| *** shaohe_feng has joined #openstack-nova | 15:37 | |
| *** paul-carlton has quit IRC | 15:38 | |
| openstackgerrit | Andrey Volkov proposed openstack/python-novaclient: Add support for microversion 2.33 https://review.openstack.org/349547 | 15:39 |
| *** itlinux has joined #openstack-nova | 15:39 | |
| andreykurilin | mriedem: thanks | 15:39 |
| *** zz_dimtruck is now known as dimtruck | 15:40 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs: Deprecate os-interface proxy API https://review.openstack.org/350277 | 15:40 |
| dansmith | johnthetubaguy: I've always thought it was weird that BDM has instance inside *it* instead of the other way around, yes | 15:41 |
| mdbooth | johnthetubaguy: BlockDeviceMapping.instance_uuid isn't nullable. However, when the object is originally created (before it's persisted) it's not set to handle the multiple create case | 15:42 |
| dansmith | johnthetubaguy: I'd also like to unfsck a bunch of the BDM code if we're going to do that though | 15:42 |
| mdbooth | See _bdm_validate_set_size_and_instance() | 15:42 |
| johnthetubaguy | dansmith: +1 | 15:42 |
| mdbooth | dansmith: +1 | 15:42 |
| johnthetubaguy | mdbooth: yeah, thats OK, as long as you can't save without and instance_uuid | 15:42 |
| johnthetubaguy | mdbooth: yeah, I was just looking in here: https://github.com/openstack/nova/blob/841fc2ecde608a012660828011cf1f5dea322026/nova/compute/api.py#L1434 | 15:43 |
| *** devkulkarni2 has joined #openstack-nova | 15:44 | |
| edleafe | if a patch adds a new test method, and the rest of the tests in that file use mox, is it OK for the new test to also use mox? | 15:44 |
| dansmith | edleafe: mriedem will smack you down for that | 15:45 |
| *** devkulkarni1 has quit IRC | 15:45 | |
| *** pece has joined #openstack-nova | 15:45 | |
| mdbooth | edleafe: I'd say it depends if the new test follows an existing (anti-)pattern. | 15:45 |
| johnthetubaguy | so we are currently trying to remove all mox tests | 15:45 |
| mdbooth | If there are 4 almost identical mox-using tests and you want to add a 5th variation | 15:45 |
| edleafe | Well, I'm looking at https://review.openstack.org/#/c/338802/9/nova/tests/unit/api/openstack/compute/test_block_device_mapping.py | 15:45 |
| mdbooth | You should either follow the pattern, or also fix all the others | 15:46 |
| mdbooth | consistency ftw | 15:46 |
| dansmith | edleafe: I _just_ got smacked for that in the last couple weeks, so .. :) | 15:46 |
| edleafe | mdbooth: yeah, but fixing the others is really not related to the current change | 15:46 |
| mriedem | use mock | 15:46 |
| mriedem | if it's a new test, use mock | 15:46 |
| dansmith | edleafe: charges are pending, but he's out on bail | 15:46 |
| mriedem | don't need to fix all the others | 15:46 |
| edleafe | dansmith: I think mriedem just likes smacking you | 15:46 |
| mriedem | use mock with a new test | 15:46 |
| mdbooth | But basically, you should do what mriedem says :) | 15:46 |
| mriedem | mox races under py3 | 15:47 |
| mriedem | and there are no more docs for mox | 15:47 |
| mriedem | it's basically EOL | 15:47 |
| mriedem | use mock | 15:47 |
| mriedem | gdi | 15:47 |
| *** shaohe_feng has quit IRC | 15:47 | |
| mriedem | keep in mind we have a whole fing blueprint for removing mox | 15:47 |
| *** armax has joined #openstack-nova | 15:47 | |
| mriedem | so let's not http://s2.quickmeme.com/img/0c/0c0fcf30234ad83af446aaa5f1484afa60a6dd9dac943371fb4c026c7802fb04.jpg | 15:48 |
| edleafe | mriedem: thanks. Wasn't sure if I should smack gmann for that or not | 15:48 |
| *** shaohe_feng has joined #openstack-nova | 15:48 | |
| mriedem | smack away | 15:48 |
| mdbooth | mriedem: So I'd argue that ^^^ is an example of where we want consistency | 15:48 |
| * edleafe gets out the long paddle... | 15:48 | |
| mdbooth | So either use mox, or fix them all | 15:48 |
| mdbooth | And if the former isn't an option... | 15:49 |
| edleafe | mdbooth: or fix the others in a follow-up patch | 15:49 |
| dansmith | or pre-patch | 15:49 |
| mriedem | that ^ | 15:49 |
| mriedem | whatever, don't do it all in the same thing | 15:49 |
| mriedem | because backports | 15:49 |
| mriedem | people | 15:49 |
| mriedem | plus review sanity | 15:49 |
| edleafe | that ^^ | 15:49 |
| mriedem | there is like a series of 5 changes in stable/mitaka for converting mox to mock | 15:50 |
| mriedem | so the backport thing is an issue | 15:50 |
| *** ihrachys has quit IRC | 15:51 | |
| *** mdrabe_ has joined #openstack-nova | 15:51 | |
| mriedem | 4th bullet down http://docs.openstack.org/infra/manual/developers.html#peer-review | 15:51 |
| mriedem | s/bullet/item/ | 15:51 |
| melwitt | my thinking is that someone has to start a new consistency and making a new test use mock helps to do that. that is, if you add a new test with mock, that will let the next person copy the pattern for the next new test, and so on | 15:52 |
| mriedem | yes yes yes | 15:52 |
| mriedem | that's why we have TestNeutronv2WithMock | 15:52 |
| mriedem | because i forced it | 15:52 |
| edleafe | melwitt: and provide a pattern for updating others | 15:52 |
| *** rmart04 has quit IRC | 15:52 | |
| mriedem | melwitt: poke https://review.openstack.org/#/c/349297/ | 15:53 |
| mriedem | speaking of ^ | 15:53 |
| dansmith | mriedem: why are you so hyper this morning? | 15:53 |
| mriedem | anger | 15:53 |
| *** moshele has quit IRC | 15:53 | |
| mriedem | +coffee | 15:53 |
| dansmith | heh | 15:53 |
| * melwitt looks | 15:54 | |
| *** Sukhdev has joined #openstack-nova | 15:54 | |
| *** mdrabe has quit IRC | 15:55 | |
| *** locust has quit IRC | 15:57 | |
| *** JoseMello has joined #openstack-nova | 15:57 | |
| *** shaohe_feng has quit IRC | 15:57 | |
| *** shaohe_feng has joined #openstack-nova | 15:58 | |
| *** akshai has quit IRC | 15:59 | |
| dansmith | mriedem: FWIW, jaypipes and I are good with the ironic multi-compute spec change, after a few rounds with jroll: https://review.openstack.org/#/c/350283 | 16:00 |
| *** annegentle has quit IRC | 16:01 | |
| *** mgoddard_ has joined #openstack-nova | 16:01 | |
| mriedem | ok, will queue it up | 16:02 |
| dansmith | thanks | 16:02 |
| *** annegentle has joined #openstack-nova | 16:02 | |
| *** chenfan has quit IRC | 16:03 | |
| jroll | ty | 16:03 |
| *** mgoddard has quit IRC | 16:05 | |
| *** pbandark has quit IRC | 16:06 | |
| *** jistr is now known as jistr|biab | 16:06 | |
| openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Api-ref: Improve os-migrateLive input parameters https://review.openstack.org/345652 | 16:07 |
| openstackgerrit | Anusha Unnam proposed openstack/nova: Config options consistency for consoleauth.py https://review.openstack.org/348050 | 16:07 |
| *** shaohe_feng has quit IRC | 16:07 | |
| *** chenfan_ has quit IRC | 16:07 | |
| *** shaohe_feng has joined #openstack-nova | 16:08 | |
| *** efried has quit IRC | 16:11 | |
| *** nic has joined #openstack-nova | 16:12 | |
| *** paul-carlton2 has joined #openstack-nova | 16:12 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/350673 | 16:13 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif: Updated from global requirements https://review.openstack.org/339919 | 16:14 |
| mriedem | but first https://review.openstack.org/#/c/324068/ | 16:15 |
| *** stewie925_ has joined #openstack-nova | 16:17 | |
| *** siva_krishnan has joined #openstack-nova | 16:17 | |
| siva_krishnan | johnthetubaguy: this is regarding your review comments on https://review.openstack.org/#/c/348946/. I just need a small clarification on it. | 16:18 |
| *** shaohe_feng has quit IRC | 16:18 | |
| jaypipes | lbeliveau: so, 326174 is currentl-Workflow'd by you, but it is the dependent patch upon which other patches around SR-IOV live migration from you and moshele are based. Can you fix that? | 16:18 |
| *** shaohe_feng has joined #openstack-nova | 16:19 | |
| *** chenfan has joined #openstack-nova | 16:20 | |
| *** chandankumar has quit IRC | 16:20 | |
| *** jdurgin1 has joined #openstack-nova | 16:21 | |
| *** hieulq__ has quit IRC | 16:21 | |
| lbeliveau | jaypipes: let me have a look | 16:22 |
| *** jistr|biab is now known as jistr | 16:22 | |
| jroll | sdague: when y'all add a new API endpoint, do you 404 it for previous microversions, or? | 16:22 |
| mriedem | hmm, where is our resize policy https://github.com/openstack/nova/tree/master/nova/policies | 16:23 |
| *** hshiina has quit IRC | 16:23 | |
| openstackgerrit | devdatta-kulkarni proposed openstack/nova: TrivialFix: Fixed a typo in nova/test.py https://review.openstack.org/350680 | 16:24 |
| *** dansmith has quit IRC | 16:27 | |
| *** Apoorva has joined #openstack-nova | 16:27 | |
| *** dansmith has joined #openstack-nova | 16:28 | |
| *** dansmith is now known as Guest20988 | 16:28 | |
| *** shaohe_feng has quit IRC | 16:28 | |
| *** shaohe_feng has joined #openstack-nova | 16:29 | |
| *** RuiChen has quit IRC | 16:29 | |
| *** Guest20988 is now known as dansmith | 16:29 | |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Allocate PCI devices on migration https://review.openstack.org/328983 | 16:29 |
| *** ssurana has joined #openstack-nova | 16:29 | |
| *** akshai has joined #openstack-nova | 16:30 | |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Fixes for race conditions in revert migration with SR-IOV https://review.openstack.org/339765 | 16:32 |
| *** akshai_ has joined #openstack-nova | 16:32 | |
| mriedem | sdague: comments are in https://review.openstack.org/#/c/324068/ | 16:33 |
| *** sdague has quit IRC | 16:34 | |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Fix revert on migration with SR-IOV https://review.openstack.org/326174 | 16:34 |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Fixes for race conditions in revert migration with SR-IOV https://review.openstack.org/339765 | 16:34 |
| *** akshai has quit IRC | 16:35 | |
| openstackgerrit | Anusha Unnam proposed openstack/nova: Config options consistency of notifications.py https://review.openstack.org/348715 | 16:35 |
| openstackgerrit | Brian Haley proposed openstack/nova: Implement setup_networks_on_host for Neutron networks https://review.openstack.org/275073 | 16:36 |
| openstackgerrit | Roman Podoliaka proposed openstack/nova: [WIP] Optional separate database for placement API https://review.openstack.org/349021 | 16:36 |
| *** abalutoiu has quit IRC | 16:37 | |
| jaypipes | lbeliveau: k, let's let the check pipelines run for that patch now. I've reviewed the code in the patch and it all looks good to me. | 16:37 |
| *** corey_ has joined #openstack-nova | 16:37 | |
| *** rcernin has quit IRC | 16:38 | |
| *** iuliat has joined #openstack-nova | 16:38 | |
| *** cleong has quit IRC | 16:38 | |
| *** shaohe_feng has quit IRC | 16:38 | |
| *** shaohe_feng has joined #openstack-nova | 16:39 | |
| *** itoader has quit IRC | 16:39 | |
| *** Sukhdev has quit IRC | 16:40 | |
| *** seldenr has joined #openstack-nova | 16:41 | |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Fixes for race conditions in revert migration with SR-IOV https://review.openstack.org/339765 | 16:42 |
| *** paul-carlton2 has quit IRC | 16:43 | |
| *** sdague has joined #openstack-nova | 16:43 | |
| openstackgerrit | Ryan Selden proposed openstack/python-novaclient: Improve character encoding in client messages https://review.openstack.org/350230 | 16:43 |
| *** pece has quit IRC | 16:44 | |
| *** danpb has quit IRC | 16:44 | |
| *** lucasagomes is now known as lucas-dinner | 16:45 | |
| *** irenab has quit IRC | 16:46 | |
| *** hoangcx has quit IRC | 16:46 | |
| lbeliveau | jaypipes: should be good now | 16:48 |
| jaypipes | lbeliveau: +2 from me on both patches there. triggered a recheck on the first that had the UNSTABLE thing from the intel nfv ci | 16:48 |
| lbeliveau | jaypipes: thanks ! | 16:48 |
| *** shaohe_feng has quit IRC | 16:48 | |
| *** shaohe_feng has joined #openstack-nova | 16:49 | |
| *** iuliat has quit IRC | 16:49 | |
| *** hieulq_ has joined #openstack-nova | 16:51 | |
| mriedem | mtreinish: this single vendor thread in the dev list - what's the point of that again? | 16:52 |
| mriedem | do projects get kicked out of the arena if they are single vendor? | 16:52 |
| mriedem | or lack diversity (which i thought was the same thing) | 16:52 |
| mriedem | isn't this just a way to scope down the summit and PTG? | 16:52 |
| *** krotscheck is now known as kro_focused | 16:53 | |
| mtreinish | mriedem: yeah, that's what's being proposed. If a project has a single vendor tag for at least 3 cycles in a row we discuss removing them from governance | 16:55 |
| mriedem | and what does that mean? | 16:55 |
| mriedem | if you're out of governance? | 16:55 |
| mriedem | i thought you could still use the CI and all? | 16:55 |
| mtreinish | you can, you basically just can't call yourself an openstack project | 16:55 |
| mtreinish | that's about it | 16:56 |
| mtreinish | and horizontal teams don't have to support you | 16:56 |
| *** unicell1 has quit IRC | 16:56 | |
| dansmith | and you don't get a mascot, that's the biggest downside | 16:56 |
| mriedem | like qa and docs | 16:56 |
| *** browne has joined #openstack-nova | 16:56 | |
| mriedem | no mascot?! | 16:56 |
| mriedem | well f that | 16:56 |
| mtreinish | mriedem: yeah, qa, docs, osc, etc. | 16:57 |
| mriedem | but docs and qa want to kick that back to the big tent projects via plugins anyway right? | 16:57 |
| mriedem | isn't that already happening? | 16:57 |
| mriedem | hence the whole plugins thread | 16:58 |
| dansmith | alaski: cells meeting in a minute? | 16:58 |
| alaski | dansmith: yes | 16:58 |
| mriedem | we should just bring back integrated vs non-integrated projects | 16:58 |
| mtreinish | mriedem: it was definitely simpler back then | 16:58 |
| mriedem | the good old days | 16:58 |
| mriedem | we need trump to make openstack great again | 16:58 |
| mriedem | he knows the tricks | 16:59 |
| mriedem | and is the only one that can fix it | 16:59 |
| *** shaohe_feng has quit IRC | 16:59 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Create Instance from BuildRequest if not in a cell https://review.openstack.org/263927 | 16:59 |
| openstackgerrit | Andrew Laski proposed openstack/nova: instance.name should be blank if instance.id is not set https://review.openstack.org/327342 | 16:59 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Cells: Handle delete with BuildRequest https://review.openstack.org/325985 | 16:59 |
| mriedem | ooo right before the meeting so alaski can tell us to review it all, sneaky | 16:59 |
| *** pcaruana has quit IRC | 17:00 | |
| *** shaohe_feng has joined #openstack-nova | 17:00 | |
| * alaski pretends that was on purpose | 17:00 | |
| mtreinish | mriedem: well lets just rewrite it all in: https://github.com/samshadwell/TrumpScript | 17:00 |
| mriedem | haha | 17:01 |
| mriedem | "No floating point numbers, only integers. America never does anything halfway." | 17:01 |
| mriedem | There are no import statements allowed. All code has to be home-grown and American made. | 17:01 |
| mriedem | nice | 17:01 |
| *** annegentle has quit IRC | 17:02 | |
| *** tesseract- has quit IRC | 17:03 | |
| *** jwcroppe has joined #openstack-nova | 17:04 | |
| *** openstackgerrit_ has joined #openstack-nova | 17:06 | |
| tdurakov | alaski: are you around? | 17:07 |
| *** xinliang has quit IRC | 17:07 | |
| *** openstackgerrit_ has quit IRC | 17:08 | |
| *** xinliang has joined #openstack-nova | 17:08 | |
| tdurakov | alaski: https://review.openstack.org/#/c/327342/13/nova/objects/instance.py - line 287, why not to re-raise exception here? | 17:08 |
| mriedem | tdurakov: cells v2 meeting atm | 17:08 |
| tdurakov | mriedem: oh, sorry | 17:08 |
| *** shaohe_feng has quit IRC | 17:09 | |
| *** jlanoux has quit IRC | 17:09 | |
| *** shaohe_feng has joined #openstack-nova | 17:10 | |
| *** akshai_ has quit IRC | 17:11 | |
| *** lpetrut has quit IRC | 17:11 | |
| *** mgoddard_ has quit IRC | 17:12 | |
| *** mgoddard has joined #openstack-nova | 17:12 | |
| *** yamahata has quit IRC | 17:15 | |
| openstackgerrit | Brian Haley proposed openstack/nova: Implement setup_networks_on_host for Neutron networks https://review.openstack.org/275073 | 17:15 |
| *** rtheis_ has joined #openstack-nova | 17:16 | |
| *** oomichi has joined #openstack-nova | 17:17 | |
| alaski | tdurakov: I'm around, will look after this meeting | 17:17 |
| *** rtheis has quit IRC | 17:18 | |
| *** moshele has joined #openstack-nova | 17:19 | |
| *** shaohe_feng has quit IRC | 17:19 | |
| *** shaohe_feng has joined #openstack-nova | 17:20 | |
| *** eharney has quit IRC | 17:20 | |
| openstackgerrit | Mikhail Chernik proposed openstack/nova: Fix require thread policy for multi-NUMA computes https://review.openstack.org/334659 | 17:20 |
| *** dave-mccowan has joined #openstack-nova | 17:20 | |
| *** dimtruck is now known as zz_dimtruck | 17:22 | |
| *** Swami has quit IRC | 17:22 | |
| *** dave-mcc_ has joined #openstack-nova | 17:22 | |
| *** Swami has joined #openstack-nova | 17:23 | |
| *** abalutoiu has joined #openstack-nova | 17:25 | |
| *** paul-carlton2 has joined #openstack-nova | 17:25 | |
| *** hieulq_ has quit IRC | 17:25 | |
| *** zhangjn has quit IRC | 17:26 | |
| *** zhangjn has joined #openstack-nova | 17:27 | |
| *** dave-mccowan has quit IRC | 17:27 | |
| *** hieulq_ has joined #openstack-nova | 17:27 | |
| *** browne1 has joined #openstack-nova | 17:27 | |
| *** browne has quit IRC | 17:27 | |
| *** rahuls has quit IRC | 17:29 | |
| *** shaohe_feng has quit IRC | 17:29 | |
| *** shaohe_feng has joined #openstack-nova | 17:30 | |
| *** unicell has joined #openstack-nova | 17:31 | |
| alaski | tdurakov: I didn't want to raise an exception there because no code that checks instance.name expects an exception currently. And I really don't expect that code path to ever get run | 17:34 |
| *** TravT has quit IRC | 17:35 | |
| *** TravT has joined #openstack-nova | 17:35 | |
| *** lpetrut has joined #openstack-nova | 17:37 | |
| *** daemontool_ has quit IRC | 17:38 | |
| *** shaohe_feng has quit IRC | 17:40 | |
| *** shaohe_feng has joined #openstack-nova | 17:41 | |
| jaypipes | dansmith, mriedem, johnthetubaguy: trying to untangle some RT unit tests around resize. Have a question for you all. In the case of a migration/resize to another host, should the source host have the migration object in its tracked_migrations dict? I was assuming that it *would* until the resize is either confirmed (in which case a drop_move_claim() would be sent to the source host for that | 17:41 |
| jaypipes | instance) or is reverted (in which case the source host would simply remove the migration from its tracked_migrations dict. But what I'm seeing is that the source host does *not* include ongoing migrations in its tracked_migrations dict for migrations/resizes to another host. | 17:41 |
| dansmith | I have no idea | 17:42 |
| mriedem | was going to say, your guess is as good as mine | 17:42 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/nova: config option: rename libvirt iscsi_use_multipath https://review.openstack.org/331357 | 17:42 |
| jaypipes | mriedem, dansmith, johnthetubaguy: to be clear, this is the block of code that is confusing as hell: https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L770-L775 | 17:43 |
| dansmith | that's the one? | 17:43 |
| dansmith | the one confusing block? | 17:43 |
| jroll | heh | 17:43 |
| *** paul-carlton2 has quit IRC | 17:43 | |
| jroll | the rest of the RT is straightforward, ofc | 17:43 |
| jaypipes | dansmith: yes... | 17:44 |
| melwitt | lol | 17:45 |
| jaypipes | belliott: you around? | 17:45 |
| jaypipes | belliott: git annotate points at you as a person who might answer this: https://github.com/openstack/nova/commit/5bc0ff6354a399f712c777fa43153f05a50a1ce3 | 17:45 |
| *** code-R has quit IRC | 17:45 | |
| *** moshele has quit IRC | 17:46 | |
| mriedem | jaypipes: i'd maybe also look for sahid in place of ndipanov | 17:46 |
| *** mat128 is now known as mat128|afk | 17:47 | |
| tdurakov | alaski, I wonder could we end up with instance.uuid as a name in the worst case, i mean the uuid will be used for libvirt domains for example | 17:47 |
| jaypipes | mriedem: ndipanov? | 17:48 |
| tdurakov | If answer is no, than it's ok) | 17:48 |
| mriedem | jaypipes: git blame showed ndipanov in that code block | 17:48 |
| mriedem | he worked on a lot of the migration RT stuff | 17:48 |
| mriedem | and sahid has taken over some of that | 17:48 |
| dansmith | yeah I would have thought ndipanov was responsible for that | 17:48 |
| jaypipes | mriedem: ah, gotcha. | 17:49 |
| jaypipes | no, belliott was original code author. | 17:49 |
| mriedem | in the days of yre | 17:49 |
| mriedem | *yore | 17:49 |
| *** shaohe_feng has quit IRC | 17:50 | |
| sdague | jroll: to earlier question, an API endpoint is an construct that's above microversions. The end point will have semantics around the version range it accepts and tells you is or is not allowed | 17:50 |
| *** shaohe_feng has joined #openstack-nova | 17:50 | |
| jroll | sdague: so if nova were to add /foo, then /foo on 2.2 would be a 406 or something not a 404? | 17:51 |
| sdague | jroll: ... that's not an endpoint, that's a resource | 17:52 |
| *** lpetrut has quit IRC | 17:52 | |
| jroll | sdague: okay, resource then, sorry :) | 17:52 |
| sdague | are we talking about major version number? | 17:52 |
| dansmith | jroll: you have to have your pedantic pants on to be in the nova channel | 17:52 |
| sdague | /foo is actually kind of ambiguous | 17:52 |
| jroll | sdague: no, minor versions | 17:53 |
| jroll | ok so more concretely | 17:53 |
| jaypipes | mriedem, johnthetubaguy, dansmith: was it your understanding that drop_move_claim() would be called on the source compute host for an instance that had a resize reverted? | 17:53 |
| sdague | right so /v1/my-awesome-new-thing | 17:53 |
| jroll | yeah | 17:53 |
| dansmith | jaypipes: I'm so touched that you think I know anything about this stuff | 17:53 |
| jaypipes | heh | 17:53 |
| dansmith | honored, really. | 17:53 |
| sdague | it's a 404 I'm pretty sure in our code | 17:53 |
| *** yamahata has joined #openstack-nova | 17:53 | |
| jroll | sdague: so GET /v1/my-awesome-new-thing, on an old version, I would think would 404, because that's the old behavior | 17:54 |
| sdague | jroll: right | 17:54 |
| jroll | sounds like you agree | 17:54 |
| sdague | yes | 17:54 |
| jroll | that's helpful, thank you :D | 17:54 |
| johnthetubaguy | jaypipes: I would say yes, but I would totally feel like I am guessing while wearing a blindfold | 17:54 |
| *** diogogmt has quit IRC | 17:54 | |
| sdague | the point is the new resource only exists in new versions | 17:54 |
| sdague | jroll: cool :) | 17:54 |
| *** claudiub has joined #openstack-nova | 17:54 | |
| alaski | tdurakov: that could happen, but that means that instance.id is not available which means the instance is not in the database at all. If we're in the virt driver building an instance from that object we have larger issues than an invalid name. | 17:55 |
| sdague | jroll: http://developer.openstack.org/api-ref/compute/#server-tags-servers-tags - server tags is an instance where we did that in our API (not top level, but the semantics should be the same) | 17:56 |
| melwitt | mriedem: on the neutronclient call patch, do you know why this still works fine but the show_quota doesn't? https://review.openstack.org/#/c/349297/2/nova/tests/unit/network/test_neutronv2.py@1680 | 17:56 |
| johnthetubaguy | jaypipes: hmm, the more I think about it, I have no idea actually | 17:56 |
| tdurakov | Yeah, thats why I'm thinking about reraise | 17:56 |
| alaski | tdurakov: I'm open to raising an exception there, but I'm a bit concerned about side effects of it. I don't know what exception handling exists around it | 17:56 |
| *** diogogmt has joined #openstack-nova | 17:57 | |
| mriedem | melwitt: no decorator https://github.com/openstack/python-neutronclient/blob/5.0.0/neutronclient/v2_0/client.py#L625 | 17:57 |
| openstackgerrit | Rafael Folco proposed openstack/nova: Improve NUMA packing to fit more instances https://review.openstack.org/346205 | 17:57 |
| mriedem | melwitt: compared to https://github.com/openstack/python-neutronclient/blob/5.0.0/neutronclient/v2_0/client.py#L599 | 17:57 |
| tdurakov | I'd prefer not to handle such at all, as you said at the point there are bigger problems around | 17:58 |
| *** harlowja has quit IRC | 17:58 | |
| melwitt | mriedem: ah, okay. I had looked in the change to neutronclient mentioned in lp and only saw the decoration of the client class itself and didn't realize there was per-method stuff too | 17:58 |
| *** haplo37__ has joined #openstack-nova | 17:59 | |
| *** shaohe_feng has quit IRC | 18:00 | |
| *** harlowja has joined #openstack-nova | 18:00 | |
| *** shaohe_feng has joined #openstack-nova | 18:01 | |
| *** gszasz has quit IRC | 18:02 | |
| *** hieulq_ has quit IRC | 18:02 | |
| *** lpetrut has joined #openstack-nova | 18:03 | |
| *** tonytan4ever has quit IRC | 18:08 | |
| *** dave-mcc_ has quit IRC | 18:08 | |
| *** zz_dimtruck is now known as dimtruck | 18:09 | |
| *** shaohe_feng has quit IRC | 18:10 | |
| *** shaohe_feng has joined #openstack-nova | 18:11 | |
| *** devkulkarni2 has quit IRC | 18:11 | |
| *** syjulian has quit IRC | 18:12 | |
| *** stewie925 has quit IRC | 18:12 | |
| *** xenogear has quit IRC | 18:12 | |
| *** jinli has quit IRC | 18:12 | |
| *** MikeG451 has quit IRC | 18:13 | |
| *** stewie925 has joined #openstack-nova | 18:17 | |
| openstackgerrit | Christopher Martin proposed openstack/nova: Fix config opt indentation, opt registration and opt group and type check in hyperv.py https://review.openstack.org/348484 | 18:17 |
| *** code-R has joined #openstack-nova | 18:17 | |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: Merged barbican and key_manager conf files into one. https://review.openstack.org/349632 | 18:18 |
| *** yamahata has quit IRC | 18:18 | |
| *** yamahata has joined #openstack-nova | 18:19 | |
| *** devkulkarni1 has joined #openstack-nova | 18:19 | |
| *** code-R_ has joined #openstack-nova | 18:20 | |
| *** shaohe_feng has quit IRC | 18:21 | |
| *** claudiub has quit IRC | 18:21 | |
| *** shaohe_feng has joined #openstack-nova | 18:21 | |
| *** code-R has quit IRC | 18:23 | |
| *** sheel has quit IRC | 18:26 | |
| openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova: Config options consistency of pci.py https://review.openstack.org/350724 | 18:26 |
| *** MikeG451 has joined #openstack-nova | 18:29 | |
| *** jaosorior has joined #openstack-nova | 18:29 | |
| *** jaosorior has quit IRC | 18:30 | |
| *** xinliang has quit IRC | 18:30 | |
| *** shaohe_feng has quit IRC | 18:31 | |
| *** shaohe_feng has joined #openstack-nova | 18:31 | |
| *** xinliang has joined #openstack-nova | 18:32 | |
| *** jinli has joined #openstack-nova | 18:36 | |
| *** amotoki has quit IRC | 18:37 | |
| *** ayoung has quit IRC | 18:38 | |
| *** annegentle has joined #openstack-nova | 18:39 | |
| *** unicell1 has joined #openstack-nova | 18:40 | |
| *** unicell has quit IRC | 18:41 | |
| *** shaohe_feng has quit IRC | 18:41 | |
| *** itoader has joined #openstack-nova | 18:41 | |
| *** syjulian has joined #openstack-nova | 18:41 | |
| *** shaohe_feng has joined #openstack-nova | 18:42 | |
| *** xenogear has joined #openstack-nova | 18:44 | |
| *** ametts has joined #openstack-nova | 18:45 | |
| *** ljxiash has quit IRC | 18:47 | |
| *** iuliat has joined #openstack-nova | 18:48 | |
| *** jdurgin1 has quit IRC | 18:48 | |
| alaski | melwitt: some comments on https://review.openstack.org/#/c/330995 | 18:50 |
| *** itoader has quit IRC | 18:51 | |
| *** shaohe_feng has quit IRC | 18:51 | |
| *** shaohe_feng has joined #openstack-nova | 18:52 | |
| *** haplo37__ has quit IRC | 18:55 | |
| *** lpetrut has quit IRC | 18:55 | |
| *** jed56 has quit IRC | 18:55 | |
| *** lpetrut has joined #openstack-nova | 18:55 | |
| *** claudiub has joined #openstack-nova | 18:56 | |
| *** eharney has joined #openstack-nova | 18:58 | |
| *** diogogmt has quit IRC | 19:00 | |
| *** READ10 has quit IRC | 19:01 | |
| *** shaohe_feng has quit IRC | 19:02 | |
| *** claudiub has quit IRC | 19:02 | |
| *** gjayavelu has joined #openstack-nova | 19:02 | |
| *** efoley has joined #openstack-nova | 19:02 | |
| *** shaohe_feng has joined #openstack-nova | 19:02 | |
| *** itoader has joined #openstack-nova | 19:04 | |
| *** dave-mccowan has joined #openstack-nova | 19:04 | |
| *** iuliat has quit IRC | 19:06 | |
| *** iuliat has joined #openstack-nova | 19:06 | |
| *** READ10 has joined #openstack-nova | 19:07 | |
| *** fifieldt has quit IRC | 19:07 | |
| *** haplo37__ has joined #openstack-nova | 19:07 | |
| *** tonytan4ever has joined #openstack-nova | 19:08 | |
| *** itoader has quit IRC | 19:09 | |
| mikal | Morning | 19:09 |
| mikal | mriedem: I'll take a look at stable reviews sometime today | 19:09 |
| mriedem | mikal: thanks | 19:10 |
| mriedem | i'm going to push for a stable/mitaka release tomorrow | 19:10 |
| *** shaohe_feng has quit IRC | 19:12 | |
| *** shaohe_feng has joined #openstack-nova | 19:13 | |
| mikal | mriedem: ok, I will try very hard to not suck at reviews there today then | 19:13 |
| mikal | mriedem: tonyb is off this week minding a sick child, which is why he hasn't been doing much | 19:13 |
| *** tonytan4ever has quit IRC | 19:13 | |
| *** itoader has joined #openstack-nova | 19:14 | |
| *** Sukhdev has joined #openstack-nova | 19:15 | |
| mriedem | mikal: totally not a problem | 19:15 |
| *** iuliat has quit IRC | 19:16 | |
| *** iuliat has joined #openstack-nova | 19:17 | |
| *** jdurgin1 has joined #openstack-nova | 19:18 | |
| *** fifieldt has joined #openstack-nova | 19:18 | |
| *** itoader has quit IRC | 19:19 | |
| *** abalutoiu has quit IRC | 19:20 | |
| *** oomichi has quit IRC | 19:20 | |
| *** READ10 has quit IRC | 19:21 | |
| *** shaohe_feng has quit IRC | 19:22 | |
| *** efoley has quit IRC | 19:22 | |
| *** shaohe_feng has joined #openstack-nova | 19:23 | |
| *** zul_ has joined #openstack-nova | 19:23 | |
| *** iuliat has quit IRC | 19:27 | |
| alaski | mriedem: sdague I have a question on release note tense in https://review.openstack.org/#/c/333098/6 | 19:28 |
| *** itoader has joined #openstack-nova | 19:28 | |
| mriedem | i don't think have been is correct | 19:28 |
| mriedem | a command is provided to migrate server groups to the api database, new server groups are automatically created in the api database | 19:29 |
| *** efried has joined #openstack-nova | 19:29 | |
| *** tblakeslee is now known as tblakes | 19:29 | |
| sdague | maybe we need some standard boiler plate for online migrations, because existing ones get moved if updated as well right? | 19:31 |
| mriedem | no | 19:31 |
| alaski | not in this case | 19:31 |
| *** tesseract- has joined #openstack-nova | 19:31 | |
| mriedem | but that's what everyone thinks by default b/c we were spoiled in kilo with the only flavor migration that dansmith did | 19:31 |
| mriedem | s/only/online/ | 19:32 |
| mriedem | new things go to the api db, lookups start in the api db, and fallback to the cell db | 19:32 |
| *** ametts has quit IRC | 19:32 | |
| mriedem | existing things are manually migrated using the online_data_migrations command | 19:32 |
| *** bvanhav has quit IRC | 19:32 | |
| dansmith | depends | 19:32 |
| openstackgerrit | Jay Pipes proposed openstack/nova: rt: Refactor test_dupe_filter unit test https://review.openstack.org/350319 | 19:32 |
| openstackgerrit | Jay Pipes proposed openstack/nova: rt: Remove incorrect unit test of resize revert https://review.openstack.org/350754 | 19:32 |
| openstackgerrit | Jay Pipes proposed openstack/nova: rt: Remove dup tests in test_resource_tracker https://review.openstack.org/350755 | 19:32 |
| openstackgerrit | Jay Pipes proposed openstack/nova: rt: Remove useless unit test in resource tracker https://review.openstack.org/350756 | 19:32 |
| openstackgerrit | Jay Pipes proposed openstack/nova: rt: Move unit tests for update mig usage https://review.openstack.org/350757 | 19:32 |
| dansmith | these api moves work that way, but not all online migrations do/will | 19:32 |
| *** shaohe_feng has quit IRC | 19:32 | |
| *** clenimar has quit IRC | 19:34 | |
| mriedem | wznoinsk: btw, is it all intel nfv ci jobs or just Intel NFV CI? | 19:34 |
| *** diogogmt has joined #openstack-nova | 19:34 | |
| mriedem | nvm, i guess the ci is Intel NFV CI | 19:34 |
| mriedem | with 3 jobs | 19:34 |
| *** iuliat has joined #openstack-nova | 19:34 | |
| *** kenperkins has quit IRC | 19:34 | |
| *** clenimar has joined #openstack-nova | 19:35 | |
| *** zul_ has quit IRC | 19:35 | |
| *** shaohe_feng has joined #openstack-nova | 19:35 | |
| *** zul_ has joined #openstack-nova | 19:35 | |
| *** tesseract- has quit IRC | 19:37 | |
| *** itoader has quit IRC | 19:37 | |
| jaypipes | dansmith: ^^ is some more pushes (and a fix) of those resource tracker unit tests. | 19:38 |
| *** ihrachys has joined #openstack-nova | 19:41 | |
| *** shaohe_feng has quit IRC | 19:43 | |
| *** shaohe_feng has joined #openstack-nova | 19:43 | |
| *** ametts has joined #openstack-nova | 19:45 | |
| *** ayoung has joined #openstack-nova | 19:45 | |
| *** tonytan4ever has joined #openstack-nova | 19:49 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Add REST API support for get me a network https://review.openstack.org/316398 | 19:50 |
| openstackgerrit | Lee Yarwood proposed openstack/nova: compute: Use stashed connector during local deletes https://review.openstack.org/340951 | 19:51 |
| *** itoader has joined #openstack-nova | 19:52 | |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: WIP: Added "networks" object in server-create-request https://review.openstack.org/309362 | 19:53 |
| *** shaohe_feng has quit IRC | 19:53 | |
| openstackgerrit | Jay Pipes proposed openstack/nova: rt: Move unit tests for update mig usage https://review.openstack.org/350757 | 19:53 |
| *** shaohe_feng has joined #openstack-nova | 19:53 | |
| *** iuliat has quit IRC | 19:55 | |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: Deprecate cert option https://review.openstack.org/348055 | 19:55 |
| *** TravT has quit IRC | 19:56 | |
| *** iuliat has joined #openstack-nova | 19:56 | |
| *** TravT has joined #openstack-nova | 19:59 | |
| *** itoader has quit IRC | 19:59 | |
| *** permalac has quit IRC | 20:02 | |
| openstackgerrit | Michael Glaser proposed openstack/nova: Check opt consistency for neutron.py https://review.openstack.org/349605 | 20:03 |
| *** shaohe_feng has quit IRC | 20:03 | |
| *** permalac has joined #openstack-nova | 20:03 | |
| *** shaohe_feng has joined #openstack-nova | 20:04 | |
| *** iuliat has quit IRC | 20:05 | |
| *** matrohon has joined #openstack-nova | 20:06 | |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: config options: Improve help for conductor https://review.openstack.org/324784 | 20:08 |
| *** lpetrut has quit IRC | 20:10 | |
| *** daemontool has joined #openstack-nova | 20:10 | |
| *** kenperkins has joined #openstack-nova | 20:11 | |
| *** coolsvap has quit IRC | 20:11 | |
| *** shaohe_feng has quit IRC | 20:13 | |
| *** shaohe_feng has joined #openstack-nova | 20:14 | |
| *** iuliat has joined #openstack-nova | 20:19 | |
| *** ihrachys has quit IRC | 20:20 | |
| *** itoader has joined #openstack-nova | 20:23 | |
| *** shaohe_feng has quit IRC | 20:24 | |
| *** shaohe_feng has joined #openstack-nova | 20:24 | |
| *** iuliat has quit IRC | 20:25 | |
| *** itoader has quit IRC | 20:33 | |
| *** shaohe_feng has quit IRC | 20:34 | |
| *** Jeffrey4l_ has joined #openstack-nova | 20:35 | |
| *** Jeffrey4l has quit IRC | 20:35 | |
| *** shaohe_feng has joined #openstack-nova | 20:35 | |
| *** devkulkarni1 has quit IRC | 20:39 | |
| *** baoli_ has quit IRC | 20:39 | |
| *** baoli has joined #openstack-nova | 20:40 | |
| openstackgerrit | Anush Krishnamurthy proposed openstack/nova: Deprecate cert option https://review.openstack.org/348055 | 20:40 |
| *** shaohe_feng has quit IRC | 20:44 | |
| *** oomichi has joined #openstack-nova | 20:47 | |
| *** shaohe_feng has joined #openstack-nova | 20:47 | |
| *** daemontool has quit IRC | 20:48 | |
| *** smatzek has quit IRC | 20:49 | |
| *** Sukhdev has quit IRC | 20:52 | |
| *** ametts has quit IRC | 20:52 | |
| *** Sukhdev has joined #openstack-nova | 20:53 | |
| *** shaohe_feng has quit IRC | 20:54 | |
| *** shaohe_feng has joined #openstack-nova | 20:55 | |
| *** itoader has joined #openstack-nova | 20:56 | |
| *** jwcroppe has quit IRC | 20:58 | |
| *** itoader has quit IRC | 21:02 | |
| *** shaohe_feng has quit IRC | 21:05 | |
| *** shaohe_feng has joined #openstack-nova | 21:06 | |
| *** READ10 has joined #openstack-nova | 21:06 | |
| *** liverpooler has quit IRC | 21:08 | |
| *** rlrossit has quit IRC | 21:08 | |
| *** JoseMello has quit IRC | 21:10 | |
| mriedem | doffm: you were asking about this this morning | 21:13 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L2392 | 21:13 |
| mriedem | default sort order for listing instances is created_at,id | 21:13 |
| mriedem | which is why we have https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L215 | 21:13 |
| mriedem | which is from https://review.openstack.org/#/c/288765/ | 21:14 |
| mriedem | that's in mitaka | 21:14 |
| *** fifieldt has quit IRC | 21:15 | |
| *** shaohe_feng has quit IRC | 21:15 | |
| *** shaohe_feng has joined #openstack-nova | 21:16 | |
| mriedem | dansmith: jaypipes: jroll: you know what's confusing? reading about compute nodes and ironic nodes in the same paragraph | 21:24 |
| mriedem | compute host / service / node is already a confusing concept | 21:24 |
| dansmith | yup | 21:24 |
| mriedem | so i'm going to ask probably a terribly dumb question, but is there only a single instance in an ironic compute node or? | 21:25 |
| *** shaohe_feng has quit IRC | 21:25 | |
| *** fifieldt has joined #openstack-nova | 21:25 | |
| dansmith | mriedem: correct | 21:25 |
| dansmith | one ironic node is one baremetal host, which can take one instance | 21:26 |
| mriedem | ok, because i was reading, "It's also important to note that, due to the way nodes with instances are handled, if an instance is deleted while the compute service is down, that node will be removed from the compute_nodes table when the service comes back up" | 21:26 |
| *** shaohe_feng has joined #openstack-nova | 21:26 | |
| mriedem | and thinking, did he mean 'instances', plural? | 21:26 |
| *** itoader has joined #openstack-nova | 21:27 | |
| *** baoli has quit IRC | 21:27 | |
| dansmith | yeah, it's definitely a bastardization of the rest of our stuff, because we require you to fully consume a node with an instance right now | 21:27 |
| dansmith | resource providers will make that a little less terrible | 21:27 |
| *** jwcroppe has joined #openstack-nova | 21:28 | |
| jaypipes | dansmith: a lot less terrible. :) | 21:29 |
| dansmith | measurably less terrible | 21:30 |
| jaypipes | :) | 21:30 |
| mriedem | we should say, 'at a fraction of the cost' more often because i always love that marketing trick | 21:31 |
| dansmith | heh | 21:31 |
| mriedem | it's .97 of the cost | 21:31 |
| mriedem | you can't afford not to buy it! | 21:31 |
| jaypipes | heh | 21:31 |
| *** matrohon has quit IRC | 21:32 | |
| *** moshele has joined #openstack-nova | 21:32 | |
| *** itoader has quit IRC | 21:34 | |
| *** shaohe_feng has quit IRC | 21:35 | |
| *** shaohe_feng has joined #openstack-nova | 21:36 | |
| mriedem | ok, my comments in https://review.openstack.org/#/c/350283/ | 21:36 |
| mriedem | only real question is https://review.openstack.org/#/c/350283/3/specs/newton/approved/ironic-multiple-compute-hosts.rst@58 | 21:37 |
| *** chenfei has quit IRC | 21:37 | |
| mriedem | dansmith: jaypipes: ^ can you answer that for me quick? | 21:37 |
| *** Qiming has quit IRC | 21:37 | |
| dansmith | just a sec | 21:37 |
| *** Qiming has joined #openstack-nova | 21:39 | |
| dansmith | mriedem: see if that helps | 21:40 |
| *** chenfei has joined #openstack-nova | 21:40 | |
| *** thorst has quit IRC | 21:40 | |
| jaypipes | mriedem: yeah, dansmith answered. | 21:40 |
| dansmith | mriedem: commented on your other thing too | 21:42 |
| *** sdake has quit IRC | 21:43 | |
| mriedem | alright | 21:43 |
| dansmith | mriedem: thanks | 21:44 |
| dansmith | mriedem: so you're good to remove the -2 on the code? or was there something else? | 21:45 |
| mriedem | something else http://m.target.com/p/graco-highback-turbobooster/-/A-15288055 | 21:45 |
| mriedem | i'm shopping | 21:45 |
| dansmith | gross | 21:45 |
| *** rtheis_ has quit IRC | 21:46 | |
| mriedem | that kid http://scene7.targetimg1.com/is/image/Target/50881510_Alt05?wid=450&hei=450&fmt=pjpeg | 21:46 |
| *** shaohe_feng has quit IRC | 21:46 | |
| mriedem | and this kid http://scene7.targetimg1.com/is/image/Target/50881510_Alt04?wid=450&hei=450&fmt=pjpeg | 21:46 |
| mriedem | it's going to be rough for them | 21:46 |
| dansmith | haha | 21:46 |
| jaypipes | lol | 21:46 |
| mriedem | i dropped the -2 on the change | 21:47 |
| *** shaohe_feng has joined #openstack-nova | 21:47 | |
| *** itoader has joined #openstack-nova | 21:49 | |
| dansmith | rock on | 21:50 |
| mriedem | alaski: looks like you have some ci failures in https://review.openstack.org/#/c/325985/ | 21:52 |
| mriedem | and therefore i get out of reviewing it tonight | 21:53 |
| *** burgerk_ has joined #openstack-nova | 21:53 | |
| openstackgerrit | Alex Szarka proposed openstack/nova: Recover instances when physical data is missing https://review.openstack.org/322341 | 21:53 |
| *** itoader has quit IRC | 21:55 | |
| *** burgerk has quit IRC | 21:56 | |
| *** shaohe_feng has quit IRC | 21:56 | |
| *** jwcroppe_ has joined #openstack-nova | 21:56 | |
| *** shaohe_feng has joined #openstack-nova | 21:57 | |
| *** jwcroppe has quit IRC | 21:58 | |
| *** burgerk_ has quit IRC | 21:58 | |
| *** corey_ has quit IRC | 21:58 | |
| *** markvoelker has quit IRC | 21:58 | |
| *** markvoelker has joined #openstack-nova | 21:59 | |
| *** mriedem has quit IRC | 22:01 | |
| *** oomichi has quit IRC | 22:02 | |
| *** eharney has quit IRC | 22:02 | |
| *** eharney has joined #openstack-nova | 22:03 | |
| *** thorst has joined #openstack-nova | 22:03 | |
| *** markvoelker has quit IRC | 22:03 | |
| *** shaohe_feng has quit IRC | 22:06 | |
| *** mdrabe_ has quit IRC | 22:07 | |
| *** shaohe_feng has joined #openstack-nova | 22:07 | |
| *** thorst has quit IRC | 22:07 | |
| *** burt has quit IRC | 22:08 | |
| *** cdelatte has quit IRC | 22:08 | |
| *** moshele has quit IRC | 22:10 | |
| *** annegentle has quit IRC | 22:13 | |
| *** yassou has quit IRC | 22:14 | |
| *** jwcroppe has joined #openstack-nova | 22:14 | |
| *** shaohe_feng has quit IRC | 22:16 | |
| *** jwcroppe_ has quit IRC | 22:17 | |
| *** shaohe_feng has joined #openstack-nova | 22:17 | |
| *** dimtruck is now known as zz_dimtruck | 22:20 | |
| *** shaohe_feng has quit IRC | 22:27 | |
| *** shaohe_feng has joined #openstack-nova | 22:28 | |
| *** rfolco has quit IRC | 22:30 | |
| *** mlavalle has quit IRC | 22:37 | |
| *** shaohe_feng has quit IRC | 22:37 | |
| *** shaohe_feng has joined #openstack-nova | 22:38 | |
| *** ducttape_ has quit IRC | 22:41 | |
| *** efried has quit IRC | 22:43 | |
| *** zul_ has quit IRC | 22:46 | |
| *** shaohe_feng has quit IRC | 22:47 | |
| *** zz_dimtruck is now known as dimtruck | 22:48 | |
| *** shaohe_feng has joined #openstack-nova | 22:48 | |
| *** hemna is now known as hemnafk | 22:52 | |
| *** xyang1 has quit IRC | 22:56 | |
| *** shaohe_feng has quit IRC | 22:57 | |
| *** sameo has quit IRC | 22:58 | |
| *** shaohe_feng has joined #openstack-nova | 22:58 | |
| *** ducttape_ has joined #openstack-nova | 23:02 | |
| *** sdake has joined #openstack-nova | 23:03 | |
| *** seldenr has quit IRC | 23:07 | |
| *** shaohe_feng has quit IRC | 23:08 | |
| *** shaohe_feng has joined #openstack-nova | 23:08 | |
| *** diogogmt has quit IRC | 23:09 | |
| *** tblakes has quit IRC | 23:12 | |
| *** shaohe_feng has quit IRC | 23:18 | |
| *** shaohe_feng has joined #openstack-nova | 23:19 | |
| *** diogogmt has joined #openstack-nova | 23:19 | |
| *** ducttape_ has quit IRC | 23:24 | |
| *** ducttape_ has joined #openstack-nova | 23:25 | |
| *** diogogmt has quit IRC | 23:27 | |
| *** shaohe_feng has quit IRC | 23:28 | |
| *** sdague has quit IRC | 23:29 | |
| jaypipes | dansmith, Yingxin, edleafe, alex_xu, jroll: https://github.com/jaypipes/os-capabilities | 23:29 |
| *** shaohe_feng has joined #openstack-nova | 23:29 | |
| *** tonytan4ever has quit IRC | 23:33 | |
| *** shaohe_feng has quit IRC | 23:38 | |
| *** hoonetorg has quit IRC | 23:39 | |
| *** shaohe_feng has joined #openstack-nova | 23:39 | |
| *** tblakes has joined #openstack-nova | 23:40 | |
| *** Swami has quit IRC | 23:41 | |
| alex_xu | jaypipes: cool! | 23:43 |
| *** hoonetorg has joined #openstack-nova | 23:44 | |
| *** takashin has joined #openstack-nova | 23:47 | |
| alex_xu | jaypipes: do we need spec for os-capabilities, or we just comment on github? | 23:47 |
| jaypipes | alex_xu: just sent a ML thread on it. please feel free to comment on that with your suggestions! :) Also, of course, feel free to submit pull requests! | 23:48 |
| *** jamielennox is now known as jamielennox|away | 23:48 | |
| *** jaypipes has quit IRC | 23:48 | |
| *** shaohe_feng has quit IRC | 23:49 | |
| *** ducttape_ has quit IRC | 23:49 | |
| *** shaohe_feng has joined #openstack-nova | 23:49 | |
| alex_xu | jaypipes: cool, thanks! not sure have any comment yet, I and YingXin just begin to discuss the interface of os-capabilities, but we didn't any time to do any actual thing :) but will try to catch up and see anything we can help on | 23:49 |
| *** jamesdenton has joined #openstack-nova | 23:50 | |
| *** sdake has quit IRC | 23:51 | |
| *** rrecio has quit IRC | 23:54 | |
| *** hoangcx has joined #openstack-nova | 23:55 | |
| *** code-R_ has quit IRC | 23:55 | |
| *** sdake has joined #openstack-nova | 23:55 | |
| gmann | edleafe: ops, yea i should use mock. just copy paste from old tests :). Thanks for catching that | 23:58 |
| *** TravT has quit IRC | 23:59 | |
| *** shaohe_feng has quit IRC | 23:59 | |
| *** shaohe_feng has joined #openstack-nova | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
