| *** hieulq has quit IRC | 00:01 | |
| *** jwcroppe has quit IRC | 00:01 | |
| *** jamielennox|away is now known as jamielennox | 00:01 | |
| *** ducttape_ has joined #openstack-nova | 00:02 | |
| *** jamesdenton has quit IRC | 00:03 | |
| *** jwcroppe has joined #openstack-nova | 00:04 | |
| *** ducttape_ has quit IRC | 00:05 | |
| *** mriedem has joined #openstack-nova | 00:06 | |
| *** zul has quit IRC | 00:07 | |
| *** TravT has joined #openstack-nova | 00:08 | |
| *** zul has joined #openstack-nova | 00:09 | |
| *** shaohe_feng has quit IRC | 00:09 | |
| *** shaohe_feng has joined #openstack-nova | 00:10 | |
| *** sdake has quit IRC | 00:10 | |
| *** ducttape_ has joined #openstack-nova | 00:11 | |
| *** baoli has joined #openstack-nova | 00:13 | |
| *** mtanino has quit IRC | 00:14 | |
| *** hieulq has joined #openstack-nova | 00:16 | |
| *** TravT has quit IRC | 00:17 | |
| *** baoli has quit IRC | 00:18 | |
| *** shaohe_feng has quit IRC | 00:19 | |
| *** shaohe_feng has joined #openstack-nova | 00:20 | |
| *** TravT has joined #openstack-nova | 00:22 | |
| mriedem | jroll: pep8 https://review.openstack.org/#/c/349528/ ? | 00:23 |
|---|---|---|
| mriedem | problems are i nhttps://review.openstack.org/#/c/350679/4/ironic/tests/unit/objects/test_fields.py | 00:24 |
| *** TravT has quit IRC | 00:26 | |
| *** shaohe_feng has quit IRC | 00:30 | |
| *** shaohe_feng has joined #openstack-nova | 00:30 | |
| *** TravT has joined #openstack-nova | 00:31 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Add the ability to configure glanceclient debug logging https://review.openstack.org/347914 | 00:32 |
| *** tonytan4ever has joined #openstack-nova | 00:33 | |
| *** hoangcx has quit IRC | 00:37 | |
| *** hoangcx has joined #openstack-nova | 00:37 | |
| *** nic has quit IRC | 00:37 | |
| *** tonytan4ever has quit IRC | 00:38 | |
| *** haplo37__ has quit IRC | 00:40 | |
| *** shaohe_feng has quit IRC | 00:40 | |
| *** gjayavelu has quit IRC | 00:41 | |
| *** stewie925_ has quit IRC | 00:42 | |
| openstackgerrit | Tina Kevin proposed openstack/nova-specs: Add allocation ratio to hypervisor-show https://review.openstack.org/350348 | 00:43 |
| *** ducttape_ has quit IRC | 00:44 | |
| *** thorst has joined #openstack-nova | 00:45 | |
| *** hoangcx has joined #openstack-nova | 00:45 | |
| *** shaohe_feng has joined #openstack-nova | 00:47 | |
| *** ssurana has quit IRC | 00:47 | |
| openstackgerrit | Tina Kevin proposed openstack/nova-specs: Add allocation ratio to hypervisor-show https://review.openstack.org/350348 | 00:47 |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova-specs: Add spec for lower case metadata keys only https://review.openstack.org/350843 | 00:49 |
| *** shaohe_feng has quit IRC | 00:50 | |
| *** shaohe_feng has joined #openstack-nova | 00:51 | |
| *** code-R has joined #openstack-nova | 00:53 | |
| openstackgerrit | Augustina Ragwitz proposed openstack/nova-specs: Add Keystone project validation to quota and flavor management https://review.openstack.org/350844 | 00:54 |
| *** code-R_ has joined #openstack-nova | 00:54 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Strict ImageRef validation to UUID only https://review.openstack.org/338802 | 00:56 |
| *** code-R has quit IRC | 00:57 | |
| *** phuongnh has joined #openstack-nova | 00:58 | |
| *** shaohe_feng has quit IRC | 01:00 | |
| *** shaohe_feng has joined #openstack-nova | 01:01 | |
| *** TravT has quit IRC | 01:03 | |
| *** thorst has quit IRC | 01:04 | |
| *** thorst has joined #openstack-nova | 01:05 | |
| *** TravT has joined #openstack-nova | 01:07 | |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: PCI: Fix network calls order on finish_revert_resize() https://review.openstack.org/349061 | 01:10 |
| *** shaohe_feng has quit IRC | 01:11 | |
| *** rama_y has quit IRC | 01:11 | |
| *** shaohe_feng has joined #openstack-nova | 01:11 | |
| *** Sukhdev has quit IRC | 01:12 | |
| *** thorst has quit IRC | 01:13 | |
| *** Apoorva_ has joined #openstack-nova | 01:16 | |
| *** TravT has quit IRC | 01:16 | |
| *** Apoorva has quit IRC | 01:18 | |
| *** Apoorva_ has quit IRC | 01:20 | |
| *** shaohe_feng has quit IRC | 01:21 | |
| openstackgerrit | Fang He proposed openstack/nova: use the HostPortGroupSpec.vswitchName instead of HostPortGroup.vswitch.split https://review.openstack.org/350335 | 01:21 |
| openstackgerrit | Fang He proposed openstack/nova: add the mock attribute https://review.openstack.org/350852 | 01:21 |
| *** TravT has joined #openstack-nova | 01:21 | |
| *** shaohe_feng has joined #openstack-nova | 01:22 | |
| alex_xu | mriedem: I remember I can input [{'auto', None, None}, {'...uuid...', None, None}] with your patch, and the api layer didn't stop me | 01:23 |
| mriedem | impossible | 01:23 |
| alex_xu | mriedem: ok, let me check again :) | 01:24 |
| mriedem | alex_xu: i'm joking | 01:24 |
| mriedem | leave a -1, i don't have a unit test for that | 01:24 |
| alex_xu | mriedem: heh, yea | 01:24 |
| mriedem | i have a unit test for auto and none | 01:24 |
| mriedem | and none and none | 01:24 |
| mriedem | but not auto and uuid | 01:24 |
| *** chenfan has quit IRC | 01:25 | |
| mriedem | i'll fix it tomorrow | 01:25 |
| alex_xu | mriedem: the api layer didn't stop me, I get exception from network_api | 01:25 |
| mriedem | ok, the api should stop you though | 01:25 |
| mriedem | so i'm missing something | 01:25 |
| alex_xu | mriedem: ok, got it | 01:26 |
| mriedem | eliqiao: looks like Vek should have -1'ed here https://review.openstack.org/#/c/334739/ | 01:27 |
| mriedem | but an easy change to get that to +2 | 01:28 |
| *** TravT has quit IRC | 01:30 | |
| *** shaohe_feng has quit IRC | 01:31 | |
| *** shaohe_feng has joined #openstack-nova | 01:32 | |
| *** pwnall has joined #openstack-nova | 01:32 | |
| *** jamielennox is now known as jamielennox|away | 01:34 | |
| *** sofie has joined #openstack-nova | 01:35 | |
| *** unicell1 has quit IRC | 01:37 | |
| *** sofie has quit IRC | 01:38 | |
| *** chenfan has joined #openstack-nova | 01:38 | |
| eliqiao | mriedem: okay, I will take a look | 01:38 |
| *** shaohe_feng has quit IRC | 01:41 | |
| *** shaohe_feng has joined #openstack-nova | 01:42 | |
| *** ljxiash has joined #openstack-nova | 01:45 | |
| *** thorst has joined #openstack-nova | 01:46 | |
| openstackgerrit | Fang He proposed openstack/nova: use the HostPortGroupSpec.vswitchName instead of HostPortGroup.vswitch.split https://review.openstack.org/350852 | 01:46 |
| *** smatzek has joined #openstack-nova | 01:46 | |
| *** thorst has quit IRC | 01:47 | |
| *** thorst has joined #openstack-nova | 01:47 | |
| *** ljxiash has quit IRC | 01:50 | |
| *** ljxiash has joined #openstack-nova | 01:51 | |
| *** shaohe_feng has quit IRC | 01:52 | |
| *** shaohe_feng has joined #openstack-nova | 01:52 | |
| *** ljxiash_ has joined #openstack-nova | 01:52 | |
| openstackgerrit | Eli Qiao proposed openstack/nova: cleanup: some update xml cases in test_migration https://review.openstack.org/334739 | 01:54 |
| *** dimtruck is now known as zz_dimtruck | 01:55 | |
| *** EinstCrazy has joined #openstack-nova | 01:55 | |
| eliqiao | mriedem: ^^ | 01:55 |
| *** thorst has quit IRC | 01:56 | |
| *** baoli has joined #openstack-nova | 01:56 | |
| mriedem | thanks | 01:56 |
| *** ljxiash has quit IRC | 01:56 | |
| eliqiao | np :) | 01:56 |
| *** dmellado has quit IRC | 01:57 | |
| *** migi has quit IRC | 01:57 | |
| *** ajo has quit IRC | 01:57 | |
| *** migi_ has joined #openstack-nova | 01:57 | |
| *** shaohe_feng has quit IRC | 02:02 | |
| *** dmellado has joined #openstack-nova | 02:02 | |
| *** shaohe_feng has joined #openstack-nova | 02:03 | |
| *** ajo has joined #openstack-nova | 02:03 | |
| *** tblakes has quit IRC | 02:06 | |
| *** amotoki has joined #openstack-nova | 02:10 | |
| *** shaohe_feng has quit IRC | 02:12 | |
| *** kenperkins has quit IRC | 02:15 | |
| *** shaohe_feng has joined #openstack-nova | 02:15 | |
| *** ducttape_ has joined #openstack-nova | 02:15 | |
| *** thorst has joined #openstack-nova | 02:18 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Strict ImageRef validation to UUID only https://review.openstack.org/338802 | 02:18 |
| gmann | mriedem: chck if it looks fine now - https://review.openstack.org/#/c/338802/11 | 02:19 |
| *** dave-mccowan has quit IRC | 02:19 | |
| mriedem | looks good | 02:19 |
| mriedem | i haven't gone through the rest of the change | 02:20 |
| mriedem | signing off soon | 02:20 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Strict ImageRef validation to UUID only https://review.openstack.org/338802 | 02:20 |
| *** ducttape_ has quit IRC | 02:20 | |
| *** mriedem has quit IRC | 02:20 | |
| gmann | mriedem: ok, and we can wait for gate too. m testing it on tempest also with all jobs - https://review.openstack.org/#/c/348158/ | 02:21 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Strict ImageRef validation to UUID only https://review.openstack.org/338802 | 02:22 |
| *** shaohe_feng has quit IRC | 02:22 | |
| *** shaohe_feng has joined #openstack-nova | 02:23 | |
| *** zz_dimtruck is now known as dimtruck | 02:24 | |
| *** markvoelker has joined #openstack-nova | 02:26 | |
| *** baoli has quit IRC | 02:26 | |
| *** thorst has quit IRC | 02:27 | |
| *** thorst has joined #openstack-nova | 02:28 | |
| *** shaohe_feng has quit IRC | 02:33 | |
| *** browne1 has quit IRC | 02:34 | |
| *** shaohe_feng has joined #openstack-nova | 02:36 | |
| *** jamielennox|away is now known as jamielennox | 02:36 | |
| *** tiendc has joined #openstack-nova | 02:36 | |
| *** thorst has quit IRC | 02:37 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/350901 | 02:39 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif: Updated from global requirements https://review.openstack.org/339919 | 02:40 |
| *** shaohe_feng has quit IRC | 02:43 | |
| *** shaohe_feng has joined #openstack-nova | 02:44 | |
| *** zerda2 has joined #openstack-nova | 02:44 | |
| *** READ10 has quit IRC | 02:45 | |
| *** liusheng has quit IRC | 02:49 | |
| *** hieulq_ has joined #openstack-nova | 02:52 | |
| *** hieulq_ has quit IRC | 02:53 | |
| *** hieulq_ has joined #openstack-nova | 02:53 | |
| *** shaohe_feng has quit IRC | 02:53 | |
| *** shaohe_feng has joined #openstack-nova | 02:54 | |
| *** itlinux has quit IRC | 02:54 | |
| *** itlinux has joined #openstack-nova | 02:56 | |
| *** palexster has quit IRC | 02:57 | |
| *** yamahata has quit IRC | 03:03 | |
| *** shaohe_feng has quit IRC | 03:03 | |
| *** shaohe_feng has joined #openstack-nova | 03:04 | |
| *** sdake has joined #openstack-nova | 03:04 | |
| *** browne has joined #openstack-nova | 03:11 | |
| *** shaohe_feng has quit IRC | 03:14 | |
| *** shaohe_feng has joined #openstack-nova | 03:14 | |
| *** ducttape_ has joined #openstack-nova | 03:17 | |
| *** smatzek has quit IRC | 03:20 | |
| *** TravT has joined #openstack-nova | 03:21 | |
| *** coolsvap has joined #openstack-nova | 03:22 | |
| *** ducttape_ has quit IRC | 03:22 | |
| *** sdake has quit IRC | 03:23 | |
| *** browne has quit IRC | 03:23 | |
| *** shaohe_feng has quit IRC | 03:24 | |
| *** shaohe_feng has joined #openstack-nova | 03:25 | |
| *** TravT has quit IRC | 03:30 | |
| *** shaohe_feng has quit IRC | 03:34 | |
| *** thorst has joined #openstack-nova | 03:35 | |
| *** shaohe_feng has joined #openstack-nova | 03:35 | |
| *** kevinz has joined #openstack-nova | 03:35 | |
| *** TravT has joined #openstack-nova | 03:35 | |
| *** ljxiash_ has quit IRC | 03:35 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Don't pass argument sqlite_db in method set_defaults https://review.openstack.org/350947 | 03:35 |
| *** jwcroppe has quit IRC | 03:39 | |
| *** thorst has quit IRC | 03:42 | |
| *** ljxiash has joined #openstack-nova | 03:44 | |
| *** shaohe_feng has quit IRC | 03:44 | |
| *** shaohe_feng has joined #openstack-nova | 03:45 | |
| *** markvoelker has quit IRC | 03:46 | |
| *** gongysh has joined #openstack-nova | 03:47 | |
| *** sdake has joined #openstack-nova | 03:50 | |
| *** ljxiash has quit IRC | 03:52 | |
| *** ljxiash has joined #openstack-nova | 03:52 | |
| *** amotoki has quit IRC | 03:54 | |
| *** shaohe_feng has quit IRC | 03:55 | |
| *** amotoki has joined #openstack-nova | 03:55 | |
| *** shaohe_feng has joined #openstack-nova | 03:56 | |
| *** ljxiash has quit IRC | 03:57 | |
| *** TravT has quit IRC | 03:58 | |
| *** Sukhdev has joined #openstack-nova | 04:03 | |
| *** gongysh has quit IRC | 04:04 | |
| *** Sukhdev has quit IRC | 04:04 | |
| *** Sukhdev has joined #openstack-nova | 04:04 | |
| *** shaohe_feng has quit IRC | 04:05 | |
| *** gongysh has joined #openstack-nova | 04:05 | |
| *** chenfan has quit IRC | 04:06 | |
| *** chenfan has joined #openstack-nova | 04:06 | |
| *** shaohe_feng has joined #openstack-nova | 04:08 | |
| *** ayoung has quit IRC | 04:08 | |
| *** shaohe_feng has quit IRC | 04:15 | |
| *** shaohe_feng has joined #openstack-nova | 04:16 | |
| *** ducttape_ has joined #openstack-nova | 04:19 | |
| *** markvoelker has joined #openstack-nova | 04:22 | |
| *** ducttape_ has quit IRC | 04:23 | |
| *** nkrinner_afk is now known as nkrinner | 04:24 | |
| *** shaohe_feng has quit IRC | 04:25 | |
| *** TravT has joined #openstack-nova | 04:26 | |
| *** shaohe_feng has joined #openstack-nova | 04:26 | |
| *** markvoelker has quit IRC | 04:26 | |
| *** links has joined #openstack-nova | 04:28 | |
| *** TravT has quit IRC | 04:31 | |
| *** gjayavelu has joined #openstack-nova | 04:33 | |
| *** ratailor has joined #openstack-nova | 04:35 | |
| *** shaohe_feng has quit IRC | 04:36 | |
| *** shaohe_feng has joined #openstack-nova | 04:36 | |
| *** sdake has quit IRC | 04:37 | |
| *** chenfei has quit IRC | 04:37 | |
| *** Qiming has quit IRC | 04:39 | |
| *** TravT has joined #openstack-nova | 04:39 | |
| *** chenfei has joined #openstack-nova | 04:40 | |
| *** thorst has joined #openstack-nova | 04:41 | |
| *** ljxiash has joined #openstack-nova | 04:42 | |
| *** Qiming has joined #openstack-nova | 04:44 | |
| *** shaohe_feng has quit IRC | 04:46 | |
| *** shaohe_feng has joined #openstack-nova | 04:46 | |
| *** thorst has quit IRC | 04:47 | |
| *** TravT has quit IRC | 04:49 | |
| *** TravT has joined #openstack-nova | 04:50 | |
| *** gongysh has quit IRC | 04:53 | |
| *** zerda2 has quit IRC | 04:53 | |
| *** TravT has quit IRC | 04:55 | |
| *** TravT has joined #openstack-nova | 04:55 | |
| *** TravT has quit IRC | 04:56 | |
| *** chandankumar has joined #openstack-nova | 04:56 | |
| *** shaohe_feng has quit IRC | 04:56 | |
| *** shaohe_feng has joined #openstack-nova | 04:57 | |
| *** unicell has joined #openstack-nova | 04:58 | |
| *** TravT has joined #openstack-nova | 05:00 | |
| *** moshele has joined #openstack-nova | 05:00 | |
| *** gjayavelu has quit IRC | 05:02 | |
| *** jraju has joined #openstack-nova | 05:04 | |
| *** moshele has quit IRC | 05:04 | |
| *** unicell has quit IRC | 05:05 | |
| *** hshiina has joined #openstack-nova | 05:05 | |
| *** zerda2 has joined #openstack-nova | 05:06 | |
| *** links has quit IRC | 05:06 | |
| *** shaohe_feng has quit IRC | 05:06 | |
| *** unicell has joined #openstack-nova | 05:08 | |
| *** shaohe_feng has joined #openstack-nova | 05:09 | |
| *** TravT has quit IRC | 05:10 | |
| *** pbandark has joined #openstack-nova | 05:10 | |
| *** TravT has joined #openstack-nova | 05:14 | |
| *** rcernin has joined #openstack-nova | 05:16 | |
| *** markvoelker has joined #openstack-nova | 05:16 | |
| *** shaohe_feng has quit IRC | 05:17 | |
| *** shaohe_feng has joined #openstack-nova | 05:17 | |
| *** TravT has quit IRC | 05:18 | |
| *** ducttape_ has joined #openstack-nova | 05:19 | |
| *** markvoelker has quit IRC | 05:22 | |
| *** ducttape_ has quit IRC | 05:24 | |
| *** shaohe_feng has quit IRC | 05:27 | |
| *** shaohe_feng has joined #openstack-nova | 05:28 | |
| *** Qiming has quit IRC | 05:32 | |
| *** Qiming has joined #openstack-nova | 05:33 | |
| *** irenab has joined #openstack-nova | 05:34 | |
| *** haplo37__ has joined #openstack-nova | 05:34 | |
| *** shaohe_feng has quit IRC | 05:37 | |
| *** tiendc|afk has joined #openstack-nova | 05:38 | |
| *** shaohe_feng has joined #openstack-nova | 05:38 | |
| *** tiendc has quit IRC | 05:41 | |
| *** haplo37__ has quit IRC | 05:42 | |
| *** ekuris_ has joined #openstack-nova | 05:42 | |
| *** thorst has joined #openstack-nova | 05:44 | |
| *** lpetrut has joined #openstack-nova | 05:46 | |
| *** shaohe_feng has quit IRC | 05:47 | |
| *** shaohe_feng has joined #openstack-nova | 05:48 | |
| *** edand has joined #openstack-nova | 05:50 | |
| *** moshele has joined #openstack-nova | 05:52 | |
| *** thorst has quit IRC | 05:52 | |
| *** maestropandy has joined #openstack-nova | 05:52 | |
| *** pwnall has quit IRC | 05:56 | |
| *** shaohe_feng has quit IRC | 05:58 | |
| *** unicell has quit IRC | 05:58 | |
| *** shaohe_feng has joined #openstack-nova | 05:58 | |
| *** oanson has joined #openstack-nova | 06:00 | |
| *** moshele has quit IRC | 06:01 | |
| *** moshele has joined #openstack-nova | 06:01 | |
| *** tiendc||afk has joined #openstack-nova | 06:02 | |
| *** rama_y has joined #openstack-nova | 06:03 | |
| *** ecelik has joined #openstack-nova | 06:03 | |
| *** tiendc||afk has quit IRC | 06:03 | |
| *** tiendc|afk has quit IRC | 06:04 | |
| *** tiendc||afk has joined #openstack-nova | 06:04 | |
| *** TravT has joined #openstack-nova | 06:05 | |
| *** rama_y has quit IRC | 06:06 | |
| *** rama_y has joined #openstack-nova | 06:06 | |
| *** shaohe_feng has quit IRC | 06:08 | |
| *** gongysh has joined #openstack-nova | 06:09 | |
| *** pcaruana has joined #openstack-nova | 06:10 | |
| *** shaohe_feng has joined #openstack-nova | 06:11 | |
| *** code-R_ has quit IRC | 06:11 | |
| *** rama_y has quit IRC | 06:11 | |
| *** rama_y has joined #openstack-nova | 06:11 | |
| *** code-R has joined #openstack-nova | 06:12 | |
| *** gongysh has quit IRC | 06:13 | |
| *** shaohe_feng has quit IRC | 06:18 | |
| *** TravT has quit IRC | 06:18 | |
| *** shaohe_feng has joined #openstack-nova | 06:19 | |
| *** jaosorior has joined #openstack-nova | 06:20 | |
| *** ducttape_ has joined #openstack-nova | 06:20 | |
| *** yalli_ has joined #openstack-nova | 06:21 | |
| *** TravT has joined #openstack-nova | 06:23 | |
| *** ducttape_ has quit IRC | 06:25 | |
| *** shaohe_feng has quit IRC | 06:28 | |
| *** mfisch has quit IRC | 06:29 | |
| *** shaohe_feng has joined #openstack-nova | 06:30 | |
| *** belmoreira has joined #openstack-nova | 06:30 | |
| *** yalei has joined #openstack-nova | 06:30 | |
| yalei | ping alex_xu | 06:31 |
| *** TravT has quit IRC | 06:32 | |
| *** tiendc||afk has left #openstack-nova | 06:33 | |
| *** tiendc||afk has quit IRC | 06:33 | |
| *** mfisch has joined #openstack-nova | 06:34 | |
| *** mfisch has quit IRC | 06:34 | |
| *** mfisch has joined #openstack-nova | 06:34 | |
| *** unicell has joined #openstack-nova | 06:35 | |
| *** chandankumar has quit IRC | 06:35 | |
| *** gongysh has joined #openstack-nova | 06:35 | |
| *** TravT has joined #openstack-nova | 06:37 | |
| *** Sukhdev has quit IRC | 06:38 | |
| *** shaohe_feng has quit IRC | 06:39 | |
| *** shaohe_feng has joined #openstack-nova | 06:39 | |
| *** unicell1 has joined #openstack-nova | 06:39 | |
| *** unicell has quit IRC | 06:39 | |
| *** yalli_ has quit IRC | 06:42 | |
| openstackgerrit | Manish proposed openstack/nova: VM with Encrypted Vol throws error on hard reboot https://review.openstack.org/337075 | 06:44 |
| *** jlanoux has joined #openstack-nova | 06:45 | |
| *** jed56 has joined #openstack-nova | 06:47 | |
| *** shaohe_feng has quit IRC | 06:49 | |
| *** shaohe_feng has joined #openstack-nova | 06:50 | |
| *** TravT has quit IRC | 06:50 | |
| *** armax has quit IRC | 06:51 | |
| *** thorst has joined #openstack-nova | 06:51 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Return instance of Guest from method write_instance_config https://review.openstack.org/265146 | 06:51 |
| *** bhagya has joined #openstack-nova | 06:52 | |
| *** rama_y has quit IRC | 06:52 | |
| *** tesseract- has joined #openstack-nova | 06:53 | |
| *** ekuris_ has quit IRC | 06:54 | |
| *** permalac has quit IRC | 06:54 | |
| *** hoangcx has quit IRC | 06:54 | |
| *** Dinesh_Bhor has quit IRC | 06:55 | |
| *** Dinesh_Bhor has joined #openstack-nova | 06:55 | |
| *** bhagyashris has quit IRC | 06:55 | |
| *** hoangcx has joined #openstack-nova | 06:56 | |
| *** thorst has quit IRC | 06:57 | |
| *** lpetrut has quit IRC | 06:59 | |
| *** shaohe_feng has quit IRC | 06:59 | |
| *** shaohe_feng has joined #openstack-nova | 07:00 | |
| openstackgerrit | Dinesh Bhor proposed openstack/nova: Fix evaluation of host disk usage by volume-backed instances https://review.openstack.org/200870 | 07:02 |
| *** ihrachys has joined #openstack-nova | 07:02 | |
| *** code-R has quit IRC | 07:05 | |
| *** code-R has joined #openstack-nova | 07:05 | |
| *** ekuris_ has joined #openstack-nova | 07:09 | |
| *** shaohe_feng has quit IRC | 07:09 | |
| *** shaohe_feng has joined #openstack-nova | 07:10 | |
| *** abalutoiu has joined #openstack-nova | 07:11 | |
| *** lpetrut has joined #openstack-nova | 07:11 | |
| *** chandankumar has joined #openstack-nova | 07:11 | |
| *** liverpooler has joined #openstack-nova | 07:11 | |
| openstackgerrit | Tomi Juvonen proposed openstack/nova-specs: Maintenance reason to server https://review.openstack.org/310510 | 07:13 |
| *** code-R_ has joined #openstack-nova | 07:17 | |
| *** yamahata has joined #openstack-nova | 07:18 | |
| *** shaohe_feng has quit IRC | 07:20 | |
| *** code-R has quit IRC | 07:20 | |
| *** shaohe_feng has joined #openstack-nova | 07:21 | |
| *** ducttape_ has joined #openstack-nova | 07:21 | |
| *** Dinesh_Bhor has quit IRC | 07:22 | |
| *** bhagyashris has joined #openstack-nova | 07:24 | |
| *** bhagya has quit IRC | 07:24 | |
| *** ducttape_ has quit IRC | 07:25 | |
| *** ljxiash has quit IRC | 07:27 | |
| *** ljxiash has joined #openstack-nova | 07:28 | |
| *** gongysh has quit IRC | 07:28 | |
| *** shaohe_feng has quit IRC | 07:30 | |
| *** shaohe_feng has joined #openstack-nova | 07:30 | |
| *** IvoSmits has quit IRC | 07:31 | |
| *** lpetrut has quit IRC | 07:31 | |
| *** dimtruck is now known as zz_dimtruck | 07:32 | |
| *** gongysh has joined #openstack-nova | 07:33 | |
| *** openstackgerrit has quit IRC | 07:33 | |
| *** openstackgerrit has joined #openstack-nova | 07:33 | |
| *** lpetrut has joined #openstack-nova | 07:40 | |
| *** ihrachys has quit IRC | 07:40 | |
| *** shaohe_feng has quit IRC | 07:40 | |
| *** shaohe_feng has joined #openstack-nova | 07:41 | |
| *** sridharg has joined #openstack-nova | 07:44 | |
| *** ekuris_ has quit IRC | 07:44 | |
| *** vishwanathj has quit IRC | 07:44 | |
| *** shihanzhang has joined #openstack-nova | 07:46 | |
| *** RuiChen has joined #openstack-nova | 07:46 | |
| *** danpb has joined #openstack-nova | 07:47 | |
| *** ihrachys has joined #openstack-nova | 07:48 | |
| *** shaohe_feng has quit IRC | 07:50 | |
| *** shaohe_feng has joined #openstack-nova | 07:51 | |
| *** mvk has quit IRC | 07:53 | |
| *** thorst has joined #openstack-nova | 07:54 | |
| *** lpetrut has quit IRC | 07:56 | |
| *** code-R_ has quit IRC | 07:56 | |
| *** ekuris_ has joined #openstack-nova | 07:57 | |
| *** ihrachys has quit IRC | 07:57 | |
| *** markvoelker has joined #openstack-nova | 07:58 | |
| *** ihrachys has joined #openstack-nova | 07:59 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** TravT has joined #openstack-nova | 08:00 | |
| *** shaohe_feng has quit IRC | 08:01 | |
| *** zzzeek has joined #openstack-nova | 08:01 | |
| *** hoangcx has quit IRC | 08:01 | |
| *** shaohe_feng has joined #openstack-nova | 08:02 | |
| *** thorst has quit IRC | 08:02 | |
| *** edand has quit IRC | 08:02 | |
| *** markvoelker has quit IRC | 08:03 | |
| *** hoangcx has joined #openstack-nova | 08:04 | |
| *** ihrachys has quit IRC | 08:06 | |
| *** markus_z has joined #openstack-nova | 08:09 | |
| *** TravT has quit IRC | 08:09 | |
| openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova-specs: WIP: Propose to support preemptible instances https://review.openstack.org/104883 | 08:09 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c https://review.openstack.org/303345 | 08:10 |
| *** ihrachys has joined #openstack-nova | 08:10 | |
| *** shaohe_feng has quit IRC | 08:11 | |
| *** ljxiash has quit IRC | 08:12 | |
| *** jaosorior has quit IRC | 08:13 | |
| *** jaosorior has joined #openstack-nova | 08:13 | |
| *** shaohe_feng has joined #openstack-nova | 08:14 | |
| *** TravT has joined #openstack-nova | 08:14 | |
| openstackgerrit | Daniel Berrange proposed openstack/nova: network: introduce helper APIs for dealing with os-vif objects https://review.openstack.org/269672 | 08:18 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: convert over to use os-vif for Linux Bridge & OVS https://review.openstack.org/350595 | 08:18 |
| *** yassine has joined #openstack-nova | 08:20 | |
| *** yassine is now known as Guest26251 | 08:20 | |
| *** shaohe_feng has quit IRC | 08:21 | |
| *** Guest26251 is now known as yassou | 08:21 | |
| *** yamahata has quit IRC | 08:22 | |
| *** shaohe_feng has joined #openstack-nova | 08:22 | |
| *** lucas-dinner is now known as lucasagomes | 08:24 | |
| *** Dinesh_Bhor has joined #openstack-nova | 08:29 | |
| openstackgerrit | Yingxin Cheng proposed openstack/nova-specs: Request Standardized Capabilities In Nova https://review.openstack.org/351063 | 08:29 |
| *** hwoarang has quit IRC | 08:30 | |
| *** annp has joined #openstack-nova | 08:31 | |
| *** shaohe_feng has quit IRC | 08:32 | |
| *** shaohe_feng has joined #openstack-nova | 08:32 | |
| *** annp has quit IRC | 08:36 | |
| *** TravT has quit IRC | 08:38 | |
| *** sameo has joined #openstack-nova | 08:38 | |
| *** moshele has quit IRC | 08:41 | |
| *** shaohe_feng has quit IRC | 08:42 | |
| *** shaohe_feng has joined #openstack-nova | 08:42 | |
| *** hwoarang has joined #openstack-nova | 08:43 | |
| *** moshele has joined #openstack-nova | 08:45 | |
| *** TravT has joined #openstack-nova | 08:46 | |
| openstackgerrit | Yingxin Cheng proposed openstack/nova-specs: Request Standardized Capabilities In Nova https://review.openstack.org/351063 | 08:49 |
| *** zz_dimtruck is now known as dimtruck | 08:52 | |
| *** shaohe_feng has quit IRC | 08:52 | |
| *** ljxiash has joined #openstack-nova | 08:52 | |
| *** markvoelker has joined #openstack-nova | 08:53 | |
| *** shaohe_feng has joined #openstack-nova | 08:53 | |
| openstackgerrit | Alexis Lee proposed openstack/nova: Group scheduler options https://review.openstack.org/349959 | 08:53 |
| *** gb21 has joined #openstack-nova | 08:55 | |
| *** markvoelker has quit IRC | 08:57 | |
| *** edand has joined #openstack-nova | 08:59 | |
| *** edand has joined #openstack-nova | 08:59 | |
| *** thorst has joined #openstack-nova | 09:00 | |
| *** TravT has quit IRC | 09:00 | |
| openstackgerrit | Krzysztof Świątek proposed openstack/nova: Fix issue with not removing rbd rescue disk https://review.openstack.org/314928 | 09:01 |
| openstackgerrit | Krzysztof Świątek proposed openstack/nova: moved test_cleanup_volumes_reverting_resize from test_rbd to test_driver, modified test_cleanup_rbd https://review.openstack.org/351070 | 09:01 |
| *** dimtruck is now known as zz_dimtruck | 09:01 | |
| *** shaohe_feng has quit IRC | 09:02 | |
| *** shaohe_feng has joined #openstack-nova | 09:03 | |
| *** TravT has joined #openstack-nova | 09:05 | |
| *** thorst has quit IRC | 09:06 | |
| *** takashin has left #openstack-nova | 09:10 | |
| *** roeyc has joined #openstack-nova | 09:11 | |
| *** shaohe_feng has quit IRC | 09:13 | |
| *** shaohe_feng has joined #openstack-nova | 09:13 | |
| *** efoley has joined #openstack-nova | 09:14 | |
| *** hshiina has quit IRC | 09:14 | |
| *** dikonoor has joined #openstack-nova | 09:14 | |
| *** hshiina has joined #openstack-nova | 09:14 | |
| *** efoley_ has joined #openstack-nova | 09:16 | |
| *** TravT has quit IRC | 09:18 | |
| *** efoley has quit IRC | 09:19 | |
| openstackgerrit | NolwennCauchois proposed openstack/nova: Clean up second ephemeral disk https://review.openstack.org/341008 | 09:21 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Fix server operations' policies to admin only https://review.openstack.org/351077 | 09:22 |
| *** ducttape_ has joined #openstack-nova | 09:22 | |
| *** xek_ has joined #openstack-nova | 09:23 | |
| *** shaohe_feng has quit IRC | 09:23 | |
| *** TravT has joined #openstack-nova | 09:23 | |
| *** xek has quit IRC | 09:24 | |
| *** dulek has quit IRC | 09:25 | |
| *** lpetrut has joined #openstack-nova | 09:26 | |
| *** shaohe_feng has joined #openstack-nova | 09:26 | |
| *** dulek has joined #openstack-nova | 09:27 | |
| *** xenogear has quit IRC | 09:27 | |
| openstackgerrit | Alexis Lee proposed openstack/nova: Mutable compute options: reserves, ratios https://review.openstack.org/349561 | 09:27 |
| *** ducttape_ has quit IRC | 09:27 | |
| *** syjulian has quit IRC | 09:28 | |
| *** stewie925 has quit IRC | 09:28 | |
| *** jinli has quit IRC | 09:28 | |
| *** gb21 has quit IRC | 09:29 | |
| *** MikeG451 has quit IRC | 09:29 | |
| *** TravT has quit IRC | 09:32 | |
| *** shaohe_feng has quit IRC | 09:33 | |
| *** shaohe_feng has joined #openstack-nova | 09:34 | |
| *** hwoarang has quit IRC | 09:37 | |
| *** TravT has joined #openstack-nova | 09:37 | |
| *** xenogear has joined #openstack-nova | 09:43 | |
| *** shaohe_feng has quit IRC | 09:43 | |
| *** shaohe_feng has joined #openstack-nova | 09:44 | |
| *** MikeG451 has joined #openstack-nova | 09:44 | |
| *** gongysh has quit IRC | 09:44 | |
| *** mvk has joined #openstack-nova | 09:45 | |
| *** jinli has joined #openstack-nova | 09:45 | |
| *** stewie925 has joined #openstack-nova | 09:46 | |
| *** markvoelker has joined #openstack-nova | 09:47 | |
| openstackgerrit | Krzysztof Świątek proposed openstack/nova: moved test_cleanup_volumes_reverting_resize from test_rbd to test_driver, modified test_cleanup_rbd https://review.openstack.org/351070 | 09:48 |
| *** permalac has joined #openstack-nova | 09:49 | |
| *** hwoarang has joined #openstack-nova | 09:50 | |
| *** markvoelker has quit IRC | 09:52 | |
| *** shaohe_feng has quit IRC | 09:54 | |
| *** shaohe_feng has joined #openstack-nova | 09:54 | |
| *** TravT has quit IRC | 09:55 | |
| openstackgerrit | Timofey Durakov proposed openstack/python-novaclient: Added support for microversion 2.34 https://review.openstack.org/337084 | 09:55 |
| *** TravT has joined #openstack-nova | 10:00 | |
| *** roeyc has quit IRC | 10:01 | |
| *** syjulian has joined #openstack-nova | 10:02 | |
| *** shaohe_feng has quit IRC | 10:04 | |
| *** hoangcx has quit IRC | 10:04 | |
| *** shaohe_feng has joined #openstack-nova | 10:04 | |
| *** efoley__ has joined #openstack-nova | 10:05 | |
| *** efoley_ has quit IRC | 10:08 | |
| openstackgerrit | Alex Szarka proposed openstack/nova: Additional resume_guests_state enhancements https://review.openstack.org/343542 | 10:09 |
| openstackgerrit | Dinesh Bhor proposed openstack/nova: Replace functions 'Dict.get' and 'del' with 'Dict.pop' https://review.openstack.org/351099 | 10:09 |
| *** kolesovdv has joined #openstack-nova | 10:10 | |
| *** hwoarang has quit IRC | 10:10 | |
| *** hwoarang has joined #openstack-nova | 10:11 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for server lock action https://review.openstack.org/351100 | 10:11 |
| *** ihrachys has quit IRC | 10:11 | |
| gmann | alex_xu: johnthetubaguy sdague this is how user_id things looks like - https://review.openstack.org/351100 | 10:12 |
| gmann | alex_xu: johnthetubaguy sdague i will push rest of them if it looks fine | 10:12 |
| johnthetubaguy | gmann: I don't think we should pass the full instance | 10:13 |
| gmann | johnthetubaguy: only user_id? that is nice | 10:13 |
| johnthetubaguy | gmann: I think we can probably add some logic to the context.can helper to take an instance, and extract the tenant and user_id | 10:13 |
| gmann | johnthetubaguy: or we can do that in controller only while calling context.can() | 10:14 |
| *** shaohe_feng has quit IRC | 10:14 | |
| *** TravT has quit IRC | 10:14 | |
| *** shaohe_feng has joined #openstack-nova | 10:15 | |
| gmann | johnthetubaguy: i mean explicitly prepare the target{} and then pass to context.can | 10:15 |
| johnthetubaguy | gmann: I just don't like the idea of us cut and pasting that logic into every controller | 10:15 |
| johnthetubaguy | having said that, if we just pass the user_id, thats probably best | 10:16 |
| *** itoader has joined #openstack-nova | 10:17 | |
| *** palexster has joined #openstack-nova | 10:17 | |
| gmann | johnthetubaguy: pass the user_id from controller right | 10:17 |
| *** hieulq_ has quit IRC | 10:18 | |
| johnthetubaguy | gmann: for this particular change, thats probably best, I added a comment on the the change | 10:18 |
| *** TravT has joined #openstack-nova | 10:18 | |
| johnthetubaguy | gmann: I was thinking about longer term, really every policy check relating to an instance, we should pass in the instance, and extract the project_id, so folks can actually make sensible policies using the project_id | 10:19 |
| openstackgerrit | Tina Kevin proposed openstack/nova-specs: Add allocation ratio to hypervisor-show https://review.openstack.org/350348 | 10:19 |
| *** TravT has quit IRC | 10:22 | |
| *** ducttape_ has joined #openstack-nova | 10:23 | |
| gmann | johnthetubaguy: i see your point. | 10:24 |
| *** shaohe_feng has quit IRC | 10:24 | |
| *** shaohe_feng has joined #openstack-nova | 10:25 | |
| openstackgerrit | Alex Szarka proposed openstack/nova: Additional resume_guests_state enhancements https://review.openstack.org/343542 | 10:27 |
| openstackgerrit | Alex Szarka proposed openstack/nova: Recover instances when physical data is missing https://review.openstack.org/322341 | 10:27 |
| *** itoader has quit IRC | 10:27 | |
| *** ducttape_ has quit IRC | 10:28 | |
| gmann | johnthetubaguy: yea we can move that part in context.can but just wondering 'target' there is for same purpose. | 10:29 |
| openstackgerrit | Alex Szarka proposed openstack/nova: Recover instances when physical data is missing https://review.openstack.org/322341 | 10:29 |
| gmann | johnthetubaguy: i mean like instance_action passing instance as target | 10:29 |
| johnthetubaguy | gmann: target is what gets passed to the policy engine, the user can use any key in that to write their policy | 10:30 |
| johnthetubaguy | gmann: we don't want them using some obscure instance field in their policy check, we want the API to be interoperable as possible | 10:30 |
| *** thorst has joined #openstack-nova | 10:31 | |
| gmann | johnthetubaguy: yea. | 10:31 |
| *** amotoki has quit IRC | 10:31 | |
| gmann | johnthetubaguy: let me see how it looks like | 10:31 |
| *** gb21 has joined #openstack-nova | 10:32 | |
| *** ihrachys has joined #openstack-nova | 10:33 | |
| *** shaohe_feng has quit IRC | 10:35 | |
| *** shaohe_feng has joined #openstack-nova | 10:35 | |
| *** thorst has quit IRC | 10:36 | |
| gmann | johnthetubaguy: for passing project_id. currently how oslo policy get the one of instance (for owner checking case) ? | 10:39 |
| pkholkin | alaski: mriedem: hi folks! please look this patch with tests https://review.openstack.org/#/c/347462/ | 10:40 |
| gmann | johnthetubaguy: we pass context.project_id as default in target | 10:40 |
| *** gb21 is now known as GB21 | 10:41 | |
| *** markvoelker has joined #openstack-nova | 10:41 | |
| *** ljxiash has quit IRC | 10:41 | |
| *** shaohe_feng has quit IRC | 10:45 | |
| *** shaohe_feng has joined #openstack-nova | 10:45 | |
| *** markvoelker has quit IRC | 10:46 | |
| *** EinstCrazy has quit IRC | 10:46 | |
| gmann | johnthetubaguy: owner policy things working ? | 10:47 |
| johnthetubaguy | gmann: almost none of those owner policy checks actually mean anything right now, sadly | 10:47 |
| johnthetubaguy | gmann: there is a hardcoded check in the DB layer | 10:47 |
| johnthetubaguy | gmann: basically we just pass through what is in the context, so the check is always foo=foo or bar=bar :( | 10:48 |
| *** gongysh has joined #openstack-nova | 10:48 | |
| *** gcb has quit IRC | 10:49 | |
| gmann | johnthetubaguy: yea, we do in DB with nova.context.authorize_project_context | 10:49 |
| *** efoley__ has quit IRC | 10:49 | |
| gmann | johnthetubaguy: we should move those to context.can only by passing project_id as you said | 10:50 |
| *** kaisers has quit IRC | 10:50 | |
| *** TravT has joined #openstack-nova | 10:51 | |
| johnthetubaguy | gmann: honestly, am I am bit tempted to instead just leave those checks hardcoded, but I think sdague found a bug about the project_id not being passed | 10:51 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Allow authorization by user_id for server lock action https://review.openstack.org/351100 | 10:51 |
| *** kaisers has joined #openstack-nova | 10:51 | |
| johnthetubaguy | gmann: anyways, I think the first thing is to do the user_id | 10:51 |
| gmann | johnthetubaguy: yea. | 10:51 |
| gmann | johnthetubaguy: check if its fine | 10:51 |
| johnthetubaguy | gmann: I think should come back and think about the project_id next | 10:51 |
| *** kaisers has quit IRC | 10:51 | |
| gmann | johnthetubaguy: true | 10:51 |
| *** smatzek has joined #openstack-nova | 10:54 | |
| *** roeyc has joined #openstack-nova | 10:54 | |
| *** shaohe_feng has quit IRC | 10:55 | |
| openstackgerrit | Krzysztof Świątek proposed openstack/nova: Fix issue with not removing rbd rescue disk https://review.openstack.org/314928 | 10:55 |
| *** TravT has quit IRC | 10:55 | |
| *** shaohe_feng has joined #openstack-nova | 10:56 | |
| *** kaisers has joined #openstack-nova | 10:57 | |
| *** gszasz has joined #openstack-nova | 10:58 | |
| *** chenfan has quit IRC | 10:58 | |
| johnthetubaguy | gmann: this is where it was added: https://review.openstack.org/#/c/3829/ | 10:59 |
| *** TravT has joined #openstack-nova | 11:00 | |
| gmann | johnthetubaguy: oh, 4.5 year back | 11:00 |
| *** gcb has joined #openstack-nova | 11:01 | |
| *** GB21 has quit IRC | 11:01 | |
| gmann | johnthetubaguy: i see, it was needed for policy enforcement of admin_owner and then we just added context.project_id | 11:02 |
| *** GB21 has joined #openstack-nova | 11:02 | |
| *** ihrachys has quit IRC | 11:02 | |
| *** thorst has joined #openstack-nova | 11:03 | |
| *** roeyc has quit IRC | 11:04 | |
| johnthetubaguy | gmann: yeah, IMHO it was the wrong fix | 11:04 |
| johnthetubaguy | gmann: the default rule was incorrect | 11:05 |
| openstackgerrit | Alex Szarka proposed openstack/nova: Additional resume_guests_state enhancements https://review.openstack.org/343542 | 11:05 |
| openstackgerrit | Alex Szarka proposed openstack/nova: Additional resume_guests_state enhancements https://review.openstack.org/343542 | 11:05 |
| *** shaohe_feng has quit IRC | 11:05 | |
| gmann | johnthetubaguy: hummm, and did we had DB hardcoded checks that time? or we fixed those later :) | 11:06 |
| *** shaohe_feng has joined #openstack-nova | 11:06 | |
| *** ihrachys has joined #openstack-nova | 11:06 | |
| *** roeyc has joined #openstack-nova | 11:06 | |
| gmann | johnthetubaguy: just wondering if any one were doing project level isolation and broke | 11:07 |
| johnthetubaguy | gmann: I suspect we had the hard coded checks ages ago, if you are not admin context, it always adding tenant_id into the model query, I think. | 11:08 |
| openstackgerrit | Alex Szarka proposed openstack/nova: Additional resume_guests_state enhancements https://review.openstack.org/343542 | 11:08 |
| gmann | johnthetubaguy: humm, i think after user_id we can do project_id one too. should not take much time but not sure how much test coverage we have for those to make avoid any regression | 11:09 |
| *** jlanoux has quit IRC | 11:09 | |
| gmann | johnthetubaguy: or we start in O and not to be in hurry in Newton | 11:10 |
| openstackgerrit | Alex Szarka proposed openstack/nova: resume_guests_state tests enhancements https://review.openstack.org/347256 | 11:11 |
| *** TravT has quit IRC | 11:13 | |
| *** mat128|afk is now known as mat128 | 11:13 | |
| *** shaohe_feng has quit IRC | 11:16 | |
| johnthetubaguy | gmann: we might want to wait for project_id, just because I think we should also make the default target {}, and I am not sure how good our coverage is around that stuff | 11:16 |
| *** shaohe_feng has joined #openstack-nova | 11:17 | |
| johnthetubaguy | gmann: having said that, trying out a POC to see what tests breaks might not be a terrible thing | 11:17 |
| gmann | johnthetubaguy: yea. | 11:17 |
| *** amotoki has joined #openstack-nova | 11:17 | |
| *** kolesovdv has quit IRC | 11:18 | |
| *** TravT has joined #openstack-nova | 11:18 | |
| gmann | johnthetubaguy: and thats why deleting other tenant server return 404, should be unauthorized | 11:18 |
| gmann | https://github.com/openstack/tempest/blob/master/tempest/api/compute/servers/test_servers_negative.py#L528 | 11:19 |
| johnthetubaguy | gmann: so there are information leakage issues to worry about there, if you can't see it 404 is more typical, so you can't tell if its a typo or not | 11:19 |
| johnthetubaguy | gmann: 404 if you can't "see" the URL, unauthorised if you can't do the action on something you can see, feels best | 11:19 |
| *** zerda2 has quit IRC | 11:20 | |
| *** sdague has joined #openstack-nova | 11:21 | |
| *** lucasagomes is now known as lucas-hungry | 11:21 | |
| gmann | johnthetubaguy: then asking to get other tenant servers also 404 | 11:22 |
| gmann | johnthetubaguy: and after project_id those will be unauthorised | 11:22 |
| johnthetubaguy | gmann: yep, 404 is correct if you don't have "access" to the URL, I think | 11:22 |
| gmann | johnthetubaguy: ah got it. its from project_id in url. | 11:23 |
| *** itoader has joined #openstack-nova | 11:24 | |
| johnthetubaguy | gmann: well, even without that | 11:24 |
| *** ducttape_ has joined #openstack-nova | 11:24 | |
| johnthetubaguy | gmann: you don't want someone to be able to find out information by getting non-404 responses from other URLs, its a bad security posture | 11:25 |
| *** fabianw has joined #openstack-nova | 11:26 | |
| *** shaohe_feng has quit IRC | 11:26 | |
| *** shaohe_feng has joined #openstack-nova | 11:27 | |
| gmann | johnthetubaguy: yea, id is there in URL. yea make sense about 404 | 11:28 |
| *** bvanhav has joined #openstack-nova | 11:28 | |
| *** ducttape_ has quit IRC | 11:29 | |
| gmann | johnthetubaguy: Thanks, learned a good thing :) | 11:29 |
| *** itoader has quit IRC | 11:31 | |
| *** TravT has quit IRC | 11:32 | |
| *** markvoelker has joined #openstack-nova | 11:35 | |
| *** jlanoux has joined #openstack-nova | 11:35 | |
| *** shaohe_feng has quit IRC | 11:36 | |
| *** TravT has joined #openstack-nova | 11:36 | |
| *** fabianw has quit IRC | 11:36 | |
| *** shaohe_feng has joined #openstack-nova | 11:37 | |
| openstackgerrit | Rui Chen proposed openstack/python-novaclient: Fix Resource.__eq__ mismatch semantics of object equal https://review.openstack.org/251020 | 11:38 |
| *** markvoelker has quit IRC | 11:39 | |
| *** xek__ has joined #openstack-nova | 11:41 | |
| *** xek_ has quit IRC | 11:42 | |
| *** efoley__ has joined #openstack-nova | 11:43 | |
| *** jaypipes has joined #openstack-nova | 11:43 | |
| *** dulek has quit IRC | 11:43 | |
| *** kolesovdv has joined #openstack-nova | 11:43 | |
| maestropandy | using python how to list security_group_list, I have tried "nova.security_groups_rules.list(secgroup.id)" but no luck | 11:43 |
| maestropandy | sorry how to list security group rules | 11:44 |
| *** dulek has joined #openstack-nova | 11:45 | |
| *** TravT has quit IRC | 11:45 | |
| *** shaohe_feng has quit IRC | 11:46 | |
| *** shaohe_feng has joined #openstack-nova | 11:47 | |
| *** yalei has quit IRC | 11:49 | |
| *** amotoki has quit IRC | 11:50 | |
| *** TravT has joined #openstack-nova | 11:50 | |
| *** dave-mccowan has joined #openstack-nova | 11:55 | |
| *** shaohe_feng has quit IRC | 11:57 | |
| *** shaohe_feng has joined #openstack-nova | 11:57 | |
| *** hieulq_ has joined #openstack-nova | 11:57 | |
| *** phuongnh has quit IRC | 11:58 | |
| *** lucas-hungry is now known as lucasagomes | 11:58 | |
| openstackgerrit | Timofey Durakov proposed openstack/nova: Remove backward compatibility with pre-grizzly releases https://review.openstack.org/348284 | 11:59 |
| *** palexster has quit IRC | 12:00 | |
| *** clenimar_ has joined #openstack-nova | 12:02 | |
| *** eharney has quit IRC | 12:02 | |
| *** TravT has quit IRC | 12:03 | |
| *** markvoelker has joined #openstack-nova | 12:05 | |
| *** clenimar_ has quit IRC | 12:07 | |
| *** shaohe_feng has quit IRC | 12:07 | |
| *** shaohe_feng has joined #openstack-nova | 12:07 | |
| *** zul has quit IRC | 12:07 | |
| *** rtheis has joined #openstack-nova | 12:09 | |
| *** hieulq_ has quit IRC | 12:09 | |
| *** ducttape_ has joined #openstack-nova | 12:12 | |
| *** diogogmt has joined #openstack-nova | 12:15 | |
| *** tblakes has joined #openstack-nova | 12:16 | |
| *** tblakes has quit IRC | 12:17 | |
| *** shaohe_feng has quit IRC | 12:17 | |
| *** shaohe_feng has joined #openstack-nova | 12:18 | |
| *** baoli has joined #openstack-nova | 12:20 | |
| *** zul has joined #openstack-nova | 12:20 | |
| openstackgerrit | Fang He proposed openstack/nova: use the HostPortGroupSpec.vswitchName instead of HostPortGroup.vswitch.split https://review.openstack.org/350852 | 12:22 |
| *** diogogmt has quit IRC | 12:24 | |
| *** eharney has joined #openstack-nova | 12:25 | |
| *** rfolco has joined #openstack-nova | 12:25 | |
| *** diogogmt has joined #openstack-nova | 12:25 | |
| *** baoli_ has joined #openstack-nova | 12:25 | |
| *** shaohe_feng has quit IRC | 12:27 | |
| *** xyang1 has joined #openstack-nova | 12:27 | |
| Dinesh_Bhor | Hi all, Can someone please take a look at it ? https://review.openstack.org/#/c/351099/ | 12:28 |
| *** baoli has quit IRC | 12:29 | |
| *** shaohe_feng has joined #openstack-nova | 12:30 | |
| *** GB21 has quit IRC | 12:30 | |
| *** ducttape_ has quit IRC | 12:31 | |
| *** TravT has joined #openstack-nova | 12:31 | |
| *** hshiina has quit IRC | 12:33 | |
| *** diogogmt has quit IRC | 12:35 | |
| openstackgerrit | Timofey Durakov proposed openstack/nova: Remove backward compatibility with pre-grizzly releases https://review.openstack.org/348284 | 12:37 |
| *** shaohe_feng has quit IRC | 12:38 | |
| *** shaohe_feng has joined #openstack-nova | 12:38 | |
| *** tblakes has joined #openstack-nova | 12:39 | |
| openstackgerrit | Pavel Kholkin proposed openstack/python-novaclient: Microversion 2.35 adds keypairs pagination support https://review.openstack.org/343648 | 12:40 |
| *** amotoki has joined #openstack-nova | 12:43 | |
| *** burgerk has joined #openstack-nova | 12:48 | |
| *** shaohe_feng has quit IRC | 12:48 | |
| *** shaohe_feng has joined #openstack-nova | 12:49 | |
| *** TravT has quit IRC | 12:49 | |
| *** tblakes has quit IRC | 12:51 | |
| openstackgerrit | Pavel Kholkin proposed openstack/python-novaclient: remove start_version arg for keypairs v2.10 shell https://review.openstack.org/351156 | 12:53 |
| *** zz_dimtruck is now known as dimtruck | 12:53 | |
| *** TravT has joined #openstack-nova | 12:54 | |
| *** gcb has quit IRC | 12:56 | |
| *** gongysh has quit IRC | 12:56 | |
| *** tblakes has joined #openstack-nova | 12:57 | |
| *** shaohe_feng has quit IRC | 12:58 | |
| *** tangchen has quit IRC | 12:59 | |
| *** shaohe_feng has joined #openstack-nova | 13:01 | |
| *** efoley_ has joined #openstack-nova | 13:02 | |
| *** efoley__ has quit IRC | 13:02 | |
| *** bhagya has joined #openstack-nova | 13:02 | |
| *** dimtruck is now known as zz_dimtruck | 13:03 | |
| *** TravT has quit IRC | 13:03 | |
| *** pradk has quit IRC | 13:04 | |
| *** kolesovdv has quit IRC | 13:06 | |
| *** bhagyashris has quit IRC | 13:06 | |
| *** Dinesh_Bhor has quit IRC | 13:06 | |
| *** zul has quit IRC | 13:07 | |
| *** TravT has joined #openstack-nova | 13:08 | |
| *** shaohe_feng has quit IRC | 13:08 | |
| *** bhagyashris has joined #openstack-nova | 13:08 | |
| *** shaohe_feng has joined #openstack-nova | 13:09 | |
| *** mdrabe has joined #openstack-nova | 13:09 | |
| *** rlrossit has joined #openstack-nova | 13:11 | |
| *** sdake has joined #openstack-nova | 13:11 | |
| openstackgerrit | Alex Szarka proposed openstack/nova: [WIP] Reduce code complexity to 25 https://review.openstack.org/351176 | 13:12 |
| *** bhagya has quit IRC | 13:12 | |
| *** markvoelker has quit IRC | 13:13 | |
| *** liverpooler has quit IRC | 13:14 | |
| jroll | any cores mind kicking a second +W on this one? zuul didn't pick it up when the deps merged https://review.openstack.org/#/c/297895/ | 13:14 |
| *** jamesdenton has joined #openstack-nova | 13:14 | |
| *** TravT has quit IRC | 13:17 | |
| *** ihrachys has quit IRC | 13:18 | |
| alaski | jroll: got it | 13:18 |
| *** shaohe_feng has quit IRC | 13:19 | |
| jroll | thanks alaski | 13:19 |
| *** cleong has joined #openstack-nova | 13:19 | |
| *** shaohe_feng has joined #openstack-nova | 13:19 | |
| alaski | sdague: we may have to agree to disagree on this thread but I needed to get my thoughts out in the open | 13:19 |
| alaski | and I do agree that too many signals could create confusion which is not good for anyone | 13:21 |
| *** zul has joined #openstack-nova | 13:22 | |
| *** ljxiash has joined #openstack-nova | 13:22 | |
| *** sdake has quit IRC | 13:24 | |
| *** Dinesh_Bhor has joined #openstack-nova | 13:24 | |
| *** karthiks has quit IRC | 13:25 | |
| *** shaohe_feng has quit IRC | 13:29 | |
| *** shaohe_feng has joined #openstack-nova | 13:29 | |
| *** matrohon has joined #openstack-nova | 13:30 | |
| alex_xu | gmann: why not just put the instance as target, just like target=instance | 13:31 |
| *** ducttape_ has joined #openstack-nova | 13:31 | |
| alex_xu | gmann: looks like you and johnthetubaguy talk about similar thing, i will read the log | 13:31 |
| *** chandankumar has quit IRC | 13:32 | |
| *** chandankumar has joined #openstack-nova | 13:33 | |
| *** Jeffrey4l_ has quit IRC | 13:34 | |
| *** ratailor has quit IRC | 13:35 | |
| *** hieulq_ has joined #openstack-nova | 13:35 | |
| johnthetubaguy | alex_xu: basically I said don't do that | 13:36 |
| *** ducttape_ has quit IRC | 13:36 | |
| johnthetubaguy | alex_xu: it lets folks use any property of the instance in the policy, which feels way too broad | 13:36 |
| johnthetubaguy | alex_xu: thats wearing my "I want better interop" hat. | 13:37 |
| alex_xu | johnthetubaguy: I'm reading the log, +1 to that, and thinking of we can do extract thing in context.can, looks like you and gmann talk about that also, but I didn't fininsh the log yet | 13:38 |
| *** karthiks has joined #openstack-nova | 13:39 | |
| *** shaohe_feng has quit IRC | 13:39 | |
| alex_xu | johnthetubaguy: ok, you already comment that | 13:39 |
| *** shaohe_feng has joined #openstack-nova | 13:39 | |
| *** mriedem has joined #openstack-nova | 13:39 | |
| alex_xu | johnthetubaguy: +1 for all your comment | 13:40 |
| johnthetubaguy | alex_xu: cool, I think in the end I think we can do the simple thing for user, and worry about the rest when we come back an look at project_id being part of the target | 13:40 |
| *** hieulq_ has quit IRC | 13:41 | |
| *** burgerk has quit IRC | 13:41 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova: libvirt: Ensure the instance resize directory is removed https://review.openstack.org/329030 | 13:42 |
| *** nkrinner is now known as nkrinner_afk | 13:43 | |
| johnthetubaguy | alex_xu: alaski had a better idea for the future, a helper method, but I think keeping the current scope to use user_id for now, make sense to me | 13:43 |
| mnaser | I | 13:43 |
| mnaser | oops. | 13:43 |
| alex_xu | johnthetubaguy: yea, learned that one more point also. I just didn't we didn't use project_id for now? | 13:44 |
| mnaser | I'm trying to go through the service "alive" checks codebase to see why 2 nodes are mysteriously marked as down.. the time is sync'd and the nova-compute process is running (doing usual qemu-img loops to check, logs are still working, no errors) | 13:44 |
| alaski | johnthetubaguy: alex_xu yeah, I wouldn't expect it to be done that way in this patch. Just a suggestion for another time | 13:44 |
| mnaser | if process is up and time is sync'd, i cant imagine why it's marked as down | 13:45 |
| sdague | alaski: yeh, sure, I'll admit though at this point in the cycle my bw for digging through implications is pretty low | 13:45 |
| alex_xu | johnthetubaguy: i mean i didn't get why we didn't use project_id for now... | 13:45 |
| *** mgoddard_ has joined #openstack-nova | 13:45 | |
| *** ametts has joined #openstack-nova | 13:45 | |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: WIP: live-migration test for serial console https://review.openstack.org/347471 | 13:45 |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: libvirt: Acquire TCP ports for console during live migration https://review.openstack.org/275801 | 13:45 |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: libvirt: fix live-migration with serial console check https://review.openstack.org/335132 | 13:45 |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: Add functional regression test for bug 1595962 https://review.openstack.org/338416 | 13:45 |
| openstack | bug 1595962 in OpenStack Compute (nova) "live migration with disabled vnc/spice not possible" [Undecided,In progress] https://launchpad.net/bugs/1595962 - Assigned to Markus Zoeller (markus_z) (mzoeller) | 13:45 |
| alex_xu | johnthetubaguy: due to we currently hardcode the project_id filter in the db? | 13:46 |
| *** jraju has quit IRC | 13:46 | |
| alaski | sdague: okay. I'm happy to discuss again in Ocata | 13:46 |
| johnthetubaguy | alex_xu: yeah | 13:47 |
| alex_xu | johnthetubaguy: ah, i got all the points now | 13:47 |
| *** ecelik has quit IRC | 13:47 | |
| alaski | johnthetubaguy: we do want to duplicate those db checks in the policy checks because it will affect the later capability exposure | 13:48 |
| johnthetubaguy | alex_xu: I keep wondering if every instance action should have the instance.project_id as a target, and we should consider that separately I think | 13:48 |
| *** mgoddard has quit IRC | 13:48 | |
| alex_xu | johnthetubaguy: yea | 13:48 |
| *** matrohon has quit IRC | 13:48 | |
| johnthetubaguy | alaski: hmm, thats a good point, its simpler if there is a single policy check that actually means "can I do X", it would be good to get there I guess. | 13:49 |
| *** shaohe_feng has quit IRC | 13:49 | |
| johnthetubaguy | alex_xu: I just added a new comment on the new patch, there is a "slight" issue, its broken if we don't pass the project_id, due to how the default target works, oops... | 13:50 |
| alaski | johnthetubaguy: yeah. I'm sure there are other places missing that check so we can batch it up later. | 13:50 |
| *** shaohe_feng has joined #openstack-nova | 13:50 | |
| johnthetubaguy | alaski: almost everywhere is missing the project_id check right now, it got dropped in the v2 -> v2.1 transition, it turns out | 13:51 |
| alaski | nice | 13:51 |
| *** cdelatte has joined #openstack-nova | 13:51 | |
| johnthetubaguy | yeah, slight boo boo | 13:51 |
| *** markvoelker has joined #openstack-nova | 13:51 | |
| johnthetubaguy | I had almost had a panic attack a few months back, before I remember about the db level check | 13:52 |
| *** sdake has joined #openstack-nova | 13:54 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Handle race in allocate_for_instance https://review.openstack.org/221803 | 13:56 |
| *** hieulq_ has joined #openstack-nova | 13:58 | |
| *** mlavalle has joined #openstack-nova | 13:58 | |
| *** mgoddard_ has quit IRC | 13:58 | |
| *** mgoddard has joined #openstack-nova | 13:58 | |
| *** baoli_ has quit IRC | 13:59 | |
| *** shaohe_feng has quit IRC | 14:00 | |
| *** hieulq_ has quit IRC | 14:00 | |
| *** shaohe_feng has joined #openstack-nova | 14:00 | |
| *** maestropandy has left #openstack-nova | 14:01 | |
| *** belmoreira has quit IRC | 14:02 | |
| *** rlrossit has quit IRC | 14:02 | |
| *** edmondsw has quit IRC | 14:02 | |
| *** ZZelle has quit IRC | 14:03 | |
| *** matrohon has joined #openstack-nova | 14:05 | |
| *** rlrossi__ has joined #openstack-nova | 14:05 | |
| *** matrohon has quit IRC | 14:05 | |
| *** pradk has joined #openstack-nova | 14:06 | |
| *** zul has quit IRC | 14:07 | |
| *** zul has joined #openstack-nova | 14:07 | |
| *** code-R has joined #openstack-nova | 14:09 | |
| *** shaohe_feng has quit IRC | 14:10 | |
| *** efried has joined #openstack-nova | 14:10 | |
| *** shaohe_feng has joined #openstack-nova | 14:10 | |
| *** code-R_ has joined #openstack-nova | 14:11 | |
| *** coolsvap has quit IRC | 14:11 | |
| *** karthiks has quit IRC | 14:13 | |
| *** code-R has quit IRC | 14:14 | |
| *** hoangcx has joined #openstack-nova | 14:17 | |
| *** jaosorior has quit IRC | 14:17 | |
| *** moshele has quit IRC | 14:19 | |
| *** TravT has joined #openstack-nova | 14:19 | |
| *** shaohe_feng has quit IRC | 14:20 | |
| *** shaohe_feng has joined #openstack-nova | 14:21 | |
| *** matrohon has joined #openstack-nova | 14:21 | |
| *** amotoki has quit IRC | 14:22 | |
| *** hapci has joined #openstack-nova | 14:23 | |
| lbeliveau | jaypipes: we finally got result from jenkins, reminder to look at https://review.openstack.org/#/c/328983/ | 14:23 |
| *** EinstCrazy has joined #openstack-nova | 14:23 | |
| *** hapci has quit IRC | 14:24 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova: Ironic: allow multiple compute services https://review.openstack.org/348443 | 14:24 |
| jroll | JayF: ^ decided to add that given there wasn't any +2 yet anyway | 14:24 |
| *** zul has quit IRC | 14:25 | |
| *** zul has joined #openstack-nova | 14:25 | |
| mriedem | markus_z: i've got all of the goodies up to run your tempest port-security-enabled=false patch on newton and mitaka but not run on liberty | 14:25 |
| mriedem | now we play the waiting game with the qa team | 14:26 |
| * mriedem heads to a meeting | 14:26 | |
| *** gabor_antal_ has joined #openstack-nova | 14:26 | |
| *** roeyc has quit IRC | 14:27 | |
| *** efoley_ has quit IRC | 14:27 | |
| *** edand has quit IRC | 14:28 | |
| *** burgerk has joined #openstack-nova | 14:28 | |
| *** cm876n has joined #openstack-nova | 14:28 | |
| jaypipes | lbeliveau: done :) | 14:29 |
| *** chandankumar has quit IRC | 14:30 | |
| *** karthiks has joined #openstack-nova | 14:30 | |
| markus_z | mriedem: ok, I'm working on that patch tomorrow. | 14:30 |
| *** ekuris_ has quit IRC | 14:30 | |
| *** shaohe_feng has quit IRC | 14:30 | |
| *** devkulkarni1 has joined #openstack-nova | 14:30 | |
| lbeliveau | jaypipes: thank you sir ! | 14:31 |
| *** mtanino has joined #openstack-nova | 14:31 | |
| *** diogogmt has joined #openstack-nova | 14:31 | |
| *** shaohe_feng has joined #openstack-nova | 14:31 | |
| *** zz_dimtruck is now known as dimtruck | 14:31 | |
| *** cdent has joined #openstack-nova | 14:32 | |
| *** vishwanathj has joined #openstack-nova | 14:32 | |
| *** catintheroof has joined #openstack-nova | 14:32 | |
| *** matrohon has quit IRC | 14:32 | |
| *** tangchen has joined #openstack-nova | 14:32 | |
| cdent | jaypipes, dansmith: rpodolyaka and I have done https://review.openstack.org/#/c/349021/ as a way of having a placement_connection for a third db, as well as a specialized aggregates model if a placement connection is being used. Still a WIP but if either of you could look to say "sensible" or "CRAZY!" that would be handy. | 14:33 |
| *** mdrabe has quit IRC | 14:34 | |
| jroll | jaypipes: os-capabilities looks interesting | 14:34 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Create Instance from BuildRequest if not in a cell https://review.openstack.org/263927 | 14:35 |
| openstackgerrit | Andrew Laski proposed openstack/nova: instance.name should be blank if instance.id is not set https://review.openstack.org/327342 | 14:35 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Cells: Handle delete with BuildRequest https://review.openstack.org/325985 | 14:35 |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: libvirt: virtlogd: use virtlogd for char devices https://review.openstack.org/323765 | 14:36 |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: libvirt: simplify "get_console_output" interface https://review.openstack.org/334480 | 14:36 |
| jaypipes | there are just way too many pugs in my household. | 14:36 |
| cdent | jaypipes: you can probably hire them out to lonely locals | 14:36 |
| *** markus_z has quit IRC | 14:38 | |
| jaypipes | cdent: I don't think anybody would pay for these ones :) | 14:38 |
| jaypipes | too damn needy. | 14:38 |
| cdent | lonely people like needy things: they make you feel useful | 14:39 |
| jaypipes | jroll: cool, thanks for checking it out. does it meet your recollection of what we discussed about that in Portland? | 14:39 |
| *** mdrabe has joined #openstack-nova | 14:39 | |
| jaypipes | cdent: pugsforlonelylocals.com <-- next big thing. | 14:39 |
| jroll | jaypipes: I don't recall much discussion about a library, actually :/ | 14:39 |
| *** dikonoor has quit IRC | 14:40 | |
| cdent | jaypipes: probably worth at least 10Instagrams | 14:40 |
| jaypipes | cdent: agreed. | 14:40 |
| jaypipes | jroll: this is all Ocata territory anyways, just getting a jumpstart on it now. | 14:40 |
| lyarwood | tdurakov: thanks, I'll rebase on your change once it's through the gate and add an additional rm for the instance dir | 14:40 |
| *** shaohe_feng has quit IRC | 14:41 | |
| *** ducttape_ has joined #openstack-nova | 14:41 | |
| lyarwood | tdurakov: what was your point re mdbooth's suggestion btw? | 14:41 |
| *** code-R_ has quit IRC | 14:41 | |
| jroll | jaypipes: indeed. I do like the cross-project-ness of it | 14:41 |
| tdurakov | lyarwood: hi, mdbooth proposed to: | 14:42 |
| tdurakov | 1. Move creation of disk.info into create_image() for all 3 backends: Flat, Qcow2, and Ploop. | 14:42 |
| tdurakov | 2. Refactor resolve_driver_format() such that Flat can read disk.info during __init__ without creating it if it doesn't exist. | 14:42 |
| tdurakov | lyarwood: so I it's make sense for me | 14:42 |
| lyarwood | tdurakov: thats now obsolete with the other work he's doing with the persistent image metadata spec AFAIK, mdbooth, feel free to correct me if I'm wrong here btw. | 14:43 |
| *** shaohe_feng has joined #openstack-nova | 14:43 | |
| jaypipes | mdbooth: ok, will take another look through your unit test patch series. I recognize it's a mess of crap (I've been doing similar refactoring in the unit tests of the resource tracker myself so I feel your pain). My only concern was increasing the surface area for bugs by essentially implementing a faked-out image backend interface that could have its own set of bugs. But anyway, will have | 14:43 |
| jaypipes | another look at the remainder of the patches. | 14:44 |
| tdurakov | lyarwood: if it so I'd prefer to wait for these patches, I mean your proposal is still kind of hot-fix, right? | 14:44 |
| *** jwcroppe has joined #openstack-nova | 14:45 | |
| *** jwcroppe has quit IRC | 14:45 | |
| *** ducttape_ has quit IRC | 14:45 | |
| *** jwcroppe has joined #openstack-nova | 14:45 | |
| *** Jeffrey4l has joined #openstack-nova | 14:45 | |
| *** raj_singh_ has joined #openstack-nova | 14:45 | |
| lyarwood | tdurakov: yeah, just easier to backport etc and avoids having to rewrite imagebackend during the cycle while others are landing specs like mdbooth's | 14:45 |
| mdbooth | jaypipes: So, I've been thinking about this. | 14:45 |
| tdurakov | btw, hello everyone:) | 14:46 |
| mdbooth | jaypipes: My fundamental need is to have a way to test what happens to individual disks, which is what most of the existing tests are doing, only better and more reliably. | 14:47 |
| mdbooth | My portents of doom were really around losing the ability to do that. | 14:47 |
| mdbooth | However, there's no doom involved in achieving that in a less messy manner. | 14:47 |
| *** matrohon has joined #openstack-nova | 14:48 | |
| jaypipes | tdurakov: hello! | 14:49 |
| jaypipes | mdbooth: was that a question or a statement? :) | 14:50 |
| jaypipes | mdbooth: or a request to me? I'm not sure how to parse.. | 14:50 |
| mdbooth | jaypipes: Sorry, attempting to follow several thought trains simultaneously. Never a good idea. | 14:50 |
| jaypipes | :) no worries | 14:51 |
| dansmith | jaypipes: he has "nova unit test brain" | 14:51 |
| *** shaohe_feng has quit IRC | 14:51 | |
| jaypipes | I just need to know if you need me to review this again with a particular mindset.... | 14:51 |
| jaypipes | dansmith: a debilitating condition for sure. | 14:51 |
| *** shaohe_feng has joined #openstack-nova | 14:52 | |
| mdbooth | jaypipes: The useful output of that mock to me is the disks dict. So I can do: disks['disk.swap'].create_from_image.assert_called_once_with(foo, bar, baz) | 14:52 |
| mdbooth | If there's a better way to achieve the same result, though, I'd be more than happy to clean it up. | 14:53 |
| jaypipes | mdbooth: k, I'll re-review it in a bit keeping that objective in mind. | 14:53 |
| *** edmondsw has joined #openstack-nova | 14:54 | |
| mdbooth | jaypipes: But at the same time, remember it comes from the end of a 34 patch series :) It's a time traveller from the future! | 14:54 |
| jaypipes | mdbooth: understood. | 14:54 |
| mdbooth | So it solves problems which don't immediately require solutions. | 14:54 |
| mdbooth | jaypipes: Awesome, thanks. | 14:55 |
| mriedem | jaypipes: please guarantee diversity with the os-capabilities library or we can't use it | 14:55 |
| *** annegentle has joined #openstack-nova | 14:55 | |
| *** code-R has joined #openstack-nova | 14:55 | |
| mriedem | if you build it, they will contribute | 14:55 |
| dansmith | jaypipes: I'm typing things in that review as we speak, I'll poke you when it's time to refresh | 14:56 |
| jaypipes | dansmith: of mdbooth's patch? | 14:56 |
| dansmith | jaypipes: yeah | 14:56 |
| jaypipes | kk | 14:56 |
| *** beagles is now known as beagles_brb | 14:56 | |
| *** code-R_ has joined #openstack-nova | 14:57 | |
| mriedem | lyarwood: did you check out why this failed grenade? https://review.openstack.org/#/c/304746/ | 14:58 |
| jaypipes | jroll: multi-tenant networking merged. | 14:58 |
| lyarwood | mriedem: nope, looking now | 14:59 |
| jroll | jaypipes: \o/ where's openstackgerrit when I need it | 14:59 |
| mriedem | lyarwood: looks like cinder upgrade failed but i'm not sure why | 14:59 |
| *** code-R has quit IRC | 15:00 | |
| gabor_antal_ | Hey, can someone help how can I run checks.py outside the pep8 tox's target? | 15:00 |
| *** annegentle has quit IRC | 15:00 | |
| *** shaohe_feng has quit IRC | 15:01 | |
| lyarwood | mriedem: yup, I can't see anything obvious | 15:01 |
| *** shaohe_feng has joined #openstack-nova | 15:01 | |
| *** devkulkarni1 has quit IRC | 15:02 | |
| mriedem | lyarwood: i guess ansible failed http://logs.openstack.org/46/304746/1/check/gate-grenade-dsvm-ubuntu-trusty/2220480/_zuul_ansible/ansible_log.txt | 15:02 |
| *** devkulkarni1 has joined #openstack-nova | 15:02 | |
| JayF | jroll: you didn't really get the point of what I was posting, I don't think | 15:02 |
| mdbooth | lyarwood tdurakov: I was suggesting that the refactor I described probably wasn't worth the effort. | 15:02 |
| *** rrecio has joined #openstack-nova | 15:02 | |
| mriedem | IOError: [Errno 2] No such file or directory: '/usr/local/lib/python2.7/dist-packages/ansible/modules/core/utilities/logic/async_status.py' | 15:02 |
| mdbooth | When you can just move the delete block so that it gets deleted anyway | 15:03 |
| JayF | jroll: imagine you treat n-cpus like say, compute workers, and you spin more up for load. You can *never* have fewer n-cpus, ever | 15:03 |
| *** tangchen has quit IRC | 15:03 | |
| mdbooth | and there's already an approved spec to make the thing being refactored go away. | 15:03 |
| JayF | jroll: it's not just about identical hostnames (or conf.host), it's about always never being able to run fewer than the max you've ever run | 15:03 |
| mriedem | we should get the ansible_log.txt indexed in logstash for stuff like this if it's not already | 15:03 |
| JayF | jroll: does that make sense? that's what this came up in context of k8s with me and deva | 15:03 |
| jroll | JayF: I understand, but if you do spin one down, and realize that's a problem, you can spin a different one back up with the same hostname to deal with it | 15:04 |
| *** jaugustine has joined #openstack-nova | 15:04 | |
| jroll | JayF: feel free to suggest a better wording on the patch, I have to run for a bit | 15:04 |
| anush- | jaypipes - thanks for reviewing https://review.openstack.org/#/c/350379. Would you mind looking at the parent for this https://review.openstack.org/#/c/332492 | 15:05 |
| *** devkulkarni1 has quit IRC | 15:05 | |
| *** devkulkarni2 has joined #openstack-nova | 15:05 | |
| lyarwood | mdbooth: yup thanks | 15:06 |
| lyarwood | mriedem: is it worth creating a bug for this or should I just recheck again? | 15:06 |
| dansmith | jaypipes: done | 15:07 |
| *** oanson has quit IRC | 15:07 | |
| dansmith | jaypipes: when you're done with that, will you have time to circle back to jroll's multi compute patch? | 15:07 |
| *** akshai has joined #openstack-nova | 15:07 | |
| *** cdent has quit IRC | 15:08 | |
| mriedem | lyarwood: i already rechecked | 15:08 |
| lyarwood | mriedem: yup just saw that, thanks | 15:09 |
| *** rcernin has quit IRC | 15:09 | |
| mdbooth | dansmith: Thanks for that. Sounds like a plan. | 15:09 |
| openstackgerrit | Eric Fried proposed openstack/nova: PEP8: E121 (hanging under-indent) https://review.openstack.org/351240 | 15:11 |
| *** shaohe_feng has quit IRC | 15:11 | |
| *** shaohe_feng has joined #openstack-nova | 15:12 | |
| *** akshai has quit IRC | 15:12 | |
| *** moshele has joined #openstack-nova | 15:13 | |
| efried | mriedem, more OCD goodness for ya ^^ | 15:13 |
| mriedem | efried: you should have probably asked about doing that before doing it | 15:16 |
| mriedem | because i don't like that rule | 15:16 |
| dansmith | and it's been done several times | 15:16 |
| dansmith | and nak'd | 15:16 |
| mriedem | i personally hate that rule | 15:16 |
| efried | Boo. | 15:16 |
| *** ayoung has joined #openstack-nova | 15:17 | |
| efried | Well, it definitely improved *some* stuff. | 15:17 |
| efried | line n+1 not lining up with line n, kind of thing. | 15:17 |
| efried | What if I took out the tox.ini change (so posterity still need not comply) and just left the existing spacing fixes? | 15:18 |
| sdague | efried: you patch conflicts with 46 open patches | 15:19 |
| efried | yuh | 15:19 |
| sdague | during milestone 3, that's definitely not a thing we want | 15:19 |
| *** EinstCrazy has quit IRC | 15:19 | |
| *** baoli has joined #openstack-nova | 15:19 | |
| *** rama_y has joined #openstack-nova | 15:19 | |
| efried | Sigh. So this comment: | 15:20 |
| efried | # The rest of the ignores are TODOs | 15:20 |
| efried | ...should be augmented to include, "except for the following, which are stupid rules in the first place: [insert list here]" | 15:20 |
| efried | ...so future hapless developers don't wind up <sheepish> like me. | 15:20 |
| *** chandankumar has joined #openstack-nova | 15:20 | |
| openstackgerrit | Rafael Folco proposed openstack/nova: Improve NUMA packing to fit more instances https://review.openstack.org/346205 | 15:21 |
| sdague | efried: yeh, once upon a time we had a blanket exclude on the 12X rules with that listed | 15:21 |
| sdague | however, any time you are proposing a 500+ line patch for anything, I'd have expected checking first with folks | 15:21 |
| *** shaohe_feng has quit IRC | 15:22 | |
| efried | Okay, noted. Learning experience for me: next time I'll ask. Thanks y'all. | 15:22 |
| *** EinstCrazy has joined #openstack-nova | 15:22 | |
| *** shaohe_feng has joined #openstack-nova | 15:22 | |
| *** baoli_ has joined #openstack-nova | 15:23 | |
| *** gjayavelu has joined #openstack-nova | 15:23 | |
| *** tangchen_ has joined #openstack-nova | 15:23 | |
| *** baoli has quit IRC | 15:23 | |
| *** matrohon has quit IRC | 15:24 | |
| *** armax has joined #openstack-nova | 15:24 | |
| *** catintheroof has quit IRC | 15:25 | |
| *** rlrossi__ has quit IRC | 15:27 | |
| *** jaugustine has quit IRC | 15:28 | |
| *** armax has quit IRC | 15:29 | |
| *** baoli_ has quit IRC | 15:29 | |
| *** armax has joined #openstack-nova | 15:29 | |
| *** baoli has joined #openstack-nova | 15:29 | |
| *** rlrossit has joined #openstack-nova | 15:30 | |
| *** EinstCrazy has quit IRC | 15:30 | |
| *** mgoddard_ has joined #openstack-nova | 15:30 | |
| *** raj_singh_ has quit IRC | 15:30 | |
| *** baoli_ has joined #openstack-nova | 15:31 | |
| *** moshele has quit IRC | 15:31 | |
| *** rama_y has quit IRC | 15:31 | |
| *** shaohe_feng has quit IRC | 15:32 | |
| *** shaohe_feng has joined #openstack-nova | 15:33 | |
| *** code-R_ has quit IRC | 15:33 | |
| openstackgerrit | Sean Dague proposed openstack/nova: update wording around pep8 exceptions https://review.openstack.org/351253 | 15:33 |
| sdague | efried: ^^^ hopefully helps avoid the situation in the future | 15:33 |
| *** mgoddard has quit IRC | 15:34 | |
| *** baoli has quit IRC | 15:34 | |
| *** amotoki has joined #openstack-nova | 15:35 | |
| efried | sdague, cool, thanks. | 15:37 |
| efried | If I'm reading this right, E251 is the only remaining candidate for potential fixage? | 15:37 |
| efried | oh, bugger, never mind. | 15:37 |
| *** hemnafk is now known as hemna | 15:37 | |
| ildikov | mriedem: hi | 15:40 |
| *** matrohon has joined #openstack-nova | 15:40 | |
| ildikov | mriedem: can you check whether I'm in the right direction with this one: https://review.openstack.org/#/c/335358/9/nova/compute/api.py regarding unreserve? | 15:41 |
| *** priteau has joined #openstack-nova | 15:41 | |
| ildikov | mriedem: also if you have any pointers to an example of a version check handy I would appreciate that pretty much | 15:41 |
| *** EinstCrazy has joined #openstack-nova | 15:42 | |
| *** diogogmt has quit IRC | 15:42 | |
| *** shaohe_feng has quit IRC | 15:42 | |
| ildikov | mriedem: I'll try to fix it this week | 15:42 |
| knikolla | I think https://bugs.launchpad.net/nova/+bug/1595369 might be invalid | 15:42 |
| openstack | Launchpad bug 1595369 in OpenStack Compute (nova) "no spacing configuration for schedule _expire_reservations" [Low,In progress] - Assigned to Kristi Nikolla (knikolla) | 15:42 |
| *** shaohe_feng has joined #openstack-nova | 15:43 | |
| *** diogogmt has joined #openstack-nova | 15:43 | |
| *** beagles_brb is now known as beagles | 15:45 | |
| *** code-R has joined #openstack-nova | 15:45 | |
| *** EinstCrazy has quit IRC | 15:47 | |
| *** EinstCrazy has joined #openstack-nova | 15:48 | |
| *** efried1 has joined #openstack-nova | 15:49 | |
| *** efried has quit IRC | 15:49 | |
| *** abalutoiu has quit IRC | 15:49 | |
| *** yamahata has joined #openstack-nova | 15:50 | |
| *** tangchen_ has quit IRC | 15:51 | |
| openstackgerrit | Ed Leafe proposed openstack/nova: update wording around pep8 exceptions https://review.openstack.org/351253 | 15:52 |
| *** shaohe_feng has quit IRC | 15:52 | |
| edleafe | sdague: trivial fix ^^ | 15:52 |
| mdbooth | lyarwood tdurakov: https://review.openstack.org/#/c/329030/13/nova/virt/libvirt/driver.py | 15:52 |
| mdbooth | tdurakov says we're not trying to delete the _resize directory, and lyarwood agrees | 15:53 |
| *** shaohe_feng has joined #openstack-nova | 15:53 | |
| mdbooth | But... surely we *are* trying to delete the _resize directory? | 15:53 |
| mdbooth | This is just code motion, and that's what the code did before. Also, that's what I would have expected it to do. | 15:54 |
| lyarwood | mdbooth: we are at the moment, the issue is that the imagebackend recreates the original instance directory | 15:54 |
| mdbooth | lyarwood: Ah........ | 15:55 |
| mdbooth | lyarwood: Gotcha. Failure of dot connection. | 15:55 |
| tdurakov | mdbooth: yeah, I mean we need to remove original dir not _resize one | 15:55 |
| lyarwood | mdbooth: np I missed it as well until tdurakov said. | 15:55 |
| mdbooth | lyarwood: Yeah, there's already a convenient 'if instance.host != CONF.host' block below for that. | 15:56 |
| *** ametts has quit IRC | 15:57 | |
| mdbooth | Although... that wouldn't be good on shared storage. | 15:57 |
| mdbooth | Hmm... | 15:57 |
| lyarwood | \o/ | 15:57 |
| mdbooth | So, about that refactor :) | 15:58 |
| lyarwood | haha | 15:58 |
| tdurakov | mdbooth, lyarwood, folks, I'm still proposing to not fix it there | 15:58 |
| tdurakov | and change images code instead | 15:58 |
| tdurakov | :) | 15:58 |
| mdbooth | tdurakov: I think you're just ahead of me. | 15:58 |
| lyarwood | tdurakov: yup I think you've won | 15:59 |
| lyarwood | mdbooth: any pointers to your imageabackend changes in this area? | 16:00 |
| lyarwood | and yeah, I'm being lazy | 16:00 |
| mdbooth | lyarwood: Nah, I haven't touched it. | 16:00 |
| openstackgerrit | Hironori Shiina proposed openstack/nova: ironic: Cleanup instance information when spawn fails https://review.openstack.org/341253 | 16:00 |
| lyarwood | mdbooth: ah but you plan to? | 16:00 |
| *** matrohon has quit IRC | 16:00 | |
| mdbooth | If you can refactor resolve_driver_format to allow you to read without creating if it doesn't exist, then you're done. | 16:00 |
| *** liverpooler has joined #openstack-nova | 16:00 | |
| mdbooth | Yeah, I plan to rip it out entirely :) | 16:00 |
| lyarwood | mdbooth: right, I'll take a swing at this unless tdurakov wants to? | 16:01 |
| mdbooth | It's not going to conflict with anything I've already got pushed in any major way. | 16:01 |
| tdurakov | lyarwood: you are welcome) | 16:01 |
| tdurakov | add me please to review it once ready | 16:02 |
| openstackgerrit | Alex Szarka proposed openstack/nova: [WIP] Reduce code complexity to 25 https://review.openstack.org/351176 | 16:02 |
| lyarwood | tdurakov: I'll just resue the review I have up at the moment to save doing that, thanks again :) | 16:02 |
| mdbooth | tdurakov lyarwood: Incidentally, I think a few functional tests might not go amiss in this area. | 16:02 |
| *** browne has joined #openstack-nova | 16:02 | |
| *** shaohe_feng has quit IRC | 16:03 | |
| mdbooth | If we could actually create a directory with some stuff in it, then run it with a couple of different backends to see it all gets deleted (or not), that would be handy. | 16:03 |
| *** shaohe_feng has joined #openstack-nova | 16:04 | |
| *** tangchen_ has joined #openstack-nova | 16:04 | |
| *** mgoddard_ has quit IRC | 16:04 | |
| lyarwood | mdbooth: yup I can look into that as well | 16:04 |
| *** mgoddard has joined #openstack-nova | 16:04 | |
| tdurakov | lyarwood, mdbooth what would be also good: I'd like to see patch to tempest, smth like live-migration after cold/resize | 16:04 |
| *** ametts has joined #openstack-nova | 16:04 | |
| tdurakov | what do you think? | 16:04 |
| mdbooth | tdurakov: Tempest can't test this. It needs to look behind the curtain. | 16:05 |
| mdbooth | This would be a Nova functional test. | 16:05 |
| mdbooth | In this case, basically a unit test which we allow to write to disk. | 16:05 |
| tdurakov | mdbooth: I propose it as additional things | 16:05 |
| *** mdavidson has quit IRC | 16:05 | |
| tdurakov | also agree on functional tests idea | 16:06 |
| *** chandankumar has quit IRC | 16:06 | |
| *** ducttape_ has joined #openstack-nova | 16:06 | |
| *** chandankumar has joined #openstack-nova | 16:06 | |
| mdbooth | I'm not sure what Tempest can usefully do, other than confirm that resize works. | 16:06 |
| mdbooth | It can't check the resulting files on the host. | 16:06 |
| tdurakov | mdbooth: for that bug | 16:06 |
| tdurakov | live-migration will fail | 16:06 |
| *** giri has joined #openstack-nova | 16:07 | |
| tdurakov | because there is directory left after cold-migration finished | 16:07 |
| lyarwood | yeah there should be a whole load of do x then live migrate tempest tests tbh | 16:07 |
| *** pwnall1 has joined #openstack-nova | 16:07 | |
| tdurakov | so kind of verification | 16:07 |
| *** jlanoux has quit IRC | 16:07 | |
| mdbooth | tdurakov: My feeling based on recent experience is that Tempest might say that's not very Tempesty. | 16:07 |
| jaypipes | lyarwood: +1000 | 16:08 |
| *** baoli_ has quit IRC | 16:08 | |
| tdurakov | mdbooth, lyarwood: could be, if you don't mind I'll take care on tempest things? | 16:08 |
| mdbooth | tdurakov: Absolutely. | 16:08 |
| lyarwood | tdurakov: yup np | 16:09 |
| *** dikonoor has joined #openstack-nova | 16:09 | |
| jaypipes | lyarwood: or nova functional tests. either way. point being, there are no good/extensive functional tests of live-migration or resize operations at this time. | 16:09 |
| mdbooth | jaypipes: Resize of ephemeral disks has been broken forever :) | 16:10 |
| jaypipes | mdbooth: heh, agreed. | 16:10 |
| mdbooth | There's a Tempest test, but it doesn't check that the disks were actually resized | 16:10 |
| mdbooth | So it passes, but they weren't resized. | 16:10 |
| *** gjayavelu has quit IRC | 16:11 | |
| * mdbooth often wonders how much ephemeral disks are actually used. | 16:11 | |
| tdurakov | mdbooth, lyarwood need to go now, happy we get agreement on that | 16:12 |
| *** pbandark has quit IRC | 16:12 | |
| mdbooth | tdurakov: So lyarwood is going to do the refactor and you're going to write a Tempest test? | 16:12 |
| tdurakov | right | 16:12 |
| lyarwood | worksforme | 16:12 |
| *** efried1 has quit IRC | 16:12 | |
| lyarwood | tdurakov: \o_ thanks for your help with this | 16:13 |
| *** eharney has quit IRC | 16:13 | |
| *** shaohe_feng has quit IRC | 16:13 | |
| *** palexster1 has joined #openstack-nova | 16:13 | |
| *** sridharg has quit IRC | 16:13 | |
| *** efried has joined #openstack-nova | 16:13 | |
| *** shaohe_feng has joined #openstack-nova | 16:14 | |
| *** tblakes has quit IRC | 16:14 | |
| *** aorourke has joined #openstack-nova | 16:14 | |
| *** baoli has joined #openstack-nova | 16:14 | |
| *** nic has joined #openstack-nova | 16:15 | |
| *** mat128 is now known as mat128|lunch | 16:15 | |
| *** seldenr has joined #openstack-nova | 16:15 | |
| *** unicell1 has quit IRC | 16:17 | |
| *** matrohon has joined #openstack-nova | 16:17 | |
| cfriesen_ | Any chance some folks could take a look at https://review.openstack.org/#/c/342709 ? This fixes a CPU packing bug on x86 hosts with hyperthreading enabled. Not my patch, but I reported the bug. | 16:18 |
| cfriesen_ | mdbooth: speaking of resize of ephemeral disks...is this the right way to handle it? https://review.openstack.org/#/c/346263/ | 16:19 |
| mdbooth | cfriesen_: Well personally I think this is the right way to do it: https://review.openstack.org/#/c/337160/ ;) | 16:23 |
| mdbooth | _create_image is the devil | 16:23 |
| *** shaohe_feng has quit IRC | 16:23 | |
| *** matrohon has quit IRC | 16:23 | |
| *** shaohe_feng has joined #openstack-nova | 16:24 | |
| mdbooth | cfriesen_: However, note that neither of those fix the problem. | 16:27 |
| mdbooth | The issue is that the resize is based on the size set on the BDM, and compute manager didn't update that for us. | 16:28 |
| mdbooth | So the real but is in compute manager, and applies to all driver. | 16:28 |
| *** Apoorva has joined #openstack-nova | 16:29 | |
| *** _ducttape_ has joined #openstack-nova | 16:30 | |
| *** Apoorva has quit IRC | 16:31 | |
| *** Apoorva has joined #openstack-nova | 16:32 | |
| *** kro_focused is now known as krotscheck | 16:32 | |
| *** EinstCra_ has joined #openstack-nova | 16:32 | |
| *** ducttape_ has quit IRC | 16:33 | |
| *** shaohe_feng has quit IRC | 16:33 | |
| *** shaohe_feng has joined #openstack-nova | 16:34 | |
| *** EinstCrazy has quit IRC | 16:35 | |
| *** chandankumar has quit IRC | 16:36 | |
| mriedem | alaski: have you ever looked at cinder's capabilities api? | 16:38 |
| mriedem | https://review.openstack.org/#/c/325895/ | 16:38 |
| mriedem | oops | 16:38 |
| mriedem | http://developer.openstack.org/api-ref-blockstorage-v2.html#showBackendCapabilities | 16:38 |
| *** lucasagomes is now known as lucas|dinner | 16:39 | |
| alaski | mriedem: I haven't. I flagged an email from a few days ago about it but hadn't dug into it yet | 16:39 |
| *** matrohon has joined #openstack-nova | 16:40 | |
| mriedem | looks like it's just a call from the api to the volume manager which asks the driver for it's list of capabilities | 16:41 |
| *** giri has quit IRC | 16:41 | |
| johnthetubaguy | hmm, thats interesting | 16:42 |
| alaski | that looks useful. I think we'd need to be able to call that on an instance and include host capabilities as part of the response | 16:42 |
| cfriesen_ | mdbooth: I like your patch series, but I don't think it's suitable for backport to Mitaka/stable. My fix would be a simple interim fix to allow resize to work if there happens to be an ephemeral disk. | 16:42 |
| *** shaohe_feng has quit IRC | 16:44 | |
| *** shaohe_feng has joined #openstack-nova | 16:44 | |
| mriedem | alaski: call it on the instance for what? flavor/image_meta capabilities? | 16:47 |
| johnthetubaguy | oh, you are SRIOV, no live-migrate for you | 16:47 |
| *** Swami has joined #openstack-nova | 16:48 | |
| alaski | mriedem: those, yes. as well as what does policy allow me to do, and what does the host it's on support. | 16:48 |
| *** gszasz has quit IRC | 16:49 | |
| mdbooth | cfriesen_: Hah, yeah. No good for a backport. | 16:50 |
| *** unicell has joined #openstack-nova | 16:50 | |
| *** _ducttape_ has quit IRC | 16:50 | |
| *** Sukhdev has joined #openstack-nova | 16:50 | |
| mdbooth | cfriesen_: So, I think I may have written that exact same patch at some point in the past, then abandoned it. | 16:51 |
| *** ducttape_ has joined #openstack-nova | 16:51 | |
| mdbooth | It misses an edge case where the source disk uses a non-standard name for its backing disk, but I don't think that's very important. It won't fix the problem, though, because the bug's really in compute manager. | 16:52 |
| *** david-lyle has quit IRC | 16:53 | |
| *** david-lyle has joined #openstack-nova | 16:53 | |
| *** dikonoor has quit IRC | 16:53 | |
| *** shaohe_feng has quit IRC | 16:54 | |
| *** shaohe_feng has joined #openstack-nova | 16:55 | |
| mriedem | johnthetubaguy: also depends on which host you land on though | 16:55 |
| mriedem | but yeah | 16:55 |
| johnthetubaguy | mriedem: yeah, true | 16:56 |
| openstackgerrit | Clenimar Filemon proposed openstack/nova: Support Identity v3 when connecting to Ironic https://review.openstack.org/300154 | 16:59 |
| *** belmoreira has joined #openstack-nova | 17:00 | |
| *** anush_ has quit IRC | 17:00 | |
| openstackgerrit | Alex Szarka proposed openstack/nova: [WIP] Reduce code complexity to 25 https://review.openstack.org/351176 | 17:00 |
| cfriesen_ | mdbooth: the case I was trying to fix was where we were resizing something else, not the ephemeral disk. Currently it breaks because the ephemeral disk ends up with no backing store. With that change it works (presumably as long as you don't try to actually resize the ephemeral disk.) | 17:01 |
| mdbooth | cfriesen_: https://review.openstack.org/#/c/3477/11/nova/virt/libvirt/connection.py | 17:01 |
| clenimar | now that ironic is supporting keystone v3, it's a good time to get https://review.openstack.org/300154 in too. i think we're close :) | 17:01 |
| mdbooth | cfriesen_: It's always been that way. | 17:02 |
| *** oomichi has joined #openstack-nova | 17:02 | |
| mdbooth | cfriesen_: IOW, seems it's that way for no good reason, despite being apparently deliberate. | 17:02 |
| openstackgerrit | dane-fichter proposed openstack/nova: Use cursive for signature verification https://review.openstack.org/351232 | 17:03 |
| *** flaper87 has quit IRC | 17:03 | |
| mriedem | clenimar: we probably need at least 3 more months and 20 more patch sets on that to meet the requisite limit | 17:03 |
| *** shaohe_feng has quit IRC | 17:04 | |
| cfriesen_ | mdbooth: that's what made me confused. :) Do you think it's worth adding tests to my patch and try to get it in as something we could backport....or should we just try to get your full solution in and give up on Mitaka? | 17:04 |
| *** shaohe_feng has joined #openstack-nova | 17:05 | |
| jroll | clenimar: ++ | 17:05 |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Update binding:profile for SR-IOV ports on resize-revert https://review.openstack.org/347444 | 17:06 |
| mdbooth | cfriesen_: No, I think you should try to get the smaller fix in. Makes no difference to me. I need to update that function anyway, and this merge conflict will be tiny. | 17:06 |
| clenimar | mriedem: ehehe i see. it's been a looooong way :) | 17:07 |
| mriedem | clenimar: plus i just -1'ed :) | 17:07 |
| *** mvk has quit IRC | 17:08 | |
| clenimar | mriedem: i appreciate that! :p i'll re-roll it right now. do you agree with the deprecation notice i've added? | 17:10 |
| mriedem | i'm not all the way through yet | 17:10 |
| mriedem | clenimar: i think iv'e asked this before, but when falling back to the v2Password auth, it's not passing service/endpoint - so are those then looked up from the service catalog? | 17:11 |
| *** matrohon has quit IRC | 17:11 | |
| *** permalac has quit IRC | 17:11 | |
| clenimar | yes... we're not passing credentials anymore but a session | 17:11 |
| clenimar | ironicclient knows how to take it from the service catalog :) | 17:11 |
| *** eharney has joined #openstack-nova | 17:12 | |
| *** unicell has quit IRC | 17:12 | |
| mriedem | oh right the session is passed to ironic client | 17:12 |
| mriedem | ok | 17:12 |
| mdbooth | jaypipes: Should I start banging out the test change that dansmith suggested in the morning? Do you have anything to add to that? | 17:12 |
| mriedem | clenimar: which release of ironicclient added keystone v3 support? | 17:12 |
| *** belmoreira has quit IRC | 17:13 | |
| mriedem | i guess 1.2.0 https://github.com/openstack/python-ironicclient/commit/7226ad44aafc0a4399a62e7ebbd26f69bade8c21 | 17:14 |
| *** jdurgin1 has quit IRC | 17:14 | |
| *** shaohe_feng has quit IRC | 17:14 | |
| *** lpetrut has quit IRC | 17:15 | |
| *** shaohe_feng has joined #openstack-nova | 17:15 | |
| mriedem | clenimar: why don't we deprecate CONF.ironic.api_endpoint again? | 17:16 |
| jroll | mriedem: idk if this is clenimar's answer, but some deployers don't trust their service catalog >.> | 17:17 |
| mriedem | is api_endpoint read by ksa? | 17:17 |
| jroll | idk, I'm just making wild assumptions | 17:17 |
| * jroll not well educated on auth systems | 17:17 | |
| jroll | that's why it was there in the past, for sure | 17:17 |
| openstackgerrit | Hironori Shiina proposed openstack/python-novaclient: Modify flatten method to display an empty dict https://review.openstack.org/351292 | 17:18 |
| openstackgerrit | Hironori Shiina proposed openstack/nova: Allow empty CPU info of hypervisors in API response https://review.openstack.org/346868 | 17:19 |
| *** unicell has joined #openstack-nova | 17:19 | |
| *** rama_y has joined #openstack-nova | 17:19 | |
| *** unicell has quit IRC | 17:19 | |
| *** unicell has joined #openstack-nova | 17:19 | |
| jroll | dansmith: not sure about that comment on get_hosts, not seeing where we could make that better | 17:20 |
| dansmith | jroll: duh, sorry.. I was thinking that was get_hosts(self.host) but it's not | 17:21 |
| jroll | heh | 17:22 |
| jroll | yeah | 17:22 |
| dansmith | jroll: if you swap the sides of the and in that you'll avoid doing the hash calculation for nodes with an instance though right? | 17:22 |
| mriedem | clenimar: comments are inline | 17:22 |
| jroll | dansmith: yeah, that's a good point | 17:22 |
| dansmith | jroll: I shall recant on the review | 17:22 |
| jroll | dansmith: too late, did it for you | 17:23 |
| *** mat128|lunch is now known as mat128 | 17:23 | |
| * jroll grabs lunch now | 17:23 | |
| dansmith | heh | 17:24 |
| *** shaohe_feng has quit IRC | 17:25 | |
| *** shaohe_feng has joined #openstack-nova | 17:25 | |
| *** smatzek_ has joined #openstack-nova | 17:26 | |
| *** hoangcx has quit IRC | 17:26 | |
| *** daemontool has joined #openstack-nova | 17:28 | |
| *** Nissname__ has joined #openstack-nova | 17:28 | |
| Nissname__ | Hello ! I don't know how to stop or start a server with PHP-opencloud, i didn't find any api call to these two functions. someone can help please ? | 17:28 |
| mriedem | Nissname__: see the channel topic | 17:29 |
| *** smatzek has quit IRC | 17:30 | |
| *** Nissname__ has quit IRC | 17:30 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Create Instance from BuildRequest if not in a cell https://review.openstack.org/263927 | 17:30 |
| openstackgerrit | Andrew Laski proposed openstack/nova: instance.name should be blank if instance.id is not set https://review.openstack.org/327342 | 17:30 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Cells: Handle delete with BuildRequest https://review.openstack.org/325985 | 17:30 |
| edleafe | mriedem: I have to miss most of the nova meeting later to take my daughter to a thing. jaypipes will handle the scheduler subteam stuff. | 17:32 |
| mriedem | ok | 17:33 |
| mriedem | dansmith: are you going to abandon this https://review.openstack.org/#/c/242602/ ? | 17:34 |
| *** unicell has quit IRC | 17:34 | |
| dansmith | mriedem: if you want.. I'm very confused about the feedback.. "yes we need it", "no we don't", "+2", "-1", etc | 17:34 |
| dansmith | so .. whatever you want :) | 17:35 |
| mriedem | the one after it to add support to the bdm object was abandoned | 17:35 |
| *** shaohe_feng has quit IRC | 17:35 | |
| mriedem | we wanted it when we were trying to fix cells v1 | 17:35 |
| dansmith | automatically right? | 17:35 |
| mriedem | no | 17:35 |
| mriedem | probably mikal | 17:35 |
| dansmith | yeah, but someone else said they wanted this for other stuff at some point | 17:35 |
| *** devkulkarni2 has quit IRC | 17:35 | |
| dansmith | right mikal automatic | 17:35 |
| *** TravT has quit IRC | 17:36 | |
| mriedem | we don't have a use case for it i don't think | 17:36 |
| *** shaohe_feng has joined #openstack-nova | 17:36 | |
| dansmith | tis gone | 17:36 |
| *** zul has quit IRC | 17:36 | |
| *** gjayavelu has joined #openstack-nova | 17:37 | |
| *** hoangcx has joined #openstack-nova | 17:37 | |
| mriedem | i'll make up a reason to need it next week and then get on your ass about restoring it :) | 17:37 |
| * dansmith nods | 17:37 | |
| *** jwcroppe has quit IRC | 17:37 | |
| *** dikonoor has joined #openstack-nova | 17:39 | |
| alaski | I think we still need that at some point, but there's nothing pressing that depends on it | 17:40 |
| *** jwcroppe has joined #openstack-nova | 17:42 | |
| dansmith | ^ see? :) | 17:42 |
| mriedem | ha | 17:43 |
| mriedem | when is alaski's birthday? | 17:43 |
| mriedem | because we can restore in time for that as a gift | 17:43 |
| *** tblakes has joined #openstack-nova | 17:44 | |
| alaski | hah | 17:44 |
| *** Sukhdev has quit IRC | 17:45 | |
| *** shaohe_feng has quit IRC | 17:45 | |
| *** shaohe_feng has joined #openstack-nova | 17:46 | |
| *** vishwanathj has quit IRC | 17:48 | |
| *** zul has joined #openstack-nova | 17:49 | |
| mriedem | i love it when you tell someone how to cherry pick a change to get the commit message straight, and they hand edit the commit message to try and trick you | 17:51 |
| *** tesseract- has quit IRC | 17:53 | |
| melwitt | zzzeek: I remembered why we can't just set sqlite_fk=True all the time for oslo.db, because we need to be able to set it to False for tests that do migrations (table alters) | 17:54 |
| *** maurosr has quit IRC | 17:54 | |
| *** thorst has quit IRC | 17:55 | |
| mriedem | haleyb: it's unclear to me if we should conditinally disable ipv6 based on the bridge name in https://review.openstack.org/#/c/313070/ | 17:55 |
| *** thorst has joined #openstack-nova | 17:55 | |
| *** shaohe_feng has quit IRC | 17:55 | |
| *** mvk has joined #openstack-nova | 17:56 | |
| *** shaohe_feng has joined #openstack-nova | 17:56 | |
| *** unicell has joined #openstack-nova | 17:57 | |
| *** mdrabe_ has joined #openstack-nova | 17:58 | |
| mriedem | rlrossit: are you still pursuing this? https://review.openstack.org/#/c/315757/ | 17:59 |
| haleyb | mriedem: it should disable on any bridge, not just ones starting with brq, the code should be agnostic in that respect | 17:59 |
| rlrossit | mriedem: not actively, if someone else is willing to take it over | 17:59 |
| *** mdrabe_ has quit IRC | 18:00 | |
| *** mdrabe_ has joined #openstack-nova | 18:00 | |
| haleyb | mriedem: oh, now i see your comment. No, i think you should do it for everything for security reasons | 18:01 |
| *** thorst_ has joined #openstack-nova | 18:01 | |
| *** mgoddard_ has joined #openstack-nova | 18:01 | |
| openstackgerrit | Randall Nortman proposed openstack/nova-specs: Scoped policies for server groups https://review.openstack.org/247654 | 18:01 |
| *** devkulkarni1 has joined #openstack-nova | 18:02 | |
| *** mdrabe has quit IRC | 18:02 | |
| *** thorst has quit IRC | 18:03 | |
| *** mgoddard has quit IRC | 18:04 | |
| clenimar | mriedem: thanks. | 18:05 |
| clenimar | about api_endpoint... am not sure if we can just remove it | 18:05 |
| *** shaohe_feng has quit IRC | 18:06 | |
| mriedem | clenimar: it's no longer used in your change | 18:06 |
| mriedem | from what i can tell | 18:06 |
| clenimar | i didn't deprecate it because i thought that ironic team should do it first | 18:06 |
| *** mgoddard_ has quit IRC | 18:06 | |
| clenimar | yep | 18:06 |
| mriedem | or does ksa magically use it | 18:06 |
| clenimar | if we don't pass api_endpoint, ironicclient take it from the catalog | 18:06 |
| *** shaohe_feng has joined #openstack-nova | 18:06 | |
| mriedem | and we no longer pass it | 18:06 |
| mriedem | b/c of the session | 18:06 |
| clenimar | yep | 18:07 |
| clenimar | but if we pass it, ironicclient will forward to ksa | 18:07 |
| mriedem | is that an upgrade issue? | 18:07 |
| clenimar | through endpoint_override | 18:07 |
| mriedem | if we fallback to legacy it seems we should continue to pass api_endpoint | 18:07 |
| mriedem | b/c jroll said the service catalog can't be trusted no way no how | 18:07 |
| *** ducttape_ has quit IRC | 18:08 | |
| *** lpetrut has joined #openstack-nova | 18:09 | |
| clenimar | i'll add it then... it won't hurt | 18:09 |
| mriedem | ok, and deprecate it | 18:09 |
| clenimar | about the tests... it seems that there are no tests for that code (baremetal_nodes.py) | 18:10 |
| *** ducttape_ has joined #openstack-nova | 18:10 | |
| openstackgerrit | melanie witt proposed openstack/nova: Add functional regression test for quota bug 1284424 https://review.openstack.org/293800 | 18:10 |
| openstack | bug 1284424 in OpenStack Compute (nova) "nova quota statistics can be incorrect" [High,In progress] https://launchpad.net/bugs/1284424 - Assigned to Dmitry Stepanenko (dstepanenko) | 18:10 |
| openstackgerrit | dane-fichter proposed openstack/nova: Use cursive for signature verification https://review.openstack.org/351232 | 18:11 |
| mriedem | clenimar: we should probably have something in https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/test_baremetal_nodes.py | 18:11 |
| *** tpeoples has quit IRC | 18:12 | |
| clenimar | oh, that's right. | 18:13 |
| clenimar | i'll fix it then... | 18:13 |
| *** dikonoor has quit IRC | 18:13 | |
| clenimar | thanks :) | 18:13 |
| *** shaohe_feng has quit IRC | 18:16 | |
| *** shaohe_feng has joined #openstack-nova | 18:17 | |
| *** tonytan4ever has joined #openstack-nova | 18:21 | |
| *** Sukhdev has joined #openstack-nova | 18:22 | |
| jaypipes | mdbooth: feel free to bang out stuff in the morning. I will have a review done on your stuff later today, thx. | 18:22 |
| *** shaohe_feng has quit IRC | 18:26 | |
| *** shaohe_feng has joined #openstack-nova | 18:26 | |
| *** jaugustine has joined #openstack-nova | 18:28 | |
| mriedem | danpb: real small test wrinkle to handle in https://review.openstack.org/#/c/269672/ and then i'm +2 | 18:29 |
| mriedem | danpb: if you're end of day though i can update it quick | 18:30 |
| *** hoangcx has quit IRC | 18:30 | |
| zzzeek | melwitt: the migration tests are pretty isolated, I'd set it to False just for those, using a different engine | 18:33 |
| zzzeek | melwitt: also, why is nova running migration tests against SQLite? SQLite doesn't support ALTER TABLE. | 18:33 |
| zzzeek | melwitt: my refactor of Nova's fixtures would solve all this, it wouldnt use migrations against SQLite ever. | 18:34 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: network: introduce helper APIs for dealing with os-vif objects https://review.openstack.org/269672 | 18:34 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: convert over to use os-vif for Linux Bridge & OVS https://review.openstack.org/350595 | 18:34 |
| *** danpb has quit IRC | 18:35 | |
| melwitt | zzzeek: I don't know the answer to that. sdague might possibly know | 18:36 |
| *** shaohe_feng has quit IRC | 18:36 | |
| *** unicell has quit IRC | 18:37 | |
| *** shaohe_feng has joined #openstack-nova | 18:37 | |
| zzzeek | melwitt: the migrations are used to build up SQLite just once, then the state of the database is captured using a pysqlite trick, then that script is used for all the rest of the tests to build up the schema | 18:37 |
| *** ayoung has quit IRC | 18:38 | |
| zzzeek | melwitt: so maybe in that first run w/ the migrations, something goes wrong, but that would mean it's going wrong for all tests across the board | 18:38 |
| *** jdillaman has quit IRC | 18:38 | |
| zzzeek | melwitt: I have a lot of suggestions here but my understanding is that these are all O or later. too late in N | 18:39 |
| *** jdillaman has joined #openstack-nova | 18:39 | |
| *** prateek has joined #openstack-nova | 18:40 | |
| *** hoangcx has joined #openstack-nova | 18:40 | |
| sdague | zzzeek: SQLite supports limited alter table right? you can add a column | 18:40 |
| zzzeek | sdague: it does. but so what. you can't deploy Nova in production against SQLite :) | 18:40 |
| melwitt | zzzeek: when I tried using the built-in flag for oslo.db for sqlite_fk I noticed I get failures right away from the migration.db_sync in the Database fixture itself, "(sqlite3.OperationalError) table instances already exists" so something is afoot there | 18:41 |
| *** maurosr has joined #openstack-nova | 18:41 | |
| dansmith | add column is all we need in migrations | 18:41 |
| zzzeek | sdague: also adding a column should have no issue with foreign key pragma turned on. the issue there would be when you drop and recreate tables which is what sqlalchemy-migrate does when you tell it to make simple alterations to SQLite tables | 18:41 |
| zzzeek | sdague: this is why in Alembic, none of that stuff just happens implicitly /magically. | 18:42 |
| sdague | zzzeek: sure, anyway, the historic reason for using the migrations was that the schema was sometimes subtly different in the migration path vs. just declaring the models | 18:42 |
| sdague | I don't know where any of that stands now | 18:42 |
| *** diogogmt has quit IRC | 18:42 | |
| *** diogogmt has joined #openstack-nova | 18:42 | |
| zzzeek | sdague: if the initial build-up of the schema from the 218 migration on forward works for SQLite then you've built the DB, so the way the fixture works now, it only does that once. I'd build that up with sqlite_fk=False, and then that's it | 18:43 |
| zzzeek | melwitt: ^^^^ | 18:43 |
| mriedem | we have a +2 on the bottom os-vif change now https://review.openstack.org/#/c/269672/ | 18:43 |
| *** unicell has joined #openstack-nova | 18:43 | |
| mriedem | jaypipes: ^ | 18:43 |
| sdague | so, I don't think there is anyone demanding for philisophical reasons that we do migration testing on sqlite, but changing that just needs to be thought through, which I think all the people that need eyes on it are kind of swamped until we get the release in the can | 18:44 |
| *** yassou has quit IRC | 18:44 | |
| melwitt | zzzeek: ah, okay. you mentioned that earlier but I didn't get it. thanks | 18:44 |
| zzzeek | sdague: yeah I'm just answering melwitt's question about something they were trying to get working. not sure if that one is for the current release or not | 18:44 |
| melwitt | sdague: yeah, zzzeek was just answering some questions I had. I had been looking at how to enable fk enforcement in our tests to help people like myself catch problems locally when working on db api code. it's not targeted for any specific release, just something I was trying out | 18:46 |
| sdague | melwitt: ok, cool | 18:46 |
| *** shaohe_feng has quit IRC | 18:47 | |
| zzzeek | melwitt: if we can get to my fixture refactor, the whole thing will be easier to look at | 18:47 |
| *** prateek has quit IRC | 18:47 | |
| *** shaohe_feng has joined #openstack-nova | 18:47 | |
| zzzeek | sdague: but noted, there's concern that the models don't match the migrations column / datatype wise I'd guess | 18:47 |
| dansmith | we have a test that checks that, right? is it not sufficient? | 18:48 |
| dansmith | it always catches me, AFAIK, anyway | 18:49 |
| alaski | gets me too | 18:49 |
| alaski | I do think it lacks on FK checking IIRC | 18:49 |
| alaski | it can verify the names match and that's it | 18:50 |
| dansmith | ah | 18:50 |
| *** daemontool has quit IRC | 18:51 | |
| lbeliveau | melwitt: this patch is stale, you commented on it a while back and your comments have been addressed, whenever you have a chance :) https://review.openstack.org/#/c/300616 | 18:52 |
| *** stewie925_ has joined #openstack-nova | 18:52 | |
| *** daemontool has joined #openstack-nova | 18:52 | |
| *** jwcroppe has quit IRC | 18:52 | |
| melwitt | lbeliveau: ah, thanks. I've been meaning to look at that again | 18:53 |
| lbeliveau | melwitt: thanks a bunch | 18:53 |
| *** stewie925_ has quit IRC | 18:53 | |
| *** stewie925_ has joined #openstack-nova | 18:54 | |
| mriedem | ildikov: commented in https://review.openstack.org/#/c/335358/ | 18:55 |
| ildikov | mriedem: thanks, checking | 18:55 |
| mriedem | ildikov: feel free to double check with dansmith in case i'm wrong :) | 18:55 |
| ildikov | mriedem: ok :) | 18:56 |
| *** shaohe_feng has quit IRC | 18:57 | |
| *** shaohe_feng has joined #openstack-nova | 18:57 | |
| ildikov | mriedem: I really just wanted check whether I got the right part of the flow and thinking in the right direction before moving forward with the code | 18:58 |
| ildikov | mriedem: thanks much! | 18:58 |
| mriedem | ildikov: well we for sure can't reserve the volume in the api if there is nothing that's going to unreserve it | 18:59 |
| mriedem | and the compute has to unreserve it on failure | 18:59 |
| *** rlrossit has quit IRC | 18:59 | |
| mriedem | but you could have a newton api and mitaka compute which won't unreserve it | 18:59 |
| *** jdillaman has quit IRC | 18:59 | |
| mriedem | so that's the thought process at least | 18:59 |
| ildikov | dansmith: please leave a comment here if you disagree with the direction it's heading: https://review.openstack.org/#/c/335358/9/nova/compute/api.py | 18:59 |
| *** rlrossit has joined #openstack-nova | 19:00 | |
| ildikov | mriedem: we discussed this process regarding multi-attach, so it should be fine | 19:00 |
| dansmith | I disagree | 19:00 |
| *** EinstCra_ has quit IRC | 19:00 | |
| ildikov | mriedem: I know we don't want to leave the Cinder volume in a useless state | 19:00 |
| *** stewie925 has quit IRC | 19:00 | |
| ildikov | dansmith: with which part? | 19:01 |
| *** stewie925_ is now known as stewie925 | 19:01 | |
| *** rlrossit_ has joined #openstack-nova | 19:01 | |
| dansmith | ildikov: I haven't looked I'm just being difficult | 19:01 |
| ildikov | dansmith: ah, you just said 'hi', got it :) | 19:02 |
| *** EinstCrazy has joined #openstack-nova | 19:02 | |
| dansmith | lol | 19:02 |
| dansmith | mriedem: she gets me | 19:02 |
| ildikov | dansmith: it took some time :) | 19:03 |
| *** oomichi has quit IRC | 19:03 | |
| *** mdrabe_ has quit IRC | 19:03 | |
| *** mdrabe__ has joined #openstack-nova | 19:03 | |
| alaski | mriedem: ildikov you have to consider calling unreserve even if the boot request never makes it to a compute | 19:04 |
| *** rlrossit has quit IRC | 19:04 | |
| *** jdillaman has joined #openstack-nova | 19:05 | |
| alaski | meaning, also in the conductor | 19:05 |
| ildikov | alaski: I guess the process should be similar like normal attach is handled | 19:05 |
| *** jwcroppe has joined #openstack-nova | 19:06 | |
| ildikov | alaski: as reserve happens on the same level than where I plan to introduce it now for BFV | 19:06 |
| ildikov | I'll check what's in the conductor for that | 19:07 |
| *** edand has joined #openstack-nova | 19:07 | |
| *** jwcroppe has quit IRC | 19:07 | |
| *** shaohe_feng has quit IRC | 19:07 | |
| *** fifieldt has quit IRC | 19:07 | |
| *** shaohe_feng has joined #openstack-nova | 19:08 | |
| alaski | yeah, it's similar to attach with the extra wrinkle that if the instance fails scheduling then the compute manager code never runs | 19:08 |
| alaski | ildikov: http://git.openstack.org/cgit/openstack/nova/tree/nova/conductor/manager.py#n485 is the error case I'm thinking of, in that situation the volume should be unreserved | 19:09 |
| *** armax_ has joined #openstack-nova | 19:11 | |
| *** daemontool_ has joined #openstack-nova | 19:11 | |
| *** armax has quit IRC | 19:12 | |
| *** armax_ is now known as armax | 19:12 | |
| *** EinstCrazy has quit IRC | 19:13 | |
| *** sdake_ has joined #openstack-nova | 19:13 | |
| alaski | dansmith: how do you feel about List objects being concatenatable? It could pretty up my code if that were added | 19:13 |
| dansmith | alaski: what does that mean? += or .append()? | 19:14 |
| alaski | + or += | 19:14 |
| *** daemontool has quit IRC | 19:15 | |
| openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova: Improve help text for vmwareapi_opts https://review.openstack.org/332503 | 19:15 |
| *** mdrabe__ is now known as mdrabe | 19:15 | |
| dansmith | alaski: I like + better | 19:15 |
| ildikov | alaski: so what you posted is the code that runs after the reserve call and can fail independently of any attach related operation, right? and you suggest to call unreserve there, right? | 19:15 |
| *** sdake has quit IRC | 19:16 | |
| *** thorst_ is now known as thorst | 19:16 | |
| alaski | dansmith: cool. I'll try to remember to propose that to ovo at some point | 19:16 |
| openstackgerrit | Swaminathan Vasudevan proposed openstack/nova: Implement setup_networks_on_host for Neutron networks https://review.openstack.org/275073 | 19:16 |
| dansmith | alaski: you can add it to our intermediate class before then | 19:16 |
| *** shaohe_feng has quit IRC | 19:17 | |
| alaski | ildikov: yep. https://review.openstack.org/#/c/335358/9/nova/compute/api.py runs early in the boot process, flow then passes to the conductor code I linked which attempts to pick a compute to build the instance on. A failure there means execution never reached a compute host to even attempt an attach | 19:18 |
| *** fifieldt has joined #openstack-nova | 19:18 | |
| ildikov | alaski: yeap, that's what I had in mind, thanks for confirming | 19:19 |
| *** vishwanathj has joined #openstack-nova | 19:19 | |
| *** haplo37__ has joined #openstack-nova | 19:20 | |
| alaski | dansmith: I wasn't sure if we still had a nova list base, but since we do ... typey typey | 19:20 |
| *** shaohe_feng has joined #openstack-nova | 19:20 | |
| dansmith | yup | 19:20 |
| *** vishwanathj has quit IRC | 19:21 | |
| *** vishwanathj has joined #openstack-nova | 19:21 | |
| ildikov | alaski: there's a note here to remove block_device_mapping and legacy_bdm in that function. do you happen to know the origin of that and what does it mean there? | 19:23 |
| alaski | ildikov: a fresh copy of the block device mapping is pulled from the db on line 507 | 19:25 |
| *** thorst has quit IRC | 19:25 | |
| *** ihrachys has joined #openstack-nova | 19:25 | |
| alaski | I don't recall the full reasons why, but the comment there indicates that the version passed over RPC isn't complete | 19:25 |
| ildikov | alaski: yeap, I've just found that one | 19:26 |
| ildikov | the pure uncoloured text tricked with where the function actually ends... :) | 19:26 |
| *** rlrossit_ has quit IRC | 19:26 | |
| *** shaohe_feng has quit IRC | 19:28 | |
| alaski | I really should link to github for that reason... | 19:28 |
| *** thorst has joined #openstack-nova | 19:28 | |
| *** ljxiash has quit IRC | 19:28 | |
| alaski | I just checked and nova does not even pass block_device_mapping over RPC anymore so that parameter will always be None | 19:28 |
| *** shaohe_feng has joined #openstack-nova | 19:28 | |
| *** thorst has quit IRC | 19:29 | |
| openstackgerrit | Maciej Szankin proposed openstack/nova: Improve consistency in scheduler opts https://review.openstack.org/349666 | 19:29 |
| *** jaugustine has quit IRC | 19:30 | |
| *** rlrossit_ has joined #openstack-nova | 19:31 | |
| *** rlrossit_ has quit IRC | 19:31 | |
| *** vishwanathj has quit IRC | 19:31 | |
| *** rlrossit_ has joined #openstack-nova | 19:31 | |
| *** vishwanathj has joined #openstack-nova | 19:31 | |
| *** thorst has joined #openstack-nova | 19:32 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova: Ironic: report node.resource_class https://review.openstack.org/345082 | 19:33 |
| *** vishwanathj has quit IRC | 19:33 | |
| jroll | jaypipes: ^ rebased | 19:33 |
| *** vishwanathj has joined #openstack-nova | 19:33 | |
| *** jwcroppe has joined #openstack-nova | 19:34 | |
| *** bvanhav has quit IRC | 19:35 | |
| *** tonytan_brb has joined #openstack-nova | 19:36 | |
| *** Apoorva has quit IRC | 19:37 | |
| ildikov | alaski: seems reasonable not to pass it, I was just wondering where to have volume_id from before I saw line 507 | 19:37 |
| *** burgerk has quit IRC | 19:37 | |
| clenimar | mriedem: jroll: what if we use api_endpoint instead of deprecating it? ksa allows one to pass an endpoint_override and ironicclient uses api_endpoint to set it... does it make sense? | 19:38 |
| *** shaohe_feng has quit IRC | 19:38 | |
| *** shaohe_feng has joined #openstack-nova | 19:38 | |
| mriedem | clenimar: and if not specified ksa/ironicclient uses the service catalog? | 19:38 |
| clenimar | yep | 19:38 |
| jroll | clenimar: I'm good with that | 19:38 |
| *** baoli has quit IRC | 19:38 | |
| mriedem | clenimar: i'm fine with a backdoor if it already exists i guess | 19:38 |
| *** tonytan4ever has quit IRC | 19:38 | |
| *** Sukhdev has quit IRC | 19:39 | |
| jroll | I'd rather api_endpoint didn't exist, I think, but I know there are ironic deployments without ironic in the catalog | 19:39 |
| jroll | then again, those folks could patch it back in | 19:39 |
| jroll | idk what typical nova policy is here | 19:39 |
| mriedem | sdague: ^ opinion there? | 19:40 |
| mriedem | on keeping a backdoor for ironic endpoint in nova.conf? | 19:40 |
| mriedem | or should we start making people use the ironic endpoint in the service catalog? | 19:40 |
| mriedem | would be a deprecation | 19:40 |
| *** haplo37__ has quit IRC | 19:41 | |
| mriedem | i'd ask jpenick but he's MIA | 19:41 |
| ildikov | alaski: do you mind if I add you to that review? | 19:42 |
| jroll | mriedem: I mean, I know it would screw over rackspace but I'm fine with that if it's the 'right' thing to do | 19:42 |
| alaski | ildikov: nope | 19:42 |
| mriedem | jroll: is rax using keystone v3 though? | 19:42 |
| jroll | but idk what's normal for nova | 19:42 |
| jroll | nop | 19:42 |
| *** baoli has joined #openstack-nova | 19:42 | |
| jroll | well, not internally | 19:42 |
| ildikov | alaski: cool, tnx! | 19:42 |
| mriedem | jroll: so i was originally thinking not using api_endpoint for v3, but use it for the legacy fallback that's using the other deprecated opts | 19:42 |
| jroll | mriedem: that seems reasonable | 19:43 |
| mriedem | hrm, keystone v2 is not deprecated | 19:43 |
| mriedem | seems kind of weird that we'd deprecate the ability to use keystone v2 with ironic in nova when keystone v2 itself isn't deprecated | 19:44 |
| mriedem | stevemar: ^ what's the story there? | 19:44 |
| jroll | dansmith: where do you see _refresh_cache mocked out? | 19:44 |
| jroll | mriedem: eh? ksa will detect to use v2 or v3 no? | 19:44 |
| mriedem | jroll: will it? | 19:44 |
| mriedem | if that's the case, then nevermind | 19:44 |
| clenimar | mriedem: keystone v2 was deprecated in mitaka | 19:45 |
| jroll | this is what I'm told | 19:45 |
| mriedem | http://developer.openstack.org/api-ref/identity/v2-admin/ | 19:45 |
| mriedem | http://developer.openstack.org/api-ref/identity/v2/ | 19:45 |
| jroll | we just made everything in ironic use ksa | 19:45 |
| jroll | so it better handle v2 :) | 19:45 |
| clenimar | jroll: it does | 19:45 |
| jroll | clenimar: okay, so this is only if ksa isn't configured with which plugin to use? | 19:46 |
| dansmith | jroll: refresh_hash_ring is | 19:46 |
| jroll | auth plugin* | 19:46 |
| mriedem | https://wiki.openstack.org/wiki/VersionDiscovery#status | 19:46 |
| mriedem | if keystone v2 is deprecated, it should be marked as such in the api ref | 19:46 |
| dansmith | jroll: still think we need unit tests for those separate from the rest, right? you're not validating that they behave properly even in the one test you have, AFAICT | 19:46 |
| *** ijw has joined #openstack-nova | 19:46 | |
| *** rama_y has quit IRC | 19:46 | |
| *** rama_y has joined #openstack-nova | 19:46 | |
| clenimar | mriedem: it is deprecated (http://docs.openstack.org/releasenotes/keystone/mitaka.html#deprecation-notes) | 19:47 |
| mriedem | [blueprint deprecated-as-of-mitaka] Deprecated all v2.0 APIs. The keystone team recommends using v3 APIs instead. Most v2.0 APIs will be removed in the ‘Q’ release. However, the authentication APIs and EC2 APIs are indefinitely deprecated and will not be removed in the ‘Q’ release. | 19:47 |
| openstackgerrit | Anusha Unnam proposed openstack/nova: Remove deprecated legacy_api config options https://review.openstack.org/351362 | 19:47 |
| mriedem | clenimar: someone should update the api-ref docs then | 19:47 |
| clenimar | mriedem: we've been migrating our docs from our repo... we might have missed this one | 19:47 |
| jroll | dansmith: yeah, we need tests for _refresh_hash_ring for sure, and they wouldn't hurt for _refresh_cache but I think I'm testing the single-compute behavior correctly | 19:47 |
| clenimar | going to fix it, thanks | 19:47 |
| * mriedem jumps to keystone channel | 19:47 | |
| jroll | dansmith: now I remember thinking 'this needs more tests' last time I changed it | 19:48 |
| *** shaohe_feng has quit IRC | 19:48 | |
| *** shaohe_feng has joined #openstack-nova | 19:48 | |
| dansmith | jroll: yeah, I guess you are, but we should have some unit tests for the multi case, like when we get back a real set of things from the service listing | 19:51 |
| *** syfy323_ has quit IRC | 19:51 | |
| jroll | dansmith: yeah, indeed | 19:51 |
| jroll | I'll hack some stuff out | 19:51 |
| clenimar | jroll: the way it is implemented, ksa tells what plugin to load from the config options under [ironic] in nova.conf. if it fails, there's a fallback. this way we're always creating a valid session and passing to ironicclient... | 19:51 |
| clenimar | ksa will always get the endpoint from the catalog | 19:52 |
| jroll | clenimar: right, that's what I thought. thanks! | 19:52 |
| clenimar | but it let you override it, if you want to | 19:52 |
| raj_singh | mriedem: Just want to confirm if this use case if even supported in Nova? https://bugs.launchpad.net/nova/+bug/1609193 | 19:52 |
| openstack | Launchpad bug 1609193 in OpenStack Compute (nova) "resize error on the same current host with enough vcpu resource" [Undecided,In progress] - Assigned to Maciej Szankin (mszankin) | 19:52 |
| *** syfy323 has joined #openstack-nova | 19:54 | |
| *** ayoung has joined #openstack-nova | 19:56 | |
| *** matrohon has joined #openstack-nova | 19:58 | |
| *** shaohe_feng has quit IRC | 19:58 | |
| *** vishwanathj has quit IRC | 19:59 | |
| *** shaohe_feng has joined #openstack-nova | 19:59 | |
| *** vishwanathj has joined #openstack-nova | 19:59 | |
| *** eharney has quit IRC | 20:02 | |
| *** moshele has joined #openstack-nova | 20:03 | |
| *** rama_y has quit IRC | 20:05 | |
| *** ametts has quit IRC | 20:05 | |
| *** zul has quit IRC | 20:05 | |
| *** rama_y has joined #openstack-nova | 20:05 | |
| *** shaohe_feng has quit IRC | 20:09 | |
| *** Apoorva has joined #openstack-nova | 20:10 | |
| *** Apoorva has quit IRC | 20:10 | |
| *** ametts has joined #openstack-nova | 20:10 | |
| *** Apoorva has joined #openstack-nova | 20:10 | |
| *** tblakes has quit IRC | 20:10 | |
| *** shaohe_feng has joined #openstack-nova | 20:11 | |
| *** rama_y has quit IRC | 20:11 | |
| *** ijw has quit IRC | 20:11 | |
| *** rama_y has joined #openstack-nova | 20:12 | |
| *** baoli has quit IRC | 20:13 | |
| *** markvoelker has quit IRC | 20:13 | |
| *** baoli has joined #openstack-nova | 20:14 | |
| *** vishwanathj has quit IRC | 20:14 | |
| *** vishwanathj has joined #openstack-nova | 20:14 | |
| mriedem | raj_singh: umm, they have 3 free vcpus on the host, they are trying to create a server with 4 vcpus, | 20:15 |
| mriedem | so it's going to fail | 20:15 |
| mriedem | they are thinking that because the vm already has 1 vcpu that it would just count 4-1 and fit the 3 available | 20:16 |
| mriedem | i'm not sure it's how that works though | 20:16 |
| mriedem | jaypipes (mr resource tracker) might know for sure | 20:17 |
| raj_singh | @mriedem: yea I understand but he was counting 1 vcpu that current instance has as a resource. But instance should not go to error? Just resize should fail, right? | 20:17 |
| *** eharney has joined #openstack-nova | 20:19 | |
| *** shaohe_feng has quit IRC | 20:19 | |
| *** shaohe_feng has joined #openstack-nova | 20:19 | |
| openstackgerrit | Jay Pipes proposed openstack/nova: rt: Remove useless unit test in resource tracker https://review.openstack.org/350756 | 20:26 |
| openstackgerrit | Jay Pipes proposed openstack/nova: rt: Move unit tests for update mig usage https://review.openstack.org/350757 | 20:26 |
| mriedem | raj_singh: what's probably happening is it's hitting ComputeResourcesUnavailable which triggers a reschedule, but since there is nowhere to reschedule to, it fails and is set to error | 20:26 |
| *** TravT has joined #openstack-nova | 20:27 | |
| *** edand has quit IRC | 20:27 | |
| clenimar | mriedem: imho leaving this api_endpoint thing to another patch seems more reasonable | 20:27 |
| mriedem | although i thought there was a size check on the dest before we try to resize | 20:27 |
| raj_singh | mriedem: yes that sounds like a bug | 20:27 |
| raj_singh | mriedem: thanks for the information | 20:28 |
| mriedem | a traceback for the failure would have been more helpful | 20:28 |
| mriedem | in case it's failing in prep_resize | 20:28 |
| *** ljxiash has joined #openstack-nova | 20:28 | |
| raj_singh | I will ask for log | 20:29 |
| raj_singh | s/log/logs | 20:29 |
| *** ihrachys has quit IRC | 20:29 | |
| *** shaohe_feng has quit IRC | 20:29 | |
| *** shaohe_feng has joined #openstack-nova | 20:30 | |
| *** catintheroof has joined #openstack-nova | 20:30 | |
| mriedem | yeah it gets into rt.resize_claim which does the claim test and raises the ComputeResourcesUnavailable exception | 20:31 |
| mriedem | which can't reschedule | 20:31 |
| mriedem | b/c it's resize to same host / single node | 20:31 |
| *** abalutoiu has joined #openstack-nova | 20:31 | |
| mriedem | and that all happens within a _error_out_instance_on_exception context manager | 20:31 |
| mriedem | so the instance is put in error state | 20:32 |
| mriedem | so i guess you'd have to handle ComputeResourcesUnavailable in _error_out_instance_on_exception and not set the instance to error state | 20:33 |
| *** lpetrut has quit IRC | 20:33 | |
| jaypipes | jroll: done | 20:33 |
| mriedem | clenimar: why? | 20:33 |
| jroll | jaypipes: ty | 20:33 |
| mriedem | clenimar: if you change nova to not use the api_endpoint option, and people were relying on it, then that's an upgrade issue | 20:33 |
| mriedem | clenimar: which is why i think in the very least you should pass api_endpoint to ksa in the legacy fallback case | 20:34 |
| *** ljxiash has quit IRC | 20:34 | |
| *** Jeffrey4l has quit IRC | 20:34 | |
| *** Jeffrey4l_ has joined #openstack-nova | 20:35 | |
| *** lpetrut has joined #openstack-nova | 20:35 | |
| *** abalutoiu_ has joined #openstack-nova | 20:37 | |
| *** vishwanathj has quit IRC | 20:38 | |
| *** vishwanathj has joined #openstack-nova | 20:39 | |
| *** abalutoiu has quit IRC | 20:39 | |
| *** shaohe_feng has quit IRC | 20:39 | |
| *** shaohe_feng has joined #openstack-nova | 20:40 | |
| *** vishwanathj has quit IRC | 20:40 | |
| *** hemanthm is now known as hemanthm|afk | 20:40 | |
| *** vishwanathj has joined #openstack-nova | 20:41 | |
| *** dimtruck is now known as zz_dimtruck | 20:42 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: WIP list instances from cell0, cell, and buildrequests https://review.openstack.org/351393 | 20:43 |
| mriedem | jaypipes: what are your thoughts on getting https://review.openstack.org/#/c/300177/ in today? | 20:43 |
| stewie925 | hello mriedem | 20:44 |
| *** smatzek_ has quit IRC | 20:44 | |
| jaypipes | mriedem: sure, lemme check your latest comments. | 20:44 |
| *** oomichi has joined #openstack-nova | 20:44 | |
| *** devkulkarni1 has quit IRC | 20:45 | |
| *** jdillaman has quit IRC | 20:46 | |
| mriedem | stewie925: hi | 20:46 |
| *** tonytan_brb has quit IRC | 20:48 | |
| raj_singh | mriedem: thank you for looking into it | 20:48 |
| jaypipes | mriedem: sorry, what do you mean by the compute API "local delete process"? | 20:48 |
| *** jdillaman has joined #openstack-nova | 20:48 | |
| mriedem | jaypipes: are you not familiar!? :) | 20:49 |
| mriedem | this will be a treat | 20:49 |
| stewie925 | oh hi mriedem: I am looking to help out with theremove-mox task - am wondering if there a list of the test modules to modify for this task? Am looking to do at least one for now - thank you | 20:50 |
| *** shaohe_feng has quit IRC | 20:50 | |
| mriedem | jaypipes: this stuff https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1610 | 20:50 |
| mriedem | jaypipes: if the nova-compute service hosting the instance is down, we do a "local delete" of stuff for the instance from the api | 20:50 |
| mriedem | since we can't get to the compute | 20:50 |
| *** zz_dimtruck is now known as dimtruck | 20:50 | |
| *** shaohe_feng has joined #openstack-nova | 20:51 | |
| mriedem | stewie925: that's frozen since last week for newton | 20:51 |
| mriedem | stewie925: https://wiki.openstack.org/wiki/Nova/Newton_Release_Schedule | 20:51 |
| stewie925 | I understand the window for Newton fixes has been closed, and future merges will be for the ocata cycle | 20:51 |
| mriedem | right | 20:51 |
| stewie925 | oh | 20:51 |
| *** cm876n has quit IRC | 20:52 | |
| stewie925 | ahh - was thinking that perhaps I could work on one and mark it as WIP until the ocata cycle is open (just thinking out loud hehe) | 20:52 |
| mriedem | stewie925: well you could, but there are already dozens of those open so it's really just merge conflict bait | 20:52 |
| *** devkulkarni1 has joined #openstack-nova | 20:53 | |
| mriedem | the config option cleanup stiff and api-ref cleanup is still ongoing as those are docs | 20:53 |
| jaypipes | mriedem: ugh. | 20:54 |
| mriedem | jaypipes: yeah. alaski and melwitt love that code. | 20:54 |
| mriedem | jaypipes: i'm not really sure why we couldn't delete the consumer allocations from the placement API via the local delete flow in the api though | 20:55 |
| alaski | the effing delete code is the bane of my existence these days | 20:55 |
| jaypipes | mriedem: I'll add some text to the spec that says the update_available_resource() periodic task on the resource tracker will essentially reconcile the placement API allocation records if it sees that an instance has been "locally deleted" and is still represented in the placement API as an allocation record. | 20:55 |
| jaypipes | mriedem: long term, we could do that, but it's just easier to consolidate th eplacement API calls within the resource tracker for Newton. | 20:56 |
| raj_singh | stewie925: Maybe you want to look into resolving some easy bugs | 20:56 |
| jroll | jaypipes: mriedem: you don't want to do it until you actually clean up the instance, right, because those resources will still be in use | 20:56 |
| stewie925 | hey raj_singh: that would be great | 20:57 |
| jaypipes | mriedem, alaski: also, any time I see SHELVED in any code, I cringe. | 20:57 |
| *** matrohon has quit IRC | 20:57 | |
| *** takashin has joined #openstack-nova | 20:57 | |
| jaypipes | jroll: right... | 20:57 |
| raj_singh | stewie925: https://bugs.launchpad.net/nova/+bugs?field.tag=low-hanging-fruit | 20:57 |
| stewie925 | just wondering how do we filter for the easy bugs - sometimes the 'low hanging fruit' tags arent as easy as we thought... | 20:57 |
| mriedem | jroll: good point | 20:57 |
| mriedem | jaypipes: ok, with that i'm +2 | 20:57 |
| stewie925 | hehe raj_singh | 20:58 |
| alaski | jaypipes: I feel complete and utter shame when seeing SHELVED | 20:58 |
| mriedem | stewie925: auggy might have some pointers if she's around | 20:58 |
| stewie925 | I'll go look into that, will give them a shot | 20:58 |
| mriedem | let's just deprecated shelve | 20:58 |
| mriedem | *deprecate | 20:58 |
| mriedem | we're deprecating everything else | 20:58 |
| Vek | alaski: sorta like me everytime a new race condition comes up in the quota code... | 20:58 |
| auggy | mriedem: stewie925: sure, let me check on the wiki to see if there's anything there that's not release dependent | 20:59 |
| stewie925 | thank you auggy! | 20:59 |
| mriedem | nova meeting in 1 minutes | 20:59 |
| mriedem | *minut | 20:59 |
| mriedem | damn | 20:59 |
| jroll | I get worried when I point things out to nova cores that aren't ironic things, I feel like I'm being sucked in | 20:59 |
| auggy | stewie925: not sure how familiar are you with the gate and elastic recheck? | 20:59 |
| *** rama_y has quit IRC | 20:59 | |
| jaypipes | mriedem: I'm adding some text to the spec, one sec. | 20:59 |
| alaski | Vek: heh | 20:59 |
| stewie925 | not yet quite - but I'll give it my best | 20:59 |
| stewie925 | auggy: I will do my best :) | 21:00 |
| *** shaohe_feng has quit IRC | 21:00 | |
| auggy | raj_singh: please don't recommend low hanging fruit bugs :) | 21:00 |
| *** rama_y has joined #openstack-nova | 21:00 | |
| mriedem | jroll: we're always looking to expand the core team you know... | 21:00 |
| *** shaohe_feng has joined #openstack-nova | 21:00 | |
| auggy | raj_singh: there is a list of tags that might be more appropriate for new folks, but low-hanging-fruit bugs simply aren't | 21:00 |
| raj_singh | auggy: :) I will keep that in mind | 21:00 |
| jroll | mriedem: this is where I run away screaming, right? | 21:00 |
| Vek | I think that's his point :) | 21:00 |
| *** ijw has joined #openstack-nova | 21:01 | |
| auggy | stewie925: feel free to look at any of the tags i have highlighted here for bugs: https://wiki.openstack.org/wiki/Nova/Mentoring#Picking_up_a_Bug | 21:02 |
| *** xinliang has quit IRC | 21:02 | |
| *** baoli_ has joined #openstack-nova | 21:02 | |
| stewie925 | thank you so much auggy | 21:02 |
| auggy | stewie925: remember to check with the team here in the nova channel before starting work, and try to only pick up anything that's been triaged. if it's been confirmed, just ask first | 21:03 |
| stewie925 | oh, thank you for the heads up | 21:03 |
| *** rtheis has quit IRC | 21:03 | |
| openstackgerrit | Jay Pipes proposed openstack/nova-specs: resource-providers: Populate allocation fields https://review.openstack.org/300177 | 21:04 |
| *** baoli has quit IRC | 21:04 | |
| jaypipes | mriedem: ^^ | 21:04 |
| *** ijw has quit IRC | 21:04 | |
| *** ijw has joined #openstack-nova | 21:04 | |
| auggy | stewie925: another thing you can do is to help with bug skimming - https://wiki.openstack.org/wiki/Meetings/Nova/BugsTeam | 21:05 |
| *** vishwanathj has quit IRC | 21:05 | |
| auggy | stewie925: you basically go through all the "new" bugs, read through them and either try to reproduce them or try to get more info from the reporter if there isn't enough information to reproduce them | 21:05 |
| *** vishwanathj has joined #openstack-nova | 21:06 | |
| auggy | if you can reproduce the bug, record how you did it and mark the bug as confirmed. Tag the bug according to the tags list. | 21:06 |
| stewie925 | thank you auggy! | 21:09 |
| stewie925 | I had been involved with the api-ref and config cleanup in the past weeks | 21:09 |
| *** thorst has quit IRC | 21:10 | |
| stewie925 | auggy: I'll look at these other tasks that you just shared - appreciate it! | 21:10 |
| auggy | stewie925: another thing that you can help with, if you feel comfortable is helping to debug elastic recheck failures - http://status.openstack.org/elastic-recheck/data/uncategorized.html | 21:10 |
| *** jwcroppe has quit IRC | 21:10 | |
| *** shaohe_feng has quit IRC | 21:10 | |
| auggy | right now we're at only 16% categorized, that should be *a lot* higher | 21:10 |
| *** shaohe_feng has joined #openstack-nova | 21:11 | |
| *** vishwanathj has quit IRC | 21:11 | |
| stewie925 | oooh - I'll look into that too | 21:11 |
| *** vishwanathj has joined #openstack-nova | 21:11 | |
| auggy | you can ask for help with that in #openstack-infra | 21:12 |
| auggy | and #openstack-qa | 21:12 |
| *** baoli_ has quit IRC | 21:12 | |
| auggy | some folks in here can probably help you too :) | 21:12 |
| *** baoli has joined #openstack-nova | 21:12 | |
| *** vishwanathj has quit IRC | 21:13 | |
| stewie925 | yeah :) thank you auggy! | 21:13 |
| *** vishwanathj has joined #openstack-nova | 21:13 | |
| stewie925 | and thanks to raj_singh and mriede too | 21:14 |
| *** TravT has quit IRC | 21:14 | |
| *** thorst has joined #openstack-nova | 21:15 | |
| *** jwcroppe has joined #openstack-nova | 21:15 | |
| *** jwcroppe has quit IRC | 21:15 | |
| *** mariusv has quit IRC | 21:16 | |
| *** vishwanathj has quit IRC | 21:16 | |
| *** vishwanathj has joined #openstack-nova | 21:16 | |
| *** baoli has quit IRC | 21:18 | |
| *** jwcroppe has joined #openstack-nova | 21:18 | |
| *** baoli has joined #openstack-nova | 21:18 | |
| *** mariusv has joined #openstack-nova | 21:18 | |
| *** mariusv has quit IRC | 21:18 | |
| *** mariusv has joined #openstack-nova | 21:18 | |
| *** Sukhdev has joined #openstack-nova | 21:18 | |
| *** eharney has quit IRC | 21:19 | |
| *** thorst has quit IRC | 21:19 | |
| *** shaohe_feng has quit IRC | 21:20 | |
| *** shaohe_feng has joined #openstack-nova | 21:21 | |
| *** jwcroppe has quit IRC | 21:23 | |
| *** vishwanathj has quit IRC | 21:24 | |
| *** vishwanathj has joined #openstack-nova | 21:24 | |
| *** shihanzhang has quit IRC | 21:25 | |
| *** shihanzhang has joined #openstack-nova | 21:25 | |
| *** baoli has quit IRC | 21:26 | |
| *** ametts has quit IRC | 21:26 | |
| *** amotoki has quit IRC | 21:27 | |
| *** takashin has left #openstack-nova | 21:28 | |
| mriedem | auggy: actually, http://status.openstack.org/elastic-recheck/data/uncategorized.html is kind of not very useful anymore | 21:28 |
| *** priteau has quit IRC | 21:28 | |
| mriedem | since it's a lot of stuff like | 21:29 |
| mriedem | gate-vitrage-dsvm-api : 1 Uncategorized Fails. 0.0% Classification Rate (1 Total Fails) | 21:29 |
| auggy | yeah i was under the impression it can take some digging | 21:29 |
| mriedem | we are pretty much not racy enough anymore | 21:29 |
| *** yamahata has quit IRC | 21:30 | |
| *** shaohe_feng has quit IRC | 21:31 | |
| *** devkulkarni2 has joined #openstack-nova | 21:31 | |
| *** devkulkarni1 has quit IRC | 21:31 | |
| *** shaohe_feng has joined #openstack-nova | 21:31 | |
| openstackgerrit | Clenimar Filemon proposed openstack/nova: Support Identity v3 when connecting to Ironic https://review.openstack.org/300154 | 21:32 |
| mriedem | hemna: does this fix that bug https://review.openstack.org/#/c/257853/ ? | 21:34 |
| hemna | I can test it | 21:36 |
| hemna | I'm guessing it would | 21:36 |
| *** dimtruck is now known as zz_dimtruck | 21:36 | |
| *** vishwanathj has quit IRC | 21:37 | |
| *** ijw has quit IRC | 21:37 | |
| *** vishwanathj has joined #openstack-nova | 21:37 | |
| *** vishwanathj has quit IRC | 21:38 | |
| mriedem | andrearosa: commented in https://review.openstack.org/#/c/257853/ | 21:38 |
| mriedem | andrearosa: we actually stash the connector in the bdm now | 21:38 |
| mriedem | it won't be there for old attached volumes before that change | 21:38 |
| hemna | mriedem, just tested it | 21:39 |
| *** vishwanathj has joined #openstack-nova | 21:39 | |
| mriedem | but it would there for new ones | 21:39 |
| hemna | and yes, that fixes it. | 21:39 |
| mriedem | hemna: ok, so maybe i'll update it with partial-bug and add a todo to check the bdm.connection_info['connector'] and if that's there, use it, else don't call terminate_connection | 21:39 |
| hemna | mriedem, +1 | 21:40 |
| mriedem | well or i just do that now | 21:40 |
| hemna | my attach happened when the instance was shelved | 21:40 |
| hemna | so I don't think there is a connector in the bdm then.... | 21:40 |
| *** ijw has joined #openstack-nova | 21:40 | |
| *** cdelatte has quit IRC | 21:41 | |
| *** shaohe_feng has quit IRC | 21:41 | |
| clenimar | mriedem: i gotta go now. thanks for the feedback :) | 21:41 |
| clenimar | g'night | 21:41 |
| *** shaohe_feng has joined #openstack-nova | 21:41 | |
| stewie925 | mriedem: thank you on sharing your thoughts on the elastic check - I will look at the bug skimming and easy bug fixes that auggy shared earlier | 21:42 |
| *** ayoung has quit IRC | 21:43 | |
| *** zz_dimtruck is now known as dimtruck | 21:43 | |
| *** ijw has quit IRC | 21:44 | |
| *** vishwanathj has quit IRC | 21:44 | |
| *** vishwanathj has joined #openstack-nova | 21:45 | |
| *** TravT has joined #openstack-nova | 21:45 | |
| *** cleong has quit IRC | 21:46 | |
| alaski | jaypipes: two small questions on https://review.openstack.org/#/c/300177 | 21:49 |
| *** yamahata has joined #openstack-nova | 21:49 | |
| *** devkulkarni1 has joined #openstack-nova | 21:49 | |
| *** devkulkarni2 has quit IRC | 21:49 | |
| *** vishwanathj has quit IRC | 21:49 | |
| *** vishwanathj has joined #openstack-nova | 21:50 | |
| *** shaohe_feng has quit IRC | 21:51 | |
| *** shaohe_feng has joined #openstack-nova | 21:52 | |
| jaypipes | alaski: answered :) | 21:52 |
| alaski | thanks | 21:53 |
| *** vishwanathj has quit IRC | 21:53 | |
| *** amotoki has joined #openstack-nova | 21:53 | |
| *** vishwanathj has joined #openstack-nova | 21:54 | |
| *** gabor_antal_ has quit IRC | 21:55 | |
| *** thorst has joined #openstack-nova | 21:56 | |
| openstackgerrit | Anusha Unnam proposed openstack/nova: Improve help text for upgrade_levels options https://review.openstack.org/329154 | 21:56 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs: Fix blueprints and specs link in ocata template https://review.openstack.org/335312 | 21:57 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs: Fix Newton approved specs list https://review.openstack.org/335306 | 21:57 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs: Check the destination host in cold migration https://review.openstack.org/334725 | 21:57 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs: Add swap volume notifications https://review.openstack.org/340715 | 21:57 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs: Enable cold migration with target host https://review.openstack.org/334286 | 21:57 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Stop using mox stubs in nova/tests/unit/virt/disk https://review.openstack.org/322778 | 21:57 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Stop using mox stubs in nova/tests/unit/cells https://review.openstack.org/323287 | 21:58 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Set 'serial' to new volume ID in swap volumes https://review.openstack.org/257135 | 21:58 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix wrong parameters in os-volumes.inc https://review.openstack.org/347112 | 21:58 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix 'id' (attachment_id) parameters https://review.openstack.org/349863 | 21:58 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Add a hacking rule for string interpolation at logging https://review.openstack.org/334844 | 21:58 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Parameter verification for os-simple-tenant-usage.inc https://review.openstack.org/333654 | 22:00 |
| *** jamesdenton has quit IRC | 22:01 | |
| *** shaohe_feng has quit IRC | 22:01 | |
| *** mdrabe has quit IRC | 22:02 | |
| *** shaohe_feng has joined #openstack-nova | 22:02 | |
| *** takashin has joined #openstack-nova | 22:02 | |
| *** thorst has quit IRC | 22:03 | |
| *** thorst has joined #openstack-nova | 22:05 | |
| *** thorst has quit IRC | 22:07 | |
| *** thorst has joined #openstack-nova | 22:08 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Use stashed volume connector in _local_cleanup_bdm_volumes https://review.openstack.org/257853 | 22:11 |
| *** rlrossit_ has quit IRC | 22:11 | |
| *** shaohe_feng has quit IRC | 22:12 | |
| *** shaohe_feng has joined #openstack-nova | 22:12 | |
| *** vishwanathj has quit IRC | 22:14 | |
| *** vishwanathj has joined #openstack-nova | 22:15 | |
| *** thorst has quit IRC | 22:16 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Use stashed volume connector in _local_cleanup_bdm_volumes https://review.openstack.org/257853 | 22:18 |
| mriedem | jaypipes: https://blueprints.launchpad.net/nova/+spec/resource-providers-allocations is all approved up | 22:19 |
| mriedem | good luck | 22:19 |
| *** ducttape_ has quit IRC | 22:20 | |
| *** mriedem has quit IRC | 22:21 | |
| *** xyang1 has quit IRC | 22:22 | |
| *** shaohe_feng has quit IRC | 22:22 | |
| *** shaohe_feng has joined #openstack-nova | 22:22 | |
| *** rrecio has quit IRC | 22:26 | |
| *** ayoung has joined #openstack-nova | 22:26 | |
| *** zul has joined #openstack-nova | 22:28 | |
| *** lpetrut has quit IRC | 22:32 | |
| *** shaohe_feng has quit IRC | 22:32 | |
| *** rfolco has quit IRC | 22:32 | |
| *** shaohe_feng has joined #openstack-nova | 22:32 | |
| *** ijw has joined #openstack-nova | 22:33 | |
| *** dimtruck is now known as zz_dimtruck | 22:34 | |
| *** pradk has quit IRC | 22:34 | |
| seldenr | melwitt: I still can't figure this out from earlier. The line `utils.do_action_on_many(action, [u'\u6d4b\u8bd5'], 'success %s', u'error')` does not produce a UnicodeError in the shell, though it does when novaclient calls it with the same arguments | 22:38 |
| *** edmondsw has quit IRC | 22:40 | |
| *** ijw has quit IRC | 22:40 | |
| melwitt | seldenr: by shell do you mean the python interactive shell? | 22:41 |
| *** shaohe_feng has quit IRC | 22:42 | |
| seldenr | yes but also that line in the tests passes melwitt | 22:42 |
| *** shaohe_feng has joined #openstack-nova | 22:45 | |
| melwitt | seldenr: is this python2? | 22:46 |
| melwitt | when I try it in python2 I get the error "'ascii' codec can't encode characters in position 8-9: ordinal not in range(128)" but in python3 I think it would work fine | 22:47 |
| seldenr | melwitt: yeah this is py2.7 | 22:48 |
| melwitt | hmm | 22:48 |
| melwitt | can you try this and see if it errors? http://paste.openstack.org/show/549314/ | 22:51 |
| seldenr | yep in python2? | 22:51 |
| melwitt | yes | 22:51 |
| *** sdague has quit IRC | 22:52 | |
| seldenr | melwitt: raises CommandError and prints the all familiar ascii not in 128 ord range | 22:52 |
| *** shaohe_feng has quit IRC | 22:53 | |
| *** shaohe_feng has joined #openstack-nova | 22:53 | |
| seldenr | melwitt: ohhh | 22:53 |
| seldenr | I see what's up | 22:53 |
| *** ijw has joined #openstack-nova | 22:56 | |
| melwitt | seldenr: what is it | 22:59 |
| *** ijw has quit IRC | 23:01 | |
| *** seldenr has quit IRC | 23:02 | |
| *** shaohe_feng has quit IRC | 23:03 | |
| *** shaohe_feng has joined #openstack-nova | 23:03 | |
| *** ayoung has quit IRC | 23:06 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova: Ironic: allow multiple compute services https://review.openstack.org/348443 | 23:07 |
| jroll | dansmith: a couple hours and lots of stupid mistakes later, I think that's well covered ^ | 23:07 |
| *** code-R has quit IRC | 23:07 | |
| dansmith | jroll: sorry :/ | 23:07 |
| jroll | dansmith: it's cool, gives me an excuse for beer | 23:07 |
| dansmith | well, judas priest kicked in as soon as I clicked on the link.. was kindof awesome | 23:08 |
| dansmith | heh | 23:08 |
| jroll | ha, nice | 23:08 |
| *** Swami has quit IRC | 23:09 | |
| *** ijw has joined #openstack-nova | 23:11 | |
| *** pwnall1 has quit IRC | 23:13 | |
| *** catintheroof has quit IRC | 23:13 | |
| *** shaohe_feng has quit IRC | 23:13 | |
| *** shaohe_feng has joined #openstack-nova | 23:14 | |
| *** code-R has joined #openstack-nova | 23:14 | |
| *** thorst has joined #openstack-nova | 23:15 | |
| *** ijw has quit IRC | 23:16 | |
| *** jaypipes has quit IRC | 23:18 | |
| *** code-R has quit IRC | 23:20 | |
| *** thorst has quit IRC | 23:22 | |
| cfriesen_ | anyone seen this? I've suddently started getting errors like this on mitaka when running tox: TypeError: this TransactionFactory is already started | 23:23 |
| *** shaohe_feng has quit IRC | 23:23 | |
| *** shaohe_feng has joined #openstack-nova | 23:24 | |
| *** markvoelker has joined #openstack-nova | 23:28 | |
| *** amotoki has quit IRC | 23:28 | |
| *** zz_dimtruck is now known as dimtruck | 23:30 | |
| *** jamielennox is now known as jamielennox|away | 23:30 | |
| *** ijw has joined #openstack-nova | 23:31 | |
| *** shaohe_feng has quit IRC | 23:34 | |
| *** shaohe_feng has joined #openstack-nova | 23:34 | |
| cfriesen_ | interestingly master branch seems okay | 23:36 |
| *** markvoelker_ has joined #openstack-nova | 23:37 | |
| *** hoangcx2 has joined #openstack-nova | 23:39 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Create Instance from BuildRequest if not in a cell https://review.openstack.org/263927 | 23:39 |
| openstackgerrit | Andrew Laski proposed openstack/nova: WIP list instances from cell0, cell, and buildrequests https://review.openstack.org/351393 | 23:39 |
| openstackgerrit | Andrew Laski proposed openstack/nova: instance.name should be blank if instance.id is not set https://review.openstack.org/327342 | 23:39 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Cells: Handle delete with BuildRequest https://review.openstack.org/325985 | 23:39 |
| *** hoangcx has quit IRC | 23:40 | |
| *** markvoelker has quit IRC | 23:41 | |
| *** jamielennox|away is now known as jamielennox | 23:41 | |
| *** ducttape_ has joined #openstack-nova | 23:41 | |
| *** Jeffrey4l_ has quit IRC | 23:42 | |
| *** shaohe_feng has quit IRC | 23:44 | |
| *** sameo has quit IRC | 23:44 | |
| *** sdake has joined #openstack-nova | 23:44 | |
| *** rrecio_ has joined #openstack-nova | 23:44 | |
| *** shaohe_feng has joined #openstack-nova | 23:44 | |
| *** EinstCrazy has joined #openstack-nova | 23:45 | |
| *** Jeffrey4l has joined #openstack-nova | 23:45 | |
| cfriesen_ | just confirmed again, current stable/mitaka with "tox -e py27 test_instance" gives me a whole bunch of "TypeError: this TransactionFactory is already started" errors. | 23:46 |
| *** catintheroof has joined #openstack-nova | 23:46 | |
| *** sdake_ has quit IRC | 23:46 | |
| *** devkulkarni1 has quit IRC | 23:49 | |
| *** rrecio_ has quit IRC | 23:49 | |
| *** devkulkarni1 has joined #openstack-nova | 23:49 | |
| jroll | dansmith: damn you, you found a bug | 23:49 |
| dansmith | I ... did? | 23:49 |
| jroll | fixed, thuogh | 23:49 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova: Ironic: allow multiple compute services https://review.openstack.org/348443 | 23:49 |
| *** rrecio has joined #openstack-nova | 23:50 | |
| jroll | yeah, I commented, those assertions were on __init__, not the one in _refresh_cache I meant to assert | 23:50 |
| dansmith | okay | 23:50 |
| dansmith | but you left the commented out code in there | 23:50 |
| dansmith | :) | 23:50 |
| jroll | hah | 23:51 |
| jroll | fixeded | 23:51 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova: Ironic: allow multiple compute services https://review.openstack.org/348443 | 23:51 |
| dansmith | cool, thanks | 23:52 |
| jroll | np, thank you | 23:52 |
| *** haplo37__ has joined #openstack-nova | 23:53 | |
| *** EinstCrazy has quit IRC | 23:53 | |
| *** lixiaoy1 has quit IRC | 23:54 | |
| *** shaohe_feng has quit IRC | 23:54 | |
| *** shaohe_feng has joined #openstack-nova | 23:54 | |
| *** ducttape_ has quit IRC | 23:56 | |
| *** thorst has joined #openstack-nova | 23:56 | |
| *** vishwanathj has quit IRC | 23:56 | |
| *** thorst has quit IRC | 23:57 | |
| *** thorst has joined #openstack-nova | 23:57 | |
| *** zul has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!