| *** dave-mccowan has quit IRC | 00:00 | |
| *** shaohe_feng has joined #openstack-nova | 00:01 | |
| *** unicell has quit IRC | 00:02 | |
| *** unicell has joined #openstack-nova | 00:02 | |
| *** bnemec has joined #openstack-nova | 00:03 | |
| *** rushil has quit IRC | 00:03 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify Scheduler RPC API select_dests() https://review.openstack.org/199205 | 00:07 |
|---|---|---|
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify conductor to use RequestSpec object https://review.openstack.org/203078 | 00:07 |
| *** bnemec has quit IRC | 00:10 | |
| *** artom has quit IRC | 00:10 | |
| *** achanda has quit IRC | 00:11 | |
| *** artom has joined #openstack-nova | 00:12 | |
| *** dave-mccowan has joined #openstack-nova | 00:14 | |
| *** andreykurilin__ has quit IRC | 00:15 | |
| *** mnestratov has quit IRC | 00:16 | |
| *** shaohe_feng has quit IRC | 00:17 | |
| *** shoutm has quit IRC | 00:18 | |
| *** armax has quit IRC | 00:20 | |
| *** shoutm has joined #openstack-nova | 00:21 | |
| *** unicell has left #openstack-nova | 00:21 | |
| *** armax has joined #openstack-nova | 00:22 | |
| *** unicell has joined #openstack-nova | 00:22 | |
| *** eglynn has quit IRC | 00:22 | |
| *** armax has quit IRC | 00:24 | |
| *** bnemec has joined #openstack-nova | 00:25 | |
| *** asettle has quit IRC | 00:28 | |
| *** dannywil_ has quit IRC | 00:28 | |
| *** salv-orl_ has quit IRC | 00:29 | |
| *** garyk1 has quit IRC | 00:30 | |
| *** dims has joined #openstack-nova | 00:30 | |
| *** bnemec has quit IRC | 00:30 | |
| *** shuquan has joined #openstack-nova | 00:31 | |
| *** rdopiera has quit IRC | 00:31 | |
| *** redbeard has joined #openstack-nova | 00:32 | |
| *** dave-mccowan has quit IRC | 00:37 | |
| *** thorst has joined #openstack-nova | 00:38 | |
| *** bnemec has joined #openstack-nova | 00:44 | |
| *** mriedem has joined #openstack-nova | 00:45 | |
| *** tpeoples has joined #openstack-nova | 00:46 | |
| *** achanda has joined #openstack-nova | 00:48 | |
| *** mdrabe has joined #openstack-nova | 00:48 | |
| *** tsekiyam_ has joined #openstack-nova | 00:49 | |
| openstackgerrit | Michael Still proposed openstack/nova: libvirt: take account of disks in migration data size https://review.openstack.org/206632 | 00:50 |
| openstackgerrit | Michael Still proposed openstack/nova: libvirt: add helper methods for getting guest devices/disks https://review.openstack.org/206631 | 00:50 |
| *** VikasC has joined #openstack-nova | 00:50 | |
| *** xyang1 has quit IRC | 00:51 | |
| *** VW_ has quit IRC | 00:51 | |
| *** VW_ has joined #openstack-nova | 00:52 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge used-limits functional tests of v2 and v2.1 https://review.openstack.org/174215 | 00:52 |
| *** eglynn has joined #openstack-nova | 00:53 | |
| *** tsekiyama has quit IRC | 00:53 | |
| *** shuquan has quit IRC | 00:53 | |
| *** mtanino has quit IRC | 00:53 | |
| *** tsekiyam_ has quit IRC | 00:53 | |
| *** eglynn has quit IRC | 00:54 | |
| mriedem | nice, the lxc stuff in libvirt.driver._create_domain_and_network is not even unit tested | 00:56 |
| mriedem | no wonder that stuff breaks | 00:56 |
| *** promulo__ has joined #openstack-nova | 00:57 | |
| *** VW_ has quit IRC | 00:57 | |
| *** VikasC has quit IRC | 00:57 | |
| mriedem | why don't we require CI for the lxc stuff if we're going to have it in tree? we require third party CI for the parallels stuff | 00:57 |
| *** tjones has left #openstack-nova | 00:57 | |
| *** vishwanathj has quit IRC | 00:58 | |
| *** dave-mccowan has joined #openstack-nova | 00:59 | |
| mriedem | apmelton: i'm gonna push a fix for https://bugs.launchpad.net/nova/+bug/1370590 quick | 00:59 |
| openstack | Launchpad bug 1370590 in OpenStack Compute (nova) "Libvirt _create_domain_and_network calls missing disk_info" [Medium,In progress] - Assigned to Andrew Melton (andrew-melton) | 00:59 |
| *** eliqiao_pc has joined #openstack-nova | 00:59 | |
| mriedem | more type conversions breaking stuff | 00:59 |
| *** Piet has quit IRC | 01:00 | |
| *** shyu has joined #openstack-nova | 01:00 | |
| *** promulo has quit IRC | 01:00 | |
| clarkb | mriedem it should be easyish to do that since lxc should perform much better than qemu on those VMs | 01:00 |
| clarkb | biggest problem is probably figuring out what tests to use as tempest likely will explode against lxc | 01:01 |
| mriedem | clarkb: yeah, and finding someone to actually get it setup and maintain it | 01:01 |
| openstackgerrit | ZhuChunzhan proposed openstack/nova: Improve the performance of get evacuated instances from a host which should be destroyed https://review.openstack.org/214555 | 01:01 |
| mriedem | at some point 3 midcycles ago rax was talking about doing that | 01:01 |
| mriedem | alaski: johnthetubaguy: do you remember or know of anything rax is planning about getting a CI job running with libvirt + lxc? | 01:02 |
| *** shaohe_feng has joined #openstack-nova | 01:02 | |
| mriedem | meanwhile, unit tests might help... | 01:02 |
| *** yanxb_ has joined #openstack-nova | 01:02 | |
| *** yanxb__ has quit IRC | 01:04 | |
| *** asettle has joined #openstack-nova | 01:05 | |
| *** eliqiao_pc has quit IRC | 01:06 | |
| *** browne has quit IRC | 01:06 | |
| *** baoli has joined #openstack-nova | 01:07 | |
| *** wanghua has joined #openstack-nova | 01:10 | |
| *** thorst has quit IRC | 01:10 | |
| *** shane-wang has joined #openstack-nova | 01:10 | |
| *** RuiChen has quit IRC | 01:11 | |
| *** diogogmt has joined #openstack-nova | 01:11 | |
| *** baoli has quit IRC | 01:12 | |
| *** haigang has joined #openstack-nova | 01:16 | |
| *** Vek has joined #openstack-nova | 01:20 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge limits functional tests of v2 and v2.1 https://review.openstack.org/214917 | 01:21 |
| openstackgerrit | wanghao proposed openstack/nova: Add nova-manage command for cleaning attachment https://review.openstack.org/184537 | 01:21 |
| gmann | alex_xu: johnthetubaguy : sdague : did you see https://review.openstack.org/#/c/174215/ | 01:21 |
| *** agireud has joined #openstack-nova | 01:22 | |
| gmann | alex_xu: johnthetubaguy : sdague : there is no RateLimitingMiddleware for v2.1 which make difference in v2 and v2.1 usedlimits and limits API | 01:22 |
| gmann | alex_xu: johnthetubaguy : sdague : rate limits are not populated on v2.1 side | 01:23 |
| *** RuiChen has joined #openstack-nova | 01:23 | |
| gmann | for limits API- https://review.openstack.org/#/c/214917/ | 01:24 |
| *** dims has quit IRC | 01:25 | |
| *** artom has quit IRC | 01:27 | |
| *** liusheng has joined #openstack-nova | 01:30 | |
| *** Apoorva has quit IRC | 01:30 | |
| *** vilobhmm1 has quit IRC | 01:33 | |
| openstackgerrit | wanghao proposed openstack/nova: Fix mistake in UT:test_detach_unattached_volume https://review.openstack.org/214920 | 01:35 |
| *** Apoorva has joined #openstack-nova | 01:39 | |
| *** shane-wang has quit IRC | 01:39 | |
| *** trpsbill has joined #openstack-nova | 01:40 | |
| mriedem | gmann: that's a known thing for awhile, see the api_rate_limit option | 01:43 |
| mriedem | http://docs.openstack.org/kilo/config-reference/content/list-of-compute-config-options.html | 01:43 |
| mriedem | "(BoolOpt) Whether to use per-user rate limiting for the api. This option is only used by v2 api. Rate limiting is removed from v3 api." | 01:44 |
| mriedem | i don't really know the history behind that though | 01:44 |
| *** liusheng has quit IRC | 01:45 | |
| *** lyanchih has joined #openstack-nova | 01:46 | |
| *** ctrath has joined #openstack-nova | 01:46 | |
| *** meghal has quit IRC | 01:48 | |
| gmann | mriedem: yea | 01:48 |
| gmann | mriedem: but not sure if we should introduced it in mivroversion or not as it is not really used (commit msg of https://review.openstack.org/#/c/115893/) | 01:49 |
| gmann | mriedem: as we cannot enable it in v2.1 which is already released | 01:50 |
| *** boris-42 has quit IRC | 01:50 | |
| mriedem | gmann: well, | 01:50 |
| mriedem | it's obviously not totally backwards compatible with v2 | 01:50 |
| mriedem | but it doesn't seem worth re-adding in a new microversion | 01:51 |
| gmann | mriedem: yea, same feeling here | 01:51 |
| mriedem | that help text on the api_rate_limit option has been around for a long time, probably since havana | 01:51 |
| gmann | mriedem: ok, then i think i should be fine as it is | 01:52 |
| *** ctrath has quit IRC | 01:52 | |
| gmann | mriedem: please check my reply on https://review.openstack.org/#/c/198944/ | 01:53 |
| *** haomaiwang has joined #openstack-nova | 01:53 | |
| gmann | mriedem: actually there was file structure change in master and kilo so did manually backport | 01:53 |
| *** agireud has quit IRC | 01:58 | |
| *** SourabhP has quit IRC | 01:59 | |
| *** agireud has joined #openstack-nova | 02:00 | |
| *** neiljerram_bb has quit IRC | 02:01 | |
| *** ctrath1 has joined #openstack-nova | 02:02 | |
| *** tpeoples has quit IRC | 02:02 | |
| mriedem | i'll have to check it tomorrow, about burned out for the night | 02:02 |
| *** shane-wang has joined #openstack-nova | 02:03 | |
| *** mdrabe has quit IRC | 02:07 | |
| *** baoli has joined #openstack-nova | 02:08 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: lxc: fix disk_info passed to _create_domain_and_network in _hard_reboot https://review.openstack.org/214925 | 02:09 |
| *** haomaiwang has quit IRC | 02:09 | |
| *** haomaiwang has joined #openstack-nova | 02:10 | |
| mriedem | apmelton: s1rp: ^ | 02:10 |
| mriedem | that should fix that lxc reboot bug | 02:10 |
| *** baoli has quit IRC | 02:12 | |
| mriedem | mikal: ^ for the bug there, we should have probably created a new bug rather than re-opening the old one that had a fix go into kilo | 02:15 |
| mriedem | since the regression was different and in liberty only | 02:15 |
| openstackgerrit | Rui Chen proposed openstack/nova: Set task_state=None when booting instance failed https://review.openstack.org/187145 | 02:16 |
| alex_xu | gmann: I think it is fine, it is optional in the v2. So the contract is user won't expect ratelimit also being here | 02:18 |
| gmann | mriedem: sure. Thanks | 02:18 |
| gmann | alex_xu: hummm. yea | 02:19 |
| openstackgerrit | Rui Chen proposed openstack/nova: Fix permission issue of server group API https://review.openstack.org/193117 | 02:20 |
| *** dims has joined #openstack-nova | 02:21 | |
| *** lyanchih has quit IRC | 02:21 | |
| openstackgerrit | Eli Qiao proposed openstack/nova: Correct expected error code for os-resetState action https://review.openstack.org/203930 | 02:21 |
| *** ctrath1 has quit IRC | 02:22 | |
| *** kumar has joined #openstack-nova | 02:23 | |
| *** unicell has quit IRC | 02:25 | |
| *** trpsbill has quit IRC | 02:26 | |
| *** trpsbill has joined #openstack-nova | 02:26 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: _create_domain_setup_lxc needs to default disk mapping as a dict https://review.openstack.org/214927 | 02:26 |
| *** trpsbill has quit IRC | 02:27 | |
| *** kumar has quit IRC | 02:28 | |
| *** trpsbill has joined #openstack-nova | 02:28 | |
| *** trpsbill has quit IRC | 02:28 | |
| *** dims has quit IRC | 02:29 | |
| *** dims has joined #openstack-nova | 02:30 | |
| *** shoutm_ has joined #openstack-nova | 02:30 | |
| *** otter768 has quit IRC | 02:30 | |
| *** shoutm has quit IRC | 02:31 | |
| *** shane-wang has quit IRC | 02:34 | |
| *** dims has quit IRC | 02:34 | |
| *** agireud has quit IRC | 02:35 | |
| *** shane-wang has joined #openstack-nova | 02:38 | |
| *** agireud has joined #openstack-nova | 02:43 | |
| *** bkopilov has quit IRC | 02:43 | |
| *** shane-wang1 has joined #openstack-nova | 02:43 | |
| *** mriedem has quit IRC | 02:44 | |
| *** salv-orlando has joined #openstack-nova | 02:44 | |
| *** markvoelker has quit IRC | 02:46 | |
| *** shane-wang has quit IRC | 02:47 | |
| *** shane-wang1 has quit IRC | 02:47 | |
| *** salv-orlando has quit IRC | 02:51 | |
| *** hakimo has joined #openstack-nova | 02:52 | |
| *** yamahata has quit IRC | 02:53 | |
| *** agireud has quit IRC | 02:53 | |
| *** hakimo_ has quit IRC | 02:54 | |
| *** salv-orlando has joined #openstack-nova | 02:55 | |
| *** Apoorva has quit IRC | 02:56 | |
| openstackgerrit | Fang Ji proposed openstack/nova: change qemu guest agent socket path https://review.openstack.org/214935 | 02:59 |
| *** diogogmt has quit IRC | 03:01 | |
| *** lyanchih has joined #openstack-nova | 03:01 | |
| *** salv-orlando has quit IRC | 03:02 | |
| *** otter768 has joined #openstack-nova | 03:02 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Remove merged sample tests and file for v2 tests https://review.openstack.org/214937 | 03:05 |
| *** shoutm has joined #openstack-nova | 03:06 | |
| *** y_sawai has joined #openstack-nova | 03:06 | |
| *** shoutm_ has quit IRC | 03:07 | |
| *** haomaiwang has quit IRC | 03:09 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Remove merged sample tests and file for v2 tests https://review.openstack.org/214937 | 03:10 |
| *** browne has joined #openstack-nova | 03:10 | |
| *** haomaiwang has joined #openstack-nova | 03:10 | |
| *** otter768 has quit IRC | 03:13 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Make query to quota usage table order preserved. https://review.openstack.org/213584 | 03:15 |
| *** armax has joined #openstack-nova | 03:15 | |
| openstackgerrit | wanghao proposed openstack/nova: Add nova-manage command for cleaning attachment https://review.openstack.org/184537 | 03:17 |
| *** y_sawai has quit IRC | 03:18 | |
| *** y_sawai has joined #openstack-nova | 03:19 | |
| *** agireud has joined #openstack-nova | 03:20 | |
| *** venkat_p has joined #openstack-nova | 03:23 | |
| *** baoli has joined #openstack-nova | 03:23 | |
| *** gibi has quit IRC | 03:24 | |
| *** gibi has joined #openstack-nova | 03:24 | |
| *** baoli has quit IRC | 03:28 | |
| *** y_sawai has quit IRC | 03:35 | |
| *** rushil has joined #openstack-nova | 03:36 | |
| *** Kennan2 is now known as Kennan | 03:36 | |
| openstackgerrit | wangxiyuan proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 03:37 |
| openstackgerrit | Eli Qiao proposed openstack/nova: Raise exception.Migration earlier in REST API layer https://review.openstack.org/214434 | 03:37 |
| *** VW_ has joined #openstack-nova | 03:38 | |
| *** tpeoples has joined #openstack-nova | 03:38 | |
| *** VW_ has quit IRC | 03:39 | |
| *** VW_ has joined #openstack-nova | 03:40 | |
| openstackgerrit | Rui Chen proposed openstack/nova: Fix incorrect result of host-describe https://review.openstack.org/211083 | 03:44 |
| *** rushil_ has joined #openstack-nova | 03:44 | |
| *** VW_ has quit IRC | 03:45 | |
| *** VW_ has joined #openstack-nova | 03:45 | |
| *** shane-wang has joined #openstack-nova | 03:45 | |
| *** rushil_ has quit IRC | 03:46 | |
| *** markvoelker has joined #openstack-nova | 03:46 | |
| *** rushil has quit IRC | 03:48 | |
| *** y_sawai has joined #openstack-nova | 03:48 | |
| *** VW_ has quit IRC | 03:50 | |
| *** lpetrut has joined #openstack-nova | 03:51 | |
| *** markvoelker has quit IRC | 03:51 | |
| *** RuiChen has quit IRC | 03:55 | |
| *** RuiChen has joined #openstack-nova | 03:55 | |
| *** y_sawai has quit IRC | 03:56 | |
| *** shoutm_ has joined #openstack-nova | 04:00 | |
| *** gibi has quit IRC | 04:00 | |
| *** gibi has joined #openstack-nova | 04:00 | |
| *** shoutm has quit IRC | 04:01 | |
| *** RuiChen has quit IRC | 04:04 | |
| *** achanda has quit IRC | 04:05 | |
| *** y_sawai has joined #openstack-nova | 04:06 | |
| *** irenab has quit IRC | 04:09 | |
| *** haomaiwang has quit IRC | 04:09 | |
| *** haomaiwang has joined #openstack-nova | 04:10 | |
| *** irenab has joined #openstack-nova | 04:11 | |
| *** Nikolay_St has quit IRC | 04:21 | |
| *** dave-mccowan has quit IRC | 04:22 | |
| *** lyanchih has quit IRC | 04:22 | |
| *** chhavi_ has joined #openstack-nova | 04:23 | |
| *** baoli has joined #openstack-nova | 04:24 | |
| *** baoli has quit IRC | 04:29 | |
| *** unicell has joined #openstack-nova | 04:30 | |
| *** bkopilov has joined #openstack-nova | 04:30 | |
| *** lpetrut has quit IRC | 04:31 | |
| *** fawadkhaliq has joined #openstack-nova | 04:32 | |
| *** salv-orlando has joined #openstack-nova | 04:32 | |
| *** agireud has quit IRC | 04:33 | |
| *** agireud has joined #openstack-nova | 04:35 | |
| *** salv-orlando has quit IRC | 04:35 | |
| *** shaohe_feng has quit IRC | 04:37 | |
| *** deray_ has joined #openstack-nova | 04:40 | |
| *** deray_ has left #openstack-nova | 04:40 | |
| *** tpeoples has quit IRC | 04:42 | |
| *** lyanchih has joined #openstack-nova | 04:42 | |
| *** Sukhdev has joined #openstack-nova | 04:43 | |
| openstackgerrit | Man Li Qi proposed openstack/nova: (WIP)Filter instance query result for DB who doesn't support regex https://review.openstack.org/130174 | 04:43 |
| *** salv-orlando has joined #openstack-nova | 04:47 | |
| *** Sukhdev has quit IRC | 04:47 | |
| *** salv-orlando has quit IRC | 04:51 | |
| *** huats has quit IRC | 04:55 | |
| *** Sree has joined #openstack-nova | 04:58 | |
| *** Sukhdev has joined #openstack-nova | 04:58 | |
| *** zul has quit IRC | 05:04 | |
| *** Jeffrey4l|afk has quit IRC | 05:05 | |
| *** Sree has quit IRC | 05:06 | |
| *** achanda has joined #openstack-nova | 05:07 | |
| *** afazekas has joined #openstack-nova | 05:08 | |
| *** haomaiwang has quit IRC | 05:09 | |
| *** danieru has quit IRC | 05:10 | |
| *** y_sawai has quit IRC | 05:10 | |
| *** haomaiwang has joined #openstack-nova | 05:10 | |
| *** Jeffrey4l|afk has joined #openstack-nova | 05:12 | |
| *** otter768 has joined #openstack-nova | 05:14 | |
| *** haigang has quit IRC | 05:14 | |
| *** afazekas has quit IRC | 05:15 | |
| *** jasonpan has left #openstack-nova | 05:16 | |
| *** chhavi__ has joined #openstack-nova | 05:16 | |
| *** jasonpan has joined #openstack-nova | 05:16 | |
| *** shane-wang has quit IRC | 05:17 | |
| jasonpan | test | 05:18 |
| *** chhavi_ has quit IRC | 05:18 | |
| *** emagana has joined #openstack-nova | 05:18 | |
| *** kiran-r has joined #openstack-nova | 05:18 | |
| *** haomaiwang has quit IRC | 05:19 | |
| *** otter768 has quit IRC | 05:19 | |
| jasonpan | kiran-r: Hi | 05:19 |
| kiran-r | jasonpan: Hi | 05:19 |
| kiran-r | jasonpan: Good morning! | 05:19 |
| jasonpan | kiran-r: Good afternoon! | 05:20 |
| jasonpan | kiran-r: did your problem solve? | 05:21 |
| *** irenab has quit IRC | 05:21 | |
| kiran-r | jasonpan: Yes I did. Thanks! I added an NFS share and solved it. :) | 05:21 |
| kiran-r | jasonpan: I am curious about other alternatives rather than NFS. | 05:25 |
| kiran-r | jasonpan: I am curious about other alternatives rather than having a shared storage, How about block live migration? | 05:25 |
| *** Sukhdev has quit IRC | 05:26 | |
| jasonpan | kiran-r: hmmm... I haven't tested using block live migration before. | 05:27 |
| *** RuiChen has joined #openstack-nova | 05:28 | |
| jasonpan | kiran-r: In manuals, block live mirgration is "No share storage required" | 05:30 |
| *** irenab has joined #openstack-nova | 05:32 | |
| *** Marga_ has joined #openstack-nova | 05:38 | |
| kiran-r | jasonpan: Thats I want to try that out :) | 05:39 |
| *** tpeoples has joined #openstack-nova | 05:41 | |
| *** agireud has quit IRC | 05:47 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify Scheduler RPC API select_dests() https://review.openstack.org/199205 | 05:50 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Consider that all scheduler calls are IO Ops https://review.openstack.org/188486 | 05:50 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Use RequestSpec object in the FilterScheduler https://review.openstack.org/188487 | 05:50 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Prepare filters for using RequestSpec object https://review.openstack.org/197912 | 05:50 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify left filters for RequestSpec https://review.openstack.org/202678 | 05:50 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify conductor to use RequestSpec object https://review.openstack.org/203078 | 05:50 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify metric-related filters for RequestSpec https://review.openstack.org/202676 | 05:50 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Use RequestSpec in the ChanceScheduler https://review.openstack.org/199051 | 05:50 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify NUMA, PCI and num_instances filters for RequestSpec https://review.openstack.org/202677 | 05:50 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify Aggregate filters for RequestSpec https://review.openstack.org/202674 | 05:50 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify default filters for RequestSpec https://review.openstack.org/202675 | 05:50 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add RequestSpec methods for primitiving into dicts https://review.openstack.org/187197 | 05:50 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify Affinity filter for RequestSpec https://review.openstack.org/202673 | 05:50 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Use RequestSpec object in HostManager https://review.openstack.org/191251 | 05:50 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Use the same pci_requests field for all filters and HostManager https://review.openstack.org/191250 | 05:50 |
| *** danieru has joined #openstack-nova | 05:52 | |
| *** nkrinner has joined #openstack-nova | 05:52 | |
| *** shoutm_ has quit IRC | 05:52 | |
| *** y_sawai has joined #openstack-nova | 05:54 | |
| *** chhavi__ has quit IRC | 05:54 | |
| *** kiran-r has quit IRC | 05:59 | |
| *** exploreshaifali has joined #openstack-nova | 05:59 | |
| *** haomaiwa_ has joined #openstack-nova | 06:00 | |
| *** armax has quit IRC | 06:00 | |
| *** y_sawai has quit IRC | 06:00 | |
| *** chhavi__ has joined #openstack-nova | 06:04 | |
| *** unicell1 has joined #openstack-nova | 06:04 | |
| *** salv-orlando has joined #openstack-nova | 06:05 | |
| *** y_sawai has joined #openstack-nova | 06:05 | |
| *** unicell has quit IRC | 06:05 | |
| *** shoutm has joined #openstack-nova | 06:07 | |
| *** VW_ has joined #openstack-nova | 06:09 | |
| *** asettle has quit IRC | 06:09 | |
| *** haomaiwa_ has quit IRC | 06:09 | |
| *** haomaiwang has joined #openstack-nova | 06:13 | |
| *** ajayaa has joined #openstack-nova | 06:14 | |
| *** yanxb has joined #openstack-nova | 06:15 | |
| *** salv-orlando has quit IRC | 06:16 | |
| *** haomaiwang has quit IRC | 06:17 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 06:18 |
| *** VW_ has quit IRC | 06:21 | |
| *** afazekas has joined #openstack-nova | 06:21 | |
| *** VW_ has joined #openstack-nova | 06:21 | |
| *** jichen has joined #openstack-nova | 06:23 | |
| *** ankit_ag has joined #openstack-nova | 06:24 | |
| *** shuquan has joined #openstack-nova | 06:25 | |
| *** Murali has joined #openstack-nova | 06:26 | |
| *** Sree has joined #openstack-nova | 06:27 | |
| jasonpan | bauzas: Hi bauzas, I have some question of the bug #1452568 | 06:28 |
| openstack | bug 1452568 in OpenStack Compute (nova) "nova allows to live-migrate instance from one availability zone to another" [Low,Confirmed] https://launchpad.net/bugs/1452568 - Assigned to Sylvain Bauza (sylvain-bauza) | 06:28 |
| *** haomaiwang has joined #openstack-nova | 06:29 | |
| *** shuquan has quit IRC | 06:30 | |
| *** salv-orlando has joined #openstack-nova | 06:32 | |
| *** shaohe_feng has joined #openstack-nova | 06:32 | |
| *** Sree has quit IRC | 06:33 | |
| jasonpan | bauzas: modify the database availability zone I think it is needed, but not allows instance from one availability zone to another I don't think it is needed. What do you think about it? | 06:36 |
| *** haigang has joined #openstack-nova | 06:37 | |
| *** jichen has quit IRC | 06:37 | |
| *** exploreshaifali has quit IRC | 06:37 | |
| *** afazekas has quit IRC | 06:37 | |
| *** ajayaa has quit IRC | 06:37 | |
| *** tpeoples has quit IRC | 06:44 | |
| *** fawadkhaliq has quit IRC | 06:45 | |
| *** y_sawai has quit IRC | 06:45 | |
| *** y_sawai has joined #openstack-nova | 06:47 | |
| *** haomaiwang has quit IRC | 06:47 | |
| *** moshele has joined #openstack-nova | 06:48 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex https://review.openstack.org/212367 | 06:49 |
| *** ajayaa has joined #openstack-nova | 06:50 | |
| *** haomaiwang has joined #openstack-nova | 06:52 | |
| *** scheuran has joined #openstack-nova | 06:52 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 06:53 |
| *** y_sawai has quit IRC | 06:57 | |
| *** browne has quit IRC | 06:59 | |
| *** Nikolay_St has joined #openstack-nova | 06:59 | |
| *** VikasC has joined #openstack-nova | 07:00 | |
| *** achanda has quit IRC | 07:00 | |
| *** ishant has joined #openstack-nova | 07:06 | |
| *** y_sawai has joined #openstack-nova | 07:07 | |
| *** ssurana has quit IRC | 07:07 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Cleanup for merging v2 and v2.1 functional tests. https://review.openstack.org/214985 | 07:08 |
| *** haomaiwang has quit IRC | 07:09 | |
| *** fawadkhaliq has joined #openstack-nova | 07:09 | |
| *** haomaiwang has joined #openstack-nova | 07:10 | |
| *** shane-wang has joined #openstack-nova | 07:13 | |
| *** otter768 has joined #openstack-nova | 07:15 | |
| *** Nikolay_St has quit IRC | 07:16 | |
| *** nkrinner has quit IRC | 07:17 | |
| openstackgerrit | wanghao proposed openstack/nova: Image&block device mapping combination isn't valid https://review.openstack.org/171984 | 07:17 |
| *** exploreshaifali has joined #openstack-nova | 07:17 | |
| *** claudiub has joined #openstack-nova | 07:19 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/214991 | 07:19 |
| *** otter768 has quit IRC | 07:19 | |
| *** cfriesen has quit IRC | 07:20 | |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Remove/deprecate conductor instance_update() https://review.openstack.org/189155 | 07:20 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Make compute manager instance updates use objects https://review.openstack.org/189154 | 07:20 |
| *** shane-wang has quit IRC | 07:21 | |
| *** nkrinner has joined #openstack-nova | 07:21 | |
| *** Murali_ has joined #openstack-nova | 07:23 | |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Add a VolumeUsage object https://review.openstack.org/180442 | 07:23 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Replace conductor proxying calls with the new VolumeUsage object https://review.openstack.org/180443 | 07:23 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Remove and deprecate unused conductor method vol_usage_update() https://review.openstack.org/180444 | 07:23 |
| *** Nikolay_St has joined #openstack-nova | 07:24 | |
| *** jasonpan has quit IRC | 07:24 | |
| *** atuvenie has joined #openstack-nova | 07:24 | |
| *** Murali has quit IRC | 07:25 | |
| *** Murali_ is now known as Murali | 07:25 | |
| *** romainh has joined #openstack-nova | 07:26 | |
| *** exploreshaifali has quit IRC | 07:26 | |
| *** exploreshaifali has joined #openstack-nova | 07:26 | |
| *** SourabhP has joined #openstack-nova | 07:26 | |
| *** jasonpan has joined #openstack-nova | 07:28 | |
| *** SourabhP_ has joined #openstack-nova | 07:29 | |
| *** Murali has quit IRC | 07:30 | |
| *** Murali_ has joined #openstack-nova | 07:30 | |
| *** Murali_ is now known as Murali | 07:30 | |
| *** SourabhP has quit IRC | 07:32 | |
| *** SourabhP_ is now known as SourabhP | 07:32 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Remove merged sample tests and file for v2 tests https://review.openstack.org/214937 | 07:37 |
| *** salv-orlando has quit IRC | 07:40 | |
| *** jcoufal has joined #openstack-nova | 07:41 | |
| *** alexschm has joined #openstack-nova | 07:42 | |
| *** SourabhP has quit IRC | 07:44 | |
| *** markvoelker has joined #openstack-nova | 07:48 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge server list multi status tests between v2 and v2.1 https://review.openstack.org/201387 | 07:49 |
| *** IanGovett has joined #openstack-nova | 07:51 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge server list multi status tests between v2 and v2.1 https://review.openstack.org/201387 | 07:52 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge block_device_mapping boot tests between v2 and v2.1 https://review.openstack.org/201401 | 07:53 |
| *** markvoelker has quit IRC | 07:53 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge virtual interface tests between v2 and v2.1 https://review.openstack.org/197811 | 07:53 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge flavor all_extensions tests between v2 and v2.1 https://review.openstack.org/201430 | 07:53 |
| *** markus_z has joined #openstack-nova | 07:53 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Fix link's href to consider osapi_compute_link_prefix https://review.openstack.org/207702 | 07:53 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Move "versions" functional tests in v2.1 tests https://review.openstack.org/201439 | 07:54 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge used-limits functional tests of v2 and v2.1 https://review.openstack.org/174215 | 07:54 |
| *** shyama has quit IRC | 07:54 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge limits functional tests of v2 and v2.1 https://review.openstack.org/214917 | 07:54 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Remove merged sample tests and file for v2 tests https://review.openstack.org/214937 | 07:54 |
| *** shyama has joined #openstack-nova | 07:55 | |
| *** alexschm has quit IRC | 07:55 | |
| *** salv-orlando has joined #openstack-nova | 07:55 | |
| *** y_sawai has quit IRC | 07:59 | |
| *** yamahata has joined #openstack-nova | 08:00 | |
| *** derekh has joined #openstack-nova | 08:08 | |
| *** yassine has joined #openstack-nova | 08:09 | |
| *** haomaiwang has quit IRC | 08:09 | |
| *** alexschm has joined #openstack-nova | 08:10 | |
| *** lucasagomes has joined #openstack-nova | 08:10 | |
| *** haomaiwa_ has joined #openstack-nova | 08:10 | |
| *** shuquan has joined #openstack-nova | 08:12 | |
| *** afazekas has joined #openstack-nova | 08:18 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Make query to quota usage table order preserved. https://review.openstack.org/213584 | 08:19 |
| *** asettle has joined #openstack-nova | 08:19 | |
| *** RuiChen has quit IRC | 08:21 | |
| *** lyanchih has quit IRC | 08:22 | |
| *** shuquan has quit IRC | 08:22 | |
| *** lyanchih has joined #openstack-nova | 08:23 | |
| *** agireud has joined #openstack-nova | 08:23 | |
| *** fawadkhaliq has quit IRC | 08:23 | |
| *** asettle has quit IRC | 08:24 | |
| *** fawadkhaliq has joined #openstack-nova | 08:26 | |
| *** bharath_ has joined #openstack-nova | 08:28 | |
| *** jistr has joined #openstack-nova | 08:28 | |
| *** shoutm has quit IRC | 08:29 | |
| *** exploreshaifali has quit IRC | 08:30 | |
| *** chhavi__ has quit IRC | 08:30 | |
| *** agireud has quit IRC | 08:33 | |
| *** sayali has quit IRC | 08:35 | |
| *** SourabhP has joined #openstack-nova | 08:35 | |
| *** lalit has quit IRC | 08:36 | |
| *** VW_ has quit IRC | 08:36 | |
| *** huats has joined #openstack-nova | 08:36 | |
| *** VW_ has joined #openstack-nova | 08:36 | |
| *** sayali has joined #openstack-nova | 08:37 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Fix remote_consoles miveroversion 2.8 not to run on /v3 https://review.openstack.org/215015 | 08:38 |
| *** VW_ has quit IRC | 08:40 | |
| *** huats has quit IRC | 08:41 | |
| *** aix has joined #openstack-nova | 08:41 | |
| *** scheuran has quit IRC | 08:44 | |
| *** shoutm has joined #openstack-nova | 08:44 | |
| johnthetubaguy | alex_xu: gmann: it would be good to catch up quick if you folks are still around? | 08:44 |
| gmann | johnthetubaguy: hi good morning | 08:45 |
| openstackgerrit | John Garbutt proposed openstack/nova: Remove the useless require_admin_context decorator https://review.openstack.org/200382 | 08:45 |
| *** apuimedo has joined #openstack-nova | 08:46 | |
| johnthetubaguy | gmann: hi, I was really just wondering how its all going | 08:46 |
| *** huats has joined #openstack-nova | 08:46 | |
| johnthetubaguy | gmann: I uploaded some stuff around the paste.ini and deprecating the extensions | 08:47 |
| gmann | johnthetubaguy: yea, I am almost done for merging the tests stuff, i will put your paste.ini patch on top of those | 08:47 |
| gmann | johnthetubaguy: but i did not get chance to look on metadata validation stuff. ll look tomorrow | 08:48 |
| johnthetubaguy | gmann: OK, I think I have it working apart from the tempest tests, well almost | 08:49 |
| gmann | johnthetubaguy: ok. for functional tests we can confirm by putting that on https://review.openstack.org/#/c/214985/ | 08:51 |
| gmann | where all functional tests moved to run on /v2 and /v2.1 instead of /v3 | 08:52 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Cleanup for merging v2 and v2.1 functional tests. https://review.openstack.org/214985 | 08:52 |
| *** aagrawal has joined #openstack-nova | 08:52 | |
| *** jichen has joined #openstack-nova | 08:53 | |
| johnthetubaguy | gmann: I really don't need all those changes to make this stuff pass | 08:53 |
| *** shoutm has quit IRC | 08:54 | |
| *** shoutm has joined #openstack-nova | 08:55 | |
| *** ankit_ag has quit IRC | 08:55 | |
| gmann | johnthetubaguy: but functional tests failure are there which needs those changes | 08:57 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Fix scheduler code to use monitor metric objects https://review.openstack.org/213317 | 08:57 |
| johnthetubaguy | gmann: only needs some of them it seems, I only have a handful of failures, stuff like this: https://review.openstack.org/#/c/215015/1 | 08:58 |
| johnthetubaguy | although I can't make that one work actually, which is confusing | 08:59 |
| *** VikasC has quit IRC | 08:59 | |
| *** alexschm has quit IRC | 08:59 | |
| *** markus_z has quit IRC | 08:59 | |
| gmann | johnthetubaguy: yea one is https://review.openstack.org/213317 needed | 09:00 |
| johnthetubaguy | gmann: these are the current failures: http://logs.openstack.org/85/214085/6/check/gate-nova-tox-functional/ff79a6a/console.html | 09:00 |
| *** jamie_h has joined #openstack-nova | 09:02 | |
| tobasco | when i boot a instance i also get assigned a ipv6 local address like fe80::xxxxxxxxxxxx/64, would setting use_ipv6=False cause these to not be assigned or how can i solve that? | 09:04 |
| gmann | johnthetubaguy: x-server-management-url are due to tests using /v3 | 09:05 |
| johnthetubaguy | gmann: agreed | 09:05 |
| * alex_xu try to catch the context | 09:05 | |
| *** SourabhP has quit IRC | 09:05 | |
| tobasco | we dont have ipv6 yet and when looking up domains that has a AAAA record it tries to use ipv6 | 09:05 |
| *** abhishekk has joined #openstack-nova | 09:06 | |
| gmann | johnthetubaguy: i am running those locally on test merge changes. lets see the result | 09:06 |
| johnthetubaguy | tobasco: please ask in #openstack for operating advice, the folks over there might have seen this issue before, sounds a bit like a networking configuration thing | 09:06 |
| johnthetubaguy | gmann: OK, cool | 09:07 |
| *** ociuhandu has quit IRC | 09:07 | |
| tobasco | johnthetubaguy: ok, was just curious if the use_ipv6 in nova.conf would be the key, but sure i will | 09:07 |
| johnthetubaguy | tobasco: it depends on your networking stack in use, I suspect, the other folks should be able to help with that | 09:08 |
| alex_xu | gmann: are you working strip the extra params out? | 09:08 |
| *** fawadkhaliq has quit IRC | 09:08 | |
| alex_xu | s/working/working on/ | 09:08 |
| openstackgerrit | John Garbutt proposed openstack/nova: api: tidy up paste.ini https://review.openstack.org/214085 | 09:08 |
| gmann | alex_xu: not yet. was doing test merge stuff | 09:09 |
| *** PrabAsh has joined #openstack-nova | 09:09 | |
| *** haomaiwa_ has quit IRC | 09:09 | |
| alex_xu | gmann: ok, let me know if you need help | 09:09 |
| *** haomaiwang has joined #openstack-nova | 09:10 | |
| *** apuimedo is now known as apuimedo|away | 09:10 | |
| PrabAsh | Can openstack migrate VM instances automatically to another node if one of the compute node goes down ? | 09:10 |
| *** shaohe_feng has quit IRC | 09:10 | |
| gmann | alex_xu: I will start tomorrow and we can discuss that. or if you have some idea you can give a try because i have to look into those yet | 09:10 |
| *** alexschm has joined #openstack-nova | 09:11 | |
| alex_xu | gmann: I didn't take look at into detail yet, but I can take a look at, then let discussion tomorrow | 09:12 |
| gmann | alex_xu: +1 perfect. | 09:12 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Switch to oslo.cache lib https://review.openstack.org/203049 | 09:13 |
| openstackgerrit | John Garbutt proposed openstack/nova: api: tidy up paste.ini https://review.openstack.org/214085 | 09:15 |
| *** shoutm has quit IRC | 09:15 | |
| *** otter768 has joined #openstack-nova | 09:16 | |
| gmann | johnthetubaguy: it passing except extension tests | 09:17 |
| gmann | remote console and usedlimit works fine | 09:17 |
| johnthetubaguy | gmann: OK, interesting, I just have a fix for that I think | 09:17 |
| gmann | johnthetubaguy: ohk | 09:18 |
| *** markus_z has joined #openstack-nova | 09:18 | |
| johnthetubaguy | gmann: https://review.openstack.org/#/c/214085/8/nova/tests/functional/test_extensions.py,cm | 09:19 |
| *** jistr has quit IRC | 09:19 | |
| johnthetubaguy | gmann: but on my change, I can't get this one to pass: https://review.openstack.org/#/c/214085/8/nova/tests/functional/api_sample_tests/test_remote_consoles.py,cm I keep getting a 400 error? | 09:20 |
| *** unicell1 has quit IRC | 09:20 | |
| johnthetubaguy | its like its pointed at the legacy mode or something | 09:20 |
| *** otter768 has quit IRC | 09:20 | |
| *** jistr has joined #openstack-nova | 09:20 | |
| *** bharath_ has left #openstack-nova | 09:22 | |
| gmann | those are passed but test_extension_info still fail with your fix | 09:22 |
| *** tbh has joined #openstack-nova | 09:23 | |
| *** unicell has joined #openstack-nova | 09:23 | |
| tbh | Hi johnthetubaguy, is this bp still valid case https://blueprints.launchpad.net/nova/+spec/os-hypervisors-ipaddress ? | 09:23 |
| *** y_sawai has joined #openstack-nova | 09:24 | |
| johnthetubaguy | tbh: I think its fine, but it needs a spec submitting for the mitaka release, with all the API change details listed | 09:25 |
| johnthetubaguy | gmann: whats the error you see? | 09:25 |
| gmann | johnthetubaguy: its 404 for v2 get_extension | 09:25 |
| johnthetubaguy | gmann: yeah, thats what the change fixed on my branch, odd | 09:26 |
| johnthetubaguy | gmann: do you have all these fixes your branch? https://review.openstack.org/#/c/214085/8/nova/tests/functional/api_paste_fixture.py,cm | 09:27 |
| tbh | johnthetubaguy: okay, I will try to figure out that | 09:27 |
| gmann | johnthetubaguy: not those. | 09:27 |
| gmann | johnthetubaguy: let me see again | 09:28 |
| johnthetubaguy | tbh: let me know if that doesn't make sense, there are some more details on the process here: https://wiki.openstack.org/wiki/Nova/Liberty_Release_Schedule#How_do_I_get_my_code_merged.3F | 09:29 |
| johnthetubaguy | gmann: https://review.openstack.org/#/c/214085/8/nova/tests/functional/api_sample_tests/legacy_v2/api_samples_test_base.py,cm and https://review.openstack.org/#/c/214085/8/nova/tests/functional/api_sample_tests/api_sample_base.py,cm might also be importnat | 09:29 |
| gmann | johnthetubaguy: i had /v2 on paste.ini just checking for /v3 removal from it | 09:29 |
| gmann | johnthetubaguy: yea | 09:30 |
| johnthetubaguy | gmann: I am still not sure we have all the things tested quite correctly after my change, its a bit confusing | 09:31 |
| tbh | johnthetubaguy: I am thinking like, I will send host_ip from nova-api, and then I will test all the other api calls | 09:31 |
| tbh | is that the correct way? | 09:32 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Implements detach_interface method https://review.openstack.org/214493 | 09:32 |
| *** yamahata has quit IRC | 09:32 | |
| gmann | johnthetubaguy: for me too. may be it will clear if we make your changes on top of test merge one and see whats left? | 09:33 |
| johnthetubaguy | tbh: not sure I understand, sounds like you want to add host_ip into one of the existing API calls, you need to submit a patch to this repo (via gerrit) to add the spec: https://github.com/openstack/nova-specs | 09:33 |
| johnthetubaguy | gmann: there are more details here: http://docs.openstack.org/infra/manual/developers.html#working-on-specifications-and-blueprints | 09:34 |
| johnthetubaguy | gmann: possibly | 09:34 |
| johnthetubaguy | gmann: feels like we need some kind of coverage check, ideally | 09:34 |
| gmann | johnthetubaguy: hummm | 09:35 |
| tbh | johnthetubaguy: yeah | 09:35 |
| johnthetubaguy | gmann: I don't get why the tests are posting to /v2 with microversions attached, that seems very odd | 09:38 |
| gmann | johnthetubaguy: that actually goes for v21 through api fixture | 09:38 |
| gmann | johnthetubaguy: we can make it on /v2 and /v2.1 separately for v2 tests and v2.1 and microversion one resp | 09:40 |
| johnthetubaguy | gmann: I think that would be better, run the base version on /v2 and /v2.1 then microversions only on /v2.1 | 09:40 |
| *** gszasz has joined #openstack-nova | 09:40 | |
| johnthetubaguy | gmann: but anyways, I am still confused with my 400 error | 09:41 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Implements detach_interface method https://review.openstack.org/214493 | 09:41 |
| gmann | johnthetubaguy: ok | 09:41 |
| gmann | johnthetubaguy: microversion runs only for v21 Router not for v2 | 09:41 |
| *** y_sawai has quit IRC | 09:42 | |
| gmann | but used /v2 which is being fixtured to "/v2: openstack_compute_api_v21" | 09:42 |
| johnthetubaguy | gmann: yeah thats the really confusing bit | 09:42 |
| johnthetubaguy | gmann: its not a configuration we would ever want anyone to run in production | 09:43 |
| gmann | johnthetubaguy: yea, i will give try to make those clear, microversion on .v2.1 without any fixture thing | 09:43 |
| johnthetubaguy | gmann: will need the fixture thing to test legacy_v2 code, after my paste.ini changes remove that | 09:43 |
| gmann | johnthetubaguy: ahh i remember now. actually issue is with version in url which is going to be in sample files link | 09:44 |
| johnthetubaguy | gmann: given we need to test: v2_legacy, v2.1 in legacy compat mode, v2.1 base | 09:44 |
| johnthetubaguy | gmann: oh dear | 09:44 |
| gmann | johnthetubaguy: thats why we run all on /v2 and make fixture for v2.1 and microversion to avoid different sample files | 09:44 |
| alex_xu | not sure the context, just note the current sample tests run on legacy compat mode also | 09:45 |
| gmann | johnthetubaguy: alex_xu: yea | 09:46 |
| gmann | we do run all tests for all those 3 - v2_legacy, v2.1 in legacy compat mode, v2.1 base | 09:46 |
| johnthetubaguy | yeah, just being sure not to break that | 09:46 |
| gmann | johnthetubaguy: not sure why you get 400 for remote console tests :). | 09:48 |
| johnthetubaguy | gmann: so in my enviroment ConsolesV28SampleJsonTests needs the extra line: extra_extensions_to_load = ["os-access-ips"] | 09:48 |
| johnthetubaguy | foudn it | 09:48 |
| openstackgerrit | John Garbutt proposed openstack/nova: api: tidy up paste.ini https://review.openstack.org/214085 | 09:49 |
| *** markvoelker has joined #openstack-nova | 09:49 | |
| gmann | johnthetubaguy: ahhh , for v21 os-access-ips is separate extension | 09:49 |
| *** sudipto has joined #openstack-nova | 09:50 | |
| johnthetubaguy | so with that, am I going for my first coffee of the day, that explains why my brain is going slowly | 09:50 |
| gmann | johnthetubaguy: i put that in base class in https://review.openstack.org/#/c/214985/ | 09:51 |
| *** aix has quit IRC | 09:51 | |
| johnthetubaguy | gmann: makes sense | 09:51 |
| johnthetubaguy | gmann: this is just really a hack so I can find out how far away we are really, the tempest tests are the big issue I feel | 09:52 |
| gmann | johnthetubaguy: :) yea | 09:52 |
| johnthetubaguy | gmann: alex_xu: I put up these hacked up changes, in case its useful: https://review.openstack.org/#/q/topic:bp/nova-api-deprecate-extensions,n,z | 09:52 |
| gmann | johnthetubaguy: most of changes are there on tests merge thing. do you want to put your changes dependent on those or those are lot more as dependent? | 09:53 |
| *** markvoelker has quit IRC | 09:54 | |
| *** romainh has quit IRC | 09:54 | |
| johnthetubaguy | gmann: I think its best not to merge those for now, thinking about it | 09:55 |
| johnthetubaguy | gmann: mine can just say on its own while we work out what to do with those tempest failures | 09:55 |
| gmann | johnthetubaguy: ok. sounds good. | 09:56 |
| *** dims has joined #openstack-nova | 09:56 | |
| johnthetubaguy | alex_xu: that v3 enable setting is still used in the v2.1 API router :( | 09:57 |
| alex_xu | johnthetubaguy: :( | 09:58 |
| *** fawadkhaliq has joined #openstack-nova | 09:58 | |
| alex_xu | johnthetubaguy: but it is ok for deprecate | 09:58 |
| *** jasonpan has quit IRC | 10:00 | |
| johnthetubaguy | alex_xu: yeah, we have to deprecate configs before we can remove them (as we want people to be able to upgrade without changing their config from the last release) | 10:02 |
| alex_xu | johnthetubaguy: just one more comment for the log msg | 10:02 |
| *** Kennan2 has joined #openstack-nova | 10:03 | |
| * alex_xu can stop the baby cry~... | 10:03 | |
| johnthetubaguy | alex_xu: yeah, the log messages could be a lot better! | 10:03 |
| *** Kennan has quit IRC | 10:04 | |
| gmann | johnthetubaguy: need fixture for v2_legacy tests - https://review.openstack.org/#/c/214085/9/nova/tests/functional/api_sample_tests/api_sample_base.py | 10:04 |
| johnthetubaguy | gmann: my api-paste.ini defaults to /v2 having v2.1 in legacy mode, so its not needed | 10:06 |
| johnthetubaguy | gmann: I had to add a new fixture to move /v2 to run the legacy v2 code base | 10:06 |
| *** ociuhandu has joined #openstack-nova | 10:06 | |
| johnthetubaguy | gmann: oh, I think I see what you mean now | 10:06 |
| gmann | johnthetubaguy: yea for later one i think you did | 10:07 |
| gmann | ok | 10:07 |
| gmann | johnthetubaguy: ApiPasteV2CompatibleFixture may be you want to rename it | 10:07 |
| gmann | for v2_legacy now | 10:07 |
| johnthetubaguy | gmann: I have already done that: https://review.openstack.org/#/c/214085/9/nova/tests/functional/api_paste_fixture.py,cm | 10:08 |
| johnthetubaguy | gmann: so I agree :) | 10:08 |
| gmann | yea | 10:08 |
| gmann | johnthetubaguy: ahh i see :) | 10:09 |
| *** haomaiwang has quit IRC | 10:09 | |
| johnthetubaguy | gmann: I kinda want the diff to show that stuff deleted, but yeah, it doesn't | 10:09 |
| *** haomaiwang has joined #openstack-nova | 10:10 | |
| *** fawadkhaliq has quit IRC | 10:13 | |
| johnthetubaguy | gmann: cools, thanks for those, good spot there, I will wait to see what jenkins says, then update that from your comments | 10:13 |
| gmann | johnthetubaguy: ok | 10:13 |
| openstackgerrit | Simona Iuliana Toader proposed openstack/nova: Hyper-V: Adds Hyper-V UEFI Secure Boot https://review.openstack.org/209581 | 10:13 |
| openstackgerrit | Simona Iuliana Toader proposed openstack/nova: Hyper-V: refactors utilsfactory https://review.openstack.org/214527 | 10:13 |
| *** markus_z has quit IRC | 10:15 | |
| *** lyanchih has quit IRC | 10:16 | |
| openstackgerrit | John Garbutt proposed openstack/nova: api: deprecate the concept of extensions in v2.1 https://review.openstack.org/214592 | 10:18 |
| *** PrabAsh has quit IRC | 10:20 | |
| *** ftersin_ has joined #openstack-nova | 10:20 | |
| *** mnestratov has joined #openstack-nova | 10:23 | |
| *** atuvenie has quit IRC | 10:24 | |
| openstackgerrit | John Garbutt proposed openstack/nova: api: deprecate the api v2 extension configuration https://review.openstack.org/214601 | 10:25 |
| johnthetubaguy | alex_xu: gmann: I updated those two patches, added a slightly better log message for the first one | 10:25 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Fix scheduler code to use monitor metric objects https://review.openstack.org/213317 | 10:27 |
| alex_xu | johnthetubaguy: cool, will check again after i get baby sleep success... | 10:32 |
| *** xgsa has quit IRC | 10:33 | |
| openstackgerrit | Simona Iuliana Toader proposed openstack/nova: Hyper-V: Adds Hyper-V UEFI Secure Boot https://review.openstack.org/209581 | 10:36 |
| openstackgerrit | Simona Iuliana Toader proposed openstack/nova: Hyper-V: refactors utilsfactory https://review.openstack.org/214527 | 10:36 |
| *** fawadkhaliq has joined #openstack-nova | 10:38 | |
| gmann | johnthetubaguy: looks good, just 1 suggestion if that make sense | 10:38 |
| *** lpetrut has joined #openstack-nova | 10:38 | |
| *** xgsa has joined #openstack-nova | 10:39 | |
| johnthetubaguy | gmann: thats cool, will take a look in a bit. | 10:47 |
| *** haomaiwang has quit IRC | 10:48 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Switch to oslo.cache lib https://review.openstack.org/203049 | 10:51 |
| *** shaohe_feng has joined #openstack-nova | 10:53 | |
| *** shuquan has joined #openstack-nova | 10:53 | |
| *** sudipto has quit IRC | 10:55 | |
| *** sudipto has joined #openstack-nova | 10:56 | |
| abhishekk | snikitin: hi you around? | 10:56 |
| openstackgerrit | wanghao proposed openstack/nova: Add nova-manage command for cleaning attachment https://review.openstack.org/184537 | 10:56 |
| *** unicell1 has joined #openstack-nova | 10:57 | |
| *** unicell has quit IRC | 10:58 | |
| *** shuquan has quit IRC | 10:58 | |
| *** mwagner_lap has quit IRC | 11:01 | |
| *** unicell1 has quit IRC | 11:04 | |
| *** alex_klimov has joined #openstack-nova | 11:04 | |
| *** unicell has joined #openstack-nova | 11:04 | |
| *** apuimedo|away is now known as apuimedo | 11:04 | |
| *** ftersin_ has quit IRC | 11:06 | |
| alex_xu | johnthetubaguy: sdague we add new status but without microversions in this patch https://review.openstack.org/#/c/212065/6 is it ok? | 11:07 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Cleanup for merging v2 and v2.1 functional tests. https://review.openstack.org/214985 | 11:10 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: cleanup NovaObjectDictCompat from quota https://review.openstack.org/215078 | 11:13 |
| *** unicell has quit IRC | 11:13 | |
| *** unicell has joined #openstack-nova | 11:13 | |
| *** jamie_h has quit IRC | 11:14 | |
| *** dims has quit IRC | 11:15 | |
| *** dims has joined #openstack-nova | 11:16 | |
| *** aix has joined #openstack-nova | 11:16 | |
| *** shaohe_feng has quit IRC | 11:17 | |
| *** otter768 has joined #openstack-nova | 11:17 | |
| *** takedakn has joined #openstack-nova | 11:18 | |
| johnthetubaguy | alex_xu: I thought we said that is not OK | 11:18 |
| johnthetubaguy | alex_xu: not sure I see how that returns a new status though | 11:20 |
| *** dims has quit IRC | 11:20 | |
| alex_xu | johnthetubaguy: the 'queued' status is new | 11:21 |
| johnthetubaguy | alex_xu: ah, thats in the migration, I guess we do have an API to list those now | 11:22 |
| *** smatzek has joined #openstack-nova | 11:22 | |
| *** otter768 has quit IRC | 11:22 | |
| alex_xu | johnthetubaguy: yea. https://github.com/openstack/nova/blob/master/doc/api_samples/os-migrations/migrations-get.json | 11:22 |
| johnthetubaguy | alex_xu: that migration stuff needs sorting out with constants, etc, so its all more obvious | 11:22 |
| alex_xu | johnthetubaguy: yea | 11:23 |
| alex_xu | johnthetubaguy: so what we can do, revert it? | 11:23 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/214991 | 11:24 |
| *** baoli has joined #openstack-nova | 11:25 | |
| johnthetubaguy | alex_xu: we can, I would send an email to the approvers | 11:27 |
| openstackgerrit | jichenjc proposed openstack/nova: Prevent build more than one default ephemeral disk https://review.openstack.org/213762 | 11:27 |
| johnthetubaguy | (and author) | 11:27 |
| *** exploreshaifali has joined #openstack-nova | 11:29 | |
| alex_xu | johnthetubaguy: ok | 11:29 |
| *** baoli has quit IRC | 11:30 | |
| *** markus_z has joined #openstack-nova | 11:30 | |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: cleanup NovaObjectDictCompat from hv_spec https://review.openstack.org/215094 | 11:31 |
| *** ftersin_ has joined #openstack-nova | 11:31 | |
| *** scheuran has joined #openstack-nova | 11:32 | |
| gmann | johnthetubaguy: just commentd on paste.ini patch failure | 11:32 |
| *** dims has joined #openstack-nova | 11:33 | |
| *** dprince has joined #openstack-nova | 11:35 | |
| *** mhorban has quit IRC | 11:35 | |
| *** markvoelker has joined #openstack-nova | 11:35 | |
| *** Murali has quit IRC | 11:35 | |
| *** mhorban has joined #openstack-nova | 11:36 | |
| *** lucasagomes is now known as lucas-hungry | 11:37 | |
| tbh | johnthetubaguy: This is the spec I have written now https://paste.kde.org/p9fammubr, I tried to issue git review, but I got network unreachable error | 11:39 |
| *** takedakn has quit IRC | 11:39 | |
| *** markvoelker has quit IRC | 11:40 | |
| tbh | johnthetubaguy: I just added ssh key, may be it takes time to reflect | 11:40 |
| *** Marga_ has quit IRC | 11:42 | |
| *** alexschm has quit IRC | 11:42 | |
| *** Marga_ has joined #openstack-nova | 11:42 | |
| *** bkopilov has quit IRC | 11:42 | |
| *** rajesht has joined #openstack-nova | 11:42 | |
| johnthetubaguy | tbh: it sounds like you are behind a firewall, but I am not 100% sure | 11:43 |
| *** thorst has joined #openstack-nova | 11:43 | |
| *** alexschm has joined #openstack-nova | 11:43 | |
| openstackgerrit | jichenjc proposed openstack/nova: conductor: update comments for rpc and use object https://review.openstack.org/185068 | 11:45 |
| *** snikitin has joined #openstack-nova | 11:45 | |
| *** salv-orlando has quit IRC | 11:45 | |
| snikitin | dims: Dims, could you look at https://review.openstack.org/#/c/203049/ ? I added using of memcached in service groups | 11:46 |
| *** afazekas has quit IRC | 11:46 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Revert "Limit parallel live migrations in progress" https://review.openstack.org/215100 | 11:46 |
| dims | snikitin: do we add new configuration options? would need a DocImpact tag | 11:47 |
| snikitin | dims: ok. I'll add | 11:47 |
| *** dansmith has quit IRC | 11:47 | |
| alex_xu | johnthetubaguy: ^ | 11:47 |
| dims | snikitin: thanks | 11:48 |
| *** dansmith has joined #openstack-nova | 11:48 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Switch to oslo.cache lib https://review.openstack.org/203049 | 11:48 |
| *** dansmith is now known as Guest95328 | 11:48 | |
| *** romainh has joined #openstack-nova | 11:49 | |
| snikitin | dims: Done | 11:49 |
| dims | snikitin: i am not happy about having to do the set_default in https://review.openstack.org/#/c/203049/10/nova/utils.py,cm | 11:49 |
| dims | snikitin: can you please talk to stevemar and bknudson to see if there's a better wat | 11:49 |
| dims | way | 11:49 |
| dims | snikitin: you can start by logging a bug and ping them when they come online in a few hours please | 11:50 |
| snikitin | dims: Ok, thank you | 11:50 |
| dims | snikitin: thanks for the hard work, it's coming along nicely | 11:52 |
| openstackgerrit | Alexander Schmidt proposed openstack/nova: libvirt: enable live migration with serial console https://review.openstack.org/191035 | 11:52 |
| openstackgerrit | Alexander Schmidt proposed openstack/nova: libvirt: reallocate TCP ports for serial console during live migration https://review.openstack.org/215102 | 11:52 |
| openstackgerrit | Marian Horban proposed openstack/nova: Added processing /compute URL https://review.openstack.org/195303 | 11:53 |
| *** kolesovdv has joined #openstack-nova | 11:53 | |
| snikitin | dims: Hope we merge it soon :) | 11:53 |
| dims | snikitin: please add a better commit message with details on the changes made | 11:53 |
| snikitin | dims: Ok, I'll add | 11:54 |
| *** VikasC has joined #openstack-nova | 11:54 | |
| dims | thanks snikitin! | 11:54 |
| snikitin | dims: thanks for review! | 11:55 |
| openstackgerrit | Alexander Schmidt proposed openstack/nova: WIP libvirt: Acquire TCP ports for console during live migration https://review.openstack.org/215102 | 11:55 |
| *** atuvenie has joined #openstack-nova | 11:55 | |
| *** emagana has quit IRC | 11:56 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Share server POST sample file for microversion too https://review.openstack.org/215104 | 11:58 |
| *** lpetrut has quit IRC | 12:02 | |
| jaypipes | mikal, alaski, Vek, other cores: rajesht's patch here: https://review.openstack.org/#/c/212374/ looks good to go now. reviews welcome. | 12:03 |
| *** derekh is now known as derekh_afk | 12:03 | |
| rajesht | jaypipes: t | 12:04 |
| rajesht | jaypipes: Thanks :) | 12:04 |
| jaypipes | rajesht: of course, no worries :) | 12:06 |
| rajesht | jaypipes: I would request you to review dependent patch as well, if you have time :) | 12:07 |
| *** b3nt_pin is now known as beagles | 12:07 | |
| jaypipes | rajesht: yup, it's on the queue :) | 12:08 |
| rajesht | jaypipes: thanks a lot :) | 12:08 |
| *** venkat_p has quit IRC | 12:09 | |
| *** salv-orlando has joined #openstack-nova | 12:11 | |
| *** shyu has quit IRC | 12:16 | |
| *** lpetrut has joined #openstack-nova | 12:17 | |
| *** haigang has quit IRC | 12:18 | |
| *** erlon has joined #openstack-nova | 12:19 | |
| *** takedakn has joined #openstack-nova | 12:20 | |
| *** burgerk has joined #openstack-nova | 12:21 | |
| *** asettle has joined #openstack-nova | 12:22 | |
| *** edmondsw has joined #openstack-nova | 12:23 | |
| *** asettle has quit IRC | 12:23 | |
| *** fawadkhaliq has quit IRC | 12:24 | |
| *** aysyd has joined #openstack-nova | 12:24 | |
| *** VikasC has quit IRC | 12:28 | |
| *** ociuhandu_ has joined #openstack-nova | 12:32 | |
| *** emagana has joined #openstack-nova | 12:32 | |
| *** ociuhandu has quit IRC | 12:33 | |
| *** ociuhandu_ is now known as ociuhandu | 12:33 | |
| *** unicell1 has joined #openstack-nova | 12:34 | |
| tbh | johnthetubaguy: still I have connectivity issue, I think you are correct | 12:34 |
| tbh | tbh: once the spec got approved, I will assign bp to myself | 12:34 |
| *** unicell has quit IRC | 12:34 | |
| *** signed8bit has joined #openstack-nova | 12:36 | |
| *** exploreshaifali has quit IRC | 12:37 | |
| *** mwagner_lap has joined #openstack-nova | 12:37 | |
| *** lpetrut has quit IRC | 12:39 | |
| *** markvoelker has joined #openstack-nova | 12:39 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: WIP: Hyper-V: determine vm_com_pipe error during spawn https://review.openstack.org/213720 | 12:41 |
| alex_xu | anyone know Anne Genttle in which timezone? | 12:42 |
| *** mriedem has joined #openstack-nova | 12:42 | |
| johnthetubaguy | alex_xu: central, she is in austin texas I think | 12:43 |
| alex_xu | johnthetubaguy: thanks | 12:44 |
| alex_xu | emm... I guess need waiting for more few hours | 12:46 |
| *** lucas-hungry is now known as lucasagomes | 12:48 | |
| *** garyk has joined #openstack-nova | 12:49 | |
| *** mriedem has quit IRC | 12:49 | |
| *** VW_ has joined #openstack-nova | 12:49 | |
| *** annegentle has joined #openstack-nova | 12:50 | |
| *** mriedem has joined #openstack-nova | 12:51 | |
| *** dave-mccowan has joined #openstack-nova | 12:52 | |
| *** jistr is now known as jistr|mtg | 12:53 | |
| *** aix has quit IRC | 12:54 | |
| *** signed8bit is now known as signed8bit_ZZZzz | 12:55 | |
| *** emagana has quit IRC | 12:57 | |
| openstackgerrit | wanghao proposed openstack/nova: Add nova-manage command for cleaning attachment https://review.openstack.org/184537 | 12:57 |
| mriedem | has the xenproject ci gone off the rails? | 12:57 |
| mriedem | oh awesome we have a new 500 in the gate | 12:59 |
| mriedem | + neutron | 12:59 |
| *** lpetrut has joined #openstack-nova | 12:59 | |
| *** aix has joined #openstack-nova | 13:00 | |
| *** signed8bit_ZZZzz is now known as signed8bit | 13:00 | |
| *** wanghua has quit IRC | 13:00 | |
| *** rlrossit has joined #openstack-nova | 13:00 | |
| *** burgerk has quit IRC | 13:02 | |
| alaski | mriedem: I'm not aware of any rax plans for libvirt + lxc CI. but the containers folks are hidden away in a room somewhere and communicate with the outside world much afaict. I can try to send a telegram or something to see if they've discussed it | 13:04 |
| alaski | *don't communicate | 13:04 |
| mriedem | smoke signals | 13:04 |
| mriedem | carrier pigeon | 13:04 |
| *** VW_ has quit IRC | 13:05 | |
| mriedem | there are still remote uncontacted tribes living in the amazon rainforest you konw | 13:05 |
| alaski | I saw a sign for someone selling homing pigeons about a week ago. I seriously considered stopping in | 13:06 |
| *** tbh has quit IRC | 13:06 | |
| mriedem | ha | 13:06 |
| mriedem | makes a great gift | 13:06 |
| *** dustins has joined #openstack-nova | 13:07 | |
| alaski | heh | 13:07 |
| *** hhuang has quit IRC | 13:07 | |
| *** VW_ has joined #openstack-nova | 13:08 | |
| *** jecarey has joined #openstack-nova | 13:08 | |
| *** raildo-afk is now known as raildo | 13:10 | |
| *** VW_ has quit IRC | 13:14 | |
| *** ijuwang has joined #openstack-nova | 13:14 | |
| *** VW_ has joined #openstack-nova | 13:15 | |
| *** bkopilov has joined #openstack-nova | 13:15 | |
| *** rfolco has joined #openstack-nova | 13:15 | |
| *** otter768 has joined #openstack-nova | 13:18 | |
| *** ajayaa has quit IRC | 13:18 | |
| *** krtaylor has quit IRC | 13:18 | |
| *** VW_ has quit IRC | 13:19 | |
| *** ishant has quit IRC | 13:21 | |
| *** aagrawal has quit IRC | 13:22 | |
| *** wanghua has joined #openstack-nova | 13:22 | |
| *** otter768 has quit IRC | 13:23 | |
| alex_xu | annegentle: hi, are you around? | 13:24 |
| *** fawadkhaliq has joined #openstack-nova | 13:24 | |
| *** xyang1 has joined #openstack-nova | 13:25 | |
| *** dustins has quit IRC | 13:26 | |
| *** dustins has joined #openstack-nova | 13:26 | |
| *** fawadkhaliq has quit IRC | 13:28 | |
| *** jamielennox is now known as jamielennox|away | 13:30 | |
| *** zul has joined #openstack-nova | 13:30 | |
| *** krtaylor has joined #openstack-nova | 13:31 | |
| *** abhishekk has quit IRC | 13:32 | |
| mriedem | rlrossit: https://bugs.launchpad.net/nova/+bug/1487038 | 13:35 |
| openstack | Launchpad bug 1487038 in OpenStack Compute (nova) "nova.exception._cleanse_dict should use oslo_utils.strutils._SANITIZE_KEYS" [Low,Confirmed] | 13:35 |
| mriedem | do it | 13:35 |
| mriedem | :) | 13:35 |
| *** dims_ has joined #openstack-nova | 13:35 | |
| rlrossit | mriedem: I'll take it, but I'm also building up a rant against this host_manager stuff | 13:35 |
| *** zzzeek has joined #openstack-nova | 13:36 | |
| *** eharney has joined #openstack-nova | 13:37 | |
| *** bfic has joined #openstack-nova | 13:38 | |
| rlrossit | mriedem: does it bother you as much as it bothers me that https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L195-L214 is setting self.metrics within a private function, instead of returning the metrics and setting them within update_from_compute_node() (where a bunch of other self.* are set)? | 13:38 |
| rlrossit | bauzas: ^ | 13:39 |
| *** diogogmt has joined #openstack-nova | 13:39 | |
| *** dims has quit IRC | 13:39 | |
| mriedem | rlrossit: well it's called from update_from_compute_node which is called from a couple of places | 13:40 |
| mriedem | and update_from_compute_node is setting a bunch of attributes on the HostState object | 13:40 |
| mriedem | i guess you could argue that _update_metrics_from_compute_node could just return the metrics dict and the caller could set it | 13:40 |
| rlrossit | mriedem: dingdingding | 13:40 |
| rlrossit | makes unit tests a lot easier | 13:40 |
| mriedem | yeah probably | 13:41 |
| rlrossit | which is what I was planning on doing in the first place | 13:41 |
| mriedem | having said that, it's not the worst thing that bothers me right now | 13:41 |
| openstackgerrit | jichenjc proposed openstack/nova: Disallow query deleted flavor https://review.openstack.org/215133 | 13:43 |
| *** dims_ has quit IRC | 13:44 | |
| *** mdrabe has joined #openstack-nova | 13:44 | |
| *** ccarmack has joined #openstack-nova | 13:45 | |
| *** tpeoples has joined #openstack-nova | 13:45 | |
| *** dims has joined #openstack-nova | 13:46 | |
| *** signed8bit is now known as signed8bit_ZZZzz | 13:46 | |
| *** ahilan has joined #openstack-nova | 13:47 | |
| *** fawadkhaliq has joined #openstack-nova | 13:48 | |
| *** signed8bit_ZZZzz is now known as signed8bit | 13:49 | |
| *** signed8bit is now known as signed8bit_ZZZzz | 13:50 | |
| *** thangp has joined #openstack-nova | 13:51 | |
| *** xyang1 has quit IRC | 13:52 | |
| *** ivasev has joined #openstack-nova | 13:52 | |
| bauzas | rlrossit: I tend to agree with mriedem, that's not exactly something really mandatory to do | 13:53 |
| *** haomaiwang has joined #openstack-nova | 13:53 | |
| openstackgerrit | jichenjc proposed openstack/nova: Disallow query deleted flavor in nova flavor-show https://review.openstack.org/215133 | 13:53 |
| bauzas | rlrossit: here, the main problem was due to the fact that the unittest was changed to fit the convience of the proposer | 13:54 |
| bauzas | at the convenience even | 13:54 |
| rlrossit | bauzas: true, but I also think there should be a little more unit testing around that area | 13:54 |
| bauzas | rlrossit: it can certainly do | 13:55 |
| mriedem | nova meeting in 5 minutes | 13:55 |
| *** obondarev_ has joined #openstack-nova | 13:56 | |
| *** tdurakov has quit IRC | 13:58 | |
| *** tdurakov has joined #openstack-nova | 13:59 | |
| *** obondarev has quit IRC | 13:59 | |
| *** xyang1 has joined #openstack-nova | 13:59 | |
| *** browne has joined #openstack-nova | 13:59 | |
| johnthetubaguy | mikal tjones cburgess jgrimm adrian_otto funzo mjturek jcookekhugen irina_pov krtaylor danpb alexpilotti flip214 jaypipes garyk edleafe dims moshele anteaya Nisha sileht claudiub lxsli neiljerram markus_z swamireddy alevine tonyb andreykurilin ndipanov sc68cal akuriata artom jlvillal mnestratov kashyap aloga rgeragnov bauzas xyang tpatil med_ nic scottda nagyz dannywilson belliott dguitarbite nova-meeting time | 13:59 |
| *** pkholkin has quit IRC | 13:59 | |
| *** pkholkin has joined #openstack-nova | 14:00 | |
| jroll | and here I thought we had a spammer until I saw the end | 14:00 |
| *** Guest95328 is now known as dansmith | 14:00 | |
| *** wanghua has quit IRC | 14:02 | |
| bauzas | rlrossit: well, if you want to get MHO, I just think all of that is just coming from the fact that we're poorly interfacing HostState | 14:03 |
| bauzas | rlrossit: there is no reason to have a python object while we already have a NovaObject (ComputeNode) | 14:03 |
| *** diogogmt has quit IRC | 14:04 | |
| *** aix has quit IRC | 14:04 | |
| rlrossit | bauzas: you're saying that HostState is kind of being a redundant wrapper of ComputeNode? | 14:04 |
| bauzas | so that error couldn't happen because the field would be coerced - that's where I would love to see some improvements instead of adding more coverage | 14:04 |
| bauzas | rlrossit: totally | 14:04 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Make query to quota usage table order preserved. https://review.openstack.org/213584 | 14:05 |
| *** signed8bit_ZZZzz has quit IRC | 14:06 | |
| *** ctrath has joined #openstack-nova | 14:06 | |
| *** afazekas has joined #openstack-nova | 14:07 | |
| *** jistr|mtg is now known as jistr | 14:08 | |
| *** aix has joined #openstack-nova | 14:09 | |
| *** haomaiwang has quit IRC | 14:09 | |
| jroll | edleafe: hey, looking at https://review.openstack.org/#/c/111837/ and the patch that supercedes it... we should be able to close https://bugs.launchpad.net/nova/+bug/1352510 I think? | 14:10 |
| openstack | Launchpad bug 1352510 in OpenStack Compute (nova) "Delete and re-add of same node to compute_nodes table is broken" [Medium,In progress] - Assigned to Ed Leafe (ed-leafe) | 14:10 |
| *** haomaiwang has joined #openstack-nova | 14:10 | |
| *** ajayaa has joined #openstack-nova | 14:11 | |
| *** lyanchih has joined #openstack-nova | 14:13 | |
| edleafe | jroll: I'll look into it after the nova meeting | 14:14 |
| markus_z | jaypipes: You +W'ed it a few days ago but it ran into a merge conflict: https://review.openstack.org/#/c/206631/ | 14:14 |
| *** signed8bit has joined #openstack-nova | 14:14 | |
| jroll | edleafe: yeah no rush | 14:14 |
| *** kiran-r has joined #openstack-nova | 14:14 | |
| jroll | just looking at bug lists for fun | 14:14 |
| *** ahilan has quit IRC | 14:15 | |
| *** kiran-r has quit IRC | 14:15 | |
| *** ftersin_ has quit IRC | 14:15 | |
| *** garyk has quit IRC | 14:15 | |
| *** burgerk has joined #openstack-nova | 14:15 | |
| *** diogogmt has joined #openstack-nova | 14:17 | |
| jaypipes | markus_z: done. | 14:17 |
| *** zul has quit IRC | 14:17 | |
| markus_z | jaypipes: Thanks! | 14:17 |
| *** mtanino has joined #openstack-nova | 14:17 | |
| openstackgerrit | j_king proposed openstack/nova: libvirt: Add wait for vif unplug events on destroy https://review.openstack.org/210126 | 14:20 |
| *** lucasagomes is now known as lucas-afk | 14:21 | |
| *** drankis has joined #openstack-nova | 14:25 | |
| *** vishwanathj has joined #openstack-nova | 14:27 | |
| *** sayali has quit IRC | 14:27 | |
| *** vivekd has joined #openstack-nova | 14:29 | |
| *** albertom-afk is now known as albertom | 14:31 | |
| *** bfic has quit IRC | 14:31 | |
| *** fawadkhaliq has quit IRC | 14:33 | |
| *** ftersin_ has joined #openstack-nova | 14:33 | |
| *** diogogmt has quit IRC | 14:34 | |
| sudipto | dims, I think we can close this one out: https://review.openstack.org/#/c/209499/3 | 14:36 |
| *** tonytan4ever has joined #openstack-nova | 14:36 | |
| *** lpetrut has quit IRC | 14:37 | |
| *** lpetrut has joined #openstack-nova | 14:38 | |
| * jaypipes throws on some deadmau5 | 14:39 | |
| dims | sudipto: it's not a bug :) | 14:39 |
| dims | sudipto: but you are on the right track | 14:39 |
| dims | sudipto: this one is a feature and it does not have DocImpact either | 14:39 |
| sudipto | dims, damn yeah - i thought Jay had them under a bug...sorry about that. | 14:40 |
| * dims pokes jaypipes :) | 14:40 | |
| apmelton | mriedem: https://gist.github.com/ramielrowe/081deaf0c6b79aec6890 | 14:41 |
| jichen | mriedem: please let me know when you submit the update for the devref, so I　can change my patch accordingly ... | 14:41 |
| jaypipes | dims: got it. should I create a bug and --amend the commit with a DocImpact? | 14:41 |
| sudipto | dims, https://review.openstack.org/#/c/156126/ | 14:41 |
| *** cfriesen has joined #openstack-nova | 14:41 | |
| jichen | mriedem: or I can do it if you are ok | 14:41 |
| *** tsekiyama has joined #openstack-nova | 14:41 | |
| sudipto | this one seems very trivial and has 3 +2s already | 14:41 |
| apmelton | mriedem: there's a couple issues I've noticed, the first is with nbd devices getting leaked | 14:41 |
| dims | jaypipes: for it to be added to the trivial list | 14:42 |
| jaypipes | dims: k, gimme a few minutes. | 14:42 |
| dims | at least DocImpact otherwise i think | 14:42 |
| sudipto | Wonder why it's not merged yet... | 14:42 |
| mriedem | jichen: yeah working on it now | 14:42 |
| apmelton | mriedem: the other issue is that network on the public interface just seems to drop, and I haven't been able to track down what actually causes that | 14:42 |
| jichen | mriedem: ok ~ | 14:42 |
| dims | sudipto: this has a workflow +1, so just needed a "recheck" | 14:42 |
| openstackgerrit | John Garbutt proposed openstack/nova: Xenapi: Handle missing aggregate metadata on startup https://review.openstack.org/156126 | 14:42 |
| sudipto | dims, yeah - ok let me put it there then? | 14:43 |
| dims | sudipto: no need to add to etherpad | 14:43 |
| mriedem | apmelton: ok, any lxc job would definitely start out on the experimetnal queue | 14:43 |
| mriedem | or non-voting check | 14:43 |
| *** signed8bit has quit IRC | 14:43 | |
| mriedem | LIBVIRT_TYPE=lxc - heh, about what i expected but wasn't sure | 14:43 |
| apmelton | yea, it's surprisingly simple at this point | 14:44 |
| *** signed8bit has joined #openstack-nova | 14:44 | |
| mriedem | apmelton: i'm assuming that's all nova-network right? | 14:44 |
| apmelton | yea | 14:44 |
| mriedem | ok, i'll see if i can hack up a project-config change this afternoon | 14:45 |
| mriedem | we can keep the tempest blacklist regex in nova's tree like we do for cells | 14:45 |
| *** dustins has quit IRC | 14:45 | |
| apmelton | oh mriedem, there's another step I always forget about | 14:46 |
| *** dustins has joined #openstack-nova | 14:46 | |
| *** takedakn1 has joined #openstack-nova | 14:46 | |
| apmelton | the default devstack doesn't enable the nbd module | 14:46 |
| mriedem | b/c it uses libguestfs | 14:46 |
| *** kolesovdv has quit IRC | 14:46 | |
| mriedem | because nbd + neutron kills the ubuntu kernel | 14:46 |
| mriedem | at least in 12.04 | 14:46 |
| apmelton | interesting | 14:47 |
| apmelton | libguestfs is only used for injecting into the guest filesystem right? | 14:47 |
| mriedem | that was a major gate issue for neutron jobs back in havana/icehouse | 14:47 |
| mriedem | yeah | 14:47 |
| apmelton | gah | 14:47 |
| mriedem | but there is an nbd option there too | 14:47 |
| mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/disk/mount/nbd.py | 14:48 |
| apmelton | yup | 14:48 |
| apmelton | the issue for lxc is it doesn't mount, modify the filesystem, then unmount | 14:48 |
| apmelton | it actually needs to leave it connected since the container is just running on the filesystem | 14:48 |
| johnthetubaguy | bauzas: alaski: how are with flavor or no flavor in here? https://review.openstack.org/#/c/145528/45 | 14:49 |
| mriedem | apmelton: hmm, can we use the loop module? http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/disk/mount/api.py#n54 | 14:49 |
| mriedem | if the image format is raw | 14:50 |
| *** takedakn has quit IRC | 14:50 | |
| mriedem | else maybe this todo from danpb is a longer term fix http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/disk/mount/api.py#n66 | 14:50 |
| *** derekh_afk is now known as derekh | 14:50 | |
| *** xgsa has quit IRC | 14:51 | |
| apmelton | interesting | 14:51 |
| alaski | johnthetubaguy: I would still prefer not to have flavor there, but what's there is a compromise that I'm good with | 14:51 |
| apmelton | that's actually what we've ended up doing | 14:51 |
| *** raildo is now known as raildo-afk | 14:51 | |
| dims | sudipto: got another one? | 14:51 |
| *** exploreshaifali has joined #openstack-nova | 14:52 | |
| mriedem | apmelton: so do you have out of tree patches to fix this stuff? | 14:52 |
| sudipto | dims, yeah reading through the entire change - https://review.openstack.org/#/c/190047/ | 14:52 |
| apmelton | mriedem: it doesn't really "fix" nbd | 14:52 |
| apmelton | it just skips it | 14:52 |
| mriedem | apmelton: i guess my point is, can we get around not using nbd? | 14:52 |
| johnthetubaguy | alaski: is your preference to make the interface independent of the flavor concept? I prefer either to having both, it has to be said | 14:52 |
| mriedem | apmelton: since i think we actually want nbd to die | 14:52 |
| apmelton | mriedem: we all do :) | 14:53 |
| sudipto | dims, it does look like a candidate to me ... | 14:54 |
| mriedem | apmelton: and guestfs doesn't work with lxc? | 14:54 |
| apmelton | I haven't tried | 14:54 |
| openstackgerrit | Jay Pipes proposed openstack/nova: Allow compute monitors in different namespaces https://review.openstack.org/209499 | 14:54 |
| jaypipes | dims, sudipto: done ^ | 14:54 |
| mriedem | apmelton: ok, i guess i can circle back on that | 14:54 |
| apmelton | mriedem: if it's not meant to keep the image mounted for long periods of time, it probably won't be a great solution | 14:54 |
| alaski | johnthetubaguy: yes. I think having a relationship with flavor adds unneeded complexity as well. But there's one filter that needs something that looks like flavor, so I think we need both for now | 14:54 |
| *** signed8bit has quit IRC | 14:55 | |
| dims | thanks jaypipes. sudipto please add that to the etherpad | 14:55 |
| alaski | johnthetubaguy: but longer term I think we can deprecate and remove flavor from this object | 14:55 |
| *** signed8bit has joined #openstack-nova | 14:55 | |
| apmelton | mriedem: let me see if I can get the work on pulling that patch upstream prioritized | 14:55 |
| jaypipes | alex_xu, dansmith: https://review.openstack.org/#/c/209499/ ready for your re-review. thx in advance. | 14:55 |
| *** raildo-afk has quit IRC | 14:55 | |
| sudipto | dims, sure. | 14:55 |
| mriedem | apmelton: ok, cool, and i'll work on the job | 14:55 |
| mriedem | apmelton: do you also have devstack patches for getting nbd installed? | 14:56 |
| apmelton | mriedem: the only caveat for our use case is that we're using LVM to back the images | 14:56 |
| *** raildo-afk has joined #openstack-nova | 14:56 | |
| apmelton | mriedem: no | 14:56 |
| johnthetubaguy | alaski: hmm, the current one seemed to have removed everything from the object thats in the flavor, to make the flavor the default | 14:56 |
| *** garyk has joined #openstack-nova | 14:56 | |
| dims | sudipto: good one, only caveat in https://review.openstack.org/#/c/190047/ is that we are adding yet another flag, but let's add it to etherpad and nova cores can choose to move it to the invalid bucket | 14:56 |
| sudipto | dims, you mean a new flag in the nova.conf? | 14:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Handle NotFound exceptions while processing network-changed events https://review.openstack.org/215170 | 14:57 |
| alaski | johnthetubaguy: right. I would have gone the other direction. but what's important I think is the object interface, and we can modify the internals down the road | 14:57 |
| dims | sudipto: y | 14:57 |
| sudipto | dims, ok | 14:57 |
| *** raildo-afk has quit IRC | 14:57 | |
| *** xgsa has joined #openstack-nova | 14:57 | |
| johnthetubaguy | alaski: true | 14:57 |
| *** raildo-afk has joined #openstack-nova | 14:57 | |
| *** annegentle has quit IRC | 14:58 | |
| *** raildo-afk is now known as raildo | 14:58 | |
| *** annegentle has joined #openstack-nova | 14:58 | |
| alex_xu | jaypipes: thanks | 15:00 |
| sudipto | dims, https://review.openstack.org/#/c/192043/ | 15:00 |
| *** alex_klimov has quit IRC | 15:01 | |
| *** zul has joined #openstack-nova | 15:02 | |
| *** exploreshaifali has quit IRC | 15:02 | |
| *** alexschm has quit IRC | 15:03 | |
| *** vivek_nandavanam has joined #openstack-nova | 15:03 | |
| alex_xu | jaypipes: just need s/obj.ext/ext.obj/ in https://review.openstack.org/#/c/209499/ | 15:03 |
| *** xgsa has quit IRC | 15:04 | |
| *** xgsa has joined #openstack-nova | 15:04 | |
| jaypipes | alex_xu: gah, thxnk! | 15:04 |
| alex_xu | jaypipes: np :) | 15:04 |
| sudipto | dims, https://review.openstack.org/#/c/188025/ this actually has a +2 from johnthetubaguy - and seems a trivial one - but guess the commit message and a bit of code comments is needed...should we still consider it? | 15:04 |
| openstackgerrit | Jay Pipes proposed openstack/nova: Allow compute monitors in different namespaces https://review.openstack.org/209499 | 15:05 |
| jaypipes | alex_xu: done :) | 15:05 |
| *** shoutm has joined #openstack-nova | 15:05 | |
| alex_xu | jaypipes: cool, go to +1 | 15:05 |
| *** fawadkhaliq has joined #openstack-nova | 15:06 | |
| dims | https://review.openstack.org/#/c/192043/ has a todo from Alex, but yes, sure please add it to etherpad | 15:06 |
| jaypipes | alex_xu: ty sir! :) | 15:06 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: CONF.allow_resize_on_same_host should check only once in controller https://review.openstack.org/186236 | 15:07 |
| alex_xu | jaypipes: you are welcom, sir :) | 15:07 |
| *** takedakn has joined #openstack-nova | 15:07 | |
| *** signed8bit has quit IRC | 15:08 | |
| *** alejandrito has joined #openstack-nova | 15:08 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add UniqueConstraint for quota usages table https://review.openstack.org/212908 | 15:08 |
| dims | sudipto: use the "edit message" button and edit the message yourself. once the CI passes then you can add it to etherpad (https://review.openstack.org/#/c/188025/). leave a note to the original committer says, "hope its ok i fixed the commit message" | 15:08 |
| *** hemnafk is now known as hemna | 15:08 | |
| dims | sudipto: lot of times, the patch may be stale and ci jobs may fail, so need to wait | 15:09 |
| *** takedakn1 has quit IRC | 15:09 | |
| *** haomaiwang has quit IRC | 15:09 | |
| *** haomaiwang has joined #openstack-nova | 15:10 | |
| *** dprince has quit IRC | 15:12 | |
| *** nkrinner has quit IRC | 15:14 | |
| edleafe | jroll: ok, got to look at that bug, and yeah, it should have closed it, but I forgot to put Closes-bug: in the commit message | 15:15 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add UniqueConstraint for quota usages table https://review.openstack.org/212908 | 15:16 |
| *** diogogmt has joined #openstack-nova | 15:16 | |
| *** burt has joined #openstack-nova | 15:17 | |
| jroll | edleafe: no worries | 15:17 |
| sudipto | dims, sure | 15:18 |
| jroll | johnthetubaguy: mind marking this bug fix committed/released/whatever as needed? https://bugs.launchpad.net/nova/+bug/1352510 | 15:18 |
| openstack | Launchpad bug 1352510 in OpenStack Compute (nova) "Delete and re-add of same node to compute_nodes table is broken" [Medium,In progress] - Assigned to Ed Leafe (ed-leafe) | 15:18 |
| jroll | (or point me at the right person) | 15:18 |
| *** otter768 has joined #openstack-nova | 15:19 | |
| johnthetubaguy | jroll: sure, I can do, does it not give you the permissions for that? | 15:19 |
| *** kfox1111 has quit IRC | 15:19 | |
| *** diogogmt has quit IRC | 15:19 | |
| *** eharney has quit IRC | 15:19 | |
| jroll | johnthetubaguy: maybe it does... | 15:20 |
| *** shoutm has quit IRC | 15:20 | |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: libvirt: Fix KeyError during LXC instance boot https://review.openstack.org/188025 | 15:20 |
| jroll | I'm having trouble posting a comment though, timeouts :/ | 15:20 |
| jroll | johnthetubaguy: april 23 merge would be in kilo release, yeah? | 15:21 |
| *** dannywilson has joined #openstack-nova | 15:21 | |
| johnthetubaguy | jroll: it should be, I usually just check in github and look at the tags to see if it made it | 15:21 |
| *** shaohe_feng has joined #openstack-nova | 15:21 | |
| *** browne has quit IRC | 15:21 | |
| jroll | good call | 15:22 |
| *** jistr is now known as jistr|mtg | 15:22 | |
| *** wanghua has joined #openstack-nova | 15:22 | |
| *** diogogmt has joined #openstack-nova | 15:22 | |
| jroll | johnthetubaguy: weird, shows 12.0.0a0 12.0.0.0b2 12.0.0.0b1 | 15:22 |
| jroll | which is liberty afaik? | 15:22 |
| johnthetubaguy | jroll: yeah, odd | 15:23 |
| jroll | L1 that is | 15:23 |
| johnthetubaguy | jroll: we do branch quite early sometimes | 15:23 |
| jroll | 2015.1.0 was tagged apr 30 | 15:23 |
| jroll | ar RCs branched? | 15:23 |
| jroll | are* | 15:23 |
| johnthetubaguy | yep | 15:23 |
| jroll | aha | 15:23 |
| johnthetubaguy | branch at RC1 | 15:23 |
| jroll | yeah, that missed | 15:23 |
| *** otter768 has quit IRC | 15:23 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: WIP: Hyper-V: determine vm_com_pipe error during spawn https://review.openstack.org/213720 | 15:24 |
| johnthetubaguy | it was dam close | 15:24 |
| jroll | rc1 was april 10 | 15:24 |
| * jroll marks released anyway because l1 | 15:24 | |
| johnthetubaguy | sounds good | 15:24 |
| jroll | done, sorry for the bother, didn't realize I could much with your bugs :) | 15:24 |
| bauzas | johnthetubaguy: alaski: right, I totally agree with alaski but we needed some mitigation because of a stupid filter | 15:26 |
| johnthetubaguy | bauzas: OK, there seem to be unit test fails further up that chain at the moment | 15:27 |
| bauzas | johnthetubaguy: strange, Jenkins was happy yesterday | 15:28 |
| bauzas | johnthetubaguy: but I'll dig into that | 15:28 |
| *** moshele has quit IRC | 15:28 | |
| *** scheuran has quit IRC | 15:28 | |
| johnthetubaguy | bauzas: I think it was the update this morning that upset it, no worries | 15:28 |
| bauzas | I'm UTC-7 so I'll look at that | 15:29 |
| *** VikasC has joined #openstack-nova | 15:31 | |
| *** wanghua has quit IRC | 15:32 | |
| *** zul has quit IRC | 15:33 | |
| *** andreykurilin__ has joined #openstack-nova | 15:34 | |
| *** xgsa has quit IRC | 15:34 | |
| *** haomaiwang has quit IRC | 15:35 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Clarify API microversion docs around handling 500 errors https://review.openstack.org/215195 | 15:36 |
| mriedem | jaypipes: alex_xu: sdague: johnthetubaguy: alaski: dansmith: jichen: ^ | 15:36 |
| jaypipes | danke | 15:36 |
| jichen | danke schon | 15:36 |
| mriedem | jichen: you're practically german already :) | 15:36 |
| *** r-daneel has joined #openstack-nova | 15:36 | |
| mriedem | just in time for october | 15:36 |
| jichen | mriedem: yeah :) | 15:36 |
| *** takedakn has quit IRC | 15:36 | |
| rlrossit | mriedem: I left a comment on https://bugs.launchpad.net/nova/+bug/1487038, but basically do we want to remove keys in _cleanse_dict() or do we want to censor the values to stay closer to strutils? | 15:38 |
| openstack | Launchpad bug 1487038 in OpenStack Compute (nova) "nova.exception._cleanse_dict should use oslo_utils.strutils._SANITIZE_KEYS" [Low,Confirmed] | 15:38 |
| *** VW_ has joined #openstack-nova | 15:39 | |
| *** rdopiera has joined #openstack-nova | 15:40 | |
| jaypipes | mriedem: did you want to include in there something about never backporting any patch to a stable branch that contains a microversion bump? | 15:42 |
| mriedem | jaypipes: i wanted to leave backport stuff to a separate change | 15:43 |
| mriedem | since i think that's it's own issue | 15:43 |
| jaypipes | mriedem: got it. ok, +W'ing this. | 15:43 |
| mriedem | +W already? | 15:43 |
| mriedem | w/o sdague? | 15:43 |
| mriedem | damn | 15:43 |
| mriedem | or alex | 15:44 |
| mriedem | i figure we should have some more concensus | 15:44 |
| jaypipes | mriedem: k, removed. | 15:44 |
| *** armax has joined #openstack-nova | 15:44 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Clarify API microversion docs around handling 500 errors https://review.openstack.org/215195 | 15:44 |
| mriedem | gotta pull it from the queue | 15:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Clarify API microversion docs around handling 500 errors https://review.openstack.org/215195 | 15:45 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Make query to quota usage table order preserved. https://review.openstack.org/213584 | 15:45 |
| mriedem | jaypipes: added kenichi | 15:45 |
| mriedem | and -2ed so there is time to review | 15:45 |
| mriedem | i know sean is in seattle with family this week | 15:45 |
| *** mriedem is now known as mriedem_away | 15:46 | |
| mriedem_away | jaypipes: alaski: btw, feel free to reapply your +2s :) | 15:46 |
| alaski | 403 over quota | 15:46 |
| *** belmoreira has joined #openstack-nova | 15:49 | |
| *** mwagner_lap has quit IRC | 15:50 | |
| *** angdraug has joined #openstack-nova | 15:51 | |
| *** salv-orlando has quit IRC | 15:52 | |
| *** hogepodge has quit IRC | 15:53 | |
| openstackgerrit | Vipin Balachandran proposed openstack/nova: VMware: Delete vmdk UUID during volume detach https://review.openstack.org/204622 | 15:55 |
| *** armax has quit IRC | 15:56 | |
| *** redbeard has quit IRC | 15:56 | |
| *** AlexeyElagin has joined #openstack-nova | 15:57 | |
| *** belmoreira has quit IRC | 15:58 | |
| *** eharney has joined #openstack-nova | 15:59 | |
| *** salv-orlando has joined #openstack-nova | 15:59 | |
| dansmith | alaski: I know you're 403, but is the request spec thing in the pipe already? | 15:59 |
| dansmith | alaski: I'd be +2, but think you should vote on it before we land it if at all possible | 15:59 |
| alaski | the 403 was only for +2s to mriedem_away | 15:59 |
| dansmith | okay | 16:00 |
| alaski | I'm finishing my rebase on top and then I'll look at it | 16:00 |
| alaski | thinking on it now I probably should have reviewed first... | 16:00 |
| openstackgerrit | bharaththiruveedula proposed openstack/nova-specs: Returning Compute Node IP address in hypervisor list https://review.openstack.org/215207 | 16:00 |
| bauzas | alaski: dansmith: I need first to rebase and update the test_relationships stuff because there was an object bump | 16:00 |
| dansmith | alaski: well, bauzas is about to push again for a rebase test fix | 16:00 |
| dansmith | yeah, that | 16:00 |
| alaski | okay, I'll review then | 16:01 |
| *** rajesht has quit IRC | 16:01 | |
| *** VW_ has quit IRC | 16:02 | |
| *** SourabhP has joined #openstack-nova | 16:02 | |
| *** ftersin_ has quit IRC | 16:03 | |
| *** VW_ has joined #openstack-nova | 16:03 | |
| *** unicell has joined #openstack-nova | 16:03 | |
| *** unicell1 has quit IRC | 16:05 | |
| *** tbh has joined #openstack-nova | 16:05 | |
| *** Nikolay_St has quit IRC | 16:05 | |
| *** SourabhP_ has joined #openstack-nova | 16:05 | |
| alaski | dansmith: bauzas lgtm. I'll wait for the new push and +2 | 16:06 |
| *** mdrabe has quit IRC | 16:06 | |
| tbh | johnthetubaguy: finally push the patch for nova-spec for review | 16:06 |
| *** VW_ has quit IRC | 16:06 | |
| *** VW_ has joined #openstack-nova | 16:07 | |
| openstackgerrit | Andrea Rosa proposed openstack/nova: Correct a wrong docstring https://review.openstack.org/215215 | 16:07 |
| bauzas | alaski: uploading now | 16:07 |
| *** SourabhP has quit IRC | 16:08 | |
| *** SourabhP_ is now known as SourabhP | 16:08 | |
| *** ftersin_ has joined #openstack-nova | 16:08 | |
| *** yamahata has joined #openstack-nova | 16:09 | |
| *** jistr|mtg is now known as jistr | 16:10 | |
| *** VW_ has quit IRC | 16:11 | |
| johnthetubaguy | tbh: cool, glad that worked out, sorry that was such a pain | 16:11 |
| *** lsmola has quit IRC | 16:12 | |
| bauzas | okay, rebase issue, alaski don't wait for me now | 16:12 |
| tbh | johnthetubaguy: I came to home and then pushed for review :) | 16:13 |
| *** shaohe_feng has quit IRC | 16:13 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: WIP: Add BuildRequest table and object https://review.openstack.org/214792 | 16:13 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add persistence to the RequestSpec object https://review.openstack.org/211753 | 16:13 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Move objects registration in tests directory https://review.openstack.org/212159 | 16:13 |
| johnthetubaguy | tbh: ah, I remember when I had to do that while my company at the time updated their firewall! | 16:13 |
| *** Apoorva has joined #openstack-nova | 16:14 | |
| tbh | johnthetubaguy: oh :), by the way who have the rights to assign the blueprint? | 16:14 |
| *** SourabhP has quit IRC | 16:15 | |
| johnthetubaguy | tbh: I should be able to move the blueprint, you mean you want to become the assignee on that? | 16:15 |
| *** tjones has joined #openstack-nova | 16:16 | |
| tbh | johnthetubaguy: yeah I want to work on this bp, as this is my first bp | 16:16 |
| johnthetubaguy | tbh: OK, lets start with the spec review I guess, we can update that all later on if you like? | 16:17 |
| tbh | johnthetubaguy: sure | 16:17 |
| *** tjones has left #openstack-nova | 16:18 | |
| *** krtaylor has quit IRC | 16:18 | |
| *** mdrabe has joined #openstack-nova | 16:19 | |
| *** exploreshaifali has joined #openstack-nova | 16:20 | |
| *** moshele has joined #openstack-nova | 16:20 | |
| *** kiran-r has joined #openstack-nova | 16:20 | |
| *** Marga_ has quit IRC | 16:22 | |
| *** hogepodge has joined #openstack-nova | 16:23 | |
| *** vivekd has quit IRC | 16:23 | |
| *** zul has joined #openstack-nova | 16:24 | |
| *** lpetrut has quit IRC | 16:26 | |
| *** mriedem_away is now known as mriedem | 16:27 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify Scheduler RPC API select_dests() https://review.openstack.org/199205 | 16:27 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Create RequestSpec object https://review.openstack.org/145528 | 16:27 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Consider that all scheduler calls are IO Ops https://review.openstack.org/188486 | 16:27 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Use RequestSpec object in the FilterScheduler https://review.openstack.org/188487 | 16:27 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify left filters for RequestSpec https://review.openstack.org/202678 | 16:27 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Prepare filters for using RequestSpec object https://review.openstack.org/197912 | 16:27 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify conductor to use RequestSpec object https://review.openstack.org/203078 | 16:27 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify metric-related filters for RequestSpec https://review.openstack.org/202676 | 16:27 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Use RequestSpec in the ChanceScheduler https://review.openstack.org/199051 | 16:27 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify NUMA, PCI and num_instances filters for RequestSpec https://review.openstack.org/202677 | 16:27 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify Aggregate filters for RequestSpec https://review.openstack.org/202674 | 16:27 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify default filters for RequestSpec https://review.openstack.org/202675 | 16:27 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add RequestSpec methods for primitiving into dicts https://review.openstack.org/187197 | 16:27 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify Affinity filter for RequestSpec https://review.openstack.org/202673 | 16:27 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Use RequestSpec object in HostManager https://review.openstack.org/191251 | 16:27 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Use the same pci_requests field for all filters and HostManager https://review.openstack.org/191250 | 16:27 |
| *** oomichi has joined #openstack-nova | 16:28 | |
| bauzas | anyone can put their dirty hands on ^ | 16:28 |
| *** mwagner_lap has joined #openstack-nova | 16:28 | |
| dansmith | alaski: you first then I'll go | 16:28 |
| *** meghal has joined #openstack-nova | 16:29 | |
| *** Marga_ has joined #openstack-nova | 16:29 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: WIP: Add BuildRequest table and object https://review.openstack.org/214792 | 16:29 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add persistence to the RequestSpec object https://review.openstack.org/211753 | 16:29 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Move objects registration in tests directory https://review.openstack.org/212159 | 16:29 |
| *** salv-orlando has quit IRC | 16:30 | |
| *** _kiran_ has joined #openstack-nova | 16:30 | |
| *** kiran-r has quit IRC | 16:31 | |
| * alaski passes the baton to dansmith | 16:31 | |
| *** matrohon has quit IRC | 16:32 | |
| bauzas | dims: I'm just working on deprecating opts, you probably remember a discussion we had like 3 weeks ago | 16:33 |
| *** browne has joined #openstack-nova | 16:33 | |
| dims | bauzas: vaguely :) | 16:33 |
| bauzas | dims: just one q before I move on, what's about http://docs.openstack.org/developer/oslo.config/opts.html#oslo_config.cfg.DeprecatedOpt and how I can have 2 opts in 2 different modules, one being deprecated and one new ? | 16:33 |
| mriedem | edleafe: can we leave your 500 -> anything else for a separate change | 16:34 |
| mriedem | ? | 16:34 |
| mriedem | i tend to agree with that, | 16:34 |
| bauzas | dims: shall I move the existing opt to the new module, then mention it as deprecated, provided it's kept in the right group . | 16:34 |
| bauzas | ? | 16:34 |
| mriedem | but it doesn't necessarily need to be in my change for clarifying 500 to 400+ | 16:34 |
| *** kashyap has quit IRC | 16:34 | |
| *** whenry_ has joined #openstack-nova | 16:34 | |
| *** lucas-afk is now known as lucasagomes | 16:34 | |
| dims | bauzas: move existing opt to new module and use DeprecatedOpt to mention the name and group of the old being deprecated | 16:34 |
| mriedem | dansmith: but then you get sloppy seconds | 16:35 |
| bauzas | dims: by looking at Nova, it seems we don't heavily use that kind of DeprecatedOpt, but rather just modifies the help comment | 16:35 |
| mriedem | gross | 16:35 |
| *** jwcroppe_ has quit IRC | 16:35 | |
| dansmith | mriedem: .... | 16:35 |
| mriedem | bauzas: DeprecatedOpt is for moving options between groups or renames | 16:35 |
| bauzas | dims: okay, that was my thoughts, but since I'm moving an opt from a scheduler namespace to a compute namespace, that's a bit harsh | 16:35 |
| *** sahid has joined #openstack-nova | 16:35 | |
| bauzas | mriedem: oh ok | 16:36 |
| mriedem | deprecated_for_removal kwarg is for deprecating, for removal | 16:36 |
| edleafe | mriedem: why separate? Why not just correct it in one? | 16:36 |
| mriedem | edleafe: b/c this specific change is for handling a 500, not a 501 | 16:37 |
| mriedem | 501 is a separate case and i think warrants a separate change and review | 16:37 |
| bauzas | mriedem: okay, so I won't use the DeprecatedOpt | 16:37 |
| *** fawadk has joined #openstack-nova | 16:37 | |
| bauzas | mriedem: but rather the kwarg you mentioned | 16:37 |
| *** kashyap has joined #openstack-nova | 16:37 | |
| *** fawadkhaliq has quit IRC | 16:37 | |
| bauzas | mriedem: dims: thanks | 16:37 |
| ctrath | is there documentation anywhere that explains where logs are dumped on tox -e py27 runs? | 16:38 |
| *** dprince has joined #openstack-nova | 16:39 | |
| *** jichen has quit IRC | 16:39 | |
| rdopiera | to the console? | 16:40 |
| mriedem | no | 16:40 |
| *** whenry_ has quit IRC | 16:40 | |
| ctrath | rdopiera: anywhere.. file, console, device... | 16:40 |
| mriedem | the subunit stream | 16:40 |
| mriedem | ctrath: e.g. http://logs.openstack.org/06/183706/7/check/gate-nova-python27/743f296/testrepository.subunit.gz | 16:40 |
| edleafe | mriedem: ok - done | 16:41 |
| rdopiera | ah, I thought when you run it manually | 16:41 |
| ctrath | yes, when I run it in devstack, specifically | 16:41 |
| edleafe | mriedem: my feeling is that any 5xx is not an expected response | 16:43 |
| *** armax has joined #openstack-nova | 16:43 | |
| mriedem | i disagree | 16:43 |
| mriedem | specifically for 501 and 503 | 16:43 |
| *** drankis has quit IRC | 16:43 | |
| mriedem | 501 - these aren't the droids you're looking for | 16:43 |
| mriedem | 503 - shit happens | 16:43 |
| *** ftersin_ has quit IRC | 16:45 | |
| *** jistr has quit IRC | 16:46 | |
| johnthetubaguy | mriedem: I so want to see your full list of codes | 16:47 |
| johnthetubaguy | 5xx - my bad, 4xx - your bad | 16:47 |
| *** vivekd has joined #openstack-nova | 16:48 | |
| *** unicell has quit IRC | 16:48 | |
| mriedem | 3xx - are these even used? | 16:48 |
| mriedem | we should use 402 more | 16:49 |
| mriedem | payment required | 16:49 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: WIP: Hyper-V: adds oslo.windows library https://review.openstack.org/212102 | 16:49 |
| *** lpetrut has joined #openstack-nova | 16:49 | |
| bauzas | dims: eh, I got again one ticket for you, what's https://github.com/openstack/nova/blob/master/nova/scheduler/opts.py ? | 16:50 |
| bauzas | dims: I looked at the comment, but I just discover that one | 16:50 |
| *** lpetrut has quit IRC | 16:50 | |
| ctrath | mriedem: don't forget about 418 - I'm a teapot | 16:50 |
| *** lpetrut has joined #openstack-nova | 16:50 | |
| *** Kennan2 has quit IRC | 16:50 | |
| bauzas | dims: it means that anytime that we change an opt, we need to change that as well ? | 16:51 |
| *** lpetrut has quit IRC | 16:51 | |
| dims | bauzas: yes, for the oslo-config-generator to pick things up | 16:51 |
| *** lpetrut has joined #openstack-nova | 16:51 | |
| *** VW_ has joined #openstack-nova | 16:51 | |
| *** lpetrut has quit IRC | 16:52 | |
| johnthetubaguy | bauzas: hence to push to move opts all into a more central location/directory | 16:52 |
| bauzas | okay | 16:52 |
| *** chaochin has quit IRC | 16:52 | |
| bauzas | good to know, I missed that one | 16:52 |
| *** park_ has quit IRC | 16:52 | |
| bauzas | so any change to an opt should impact that file, gotcha | 16:53 |
| bauzas | at least additions | 16:53 |
| *** mingy has joined #openstack-nova | 16:53 | |
| *** atuvenie has quit IRC | 16:53 | |
| *** ftersin_ has joined #openstack-nova | 16:55 | |
| *** SourabhP has joined #openstack-nova | 16:55 | |
| *** sahid has quit IRC | 16:56 | |
| *** armax has quit IRC | 16:57 | |
| jroll | mriedem: just swap out 500 for 402, payment required in form of bug fixes | 16:58 |
| *** romainh has left #openstack-nova | 16:58 | |
| mriedem | jroll: that's what i tried to pull on cfriesen yesterday | 16:59 |
| jroll | hah | 16:59 |
| mriedem | apmelton: as you can see in https://review.openstack.org/#/c/214927/ - that method is pretty wonky, not even tested | 16:59 |
| mriedem | but has been around a long time | 16:59 |
| *** derekh has quit IRC | 17:00 | |
| bauzas | mmm, I'm really wondering on how to properly move one opt from one component to another and provide a nice compat'... | 17:01 |
| *** tpeoples has quit IRC | 17:01 | |
| jroll | bauzas: deprecated_group? | 17:01 |
| jroll | I feel like that's a thing | 17:01 |
| *** VW_ has quit IRC | 17:01 | |
| *** armax has joined #openstack-nova | 17:02 | |
| *** VW_ has joined #openstack-nova | 17:02 | |
| *** afazekas has quit IRC | 17:02 | |
| bauzas | jroll: well, the thing is - we need to send the batsignal to operators that they have to provide that conf flag not in the same nova.conf file | 17:03 |
| jroll | oh, different service | 17:03 |
| bauzas | jroll: I feel there is no alternative than just creating a new opt and explicitely duplicate that | 17:03 |
| *** vilobhmm1 has joined #openstack-nova | 17:03 | |
| bauzas | yeah, s/component/service my bad | 17:03 |
| *** tsekiyama has quit IRC | 17:04 | |
| jroll | yeah, I'm not sure :/ | 17:04 |
| bauzas | okay, nvm, I'm gonna shot something and we'll see | 17:05 |
| *** achanda has joined #openstack-nova | 17:05 | |
| *** Kennan has joined #openstack-nova | 17:05 | |
| *** jcoufal has quit IRC | 17:06 | |
| *** park_ has joined #openstack-nova | 17:06 | |
| *** VW_ has quit IRC | 17:07 | |
| apmelton | mriedem: it's tested here https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/test_driver.py#L10584-L10705 | 17:07 |
| *** SourabhP has quit IRC | 17:08 | |
| *** markus_z has quit IRC | 17:08 | |
| *** chaochin has joined #openstack-nova | 17:09 | |
| *** tpeoples has joined #openstack-nova | 17:10 | |
| *** nic has joined #openstack-nova | 17:10 | |
| *** Nikolay_St has joined #openstack-nova | 17:12 | |
| *** Kennan has quit IRC | 17:14 | |
| *** park_ has quit IRC | 17:14 | |
| *** chaochin has quit IRC | 17:14 | |
| *** lyanchih has quit IRC | 17:16 | |
| *** unicell has joined #openstack-nova | 17:16 | |
| *** oomichi has quit IRC | 17:17 | |
| openstackgerrit | Eli Qiao proposed openstack/nova: Catch Exception when detach encryptied volume https://review.openstack.org/215252 | 17:17 |
| *** chaochin has joined #openstack-nova | 17:19 | |
| *** otter768 has joined #openstack-nova | 17:20 | |
| *** Kennan has joined #openstack-nova | 17:20 | |
| *** park_ has joined #openstack-nova | 17:20 | |
| mingy | edleafe: ping | 17:21 |
| *** aix has quit IRC | 17:22 | |
| edleafe | mingy: https://blogs.gnome.org/markmc/2014/02/20/naked-pings/ | 17:22 |
| edleafe | mingy: but anyway... pong | 17:22 |
| edleafe | mingy: did you have a chance to review? | 17:23 |
| *** ssurana has joined #openstack-nova | 17:23 | |
| mingy | edleafe: yeah so I checked this last night and you were right and I was wrong, it returns the empty generator object. | 17:23 |
| mingy | edleafe: turns out I misunderstood how the yield keyword works in python | 17:23 |
| edleafe | mingy: yeah, it doesn't have to hit the yield to return a generator | 17:24 |
| edleafe | mingy: so are we cool? | 17:24 |
| mingy | we're cool :) | 17:24 |
| edleafe | :) | 17:24 |
| *** Kennan has quit IRC | 17:24 | |
| *** otter768 has quit IRC | 17:24 | |
| *** chaochin has quit IRC | 17:24 | |
| *** park_ has quit IRC | 17:25 | |
| *** signed8bit has joined #openstack-nova | 17:26 | |
| *** achanda has quit IRC | 17:27 | |
| openstackgerrit | Roman Bogorodskiy proposed openstack/nova: Sync L3Driver, NullL3 interface with LinuxNetL3 https://review.openstack.org/189001 | 17:28 |
| *** oomichi has joined #openstack-nova | 17:28 | |
| *** VikasC has quit IRC | 17:28 | |
| mingy | as for the ping thing... I just kind of saw people doing it on irc so I followed suite. I always thought it was a mannerism, I never knew it did things to the client. | 17:29 |
| mingy | but yeah ok will take note in the future | 17:29 |
| dansmith | mingy: for what it's worth, I do *not* subscribe to the naked pings thing :) | 17:31 |
| *** meghal has quit IRC | 17:32 | |
| *** meghal has joined #openstack-nova | 17:32 | |
| dansmith | mingy: meaning, I think so-called "naked pings" are fine :) | 17:32 |
| cfriesen | jaypipes: bauzas: is https://review.openstack.org/#/c/203044/ of any interest to you? We hit this issue when working with SRIOV devices capable of 128+ VFs. | 17:33 |
| *** yamahata has quit IRC | 17:34 | |
| mriedem | apmelton: ok, missed that since it's not unit tested directly | 17:34 |
| mriedem | however, | 17:34 |
| mriedem | apmelton: you'll notice [] is passed in for disk_info rather than {} | 17:34 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/test_driver.py#L10631 | 17:34 |
| mriedem | and _is_booted_from_volume is mocked out | 17:35 |
| mriedem | so that's why it doesn't explode | 17:35 |
| apmelton | D: | 17:35 |
| mriedem | it at least makes my job easier in updating that test rather than writing a new one | 17:35 |
| melwitt | dansmith: "Jenkins: Please make this go away" :) | 17:36 |
| mriedem | dansmith: ping | 17:36 |
| *** oomichi has quit IRC | 17:36 | |
| *** ahilan has joined #openstack-nova | 17:37 | |
| mingy | dansmith: thanks for letting me know. although now that also makes me more confused. verily, I need more training data to make a judgment on proper IRC etiquette. | 17:37 |
| *** park_ has joined #openstack-nova | 17:37 | |
| dansmith | melwitt: heh | 17:37 |
| *** nic has quit IRC | 17:37 | |
| *** chaochin has joined #openstack-nova | 17:38 | |
| mriedem | rlrossit: per your question before i left for lunch, | 17:39 |
| mriedem | rlrossit: i wasn't thinking of replacing the '_pass' in nova with the list in oslo.utils, | 17:39 |
| bauzas | cfriesen: sure, reloading the PCI stuff in my head is always good to me since I think we have to fix that | 17:39 |
| mriedem | but somehow supplement | 17:39 |
| *** whenry_ has joined #openstack-nova | 17:39 | |
| mriedem | like check in the oslo.utils list and check '_pass' in key | 17:40 |
| bauzas | cfriesen: that tho means it will take time for me to review that one | 17:40 |
| mriedem | rlrossit: unless you can come up with a fancy regex way that handles both | 17:40 |
| *** Kennan has joined #openstack-nova | 17:40 | |
| mriedem | rlrossit: i guess think about it for awhile. i just know that if you have a 'password' key in the dict, that method won't filter it out right now | 17:40 |
| mriedem | and we have things in strutils that do just this today, so it seems we should leverage those somehow | 17:41 |
| *** salv-orlando has joined #openstack-nova | 17:42 | |
| melwitt | mriedem: I didn't know we're supposed to use six.text_type() for logging exception objects, this is the first time I see it https://review.openstack.org/#/c/215170/1/nova/compute/manager.py,cm | 17:43 |
| *** emagana has joined #openstack-nova | 17:43 | |
| *** oomichi has joined #openstack-nova | 17:43 | |
| mriedem | melwitt: yar | 17:43 |
| mriedem | because of unicode | 17:43 |
| melwitt | noted. I think I missed it in a recent review | 17:44 |
| *** vilobhmm1 has quit IRC | 17:44 | |
| *** whenry_ has quit IRC | 17:44 | |
| *** vilobhmm1 has joined #openstack-nova | 17:45 | |
| mriedem | someone in asia is cursing your name | 17:46 |
| rlrossit | mriedem: my question was aimed more towards how we want the function to operate. Like do we want to remove the keys from the dict, or do we want to substitute the value with "***"? | 17:46 |
| mriedem | "UnicodeDecodeError?! curse you, melwitt!!!" | 17:46 |
| *** salv-orlando has quit IRC | 17:46 | |
| mriedem | rlrossit: probably remove as it does today | 17:46 |
| melwitt | lol! | 17:46 |
| * melwitt hides | 17:46 | |
| rlrossit | mriedem: alrighty | 17:46 |
| mriedem | rlrossit: that's just a guess, honestly i didn't know that method existed until today | 17:47 |
| cfriesen | bauzas: no worries, it's a trivial fix. the only reason we let it slip was that someone had mentioned that the config options might get reorganized. | 17:47 |
| *** krtaylor has joined #openstack-nova | 17:47 | |
| mriedem | rlrossit: as noted in the bug, it seems like oslo.messaging's log notifier should actually be doing the mask_password bit | 17:47 |
| mriedem | to catch anything not filtered at the top | 17:47 |
| mriedem | dims: ^ | 17:47 |
| bauzas | cfriesen: yeah was about to leave a comment on that purpose | 17:47 |
| mriedem | rlrossit: here http://git.openstack.org/cgit/openstack/oslo.messaging/tree/oslo_messaging/notify/_impl_log.py#n41 | 17:48 |
| *** lpetrut has joined #openstack-nova | 17:48 | |
| dims | what bug are we looking at mriedem? | 17:48 |
| rlrossit | dims: https://bugs.launchpad.net/nova/+bug/1487038 | 17:48 |
| openstack | Launchpad bug 1487038 in OpenStack Compute (nova) "nova.exception._cleanse_dict should use oslo_utils.strutils._SANITIZE_KEYS" [Low,Confirmed] | 17:48 |
| mriedem | dims: it seems http://git.openstack.org/cgit/openstack/oslo.messaging/tree/oslo_messaging/notify/_impl_log.py#n41 should call strutils.mask_password on the jsonified message | 17:49 |
| cfriesen | bauzas: I can get the change rebased to current...if you've got any suggestions for changes, please add them to the review. | 17:49 |
| *** _kiran_ has quit IRC | 17:50 | |
| apmelton | ndipanov: around? I've got a question about some boot from volume/blockdevice code in the libvirt driver | 17:51 |
| jaypipes | cfriesen: /me looks | 17:53 |
| *** vilobhmm11 has joined #openstack-nova | 17:54 | |
| *** vilobhmm1 has quit IRC | 17:54 | |
| *** achanda has joined #openstack-nova | 17:55 | |
| openstackgerrit | Cale Rath proposed openstack/nova: Purge soft-deleted instances cmd https://review.openstack.org/203751 | 17:55 |
| *** vilobhmm1 has joined #openstack-nova | 17:55 | |
| *** dustins has quit IRC | 17:56 | |
| *** tsekiyama has joined #openstack-nova | 17:56 | |
| *** signed8bit is now known as signed8bit_ZZZzz | 17:56 | |
| *** oomichi has quit IRC | 17:58 | |
| *** vilobhmm11 has quit IRC | 17:58 | |
| *** penick has joined #openstack-nova | 17:58 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: _create_domain_setup_lxc needs to default disk mapping as a dict https://review.openstack.org/214927 | 17:59 |
| dims | mriedem: we can for M | 17:59 |
| mriedem | dims: sure | 18:00 |
| *** gyee has joined #openstack-nova | 18:00 | |
| *** gyee has quit IRC | 18:00 | |
| *** VW_ has joined #openstack-nova | 18:01 | |
| *** gyee has joined #openstack-nova | 18:03 | |
| *** meghal has quit IRC | 18:04 | |
| *** signed8bit_ZZZzz is now known as signed8bit | 18:06 | |
| *** lpetrut has quit IRC | 18:06 | |
| *** worship has joined #openstack-nova | 18:10 | |
| *** worship has left #openstack-nova | 18:10 | |
| *** SourabhP has joined #openstack-nova | 18:10 | |
| *** bapalm has quit IRC | 18:11 | |
| rlrossit | mriedem: so should I move forward with a fix for nova for now? | 18:11 |
| *** bapalm has joined #openstack-nova | 18:14 | |
| *** angdraug has quit IRC | 18:14 | |
| *** nic has joined #openstack-nova | 18:14 | |
| *** burgerk has quit IRC | 18:16 | |
| *** whenry_ has joined #openstack-nova | 18:17 | |
| *** armax has quit IRC | 18:18 | |
| *** rdopiera has quit IRC | 18:18 | |
| *** vivek_nandavanam has quit IRC | 18:18 | |
| *** moshele has quit IRC | 18:21 | |
| *** vivekd has quit IRC | 18:21 | |
| jaypipes | cfriesen: reviewed. | 18:22 |
| melwitt | bauzas: I just saw your tweet. you don't think AZs are for providing application availability by spreading across zones? | 18:23 |
| cfriesen | jaypipes: thanks. trying to sort out your comment. We did run into problems with this constant, and we did have to make it bigger. (I | 18:24 |
| *** achanda has quit IRC | 18:24 | |
| *** oomichi has joined #openstack-nova | 18:25 | |
| cfriesen | jaypipes: we currently have it hardcoded to 0xff | 18:25 |
| cfriesen | jaypipes: let me dig up the original bug report | 18:26 |
| jaypipes | cfriesen: just set your whitelist values to *. That MAX_FUNC value is only ever used when reading the CONF.pci_passthrough_whitelist values. | 18:26 |
| *** fawadk has quit IRC | 18:27 | |
| *** signed8bit is now known as signed8bit_ZZZzz | 18:27 | |
| *** tbh has quit IRC | 18:27 | |
| *** ftersin_ has quit IRC | 18:27 | |
| *** signed8bit_ZZZzz is now known as signed8bit | 18:28 | |
| *** meghal has joined #openstack-nova | 18:28 | |
| *** tonytan4ever has quit IRC | 18:29 | |
| bauzas | melwitt: yes I do, but there is a big difference between providing segregation and failure isolation | 18:30 |
| bauzas | melwitt: because AZs are on the same controlplane, right? | 18:31 |
| cfriesen | jaypipes: you mean set the func portion of the PCI whitelist to *? (sorry, not my area of expertise) | 18:31 |
| mriedem | rlrossit: sure | 18:31 |
| bauzas | melwitt: so, saying that AZs will prevent you from a failure is just a pony story | 18:31 |
| mriedem | we can always -2 it :) | 18:31 |
| *** mingy has quit IRC | 18:32 | |
| bauzas | melwitt: we even don't isolate the network, right ? 2 AZs can be on the same subnet nope ? | 18:32 |
| jaypipes | cfriesen: yeah (or just set address to *:*:*.* | 18:32 |
| melwitt | bauzas: yes, it won't save you from everything | 18:32 |
| * bauzas wonders how AZs are isolated from a Neutron POV | 18:32 | |
| *** kiran-r has joined #openstack-nova | 18:33 | |
| bauzas | melwitt: so, that's an unicorn to say that OpenStack AZs are about failure domains - that's not true, hence my very angried ping | 18:33 |
| bauzas | melwitt: that said, I know that jaypipes has a dream | 18:33 |
| cfriesen | jaypipes: but what if I don't want to whitelist all the functions? (like some are in use by the host)? | 18:33 |
| bauzas | and I second him on that | 18:33 |
| bauzas | but I just wonder if cells can't be our unicorn for having separate failure domains | 18:34 |
| melwitt | bauzas: yeah, I don't know how/if one can designate different subnets to different AZs. I hope that's possible | 18:34 |
| jaypipes | cfriesen: there very well *could* be bugs in this stuff, but I'm pretty sure the patch poster is confusing the FUNC in the PCI configuration address with the SR-IOV VF identifier (which is quite different and is like the composite of the slot, the func identifier, and the bus. | 18:34 |
| cfriesen | jaypipes: yeah, the commit message could easily be messed up. | 18:34 |
| *** Sukhdev has joined #openstack-nova | 18:34 | |
| *** jwcroppe has joined #openstack-nova | 18:35 | |
| cfriesen | jaypipes: will get someone to take a look | 18:35 |
| jaypipes | cfriesen: what does `sudo virsh nodedev-list | grep pci` show you? | 18:35 |
| *** dave-mcc_ has joined #openstack-nova | 18:36 | |
| alaski | bauzas: cells provides more separation, but it isn't complete. there's still a shared global db at the top | 18:36 |
| melwitt | bauzas: I think I understand your view now. AZs can provide some resiliency to failure but it's not a catch all | 18:37 |
| *** dustins has joined #openstack-nova | 18:37 | |
| bauzas | alaski: sure, that's just a better place for talking about failure domains than AZs | 18:37 |
| *** davideagnello has quit IRC | 18:38 | |
| *** VW_ has quit IRC | 18:38 | |
| bauzas | alaski: to be clear, I'm making a distinction between a failure domain and resiliency | 18:38 |
| openstackgerrit | Ahilan Rajadeva proposed openstack/nova: Update to the reworked monitor plugin interface to pass in the MonitorMetric Object. https://review.openstack.org/214772 | 18:38 |
| bauzas | alaski: having failure domains doesn't mean your cloud is resilient, you can still have SPOFs | 18:38 |
| *** davideagnello has joined #openstack-nova | 18:39 | |
| *** dave-mccowan has quit IRC | 18:39 | |
| bauzas | alaski: that just means that if a crucial component is failing, the whole set will drop down | 18:39 |
| *** angdraug has joined #openstack-nova | 18:39 | |
| *** signed8bit is now known as signed8bit_ZZZzz | 18:39 | |
| alaski | bauzas: sure. but there's still a point that can take out all the cells | 18:39 |
| alaski | but it's still a better situation than now | 18:39 |
| bauzas | alaski: sure, but at least you have a consistent view of a possible failure for your whole cell that wouldn't impact the other cell | 18:40 |
| cfriesen | jaypipes: trying to track down a system configured appropriately | 18:40 |
| jaypipes | cfriesen: k. pastebin it when you've found one :) | 18:40 |
| bauzas | alaski: that's why I'm saying that's a failure domain, not a resiliency stuff | 18:41 |
| jaypipes | cfriesen: FYI, the term "FUNC" in the PCI configuration address was an unfortunate pick. :) | 18:41 |
| *** signed8bit_ZZZzz is now known as signed8bit | 18:41 | |
| *** lucasagomes is now known as lucas-dinner | 18:43 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Move CPU and RAM allocation ratios to ResourceTracker https://review.openstack.org/215278 | 18:43 |
| *** dannywilson has quit IRC | 18:44 | |
| *** dannywilson has joined #openstack-nova | 18:46 | |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: cleanup NovaObjectDictCompat from quota https://review.openstack.org/215078 | 18:48 |
| alaski | bauzas: I see. a cell is a failure domain, but it's within a larger failure domain of a region | 18:48 |
| *** whenry_ has quit IRC | 18:48 | |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: cleanup NovaObjectDictCompat from hv_spec https://review.openstack.org/215094 | 18:49 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: cleanup NovaObjectDictCompat from hv_spec https://review.openstack.org/215094 | 18:49 |
| rlrossit | oh mriedem, also remember that https://review.openstack.org/#/c/197135/ exists :) | 18:49 |
| *** davidlenwell has quit IRC | 18:50 | |
| *** davideag_ has joined #openstack-nova | 18:50 | |
| cfriesen | jaypipes: I tracked down our original bug report, it contained the following: http://paste.openstack.org/show/422746/ note the addresses as high as 0000:04:10.14 Now I suppose it's possible we're doing something wrong with setting up the whitelist... | 18:51 |
| *** davidlenwell has joined #openstack-nova | 18:51 | |
| *** davideagnello has quit IRC | 18:52 | |
| *** kiran-r has quit IRC | 18:53 | |
| *** oomichi has quit IRC | 18:53 | |
| *** meghal has quit IRC | 18:54 | |
| *** shyama has quit IRC | 18:55 | |
| *** afazekas has joined #openstack-nova | 18:55 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Move CPU and RAM allocation ratios to ResourceTracker https://review.openstack.org/215278 | 18:56 |
| *** ociuhandu has quit IRC | 18:58 | |
| *** davidlenwell has quit IRC | 18:58 | |
| jaypipes | cfriesen: if you run `lspci | cut -d' ' -f1` on your machine, pretty sure you won't see a value above 7 for the final field :) | 18:58 |
| *** davidlenwell has joined #openstack-nova | 18:59 | |
| mriedem | rlrossit: yeah yeah | 19:01 |
| mriedem | sheehs | 19:01 |
| rlrossit | mriedem: I know I can bug you about it because it's not possible for you to get any more annoyed at me :) | 19:01 |
| mriedem | rlrossit: try peeing on my living room floor | 19:02 |
| *** meghal has joined #openstack-nova | 19:02 | |
| *** afazekas has quit IRC | 19:03 | |
| jaypipes | cfriesen: note that the domain part of the PCI address space doesn't show if your system only has domain 0. To show it always, do `lspci -D | cut -d' ' -f1` | 19:04 |
| *** dannywilson has quit IRC | 19:04 | |
| *** dannywilson has joined #openstack-nova | 19:05 | |
| openstackgerrit | Brian Elliott proposed openstack/nova: Don't "lock" the DB on expand dry run https://review.openstack.org/215288 | 19:07 |
| openstackgerrit | Jay Pipes proposed openstack/nova: Allow compute monitors in different namespaces https://review.openstack.org/209499 | 19:07 |
| *** achanda has joined #openstack-nova | 19:08 | |
| jaypipes | ahilan: yay! just saw your patch :) will review shortly. | 19:10 |
| *** emagana has quit IRC | 19:10 | |
| *** dannywilson has quit IRC | 19:10 | |
| *** dannywilson has joined #openstack-nova | 19:10 | |
| ahilan | jaypipes: Thanks :-) | 19:10 |
| bauzas | jaypipes: I think you should be interested in https://review.openstack.org/#/c/215278/ | 19:10 |
| jaypipes | bauzas: you wrote that, so ... nope. | 19:11 |
| jaypipes | :P | 19:11 |
| bauzas | jaypipes: DB upgrade and object bump are following | 19:11 |
| bauzas | jaypipes: arrrgh | 19:11 |
| cfriesen | jaypipes: thanks for the clarification. it's looking like we may have had a bug generating the whitelist (since fixed) which led to the issue with exceeding the MAX_FUNC value. | 19:11 |
| jaypipes | bauzas: coolio, thanks for tackling this! | 19:11 |
| bauzas | jaypipes: I'm in the US, I can ask the crew to make a stop by Florida :p | 19:11 |
| jaypipes | cfriesen: no worries, mate, lemme know if you need assistance on anything further. happy to help. | 19:11 |
| jaypipes | bauzas: :) | 19:12 |
| *** oomichi has joined #openstack-nova | 19:21 | |
| *** zul has quit IRC | 19:23 | |
| *** dims_ has joined #openstack-nova | 19:26 | |
| *** vishwana_ has joined #openstack-nova | 19:26 | |
| *** meghal has quit IRC | 19:27 | |
| *** ijw_ has joined #openstack-nova | 19:27 | |
| *** signed8bit is now known as signed8bit_ZZZzz | 19:27 | |
| *** ttx has quit IRC | 19:27 | |
| *** rex_lee has quit IRC | 19:27 | |
| *** jamielennox|away has quit IRC | 19:27 | |
| *** signed8bit_ZZZzz is now known as signed8bit | 19:28 | |
| *** dims has quit IRC | 19:28 | |
| *** DuncanT has quit IRC | 19:28 | |
| *** ijw has quit IRC | 19:28 | |
| *** adam_g has quit IRC | 19:28 | |
| *** oomichi has quit IRC | 19:28 | |
| *** davidlenwell has quit IRC | 19:28 | |
| *** r-daneel has quit IRC | 19:28 | |
| *** vishwanathj has quit IRC | 19:28 | |
| *** dguitarbite has quit IRC | 19:28 | |
| *** serverascode has quit IRC | 19:28 | |
| *** toan has quit IRC | 19:28 | |
| *** toan has joined #openstack-nova | 19:29 | |
| *** irenab has quit IRC | 19:29 | |
| *** dave-mccowan has joined #openstack-nova | 19:30 | |
| *** davidlenwell has joined #openstack-nova | 19:31 | |
| *** DuncanT has joined #openstack-nova | 19:31 | |
| *** meghal has joined #openstack-nova | 19:31 | |
| sudipto | ahilan, Just looking at your patch...trying to understand, what advantage does it give us to pass the monitormetric object as a method argument? :) | 19:32 |
| *** serverascode has joined #openstack-nova | 19:32 | |
| *** signed8bit is now known as signed8bit_ZZZzz | 19:32 | |
| *** dave-mcc_ has quit IRC | 19:33 | |
| *** VW_ has joined #openstack-nova | 19:33 | |
| *** ttx has joined #openstack-nova | 19:33 | |
| *** meghal has quit IRC | 19:33 | |
| *** achanda has quit IRC | 19:34 | |
| *** rex_lee has joined #openstack-nova | 19:34 | |
| *** yassine has quit IRC | 19:36 | |
| *** adam_g has joined #openstack-nova | 19:36 | |
| *** adam_g has quit IRC | 19:36 | |
| *** adam_g has joined #openstack-nova | 19:36 | |
| *** signed8bit_ZZZzz is now known as signed8bit | 19:36 | |
| *** Marga_ has quit IRC | 19:40 | |
| ahilan | sudipto: this allows metric plugin to set the MonitorMetric fields and not the base | 19:41 |
| *** meghal has joined #openstack-nova | 19:41 | |
| *** Marga_ has joined #openstack-nova | 19:41 | |
| *** dguitarbite has joined #openstack-nova | 19:41 | |
| *** salv-orlando has joined #openstack-nova | 19:41 | |
| sudipto | ahilan, yeah my question is - if we instantiate the object inside the populate_metrics_object - will it not work? | 19:42 |
| sudipto | i guess that way the populate_metrics_object name could change to get_metrics_object or something...just a thought :) | 19:42 |
| *** VW_ has quit IRC | 19:43 | |
| ahilan | Sudipto: So if we add new fields to MonitorMetric Object, then each metric plugin can update their field in their metric plugin code and no need to modify the base | 19:43 |
| *** VW_ has joined #openstack-nova | 19:43 | |
| *** r-daneel has joined #openstack-nova | 19:44 | |
| sudipto | ahilan, hmm i got the intent...i didn't mean that - i just meant - if your metric_object instantiation could have been just done inside each plugin (then like you said - the plugin anyway knows what to populate it with)...nevermind! | 19:44 |
| *** sudipto has quit IRC | 19:46 | |
| mriedem | apmelton: good news, i was able to bring up a devstack with lxc | 19:46 |
| mriedem | that exceeded my expectations | 19:46 |
| *** Vek has quit IRC | 19:46 | |
| apmelton | woo! | 19:46 |
| apmelton | haha | 19:46 |
| *** Vek has joined #openstack-nova | 19:47 | |
| *** armax has joined #openstack-nova | 19:47 | |
| *** alejandrito has quit IRC | 19:47 | |
| mriedem | bad news is, nova boot fails with NoValidHost :) | 19:47 |
| *** jamielennox|away has joined #openstack-nova | 19:47 | |
| apmelton | :/ | 19:47 |
| *** jamielennox|away is now known as jamielennox | 19:47 | |
| *** VW_ has quit IRC | 19:48 | |
| apmelton | mriedem: did you run "sudo modprobe nbd"? | 19:48 |
| mriedem | nope | 19:49 |
| *** alejandrito has joined #openstack-nova | 19:49 | |
| openstackgerrit | Ryan Rossiter proposed openstack/nova: Search for more keys when clearing passwords https://review.openstack.org/215308 | 19:51 |
| openstackgerrit | j_king proposed openstack/nova: libvirt: Add wait for vif unplug events on destroy https://review.openstack.org/210126 | 19:51 |
| *** setuid has quit IRC | 19:52 | |
| openstackgerrit | Brian Haley proposed openstack/nova: Disable IPv6 on bridge devices https://review.openstack.org/198054 | 19:53 |
| openstackgerrit | Andrew Melton proposed openstack/nova: libvirt: refactor _create_domain_setup_lxc to use Image.get_model https://review.openstack.org/215310 | 19:53 |
| openstackgerrit | Andrew Melton proposed openstack/nova: virt: allow for direct mounting of LocalBlockImages https://review.openstack.org/215311 | 19:53 |
| apmelton | mriedem: ^^ | 19:53 |
| apmelton | I'm not sure if devstack supports the LVM image backend for Nova, but with those patches Nova will skip nbd when using the LVM backend | 19:54 |
| *** andreykurilin__ has quit IRC | 19:55 | |
| *** jichen has joined #openstack-nova | 19:56 | |
| *** setuid has joined #openstack-nova | 19:59 | |
| *** ssurana has quit IRC | 20:02 | |
| *** tjones1 has joined #openstack-nova | 20:03 | |
| *** ssurana has joined #openstack-nova | 20:03 | |
| *** annegentle has quit IRC | 20:04 | |
| *** annegentle has joined #openstack-nova | 20:04 | |
| *** IanGovett has quit IRC | 20:06 | |
| *** tjones1 has left #openstack-nova | 20:08 | |
| *** alejandrito has quit IRC | 20:09 | |
| *** browne has quit IRC | 20:11 | |
| *** artom has joined #openstack-nova | 20:12 | |
| *** browne has joined #openstack-nova | 20:12 | |
| *** achanda has joined #openstack-nova | 20:13 | |
| *** alejandrito has joined #openstack-nova | 20:13 | |
| *** irenab has joined #openstack-nova | 20:15 | |
| *** irenab has quit IRC | 20:15 | |
| *** ajayaa has quit IRC | 20:19 | |
| *** achanda has quit IRC | 20:19 | |
| *** emagana has joined #openstack-nova | 20:20 | |
| mriedem | apmelton: sudo modprobe nbd fixed the boot | 20:20 |
| mriedem | i need to get that into devstack | 20:20 |
| *** ndipanov has joined #openstack-nova | 20:20 | |
| apmelton | mriedem: good to hear | 20:21 |
| *** VW_ has joined #openstack-nova | 20:22 | |
| *** jichen has quit IRC | 20:24 | |
| *** exploreshaifali has quit IRC | 20:30 | |
| alaski | mriedem: I just hit an instance of https://bugs.launchpad.net/neutron/+bug/1485969. should I just recheck, or is a e-r change needed as well? | 20:30 |
| openstack | Launchpad bug 1485969 in neutron "test_dualnet_multi_prefix_dhcpv6_stateless failed due to "RuntimeError: Set changed size during iteration" in quota code" [Undecided,In progress] - Assigned to Ihar Hrachyshka (ihar-hrachyshka) | 20:30 |
| mriedem | recheck | 20:30 |
| mriedem | i need to get the e-r query up | 20:30 |
| *** VW_ has quit IRC | 20:30 | |
| *** VW_ has joined #openstack-nova | 20:31 | |
| alaski | ok. I saw the failure on the test volume boot pattern test in Nova | 20:31 |
| mriedem | yeah, it's a recent failure | 20:31 |
| *** achanda has joined #openstack-nova | 20:32 | |
| *** meghal has quit IRC | 20:33 | |
| *** Sukhdev has quit IRC | 20:34 | |
| *** meghal has joined #openstack-nova | 20:35 | |
| *** ndipanov has quit IRC | 20:35 | |
| *** VW_ has quit IRC | 20:35 | |
| *** signed8bit is now known as signed8bit_ZZZzz | 20:37 | |
| bauzas | melwitt: alaski: meh, hitting http://logs.openstack.org/78/215278/2/check/gate-tempest-dsvm-cells/a55bcab/logs/screen-n-cell-region.txt.gz?level=TRACE | 20:39 |
| *** alex_klimov has joined #openstack-nova | 20:39 | |
| bauzas | melwitt: alaski: this is not something I remember | 20:39 |
| melwitt | has anyone seen before mock not working as expected running unit tests with the py34 env? I'm seeing a thing where I set side_effect=[..., ..., ..., ...] and the first call of the mocked function isn't returning the thing I put in side_effect | 20:39 |
| *** zul has joined #openstack-nova | 20:39 | |
| mriedem | apmelton: nice, nova stop lxc-test - killed the connection to my devstack vm | 20:39 |
| bauzas | melwitt: alaski: but I was pretty off the cells bus for the last 3 months so I probably missed that | 20:39 |
| apmelton | mriedem: D: yea, I haven't quite figured that one out yet | 20:40 |
| bauzas | melwitt: mmm, none I've seen and tho I had some problems :) | 20:40 |
| bauzas | (now speaking of the side_effect) | 20:40 |
| mriedem | apmelton: oh double nice, now i can't get back in via ssh | 20:41 |
| mriedem | suweeet | 20:41 |
| alaski | bauzas: that would be due to https://review.openstack.org/#/c/202593/. it's not a problem unless it happens multiple times for the same db update. right now it's exposing races that were hidden before | 20:41 |
| mriedem | thanks nbd | 20:41 |
| *** signed8bit_ZZZzz is now known as signed8bit | 20:41 | |
| apmelton | mriedem: should have warned ya to make sure you had a second way in | 20:41 |
| *** boris-42 has joined #openstack-nova | 20:41 | |
| bauzas | alaski: oh | 20:43 |
| *** thangp has quit IRC | 20:43 | |
| bauzas | alaski: any referenced bug that I could recheck against ? | 20:43 |
| alaski | bauzas: did it cause a failure? | 20:44 |
| bauzas | alaski: yep | 20:44 |
| bauzas | alaski: https://review.openstack.org/#/c/215278/ | 20:44 |
| alaski | bauzas: I'm not aware of an open bug for it. I haven't seen it cause a failure yet | 20:44 |
| alaski | hadn't | 20:44 |
| bauzas | lemme recheck and see | 20:45 |
| bauzas | I seriously don't think my change can't be responsible for that :) | 20:45 |
| melwitt | alaski: I'm glad you know what it is because I was looking and coming up with nothing | 20:45 |
| *** gszasz has quit IRC | 20:47 | |
| alaski | melwitt: I helped revert that patch originally so the exception was familiar :) | 20:47 |
| *** emagana has quit IRC | 20:47 | |
| melwitt | nice :) | 20:48 |
| bauzas | okay, so I'm probably unlucky then :) | 20:48 |
| *** exploreshaifali has joined #openstack-nova | 20:48 | |
| apmelton | mriedem: I was poking around devstack and apparently we can set NOVA_BACKEND=LVM, and that'll get everything set up | 20:49 |
| apmelton | I've gotta run for the evening, but I'll start testing out my patchsets with that asap | 20:49 |
| *** armax has quit IRC | 20:49 | |
| mriedem | apmelton: sounds good, thanks | 20:50 |
| mriedem | dims_: do you remember the way to run a specific nova change from devstack? i thought that was by setting the NOVA_BRANCH var in stackrc | 20:50 |
| mriedem | mtreinish: ^ if you're around | 20:50 |
| *** meghal has quit IRC | 20:50 | |
| alaski | bauzas: I don't think it's related to those TRACES. the failure is http://logs.openstack.org/78/215278/2/check/gate-tempest-dsvm-cells/a55bcab/logs/screen-n-api.txt.gz#_2015-08-20_19_39_28_303 | 20:51 |
| alaski | and that instance isn't in any of the trace logs | 20:51 |
| dims_ | mriedem: one sec | 20:52 |
| *** ivasev has quit IRC | 20:53 | |
| dims_ | NOVA_REPO=https://review.openstack.org/p/openstack/nova | 20:54 |
| dims_ | NOVA_BRANCH=refs/changes/50/5050/1 | 20:54 |
| dims_ | mriedem: is that what you are looking for? | 20:54 |
| mriedem | dims_: yup, perfect, thanks | 20:55 |
| bauzas | alaski: that's not related to my change either :) | 20:55 |
| bauzas | anyway, I won't take too much time on that one, let's see what a anonym recheck does (booh) | 20:55 |
| melwitt | lifeless: are you aware of any issues with setting a mock side_effect = [Mock(), Mock(), Mock(), Mock()] in py34? I have a test where it works fine in py27 but in py34 the first call of the mocked function calls through and doesn't return the Mock() I set in side_effect. am I doing something wrong? | 20:57 |
| *** achanda has quit IRC | 20:57 | |
| *** achanda_ has joined #openstack-nova | 20:57 | |
| bauzas | melwitt: haypo is on your TZ today | 20:59 |
| bauzas | melwitt: he could probably help you with that | 20:59 |
| bauzas | melwitt: did you reproduced locally ? | 21:00 |
| *** dannywil_ has joined #openstack-nova | 21:00 | |
| melwitt | bauzas: yeah I'm only seeing it locally, that is, I haven't uploaded what I've got yet because it's failing locally | 21:00 |
| *** ndipanov has joined #openstack-nova | 21:01 | |
| bauzas | melwitt: okay, any paste I could look at ? | 21:02 |
| *** dannywilson has quit IRC | 21:03 | |
| bauzas | melwitt: what's strange with your comment is that [Mock(), Mock(), Mock(), Mock()] is not callable, right? | 21:04 |
| bauzas | side_effect is waiting a callable AFAIK | 21:04 |
| *** meghal has joined #openstack-nova | 21:05 | |
| alaski | I thought it wanted an iterable? | 21:05 |
| *** aysyd has quit IRC | 21:06 | |
| melwitt | yeah, I'm doing this style https://docs.python.org/3/library/unittest.mock.html#quick-guide | 21:06 |
| melwitt | >>> mock.side_effect = [5, 4, 3, 2, 1] | 21:06 |
| * melwitt assembling a paste | 21:06 | |
| bauzas | melwitt: my bad, it accepts an iterable https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.side_effect | 21:07 |
| bauzas | melwitt: but if an iterable, then you have to yield | 21:08 |
| bauzas | melwitt: I guess you want to mock 3 calls of the same method for example ? | 21:09 |
| melwitt | bauzas: right. | 21:09 |
| *** yamahata has joined #openstack-nova | 21:10 | |
| bauzas | melwitt: so with 3 different results? | 21:10 |
| bauzas | melwitt: because here, you actually don't care about the result, all of them are mocks | 21:11 |
| bauzas | melwitt: if so, just provide a function which returns a mock, that will work everytime | 21:11 |
| haypo | melwitt: i recall vaguely a change on side_effect with list. don't use side_effect with a list :) | 21:13 |
| melwitt | bauzas: thanks for the suggestion, I'll try that | 21:13 |
| haypo | melwitt: or use .return_value, sorry i didn't read the whole discussion | 21:14 |
| melwitt | haypo: the current docs shows it as a valid way to use https://docs.python.org/3/library/unittest.mock.html#quick-guide so I'd be interested in what's different now | 21:14 |
| haypo | melwitt: unittest.mock is in python 3.3+, but nova uses the third party mock module on python 2. there are subtle differences between the two modules | 21:15 |
| haypo | as the one you hitted | 21:15 |
| bauzas | melwitt: yeah, return_value is even better for an identical result | 21:15 |
| *** dprince has quit IRC | 21:16 | |
| melwitt | haypo: I understand that, but isn't the doc I just linked talking about the python 3 builtin? that's where I'm hitting the problem. py27 works for me | 21:16 |
| haypo | m.side_effect=[1,2]; [m(), m()]) must return [1, 2] | 21:16 |
| *** thorst has quit IRC | 21:16 | |
| *** meghal has quit IRC | 21:17 | |
| haypo | melwitt: can i see your code? do you have a paste? | 21:17 |
| *** derekh has joined #openstack-nova | 21:17 | |
| dims_ | melwitt: works for me - http://paste.openstack.org/show/422763/ | 21:17 |
| dims_ | melwitt: can you try the same as haypo pasted? | 21:18 |
| *** zul has quit IRC | 21:18 | |
| *** erlon has quit IRC | 21:18 | |
| haypo | i have the same behaviour on python 3.4 (unittest.mock) and python 2.7 (mock 1.0 and mock 1.3) | 21:20 |
| melwitt | haypo dims_: this is what I have http://pastebin.com/DCYQRck7 | 21:20 |
| *** annegentle has quit IRC | 21:20 | |
| *** annegentle has joined #openstack-nova | 21:20 | |
| haypo | melwitt: i don't understand why you use side_effect with a list of mocks. if you don't reuse mocks, use side_effect=lambda: mock.Mock(), or simply side_effect=mock.Mock | 21:21 |
| *** eharney has quit IRC | 21:21 | |
| melwitt | haypo: yeah, I realized from bauzas suggestion that I can do it another way. I just thought what I had before is supposed to also work | 21:22 |
| ericksonsantos | melwitt, I think return_value should be good in your case, unless you want different results | 21:22 |
| *** rfolco has quit IRC | 21:23 | |
| bauzas | melwitt: I think you were probably not calling your mocked method within an iterable | 21:23 |
| bauzas | melwitt: because it's necessary | 21:24 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: only get bdm in _create_domain_setup_lxc if booted from volume https://review.openstack.org/215342 | 21:24 |
| bauzas | or call the .__next__ | 21:24 |
| bauzas | something like mocked.side_effect = [1,2@ | 21:24 |
| bauzas | oops | 21:24 |
| bauzas | [1, 2] | 21:24 |
| bauzas | and thezn | 21:24 |
| bauzas | mocked.__next__() | 21:25 |
| bauzas | mocked.__next__() | 21:25 |
| *** krtaylor has quit IRC | 21:26 | |
| *** armax has joined #openstack-nova | 21:26 | |
| haypo | bauzas: hum? mock.__next__() returns a new mock | 21:27 |
| melwitt | bauzas: yeah, I don't know. the examples show you don't have to | 21:27 |
| melwitt | >>> mock.side_effect = [5, 4, 3, 2, 1] | 21:27 |
| melwitt | >>> mock(), mock(), mock() | 21:27 |
| melwitt | (5, 4, 3) | 21:27 |
| bauzas | anyway, keep it simple I guess | 21:31 |
| mtreinish | mriedem: yeah, what dims_ said | 21:32 |
| mriedem | still stacking | 21:32 |
| *** dustins has quit IRC | 21:32 | |
| *** vilobhmm1 has quit IRC | 21:34 | |
| alaski | melwitt: I've used it the way you tried to, there are other examples of that in the Nova codebase. so the concept in theory shoudl be working | 21:34 |
| *** lucas-dinner has quit IRC | 21:34 | |
| *** ahilan has quit IRC | 21:34 | |
| *** ndipanov has quit IRC | 21:35 | |
| *** rlrossit has left #openstack-nova | 21:35 | |
| *** Piet has joined #openstack-nova | 21:35 | |
| melwitt | hm, fails the same way with side_effect=lambda *a, **k: mock.Mock() in py34 only. I did not expect that | 21:35 |
| melwitt | first call goes through to the real code even though I mocked the function being called | 21:36 |
| *** vilobhmm1 has joined #openstack-nova | 21:36 | |
| *** vilobhmm11 has joined #openstack-nova | 21:37 | |
| *** smatzek has quit IRC | 21:38 | |
| *** dannywil_ has quit IRC | 21:40 | |
| *** vilobhmm1 has quit IRC | 21:40 | |
| *** ccarmack has left #openstack-nova | 21:40 | |
| *** annegentle has quit IRC | 21:42 | |
| *** VW_ has joined #openstack-nova | 21:43 | |
| *** edmondsw has quit IRC | 21:44 | |
| bauzas | melwitt: mmm | 21:48 |
| bauzas | melwitt: weirod | 21:48 |
| bauzas | weirdo even | 21:48 |
| bauzas | melwitt: failback to return_value | 21:48 |
| bauzas | melwitt: I'm tho pretty sure that side_effect is already called by the py34 tests | 21:49 |
| melwitt | bauzas: yeah :( I thought about it but I think that can't work if I need a new instance for every call. else I have to rethink my test. I'm trying to test whether I get a new thing back vs a cached thing | 21:49 |
| *** alejandrito has quit IRC | 21:49 | |
| *** bapalm has quit IRC | 21:49 | |
| bauzas | so you wanna mock the instance creation ? | 21:50 |
| bauzas | and give a fake Instance? | 21:50 |
| melwitt | bauzas: I want _create_facade to always return a new/different facade. and that should only happen if a cached facade isn't found | 21:51 |
| bauzas | I see, so yeah a side_effect is needed there IMHO | 21:52 |
| *** bapalm has joined #openstack-nova | 21:52 | |
| *** alejandrito has joined #openstack-nova | 21:52 | |
| *** dannywilson has joined #openstack-nova | 21:54 | |
| *** signed8bit has quit IRC | 21:55 | |
| *** meghal has joined #openstack-nova | 21:55 | |
| *** bapalm has quit IRC | 21:57 | |
| lifeless | melwitt: what implementation of mock are you using ? | 21:58 |
| *** diogogmt_ has joined #openstack-nova | 22:00 | |
| openstackgerrit | Cale Rath proposed openstack/nova: Purge soft-deleted instances cmd https://review.openstack.org/203751 | 22:00 |
| *** diogogmt has quit IRC | 22:00 | |
| *** diogogmt_ is now known as diogogmt | 22:00 | |
| *** burt has quit IRC | 22:02 | |
| *** bapalm has joined #openstack-nova | 22:03 | |
| openstackgerrit | Cale Rath proposed openstack/nova: Purge soft-deleted instances cmd https://review.openstack.org/203751 | 22:04 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Update Flavor obj_reset_changes to match signature https://review.openstack.org/215358 | 22:04 |
| melwitt | lifeless, bauzas: I think I have finally found through more digging that it's not related to mock. the calls are actually different between py27 and py34 because of the different state of a global variable in sqlalchemy/db/api.py between the two envs. sorry about that :( | 22:04 |
| *** claudiub has quit IRC | 22:05 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: WIP: Add BuildRequest table and object https://review.openstack.org/214792 | 22:07 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add persistence to the RequestSpec object https://review.openstack.org/211753 | 22:07 |
| *** bapalm has quit IRC | 22:08 | |
| lifeless | melwitt: np | 22:11 |
| bauzas | melwitt: soooooooo specific :/ | 22:12 |
| bauzas | glad you found it | 22:12 |
| *** bapalm has joined #openstack-nova | 22:14 | |
| melwitt | bauzas: at least I have the lambda returning the Mock() now! better than the list :) | 22:16 |
| *** oomichi has joined #openstack-nova | 22:17 | |
| *** krtaylor has joined #openstack-nova | 22:18 | |
| mriedem | alaski: is https://review.openstack.org/#/c/215358/ fixing a bug or you're going to build on that? | 22:18 |
| *** bapalm has quit IRC | 22:19 | |
| *** ctrath has quit IRC | 22:20 | |
| *** annegentle has joined #openstack-nova | 22:20 | |
| *** zul has joined #openstack-nova | 22:26 | |
| *** oomichi has quit IRC | 22:26 | |
| *** alex_klimov has quit IRC | 22:28 | |
| *** jecarey has quit IRC | 22:28 | |
| *** exploreshaifali_ has joined #openstack-nova | 22:29 | |
| *** bapalm has joined #openstack-nova | 22:29 | |
| *** exploreshaifali_ has quit IRC | 22:30 | |
| *** exploreshaifali has quit IRC | 22:31 | |
| *** thorst has joined #openstack-nova | 22:32 | |
| *** annegentle has quit IRC | 22:33 | |
| *** annegentle has joined #openstack-nova | 22:33 | |
| *** tpeoples has quit IRC | 22:34 | |
| *** bapalm has quit IRC | 22:34 | |
| *** mriedem is now known as mriedem_away | 22:35 | |
| *** bapalm has joined #openstack-nova | 22:35 | |
| *** annegentle has quit IRC | 22:38 | |
| *** xyang1 has quit IRC | 22:38 | |
| *** flwang1 has quit IRC | 22:39 | |
| *** rfolco has joined #openstack-nova | 22:39 | |
| *** emagana has joined #openstack-nova | 22:40 | |
| *** bapalm has quit IRC | 22:43 | |
| *** bapalm has joined #openstack-nova | 22:43 | |
| bauzas | melwitt: alaski: grrr, just listening a Trove presentation, hearing "so, if using AZs, if your master DB is failing from AZ1, then the slave one will still be good" | 22:44 |
| bauzas | and that said, the presenter is the Trove PTL | 22:44 |
| bauzas | so I think we have a huuuuge problem with leaving people understand what AZs mean in Nova | 22:44 |
| bauzas | sounds like the contract is not fulfilled, and I don't know how to fix that | 22:45 |
| bauzas | I should probably write a blogpost | 22:45 |
| bauzas | jaypipes: ^ | 22:46 |
| *** nic has quit IRC | 22:46 | |
| melwitt | bauzas: that would be interesting. the topic has come up a lot | 22:47 |
| bauzas | now writing a -dev thread | 22:48 |
| *** bapalm has quit IRC | 22:48 | |
| *** dannywilson has quit IRC | 22:48 | |
| *** bapalm has joined #openstack-nova | 22:51 | |
| *** mdrabe has quit IRC | 22:51 | |
| *** VikasC has joined #openstack-nova | 22:53 | |
| *** thorst has quit IRC | 22:55 | |
| *** dannywilson has joined #openstack-nova | 22:57 | |
| *** tsbot_ has quit IRC | 23:01 | |
| *** asettle has joined #openstack-nova | 23:03 | |
| *** ijuwang has quit IRC | 23:05 | |
| *** achanda_ has quit IRC | 23:05 | |
| *** alejandrito has quit IRC | 23:06 | |
| *** diogogmt has quit IRC | 23:12 | |
| *** diogogmt has joined #openstack-nova | 23:14 | |
| *** emagana has quit IRC | 23:14 | |
| *** hemna is now known as hemnafk | 23:16 | |
| *** achanda has joined #openstack-nova | 23:16 | |
| *** dannywilson has quit IRC | 23:19 | |
| *** VW_ has quit IRC | 23:25 | |
| *** zzzeek has quit IRC | 23:25 | |
| *** VW_ has joined #openstack-nova | 23:25 | |
| *** r-daneel has quit IRC | 23:27 | |
| *** flwang1 has joined #openstack-nova | 23:29 | |
| *** dannywilson has joined #openstack-nova | 23:30 | |
| *** VW_ has quit IRC | 23:30 | |
| *** otter768 has joined #openstack-nova | 23:30 | |
| *** VW_ has joined #openstack-nova | 23:34 | |
| *** cfriesen has quit IRC | 23:35 | |
| *** SourabhP has quit IRC | 23:43 | |
| *** angdraug has quit IRC | 23:45 | |
| *** Marga_ has quit IRC | 23:46 | |
| *** salv-orlando has quit IRC | 23:46 | |
| *** Marga_ has joined #openstack-nova | 23:47 | |
| *** dannywilson has quit IRC | 23:56 | |
| *** VW_ has quit IRC | 23:56 | |
| *** VW_ has joined #openstack-nova | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!