| gmann | mriedem: done. and regarding backport to kilo actually cherry-pick do not work as modified file structure has been changed on master. | 00:00 |
|---|---|---|
| *** neiljerram_bb has joined #openstack-nova | 00:01 | |
| *** achanda_ has joined #openstack-nova | 00:02 | |
| *** achanda has quit IRC | 00:05 | |
| *** VW_ has quit IRC | 00:05 | |
| *** rdopiera has quit IRC | 00:05 | |
| *** VW_ has joined #openstack-nova | 00:06 | |
| *** asettle has joined #openstack-nova | 00:07 | |
| *** achanda_ has quit IRC | 00:07 | |
| *** vilobhmm1 has joined #openstack-nova | 00:09 | |
| *** VW_ has quit IRC | 00:10 | |
| *** sachin has quit IRC | 00:11 | |
| *** sachin has joined #openstack-nova | 00:13 | |
| *** VW_ has joined #openstack-nova | 00:18 | |
| *** VW_ has quit IRC | 00:18 | |
| *** VW_ has joined #openstack-nova | 00:19 | |
| *** sachin has quit IRC | 00:27 | |
| *** claudiub has quit IRC | 00:28 | |
| *** vilobhmm1 has quit IRC | 00:29 | |
| *** tsekiyam_ has joined #openstack-nova | 00:29 | |
| *** mtanino has quit IRC | 00:31 | |
| *** tsekiyama has quit IRC | 00:32 | |
| *** tsekiyam_ has quit IRC | 00:34 | |
| *** salv-orl_ has quit IRC | 00:34 | |
| alex_xu | sdague: mikal , the last policy cleanup patch is ready to go https://review.openstack.org/#/c/200382/ | 00:35 |
| *** Piet has joined #openstack-nova | 00:36 | |
| *** shoutm has quit IRC | 00:36 | |
| *** shoutm has joined #openstack-nova | 00:37 | |
| *** penick has quit IRC | 00:42 | |
| *** otter768 has joined #openstack-nova | 00:42 | |
| *** andreykurilin__ has quit IRC | 00:45 | |
| *** dims has joined #openstack-nova | 00:46 | |
| *** dims_ has quit IRC | 00:47 | |
| *** baoli has joined #openstack-nova | 00:49 | |
| *** sachin has joined #openstack-nova | 00:53 | |
| *** baoli has quit IRC | 00:54 | |
| *** Piet has quit IRC | 00:55 | |
| *** gyee has quit IRC | 00:55 | |
| *** dims has quit IRC | 00:56 | |
| *** dims has joined #openstack-nova | 00:56 | |
| *** meghal has quit IRC | 00:58 | |
| *** sachin has quit IRC | 01:00 | |
| *** ctrath has joined #openstack-nova | 01:02 | |
| *** thorst has quit IRC | 01:02 | |
| openstackgerrit | garyk proposed openstack/nova: VMware: Use actual VM state instead of using the instance vm_state https://review.openstack.org/190627 | 01:04 |
| gmann | alex_xu: hi | 01:08 |
| *** zhenguo has joined #openstack-nova | 01:09 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add project-id when list server-groups https://review.openstack.org/209018 | 01:09 |
| *** VW_ has quit IRC | 01:10 | |
| *** y_sawai has joined #openstack-nova | 01:12 | |
| *** meghal has joined #openstack-nova | 01:12 | |
| gmann | alex_xu: regarding https://review.openstack.org/#/c/214311/1/nova/api/openstack/__init__.py | 01:13 |
| *** ssurana has quit IRC | 01:14 | |
| gmann | alex_xu: should we remove CONF.osapi_v21.enabled now or in N as decided recently ? that option does not looks good for v2.1. IMO we should remove that now | 01:14 |
| *** y_sawai has quit IRC | 01:17 | |
| *** SourabhP has quit IRC | 01:17 | |
| alex_xu | gmann: I think we can't, we should deprecated the option first | 01:17 |
| *** SourabhP has joined #openstack-nova | 01:17 | |
| *** SourabhP has quit IRC | 01:17 | |
| alex_xu | gmann: then remove it in M | 01:17 |
| alex_xu | gmann: see line 48, there already have one mark as deprecated | 01:18 |
| *** browne has quit IRC | 01:18 | |
| gmann | alex_xu: yea but i feel we should reconsider that as v3 nerver got released and for v2.1 we should not have that option | 01:18 |
| alex_xu | gmann: but I'm think what happen after we remove v3 from api-paste.ini for enable option | 01:19 |
| gmann | alex_xu: that is being changed to v21 | 01:19 |
| gmann | alex_xu: thats why m worried | 01:19 |
| gmann | on this https://review.openstack.org/#/c/214311/1/nova/api/openstack/__init__.py, option is being changed for v21 | 01:20 |
| *** RuiChen has joined #openstack-nova | 01:20 | |
| gmann | alex_xu: deprecation we did for v3 but as we are going to remove v3 from paste.ini then it has no meaning | 01:21 |
| gmann | alex_xu: and its not valid to make that option for v21 | 01:21 |
| alex_xu | gmann: at least, I think we shouldn't rename them to v21 | 01:21 |
| alex_xu | gmann: but actually extensions_whitelist works for v2.1 | 01:21 |
| gmann | alex_xu: +1. yea that whats my point was | 01:21 |
| alex_xu | gmann: although we call it as v3.extensions_whitelist | 01:22 |
| gmann | alex_xu: yes whitelist, balcklist option we can rename | 01:22 |
| *** moshele has joined #openstack-nova | 01:22 | |
| openstackgerrit | garyk proposed openstack/nova: Host manager: add in missing log hints https://review.openstack.org/214404 | 01:22 |
| alex_xu | gmann: I prefer not rename, we should deprecated or remove them | 01:22 |
| gmann | alex_xu: and when we remove v3 from paste.ini we can decide on CONF.osapi_v3.enabled | 01:22 |
| *** shuquan has joined #openstack-nova | 01:23 | |
| alex_xu | gmann: yea | 01:23 |
| gmann | alex_xu: you mean whitelist, blacklist option also not to rename? | 01:23 |
| *** y_sawai has joined #openstack-nova | 01:23 | |
| alex_xu | gmann: yea, we have plan remove extension, so those option should be removed in the M | 01:24 |
| gmann | alex_xu: yea | 01:24 |
| *** shuquan has quit IRC | 01:24 | |
| alex_xu | gmann: I talk with johnthetubaguy , he think remove option need deprecate first. | 01:24 |
| alex_xu | gmann: if we deprecate them, I think rename is meanless | 01:24 |
| *** ctrath has quit IRC | 01:24 | |
| gmann | but till then we can rename those ans remove/deprecate on extension removal | 01:24 |
| gmann | alex_xu: hummm. nice point | 01:25 |
| alex_xu | gmann: rename also need deprecate I think | 01:25 |
| *** wanghua has joined #openstack-nova | 01:25 | |
| gmann | alex_xu: yea logically yes :) | 01:25 |
| alex_xu | gmann: you rename to v21.extensions_whitelist, you need deprecate v3.extensions_whitelist... | 01:25 |
| *** shuquan has joined #openstack-nova | 01:26 | |
| *** nic has quit IRC | 01:26 | |
| alex_xu | gmann: I still think this isn't something we want to support, why we can't remove them directly | 01:26 |
| gmann | alex_xu: but we can take those exception as v3 never got released | 01:26 |
| gmann | alex_xu: +2, i also think same | 01:26 |
| alex_xu | gmann: yea, for v3.enable, it is good point. | 01:27 |
| alex_xu | gmann: maybe we should bring this up again in next meeting | 01:28 |
| *** y_sawai has quit IRC | 01:28 | |
| *** tjones has quit IRC | 01:29 | |
| gmann | alex_xu: yea | 01:29 |
| *** shuquan has quit IRC | 01:31 | |
| gmann | alex_xu: one more thing to discussed | 01:31 |
| gmann | alex_xu: regarding https://review.openstack.org/#/c/198753/ | 01:32 |
| gmann | alex_xu: if new status code is introduced (500 ->new error code) we do need version bump right? | 01:32 |
| *** Apoorva has quit IRC | 01:34 | |
| *** tjones has joined #openstack-nova | 01:35 | |
| *** sachin has joined #openstack-nova | 01:35 | |
| *** dave-mccowan has quit IRC | 01:36 | |
| *** RuiChen has quit IRC | 01:40 | |
| *** shyu has joined #openstack-nova | 01:41 | |
| *** lyanchih has joined #openstack-nova | 01:41 | |
| alex_xu | gmann: if you see the flow chart in http://docs.openstack.org/developer/nova/api_microversion_dev.html we needn't microversions | 01:41 |
| gmann | alex_xu: yea if it is from existing one. | 01:42 |
| alex_xu | gmann: also there is footnotes | 01:42 |
| *** garyk has quit IRC | 01:42 | |
| gmann | alex_xu: yea, should we fix 500 to most appropriate one or from existing one only | 01:42 |
| gmann | alex_xu: as fixing 500 to new code need version and which will be too small for version bump? | 01:43 |
| *** RuiChen has joined #openstack-nova | 01:46 | |
| *** shuquan has joined #openstack-nova | 01:53 | |
| *** RuiChen has quit IRC | 01:55 | |
| *** y_sawai has joined #openstack-nova | 01:56 | |
| *** eliqiao_pc has joined #openstack-nova | 01:57 | |
| eliqiao_pc | hi prc hackathon hacker , #link https://etherpad.openstack.org/p/hackathon2_all_list | 01:58 |
| *** humble_ has joined #openstack-nova | 01:59 | |
| *** wanghua has quit IRC | 02:00 | |
| *** shuquan has quit IRC | 02:00 | |
| *** y_sawai has quit IRC | 02:02 | |
| *** shane-wang has joined #openstack-nova | 02:02 | |
| *** yuntongjin has joined #openstack-nova | 02:02 | |
| shane-wang | hello | 02:02 |
| shane-wang | https://etherpad.openstack.org/p/hackathon2_all_list | 02:03 |
| *** RuiChen has joined #openstack-nova | 02:04 | |
| *** Piet has joined #openstack-nova | 02:04 | |
| *** haomaiwang has joined #openstack-nova | 02:05 | |
| alex_xu | shane-wang: eliqiao_pc wow, a lot of bugs | 02:05 |
| *** moshele has quit IRC | 02:06 | |
| eliqiao_pc | alex_xu: feel free to take them :) | 02:07 |
| alex_xu | eliqiao_pc: heh | 02:07 |
| *** redbeard has joined #openstack-nova | 02:07 | |
| *** y_sawai has joined #openstack-nova | 02:08 | |
| shane-wang | @alex_xu, please help us remotely | 02:10 |
| *** RuiChen has quit IRC | 02:11 | |
| shane-wang | alex_xu: yes, feel free to take | 02:11 |
| *** diogogmt has joined #openstack-nova | 02:11 | |
| alex_xu | shane-wang: will try, not sure I have enough bandwidth, but I'm happy to help on review | 02:12 |
| alex_xu | shane-wang: is there list for patch ready for review? | 02:13 |
| *** yamahata has quit IRC | 02:14 | |
| *** shaohe_feng has joined #openstack-nova | 02:14 | |
| openstackgerrit | Zhenzan Zhou proposed openstack/nova: filter pre_assigned_dev_names when finding disk dev https://review.openstack.org/214419 | 02:15 |
| *** humble_ has quit IRC | 02:15 | |
| *** RuiChen has joined #openstack-nova | 02:16 | |
| *** wxy_ has joined #openstack-nova | 02:17 | |
| shane-wang | alex_xu: no | 02:18 |
| shane-wang | alex_xu: we're collecting bugs till 10:30am | 02:18 |
| alex_xu | shane-wang: cool | 02:18 |
| *** tjones has quit IRC | 02:18 | |
| alex_xu | gmann: just take a look at tempest failure https://review.openstack.org/#/c/214085/3 | 02:19 |
| alex_xu | gmann: some of failure because tempest have some extra parameter tests, for example test_update_host_with_extra_param | 02:19 |
| alex_xu | gmann: what we can do for it? | 02:19 |
| gmann | alex_xu: yea, m alos checking those | 02:20 |
| gmann | even metadata one is might be tempest issue but need to confirm and fix that | 02:20 |
| gmann | alex_xu: for test_update_host_with_extra_param, i found this is the only test in tempest which checking additional property (but need to confirm) | 02:21 |
| gmann | alex_xu: I ma thinking to update that to catch both error (bad request for v2.1 and v2 and 501 for v2onv21) | 02:22 |
| *** RuiChen has quit IRC | 02:23 | |
| *** yuntongjin1 has joined #openstack-nova | 02:24 | |
| *** yuntongjin has quit IRC | 02:24 | |
| alex_xu | gmann: if we have separated job for v2 on v21, we can skip it for v2.1? | 02:24 |
| *** annegentle has quit IRC | 02:25 | |
| gmann | alex_xu: but as per latest paste.ini all /v2 going to be on v21 code where 501 will be raised | 02:26 |
| *** shuquan has joined #openstack-nova | 02:26 | |
| *** annegentle has joined #openstack-nova | 02:26 | |
| gmann | alex_xu: as that test if valid for /v21 but it change error code when v2 on v21 | 02:27 |
| gmann | alex_xu: i am wondering there will be lot of cases where error code will change for v2 on v21. or m missing something here | 02:28 |
| openstackgerrit | Eli Qiao proposed openstack/nova: API: Handle InstanceUnknownCell exception when doing live-migraion https://review.openstack.org/212965 | 02:29 |
| alex_xu | gmann: actually not change error code, it return success than 400, 501 is returned from compute node I think. Because there isn't extra param check in api layer, then the request send to compute node. compute node return not implement | 02:29 |
| gmann | alex_xu: as for v2 on v21, additional properties are skipped and we do not have python code validation in v2.1 code | 02:29 |
| alex_xu | gmann: yes | 02:30 |
| *** sachin has quit IRC | 02:30 | |
| gmann | alex_xu: then its a issue mean v2onv21 is not same as v2 | 02:30 |
| alex_xu | gmann: I'm afraid few of them may return 500, if there are some underlayer code didn't process extra params correct | 02:30 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Expose keystoneclient's session and auth plugin loading parameters https://review.openstack.org/214423 | 02:30 |
| gmann | alex_xu: yea | 02:30 |
| alex_xu | gmann: I think it is just way for switch v2 to v2.1 smoothly, there isn't way make v2.1 equal to v2 | 02:31 |
| alex_xu | gmann: as we just skip extra params checking, but in the json-schema we still have some validation is strict than v2 | 02:32 |
| *** annegentle has quit IRC | 02:32 | |
| alex_xu | gmann: so v2 on v2.1 isn't equal to v2 exactly | 02:32 |
| *** achanda has joined #openstack-nova | 02:32 | |
| *** RuiChen has joined #openstack-nova | 02:33 | |
| *** unicell has quit IRC | 02:33 | |
| gmann | alex_xu: yea, but in term of extra param (not complete validation) it should be same as we thought when doing relax validation | 02:33 |
| alex_xu | johnthetubaguy: sdague, when you wake up, hope you check those ^ , without validation, we turn some 400 to 2xx. And maybe something will return 500. let me know those is accepted to you or not. But I remember we know this before. | 02:34 |
| openstackgerrit | Eli Qiao proposed openstack/nova: Ironic: Add numa_topology to get_available_resource return values https://review.openstack.org/214425 | 02:35 |
| alex_xu | gmann: emm...sorry, I did't et your last word | 02:35 |
| *** meghal1 has joined #openstack-nova | 02:36 | |
| gmann | alex_xu: means our purpose of relax validation was not to break v2 users which pass extra param | 02:36 |
| alex_xu | gmann: yea, that is our goal | 02:36 |
| gmann | alex_xu: but now on v2onv21 it might not break as return code can be changed | 02:37 |
| gmann | *might break | 02:38 |
| alex_xu | gmann: only for extra params? | 02:38 |
| *** shuquan has quit IRC | 02:38 | |
| gmann | alex_xu: yea | 02:38 |
| *** meghal has quit IRC | 02:38 | |
| *** yuntongjin1 has quit IRC | 02:42 | |
| gmann | alex_xu: johnthetubaguy: sdague : my main worry is when it return 500 or 501 (which were 400 etc on v2 code) which i think is bad | 02:43 |
| *** yuntongjin1 has joined #openstack-nova | 02:43 | |
| gmann | alex_xu: meantime i will check metadata failure. may be those are from tempest side | 02:44 |
| *** shaohe_feng1 has joined #openstack-nova | 02:47 | |
| *** zhihai_s has joined #openstack-nova | 02:47 | |
| alex_xu | gmann: thanks | 02:48 |
| *** shaohe_feng has quit IRC | 02:48 | |
| *** shuquan has joined #openstack-nova | 02:49 | |
| *** salv-orlando has joined #openstack-nova | 02:49 | |
| *** yuntongjin has joined #openstack-nova | 02:51 | |
| *** hakimo_ has joined #openstack-nova | 02:52 | |
| *** shuquan has quit IRC | 02:53 | |
| *** yuntongjin1 has quit IRC | 02:54 | |
| *** hakimo has quit IRC | 02:54 | |
| *** dims has quit IRC | 02:55 | |
| *** yuntongjin2 has joined #openstack-nova | 02:59 | |
| *** dave-mccowan has joined #openstack-nova | 03:00 | |
| *** haomaiwang has quit IRC | 03:01 | |
| *** y_sawai has quit IRC | 03:01 | |
| *** yuntongjin has quit IRC | 03:01 | |
| *** sachin has joined #openstack-nova | 03:01 | |
| *** haomaiwang has joined #openstack-nova | 03:02 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add project-id when list server-groups https://review.openstack.org/209018 | 03:02 |
| openstackgerrit | Tan Lin proposed openstack/nova: Make extra_spec case insensitive https://review.openstack.org/193047 | 03:03 |
| *** asettle is now known as asettle-afk | 03:03 | |
| *** salv-orlando has quit IRC | 03:05 | |
| *** shaohe_feng1 has quit IRC | 03:05 | |
| *** sachin has quit IRC | 03:06 | |
| *** JasonPan has joined #openstack-nova | 03:08 | |
| *** yuntongjin has joined #openstack-nova | 03:08 | |
| openstackgerrit | Jianghua Wang proposed openstack/nova: To expose disk labels in guest for root and ephemeral disks https://review.openstack.org/213094 | 03:08 |
| *** tjones has joined #openstack-nova | 03:09 | |
| *** agireud has joined #openstack-nova | 03:09 | |
| *** browne has joined #openstack-nova | 03:10 | |
| *** yuntongjin2 has quit IRC | 03:11 | |
| openstackgerrit | Eli Qiao proposed openstack/nova: Raise exception Migration earlier in REST API sid https://review.openstack.org/214434 | 03:12 |
| eliqiao_pc | alex_xu: | 03:12 |
| alex_xu | edleafe: ? | 03:12 |
| alex_xu | eliqiao_pc: ? | 03:12 |
| alex_xu | edleafe: sorry, I'm talking with eliqiao_pc... | 03:13 |
| eliqiao_pc | hi alex, #link https://github.com/openstack/nova/blob/master/nova/compute/api.py#L241 | 03:14 |
| eliqiao_pc | it's re https://review.openstack.org/#/c/212965/ | 03:14 |
| eliqiao_pc | check_instance_cell will only raise exception.InstanceUnknownCell and exception.InstanceInvalidState | 03:14 |
| eliqiao_pc | and exception.InstanceInvalidState has been catched in _live_migration() in REST API, right? | 03:15 |
| *** redbeard has quit IRC | 03:15 | |
| *** rodrigods has quit IRC | 03:16 | |
| *** erlon has quit IRC | 03:18 | |
| *** rodrigods has joined #openstack-nova | 03:19 | |
| eliqiao_pc | alex_xu: around ? | 03:19 |
| eliqiao_pc | alex_xu: still around? | 03:19 |
| *** shuquan has joined #openstack-nova | 03:20 | |
| alex_xu | eliqiao_pc: yea, right | 03:20 |
| *** redbeard has joined #openstack-nova | 03:21 | |
| alex_xu | eliqiao_pc: also reviewed https://review.openstack.org/214434, how about we check it more early, check it in the api layer to save extra rpc call | 03:24 |
| eliqiao_pc | alex_xu, that may bring more changes, if we do an extra rpc call to nova_compute , then we do need a new rcp methord? | 03:26 |
| alex_xu | eliqiao_pc: I mean 'save' an extra rpc call | 03:27 |
| *** mrodden has quit IRC | 03:27 | |
| *** raginbajin has quit IRC | 03:27 | |
| alex_xu | eliqiao_pc: currently you still check that in the virt driver, it means conductor will request an rpc call, then will know whether instance include bdm or not. | 03:28 |
| alex_xu | eliqiao_pc: actually the bdm stores in the db, it isn't related to compute node, so we totally can check that in the api layer by getting bdm from db directly | 03:28 |
| *** raginbajin has joined #openstack-nova | 03:29 | |
| eliqiao_pc | alex_xu: okay, I will check if we have already some get such information(bdm) in nova-api layer already... | 03:29 |
| alex_xu | eliqiao_pc: yea, if already get that will be great, the patch will become more easy | 03:30 |
| *** JasonPan has quit IRC | 03:30 | |
| eliqiao_pc | alex_xu: it's re https://review.openstack.org/#/c/212965/ , can you detail your comments | 03:30 |
| eliqiao_pc | alex_xu: what's exceptions will check_instance_cell raise? | 03:31 |
| *** JasonPan has joined #openstack-nova | 03:31 | |
| *** asettle-afk is now known as asettle | 03:31 | |
| alex_xu | eliqiao_pc: InstanceUnknownCell | 03:31 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add project-id when list server-groups https://review.openstack.org/209018 | 03:31 |
| *** logan2 has quit IRC | 03:31 | |
| alex_xu | eliqiao_pc: that means action like start/stop will raise that exception also | 03:32 |
| alex_xu | eliqiao_pc: for those api, we should catch it also | 03:32 |
| eliqiao_pc | alex_xu: okay , get you now. | 03:32 |
| *** shaohe_feng has joined #openstack-nova | 03:32 | |
| alex_xu | eliqiao_pc: but we better to ensure InstanceUnknownCell is expected exception first, I think alaski can give opinion on that | 03:32 |
| *** mrodden has joined #openstack-nova | 03:33 | |
| *** agireud has quit IRC | 03:33 | |
| *** shuquan has quit IRC | 03:34 | |
| *** yuntongjin has quit IRC | 03:34 | |
| eliqiao_pc | alex_xu: ya, I think I need Andrew's comment first before I can do next steps. | 03:35 |
| *** JasonPan has quit IRC | 03:35 | |
| *** kiran-r has joined #openstack-nova | 03:36 | |
| *** kiran-r has quit IRC | 03:36 | |
| *** agireud has joined #openstack-nova | 03:38 | |
| *** yamahata has joined #openstack-nova | 03:40 | |
| *** shaohe_feng1 has joined #openstack-nova | 03:40 | |
| openstackgerrit | Wen Zhi Yu proposed openstack/nova-specs: Spec for nova API blueprint correct-volume-attachment-id-in-nova-api-volumes https://review.openstack.org/214021 | 03:41 |
| *** shaohe_feng has quit IRC | 03:41 | |
| *** diogogmt has quit IRC | 03:42 | |
| *** root____7 has joined #openstack-nova | 03:42 | |
| *** venkat_p has joined #openstack-nova | 03:43 | |
| *** shoutm has quit IRC | 03:45 | |
| *** JasonPan has joined #openstack-nova | 03:46 | |
| root____7 | exit | 03:46 |
| root____7 | quit | 03:46 |
| *** shaohe_feng has joined #openstack-nova | 03:46 | |
| root____7 | d | 03:46 |
| root____7 | can anybody help me please.I am new to IRC client | 03:47 |
| *** haigang has joined #openstack-nova | 03:47 | |
| *** shuquan has joined #openstack-nova | 03:47 | |
| *** unicell has joined #openstack-nova | 03:48 | |
| *** shaohe_feng1 has quit IRC | 03:48 | |
| *** shuquan has quit IRC | 03:54 | |
| *** redbeard has quit IRC | 03:55 | |
| *** shoutm has joined #openstack-nova | 03:56 | |
| *** sachin has joined #openstack-nova | 03:56 | |
| *** redbeard has joined #openstack-nova | 03:57 | |
| *** redbeard has quit IRC | 03:58 | |
| *** redbeard has joined #openstack-nova | 03:58 | |
| *** sachin has quit IRC | 04:00 | |
| openstackgerrit | Shuquan Huang proposed openstack/nova: nova.utils._get_root_helper() should be public https://review.openstack.org/207366 | 04:00 |
| *** haomaiwang has quit IRC | 04:01 | |
| *** haomaiwang has joined #openstack-nova | 04:02 | |
| *** chhavi has joined #openstack-nova | 04:03 | |
| *** RuiChen has quit IRC | 04:04 | |
| *** salv-orlando has joined #openstack-nova | 04:04 | |
| *** apuimedo has joined #openstack-nova | 04:05 | |
| *** root____7 has quit IRC | 04:06 | |
| *** zhihai_song has joined #openstack-nova | 04:07 | |
| *** dave-mccowan has quit IRC | 04:07 | |
| *** VikasC has joined #openstack-nova | 04:08 | |
| *** raginbajin has quit IRC | 04:10 | |
| *** zhihai_s has quit IRC | 04:11 | |
| VikasC | reload | 04:17 |
| *** lyanchih has quit IRC | 04:18 | |
| *** otter768 has quit IRC | 04:18 | |
| *** VikasC has quit IRC | 04:19 | |
| *** sachin has joined #openstack-nova | 04:20 | |
| *** otter768 has joined #openstack-nova | 04:20 | |
| *** salv-orlando has quit IRC | 04:21 | |
| *** moshele has joined #openstack-nova | 04:22 | |
| *** VikasC has joined #openstack-nova | 04:26 | |
| *** raginbajin has joined #openstack-nova | 04:28 | |
| *** VikasC has quit IRC | 04:28 | |
| *** otter768 has quit IRC | 04:29 | |
| *** Sree has joined #openstack-nova | 04:31 | |
| *** VikasC has joined #openstack-nova | 04:31 | |
| *** Sree has quit IRC | 04:31 | |
| *** Sree has joined #openstack-nova | 04:32 | |
| *** shaohe_feng has quit IRC | 04:32 | |
| *** shyama has joined #openstack-nova | 04:33 | |
| *** y_sawai has joined #openstack-nova | 04:36 | |
| *** meghal1 has quit IRC | 04:37 | |
| *** y_sawai has quit IRC | 04:42 | |
| *** whitekid has joined #openstack-nova | 04:42 | |
| *** eliqiao_pc has quit IRC | 04:44 | |
| *** eliqiao_pc has joined #openstack-nova | 04:45 | |
| *** coolsvap|away is now known as coolsvap | 04:46 | |
| *** y_sawai has joined #openstack-nova | 04:48 | |
| *** agireud has quit IRC | 04:48 | |
| *** mdrabe has quit IRC | 04:49 | |
| *** deepakcs has joined #openstack-nova | 04:52 | |
| *** meghal has joined #openstack-nova | 04:52 | |
| *** agireud has joined #openstack-nova | 04:55 | |
| *** meghal has quit IRC | 04:56 | |
| *** tjones has quit IRC | 04:57 | |
| *** irenab has quit IRC | 04:58 | |
| *** haomaiwang has quit IRC | 05:01 | |
| *** vivekd has joined #openstack-nova | 05:01 | |
| *** haomaiwa_ has joined #openstack-nova | 05:02 | |
| gmann | alex_xu: hi | 05:04 |
| *** shane-wang has quit IRC | 05:06 | |
| *** shane-wang has joined #openstack-nova | 05:06 | |
| *** coolsvap is now known as coolsvap|away | 05:08 | |
| *** moshele has quit IRC | 05:11 | |
| *** y_sawai has quit IRC | 05:11 | |
| *** redbeard is now known as Guest95303 | 05:14 | |
| *** vilobhmm1 has joined #openstack-nova | 05:14 | |
| *** wanghua has joined #openstack-nova | 05:14 | |
| *** JoshNang has quit IRC | 05:17 | |
| *** y_sawai has joined #openstack-nova | 05:19 | |
| *** boris-42 has quit IRC | 05:20 | |
| *** y_sawai has quit IRC | 05:20 | |
| *** ashishb has joined #openstack-nova | 05:20 | |
| *** coolsvap|away is now known as coolsvap | 05:23 | |
| *** JoshNang has joined #openstack-nova | 05:25 | |
| *** RuiChen has joined #openstack-nova | 05:26 | |
| *** vivekd has quit IRC | 05:28 | |
| *** vivekd_ has joined #openstack-nova | 05:28 | |
| *** vivekd_ is now known as vivekd | 05:28 | |
| *** salv-orlando has joined #openstack-nova | 05:28 | |
| *** chhavi has quit IRC | 05:29 | |
| *** irenab has joined #openstack-nova | 05:30 | |
| *** apuimedo has quit IRC | 05:31 | |
| *** sudipto has joined #openstack-nova | 05:38 | |
| *** Sree_ has joined #openstack-nova | 05:38 | |
| *** Sree_ is now known as Guest17840 | 05:39 | |
| *** Sree has quit IRC | 05:42 | |
| *** sudipto has quit IRC | 05:43 | |
| *** emagana has joined #openstack-nova | 05:45 | |
| *** JasonPan is now known as jasonpan | 05:47 | |
| *** jasonpan has left #openstack-nova | 05:48 | |
| *** jasonpan has joined #openstack-nova | 05:53 | |
| *** claudiub has joined #openstack-nova | 05:55 | |
| *** moshele has joined #openstack-nova | 05:57 | |
| *** jasonpan has quit IRC | 05:58 | |
| *** haomaiwa_ has quit IRC | 06:01 | |
| *** lyanchih has joined #openstack-nova | 06:02 | |
| *** haomaiwa_ has joined #openstack-nova | 06:02 | |
| *** asettle has quit IRC | 06:02 | |
| *** jasonpan has joined #openstack-nova | 06:02 | |
| *** sudipto has joined #openstack-nova | 06:02 | |
| *** venkat_p has quit IRC | 06:03 | |
| *** agireud has quit IRC | 06:04 | |
| *** lpetrut has joined #openstack-nova | 06:05 | |
| *** armax has quit IRC | 06:05 | |
| *** afazkas has joined #openstack-nova | 06:06 | |
| openstackgerrit | ZhuChunzhan proposed openstack/nova: Improve the performance of get evacuated instances from a host which should be destroyed https://review.openstack.org/214464 | 06:08 |
| alex_xu | gmann: hi | 06:08 |
| *** cfriesen has quit IRC | 06:09 | |
| jasonpan | bauzas: Hi | 06:09 |
| *** coolsvap is now known as coolsvap|away | 06:10 | |
| *** kaisers has joined #openstack-nova | 06:10 | |
| *** Murali has joined #openstack-nova | 06:10 | |
| openstackgerrit | ZhuChunzhan proposed openstack/nova: Improve the performance of get evacuated instances from a host which should be destroyed https://review.openstack.org/214464 | 06:10 |
| *** vilobhmm1 has quit IRC | 06:11 | |
| openstackgerrit | Eli Qiao proposed openstack/nova: Correct expected error code for os-resetState action https://review.openstack.org/203930 | 06:12 |
| *** Guest17840 has quit IRC | 06:13 | |
| jasonpan | bauzas: I'm interest in the bug #1452568. I leave the comment. I don't what do you think about it? | 06:14 |
| openstack | bug 1452568 in OpenStack Compute (nova) "nova allows to live-migrate instance from one availability zone to another" [Low,Confirmed] https://launchpad.net/bugs/1452568 - Assigned to Sylvain Bauza (sylvain-bauza) | 06:14 |
| *** Sree has joined #openstack-nova | 06:14 | |
| *** vivekd has quit IRC | 06:17 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Fixes serial port issue on Windows Threshold https://review.openstack.org/192617 | 06:18 |
| *** lsmola has joined #openstack-nova | 06:20 | |
| openstackgerrit | heijlong proposed openstack/nova-specs: Spec for nova API blueprint correct-volume-attachment-id-in-nova-api-volumes https://review.openstack.org/214021 | 06:22 |
| *** mhorban has quit IRC | 06:22 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex https://review.openstack.org/212367 | 06:23 |
| *** y_sawai has joined #openstack-nova | 06:27 | |
| *** ankit_ag has joined #openstack-nova | 06:28 | |
| *** mhorban has joined #openstack-nova | 06:29 | |
| *** markus_z has joined #openstack-nova | 06:30 | |
| *** otter768 has joined #openstack-nova | 06:30 | |
| *** mhorban has left #openstack-nova | 06:31 | |
| *** mhorban has joined #openstack-nova | 06:33 | |
| *** shane-wang1 has joined #openstack-nova | 06:34 | |
| *** achanda has quit IRC | 06:34 | |
| *** shane-wang has quit IRC | 06:34 | |
| *** whenry has joined #openstack-nova | 06:34 | |
| *** otter768 has quit IRC | 06:35 | |
| *** neiljerram_bb has quit IRC | 06:36 | |
| *** SourabhP has joined #openstack-nova | 06:37 | |
| *** nkrinner has joined #openstack-nova | 06:39 | |
| *** scheuran has joined #openstack-nova | 06:40 | |
| *** SourabhP_ has joined #openstack-nova | 06:40 | |
| *** salv-orlando has quit IRC | 06:40 | |
| *** SourabhP has quit IRC | 06:42 | |
| *** SourabhP_ is now known as SourabhP | 06:42 | |
| *** browne has quit IRC | 06:48 | |
| gmann | alex_xu: hi, regarding metadata failure | 06:50 |
| alex_xu | gmann: hi | 06:51 |
| gmann | alex_xu: actually there also error code changed from 400->500 as wrong key falls under extra param in v2.1 validation | 06:51 |
| gmann | alex_xu: as schema file use patternProperty for key too which is correct | 06:52 |
| gmann | alex_xu: https://github.com/openstack/nova/blob/master/nova/api/validation/parameter_types.py#L172 | 06:53 |
| openstackgerrit | Wen Zhi Yu proposed openstack/nova-specs: Spec for nova API blueprint correct-volume-attachment-id-in-nova-api-volumes https://review.openstack.org/214021 | 06:53 |
| gmann | alex_xu: so any wrong key falls under extra key and v2.1 used to consider that additional property and raise validation error | 06:53 |
| gmann | alex_xu: but now as addition property error is relaxed on v2onv21, it return 500 | 06:54 |
| gmann | alex_xu: i think here we need to add python code validation on v2.1 | 06:54 |
| alex_xu | gmann: yea, agree, we need another way to validate it | 06:55 |
| gmann | alex_xu: in most place it will be easy just to capture Invalidmetadata exception | 06:56 |
| gmann | alex_xu: i am preparing patch for that and lets see if that looks fine | 06:56 |
| *** Jeffrey4l has joined #openstack-nova | 06:56 | |
| *** Jeffrey4l has quit IRC | 06:56 | |
| alex_xu | gmann: cool, thanks | 06:56 |
| *** Jeffrey4l_ has joined #openstack-nova | 06:56 | |
| *** Jeffrey4l_ has quit IRC | 06:57 | |
| *** Murali has quit IRC | 06:57 | |
| *** jlvillal has quit IRC | 06:58 | |
| *** jlvillal has joined #openstack-nova | 06:58 | |
| *** StevenK has quit IRC | 06:58 | |
| *** StevenK has joined #openstack-nova | 06:59 | |
| *** VikasC has quit IRC | 06:59 | |
| *** y_sawai has quit IRC | 07:00 | |
| *** Murali has joined #openstack-nova | 07:01 | |
| *** haomaiwa_ has quit IRC | 07:01 | |
| *** haomaiwang has joined #openstack-nova | 07:01 | |
| *** Sree has quit IRC | 07:02 | |
| *** Sree has joined #openstack-nova | 07:03 | |
| openstackgerrit | Rajesh Tailor proposed openstack/nova: Move quota delta reserve methods from api to utils https://review.openstack.org/212374 | 07:05 |
| openstackgerrit | Rui Chen proposed openstack/nova: Fix incorrect result of host-describe https://review.openstack.org/211083 | 07:06 |
| *** kiran-r has joined #openstack-nova | 07:06 | |
| openstackgerrit | Rajesh Tailor proposed openstack/nova: Fix quota-update when nova-compute startup finish https://review.openstack.org/170118 | 07:07 |
| *** Sree has quit IRC | 07:07 | |
| openstackgerrit | Rui Chen proposed openstack/nova: Set task_state=None when booting instance failed https://review.openstack.org/187145 | 07:08 |
| *** ajayaa has joined #openstack-nova | 07:10 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge server list multi status tests between v2 and v2.1 https://review.openstack.org/201387 | 07:10 |
| *** Nikolay_St has joined #openstack-nova | 07:11 | |
| openstackgerrit | Eli Qiao proposed openstack/nova: Scheduler: Send notifier.info in ChanceScheduler https://review.openstack.org/211887 | 07:12 |
| openstackgerrit | Rui Chen proposed openstack/nova: Fix permission issue of server group API https://review.openstack.org/193117 | 07:14 |
| *** sileht has joined #openstack-nova | 07:15 | |
| *** venkat_p has joined #openstack-nova | 07:17 | |
| kiran-r | Hello All, I am getting this error when i live migrate an instance across compute nodes. http://paste.openstack.org/show/421549/ Please help me | 07:17 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Drop scheduler RPC 3.x support https://review.openstack.org/192836 | 07:17 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge block_device_mapping boot tests between v2 and v2.1 https://review.openstack.org/201401 | 07:19 |
| eliqiao_pc | hi , a lot of xen ci failed, any problem with xen ci? | 07:20 |
| *** whenry has quit IRC | 07:22 | |
| *** fawadkhaliq has joined #openstack-nova | 07:23 | |
| *** matrohon has joined #openstack-nova | 07:23 | |
| *** scheuran has quit IRC | 07:23 | |
| *** lpetrut has quit IRC | 07:26 | |
| *** alex_klimov has joined #openstack-nova | 07:26 | |
| *** y_sawai has joined #openstack-nova | 07:27 | |
| *** lyanchih has quit IRC | 07:27 | |
| *** rubasov has joined #openstack-nova | 07:27 | |
| *** matrohon has quit IRC | 07:27 | |
| *** belmoreira has joined #openstack-nova | 07:28 | |
| *** alex_klimov has quit IRC | 07:29 | |
| *** alex_klimov has joined #openstack-nova | 07:29 | |
| *** kiran-r has quit IRC | 07:29 | |
| *** apuimedo has joined #openstack-nova | 07:31 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge virtual interface tests between v2 and v2.1 https://review.openstack.org/197811 | 07:31 |
| openstackgerrit | whitekid proposed openstack/nova: tuning extended volume extension https://review.openstack.org/211258 | 07:31 |
| openstackgerrit | Lianhao Lu proposed openstack/nova-specs: Add new API to list compute node metric names https://review.openstack.org/180049 | 07:32 |
| *** rajesht has joined #openstack-nova | 07:33 | |
| *** kiran-r has joined #openstack-nova | 07:33 | |
| *** SourabhP has quit IRC | 07:33 | |
| *** IanGovett has joined #openstack-nova | 07:37 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Implements detach_interface method https://review.openstack.org/214493 | 07:37 |
| *** andreykurilin__ has joined #openstack-nova | 07:38 | |
| openstackgerrit | Shuquan Huang proposed openstack/nova: The API unit tests for serial console use http instead of ws https://review.openstack.org/207375 | 07:39 |
| openstackgerrit | Zhenzan Zhou proposed openstack/python-novaclient: Add help message for floating ip bulk operation https://review.openstack.org/214494 | 07:39 |
| *** lyanchih has joined #openstack-nova | 07:40 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Implements detach_interface method https://review.openstack.org/214493 | 07:40 |
| *** IanGovett has quit IRC | 07:41 | |
| *** salv-orlando has joined #openstack-nova | 07:41 | |
| *** IanGovett has joined #openstack-nova | 07:44 | |
| *** whitekid has quit IRC | 07:47 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge flavor all_extensions tests between v2 and v2.1 https://review.openstack.org/201430 | 07:48 |
| *** whitekid has joined #openstack-nova | 07:48 | |
| *** matrohon has joined #openstack-nova | 07:50 | |
| *** romainh has joined #openstack-nova | 07:51 | |
| *** whitekid has quit IRC | 07:51 | |
| jasonpan | kiran-r: Hi did you use share storage to share instance data with another compute node? ex. nfs.... | 07:51 |
| *** whitekid has joined #openstack-nova | 07:51 | |
| kiran-r | jasonpan: No. | 07:51 |
| jasonpan | kiran-r: that is the question , live migration need share storage to share instance | 07:52 |
| jasonpan | kiran-r: try this one http://docs.openstack.org/admin-guide-cloud/content/section_configuring-compute-migrations.html | 07:53 |
| *** deepakcs has quit IRC | 07:54 | |
| *** shaohe_feng has joined #openstack-nova | 07:54 | |
| jasonpan | kiran-r: I hope that can't help you solve your problem | 07:54 |
| *** Sree has joined #openstack-nova | 07:55 | |
| jasonpan | kiran-r: I hope that can help you solve your problem. sorry type error:) | 07:55 |
| kiran-r | jasonpan:Thanks, I am trying... =) | 07:56 |
| *** matrohon has quit IRC | 07:58 | |
| *** boris-42 has joined #openstack-nova | 07:59 | |
| *** haomaiwang has quit IRC | 08:01 | |
| openstackgerrit | Rui Chen proposed openstack/nova: Adds instance_uuid index for instance_system_metadata https://review.openstack.org/208277 | 08:01 |
| *** haomaiwang has joined #openstack-nova | 08:02 | |
| *** jcoufal has joined #openstack-nova | 08:02 | |
| *** shaohe_feng has quit IRC | 08:03 | |
| openstackgerrit | Rui Chen proposed openstack/nova: Adds instance_uuid index for instance_system_metadata https://review.openstack.org/208277 | 08:03 |
| *** shaohe_feng has joined #openstack-nova | 08:03 | |
| *** shaohe_feng1 has joined #openstack-nova | 08:09 | |
| *** yassine__ has joined #openstack-nova | 08:09 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Fix link's href to consider osapi_compute_link_prefix https://review.openstack.org/207702 | 08:11 |
| *** deepakcs has joined #openstack-nova | 08:11 | |
| *** shaohe_feng has quit IRC | 08:12 | |
| *** kylek3h has quit IRC | 08:12 | |
| *** kylek3h has joined #openstack-nova | 08:13 | |
| *** kylek3h has quit IRC | 08:17 | |
| *** lyanchih has quit IRC | 08:18 | |
| *** apuimedo has quit IRC | 08:19 | |
| *** saikrishna has joined #openstack-nova | 08:19 | |
| *** ociuhandu has quit IRC | 08:20 | |
| *** timbyr_ has joined #openstack-nova | 08:21 | |
| *** markvoelker has quit IRC | 08:22 | |
| *** exploreshaifali has joined #openstack-nova | 08:24 | |
| *** shaohe_feng1 has quit IRC | 08:24 | |
| *** park_heijlong has joined #openstack-nova | 08:25 | |
| *** park_heijlong has quit IRC | 08:25 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Use version convert methods from oslo_utils.versionutils https://review.openstack.org/203322 | 08:27 |
| *** derekh has joined #openstack-nova | 08:27 | |
| *** eliqiao_pc has quit IRC | 08:31 | |
| *** saikrishna has quit IRC | 08:31 | |
| *** otter768 has joined #openstack-nova | 08:31 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Move "versions" functional tests in v2.1 tests https://review.openstack.org/201439 | 08:31 |
| *** Sree__ has joined #openstack-nova | 08:33 | |
| *** gszasz has joined #openstack-nova | 08:33 | |
| *** jistr has joined #openstack-nova | 08:34 | |
| *** Sree__ has quit IRC | 08:34 | |
| *** lucasagomes has joined #openstack-nova | 08:35 | |
| *** otter768 has quit IRC | 08:36 | |
| *** fawadkhaliq has quit IRC | 08:36 | |
| *** shuquan has joined #openstack-nova | 08:37 | |
| *** lpetrut has joined #openstack-nova | 08:39 | |
| haigang | hi guys, I got a problem while create instance, the console.log was write to disk one bytes per time | 08:39 |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Update log's level when backup a volume backend instance https://review.openstack.org/214511 | 08:40 |
| *** shoutm has quit IRC | 08:40 | |
| haigang | this make disk load high, can i merge the write request? | 08:40 |
| *** jichen has joined #openstack-nova | 08:42 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Switch from deprecated timeutils.isotime https://review.openstack.org/211146 | 08:43 |
| *** shyu has quit IRC | 08:46 | |
| *** tpeoples has quit IRC | 08:46 | |
| johnthetubaguy | haigang: the folks on #openstack might have better operator focused help for you, those folks might have seen your issue before | 08:47 |
| *** alexschm has joined #openstack-nova | 08:47 | |
| *** achanda has joined #openstack-nova | 08:48 | |
| *** kiran-r has quit IRC | 08:49 | |
| *** RuiChen has quit IRC | 08:49 | |
| *** Murali has quit IRC | 08:49 | |
| mhorban | johnthetubaguy: I've created an issue in tracker for parsing URL version https://bugs.launchpad.net/nova/+bug/1486447 | 08:50 |
| openstack | Launchpad bug 1486447 in OpenStack Compute (nova) "Removing version of API for bookmark URL is wrong" [Undecided,New] - Assigned to Marian Horban (mhorban) | 08:50 |
| *** shyu has joined #openstack-nova | 08:50 | |
| johnthetubaguy | mhorban: OK, good stuff, have you added that bug to your commit message? | 08:51 |
| mhorban | johnthetubaguy: Actually not yet... because there is one +2 ;) | 08:51 |
| haigang | johnthetubaguy: thx! | 08:51 |
| johnthetubaguy | mhorban: by the way, is there any chance you can add a specific example into that bug, like examples of what SCRIPT_NAME would bug? | 08:52 |
| *** haigang has quit IRC | 08:52 | |
| johnthetubaguy | mhorban: have you got a link to your patch again? | 08:52 |
| *** haigang has joined #openstack-nova | 08:52 | |
| *** shyama_ has joined #openstack-nova | 08:52 | |
| *** haigang has quit IRC | 08:52 | |
| *** haigang has joined #openstack-nova | 08:53 | |
| mhorban | johnthetubaguy: https://review.openstack.org/#/c/195303/ | 08:53 |
| *** haigang has quit IRC | 08:53 | |
| mhorban | johnthetubaguy: ok, i'll add details to bug descr. | 08:53 |
| *** haigang has joined #openstack-nova | 08:53 | |
| *** aix has joined #openstack-nova | 08:54 | |
| johnthetubaguy | mhorban: thanks, ping me when thats sorted (ideally something that matches what you have in your unit tests) | 08:54 |
| *** shyama has quit IRC | 08:55 | |
| *** shyama_ is now known as shyama | 08:55 | |
| shane-wang1 | hello | 08:56 |
| *** shuquan has quit IRC | 08:56 | |
| *** shuquan has joined #openstack-nova | 08:58 | |
| *** shuquan has quit IRC | 08:58 | |
| gmann | johnthetubaguy: hi | 08:59 |
| shane-wang1 | the China teams from different companies (Huawei, Intel, IBM, Mirantis, 99cloud, unitedstack, awcloud and others) are doing hackathon from today to the day after tomorrow, if you have more bandwidth, please review the fixes for our bug list at https://etherpad.openstack.org/p/hackathon2_all_list, thanks. | 08:59 |
| johnthetubaguy | gmann: good morning | 08:59 |
| gmann | johnthetubaguy: good morning | 08:59 |
| johnthetubaguy | gmann: I guess good evening for you | 08:59 |
| gmann | johnthetubaguy: me and alex_xu discussed regarding failure on https://review.openstack.org/#/c/214085/ | 08:59 |
| gmann | johnthetubaguy: yea:) | 09:00 |
| johnthetubaguy | oh, yeah | 09:00 |
| gmann | johnthetubaguy: basically 2 issues here | 09:00 |
| *** haomaiwang has quit IRC | 09:01 | |
| johnthetubaguy | shane-wang1: is it possible to add a link to the review in the etherpad, when there is a patch you folks think is ready? | 09:01 |
| gmann | johnthetubaguy: 1. relax validation for extra param leads to different status code (400 -> 2xx or 50X) when v2 on v21 | 09:01 |
| johnthetubaguy | shane-wang1: just checking, but I guess you are reviewing each other code as well, before saying its ready for review, using the above system | 09:01 |
| *** RuiChen has joined #openstack-nova | 09:02 | |
| gmann | johnthetubaguy: example test_update_host_with_extra_param | 09:02 |
| johnthetubaguy | gmann: yep, thats a nasty one, the 500 we can totally just fix up | 09:02 |
| *** haomaiwa_ has joined #openstack-nova | 09:02 | |
| johnthetubaguy | gmann: honestly, this is why I wanted us to strip out the additional params, not just ignore them | 09:02 |
| gmann | johnthetubaguy: but there might be other place also which we do not have tests for those | 09:02 |
| johnthetubaguy | gmann: totally agree | 09:03 |
| *** saikrishna has joined #openstack-nova | 09:04 | |
| *** venkat_p has quit IRC | 09:04 | |
| gmann | johnthetubaguy: yea strip out could have been better which results 400 -> 2xx than 400->5xx | 09:05 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Switch from deprecated timeutils.isotime https://review.openstack.org/211146 | 09:06 |
| gmann | johnthetubaguy: alex_xu : how we should go on those now? | 09:06 |
| johnthetubaguy | (sorry got disconnected for a moment there) | 09:06 |
| johnthetubaguy | I saw your comment on 400->2xxx, did you mention something after that? | 09:07 |
| johnthetubaguy | what was problem 2? | 09:07 |
| gmann | johnthetubaguy: 2. is with metadata validation which is actually due to validation we have for metadata key | 09:08 |
| gmann | johnthetubaguy: https://github.com/openstack/nova/blob/master/nova/api/validation/parameter_types.py#L172 | 09:08 |
| gmann | johnthetubaguy: here invalid metadata keys (>255 or blank ) are considered as extra param and v2.1 used to raise additional property error which results to 400 | 09:09 |
| johnthetubaguy | gmann: ah, I see, thats extra validation, I would argue we just need to fix the tempest test for those | 09:09 |
| johnthetubaguy | oh | 09:09 |
| gmann | johnthetubaguy: but v2 on v21 will result to 500 instead of 400 | 09:09 |
| johnthetubaguy | yeah, got it the wrong way around in my head | 09:10 |
| gmann | i thought of solution to have those validation in python code as in v2 code | 09:10 |
| *** eliqiao_pc has joined #openstack-nova | 09:10 | |
| johnthetubaguy | gmann: yeah, that seems a little silly though | 09:10 |
| gmann | johnthetubaguy: yea | 09:11 |
| *** vivekd has joined #openstack-nova | 09:11 | |
| johnthetubaguy | (in the sense that we know there will be other cases) | 09:11 |
| gmann | yea other cases also where ever parameter_type.metadata is being used for validation | 09:11 |
| johnthetubaguy | what about trying the strip out extra properties thing? I guess that still breaks the tests | 09:12 |
| gmann | or we can handle metadata validation case as exception and not to relax additional property validation for metadata case? | 09:12 |
| gmann | yes tests will fail with strip out also | 09:13 |
| openstackgerrit | Feodor Tersin proposed openstack/nova: Remove unused root_metadata method of BlockDeviceMappingList https://review.openstack.org/212324 | 09:13 |
| openstackgerrit | Feodor Tersin proposed openstack/nova: Fix collection of metadata for a snapshot of a volume-backed instance https://review.openstack.org/170243 | 09:13 |
| openstackgerrit | Feodor Tersin proposed openstack/nova: Consolidate initialization of instance snapshot metadata https://review.openstack.org/198959 | 09:13 |
| *** yanxb_ has joined #openstack-nova | 09:13 | |
| *** sudipto has quit IRC | 09:13 | |
| johnthetubaguy | gmann: so the metadata one (and similar things with patternproperties I guess, might be a good thing to special case | 09:14 |
| *** yanxb has joined #openstack-nova | 09:14 | |
| johnthetubaguy | just worried about the others, maybe the others should just get stripped out | 09:14 |
| johnthetubaguy | although thats not idea either | 09:14 |
| gmann | johnthetubaguy: yea because metadata is being used in some other schema also like create server | 09:15 |
| johnthetubaguy | gmann: I am thinking everything with patternproperties will have the same issue right? | 09:15 |
| gmann | johnthetubaguy: yes. | 09:15 |
| johnthetubaguy | so maybe lets fix those ones first | 09:16 |
| johnthetubaguy | then see where we are | 09:16 |
| openstackgerrit | Feodor Tersin proposed openstack/nova: Fix evaluation of host disk usage by volume-backed instances https://review.openstack.org/200870 | 09:17 |
| gmann | johnthetubaguy: just searched and looks like only metadata have patternProperties | 09:17 |
| *** achanda has quit IRC | 09:17 | |
| *** abhishekk has joined #openstack-nova | 09:17 | |
| *** lyanchih has joined #openstack-nova | 09:18 | |
| *** venkat_p has joined #openstack-nova | 09:18 | |
| gmann | johnthetubaguy: but that is being used in inside of many schema | 09:18 |
| gmann | johnthetubaguy: so not sure how we will strip out only metadata extra param? | 09:18 |
| eliqiao_pc | johnthetubaguy: hi john, GM. | 09:19 |
| johnthetubaguy | gmann: magic code that runs before the validation happens, was the only thing I could come up with | 09:19 |
| *** yanxb has quit IRC | 09:19 | |
| *** yanxb_ has quit IRC | 09:19 | |
| johnthetubaguy | eliqiao_pc: hi | 09:19 |
| *** ishant has joined #openstack-nova | 09:19 | |
| *** shane-wang1 has quit IRC | 09:20 | |
| eliqiao_pc | johnthetubaguy: we are doing prc-hackathon today. and have some bug list output, can you help to review them? | 09:20 |
| openstackgerrit | Simona Iuliana Toader proposed openstack/nova: Hyper-V: Adds Hyper-V UEFI Secure Boot https://review.openstack.org/209581 | 09:21 |
| openstackgerrit | Simona Iuliana Toader proposed openstack/nova: Hyper-V: Fixes serial port issue on Windows Threshold https://review.openstack.org/192617 | 09:21 |
| openstackgerrit | Simona Iuliana Toader proposed openstack/nova: Hyper-V: refactors utilsfactory https://review.openstack.org/214527 | 09:21 |
| *** wanghua has quit IRC | 09:21 | |
| gmann | johnthetubaguy: hummm but before validation to know metadata is in request and it is extra param or not seems difficult | 09:21 |
| *** zhihai_song has quit IRC | 09:21 | |
| johnthetubaguy | eliqiao_pc: sent some asks above to shane-wang1, I would love you folks to review each others changes, and when you are happy add a link to the review request into that etherpad, if possible? | 09:21 |
| johnthetubaguy | (after voting on the patches in gerrit, I guess) | 09:22 |
| johnthetubaguy | eliqiao_pc: also, please do add comments in gerrit rather than just talking to each other, that sounds silly, but its just good to get into good habbits! | 09:22 |
| *** RuiChen has quit IRC | 09:23 | |
| johnthetubaguy | gmann: you would have to parse the validation stuff ourselves (well read it anyways) | 09:23 |
| *** markvoelker has joined #openstack-nova | 09:23 | |
| *** jordanP has joined #openstack-nova | 09:24 | |
| *** yanxb_ has joined #openstack-nova | 09:24 | |
| eliqiao_pc | johnthetubaguy: yeah, that would be cool, we can do the review first and will prepare the list when we are done. we are looking forward you to give +2? :) thanks in advance. | 09:24 |
| *** Sree__ has joined #openstack-nova | 09:24 | |
| eliqiao_pc | johnthetubaguy: yeah, thanks for your comments:) | 09:24 |
| openstackgerrit | Rajesh Tailor proposed openstack/nova: Remove unnecessary ValueError exception https://review.openstack.org/190525 | 09:25 |
| *** eliqiao_pc has quit IRC | 09:25 | |
| johnthetubaguy | gmann: hmm, this is nasty stuff :( | 09:25 |
| gmann | johnthetubaguy: yea, actually validating key also along with value makes it bad | 09:26 |
| *** fawadkhaliq has joined #openstack-nova | 09:28 | |
| *** Sree has quit IRC | 09:28 | |
| *** markvoelker has quit IRC | 09:28 | |
| *** Sree__ has quit IRC | 09:29 | |
| openstackgerrit | Marian Horban proposed openstack/nova: Added processing /compute URL https://review.openstack.org/195303 | 09:30 |
| mhorban | johnthetubaguy: Details added https://bugs.launchpad.net/nova/+bug/1486447. And Closes-Bug in commit message added | 09:32 |
| openstack | Launchpad bug 1486447 in OpenStack Compute (nova) "Removing version of API for bookmark URL is wrong" [Undecided,In progress] - Assigned to Marian Horban (mhorban) | 09:32 |
| gmann | johnthetubaguy: i will try some ideas tomorrow and lets see if i can find any good one | 09:33 |
| *** kiran-r has joined #openstack-nova | 09:34 | |
| openstackgerrit | John Garbutt proposed openstack/nova: Added processing /compute URL https://review.openstack.org/195303 | 09:36 |
| johnthetubaguy | mhorban: thanks for those details in the bug report, I am thinking it might be good to add them in the commit message | 09:37 |
| openstackgerrit | John Garbutt proposed openstack/nova: Added processing /compute URL https://review.openstack.org/195303 | 09:39 |
| *** _kiran_ has joined #openstack-nova | 09:40 | |
| *** kiran-r has quit IRC | 09:41 | |
| *** kylek3h has joined #openstack-nova | 09:43 | |
| *** jaypipes has quit IRC | 09:46 | |
| *** kylek3h has quit IRC | 09:48 | |
| openstackgerrit | John Garbutt proposed openstack/nova: Add functional test for server group https://review.openstack.org/147514 | 09:51 |
| openstackgerrit | Simona Iuliana Toader proposed openstack/nova: Hyper-V: Adds Hyper-V UEFI Secure Boot https://review.openstack.org/209581 | 09:53 |
| *** _kiran_ is now known as kiran-r | 09:53 | |
| *** kiran-r has quit IRC | 09:53 | |
| *** kiran-r has joined #openstack-nova | 09:54 | |
| *** ociuhandu has joined #openstack-nova | 09:54 | |
| *** apuimedo has joined #openstack-nova | 09:57 | |
| *** exploreshaifali has quit IRC | 09:57 | |
| lxsli | alex_xu: are you awake? | 09:58 |
| *** saikrishna has quit IRC | 10:00 | |
| *** haomaiwa_ has quit IRC | 10:01 | |
| openstackgerrit | John Garbutt proposed openstack/nova: Hyper-V: Adds HyperVDriver unit tests https://review.openstack.org/148980 | 10:01 |
| *** haomaiwang has joined #openstack-nova | 10:02 | |
| *** exploreshaifali has joined #openstack-nova | 10:02 | |
| openstackgerrit | Alexis Lee proposed openstack/nova: Adds resource classes https://review.openstack.org/128999 | 10:03 |
| openstackgerrit | Alexis Lee proposed openstack/nova: Add object models for comparing resource amounts https://review.openstack.org/128992 | 10:03 |
| openstackgerrit | ZhuChunzhan proposed openstack/nova: Improve the performance of get evacuated instances from a host which should be destroyed https://review.openstack.org/214540 | 10:06 |
| *** apmelton has quit IRC | 10:06 | |
| *** d34dh0r53 has quit IRC | 10:07 | |
| alex_xu | lxsli: hi, I'm here | 10:07 |
| johnthetubaguy | jichen: hey, just looking at this patch, lets catch up about this if we are online at the same time: https://review.openstack.org/#/c/163177/2 | 10:08 |
| *** belmoreira has quit IRC | 10:08 | |
| *** d34dh0r53 has joined #openstack-nova | 10:08 | |
| *** apmelton has joined #openstack-nova | 10:09 | |
| lxsli | alex_xu: hi there! I just wanted to ask about NotImplementedError on https://review.openstack.org/#/c/128992/, are you happy with EG raise NotImplementedError(_("Amount#__eq__")) please? | 10:09 |
| *** belmoreira has joined #openstack-nova | 10:09 | |
| alex_xu | lxsli: I'm ok with that | 10:11 |
| lxsli | alex_xu: great, thank you | 10:11 |
| alex_xu | lxsli: np | 10:12 |
| *** belmoreira has quit IRC | 10:14 | |
| *** belmoreira has joined #openstack-nova | 10:15 | |
| *** kmartin has quit IRC | 10:16 | |
| *** asselin_ has quit IRC | 10:16 | |
| alex_xu | johnthetubaguy: gmann , maybe strip out is right way, it can resolve all the concern. | 10:18 |
| *** shoutm has joined #openstack-nova | 10:18 | |
| alex_xu | but a little hard to implement | 10:19 |
| johnthetubaguy | yeah, +1 to both | 10:19 |
| alex_xu | probably need some code to get required properties when validation input with json-schema | 10:20 |
| alex_xu | then remove it from the input | 10:20 |
| *** whitekid has quit IRC | 10:21 | |
| *** _kiran_ has joined #openstack-nova | 10:23 | |
| *** y_sawai has quit IRC | 10:24 | |
| *** kiran-r has quit IRC | 10:24 | |
| *** _kiran_ has quit IRC | 10:29 | |
| openstackgerrit | ZhuChunzhan proposed openstack/nova: Improve the performance of get evacuated instances from a host which should be destroyed https://review.openstack.org/214540 | 10:31 |
| *** chhavi has joined #openstack-nova | 10:31 | |
| *** yamahata has quit IRC | 10:32 | |
| *** otter768 has joined #openstack-nova | 10:32 | |
| openstackgerrit | John Garbutt proposed openstack/nova: New db api method instance_get_all_by_grantee_security_groups() https://review.openstack.org/72380 | 10:32 |
| *** otter768 has quit IRC | 10:37 | |
| *** venkat_p has quit IRC | 10:38 | |
| lxsli | bauzas: morning, you wanted requested_destination to be a ComputeNode object. Should I put that in the DB as a FK or serialised JSON please? alaski has taken the latter approach for everything else and I'm not quite sure why | 10:39 |
| *** chhavi_ has joined #openstack-nova | 10:42 | |
| *** kiran-r has joined #openstack-nova | 10:43 | |
| *** kylek3h has joined #openstack-nova | 10:44 | |
| *** chhavi has quit IRC | 10:44 | |
| *** _kiran_ has joined #openstack-nova | 10:45 | |
| *** _kiran_ has quit IRC | 10:45 | |
| *** _kiran_ has joined #openstack-nova | 10:45 | |
| *** _kiran_ has quit IRC | 10:46 | |
| *** _kiran_ has joined #openstack-nova | 10:47 | |
| *** belmoreira has quit IRC | 10:48 | |
| *** kiran-r has quit IRC | 10:48 | |
| *** _kiran_ has quit IRC | 10:48 | |
| *** kiran-r has joined #openstack-nova | 10:49 | |
| kiran-r | jasonpan: What is the use of having host aggregates?? | 10:50 |
| *** venkat_p has joined #openstack-nova | 10:50 | |
| *** chhavi_ has quit IRC | 10:50 | |
| *** salv-orlando has quit IRC | 10:53 | |
| *** Sree has joined #openstack-nova | 10:53 | |
| openstackgerrit | ZhuChunzhan proposed openstack/nova: Improve the performance of get evacuated instances from a host which should be destroyed https://review.openstack.org/214555 | 10:53 |
| *** fawadkhaliq has quit IRC | 10:53 | |
| *** dims has joined #openstack-nova | 10:56 | |
| openstackgerrit | Simona Iuliana Toader proposed openstack/nova: Hyper-V: Adds Hyper-V UEFI Secure Boot https://review.openstack.org/209581 | 10:57 |
| openstackgerrit | Simona Iuliana Toader proposed openstack/nova: Hyper-V: refactors utilsfactory https://review.openstack.org/214527 | 10:57 |
| *** mwagner_lap has quit IRC | 10:57 | |
| *** ccesario_ has quit IRC | 10:59 | |
| *** shoutm has quit IRC | 11:01 | |
| *** dims_ has joined #openstack-nova | 11:03 | |
| *** baoli has joined #openstack-nova | 11:05 | |
| *** dims has quit IRC | 11:07 | |
| *** Murali has joined #openstack-nova | 11:08 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Fixes snapshoting inexistent VM issue https://review.openstack.org/214560 | 11:08 |
| *** thorst has joined #openstack-nova | 11:09 | |
| *** ishant has quit IRC | 11:10 | |
| *** garyk has joined #openstack-nova | 11:10 | |
| *** baoli has quit IRC | 11:10 | |
| *** saikrishna has joined #openstack-nova | 11:11 | |
| *** haomaiwang has quit IRC | 11:12 | |
| openstackgerrit | lalit dagre proposed openstack/nova: WIP: Flavor create using api DB https://review.openstack.org/213041 | 11:13 |
| openstackgerrit | lalit dagre proposed openstack/nova: Creates flavor* tables in API database https://review.openstack.org/201606 | 11:13 |
| *** sudipto has joined #openstack-nova | 11:13 | |
| johnthetubaguy | anthonyper: hey, I am just looking at these patches you have up here: https://review.openstack.org/#/c/199092 | 11:13 |
| johnthetubaguy | anthonyper: it really looks like a new feature | 11:13 |
| johnthetubaguy | anthonyper: OK, so reading the bug, I think I see what is happening now. | 11:14 |
| *** ociuhandu has quit IRC | 11:16 | |
| *** ociuhandu has joined #openstack-nova | 11:18 | |
| *** boris-42 has quit IRC | 11:20 | |
| openstackgerrit | George Peristerakis proposed openstack/python-novaclient: Search the list of servers with unicode text. https://review.openstack.org/200649 | 11:21 |
| *** markvoelker has joined #openstack-nova | 11:24 | |
| *** shoutm has joined #openstack-nova | 11:26 | |
| openstackgerrit | jichenjc proposed openstack/nova: Cleanup HTTPRequest for security_groups test https://review.openstack.org/182630 | 11:28 |
| *** markvoelker has quit IRC | 11:28 | |
| *** dims has joined #openstack-nova | 11:29 | |
| *** dims_ has quit IRC | 11:31 | |
| *** dims_ has joined #openstack-nova | 11:31 | |
| openstackgerrit | ZhuChunzhan proposed openstack/nova: Improve the performance of get evacuated instances from a host which should be destroyed https://review.openstack.org/214555 | 11:32 |
| *** wxy_ has quit IRC | 11:32 | |
| *** lyanchih has quit IRC | 11:34 | |
| *** dims has quit IRC | 11:34 | |
| *** fawadkhaliq has joined #openstack-nova | 11:35 | |
| *** saikrishna has quit IRC | 11:36 | |
| *** lucasagomes is now known as lucas-hungry | 11:40 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Implements detach_interface method https://review.openstack.org/214493 | 11:43 |
| *** saikrishna has joined #openstack-nova | 11:46 | |
| *** diogogmt has joined #openstack-nova | 11:46 | |
| *** otter768 has joined #openstack-nova | 11:46 | |
| dims_ | johnthetubaguy: neutronv2/api.py has support for auth plugin(s) BUT the config parameters do not show up in "tox -e genconfig" (lines 121, 123 in https://review.openstack.org/#/c/136931/14/nova/network/neutronv2/api.py,cm) | 11:48 |
| dims_ | johnthetubaguy: it probably did not showed up in the kilo nova.conf.sample either, will have to verify that | 11:49 |
| openstackgerrit | George Peristerakis proposed openstack/python-novaclient: Search the list of servers with unicode text. https://review.openstack.org/200649 | 11:50 |
| markus_z | dims_: I remember a bug about that, let me look it up | 11:50 |
| markus_z | dims_: https://bugs.launchpad.net/nova/+bug/1476912 | 11:51 |
| openstack | Launchpad bug 1476912 in OpenStack Compute (nova) "No nova.conf.sample, and no details procedures to describe how to generate a full list of nova.conf.sample" [Undecided,Won't fix] | 11:51 |
| *** jaypipes has joined #openstack-nova | 11:53 | |
| *** irenab has quit IRC | 11:55 | |
| *** pc_m_ has joined #openstack-nova | 11:57 | |
| dims_ | markus_z: this is related but not the same as that bug | 11:58 |
| *** saikrishna has quit IRC | 11:58 | |
| dims_ | markus_z: in this case, we pick up options from config file *if* someone reads jamie's blog and looks at the code :) http://www.jamielennox.net/blog/2015/02/17/loading-authentication-plugins/ | 11:59 |
| dims_ | then they can use it | 11:59 |
| dims_ | markus_z: i have a hack, run "tox -e genconfig" before and after applying this review (https://review.openstack.org/#/c/214423/) and you can diff the nova.conf.sample to see the new options | 12:00 |
| markus_z | dims_: I see. I got triggered by the statement, that not all config options are in the "sample.conf" file. | 12:02 |
| dims_ | right | 12:02 |
| *** otter768 has quit IRC | 12:02 | |
| *** afazkas has quit IRC | 12:04 | |
| dims_ | markus_z: yes, thanks. kilo we did not use oslo-config-generator so now we should not have the problem (1476912) | 12:05 |
| *** andreykurilin__ has quit IRC | 12:05 | |
| *** dave-mccowan has joined #openstack-nova | 12:06 | |
| *** dprince has joined #openstack-nova | 12:08 | |
| markus_z | dims_: oh man, I did miss the version and didn't do a double-check how we created the sample.conf in earlier releases. Thanks for the pointer. | 12:09 |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: DO NOT MERGE: Example of config options reshuffle https://review.openstack.org/214581 | 12:10 |
| johnthetubaguy | dims_: I could totally believe we missed a few | 12:11 |
| johnthetubaguy | dims_: do you have a bug for that one? | 12:11 |
| dims_ | johnthetubaguy: nope, jamie's -1 on this review triggered my exploration (https://review.openstack.org/#/c/209599/) | 12:12 |
| johnthetubaguy | dims_: ah, gotcha | 12:13 |
| *** raildo-afk is now known as raildo | 12:14 | |
| openstackgerrit | wanghao proposed openstack/nova: Add nova-manage command for cleaning attachment https://review.openstack.org/184537 | 12:14 |
| johnthetubaguy | dims_: I don't like thinkings its a docs issue, but maybe we just need better docs, and devstack setup of keystone v3, maybe? I am missing a lot of context on where we are at with all that right now | 12:15 |
| *** amotoki_ has joined #openstack-nova | 12:17 | |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Fix cells use of legacy bdms during local instance delete operations https://review.openstack.org/214583 | 12:19 |
| *** belmoreira has joined #openstack-nova | 12:19 | |
| *** belmoreira has quit IRC | 12:19 | |
| *** diogogmt has quit IRC | 12:20 | |
| dims_ | johnthetubaguy: that's where i started (devstack) https://review.openstack.org/#/c/209566/ | 12:21 |
| dims_ | we don't have a job where nova fully uses keystone v3 api | 12:21 |
| dims_ | since for neutron we always use keystone v2 api in devstack scripts | 12:21 |
| *** erlon has joined #openstack-nova | 12:22 | |
| *** deepakcs has quit IRC | 12:23 | |
| *** ashishb has quit IRC | 12:24 | |
| *** salv-orlando has joined #openstack-nova | 12:25 | |
| *** matrohon has joined #openstack-nova | 12:26 | |
| *** yanxb_ has quit IRC | 12:27 | |
| *** venkat_p has quit IRC | 12:27 | |
| *** amotoki_ has quit IRC | 12:27 | |
| *** edmondsw has joined #openstack-nova | 12:27 | |
| *** yanxb_ has joined #openstack-nova | 12:31 | |
| johnthetubaguy | dims_: oh, I guess we could move the nova-net jobs over to keystone v3? | 12:32 |
| *** salv-orl_ has joined #openstack-nova | 12:32 | |
| johnthetubaguy | I remember talk of an experimental job being added, not sure who promised to do that | 12:32 |
| *** salv-orlando has quit IRC | 12:33 | |
| *** mwagner_lap has joined #openstack-nova | 12:33 | |
| openstackgerrit | Alexis Lee proposed openstack/nova: Clean up live migration retry loop https://review.openstack.org/213056 | 12:36 |
| openstackgerrit | Alexis Lee proposed openstack/nova: WIP check destination on migrations https://review.openstack.org/212510 | 12:36 |
| openstackgerrit | lalit dagre proposed openstack/nova: WIP: Flavor create using api DB https://review.openstack.org/213041 | 12:37 |
| *** lucas-hungry is now known as lucasagomes | 12:39 | |
| *** logan2 has joined #openstack-nova | 12:39 | |
| *** haomaiwang has joined #openstack-nova | 12:39 | |
| *** haigang has quit IRC | 12:39 | |
| *** markvoelker has joined #openstack-nova | 12:40 | |
| *** ashishb has joined #openstack-nova | 12:40 | |
| *** zhihai_song has joined #openstack-nova | 12:41 | |
| *** shyu has quit IRC | 12:42 | |
| *** zhihai_song has quit IRC | 12:43 | |
| openstackgerrit | Alexis Lee proposed openstack/nova: Clean up live migration retry loop https://review.openstack.org/213056 | 12:44 |
| *** eharney has joined #openstack-nova | 12:45 | |
| *** fawadkhaliq has quit IRC | 12:46 | |
| lxsli | markus_z: should we open bugs for code cleanup? | 12:46 |
| *** amotoki_ has joined #openstack-nova | 12:47 | |
| openstackgerrit | John Garbutt proposed openstack/nova: api: deprecate the concept of extensions in v2.1 https://review.openstack.org/214592 | 12:48 |
| *** exploreshaifali has quit IRC | 12:54 | |
| *** lyanchih has joined #openstack-nova | 12:54 | |
| *** jcoufal_ has joined #openstack-nova | 12:58 | |
| *** smatzek has joined #openstack-nova | 13:00 | |
| *** xyang1 has joined #openstack-nova | 13:00 | |
| *** irenab has joined #openstack-nova | 13:01 | |
| *** jcoufal has quit IRC | 13:01 | |
| markus_z | lxsli: no, don't think so. Refactoring is a continuous task, I don't see a value in a bug report. | 13:04 |
| lxsli | markus_z: cool, thank you | 13:04 |
| markus_z | lxsli: If the cleanup should have a side effect like better performance or so, then maybe. | 13:05 |
| *** rfolco has joined #openstack-nova | 13:06 | |
| openstackgerrit | John Garbutt proposed openstack/nova: api: deprecate the api v2 extension configuration https://review.openstack.org/214601 | 13:08 |
| johnthetubaguy | alex_xu: gmann: something for when you are around tomorrow, its more a sketch to help poke at the problem: https://review.openstack.org/#/q/topic:bp/nova-api-deprecate-extensions,n,z | 13:09 |
| alex_xu | johnthetubaguy: thanks, that is one thing we should do in Liberty for remove extension | 13:11 |
| openstackgerrit | ZhuChunzhan proposed openstack/nova: Improve the performance of get evacuated instances from a host which should be destroyed https://review.openstack.org/214555 | 13:12 |
| *** annegentle has joined #openstack-nova | 13:13 | |
| *** rlrossit has joined #openstack-nova | 13:13 | |
| *** pc_m_ has quit IRC | 13:15 | |
| *** andreykurilin__ has joined #openstack-nova | 13:16 | |
| *** Sree has quit IRC | 13:17 | |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Make compute_api.trigger_members_refresh() issue a single db call https://review.openstack.org/72382 | 13:18 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Remove unused db.security_group_rule_get_by_security_group_grantee() https://review.openstack.org/72383 | 13:18 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Revert "Make nova-network use conductor for security groups refresh" https://review.openstack.org/182212 | 13:19 |
| *** dustins has joined #openstack-nova | 13:19 | |
| *** mdrabe has joined #openstack-nova | 13:26 | |
| *** dims_ has quit IRC | 13:29 | |
| *** vivekd has quit IRC | 13:29 | |
| *** dims has joined #openstack-nova | 13:29 | |
| andreykurilin__ | sdague, alex_xu: hi! I want to know your opinion about modifying return data of boot call. Currently, it returns only 1 server, even if min_count>1, so creation several vms by one call is inconvenient. | 13:30 |
| alex_xu | andreykurilin__: actually there is reservation_id in the response if the user requested | 13:31 |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: DO NOT MERGE: Example of config options reshuffle https://review.openstack.org/214581 | 13:32 |
| alex_xu | andreykurilin__: https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L652 | 13:32 |
| andreykurilin__ | alex_xu: from cyeoh note: "In the long term with the tasks API we will probably just drop the concept of reservation_id" | 13:33 |
| *** mriedem has joined #openstack-nova | 13:33 | |
| alex_xu | andreykurilin__: yea, I remember there is some discussion before. | 13:34 |
| alex_xu | andreykurilin__: tasks API not here yet | 13:34 |
| andreykurilin__ | alex_xu: why not just return list of servers at once ? | 13:35 |
| *** ijuwang has joined #openstack-nova | 13:35 | |
| alex_xu | andreykurilin__: I don't remember the detail, one thing I remember is we have different return status for multiple servers | 13:36 |
| openstackgerrit | John Garbutt proposed openstack/nova: api: tidy up paste.ini https://review.openstack.org/214085 | 13:37 |
| *** annegentle has quit IRC | 13:37 | |
| andreykurilin__ | alex_xu: hm | 13:37 |
| Kevin_Zheng_ | Hi, could someone review on this: https://review.openstack.org/#/c/202379/ Thanks alot | 13:40 |
| andreykurilin__ | alex_xu: sorry, but I don't understand which codes can different. boot method raises/returns the same errors no matter what number of servers are requested. | 13:42 |
| *** jecarey has joined #openstack-nova | 13:42 | |
| openstackgerrit | Maxim Nestratov proposed openstack/nova: libvirt: clear instance.root_device_name while ignoring user device name https://review.openstack.org/214314 | 13:42 |
| *** kiran-r has quit IRC | 13:42 | |
| *** diogogmt has joined #openstack-nova | 13:43 | |
| andreykurilin__ | alex_xu: choose of return server is the one of the last steps of the boot - https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L660 | 13:43 |
| rlrossit | yo dansmith, why did you -1 yourself on the save_batch() patch? | 13:45 |
| dansmith | rlrossit: jaypipes wanted to revisit my assertion about save() on list objects and I'm not in a place to have a conversation this week | 13:46 |
| dansmith | so I figured I'd wait until next week and pin it so it doesn't merge accidentally | 13:46 |
| alex_xu | andreykurilin__: emm... maybe I remember that wrong. | 13:46 |
| *** dboik has joined #openstack-nova | 13:46 | |
| *** diogogmt has quit IRC | 13:47 | |
| mriedem | i just jumped into the swift channel and they have a good idea for channel topic - they have their review dashboard in the topic | 13:47 |
| *** burt has joined #openstack-nova | 13:47 | |
| mriedem | e.g. Review Dashboard: https://goo.gl/eqeGwE | Summary Dashboard: https://goo.gl/jL0byl | 13:47 |
| mriedem | johnthetubaguy: ^ | 13:47 |
| rlrossit | dansmith: gotcha. yeah it looked like nothing happened besides a rebase, and suddenly you just cut it off. I guess I missed that conversation | 13:48 |
| mriedem | at this point in the release we probably shouldn't say in the nova channel topic that lemming is open for development since we're in bug fix mode | 13:48 |
| alex_xu | andreykurilin__: about why use task api, maybe alaski remember that | 13:48 |
| andreykurilin__ | alex_xu: ok, thanks | 13:48 |
| johnthetubaguy | mriedem: those dashboards are nifty, just using the stars, I like it | 13:48 |
| johnthetubaguy | mriedem: yeah, I haven't looked into how we change the topic, do you know? | 13:49 |
| *** gzhai has joined #openstack-nova | 13:49 | |
| alex_xu | andreykurilin__: or you can 'git blame' the code, to check another note on the commit, hope can track some history | 13:49 |
| dansmith | johnthetubaguy: I can change it | 13:49 |
| *** jcoufal_ has quit IRC | 13:49 | |
| *** ChanServ sets mode: +o dansmith | 13:49 | |
| johnthetubaguy | dansmith: cool | 13:50 |
| *** dansmith changes topic to "This channel is for Nova development. For support of Nova deployments, please use #openstack." | 13:50 | |
| johnthetubaguy | dansmith: sweet | 13:50 |
| johnthetubaguy | dansmith: I guess we could link to this: https://wiki.openstack.org/wiki/Nova/Liberty_Release_Schedule | 13:50 |
| andreykurilin__ | alex_xu: so you do not see any negative aspects of such change(btw, I have a draft and it quite small - https://review.openstack.org/#/c/213776/1/nova/api/openstack/compute/servers.py ) ? | 13:51 |
| *** dansmith changes topic to "This channel is for Nova development. For support of Nova deployments, please use #openstack. Please see: https://wiki.openstack.org/wiki/Nova/Liberty_Release_Schedule" | 13:51 | |
| rajesht | hi cores, | 13:51 |
| rajesht | could you please review https://review.openstack.org/#/c/170118/ | 13:51 |
| markus_z | mriedem: Those dashboards are pretty sweet and better than a list in etherpad IMO | 13:51 |
| rajesht | thanks | 13:51 |
| *** jcoufal has joined #openstack-nova | 13:51 | |
| johnthetubaguy | markus_z: +1 we have been actively looking for a way to kill the etherpad of doom | 13:51 |
| mriedem | yeah, it looks like they have several categories in theirs | 13:52 |
| alex_xu | andreykurilin__: I need think about also need track the history before I give answer | 13:52 |
| mriedem | needs final +W, some grouped by feature branch, which could be priority topic branch in our case | 13:52 |
| gzhai | sdague: Do you have time to have a review @ https://review.openstack.org/#/c/203573/ ? | 13:52 |
| Kevin_Zheng_ | johnthetubaguy: Thanks a lot for your review, pls see my reply. | 13:52 |
| gzhai | sdague: Just minor changes according to your comment. Thanks! | 13:52 |
| johnthetubaguy | Kevin_Zheng_: I am fine with the idea, I just don't think your code is actually doing that (it just sets the DB state, it doesn't change the instance state) | 13:53 |
| *** ctrath has joined #openstack-nova | 13:54 | |
| *** whitekid has joined #openstack-nova | 13:54 | |
| rlrossit | mriedem: johnthetubaguy: and coming from someone that doesn't know what to review, having a list of "These things really need to be reviewed" would be really nice | 13:54 |
| rlrossit | instead of the fire hose of changes that roll through my watchlist | 13:54 |
| markus_z | johnthetubaguy: Would be cool to have a dashboard subject for bugs (but you most probably already thought about that). | 13:54 |
| mriedem | rlrossit: that's supposed to be https://etherpad.openstack.org/p/liberty-nova-priorities-tracking right now | 13:54 |
| johnthetubaguy | mriedem: +1 | 13:55 |
| sdague | gzhai: +2, thanks | 13:55 |
| rlrossit | yeah and I hate the etherpad | 13:55 |
| rlrossit | very non-dynamic | 13:55 |
| ctrath | rlrossit: +1 | 13:55 |
| sdague | rlrossit: build us a better system then :) | 13:55 |
| Kevin_Zheng_ | johnthetubaguy: I will check agian, but I think the actual instance state didn't even change | 13:55 |
| dansmith | yeah, see, | 13:55 |
| dansmith | the etherpad is crowdsourced | 13:55 |
| dansmith | these dashboards are awesome, but they require maintenance | 13:55 |
| johnthetubaguy | rlrossit: I have tried to collect some top tips in this wiki page: https://wiki.openstack.org/wiki/Nova/Mentoring#Why_do_code_reviews_if_I_am_not_in_nova-core.3F | 13:55 |
| *** ChanServ sets mode: -o dansmith | 13:55 | |
| *** artom has joined #openstack-nova | 13:55 | |
| Kevin_Zheng_ | johnthetubaguy: if this excption has been thrown | 13:56 |
| *** abhishekk has quit IRC | 13:56 | |
| johnthetubaguy | Kevin_Zheng_: that might be driver dependent, and depends on where it fails, I fear | 13:56 |
| johnthetubaguy | Kevin_Zheng_: I know in xenapi, we start the instance back up after a failure | 13:56 |
| Kevin_Zheng_ | johnthetubaguy: Thanks I will check that | 13:57 |
| mriedem | sdague: johnthetubaguy: dansmith: still, couldn't we start with something as basic as (1) needs final +2 and (2) patches directly related to bugs | 13:57 |
| *** rlrossit1 has joined #openstack-nova | 13:57 | |
| johnthetubaguy | Kevin_Zheng_: we start it back up, becuase we previously had to shut it down, I suspect it might be better just to check the actual power state of the VM, rather than just mark it as ACTIVE, thats probably a little easier at this point | 13:57 |
| mriedem | then we wouldn't need to maintain a list of topic branches for priorities | 13:57 |
| dansmith | mriedem: sure, a few people have those dashboards already, right? | 13:58 |
| Kevin_Zheng_ | johnthetubaguy: yes you are right | 13:58 |
| mriedem | if someone has a sweet ass dashboard, we should link that into the channel topic | 13:58 |
| johnthetubaguy | mriedem: I thought sdague had something that did some of that already, but yeah, a basic thing would help I think | 13:58 |
| johnthetubaguy | mriedem: yeah, thats a good plan | 13:58 |
| alaski | alex_xu: andreykurilin__ the primary reason, IMO, to use a task api for multiple servers boot responses is the potential size of the response if booting something like 100 instances | 13:58 |
| mriedem | because then when people complain about not getting their changes reviewed, we can point at that | 13:59 |
| Kevin_Zheng_ | johnthetubaguy: you mean we just save the current actual state to the DB | 13:59 |
| *** rlrossit has quit IRC | 13:59 | |
| rlrossit1 | mriedem: +1 | 13:59 |
| alaski | alex_xu: andreykurilin__ and if we are going to modify the response for multiple boot it would be desirable to move towards a task api vs making a small change now that we want to undo later | 13:59 |
| *** mriedem is now known as mriedem_meeting | 13:59 | |
| alex_xu | alaski: thanks! | 13:59 |
| Kevin_Zheng_ | johnthetubaguy: don't set it back to initial if they are different | 13:59 |
| *** ftersin has joined #openstack-nova | 13:59 | |
| johnthetubaguy | mriedem: true, am using russell's tooling to create this: reviews.johnthetubaguy.com but yes, a bit of context would be useful here, thats a top idea | 13:59 |
| *** rubasov has quit IRC | 14:00 | |
| alex_xu | alaski: thanks, I see now | 14:00 |
| ftersin | dansmith: hi, about nullable fields in ImageMeta (https://review.openstack.org/#/c/211048) | 14:01 |
| openstackgerrit | John Garbutt proposed openstack/nova: api: tidy up paste.ini https://review.openstack.org/214085 | 14:01 |
| *** Sree has joined #openstack-nova | 14:01 | |
| *** dboik has quit IRC | 14:02 | |
| gzhai | sdague:Thanks for your review! | 14:02 |
| ftersin | dansmith: as i understand, the reason why we didn't set nullability for the fields was compatibility between nodes | 14:02 |
| dansmith | ftersin: I'm about to leave now, so I can't really discuss it | 14:02 |
| dansmith | ftersin: I might be able to in a few hours though | 14:02 |
| *** otter768 has joined #openstack-nova | 14:03 | |
| gzhai | dansmith: Could you pls. have a look at https://review.openstack.org/#/c/203573/ since you have reviewed similar patch? | 14:03 |
| *** rajesht has quit IRC | 14:03 | |
| *** ankit_ag has quit IRC | 14:03 | |
| gzhai | dansmith: Thanks! | 14:03 |
| openstackgerrit | John Garbutt proposed openstack/nova: api: tidy up paste.ini https://review.openstack.org/214085 | 14:04 |
| *** whitekid has quit IRC | 14:06 | |
| *** kbyrne has quit IRC | 14:07 | |
| *** otter768 has quit IRC | 14:07 | |
| *** timbyr_ has quit IRC | 14:07 | |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Make compute_api.trigger_members_refresh() issue a single db call https://review.openstack.org/72382 | 14:08 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Remove unused db.security_group_rule_get_by_security_group_grantee() https://review.openstack.org/72383 | 14:08 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Revert "Make nova-network use conductor for security groups refresh" https://review.openstack.org/182212 | 14:08 |
| *** ajayaa has quit IRC | 14:08 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Remove get_all method from servicegroup API https://review.openstack.org/214629 | 14:09 |
| *** shoutm has quit IRC | 14:10 | |
| *** thangp has joined #openstack-nova | 14:10 | |
| *** kbyrne has joined #openstack-nova | 14:11 | |
| jaypipes | dansmith: should we have the convo on the patch, or wait for a chance to do a high-bandwidth conversation next week when y'all are back from Seattle? | 14:12 |
| dansmith | jaypipes: the latter is fine I think | 14:13 |
| dansmith | less stuff to do this week is better | 14:13 |
| dansmith | if that's cool | 14:13 |
| jaypipes | no problem ata ll, dansmith | 14:14 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Expose keystoneclient's session and auth plugin loading parameters https://review.openstack.org/214423 | 14:15 |
| *** thumpba has joined #openstack-nova | 14:15 | |
| andreykurilin__ | alaski: thanks for explanation. Ok, I understand that response can be bigger, but since nova already provides API for creating multiple vms by one call, imo, we should deprecate such ability or update response | 14:16 |
| *** boris-42 has joined #openstack-nova | 14:16 | |
| ftersin | dansmith: i've answered you there. please look at, when you have a time | 14:16 |
| dansmith | ftersin: okay I will | 14:16 |
| alaski | andreykurilin__: there has been talk of deprecating that ability | 14:17 |
| *** garyk has quit IRC | 14:17 | |
| *** busterswt has joined #openstack-nova | 14:17 | |
| *** cfriesen has joined #openstack-nova | 14:17 | |
| andreykurilin__ | alaski: got it | 14:18 |
| andreykurilin__ | thanks | 14:18 |
| *** mtanino has joined #openstack-nova | 14:18 | |
| jaypipes | markus_z: BTW, thank you for tackling the global CONF problem. really appreciate your efforts there. | 14:18 |
| alaski | andreykurilin__: I agree that it's a bit poor at the moment. But all discussion has been around removing it or using tasks, and avoiding returning everything. | 14:19 |
| markus_z | jaypipes: Thanks, nice to hear. I hope I can make the picture clearer with another patch set. | 14:19 |
| jaypipes | markus_z: yep, that would be cool. looking forward to seeing it. | 14:20 |
| *** gszasz has quit IRC | 14:20 | |
| markus_z | jaypipes: Having all options in one file would result in a huge one I guess. I've seen that we already have 800 options. | 14:20 |
| *** jecarey has quit IRC | 14:21 | |
| jaypipes | markus_z: doesn't need to be in one file really... just importable via one module. So, basically, setting the __all__ meta attribute on the dunderinit file in nova/conf/ | 14:21 |
| jaypipes | markus_z: just as long as we don't need to remember what directory/module a particular option is in eventually, I'd be happy with that. | 14:22 |
| *** edmondsw has quit IRC | 14:22 | |
| markus_z | jaypipes: Ah, OK, that's the issue you want to tackle, got it | 14:22 |
| jaypipes | markus_z: think of the way that all of the nova objects are registered in nova/objects/__init__.py :) | 14:22 |
| jaypipes | markus_z: which makes it simple to use... from nova import objects; obj = objects.Instance(**values) | 14:22 |
| *** aysyd has joined #openstack-nova | 14:23 | |
| Kevin_Zheng_ | johnthetubaguy: Thanks a lot, I might konw what you mean, I will try to fix that. | 14:23 |
| *** gzhai has quit IRC | 14:23 | |
| jaypipes | markus_z: would be awesome to do: from nova import conf; if conf.getopt('libvirt_driver') == 'kvm': do something... | 14:23 |
| *** gzhai has joined #openstack-nova | 14:23 | |
| jaypipes | markus_z: or something like that... you get the idea. | 14:24 |
| *** dave-mccowan has quit IRC | 14:24 | |
| jaypipes | markus_z: eventually it would be great to inject only the relevant configuration options into the base driver/manager classes and not import nova.conf at all of course. | 14:24 |
| jaypipes | markus_z: so, getting rid of the global conf entirely, but I realize that's a ways away... | 14:25 |
| *** edleafe has quit IRC | 14:27 | |
| markus_z | jaypipes: Yeah, the injection of the relevant data is what I have in mind. And you are right, maybe we need a second step in between before we can do that. I'll have a look. | 14:28 |
| *** edleafe has joined #openstack-nova | 14:28 | |
| *** browne has joined #openstack-nova | 14:29 | |
| *** Sree has quit IRC | 14:31 | |
| *** deepakcs has joined #openstack-nova | 14:33 | |
| *** deepakcs has quit IRC | 14:34 | |
| *** Murali has quit IRC | 14:34 | |
| jaypipes | dansmith: my new favorite image: https://s-media-cache-ak0.pinimg.com/736x/59/cd/5c/59cd5c0b8b1929a3a6ceb2b3e420d51a.jpg | 14:35 |
| *** edmondsw has joined #openstack-nova | 14:37 | |
| *** mriedem_meeting is now known as mriedem | 14:37 | |
| *** dave-mccowan has joined #openstack-nova | 14:38 | |
| *** lalitd has joined #openstack-nova | 14:38 | |
| cfriesen | has anyone considered adding a "--tenant-id" or "--owner" field to the nova commands? That would allow an admin user to set up nova resources on behalf of other tenants. Other components seem to have this ability but nova doesn't. | 14:39 |
| *** rlrossit has joined #openstack-nova | 14:39 | |
| *** VW_ has joined #openstack-nova | 14:39 | |
| sudipto | rlrossit, how about changing the creation of the MonitorMetric object to: MonitorMetric(**metric) for metric in leg_dict | 14:40 |
| sudipto | rlrossit, talking about: https://review.openstack.org/#/c/213317/6 | 14:41 |
| *** rlrossit1 has quit IRC | 14:41 | |
| rlrossit | sudipto: it does look like the kwargs are identical so that would be super ideal. Great idea! | 14:42 |
| *** alexschm has quit IRC | 14:42 | |
| edmondsw | cfriesen, we need to support changing ownership, and then moving something to a different tenant/project, but allowing the admin of project A to create something in project B sounds like a security flaw | 14:42 |
| sudipto | rlrossit, cool! | 14:42 |
| rlrossit | sudipto: and then you could probably do jsonutils.loads() as part of the list comprehension too? that would super compress that part down too | 14:43 |
| alaski | cfriesen: I think that would be handled on the identity side, having an admin able to get a token scoped to another tenant | 14:43 |
| edmondsw | that admin is only an admin in project A... not project B. Or if they also have the admin role in project B, they should get a token for project B and use that to create there | 14:43 |
| *** zzzeek has joined #openstack-nova | 14:43 | |
| *** garyk has joined #openstack-nova | 14:44 | |
| sudipto | rlrossit, yeah that's a very valid point, i missed jaypipes's comment on that :) thanks for pointing that out. | 14:44 |
| *** gzhai has quit IRC | 14:45 | |
| *** jcoufal_ has joined #openstack-nova | 14:45 | |
| *** Murali has joined #openstack-nova | 14:46 | |
| *** tonytan4ever has joined #openstack-nova | 14:46 | |
| *** tpeoples has joined #openstack-nova | 14:46 | |
| *** annegentle has joined #openstack-nova | 14:46 | |
| *** annegentle has quit IRC | 14:47 | |
| *** busterswt has quit IRC | 14:47 | |
| *** annegentle has joined #openstack-nova | 14:47 | |
| *** jecarey has joined #openstack-nova | 14:48 | |
| *** jcoufal has quit IRC | 14:48 | |
| lalitd | alaski: today meeting will be there at 1700 UTC ? | 14:49 |
| alaski | lalitd: should be next week at 1700 | 14:50 |
| alaski | although the wiki is wrong, let me update that | 14:50 |
| cfriesen | admondsw: alaski: "neutron net-create" for instance has the "--tenant-id" flag which lets you create a network and assign the owner tenant. cinder and glance have the "--owner" flag when creating resources. | 14:50 |
| cfriesen | whoops, maybe not cinder. | 14:51 |
| alaski | cfriesen: I don't have a strong opinion on it, but I do think that handling it via identity is the proper and robust route. then each service doesn't need to implement a --tenant-id flag, and worry about authorization if identity moves past a single tenant auth scheme | 14:53 |
| *** diogogmt has joined #openstack-nova | 14:54 | |
| *** xgsa1 has joined #openstack-nova | 14:54 | |
| openstackgerrit | whitekid proposed openstack/nova: tuning extended volume extension https://review.openstack.org/211258 | 14:54 |
| *** xgsa has quit IRC | 14:55 | |
| lalitd | alaski: I have to discuss about flavor support for nova and api db. I have implemented flavor-creation part, which will create flavor in api db and for duplicacy it checks in both db https://review.openstack.org/#/c/213041/ | 14:56 |
| *** Murali has quit IRC | 14:56 | |
| lalitd | alaski: can you have a look on https://review.openstack.org/#/c/213041/ | 14:57 |
| *** emagana has quit IRC | 14:57 | |
| cfriesen | alaski: fair enough, thanks | 14:57 |
| alaski | lalitd: sure, opened in a tab to look in a bit | 14:57 |
| *** ccesario has joined #openstack-nova | 14:59 | |
| *** MarcF has quit IRC | 15:00 | |
| *** dims has quit IRC | 15:01 | |
| *** logan2 has quit IRC | 15:01 | |
| *** dims has joined #openstack-nova | 15:01 | |
| *** xgsa1 has quit IRC | 15:02 | |
| *** agireud has joined #openstack-nova | 15:02 | |
| *** xgsa has joined #openstack-nova | 15:03 | |
| *** artom has quit IRC | 15:04 | |
| *** dims_ has joined #openstack-nova | 15:05 | |
| *** logan2 has joined #openstack-nova | 15:05 | |
| *** artom has joined #openstack-nova | 15:05 | |
| *** dims has quit IRC | 15:06 | |
| *** shaohe_feng has joined #openstack-nova | 15:07 | |
| lalitd | alaski: right now only flavor_create() function is implemented in API DB so some tests are failing which are related to flavor_get*. but some tests are failing due to soft delete removal. | 15:07 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Utilize object directly of instance and flavor https://review.openstack.org/185068 | 15:07 |
| mriedem | jichen: ^ i pulled that out of the gate | 15:07 |
| *** zul has joined #openstack-nova | 15:07 | |
| mriedem | jichen: it looks like we can now remove the flavor type check and compat in the _cold_migrate flow in conductor manager | 15:08 |
| mriedem | given the note from melwitt about removing that once we're at v2.0 for conductor, and we're at v2.1 right now | 15:08 |
| jichen | mriedem: ok, got it , let me take a look ,thanks | 15:08 |
| johnthetubaguy | alaski: melwitt: hey, just wondering if we can fill up the list of cells changes in the etherpad? I guess there are a few more changes that can get reviewed now?: https://etherpad.openstack.org/p/liberty-nova-priorities-tracking | 15:09 |
| alaski | johnthetubaguy: sure | 15:10 |
| *** hemnafk is now known as hemna | 15:11 | |
| markus_z | johnthetubaguy: My 2cents to the gerrit dashboard: https://goo.gl/rQpW0G I can maintain such a list if we decide to go this way. | 15:12 |
| jichen | mriedem: ok, I got your point now , I will do it according to the suggestion, thanks~ | 15:12 |
| *** dannywilson has joined #openstack-nova | 15:13 | |
| *** dannywilson has quit IRC | 15:14 | |
| *** dannywilson has joined #openstack-nova | 15:14 | |
| *** agireud has quit IRC | 15:16 | |
| *** atuvenie has joined #openstack-nova | 15:16 | |
| *** coolsvap|away is now known as coolsvap | 15:18 | |
| *** yamahata has joined #openstack-nova | 15:18 | |
| *** dims_ has quit IRC | 15:19 | |
| *** dims has joined #openstack-nova | 15:19 | |
| *** ashishb has quit IRC | 15:22 | |
| *** coolsvap is now known as coolsvap|away | 15:22 | |
| *** irenab has quit IRC | 15:22 | |
| *** moshele has quit IRC | 15:23 | |
| *** zul has quit IRC | 15:23 | |
| openstackgerrit | Simona Iuliana Toader proposed openstack/nova: Hyper-V: Adds Hyper-V UEFI Secure Boot https://review.openstack.org/209581 | 15:24 |
| openstackgerrit | Simona Iuliana Toader proposed openstack/nova: Hyper-V: refactors utilsfactory https://review.openstack.org/214527 | 15:24 |
| *** burgerk has quit IRC | 15:24 | |
| *** burgerk has joined #openstack-nova | 15:24 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Add functional test for server group https://review.openstack.org/147514 | 15:26 |
| lalitd | alaski: after getting throgh patch set, can you suggest about the further implementation of flavor_get* i.e in API DB these should me implemented or other way? | 15:26 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Fix host_manager to use monitor metric objects https://review.openstack.org/213317 | 15:26 |
| *** vivekd has joined #openstack-nova | 15:27 | |
| *** agireud has joined #openstack-nova | 15:30 | |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Fix host_manager to use monitor metric objects https://review.openstack.org/213317 | 15:30 |
| ftersin | mnestratov: hi. about but 1486204 | 15:31 |
| *** irenab has joined #openstack-nova | 15:31 | |
| openstackgerrit | Adelina Tuvenie proposed openstack/nova: Fixes Bug "destroy_vm fails with HyperVException" https://review.openstack.org/204007 | 15:31 |
| mnestratov | ftersin: hi | 15:31 |
| ftersin | mnestratov: is it related to root device only, or it affects all devices? | 15:31 |
| mnestratov | ftersin: root device only, right | 15:32 |
| ftersin | mnestratov: and what about parallels, does it use libvirt? | 15:32 |
| openstackgerrit | lalit dagre proposed openstack/nova: WIP: Flavor create using api DB https://review.openstack.org/213041 | 15:33 |
| *** xgsa has quit IRC | 15:33 | |
| mnestratov | ftersin: hmm, in fact other devices are affected also if root device is not specified with letter 'a' | 15:33 |
| mnestratov | ftersin: yes, parallels is in fact libvirt subdriver libvirt virt_type=parallels | 15:34 |
| *** eglynn has joined #openstack-nova | 15:35 | |
| ftersin | mnestratov: what kind of affect for other devices? just anoter autoselected device names or they keep user defined names? | 15:35 |
| mnestratov | ftersin: if you try to boot from volume and have swap or ephemeral disk, and you specify 'vdc' for instance for your root device, your secondary ephemeral disk will get 'vda' name, which is incorrect | 15:38 |
| alaski | lalitd: sure. I'll put the suggestions on the review | 15:38 |
| *** tsekiyama has joined #openstack-nova | 15:38 | |
| ftersin | mnestratov: well, this is just a consequence of the keeping of root volume name | 15:39 |
| *** ahilan has joined #openstack-nova | 15:39 | |
| lalitd | alaski: thankyou | 15:39 |
| *** haomaiwang has quit IRC | 15:40 | |
| ftersin | mnestratov: but what is a reason for a user to specify vdc for a root device? | 15:40 |
| *** scheuran has joined #openstack-nova | 15:40 | |
| *** nkrinner has quit IRC | 15:41 | |
| ftersin | mnestratov: or this is just an example to reproduce a problem? | 15:41 |
| mnestratov | ftersin: no reason, it is just an example | 15:42 |
| *** Piet has quit IRC | 15:42 | |
| *** VW_ has quit IRC | 15:43 | |
| ftersin | mnestratov: ok. what about disk bus with parallels? as i understand you, if i specify vda for a root device, the result name should become sda. is it right? | 15:43 |
| mnestratov | ftersin: yes | 15:44 |
| mnestratov | the same for qemu/kvm with iscsi bus | 15:44 |
| *** busterswt has joined #openstack-nova | 15:44 | |
| *** dustins has quit IRC | 15:44 | |
| ftersin | mnestratov: thanks | 15:44 |
| *** tonytan4ever has quit IRC | 15:45 | |
| mnestratov | ftersin: and it was intended by ndipanov as far as i understand | 15:45 |
| ftersin | mnestratov: so there is no reason to pass in root device name to device name 'calculator' | 15:45 |
| *** zul has joined #openstack-nova | 15:45 | |
| *** emagana has joined #openstack-nova | 15:46 | |
| ftersin | mnestratov: but get_disk_mapping produces not only volume records, but a root record as well | 15:47 |
| *** atuvenie has quit IRC | 15:47 | |
| ftersin | mnestratov: before my fix in your case the root record had '/dev/vdc' name, while the volume record had '/dev/sda' name | 15:48 |
| *** tonytan4ever has joined #openstack-nova | 15:48 | |
| *** lpetrut has quit IRC | 15:48 | |
| ftersin | mnestratov: thus the root record was wrong, but it doesn't break anything | 15:49 |
| *** dims has quit IRC | 15:49 | |
| *** shaohe_feng1 has joined #openstack-nova | 15:49 | |
| *** dims has joined #openstack-nova | 15:49 | |
| *** scheuran has quit IRC | 15:50 | |
| ftersin | mnestratov: so the question is - should we continue to create the root record if it wrong state doesn't lead to errors | 15:50 |
| ftersin | mnestratov: i'm going to dig this a few | 15:50 |
| *** mdrabe has quit IRC | 15:51 | |
| mnestratov | ftersin: I guess it is used for other drivers | 15:51 |
| *** shaohe_feng has quit IRC | 15:51 | |
| *** dprince has quit IRC | 15:51 | |
| ftersin | mnestratov: probably | 15:51 |
| ftersin | mnestratov: but when you was fixing this, did you look at get_disk_mapping result? | 15:52 |
| *** alex_klimov has quit IRC | 15:52 | |
| johnthetubaguy | it would be great if someone can dig deep on these BDM issues, and try fix things up across all the drivers, I think adding tempest tests for the desired behaviour is a good way to start | 15:52 |
| openstackgerrit | jichenjc proposed openstack/nova: Return HTTPForbidden if over quota https://review.openstack.org/180469 | 15:52 |
| mnestratov | ftersin: you mean mapping['root'] ? | 15:53 |
| *** dims_ has joined #openstack-nova | 15:53 | |
| ftersin | mnestratov: yes. what does it return with your fix for the root record? | 15:53 |
| ftersin | mnestratov: does it has correct (/dev/sda) name or does not? | 15:53 |
| *** shaohe_feng1 has quit IRC | 15:53 | |
| *** dims has quit IRC | 15:54 | |
| mnestratov | johnthetubaguy: absolutly agree, I'll try to write some tempest test for this | 15:54 |
| *** Sukhdev has joined #openstack-nova | 15:54 | |
| *** Nikolay_St has quit IRC | 15:55 | |
| *** zul has quit IRC | 15:55 | |
| ftersin | mnestratov: never mind, it should be correct. because it's a copy of the volume record | 15:55 |
| mnestratov | ftersin: I'll tell you in a couple of hours, I have to go right now | 15:56 |
| ftersin | mnestratov: well, thank you. i'll think and dig | 15:56 |
| *** takedakn has joined #openstack-nova | 15:57 | |
| mnestratov | ftersin: before I left, yes, it was correct | 15:59 |
| *** schwicke has joined #openstack-nova | 16:00 | |
| johnthetubaguy | mnestratov: thank you, that would be great | 16:00 |
| ahilan | jaypipes: Would this be a place where we can discuss the Nova Monitor Metrics new framework ? | 16:00 |
| jaypipes | ahilan: absolutely. just give me about 15 minutes? | 16:01 |
| ahilan | jaypipes: sure. Thanks | 16:01 |
| *** garyk1 has joined #openstack-nova | 16:02 | |
| *** lyanchih has quit IRC | 16:02 | |
| *** mdrabe has joined #openstack-nova | 16:03 | |
| *** kiran-r has joined #openstack-nova | 16:03 | |
| *** garyk has quit IRC | 16:03 | |
| *** otter768 has joined #openstack-nova | 16:04 | |
| *** mestery has joined #openstack-nova | 16:04 | |
| *** exploreshaifali has joined #openstack-nova | 16:06 | |
| *** eglynn has quit IRC | 16:06 | |
| *** irenab has quit IRC | 16:07 | |
| *** xgsa has joined #openstack-nova | 16:07 | |
| openstackgerrit | jichenjc proposed openstack/nova: Remove 'Retry-After' in server create and resize https://review.openstack.org/214691 | 16:07 |
| *** Apoorva has joined #openstack-nova | 16:07 | |
| *** fawadkhaliq has joined #openstack-nova | 16:08 | |
| *** irenab has joined #openstack-nova | 16:08 | |
| *** Piet has joined #openstack-nova | 16:08 | |
| *** otter768 has quit IRC | 16:08 | |
| bauzas | jaypipes: heya, FYI, I'm going to spin-off a new shot of the ReqSpec chain of the hell because I just discovered that it was discussed before to dump the Flavor object | 16:09 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Remove 'v3' from extension code https://review.openstack.org/214311 | 16:09 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Remove v3 references in unit test 'contrib' https://review.openstack.org/212851 | 16:09 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Remove more 'v3' references from the code https://review.openstack.org/214290 | 16:09 |
| *** dustins has joined #openstack-nova | 16:09 | |
| *** VW_ has joined #openstack-nova | 16:11 | |
| *** kmartin has joined #openstack-nova | 16:11 | |
| *** busterswt has quit IRC | 16:12 | |
| edleafe | johnthetubaguy: ^ Just a rebase. Wondering the best way to resolve the /v2 vs. /v21 question. | 16:12 |
| dansmith | jaypipes: lol, nice | 16:13 |
| *** jichen has quit IRC | 16:13 | |
| *** vivekd has quit IRC | 16:14 | |
| *** Guest95303 has quit IRC | 16:16 | |
| jaypipes | bauzas: sounds good. | 16:16 |
| bauzas | jaypipes: I just bermoan that kind of discussion happening now close to FF :) | 16:18 |
| *** jcoufal_ has quit IRC | 16:18 | |
| *** dprince has joined #openstack-nova | 16:19 | |
| *** takedakn has quit IRC | 16:20 | |
| *** lpetrut has joined #openstack-nova | 16:21 | |
| *** moshele has joined #openstack-nova | 16:21 | |
| openstackgerrit | Jay Pipes proposed openstack/nova: Move abort and update_usage tests to test_tracker https://review.openstack.org/213590 | 16:22 |
| openstackgerrit | Jay Pipes proposed openstack/nova: Move test of claim context manager to test_tracker https://review.openstack.org/213591 | 16:22 |
| openstackgerrit | Jay Pipes proposed openstack/nova: pci: Remove nova.pci.device module https://review.openstack.org/213588 | 16:22 |
| openstackgerrit | Jay Pipes proposed openstack/nova: Cleanup RT _instance_in_resize_state() https://review.openstack.org/213589 | 16:22 |
| openstackgerrit | Jay Pipes proposed openstack/nova: pci: Remove objects.InstancePCIRequests.save() https://review.openstack.org/213587 | 16:22 |
| openstackgerrit | Jay Pipes proposed openstack/nova: Move resize claim abort test to test_tracker https://review.openstack.org/213592 | 16:22 |
| *** unicell has quit IRC | 16:23 | |
| *** ctrath has quit IRC | 16:24 | |
| johnthetubaguy | edleafe: good question, not sure the best way to work that out, given the user should be calling /v21/ it feels to me like the tests should | 16:24 |
| edleafe | johnthetubaguy: I wasn't involved in the V3 days, so I'm really not sure what the original intent was | 16:25 |
| johnthetubaguy | edleafe: I have to take my sister to the rail station I am afraid, I will try catch alex_xu about that in the morning | 16:25 |
| edleafe | johnthetubaguy: ok. FWIW, my original had /v21, and alex_xu asked me to change it | 16:25 |
| johnthetubaguy | edleafe: I think we should ignore the v3 intent here, we want all the code testing /v2.1 (the new thing), and well, we can use those to test /v2 as well in most cases | 16:26 |
| *** penick has joined #openstack-nova | 16:26 | |
| edleafe | johnthetubaguy: well, it helps to understand the intent of the original design when mucking around with changes :) | 16:27 |
| *** _kiran_ has joined #openstack-nova | 16:27 | |
| *** VW_ has quit IRC | 16:27 | |
| *** VW_ has joined #openstack-nova | 16:28 | |
| *** VW_ has quit IRC | 16:29 | |
| *** VW_ has joined #openstack-nova | 16:29 | |
| *** jistr has quit IRC | 16:30 | |
| *** jordanP has quit IRC | 16:30 | |
| *** vilobhmm1 has joined #openstack-nova | 16:30 | |
| *** kiran-r has quit IRC | 16:31 | |
| *** vivekd has joined #openstack-nova | 16:31 | |
| jaypipes | lxsli: please see my responses on https://review.openstack.org/#/c/213592/ and its two dependent patches... | 16:31 |
| openstackgerrit | Jay Pipes proposed openstack/nova: rt: Rewrite abort and update_usage tests https://review.openstack.org/213590 | 16:31 |
| openstackgerrit | Jay Pipes proposed openstack/nova: Move test of claim context manager to test_tracker https://review.openstack.org/213591 | 16:31 |
| openstackgerrit | Jay Pipes proposed openstack/nova: Move resize claim abort test to test_tracker https://review.openstack.org/213592 | 16:31 |
| *** thumpba has quit IRC | 16:32 | |
| *** browne has quit IRC | 16:36 | |
| sdague | mriedem: you mean - https://github.com/stackforge/gerrit-dash-creator/blob/master/dashboards/compute-program.dash ? | 16:37 |
| sdague | honestly, we can tweak that sort of thing later. This week is kind of distracting with conference going on | 16:37 |
| *** ctrath has joined #openstack-nova | 16:37 | |
| mriedem | sdague: sure | 16:38 |
| melwitt | dansmith: I saw your comment about making fields nullable on https://review.openstack.org/#/c/211048 and I was wondering, how is it different than the approach in https://review.openstack.org/#/c/169284/ ? or are they both not okay? | 16:38 |
| bauzas | alaski: edleafe: okay, I went into the hips of removing the Flavor object from the ReqSpec and my answer is NO - please don't remove it, at least due to the TypeFilter | 16:38 |
| *** dims_ has quit IRC | 16:39 | |
| *** dims has joined #openstack-nova | 16:39 | |
| mriedem | belliott: i think that comment maybe needs to change from "Remove this in version 2.0 of the RPC API" to "Remove this when we drop support for v1 of the RPC API" | 16:40 |
| *** zul has joined #openstack-nova | 16:40 | |
| *** schwicke has quit IRC | 16:40 | |
| belliott | mriedem: yeah i guess my general question is when do we drop v1.x rpc apis | 16:40 |
| bauzas | alaski: edleafe: so I'll stick with my latest patch series, ie. https://review.openstack.org/#/c/145528/43 | 16:40 |
| belliott | or have we? lots of references to 1.x in rpcapi code | 16:40 |
| mriedem | dansmith: are you MIA today? | 16:41 |
| *** ssurana has joined #openstack-nova | 16:42 | |
| bauzas | alaski: so I guess you would be unhappy with that, so any time for a convo ? | 16:42 |
| melwitt | dansmith: nvm, I see your response on the review now | 16:43 |
| mriedem | melwitt: can you take a look at this and see if my logic is correct? https://review.openstack.org/#/c/185068/4/nova/conductor/manager.py | 16:43 |
| ahilan | jaypipes: available for monitor metrics discussion ? | 16:44 |
| jaypipes | ahilan: yes, sorry for not pinging you back. | 16:44 |
| ahilan | jaypipes: no problem. I would like to know whether we can pass the MonitorMetric object as a parameter to the get_metric() abstract method | 16:45 |
| *** romainh has quit IRC | 16:46 | |
| ahilan | This way the metrics plugin can set their own fields in the MonitorMetric object instead of modifying the Nova/Compute/monitors/base.py | 16:46 |
| jaypipes | ahilan: yeah, I think that's a good idea. | 16:47 |
| *** Marga_ has quit IRC | 16:47 | |
| melwitt | mriedem: had to think about it a bit. my understanding is we have to keep those compat things until we can be sure we won't receive any old-world objects from anything during a same-release upgrade. and once we bump the major version, we're guaranteed to receive only objects (the next release) | 16:47 |
| *** zul has quit IRC | 16:47 | |
| jaypipes | ahilan: feel free to propose a patch that does just that. | 16:47 |
| mriedem | melwitt: yeah, so that was added in 1.10, | 16:47 |
| jaypipes | ahilan: might want to rename the abstractmethod to "populate_metric_object" then? | 16:47 |
| mriedem | so until we drop 1.x, we have to keep the compat shim in is my understanding | 16:47 |
| mriedem | melwitt: so the comment about dropping it when we moved to 2.0 confused me | 16:47 |
| *** SourabhP has joined #openstack-nova | 16:48 | |
| ahilan | oh ok. sure would do that | 16:48 |
| jaypipes | ahilan: thank you! :) | 16:48 |
| jaypipes | ahilan: that's a very good proposal. | 16:48 |
| *** zul has joined #openstack-nova | 16:49 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Fixes snapshoting inexistent VM issue https://review.openstack.org/214560 | 16:49 |
| melwitt | mriedem: hm. I guess I think of it as 1.x has to work together between its versions but 1.x doesn't have to work with 2.x | 16:50 |
| ahilan | jaypipes: np. thank you. I am trying to extend the nova monitor metric to provide a new plugin, and thats when i noticed that to extend, i had to modify base.py, __init.py, and nova/objects/fields.py and nova/objects/monitor_metric.py | 16:50 |
| *** SourabhP_ has joined #openstack-nova | 16:50 | |
| *** earlephilhower has quit IRC | 16:51 | |
| ahilan | jaypipes: If i can avoid changing the base and core parts and only provide extension/addition through new plugin parts then it probably extend well | 16:51 |
| *** derekh has quit IRC | 16:51 | |
| *** dustins has quit IRC | 16:52 | |
| jaypipes | ahilan: ++ | 16:52 |
| *** SourabhP has quit IRC | 16:52 | |
| *** SourabhP_ is now known as SourabhP | 16:52 | |
| *** atuvenie has joined #openstack-nova | 16:53 | |
| *** tjones has joined #openstack-nova | 16:53 | |
| *** tjones has left #openstack-nova | 16:53 | |
| *** tonytan4ever has quit IRC | 16:54 | |
| *** lpetrut has quit IRC | 16:54 | |
| edleafe | bauzas: ugh, you're right | 16:54 |
| *** unicell has joined #openstack-nova | 16:55 | |
| *** dustins has joined #openstack-nova | 16:56 | |
| bauzas | edleafe: I mean, that's fair to say that some instance-related fields are okay, but then by adding flavor.id and flavor.name, it just means we're duplicating some flavor-related fields which would create some bugs if we are bad by syncing them | 16:56 |
| bauzas | alaski: ^ | 16:56 |
| bauzas | jaypipes: I know you were pretty off the discussion, but do you get the problem ? | 16:56 |
| bauzas | jaypipes: I would enjoy your thoughts on that | 16:57 |
| edleafe | bauzas: yes, the spec for moving flavors to API-only will have to deal with the TYpeFilter | 16:57 |
| jaypipes | bauzas: sorry, you're bringing me in at the middle/end of the conversation... could you fill me in on the question and problem we're trying to solve? | 16:57 |
| bauzas | jaypipes: np | 16:58 |
| bauzas | jaypipes: you have rights to hate me | 16:58 |
| *** meghal has joined #openstack-nova | 16:59 | |
| bauzas | jaypipes: so, the stuff isin https://review.openstack.org/#/c/145528/44 | 16:59 |
| *** nic has joined #openstack-nova | 16:59 | |
| *** Nikolay_St has joined #openstack-nova | 16:59 | |
| *** _kiran_ has quit IRC | 16:59 | |
| bauzas | jaypipes: the thing is, I was lazily copying the flavor-related fields and leaving the Flavor object | 16:59 |
| bauzas | jaypipes: somewhere we have to decide either to keep only a Flavor object, or duplicate all the necessary fields in the Spec object and dump the nested object | 17:00 |
| bauzas | jaypipes: due to the typ_filters.py filters, it inflates a huge number of fields which worries me about syncing thay | 17:01 |
| bauzas | jaypipes: so MHO is to keep a Flavor nested object like I did in PS44 | 17:01 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: Allow for migration object to be passed to _move_claim https://review.openstack.org/199679 | 17:01 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: rt: generalize claim code to be useful for other move actions https://review.openstack.org/197138 | 17:01 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: rt: move filtering of mygration by type lower in the call stack https://review.openstack.org/199678 | 17:01 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: compute: Make rebuild_instance RPC take additional args https://review.openstack.org/200485 | 17:01 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: compute: Split the rebuild_instance method https://review.openstack.org/213461 | 17:01 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: compute: Make rebuild consider the node that was passed in https://review.openstack.org/214713 | 17:01 |
| *** emagana has quit IRC | 17:02 | |
| *** lpetrut has joined #openstack-nova | 17:02 | |
| *** vivekd has quit IRC | 17:02 | |
| *** emagana has joined #openstack-nova | 17:03 | |
| jaypipes | bauzas: I'm actually with alaski on this. I would really prefer to have the fields broken out instead of having a Flavor object in there. The TypeFilter should go away, IMHO. there's nothing in it that cannot be done with other filters, frankly. | 17:03 |
| *** unicell has quit IRC | 17:04 | |
| *** vivekd has joined #openstack-nova | 17:04 | |
| *** unicell has joined #openstack-nova | 17:04 | |
| dansmith | mriedem: yeah, mostly | 17:05 |
| bauzas | jaypipes: we can't just say "let's remove a filter" you kno w :) | 17:05 |
| *** apuimedo has quit IRC | 17:05 | |
| dansmith | melwitt: the other example is less smelly in my opinion because it actually finds and fills in the service_id, so it's actually compatible | 17:05 |
| bauzas | jaypipes: so, you agree with duplicating fields and leave the syncing problem to be resolved later? | 17:05 |
| jaypipes | bauzas: sure we can.. just change its implementation to return True always, and rely on the other fine-grained filters to do the work. | 17:05 |
| bauzas | service_id mmm ? | 17:05 |
| bauzas | jaypipes: hah | 17:05 |
| jaypipes | bauzas: I'm being serious. | 17:06 |
| bauzas | jaypipes: are you wanting to delay the Spec object ? :) | 17:06 |
| jaypipes | bauzas: no... | 17:06 |
| jaypipes | bauzas: I suppose we can always go forward with using a Flavor object field and break it out in the future... | 17:06 |
| bauzas | jaypipes: sure, was just frightening you, my bad | 17:06 |
| jaypipes | bauzas: and just deprecate the Flavor object field in the future after breaking it out into a separate resource collection and extra specs/conditions thing. | 17:07 |
| bauzas | jaypipes: I think it sounds possible to do a later patch series where we could just add a new version of the Spec object and deprecate the type filter if needed | 17:07 |
| jaypipes | bauzas: yeah, I'm cool with that. | 17:07 |
| melwitt | dansmith: I see your point. the only odd part of the compute node one is setting service_id = -1 if it's not found | 17:07 |
| jaypipes | alaski: you cool with a refactor in the future to break out that stuff? | 17:07 |
| edleafe | bauzas: +1 | 17:08 |
| *** kmartin has quit IRC | 17:08 | |
| *** kmartin has joined #openstack-nova | 17:08 | |
| bauzas | melwitt: dansmith: just taking the convo now, what's the change? | 17:08 |
| bauzas | or problem ? | 17:08 |
| dansmith | melwitt: yeah, which is probably a good thing to bring up, but if it won't actually harm the behavior of the older code then it's actually okay | 17:08 |
| dansmith | melwitt: I think we've been not using service.id for a while now, even though it's in the object schema, | 17:08 |
| dansmith | so that might be just fine | 17:08 |
| mriedem | garyk1: this drives me nuts https://review.openstack.org/#/c/204622/ | 17:09 |
| mriedem | the testing | 17:09 |
| melwitt | bauzas: I was just asking dansmith about https://review.openstack.org/#/c/211048 vs https://review.openstack.org/#/c/169284/ making fields nullable and handling the compat | 17:09 |
| * bauzas looking | 17:09 | |
| bauzas | ha that one | 17:10 |
| mriedem | garyk1: that's a perfect example of why i get frustrated reviewing vmware patches | 17:10 |
| melwitt | dansmith: yeah. the rationale on the service id is, the -1 will make it not be found by anything trying to query it, so it doesn't break anything | 17:10 |
| *** yassine__ has quit IRC | 17:10 | |
| bauzas | melwitt: so hans was giving me a hand on finishing the detach-service BP | 17:11 |
| bauzas | melwitt: so I think his change is very safe | 17:11 |
| *** VW_ has quit IRC | 17:11 | |
| bauzas | melwitt: but lemme look at feodor's change | 17:11 |
| *** asselin_ has joined #openstack-nova | 17:11 | |
| *** VW_ has joined #openstack-nova | 17:12 | |
| melwitt | bauzas: yeah, I saw your comments on hans patch | 17:12 |
| *** rajesht has joined #openstack-nova | 17:12 | |
| *** moshele has quit IRC | 17:12 | |
| *** jichen has joined #openstack-nova | 17:13 | |
| bauzas | melwitt: so, I definitely prefer hans's change, it's definitely more acceptable because having a service_id negative is totally understandable - it just means no service related | 17:13 |
| *** markus_z has quit IRC | 17:14 | |
| bauzas | melwitt: while putting empty string for a field doesn't carry a specific message IMHO | 17:14 |
| bauzas | melwitt: it just means "I don't know what I should fill in that field, so I'm putting blank" | 17:14 |
| *** mestery has quit IRC | 17:14 | |
| bauzas | that's very dangerous IMHO | 17:14 |
| openstackgerrit | Bob Ball proposed openstack/nova: To expose disk labels in guest for root and ephemeral disks https://review.openstack.org/213094 | 17:15 |
| rajesht | dansmith, alaski, mikal, melwitt: could you please review https://review.openstack.org/#/c/170118/ | 17:15 |
| melwitt | bauzas: yeah | 17:16 |
| *** VW_ has quit IRC | 17:16 | |
| *** SourabhP has quit IRC | 17:17 | |
| *** angdraug has joined #openstack-nova | 17:17 | |
| *** ndipanov has joined #openstack-nova | 17:17 | |
| *** ndipanov_ has joined #openstack-nova | 17:17 | |
| *** VW_ has joined #openstack-nova | 17:17 | |
| *** ndipanov_ has quit IRC | 17:18 | |
| *** claudiub has quit IRC | 17:18 | |
| sdague | johnthetubaguy: can you +A this through - https://review.openstack.org/#/c/180956/ - it's got 2 +2s on it, you are one of them, and it would land 2 cleanup patches I've had up for 3 months. | 17:18 |
| dansmith | bauzas: agree | 17:19 |
| *** fawadk has joined #openstack-nova | 17:20 | |
| *** fawadkhaliq has quit IRC | 17:21 | |
| *** zul has quit IRC | 17:23 | |
| alaski | jaypipes: bauzas I'm fine with a later refactor to break it out. I would still like it if we just used properties for now so users of request spec can start consuming it that way, i.e. req_spec.root_gb just proxies to req_spec.flavor.root_gb | 17:26 |
| jaypipes | alaski: sure, that's an easy compromise. | 17:26 |
| mriedem | sdague: i'll take a look at it | 17:26 |
| dansmith | alaski: yeah, that makes sense | 17:27 |
| mriedem | 'model server shit the bed' would be infinitely more clear imo :) | 17:27 |
| mriedem | j/k | 17:27 |
| dansmith | alaski: that makes it not part of the rpc schema, but works for existing bits.. that's your goal, right? | 17:27 |
| alaski | dansmith: somewhat. I would actually prefer root_gb in the rpc schema vs Flavor, but this is me punting on that as long as the object interface is clear to users | 17:28 |
| *** tonytan4ever has joined #openstack-nova | 17:28 | |
| *** rajesht has quit IRC | 17:28 | |
| *** dave-mcc_ has joined #openstack-nova | 17:29 | |
| *** lucasagomes is now known as lucas-hungry | 17:29 | |
| bauzas | alaski: that's doable | 17:29 |
| alaski | dansmith: but it makes sense to not duplicate it over rpc right now | 17:29 |
| dansmith | yeah | 17:30 |
| bauzas | well, we're just talking about only a getter right.? | 17:30 |
| bauzas | not a setter, which I would -1 | 17:30 |
| *** dave-mccowan has quit IRC | 17:30 | |
| dansmith | bauzas: I'd be fine with either, but sure | 17:30 |
| bauzas | that's fine to have a read-only property for accessing the flavor-related fields, sure but I don't like to hide the semantics behing a writable property | 17:31 |
| bauzas | behind even | 17:31 |
| bauzas | it would just look like an hack | 17:31 |
| bauzas | and would create some precedence for people wanting to write bad code | 17:31 |
| dansmith | I dunno, it doesn't bother me greatly because it's not part of the rpc api, meaning it's easier to change later | 17:32 |
| dansmith | however, if we're trying to get people away from using it then making it just a getter is probably a good signal | 17:32 |
| *** mingy has joined #openstack-nova | 17:32 | |
| dansmith | as long as it's not too much work to just support it as read-only then getter only is cool | 17:32 |
| bauzas | that's the problem, allowing a setter for modifying a remotable field would confuse people IMHO | 17:33 |
| dansmith | by "remotable field" you mean a field that is part of the schema that goes over the wire, yes? | 17:34 |
| bauzas | dansmith: yup | 17:34 |
| bauzas | it hides the contract | 17:34 |
| dansmith | in this case, I really don't think it's likely to be a confusing thing, but I won't argue | 17:34 |
| *** yamahata has quit IRC | 17:34 | |
| dansmith | the whole thing is an object that goes over the wire, | 17:34 |
| dansmith | I don't really see the difference | 17:34 |
| alaski | I agree with dansmith, I don't think it would be a problem. But I'm not sure it's important atm | 17:34 |
| dansmith | aye | 17:35 |
| *** Piet has quit IRC | 17:35 | |
| bauzas | alaski: fair to say | 17:35 |
| bauzas | dansmith: ^ | 17:35 |
| bauzas | alaski: last point, property as well for name and id ? | 17:35 |
| alaski | bauzas: of the flavor? no, imo | 17:36 |
| bauzas | https://github.com/openstack/nova/blob/master/nova/scheduler/filters/type_filter.py#L58 | 17:36 |
| bauzas | alaski: ^ | 17:36 |
| *** Piet has joined #openstack-nova | 17:36 | |
| bauzas | alaski: or https://github.com/openstack/nova/blob/master/nova/scheduler/filters/type_filter.py#L35 | 17:37 |
| *** krtaylor has quit IRC | 17:37 | |
| alaski | really? why is that even being done | 17:38 |
| bauzas | alaski: that's the point, this is done because of a stupid filter that we support :) | 17:38 |
| *** exploreshaifali has quit IRC | 17:38 | |
| alaski | I would still say no. I'm with jaypipes that that could be accomplished in a different way | 17:38 |
| bauzas | alaski: you can create an aggregate and put flavor names as metadata, you'll then get a flavor-related compute | 17:38 |
| bauzas | alaski: agreed, but that's the UX y'know :) | 17:39 |
| bauzas | alaski: so, I'm open to alternatives for providing a way to have flavor-isolated compute nodes | 17:41 |
| *** browne has joined #openstack-nova | 17:41 | |
| bauzas | alaski: but atm, the scheduler only gets the flavor asked thru the request spec | 17:41 |
| bauzas | asked flavcor even | 17:41 |
| *** Piet has quit IRC | 17:41 | |
| *** achanda has joined #openstack-nova | 17:42 | |
| alaski | for now I would leave flavor on the request_spec, and expose the resources as properties. We can deal with TypeAffinity later | 17:43 |
| bauzas | alaski: sure, I was only wondering if then flavor_id would be a property too | 17:44 |
| mriedem | Sukhdev: where is this used? https://review.openstack.org/#/c/213264/ | 17:44 |
| mriedem | jroll: ^ | 17:44 |
| bauzas | alaski: or if we would still access the flavor object directly and get the id | 17:44 |
| jroll | mriedem: future patch I believe | 17:44 |
| bauzas | that's maybe nitpicking tho | 17:44 |
| alaski | bauzas: yeah, just access the flavor object directly in that filter | 17:44 |
| mriedem | jroll: oh really | 17:44 |
| jroll | mriedem: or maybe, if nova reads a neutron port with that type it explodes | 17:45 |
| Sukhdev | mriedem: It is used to pass the vnic_type to neutron | 17:45 |
| bauzas | ack, let's roll a new dance of patches | 17:45 |
| *** Piet has joined #openstack-nova | 17:45 | |
| bauzas | should be quick | 17:45 |
| mriedem | Sukhdev: i don't see that constant used anywhere | 17:45 |
| mriedem | jroll: i'd expect it to be in a whitelist somewhere then in nova | 17:46 |
| mriedem | and it's not in that change | 17:46 |
| Sukhdev | mriedem: attribute types are matched when nova make create_port() call to neutron - this call fails if this literal is not defined | 17:46 |
| jroll | mriedem: yeah, idk the details, I'm told it's needed | 17:46 |
| Sukhdev | mriedem: the reason you do not see it anywhere is because we can not push those patches yet, as they will fail - unless this patch merges first | 17:46 |
| mriedem | Sukhdev: ? | 17:47 |
| jroll | Sukhdev: dependent patches? | 17:47 |
| mriedem | Sukhdev: why can't they be pushed as dependencies? | 17:47 |
| mriedem | Sukhdev: if you have a stacktrace of the error, that should be in the bug report | 17:47 |
| mriedem | which i've marked as wishlist | 17:47 |
| mriedem | 'nova doesn't yet support new thing' isn't a bug | 17:47 |
| Sukhdev | mriedem: here is the corresponding patch on the neutron side - https://review.openstack.org/#/c/197774/ | 17:47 |
| mriedem | Sukhdev: so call that out in the nova change's commit message | 17:48 |
| Sukhdev | mriedem: the other patches are still being debugged and not ready to be pushed yet | 17:48 |
| mriedem | Sukhdev: but it still fail to see where the validation is using the new vnic_type in the nova network model | 17:48 |
| mriedem | Sukhdev: ok, so -1 until those are pushed | 17:48 |
| *** eglynn has joined #openstack-nova | 17:49 | |
| *** atuvenie has quit IRC | 17:49 | |
| Sukhdev | mriedem: What do you see as a harm of letting this go in? | 17:49 |
| mriedem | Sukhdev: it's not used | 17:50 |
| *** armax has joined #openstack-nova | 17:50 | |
| mriedem | we don't put things in tree (not knowingly) that aren't used | 17:50 |
| mriedem | we don't add things into nova to enable out of tree things either unless there are clear interfaces | 17:50 |
| mriedem | backdoor neutron thingies included | 17:50 |
| Sukhdev | mriedem: I see - the patch that will set this will be in the ironic driver (most likely) | 17:51 |
| mriedem | Sukhdev: ok, so when that shows up, ping me | 17:51 |
| mriedem | or better yet, integrate it into this existing change | 17:51 |
| mriedem | where it's actually used | 17:51 |
| mriedem | a 1 line change to add an unused flag isn't going to happen though imo | 17:51 |
| Sukhdev | mriedem: I thought we fix the framework and then we can push the patch that uses the framework | 17:52 |
| Sukhdev | mriedem: but, I see your point - | 17:52 |
| mriedem | i will gladly pay you tomorrow for a hamburger today | 17:52 |
| *** SourabhP has joined #openstack-nova | 17:52 | |
| jroll | mriedem: for context, we'll have a patch that does one of two things: makes a baremetal vif driver whatever thing, or reaches into the virt driver for the vnic_type, neither are trivial | 17:53 |
| Sukhdev | mriedem: :-) | 17:53 |
| *** achanda_ has joined #openstack-nova | 17:54 | |
| *** Sukhdev has quit IRC | 17:54 | |
| *** afazkas has joined #openstack-nova | 17:54 | |
| *** jichen_ has joined #openstack-nova | 17:54 | |
| *** aix has quit IRC | 17:55 | |
| *** yanxb__ has joined #openstack-nova | 17:55 | |
| *** achanda has quit IRC | 17:55 | |
| *** kiran-r has joined #openstack-nova | 17:55 | |
| *** jichen has quit IRC | 17:56 | |
| *** yamahata has joined #openstack-nova | 17:56 | |
| *** Sukhdev has joined #openstack-nova | 17:56 | |
| *** jichen_ is now known as jichen | 17:56 | |
| *** yanxb_ has quit IRC | 17:57 | |
| *** tpeoples has quit IRC | 17:57 | |
| mriedem | jichen: note the updated comments in your conductor cold migrate flavor thing | 18:02 |
| mriedem | about whether or not we can drop that compat shim | 18:02 |
| *** annegentle has quit IRC | 18:04 | |
| *** otter768 has joined #openstack-nova | 18:05 | |
| *** kiran-r has quit IRC | 18:05 | |
| *** rushil has joined #openstack-nova | 18:07 | |
| mriedem | lxsli: finally got your +1 on https://review.openstack.org/#/c/200224/ huh :) | 18:08 |
| mriedem | my work here is done | 18:08 |
| *** otter768 has quit IRC | 18:09 | |
| *** tpeoples has joined #openstack-nova | 18:11 | |
| *** rdopiera has joined #openstack-nova | 18:11 | |
| *** krtaylor has joined #openstack-nova | 18:13 | |
| *** rdopiera has quit IRC | 18:14 | |
| *** rdopiera has joined #openstack-nova | 18:14 | |
| *** emagana has quit IRC | 18:16 | |
| *** Piet has quit IRC | 18:16 | |
| *** ssurana has quit IRC | 18:17 | |
| *** VW_ has quit IRC | 18:20 | |
| *** VW_ has joined #openstack-nova | 18:20 | |
| *** mingy has quit IRC | 18:20 | |
| *** penick has quit IRC | 18:22 | |
| *** emagana has joined #openstack-nova | 18:22 | |
| rlrossit | sudipto: one last fix in the unit tests (caused by my comment that was too vague). After that, you'll get my stamp of approval | 18:23 |
| rlrossit | for https://review.openstack.org/#/c/213317/8 | 18:23 |
| *** ssurana has joined #openstack-nova | 18:24 | |
| *** VW_ has quit IRC | 18:24 | |
| sudipto | rlrossit, sure | 18:25 |
| *** danieru has quit IRC | 18:26 | |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Fix host_manager to use monitor metric objects https://review.openstack.org/213317 | 18:28 |
| sudipto | rlrossit, ^ | 18:29 |
| *** bapalm has quit IRC | 18:31 | |
| *** kmartin has quit IRC | 18:32 | |
| *** bapalm has joined #openstack-nova | 18:32 | |
| rlrossit | sudipto: I'm really happy with how that patch turned out, great job! | 18:32 |
| sudipto | rlrossit, great! Thanks :) | 18:32 |
| sudipto | jaypipes, ^ whenever you have some time :) | 18:33 |
| *** emagana has quit IRC | 18:34 | |
| *** jwang has quit IRC | 18:34 | |
| *** emagana has joined #openstack-nova | 18:34 | |
| *** Marga_ has joined #openstack-nova | 18:35 | |
| *** eharney has quit IRC | 18:37 | |
| *** eharney has joined #openstack-nova | 18:39 | |
| *** jwang has joined #openstack-nova | 18:40 | |
| *** Piet has joined #openstack-nova | 18:41 | |
| *** exploreshaifali has joined #openstack-nova | 18:42 | |
| *** claudiub has joined #openstack-nova | 18:43 | |
| *** nic has quit IRC | 18:45 | |
| *** cfarquhar has joined #openstack-nova | 18:47 | |
| *** cfarquhar has joined #openstack-nova | 18:47 | |
| *** Sree has joined #openstack-nova | 18:47 | |
| *** zul has joined #openstack-nova | 18:50 | |
| mriedem | sudipto: that's not really a bug right? | 18:54 |
| jichen | mriedem: got it , just return from dinner | 18:54 |
| *** nic has joined #openstack-nova | 18:55 | |
| *** kmartin has joined #openstack-nova | 18:56 | |
| *** rushil has quit IRC | 19:01 | |
| mriedem | sudipto: rlrossit: -1 | 19:02 |
| mriedem | comments inline | 19:02 |
| *** sudipto has quit IRC | 19:02 | |
| *** rushil has joined #openstack-nova | 19:03 | |
| *** lpetrut has quit IRC | 19:03 | |
| *** fawadk has quit IRC | 19:04 | |
| *** lpetrut has joined #openstack-nova | 19:04 | |
| *** VW_ has joined #openstack-nova | 19:07 | |
| *** ociuhandu has quit IRC | 19:08 | |
| *** danieru has joined #openstack-nova | 19:12 | |
| *** annegentle has joined #openstack-nova | 19:13 | |
| *** hhuang has quit IRC | 19:13 | |
| *** lpetrut has quit IRC | 19:13 | |
| *** afazkas has quit IRC | 19:13 | |
| *** nikhil_k_ has quit IRC | 19:13 | |
| *** afazekas has joined #openstack-nova | 19:14 | |
| *** nikhil has joined #openstack-nova | 19:14 | |
| rlrossit | mriedem: I did mention in my first batch of comments that it could go under bp liberty-objects... is that more correct than a bug? | 19:16 |
| *** nikhil is now known as nikhil_k | 19:16 | |
| mriedem | rlrossit: not really | 19:16 |
| mriedem | rlrossit: it's just general cleanup | 19:16 |
| mriedem | it was already using objects, this is just a cleaner usage | 19:17 |
| mriedem | which is good and all, just doesn't need to be a bug or bp or anything, it's just refactor | 19:17 |
| mriedem | changing self.metrics from a dict to a list is not good imo | 19:17 |
| mriedem | however, apparently nothing in tree even reads HostState.metrics - what's up with that? | 19:17 |
| mriedem | jaypipes: bauzas: edleafe: ^ | 19:17 |
| *** emagana has quit IRC | 19:17 | |
| *** VW_ has quit IRC | 19:18 | |
| rlrossit | mriedem: metrics starts out as a dict? huh missed that part | 19:18 |
| openstackgerrit | Chris Friesen proposed openstack/nova: Improve error logs for start/stop of locked instance https://review.openstack.org/210689 | 19:18 |
| mriedem | self.metrics is defined as an empty dict in HostState init | 19:18 |
| *** VW_ has joined #openstack-nova | 19:18 | |
| bauzas | mriedem: there is a metrics filter and a weigher AFAICR | 19:18 |
| mriedem | the metric objects are mapped to metric['name'] | 19:18 |
| mriedem | bauzas: ah yes | 19:19 |
| mriedem | value += host_state.metrics[name].value * ratio | 19:19 |
| mriedem | unavail = [i for i in self.keys if i not in host_state.metrics] | 19:19 |
| *** Piet has quit IRC | 19:19 | |
| mriedem | so yeah, sudipto's change would totally break those filters | 19:19 |
| mriedem | rlrossit: ^ | 19:19 |
| bauzas | mriedem: metrics are run on the compute side by monitors, which updates the metrics field in the compute_nodes table | 19:19 |
| rlrossit | good catch mriedem. totally missed that but surprised nothing is testing against that... | 19:20 |
| bauzas | mriedem: and then the host manager is getting those metrics when populating from the DB | 19:20 |
| bauzas | IIRC, the metrics filter is just for making sure we have metrics | 19:20 |
| mriedem | rlrossit: well, i'm sure there are mocked unit tests | 19:20 |
| *** lennyb has quit IRC | 19:20 | |
| bauzas | it's mostly used for weighting | 19:20 |
| bauzas | mriedem: any change I could put my dirty hands on ? | 19:21 |
| mriedem | bauzas: this is the change in question https://review.openstack.org/#/c/213317 | 19:21 |
| * bauzas looking | 19:21 | |
| mriedem | i've already -1ed it to death though | 19:21 |
| mriedem | gd python | 19:22 |
| *** eharney has quit IRC | 19:22 | |
| mriedem | wow http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/unit/scheduler/filters/test_metrics_filters.py | 19:22 |
| *** VW__ has joined #openstack-nova | 19:23 | |
| *** VW__ has quit IRC | 19:23 | |
| *** Sukhdev has quit IRC | 19:23 | |
| mriedem | so, | 19:23 |
| *** VW_ has quit IRC | 19:23 | |
| mriedem | fakes.FakeHostState should probably die in a fire | 19:23 |
| *** VW_ has joined #openstack-nova | 19:23 | |
| mriedem | jichen: i commented on both of your patches from the ML re: microversion bump needed or not | 19:25 |
| mriedem | jichen: the ones that convert a 500 to a 400 | 19:25 |
| mriedem | those don't require microversion bumps | 19:25 |
| *** eharney has joined #openstack-nova | 19:26 | |
| bauzas | mriedem: so, yes, metrics are a list of dicts | 19:27 |
| *** VW_ has quit IRC | 19:27 | |
| bauzas | mriedem: one item per metric with a metric composed of a name, a ts and a value IIRC | 19:27 |
| *** kairo has joined #openstack-nova | 19:28 | |
| *** kairo has left #openstack-nova | 19:28 | |
| *** hhuang has joined #openstack-nova | 19:29 | |
| bauzas | mriedem: I don't get the problem with FakeHostState? it's not stubbing the regular HostState, just how the HostState is populated by bypassing calls to aggs and instances | 19:31 |
| jichen | mriedem: I see the comments just now, seems it is different to what we documented in microversion doc | 19:32 |
| bauzas | mriedem: ah okay, I see your problem | 19:32 |
| mriedem | jichen: yeah i just found http://git.openstack.org/cgit/openstack/nova/tree/doc/source/api_microversion_dev.rst#n68 | 19:33 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: Allow for migration object to be passed to _move_claim https://review.openstack.org/199679 | 19:33 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: rt: generalize claim code to be useful for other move actions https://review.openstack.org/197138 | 19:33 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: rt: move filtering of migration by type lower in the call stack https://review.openstack.org/199678 | 19:33 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: compute: Make rebuild consider the node that was passed in https://review.openstack.org/214713 | 19:33 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: compute: Make rebuild_instance RPC take additional args https://review.openstack.org/200485 | 19:33 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: compute: Split the rebuild_instance method https://review.openstack.org/213461 | 19:33 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: Make rebuild/evacuate use resource claims https://review.openstack.org/214770 | 19:33 |
| jichen | mriedem: yes, that's what I refer to , I don't know which to follow but I think if the doc has agreement, we 'd better clear that then focus on the patch | 19:33 |
| bauzas | mriedem: well, that _update_metrics_from_compute_node method should be covered by the test_host_manager IMHO, not by the filter unittest IMHO | 19:34 |
| openstackgerrit | Ahilan Rajadeva proposed openstack/nova: Update to the reworked monitor plugin interface to pass in the MonitorMetric Object. https://review.openstack.org/214772 | 19:34 |
| rlrossit | bauzas: agreed | 19:34 |
| bauzas | mriedem: so if the problem was not seen by the py27 job, that's probably because that method is not covered | 19:34 |
| bauzas | lemme doublecheck | 19:34 |
| mriedem | jichen: so https://review.openstack.org/#/c/173985/ is easy, just return 400 | 19:34 |
| *** nic has quit IRC | 19:35 | |
| mriedem | bauzas: it is covered in test_host_manager | 19:35 |
| mriedem | but the assertion that was handling metrics as a dict was changed to handling it as a list | 19:35 |
| jichen | mriedem: well, the over quota is documented in API guide, let me try to give you a link | 19:35 |
| bauzas | mriedem: so the guy who changed that forgot to change the test_host_manager :) | 19:36 |
| rlrossit | mriedem: self.assertEqual(len(host.metrics), 2) has always been there... | 19:36 |
| jichen | mriedem: https://github.com/openstack/api-wg/blob/master/guidelines/http.rst, If the request results in the OpenStack user exceeding his or her quota, the return code should be 403 Forbidden. Do not use 413 Request Entity Too Large. | 19:36 |
| rlrossit | oh wait is len on a dict just basically len(dict.keys())? | 19:36 |
| jichen | I remember there are some discussions before on this but that a conclusion and the rst file is same to before | 19:37 |
| bauzas | I'm about to be hungry and I'm jailed in a conference room, so my brain is a bit fried, but I'll look at the change | 19:37 |
| bauzas | rlrossit: yep | 19:37 |
| bauzas | rlrossit: that's why it's not caught | 19:37 |
| *** achanda_ has quit IRC | 19:37 | |
| mriedem | jichen: cinderclient returns a 413 | 19:38 |
| bauzas | rlrossit: the assertion is really poor | 19:38 |
| mriedem | jichen: oh i see what you're saying | 19:38 |
| bauzas | rlrossit: I'd rather love to see a better unittest for checking the metrics | 19:38 |
| rlrossit | bauzas: mriedem: and I guess the assertion on the next line got changed from metrics.keys() to metrics.to_list() | 19:38 |
| mriedem | jichen: then i guess the arguemnt is anytime an OverQuota is handled in the compute API extensions it should be returning a 403 rather than a 400 | 19:38 |
| mriedem | which would rewquire a microversion bump and a spec and the world will end and we'll never make any headway on anything | 19:38 |
| *** nic has joined #openstack-nova | 19:40 | |
| *** kmartin has quit IRC | 19:40 | |
| jichen | mriedem: I agree with to make it simple but seems those kind of arguments need some agreement .... | 19:40 |
| mriedem | jichen: plus i have no idea how one backports bug fixes which required a microversion | 19:41 |
| mriedem | since kilo can't jump from v2.4 to v2.13 | 19:42 |
| openstackgerrit | Cale Rath proposed openstack/nova: Fixes Bug "destroy_vm fails with HyperVException" https://review.openstack.org/204007 | 19:42 |
| mriedem | so i guess we just can't ever backport anything, unless we have patch level microversions | 19:42 |
| * mriedem ragequits | 19:42 | |
| mriedem | jichen: can you throw this into the nova meeting agenda for thursday? | 19:42 |
| mriedem | this all seems crazy to me | 19:42 |
| jichen | mriedem: that's a nice point, how about just make it 400 and see someone else has any idea or post mail on ML to get more input? | 19:43 |
| *** Sukhdev has joined #openstack-nova | 19:43 | |
| jichen | I personally prefer to simple it and avoid overhead microversion bump | 19:43 |
| *** ndipanov has quit IRC | 19:43 | |
| mriedem | jichen: well if we aren't going to follow the docs for a reason, we should probably update the docs | 19:43 |
| mriedem | because this will just keep coming up | 19:44 |
| *** nic has quit IRC | 19:44 | |
| mriedem | i can totally see changing a 200/202 to a 400 as a microversion bump | 19:44 |
| mriedem | but going from 500 to 40x seems like a no brainer bug fix to me | 19:44 |
| mriedem | i think tempest checks for anything 400+ and considers it a failure | 19:44 |
| mriedem | i'll add this to the nova meeting agenda for this week | 19:45 |
| jichen | mriedem: I can't remember who gives some idea on this before maybe Ken'ichi, Maybe Alex or someone else, | 19:45 |
| jichen | mriedem: ok, I will join the meeting | 19:45 |
| mriedem | sdague wrote the doc | 19:45 |
| mriedem | everyone is at linuxcon this week i think | 19:45 |
| *** afazekas has quit IRC | 19:46 | |
| jichen | mriedem: ok, anyway, let's see whether we can get some input..thanks for help on this | 19:46 |
| *** eglynn has quit IRC | 19:46 | |
| *** raildo is now known as raildo-afk | 19:47 | |
| *** rdopiera has quit IRC | 19:47 | |
| mriedem | alaski: you're not cool enough to be at linuxcon this week right? | 19:47 |
| alaski | mriedem: that is correct | 19:47 |
| mriedem | alaski: do you know if any of the compute/conductor task API stuff that's already in tree is documented anywhere in the devref / arch guide? | 19:48 |
| mriedem | that's a thing i've never really had to deal with | 19:48 |
| mriedem | but it seems like something you'd need to understand before starting to think about working on the tasks 2000 engine | 19:48 |
| alaski | I'm not aware of any docs on it, and I know I didn't write any. let me peek real quick | 19:49 |
| alaski | mriedem: yeah, the motivation there would be good to get written down for others to understand | 19:49 |
| alaski | the tl;dr is that long running orchestrated things should happen in conductor not on computes | 19:50 |
| *** belmoreira has joined #openstack-nova | 19:50 | |
| alaski | the way build_and_run_instance handles retries in the conductor is the new hotness, vs the resize logic that's distributed everywhere | 19:50 |
| *** ociuhandu has joined #openstack-nova | 19:51 | |
| *** achanda has joined #openstack-nova | 19:51 | |
| *** alex_klimov has joined #openstack-nova | 19:51 | |
| alaski | I'll add documenting that to my queue | 19:51 |
| mriedem | i'm sure johnthetubaguy would be grateful :) | 19:52 |
| mriedem | and me | 19:52 |
| alaski | I aim to please | 19:53 |
| openstackgerrit | Matthew Booth proposed openstack/nova: compute: improve exceptions related to disk size checks https://review.openstack.org/206565 | 19:55 |
| *** angdraug has quit IRC | 19:56 | |
| mriedem | jichen: updated https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | 19:57 |
| jichen | mriedem: got it ~thx | 19:59 |
| *** alejandrito has joined #openstack-nova | 19:59 | |
| *** annegentle has quit IRC | 19:59 | |
| *** alejandrito_ has joined #openstack-nova | 20:00 | |
| *** alejandrito has quit IRC | 20:00 | |
| *** meghal has quit IRC | 20:00 | |
| *** otter768 has joined #openstack-nova | 20:05 | |
| *** otter768 has quit IRC | 20:10 | |
| *** Piet has joined #openstack-nova | 20:11 | |
| *** rushil has quit IRC | 20:16 | |
| *** alejandrito_ has quit IRC | 20:18 | |
| *** lpetrut has joined #openstack-nova | 20:20 | |
| *** nic has joined #openstack-nova | 20:21 | |
| edleafe | Hmmm - why is the gate-tempest-dsvm-full test for https://review.openstack.org/#/c/192184/ showing as FAILURE, when the results say all tests passed? | 20:23 |
| *** r-daneel has joined #openstack-nova | 20:24 | |
| *** Sree has quit IRC | 20:26 | |
| *** emagana has joined #openstack-nova | 20:28 | |
| dims | edleafe: see http://logs.openstack.org/84/192184/6/check/gate-tempest-dsvm-full/7aa51d9/logs/testr_results.html.gz | 20:28 |
| *** Piet has quit IRC | 20:29 | |
| *** nic has quit IRC | 20:29 | |
| *** Piet has joined #openstack-nova | 20:32 | |
| clarkb | and http://logs.openstack.org/84/192184/6/check/gate-tempest-dsvm-full/7aa51d9/console.html#_2015-08-19_16_59_56_605 | 20:33 |
| clarkb | not sure where yo usee it assed? | 20:33 |
| clarkb | *passed | 20:33 |
| mriedem | http://logs.openstack.org/84/192184/6/check/gate-tempest-dsvm-full/7aa51d9/console.html#_2015-08-19_16_36_49_556 | 20:33 |
| mriedem | http://logs.openstack.org/84/192184/6/check/gate-tempest-dsvm-full/7aa51d9/console.html#_2015-08-19_16_59_56_599 | 20:34 |
| mriedem | edleafe: it's your bifocals that failed :P | 20:34 |
| *** jichen has quit IRC | 20:34 | |
| edleafe | mriedem: :-P | 20:34 |
| *** nic has joined #openstack-nova | 20:34 | |
| *** thangp has quit IRC | 20:35 | |
| edleafe | dims: clarkb: mriedem: I see it now. I pulled it up before and got all passing. Must have been a prior PS or something | 20:36 |
| edleafe | Sorry for the noise | 20:36 |
| *** VW_ has joined #openstack-nova | 20:36 | |
| cfriesen | who do I talk to about nova/cinder interactions? | 20:37 |
| *** VW_ has quit IRC | 20:38 | |
| mriedem | depends on the question | 20:38 |
| *** VW_ has joined #openstack-nova | 20:38 | |
| *** meghal has joined #openstack-nova | 20:39 | |
| cfriesen | mriedem: well, I'm running stable/kilo, and I seem to be getting cases with deleting boot-from-volume instances where nova/cinder get stuck. cinder thinks the volume is detached, nova thinks it's attached. I tell nova to delete, cinder returns an error, nova gives up. | 20:40 |
| mriedem | cfriesen: funny you bring that up | 20:41 |
| *** exploreshaifali has quit IRC | 20:41 | |
| mriedem | cfriesen: https://review.openstack.org/#/c/213761/ | 20:41 |
| mriedem | now pay me | 20:41 |
| *** eglynn has joined #openstack-nova | 20:42 | |
| cfriesen | beer at the summit, if I get to go. :) | 20:42 |
| *** kmartin has joined #openstack-nova | 20:42 | |
| *** VW_ has quit IRC | 20:42 | |
| mriedem | i won't be there and i don't drink | 20:42 |
| mriedem | try again | 20:42 |
| cfriesen | undying respect and adulation? | 20:43 |
| cfriesen | a swarm of houris? | 20:44 |
| *** belmoreira has quit IRC | 20:44 | |
| *** annegentle has joined #openstack-nova | 20:45 | |
| mriedem | never heard of houris | 20:45 |
| mriedem | now i know | 20:45 |
| *** rlrossit has left #openstack-nova | 20:46 | |
| *** IanGovett has quit IRC | 20:46 | |
| *** lpetrut has quit IRC | 20:46 | |
| *** tonytan4ever has quit IRC | 20:47 | |
| *** achanda has quit IRC | 20:47 | |
| *** rdopiera has joined #openstack-nova | 20:47 | |
| *** dustins has quit IRC | 20:50 | |
| *** armax has quit IRC | 20:51 | |
| *** achanda has joined #openstack-nova | 20:52 | |
| *** freyes has left #openstack-nova | 20:52 | |
| *** annegentle has quit IRC | 20:53 | |
| *** annegentle has joined #openstack-nova | 20:54 | |
| *** tonytan4ever has joined #openstack-nova | 20:54 | |
| *** VW_ has joined #openstack-nova | 20:57 | |
| *** meghal has quit IRC | 20:59 | |
| *** armax has joined #openstack-nova | 20:59 | |
| *** meghal has joined #openstack-nova | 20:59 | |
| *** meghal has quit IRC | 20:59 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add persistence to the RequestSpec object https://review.openstack.org/211753 | 20:59 |
| openstackgerrit | Andrew Laski proposed openstack/nova: WIP: Add BuildRequest table and object https://review.openstack.org/214792 | 20:59 |
| *** meghal has joined #openstack-nova | 21:00 | |
| *** zul has quit IRC | 21:00 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: WIP: Add BuildRequest table and object https://review.openstack.org/214792 | 21:01 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add persistence to the RequestSpec object https://review.openstack.org/211753 | 21:01 |
| *** dave-mcc_ has quit IRC | 21:01 | |
| bauzas | alaski: heh, I'm just about uploading the latest set of ReqSpec (incl. the property attrs) | 21:01 |
| bauzas | alaski: so you will have to rebase :) | 21:01 |
| bauzas | (that's just uploading now :) | 21:01 |
| alaski | bauzas: heh, np. mainly wanted to tack that last one on there | 21:02 |
| *** tjones1 has joined #openstack-nova | 21:02 | |
| *** tjones1 has left #openstack-nova | 21:02 | |
| bauzas | woah, it takes now more than 2 mins to send a branch :) | 21:02 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify Scheduler RPC API select_dests() https://review.openstack.org/199205 | 21:03 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Create RequestSpec object https://review.openstack.org/145528 | 21:03 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Consider that all scheduler calls are IO Ops https://review.openstack.org/188486 | 21:03 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Use RequestSpec object in the FilterScheduler https://review.openstack.org/188487 | 21:03 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify left filters for RequestSpec https://review.openstack.org/202678 | 21:03 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Prepare filters for using RequestSpec object https://review.openstack.org/197912 | 21:03 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify conductor to use RequestSpec object https://review.openstack.org/203078 | 21:03 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify metric-related filters for RequestSpec https://review.openstack.org/202676 | 21:03 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Use RequestSpec in the ChanceScheduler https://review.openstack.org/199051 | 21:03 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify NUMA, PCI and num_instances filters for RequestSpec https://review.openstack.org/202677 | 21:03 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify Aggregate filters for RequestSpec https://review.openstack.org/202674 | 21:03 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify default filters for RequestSpec https://review.openstack.org/202675 | 21:03 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add RequestSpec methods for primitiving into dicts https://review.openstack.org/187197 | 21:03 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify Affinity filter for RequestSpec https://review.openstack.org/202673 | 21:03 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Use RequestSpec object in HostManager https://review.openstack.org/191251 | 21:03 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Use the same pci_requests field for all filters and HostManager https://review.openstack.org/191250 | 21:03 |
| *** neiljerram_bb has joined #openstack-nova | 21:04 | |
| bauzas | alaski: ^ enjoy | 21:04 |
| alaski | thanks :) | 21:04 |
| *** VW_ has quit IRC | 21:04 | |
| mriedem | does joel coffman ever hang out on irc? | 21:04 |
| *** VW_ has joined #openstack-nova | 21:05 | |
| dansmith | mriedem: yeah | 21:05 |
| mriedem | i'm trying to unwind some crazy json conversion crap that happened | 21:06 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1370590 | 21:06 |
| openstack | Launchpad bug 1370590 in OpenStack Compute (nova) "Libvirt _create_domain_and_network calls missing disk_info" [Medium,New] - Assigned to Rick Harris (rconradharris) | 21:06 |
| mriedem | lxc is apparently busted | 21:06 |
| *** Marga_ has quit IRC | 21:06 | |
| mriedem | s1rp: are you working that? ^ | 21:06 |
| *** achanda has quit IRC | 21:06 | |
| *** aysyd has quit IRC | 21:07 | |
| *** rushil has joined #openstack-nova | 21:09 | |
| bauzas | mriedem: so, I looked at https://review.openstack.org/#/c/213317/9/nova/objects/monitor_metric.py,cm | 21:12 |
| bauzas | mriedem: and I think that it's working, even very poorly written and confusing | 21:12 |
| bauzas | mriedem: just because the parameter is badly named - that's a list and not a dict | 21:12 |
| *** rushil_ has joined #openstack-nova | 21:13 | |
| bauzas | mriedem: but the owner is actually iterating over that list to hydrate the MonitorMetric object and then returns a list of MonitorMetric objects - which is valid | 21:13 |
| *** amotoki_ has quit IRC | 21:14 | |
| mriedem | bauzas: that's not the dict i'm talking about | 21:14 |
| mriedem | HostState.metrics is the dict i'm talking about | 21:14 |
| mriedem | self.metrics = objects.MonitorMetricList.from_legacy_json(metrics) | 21:14 |
| mriedem | makes it a list | 21:14 |
| mriedem | which will break the metrics filter | 21:14 |
| bauzas | mriedem: HostState.metrics is a list too | 21:15 |
| *** rushil_ has quit IRC | 21:16 | |
| bauzas | oh sec | 21:16 |
| mriedem | no it's not | 21:16 |
| mriedem | ftersin: are you around? | 21:16 |
| *** rushil has quit IRC | 21:16 | |
| *** rushil has joined #openstack-nova | 21:16 | |
| bauzas | what the hell is that ?! | 21:17 |
| mriedem | bauzas: you should probably sign off :) | 21:17 |
| *** krtaylor has quit IRC | 21:18 | |
| mriedem | ftersin: s1rp: i thought a disk mapping was always a dict? but this defaults it to a list if it's not in the disk_info dict https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4430 | 21:18 |
| mriedem | i really hate the blockinfo/diskinfo/diskmapping stuff in the libvirt driver... | 21:19 |
| mriedem | that needs to all be typed | 21:19 |
| mriedem | dansmith: sdague: add that to my rant list today ^ | 21:19 |
| *** nic has quit IRC | 21:20 | |
| dansmith | mriedem: BDMs are objects in most places, but they look like dicts | 21:20 |
| mriedem | blockinfo.get_disk_info is not | 21:20 |
| mriedem | it's a bunch of wild dicts | 21:20 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/blockinfo.py#L599 | 21:20 |
| dansmith | ah, from the driver, yeah | 21:20 |
| mriedem | i have it on my whiteboard to make some sort of primitive object out of that stuff at some point | 21:21 |
| bauzas | mriedem: the filter is stupid ? | 21:21 |
| mriedem | the docstring explains the structure https://github.com/openstack/nova/blob/master/nova/virt/libvirt/blockinfo.py#L52 | 21:21 |
| mriedem | but it's up to the caller to always remember that i guess | 21:21 |
| bauzas | mriedem: nvm | 21:21 |
| mriedem | and rlrossit has left the building | 21:23 |
| mriedem | ctrath: converting the wild west of dicts in nova.virt.libvirt.blockinfo would be a nice todo ^ | 21:23 |
| mriedem | rlrossit and chuckcarmack appear to be MIA | 21:24 |
| ctrath | mriedem: ok, I'll do it | 21:24 |
| mriedem | that probably requires a blueprint | 21:25 |
| ctrath | ok.. I can do that too | 21:25 |
| mriedem | is there anything you can't do? | 21:25 |
| ctrath | yes… make my wife happy | 21:25 |
| mriedem | well they can't be pleased by nature | 21:26 |
| mriedem | nor can i | 21:26 |
| ctrath | +1 | 21:26 |
| ctrath | another +1 | 21:26 |
| *** ndipanov has joined #openstack-nova | 21:26 | |
| mriedem | 'i don't hate it' is about the best you'll ever get out of me | 21:26 |
| ctrath | lol | 21:26 |
| *** meghal has quit IRC | 21:26 | |
| *** meghal has joined #openstack-nova | 21:27 | |
| *** meghal has quit IRC | 21:27 | |
| *** meghal has joined #openstack-nova | 21:27 | |
| *** smatzek has quit IRC | 21:28 | |
| *** nic has joined #openstack-nova | 21:29 | |
| *** thorst has quit IRC | 21:32 | |
| *** Piet has quit IRC | 21:38 | |
| *** ccarmack has left #openstack-nova | 21:40 | |
| *** Sukhdev has quit IRC | 21:43 | |
| *** eglynn has quit IRC | 21:43 | |
| *** unicell has quit IRC | 21:45 | |
| *** unicell has joined #openstack-nova | 21:45 | |
| *** signed8bit has joined #openstack-nova | 21:49 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: add docstring for _get_instance_disk_info https://review.openstack.org/214814 | 21:52 |
| mriedem | and with that ^ i have to head out | 21:53 |
| bauzas | jaypipes: I'm about resuming my reviewing effort | 21:53 |
| bauzas | jaypipes: you mentioned us a series we should look at, which one please ? | 21:53 |
| bauzas | jaypipes: I mean one of yours :) | 21:53 |
| jaypipes | bauzas: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:pci-cleanup,n,z please :) | 21:54 |
| bauzas | jaypipes: preferred to resource-objects first? | 21:54 |
| jaypipes | bauzas: yes, it's a precursor. thx man! :) | 21:55 |
| *** mriedem has quit IRC | 21:57 | |
| bauzas | dansmith: I have a question for you on jaypipes's https://review.openstack.org/#/c/213587/3 | 21:58 |
| bauzas | jaypipes: I don't think that could work | 21:59 |
| *** dprince has quit IRC | 21:59 | |
| dansmith | yep | 21:59 |
| *** krtaylor has joined #openstack-nova | 22:00 | |
| *** rushil_ has joined #openstack-nova | 22:01 | |
| *** burt has quit IRC | 22:01 | |
| openstackgerrit | Andrew Melton proposed openstack/nova: libvirt: use proper disk_info in _hard_reboot https://review.openstack.org/214816 | 22:02 |
| *** burgerk has quit IRC | 22:02 | |
| *** dave-mccowan has joined #openstack-nova | 22:02 | |
| *** y_sawai has joined #openstack-nova | 22:02 | |
| *** rushil has quit IRC | 22:04 | |
| *** mingy has joined #openstack-nova | 22:05 | |
| *** mingy has quit IRC | 22:06 | |
| *** mingy has joined #openstack-nova | 22:06 | |
| *** belmoreira has joined #openstack-nova | 22:06 | |
| *** belmoreira has quit IRC | 22:06 | |
| *** otter768 has joined #openstack-nova | 22:06 | |
| *** y_sawai has quit IRC | 22:08 | |
| *** eglynn has joined #openstack-nova | 22:10 | |
| *** y_sawai has joined #openstack-nova | 22:10 | |
| *** emagana has quit IRC | 22:10 | |
| openstackgerrit | Andrew Melton proposed openstack/nova: libvirt: use proper disk_info in _hard_reboot https://review.openstack.org/214816 | 22:11 |
| *** otter768 has quit IRC | 22:11 | |
| mingy | edleafe: ping | 22:11 |
| *** y_sawai_ has joined #openstack-nova | 22:11 | |
| edleafe | mingy: pong | 22:12 |
| *** unicell has quit IRC | 22:12 | |
| *** unicell has joined #openstack-nova | 22:12 | |
| mingy | I was looking at 192184, and I realized that there are some filters that don't inherit from the base filter | 22:13 |
| *** Sukhdev has joined #openstack-nova | 22:13 | |
| mingy | I like the logging thing, so I was wondering if we should seek to replicate the logging functionality in other parts too | 22:14 |
| mingy | either that or make everything inherit from base filter | 22:14 |
| *** amotoki_ has joined #openstack-nova | 22:14 | |
| *** y_sawai has quit IRC | 22:14 | |
| edleafe | mingy: not sure that the filter class matters much in that code | 22:14 |
| edleafe | mingy: the logging is in the filter handler | 22:15 |
| *** rfolco has quit IRC | 22:15 | |
| *** y_sawai_ has quit IRC | 22:16 | |
| mingy | edleafe: doesn't the filter handler require an instance of filter that ought to inherit from base filter? | 22:16 |
| edleafe | mingy: it's passed a list of filters | 22:17 |
| *** annegentle has quit IRC | 22:17 | |
| *** ahilan has quit IRC | 22:17 | |
| *** mdrabe has quit IRC | 22:17 | |
| edleafe | mingy: all that really matters is that it implements _run_filter_for_index() and filter_all() | 22:18 |
| mingy | edleafe: yeah I get that | 22:18 |
| *** ctrath has quit IRC | 22:18 | |
| *** amotoki_ has quit IRC | 22:19 | |
| jaypipes | dansmith, bauzas: there were/are no users of the InstancePCIRequests.save method. | 22:19 |
| mingy | edleafe: well the thing I was thinking about was tangentially related to 192184, I was looking at nova.scheduler.host_manager.get_filtered_hosts | 22:19 |
| dansmith | jaypipes: never in the past? | 22:19 |
| jaypipes | not that I can tell.\ | 22:19 |
| jaypipes | only unit tests. | 22:20 |
| dansmith | jaypipes: okay lemme look a bit and then that's cool | 22:20 |
| jaypipes | dansmith: appreciated. | 22:20 |
| mingy | edleafe: which implements the filters as nested classes. it doesn't use the filter handler at all. | 22:21 |
| bauzas | jaypipes: oh ok, lemme check | 22:22 |
| bauzas | jaypipes: so it means we created a whole object but never used it ? wah :) | 22:22 |
| bauzas | jaypipes: oh I see your comment - that I read it but forgot it | 22:23 |
| dansmith | actually, I think we never have needed to update | 22:24 |
| dansmith | only create | 22:24 |
| jaypipes | right. | 22:24 |
| mingy | edleafe: then the other thing that is related to 192184 is that if filter_all yields then the function returns None and the handler won't log. I am not very coherent as I'm talking about two things at once. | 22:24 |
| dansmith | so yeah, makes sense I think | 22:24 |
| *** dave-mccowan has quit IRC | 22:24 | |
| edleafe | mingy: not sure I follow. It calls self.filter_handler.get_filtered_objects(), passing in the filters | 22:25 |
| mingy | edleafe: line 88 in filters.py returns | 22:26 |
| mingy | if "objs = filter_.filter_all(list_objs, filter_properties)" is None | 22:26 |
| mingy | this will be None if the filter's "filter_all()" filters all the hosts, i.e. no hosts returned | 22:27 |
| edleafe | mingy: sure - that's for when a filter shuts down the process for some reason. I still don't know of a use case for that | 22:27 |
| mingy | so filter_all() returns a generator object (according to the base class) | 22:27 |
| edleafe | mingy: no, it should return an empty object list | 22:27 |
| *** Piet has joined #openstack-nova | 22:28 | |
| edleafe | well, yeah, a generator that represents an empty object list | 22:29 |
| *** nic has quit IRC | 22:29 | |
| mingy | edleafe: so I think line 45 will never yield if the filter never passes, so the function will have no return or yield value | 22:30 |
| mingy | so ugh this is really bad timing, but I suddenly have to go, but can I come back to this conversation in about 20 minutes? really sorry | 22:31 |
| edleafe | mingy: I have to leave in about 10 :) | 22:32 |
| edleafe | mingy: tomorrow? | 22:32 |
| mingy | edleafe: sure! | 22:32 |
| *** mwagner_lap has quit IRC | 22:32 | |
| mingy | see you tomorrow | 22:32 |
| *** signed8bit is now known as signed8bit_ZZZzz | 22:32 | |
| *** agireud has quit IRC | 22:34 | |
| *** mingy has quit IRC | 22:36 | |
| *** signed8bit_ZZZzz is now known as signed8bit | 22:39 | |
| *** ijuwang has quit IRC | 22:39 | |
| *** tpeoples has quit IRC | 22:44 | |
| *** VikasC has joined #openstack-nova | 22:45 | |
| *** claudiub has quit IRC | 22:46 | |
| *** dave-mccowan has joined #openstack-nova | 22:47 | |
| VikasC | Hi Folks , Can somebody please review https://review.openstack.org/#/c/213692/3 | 22:47 |
| *** r-daneel has quit IRC | 22:49 | |
| *** hemna is now known as hemnafk | 22:49 | |
| *** baoli has joined #openstack-nova | 22:51 | |
| *** Piet has quit IRC | 22:53 | |
| *** signed8bit has quit IRC | 22:54 | |
| *** baoli has quit IRC | 22:56 | |
| *** zzzeek has quit IRC | 22:56 | |
| *** bnemec has quit IRC | 22:56 | |
| *** otter768 has joined #openstack-nova | 22:59 | |
| *** jecarey has quit IRC | 22:59 | |
| *** VikasC has quit IRC | 23:00 | |
| *** VW_ has quit IRC | 23:00 | |
| bauzas | jaypipes: my bad, +1'd it | 23:01 |
| jaypipes | bauzas: no worries mate | 23:01 |
| *** dannywil_ has joined #openstack-nova | 23:01 | |
| *** VW_ has joined #openstack-nova | 23:01 | |
| *** tjones has joined #openstack-nova | 23:02 | |
| *** VW_ has quit IRC | 23:02 | |
| *** tjones has left #openstack-nova | 23:02 | |
| *** VW_ has joined #openstack-nova | 23:02 | |
| *** diogogmt has quit IRC | 23:03 | |
| *** dannywilson has quit IRC | 23:03 | |
| *** Sukhdev has quit IRC | 23:05 | |
| *** albertom is now known as albertom-afk | 23:06 | |
| *** zul has joined #openstack-nova | 23:07 | |
| *** lucas-hungry has quit IRC | 23:08 | |
| *** eharney has quit IRC | 23:08 | |
| *** rushil_ has quit IRC | 23:10 | |
| *** rushil has joined #openstack-nova | 23:10 | |
| *** zul has quit IRC | 23:12 | |
| *** Piet has joined #openstack-nova | 23:12 | |
| *** dave-mccowan has quit IRC | 23:13 | |
| *** amotoki_ has joined #openstack-nova | 23:15 | |
| *** mwagner_lap has joined #openstack-nova | 23:19 | |
| *** amotoki_ has quit IRC | 23:19 | |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: Make rebuild/evacuate use resource claims https://review.openstack.org/214770 | 23:20 |
| openstackgerrit | Nikola Dipanov proposed openstack/nova: compute: Make rebuild consider the node that was passed in https://review.openstack.org/214713 | 23:20 |
| *** tonytan4ever has quit IRC | 23:20 | |
| *** bnemec has joined #openstack-nova | 23:20 | |
| *** nagyz__ has joined #openstack-nova | 23:21 | |
| *** Vek has quit IRC | 23:22 | |
| *** nagyz_ has quit IRC | 23:24 | |
| alex_xu | edleafe: you have trouble with https://review.openstack.org/#/c/212851/? I just replied | 23:29 |
| *** asettle has joined #openstack-nova | 23:31 | |
| *** flwang1 has quit IRC | 23:32 | |
| alex_xu | sdague: I remember we said we will only have one endpoint '/v2' in the future. But I don't konw we finally we want to keep '/v2.1' endpoint, do you know the reason? | 23:32 |
| alex_xu | s/we finally/why finally/ | 23:32 |
| *** achanda has joined #openstack-nova | 23:33 | |
| *** Piet has quit IRC | 23:33 | |
| *** NightKhaos has joined #openstack-nova | 23:33 | |
| *** dims_ has joined #openstack-nova | 23:33 | |
| *** dims has quit IRC | 23:36 | |
| *** shoutm has joined #openstack-nova | 23:37 | |
| *** Piet has joined #openstack-nova | 23:37 | |
| *** tjones1 has joined #openstack-nova | 23:37 | |
| *** tjones1 has left #openstack-nova | 23:37 | |
| *** alex_klimov has quit IRC | 23:38 | |
| *** dims_ has quit IRC | 23:39 | |
| *** dims has joined #openstack-nova | 23:39 | |
| *** dave-mccowan has joined #openstack-nova | 23:40 | |
| *** zul has joined #openstack-nova | 23:41 | |
| *** bnemec has quit IRC | 23:43 | |
| *** dims has quit IRC | 23:44 | |
| *** vivekd has quit IRC | 23:45 | |
| *** bnemec has joined #openstack-nova | 23:45 | |
| *** ndipanov has quit IRC | 23:45 | |
| *** Piet has quit IRC | 23:47 | |
| NightKhaos | So I'v figured out how to online extend a volume with Ceph and Libvirt, and I'm trying to work out the best way to add this into the API. | 23:48 |
| *** tjones has joined #openstack-nova | 23:51 | |
| *** Piet has joined #openstack-nova | 23:53 | |
| *** RuiChen has joined #openstack-nova | 23:55 | |
| *** edmondsw has quit IRC | 23:56 | |
| *** flwang1 has joined #openstack-nova | 23:57 | |
| *** erlon has quit IRC | 23:58 | |
| *** bnemec has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
