| *** yamahata has quit IRC | 00:00 | |
| alaski | mriedem_away: it's a bug, and I'll file one. I was going to depend on it for something and then didn't need it, but wanted to toss it up so it didn't get forgotten | 00:01 |
|---|---|---|
| *** VW_ has quit IRC | 00:01 | |
| *** derekh has quit IRC | 00:04 | |
| alaski | bauzas: yeah, getting something out to explain what they are, and aren't, would be good | 00:04 |
| bauzas | alaski: melwitt: just hitting again a problem with the cells job, same cells-region issue (conflict= | 00:05 |
| bauzas | alaski: melwitt: I'm about to check logstash | 00:05 |
| bauzas | to see if there is a regression | 00:05 |
| *** whenry_ has joined #openstack-nova | 00:10 | |
| *** diogogmt_ has joined #openstack-nova | 00:12 | |
| *** dims_ has quit IRC | 00:12 | |
| *** diogogmt has quit IRC | 00:12 | |
| *** diogogmt_ is now known as diogogmt | 00:12 | |
| *** jwcroppe has quit IRC | 00:15 | |
| *** artom_ has joined #openstack-nova | 00:16 | |
| *** thorst has joined #openstack-nova | 00:17 | |
| *** artom_ has quit IRC | 00:17 | |
| *** artom_ has joined #openstack-nova | 00:17 | |
| *** artom has quit IRC | 00:19 | |
| *** oomichi has joined #openstack-nova | 00:20 | |
| *** VikasC has quit IRC | 00:23 | |
| *** thorst has quit IRC | 00:30 | |
| *** thorst has joined #openstack-nova | 00:32 | |
| *** mdrabe has joined #openstack-nova | 00:32 | |
| *** thorst has left #openstack-nova | 00:33 | |
| *** whenry_ has quit IRC | 00:34 | |
| openstackgerrit | Tomoki Sekiyama proposed openstack/nova: Ironic: Support boot from Cinder volume https://review.openstack.org/215385 | 00:35 |
| *** diogogmt has quit IRC | 00:37 | |
| *** tsbot_ has joined #openstack-nova | 00:38 | |
| *** tsbot_ has quit IRC | 00:38 | |
| *** tsbot_ has joined #openstack-nova | 00:38 | |
| *** tsekiyama has quit IRC | 00:40 | |
| *** ssurana has quit IRC | 00:44 | |
| *** garyk has quit IRC | 00:45 | |
| *** mtanino has quit IRC | 00:45 | |
| *** salv-orlando has joined #openstack-nova | 00:49 | |
| *** vilobhmm11 has quit IRC | 00:51 | |
| *** rfolco has quit IRC | 00:52 | |
| *** penick has quit IRC | 00:52 | |
| *** salv-orlando has quit IRC | 00:54 | |
| *** eliqiao_pc has joined #openstack-nova | 00:57 | |
| *** achanda has quit IRC | 00:58 | |
| *** haigang has joined #openstack-nova | 01:00 | |
| *** oomichi has quit IRC | 01:01 | |
| *** eliqiao_pc has quit IRC | 01:01 | |
| *** zzzeek has joined #openstack-nova | 01:03 | |
| *** dims has joined #openstack-nova | 01:04 | |
| *** RuiChen has joined #openstack-nova | 01:05 | |
| *** oomichi has joined #openstack-nova | 01:05 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 01:08 |
| *** shoutm has joined #openstack-nova | 01:08 | |
| *** baoli has joined #openstack-nova | 01:11 | |
| *** meghal has quit IRC | 01:11 | |
| *** meghal has joined #openstack-nova | 01:11 | |
| *** bapalm has quit IRC | 01:12 | |
| *** oomichi has quit IRC | 01:14 | |
| *** bapalm has joined #openstack-nova | 01:14 | |
| *** baoli has quit IRC | 01:15 | |
| *** browne has quit IRC | 01:18 | |
| *** rfolco has joined #openstack-nova | 01:19 | |
| *** shaohe_feng has joined #openstack-nova | 01:21 | |
| *** bapalm has quit IRC | 01:21 | |
| *** rotbeard has joined #openstack-nova | 01:24 | |
| *** shane-wang has joined #openstack-nova | 01:28 | |
| *** zzzeek has quit IRC | 01:29 | |
| *** ahilan has joined #openstack-nova | 01:30 | |
| *** jwcroppe has joined #openstack-nova | 01:31 | |
| *** dave-mccowan has quit IRC | 01:32 | |
| *** eliqiao_pc has joined #openstack-nova | 01:32 | |
| *** bapalm has joined #openstack-nova | 01:33 | |
| openstackgerrit | wanghao proposed openstack/nova: Add nova-manage command for cleaning attachment https://review.openstack.org/184537 | 01:35 |
| *** jasonpan has joined #openstack-nova | 01:37 | |
| *** bapalm has quit IRC | 01:38 | |
| *** diogogmt has joined #openstack-nova | 01:42 | |
| *** bapalm has joined #openstack-nova | 01:44 | |
| *** takedakn has joined #openstack-nova | 01:44 | |
| *** Apoorva has quit IRC | 01:45 | |
| *** rdopiera has joined #openstack-nova | 01:46 | |
| *** ahilan has quit IRC | 01:46 | |
| *** diogogmt has quit IRC | 01:48 | |
| *** ahilan has joined #openstack-nova | 01:49 | |
| *** diogogmt has joined #openstack-nova | 01:49 | |
| *** lyanchih has joined #openstack-nova | 01:50 | |
| *** bapalm has quit IRC | 01:51 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Move common sample files methods in test base class https://review.openstack.org/215398 | 01:52 |
| *** haomaiwang has joined #openstack-nova | 01:55 | |
| *** salv-orlando has joined #openstack-nova | 01:56 | |
| *** bapalm has joined #openstack-nova | 01:56 | |
| *** shuquan has joined #openstack-nova | 01:57 | |
| *** achanda has joined #openstack-nova | 02:02 | |
| *** bapalm has quit IRC | 02:03 | |
| *** meghal has quit IRC | 02:06 | |
| *** shane-wang has quit IRC | 02:06 | |
| *** salv-orlando has quit IRC | 02:06 | |
| *** shuquan has quit IRC | 02:07 | |
| *** shuquan has joined #openstack-nova | 02:08 | |
| *** salv-orlando has joined #openstack-nova | 02:08 | |
| *** haomaiwang has quit IRC | 02:09 | |
| *** haomaiwa_ has joined #openstack-nova | 02:10 | |
| *** takedakn1 has joined #openstack-nova | 02:10 | |
| *** bapalm has joined #openstack-nova | 02:10 | |
| *** rfolco has quit IRC | 02:10 | |
| *** takedakn has quit IRC | 02:11 | |
| *** baoli has joined #openstack-nova | 02:11 | |
| *** changbl_ has joined #openstack-nova | 02:14 | |
| *** salv-orlando has quit IRC | 02:15 | |
| *** bapalm has quit IRC | 02:15 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Better handling of SSH key comments https://review.openstack.org/208661 | 02:15 |
| *** tpeoples has joined #openstack-nova | 02:16 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Test cases for better handling of SSH key comments https://review.openstack.org/208661 | 02:16 |
| *** rdopiera has quit IRC | 02:16 | |
| *** baoli has quit IRC | 02:16 | |
| *** shuquan has quit IRC | 02:17 | |
| *** jwcroppe has quit IRC | 02:20 | |
| *** bapalm has joined #openstack-nova | 02:23 | |
| *** shane-wang has joined #openstack-nova | 02:30 | |
| *** bapalm has quit IRC | 02:30 | |
| *** shyu has joined #openstack-nova | 02:31 | |
| *** bapalm has joined #openstack-nova | 02:33 | |
| *** flaper87 has quit IRC | 02:33 | |
| *** garyk has joined #openstack-nova | 02:34 | |
| *** flaper87 has joined #openstack-nova | 02:36 | |
| gmann | alex_xu: hi | 02:36 |
| openstackgerrit | Rui Chen proposed openstack/nova: Set task_state=None when booting instance failed https://review.openstack.org/187145 | 02:36 |
| alex_xu | gmann: hi | 02:36 |
| gmann | alex_xu: regarding v2on v21 failure | 02:37 |
| gmann | alex_xu: how about if we catch the addition property error and raise 400 for all? | 02:37 |
| gmann | alex_xu: I think json schema raise common exception but we can check the error msg | 02:38 |
| alex_xu | gmann: I guess no, the goal of relax validation is because we have some api ignore extra params in v2 | 02:38 |
| gmann | alex_xu: ahh but issue is some v2 2XX can be 400 then | 02:38 |
| gmann | alex_xu: yea | 02:38 |
| alex_xu | gmann: if we raise 400....that is what v2.1 doing now | 02:39 |
| gmann | alex_xu: yea | 02:39 |
| *** shaohe_feng has quit IRC | 02:39 | |
| *** bapalm has quit IRC | 02:40 | |
| alex_xu | gmann: I have idea, but I didn't ensure it works, actually working on reply the microversion problem... | 02:40 |
| gmann | alex_xu: ok | 02:40 |
| alex_xu | gmann: the idea is whether we can strip the extra params in this custom hook https://github.com/openstack/nova/blob/master/nova/api/validation/validators.py#L100 | 02:40 |
| gmann | alex_xu: for extra param or for metadata one also | 02:41 |
| openstackgerrit | Roman Bogorodskiy proposed openstack/nova: Sync L3Driver, NullL3 interface with LinuxNetL3 https://review.openstack.org/189001 | 02:41 |
| alex_xu | gmann: would you like try that ^ | 02:41 |
| alex_xu | but I definitely not sure it work or not | 02:42 |
| *** bapalm has joined #openstack-nova | 02:42 | |
| alex_xu | gmann: I guess one reason why my failed is we remove item in the iteration of dict | 02:43 |
| alex_xu | s/my failed/may failed/ | 02:43 |
| alex_xu | or I will try that later | 02:44 |
| gmann | alex_xu: hummm. ok | 02:44 |
| gmann | alex_xu: i will try for metadata one which are considered as extra param but actually those are not and we should raise invalidmetadata data error | 02:44 |
| gmann | alex_xu: but not sure how we will segregate that from other extra param strip out | 02:46 |
| alex_xu | gmann: yea | 02:46 |
| *** haomaiwa_ has quit IRC | 02:47 | |
| *** haomaiwang has joined #openstack-nova | 02:47 | |
| *** shane-wang has quit IRC | 02:48 | |
| *** venkat_p has joined #openstack-nova | 02:50 | |
| *** rook has quit IRC | 02:50 | |
| *** hakimo_ has joined #openstack-nova | 02:52 | |
| *** bapalm has quit IRC | 02:52 | |
| *** shaohe_feng has joined #openstack-nova | 02:52 | |
| *** hakimo has quit IRC | 02:54 | |
| *** bapalm has joined #openstack-nova | 02:55 | |
| *** dims has quit IRC | 02:55 | |
| *** haomaiwang has quit IRC | 02:58 | |
| *** shane-wang has joined #openstack-nova | 02:58 | |
| *** haomaiwang has joined #openstack-nova | 02:58 | |
| *** ahilan has quit IRC | 02:59 | |
| *** shaohe_feng1 has joined #openstack-nova | 02:59 | |
| *** haomaiwang has quit IRC | 03:01 | |
| *** haomaiwa_ has joined #openstack-nova | 03:01 | |
| *** shaohe_feng has quit IRC | 03:02 | |
| openstackgerrit | wanghao proposed openstack/nova: Add nova-manage command for cleaning attachment https://review.openstack.org/184537 | 03:02 |
| openstackgerrit | Shuquan Huang proposed openstack/nova: Support to launch instance booted from uefi rom for AARCH64/ARM https://review.openstack.org/215414 | 03:04 |
| *** bapalm has quit IRC | 03:04 | |
| *** lykinsbd has joined #openstack-nova | 03:08 | |
| *** gyee has quit IRC | 03:09 | |
| *** bapalm has joined #openstack-nova | 03:10 | |
| *** shoutm_ has joined #openstack-nova | 03:11 | |
| *** dave-mccowan has joined #openstack-nova | 03:11 | |
| *** unicell has quit IRC | 03:11 | |
| *** shoutm has quit IRC | 03:12 | |
| *** diogogmt has quit IRC | 03:13 | |
| *** changbl_ has quit IRC | 03:14 | |
| openstackgerrit | Zhang Jinnan proposed openstack/nova: libvirt: Fix snapshot delete for network disk type for blockRebase op https://review.openstack.org/212518 | 03:20 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 03:21 |
| *** lykinsbd has quit IRC | 03:21 | |
| *** shane-wang1 has joined #openstack-nova | 03:21 | |
| *** shane-wang has quit IRC | 03:23 | |
| openstackgerrit | Zhang Jinnan proposed openstack/nova: libvirt: Fix snapshot delete for network disk type for blockRebase op https://review.openstack.org/212518 | 03:25 |
| *** browne has joined #openstack-nova | 03:26 | |
| *** achanda has quit IRC | 03:28 | |
| openstackgerrit | Rui Chen proposed openstack/nova: Fix incomplete error message of quota exceeded https://review.openstack.org/197460 | 03:33 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: CONF.allow_resize_on_same_host should check only once in controller https://review.openstack.org/186236 | 03:33 |
| *** garyk has quit IRC | 03:34 | |
| *** ivasev_ has joined #openstack-nova | 03:35 | |
| *** huats has quit IRC | 03:40 | |
| *** dave-mcc_ has joined #openstack-nova | 03:43 | |
| *** shane-wang1 has quit IRC | 03:43 | |
| *** dave-mccowan has quit IRC | 03:45 | |
| *** VikasC has joined #openstack-nova | 03:49 | |
| *** salv-orlando has joined #openstack-nova | 03:49 | |
| *** ccarmack has joined #openstack-nova | 03:51 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add project-id when list server-groups https://review.openstack.org/209018 | 03:52 |
| *** shoutm has joined #openstack-nova | 03:52 | |
| *** meghal has joined #openstack-nova | 03:52 | |
| *** meghal has quit IRC | 03:52 | |
| *** meghal has joined #openstack-nova | 03:53 | |
| *** shoutm_ has quit IRC | 03:54 | |
| *** meghal1 has joined #openstack-nova | 03:54 | |
| *** shoutm_ has joined #openstack-nova | 03:55 | |
| *** meghal1 has quit IRC | 03:56 | |
| *** meghal has quit IRC | 03:57 | |
| *** meghal1 has joined #openstack-nova | 03:57 | |
| *** shoutm has quit IRC | 03:57 | |
| *** shoutm has joined #openstack-nova | 03:58 | |
| *** shoutm_ has quit IRC | 03:59 | |
| tonyb | johnthetubaguy: I left some feedk back on https://review.openstack.org/#/c/184537/ re keystone that I think would be good to get your (and other cores) opinion on. As it sets direction for how we use keystone. | 04:00 |
| *** meghal1 has quit IRC | 04:01 | |
| *** rajesht has joined #openstack-nova | 04:02 | |
| *** fawadkhaliq has joined #openstack-nova | 04:02 | |
| *** mdrabe has quit IRC | 04:09 | |
| *** salv-orlando has quit IRC | 04:10 | |
| *** dave-mccowan has joined #openstack-nova | 04:11 | |
| *** dave-mcc_ has quit IRC | 04:13 | |
| *** tojuvone has joined #openstack-nova | 04:14 | |
| *** Sree has joined #openstack-nova | 04:15 | |
| *** dave-mccowan has quit IRC | 04:18 | |
| *** achanda has joined #openstack-nova | 04:20 | |
| *** vilobhmm1 has joined #openstack-nova | 04:22 | |
| *** takedakn1 has quit IRC | 04:25 | |
| *** takedakn has joined #openstack-nova | 04:26 | |
| *** haigang has quit IRC | 04:27 | |
| *** deepakcs has joined #openstack-nova | 04:27 | |
| *** Sree has quit IRC | 04:29 | |
| *** lyanchih has quit IRC | 04:32 | |
| *** takedakn has quit IRC | 04:35 | |
| *** shaohe_feng1 has quit IRC | 04:39 | |
| *** shoutm_ has joined #openstack-nova | 04:39 | |
| *** bapalm has quit IRC | 04:39 | |
| *** shoutm has quit IRC | 04:41 | |
| *** bapalm has joined #openstack-nova | 04:41 | |
| openstackgerrit | Alex Xu proposed openstack/nova: api: tidy up paste.ini https://review.openstack.org/214085 | 04:42 |
| openstackgerrit | Alex Xu proposed openstack/nova: Strip the extra input parameters out when using legacy v2 middleware https://review.openstack.org/215436 | 04:42 |
| alex_xu | johnthetubaguy: gmann ^ hope this works | 04:43 |
| *** tpeoples has quit IRC | 04:44 | |
| *** bapalm has quit IRC | 04:46 | |
| *** Nikolay_St has quit IRC | 04:46 | |
| *** bapalm has joined #openstack-nova | 04:47 | |
| *** fawadkhaliq has quit IRC | 04:51 | |
| *** fawadk has joined #openstack-nova | 04:51 | |
| *** moshele has joined #openstack-nova | 04:51 | |
| *** salv-orlando has joined #openstack-nova | 04:53 | |
| *** setuid has quit IRC | 04:53 | |
| *** bapalm has quit IRC | 04:54 | |
| *** setuid has joined #openstack-nova | 04:55 | |
| *** bapalm has joined #openstack-nova | 04:56 | |
| *** shyama has joined #openstack-nova | 04:57 | |
| *** unicell has joined #openstack-nova | 04:58 | |
| *** SourabhP has joined #openstack-nova | 04:59 | |
| *** SourabhP_ has joined #openstack-nova | 05:00 | |
| gmann | alex_xu: cool. i was also doing the same. adding for metadata pattern also | 05:03 |
| *** bapalm has quit IRC | 05:03 | |
| *** SourabhP has quit IRC | 05:04 | |
| *** SourabhP_ is now known as SourabhP | 05:04 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: libvirt:Remove duplicated check code for config option sysinfo_serial https://review.openstack.org/198285 | 05:05 |
| *** unicell has quit IRC | 05:05 | |
| alex_xu | gmann: yea, cool | 05:05 |
| *** kiran-r has joined #openstack-nova | 05:05 | |
| alex_xu | gmann: we are lucky, looks like this way will works | 05:05 |
| *** unicell has joined #openstack-nova | 05:06 | |
| gmann | alex_xu: seems so. | 05:06 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Strip the extra input parameters out when using legacy v2 middleware https://review.openstack.org/215436 | 05:06 |
| gmann | alex_xu: ^^ | 05:06 |
| alex_xu | gmann: cool, thanks! | 05:06 |
| *** bapalm has joined #openstack-nova | 05:07 | |
| gmann | alex_xu: but as we strip out extra param, it will be success and we need to change the tempest tests as they expect error | 05:07 |
| gmann | alex_xu: only for v2onv21 | 05:07 |
| alex_xu | gmann: yea, good point | 05:07 |
| *** kiran-r has quit IRC | 05:07 | |
| gmann | alex_xu: m tested metadata thing with tempest changes and its work fine | 05:08 |
| gmann | alex_xu: testing for host test also | 05:08 |
| alex_xu | gmann: cool | 05:08 |
| *** armax has quit IRC | 05:08 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: api: tidy up paste.ini https://review.openstack.org/214085 | 05:08 |
| *** armax has joined #openstack-nova | 05:09 | |
| alex_xu | gmann: this looks like will strip too long parameter out also | 05:10 |
| gmann | alex_xu: for metadata? | 05:10 |
| alex_xu | gmann: yea | 05:10 |
| *** ajayaa has joined #openstack-nova | 05:10 | |
| *** sabari has quit IRC | 05:10 | |
| gmann | alex_xu: yes, actually any invalid key in metadata case considered as extra param in v2.1 | 05:10 |
| alex_xu | gmann: I'm thinking whether we should keep that return 400 for user | 05:10 |
| gmann | v2.1 validation | 05:10 |
| alex_xu | gmann: humm...yea | 05:11 |
| gmann | alex_xu: that is difficult for metadata case as we would not be able to differentiate extra vs invalid param till we add python code validation | 05:12 |
| gmann | alex_xu: as it use patternproperty | 05:12 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/214991 | 05:12 |
| alex_xu | gmann: emmm...one more idea, can we make patternproperty works as normal? | 05:12 |
| gmann | alex_xu: you mean validate key in python code only not in schema validation like v2? | 05:13 |
| *** ivasev_ has quit IRC | 05:14 | |
| *** wanghua has joined #openstack-nova | 05:15 | |
| alex_xu | gmann: no, still use schema | 05:15 |
| alex_xu | gmann: we only strip for addtionalProperties, but make patternParoperties works | 05:15 |
| gmann | alex_xu: yea, but then metadata case will still fail as before | 05:16 |
| *** bapalm has quit IRC | 05:16 | |
| gmann | alex_xu: and now i also feels making metadata invalid key return success not good | 05:16 |
| alex_xu | gmann: me too | 05:17 |
| gmann | alex_xu: only way i think to do so in putting python code validation in v2.1 as v2 (initial idea) | 05:17 |
| *** bapalm has joined #openstack-nova | 05:20 | |
| *** oomichi has joined #openstack-nova | 05:20 | |
| *** jwcroppe has joined #openstack-nova | 05:21 | |
| alex_xu | gmann: in line 85 https://review.openstack.org/#/c/215436/2/nova/api/validation/validators.py , if we have pattern, and the instance not match the pattern, then we return fauilure, does works? | 05:22 |
| gmann | alex_xu: ah i see. nice idea. i think that should work | 05:23 |
| gmann | alex_xu: let me test quickly | 05:23 |
| alex_xu | gmann: thanks! | 05:23 |
| gmann | alex_xu: worked perfect for metadata :) +100 for your idea :) | 05:28 |
| *** nkrinner has joined #openstack-nova | 05:28 | |
| gmann | alex_xu: updating patch | 05:29 |
| *** sudipto has joined #openstack-nova | 05:30 | |
| *** oomichi has quit IRC | 05:30 | |
| *** topshare has joined #openstack-nova | 05:31 | |
| *** shuquan has joined #openstack-nova | 05:34 | |
| *** bapalm has quit IRC | 05:34 | |
| openstackgerrit | Deepak C Shetty (deepakcs) proposed openstack/nova: libvirt: Fix snapshot delete for network disk type for blockRebase op https://review.openstack.org/212518 | 05:35 |
| *** bapalm has joined #openstack-nova | 05:35 | |
| *** shaohe_feng has joined #openstack-nova | 05:35 | |
| *** chaochin has quit IRC | 05:39 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Strip the extra input parameters out when using legacy v2 middleware https://review.openstack.org/215436 | 05:39 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: api: tidy up paste.ini https://review.openstack.org/214085 | 05:39 |
| gmann | alex_xu: ^^ | 05:39 |
| *** chaochin has joined #openstack-nova | 05:39 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 05:40 |
| *** topshare has quit IRC | 05:40 | |
| *** Zhang has joined #openstack-nova | 05:41 | |
| eliqiao_pc | alex_xu: ping , r u available now? | 05:42 |
| *** shane-wang has joined #openstack-nova | 05:43 | |
| openstackgerrit | Moshe Levi proposed openstack/nova-specs: Add spec to enhance PCI passthrough whitelist to support regex https://review.openstack.org/213428 | 05:43 |
| *** shuquan has quit IRC | 05:43 | |
| *** bapalm has quit IRC | 05:44 | |
| *** wanghua has quit IRC | 05:44 | |
| *** shuquan has joined #openstack-nova | 05:46 | |
| *** dims has joined #openstack-nova | 05:47 | |
| openstackgerrit | Mike Dorman proposed openstack/nova: Cells v1: Support attach/detach interface and external events https://review.openstack.org/215459 | 05:50 |
| *** Sree has joined #openstack-nova | 05:51 | |
| *** dims has quit IRC | 05:52 | |
| *** lyanchih has joined #openstack-nova | 05:52 | |
| alex_xu | gmann: cool, thanks | 05:53 |
| alex_xu | eliqiao_pc: hey, I'm here | 05:53 |
| *** Sree has quit IRC | 05:54 | |
| *** Sree has joined #openstack-nova | 05:55 | |
| *** bapalm has joined #openstack-nova | 05:56 | |
| *** y_sawai has joined #openstack-nova | 05:56 | |
| *** shuquan has quit IRC | 05:56 | |
| *** Sree has quit IRC | 05:59 | |
| *** rotbeard has quit IRC | 06:00 | |
| openstackgerrit | Rui Chen proposed openstack/nova: Fix incorrect result of host-describe https://review.openstack.org/211083 | 06:00 |
| *** dims has joined #openstack-nova | 06:01 | |
| *** wanghua has joined #openstack-nova | 06:02 | |
| *** eliqiao_pc has quit IRC | 06:05 | |
| *** dims has quit IRC | 06:05 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex https://review.openstack.org/212367 | 06:07 |
| *** rajesht has quit IRC | 06:08 | |
| *** oomichi has joined #openstack-nova | 06:08 | |
| *** Sree has joined #openstack-nova | 06:09 | |
| *** penick has joined #openstack-nova | 06:09 | |
| openstackgerrit | wanghao proposed openstack/nova: Add nova-manage command for cleaning attachment https://review.openstack.org/184537 | 06:09 |
| *** sabari has joined #openstack-nova | 06:10 | |
| *** abhishekk has joined #openstack-nova | 06:10 | |
| *** vivekd has joined #openstack-nova | 06:11 | |
| openstackgerrit | wanghao proposed openstack/nova: Add nova-manage command for cleaning attachment https://review.openstack.org/184537 | 06:12 |
| *** penick has quit IRC | 06:12 | |
| openstackgerrit | Jianghua Wang proposed openstack/nova: xen: To expose disk labels in guest for root and ephemeral disks https://review.openstack.org/213094 | 06:14 |
| *** bapalm has quit IRC | 06:15 | |
| *** browne has quit IRC | 06:15 | |
| *** bapalm has joined #openstack-nova | 06:16 | |
| openstackgerrit | Shuquan Huang proposed openstack/nova: Support to launch instance booted from uefi rom for AARCH64/ARM https://review.openstack.org/215414 | 06:18 |
| *** shuquan has joined #openstack-nova | 06:18 | |
| *** armax has quit IRC | 06:18 | |
| *** bapalm has quit IRC | 06:20 | |
| *** takedakn has joined #openstack-nova | 06:23 | |
| *** oomichi has quit IRC | 06:24 | |
| *** shane-wang has quit IRC | 06:25 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Move CPU and RAM allocation ratios to ResourceTracker https://review.openstack.org/215278 | 06:25 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add cpu_allocation_ratio and ram_allocation_ratio to ComputeNode https://review.openstack.org/215471 | 06:25 |
| *** SourabhP has quit IRC | 06:26 | |
| *** salv-orlando has quit IRC | 06:30 | |
| *** Sree has quit IRC | 06:34 | |
| *** asettle has quit IRC | 06:35 | |
| *** vivekd has quit IRC | 06:38 | |
| *** shuquan has quit IRC | 06:38 | |
| *** oomichi has joined #openstack-nova | 06:40 | |
| *** vivekd has joined #openstack-nova | 06:41 | |
| *** vilobhmm1 has quit IRC | 06:42 | |
| *** y_sawai_ has joined #openstack-nova | 06:43 | |
| gmann | alex_xu: that will not work for extra param in nested property | 06:43 |
| alex_xu | gmann: do you have example? | 06:44 |
| *** shuquan has joined #openstack-nova | 06:45 | |
| gmann | alex_xu: we do not tests for such case, i just added some extra param in server create request where request is like {u'server': {u'flavorRef': u'42', u'adminPass': u'testpassword', u'name': u'tempest.common.compute-instance-1821082205', u'extra_param': u'extra', u'imageRef': u'8d223cad-b1ca-4023-96d5-0faf220b453d'}} | 06:45 |
| gmann | embedded in 'server' dict | 06:45 |
| *** xgsa has joined #openstack-nova | 06:45 | |
| *** y_sawai has quit IRC | 06:45 | |
| *** salv-orlando has joined #openstack-nova | 06:46 | |
| gmann | alex_xu: we need to iterate in instance to get all nested property also | 06:46 |
| alex_xu | gmann: strange, I remember my test case is {'adminPassword': {'adminPass': 'abc', 'extra': '123'}} | 06:46 |
| gmann | alex_xu: ohh, let me reconfirm may be m missing something | 06:47 |
| alex_xu | gmann: emm...the jsonschema code will responsible for iterate the instance I guess | 06:47 |
| gmann | alex_xu: yea, for each property json schema should call additionalProperty validator | 06:47 |
| alex_xu | gmann: yea | 06:48 |
| *** markus_z has joined #openstack-nova | 06:50 | |
| gmann | alex_xu: but looks like not on my env | 06:58 |
| alex_xu | gmann: let me check that also | 06:58 |
| *** shane-wang has joined #openstack-nova | 06:59 | |
| *** Murali has joined #openstack-nova | 07:00 | |
| *** scheuran has joined #openstack-nova | 07:00 | |
| *** shoutm has joined #openstack-nova | 07:03 | |
| openstackgerrit | Rajesh Tailor proposed openstack/nova: Set migration status to 'error' on live-migration failure https://review.openstack.org/215483 | 07:04 |
| *** sudipto has quit IRC | 07:04 | |
| *** shoutm_ has quit IRC | 07:05 | |
| *** emagana has joined #openstack-nova | 07:05 | |
| *** jcoufal has joined #openstack-nova | 07:05 | |
| alex_xu | gmann: quick look, feel this is wrong "if patterns and re.search(patterns, property):" | 07:06 |
| alex_xu | gmann: if no pattern, it will return fault also | 07:06 |
| *** rajesht has joined #openstack-nova | 07:16 | |
| *** ankit_ag has joined #openstack-nova | 07:17 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Strip the extra input parameters out when using legacy v2 middleware https://review.openstack.org/215436 | 07:17 |
| openstackgerrit | Alex Xu proposed openstack/nova: api: tidy up paste.ini https://review.openstack.org/214085 | 07:17 |
| alex_xu | gmann: ^ | 07:17 |
| *** sudipto has joined #openstack-nova | 07:21 | |
| *** ttx has quit IRC | 07:23 | |
| *** ttx has joined #openstack-nova | 07:23 | |
| *** lyanchih has quit IRC | 07:26 | |
| *** shoutm has quit IRC | 07:29 | |
| *** shuquan has quit IRC | 07:31 | |
| openstackgerrit | wanghao proposed openstack/nova: Add nova-manage command for cleaning attachment https://review.openstack.org/184537 | 07:31 |
| *** lsmola has joined #openstack-nova | 07:31 | |
| *** dguitarbite has quit IRC | 07:32 | |
| openstackgerrit | wangxiyuan proposed openstack/nova: Add UniqueConstraint for quota usages table https://review.openstack.org/212908 | 07:32 |
| *** achanda has quit IRC | 07:35 | |
| *** lyanchih has joined #openstack-nova | 07:36 | |
| openstackgerrit | Brooks Kaminski proposed openstack/nova: Xenapi: Correct misaligned partitioning https://review.openstack.org/203323 | 07:39 |
| openstackgerrit | Wen Zhi Yu proposed openstack/nova-specs: Spec for nova API blueprint correct-volume-attachment-id-in-nova-api-volumes https://review.openstack.org/214021 | 07:44 |
| *** Nikolay_St has joined #openstack-nova | 07:44 | |
| openstackgerrit | wangxiyuan proposed openstack/nova: Make query to quota usage table order preserved. https://review.openstack.org/213584 | 07:46 |
| *** lpetrut has joined #openstack-nova | 07:47 | |
| *** matrohon has joined #openstack-nova | 07:48 | |
| *** shoutm has joined #openstack-nova | 07:48 | |
| *** lyanchih has quit IRC | 07:48 | |
| *** haomaiwa_ has quit IRC | 07:49 | |
| *** haomaiwang has joined #openstack-nova | 07:49 | |
| *** IanGovett has joined #openstack-nova | 07:50 | |
| *** shane-wang has quit IRC | 07:50 | |
| *** tdurakov has left #openstack-nova | 07:50 | |
| *** shane-wang has joined #openstack-nova | 07:50 | |
| *** lyanchih has joined #openstack-nova | 07:50 | |
| *** ajayaa has quit IRC | 07:51 | |
| *** tdurakov1 has joined #openstack-nova | 07:52 | |
| *** tdurakov1 has left #openstack-nova | 07:52 | |
| *** tdurakov1 has joined #openstack-nova | 07:52 | |
| *** tdurakov1 has left #openstack-nova | 07:54 | |
| *** LukeHinds has joined #openstack-nova | 07:55 | |
| *** alexschm has joined #openstack-nova | 07:55 | |
| *** tdurakov has joined #openstack-nova | 07:59 | |
| *** haomaiwang has quit IRC | 08:01 | |
| *** VikasC has quit IRC | 08:01 | |
| *** haomaiwang has joined #openstack-nova | 08:02 | |
| *** huats has joined #openstack-nova | 08:04 | |
| *** fawadk has quit IRC | 08:06 | |
| *** fawadkhaliq has joined #openstack-nova | 08:06 | |
| *** shane-wang has quit IRC | 08:08 | |
| *** derekh has joined #openstack-nova | 08:08 | |
| *** shuquan has joined #openstack-nova | 08:09 | |
| *** yassine has joined #openstack-nova | 08:09 | |
| *** dguitarbite has joined #openstack-nova | 08:11 | |
| *** shoutm_ has joined #openstack-nova | 08:11 | |
| *** oomichi has quit IRC | 08:11 | |
| *** chhavi__ has joined #openstack-nova | 08:11 | |
| *** shoutm has quit IRC | 08:13 | |
| *** lyanchih has quit IRC | 08:14 | |
| *** chhavi_ has joined #openstack-nova | 08:14 | |
| johnthetubaguy | alex_xu: thats the most complex noop I have every seen, but I think I like where it is going :) https://review.openstack.org/#/c/215436/4/nova/api/validation/validators.py,cm | 08:15 |
| *** shuquan has quit IRC | 08:15 | |
| johnthetubaguy | tonyb: thanks for the heads up, I will take a peak | 08:15 |
| gmann | alex_xu: yea, its working fine now | 08:15 |
| *** Marga_ has quit IRC | 08:16 | |
| *** Marga_ has joined #openstack-nova | 08:16 | |
| *** chhavi__ has quit IRC | 08:16 | |
| gmann | johnthetubaguy: now on https://review.openstack.org/#/c/214085/, only comment of PS9 needs to be fix for functional tests pass | 08:16 |
| *** tbh has joined #openstack-nova | 08:17 | |
| gmann | johnthetubaguy: yes validator one was complex and it handle the metedata things too. tested on my local env with some extra param in nested property too and working fine | 08:18 |
| openstackgerrit | Jordan Pittier proposed openstack/nova: libvirt:update live_migration_monitor to use Guest https://review.openstack.org/211152 | 08:19 |
| openstackgerrit | Li Yuanyuan proposed openstack/nova: Fix param backlog exception msg from 'The backlog must be more than 1' to 'The backlog must be more than 0'. https://review.openstack.org/215509 | 08:19 |
| johnthetubaguy | gmann: I did make that change locally, but it didn't totally seem to help everything, I should push up what I have | 08:21 |
| gmann | johnthetubaguy: sure | 08:21 |
| *** fawadkhaliq has quit IRC | 08:21 | |
| *** lyanchih has joined #openstack-nova | 08:23 | |
| openstackgerrit | John Garbutt proposed openstack/nova: api: tidy up paste.ini https://review.openstack.org/214085 | 08:24 |
| *** romainh has joined #openstack-nova | 08:25 | |
| johnthetubaguy | gmann: this is what I had, but not sure thats correct: https://review.openstack.org/#/c/214085/14/nova/tests/functional/api_sample_tests/api_sample_base.py,cm | 08:25 |
| *** shaohe_feng has quit IRC | 08:25 | |
| *** wanghua has quit IRC | 08:27 | |
| *** Zhang has quit IRC | 08:27 | |
| openstackgerrit | Jordan Pittier proposed openstack/nova: libvirt:on snapshot delete, use qemu-img to blockRebase if VM is stopped https://review.openstack.org/192736 | 08:27 |
| *** chhavi__ has joined #openstack-nova | 08:28 | |
| *** lpetrut has quit IRC | 08:29 | |
| *** jistr has joined #openstack-nova | 08:30 | |
| *** chhavi_ has quit IRC | 08:30 | |
| *** RuiChen has quit IRC | 08:31 | |
| gmann | johnthetubaguy: that looks fine but also need more for extension test failure. i added comment not on file just outside for extension thing failure - | 08:32 |
| gmann | johnthetubaguy: Need fix for class ExtensionInfoSamplesJsonTest(api_sample_base.ApiSampleTestBaseV3) as done in https://review.openstack.org/#/c/214985/3/nova/tests/functional/api_sample_tests/test_extension_info.py | 08:32 |
| gmann | with _api_version=v2 | 08:32 |
| gmann | as it run for _api_version=v3 and no get extension API in v2. | 08:32 |
| *** rpodolyaka1 has quit IRC | 08:32 | |
| johnthetubaguy | yeah, I still see a fail for v2 | 08:33 |
| johnthetubaguy | so v2.1 fixes it, possibly incorrectly | 08:33 |
| gmann | johnthetubaguy: this one - Ghanshyam MannAug 20 8:32 PM | 08:33 |
| *** lyanchih has quit IRC | 08:33 | |
| openstackgerrit | John Garbutt proposed openstack/nova: api: tidy up paste.ini https://review.openstack.org/214085 | 08:33 |
| johnthetubaguy | so I fixed in a possibly incorrect way... anyways, take a peak at the latest | 08:35 |
| *** ajayaa has joined #openstack-nova | 08:35 | |
| johnthetubaguy | gmann: this seemed to do the trick: https://review.openstack.org/#/c/214085/15/nova/tests/functional/api_sample_tests/test_extension_info.py,cm | 08:35 |
| gmann | johnthetubaguy: yea | 08:39 |
| tonyb | johnthetubaguy: Thanks. I hope I didn't speak out of turn. | 08:40 |
| *** shoutm_ has quit IRC | 08:40 | |
| *** yanxb_ has quit IRC | 08:41 | |
| johnthetubaguy | tonyb: not at all | 08:42 |
| *** yanxb_ has joined #openstack-nova | 08:42 | |
| johnthetubaguy | tonyb: I was assuming we would make nova-manage match python-novaclient so localrc works | 08:43 |
| johnthetubaguy | tonyb: I mean openrc, but yeah, not sure thats true here | 08:43 |
| *** fawadkhaliq has joined #openstack-nova | 08:43 | |
| *** sayali has joined #openstack-nova | 08:47 | |
| *** Marga_ has quit IRC | 08:48 | |
| johnthetubaguy | tonyb: PS, you should feel free to speak at any time! | 08:48 |
| *** Marga_ has joined #openstack-nova | 08:49 | |
| *** lyanchih has joined #openstack-nova | 08:49 | |
| johnthetubaguy | alex_xu: I wonder if that properties thing is correct, are you working on a unit test for that already? | 08:49 |
| *** maurosr has quit IRC | 08:51 | |
| *** timello has quit IRC | 08:51 | |
| *** ekhugen has quit IRC | 08:52 | |
| *** rotbeard has joined #openstack-nova | 08:54 | |
| *** timello has joined #openstack-nova | 08:54 | |
| *** maurosr has joined #openstack-nova | 08:55 | |
| *** salv-orlando has quit IRC | 08:55 | |
| *** ekhugen has joined #openstack-nova | 08:56 | |
| *** jwcroppe has quit IRC | 08:58 | |
| *** haomaiwang has quit IRC | 09:01 | |
| *** haomaiwang has joined #openstack-nova | 09:02 | |
| mhorban | johnthetubaguy: Hi, could you please look at https://review.openstack.org/#/c/195303/ ? | 09:04 |
| *** sayali has quit IRC | 09:04 | |
| tbh | johnthetubaguy: hi, can you please have a look at https://review.openstack.org/#/c/215207/ ? | 09:06 |
| johnthetubaguy | mhorban: I think I would like to hear more from sdague before I vote again | 09:06 |
| johnthetubaguy | tbh: did you see the test failure on there? | 09:07 |
| *** sayali has joined #openstack-nova | 09:08 | |
| johnthetubaguy | tbh: the test error says: testtools.matchers._impl.MismatchError: 'os-hypervisors-ipaddress.rst' not in ['redirects', 'implemented', 'approved']: Found unexpected file in 'specs/mitaka', specs should be submitted to 'specs/mitaka/approved' | 09:08 |
| johnthetubaguy | tbh: you can see that by clicking on the test failure link, that takes you here: http://logs.openstack.org/07/215207/1/check/gate-nova-specs-python27/511af75/console.html | 09:08 |
| tbh | johnthetubaguy: sorry I saw that error now, I thought the test case wont apply for specs | 09:09 |
| tbh | I will modify it | 09:09 |
| johnthetubaguy | tbh: as a heads up, we are not really reviewing nova-specs at the moment, while we drive forward with getting all the liberty bug fixes and features reviewed | 09:10 |
| *** vipul has quit IRC | 09:10 | |
| *** jodah has quit IRC | 09:10 | |
| *** lpetrut has joined #openstack-nova | 09:10 | |
| *** jodah has joined #openstack-nova | 09:11 | |
| tonyb | johnthetubaguy: Thanks. | 09:12 |
| tbh | johnthetubaguy: then can I proceed with implementing bp and push for review? or do I need to check for another bp? | 09:12 |
| *** vipul has joined #openstack-nova | 09:12 | |
| *** lpetrut has quit IRC | 09:15 | |
| *** lyanchih has quit IRC | 09:16 | |
| alex_xu | johnthetubaguy: I'm not working on the unittest yet | 09:17 |
| alex_xu | johnthetubaguy: actually I want to get some feedback from you first | 09:17 |
| *** lyanchih has joined #openstack-nova | 09:17 | |
| johnthetubaguy | tbh: so the code will not get reviewed until we open for Mitaka, we really want folks to help with bug fixes and review bug fixes right now | 09:18 |
| johnthetubaguy | tbh: really you need to wait until after liberty-rc1 to upload new feature code for review | 09:18 |
| johnthetubaguy | tbh: probably sometime just after September 21st | 09:18 |
| tbh | johnthetubaguy: Okay, I will look on bugs now, and can you please assign that bp to me, so that when rc1 is out, I can work on it? | 09:19 |
| *** aix has joined #openstack-nova | 09:19 | |
| johnthetubaguy | tbh: its possible the spec review means you change how you code is written, but I don't want to stop folks creating prototypes | 09:20 |
| johnthetubaguy | tbh: do you have the link to that blueprint, and your launchpad username for me? | 09:20 |
| johnthetubaguy | tbh: bug wise, ideally please review the bugs that are already up for review, see here for tips: https://wiki.openstack.org/wiki/Nova/Mentoring#Why_do_code_reviews_if_I_am_not_in_nova-core.3F | 09:21 |
| *** VikasC has joined #openstack-nova | 09:21 | |
| johnthetubaguy | tbh: if you want to do some bug fixes, I would look at high priority ones first, and ones that you think are really important (there are bug tags to try and help narrow it down): https://bugs.launchpad.net/nova | 09:22 |
| johnthetubaguy | alex_xu: thats cool, makes sense, I added a comment | 09:22 |
| alex_xu | johnthetubaguy: I'm reading | 09:22 |
| tbh | johnthetubaguy: https://blueprints.launchpad.net/nova/+spec/os-hypervisors-ipaddress and my lauunchpad iD is "bharath-ves" | 09:22 |
| johnthetubaguy | alex_xu: I like the checking of the patterns, I think we might get away without the stripping of the extra params | 09:22 |
| tbh | johnthetubaguy: sure I will look into it | 09:23 |
| alex_xu | johnthetubaguy: But I'm afraid there may some code can't process extra param safely | 09:23 |
| openstackgerrit | John Garbutt proposed openstack/nova-specs: Returning Compute Node IP address in hypervisor list https://review.openstack.org/215207 | 09:24 |
| tonyb | johnthetubaguy: I don't think that using session vs the existing stuff will make a difference to how openrc work | 09:25 |
| alex_xu | johnthetubaguy: but I need find if there is example, I'm just afraid something like params = body['x']; self.compute_api.xaction(**params), but xaction not accept kwargs, it have specific parameter list. | 09:26 |
| alexschm | Hi all, my (partial) bugfix for enabling live migration with serial console has been online for a while now, anyone willing to review this? | 09:26 |
| tonyb | johnthetubaguy: Also I'm mostly worried about saying "go nd do this thing" have have it not be the correct direction. | 09:26 |
| alexschm | https://review.openstack.org/#/c/191035/ | 09:26 |
| *** takedakn has quit IRC | 09:26 | |
| *** chhavi__ has quit IRC | 09:27 | |
| *** takedakn has joined #openstack-nova | 09:27 | |
| johnthetubaguy | tonyb: I guess I was missing which comment you were worried about? | 09:27 |
| johnthetubaguy | alex_xu: yes, I was worried about that was well, but it got over-ruled in the spec review | 09:28 |
| johnthetubaguy | alex_xu: so I like the idea of trying the in between bits | 09:28 |
| *** tbh has quit IRC | 09:29 | |
| *** shoutm has joined #openstack-nova | 09:30 | |
| *** tbh has joined #openstack-nova | 09:31 | |
| *** VikasC has quit IRC | 09:31 | |
| alex_xu | johnthetubaguy: ok, I'm ok with that, at least I can't find out an exmaple for this case | 09:32 |
| tonyb | johnthetubaguy: Yeah I wasn't thinking about the @args stuff which is far more important as it affects the end user's experience. | 09:32 |
| alex_xu | johnthetubaguy: btw, I'm try to go through the v2.1 doc, looks like not good https://etherpad.openstack.org/p/nova-v2.1-api-doc :( | 09:32 |
| tonyb | johnthetubaguy: I was hoping Wanghao would basially use v2.Password to get the auth token and pass that around. | 09:33 |
| johnthetubaguy | alex_xu: so thats a really good list, and a fantastic starting point for the docs work | 09:33 |
| tonyb | we can totally reuse the stuff from novaclient and make sure that works also. | 09:33 |
| johnthetubaguy | tonyb: oh, I see, rather than using the context | 09:34 |
| alex_xu | johnthetubaguy: thanks, will try to work with Anne to find out a way for v2.1 API in Liberty | 09:34 |
| johnthetubaguy | alex_xu: let me sketch out and idea I have been having in your etherpad | 09:35 |
| *** tbh has quit IRC | 09:35 | |
| alex_xu | johnthetubaguy: thanks | 09:35 |
| tonyb | johnthetubaguy: What Wanghao has done is on the right path but we also need to, as you point out, hook into the register_argparse_arguments(parser) stuff | 09:37 |
| tonyb | johnthetubaguy: There are nice decorators we can use also. | 09:37 |
| tonyb | I'll take a stab at it next week, assuming I can fix the devstack/juno thing | 09:37 |
| tonyb | johnthetubaguy: Thanks again for your support. | 09:38 |
| johnthetubaguy | tonyb: yeah, +1 all you are saying there | 09:39 |
| johnthetubaguy | tonyb: my concern is we don't want to ship a broken interface, because we would then have to worry about backwards compatbilitiy | 09:39 |
| tonyb | johnthetubaguy: Yeah for sure. | 09:39 |
| johnthetubaguy | tonyb: I am actually less worried about the internals, because of the above problem, if you see what I mean | 09:39 |
| johnthetubaguy | but we need those correct, but it could be a follow up patch if it gets messy | 09:40 |
| *** eliqiao_pc has joined #openstack-nova | 09:40 | |
| tonyb | johnthetubaguy: Yeah. I'm with you now. | 09:40 |
| johnthetubaguy | tonyb: cools | 09:42 |
| alex_xu | sdague: there is something I go through the doc, hope get your input also when you onlin https://etherpad.openstack.org/p/nova-v2.1-api-doc | 09:42 |
| tonyb | johnthetubaguy: I wont reply tonight as I really want to investigate the options and provide better feedback. | 09:42 |
| *** alex_klimov has joined #openstack-nova | 09:43 | |
| *** shoutm has quit IRC | 09:45 | |
| johnthetubaguy | tonyb: no worries, that makes sense | 09:45 |
| johnthetubaguy | alex_xu: does that stuff on line14 make sense? | 09:46 |
| johnthetubaguy | alex_xu: I hope we get to 2.4 before the end of liberty, is my thinking | 09:46 |
| alex_xu | johnthetubaguy: v2.4? | 09:46 |
| alex_xu | johnthetubaguy: oops, sorry, I got what your mean... | 09:47 |
| johnthetubaguy | alex_xu: oops, I mean point 2.4 | 09:47 |
| johnthetubaguy | hehe, bad number clash there | 09:47 |
| alex_xu | johnthetubaguy: yea, that make sense | 09:47 |
| eliqiao_pc | hi johnthetubaguy GM. | 09:47 |
| alex_xu | johnthetubaguy: at least that make us have somethign for L | 09:48 |
| johnthetubaguy | alex_xu: I think we want to get ourselves into a position where lots of folks can help out, so it might be a case of doing both of those at once, then getting people to help turn the handle on finishing the job? | 09:49 |
| alex_xu | johnthetubaguy: the doc team plan is: using fairy-slipper convert wadl to sagger, then in M when we have way to gennerate swagger from code, will using those converted sagger validate with generated swagger | 09:49 |
| johnthetubaguy | alex_xu: agreed | 09:49 |
| johnthetubaguy | alex_xu: our WADL is so bad, I can't see that helping our users for Liberty | 09:50 |
| johnthetubaguy | eliqiao_pc: hi | 09:50 |
| gmann | alex_xu: johnthetubaguy I can also help on doc thing if needed | 09:50 |
| gmann | alex_xu: so looks like we need to update WADL manually? | 09:50 |
| alex_xu | gmann: thanks | 09:50 |
| alex_xu | gmann: I guess so | 09:50 |
| johnthetubaguy | gmann: yeah, I think once we get v3 deprecated and v2.1 by default, we need to push hard on this | 09:50 |
| gmann | alex_xu: johnthetubaguy : yea | 09:51 |
| johnthetubaguy | gmann: alex_xu: I will try work on a cunning plan to improve the testing of the API, the feature classification stuff, I want to get that kicked off now. | 09:51 |
| eliqiao_pc | johnthetubaguy: We finished prc hackathon this afternoon, and finally we got a bug/patch list out. totally there are 31 patches were submited (some of them are old patches but we have some disscussion on them) | 09:52 |
| alex_xu | johnthetubaguy: thanks! | 09:52 |
| alex_xu | eliqiao_pc: cool | 09:53 |
| gmann | johnthetubaguy: yea that will be cool. Thanks | 09:53 |
| johnthetubaguy | eliqiao_pc: awesome | 09:53 |
| eliqiao_pc | johnthetubaguy: as you told, we did review on each others. and this is the link for the bug/patch list #link https://etherpad.openstack.org/p/hackathon2_nova_list | 09:53 |
| johnthetubaguy | eliqiao_pc: how did the reviewing each others patches go? | 09:53 |
| eliqiao_pc | alex_xu: yeah, thanks for review our patches. | 09:54 |
| eliqiao_pc | johnthetubaguy: some have -1s , may need further discussion, most get +1s and there are fews get merged already | 09:55 |
| alex_xu | eliqiao_pc: np, really hope I can go to Xi'an also | 09:55 |
| johnthetubaguy | eliqiao_pc: great stuff | 09:55 |
| eliqiao_pc | johnthetubaguy: also kenichi help +2 too and other cores give good supporting. | 09:55 |
| johnthetubaguy | eliqiao_pc: my mission is to make it more normal for folks to review each others code in the open | 09:55 |
| johnthetubaguy | eliqiao_pc: https://wiki.openstack.org/wiki/Nova/Mentoring#Why_do_code_reviews_if_I_am_not_in_nova-core.3F | 09:56 |
| eliqiao_pc | johnthetubaguy: get it. | 09:56 |
| johnthetubaguy | eliqiao_pc: getting more folks into that habbit is fantastic stuff, thank you! | 09:56 |
| johnthetubaguy | eliqiao_pc: almost perfect timing with this event, FWIW, love it | 09:57 |
| eliqiao_pc | johnthetubaguy: thanks, hackathon is a good event, we hope we can do it every release. | 09:57 |
| *** fawadkhaliq has quit IRC | 09:57 | |
| johnthetubaguy | eliqiao_pc: sounds good, particularly the review-athon bit :) | 09:57 |
| eliqiao_pc | johnthetubaguy: there are around 10+ novaers , and we have other projects's core, such as neutron (1 core , 1 ex-core), heat (2 cores) | 09:58 |
| eliqiao_pc | johnthetubaguy: it would be good if we can have nova core to take part in our event next time(I know you are all very busy). | 09:59 |
| *** romainh has quit IRC | 10:00 | |
| johnthetubaguy | eliqiao_pc: we can keep asking, we are not as spread across the globe as I would like, which doesn't help, but its worth trying to get folks there | 10:00 |
| eliqiao_pc | johnthetubaguy: could you help to encourage other cores to have to review the bug list, I would be appreciate of it, thanks in advance :) | 10:00 |
| *** haomaiwang has quit IRC | 10:01 | |
| johnthetubaguy | eliqiao_pc: I have added it into our etherpad for folks to dig into, which should help | 10:01 |
| alex_xu | eliqiao_pc: did you send out the link which ready for review? | 10:01 |
| eliqiao_pc | alex_xu: this is the link for all bugs #link https://etherpad.openstack.org/p/hackathon2_nova_list | 10:02 |
| *** haomaiwa_ has joined #openstack-nova | 10:02 | |
| eliqiao_pc | do we need to indentify those +1/+2 's one? | 10:02 |
| alex_xu | eliqiao_pc: cool, maybe an email also worth | 10:03 |
| eliqiao_pc | alex_xu: yeah, good idea. | 10:03 |
| johnthetubaguy | +1 for a mail to the ML | 10:03 |
| johnthetubaguy | eliqiao_pc: it would be good if you can add in there which ones have a +1 from folks at the hackathon | 10:03 |
| johnthetubaguy | (you know which ones had some -1s from folks they got fixed up, and now have +1s) | 10:04 |
| *** rook has joined #openstack-nova | 10:04 | |
| *** dims has joined #openstack-nova | 10:05 | |
| eliqiao_pc | johnthetubaguy: okay, I will try to indentify those +1s ones. | 10:06 |
| *** matrohon has quit IRC | 10:08 | |
| andrearosa | johnthetubaguy: it woudl be nice to have the same thing here in europe, with the low-cost it shouldn't be hard to get a bunch of ppl for a couple of days in the same place | 10:08 |
| johnthetubaguy | andrearosa: its a good plan, I am thinking about how to deal with the next midcyle, this could be a good way to get something in europe | 10:09 |
| *** aix has quit IRC | 10:10 | |
| andrearosa | johnthetubaguy: definitively | 10:10 |
| *** xgsa has quit IRC | 10:11 | |
| *** jcoufal has quit IRC | 10:11 | |
| johnthetubaguy | andrearosa: I got a few folks suggesting some HP offices in bristol, as one possiblity | 10:13 |
| johnthetubaguy | andrearosa: what about a joint Nova and Neutron hackathon/review-athon? | 10:13 |
| *** gszasz has joined #openstack-nova | 10:16 | |
| lxsli | sounds great to me | 10:19 |
| lxsli | andrearosa + I both work at HP Bristol :) | 10:19 |
| *** aix has joined #openstack-nova | 10:22 | |
| *** lpetrut has joined #openstack-nova | 10:28 | |
| openstackgerrit | Alexis Lee proposed openstack/nova: Add some tests for map_dev https://review.openstack.org/215568 | 10:29 |
| johnthetubaguy | mriedem_away: there is this one that needs a look, I know what you mean about it being refactor time, and I don't like the use case, and its really a feature, but I can't bring myself to block it or approve it, for some reason: https://review.openstack.org/#/c/190047/11 | 10:32 |
| *** jwcroppe has joined #openstack-nova | 10:36 | |
| *** fawadkhaliq has joined #openstack-nova | 10:36 | |
| andrearosa | johnthetubaguy: sorry was in a meeting. any particular reason for having Nova + Neutron? by the time the next mid-cycle I think Cinder will have a lot of work in progress in redesign their API so having Nova + Cinder woudl be nice | 10:39 |
| *** shyama has quit IRC | 10:39 | |
| johnthetubaguy | andrearosa: true, or all three, more of a random pick really, to get a good group of folks | 10:40 |
| *** lyanchih has quit IRC | 10:40 | |
| *** shyama has joined #openstack-nova | 10:42 | |
| *** jwcroppe has quit IRC | 10:44 | |
| *** eliqiao_pc has quit IRC | 10:44 | |
| *** jwcroppe has joined #openstack-nova | 10:45 | |
| *** lpetrut1 has joined #openstack-nova | 10:45 | |
| *** lyanchih has joined #openstack-nova | 10:46 | |
| *** alex_klimov has quit IRC | 10:46 | |
| *** lpetrut has quit IRC | 10:46 | |
| johnthetubaguy | alex_xu: gmann: doesn't the validator produce a possible 400 error? Or am I missing something here? https://review.openstack.org/#/c/203930/3 | 10:48 |
| *** jwcroppe has quit IRC | 10:49 | |
| *** fawadkhaliq has quit IRC | 10:51 | |
| *** haigang has joined #openstack-nova | 10:52 | |
| *** rotbeard has quit IRC | 10:53 | |
| *** shyu has quit IRC | 10:55 | |
| *** rotbeard has joined #openstack-nova | 10:57 | |
| *** shyama has quit IRC | 10:57 | |
| *** alex_klimov has joined #openstack-nova | 10:57 | |
| *** lpetrut has joined #openstack-nova | 10:57 | |
| *** lpetrut1 has quit IRC | 10:58 | |
| *** fawadkhaliq has joined #openstack-nova | 10:59 | |
| openstackgerrit | Dheeraj Gupta proposed openstack/nova: Creates flavor* tables in API database https://review.openstack.org/201606 | 11:00 |
| *** haomaiwa_ has quit IRC | 11:01 | |
| *** haomaiwang has joined #openstack-nova | 11:02 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Add rootwrap daemon mode support https://review.openstack.org/180695 | 11:02 |
| *** davideag_ has quit IRC | 11:03 | |
| *** shyama has joined #openstack-nova | 11:04 | |
| *** salv-orlando has joined #openstack-nova | 11:06 | |
| *** moshele has quit IRC | 11:08 | |
| *** y_sawai_ has quit IRC | 11:09 | |
| *** VikasC has joined #openstack-nova | 11:11 | |
| openstackgerrit | John Garbutt proposed openstack/nova: api: deprecate the concept of extensions in v2.1 https://review.openstack.org/214592 | 11:11 |
| VikasC | Hi Folks | 11:12 |
| VikasC | Can you please review https://review.openstack.org/#/c/213692/3 | 11:12 |
| openstackgerrit | John Garbutt proposed openstack/nova: api: deprecate the api v2 extension configuration https://review.openstack.org/214601 | 11:13 |
| *** LukeHinds has quit IRC | 11:14 | |
| *** dheeraj has joined #openstack-nova | 11:16 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Run using rootwrap daemon as True https://review.openstack.org/180809 | 11:18 |
| *** lyanchih has quit IRC | 11:18 | |
| *** takedakn has quit IRC | 11:19 | |
| *** dheeraj has left #openstack-nova | 11:19 | |
| *** sudipto has quit IRC | 11:19 | |
| *** romainh has joined #openstack-nova | 11:27 | |
| *** smatzek has joined #openstack-nova | 11:28 | |
| *** thorst has joined #openstack-nova | 11:31 | |
| *** dprince has joined #openstack-nova | 11:35 | |
| lxsli | There's a spec up about quota-by-flavor I've been reviewing: https://review.openstack.org/#/c/206160 | 11:36 |
| lxsli | For non-Ironic cases I'd prefer quota-by-resource; but if that doesn't work for Ironic, maybe we need both? | 11:36 |
| lxsli | An opinion from someone who understands this stuff well would be very helpful | 11:37 |
| johnthetubaguy | lxsli: have you spoken to alaski about his idea of quota per flavor class? | 11:37 |
| lxsli | johnthetubaguy: nope, will do ty | 11:37 |
| johnthetubaguy | lxsli: I am trying to avoid spec reviews right now, to move the needle on the number of bug fixes we can get into liberty (and get API v2 and API extensions deprecated, ideally) | 11:38 |
| lxsli | sure thing | 11:38 |
| *** sudipto has joined #openstack-nova | 11:38 | |
| lxsli | btw about phabricator etc. I'm not sure I'm the right person to help with that, sorry | 11:38 |
| lxsli | I don't think I understand our requirements well enough and I kinda have enough on my plate too | 11:39 |
| johnthetubaguy | lxsli: no worries, appreciate you considering it | 11:39 |
| johnthetubaguy | yeah, its quite a big thing to chew on, sadly | 11:39 |
| lxsli | It's a tricky one because you need someone right in the thick of things to understand the reqs; but those people tend to be super busy already | 11:40 |
| *** haomaiwang has quit IRC | 11:42 | |
| *** markus_z has quit IRC | 11:44 | |
| *** sayali has quit IRC | 11:44 | |
| *** sayali has joined #openstack-nova | 11:45 | |
| lxsli | a core's intern might be quite suitable | 11:45 |
| *** jwcroppe has joined #openstack-nova | 11:45 | |
| alex_xu | johnthetubaguy: validatorerror is raise up to wsgi stack, then wsgi stack convert it to 400 https://github.com/openstack/nova/blob/master/nova/api/openstack/extensions.py#L498 | 11:49 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add project-id when list server-groups https://review.openstack.org/209018 | 11:55 |
| *** fawadkhaliq has quit IRC | 11:57 | |
| *** fawadkhaliq has joined #openstack-nova | 11:57 | |
| *** ociuhandu has joined #openstack-nova | 11:59 | |
| *** jcoufal has joined #openstack-nova | 12:03 | |
| *** ociuhandu has quit IRC | 12:04 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add UniqueConstraint for quota usages table https://review.openstack.org/212908 | 12:06 |
| *** deepakcs has quit IRC | 12:09 | |
| *** asettle has joined #openstack-nova | 12:09 | |
| lxsli | Does anyone know of any introductory doc on cells code please? | 12:11 |
| *** claudiub has joined #openstack-nova | 12:11 | |
| *** jwcroppe has quit IRC | 12:12 | |
| *** ociuhandu has joined #openstack-nova | 12:13 | |
| johnthetubaguy | lxsli: its in devref, I think | 12:16 |
| *** edleafe is now known as figleaf | 12:16 | |
| *** tojuvone has quit IRC | 12:17 | |
| johnthetubaguy | lxsli: hmm, so that might be more cells v2 http://docs.openstack.org/developer/nova/cells.html | 12:17 |
| johnthetubaguy | lxsli: I remember alaski had something for prereading at the summit, not totally sure where that is now | 12:18 |
| lxsli | johnthetubaguy: I'll add it to the list of things I need to ask him about :) | 12:18 |
| johnthetubaguy | lxsli: its is cells v1 you are wanting to know about, or cells v2? | 12:19 |
| lxsli | cells v1 | 12:19 |
| johnthetubaguy | lxsli: I can answer some questions, if that helps get your answer quicker | 12:19 |
| *** alejandrito has joined #openstack-nova | 12:20 | |
| lxsli | let me try and work out a good question and get back to you, thank you | 12:20 |
| *** rajesht has quit IRC | 12:21 | |
| lxsli | if you have 2mins, could you give a first impression on if this sort of thing is useful please? http://docs-draft.openstack.org/67/210467/3/check/gate-nova-docs/1bf8692//doc/build/html/trace.html | 12:21 |
| *** yassine has quit IRC | 12:22 | |
| lxsli | not a full review just an indication | 12:22 |
| *** venkat_p has quit IRC | 12:22 | |
| *** ahilan has joined #openstack-nova | 12:23 | |
| johnthetubaguy | lxsli: I actually approved a summit talk that goes through this "the flow of a create server request" or something like that | 12:23 |
| johnthetubaguy | lxsli: its handy | 12:24 |
| lxsli | johnthetubaguy: okay thanks! I'll try to extend it for cells v1 then | 12:24 |
| johnthetubaguy | maybe, I just not sure I want us to document cells v1 too much now, given we plan to delete it, but I guess its useful to help maintain things | 12:25 |
| *** vivekd has quit IRC | 12:26 | |
| *** VikasC has quit IRC | 12:26 | |
| lxsli | it's useful as an exercise for me anyway; and if there's doc we can tell alaski to fix it for cells v2 | 12:27 |
| *** kiran-r has joined #openstack-nova | 12:29 | |
| *** yassine has joined #openstack-nova | 12:30 | |
| *** edmondsw has joined #openstack-nova | 12:31 | |
| *** aysyd has joined #openstack-nova | 12:37 | |
| *** Marga_ has quit IRC | 12:38 | |
| *** Marga_ has joined #openstack-nova | 12:38 | |
| *** rfolco has joined #openstack-nova | 12:39 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: WIP: Hyper-V: adds oslo.windows library https://review.openstack.org/212102 | 12:40 |
| *** ijuwang has joined #openstack-nova | 12:44 | |
| *** VW_ has joined #openstack-nova | 12:44 | |
| *** abhirc has joined #openstack-nova | 12:44 | |
| *** Murali has quit IRC | 12:45 | |
| *** VW_ has quit IRC | 12:48 | |
| *** VW_ has joined #openstack-nova | 12:49 | |
| *** kiran-r has quit IRC | 12:49 | |
| *** kiran-r has joined #openstack-nova | 12:50 | |
| *** sayali has quit IRC | 12:51 | |
| *** exploreshaifali has joined #openstack-nova | 12:52 | |
| *** jichen has joined #openstack-nova | 12:53 | |
| dims | johnthetubaguy: oslo.rootwrap daemon is ready with the changes you requested - https://review.openstack.org/#/c/180695/ | 12:53 |
| johnthetubaguy | lxsli: cells v2 is totally different to cells v1 though, basically cells v2 just means you know about the two databases (API vs Compute database) and that there is logic to choose which RPC queue and database is used for the specific compute node, and that kind of thing | 12:53 |
| *** VW_ has quit IRC | 12:53 | |
| johnthetubaguy | dims: sweet, I will take another look now | 12:54 |
| *** ankit_ag has quit IRC | 12:54 | |
| *** sayali has joined #openstack-nova | 12:56 | |
| dims | thanks! john | 12:56 |
| lxsli | johnthetubaguy: OK I don't know anything about cells v2 | 13:00 |
| openstackgerrit | Alexis Lee proposed openstack/nova: Wait for device to be mapped https://review.openstack.org/215613 | 13:00 |
| lxsli | I'd planned to avoid it but that seems impossible if I want to touch the API | 13:00 |
| johnthetubaguy | lxsli: yeah, thats true, thats mostly why we are going for cells v2 (where everyone uses cells by default) rather than cells v1 (where there are two code paths to maintain) | 13:01 |
| johnthetubaguy | dims: I have a feeling that root wrap deamon is missing some unit tests, totally missed that before :( | 13:01 |
| *** dustins has joined #openstack-nova | 13:02 | |
| johnthetubaguy | dims: looking more closely, maybe we are just missing an assert for one that does trigger a retry, I am not sure? | 13:05 |
| *** mdrabe has joined #openstack-nova | 13:05 | |
| dims | johnthetubaguy: ack, will add an assert for the retry loop. | 13:05 |
| *** jecarey has joined #openstack-nova | 13:06 | |
| johnthetubaguy | dims: thank you | 13:06 |
| *** abhishekk has quit IRC | 13:06 | |
| johnthetubaguy | dims: I wonder if we should have something that checks all those process utils args get passed through, as well? | 13:06 |
| *** amotoki has joined #openstack-nova | 13:06 | |
| dims | johnthetubaguy: good point, ack | 13:07 |
| *** cfriesen has joined #openstack-nova | 13:07 | |
| openstackgerrit | Alexis Lee proposed openstack/nova: Wait for device to be mapped https://review.openstack.org/215613 | 13:07 |
| *** dave-mccowan has joined #openstack-nova | 13:08 | |
| *** shoutm has joined #openstack-nova | 13:08 | |
| *** Piet has quit IRC | 13:10 | |
| *** cfriesen has quit IRC | 13:10 | |
| *** haigang has quit IRC | 13:10 | |
| *** cfriesen has joined #openstack-nova | 13:11 | |
| *** jecarey has quit IRC | 13:12 | |
| *** agireud has joined #openstack-nova | 13:13 | |
| *** salv-orlando has quit IRC | 13:15 | |
| *** salv-orlando has joined #openstack-nova | 13:15 | |
| *** agireud has quit IRC | 13:15 | |
| *** agireud has joined #openstack-nova | 13:16 | |
| *** dims has quit IRC | 13:16 | |
| *** dims has joined #openstack-nova | 13:17 | |
| *** asettle has quit IRC | 13:17 | |
| *** agireud has quit IRC | 13:17 | |
| *** VW_ has joined #openstack-nova | 13:18 | |
| *** dane-fichter has joined #openstack-nova | 13:20 | |
| *** jwcroppe has joined #openstack-nova | 13:23 | |
| *** _kiran_ has joined #openstack-nova | 13:24 | |
| *** kiran-r has quit IRC | 13:26 | |
| *** mriedem_away is now known as mriedem | 13:27 | |
| mriedem | johnthetubaguy: i'm not crazy about https://review.openstack.org/#/c/190047/ | 13:27 |
| *** thangp has joined #openstack-nova | 13:28 | |
| mriedem | johnthetubaguy: there, i -1ed it :) | 13:28 |
| johnthetubaguy | mriedem: yeah, I was re-reading your previous comments and really starting to agree with you | 13:29 |
| *** _kiran_ has quit IRC | 13:29 | |
| mriedem | my main complaint is how gorpy and ugly that method is becoming | 13:29 |
| mriedem | with so many conditionals | 13:29 |
| *** nkrinner has quit IRC | 13:29 | |
| mriedem | i'd prefer to see that all abstracted off somewhere | 13:29 |
| mriedem | if rlrossit were around i'd point him at it | 13:29 |
| *** jwcroppe has quit IRC | 13:30 | |
| johnthetubaguy | yeah, it needs some love, but I felt bad blocking on that, although I am not that excited about the feature its adding, seems to legitimise admins doing things outside of Nova | 13:30 |
| mriedem | yes, that was the other thing i didn't like about this | 13:30 |
| mriedem | i had pointed out that you can disable the sync task and the lifecycle event task if you don't want those automatically shutting down your instances | 13:31 |
| mriedem | but garyk said he didn't like just disabling them | 13:31 |
| mriedem | because then you lose debug of what's going on | 13:32 |
| mriedem | even though the vmware driver doesn't implement the lifecycle stuff | 13:32 |
| johnthetubaguy | hmm, good point, whats left after you disable the sync task... | 13:33 |
| *** kmARC_ has joined #openstack-nova | 13:33 | |
| *** kmARC_ has quit IRC | 13:34 | |
| alaski | lxsli: there isn't really much in the way of docs for cells v1, just some really really old slides from comstud floating around somewhere | 13:36 |
| *** alaski is now known as lascii | 13:36 | |
| *** lxsli is now known as lexloofah | 13:37 | |
| lexloofah | lascii: morning! thanks. What about quota_by_flavor? | 13:38 |
| *** haigang has joined #openstack-nova | 13:38 | |
| lascii | lexloofah: that's on my backlog to write up, but the general idea is to add a grouping mechanism to flavors (which we've called a flavor class so far) and then add quotas to that | 13:39 |
| lascii | that's a bit more flexible than doing it directly on flavors | 13:39 |
| lexloofah | Yahoo have a proposal here: https://review.openstack.org/#/c/206160/ | 13:39 |
| lexloofah | I'm not mad about doing it by flavors at all - by resources as Joanna suggested seems much smarter | 13:39 |
| lexloofah | but Meghal says that doesn't work for Ironic? Which is icky | 13:40 |
| johnthetubaguy | lascii: I have a feeling I saw jroll pushed some code for part of the flavor group thing, but not 100% sure if my brain is remembering that correctly (I think I dutifully -2-ed the patch) | 13:40 |
| lascii | johnthetubaguy: he pushed up something that used it, a scheduler filter I think. since our implementation is just flavor extra specs it requires no additional code to use that | 13:41 |
| jroll | johnthetubaguy: I put a flavor class scheduler filter up because someone wanted to see the code and it was the easiest way :P | 13:41 |
| johnthetubaguy | lexloofah: I think there are quotas scoped by groups of flavors and quotas around flavor counts (although they are very related) | 13:41 |
| johnthetubaguy | jroll: I figured that might be why, and thats totally cool :) | 13:41 |
| *** apuimedo_ has joined #openstack-nova | 13:41 | |
| jroll | someone is more than welcome to take that patch and run with it :) | 13:42 |
| lascii | lexloofah: there are a lot of comments on this review, what specifically is meant by a resource? | 13:42 |
| lexloofah | lascii: check the ones on line 134 | 13:42 |
| lexloofah | lascii: I'm concerned that with quota-by-flavor it's hard to tell how much actual EG disk is allowed | 13:43 |
| mriedem | johnthetubaguy: left some more comments in https://review.openstack.org/#/c/190047/ | 13:43 |
| mriedem | johnthetubaguy: basically the only case that i think is potentially bad in that sync method is when nova thinks the instance is stopped but the hypervisor says it's running, so nova stops it, | 13:43 |
| *** jecarey has joined #openstack-nova | 13:44 | |
| *** jcoufal has quit IRC | 13:44 | |
| lexloofah | when writing examples to illustrate the effects, it's been really easy to make mistakes and over- or under-deliver and I think that's a terrible omen | 13:44 |
| mriedem | everything else is just syncing nova up with the hypervisor, i.e. the case where nova says it's active but the hypervisor says it's stopped, so nova stops it and syncs up the nova db | 13:44 |
| mriedem | kylek3h: want to review https://review.openstack.org/#/c/190047/ again? | 13:44 |
| mriedem | lascii: dansmith: ^ could probably use more core input there too | 13:45 |
| *** Piet has joined #openstack-nova | 13:45 | |
| *** agireud has joined #openstack-nova | 13:45 | |
| kylek3h | mriedem: Sure. I'll take a look. | 13:46 |
| *** dansmith is now known as superdan | 13:47 | |
| lascii | mriedem: will take a look. the stop case is assuming that if Nova thinks the instance is stopped then the user intended to stop it, so it makes it so on the hypervisor | 13:47 |
| mriedem | lascii: yeah, that's one assumption | 13:48 |
| mriedem | there is this other that the admin is stopping things outside of nova | 13:48 |
| *** browne has joined #openstack-nova | 13:49 | |
| *** diogogmt has joined #openstack-nova | 13:49 | |
| lascii | admins shouldn't be doing that | 13:49 |
| mriedem | that's what i said | 13:49 |
| *** ctrath has joined #openstack-nova | 13:50 | |
| *** diogogmt has quit IRC | 13:50 | |
| jroll | lascii: mriedem idk about virt, but if a user runs "shutdown" inside the instance on baremetal, we hit the same condition | 13:50 |
| mriedem | i guess my main point is if you don't want this thing turning off your instances, disable the task | 13:50 |
| *** abhirc has quit IRC | 13:50 | |
| *** vikram__ has joined #openstack-nova | 13:51 | |
| mriedem | jroll: that would be the case with any of them | 13:51 |
| jroll | I didn't realize you could disable the task though :) | 13:51 |
| mriedem | jroll: if i boot an instance via libvirt via nova, but then use virsh to stop the instance, | 13:51 |
| mriedem | nova will sync that up and stop it via this task in the nova database and api | 13:51 |
| mriedem | then if i restart the instance with virsh, nova will sync and stop it again | 13:51 |
| mriedem | basically saying, 'f you, use the nova-api, gdi' | 13:52 |
| *** diogogmt has joined #openstack-nova | 13:52 | |
| jroll | mmm, right, an admin needs to kick the restart to actually hit this | 13:52 |
| *** romainh has left #openstack-nova | 13:52 | |
| lascii | yeah, a user couldn't do that | 13:52 |
| mriedem | all periodic tasks can be disabled | 13:52 |
| *** ssurana has joined #openstack-nova | 13:52 | |
| mriedem | and with https://review.openstack.org/#/c/190047/ you can disable the lifecycle event handling stuff which also hits this sync code | 13:52 |
| mriedem | but only libvirt and hyperv implement the lifecycle event code | 13:53 |
| lascii | my feeling is that if an admin does something outside of Nova and it causes unexpected behavior it's not a bug | 13:53 |
| mriedem | oops not that one | 13:53 |
| mriedem | this one https://review.openstack.org/#/c/159275/ | 13:53 |
| jroll | lascii: yeah, this is an annoying and unexpected thing if you're standing nova up for the first time, or debugging or whatever | 13:54 |
| jroll | but I agree | 13:54 |
| mriedem | i think the only thing that garyk might have had a point on was some vmware HA cluster scenario | 13:55 |
| mriedem | but it's not really articulated | 13:55 |
| mriedem | just says 'HA events, etc' | 13:55 |
| *** aysyd has quit IRC | 13:55 | |
| lascii | I'm not against making the experience better, but with the complexity of that method that mriedem has pointed out it does seem worth finding a better approach even if that takes more time | 13:55 |
| mriedem | i guess if the problem is a race with HA failovers, then i'd say if you're going to run HA that hits this problem, disable the task | 13:56 |
| mriedem | so maybe, | 13:56 |
| *** eharney has joined #openstack-nova | 13:56 | |
| *** eharney has quit IRC | 13:56 | |
| mriedem | instance is running on host A, it's stopped and restarted on host B, | 13:56 |
| *** eharney has joined #openstack-nova | 13:56 | |
| mriedem | nova syncs up when it's stopped on host A and marks the db as stopped, | 13:57 |
| mriedem | nova syncs up again after it's running on host B and says i think you're stopped but vmware says you're running, i'm going to stop you | 13:57 |
| *** apuimedo_ has quit IRC | 13:57 | |
| superdan | well, the deal is, | 13:57 |
| *** aysyd has joined #openstack-nova | 13:57 | |
| mriedem | there is a host check at the top of the method though | 13:57 |
| superdan | running two nova computes against a single hypervisor endpoint is something we definitely don't optimize for right now | 13:57 |
| mriedem | if self.host != db_instance.host: | 13:58 |
| mriedem | return | 13:58 |
| jroll | "don't optimize for" is an interesting way to spell "think is insane" :) | 13:58 |
| *** agireud has quit IRC | 13:58 | |
| *** ahilan has quit IRC | 13:58 | |
| *** vikram__ has quit IRC | 13:59 | |
| lexloofah | I like "suboptimal" | 14:00 |
| mriedem | superdan: and i guess https://review.openstack.org/#/c/103916 should help avoid that | 14:00 |
| mriedem | oh look who just recently merged that :) | 14:00 |
| superdan | mriedem: not really related actually | 14:01 |
| mriedem | oh, i figured that was related to the 1:M case | 14:01 |
| superdan | no, that's the N:M case | 14:03 |
| superdan | which is even more insane :D | 14:04 |
| lascii | lexloofah: I'm not sure I like the idea of quotas on resources. But I see the issue that joanna is attempting to solve and I wonder if attaching a target to the quota would help. so a quota could be flavor_class:AZ, which would prevent needing to redifine flavors per AZ | 14:04 |
| mriedem | superdan: oh sweet, a web | 14:04 |
| *** garyk has joined #openstack-nova | 14:04 | |
| mriedem | where vmware is the spider and i'm the fly | 14:05 |
| superdan | heh | 14:05 |
| *** VikasC has joined #openstack-nova | 14:07 | |
| lexloofah | lascii: I didn't quite follow what a flavor_class is | 14:08 |
| lascii | just a grouping of flavors, for now s/flavor_class/flavor/ and the meaning is essentially the same | 14:08 |
| lexloofah | so you could have a "standard" flavor class and an "ssd" flavor class? with EG ssd.tiny, ssd.small etc within those | 14:09 |
| lascii | lexloofah: exactly | 14:09 |
| *** tpeoples has joined #openstack-nova | 14:10 | |
| lexloofah | lascii: yes that helps - on similar lines I was thinking of tenant groups | 14:10 |
| lexloofah | lascii: so you'd have "silver" and "gold" tenant group, with associated quota caps | 14:10 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add project-id when list server-groups https://review.openstack.org/209018 | 14:11 |
| lexloofah | these both normalise the model, reducing admin overhead | 14:11 |
| *** ahilan has joined #openstack-nova | 14:11 | |
| lascii | lexloofah: yeah, I could see that being useful | 14:11 |
| *** takedakn has joined #openstack-nova | 14:11 | |
| lexloofah | may I ask why you don't like quotas on resources? | 14:12 |
| lascii | it's disconnected from the way we actually consume resources. it would be easy to get to a spot where there's a lot of one resource left and no way to consume it | 14:13 |
| figleaf | lascii: so 'flavor_class' is like a 'flavor_aggregate'? | 14:13 |
| lascii | lexloofah: that being said, I'm not totally against it, but I would see it as a cap on top of flavor quotas | 14:14 |
| lexloofah | figleaf: I don't know why of all the million words we have for class/group we started to use aggregate >.< | 14:14 |
| figleaf | lexloofah: heh | 14:14 |
| *** salv-orlando has quit IRC | 14:14 | |
| figleaf | lexloofah: yeah, but that's the predominate term now in nova | 14:15 |
| lascii | figleaf: possibly? aggregate is so overloaded I'm not exactly sure what it means | 14:15 |
| *** jang has quit IRC | 14:15 | |
| figleaf | lascii: oh, and 'class' is less overloaded? :) | 14:15 |
| lascii | touche | 14:15 |
| figleaf | lascii: meaning "a group of things" | 14:16 |
| lascii | yeah, it's like that. I think 'class' implies a bit of a relation between them rather than a random grouping, but yeah same thing | 14:17 |
| *** VikasC has quit IRC | 14:17 | |
| *** takedakn has quit IRC | 14:17 | |
| figleaf | lascii: well, yeah, the idea is to have the groupings make sense. But from a code POV, they are arbitrary | 14:18 |
| figleaf | lascii: meaning you can create a group/class along any criteria you like. | 14:18 |
| lascii | yep | 14:19 |
| figleaf | lascii: and nova won't say "WTF, they don't belong together!" | 14:19 |
| lascii | I'm not too attached to a name, we just use flavor_class internally already | 14:19 |
| lexloofah | fwiw I hate the word aggregate, it's a silly way to say "group" | 14:19 |
| figleaf | lascii: understood | 14:19 |
| figleaf | lexloofah: me too, but I hate adding even more terms to mean the same thing even more | 14:20 |
| lexloofah | group is already part of standard English though, you can assume people know it | 14:20 |
| lascii | I actually think of it more like a scope, but that may be even more confusing to use as a term | 14:20 |
| figleaf | I don't care too much about which term is used; I do care about creating lots of different terms to represent the same concept | 14:21 |
| *** lpetrut has quit IRC | 14:21 | |
| *** haigang has quit IRC | 14:21 | |
| *** penick has joined #openstack-nova | 14:21 | |
| lexloofah | anyway - flavors help match resource consumption to usage while they're symmetric | 14:22 |
| lexloofah | if we put quota-per-flavor in, it'll become challenging to plan capacity with asymmetric flavors | 14:22 |
| *** dannywilson has joined #openstack-nova | 14:22 | |
| lexloofah | whereas quota-per-resource is very simple | 14:23 |
| lexloofah | and operators are free to design their quota-per-resource as multiples of their common flavors | 14:23 |
| *** garyk has quit IRC | 14:23 | |
| openstackgerrit | Pavel Kholkin proposed openstack/nova: Removed duplicated keys in dictionary https://review.openstack.org/215658 | 14:23 |
| lexloofah | by symmetric I mean all flavors maintain a common ratio between vcpu:ram:disk:etc | 14:24 |
| openstackgerrit | Cale Rath proposed openstack/nova: Purge soft-deleted instances cmd https://review.openstack.org/203751 | 14:25 |
| *** tpeoples has quit IRC | 14:25 | |
| *** smatzek_ has joined #openstack-nova | 14:25 | |
| *** garyk has joined #openstack-nova | 14:25 | |
| *** diogogmt has quit IRC | 14:26 | |
| *** haomaiwang has joined #openstack-nova | 14:26 | |
| *** rdopiera has joined #openstack-nova | 14:27 | |
| *** agireud has joined #openstack-nova | 14:27 | |
| *** agireud has quit IRC | 14:28 | |
| *** smatzek_ has quit IRC | 14:28 | |
| lascii | I really think we need a more powerful quota engine what operates much like the policy engine. let operators define what they want to track against a quota, and define arbitrary quotas. | 14:28 |
| *** garyk has quit IRC | 14:28 | |
| lascii | rather than hardcoded all the things people may want to track | 14:29 |
| johnthetubaguy | lascii: +1 | 14:29 |
| openstackgerrit | John Garbutt proposed openstack/nova: docs: add the concept of Feature Classifcation https://review.openstack.org/215664 | 14:29 |
| johnthetubaguy | lascii: and one that works | 14:29 |
| lascii | though the prospect of that with our current quota issues/complexity scares me a bit | 14:29 |
| johnthetubaguy | lascii: +1 | 14:29 |
| lexloofah | would it be fair to Meghal to -2 the spec then, saying this needs a bigger solution? | 14:30 |
| *** scheuran has quit IRC | 14:30 | |
| *** diogogmt has joined #openstack-nova | 14:31 | |
| *** tonytan4ever has joined #openstack-nova | 14:32 | |
| *** lpetrut has joined #openstack-nova | 14:32 | |
| *** mdrabe has quit IRC | 14:33 | |
| *** VikasC has joined #openstack-nova | 14:34 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Add rootwrap daemon mode support https://review.openstack.org/180695 | 14:34 |
| *** mtanino has joined #openstack-nova | 14:35 | |
| openstackgerrit | Tristan Cacqueray proposed openstack/nova: virt: Use preexec_fn to ulimit qemu-img info call https://review.openstack.org/209627 | 14:36 |
| *** takedakn has joined #openstack-nova | 14:36 | |
| lascii | lexloofah: I'm not sure a -2 is necessary at this point, but what I might suggest is to think about bringing this up at the summit if possible | 14:36 |
| lexloofah | OK, cheers | 14:36 |
| *** sudipto has quit IRC | 14:37 | |
| *** VikasC has quit IRC | 14:39 | |
| *** rdopiera has quit IRC | 14:40 | |
| *** fawadkhaliq has quit IRC | 14:41 | |
| *** xyang1 has joined #openstack-nova | 14:42 | |
| lexloofah | lascii: one more question, about something completely different, if you'd be so kind | 14:42 |
| lexloofah | when nova/cells/rpcapi.py makes an RPC call, what receives that call? | 14:43 |
| *** exploreshaifali has quit IRC | 14:43 | |
| lascii | nova/cells/manager.py | 14:43 |
| lascii | here's a qquick breakdown: | 14:43 |
| lascii | cells/rpcapi.py is for nova-api or nova-compute to send an rpc to nova-cells in the same cell | 14:44 |
| lexloofah | I've figured out the ComputeCellsAPI side now | 14:44 |
| lascii | nova-cells uses cells/messaging.py to communicate between cells | 14:44 |
| *** zul has quit IRC | 14:44 | |
| lascii | that's basically it | 14:45 |
| *** dannywilson has quit IRC | 14:45 | |
| lascii | so rpcapi.py -> manager.py, messaging.py -> messaging.py | 14:45 |
| *** dannywilson has joined #openstack-nova | 14:45 | |
| lexloofah | Great | 14:45 |
| *** zul has joined #openstack-nova | 14:46 | |
| lexloofah | is there a way to tell from the code that cells/rpcapi.py -> cells/manager.py ? | 14:46 |
| lascii | you could possibly look at the way oslo_messaging is setup there and maybe tie them together, I'm not really sure | 14:47 |
| lascii | it's just the convention we have in nova for rpcapi to go to a manager | 14:47 |
| lexloofah | OK thanks | 14:47 |
| openstackgerrit | Alexander Schmidt proposed openstack/nova: WIP libvirt: Acquire TCP ports for console during live migration https://review.openstack.org/215102 | 14:51 |
| *** mdrabe has joined #openstack-nova | 14:52 | |
| *** alexschm has quit IRC | 14:54 | |
| *** Nikolay_St has quit IRC | 14:56 | |
| *** jwcroppe has joined #openstack-nova | 14:57 | |
| *** zzzeek has joined #openstack-nova | 14:57 | |
| *** jwcroppe has quit IRC | 14:59 | |
| *** jwcroppe has joined #openstack-nova | 14:59 | |
| *** haomaiwang has quit IRC | 15:01 | |
| *** yamahata has joined #openstack-nova | 15:01 | |
| *** haomaiwang has joined #openstack-nova | 15:02 | |
| *** r-daneel has joined #openstack-nova | 15:02 | |
| *** garyk has joined #openstack-nova | 15:02 | |
| *** hemnafk is now known as hemna | 15:02 | |
| *** unicell1 has joined #openstack-nova | 15:03 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Make query to quota usage table order preserved. https://review.openstack.org/213584 | 15:03 |
| *** unicell has quit IRC | 15:04 | |
| mriedem | apmelton: well i'll be damned | 15:06 |
| apmelton | mriedem: whats up? | 15:07 |
| mriedem | apmelton: i've got a devstack running with an lvm backed lxc instance using https://review.openstack.org/#/c/215311/ | 15:07 |
| apmelton | awesomeness! | 15:07 |
| mriedem | :) | 15:07 |
| apmelton | mriedem: one thing I was thinking about, if we're gonna be running tempest on top of a nova backed by LVM, we might wanna set https://github.com/openstack/nova/blob/master/nova/virt/libvirt/storage/lvm.py#L35 to none | 15:10 |
| apmelton | otherwise it's gonna spend a ton of time waiting on instance deletes | 15:10 |
| mriedem | apmelton: yeah | 15:11 |
| *** SourabhP has joined #openstack-nova | 15:11 | |
| mriedem | i remember actually pushing a change to devstack to do ignore that on the cinder side as well | 15:12 |
| mriedem | long time ago | 15:12 |
| *** SourabhP_ has joined #openstack-nova | 15:13 | |
| *** SourabhP has quit IRC | 15:16 | |
| *** SourabhP_ is now known as SourabhP | 15:16 | |
| *** haigang has joined #openstack-nova | 15:18 | |
| mriedem | ha, just hit the bug for restarting a stopped lxc instance | 15:18 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1370590/comments/18 | 15:19 |
| openstack | Launchpad bug 1370590 in OpenStack Compute (nova) "Libvirt _create_domain_and_network calls missing disk_info" [High,In progress] - Assigned to Matt Riedemann (mriedem) | 15:19 |
| *** fawadkhaliq has joined #openstack-nova | 15:19 | |
| mriedem | this is a pretty simple fix so that you can reboot lxc instances: https://review.openstack.org/#/c/214925/ | 15:19 |
| mriedem | 9 LOC to fix the bug | 15:19 |
| *** Sree has joined #openstack-nova | 15:21 | |
| *** bapalm has joined #openstack-nova | 15:21 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 15:22 |
| apmelton | mriedem: stopping didn't kill your network this time around? | 15:24 |
| openstackgerrit | Alexis Lee proposed openstack/nova: Walk through the API, Conductor and Compute code https://review.openstack.org/210467 | 15:24 |
| mriedem | apmelton: nope, i think some of the network issues yesterday where either related to (1) nbd or (2) some issues we were having with networking in our internal host running this devstack instance | 15:25 |
| *** VW_ has quit IRC | 15:25 | |
| *** VW_ has joined #openstack-nova | 15:26 | |
| apmelton | mriedem: hmmmm, I know losing public network was an intermittent issue we'd run into in the past running lxc in devstack | 15:26 |
| apmelton | and it was only the public interface | 15:26 |
| apmelton | or rather, it was only the interface being bridged into by nova network | 15:27 |
| apmelton | if it was nbd, I'd think it would just kill all networking | 15:27 |
| mriedem | apmelton: fwiw, i don't set PUBLIC_INTERFACE=eth0 like was in your local.conf | 15:27 |
| apmelton | gotcha | 15:27 |
| apmelton | I'm not sure that's entirely necessary anymore anways | 15:27 |
| apmelton | dunno if you noticed, but that gist was a year old >_> | 15:28 |
| *** SourabhP has quit IRC | 15:28 | |
| mriedem | i didn't :) | 15:28 |
| mriedem | i don't monkey with the networking stuff in my devstack settings, i let it figure it out for me | 15:28 |
| apmelton | mriedem: I'm thinking when I push up the fixes to the lvm/block mount reviews, I'll just rebase on top of https://review.openstack.org/#/c/215342/ | 15:29 |
| apmelton | any reason I shouldn't? | 15:29 |
| mriedem | i think that's a good idea | 15:29 |
| mriedem | we need all of those for this to work | 15:29 |
| mriedem | i'm working on an etherpad to take notes and todos | 15:29 |
| apmelton | aight | 15:30 |
| mriedem | https://etherpad.openstack.org/p/nova-lxc-ci | 15:30 |
| mriedem | you might want to fix that pep8 error too :) | 15:30 |
| apmelton | thanks, really appreciate your help on this | 15:30 |
| apmelton | mriedem: it's fixed :P | 15:30 |
| mriedem | just tell mikal to send me a check | 15:30 |
| apmelton | lmao | 15:30 |
| *** VW_ has quit IRC | 15:30 | |
| *** lyanchih has joined #openstack-nova | 15:36 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add project-id when list server-groups https://review.openstack.org/209018 | 15:36 |
| *** zul has quit IRC | 15:37 | |
| *** Sree has quit IRC | 15:38 | |
| *** artom_ has quit IRC | 15:40 | |
| *** tsekiyama has joined #openstack-nova | 15:41 | |
| *** lyanchih has quit IRC | 15:41 | |
| *** artom has joined #openstack-nova | 15:41 | |
| *** armax has joined #openstack-nova | 15:42 | |
| *** VW_ has joined #openstack-nova | 15:42 | |
| *** mestery has joined #openstack-nova | 15:43 | |
| openstackgerrit | Mike Dorman proposed openstack/nova: Cells v1: Support attach/detach interface and external events https://review.openstack.org/215459 | 15:43 |
| *** mestery is now known as mestery_afk | 15:44 | |
| *** Marga_ has quit IRC | 15:47 | |
| *** takedakn has quit IRC | 15:50 | |
| *** rdopiera has joined #openstack-nova | 15:50 | |
| openstackgerrit | Alexis Lee proposed openstack/nova: Add some tests for map_dev https://review.openstack.org/215568 | 15:52 |
| openstackgerrit | Alexis Lee proposed openstack/nova: Wait for device to be mapped https://review.openstack.org/215613 | 15:52 |
| mriedem | ccarmack: https://etherpad.openstack.org/p/nova-lxc-ci | 15:52 |
| mriedem | fyi | 15:52 |
| mriedem | ctrath: ^ | 15:52 |
| *** lpetrut has quit IRC | 15:53 | |
| *** rushil has joined #openstack-nova | 15:54 | |
| ctrath | ccarmack: do you have cycles for ^^? | 15:54 |
| *** haigang has quit IRC | 15:55 | |
| *** abhirc has joined #openstack-nova | 15:55 | |
| ccarmack | ctrath: yes, I'll take a look | 15:55 |
| ctrath | cool | 15:55 |
| mriedem | ccarmack: the first todo should be relatively straightforward | 15:56 |
| mriedem | just enabling a thing in devstack | 15:56 |
| ccarmack | ok | 15:57 |
| mriedem | i'm going to try a tempest full run on my devstack instance to see how terribly it blows up | 15:57 |
| apmelton | mriedem: I'm rebasing my change on top of your review, but git review ended up needing to rebase on top of master and thus the commits changed slightly | 15:57 |
| apmelton | if I push that up, I can't remember if that's gonna reassign the reviews to me | 15:58 |
| mriedem | i had merge conflicts? | 15:58 |
| mriedem | did you do git review -d? | 15:58 |
| apmelton | no, what's -d? | 15:58 |
| mriedem | :) | 15:58 |
| *** dane-fichter has quit IRC | 15:58 | |
| mriedem | checks out my topic branch | 15:58 |
| mriedem | so if you were starting on a clean master branch | 15:59 |
| mriedem | git review -d 215342 | 15:59 |
| mriedem | that will checkout my topic branch | 15:59 |
| mriedem | and then you could rebase your changes on top of that | 15:59 |
| *** schwicke has joined #openstack-nova | 16:00 | |
| *** Marga_ has joined #openstack-nova | 16:00 | |
| *** haomaiwang has quit IRC | 16:01 | |
| mriedem | apmelton: looks like you got a change up for the disk_info bug a few hours before me | 16:01 |
| mriedem | so i'll drop mine, so then i'll have to rebase | 16:01 |
| apmelton | mriedem: no worries, they are pretty much equivalent | 16:01 |
| openstackgerrit | garyk proposed openstack/nova: Compute: enable admin to decide action for conflicting states https://review.openstack.org/190047 | 16:01 |
| *** armax has quit IRC | 16:02 | |
| apmelton | mriedem: unless there's something in my patch that you think is done better, we can just stick with your branch | 16:02 |
| *** haomaiwang has joined #openstack-nova | 16:02 | |
| mriedem | was just making a comment in yours to do something mine did | 16:02 |
| mriedem | but not a huge deal | 16:03 |
| *** vilobhmm1 has joined #openstack-nova | 16:04 | |
| *** armax has joined #openstack-nova | 16:04 | |
| *** jistr has quit IRC | 16:05 | |
| mriedem | ok, dropped my fix, now i'm going to rebase that series | 16:06 |
| apmelton | mriedem: sounds good | 16:06 |
| *** apuimedo_ has joined #openstack-nova | 16:06 | |
| openstackgerrit | Alexis Lee proposed openstack/nova: Walk through the API, Conductor and Compute code https://review.openstack.org/210467 | 16:07 |
| *** rotbeard has quit IRC | 16:08 | |
| *** thorst has quit IRC | 16:11 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Update obj_reset_changes signatures to match https://review.openstack.org/215358 | 16:12 |
| lascii | superdan: mriedem ^ | 16:13 |
| *** arnaud has joined #openstack-nova | 16:14 | |
| *** arnaud has quit IRC | 16:14 | |
| *** alex_klimov has quit IRC | 16:15 | |
| *** zul has joined #openstack-nova | 16:15 | |
| *** kiran-r has joined #openstack-nova | 16:15 | |
| *** kiran-r has quit IRC | 16:15 | |
| *** apuimedo_ has quit IRC | 16:18 | |
| openstackgerrit | Andrew Melton proposed openstack/nova: libvirt: use proper disk_info in _hard_reboot https://review.openstack.org/214816 | 16:18 |
| *** bauzas is now known as bauwser | 16:19 | |
| apmelton | mriedem: ^ updated, I also included your comments in the test, I think that interaction could use all clarity possible | 16:19 |
| *** penick has quit IRC | 16:19 | |
| *** Apoorva has joined #openstack-nova | 16:22 | |
| *** unicell1 has quit IRC | 16:24 | |
| *** dims is now known as dimsum__ | 16:26 | |
| *** jichen has quit IRC | 16:27 | |
| *** ssurana has quit IRC | 16:27 | |
| *** vilobhmm1 has quit IRC | 16:28 | |
| *** browne has quit IRC | 16:29 | |
| bauwser | johnthetubaguy: meh, I put https://blueprints.launchpad.net/nova/+spec/allocation-ratio-to-resource-tracker against lib-3 but it seems it's the only bp waiting to be merged | 16:29 |
| *** vilobhmm1 has joined #openstack-nova | 16:30 | |
| bauwser | johnthetubaguy: shall I remove the milestone ? how can I make sure that it's tracked, apart from amending the etherpad that I already did ? | 16:30 |
| *** tbh has joined #openstack-nova | 16:31 | |
| *** vilobhmm1 has quit IRC | 16:31 | |
| tbh | johnthetubaguy: thanks for updating the commit message! | 16:31 |
| *** browne has joined #openstack-nova | 16:32 | |
| *** gszasz has quit IRC | 16:32 | |
| *** VW__ has joined #openstack-nova | 16:32 | |
| *** exploreshaifali has joined #openstack-nova | 16:34 | |
| *** thorst has joined #openstack-nova | 16:35 | |
| *** VW_ has quit IRC | 16:36 | |
| *** VW__ has quit IRC | 16:37 | |
| *** schwicke has quit IRC | 16:38 | |
| *** salv-orlando has joined #openstack-nova | 16:38 | |
| *** yanxb_ has quit IRC | 16:39 | |
| *** yanxb_ has joined #openstack-nova | 16:39 | |
| *** browne has quit IRC | 16:41 | |
| *** AlexeyElagin has quit IRC | 16:41 | |
| *** salv-orl_ has joined #openstack-nova | 16:41 | |
| *** smatzek has quit IRC | 16:42 | |
| *** VW_ has joined #openstack-nova | 16:42 | |
| *** derekh has quit IRC | 16:43 | |
| *** Zhang has joined #openstack-nova | 16:44 | |
| *** tbh has quit IRC | 16:44 | |
| *** salv-orlando has quit IRC | 16:44 | |
| *** davideagnello has joined #openstack-nova | 16:49 | |
| *** unicell has joined #openstack-nova | 16:51 | |
| dimsum__ | johnthetubaguy: rootwrap daemon review for Nova with additional tests requested is ready - https://review.openstack.org/#/c/180695/ | 16:51 |
| *** jecarey has quit IRC | 16:52 | |
| bauwser | dimsum__: you do confirm that I need to modify the related opts.py in https://review.openstack.org/#/c/215278/3 ? | 16:53 |
| bauwser | dimsum__: because Jenkins is happy | 16:53 |
| bauwser | dimsum__: so I just wonder how we can test it | 16:53 |
| *** amotoki has quit IRC | 16:53 | |
| johnthetubaguy | dimsum__: your name makes me hungry, but I will take a look at that | 16:54 |
| *** meghal1 has joined #openstack-nova | 16:54 | |
| *** sabari has left #openstack-nova | 16:54 | |
| dimsum__ | haha | 16:54 |
| *** gszasz has joined #openstack-nova | 16:55 | |
| dimsum__ | bauwser: run "tox -e genconfig" it will fail | 16:57 |
| bauwser | dimsum__: so we should gate, nope ? | 16:57 |
| dimsum__ | see scheduler/opts.py it has a reference to nova.scheduler.filters.core_filter.cpu_allocation_ratio_opt | 16:57 |
| bauwser | dimsum__: I do understand the miss, I just think we should cover that | 16:58 |
| *** ssurana has joined #openstack-nova | 16:58 | |
| dimsum__ | bauwser: we haven't gated on config generation for a very long time... +1 to gate | 16:58 |
| *** achanda has joined #openstack-nova | 16:58 | |
| *** zul has quit IRC | 16:59 | |
| *** Marga_ has quit IRC | 17:00 | |
| johnthetubaguy | dimsum__: bauwser: +1 we should totally gate on that | 17:00 |
| johnthetubaguy | dimsum__: it is worth adding a unit test, just to check for a non empty string or something? | 17:00 |
| *** haomaiwang has quit IRC | 17:01 | |
| bauwser | johnthetubaguy: yeah, running tox -egenconfig for gating seems a bit overkill | 17:01 |
| bauwser | dimsum__: it would mean a new job, etc. | 17:01 |
| bauwser | dimsum__: couldn't we just add some tests for that ? | 17:02 |
| *** kiran-r has joined #openstack-nova | 17:02 | |
| *** haomaiwa_ has joined #openstack-nova | 17:02 | |
| dimsum__ | bauwser: johnthetubaguy: https://review.openstack.org/215711 | 17:02 |
| bauwser | that's what I thought when I said 'gating', no real new 'config' job | 17:02 |
| *** vilobhmm1 has joined #openstack-nova | 17:02 | |
| dimsum__ | not sure if you want that | 17:02 |
| *** Nikolay_St has joined #openstack-nova | 17:02 | |
| johnthetubaguy | dimsum__: do other projects do it that way? | 17:03 |
| dimsum__ | johnthetubaguy: only one - manila | 17:03 |
| johnthetubaguy | (just seems a bit wasteful on VMs) | 17:03 |
| bauwser | dimsum__: like I said, that sounds a little footprinting | 17:03 |
| dimsum__ | right | 17:03 |
| bauwser | johnthetubaguy: +1 | 17:03 |
| johnthetubaguy | tempting to just fudge it into the unit test runs, somehow | 17:04 |
| *** VW_ has quit IRC | 17:04 | |
| *** VW_ has joined #openstack-nova | 17:04 | |
| *** abhirc has quit IRC | 17:06 | |
| dimsum__ | johnthetubaguy: just add the "oslo-config-generator --config-file=etc/nova/nova-config-generator.conf" to whichever target in tox.ini say functional | 17:06 |
| dimsum__ | or docs | 17:06 |
| bauwser | so, a simple test like walking thru the code to get the opts.py files and test the imports doesn't sound sufficient ? | 17:07 |
| dimsum__ | that is probably more saner to add it to docs | 17:07 |
| bauwser | dimsum__: why should we gate something external to nova ? | 17:07 |
| *** VW__ has joined #openstack-nova | 17:07 | |
| bauwser | dimsum__: we need to gate the nova-related bits (the interface if you prefer), not the tool itself IMHO | 17:08 |
| *** garyk has quit IRC | 17:08 | |
| dimsum__ | bauwser: what are you talking about? if you see tox.ini genconfig section that's the command used to generate the nova sample config | 17:08 |
| *** shoutm has quit IRC | 17:08 | |
| *** VW_ has quit IRC | 17:08 | |
| dimsum__ | bauwser: i am saying that we should run the tool and fail a job if it fails | 17:08 |
| *** garyk has joined #openstack-nova | 17:08 | |
| bauwser | dimsum__: that genconfig runs oslo-config-generator which is not nova, right? | 17:08 |
| dimsum__ | and docs seems the most closely related job | 17:08 |
| johnthetubaguy | bauwser: I duno, just feels like yet another external dependency, just like other oslo libs that could break the unit tests if they go bad | 17:09 |
| bauwser | dimsum__: docs was the former place for testing that IIRC | 17:09 |
| johnthetubaguy | dimsum__: docs job could output it somewhere useful, that works | 17:09 |
| bauwser | dimsum__: because of the comparison check | 17:09 |
| dimsum__ | y, we should at least run the generator and see if it works fine | 17:09 |
| dimsum__ | which is what would have failed in bauwser's review | 17:10 |
| bauwser | okay fair enough | 17:10 |
| bauwser | add a run in the docs job then | 17:10 |
| bauwser | dimsum__: how are other projects testing that ? are we the only ones who wonder about that ? | 17:11 |
| *** garyk has quit IRC | 17:11 | |
| *** Zhang has quit IRC | 17:11 | |
| *** tjones has joined #openstack-nova | 17:11 | |
| *** Zhang has joined #openstack-nova | 17:11 | |
| *** yamahata has quit IRC | 17:12 | |
| *** Zhang has quit IRC | 17:12 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Fixes snapshoting inexistent VM issue https://review.openstack.org/214560 | 17:12 |
| *** moshele has joined #openstack-nova | 17:12 | |
| *** lsmola has quit IRC | 17:13 | |
| dimsum__ | bauwser: let me check if oslo-config-generator provides proper exit codes | 17:13 |
| superdan | lascii: nice, thanks | 17:15 |
| *** sabari has joined #openstack-nova | 17:16 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Fixes snapshoting inexistent VM issue https://review.openstack.org/214560 | 17:20 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Gate on nova.conf.sample generation https://review.openstack.org/215720 | 17:23 |
| *** moshele has quit IRC | 17:23 | |
| dimsum__ | bauwser: try with ^^ you can see your review will fail in the docs job | 17:23 |
| *** zul has joined #openstack-nova | 17:24 | |
| bauwser | dimsum__: you know what ? I trust you :p | 17:25 |
| dimsum__ | bauwser: like i tell my kids, trust but verify :) here's proof - http://paste.openstack.org/show/423601/ | 17:26 |
| *** browne has joined #openstack-nova | 17:26 | |
| *** albertom has quit IRC | 17:26 | |
| bauwser | johnthetubaguy: you haven't answered my question about the related https://blueprints.launchpad.net/nova/+spec/allocation-ratio-to-resource-tracker , shall I descope it from l-3 ? | 17:26 |
| bauwser | dimsum__: awesomeness | 17:26 |
| johnthetubaguy | bauwser: I didn't know you were asking me a question | 17:26 |
| johnthetubaguy | bauwser: whats the question? | 17:27 |
| bauwser | lol | 17:27 |
| bauwser | johnthetubaguy: no worries at all | 17:27 |
| bauwser | johnthetubaguy: you're so a busy guy and close to the weekend | 17:27 |
| johnthetubaguy | bauwser: where did you ask the question, I am curious? | 17:27 |
| bauwser | johnthetubaguy: so I just targeted https://blueprints.launchpad.net/nova/+spec/allocation-ratio-to-resource-tracker to have the liberty-3 milestone | 17:27 |
| *** gszasz has quit IRC | 17:27 | |
| bauwser | (09:29:45) bauwser: johnthetubaguy: meh, I put https://blueprints.launchpad.net/nova/+spec/allocation-ratio-to-resource-tracker against lib-3 but it seems it's the only bp waiting to be merged | 17:28 |
| johnthetubaguy | bauwser: ah, so we generally only add the target milestone once something has been implemented now, but I you can add it if you want | 17:28 |
| bauwser | johnthetubaguy: I don't want to confuse people | 17:28 |
| bauwser | johnthetubaguy: hence my queston | 17:28 |
| *** albertom has joined #openstack-nova | 17:28 | |
| bauwser | question even | 17:28 |
| dimsum__ | superdan: mriedem: jaypipes: one of you have a bit of time to review https://review.openstack.org/#/c/180695/ (it has john's freshly minted +2) | 17:28 |
| johnthetubaguy | bauwser: there are lots of pending blueprints here: https://blueprints.launchpad.net/nova/liberty | 17:28 |
| *** rushil has quit IRC | 17:29 | |
| *** tonytan4ever has quit IRC | 17:29 | |
| bauwser | johnthetubaguy: okay, leaving it then but feel free to dump it if you wish | 17:30 |
| *** rushil has joined #openstack-nova | 17:30 | |
| *** vivekd has joined #openstack-nova | 17:30 | |
| *** abhirc has joined #openstack-nova | 17:30 | |
| *** yamahata has joined #openstack-nova | 17:33 | |
| *** lpetrut has joined #openstack-nova | 17:34 | |
| mriedem | apmelton: looks good, thanks, +2 | 17:34 |
| mriedem | easy +W here https://review.openstack.org/#/c/214816/ | 17:35 |
| *** bradjones has quit IRC | 17:37 | |
| *** moshele has joined #openstack-nova | 17:38 | |
| *** bradjones has joined #openstack-nova | 17:38 | |
| *** bradjones has quit IRC | 17:38 | |
| *** bradjones has joined #openstack-nova | 17:38 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: add docstring for _get_instance_disk_info https://review.openstack.org/214814 | 17:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: only get bdm in _create_domain_setup_lxc if booted from volume https://review.openstack.org/215342 | 17:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: _create_domain_setup_lxc needs to default disk mapping as a dict https://review.openstack.org/214927 | 17:39 |
| mriedem | apmelton: ^ rebased after dropping that one commit for the bug fix | 17:39 |
| apmelton | mriedem: give me a sec and I'll get the block mount changes on top | 17:39 |
| *** vivekd has quit IRC | 17:43 | |
| *** achanda has quit IRC | 17:44 | |
| openstackgerrit | John Garbutt proposed openstack/nova: docs: add the concept of Feature Classifcation https://review.openstack.org/215664 | 17:44 |
| johnthetubaguy | mriedem: your talk about LXC testing reminding me to try and sit down and write up that idea properly ^ | 17:45 |
| *** penick has joined #openstack-nova | 17:45 | |
| johnthetubaguy | mriedem: would love your thoughts on that general idea | 17:45 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add cpu_allocation_ratio and ram_allocation_ratio to ComputeNode https://review.openstack.org/215471 | 17:45 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Move CPU and RAM allocation ratios to ResourceTracker https://review.openstack.org/215278 | 17:45 |
| mriedem | ok | 17:46 |
| openstackgerrit | Andrew Melton proposed openstack/nova: virt: allow for direct mounting of LocalBlockImages https://review.openstack.org/215311 | 17:46 |
| openstackgerrit | Andrew Melton proposed openstack/nova: libvirt: refactor _create_domain_setup_lxc to use Image.get_model https://review.openstack.org/215310 | 17:46 |
| *** apuimedo has quit IRC | 17:48 | |
| *** aix has quit IRC | 17:49 | |
| mriedem | oh nice http://logs.openstack.org/70/215170/1/check/gate-tempest-dsvm-nova-v21-full/3fdc0d6/logs/screen-n-api.txt.gz?level=TRACE#_2015-08-21_15_39_06_148 | 17:54 |
| *** tonytan4ever has joined #openstack-nova | 17:55 | |
| *** rdopiera has quit IRC | 17:55 | |
| mriedem | superdan: what did we do? ^ | 17:57 |
| mriedem | http://goo.gl/DyP55Y | 17:57 |
| superdan | mriedem: hmm, instance deleted between fetching it and lazy-loading the flavor? | 17:58 |
| mriedem | yeah | 17:58 |
| mriedem | not 100% fail | 17:58 |
| *** lpetrut has quit IRC | 17:58 | |
| *** shyama_ has joined #openstack-nova | 17:59 | |
| superdan | yeah, so makes sense | 17:59 |
| superdan | but regardless, we should probably be pre-loading flavor anyway, which would avoid it being loaded after delete | 17:59 |
| superdan | however, I wonder if we should always read_deleted=yes when we're lazy-loading a thing... | 17:59 |
| *** shyama has quit IRC | 17:59 | |
| *** shyama_ is now known as shyama | 17:59 | |
| *** jaypipes is now known as leakypipes | 18:00 | |
| *** haomaiwa_ has quit IRC | 18:01 | |
| mriedem | i'm trying to see what triggered this to crop up | 18:01 |
| mriedem | however, given logstash problems for hte last week we might only have data for the last 2 days | 18:01 |
| leakypipes | dimsum__: done | 18:02 |
| dimsum__ | thanks jay | 18:02 |
| *** haomaiwang has joined #openstack-nova | 18:02 | |
| *** ssurana has quit IRC | 18:05 | |
| *** yanxb has quit IRC | 18:06 | |
| *** yanxb has joined #openstack-nova | 18:06 | |
| *** achanda has joined #openstack-nova | 18:07 | |
| *** achanda has quit IRC | 18:08 | |
| *** achanda has joined #openstack-nova | 18:08 | |
| *** achanda has quit IRC | 18:09 | |
| mriedem | superdan: ah, ok, so it's test_list_servers_by_admin_with_all_tenants that's failing, | 18:12 |
| mriedem | which is a test where the admin just lists servers for all tenants | 18:12 |
| mriedem | so yeah definitely a chance for a race there | 18:12 |
| mriedem | given multi worker tempest | 18:12 |
| mriedem | one test is tearing down an instance after test_list_servers_by_admin_with_all_tenants started it's query | 18:12 |
| mriedem | so if --all-tenants is true when listing servers, we should be lazy-loading the stuff that will be viewed | 18:13 |
| mriedem | or we just handle InstanceNotFound in that case | 18:14 |
| *** albertom has quit IRC | 18:18 | |
| *** boris-42 has quit IRC | 18:20 | |
| *** albertom has joined #openstack-nova | 18:22 | |
| *** moshele has quit IRC | 18:26 | |
| *** rushil has quit IRC | 18:27 | |
| *** rushil has joined #openstack-nova | 18:27 | |
| mriedem | seems better to handle the InstanceNotFound in the all-tenants list case, otherwise we have to know to pre-load flavor, info_cache and metadata since that's what the detail view uses | 18:27 |
| mriedem | and would tightly couple the api extension code to the view builder, which is gross | 18:27 |
| mriedem | or we read_deleted=yes when lazy-loading, as noted, but if we want to remove soft delete then it seems we wouldn't want to use read_deleted=yes in more places if we can help it | 18:28 |
| *** ccarmack has left #openstack-nova | 18:29 | |
| *** rushil_ has joined #openstack-nova | 18:32 | |
| *** rushil has quit IRC | 18:34 | |
| *** albertom has quit IRC | 18:39 | |
| *** kiran-r has quit IRC | 18:39 | |
| *** rushil has joined #openstack-nova | 18:40 | |
| *** ociuhandu has quit IRC | 18:41 | |
| *** rushil_ has quit IRC | 18:43 | |
| *** ssurana has joined #openstack-nova | 18:46 | |
| *** albertom has joined #openstack-nova | 18:46 | |
| *** ccarmack has joined #openstack-nova | 18:48 | |
| *** yassine has quit IRC | 18:49 | |
| *** abhirc has quit IRC | 18:55 | |
| *** emagana has quit IRC | 18:56 | |
| mriedem | hrm, wtf does tihs mean return [fakes.stub_instance_obj(100)] | 18:58 |
| *** fawadkhaliq has quit IRC | 18:58 | |
| *** haomaiwang has quit IRC | 19:01 | |
| *** moshele has joined #openstack-nova | 19:01 | |
| *** haomaiwang has joined #openstack-nova | 19:02 | |
| *** lpetrut has joined #openstack-nova | 19:02 | |
| *** haypo has quit IRC | 19:02 | |
| openstackgerrit | Feodor Tersin proposed openstack/python-novaclient: Fix versions.list for v2.1 Nova API https://review.openstack.org/215757 | 19:04 |
| *** IanGovett has quit IRC | 19:05 | |
| *** ahilan has quit IRC | 19:08 | |
| *** salv-orl_ has quit IRC | 19:10 | |
| *** lpetrut has quit IRC | 19:10 | |
| *** jichen has joined #openstack-nova | 19:12 | |
| *** moshele has quit IRC | 19:14 | |
| *** raildo is now known as raildo-afk | 19:15 | |
| *** Marga_ has joined #openstack-nova | 19:15 | |
| *** Marga_ has quit IRC | 19:19 | |
| *** Marga_ has joined #openstack-nova | 19:19 | |
| *** shyama has quit IRC | 19:21 | |
| *** Guest75934 has joined #openstack-nova | 19:24 | |
| *** Guest75934 has quit IRC | 19:25 | |
| ccarmack | mriedem: For the nova lxc CI job https://etherpad.openstack.org/p/nova-lxc-ci, should I create a bug for TODO #1? | 19:27 |
| *** dprince has quit IRC | 19:27 | |
| mriedem | ccarmack: no, it's not a bug | 19:29 |
| mriedem | well, i guess you could open a wishlist bug if you wanted something to track | 19:29 |
| ccarmack | OK, but what would I use for the commit, when I'm ready for that | 19:30 |
| mriedem | umm | 19:30 |
| mriedem | the single sentence i have in the etherpad is probably justification enough | 19:30 |
| mriedem | Need to add a NOVA_VOLUME_CLEAR flag to devstack to set libvirt.volume_clear in nova.conf so that we can set that to 'none' for lvm-backed lxc instances (really anything using NOVA_BACKEND=LVM in devstack). | 19:31 |
| ccarmack | ok, I had the idea that all commits need something in launch pad | 19:31 |
| mriedem | no | 19:31 |
| ccarmack | ok | 19:31 |
| mriedem | i'm goign to take this conditional block out back and beat it to death http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/servers.py#n350 | 19:32 |
| *** rushil has quit IRC | 19:32 | |
| *** rushil has joined #openstack-nova | 19:32 | |
| *** rushil has quit IRC | 19:38 | |
| *** signed8bit has joined #openstack-nova | 19:39 | |
| *** signed8b_ has joined #openstack-nova | 19:41 | |
| openstackgerrit | Vilobh Meshram proposed openstack/nova: Servicegroup foundational refactoring for Control Plane https://review.openstack.org/202714 | 19:43 |
| *** rfolco has quit IRC | 19:43 | |
| *** geekinutah has joined #openstack-nova | 19:44 | |
| *** signed8bit has quit IRC | 19:44 | |
| openstackgerrit | Chris Friesen proposed openstack/nova: Don't allow instance to overcommit against itself https://review.openstack.org/215764 | 19:45 |
| *** bkopilov has quit IRC | 19:47 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Pull the all_tenants search_opts checking code into a common utility https://review.openstack.org/215765 | 19:47 |
| mriedem | please god merge me ^ | 19:47 |
| *** bkopilov has joined #openstack-nova | 19:47 | |
| *** alejandrito has quit IRC | 19:48 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Pull the all_tenants search_opts checking code into a common utility https://review.openstack.org/215765 | 19:48 |
| cfriesen | sgordon: I haven't heard anything from the operators list on the above overcommit issue, figured I'd propose it and see what people say. | 19:48 |
| *** rushil has joined #openstack-nova | 19:49 | |
| leakypipes | mriedem: trade ya... https://review.openstack.org/#/c/209499/ | 19:49 |
| mriedem | leakypipes: but yours looks like scary stuff | 19:51 |
| mriedem | stevedore, etc | 19:51 |
| mriedem | plugins | 19:51 |
| mriedem | oh my | 19:51 |
| *** yanxb has quit IRC | 19:52 | |
| leakypipes | mriedem: done. | 19:52 |
| *** yanxb has joined #openstack-nova | 19:53 | |
| leakypipes | mriedem: https://review.openstack.org/#/c/213588/ might be easier? :) | 19:53 |
| leakypipes | lascii: ^^ if you have time, too :) | 19:53 |
| *** raildo-afk is now known as raildo | 19:53 | |
| *** rushil has quit IRC | 19:53 | |
| mriedem | pci?! | 19:54 |
| mriedem | oh my | 19:54 |
| mriedem | pci + objects?! | 19:54 |
| mriedem | leakypipes: i'm not sure what your idea of a softball is | 19:54 |
| leakypipes | mriedem: :) | 19:54 |
| *** sachin has quit IRC | 19:55 | |
| *** signed8b_ has quit IRC | 19:56 | |
| *** salv-orlando has joined #openstack-nova | 19:56 | |
| *** emagana has joined #openstack-nova | 19:56 | |
| mriedem | fixing that typo | 19:56 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Pull the all_tenants search_opts checking code into a common utility https://review.openstack.org/215765 | 19:56 |
| *** meghal1 has quit IRC | 19:57 | |
| *** boris-42 has joined #openstack-nova | 19:58 | |
| *** haomaiwang has quit IRC | 20:01 | |
| *** emagana has quit IRC | 20:01 | |
| *** 7JTAAIXB0 has joined #openstack-nova | 20:02 | |
| *** fawadkhaliq has joined #openstack-nova | 20:03 | |
| *** whenry__ has joined #openstack-nova | 20:05 | |
| *** kiran-r has joined #openstack-nova | 20:06 | |
| *** eharney has quit IRC | 20:07 | |
| *** moshele has joined #openstack-nova | 20:08 | |
| *** jwcroppe has quit IRC | 20:10 | |
| *** Marga_ has quit IRC | 20:12 | |
| *** signed8bit has joined #openstack-nova | 20:12 | |
| *** jwcroppe has joined #openstack-nova | 20:13 | |
| *** yanxb has quit IRC | 20:13 | |
| *** tjones has quit IRC | 20:13 | |
| *** yanxb has joined #openstack-nova | 20:13 | |
| *** marcusvrn_ has quit IRC | 20:15 | |
| *** xyang1 has quit IRC | 20:16 | |
| *** signed8b_ has joined #openstack-nova | 20:16 | |
| *** Marga_ has joined #openstack-nova | 20:18 | |
| *** signed8bit has quit IRC | 20:18 | |
| *** xyang1 has joined #openstack-nova | 20:22 | |
| *** sachin has joined #openstack-nova | 20:24 | |
| *** whenry__ has quit IRC | 20:25 | |
| *** meghal has joined #openstack-nova | 20:26 | |
| *** bkopilov has quit IRC | 20:27 | |
| *** albertom has quit IRC | 20:34 | |
| *** bkopilov has joined #openstack-nova | 20:35 | |
| *** eharney has joined #openstack-nova | 20:36 | |
| ctrath | mriedem: need a spec? https://blueprints.launchpad.net/nova/+spec/blockinfo-objectify-returned-dictionaries | 20:37 |
| mriedem | ctrath: the blueprint at least needs some more information, i.e. rough idea of which specific objects, like blockinfo.get_disk_info and get_disk_mapping | 20:37 |
| mriedem | and are they versioned objects? | 20:38 |
| mriedem | at one point i tried just using named tuples but those don't really allow optional fields | 20:38 |
| mriedem | and some of the fields are optional from what i remember | 20:38 |
| ctrath | ok.. so, do you think the objects need to be in the objects directory, or can I just create a model directly in the libvirt directory? | 20:39 |
| mriedem | ctrath: so i guess put some thought into that, put it in the bp description in there and then ask ndipanov and/or danpb if they would like to see a spec | 20:39 |
| mriedem | i was thinking in the libvirt directory | 20:39 |
| mriedem | these are only used in the libvirt director | 20:39 |
| mriedem | *directory | 20:39 |
| mriedem | similar to how diagnostics are versioned objects but only used in the nova.virt module scope | 20:39 |
| mriedem | although i guess they would be returned up through compute manager and compute api | 20:40 |
| mriedem | so i guess that's a thing to consider in the bp | 20:40 |
| mriedem | blockinfo isn't exposed through the nova api though i don't think | 20:40 |
| ctrath | mriedem: alright.. I'll create a spec. seems like there's enough info that I need to provide where I should create one | 20:40 |
| mriedem | i think nova.virt.libvirt would be ok | 20:40 |
| *** tjones has joined #openstack-nova | 20:40 | |
| *** thangp has quit IRC | 20:41 | |
| ctrath | ok, thx | 20:41 |
| *** bkopilov has quit IRC | 20:41 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Filter deleted instances when doing a detailed list with all_tenants=1 https://review.openstack.org/215774 | 20:41 |
| *** albertom has joined #openstack-nova | 20:41 | |
| mriedem | superdan: leakypipes: lascii: alex_xu: ^ wouldn't mind your thoughts on that before i spend time adding tests | 20:41 |
| *** _kiran_ has joined #openstack-nova | 20:47 | |
| *** exploreshaifali has quit IRC | 20:47 | |
| *** tonytan4ever has quit IRC | 20:48 | |
| *** kiran-r has quit IRC | 20:48 | |
| *** _kiran_ is now known as kiran-r | 20:49 | |
| *** sachin has quit IRC | 20:52 | |
| *** sachin has joined #openstack-nova | 20:53 | |
| openstackgerrit | Satheesh Kumar Ulaganathan proposed openstack/python-novaclient: Add response message when the state of a server is reset https://review.openstack.org/208071 | 20:53 |
| *** bkopilov has joined #openstack-nova | 20:53 | |
| lascii | mriedem: why only do this for all_tenants? | 20:55 |
| *** Apoorva has quit IRC | 20:55 | |
| mriedem | lascii: hrm | 20:56 |
| mriedem | i suppose it shouldn't matter | 20:56 |
| mriedem | i was thinking of it from that POV, i.e. i'm getting everything for everyone's instances, so i don't really care if some are filtered out | 20:56 |
| mriedem | but if i'm just a tenant user and listing my instances, if i've gotten to the view builder and some are gone by then, | 20:57 |
| lascii | yeah, I'm not sure that it matters | 20:57 |
| mriedem | i probably don't care that they are not shown, because either i or the admin deleted them | 20:57 |
| mriedem | it would make this simpler if we don't care about all_tenants | 20:58 |
| mriedem | that was also the tempest test that was failing for this that i hit today | 20:58 |
| mriedem | if other people are cool with dropping that filter, i'm all for it | 20:58 |
| *** fawadkhaliq has quit IRC | 20:58 | |
| lascii | yeah, all_tenants definitely makes it more likely | 20:58 |
| lascii | I think it should just be a general thing | 20:58 |
| mriedem | ok, want to make that comment in there? | 20:59 |
| lascii | I think this is a good approach for now, but longer term I would like it if the view builder could indicate what properties it needs so instance lookups can get them all at once | 20:59 |
| lascii | sure | 20:59 |
| *** 7JTAAIXB0 has quit IRC | 21:01 | |
| *** haomaiwang has joined #openstack-nova | 21:01 | |
| *** raildo is now known as raildo-afk | 21:01 | |
| mriedem | yeah, that would be nice too | 21:02 |
| mriedem | that wouldn't be hard to implement either... | 21:03 |
| mriedem | viewbuilder.get_detail_expected_attrs() | 21:03 |
| mriedem | return ('flavor', 'info_cache', 'metadata') | 21:04 |
| lascii | yep, I commented on that in the review as well | 21:04 |
| *** jichen has quit IRC | 21:08 | |
| *** tonytan4ever has joined #openstack-nova | 21:09 | |
| *** moshele has quit IRC | 21:09 | |
| *** sachin has quit IRC | 21:11 | |
| *** sachin has joined #openstack-nova | 21:13 | |
| *** meghal has quit IRC | 21:17 | |
| *** Piet has quit IRC | 21:17 | |
| *** dustins has quit IRC | 21:17 | |
| *** salv-orlando has quit IRC | 21:26 | |
| *** Piet has joined #openstack-nova | 21:26 | |
| *** Apoorva has joined #openstack-nova | 21:28 | |
| *** tpeoples has joined #openstack-nova | 21:28 | |
| *** Raildo has joined #openstack-nova | 21:29 | |
| *** aysyd has quit IRC | 21:31 | |
| *** alex_klimov has joined #openstack-nova | 21:32 | |
| *** xyang1 has quit IRC | 21:32 | |
| *** signed8b_ has quit IRC | 21:33 | |
| *** edmondsw has quit IRC | 21:34 | |
| *** Piet has quit IRC | 21:34 | |
| *** artom has quit IRC | 21:36 | |
| *** moshele has joined #openstack-nova | 21:38 | |
| *** lascii is now known as alaski | 21:38 | |
| *** artom has joined #openstack-nova | 21:39 | |
| *** mriedem has quit IRC | 21:42 | |
| *** r-daneel has quit IRC | 21:42 | |
| *** thorst has quit IRC | 21:42 | |
| *** bradjones has quit IRC | 21:42 | |
| *** meghal has joined #openstack-nova | 21:43 | |
| *** bradjones has joined #openstack-nova | 21:43 | |
| *** bradjones has quit IRC | 21:43 | |
| *** bradjones has joined #openstack-nova | 21:43 | |
| *** ctrath has quit IRC | 21:44 | |
| *** abhirc has joined #openstack-nova | 21:45 | |
| *** alex_klimov has quit IRC | 21:49 | |
| *** salv-orlando has joined #openstack-nova | 21:51 | |
| *** sungju has joined #openstack-nova | 21:53 | |
| *** sungju has quit IRC | 21:53 | |
| *** haomaiwang has quit IRC | 22:01 | |
| *** ccarmack has left #openstack-nova | 22:01 | |
| *** ajayaa has quit IRC | 22:01 | |
| *** fultonj has joined #openstack-nova | 22:01 | |
| *** Raildo has quit IRC | 22:02 | |
| *** haomaiwang has joined #openstack-nova | 22:02 | |
| *** zzzeek has quit IRC | 22:02 | |
| *** hemna has quit IRC | 22:04 | |
| *** rfolco has joined #openstack-nova | 22:05 | |
| *** kiran-r has quit IRC | 22:07 | |
| *** y_sawai has joined #openstack-nova | 22:11 | |
| *** mdrabe has quit IRC | 22:14 | |
| *** tonytan4ever has quit IRC | 22:16 | |
| *** huats has quit IRC | 22:18 | |
| openstackgerrit | Ming Yang proposed openstack/nova: Refactor get_filtered_hosts in filter host manager https://review.openstack.org/211307 | 22:18 |
| *** artom has quit IRC | 22:18 | |
| *** artom has joined #openstack-nova | 22:20 | |
| *** tjones has quit IRC | 22:22 | |
| *** sachin has quit IRC | 22:24 | |
| *** meghal1 has joined #openstack-nova | 22:26 | |
| *** sachin has joined #openstack-nova | 22:26 | |
| *** meghal has quit IRC | 22:26 | |
| *** meghal1 has quit IRC | 22:26 | |
| *** meghal has joined #openstack-nova | 22:26 | |
| *** tjones has joined #openstack-nova | 22:27 | |
| *** huats has joined #openstack-nova | 22:27 | |
| *** sachin has quit IRC | 22:27 | |
| *** sachin has joined #openstack-nova | 22:28 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add cpu_allocation_ratio and ram_allocation_ratio to ComputeNode https://review.openstack.org/215471 | 22:30 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Move CPU and RAM allocation ratios to ResourceTracker https://review.openstack.org/215278 | 22:30 |
| *** ijuwang has quit IRC | 22:30 | |
| *** meghal has quit IRC | 22:31 | |
| *** meghal has joined #openstack-nova | 22:31 | |
| *** figleaf is now known as edleafe | 22:34 | |
| *** achanda has joined #openstack-nova | 22:38 | |
| *** y_sawai has quit IRC | 22:39 | |
| *** hemna has joined #openstack-nova | 22:42 | |
| *** alejandrito has joined #openstack-nova | 22:46 | |
| *** haomaiwang has quit IRC | 23:01 | |
| *** fultonj has quit IRC | 23:01 | |
| *** haomaiwang has joined #openstack-nova | 23:02 | |
| *** penick has quit IRC | 23:04 | |
| *** abhirc has quit IRC | 23:12 | |
| *** burgerk has joined #openstack-nova | 23:17 | |
| *** salv-orlando has quit IRC | 23:19 | |
| *** meghal has quit IRC | 23:20 | |
| *** abhirc has joined #openstack-nova | 23:24 | |
| *** burgerk has quit IRC | 23:26 | |
| *** meghal has joined #openstack-nova | 23:30 | |
| *** meghal has quit IRC | 23:30 | |
| *** meghal has joined #openstack-nova | 23:30 | |
| *** claudiub has quit IRC | 23:31 | |
| *** promulo has joined #openstack-nova | 23:31 | |
| *** promulo__ has quit IRC | 23:32 | |
| *** whenry__ has joined #openstack-nova | 23:34 | |
| *** meghal has quit IRC | 23:35 | |
| *** sachin has quit IRC | 23:37 | |
| *** sachin has joined #openstack-nova | 23:39 | |
| *** sachin has quit IRC | 23:40 | |
| *** sachin has joined #openstack-nova | 23:41 | |
| *** setuid has quit IRC | 23:41 | |
| *** sachin has quit IRC | 23:41 | |
| *** sachin has joined #openstack-nova | 23:41 | |
| *** sachin has quit IRC | 23:43 | |
| *** sachin has joined #openstack-nova | 23:43 | |
| *** sachin has quit IRC | 23:44 | |
| *** sachin has joined #openstack-nova | 23:44 | |
| *** VW__ has quit IRC | 23:44 | |
| *** VW_ has joined #openstack-nova | 23:45 | |
| *** sachin has quit IRC | 23:46 | |
| *** sachin has joined #openstack-nova | 23:46 | |
| *** sachin has quit IRC | 23:47 | |
| *** sachin has joined #openstack-nova | 23:47 | |
| *** sachin has quit IRC | 23:48 | |
| *** sachin has joined #openstack-nova | 23:49 | |
| *** VW_ has quit IRC | 23:50 | |
| *** sachin_ has joined #openstack-nova | 23:50 | |
| *** sachin has quit IRC | 23:50 | |
| *** setuid has joined #openstack-nova | 23:50 | |
| *** mriedem has joined #openstack-nova | 23:51 | |
| *** sachin_ has quit IRC | 23:51 | |
| *** sachin has joined #openstack-nova | 23:52 | |
| *** sachin has quit IRC | 23:52 | |
| *** sachin has joined #openstack-nova | 23:53 | |
| *** sachin has quit IRC | 23:54 | |
| *** sachin has joined #openstack-nova | 23:54 | |
| *** sachin has quit IRC | 23:55 | |
| *** tpeoples has quit IRC | 23:55 | |
| *** sachin has joined #openstack-nova | 23:55 | |
| *** sachin has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!