| *** shardy has quit IRC | 00:01 | |
| *** bobh has joined #openstack-mistral | 00:51 | |
| *** bobh has quit IRC | 00:51 | |
| *** bobh has joined #openstack-mistral | 00:51 | |
| *** bobh has quit IRC | 00:51 | |
| *** bobh has joined #openstack-mistral | 01:37 | |
| *** bobh has quit IRC | 01:57 | |
| *** bobh has joined #openstack-mistral | 02:14 | |
| *** thrash is now known as thrash|g0ne | 03:33 | |
| *** bobh has quit IRC | 04:25 | |
| *** jamielennox is now known as jamielennox|away | 05:06 | |
| *** gongysh has joined #openstack-mistral | 05:18 | |
| d0ugal | rakhmerov: hey | 07:46 |
|---|---|---|
| rakhmerov | hi | 07:49 |
| d0ugal | rakhmerov: I have a workflow style question if you have a moment :) | 07:49 |
| rakhmerov | yes | 07:50 |
| rakhmerov | sure | 07:50 |
| d0ugal | In the TripleO workflows we are repeating these two tasks in every workflow. https://github.com/openstack/tripleo-common/blob/master/workbooks/plan_management.yaml#L290-L305 | 07:50 |
| d0ugal | Can you think of a better way? | 07:50 |
| d0ugal | I guess I could shorten it a bit with a sub-workflow call or an ad-hoc action, but it probably wouldn't be that much better... | 07:50 |
| rakhmerov | ok, let me see | 07:51 |
| d0ugal | I might try the ad-hoc action. | 07:51 |
| d0ugal | so far I count that we have it copy and pasted 29 times! | 07:52 |
| d0ugal | so updating it has become painful | 07:52 |
| d0ugal | (30 times actually, just updated my git clone) | 07:53 |
| rakhmerov | hm.. | 07:54 |
| rakhmerov | yeah, an ad-hoc could probably help | 07:54 |
| rakhmerov | except I'm not sure what you'll be doing with fail_workflow | 07:55 |
| rakhmerov | ooh, btw | 07:55 |
| rakhmerov | would it be better to do "on-success: - fail: <% ... %>" ? | 07:55 |
| rakhmerov | if your goal is to fail the whole workflow then there's a special command for that | 07:56 |
| rakhmerov | 'fail' | 07:56 |
| d0ugal | rakhmerov: !! | 07:56 |
| d0ugal | I did not know about that | 07:56 |
| d0ugal | That is the goal indeed | 07:56 |
| d0ugal | rakhmerov: so, when our workflow has an error we want it to send a zaqar message. However, that means the final task is a success - this means that sub-workflow executions don't error well for the parent workflow. | 07:56 |
| rakhmerov | there are reserved words in Mistral that we call "engine commands": succeed, fail, pause, noop | 07:57 |
| d0ugal | awesome. that will help a bunch - then I can remove the extra task. | 07:57 |
| rakhmerov | not sure what you said :) | 07:57 |
| d0ugal | haha, sorry, it is confusing. | 07:57 |
| d0ugal | rakhmerov: so, Workflow A has a task that fails, the on-error triggers another task that sends a zaqar message. | 07:58 |
| rakhmerov | yeah, re-read, kind of makes sense | 07:58 |
| d0ugal | That workflow then doesn't look like it failed. | 07:58 |
| rakhmerov | yep | 07:58 |
| rakhmerov | use 'fail' | 07:58 |
| d0ugal | so if Workblow B calls Workflow A, then it doesn't know if it failed or not | 07:58 |
| d0ugal | yup, I will update to use that :) | 07:58 |
| d0ugal | Are these special words in the docs? | 07:58 |
| rakhmerov | also, you may want to look at task-defaults | 07:58 |
| rakhmerov | not sure whether you use them or not | 07:58 |
| d0ugal | task-defaults?! haha is that in the docs? | 07:59 |
| d0ugal | I should have asked about this before :) | 07:59 |
| rakhmerov | for example, if you need to have exact same handling in every workflow task you can define this handling once in task-defaults section under the workflow itself | 07:59 |
| rakhmerov | it's in docs, yes | 07:59 |
| rakhmerov | you can do, for example | 07:59 |
| rakhmerov | wf: | 07:59 |
| rakhmerov | task-defaults: | 07:59 |
| rakhmerov | on-error: fail | 08:00 |
| d0ugal | right | 08:00 |
| d0ugal | hmm, I am not sure if that would help - I will try. | 08:01 |
| d0ugal | rakhmerov: is "fail" implemented as a task that is included in every workflow? | 08:02 |
| rakhmerov | woow, f...ck | 08:08 |
| rakhmerov | d0ugal: 'task-defaults' is in docs but these engine commands seem to be not | 08:08 |
| rakhmerov | gosh.. | 08:08 |
| rakhmerov | I'll create a BP | 08:08 |
| d0ugal | rakhmerov: I found it in an example, but can't see it otherwise | 08:08 |
| rakhmerov | yes | 08:08 |
| d0ugal | http://docs.openstack.org/developer/mistral/dsl/dsl_v2.html#id1 | 08:08 |
| rakhmerov | yes, but it's not explained well anywhere | 08:09 |
| rakhmerov | so, answering your questions | 08:09 |
| rakhmerov | these commands are not implemented as tasks | 08:09 |
| rakhmerov | they are just direct instructions for engine | 08:09 |
| d0ugal | ok, cool | 08:10 |
| rakhmerov | what to do with a workflow execution | 08:10 |
| d0ugal | and they are called "engine commands"? | 08:10 |
| rakhmerov | essentially all of them are just intended to change a workflow execution state | 08:10 |
| rakhmerov | yes | 08:10 |
| d0ugal | I am trying to figure out what to write in my commit message :) | 08:10 |
| rakhmerov | yes | 08:10 |
| rakhmerov | engine commands | 08:10 |
| d0ugal | thanks! | 08:10 |
| rakhmerov | we'll write docs for them asap | 08:10 |
| rakhmerov | it's a very cool feature | 08:11 |
| d0ugal | I can probably do that, if you tell me what all the commands are and check what I write is correct :) | 08:11 |
| rakhmerov | that would be awesome | 08:13 |
| rakhmerov | give me a few min.. | 08:13 |
| d0ugal | Is it accurate to say that it can be used anywhere you can call a task? | 08:15 |
| rakhmerov | in on-xxx handlers | 08:15 |
| rakhmerov | yes | 08:15 |
| rakhmerov | https://blueprints.launchpad.net/mistral/+spec/mistral-engine-commands-docs | 08:15 |
| d0ugal | Thanks | 08:16 |
| rakhmerov | d0ugal: you can take a look at the tests for them in order to learn more https://github.com/openstack/mistral/blob/master/mistral/tests/unit/engine/test_commands.py | 08:17 |
| d0ugal | Thanks, added a link to that in the whiteboard. | 08:17 |
| rakhmerov | yep | 08:18 |
| * rakhmerov needs to review all our docs asap.. | 08:19 | |
| *** shardy has joined #openstack-mistral | 08:19 | |
| d0ugal | This made me happy :) https://review.openstack.org/#/c/425047/ | 08:19 |
| d0ugal | It would be nice if ad-hoc actions allowed you to include non-input parameters (like timeout and retry) | 08:29 |
| d0ugal | rakhmerov: the ad-hoc action doesn't really save that much, I only added it and updated it in one place: https://review.openstack.org/#/c/425056/1/workbooks/baremetal.yaml | 08:40 |
| d0ugal | I think a sub-workflow call would be better, but a little strange :) | 08:41 |
| d0ugal | sub-workflows are a bit better... https://review.openstack.org/#/c/425060/ | 08:47 |
| *** jpich has joined #openstack-mistral | 08:55 | |
| rakhmerov | d0ugal: retry and timeout are properties of tasks, not actions | 09:35 |
| rakhmerov | they don't really fit into their concept | 09:35 |
| d0ugal | true | 09:35 |
| d0ugal | maybe I want an ad-hoc task :) | 09:35 |
| d0ugal | or a re-usable task anyway | 09:35 |
| rakhmerov | :) | 09:35 |
| rakhmerov | it may come to workflow inheritance again | 09:36 |
| d0ugal | yeah | 09:36 |
| d0ugal | it does :) | 09:36 |
| rakhmerov | where we could define certain tasks in a parent workflow and reuse them | 09:36 |
| d0ugal | I am trying to think of a simpler way than full inheritance | 09:36 |
| rakhmerov | https://review.openstack.org/#/c/425047/2/workbooks/baremetal.yaml looks nice, yes :) | 09:36 |
| rakhmerov | d0ugal: I'm open to suggestions, if you have good ideas please share | 09:37 |
| rakhmerov | sharatss: hi, were you able to test Congress actions? | 09:39 |
| *** openstackgerrit has quit IRC | 10:17 | |
| ddeja | rakhmerov: Hi, I was asked on another channel why this got closed? https://blueprints.launchpad.net/mistral/+spec/mistral-ha | 10:31 |
| ddeja | as 'obsolete'? | 10:31 |
| rakhmerov | it just doesn't make a lot of sense in this form | 10:31 |
| rakhmerov | and it was created initially as an informational thing | 10:32 |
| rakhmerov | in fact, it breaks down to a number of more concrete blueprints that we need to work on | 10:32 |
| rakhmerov | so, it was more an intention than a real blueprint that could be assigned to one person | 10:33 |
| *** jpich has quit IRC | 10:35 | |
| ddeja | OK, thanks :) | 10:36 |
| *** tuan_ has joined #openstack-mistral | 10:54 | |
| tuan_ | hey guys | 11:01 |
| tuan_ | when i run tox with mistral master | 11:01 |
| tuan_ | it fails with error of test-requirements not installed | 11:02 |
| tuan_ | the error also shows out the problem of md5 hashing of pbr | 11:02 |
| tuan_ | does anyone have this problem before? | 11:02 |
| *** thrash|g0ne is now known as thrash | 11:06 | |
| ddeja | tuan_: 2 things: 1) do you have connection to the internet on the machine that you are using for running tox? 2) did you try to remove .tox directory and re-run tests? | 11:07 |
| ddeja | it usually helps with errors with some-package-name not installed | 11:07 |
| tuan_ | ddeja: Hi, | 11:09 |
| tuan_ | #1: Yeap i have, pip runs well | 11:09 |
| tuan_ | #2: I deleted .tox multiple times | 11:10 |
| tuan_ | hmm, i have not seen this problem before | 11:10 |
| tuan_ | let me run again now | 11:10 |
| tuan_ | it fails again | 11:20 |
| tuan_ | Cloning https://git.openstack.org/openstack/requirements (to master) to ./.tox/pep8/src/requirements | 11:21 |
| tuan_ | error: RPC failed; curl 56 GnuTLS recv error (-9): A TLS packet with unexpected length was received. | 11:21 |
| tuan_ | here is the error | 11:21 |
| *** d0ugal has quit IRC | 12:10 | |
| tuan_ | ddeja: more error | 12:11 |
| tuan_ | distutils.errors.DistutilsError: md5 validation failed for pbr-1.10.0.tar.gz; possible download problem? | 12:11 |
| tuan_ | i also upgraded pip | 12:12 |
| tuan_ | version of 9.0.1 | 12:12 |
| tuan_ | hmm | 12:12 |
| *** d0ugal has joined #openstack-mistral | 12:19 | |
| *** shardy is now known as shardy_lunch | 12:20 | |
| *** catintheroof has joined #openstack-mistral | 12:28 | |
| tuan_ | hi guys, | 12:44 |
| tuan_ | what about the cacert in mistral | 12:44 |
| tuan_ | it mistral does not provide\ | 12:44 |
| d0ugal | You could try removing this line locally: https://github.com/openstack/mistral/blob/master/tox.ini#L8 | 12:44 |
| tuan_ | how we can parse this cacert to another project of openstack like nova, heat | 12:44 |
| *** bobh has joined #openstack-mistral | 13:01 | |
| *** bobh has quit IRC | 13:01 | |
| *** bobh has joined #openstack-mistral | 13:01 | |
| tuan_ | i myself think that it is a bug of mistral without providing cacert | 13:02 |
| *** shardy_lunch is now known as shardy | 13:26 | |
| *** bobh has quit IRC | 13:36 | |
| *** bobh has joined #openstack-mistral | 14:11 | |
| *** dprince has joined #openstack-mistral | 14:21 | |
| *** bobh has quit IRC | 14:31 | |
| *** openstackgerrit has joined #openstack-mistral | 14:45 | |
| openstackgerrit | luong tuan proposed openstack/mistral: Deleting the expired execution in chunk https://review.openstack.org/424621 | 14:45 |
| *** rbrady is now known as rbrady-brb | 14:52 | |
| *** catinthe_ has joined #openstack-mistral | 15:00 | |
| *** catintheroof has quit IRC | 15:02 | |
| *** thrash is now known as thrash|biab | 15:05 | |
| *** jaosorior has joined #openstack-mistral | 15:10 | |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Refactor rpc configuration loading https://review.openstack.org/424171 | 15:12 |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Add support for Rabbit HA https://review.openstack.org/425229 | 15:12 |
| *** thrash|biab is now known as thrash | 15:26 | |
| *** tuan_ has quit IRC | 15:28 | |
| *** bobh has joined #openstack-mistral | 15:32 | |
| *** bobh has quit IRC | 15:37 | |
| *** catintheroof has joined #openstack-mistral | 15:43 | |
| *** catinthe_ has quit IRC | 15:46 | |
| *** toure|biab is now known as toure | 16:05 | |
| *** gongysh has quit IRC | 16:07 | |
| *** bobh has joined #openstack-mistral | 16:33 | |
| *** rbrady-brb is now known as rbrady | 16:34 | |
| *** AlexeyAbashkin has quit IRC | 16:35 | |
| *** bobh has quit IRC | 16:38 | |
| *** jaosorior has quit IRC | 17:22 | |
| *** jaosorior has joined #openstack-mistral | 17:32 | |
| *** bobh has joined #openstack-mistral | 17:34 | |
| *** bobh has quit IRC | 17:38 | |
| *** dprince has quit IRC | 17:53 | |
| *** catinthe_ has joined #openstack-mistral | 18:33 | |
| *** bobh has joined #openstack-mistral | 18:34 | |
| *** catintheroof has quit IRC | 18:35 | |
| *** bobh has quit IRC | 18:39 | |
| *** dprince has joined #openstack-mistral | 18:41 | |
| *** sharatss has quit IRC | 18:49 | |
| *** sharatss has joined #openstack-mistral | 18:49 | |
| *** shardy is now known as shardy_afk | 19:01 | |
| *** FL1SK has quit IRC | 19:01 | |
| *** jaosorior has quit IRC | 19:21 | |
| *** dprince has quit IRC | 19:48 | |
| *** dprince has joined #openstack-mistral | 19:49 | |
| *** jaosorior has joined #openstack-mistral | 20:12 | |
| *** jaosorior has quit IRC | 20:17 | |
| *** jaosorior has joined #openstack-mistral | 20:24 | |
| *** catinthe_ has quit IRC | 20:27 | |
| *** dougshelley66 has quit IRC | 20:38 | |
| *** dougshelley66 has joined #openstack-mistral | 20:45 | |
| *** jamielennox|away has quit IRC | 20:46 | |
| *** dprince has quit IRC | 20:48 | |
| *** dprince has joined #openstack-mistral | 20:48 | |
| openstackgerrit | Merged openstack/mistral: External OpenStack action mapping file support added https://review.openstack.org/418761 | 20:50 |
| openstackgerrit | Merged openstack/mistral: Enforce style check for assertIsNone https://review.openstack.org/420405 | 20:50 |
| *** jamielennox|away has joined #openstack-mistral | 20:56 | |
| *** jamielennox|away is now known as jamielennox | 20:56 | |
| *** FL1SK has joined #openstack-mistral | 21:01 | |
| *** shardy_afk has quit IRC | 21:03 | |
| *** shardy_afk has joined #openstack-mistral | 21:05 | |
| *** shardy_afk is now known as shardy | 21:07 | |
| *** dprince has quit IRC | 21:23 | |
| *** jaosorior has quit IRC | 21:31 | |
| *** shardy has quit IRC | 21:45 | |
| *** rbrady is now known as rbrady-afk | 22:08 | |
| *** catintheroof has joined #openstack-mistral | 23:00 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/mistral: Updated from global requirements https://review.openstack.org/424617 | 23:23 |
| *** catintheroof has quit IRC | 23:58 | |
| *** catintheroof has joined #openstack-mistral | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!