| *** catintheroof has quit IRC | 00:03 | |
| *** bobh has joined #openstack-mistral | 00:16 | |
| *** rbrady-afk has quit IRC | 00:47 | |
| *** bobh has quit IRC | 00:55 | |
| *** bobh__ has joined #openstack-mistral | 00:55 | |
| *** bobh__ has quit IRC | 01:09 | |
| *** bobh has joined #openstack-mistral | 01:25 | |
| *** bobh has quit IRC | 01:39 | |
| *** catintheroof has joined #openstack-mistral | 01:44 | |
| *** catintheroof has quit IRC | 01:49 | |
| *** gongysh has joined #openstack-mistral | 01:49 | |
| *** rbrady-afk has joined #openstack-mistral | 02:13 | |
| *** bobh has joined #openstack-mistral | 02:28 | |
| *** d0ugal has quit IRC | 03:00 | |
| *** bobh has quit IRC | 03:01 | |
| *** d0ugal has joined #openstack-mistral | 03:18 | |
| *** thrash is now known as thrash|g0ne | 04:12 | |
| openstackgerrit | Merged openstack/mistral-dashboard: Updated from global requirements https://review.openstack.org/425391 | 04:31 |
|---|---|---|
| *** jtomasek has quit IRC | 05:18 | |
| openstackgerrit | Merged openstack/mistral: Updated from global requirements https://review.openstack.org/424617 | 05:25 |
| *** AlexeyAbashkin has joined #openstack-mistral | 07:22 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Don't create actions with empty arg_lists https://review.openstack.org/412433 | 07:40 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral: Don't create actions with empty arg_lists https://review.openstack.org/412433 | 07:40 |
| *** sharatss has quit IRC | 08:32 | |
| *** sharatss has joined #openstack-mistral | 08:33 | |
| openstackgerrit | Istvan Imre proposed openstack/mistral: External OpenStack action mapping file support https://review.openstack.org/425581 | 08:41 |
| *** jpich has joined #openstack-mistral | 08:44 | |
| *** brunograz has joined #openstack-mistral | 08:57 | |
| *** shardy has joined #openstack-mistral | 09:02 | |
| *** gongysh has quit IRC | 09:10 | |
| *** AlexeyAbashkin has quit IRC | 09:10 | |
| *** tuan_ has joined #openstack-mistral | 09:21 | |
| *** shardy has quit IRC | 09:42 | |
| *** shardy has joined #openstack-mistral | 09:42 | |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Refactor rpc configuration loading https://review.openstack.org/424171 | 10:49 |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Add support for Rabbit HA https://review.openstack.org/425229 | 10:49 |
| *** shardy has quit IRC | 10:51 | |
| *** shardy has joined #openstack-mistral | 10:52 | |
| rakhmerov | kong: here? | 11:04 |
| rakhmerov | hi | 11:04 |
| ddeja | Hi rakhmerov, could you please look on those 2 patches: https://review.openstack.org/424171 https://review.openstack.org/425229 | 11:06 |
| ddeja | I'd like to get them in ocata if possible ;) | 11:06 |
| * ddeja should finish them faster | 11:06 | |
| rakhmerov | ok, yes | 11:07 |
| rakhmerov | give me a few mins | 11:07 |
| ddeja | rakhmerov: thanks :) | 11:13 |
| rakhmerov | ddeja: our mysql/postgres gates are failing now with a weird error, by any chance do you know what it could be? | 11:17 |
| rakhmerov | http://logs.openstack.org/71/424171/3/check/gate-mistral-tox-db-unit-mysql-ubuntu-xenial/b408212/testr_results.html.gz | 11:17 |
| *** openstackgerrit has quit IRC | 11:17 | |
| rakhmerov | I remember you fixed a similar thing not so long ago | 11:17 |
| rakhmerov | maybe they started using a different ubuntu image or something | 11:18 |
| ddeja | rakhmerov: let me take a look | 11:23 |
| rakhmerov | ddeja: quick question on your review | 11:23 |
| rakhmerov | https://review.openstack.org/#/c/424171/3/mistral/engine/rpc_backend/kombu/kombu_client.py | 11:23 |
| ddeja | ? | 11:23 |
| rakhmerov | what exactly happens in line 41? | 11:23 |
| rakhmerov | I don't quite understand the following thing: you use properties like CONF.oslo_messaging_rabbit.rabbit_virtual_host | 11:24 |
| rakhmerov | does line 41 fill those config properties? | 11:24 |
| rakhmerov | because 'transport_url' is now considered the right method of configuring these properties | 11:25 |
| ddeja | it constructs the TransportUrl object based on config | 11:25 |
| rakhmerov | ok, then what about the config properties you use directly w/o it? | 11:26 |
| ddeja | they are only used, if transport url is not provided | 11:26 |
| rakhmerov | how come? | 11:26 |
| rakhmerov | where is this logic? | 11:26 |
| ddeja | in kombu_hosts.py | 11:27 |
| ddeja | https://review.openstack.org/#/c/424171/3/mistral/engine/rpc_backend/kombu/kombu_hosts.py | 11:27 |
| ddeja | lines 32-47 | 11:28 |
| rakhmerov | yes, ok | 11:28 |
| rakhmerov | I see | 11:28 |
| rakhmerov | ddeja: +2, very cool patch (much needed) | 11:30 |
| rakhmerov | d0ugal: hi, can you pls look at https://review.openstack.org/#/c/424171 ? | 11:30 |
| ddeja | rakhmerov: thanks :) | 11:31 |
| ddeja | about the gate failing, it's very strange... all the tests passed end then gaite failed | 11:31 |
| ddeja | s/end/and/ | 11:32 |
| rakhmerov | ooh, really? | 11:32 |
| *** shardy has quit IRC | 11:32 | |
| rakhmerov | so it ran the tests successfully? | 11:32 |
| ddeja | you mean on my patch, or on another? | 11:32 |
| rakhmerov | I believe it's not related with your patch | 11:33 |
| rakhmerov | I guess something happened with CI | 11:33 |
| ddeja | becaouse on my patch everything passed | 11:33 |
| ddeja | and the failure is becouse of pep8 failure | 11:33 |
| ddeja | I forgot to run it before sending a patch, my fault | 11:33 |
| rakhmerov | no-no | 11:34 |
| rakhmerov | wait | 11:34 |
| ddeja | http://logs.openstack.org/71/424171/2/check/gate-mistral-tox-db-unit-mysql-ubuntu-xenial/455488c/console.html#_2017-01-25_17_18_17_629194 | 11:34 |
| rakhmerov | I'm looking at Zuul | 11:34 |
| *** shardy has joined #openstack-mistral | 11:34 | |
| ddeja | oh, OK | 11:34 |
| rakhmerov | your first patch is fine, all the tests passed except unit tests on mysql and postgres | 11:34 |
| rakhmerov | do you see it? | 11:34 |
| d0ugal | rakhmerov: okay, I'll try - not sure I'll fully understand it tho :) | 11:35 |
| rakhmerov | the same with your second patch | 11:35 |
| ddeja | rakhmerov: Yup, I see | 11:35 |
| rakhmerov | but my assumption is that it's not related to your changes, I just noticed it on your patches | 11:35 |
| ddeja | I'll look on it as soon as all logs will be available | 11:36 |
| rakhmerov | ok | 11:38 |
| rakhmerov | d0ugal: that's ok, I almost understand, just check things you understand :) | 11:38 |
| *** tuan_ has quit IRC | 11:39 | |
| rakhmerov | ddeja: just a few small things in https://review.openstack.org/#/c/425229 | 11:41 |
| rakhmerov | please fix, I'll review in a couple of hours | 11:41 |
| ddeja | rakhmerov: sure, doing right now | 11:42 |
| *** thrash|g0ne is now known as thrash | 11:43 | |
| *** openstackgerrit has joined #openstack-mistral | 11:46 | |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Add support for Rabbit HA https://review.openstack.org/425229 | 11:46 |
| *** tuan_ has joined #openstack-mistral | 11:53 | |
| ddeja | rakhmerov: fixed ^^ | 11:57 |
| * ddeja is going for lunch, will be back in ~40 minutes | 11:57 | |
| *** shardy is now known as shardy_lunch | 12:10 | |
| *** catintheroof has joined #openstack-mistral | 12:27 | |
| *** catintheroof has quit IRC | 12:38 | |
| *** catintheroof has joined #openstack-mistral | 12:38 | |
| ddeja | rakhmerov: about gate failures | 12:47 |
| ddeja | almost all test failed | 12:48 |
| ddeja | with this error: AttributeError: 'module' object has no attribute 'poll' | 12:48 |
| ddeja | and it's a result of using importutils from oslo_utils | 12:49 |
| ddeja | so I guess that the problem is in oslo | 12:49 |
| *** dprince has joined #openstack-mistral | 12:51 | |
| *** bobh has joined #openstack-mistral | 12:54 | |
| *** bobh has quit IRC | 12:54 | |
| *** bobh has joined #openstack-mistral | 12:54 | |
| *** catinthe_ has joined #openstack-mistral | 12:57 | |
| *** catintheroof has quit IRC | 12:59 | |
| *** shardy_lunch is now known as shardy | 13:04 | |
| *** bobh has quit IRC | 13:21 | |
| tuan_ | ddeja: I have also this problem too when running unittest | 13:29 |
| openstackgerrit | Merged openstack/mistral: Refactor rpc configuration loading https://review.openstack.org/424171 | 13:32 |
| ddeja | tuan_: oh. did you upgraded recently? | 13:36 |
| ddeja | Like in the last 24h? | 13:37 |
| *** rbrady-afk is now known as rbrady | 13:43 | |
| tuan_ | i am using master branch | 13:48 |
| tuan_ | latest | 13:48 |
| ddeja | I mean if you did any system upgrades | 13:49 |
| tuan_ | nope | 13:49 |
| ddeja | strange... | 13:50 |
| tuan_ | and why in unittest | 13:50 |
| tuan_ | i have the smae problem | 13:50 |
| ddeja | or maybe you have upgraded any package using pip? | 13:50 |
| tuan_ | i think so | 13:50 |
| tuan_ | nope | 13:50 |
| tuan_ | i do not think so | 13:50 |
| tuan_ | :D | 13:50 |
| tuan_ | just run tox on latest master | 13:51 |
| tuan_ | that is it | 13:51 |
| tuan_ | well, it may happen like this | 13:51 |
| tuan_ | since my pip has to go through our proxy and my pip is set to featch packages from our own pypi | 13:51 |
| tuan_ | and i do not have no any information about packages ovethere | 13:52 |
| ddeja | it may get upgraded, ok thanks | 13:52 |
| tuan_ | yeap | 13:52 |
| ddeja | OK, I'm trying to find out what happend | 13:53 |
| ddeja | d0ugal: if you have time and can look on this: https://review.openstack.org/#/c/425229 | 14:03 |
| *** shardy has quit IRC | 14:14 | |
| *** shardy has joined #openstack-mistral | 14:15 | |
| *** shardy has quit IRC | 14:35 | |
| *** tuan_ has quit IRC | 14:41 | |
| *** tuan_ has joined #openstack-mistral | 14:43 | |
| tuan_ | ddeja: i have run tox by downloading package from global pypi | 14:52 |
| tuan_ | indeed it has the poll problem | 14:52 |
| tuan_ | and it is raised from importing muranoclient | 14:53 |
| tuan_ | :( | 14:53 |
| ddeja | tuan_: oh, so it's muranoclient | 14:55 |
| ddeja | it's one of the 2 packages which been added in last 24 hours | 14:56 |
| ddeja | rakhmerov: ^^ | 14:56 |
| ddeja | rakhmerov: tuan_ probably found what couses our tox gates to fail | 14:56 |
| *** jrist has quit IRC | 14:56 | |
| *** sharatss has quit IRC | 14:57 | |
| tuan_ | :(, it blocks me the whole day to finish my patch on community | 14:57 |
| *** sharatss has joined #openstack-mistral | 14:57 | |
| tuan_ | also another idea for cacert in mistral too | 14:57 |
| tuan_ | :( | 14:57 |
| tuan_ | could you guys please check this version of muranoclient | 14:58 |
| ddeja | tuan_: well | 15:01 |
| ddeja | I'm not sure why it is installed at all | 15:01 |
| ddeja | I don't have it installed | 15:01 |
| ddeja | it is not installed on our py27/py35 gate | 15:01 |
| tuan_ | what? | 15:02 |
| ddeja | but it is installed on our tox mysql gate | 15:02 |
| tuan_ | :)) | 15:02 |
| ddeja | which fails | 15:02 |
| ddeja | and now I'm just staring at logs feeling stupid | 15:02 |
| ddeja | trying to understand why the heck it gets installed | 15:02 |
| ddeja | and only on some gates, not in all | 15:02 |
| *** bobh has joined #openstack-mistral | 15:09 | |
| *** jrist has joined #openstack-mistral | 15:09 | |
| ddeja | d0ugal: You give me a +W without second +2... | 15:10 |
| ddeja | https://review.openstack.org/#/c/425229/ | 15:10 |
| ddeja | I don't mind getting my patches merged, but since this one is not trivial, I guess someone else may want to look at it ;) | 15:11 |
| tuan_ | okay | 15:12 |
| tuan_ | let me take a look to that | 15:12 |
| tuan_ | while waiting for muranoclient fix | 15:12 |
| tuan_ | let me see how did you modify to compare to Nova stuff | 15:13 |
| openstackgerrit | Dawid Deja proposed openstack/mistral: Add support for Rabbit HA https://review.openstack.org/425229 | 15:13 |
| tuan_ | :) | 15:13 |
| d0ugal | ddeja: whoops, sorry - good spot | 15:27 |
| d0ugal | for some reason I thought rakhmerov had already reviewed it | 15:27 |
| * d0ugal has too many reviews open | 15:28 | |
| *** jaosorior has joined #openstack-mistral | 15:31 | |
| ddeja | d0ugal: no problem, I rebased, so only +2 is left | 15:37 |
| ddeja | d0ugal: rakhmerov did reviewed it, but gave -1 ;) | 15:37 |
| mgershen | ddeja: what about the todo you added, is there another patch? | 15:38 |
| *** catintheroof has joined #openstack-mistral | 15:39 | |
| ddeja | mgershen: yup, I'd like to resolve it as a bug | 15:39 |
| mgershen | ddeja: maybe it will be nice to add a link to the bug in the commit message? not a must. | 15:42 |
| ddeja | well, there is no bug. Yet. Since it is not merged ;) | 15:42 |
| *** catinthe_ has quit IRC | 15:42 | |
| *** sharatss has quit IRC | 15:44 | |
| *** sharatss has joined #openstack-mistral | 15:45 | |
| mgershen | ddeja: oops sorry. I thought maybe there was something like problem in retry mechanism when connecting to rabbit. but as I said not a must :) | 15:45 |
| ddeja | mgershen: noo, I just wanted to make the patch short, so I hardcoded some values | 15:46 |
| *** shardy has joined #openstack-mistral | 15:46 | |
| *** openstackgerrit has quit IRC | 15:48 | |
| mgershen | ddeja: ok, that's fine by me too. | 15:49 |
| tuan_ | ddeja: May i have question | 15:53 |
| tuan_ | i have take a look to your patch | 15:53 |
| tuan_ | it seems good to me except to while loop in kombu_server.py | 15:54 |
| tuan_ | since kombu library supports multiple hosts with failover_strategy (e.g. round robin) | 15:55 |
| tuan_ | then we do not need while loop here | 15:55 |
| tuan_ | just put the list of hosts into kombu.Connection with failover_strategy | 15:55 |
| tuan_ | it seems more simpler | 15:55 |
| tuan_ | just only my private idea | 15:56 |
| *** bobh has quit IRC | 15:57 | |
| ddeja | tuan_: Oh, ok. I'll look on that, thanks | 15:58 |
| tuan_ | ddeja: http://docs.celeryproject.org/projects/kombu/en/latest/_modules/kombu/connection.html#Connection | 16:00 |
| tuan_ | take a look to this | 16:01 |
| tuan_ | AFAIK the oslo messaging also implement this | 16:01 |
| tuan_ | i do not remember now but when i work for Nova and Neutron then it is | 16:02 |
| tuan_ | hopefully it does not change | 16:02 |
| tuan_ | :D | 16:02 |
| ddeja | tuan_: oh, OK i was looking for something like this but with no luck | 16:02 |
| ddeja | thanks for pointing this, it makes the whole change easier | 16:02 |
| tuan_ | :D, yeah | 16:02 |
| tuan_ | thumb up | 16:02 |
| tuan_ | otherwise, how can we solve the problem of muranoclient? | 16:03 |
| tuan_ | :( | 16:03 |
| ddeja | it's very strange | 16:03 |
| tuan_ | my whole unittest fails just because of that | 16:03 |
| tuan_ | for me too | 16:03 |
| ddeja | tuan_: how do you run unittest? | 16:03 |
| tuan_ | i just clone the lastest master from github | 16:03 |
| tuan_ | and run tox as usual | 16:04 |
| tuan_ | i have done it multiple times in Nova | 16:04 |
| ddeja | could you paste your command please? | 16:04 |
| tuan_ | and it did not show any problem | 16:04 |
| tuan_ | yeah | 16:04 |
| ddeja | that you use for running tox | 16:04 |
| tuan_ | tox -e py27 | 16:04 |
| tuan_ | that is it | 16:04 |
| ddeja | so same as mine... | 16:04 |
| tuan_ | from very beginning | 16:04 |
| ddeja | because, I have same error | 16:04 |
| tuan_ | and it is standard :D | 16:04 |
| tuan_ | what erros | 16:04 |
| ddeja | but only if i run tox -e unit-mysql | 16:05 |
| ddeja | but more importantly | 16:05 |
| ddeja | if I use this virtual env | 16:05 |
| ddeja | and inside it try to run same code, that makes uni tests fails | 16:05 |
| ddeja | it works correctly | 16:05 |
| ddeja | but | 16:05 |
| ddeja | it starts to eat all of my cores | 16:05 |
| ddeja | and freezes the console | 16:05 |
| ddeja | unitl I use ctrl+c | 16:06 |
| tuan_ | hmm | 16:06 |
| tuan_ | weird | 16:06 |
| ddeja | so it seems like that something is broken regarding this library | 16:06 |
| ddeja | or with gate | 16:06 |
| ddeja | or I have no idea what :D | 16:06 |
| tuan_ | probably some changes in package | 16:06 |
| tuan_ | since unittest has no connection to CI gate | 16:06 |
| tuan_ | i mean when we run in local | 16:07 |
| tuan_ | :d | 16:07 |
| tuan_ | each time i delete whole mistral dir | 16:07 |
| tuan_ | and re-clone it from github | 16:07 |
| tuan_ | it raises the same error | 16:07 |
| tuan_ | :( | 16:08 |
| tuan_ | let me do it once again | 16:08 |
| *** sharatss has quit IRC | 16:08 | |
| *** sharatss has joined #openstack-mistral | 16:09 | |
| ddeja | I tried deleting the .tox folder, but I don't have this problem | 16:09 |
| *** jrist has quit IRC | 16:10 | |
| tuan_ | i did deleted multiple times too | 16:11 |
| tuan_ | :D | 16:11 |
| tuan_ | i am running again | 16:11 |
| tuan_ | let's seee | 16:11 |
| tuan_ | by the way, i wait for the new patch of kombu from you | 16:12 |
| tuan_ | :D | 16:12 |
| *** jrist has joined #openstack-mistral | 16:21 | |
| *** thrash is now known as thrash|biab | 16:33 | |
| *** tuan_ has quit IRC | 16:36 | |
| *** dprince has quit IRC | 16:37 | |
| *** sharatss has quit IRC | 17:06 | |
| *** sharatss has joined #openstack-mistral | 17:07 | |
| *** jpich has quit IRC | 17:23 | |
| *** sharatss has quit IRC | 17:31 | |
| *** sharatss has joined #openstack-mistral | 17:32 | |
| *** sharatss has quit IRC | 17:37 | |
| *** sharatss has joined #openstack-mistral | 17:37 | |
| *** shardy is now known as shardy_afk | 17:53 | |
| *** dprince has joined #openstack-mistral | 18:28 | |
| *** openstackgerrit has joined #openstack-mistral | 18:45 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/mistral: Updated from global requirements https://review.openstack.org/425829 | 18:45 |
| *** harlowja has quit IRC | 19:02 | |
| *** thrash|biab is now known as thrash | 19:21 | |
| *** weshay is now known as weshay_brb | 19:55 | |
| *** harlowja has joined #openstack-mistral | 20:09 | |
| *** weshay_brb is now known as weshay | 20:20 | |
| *** sharatss has quit IRC | 20:28 | |
| *** sharatss has joined #openstack-mistral | 20:28 | |
| *** sharatss has quit IRC | 20:43 | |
| *** sharatss has joined #openstack-mistral | 20:44 | |
| *** thrash is now known as thrash|brb | 21:40 | |
| *** catintheroof has quit IRC | 21:47 | |
| kong | rakhmerov: seems we have some problem in mistral CI? | 22:06 |
| kong | will that block our b3 release? | 22:07 |
| *** dprince has quit IRC | 22:15 | |
| *** thrash|brb is now known as thrahs | 22:29 | |
| *** thrahs is now known as thrash | 22:29 | |
| kong | rakhmerov: please ping me when you are here, I will be here in next 4 hours, and from 10PM in UTC+13 | 22:32 |
| kong | i want to discuss release stuff with you | 22:33 |
| *** rbrady is now known as rbrady-afk | 22:34 | |
| openstackgerrit | Merged openstack/mistral: Updated from global requirements https://review.openstack.org/425829 | 22:37 |
| *** bobh has joined #openstack-mistral | 22:57 | |
| *** bobh has quit IRC | 22:57 | |
| *** bobh has joined #openstack-mistral | 22:57 | |
| *** bobh has quit IRC | 23:02 | |
| *** jaosorior has quit IRC | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!