Wednesday, 2014-05-28

*** matsuhashi has joined #openstack-ironic00:01
*** radsy has joined #openstack-ironic00:04
*** takadayuiko has joined #openstack-ironic00:06
*** zdiN0bot1 has quit IRC00:08
*** Penick has joined #openstack-ironic00:10
adam_gbummer. ubuntu's tgt utilites are not built with aio support00:14
*** Penick has quit IRC00:16
*** shakamunyi has quit IRC00:18
*** Penick has joined #openstack-ironic00:19
* devananda is back00:21
* devananda now includes tacos and coffee00:21
openstackgerritJosh Gachnang proposed a change to openstack/ironic: Factoring out PXE and TFTP functions  https://review.openstack.org/9023300:22
openstackgerritJosh Gachnang proposed a change to openstack/ironic: Adding a reference driver for the agent  https://review.openstack.org/8479500:22
*** lazy_prince has joined #openstack-ironic00:24
*** BadCub01_ has quit IRC00:57
openstackgerritJosh Gachnang proposed a change to openstack/ironic: Factoring out PXE and TFTP functions  https://review.openstack.org/9023301:03
openstackgerritJosh Gachnang proposed a change to openstack/ironic: Adding a reference driver for the agent  https://review.openstack.org/8479501:04
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Remove vim modelines  https://review.openstack.org/9598301:15
openstackgerritDevananda van der Veen proposed a change to openstack/python-ironicclient: Remove vim modelines  https://review.openstack.org/9598501:20
*** eguz has quit IRC01:27
*** rloo has quit IRC01:45
*** nosnos has joined #openstack-ironic01:48
*** martyntaylor has quit IRC02:08
devanandadhellmann: know if there are any plans to add 3xx status code handling to wsme? (not that ironic needs it, but it looks like it's not supported, so i'm glad we dont need it)02:09
devanandadhellmann: oh - perhaps it's just not set up to handle exceptions with 3xx codes? if so, never mind, I was thinking I could raise those02:11
*** lazy_prince has quit IRC02:13
*** mkerrin1 has joined #openstack-ironic02:32
*** mkerrin has quit IRC02:33
devanandadtantsur|afk: around?02:36
*** vinbs has joined #openstack-ironic03:09
openstackgerritA change was merged to openstack/ironic: Add parallel_image_downloads option  https://review.openstack.org/9521303:13
openstackgerritA change was merged to openstack/ironic: Run keepalive in a dedicated thread  https://review.openstack.org/9308303:13
*** harlowja_ is now known as harlowja_away03:16
*** shakamunyi has joined #openstack-ironic03:19
*** dwalleck has joined #openstack-ironic03:21
*** shakamunyi has quit IRC03:24
*** eghobo has joined #openstack-ironic03:33
*** dwalleck has quit IRC03:34
*** Haomeng|2 has quit IRC03:40
mrdahey devananda - would you consider this appropriate behaviour?  https://bugs.launchpad.net/ironic/+bug/1315224  i.e. nodes should be powered off immediately after being added to ironic?03:45
*** nosnos has quit IRC03:47
*** shakamunyi has joined #openstack-ironic03:52
*** matsuhashi has quit IRC04:15
*** matsuhashi has joined #openstack-ironic04:26
*** nosnos has joined #openstack-ironic04:27
*** shakamunyi has quit IRC04:27
*** k4n0 has joined #openstack-ironic04:30
*** rameshg87 has joined #openstack-ironic04:39
*** lazy_prince has joined #openstack-ironic04:50
*** shakamunyi has joined #openstack-ironic04:52
*** shakamunyi has quit IRC04:54
*** radsy has quit IRC04:55
*** shakamunyi has joined #openstack-ironic05:12
*** lokesh184 has joined #openstack-ironic05:12
*** krtaylor has quit IRC05:15
*** shakamunyi has quit IRC05:40
*** shakamunyi has joined #openstack-ironic05:40
*** pradipta_away is now known as pradipta06:00
*** Mikhail_D_ltp has joined #openstack-ironic06:01
openstackgerritOpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex  https://review.openstack.org/9606306:02
*** eghobo has quit IRC06:05
*** rakesh_hs has joined #openstack-ironic06:16
*** sysexit has joined #openstack-ironic06:25
*** romcheg has joined #openstack-ironic06:30
*** sabah has joined #openstack-ironic06:37
*** pradipta is now known as pradipta_away06:38
*** boris-42 has quit IRC06:45
devanandamrda: hi! so - yes.06:48
devanandamrda: there's an option to control that behaviour now06:49
*** boris-42 has joined #openstack-ironic06:50
devanandamrda: the commit you reference even mentions this06:50
devanandamrda: ironic has a periodic task (of configurable interval) but tripleo is doing two unique things that warrant the workaround in 42cd4ca2a20415542ab99217fb384b1453bc9dd406:51
devananda1) registering nodes which are currently turned on06:51
devananda2) expecting to be able to deploy to them before Ironic has run its periodic power state sync06:51
devanandatherefor -- tripleo needs to explicitly tell ironic to set the power state to the one that tripleo expects the node to have06:51
*** Mikhail_D_ltp has quit IRC06:57
*** eghobo has joined #openstack-ironic06:58
lifelessdevananda: I'm not sure I agree that those two things are unique to tripleo :)07:03
lifelessdevananda: the first is accidental when it happens, the second is the result of automation which I think everyone will trigger :)07:04
*** jistr has joined #openstack-ironic07:05
*** derekh_ has joined #openstack-ironic07:08
devanandalifeless: s/unique/distinct/07:11
lifelessok :)07:11
*** ifarkas has joined #openstack-ironic07:14
mrdadevananda: ok, so the bug isn't :)  i.e. no change required to ironic code07:16
*** subah has joined #openstack-ironic07:19
*** sabah has quit IRC07:19
mrda...at least not high priority07:23
*** jcoufal has joined #openstack-ironic07:28
*** lokesh184 has quit IRC07:33
*** lazy_prince has quit IRC07:34
*** lazy_prince has joined #openstack-ironic07:35
mrdanight all07:43
*** mrda is now known as mrda-away07:43
*** eghobo has quit IRC07:44
*** lokesh184 has joined #openstack-ironic07:50
*** igordcard has joined #openstack-ironic07:52
lifelessmrda-away: hmm, would be really nice to fix soon actually, because we're about to have manual workarounds in production code forever07:54
*** dtantsur|afk is now known as dtantsur08:01
*** romcheg has quit IRC08:02
dtantsurLate morning, Ironic08:02
*** subah has quit IRC08:06
*** derekh_ has quit IRC08:09
*** derekh_ has joined #openstack-ironic08:11
*** coolsvap|afk is now known as coolsvap08:11
*** matsuhashi has quit IRC08:14
*** matsuhashi has joined #openstack-ironic08:15
*** matsuhashi has quit IRC08:17
*** matsuhashi has joined #openstack-ironic08:17
*** romcheg has joined #openstack-ironic08:25
*** sabah has joined #openstack-ironic08:30
*** lucasagomes has joined #openstack-ironic08:33
*** shakamunyi has quit IRC08:43
openstackgerritDmitry Tantsur proposed a change to openstack/ironic: Change NodeLocked status code to a client-side error  https://review.openstack.org/9557308:45
dtantsurlucasagomes, hi, could you revote on this ^^^08:46
lucasagomesdtantsur, hey yes, I'm right now testing a patch the pxe refactor08:47
lucasagomesi will go to that next08:47
dtantsurthnx!08:47
lucasagomesdtantsur, and good morning :)08:47
lucasagomesgood morning Ironic!08:47
yuriyzmorning Ironic08:49
lucasagomesdtantsur, reviwed08:53
lucasagomesreviewed*08:53
dtantsurmorning yuriyz!08:53
dtantsurlucasagomes, thnx!08:53
lucasagomesdtantsur, other than that it lgtm08:53
dtantsurgood point08:54
lucasagomesdtantsur, it's weird that the new reviews doesn't revoke our vote08:57
dtantsuryeah, that's always the case with changing commit message08:57
lucasagomesyeah, seems wrong to me, since we can vote based on the commit message08:59
openstackgerritDmitry Tantsur proposed a change to openstack/ironic: Change NodeLocked status code to a client-side error  https://review.openstack.org/9557308:59
dtantsurlucasagomes, update ^^^09:00
lucasagomesdtantsur, cool09:00
lucasagomesdtantsur, just waiting for jenkins, but changes lgtm!09:00
*** Mikhail_D_ltp has joined #openstack-ironic09:01
openstackgerritMartin Geisler proposed a change to openstack/python-ironicclient: Remove unnecessary coding lines  https://review.openstack.org/9610909:02
openstackgerritMartin Geisler proposed a change to openstack/python-ironicclient: Use Emacs-friendly file variable to set file encoding  https://review.openstack.org/9588209:02
*** pelix has joined #openstack-ironic09:03
*** takadayuiko has quit IRC09:18
*** lazy_prince has quit IRC09:19
*** lokesh184 has quit IRC09:20
openstackgerritDmitry Tantsur proposed a change to openstack/ironic: Consider free disk space before downloading images into cache  https://review.openstack.org/9262509:21
*** lokesh184 has joined #openstack-ironic09:22
*** martyntaylor has joined #openstack-ironic09:22
*** lazy_prince has joined #openstack-ironic09:22
*** radsy has joined #openstack-ironic09:27
*** radsy has joined #openstack-ironic09:27
*** ndipanov has joined #openstack-ironic09:28
*** ndipanov has quit IRC09:29
openstackgerritDmitry Tantsur proposed a change to openstack/ironic: PXE to pass hints to ImageCache on how much space to reclaim  https://review.openstack.org/9437109:32
*** sysexit has quit IRC09:36
*** shakamunyi has joined #openstack-ironic09:40
*** sysexit has joined #openstack-ironic09:41
*** shakamunyi has quit IRC09:45
*** boris-42 has quit IRC09:52
*** k4n0 has quit IRC09:54
*** dtantsur is now known as dtantsur|lunch09:56
*** romcheg has quit IRC10:01
*** max_lobur has joined #openstack-ironic10:04
*** k4n0 has joined #openstack-ironic10:07
*** lokesh184 has quit IRC10:12
*** boris-42 has joined #openstack-ironic10:15
openstackgerritA change was merged to openstack/ironic: Fix chassis bookmark link url  https://review.openstack.org/9459710:19
*** k4n0 has quit IRC10:30
*** sabah has quit IRC10:36
*** k4n0 has joined #openstack-ironic10:37
*** radsy has quit IRC10:43
*** matsuhashi has quit IRC10:48
*** sysexit has quit IRC10:54
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Add migration script to instance_info  https://review.openstack.org/9613610:55
*** Mikhail_D_ltp has quit IRC10:58
*** lokesh184 has joined #openstack-ironic11:05
*** rakesh_hs has quit IRC11:15
*** lucasagomes is now known as lucas-hungry11:15
*** rakesh_hs has joined #openstack-ironic11:15
*** rameshg87 has left #openstack-ironic11:20
*** yfujioka has joined #openstack-ironic11:20
*** romcheg has joined #openstack-ironic11:28
*** dtantsur|lunch is now known as dtantsur11:29
*** igordcard has quit IRC11:30
*** coolsvap is now known as coolsvap|afk11:33
*** lokesh184 has quit IRC11:52
*** k4n0 has quit IRC12:13
*** vinbs has quit IRC12:15
*** krtaylor has joined #openstack-ironic12:19
*** lucas-hungry is now known as lucasagomes12:23
*** rakesh_hs2 has joined #openstack-ironic12:33
*** sabah has joined #openstack-ironic12:34
*** rakesh_hs has quit IRC12:35
NobodyCamGood mroning Ironic12:36
*** jdob has joined #openstack-ironic12:37
*** lazy_prince has quit IRC12:37
*** linggao has joined #openstack-ironic12:38
*** lazy_prince has joined #openstack-ironic12:38
*** sysexit has joined #openstack-ironic12:43
dtantsurmorning, NobodyCam12:44
NobodyCammoring dtantsur :)12:44
*** nosnos has quit IRC12:50
lucasagomesmorning NobodyCam12:51
dtantsurNobodyCam, could you close https://bugs.launchpad.net/python-ironicclient/+bug/1285530 ?12:52
dtantsurappropriate code review was rejected12:52
dtantsurNobodyCam, also https://bugs.launchpad.net/python-ironicclient/+bug/1229324 it seems to be fixed12:54
* dtantsur thinks that even files on a Samba share is a better bug tracker than launchpad :-[12:55
NobodyCamlol12:55
*** jcoufal has quit IRC12:56
*** jcoufal has joined #openstack-ironic12:57
*** lazy_prince has quit IRC13:05
NobodyCamdtantsur: humm13:07
dtantsur?13:07
NobodyCamwas looking for the rejected code review13:08
*** sabah has quit IRC13:08
dtantsurNobodyCam, https://review.openstack.org/#/c/76803/13:09
NobodyCamok so that bug will be (for lack of a better word) "replaced" buy https://review.openstack.org/#/c/94924/4/specs/juno/improve-logging.rst13:20
*** romcheg has quit IRC13:20
*** romcheg1 has joined #openstack-ironic13:20
*** yfujioka has quit IRC13:23
*** rakesh_hs2 has quit IRC13:23
*** rakesh_hs has joined #openstack-ironic13:24
*** jbjohnso has joined #openstack-ironic13:30
*** Alexei_9871 has joined #openstack-ironic13:31
*** ifarkas_ has joined #openstack-ironic13:34
*** rloo has joined #openstack-ironic13:34
*** ifarkas has quit IRC13:34
dtantsurlucasagomes, mind having one more look at https://review.openstack.org/#/c/92625/ (about PXE cache and free disk space)?13:44
lucasagomesdtantsur, will do in a moment, looking at the email u sent to the list about the API13:44
lucasagomesdtantsur, thanks for that btw13:44
dtantsuroh, that's good, there is a lot of text there :)13:45
NobodyCamyep was just reading that too13:45
NobodyCammorning lucasagomes :)13:45
lucasagomesNobodyCam, morning :)13:47
*** jcoufal has quit IRC13:54
*** shakamunyi has joined #openstack-ironic13:54
*** jcoufal has joined #openstack-ironic13:55
*** jcoufal has quit IRC13:56
*** jcoufal has joined #openstack-ironic13:56
romcheg1Morning NobodyCam and everyone else13:58
*** romcheg1 is now known as romcheg13:59
dtantsurmorning, romcheg13:59
dtantsurand morning, rloo14:00
openstackgerritRakesh H S proposed a change to openstack/ironic: ipmi double bridging functionality  https://review.openstack.org/9577514:00
rloohi dtantsur, romcheg, lucasagomes, NobodyCam and everyone else! :D14:00
*** BadCub has joined #openstack-ironic14:01
lucasagomesrloo, morning :D14:02
romchegdtantsur: Is there a reason for not cleaning up all caches when there's not enough space?14:03
romchegI mean L29314:03
romchegdtantsur: in this patch https://review.openstack.org/#/c/92625/8/ironic/drivers/modules/pxe.py14:03
NobodyCammorning romcheg :)14:04
*** matty_dubs|gone is now known as matty_dubs14:05
NobodyCammorning rloo14:05
matty_dubsHowdy romcheg rloo NobodyCam14:09
NobodyCammorning matty_dubs14:09
rlooMornin' matty_dubs.14:11
devanandamorning, all14:13
matty_dubsmornin'14:15
dtantsurromcheg, cleaning can take a lot of time, and I'd like to start deploy asap14:16
dtantsurmorning devananda, matty_dubs14:16
romchegdtantsur: that makes sense14:17
NobodyCamgood morning devananda14:18
*** sysexit has quit IRC14:19
lucasagomesdevananda, morning14:22
*** foexle has joined #openstack-ironic14:26
lucasagomesNobodyCam, any news on the label problem thing? (my connection dropped so did my IRC so I don't have any backlogs from yest night) :(14:28
linggaomorning everyone.14:28
matty_dubsHi linggao14:30
linggaoHi matty_dubs14:30
romchegdtantsur: Giving it a run14:31
lucasagomesmorning linggao matty_dubs14:31
linggaoHi lucasagomes14:31
*** jcoufal has quit IRC14:33
linggaodevanana, mattry_dubs, can we have more console logging discussion?14:35
linggaosorry I always got dvananda's name wrong :(14:35
matty_dubsI always just use tab autocomplete for nicks; saves me from having to spell things right ;)14:36
matty_dubsBut sure!14:36
NobodyCamlucasagomes: I working on some test now.14:37
dtantsurmorning linggao14:37
matty_dubsOh, huh, it also seems that Red Hat (through Jaromir) has just offered to host a mid-cycle meetup14:37
linggaomorning dtantsur.14:37
NobodyCamlinggao: morning14:37
linggaomatty_dubs, ah, I learned something new.14:37
dtantsurmatty_dubs, wow14:37
linggaomorning NobodyCam14:37
NobodyCamlucasagomes: there is http://eavesdrop.openstack.org/irclogs/ for irc logs14:37
NobodyCam^^^^ just fyu14:38
NobodyCam:-p14:38
linggaoso everyone welcome to join the console logging discussion.14:38
NobodyCams/fyu/fyi/14:38
lucasagomesNobodyCam, ah I didn't know that14:38
lucasagomescheerios!14:38
matty_dubsI just learned this from openstack-dev, vs. the fact that I work for the company hosting it and it's a coworker that sent the email14:38
* dtantsur is out for a walk, be back later14:38
*** eghobo has joined #openstack-ironic14:39
linggaoThe main thing is that BMC does not save the log within itself. We have to open a session and keeps reading the console while it goes14:39
linggaoand saves it to a file.14:39
*** dtantsur is now known as dtantsur|afk14:39
linggaoThere are third party product like conserver http://www.conserver.com/ and confluent that are doing it.14:40
matty_dubsAnd that log should be somewhere shared, not one node :-\14:40
linggaoconfluent is the console server/client that jbjohso wrote for use in xCAT and OpenStack.14:41
*** sysexit has joined #openstack-ironic14:41
linggaojbjohnso made sure that the license is Apache2 so that it can be used by OpenStack14:42
jbjohnsoconfluent is easy enough to play with, fyi14:42
*** eghobo has quit IRC14:42
jbjohnsoif someone wants to try it out14:42
NobodyCamquick walkies... brb14:42
jbjohnsoand it's still not promising consistency such that possibilities are precluded14:43
matty_dubsI haven't really evaluated it thoroughly, but it seems like it might make the most sense to look at using something existing vs. reinventing the wheel14:43
linggao So the question is should we use confluent or conserver or reinvent the wheels.14:43
jbjohnsoe.g. at the *moment*, it puts stuff in /var/log/confluent/consoles/<name>14:43
jbjohnsoso pip install confluent_server14:43
jbjohnsoactually, let me link to my instructions, they are short...14:43
jbjohnsohttp://comments.gmane.org/gmane.comp.clustering.xcat.user/25914:44
linggaojbjohnso, if we use confluent, do you see each ironic-conductor host has one confluent server? (ironic-conductor is more like xCAT service node)14:45
jbjohnsothose are the 5 steps to try it out14:45
matty_dubsHa, from that URL I thought for a moment that it was a Usenet thread14:45
jbjohnsoconfluent currently does not care what you do to it in terms of hierarchy.  I plan for it one day to be able to be joined together and coordinate, but even then it would be an option whether to 'join' or just leave disparate14:46
jbjohnsoas it says in the instructions in the last line, there are currently three directories that are not yet configurable, but I was planning on having the locations configurable14:46
jbjohnsoif those directories are writable, that's all it cares about14:47
jbjohnsoanyway, looking for feedback14:48
jbjohnsothe log files are plaintext with external binary metadata to describe things like timestamps and stuff14:48
jbjohnsoand what users have connected and how connected they are and whether or not the terminal has a shift in character set or not and what the cursor key mode is..14:49
rloomatty_dubs: qq about https://review.openstack.org/83577. we should update the option descriptions. I can do it, but thought I'd give you first dibs.14:49
jbjohnsolinggao, you followed those instructions yet?14:49
jbjohnsoI was trying to make it a lot easier to use than other endeavors of mine...14:49
linggaojbjohnso, yes, I did.14:50
jbjohnsoit has an http interface, but the browser interface I need to put on git, someone would have to incorporate the web widget into a decent web interface instead of my little one that I showed on youtube14:50
*** rakesh_hs has quit IRC14:50
jbjohnsoI'm going to present something in a moment, so I'll be away.  I'll check the channel if my name is said again ;)14:50
linggaolike jbjohnso said, there are a lot to take care if we write our own console logging server in Ironic.14:51
linggaothanks jbjohnso14:51
jbjohnsoI'll also do a walkthrough of what all is there beyond consoles and under the covers stuff14:51
jbjohnsoif desired14:51
*** jgrimm has joined #openstack-ironic14:52
matty_dubsrloo: Whoops, sorry, IRL conversation interrupted me.14:53
matty_dubsrloo: I can take a look at doing it today.14:53
matty_dubsAm I supposed to create a blueprint?14:53
rloomatty_dubs: thx, no hurry. just wanted to make sure it was done so I can forget about it ;)14:54
rloomatty_dubs: no, a bug maybe. the help strings already exist; just update if they can be improved.14:54
jbjohnsomatty_dubs, yeah, this is the same thing I showed earlier, but now it can be installed and poked from CLI (the web can be poked too, but that's more easy to understand once I push my javascript code widget/example)14:57
jbjohnsoinstalled by anyone I should say14:57
linggaodevananda, matty_dubs how about this we do this in Ironic:  implmenent console logging in ironic-conductor for ipmitool driver. the logging will start when power_on command is issued. and the log will be flushed with next power_on command? For ipminative, we can use confluent for both interactive console and console logging.15:01
*** igordcard has joined #openstack-ironic15:02
linggaodevananda, matty_dubs, I mean write our own console logging code for ipmitool driver. And use 3rd party console server confluent for ipminative driver.15:04
lucasagomesNobodyCam, agree with lifeless that making the disk look blank for the next deploy is the right thing to do, perhaps should we have a bug about it as well that could be tagged with ur fix?15:05
matty_dubsHmm. I don't have a strong opinion, really. Writing our own isn't a lot of fun.15:06
linggaoI know.15:06
Ngdoes Ironic provision disk space that isn't claimed by the image, like nova would in a VM? (i.e. partition/format it, so it will be mounted as ephemeral storage)15:06
rloolucasagomes: https://review.openstack.org/#/c/92554/. I didn't approve because I didn't test. but Shrews did. Is that enough to approve?15:14
*** shakamunyi has quit IRC15:16
lucasagomesrloo, hmm... hard to asnwer heh15:16
lucasagomesrloo, I tested...15:16
lucasagomesbut, if it wasn't my patch I would probably going to give it a go before approving15:16
lucasagomesbut it's personal, I don't think that reviewers have to test everything before approving stuff15:17
lucasagomesif the conde looks good, and someone I trust already tested it I would approve15:17
rloolucasagomes: it seems to me that if it doesn't work, it most likely won't be due to the driver code ;)15:17
rloolucasagomes: ok, i'm going to approve it.15:17
lucasagomesbut it's up to the reviewer really15:17
lucasagomesdevananda, any inputs on that^15:17
lucasagomesrloo, ack15:17
Shrewshrm, that was 3 weeks ago. we could add a tempest test for that, i suppose15:17
lucasagomesrloo, thank you15:17
lucasagomesShrews, +115:18
rloolucasagomes: now that you asked devananda, I guess I should wait to see what he thinks.15:18
lucasagomesrloo, heh ok, I'm also very confused about such things15:18
Shrewslucasagomes: i'll add that since i just finished the rebuild test15:18
*** shakamunyi has joined #openstack-ironic15:18
lucasagomespersonally I don't think that it's an obligation to reviewers to actually test everything they review15:19
lucasagomesShrews, cooleo, thank you for that15:19
rlooShrews: good point. how/who adds tempest tests? is that something we should be thinking of when we make/approve changes?15:19
Shrewsrloo: imho, we should all be adding tempest changes as we see a deficiencies in our testing. we aren't testing much, atm, other than booting an instance in the scenario tests15:20
Shrewsand soon rebuild15:20
Shrewsand soon reboot15:20
rloolucasagomes: yeah, I don't think reviewers should test everything either. Ah, I'll approve it; don't want to wait.15:21
NobodyCamlucasagomes: yep.. as soon as I get thru a proxy issue I am having atm.15:22
NobodyCam:-p15:22
rlooShrews: I put on my evergrowing list, to learn about how to deal with tempest. is there a cheat sheet somewhere?15:22
Shrewsrloo: i just worked my way through http://docs.openstack.org/developer/tempest/ ... and bugged adam_g a lot  :)15:23
rloolucasagomes: sorry, another question about 92554. There are 'pass' in other functions in the driver. Do we know whether they are supposed to be 'pass'? If not, maybe we should return errors or something so it makes it easier to track down?15:23
lucasagomesrloo, hmm in the driver u mean?15:24
rlooShrews: thx. bed time reading. NOT.15:24
rloolucasagomes: yeah, in the driver. like the reboot() had.15:24
lucasagomesrloo, so depends of what nova is expecting for those funcitons, many of them might be hypervisor related and can't be implemented in Ironic so we just pass15:24
lucasagomesto fake it out to nova15:24
rloolucasagomes: ok. so might be worth going through and adding a comment to the ones we really mean to pass.15:25
lucasagomesrloo, it might very a lot from method to method, we should actually check each one to see if it's something that makes sense to us to implement15:25
rloolucasagomes: and replacing pass for the ones that we ought TODO.15:25
lucasagomesor if it's something we just want to stub15:25
rloolucasagomes: yeah. we probably want to do that before trying to get it into nova.15:25
lucasagomesvary*15:25
rloolucasagomes: do you have time to do that? or i can take a stab at it tomorrow or next week.15:26
lucasagomesrloo, yeah, actually not a comment, but a docstring saying that it's going to be ignore by the drive15:26
lucasagomesdriver* might be the correct way to do it as well15:26
rloolucasagomes: yeah, docstring.15:26
*** foexle has quit IRC15:28
lucasagomesrloo, what I'm doing is a bit related, cause I have/want to review the driver before we submit it to nova, right now I'm trying to sort out the refactors needed in ironic that will affect the driver like instance_info15:29
lucasagomesbut soon I will look at the driver's code as well15:29
lucasagomeswe probably will need both looking at this stuff15:29
lucasagomesit's easy to skip15:29
rloolucasagomes: good stuff. Thx!15:29
rloolucasagomes: will let you do the first pass, then I'll look :-)15:29
lucasagomeslol ack, will do soon15:29
lucasagomeslike tomorrow or so I will try to take a look at it15:29
rloolucasagomes: great!15:30
*** dwalleck has joined #openstack-ironic15:32
*** foexle has joined #openstack-ironic15:41
*** vinbs has joined #openstack-ironic15:41
*** zdin0bot has joined #openstack-ironic15:42
*** zdin0bot has joined #openstack-ironic15:43
*** igordcard has quit IRC15:44
*** jistr has quit IRC15:50
*** vinbs has quit IRC15:52
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: SSH virsh to use the new ManagementInterface  https://review.openstack.org/8988415:54
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: IPMITool to use the new ManagementInterface  https://review.openstack.org/8609215:54
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: SeaMicro to use the new ManagementInterface  https://review.openstack.org/8632815:54
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: IPMINative to use the new ManagementInterface  https://review.openstack.org/8658815:54
*** eghobo has joined #openstack-ironic15:54
*** martyntaylor has left #openstack-ironic15:55
devanandarloo: so, there really should be tempest test coverage for anything that the nova.virt.ironic driver does15:59
devanandarloo: in this case (92554) we'd need to do some awkward juggling to get tempest to test it before it lands -- since we couldn't land the tempest test without it passing (or we'd break our gate)16:00
*** derekh_ has quit IRC16:00
*** derekh_ has joined #openstack-ironic16:01
rloodevananda: so code has to land first, then tempest test can be updated/added?16:02
Shrewsi think it takes tempest longer to land changes than ironic, so it would probably work out anyway   :)16:02
rloodevananda: w/o going through contortions.16:02
devanandarloo: in an ideal, test-driven-development world, we'd land the tempest change first -- but in some non-voting way16:03
devanandaor we'd have an ability to gate both changes (which are in separate projects) together16:03
devanandabut that doesn't exist (in gerrit/jenkins/zuul) yet16:03
rloodevananda: must be the same problem that other projects have too then.16:03
devanandayep16:03
Shrewsrloo: tempest is run via devstack, so the latest master branch of ironic is cloned, then tests are run against it. so the support needs to be in ironic tree first.16:04
Shrewsif that makes sense16:04
devananda^ yes, unless you're working on a featurebranch (which is where cross project feature branch support comes in, which we dont have yet)16:04
rloowhen we have code changes, we can check at the same time that there are unit tests16:05
rloowondering how we will remember to check that there will be tempest tests.16:05
devanandayou can also make non-voting tests in tempest IIRC, but then the path is: land test that doesn't pass and doesn't vote; land code that passes test; make test voting;16:05
devanandarloo: tempest tests at a higher layer -- it's a black-box functionality test16:06
devanandarloo: we don't need tempest tests for every patch we land in ironic16:06
devanandajust the significant API visible functionality16:06
lucasagomesthat's good info :)16:06
rloodevananda: right, so 1. need to know which changes require a tempest test; 2. make sure those tests exist after change has landed.16:07
openstackgerritJosh Gachnang proposed a change to openstack/ironic: Drivers determine acceptable power states  https://review.openstack.org/8674416:07
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Pass kwargs to ClientWrapper's call() method  https://review.openstack.org/9238416:07
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: list_instances() to return a list of instances names  https://review.openstack.org/9238516:07
rloodevananda: 'significant' API not 'any' API...?16:08
devanandarloo: it's fair to make sure the tempest change exists (as a WIP) before the change lands in ironic16:08
devanandarloo: which also allows you to download that tempest change and run it locally to make sure it passes16:09
*** ifarkas_ has quit IRC16:09
devanandathere are ways to make that ^ happen upstream, but it's a hassle right now. it's worth it for really big things (like landing ironic in nova's tree) but not for every patch16:09
rloodevananda: i'm fine if the tempest change passes after the code has landed. want to minimize the amount of work for us.16:10
devanandarloo: right -- i mean, it's fair for us to block an ironic change until there is, at least, a tempest change proposed that covers it16:11
devananda(assuming it makes sense for tempest to test it)16:11
rloodevananda: if we block, it means the developer that makes the change is responsible for a corresponding tempest change. Is that reasonable?16:12
*** foexle has quit IRC16:12
rloojust thinking that it is probably reasonable. i'm just worried about the 'overhead' for a developer to get a change in.16:12
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Add the remaining unittests to the ClientWrapper class  https://review.openstack.org/9241616:12
devanandarloo: or said developer needs to work with another developer who can help write tempest tests16:13
*** ifarkas has joined #openstack-ironic16:13
rloodevananda: right. but said developer is responsible for making sure it happens :-)16:13
devanandaif they want their patch to land :)16:13
rlooi'm fine with it. will make sure that lucasagomes makes all such changes! :D16:14
lucasagomeslol16:14
rloonow, do we have guidelines or something where we can capture this?16:14
lucasagomeswiki?16:14
devanandammm, wiki for breakfast16:15
*** romcheg has quit IRC16:15
rlooscrambled kiwi? :)16:15
rloostill, ewww16:15
devanandaalso, coffee. i should have some16:15
* Shrews replaces NobodyCam's breakfast bagel with a breakfast wiki16:15
lucasagomesrloo, ew, scrambled kiwi!? ppl do that?16:15
NobodyCamlol16:15
devanandai know some kiwi's who might resent being eaten for breakfast16:16
NobodyCamlol16:16
rloolucasagomes: scrambled kiwi == wiki ;)16:16
lucasagomeslol16:16
rloooops, forgot about those kiwis. forget i mentioned it.16:16
lucasagomesok got it now16:16
*** matty_dubs is now known as matty_dubs|lunch16:17
matty_dubs|lunch^ not scrambled kiwi16:17
lucasagomesif I had a band I would name it scrambled kiwi now16:17
NobodyCamlol: lucasagomes and the Scrambled Kiwi's16:19
lucasagomeslol16:19
*** dwalleck has quit IRC16:20
*** derekh_ has quit IRC16:23
*** igordcard has joined #openstack-ironic16:25
rloogoing back to wikis, I don't see placeholder for things like the tempest tests. from the ironic wiki, you can get to eg http://docs.openstack.org/developer/ironic/dev/contributing.html, and then to https://wiki.openstack.org/wiki/HowToContribute.16:25
*** foexle has joined #openstack-ironic16:25
lucasagomesrloo, hmm maybe start a new page for those guidelines?16:27
*** zdin0bot has quit IRC16:27
lucasagomes(we also may want to start adding new pages for other stuff, like code guidelines etc)16:28
rloolucasagomes: I suppose a page with those guidelines and maybe other ones would be useful.16:28
lucasagomes+116:28
NobodyCam+116:28
rloolucasagomes: would be good to be a wiki though so anyone can edit it.16:28
lucasagomesyeah, it's easier to edit if needed16:29
rlooor etherpad?16:29
rlooi suppose wiki is better.16:29
NobodyCam-1 for etherpad16:29
NobodyCam:-p16:29
rlooanyone know how to add wiki pages, and link it off of our main one: https://wiki.openstack.org/wiki/Ironic?16:30
lucasagomeshttps://wiki.openstack.org/w/index.php?title=Ironic&action=edit&section=116:31
lucasagomesI think to open a new link to a page16:31
lucasagomesyou simply put it between []16:31
lucasagomeslike [new link] and then the wiki will create a link called new link16:31
lucasagomeswhich you can after click and edit16:31
*** foexle has quit IRC16:31
*** bearhands is now known as comstud16:32
lucasagomesactually it might be [[ ]]16:32
lucasagomesdouble brackets16:32
*** jdob has quit IRC16:33
rloolucasagomes: ok, thx. guess i can play around. how much harm can I do? :-)16:33
lucasagomeslol16:33
lucasagomesyeah16:33
lucasagomesu can always see the preview before saving it :)16:34
NobodyCamlucasagomes: gots a minute16:41
openstackgerritChris Krelle proposed a change to openstack/ironic: Wipe any matadata from a nodes disk on first deploy  https://review.openstack.org/9313316:41
NobodyCamlucasagomes: ^^^^16:41
lucasagomesNobodyCam, hey will take a look16:41
lucasagomesthanks16:41
rlooNobodyCam: metadata, not matadata ;)16:41
NobodyCamdoh16:42
NobodyCamjust set wip16:42
NobodyCamits not ready to land16:42
NobodyCamjust wanted to have eyes on it16:42
*** ellenh has joined #openstack-ironic16:42
rlooNobodyCam: looking forward to it landing!16:43
NobodyCamyes16:43
NobodyCamwoo a new error this time!16:43
NobodyCamhappy happy joy joy16:43
devanandaNobodyCam: you're creating a DiskPartitioner instance, for the same device, twice. why?16:44
NobodyCamis that with get_part_dict16:46
NobodyCamI need to redo that16:46
NobodyCamI guess it the work_on_disk change what I wanted to be seen16:49
NobodyCambrb16:50
devanandainstead of splitting make_partitions in two functions, add an optinoal parameter that tells it not to db.commit()16:50
NobodyCamyea that was what I thought after I split16:51
NobodyCamit out16:51
NobodyCamI don't like the split out right now :)16:51
*** zdin0bot has joined #openstack-ironic16:53
*** vinbs has joined #openstack-ironic16:53
*** dwalleck has joined #openstack-ironic16:55
*** eghobo has quit IRC16:56
*** eghobo has joined #openstack-ironic16:59
*** BadCub has quit IRC17:00
*** matty_dubs|lunch is now known as matty_dubs17:01
lucasagomesNobodyCam, reviewed17:04
lucasagomesdevananda, +1 yeah I suggested that as well17:04
lucasagomesalso the counting is wrong, it's not wiping 18KiB it's wiping 9Kib there,, 512*1817:05
devanandaNobodyCam: reviewed17:05
*** vinbs has quit IRC17:08
* devananda goes to work on the async-api spec doc17:08
lucasagomesdevananda, this thing about not recreating the part table if we need to preserve ephemeral17:09
devananda?17:09
lucasagomesdevananda, in a rebuild, if the new image is bigger than the previous one17:09
lucasagomesit might not fit in the previous layout17:09
lucasagomesI'm kinda worried about it, maybe I'm not seem things correctly17:09
devanandalucasagomes: root part is created based on the nova flavor's root_gb setting, not the image size17:10
devanandalucasagomes: assuming growroot wasn't used, and the image is smaller than root_gb, i think it's fine17:10
devanandaif growroot was used, the point is moot anyway17:10
lucasagomesright17:10
lucasagomesyeah hmm17:10
*** ifarkas has quit IRC17:10
devanandaand if the image is bigger than root_gb, things are broken anyway :)17:10
lucasagomesheh17:11
devanandaunless i'm missing something17:11
lucasagomeswe have a sanity check for that :)17:11
lucasagomesI think17:11
lucasagomescool yeah17:11
openstackgerritChris Krelle proposed a change to openstack/ironic: Wipe any metadata from a nodes disk on first deploy  https://review.openstack.org/9313317:11
*** eghobo has quit IRC17:11
NobodyCamgah irssi locked up17:13
NobodyCamthat only address the split out17:14
NobodyCamwill address the other comments in next rev17:14
NobodyCamstil battling proxy and poor internet17:14
rloolucasagomes, devananda, NobodyCam, anyone that wants some reading: I added a note about tempest tests here: https://wiki.openstack.org/wiki/Ironic/Developer_guidelines, linked from https://wiki.openstack.org/wiki/Ironic#Developers. Please edit as you see fit.17:15
*** harlowja_away is now known as harlowja_17:16
NobodyCamdoh ty lucasagomes for the math error catch :-p17:17
lucasagomesNobodyCam, just small concerns about the amount of data ur wiping (9KiB insteand of 18KiB)17:17
lucasagomesyeah17:17
devanandarloo: ++17:17
NobodyCamdoh,17:17
lucasagomesNobodyCam, other than that concerns, and the i18N log problem that devananda pointed out on the previous review I'm fine with it17:17
lucasagomesrloo, will check17:17
lucasagomesrloo, ah great start!17:17
NobodyCamack that was what I was really looking for ,,, I will clean up!17:18
devanandarloo: fwiw, the same is true (we ought to blck patches if ...) regarding in-tree doc updates17:18
devanandas/ought/can/17:18
rloodevananda: what do you mean by in-tree doc updates?17:19
lucasagomesalright I will call it a day :)17:19
devanandaactually, never mind. that really applies to developer docs, and not as much deployer docs, which are more end-of-cycle right now17:19
rloodevananda: okay ;)17:20
rloolucasagomes: ciao17:20
devanandalucasagomes: g'night!17:20
lucasagomesdevananda, btw deva, if get a time... is it the kinda of migration script we are expecting for the instance_info? script we are expecting for the migration17:20
lucasagomesops17:20
rlooI'm sure there are other guidelines that can be added, but I can't think of any right now.17:20
lucasagomeshttps://review.openstack.org/#/c/96136/17:20
lucasagomesrloo, devananda good night17:20
lucasagomesdevananda, don't need to check it now, when u get some free time only17:21
devanandarloo: related to your update, ave you seen https://wiki.openstack.org/wiki/Ironic/Testing ?17:21
*** lucasagomes is now known as lucas-dinner17:21
NobodyCamnight lucas-dinner17:21
lucas-dinnerNobodyCam, night :)17:21
rloodevananda: yeah. I was going to link to it, but forgot. I think maybe cuz I'd have to link it in somehow and I ran out of words. ha ha.17:21
jbjohnsoahh... now my kvm consoles are under conflunet too17:22
devanandalucas-dinner: something along those lines, i think -- but we should check with sdague, as he offered to give some help with grenade testing17:23
rlooback in an hour or so.17:24
*** rloo has quit IRC17:24
*** jdob has joined #openstack-ironic17:28
*** Alexei_9871 has quit IRC17:34
devanandaanyone know if ifarkas is around / working on https://bugs.launchpad.net/ironic/+bug/1314961 ?17:37
devanandahe assigned it to himself about 3 weeks ago then hasn't proposed any code17:38
devanandaand I dont see him on IRC17:38
lifelessNg: no, cloud-init does17:42
matty_dubsI'm not sure if ifarkas is working on that or not. Thought it's 19:45 in his TZ so we probably won't catch him until tomorrow17:44
*** max_lobur has quit IRC17:47
NobodyCambrb17:49
dtantsur|afkdevananda, ifarkas is around earlier, he should be gone by now17:56
dtantsur|afkit's 8pm here in Czech :)17:56
*** dtantsur|afk is now known as dtantsur17:56
devanandadtantsur: ah, thanks17:57
dtantsurthat is really troublesome: e.g. I make pause in the middle of the day and get back in the evening so that to catch up with all you :)17:57
dtantsurdevananda, btw, you already saw my mail on ML? You can consider it a loong comment on async spec :)18:03
devanandadtantsur: yea, about to send a reply18:05
openstackgerritChris Krelle proposed a change to openstack/ironic: Wipe any metadata from a nodes disk on first deploy  https://review.openstack.org/9313318:08
matty_dubsSo, the .ninja TLD opened up today. Someone already took 'openstack.ninja' :'(18:10
lifelessNobodyCam: 'repartition'18:10
NobodyCamlol just -1 for that18:11
NobodyCam:-p18:11
lifelessreviewing now18:11
NobodyCami just -1'd for that :-p18:11
lifelessbut yes thats egregious :)18:11
dtantsurdevananda, lifeless, also could you have a look at https://review.openstack.org/95573 (proposed fix for NodeLocked problem)?18:14
lifelessNobodyCam: actual -1 for other things :)18:17
lifelessdtantsur: do we have 409 retry support in the client ?18:17
dtantsurlifeless, depending on what you mean by "support". It does output a nice message.18:18
dtantsur(I mean, cli output, library itself sees at as Conflict exception, I guess)18:18
NobodyCamack just saw error in some tests too18:19
dtantsurNobodyCam, btw, what's the situation with bugs, which I can't close?18:23
NobodyCamI could not close18:24
devanandalifeless: the nova side implements retry for this. python-ironicclient does not automatically retry18:26
devanandadtantsur: there are some bugs in LP which are not closable via the UI (eg, bugs which affect 10's of projects)18:26
devanandadtantsur: there's an email interface for LP which I have been told works18:27
devanandabut i haven't tried it yet18:27
*** zdin0bot has quit IRC18:27
dtantsurwow18:27
*** zdin0bot has joined #openstack-ironic18:27
*** rloo has joined #openstack-ironic18:27
dtantsurnot sure how to use it also...18:27
devanandalifeless: are you reviewing 95573? if so, i'll wait to approve it a bit longer18:28
*** datajerk1 has joined #openstack-ironic18:29
*** datajerk has quit IRC18:30
*** rloo has quit IRC18:33
*** rloo has joined #openstack-ironic18:33
*** rloo has quit IRC18:33
*** dwalleck_ has joined #openstack-ironic18:34
dtantsur"Sorry, something went wrong when Launchpad tried processing your mail."  <-- well, email interface does not seems to work18:34
openstackgerritA change was merged to openstack/ironic: Consider free disk space before downloading images into cache  https://review.openstack.org/9262518:34
*** rloo has joined #openstack-ironic18:34
openstackgerritA change was merged to openstack/ironic: Implement the reboot command on the Ironic Driver  https://review.openstack.org/9255418:34
openstackgerritChris Krelle proposed a change to openstack/ironic: Wipe any metadata from a nodes disk on first deploy  https://review.openstack.org/9313318:35
*** dwalleck_ has quit IRC18:36
*** dwalleck has quit IRC18:38
*** dwalleck_ has joined #openstack-ironic18:38
*** dwalleck_ has quit IRC18:38
*** rloo has quit IRC18:38
*** dwalleck has joined #openstack-ironic18:39
*** rloo has joined #openstack-ironic18:39
*** rloo has quit IRC18:39
*** sysexit has quit IRC18:40
*** rloo has joined #openstack-ironic18:40
*** rloo has quit IRC18:40
*** rloo has joined #openstack-ironic18:41
*** datajerk1 has quit IRC18:41
*** datajerk has joined #openstack-ironic18:42
devanandadtantsur: hah :(18:43
*** eghobo has joined #openstack-ironic18:43
dtantsurdevananda, I opened a question at launchpad project, following instruction in the mail I got18:43
dtantsurhope that will help...18:43
*** rloo has quit IRC18:43
dtantsurhttps://answers.launchpad.net/launchpad/+question/24943518:43
*** rloo has joined #openstack-ironic18:43
NobodyCambrb18:48
*** rloo has quit IRC18:48
*** rloo has joined #openstack-ironic18:49
*** datajerk has quit IRC18:52
*** datajerk1 has joined #openstack-ironic18:53
*** bandicot has joined #openstack-ironic18:54
*** dwalleck has quit IRC18:59
*** dwalleck has joined #openstack-ironic18:59
*** matty_dubs is now known as matty_dubs|gone19:01
*** dwalleck has quit IRC19:04
*** zdin0bot has quit IRC19:05
*** dwalleck has joined #openstack-ironic19:06
*** romcheg has joined #openstack-ironic19:08
*** bandicot has quit IRC19:11
dtantsurI'm done for today, g'night, Ironic19:11
NobodyCamhave a good night dtantsur19:11
*** datajerk1 has quit IRC19:11
*** dtantsur is now known as dtantsur|afk19:12
NobodyCammmmm /me looks for food stuffs19:13
openstackgerritOpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements  https://review.openstack.org/9622819:14
*** datajerk has joined #openstack-ironic19:21
*** dwalleck has quit IRC19:23
*** dwalleck has joined #openstack-ironic19:24
*** pelix has quit IRC19:28
*** max_lobur has joined #openstack-ironic19:34
*** datajerk has quit IRC19:36
*** datajerk has joined #openstack-ironic19:38
*** tatyana has joined #openstack-ironic19:44
*** tatyana has quit IRC19:46
*** datajerk1 has joined #openstack-ironic19:54
*** datajerk has quit IRC19:54
*** sysexit has joined #openstack-ironic19:57
*** datajerk1 has quit IRC19:59
*** dwalleck has quit IRC19:59
NobodyCamdevananda: where you holding off landing 9557320:00
*** zdiN0bot has joined #openstack-ironic20:00
*** dwalleck has joined #openstack-ironic20:02
devanandaNobodyCam: i thought lifeless was reviewing it, so held off. if not, i'll approve now20:04
*** zdiN0bot has quit IRC20:04
*** zdin0bot has joined #openstack-ironic20:05
lifelessoh dtantsur|afk asked fora  review and I got context switched before getting to it20:05
lifelessdevananda: w.r.t. retries - I was thinking of the CLI and tools like os-cloud-config that will also need to retry; it would be nice to be able to say '--retry-for 10s'20:06
*** max_lobur1 has joined #openstack-ironic20:09
devanandalifeless: remind me, in what context is occ talking to ironic directly?20:09
*** zdin0bot has quit IRC20:10
*** max_lobur has quit IRC20:11
lifelessdevananda: in register-nodes20:12
devanandalifeless: right. that shouldn't ever hit this issue20:12
devanandalifeless: creating a node shouldn't be touching RPC20:12
* devananda checks the code to see if it changed when he wasnt' looking20:13
lifelessdevananda: we power the node off when we create it20:13
lifelessdevananda: per the workaround for bug 131522420:13
devanandalifeless: ooh. right20:13
devanandanvm20:13
* devananda wishes the API was async20:14
devanandaI feel like we're doing a lot of work arounds right now for this, when we should just fix it20:14
devanandathings like power-off and tear-down would be low hanging fruit20:14
lifelessyeah, I support fixing it20:15
lifelessthus reviewing the spec :)20:15
devananda:)20:16
*** ellenh has quit IRC20:18
*** max_lobur1 has quit IRC20:18
*** gmatefi has joined #openstack-ironic20:21
*** r-daneel has joined #openstack-ironic20:22
*** gmatefi has quit IRC20:33
*** bandicot has joined #openstack-ironic20:40
Shrewsso, adding a tempest test for the new reboot support is a bit tricky20:48
Shrewshow do we verify that it actually rebooted? the power state can (and does) change way too quickly to test against that20:49
*** bandicot has quit IRC20:50
Shrewsso i'm open to ideas20:50
*** jdob has quit IRC20:52
dwalleckShrews: The way I've done it in the past it to check the actual server uptime20:52
dwalleckUnless someone ripped it out, the Tempest tests used to do that20:53
Shrewsdwalleck: ooh, great idea. remember which test that was?20:53
Shrewsso i can stealz your codez20:53
dwalleckThere's also the instance-actions extension that shows what actions have taken place for a server, but I'm not sure that's reliable20:54
dwalleckLets see....20:54
dwalleckSo there's this in Tempest (test_reboot_server_hard if the run_ssh option is enabled) https://github.com/openstack/tempest/blob/master/tempest/api/compute/servers/test_server_actions.py20:55
dwalleckI don't think it is for gate though, otherwise it would've caught it earlier20:55
*** bandicot has joined #openstack-ironic20:56
Shrewsoh, there's also a get_boot_time() i can make use of20:56
Shrewsas part of RemoteClient20:56
dwalleckYessir. There's a whole ssh client to abstract things like that for simplicity20:56
Shrewsdwalleck: great. thx20:57
dwalleckOr if it's in fubar in Tempest, here's what I actually found it with (https://github.com/stackforge/cloudroast/blob/master/cloudroast/compute/functional/servers/actions/test_reboot_server_soft.py)20:57
Shrewscool20:57
openstackgerritOpenStack Proposal Bot proposed a change to openstack/python-ironicclient: Updated from global requirements  https://review.openstack.org/9626320:59
*** jbjohnso has quit IRC21:01
NobodyCambrb21:02
*** eghobo has quit IRC21:04
*** zdin0bot has joined #openstack-ironic21:06
*** ellenh has joined #openstack-ironic21:07
*** eghobo has joined #openstack-ironic21:07
*** zdin0bot has quit IRC21:10
*** bandicot has quit IRC21:13
NobodyCamnow this is new: TypeError: get_node_mac_addresses() takes exactly 2 arguments (1 given)21:17
*** BadCub has joined #openstack-ironic21:18
*** sysexit has quit IRC21:19
*** eghobo has quit IRC21:27
openstackgerritDevananda van der Veen proposed a change to openstack/ironic-specs: Make the REST API fully asynchronous  https://review.openstack.org/9492321:30
*** zdiN0bot has joined #openstack-ironic21:31
*** zdiN0bot has quit IRC21:32
*** zdiN0bot has joined #openstack-ironic21:33
*** Penick has joined #openstack-ironic21:39
*** dwalleck has quit IRC21:39
*** zdin0bot1 has joined #openstack-ironic21:40
NobodyCamoh next error: Error: node_set_boot_device() got multiple values for keyword argument 'persistent' :-p21:41
*** zdiN0bot has quit IRC21:43
NobodyCambrb21:44
*** zdin0bot1 has quit IRC21:45
openstackgerritJosh Gachnang proposed a change to openstack/ironic: Factoring out PXE and TFTP functions  https://review.openstack.org/9023321:46
openstackgerritJosh Gachnang proposed a change to openstack/ironic: Adding a reference driver for the agent  https://review.openstack.org/8479521:46
*** mrda-away is now known as mrda21:47
mrdaMorning Ironic!21:47
devanandamornin, mrda !21:52
* devananda has some offline things to take care of, and will probably be offline for most of the afternoon21:53
*** bandicot has joined #openstack-ironic21:53
mrdahi devananda!21:54
* mrda reading scrollback21:54
NobodyCamgood morning mrda21:55
*** dhellmann is now known as dhellmann_21:58
*** dhellmann_ is now known as dhellmann21:58
*** dhellmann is now known as dhellmann_21:58
mrdadevananda: so just on https://bugs.launchpad.net/ironic/+bug/1315224  What is the desired behaviour?  Is it to just improve the latency of asserting the power state post-registration? Should we ensure nodes are powered off post-registration?  Should we do nothing because ironic will eventually get there?  Which solution sounds most reasonable to you?22:01
*** ekarlso has quit IRC22:01
*** ellenh has quit IRC22:01
devanandaasserting power state post-registration seems reasonable to me22:04
devanandahowever22:05
devanandait doesn't make sense in some ways given today's api22:05
devanandayou register a node. but you can't register it WITH a power state22:05
devanandaso then ironic checks the node's current power state and /might/ go turn it off22:05
mrdaso adding an optional desired_power_state might be the way forward?22:06
mrda...to the api22:06
lifelessShrews: hi22:06
devanandamrda: dont think that's good either22:06
lifelessShrews: are you looking into the block device metadata missing thing ?22:06
devanandamrda: but i need to run now :(22:06
mrdaok, no problems22:07
* devananda will bbl or bbtmw22:07
mrdatalk later devananda - thanks22:07
lifelessdevananda: huh, why wouldn't it turn it off like it does now, just more quickly ?22:07
lifelessdevananda: I agree that we could do more, but that seems orthogonal22:07
*** bandicot has quit IRC22:08
lifelessShrews: https://bugs.launchpad.net/tripleo/+bug/132428622:08
*** lucas-dinner has quit IRC22:13
*** jgrimm has quit IRC22:13
*** ellenh has joined #openstack-ironic22:15
NobodyCamomg 890c39b4-a95f-48c3-a115-49e588d26869 | epDeployTest | ACTIVE22:21
NobodyCam:-p22:21
*** r-daneel has quit IRC22:26
*** ekarlso has joined #openstack-ironic22:26
*** jdonalds has joined #openstack-ironic22:28
Shrewslifeless: no, i was simply curious. is that metadata something ironic is responsible for?22:28
openstackgerritChris Krelle proposed a change to openstack/ironic: Wipe any metadata from a nodes disk on first deploy  https://review.openstack.org/9313322:28
Shrewsor is that a nova thing?22:28
*** dwalleck has joined #openstack-ironic22:29
*** eghobo has joined #openstack-ironic22:34
*** dwalleck_ has joined #openstack-ironic22:35
*** dwalleck_ has quit IRC22:36
*** dwalleck_ has joined #openstack-ironic22:36
*** dwalleck_ has quit IRC22:36
lifelessShrews: the nova driver22:37
*** dwalleck_ has joined #openstack-ironic22:37
lifelessShrews: so its a patch to ironic/nova/virt/...22:37
lifelessShrews: its pretty critical to make ephemeral support work; I'd love it if you were to do it :)22:38
Shrewslifeless: ah, i think i see it now. the old bm driver has a call to _set_default_ephemeral_device() in spawn(). i don't think we replicate that22:38
Shrewslifeless: looks easy enough to fix. i'll look at it tomorrow22:38
*** dwalleck has quit IRC22:39
*** radsy has joined #openstack-ironic22:39
*** radsy has joined #openstack-ironic22:39
lifelessShrews: cool22:40
NobodyCamlifeless: gota a second to peek at 93133.. Just tested and this time it actually preserves the ephemeral partition when asked to :-p22:40
lifelessNobodyCam: I just +2'd it22:41
*** zdin0bot has joined #openstack-ironic22:41
NobodyCamw00t!!!! NobodyCam does Happy Dance22:41
*** ellenh has quit IRC22:42
mrdalol22:43
NobodyCammrda: Uploaded patch set 41. :-p22:43
NobodyCamhehehe22:44
mrdaSo nova gets into the 80's, so you've got a way to go :)22:44
NobodyCamthat patch kinda lost it way in life22:44
NobodyCamlol and I thought only neutron got up that high22:44
mrdaso long as it eventually gets through22:45
NobodyCamyep :)22:45
*** zdin0bot has quit IRC22:46
mrda...which reminds me - it's code review time22:46
NobodyCamafter five here... time for a strawberry daiquiri22:49
NobodyCam:-p22:49
mrdabefore 8:30am here, time for coffee :P22:50
NobodyCamhehheehe22:50
*** zdiN0bot has joined #openstack-ironic22:51
NobodyCamlol daiquiri too much work ... bud light easier22:53
*** romcheg has quit IRC22:54
lifelessNobodyCam: but so much less tasty23:01
NobodyCamthis is true :)23:02
*** BadCub has quit IRC23:04
*** linggao has quit IRC23:16
*** zdiN0bot has quit IRC23:33
*** dwalleck_ has quit IRC23:35
*** zdin0bot has joined #openstack-ironic23:42
Shrewsdevananda: bug https://bugs.launchpad.net/tripleo/+bug/1324286 will need some discussion, i think23:45
*** zdin0bot has quit IRC23:46
* Shrews now leaves to attempt to enjoy his evening23:46
*** foexle has joined #openstack-ironic23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!