*** matsuhashi has joined #openstack-ironic | 00:01 | |
*** radsy has joined #openstack-ironic | 00:04 | |
*** takadayuiko has joined #openstack-ironic | 00:06 | |
*** zdiN0bot1 has quit IRC | 00:08 | |
*** Penick has joined #openstack-ironic | 00:10 | |
adam_g | bummer. ubuntu's tgt utilites are not built with aio support | 00:14 |
---|---|---|
*** Penick has quit IRC | 00:16 | |
*** shakamunyi has quit IRC | 00:18 | |
*** Penick has joined #openstack-ironic | 00:19 | |
* devananda is back | 00:21 | |
* devananda now includes tacos and coffee | 00:21 | |
openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Factoring out PXE and TFTP functions https://review.openstack.org/90233 | 00:22 |
openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Adding a reference driver for the agent https://review.openstack.org/84795 | 00:22 |
*** lazy_prince has joined #openstack-ironic | 00:24 | |
*** BadCub01_ has quit IRC | 00:57 | |
openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Factoring out PXE and TFTP functions https://review.openstack.org/90233 | 01:03 |
openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Adding a reference driver for the agent https://review.openstack.org/84795 | 01:04 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Remove vim modelines https://review.openstack.org/95983 | 01:15 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/python-ironicclient: Remove vim modelines https://review.openstack.org/95985 | 01:20 |
*** eguz has quit IRC | 01:27 | |
*** rloo has quit IRC | 01:45 | |
*** nosnos has joined #openstack-ironic | 01:48 | |
*** martyntaylor has quit IRC | 02:08 | |
devananda | dhellmann: know if there are any plans to add 3xx status code handling to wsme? (not that ironic needs it, but it looks like it's not supported, so i'm glad we dont need it) | 02:09 |
devananda | dhellmann: oh - perhaps it's just not set up to handle exceptions with 3xx codes? if so, never mind, I was thinking I could raise those | 02:11 |
*** lazy_prince has quit IRC | 02:13 | |
*** mkerrin1 has joined #openstack-ironic | 02:32 | |
*** mkerrin has quit IRC | 02:33 | |
devananda | dtantsur|afk: around? | 02:36 |
*** vinbs has joined #openstack-ironic | 03:09 | |
openstackgerrit | A change was merged to openstack/ironic: Add parallel_image_downloads option https://review.openstack.org/95213 | 03:13 |
openstackgerrit | A change was merged to openstack/ironic: Run keepalive in a dedicated thread https://review.openstack.org/93083 | 03:13 |
*** harlowja_ is now known as harlowja_away | 03:16 | |
*** shakamunyi has joined #openstack-ironic | 03:19 | |
*** dwalleck has joined #openstack-ironic | 03:21 | |
*** shakamunyi has quit IRC | 03:24 | |
*** eghobo has joined #openstack-ironic | 03:33 | |
*** dwalleck has quit IRC | 03:34 | |
*** Haomeng|2 has quit IRC | 03:40 | |
mrda | hey devananda - would you consider this appropriate behaviour? https://bugs.launchpad.net/ironic/+bug/1315224 i.e. nodes should be powered off immediately after being added to ironic? | 03:45 |
*** nosnos has quit IRC | 03:47 | |
*** shakamunyi has joined #openstack-ironic | 03:52 | |
*** matsuhashi has quit IRC | 04:15 | |
*** matsuhashi has joined #openstack-ironic | 04:26 | |
*** nosnos has joined #openstack-ironic | 04:27 | |
*** shakamunyi has quit IRC | 04:27 | |
*** k4n0 has joined #openstack-ironic | 04:30 | |
*** rameshg87 has joined #openstack-ironic | 04:39 | |
*** lazy_prince has joined #openstack-ironic | 04:50 | |
*** shakamunyi has joined #openstack-ironic | 04:52 | |
*** shakamunyi has quit IRC | 04:54 | |
*** radsy has quit IRC | 04:55 | |
*** shakamunyi has joined #openstack-ironic | 05:12 | |
*** lokesh184 has joined #openstack-ironic | 05:12 | |
*** krtaylor has quit IRC | 05:15 | |
*** shakamunyi has quit IRC | 05:40 | |
*** shakamunyi has joined #openstack-ironic | 05:40 | |
*** pradipta_away is now known as pradipta | 06:00 | |
*** Mikhail_D_ltp has joined #openstack-ironic | 06:01 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/96063 | 06:02 |
*** eghobo has quit IRC | 06:05 | |
*** rakesh_hs has joined #openstack-ironic | 06:16 | |
*** sysexit has joined #openstack-ironic | 06:25 | |
*** romcheg has joined #openstack-ironic | 06:30 | |
*** sabah has joined #openstack-ironic | 06:37 | |
*** pradipta is now known as pradipta_away | 06:38 | |
*** boris-42 has quit IRC | 06:45 | |
devananda | mrda: hi! so - yes. | 06:48 |
devananda | mrda: there's an option to control that behaviour now | 06:49 |
*** boris-42 has joined #openstack-ironic | 06:50 | |
devananda | mrda: the commit you reference even mentions this | 06:50 |
devananda | mrda: ironic has a periodic task (of configurable interval) but tripleo is doing two unique things that warrant the workaround in 42cd4ca2a20415542ab99217fb384b1453bc9dd4 | 06:51 |
devananda | 1) registering nodes which are currently turned on | 06:51 |
devananda | 2) expecting to be able to deploy to them before Ironic has run its periodic power state sync | 06:51 |
devananda | therefor -- tripleo needs to explicitly tell ironic to set the power state to the one that tripleo expects the node to have | 06:51 |
*** Mikhail_D_ltp has quit IRC | 06:57 | |
*** eghobo has joined #openstack-ironic | 06:58 | |
lifeless | devananda: I'm not sure I agree that those two things are unique to tripleo :) | 07:03 |
lifeless | devananda: the first is accidental when it happens, the second is the result of automation which I think everyone will trigger :) | 07:04 |
*** jistr has joined #openstack-ironic | 07:05 | |
*** derekh_ has joined #openstack-ironic | 07:08 | |
devananda | lifeless: s/unique/distinct/ | 07:11 |
lifeless | ok :) | 07:11 |
*** ifarkas has joined #openstack-ironic | 07:14 | |
mrda | devananda: ok, so the bug isn't :) i.e. no change required to ironic code | 07:16 |
*** subah has joined #openstack-ironic | 07:19 | |
*** sabah has quit IRC | 07:19 | |
mrda | ...at least not high priority | 07:23 |
*** jcoufal has joined #openstack-ironic | 07:28 | |
*** lokesh184 has quit IRC | 07:33 | |
*** lazy_prince has quit IRC | 07:34 | |
*** lazy_prince has joined #openstack-ironic | 07:35 | |
mrda | night all | 07:43 |
*** mrda is now known as mrda-away | 07:43 | |
*** eghobo has quit IRC | 07:44 | |
*** lokesh184 has joined #openstack-ironic | 07:50 | |
*** igordcard has joined #openstack-ironic | 07:52 | |
lifeless | mrda-away: hmm, would be really nice to fix soon actually, because we're about to have manual workarounds in production code forever | 07:54 |
*** dtantsur|afk is now known as dtantsur | 08:01 | |
*** romcheg has quit IRC | 08:02 | |
dtantsur | Late morning, Ironic | 08:02 |
*** subah has quit IRC | 08:06 | |
*** derekh_ has quit IRC | 08:09 | |
*** derekh_ has joined #openstack-ironic | 08:11 | |
*** coolsvap|afk is now known as coolsvap | 08:11 | |
*** matsuhashi has quit IRC | 08:14 | |
*** matsuhashi has joined #openstack-ironic | 08:15 | |
*** matsuhashi has quit IRC | 08:17 | |
*** matsuhashi has joined #openstack-ironic | 08:17 | |
*** romcheg has joined #openstack-ironic | 08:25 | |
*** sabah has joined #openstack-ironic | 08:30 | |
*** lucasagomes has joined #openstack-ironic | 08:33 | |
*** shakamunyi has quit IRC | 08:43 | |
openstackgerrit | Dmitry Tantsur proposed a change to openstack/ironic: Change NodeLocked status code to a client-side error https://review.openstack.org/95573 | 08:45 |
dtantsur | lucasagomes, hi, could you revote on this ^^^ | 08:46 |
lucasagomes | dtantsur, hey yes, I'm right now testing a patch the pxe refactor | 08:47 |
lucasagomes | i will go to that next | 08:47 |
dtantsur | thnx! | 08:47 |
lucasagomes | dtantsur, and good morning :) | 08:47 |
lucasagomes | good morning Ironic! | 08:47 |
yuriyz | morning Ironic | 08:49 |
lucasagomes | dtantsur, reviwed | 08:53 |
lucasagomes | reviewed* | 08:53 |
dtantsur | morning yuriyz! | 08:53 |
dtantsur | lucasagomes, thnx! | 08:53 |
lucasagomes | dtantsur, other than that it lgtm | 08:53 |
dtantsur | good point | 08:54 |
lucasagomes | dtantsur, it's weird that the new reviews doesn't revoke our vote | 08:57 |
dtantsur | yeah, that's always the case with changing commit message | 08:57 |
lucasagomes | yeah, seems wrong to me, since we can vote based on the commit message | 08:59 |
openstackgerrit | Dmitry Tantsur proposed a change to openstack/ironic: Change NodeLocked status code to a client-side error https://review.openstack.org/95573 | 08:59 |
dtantsur | lucasagomes, update ^^^ | 09:00 |
lucasagomes | dtantsur, cool | 09:00 |
lucasagomes | dtantsur, just waiting for jenkins, but changes lgtm! | 09:00 |
*** Mikhail_D_ltp has joined #openstack-ironic | 09:01 | |
openstackgerrit | Martin Geisler proposed a change to openstack/python-ironicclient: Remove unnecessary coding lines https://review.openstack.org/96109 | 09:02 |
openstackgerrit | Martin Geisler proposed a change to openstack/python-ironicclient: Use Emacs-friendly file variable to set file encoding https://review.openstack.org/95882 | 09:02 |
*** pelix has joined #openstack-ironic | 09:03 | |
*** takadayuiko has quit IRC | 09:18 | |
*** lazy_prince has quit IRC | 09:19 | |
*** lokesh184 has quit IRC | 09:20 | |
openstackgerrit | Dmitry Tantsur proposed a change to openstack/ironic: Consider free disk space before downloading images into cache https://review.openstack.org/92625 | 09:21 |
*** lokesh184 has joined #openstack-ironic | 09:22 | |
*** martyntaylor has joined #openstack-ironic | 09:22 | |
*** lazy_prince has joined #openstack-ironic | 09:22 | |
*** radsy has joined #openstack-ironic | 09:27 | |
*** radsy has joined #openstack-ironic | 09:27 | |
*** ndipanov has joined #openstack-ironic | 09:28 | |
*** ndipanov has quit IRC | 09:29 | |
openstackgerrit | Dmitry Tantsur proposed a change to openstack/ironic: PXE to pass hints to ImageCache on how much space to reclaim https://review.openstack.org/94371 | 09:32 |
*** sysexit has quit IRC | 09:36 | |
*** shakamunyi has joined #openstack-ironic | 09:40 | |
*** sysexit has joined #openstack-ironic | 09:41 | |
*** shakamunyi has quit IRC | 09:45 | |
*** boris-42 has quit IRC | 09:52 | |
*** k4n0 has quit IRC | 09:54 | |
*** dtantsur is now known as dtantsur|lunch | 09:56 | |
*** romcheg has quit IRC | 10:01 | |
*** max_lobur has joined #openstack-ironic | 10:04 | |
*** k4n0 has joined #openstack-ironic | 10:07 | |
*** lokesh184 has quit IRC | 10:12 | |
*** boris-42 has joined #openstack-ironic | 10:15 | |
openstackgerrit | A change was merged to openstack/ironic: Fix chassis bookmark link url https://review.openstack.org/94597 | 10:19 |
*** k4n0 has quit IRC | 10:30 | |
*** sabah has quit IRC | 10:36 | |
*** k4n0 has joined #openstack-ironic | 10:37 | |
*** radsy has quit IRC | 10:43 | |
*** matsuhashi has quit IRC | 10:48 | |
*** sysexit has quit IRC | 10:54 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Add migration script to instance_info https://review.openstack.org/96136 | 10:55 |
*** Mikhail_D_ltp has quit IRC | 10:58 | |
*** lokesh184 has joined #openstack-ironic | 11:05 | |
*** rakesh_hs has quit IRC | 11:15 | |
*** lucasagomes is now known as lucas-hungry | 11:15 | |
*** rakesh_hs has joined #openstack-ironic | 11:15 | |
*** rameshg87 has left #openstack-ironic | 11:20 | |
*** yfujioka has joined #openstack-ironic | 11:20 | |
*** romcheg has joined #openstack-ironic | 11:28 | |
*** dtantsur|lunch is now known as dtantsur | 11:29 | |
*** igordcard has quit IRC | 11:30 | |
*** coolsvap is now known as coolsvap|afk | 11:33 | |
*** lokesh184 has quit IRC | 11:52 | |
*** k4n0 has quit IRC | 12:13 | |
*** vinbs has quit IRC | 12:15 | |
*** krtaylor has joined #openstack-ironic | 12:19 | |
*** lucas-hungry is now known as lucasagomes | 12:23 | |
*** rakesh_hs2 has joined #openstack-ironic | 12:33 | |
*** sabah has joined #openstack-ironic | 12:34 | |
*** rakesh_hs has quit IRC | 12:35 | |
NobodyCam | Good mroning Ironic | 12:36 |
*** jdob has joined #openstack-ironic | 12:37 | |
*** lazy_prince has quit IRC | 12:37 | |
*** linggao has joined #openstack-ironic | 12:38 | |
*** lazy_prince has joined #openstack-ironic | 12:38 | |
*** sysexit has joined #openstack-ironic | 12:43 | |
dtantsur | morning, NobodyCam | 12:44 |
NobodyCam | moring dtantsur :) | 12:44 |
*** nosnos has quit IRC | 12:50 | |
lucasagomes | morning NobodyCam | 12:51 |
dtantsur | NobodyCam, could you close https://bugs.launchpad.net/python-ironicclient/+bug/1285530 ? | 12:52 |
dtantsur | appropriate code review was rejected | 12:52 |
dtantsur | NobodyCam, also https://bugs.launchpad.net/python-ironicclient/+bug/1229324 it seems to be fixed | 12:54 |
* dtantsur thinks that even files on a Samba share is a better bug tracker than launchpad :-[ | 12:55 | |
NobodyCam | lol | 12:55 |
*** jcoufal has quit IRC | 12:56 | |
*** jcoufal has joined #openstack-ironic | 12:57 | |
*** lazy_prince has quit IRC | 13:05 | |
NobodyCam | dtantsur: humm | 13:07 |
dtantsur | ? | 13:07 |
NobodyCam | was looking for the rejected code review | 13:08 |
*** sabah has quit IRC | 13:08 | |
dtantsur | NobodyCam, https://review.openstack.org/#/c/76803/ | 13:09 |
NobodyCam | ok so that bug will be (for lack of a better word) "replaced" buy https://review.openstack.org/#/c/94924/4/specs/juno/improve-logging.rst | 13:20 |
*** romcheg has quit IRC | 13:20 | |
*** romcheg1 has joined #openstack-ironic | 13:20 | |
*** yfujioka has quit IRC | 13:23 | |
*** rakesh_hs2 has quit IRC | 13:23 | |
*** rakesh_hs has joined #openstack-ironic | 13:24 | |
*** jbjohnso has joined #openstack-ironic | 13:30 | |
*** Alexei_9871 has joined #openstack-ironic | 13:31 | |
*** ifarkas_ has joined #openstack-ironic | 13:34 | |
*** rloo has joined #openstack-ironic | 13:34 | |
*** ifarkas has quit IRC | 13:34 | |
dtantsur | lucasagomes, mind having one more look at https://review.openstack.org/#/c/92625/ (about PXE cache and free disk space)? | 13:44 |
lucasagomes | dtantsur, will do in a moment, looking at the email u sent to the list about the API | 13:44 |
lucasagomes | dtantsur, thanks for that btw | 13:44 |
dtantsur | oh, that's good, there is a lot of text there :) | 13:45 |
NobodyCam | yep was just reading that too | 13:45 |
NobodyCam | morning lucasagomes :) | 13:45 |
lucasagomes | NobodyCam, morning :) | 13:47 |
*** jcoufal has quit IRC | 13:54 | |
*** shakamunyi has joined #openstack-ironic | 13:54 | |
*** jcoufal has joined #openstack-ironic | 13:55 | |
*** jcoufal has quit IRC | 13:56 | |
*** jcoufal has joined #openstack-ironic | 13:56 | |
romcheg1 | Morning NobodyCam and everyone else | 13:58 |
*** romcheg1 is now known as romcheg | 13:59 | |
dtantsur | morning, romcheg | 13:59 |
dtantsur | and morning, rloo | 14:00 |
openstackgerrit | Rakesh H S proposed a change to openstack/ironic: ipmi double bridging functionality https://review.openstack.org/95775 | 14:00 |
rloo | hi dtantsur, romcheg, lucasagomes, NobodyCam and everyone else! :D | 14:00 |
*** BadCub has joined #openstack-ironic | 14:01 | |
lucasagomes | rloo, morning :D | 14:02 |
romcheg | dtantsur: Is there a reason for not cleaning up all caches when there's not enough space? | 14:03 |
romcheg | I mean L293 | 14:03 |
romcheg | dtantsur: in this patch https://review.openstack.org/#/c/92625/8/ironic/drivers/modules/pxe.py | 14:03 |
NobodyCam | morning romcheg :) | 14:04 |
*** matty_dubs|gone is now known as matty_dubs | 14:05 | |
NobodyCam | morning rloo | 14:05 |
matty_dubs | Howdy romcheg rloo NobodyCam | 14:09 |
NobodyCam | morning matty_dubs | 14:09 |
rloo | Mornin' matty_dubs. | 14:11 |
devananda | morning, all | 14:13 |
matty_dubs | mornin' | 14:15 |
dtantsur | romcheg, cleaning can take a lot of time, and I'd like to start deploy asap | 14:16 |
dtantsur | morning devananda, matty_dubs | 14:16 |
romcheg | dtantsur: that makes sense | 14:17 |
NobodyCam | good morning devananda | 14:18 |
*** sysexit has quit IRC | 14:19 | |
lucasagomes | devananda, morning | 14:22 |
*** foexle has joined #openstack-ironic | 14:26 | |
lucasagomes | NobodyCam, any news on the label problem thing? (my connection dropped so did my IRC so I don't have any backlogs from yest night) :( | 14:28 |
linggao | morning everyone. | 14:28 |
matty_dubs | Hi linggao | 14:30 |
linggao | Hi matty_dubs | 14:30 |
romcheg | dtantsur: Giving it a run | 14:31 |
lucasagomes | morning linggao matty_dubs | 14:31 |
linggao | Hi lucasagomes | 14:31 |
*** jcoufal has quit IRC | 14:33 | |
linggao | devanana, mattry_dubs, can we have more console logging discussion? | 14:35 |
linggao | sorry I always got dvananda's name wrong :( | 14:35 |
matty_dubs | I always just use tab autocomplete for nicks; saves me from having to spell things right ;) | 14:36 |
matty_dubs | But sure! | 14:36 |
NobodyCam | lucasagomes: I working on some test now. | 14:37 |
dtantsur | morning linggao | 14:37 |
matty_dubs | Oh, huh, it also seems that Red Hat (through Jaromir) has just offered to host a mid-cycle meetup | 14:37 |
linggao | morning dtantsur. | 14:37 |
NobodyCam | linggao: morning | 14:37 |
linggao | matty_dubs, ah, I learned something new. | 14:37 |
dtantsur | matty_dubs, wow | 14:37 |
linggao | morning NobodyCam | 14:37 |
NobodyCam | lucasagomes: there is http://eavesdrop.openstack.org/irclogs/ for irc logs | 14:37 |
NobodyCam | ^^^^ just fyu | 14:38 |
NobodyCam | :-p | 14:38 |
linggao | so everyone welcome to join the console logging discussion. | 14:38 |
NobodyCam | s/fyu/fyi/ | 14:38 |
lucasagomes | NobodyCam, ah I didn't know that | 14:38 |
lucasagomes | cheerios! | 14:38 |
matty_dubs | I just learned this from openstack-dev, vs. the fact that I work for the company hosting it and it's a coworker that sent the email | 14:38 |
* dtantsur is out for a walk, be back later | 14:38 | |
*** eghobo has joined #openstack-ironic | 14:39 | |
linggao | The main thing is that BMC does not save the log within itself. We have to open a session and keeps reading the console while it goes | 14:39 |
linggao | and saves it to a file. | 14:39 |
*** dtantsur is now known as dtantsur|afk | 14:39 | |
linggao | There are third party product like conserver http://www.conserver.com/ and confluent that are doing it. | 14:40 |
matty_dubs | And that log should be somewhere shared, not one node :-\ | 14:40 |
linggao | confluent is the console server/client that jbjohso wrote for use in xCAT and OpenStack. | 14:41 |
*** sysexit has joined #openstack-ironic | 14:41 | |
linggao | jbjohnso made sure that the license is Apache2 so that it can be used by OpenStack | 14:42 |
jbjohnso | confluent is easy enough to play with, fyi | 14:42 |
*** eghobo has quit IRC | 14:42 | |
jbjohnso | if someone wants to try it out | 14:42 |
NobodyCam | quick walkies... brb | 14:42 |
jbjohnso | and it's still not promising consistency such that possibilities are precluded | 14:43 |
matty_dubs | I haven't really evaluated it thoroughly, but it seems like it might make the most sense to look at using something existing vs. reinventing the wheel | 14:43 |
linggao | So the question is should we use confluent or conserver or reinvent the wheels. | 14:43 |
jbjohnso | e.g. at the *moment*, it puts stuff in /var/log/confluent/consoles/<name> | 14:43 |
jbjohnso | so pip install confluent_server | 14:43 |
jbjohnso | actually, let me link to my instructions, they are short... | 14:43 |
jbjohnso | http://comments.gmane.org/gmane.comp.clustering.xcat.user/259 | 14:44 |
linggao | jbjohnso, if we use confluent, do you see each ironic-conductor host has one confluent server? (ironic-conductor is more like xCAT service node) | 14:45 |
jbjohnso | those are the 5 steps to try it out | 14:45 |
matty_dubs | Ha, from that URL I thought for a moment that it was a Usenet thread | 14:45 |
jbjohnso | confluent currently does not care what you do to it in terms of hierarchy. I plan for it one day to be able to be joined together and coordinate, but even then it would be an option whether to 'join' or just leave disparate | 14:46 |
jbjohnso | as it says in the instructions in the last line, there are currently three directories that are not yet configurable, but I was planning on having the locations configurable | 14:46 |
jbjohnso | if those directories are writable, that's all it cares about | 14:47 |
jbjohnso | anyway, looking for feedback | 14:48 |
jbjohnso | the log files are plaintext with external binary metadata to describe things like timestamps and stuff | 14:48 |
jbjohnso | and what users have connected and how connected they are and whether or not the terminal has a shift in character set or not and what the cursor key mode is.. | 14:49 |
rloo | matty_dubs: qq about https://review.openstack.org/83577. we should update the option descriptions. I can do it, but thought I'd give you first dibs. | 14:49 |
jbjohnso | linggao, you followed those instructions yet? | 14:49 |
jbjohnso | I was trying to make it a lot easier to use than other endeavors of mine... | 14:49 |
linggao | jbjohnso, yes, I did. | 14:50 |
jbjohnso | it has an http interface, but the browser interface I need to put on git, someone would have to incorporate the web widget into a decent web interface instead of my little one that I showed on youtube | 14:50 |
*** rakesh_hs has quit IRC | 14:50 | |
jbjohnso | I'm going to present something in a moment, so I'll be away. I'll check the channel if my name is said again ;) | 14:50 |
linggao | like jbjohnso said, there are a lot to take care if we write our own console logging server in Ironic. | 14:51 |
linggao | thanks jbjohnso | 14:51 |
jbjohnso | I'll also do a walkthrough of what all is there beyond consoles and under the covers stuff | 14:51 |
jbjohnso | if desired | 14:51 |
*** jgrimm has joined #openstack-ironic | 14:52 | |
matty_dubs | rloo: Whoops, sorry, IRL conversation interrupted me. | 14:53 |
matty_dubs | rloo: I can take a look at doing it today. | 14:53 |
matty_dubs | Am I supposed to create a blueprint? | 14:53 |
rloo | matty_dubs: thx, no hurry. just wanted to make sure it was done so I can forget about it ;) | 14:54 |
rloo | matty_dubs: no, a bug maybe. the help strings already exist; just update if they can be improved. | 14:54 |
jbjohnso | matty_dubs, yeah, this is the same thing I showed earlier, but now it can be installed and poked from CLI (the web can be poked too, but that's more easy to understand once I push my javascript code widget/example) | 14:57 |
jbjohnso | installed by anyone I should say | 14:57 |
linggao | devananda, matty_dubs how about this we do this in Ironic: implmenent console logging in ironic-conductor for ipmitool driver. the logging will start when power_on command is issued. and the log will be flushed with next power_on command? For ipminative, we can use confluent for both interactive console and console logging. | 15:01 |
*** igordcard has joined #openstack-ironic | 15:02 | |
linggao | devananda, matty_dubs, I mean write our own console logging code for ipmitool driver. And use 3rd party console server confluent for ipminative driver. | 15:04 |
lucasagomes | NobodyCam, agree with lifeless that making the disk look blank for the next deploy is the right thing to do, perhaps should we have a bug about it as well that could be tagged with ur fix? | 15:05 |
matty_dubs | Hmm. I don't have a strong opinion, really. Writing our own isn't a lot of fun. | 15:06 |
linggao | I know. | 15:06 |
Ng | does Ironic provision disk space that isn't claimed by the image, like nova would in a VM? (i.e. partition/format it, so it will be mounted as ephemeral storage) | 15:06 |
rloo | lucasagomes: https://review.openstack.org/#/c/92554/. I didn't approve because I didn't test. but Shrews did. Is that enough to approve? | 15:14 |
*** shakamunyi has quit IRC | 15:16 | |
lucasagomes | rloo, hmm... hard to asnwer heh | 15:16 |
lucasagomes | rloo, I tested... | 15:16 |
lucasagomes | but, if it wasn't my patch I would probably going to give it a go before approving | 15:16 |
lucasagomes | but it's personal, I don't think that reviewers have to test everything before approving stuff | 15:17 |
lucasagomes | if the conde looks good, and someone I trust already tested it I would approve | 15:17 |
rloo | lucasagomes: it seems to me that if it doesn't work, it most likely won't be due to the driver code ;) | 15:17 |
rloo | lucasagomes: ok, i'm going to approve it. | 15:17 |
lucasagomes | but it's up to the reviewer really | 15:17 |
lucasagomes | devananda, any inputs on that^ | 15:17 |
lucasagomes | rloo, ack | 15:17 |
Shrews | hrm, that was 3 weeks ago. we could add a tempest test for that, i suppose | 15:17 |
lucasagomes | rloo, thank you | 15:17 |
lucasagomes | Shrews, +1 | 15:18 |
rloo | lucasagomes: now that you asked devananda, I guess I should wait to see what he thinks. | 15:18 |
lucasagomes | rloo, heh ok, I'm also very confused about such things | 15:18 |
Shrews | lucasagomes: i'll add that since i just finished the rebuild test | 15:18 |
*** shakamunyi has joined #openstack-ironic | 15:18 | |
lucasagomes | personally I don't think that it's an obligation to reviewers to actually test everything they review | 15:19 |
lucasagomes | Shrews, cooleo, thank you for that | 15:19 |
rloo | Shrews: good point. how/who adds tempest tests? is that something we should be thinking of when we make/approve changes? | 15:19 |
Shrews | rloo: imho, we should all be adding tempest changes as we see a deficiencies in our testing. we aren't testing much, atm, other than booting an instance in the scenario tests | 15:20 |
Shrews | and soon rebuild | 15:20 |
Shrews | and soon reboot | 15:20 |
rloo | lucasagomes: yeah, I don't think reviewers should test everything either. Ah, I'll approve it; don't want to wait. | 15:21 |
NobodyCam | lucasagomes: yep.. as soon as I get thru a proxy issue I am having atm. | 15:22 |
NobodyCam | :-p | 15:22 |
rloo | Shrews: I put on my evergrowing list, to learn about how to deal with tempest. is there a cheat sheet somewhere? | 15:22 |
Shrews | rloo: i just worked my way through http://docs.openstack.org/developer/tempest/ ... and bugged adam_g a lot :) | 15:23 |
rloo | lucasagomes: sorry, another question about 92554. There are 'pass' in other functions in the driver. Do we know whether they are supposed to be 'pass'? If not, maybe we should return errors or something so it makes it easier to track down? | 15:23 |
lucasagomes | rloo, hmm in the driver u mean? | 15:24 |
rloo | Shrews: thx. bed time reading. NOT. | 15:24 |
rloo | lucasagomes: yeah, in the driver. like the reboot() had. | 15:24 |
lucasagomes | rloo, so depends of what nova is expecting for those funcitons, many of them might be hypervisor related and can't be implemented in Ironic so we just pass | 15:24 |
lucasagomes | to fake it out to nova | 15:24 |
rloo | lucasagomes: ok. so might be worth going through and adding a comment to the ones we really mean to pass. | 15:25 |
lucasagomes | rloo, it might very a lot from method to method, we should actually check each one to see if it's something that makes sense to us to implement | 15:25 |
rloo | lucasagomes: and replacing pass for the ones that we ought TODO. | 15:25 |
lucasagomes | or if it's something we just want to stub | 15:25 |
rloo | lucasagomes: yeah. we probably want to do that before trying to get it into nova. | 15:25 |
lucasagomes | vary* | 15:25 |
rloo | lucasagomes: do you have time to do that? or i can take a stab at it tomorrow or next week. | 15:26 |
lucasagomes | rloo, yeah, actually not a comment, but a docstring saying that it's going to be ignore by the drive | 15:26 |
lucasagomes | driver* might be the correct way to do it as well | 15:26 |
rloo | lucasagomes: yeah, docstring. | 15:26 |
*** foexle has quit IRC | 15:28 | |
lucasagomes | rloo, what I'm doing is a bit related, cause I have/want to review the driver before we submit it to nova, right now I'm trying to sort out the refactors needed in ironic that will affect the driver like instance_info | 15:29 |
lucasagomes | but soon I will look at the driver's code as well | 15:29 |
lucasagomes | we probably will need both looking at this stuff | 15:29 |
lucasagomes | it's easy to skip | 15:29 |
rloo | lucasagomes: good stuff. Thx! | 15:29 |
rloo | lucasagomes: will let you do the first pass, then I'll look :-) | 15:29 |
lucasagomes | lol ack, will do soon | 15:29 |
lucasagomes | like tomorrow or so I will try to take a look at it | 15:29 |
rloo | lucasagomes: great! | 15:30 |
*** dwalleck has joined #openstack-ironic | 15:32 | |
*** foexle has joined #openstack-ironic | 15:41 | |
*** vinbs has joined #openstack-ironic | 15:41 | |
*** zdin0bot has joined #openstack-ironic | 15:42 | |
*** zdin0bot has joined #openstack-ironic | 15:43 | |
*** igordcard has quit IRC | 15:44 | |
*** jistr has quit IRC | 15:50 | |
*** vinbs has quit IRC | 15:52 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: SSH virsh to use the new ManagementInterface https://review.openstack.org/89884 | 15:54 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: IPMITool to use the new ManagementInterface https://review.openstack.org/86092 | 15:54 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: SeaMicro to use the new ManagementInterface https://review.openstack.org/86328 | 15:54 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: IPMINative to use the new ManagementInterface https://review.openstack.org/86588 | 15:54 |
*** eghobo has joined #openstack-ironic | 15:54 | |
*** martyntaylor has left #openstack-ironic | 15:55 | |
devananda | rloo: so, there really should be tempest test coverage for anything that the nova.virt.ironic driver does | 15:59 |
devananda | rloo: in this case (92554) we'd need to do some awkward juggling to get tempest to test it before it lands -- since we couldn't land the tempest test without it passing (or we'd break our gate) | 16:00 |
*** derekh_ has quit IRC | 16:00 | |
*** derekh_ has joined #openstack-ironic | 16:01 | |
rloo | devananda: so code has to land first, then tempest test can be updated/added? | 16:02 |
Shrews | i think it takes tempest longer to land changes than ironic, so it would probably work out anyway :) | 16:02 |
rloo | devananda: w/o going through contortions. | 16:02 |
devananda | rloo: in an ideal, test-driven-development world, we'd land the tempest change first -- but in some non-voting way | 16:03 |
devananda | or we'd have an ability to gate both changes (which are in separate projects) together | 16:03 |
devananda | but that doesn't exist (in gerrit/jenkins/zuul) yet | 16:03 |
rloo | devananda: must be the same problem that other projects have too then. | 16:03 |
devananda | yep | 16:03 |
Shrews | rloo: tempest is run via devstack, so the latest master branch of ironic is cloned, then tests are run against it. so the support needs to be in ironic tree first. | 16:04 |
Shrews | if that makes sense | 16:04 |
devananda | ^ yes, unless you're working on a featurebranch (which is where cross project feature branch support comes in, which we dont have yet) | 16:04 |
rloo | when we have code changes, we can check at the same time that there are unit tests | 16:05 |
rloo | wondering how we will remember to check that there will be tempest tests. | 16:05 |
devananda | you can also make non-voting tests in tempest IIRC, but then the path is: land test that doesn't pass and doesn't vote; land code that passes test; make test voting; | 16:05 |
devananda | rloo: tempest tests at a higher layer -- it's a black-box functionality test | 16:06 |
devananda | rloo: we don't need tempest tests for every patch we land in ironic | 16:06 |
devananda | just the significant API visible functionality | 16:06 |
lucasagomes | that's good info :) | 16:06 |
rloo | devananda: right, so 1. need to know which changes require a tempest test; 2. make sure those tests exist after change has landed. | 16:07 |
openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Drivers determine acceptable power states https://review.openstack.org/86744 | 16:07 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Pass kwargs to ClientWrapper's call() method https://review.openstack.org/92384 | 16:07 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: list_instances() to return a list of instances names https://review.openstack.org/92385 | 16:07 |
rloo | devananda: 'significant' API not 'any' API...? | 16:08 |
devananda | rloo: it's fair to make sure the tempest change exists (as a WIP) before the change lands in ironic | 16:08 |
devananda | rloo: which also allows you to download that tempest change and run it locally to make sure it passes | 16:09 |
*** ifarkas_ has quit IRC | 16:09 | |
devananda | there are ways to make that ^ happen upstream, but it's a hassle right now. it's worth it for really big things (like landing ironic in nova's tree) but not for every patch | 16:09 |
rloo | devananda: i'm fine if the tempest change passes after the code has landed. want to minimize the amount of work for us. | 16:10 |
devananda | rloo: right -- i mean, it's fair for us to block an ironic change until there is, at least, a tempest change proposed that covers it | 16:11 |
devananda | (assuming it makes sense for tempest to test it) | 16:11 |
rloo | devananda: if we block, it means the developer that makes the change is responsible for a corresponding tempest change. Is that reasonable? | 16:12 |
*** foexle has quit IRC | 16:12 | |
rloo | just thinking that it is probably reasonable. i'm just worried about the 'overhead' for a developer to get a change in. | 16:12 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Add the remaining unittests to the ClientWrapper class https://review.openstack.org/92416 | 16:12 |
devananda | rloo: or said developer needs to work with another developer who can help write tempest tests | 16:13 |
*** ifarkas has joined #openstack-ironic | 16:13 | |
rloo | devananda: right. but said developer is responsible for making sure it happens :-) | 16:13 |
devananda | if they want their patch to land :) | 16:13 |
rloo | i'm fine with it. will make sure that lucasagomes makes all such changes! :D | 16:14 |
lucasagomes | lol | 16:14 |
rloo | now, do we have guidelines or something where we can capture this? | 16:14 |
lucasagomes | wiki? | 16:14 |
devananda | mmm, wiki for breakfast | 16:15 |
*** romcheg has quit IRC | 16:15 | |
rloo | scrambled kiwi? :) | 16:15 |
rloo | still, ewww | 16:15 |
devananda | also, coffee. i should have some | 16:15 |
* Shrews replaces NobodyCam's breakfast bagel with a breakfast wiki | 16:15 | |
lucasagomes | rloo, ew, scrambled kiwi!? ppl do that? | 16:15 |
NobodyCam | lol | 16:15 |
devananda | i know some kiwi's who might resent being eaten for breakfast | 16:16 |
NobodyCam | lol | 16:16 |
rloo | lucasagomes: scrambled kiwi == wiki ;) | 16:16 |
lucasagomes | lol | 16:16 |
rloo | oops, forgot about those kiwis. forget i mentioned it. | 16:16 |
lucasagomes | ok got it now | 16:16 |
*** matty_dubs is now known as matty_dubs|lunch | 16:17 | |
matty_dubs|lunch | ^ not scrambled kiwi | 16:17 |
lucasagomes | if I had a band I would name it scrambled kiwi now | 16:17 |
NobodyCam | lol: lucasagomes and the Scrambled Kiwi's | 16:19 |
lucasagomes | lol | 16:19 |
*** dwalleck has quit IRC | 16:20 | |
*** derekh_ has quit IRC | 16:23 | |
*** igordcard has joined #openstack-ironic | 16:25 | |
rloo | going back to wikis, I don't see placeholder for things like the tempest tests. from the ironic wiki, you can get to eg http://docs.openstack.org/developer/ironic/dev/contributing.html, and then to https://wiki.openstack.org/wiki/HowToContribute. | 16:25 |
*** foexle has joined #openstack-ironic | 16:25 | |
lucasagomes | rloo, hmm maybe start a new page for those guidelines? | 16:27 |
*** zdin0bot has quit IRC | 16:27 | |
lucasagomes | (we also may want to start adding new pages for other stuff, like code guidelines etc) | 16:28 |
rloo | lucasagomes: I suppose a page with those guidelines and maybe other ones would be useful. | 16:28 |
lucasagomes | +1 | 16:28 |
NobodyCam | +1 | 16:28 |
rloo | lucasagomes: would be good to be a wiki though so anyone can edit it. | 16:28 |
lucasagomes | yeah, it's easier to edit if needed | 16:29 |
rloo | or etherpad? | 16:29 |
rloo | i suppose wiki is better. | 16:29 |
NobodyCam | -1 for etherpad | 16:29 |
NobodyCam | :-p | 16:29 |
rloo | anyone know how to add wiki pages, and link it off of our main one: https://wiki.openstack.org/wiki/Ironic? | 16:30 |
lucasagomes | https://wiki.openstack.org/w/index.php?title=Ironic&action=edit§ion=1 | 16:31 |
lucasagomes | I think to open a new link to a page | 16:31 |
lucasagomes | you simply put it between [] | 16:31 |
lucasagomes | like [new link] and then the wiki will create a link called new link | 16:31 |
lucasagomes | which you can after click and edit | 16:31 |
*** foexle has quit IRC | 16:31 | |
*** bearhands is now known as comstud | 16:32 | |
lucasagomes | actually it might be [[ ]] | 16:32 |
lucasagomes | double brackets | 16:32 |
*** jdob has quit IRC | 16:33 | |
rloo | lucasagomes: ok, thx. guess i can play around. how much harm can I do? :-) | 16:33 |
lucasagomes | lol | 16:33 |
lucasagomes | yeah | 16:33 |
lucasagomes | u can always see the preview before saving it :) | 16:34 |
NobodyCam | lucasagomes: gots a minute | 16:41 |
openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Wipe any matadata from a nodes disk on first deploy https://review.openstack.org/93133 | 16:41 |
NobodyCam | lucasagomes: ^^^^ | 16:41 |
lucasagomes | NobodyCam, hey will take a look | 16:41 |
lucasagomes | thanks | 16:41 |
rloo | NobodyCam: metadata, not matadata ;) | 16:41 |
NobodyCam | doh | 16:42 |
NobodyCam | just set wip | 16:42 |
NobodyCam | its not ready to land | 16:42 |
NobodyCam | just wanted to have eyes on it | 16:42 |
*** ellenh has joined #openstack-ironic | 16:42 | |
rloo | NobodyCam: looking forward to it landing! | 16:43 |
NobodyCam | yes | 16:43 |
NobodyCam | woo a new error this time! | 16:43 |
NobodyCam | happy happy joy joy | 16:43 |
devananda | NobodyCam: you're creating a DiskPartitioner instance, for the same device, twice. why? | 16:44 |
NobodyCam | is that with get_part_dict | 16:46 |
NobodyCam | I need to redo that | 16:46 |
NobodyCam | I guess it the work_on_disk change what I wanted to be seen | 16:49 |
NobodyCam | brb | 16:50 |
devananda | instead of splitting make_partitions in two functions, add an optinoal parameter that tells it not to db.commit() | 16:50 |
NobodyCam | yea that was what I thought after I split | 16:51 |
NobodyCam | it out | 16:51 |
NobodyCam | I don't like the split out right now :) | 16:51 |
*** zdin0bot has joined #openstack-ironic | 16:53 | |
*** vinbs has joined #openstack-ironic | 16:53 | |
*** dwalleck has joined #openstack-ironic | 16:55 | |
*** eghobo has quit IRC | 16:56 | |
*** eghobo has joined #openstack-ironic | 16:59 | |
*** BadCub has quit IRC | 17:00 | |
*** matty_dubs|lunch is now known as matty_dubs | 17:01 | |
lucasagomes | NobodyCam, reviewed | 17:04 |
lucasagomes | devananda, +1 yeah I suggested that as well | 17:04 |
lucasagomes | also the counting is wrong, it's not wiping 18KiB it's wiping 9Kib there,, 512*18 | 17:05 |
devananda | NobodyCam: reviewed | 17:05 |
*** vinbs has quit IRC | 17:08 | |
* devananda goes to work on the async-api spec doc | 17:08 | |
lucasagomes | devananda, this thing about not recreating the part table if we need to preserve ephemeral | 17:09 |
devananda | ? | 17:09 |
lucasagomes | devananda, in a rebuild, if the new image is bigger than the previous one | 17:09 |
lucasagomes | it might not fit in the previous layout | 17:09 |
lucasagomes | I'm kinda worried about it, maybe I'm not seem things correctly | 17:09 |
devananda | lucasagomes: root part is created based on the nova flavor's root_gb setting, not the image size | 17:10 |
devananda | lucasagomes: assuming growroot wasn't used, and the image is smaller than root_gb, i think it's fine | 17:10 |
devananda | if growroot was used, the point is moot anyway | 17:10 |
lucasagomes | right | 17:10 |
lucasagomes | yeah hmm | 17:10 |
*** ifarkas has quit IRC | 17:10 | |
devananda | and if the image is bigger than root_gb, things are broken anyway :) | 17:10 |
lucasagomes | heh | 17:11 |
devananda | unless i'm missing something | 17:11 |
lucasagomes | we have a sanity check for that :) | 17:11 |
lucasagomes | I think | 17:11 |
lucasagomes | cool yeah | 17:11 |
openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Wipe any metadata from a nodes disk on first deploy https://review.openstack.org/93133 | 17:11 |
*** eghobo has quit IRC | 17:11 | |
NobodyCam | gah irssi locked up | 17:13 |
NobodyCam | that only address the split out | 17:14 |
NobodyCam | will address the other comments in next rev | 17:14 |
NobodyCam | stil battling proxy and poor internet | 17:14 |
rloo | lucasagomes, devananda, NobodyCam, anyone that wants some reading: I added a note about tempest tests here: https://wiki.openstack.org/wiki/Ironic/Developer_guidelines, linked from https://wiki.openstack.org/wiki/Ironic#Developers. Please edit as you see fit. | 17:15 |
*** harlowja_away is now known as harlowja_ | 17:16 | |
NobodyCam | doh ty lucasagomes for the math error catch :-p | 17:17 |
lucasagomes | NobodyCam, just small concerns about the amount of data ur wiping (9KiB insteand of 18KiB) | 17:17 |
lucasagomes | yeah | 17:17 |
devananda | rloo: ++ | 17:17 |
NobodyCam | doh, | 17:17 |
lucasagomes | NobodyCam, other than that concerns, and the i18N log problem that devananda pointed out on the previous review I'm fine with it | 17:17 |
lucasagomes | rloo, will check | 17:17 |
lucasagomes | rloo, ah great start! | 17:17 |
NobodyCam | ack that was what I was really looking for ,,, I will clean up! | 17:18 |
devananda | rloo: fwiw, the same is true (we ought to blck patches if ...) regarding in-tree doc updates | 17:18 |
devananda | s/ought/can/ | 17:18 |
rloo | devananda: what do you mean by in-tree doc updates? | 17:19 |
lucasagomes | alright I will call it a day :) | 17:19 |
devananda | actually, never mind. that really applies to developer docs, and not as much deployer docs, which are more end-of-cycle right now | 17:19 |
rloo | devananda: okay ;) | 17:20 |
rloo | lucasagomes: ciao | 17:20 |
devananda | lucasagomes: g'night! | 17:20 |
lucasagomes | devananda, btw deva, if get a time... is it the kinda of migration script we are expecting for the instance_info? script we are expecting for the migration | 17:20 |
lucasagomes | ops | 17:20 |
rloo | I'm sure there are other guidelines that can be added, but I can't think of any right now. | 17:20 |
lucasagomes | https://review.openstack.org/#/c/96136/ | 17:20 |
lucasagomes | rloo, devananda good night | 17:20 |
lucasagomes | devananda, don't need to check it now, when u get some free time only | 17:21 |
devananda | rloo: related to your update, ave you seen https://wiki.openstack.org/wiki/Ironic/Testing ? | 17:21 |
*** lucasagomes is now known as lucas-dinner | 17:21 | |
NobodyCam | night lucas-dinner | 17:21 |
lucas-dinner | NobodyCam, night :) | 17:21 |
rloo | devananda: yeah. I was going to link to it, but forgot. I think maybe cuz I'd have to link it in somehow and I ran out of words. ha ha. | 17:21 |
jbjohnso | ahh... now my kvm consoles are under conflunet too | 17:22 |
devananda | lucas-dinner: something along those lines, i think -- but we should check with sdague, as he offered to give some help with grenade testing | 17:23 |
rloo | back in an hour or so. | 17:24 |
*** rloo has quit IRC | 17:24 | |
*** jdob has joined #openstack-ironic | 17:28 | |
*** Alexei_9871 has quit IRC | 17:34 | |
devananda | anyone know if ifarkas is around / working on https://bugs.launchpad.net/ironic/+bug/1314961 ? | 17:37 |
devananda | he assigned it to himself about 3 weeks ago then hasn't proposed any code | 17:38 |
devananda | and I dont see him on IRC | 17:38 |
lifeless | Ng: no, cloud-init does | 17:42 |
matty_dubs | I'm not sure if ifarkas is working on that or not. Thought it's 19:45 in his TZ so we probably won't catch him until tomorrow | 17:44 |
*** max_lobur has quit IRC | 17:47 | |
NobodyCam | brb | 17:49 |
dtantsur|afk | devananda, ifarkas is around earlier, he should be gone by now | 17:56 |
dtantsur|afk | it's 8pm here in Czech :) | 17:56 |
*** dtantsur|afk is now known as dtantsur | 17:56 | |
devananda | dtantsur: ah, thanks | 17:57 |
dtantsur | that is really troublesome: e.g. I make pause in the middle of the day and get back in the evening so that to catch up with all you :) | 17:57 |
dtantsur | devananda, btw, you already saw my mail on ML? You can consider it a loong comment on async spec :) | 18:03 |
devananda | dtantsur: yea, about to send a reply | 18:05 |
openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Wipe any metadata from a nodes disk on first deploy https://review.openstack.org/93133 | 18:08 |
matty_dubs | So, the .ninja TLD opened up today. Someone already took 'openstack.ninja' :'( | 18:10 |
lifeless | NobodyCam: 'repartition' | 18:10 |
NobodyCam | lol just -1 for that | 18:11 |
NobodyCam | :-p | 18:11 |
lifeless | reviewing now | 18:11 |
NobodyCam | i just -1'd for that :-p | 18:11 |
lifeless | but yes thats egregious :) | 18:11 |
dtantsur | devananda, lifeless, also could you have a look at https://review.openstack.org/95573 (proposed fix for NodeLocked problem)? | 18:14 |
lifeless | NobodyCam: actual -1 for other things :) | 18:17 |
lifeless | dtantsur: do we have 409 retry support in the client ? | 18:17 |
dtantsur | lifeless, depending on what you mean by "support". It does output a nice message. | 18:18 |
dtantsur | (I mean, cli output, library itself sees at as Conflict exception, I guess) | 18:18 |
NobodyCam | ack just saw error in some tests too | 18:19 |
dtantsur | NobodyCam, btw, what's the situation with bugs, which I can't close? | 18:23 |
NobodyCam | I could not close | 18:24 |
devananda | lifeless: the nova side implements retry for this. python-ironicclient does not automatically retry | 18:26 |
devananda | dtantsur: there are some bugs in LP which are not closable via the UI (eg, bugs which affect 10's of projects) | 18:26 |
devananda | dtantsur: there's an email interface for LP which I have been told works | 18:27 |
devananda | but i haven't tried it yet | 18:27 |
*** zdin0bot has quit IRC | 18:27 | |
dtantsur | wow | 18:27 |
*** zdin0bot has joined #openstack-ironic | 18:27 | |
*** rloo has joined #openstack-ironic | 18:27 | |
dtantsur | not sure how to use it also... | 18:27 |
devananda | lifeless: are you reviewing 95573? if so, i'll wait to approve it a bit longer | 18:28 |
*** datajerk1 has joined #openstack-ironic | 18:29 | |
*** datajerk has quit IRC | 18:30 | |
*** rloo has quit IRC | 18:33 | |
*** rloo has joined #openstack-ironic | 18:33 | |
*** rloo has quit IRC | 18:33 | |
*** dwalleck_ has joined #openstack-ironic | 18:34 | |
dtantsur | "Sorry, something went wrong when Launchpad tried processing your mail." <-- well, email interface does not seems to work | 18:34 |
openstackgerrit | A change was merged to openstack/ironic: Consider free disk space before downloading images into cache https://review.openstack.org/92625 | 18:34 |
*** rloo has joined #openstack-ironic | 18:34 | |
openstackgerrit | A change was merged to openstack/ironic: Implement the reboot command on the Ironic Driver https://review.openstack.org/92554 | 18:34 |
openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Wipe any metadata from a nodes disk on first deploy https://review.openstack.org/93133 | 18:35 |
*** dwalleck_ has quit IRC | 18:36 | |
*** dwalleck has quit IRC | 18:38 | |
*** dwalleck_ has joined #openstack-ironic | 18:38 | |
*** dwalleck_ has quit IRC | 18:38 | |
*** rloo has quit IRC | 18:38 | |
*** dwalleck has joined #openstack-ironic | 18:39 | |
*** rloo has joined #openstack-ironic | 18:39 | |
*** rloo has quit IRC | 18:39 | |
*** sysexit has quit IRC | 18:40 | |
*** rloo has joined #openstack-ironic | 18:40 | |
*** rloo has quit IRC | 18:40 | |
*** rloo has joined #openstack-ironic | 18:41 | |
*** datajerk1 has quit IRC | 18:41 | |
*** datajerk has joined #openstack-ironic | 18:42 | |
devananda | dtantsur: hah :( | 18:43 |
*** eghobo has joined #openstack-ironic | 18:43 | |
dtantsur | devananda, I opened a question at launchpad project, following instruction in the mail I got | 18:43 |
dtantsur | hope that will help... | 18:43 |
*** rloo has quit IRC | 18:43 | |
dtantsur | https://answers.launchpad.net/launchpad/+question/249435 | 18:43 |
*** rloo has joined #openstack-ironic | 18:43 | |
NobodyCam | brb | 18:48 |
*** rloo has quit IRC | 18:48 | |
*** rloo has joined #openstack-ironic | 18:49 | |
*** datajerk has quit IRC | 18:52 | |
*** datajerk1 has joined #openstack-ironic | 18:53 | |
*** bandicot has joined #openstack-ironic | 18:54 | |
*** dwalleck has quit IRC | 18:59 | |
*** dwalleck has joined #openstack-ironic | 18:59 | |
*** matty_dubs is now known as matty_dubs|gone | 19:01 | |
*** dwalleck has quit IRC | 19:04 | |
*** zdin0bot has quit IRC | 19:05 | |
*** dwalleck has joined #openstack-ironic | 19:06 | |
*** romcheg has joined #openstack-ironic | 19:08 | |
*** bandicot has quit IRC | 19:11 | |
dtantsur | I'm done for today, g'night, Ironic | 19:11 |
NobodyCam | have a good night dtantsur | 19:11 |
*** datajerk1 has quit IRC | 19:11 | |
*** dtantsur is now known as dtantsur|afk | 19:12 | |
NobodyCam | mmmm /me looks for food stuffs | 19:13 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements https://review.openstack.org/96228 | 19:14 |
*** datajerk has joined #openstack-ironic | 19:21 | |
*** dwalleck has quit IRC | 19:23 | |
*** dwalleck has joined #openstack-ironic | 19:24 | |
*** pelix has quit IRC | 19:28 | |
*** max_lobur has joined #openstack-ironic | 19:34 | |
*** datajerk has quit IRC | 19:36 | |
*** datajerk has joined #openstack-ironic | 19:38 | |
*** tatyana has joined #openstack-ironic | 19:44 | |
*** tatyana has quit IRC | 19:46 | |
*** datajerk1 has joined #openstack-ironic | 19:54 | |
*** datajerk has quit IRC | 19:54 | |
*** sysexit has joined #openstack-ironic | 19:57 | |
*** datajerk1 has quit IRC | 19:59 | |
*** dwalleck has quit IRC | 19:59 | |
NobodyCam | devananda: where you holding off landing 95573 | 20:00 |
*** zdiN0bot has joined #openstack-ironic | 20:00 | |
*** dwalleck has joined #openstack-ironic | 20:02 | |
devananda | NobodyCam: i thought lifeless was reviewing it, so held off. if not, i'll approve now | 20:04 |
*** zdiN0bot has quit IRC | 20:04 | |
*** zdin0bot has joined #openstack-ironic | 20:05 | |
lifeless | oh dtantsur|afk asked fora review and I got context switched before getting to it | 20:05 |
lifeless | devananda: w.r.t. retries - I was thinking of the CLI and tools like os-cloud-config that will also need to retry; it would be nice to be able to say '--retry-for 10s' | 20:06 |
*** max_lobur1 has joined #openstack-ironic | 20:09 | |
devananda | lifeless: remind me, in what context is occ talking to ironic directly? | 20:09 |
*** zdin0bot has quit IRC | 20:10 | |
*** max_lobur has quit IRC | 20:11 | |
lifeless | devananda: in register-nodes | 20:12 |
devananda | lifeless: right. that shouldn't ever hit this issue | 20:12 |
devananda | lifeless: creating a node shouldn't be touching RPC | 20:12 |
* devananda checks the code to see if it changed when he wasnt' looking | 20:13 | |
lifeless | devananda: we power the node off when we create it | 20:13 |
lifeless | devananda: per the workaround for bug 1315224 | 20:13 |
devananda | lifeless: ooh. right | 20:13 |
devananda | nvm | 20:13 |
* devananda wishes the API was async | 20:14 | |
devananda | I feel like we're doing a lot of work arounds right now for this, when we should just fix it | 20:14 |
devananda | things like power-off and tear-down would be low hanging fruit | 20:14 |
lifeless | yeah, I support fixing it | 20:15 |
lifeless | thus reviewing the spec :) | 20:15 |
devananda | :) | 20:16 |
*** ellenh has quit IRC | 20:18 | |
*** max_lobur1 has quit IRC | 20:18 | |
*** gmatefi has joined #openstack-ironic | 20:21 | |
*** r-daneel has joined #openstack-ironic | 20:22 | |
*** gmatefi has quit IRC | 20:33 | |
*** bandicot has joined #openstack-ironic | 20:40 | |
Shrews | so, adding a tempest test for the new reboot support is a bit tricky | 20:48 |
Shrews | how do we verify that it actually rebooted? the power state can (and does) change way too quickly to test against that | 20:49 |
*** bandicot has quit IRC | 20:50 | |
Shrews | so i'm open to ideas | 20:50 |
*** jdob has quit IRC | 20:52 | |
dwalleck | Shrews: The way I've done it in the past it to check the actual server uptime | 20:52 |
dwalleck | Unless someone ripped it out, the Tempest tests used to do that | 20:53 |
Shrews | dwalleck: ooh, great idea. remember which test that was? | 20:53 |
Shrews | so i can stealz your codez | 20:53 |
dwalleck | There's also the instance-actions extension that shows what actions have taken place for a server, but I'm not sure that's reliable | 20:54 |
dwalleck | Lets see.... | 20:54 |
dwalleck | So there's this in Tempest (test_reboot_server_hard if the run_ssh option is enabled) https://github.com/openstack/tempest/blob/master/tempest/api/compute/servers/test_server_actions.py | 20:55 |
dwalleck | I don't think it is for gate though, otherwise it would've caught it earlier | 20:55 |
*** bandicot has joined #openstack-ironic | 20:56 | |
Shrews | oh, there's also a get_boot_time() i can make use of | 20:56 |
Shrews | as part of RemoteClient | 20:56 |
dwalleck | Yessir. There's a whole ssh client to abstract things like that for simplicity | 20:56 |
Shrews | dwalleck: great. thx | 20:57 |
dwalleck | Or if it's in fubar in Tempest, here's what I actually found it with (https://github.com/stackforge/cloudroast/blob/master/cloudroast/compute/functional/servers/actions/test_reboot_server_soft.py) | 20:57 |
Shrews | cool | 20:57 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/96263 | 20:59 |
*** jbjohnso has quit IRC | 21:01 | |
NobodyCam | brb | 21:02 |
*** eghobo has quit IRC | 21:04 | |
*** zdin0bot has joined #openstack-ironic | 21:06 | |
*** ellenh has joined #openstack-ironic | 21:07 | |
*** eghobo has joined #openstack-ironic | 21:07 | |
*** zdin0bot has quit IRC | 21:10 | |
*** bandicot has quit IRC | 21:13 | |
NobodyCam | now this is new: TypeError: get_node_mac_addresses() takes exactly 2 arguments (1 given) | 21:17 |
*** BadCub has joined #openstack-ironic | 21:18 | |
*** sysexit has quit IRC | 21:19 | |
*** eghobo has quit IRC | 21:27 | |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic-specs: Make the REST API fully asynchronous https://review.openstack.org/94923 | 21:30 |
*** zdiN0bot has joined #openstack-ironic | 21:31 | |
*** zdiN0bot has quit IRC | 21:32 | |
*** zdiN0bot has joined #openstack-ironic | 21:33 | |
*** Penick has joined #openstack-ironic | 21:39 | |
*** dwalleck has quit IRC | 21:39 | |
*** zdin0bot1 has joined #openstack-ironic | 21:40 | |
NobodyCam | oh next error: Error: node_set_boot_device() got multiple values for keyword argument 'persistent' :-p | 21:41 |
*** zdiN0bot has quit IRC | 21:43 | |
NobodyCam | brb | 21:44 |
*** zdin0bot1 has quit IRC | 21:45 | |
openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Factoring out PXE and TFTP functions https://review.openstack.org/90233 | 21:46 |
openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Adding a reference driver for the agent https://review.openstack.org/84795 | 21:46 |
*** mrda-away is now known as mrda | 21:47 | |
mrda | Morning Ironic! | 21:47 |
devananda | mornin, mrda ! | 21:52 |
* devananda has some offline things to take care of, and will probably be offline for most of the afternoon | 21:53 | |
*** bandicot has joined #openstack-ironic | 21:53 | |
mrda | hi devananda! | 21:54 |
* mrda reading scrollback | 21:54 | |
NobodyCam | good morning mrda | 21:55 |
*** dhellmann is now known as dhellmann_ | 21:58 | |
*** dhellmann_ is now known as dhellmann | 21:58 | |
*** dhellmann is now known as dhellmann_ | 21:58 | |
mrda | devananda: so just on https://bugs.launchpad.net/ironic/+bug/1315224 What is the desired behaviour? Is it to just improve the latency of asserting the power state post-registration? Should we ensure nodes are powered off post-registration? Should we do nothing because ironic will eventually get there? Which solution sounds most reasonable to you? | 22:01 |
*** ekarlso has quit IRC | 22:01 | |
*** ellenh has quit IRC | 22:01 | |
devananda | asserting power state post-registration seems reasonable to me | 22:04 |
devananda | however | 22:05 |
devananda | it doesn't make sense in some ways given today's api | 22:05 |
devananda | you register a node. but you can't register it WITH a power state | 22:05 |
devananda | so then ironic checks the node's current power state and /might/ go turn it off | 22:05 |
mrda | so adding an optional desired_power_state might be the way forward? | 22:06 |
mrda | ...to the api | 22:06 |
lifeless | Shrews: hi | 22:06 |
devananda | mrda: dont think that's good either | 22:06 |
lifeless | Shrews: are you looking into the block device metadata missing thing ? | 22:06 |
devananda | mrda: but i need to run now :( | 22:06 |
mrda | ok, no problems | 22:07 |
* devananda will bbl or bbtmw | 22:07 | |
mrda | talk later devananda - thanks | 22:07 |
lifeless | devananda: huh, why wouldn't it turn it off like it does now, just more quickly ? | 22:07 |
lifeless | devananda: I agree that we could do more, but that seems orthogonal | 22:07 |
*** bandicot has quit IRC | 22:08 | |
lifeless | Shrews: https://bugs.launchpad.net/tripleo/+bug/1324286 | 22:08 |
*** lucas-dinner has quit IRC | 22:13 | |
*** jgrimm has quit IRC | 22:13 | |
*** ellenh has joined #openstack-ironic | 22:15 | |
NobodyCam | omg 890c39b4-a95f-48c3-a115-49e588d26869 | epDeployTest | ACTIVE | 22:21 |
NobodyCam | :-p | 22:21 |
*** r-daneel has quit IRC | 22:26 | |
*** ekarlso has joined #openstack-ironic | 22:26 | |
*** jdonalds has joined #openstack-ironic | 22:28 | |
Shrews | lifeless: no, i was simply curious. is that metadata something ironic is responsible for? | 22:28 |
openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Wipe any metadata from a nodes disk on first deploy https://review.openstack.org/93133 | 22:28 |
Shrews | or is that a nova thing? | 22:28 |
*** dwalleck has joined #openstack-ironic | 22:29 | |
*** eghobo has joined #openstack-ironic | 22:34 | |
*** dwalleck_ has joined #openstack-ironic | 22:35 | |
*** dwalleck_ has quit IRC | 22:36 | |
*** dwalleck_ has joined #openstack-ironic | 22:36 | |
*** dwalleck_ has quit IRC | 22:36 | |
lifeless | Shrews: the nova driver | 22:37 |
*** dwalleck_ has joined #openstack-ironic | 22:37 | |
lifeless | Shrews: so its a patch to ironic/nova/virt/... | 22:37 |
lifeless | Shrews: its pretty critical to make ephemeral support work; I'd love it if you were to do it :) | 22:38 |
Shrews | lifeless: ah, i think i see it now. the old bm driver has a call to _set_default_ephemeral_device() in spawn(). i don't think we replicate that | 22:38 |
Shrews | lifeless: looks easy enough to fix. i'll look at it tomorrow | 22:38 |
*** dwalleck has quit IRC | 22:39 | |
*** radsy has joined #openstack-ironic | 22:39 | |
*** radsy has joined #openstack-ironic | 22:39 | |
lifeless | Shrews: cool | 22:40 |
NobodyCam | lifeless: gota a second to peek at 93133.. Just tested and this time it actually preserves the ephemeral partition when asked to :-p | 22:40 |
lifeless | NobodyCam: I just +2'd it | 22:41 |
*** zdin0bot has joined #openstack-ironic | 22:41 | |
NobodyCam | w00t!!!! NobodyCam does Happy Dance | 22:41 |
*** ellenh has quit IRC | 22:42 | |
mrda | lol | 22:43 |
NobodyCam | mrda: Uploaded patch set 41. :-p | 22:43 |
NobodyCam | hehehe | 22:44 |
mrda | So nova gets into the 80's, so you've got a way to go :) | 22:44 |
NobodyCam | that patch kinda lost it way in life | 22:44 |
NobodyCam | lol and I thought only neutron got up that high | 22:44 |
mrda | so long as it eventually gets through | 22:45 |
NobodyCam | yep :) | 22:45 |
*** zdin0bot has quit IRC | 22:46 | |
mrda | ...which reminds me - it's code review time | 22:46 |
NobodyCam | after five here... time for a strawberry daiquiri | 22:49 |
NobodyCam | :-p | 22:49 |
mrda | before 8:30am here, time for coffee :P | 22:50 |
NobodyCam | hehheehe | 22:50 |
*** zdiN0bot has joined #openstack-ironic | 22:51 | |
NobodyCam | lol daiquiri too much work ... bud light easier | 22:53 |
*** romcheg has quit IRC | 22:54 | |
lifeless | NobodyCam: but so much less tasty | 23:01 |
NobodyCam | this is true :) | 23:02 |
*** BadCub has quit IRC | 23:04 | |
*** linggao has quit IRC | 23:16 | |
*** zdiN0bot has quit IRC | 23:33 | |
*** dwalleck_ has quit IRC | 23:35 | |
*** zdin0bot has joined #openstack-ironic | 23:42 | |
Shrews | devananda: bug https://bugs.launchpad.net/tripleo/+bug/1324286 will need some discussion, i think | 23:45 |
*** zdin0bot has quit IRC | 23:46 | |
* Shrews now leaves to attempt to enjoy his evening | 23:46 | |
*** foexle has joined #openstack-ironic | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!