lifeless | Shrews: devananda: nah, its straight forward. I think you have a concern that is due to misunderstanding how the layers interact. | 00:01 |
---|---|---|
*** Penick has joined #openstack-ironic | 00:03 | |
*** zdiN0bot has joined #openstack-ironic | 00:13 | |
*** zdiN0bot has quit IRC | 00:16 | |
openstackgerrit | A change was merged to openstack/ironic-python-agent: Don't begin heartbeating until the API server is listening https://review.openstack.org/94482 | 00:16 |
*** zdiN0bot has joined #openstack-ironic | 00:16 | |
*** matsuhashi has joined #openstack-ironic | 00:22 | |
*** eguz has joined #openstack-ironic | 00:28 | |
*** jdonalds has quit IRC | 00:29 | |
*** Penick has quit IRC | 00:31 | |
*** eghobo has quit IRC | 00:33 | |
openstackgerrit | A change was merged to openstack/ironic: Synced jsonutils from oslo-incubator https://review.openstack.org/95691 | 00:35 |
*** Penick has joined #openstack-ironic | 00:35 | |
*** Penick has quit IRC | 00:36 | |
*** zdin0bot1 has joined #openstack-ironic | 00:42 | |
*** foexle has quit IRC | 00:43 | |
*** zdin0bot1 has quit IRC | 00:46 | |
*** JayF has quit IRC | 00:58 | |
Shrews | lifeless: not surprising i'm misunderstanding something :) | 01:00 |
*** JayF has joined #openstack-ironic | 01:03 | |
*** igordcard has quit IRC | 01:04 | |
*** BadCub has joined #openstack-ironic | 01:05 | |
*** dwalleck has joined #openstack-ironic | 01:05 | |
*** dwalleck has quit IRC | 01:06 | |
*** dwalleck has joined #openstack-ironic | 01:06 | |
*** BadCub has quit IRC | 01:09 | |
*** shakamunyi has quit IRC | 01:16 | |
*** zdin0bot1 has joined #openstack-ironic | 01:43 | |
*** nosnos has joined #openstack-ironic | 01:45 | |
*** zdin0bot1 has quit IRC | 01:48 | |
*** jdonalds has joined #openstack-ironic | 02:14 | |
*** zdiN0bot has quit IRC | 02:15 | |
*** zdiN0bot has joined #openstack-ironic | 02:16 | |
*** zdiN0bot has quit IRC | 02:16 | |
*** rloo has quit IRC | 02:36 | |
*** jdonalds has quit IRC | 02:39 | |
*** zdin0bot has joined #openstack-ironic | 02:44 | |
*** radsy has quit IRC | 02:47 | |
*** zdin0bot has quit IRC | 02:48 | |
*** vinbs has joined #openstack-ironic | 02:55 | |
*** matsuhashi has quit IRC | 03:00 | |
*** matsuhashi has joined #openstack-ironic | 03:04 | |
*** BadCub has joined #openstack-ironic | 03:06 | |
*** BadCub has quit IRC | 03:10 | |
*** rameshg87 has joined #openstack-ironic | 03:31 | |
*** nosnos has quit IRC | 03:33 | |
*** matsuhashi has quit IRC | 03:34 | |
*** matsuhashi has joined #openstack-ironic | 03:35 | |
*** datajerk has joined #openstack-ironic | 03:39 | |
*** matsuhashi has quit IRC | 03:39 | |
*** zdin0bot has joined #openstack-ironic | 03:39 | |
*** zdin0bot has quit IRC | 03:44 | |
*** eghobo has joined #openstack-ironic | 03:46 | |
*** shakamunyi has joined #openstack-ironic | 03:49 | |
*** lazy_prince has joined #openstack-ironic | 03:54 | |
*** matsuhashi has joined #openstack-ironic | 03:56 | |
*** shakamunyi has quit IRC | 04:05 | |
*** k4n0 has joined #openstack-ironic | 04:11 | |
*** rameshg87 has joined #openstack-ironic | 04:16 | |
*** jdonalds has joined #openstack-ironic | 04:31 | |
*** lazy_prince has quit IRC | 04:32 | |
*** harlowja_ is now known as harlowja_away | 04:38 | |
*** jdonalds has quit IRC | 04:40 | |
*** zdin0bot has joined #openstack-ironic | 04:40 | |
*** Penick has joined #openstack-ironic | 04:43 | |
*** Penick has quit IRC | 04:43 | |
*** zdin0bot has quit IRC | 04:45 | |
*** nosnos has joined #openstack-ironic | 04:45 | |
*** jdonalds has joined #openstack-ironic | 04:53 | |
*** eghobo has quit IRC | 04:57 | |
*** eghobo has joined #openstack-ironic | 04:57 | |
*** jdonalds has quit IRC | 04:59 | |
*** eguz has joined #openstack-ironic | 04:59 | |
*** jdonalds has joined #openstack-ironic | 05:02 | |
*** shakamunyi has joined #openstack-ironic | 05:03 | |
*** eghobo has quit IRC | 05:03 | |
*** lazy_prince has joined #openstack-ironic | 05:05 | |
*** jdonalds has quit IRC | 05:06 | |
*** BadCub has joined #openstack-ironic | 05:07 | |
*** BadCub has quit IRC | 05:11 | |
*** shakamunyi has quit IRC | 05:14 | |
openstackgerrit | A change was merged to openstack/ironic: Change NodeLocked status code to a client-side error https://review.openstack.org/95573 | 05:34 |
*** shakamunyi has joined #openstack-ironic | 05:40 | |
*** zdin0bot has joined #openstack-ironic | 05:41 | |
*** sysexit has joined #openstack-ironic | 05:45 | |
*** zdin0bot has quit IRC | 05:45 | |
*** shakamunyi has quit IRC | 05:50 | |
*** vinbs has quit IRC | 05:54 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/96063 | 06:02 |
openstackgerrit | Rohan Kanade proposed a change to openstack/ironic: Partially remove hard-coded ID's from testdata https://review.openstack.org/76990 | 06:02 |
*** sysexit has quit IRC | 06:09 | |
openstackgerrit | Russell Haering proposed a change to openstack/ironic-python-agent: Switch to oslo.config for CLI parsing https://review.openstack.org/96364 | 06:13 |
russell_h | JoshNang: https://review.openstack.org/#/c/96364/ | 06:13 |
*** dwalleck has quit IRC | 06:23 | |
*** rameshg87 has left #openstack-ironic | 06:26 | |
*** lazy_prince has quit IRC | 06:38 | |
*** lazy_prince has joined #openstack-ironic | 06:40 | |
*** zdin0bot has joined #openstack-ironic | 06:42 | |
*** rakesh_hs has joined #openstack-ironic | 06:42 | |
*** zdin0bot has quit IRC | 06:47 | |
*** shakamunyi has joined #openstack-ironic | 06:47 | |
*** lokesh184 has joined #openstack-ironic | 06:53 | |
*** shakamunyi has quit IRC | 06:59 | |
*** jdonalds has joined #openstack-ironic | 07:03 | |
openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Add IloDriver and its IloPower module https://review.openstack.org/89500 | 07:16 |
*** rameshg87 has joined #openstack-ironic | 07:18 | |
*** eguz has quit IRC | 07:22 | |
*** shakamunyi has joined #openstack-ironic | 07:25 | |
*** rameshg87 has quit IRC | 07:29 | |
*** rameshg87 has joined #openstack-ironic | 07:30 | |
*** ifarkas has joined #openstack-ironic | 07:31 | |
*** jistr has joined #openstack-ironic | 07:34 | |
*** zdin0bot has joined #openstack-ironic | 07:35 | |
*** shakamunyi has quit IRC | 07:36 | |
*** romcheg has joined #openstack-ironic | 07:38 | |
*** mrda is now known as mrda-away | 07:39 | |
mrda-away | Night Ironic | 07:39 |
*** pelix has joined #openstack-ironic | 07:41 | |
*** sysexit has joined #openstack-ironic | 07:46 | |
*** lazy_prince has quit IRC | 07:50 | |
*** martyntaylor has joined #openstack-ironic | 07:52 | |
*** lazy_prince has joined #openstack-ironic | 07:53 | |
*** matsuhashi has quit IRC | 07:58 | |
*** matsuhashi has joined #openstack-ironic | 07:59 | |
*** rameshg87 has quit IRC | 08:01 | |
*** matsuhas_ has joined #openstack-ironic | 08:02 | |
*** rameshg87 has joined #openstack-ironic | 08:02 | |
*** shakamunyi has joined #openstack-ironic | 08:03 | |
*** matsuhashi has quit IRC | 08:04 | |
*** zdin0bot has quit IRC | 08:06 | |
*** shakamunyi has quit IRC | 08:14 | |
*** lucasagomes has joined #openstack-ironic | 08:16 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Set the correct target versions for the RPC methods https://review.openstack.org/94379 | 08:22 |
*** derekh_ has joined #openstack-ironic | 08:25 | |
*** igordcard has joined #openstack-ironic | 08:35 | |
*** shakamunyi has joined #openstack-ironic | 08:40 | |
dtantsur|afk | Hi folks! Unfortunately, I'm not feeling ok today, so see you all tomorrow | 08:42 |
dtantsur|afk | ifarkas, devananda was looking for you: "anyone know if ifarkas is around / working on https://bugs.launchpad.net/ironic/+bug/1314961 ? he assigned it to himself about 3 weeks ago then hasn't proposed any code" | 08:43 |
dtantsur|afk | Now getting back to recovery :( | 08:43 |
ifarkas | dtantsur|afk, yeah, I already started working. I just got distracted a bit by the drac driver. | 08:44 |
ifarkas | dtantsur|afk, What recovery? | 08:44 |
ifarkas | dtantsur|afk, ahh, okay. I hope you will get better! | 08:45 |
dtantsur|afk | ifarkas, thanks. I think you'd better leave a comment in the bug | 08:45 |
ifarkas | dtantsur|afk, yeah, I will do that | 08:46 |
romcheg | dtantsur|afk: get better! | 08:46 |
*** jcoufal has joined #openstack-ironic | 08:46 | |
*** shakamunyi has quit IRC | 08:52 | |
*** matsuhas_ has quit IRC | 08:53 | |
*** matsuhashi has joined #openstack-ironic | 08:58 | |
lucasagomes | dtantsur|afk, hey man, hope you get better soon | 08:59 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Remove 'node' parameter from the Console and Rescue interfaces https://review.openstack.org/91097 | 09:00 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Remove 'node' parameter from the Power interface https://review.openstack.org/91093 | 09:00 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Remove 'node' parameter from the validate() methods https://review.openstack.org/91104 | 09:00 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Pass kwargs to ClientWrapper's call() method https://review.openstack.org/92384 | 09:04 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: list_instances() to return a list of instances names https://review.openstack.org/92385 | 09:04 |
*** foexle has joined #openstack-ironic | 09:09 | |
*** Haomeng has joined #openstack-ironic | 09:10 | |
*** tatyana has joined #openstack-ironic | 09:13 | |
*** shakamunyi has joined #openstack-ironic | 09:19 | |
*** foexle has quit IRC | 09:21 | |
*** dguerri is now known as _dguerri | 09:22 | |
*** _dguerri is now known as dguerri | 09:26 | |
*** shakamunyi has quit IRC | 09:31 | |
*** matsuhashi has quit IRC | 09:33 | |
*** matsuhashi has joined #openstack-ironic | 09:33 | |
*** matsuhashi has quit IRC | 09:35 | |
*** matsuhashi has joined #openstack-ironic | 09:36 | |
*** lynxman has quit IRC | 09:36 | |
*** lynxman has joined #openstack-ironic | 09:37 | |
openstackgerrit | Rohan Kanade proposed a change to openstack/ironic: Partially remove hard-coded ID's from testdata https://review.openstack.org/76990 | 09:52 |
*** shakamunyi has joined #openstack-ironic | 09:58 | |
*** romcheg1 has joined #openstack-ironic | 09:59 | |
*** romcheg has quit IRC | 10:00 | |
*** nosnos has quit IRC | 10:02 | |
*** nosnos has joined #openstack-ironic | 10:05 | |
*** shakamunyi has quit IRC | 10:05 | |
*** romcheg has joined #openstack-ironic | 10:07 | |
*** romcheg1 has quit IRC | 10:08 | |
*** foexle has joined #openstack-ironic | 10:16 | |
openstackgerrit | A change was merged to openstack/python-ironicclient: replace dict.iteritems() with six.iteritems(dict) https://review.openstack.org/95562 | 10:22 |
*** takadayuiko has joined #openstack-ironic | 10:25 | |
*** lokesh184 has quit IRC | 10:28 | |
*** foexle has quit IRC | 10:30 | |
*** matsuhashi has quit IRC | 10:41 | |
*** nosnos has quit IRC | 10:41 | |
*** nosnos has joined #openstack-ironic | 10:45 | |
*** lokesh184 has joined #openstack-ironic | 10:46 | |
*** nosnos has quit IRC | 10:46 | |
*** nosnos has joined #openstack-ironic | 10:47 | |
*** nosnos has quit IRC | 10:48 | |
*** sysexit has quit IRC | 10:55 | |
*** pradipta_away is now known as pradipta | 11:14 | |
*** dguerri is now known as _dguerri | 11:20 | |
NobodyCam | good morning Ironic | 11:23 |
romcheg | Morning NobodyCam! | 11:23 |
*** igordcard_ has joined #openstack-ironic | 11:23 | |
NobodyCam | morning romcheg :) | 11:24 |
*** igordcard has quit IRC | 11:24 | |
*** _dguerri is now known as dguerri | 11:24 | |
Haomeng | morning NobodyCam, romcheg! | 11:24 |
NobodyCam | morning Haomeng :) | 11:25 |
Haomeng | NobodyCam: :) | 11:25 |
lucasagomes | morning NobodyCam Haomeng romcheg :) | 11:26 |
Haomeng | lucasagomes: morning:) | 11:26 |
NobodyCam | good morning lucasagomes | 11:26 |
romcheg | Morning everyone | 11:27 |
romcheg | Easier :) | 11:27 |
NobodyCam | lol | 11:31 |
NobodyCam | apple bpught beets audio... wow | 11:31 |
NobodyCam | bought even | 11:31 |
*** rameshg87 has left #openstack-ironic | 11:36 | |
romcheg | I came up with a joke but it sounds a little racist :( | 11:37 |
*** lokesh184 has quit IRC | 11:38 | |
NobodyCam | gate-python-ironicclient-pypy is non voting? | 11:39 |
romcheg | I think pypy is non-voting for everything | 11:40 |
NobodyCam | :) | 11:40 |
romcheg | I can check | 11:40 |
romcheg | - name: ^gate-.*-pypy$ | 11:41 |
romcheg | voting: false | 11:41 |
NobodyCam | :) | 11:42 |
NobodyCam | morning walkies brb | 11:43 |
*** foexle has joined #openstack-ironic | 11:44 | |
*** dguerri is now known as _dguerri | 11:47 | |
*** takadayuiko has quit IRC | 11:51 | |
romcheg | Guys, I recall a conversation about commit messages when we agreed to make them short and brief | 11:52 |
*** Jatin360 has joined #openstack-ironic | 11:53 | |
Jatin360 | stupid question: i added some logs in pxe.py, how do I get these changes "compiled" in? | 11:54 |
*** praefect has joined #openstack-ironic | 11:54 | |
romcheg | I'm looking at Ruby's patch https://review.openstack.org/#/c/73005/ maybe it's worth mentioning? | 11:54 |
romcheg | Jatin360: Hi! | 11:54 |
romcheg | Jatin360: Do you want to merge the changes to the upstream? | 11:55 |
Jatin360 | no, just for debugging | 11:55 |
Jatin360 | i come from c backgroud | 11:55 |
romcheg | All you need is restarting the conductor service | 11:55 |
Jatin360 | not sure if I need to compile | 11:55 |
romcheg | Ah, no, Python is an interpretable lang | 11:56 |
romcheg | language even | 11:56 |
Jatin360 | i deleted pxe.pyc and then restarted conductor but it didn't recreate pxe.pyc file | 11:56 |
romcheg | So just restart the conductor service and your code will be running | 11:56 |
romcheg | It recreates .pyc files afret the module was actually invoked | 11:57 |
NobodyCam | Jatin360: are you runing in a venv? | 11:57 |
Jatin360 | I dont think I am running in venv however I am not sure | 11:58 |
romcheg | Jatin360: Did you use devstack? | 11:58 |
Jatin360 | i am using openstack | 11:58 |
romcheg | Yes, but did you install it manually or using devstack? | 11:58 |
NobodyCam | Jatin360: did you manually set it up or run somehting like devstack / devtest? | 11:59 |
*** vinbs has joined #openstack-ironic | 11:59 | |
Jatin360 | we did it manually, | 11:59 |
Jatin360 | using the openstack manual proceduce | 12:00 |
Jatin360 | i am not using devstack | 12:00 |
Jatin360 | it is all in one set up | 12:00 |
romcheg | Did you install ironic as a python package? | 12:00 |
Jatin360 | yes, installed as a python package | 12:00 |
romcheg | Did you change the source code in the Python directory or in your copy? | 12:01 |
Jatin360 | python directory | 12:02 |
romcheg | Restarting the ironic-conductor service should be enough then | 12:02 |
Jatin360 | ok, i will check further why it is not doing it | 12:02 |
NobodyCam | lucasagomes: Haomeng: did you test eh global update to sphinx? | 12:03 |
romcheg | .pyc are getting created at the time the appropriate .py file was invoced | 12:03 |
Jatin360 | will make sure if I am hitting that particular code in the test case | 12:03 |
romcheg | invoked even | 12:03 |
Jatin360 | thanks guyz | 12:04 |
romcheg | Jatin360: our pleasure! | 12:05 |
*** pradipta is now known as pradipta_away | 12:19 | |
*** pradipta_away is now known as pradipta | 12:19 | |
*** vinbs has quit IRC | 12:20 | |
romcheg | NobodyCam: are you back? | 12:22 |
lucasagomes | NobodyCam, there's gate tests for the docs, I tested the paramiko changed in my env | 12:22 |
lucasagomes | I can run the docs build as well if needed | 12:22 |
NobodyCam | yeppers | 12:23 |
*** _dguerri is now known as dguerri | 12:23 | |
romcheg | I'd like to discuss the way driver properties are implemented here https://review.openstack.org/#/c/73005/14 | 12:23 |
NobodyCam | i was just asking as I have very poor interwebs and building is painful | 12:23 |
romcheg | Ruby unfortunately does not seem to be here | 12:23 |
romcheg | So right now the driver properties is a static list of items | 12:24 |
romcheg | However to fetch them we use RCP calls to conductor | 12:24 |
romcheg | I'd rather just read that information from the DB | 12:25 |
*** rakesh_hs has quit IRC | 12:25 | |
romcheg | lucasagomes NobodyCam what do you think? | 12:25 |
*** Jatin360 has quit IRC | 12:26 | |
romcheg | We store some information about drivers in the database, maybe just extend that a little bit to add some meta information about them? | 12:30 |
*** pradipta is now known as pradipta_away | 12:30 | |
romcheg | Ok, I'm going to write my thoughts to the review. That's the right way to discuss the things :) | 12:32 |
NobodyCam | romcheg: thats seems in line with the make rest api asynchronous stuff | 12:32 |
romcheg | NobodyCam: Yes. | 12:33 |
romcheg | This stuff doe not even requires conductor because the information is static | 12:33 |
NobodyCam | ya, | 12:33 |
romcheg | There are 14 patch sets and I'm a little hesitant to say "-1, I think it should be re-done in different way" | 12:34 |
romcheg | Ok, that is just my opinion and I will let Ruby to punch me in my face, if no one agrees :) | 12:35 |
*** rloo has joined #openstack-ironic | 12:40 | |
*** rloo has quit IRC | 12:41 | |
*** rloo has joined #openstack-ironic | 12:41 | |
*** k4n0 has quit IRC | 12:51 | |
NobodyCam | sorry dropped internet | 12:53 |
NobodyCam | :-p | 12:53 |
NobodyCam | back on phone | 12:53 |
romcheg | NobodyCam: I commented the same thing on the patch. Let's see what other guys think | 12:57 |
NobodyCam | :) | 12:58 |
*** linggao has joined #openstack-ironic | 12:59 | |
NobodyCam | lucasagomes: seems I landed 94860 befor 95701 was approved :-p | 13:01 |
romcheg | I thought Gerrit should not allow that | 13:01 |
lucasagomes | NobodyCam, :) it's grand, the instance_info field already exist in the Node's resource | 13:01 |
lucasagomes | even before the spec repo was created | 13:02 |
NobodyCam | lol :) | 13:02 |
lucasagomes | already existed* | 13:02 |
lucasagomes | the new spec is a port of a blueprint written by jroll | 13:02 |
*** sysexit has joined #openstack-ironic | 13:03 | |
romcheg | Oh, it's cross project dependencies | 13:04 |
romcheg | I got confused :) | 13:04 |
*** jbjohnso has joined #openstack-ironic | 13:10 | |
*** jdob has joined #openstack-ironic | 13:11 | |
*** lazy_prince has quit IRC | 13:14 | |
NobodyCam | lucasagomes: reading over 95701. Have you thought about how we'll change the deploy ramdisk to say something like a recovery / repair ramdisk? | 13:14 |
lucasagomes | NobodyCam, not really, idk if it's related to that blueprint | 13:15 |
lucasagomes | NobodyCam, the deploy ramdisk and kernel will still live in the driver_info | 13:15 |
NobodyCam | it very well may be out of scope | 13:15 |
lucasagomes | but instead of getting it from the nova flavor we are requering users to set when enrolling the node | 13:16 |
lucasagomes | because we want to support diff deploy methods using the same flavor | 13:16 |
*** shakamunyi has joined #openstack-ironic | 13:16 | |
lucasagomes | e.g the IPA and the default PXE driver uses diff deploy K&R so it can't be associated with a flavor as-is now | 13:16 |
NobodyCam | ya | 13:16 |
lucasagomes | but I suspect that for a recovery/repair ramdisk | 13:17 |
lucasagomes | we would have another parameter on the driver_info | 13:17 |
*** rloo has quit IRC | 13:17 | |
NobodyCam | ok that would work | 13:17 |
*** rloo has joined #openstack-ironic | 13:18 | |
lucasagomes | related to the driver implementing the rescue interface or something | 13:18 |
lucasagomes | (/me haven't thought about it) | 13:18 |
*** max_lobur has joined #openstack-ironic | 13:18 | |
romcheg | brb | 13:18 |
*** shakayumi has joined #openstack-ironic | 13:19 | |
*** shakamunyi has quit IRC | 13:21 | |
*** eghobo has joined #openstack-ironic | 13:22 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Implement security groups and firewall filtering methods https://review.openstack.org/96466 | 13:31 |
*** shakayumi has quit IRC | 13:34 | |
openstackgerrit | A change was merged to openstack/ironic: Set the correct target versions for the RPC methods https://review.openstack.org/94379 | 13:38 |
*** romcheg1 has joined #openstack-ironic | 13:39 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements https://review.openstack.org/96228 | 13:40 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/88722 | 13:40 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/96263 | 13:47 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Return the HTTP Location for accepted requestes https://review.openstack.org/92616 | 13:47 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Return the HTTP Location for newly created resources https://review.openstack.org/92615 | 13:47 |
*** matty_dubs|gone is now known as matty_dubs | 13:48 | |
*** shakayumi has joined #openstack-ironic | 13:48 | |
NobodyCam | good morning matty_dubs | 13:49 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: list_instances() to return a list of instances names https://review.openstack.org/92385 | 13:50 |
Shrews | lucasagomes: Hi. Have you had a chance to look at bug https://bugs.launchpad.net/ironic/+bug/1324286 ? Wondering what your thoughts are on the suggestion to pre-calculate values. | 13:55 |
lucasagomes | Shrews, hey, oh no I haven't lemme take a look | 13:56 |
Shrews | lucasagomes: major blocker for tripleo guys i believe | 13:56 |
*** tatyana_ has joined #openstack-ironic | 13:57 | |
*** dguerri is now known as _dguerri | 13:58 | |
*** _dguerri is now known as dguerri | 13:58 | |
*** tatyana has quit IRC | 13:59 | |
*** tatyana_ is now known as tatyana | 13:59 | |
lucasagomes | Shrews, right I think that it's safe to assume that the ephemeral is the first partition in Ironic | 14:00 |
lucasagomes | because if ephemeral is present it's always the first partition | 14:00 |
Shrews | lucasagomes: sure, but how do we set the correct device name on the instance? or can we just use the label instead? | 14:01 |
lucasagomes | ahh... idk how cloud-init works, I would prefer to use the label | 14:02 |
lucasagomes | so we wouldn't even care what partition number it is | 14:02 |
lucasagomes | idk if that works, it should | 14:02 |
Shrews | i don't know if that's supported, though | 14:02 |
*** jgrimm has joined #openstack-ironic | 14:02 | |
lucasagomes | :/ | 14:03 |
romcheg1 | Gates are so loaded... | 14:03 |
lucasagomes | there's no safe way to predict the name of the device on that instance, unless you explicitly added a udev rule or something | 14:03 |
lucasagomes | which we don't and shouldn't | 14:03 |
Shrews | i *think* lifeless is suggesting using the label, b/c, as you say, we can't precalculate the device | 14:04 |
romcheg1 | Good morning matty_dubs Shrews! | 14:04 |
Shrews | romcheg1: morning! | 14:04 |
lucasagomes | Shrews, yeah I think so, the label would be safe enough I think | 14:04 |
lucasagomes | Shrews, one thing about this label is that right now we name it as label0 always, we should maybe name it as label-<instance-uuid> to be safer | 14:05 |
lucasagomes | in case somehow that machine have to disks and partitions with the same label or something | 14:05 |
Shrews | lucasagomes: sounds reasonable | 14:06 |
*** eghobo has quit IRC | 14:08 | |
*** romcheg has quit IRC | 14:18 | |
*** yfujioka has joined #openstack-ironic | 14:19 | |
*** eghobo has joined #openstack-ironic | 14:23 | |
romcheg1 | lucasagomes: Why not generate something more random and same that to instance_info? | 14:23 |
romcheg1 | s/same/save | 14:24 |
*** eghobo has quit IRC | 14:24 | |
*** jdonalds has quit IRC | 14:26 | |
lucasagomes | romcheg1, needs to be predictable so you can set it in the nova driver | 14:26 |
lucasagomes | ah save to the instance_info | 14:26 |
lucasagomes | ok yeah that works as well | 14:26 |
romcheg1 | yup, that new property is pretty good place for values like that | 14:27 |
lucasagomes | yup | 14:27 |
lucasagomes | +1 then | 14:27 |
lucasagomes | :) | 14:27 |
*** seannj427 has joined #openstack-ironic | 14:28 | |
*** Haomeng has quit IRC | 14:38 | |
*** yfujioka has quit IRC | 14:39 | |
*** Haomeng|2 has joined #openstack-ironic | 14:40 | |
Shrews | lucasagomes: well, since we aren't filling in those values for the instance, it shouldn't be any more wrong to just put in the label values. :) TripleO will just have to know they're labels and use them appropriately. | 14:41 |
lucasagomes | :) | 14:42 |
seannj427 | Hey folks, need some direction on ironic on icehouse. | 14:43 |
*** tatyana_ has joined #openstack-ironic | 14:43 | |
seannj427 | We are looking to provision ironic services in our existing IceHouse implementation, which has all of the various resources on separate computing entities (keystone, glance, nova scheduler, nova compute, cinder, neutron). | 14:43 |
seannj427 | Before we make changes to our existing infrastructure, in reading the documentation here: http://docs.openstack.org/developer/ironic/deploy/install-guide.html We have a few questions. | 14:43 |
*** tatyana has quit IRC | 14:44 | |
*** tatyana_ is now known as tatyana | 14:44 | |
seannj427 | In the section entitled “Configure Compute Service to use the Bare Metal Service”, we see that after we’ve setup the database and the ironic bare metal services, we need to reconfigure the Nova Manager and Compute Nodes. Our questions are: | 14:44 |
seannj427 | 1. Will this change affect the operation of existing services in our existing openstack setup? | 14:44 |
seannj427 | 2. Do we need to make these changes to all of the Nova compute nodes? | 14:44 |
seannj427 | 3. Could we just setup one or 2 nodes to act as ironic-conductors? | 14:44 |
seannj427 | 4. Does the ironic-conductor run on its own resource, on the nova compute and Manager nodes, or on all 3? | 14:45 |
NobodyCam | brb quick walkies | 15:01 |
*** romcheg1 has quit IRC | 15:18 | |
openstackgerrit | A change was merged to openstack/python-ironicclient: node-show to show the instance_info field https://review.openstack.org/94860 | 15:19 |
rloo | hi seannj427. To be clear, with the changes to use Ironic, the OpenStack cluster will not be able to provision both VMs and baremetal. | 15:20 |
rloo | seannj427: so 1. it'll only affect the nova/compute service. | 15:20 |
rloo | seannj427: 2. yes. but you don't need many compute nodes. or at least, not to try out ironic. | 15:21 |
rloo | seannj427: 3. yes. | 15:22 |
rloo | seannj427: 3. well, depends on your load but I'm assuming you just want to try things out. | 15:22 |
openstackgerrit | A change was merged to openstack/ironic: Remove 'node' parameter from the Power interface https://review.openstack.org/91093 | 15:23 |
rloo | seannj427: 4. ironic-conductor can run on its own resource,, or you can have it run on compute node. regardless, the ironic code needs to be installed on compute nodes to get the nova-ironic-driver. | 15:24 |
seannj427 | rloo - thanks. I really appreciate the insight. | 15:25 |
rloo | seannj427: hope that helps. let us know how it goes! | 15:25 |
rloo | seannj427: it occurs to me that there might be things missing from that docn. so ask :-) | 15:26 |
*** romcheg has joined #openstack-ironic | 15:27 | |
seannj427 | rloo I was @ openstack ATL a few weeks ago. It was mentioned that doc help is needed, so, if we decide to go forward, I'll post any suggested changes here or on the message board. I'm sort of leaning in the direction at this point that we should have a parallel openstack deployment for baremetal. | 15:29 |
*** blamar has quit IRC | 15:29 | |
rloo | seannj427: YES, doc help is needed! | 15:29 |
rloo | seannj427: what's a message board? etherpad? Whatever is easiest for you. You are also welcome to update the docn by submitting a patch. But we'll take feedback however ;) thx. | 15:31 |
seannj427 | rloo sorry I'm a newb here. :) | 15:31 |
*** BadCub has joined #openstack-ironic | 15:32 | |
*** BadCub has quit IRC | 15:32 | |
rloo | seannj427: no worries. And welcome to Ironic! :D | 15:34 |
*** BadCub has joined #openstack-ironic | 15:35 | |
openstackgerrit | David Shrewsbury proposed a change to openstack/ironic: WIP: Set instance default_ephemeral_device https://review.openstack.org/96498 | 15:37 |
*** jcoufal has quit IRC | 15:50 | |
rloo | seannj427: etherpad for install notes: https://etherpad.openstack.org/p/IronicInstallationNotes. Feel free to add. | 15:52 |
romcheg | lucasagomes Shrews: So what are our plan for the label? I think David's solution works as a temporary fix but I think we need to figure out about generating unique labels (either default+uuid or default+random stored in instance_info) | 15:52 |
Shrews | romcheg: labels cannot be more than 16 characters, as it turns out | 15:56 |
romcheg | Shrews: so uuid is not an option | 15:56 |
Shrews | not sure what the permanent fix is going forward, but I'm having the tripleo guys test that patch out now | 15:57 |
Shrews | since it's a big problem for them right now | 15:58 |
*** shakayumi is now known as shakamunyi | 15:59 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements https://review.openstack.org/96228 | 16:00 |
NobodyCam | hummm:touch: cannot touch '/tmp/image.jPTuKVU1/mnt/etc/resolv.conf': No such file or directory | 16:06 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/96263 | 16:06 |
*** dguerri is now known as _dguerri | 16:07 | |
*** zdiN0bot has joined #openstack-ironic | 16:08 | |
lucasagomes | NobodyCam, broken link maybe? | 16:10 |
*** _dguerri is now known as dguerri | 16:10 | |
* NobodyCam is thinking no path ... touch should create the file | 16:11 | |
*** martyntaylor has quit IRC | 16:14 | |
*** matty_dubs is now known as matty_dubs|lunch | 16:14 | |
*** blamar has joined #openstack-ironic | 16:16 | |
*** zdiN0bot1 has joined #openstack-ironic | 16:17 | |
lucasagomes | NobodyCam, +1, unless the path it's pointing to doesn't exist | 16:19 |
lucasagomes | e.g | 16:19 |
lucasagomes | http://paste.openstack.org/show/82059/ | 16:19 |
*** zdiN0bot has quit IRC | 16:21 | |
NobodyCam | creating the dir got me past the error | 16:21 |
*** zdiN0bot1 has quit IRC | 16:24 | |
*** zdiN0bot has joined #openstack-ironic | 16:29 | |
*** martyntaylor has joined #openstack-ironic | 16:33 | |
*** romcheg has left #openstack-ironic | 16:37 | |
*** bandicot has joined #openstack-ironic | 16:38 | |
*** romcheg has joined #openstack-ironic | 16:41 | |
romcheg | Gotta go to my spanish class, will be back later | 16:41 |
openstackgerrit | David Shrewsbury proposed a change to openstack/ironic: WIP: Set instance default_ephemeral_device https://review.openstack.org/96498 | 16:42 |
lucasagomes | romcheg, enjoy | 16:49 |
NobodyCam | conf call done.. brb | 16:51 |
*** jistr is now known as jistr|afk | 16:56 | |
*** zdiN0bot has quit IRC | 16:57 | |
lucasagomes | and I'm heading home now, came to the office today | 16:58 |
lucasagomes | have a good night everybody | 16:58 |
*** lucasagomes has quit IRC | 16:59 | |
*** harlowja_away is now known as harlowja_ | 17:02 | |
NobodyCam | night lucas | 17:03 |
*** jbjohnso has quit IRC | 17:04 | |
*** zdiN0bot has joined #openstack-ironic | 17:13 | |
*** matty_dubs|lunch is now known as matty_dubs | 17:14 | |
devananda | g'morning, all! | 17:14 |
NobodyCam | good morning devananda | 17:14 |
matty_dubs | Howdy devananda | 17:15 |
*** jistr|afk has quit IRC | 17:16 | |
Shrews | hey devananda | 17:16 |
*** derekh_ has quit IRC | 17:18 | |
*** dwalleck has joined #openstack-ironic | 17:26 | |
* devananda catches up on all the emails | 17:27 | |
*** jbjohnso has joined #openstack-ironic | 17:31 | |
jroll | morning ironic | 17:32 |
NobodyCam | goot en morgan taug jroll | 17:32 |
*** zdiN0bot has quit IRC | 17:34 | |
*** zdiN0bot has joined #openstack-ironic | 17:34 | |
*** eghobo has joined #openstack-ironic | 17:34 | |
*** praefect1 has joined #openstack-ironic | 17:42 | |
*** praefect has quit IRC | 17:43 | |
*** praefect has joined #openstack-ironic | 17:45 | |
*** sysexit has quit IRC | 17:46 | |
openstackgerrit | linggao proposed a change to openstack/ironic-specs: Add console log support https://review.openstack.org/96538 | 17:46 |
rloo | NobodyCam: thx for updating 93133! I left a few comments. Wo bist du? | 17:47 |
*** praefect1 has quit IRC | 17:47 | |
NobodyCam | :) Ty rloo will take a look | 17:49 |
devananda | augh - gotta run, eye appt | 17:50 |
* devananda needs sunglasses | 17:50 | |
devananda | bbiah | 17:50 |
rloo | devananda wants to be cool! | 17:50 |
NobodyCam | enjot devananda :) | 17:50 |
NobodyCam | enjoy even | 17:51 |
openstackgerrit | linggao proposed a change to openstack/ironic-specs: Add console log support https://review.openstack.org/96538 | 17:51 |
lifeless | Shrews: huh | 17:53 |
lifeless | Shrews: no, I'm saying precalculate like nova-bm did | 17:53 |
Shrews | lifeless: precalculate what? | 17:53 |
lifeless | Shrews: the devname to put in the metadata | 17:53 |
lifeless | at least as a unbreak-things step | 17:53 |
*** tatyana has quit IRC | 17:54 | |
Shrews | lifeless: nova-bm used a hardcoded value. we can't determine what the real dev name is | 17:54 |
lifeless | longer term we should expose the partition map back from the conductor and nova can do a read-back | 17:54 |
lifeless | Shrews: I don't understand why you can't use a hard coded value and an if statement | 17:54 |
lifeless | Shrews: in the short term, not in the long term | 17:54 |
*** bandicot has quit IRC | 17:55 | |
Shrews | lifeless: Ng is trying this short term fix out: https://review.openstack.org/96498 | 17:55 |
*** max_lobur has quit IRC | 17:56 | |
Shrews | as long as udev is present, that should work | 17:56 |
*** martyntaylor has left #openstack-ironic | 17:56 | |
lifeless | thats an interesting approach | 17:56 |
lifeless | it makes me nervous | 17:56 |
lifeless | because labels are not necessarily unique | 17:56 |
Shrews | well, that's another issue | 17:57 |
Shrews | random labels has been tossed around today | 17:57 |
*** openstackgerrit has quit IRC | 17:57 | |
lifeless | what stops us using the nova bm logic | 17:57 |
lifeless | I haven't had an answer to that | 17:57 |
Shrews | lifeless: we can set it to '/dev/sda?' like nova-bm, i don't see how that's better though | 17:58 |
Shrews | that seems less likely to work to me | 17:58 |
Shrews | (for more cases) | 17:58 |
*** aboutGod has joined #openstack-ironic | 17:59 | |
lifeless | Shrews: that gets us something we know works in a wide variety of things today, and room to discuss alternative approaches | 17:59 |
lifeless | Shrews: we *know* cloud-init is fussy about this stuff | 17:59 |
lifeless | Shrews: since we are already having to carry a fix for it, I really don't want to make it worse | 17:59 |
lifeless | Shrews: so here are my concerns | 18:02 |
lifeless | - /dev/sdaN is a known quantity | 18:02 |
lifeless | - its also mechanically relevant to the partition table layer which means we aren't introducing a dependency on an in-operating-system concept into Ironic | 18:03 |
lifeless | - we have an ecosystem of other tools that may well contain bugs - like we hit merely by going to /dev/sdaN vs /dev/sda - by doing anything more exotic | 18:03 |
lifeless | Shrews: TripleO testenvs are already defined without virtio for disk, because of the /dev/sda thing. | 18:04 |
lifeless | Shrews: What I'm proposing is that we do what we know works today, and open a design spec in ironic-specs for permitting that to be different (e.g. /dev/vda *or* /...by-label/..., or whatever else comes up when we have a broad design discussion) | 18:05 |
Shrews | lifeless: if it unblocks tripleo, and the nova-bm way is your preference, i'm totally fine with that | 18:07 |
NobodyCam | hummm no notice of patch uploaded... /me thinks ye old gerrit bot has died | 18:07 |
NobodyCam | rloo: 93133 pushed | 18:08 |
rloo | NobodyCam: thx! Going to look at it now. Maybe I'll beat Jenkins ;) | 18:08 |
Shrews | openstackgerrit | 18:08 |
Shrews | hrm, sometimes just calling it's name brings it back. not this time i guess | 18:09 |
lifeless | its not in the channel | 18:10 |
lifeless | Shrews: I would feel a lot safer doing that, for all that it has flaws - thank you! | 18:11 |
Shrews | lifeless: i *think* /dev/sda1 is the correct value... just need to verify before pushing up another patchset | 18:11 |
Shrews | *and* figure out why the nova tests are breaking with "unknown table" | 18:12 |
lifeless | yes, ephemeral when present is first in Ironic | 18:14 |
*** bandicot has joined #openstack-ironic | 18:14 | |
*** aboutGod has left #openstack-ironic | 18:14 | |
NobodyCam | humm check_uptodate.sh: ironic.conf.sample is not up to date. looks like I need a rebase too :) | 18:14 |
*** sysexit has joined #openstack-ironic | 18:16 | |
Shrews | lifeless: patchset pushed https://review.openstack.org/96498. if you could give that a spin to verify it unblocks you, that would be great | 18:19 |
*** pelix has quit IRC | 18:21 | |
lifeless | Ng: ^ | 18:23 |
lifeless | / adam_g ^ | 18:23 |
Ng | GheRivero was running a build with that applied, on 405 just before I broke for dinner | 18:25 |
* Shrews needs to step away for a while. Will check in tonight | 18:26 | |
lifeless | Ng: the new one was just pushed up | 18:27 |
lifeless | Ng: after I freaked out | 18:27 |
*** sysexit has quit IRC | 18:27 | |
lifeless | (call a spade a spade) | 18:27 |
Ng | lifeless: ah right | 18:29 |
Ng | we'll get a fresh build running | 18:29 |
NobodyCam | anyone have the generate_sample command line handy? | 18:35 |
rloo | NobodyCam: you mean something like ./tools/config/generate_sample.sh -b . -p ironic -o ./etc/ironic? | 18:37 |
comstud | So | 18:37 |
comstud | new keystoneclient was posted to pypi today | 18:38 |
comstud | that breaks our tests | 18:38 |
comstud | Anyone fix it yet? If not, I'll put up the patch | 18:38 |
comstud | I don't see it in list of ironic reviews yet | 18:38 |
NobodyCam | rloo: yeppers ..ty | 18:38 |
rloo | comstud: if no patch and no bug, i think it's all yours. haven't heard anyone mention in in the past 5 hours or so. | 18:39 |
comstud | File "/home/cbehrens/git/ironic/os.git/.tox/py27/local/lib/python2.7/site-packages/keystoneclient/middleware/auth_token.py", line 1154, in _cache_store | 18:39 |
comstud | cache.set(cache_key, data_to_store, time=self.token_cache_time) | 18:39 |
comstud | TypeError: set() got an unexpected keyword argument 'time' | 18:39 |
comstud | anyway, ok. I have a patch I'll put up | 18:40 |
rloo | comstud: thx. not familiar with keystoneclient. should it break existing code? | 18:40 |
comstud | not sure if it actually breaks code or just this test | 18:41 |
comstud | will know in a sec | 18:41 |
rloo | comstud: thought they were supposed to be backwards compatible. | 18:41 |
comstud | i think | 18:41 |
comstud | it's just a stub in our tests | 18:42 |
comstud | for some reason we think it's a good idea to stub something internal to keystoneclient, I guess. | 18:42 |
comstud | :) | 18:42 |
rloo | comstud: ah yeah, the royal we. we are known to change our minds too, if there's good reason :-) | 18:42 |
comstud | hm, it's in our FakeMemcache | 18:42 |
matty_dubs | ls | 18:43 |
matty_dubs | D'oh. I am an idiot. | 18:43 |
NobodyCam | not | 18:44 |
comstud | of course.. | 18:45 |
comstud | Fixing this causes some other tests to fail | 18:45 |
comstud | things like MismatchError: 403 != 401 | 18:45 |
comstud | anyway, I filed bug/1324655 | 18:45 |
comstud | and am working on it | 18:45 |
comstud | https://bugs.launchpad.net/ironic/+bug/1324655 | 18:45 |
comstud | The alternative here, is we lock our requirements to the older keystoneclient version, I guess | 18:48 |
comstud | I'm a little concerned that it appears API code responses will change | 18:48 |
NobodyCam | with out digging into that ... I would agree thats concerning | 18:50 |
Ng | lifeless: I think we might want to see if we can do something with https://bugs.launchpad.net/ironic/+bug/1320513 - we've killed multiple nodes in 405 with it so far, they required a physical power cycle to restore :( | 18:50 |
lifeless | Ng: I suggested to nick that he talk to devananda about finding a volunteer to fix it. | 18:51 |
adam_g | Ng, does that explain the RESET state we've seen? | 18:53 |
lifeless | adam_g: yes, thats why I filed it | 18:53 |
lifeless | its in the end-to-end etherpad | 18:54 |
NobodyCam | Ng: lifeless: I wounder if setting https://github.com/openstack/ironic/blob/master/ironic/openstack/common/processutils.py#L90 would be a quick fix? | 18:56 |
lifeless | NobodyCam: thats a starting point | 18:58 |
lifeless | NobodyCam: we also need inter-command gaps | 18:58 |
lifeless | NobodyCam: between off and on, for instance. | 18:58 |
*** zdiN0bot has quit IRC | 19:03 | |
*** zdiN0bot1 has joined #openstack-ironic | 19:03 | |
comstud | NobodyCam: I think the problem appears to be our FakeMemcache is... crappy. | 19:07 |
comstud | and doesn't fully implement stuff | 19:07 |
comstud | We have a 'timeout' kwarg that should be named 'time' | 19:07 |
comstud | and we don't actually do anything with it | 19:07 |
*** openstackgerrit has joined #openstack-ironic | 19:07 | |
*** bandicot has quit IRC | 19:11 | |
NobodyCam | comstud: for the failing conf file check | 19:12 |
NobodyCam | ? | 19:12 |
comstud | I'm talking about the test failures with new keystoneclient | 19:13 |
comstud | and our FakeMemcache | 19:13 |
*** openstackgerrit has quit IRC | 19:13 | |
*** zdiN0bot1 has quit IRC | 19:15 | |
*** eghobo has quit IRC | 19:23 | |
*** eghobo has joined #openstack-ironic | 19:23 | |
NobodyCam | lifeless: Ng: heres a quick stab at 1320513: https://review.openstack.org/#/c/96558 (totaly untested) | 19:26 |
Ng | NobodyCam: will that mean that ipmi commands across all nodes will be spaced out by 5 seconds, rather than per node? | 19:27 |
*** derekh_ has joined #openstack-ironic | 19:27 | |
NobodyCam | humm it could | 19:27 |
lifeless | it does | 19:28 |
lifeless | I have just written tat in review | 19:28 |
NobodyCam | I'll put more thought in to it... | 19:30 |
*** jrist has quit IRC | 19:30 | |
NobodyCam | i did say quick stab :-p hehehehe | 19:30 |
lifeless | reviewed | 19:30 |
NobodyCam | lol love the epoch used as last time comment | 19:32 |
*** openstackgerrit has joined #openstack-ironic | 19:35 | |
*** foexle has quit IRC | 19:37 | |
*** max_lobur has joined #openstack-ironic | 19:39 | |
*** jrist has joined #openstack-ironic | 19:45 | |
*** ifarkas has quit IRC | 19:49 | |
*** ellenh has joined #openstack-ironic | 19:51 | |
openstackgerrit | linggao proposed a change to stackforge/pyghmi: Added password file support https://review.openstack.org/96569 | 19:52 |
*** zdiN0bot has joined #openstack-ironic | 20:01 | |
*** praefect has quit IRC | 20:04 | |
*** Mikhail_D_ltp has joined #openstack-ironic | 20:04 | |
Ng | bug #1324670 also seems to be affecting tripleo scale deployments pretty consistently | 20:04 |
Ng | blah bug bots. https://bugs.launchpad.net/ironic/+bug/1324670 | 20:04 |
comstud | ok | 20:05 |
romcheg | rloo: I don't remember whether I spoke to you today, so hi! | 20:05 |
rloo | hi romcheg. Back again? ;) | 20:05 |
comstud | is Roman around? (dunno his irc nick) | 20:05 |
rloo | comstud: which Roman. romcheg is Roman. | 20:05 |
*** zdiN0bot has quit IRC | 20:06 | |
comstud | Roman Prykhodchenko | 20:06 |
romcheg | that's me | 20:06 |
rloo | bingo :-) | 20:06 |
Ng | lifeless: ^^ another bug we're running into on 405, thought you should be aware | 20:06 |
romcheg | rloo: What do you think about adding a topic for the next meeting about storing extended information about drivers somehow? | 20:06 |
romcheg | comstud: People usually remember my IRC nick but not my name :) | 20:07 |
lifeless | Ng: is that wrapped with attempts=N ? | 20:07 |
comstud | hehehe | 20:08 |
comstud | romcheg: So, this FakeMemcache client in our tests is causing problems | 20:08 |
romcheg | Ah, new keystone client | 20:09 |
comstud | because you're asserting token format.. and some things internal to keystoneclient | 20:09 |
romcheg | I've just read the scrollback | 20:09 |
comstud | which have now changed | 20:09 |
comstud | I think I am onto a real fix now.... | 20:09 |
comstud | but I think maybe we should rethink stubbing in this way at some point | 20:09 |
comstud | :) | 20:09 |
comstud | the new keystone middleware is now looking for a 'expires' or 'expires_at' in the token | 20:09 |
comstud | along with a kwarg change to the cache client | 20:09 |
romcheg | Lemme check that code again. I worked on it ages ago :) | 20:10 |
comstud | yeah, july | 20:10 |
Ng | lifeless: not afaics, looks like it's line 71 in ironic/drivers/modules/deploy_utils.py | 20:10 |
romcheg | 10 Month == ages in terms of the time after you worked on some code :) | 20:10 |
rloo | romcheg: that properties stuff is static. seems like we should be able to get the info from the code/files themselves, not from a db. haven't thought much about it though. | 20:10 |
lifeless | Ng: might be an easy patch then | 20:11 |
Ng | lifeless: worth a shot I guess :) | 20:11 |
romcheg | rloo: We should consider whether that information might be useful for something else. Or even maybe there is some additional information that should be stored somewhere. | 20:12 |
romcheg | rloo: Anyway, I think that it requires a good discussion | 20:12 |
*** rloo has quit IRC | 20:12 | |
*** rloo has joined #openstack-ironic | 20:13 | |
romcheg | comstud: is that test_acl that causes the problem? | 20:14 |
*** praefect has joined #openstack-ironic | 20:14 | |
comstud | ok | 20:14 |
comstud | yes | 20:14 |
comstud | that's one of them | 20:14 |
comstud | er | 20:14 |
comstud | that file is the problem | 20:14 |
comstud | So I have a fix now | 20:14 |
comstud | pushing it up | 20:15 |
romcheg | I'm going to take a look at that as soon as it's in gerrit | 20:15 |
comstud | it's pretty simple | 20:16 |
openstackgerrit | Chris Behrens proposed a change to openstack/ironic: Fix tests with new keystoneclient https://review.openstack.org/96576 | 20:16 |
comstud | but unfortunately keystone client turns 500s into 401s which was extra confusing | 20:16 |
comstud | I had to have them look at this for me | 20:16 |
openstackgerrit | Chris Jones proposed a change to openstack/ironic: Work around iscsiadm delete failures. https://review.openstack.org/96577 | 20:16 |
comstud | romcheg: ^^ | 20:16 |
* romcheg is looking | 20:16 | |
romcheg | Yeah, it's pretty simple indeed. | 20:18 |
*** ellenh has quit IRC | 20:18 | |
comstud | romcheg: So, longer term, I think we should not stub this way | 20:19 |
comstud | They've suggested some alternatives | 20:19 |
comstud | [13:06:04] <morganfainberg> comstud, i think | 20:19 |
comstud | https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/fixture/v2.py is what you | 20:19 |
*** derekh_ has quit IRC | 20:19 | |
comstud | should use to create the fake token | 20:19 |
comstud | like that, for example, to create auth tokens so we don't have to assume format | 20:19 |
romcheg | comstud: That sounds very reasonable | 20:20 |
-openstackstatus- NOTICE: Gerrit is going offline to correct an issue with a recent project rename. ETA 20:45 UTC. | 20:20 | |
*** ChanServ changes topic to "Gerrit is going offline to correct an issue with a recent project rename. ETA 20:45 UTC." | 20:20 | |
romcheg | comstud: Perhaps it's reasonable to file a bug for that | 20:21 |
comstud | yeah | 20:21 |
comstud | was thinking that also | 20:21 |
comstud | doing so now | 20:21 |
*** bandicot has joined #openstack-ironic | 20:22 | |
*** Mikhail_D_ltp has quit IRC | 20:23 | |
comstud | https://bugs.launchpad.net/ironic/+bug/1324684 | 20:23 |
*** Mikhail_D_ltp has joined #openstack-ironic | 20:25 | |
*** openstackgerrit has quit IRC | 20:25 | |
romcheg | comstud: Are you going to work on that? | 20:26 |
Ng | Shrews: lifeless: FYI, the new revision on 96498 seems to work :) | 20:31 |
comstud | romcheg: Probably not... not right now anyway | 20:32 |
matty_dubs | romcheg: Hey, totally off-topic, but did you ever find your camera bag from Summit? | 20:32 |
romcheg | comstud: I will try fixing it in the morning, if you won't have time/interest in doing that by that time :) | 20:33 |
romcheg | matty_dubs: No, I didn't. There is a chance to get myself a new camera | 20:34 |
romcheg | matty_dubs: At least now I have a firm reason for that :) | 20:34 |
matty_dubs | Ugh, sorry to hear that. Though I like the way you think. ;) | 20:34 |
romcheg | matty_dubs: I miss emotions or people (in some cases), not the things I can buy any time :) | 20:36 |
*** Mikhail_D_ltp has quit IRC | 20:39 | |
*** ChanServ changes topic to "OpenStack Bare Metal Provisioning | Docs: http://docs.openstack.org/developer/ironic/ | Bugs: https://bugs.launchpad.net/ironic | Status: https://etherpad.openstack.org/p/IronicWhiteBoard" | 20:39 | |
-openstackstatus- NOTICE: Gerrit is back online | 20:39 | |
*** linggao has quit IRC | 20:39 | |
*** Mikhail_D_ltp has joined #openstack-ironic | 20:40 | |
comstud | romcheg: I will definitely not be working on it in the next week | 20:44 |
comstud | :) | 20:44 |
romcheg | comstud: Got it :) | 20:44 |
comstud | Too many other things to do... and as long as it works for now with new keystoneclient, I'm good | 20:44 |
NobodyCam | lifeless: Ng: just a rev 2 of https://review.openstack.org/#/c/96558 | 20:49 |
NobodyCam | gah... s/just a/just PUSHED a/ | 20:49 |
*** shakamunyi has quit IRC | 20:51 | |
devananda | back from lunch | 20:51 |
devananda | but only for a few hours | 20:52 |
NobodyCam | wb devananda | 20:52 |
* devananda reads lots of scrollback | 20:52 | |
*** shakamunyi has joined #openstack-ironic | 20:52 | |
*** rloo has quit IRC | 20:53 | |
romcheg | Ok guys, it's quite late here already. | 20:54 |
*** jdob has quit IRC | 20:54 | |
*** rloo has joined #openstack-ironic | 20:54 | |
romcheg | See you tomorrow! Bye! | 20:54 |
NobodyCam | have a good night romcheg | 20:54 |
matty_dubs | +1 | 20:55 |
*** zdiN0bot has joined #openstack-ironic | 20:55 | |
*** rloo has quit IRC | 20:55 | |
*** rloo has joined #openstack-ironic | 20:56 | |
*** rloo has quit IRC | 20:56 | |
*** Mikhail_D_ltp has left #openstack-ironic | 20:56 | |
*** rloo has joined #openstack-ironic | 20:56 | |
*** dwalleck_ has joined #openstack-ironic | 20:57 | |
*** dwalleck_ has quit IRC | 21:00 | |
lifeless | Ng: great | 21:00 |
*** dwalleck_ has joined #openstack-ironic | 21:00 | |
*** sysexit has joined #openstack-ironic | 21:00 | |
*** dwalleck has quit IRC | 21:00 | |
Shrews | Ng: awesome. Will clean the patch up when I get back from this OS meetup | 21:01 |
*** rloo has quit IRC | 21:01 | |
*** rloo has joined #openstack-ironic | 21:01 | |
*** matty_dubs is now known as matty_dubs|gone | 21:04 | |
*** shakamunyi has quit IRC | 21:14 | |
*** jbjohnso has quit IRC | 21:18 | |
*** romcheg has left #openstack-ironic | 21:20 | |
*** eguz has joined #openstack-ironic | 21:26 | |
devananda | comstud: thanks for fixing that - i'm waiting for Jenkins to test it | 21:27 |
*** Penick has joined #openstack-ironic | 21:29 | |
NobodyCam | devananda: if you have time https://review.openstack.org/#/c/96558 an attempt to stop flooding bmc's | 21:29 |
devananda | NobodyCam: yea, on my queue | 21:29 |
NobodyCam | :) | 21:29 |
*** eghobo has quit IRC | 21:30 | |
comstud | devananda: np | 21:31 |
*** openstackgerrit has joined #openstack-ironic | 21:35 | |
openstackgerrit | A change was merged to openstack/ironic-python-agent: Switch to oslo.config for CLI parsing https://review.openstack.org/96364 | 21:36 |
*** eghobo has joined #openstack-ironic | 21:38 | |
*** eguz_ has joined #openstack-ironic | 21:39 | |
*** eguz has quit IRC | 21:39 | |
*** praefect has quit IRC | 21:42 | |
*** eghobo has quit IRC | 21:43 | |
*** ellenh has joined #openstack-ironic | 21:45 | |
*** openstackgerrit has quit IRC | 21:47 | |
*** mrda-away is now known as mrda | 21:48 | |
mrda | Morning Ironic | 21:49 |
NobodyCam | morning mrda | 21:49 |
mrda | \o | 21:49 |
devananda | mrda: o/ | 21:54 |
mrda | \o | 21:55 |
*** zdiN0bot has quit IRC | 21:56 | |
*** seannj427 has quit IRC | 21:58 | |
devananda | NobodyCam: comments posted | 22:02 |
*** eguz_ has quit IRC | 22:03 | |
*** eghobo has joined #openstack-ironic | 22:04 | |
*** zdiN0bot has joined #openstack-ironic | 22:05 | |
*** sysexit has quit IRC | 22:07 | |
mrda | hey deva, I'd like to nail down the desired behaviour for https://bugs.launchpad.net/ironic/+bug/1315224 Should we simply power off nodes post registartion if they're on already? | 22:08 |
mrda | devananda: ^^^ sorry | 22:10 |
*** shakamunyi has joined #openstack-ironic | 22:11 | |
devananda | mrda: https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/node.py#L637 | 22:12 |
devananda | and | 22:13 |
devananda | https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L97 | 22:13 |
devananda | mrda: so... I think it's a reasonable thing to do IFF force_power_state_during_sync=TRUE | 22:14 |
devananda | even if that option is TRUE, the creation of a node is simply a DB insert. it doesn't pass anything to conductor today -- so this would be a bit of a larger change | 22:15 |
mrda | ok, so when a node is registered, if force_power_state_during_sync is True, power off the node (since the default power state in the DB is off)? | 22:15 |
devananda | and create another point where API requests could starve RPC threads | 22:15 |
mrda | ok, so it sounds like you're reluctant for this change to happen | 22:16 |
* devananda rereads the code | 22:16 | |
mrda | ...unless some clever code can be constructed to not create a new problem :) | 22:16 |
devananda | https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L530 | 22:16 |
devananda | so current behavior is, if node has no power state recorded in the db, we just update the DB with the actual state | 22:17 |
devananda | regardless | 22:17 |
devananda | so this is a behavior change, and possibly an RPC API change | 22:18 |
mrda | hmmm. | 22:20 |
JayF | I kinda like the existing behavior. | 22:21 |
*** shakamunyi has quit IRC | 22:22 | |
JayF | Reflect the reality of the power state when the node is registered vs dictating it means you only cycle the power if needed (i.e. if the nodes weren't in the correct vlan to boot the [agent|pxe] ramdisk at startup) | 22:22 |
*** shakayumi has joined #openstack-ironic | 22:22 | |
mrda | JayF: I guess that's why I'm seeking PTL direction on this :) | 22:27 |
comstud | devananda: https://review.openstack.org/#/c/96576/ is G2G | 22:47 |
comstud | according to jenkins | 22:47 |
*** zdiN0bot has quit IRC | 22:49 | |
devananda | NobodyCam: around? want to look at ^ ? | 22:51 |
*** bandicot has quit IRC | 22:52 | |
* NobodyCam looking | 22:59 | |
* NobodyCam landing | 23:02 | |
*** zdiN0bot has joined #openstack-ironic | 23:02 | |
*** zdiN0bot has quit IRC | 23:02 | |
*** zdiN0bot has joined #openstack-ironic | 23:03 | |
*** bandicot has joined #openstack-ironic | 23:03 | |
*** dwalleck_ has quit IRC | 23:04 | |
NobodyCam | devananda: thank you for the feed back. :) i'm making the corrections but prob wont end up pushing to the morning :) | 23:04 |
devananda | NobodyCam: ack | 23:04 |
devananda | switching networks to try to file expenses, then heading out after that | 23:05 |
NobodyCam | have a good night devananda | 23:06 |
mrda | thanks deva | 23:06 |
*** derekh_ has joined #openstack-ironic | 23:09 | |
*** max_lobur has quit IRC | 23:17 | |
*** radsy has joined #openstack-ironic | 23:18 | |
*** radsy has joined #openstack-ironic | 23:18 | |
*** zdiN0bot has quit IRC | 23:31 | |
*** zdiN0bot has joined #openstack-ironic | 23:38 | |
*** derekh_ has quit IRC | 23:44 | |
*** zdiN0bot has quit IRC | 23:49 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!