Tuesday, 2014-05-27

*** romcheg has joined #openstack-ironic00:10
*** romcheg has left #openstack-ironic00:11
*** radsy has quit IRC00:19
*** matsuhashi has joined #openstack-ironic00:26
*** matsuhashi has quit IRC00:33
*** matsuhashi has joined #openstack-ironic00:34
*** yongli has quit IRC00:39
*** igor_ has joined #openstack-ironic00:52
*** igor_ has quit IRC00:57
*** radsy has joined #openstack-ironic01:02
*** matsuhashi has quit IRC01:33
*** matsuhashi has joined #openstack-ironic01:34
*** nosnos has joined #openstack-ironic01:44
*** igor_ has joined #openstack-ironic01:53
*** igor_ has quit IRC01:57
*** igor_ has joined #openstack-ironic02:54
*** igor_ has quit IRC02:58
*** coolsvap|afk is now known as coolsvap03:06
*** vinbs has joined #openstack-ironic03:11
*** rameshg87 has joined #openstack-ironic03:17
*** nosnos has quit IRC03:25
*** ramineni has joined #openstack-ironic03:29
*** eghobo has joined #openstack-ironic03:30
*** igor_ has joined #openstack-ironic03:55
*** igor_ has quit IRC03:59
*** shausy has joined #openstack-ironic04:31
*** Haomeng has joined #openstack-ironic04:35
*** nosnos has joined #openstack-ironic04:46
*** coolsvap is now known as coolsvap|afk04:54
*** sabah has joined #openstack-ironic04:55
*** igor_ has joined #openstack-ironic04:55
*** igor_ has quit IRC05:00
*** k4n0 has joined #openstack-ironic05:03
*** vkdrao has joined #openstack-ironic05:12
mrdalucasagomes: we should chat when you're online next re: dell kit and ironic05:14
*** k4n0 has quit IRC05:21
*** rameshg87 has left #openstack-ironic05:24
*** lazy_prince has joined #openstack-ironic05:27
*** takadayuiko has joined #openstack-ironic05:29
*** k4n0 has joined #openstack-ironic05:30
*** lazy_prince has quit IRC05:31
*** lazy_prince has joined #openstack-ironic05:32
*** eghobo has quit IRC05:44
*** coolsvap|afk is now known as coolsvap05:50
*** rameshg87 has joined #openstack-ironic05:50
*** igor_ has joined #openstack-ironic05:56
*** igor_ has quit IRC06:00
*** Mikhail_D_ltp has joined #openstack-ironic06:09
*** sysexit_away has joined #openstack-ironic06:10
*** radsy has quit IRC06:13
*** sysexit_away is now known as sysexit06:16
dtantsur|afkmorning Ironic06:30
dtantsur|afklifeless, I think we could merge it06:31
*** dtantsur|afk is now known as dtantsur06:31
lifelessdtantsur: you have it marked WIP06:35
dtantsurlifeless, yeah, I'm finishing it right now06:35
mrdahey dtantsur06:35
dtantsurhey mrda06:36
mrda'grats on the nomination to core!06:37
openstackgerritlifeless proposed a change to openstack/ironic: Workaround for conflicting volume labels  https://review.openstack.org/9313306:37
openstackgerritlifeless proposed a change to openstack/ironic: Allow more time for API requests to be completed  https://review.openstack.org/9373106:37
openstackgerritDmitry Tantsur proposed a change to openstack/ironic: NodeLocked causing random test failures  https://review.openstack.org/9557306:43
dtantsurmrda, oh, thanks :)06:43
dtantsurlifeless, I've posted what I think could be the final version06:44
dtantsurlet us see what Jenkins will say06:44
lifelesscool06:46
*** ifarkas has joined #openstack-ironic06:50
*** rameshg87 has left #openstack-ironic06:56
*** igor_ has joined #openstack-ironic06:57
*** igor_ has quit IRC07:01
*** rameshg87 has joined #openstack-ironic07:02
*** rameshg87 has quit IRC07:03
*** boris-42 has quit IRC07:03
*** rameshg87 has joined #openstack-ironic07:03
*** boris-42 has joined #openstack-ironic07:11
Haomengdtantsur: 'grats:)07:16
*** jcoufal has joined #openstack-ironic07:17
dtantsurHaomeng, thanks) and good morning07:18
*** lazy_prince has quit IRC07:19
Haomengdtantsur: :)07:19
*** lazy_prince has joined #openstack-ironic07:21
*** pradipta_away is now known as pradipta07:28
*** Haomeng|2 has joined #openstack-ironic07:36
*** Haomeng has quit IRC07:37
openstackgerritYuiko Takada proposed a change to openstack/ironic: Remove "node" parameter from methods handling power state  https://review.openstack.org/9567007:51
rameshg87hello dtantsur08:09
dtantsurrameshg87, hi08:09
*** viktors|afk has quit IRC08:09
rameshg87regarding the ilo reviews, we are working on design specs08:09
rameshg87but should we wait for it before raising code reviews ?08:09
rameshg87dtantsur: i mean, can we continue the current code reviews ?08:10
dtantsurrameshg87, patch can't be approved until you get your spec approved. Keeping that in mind, we can continue to work on code quality etc08:11
rameshg87dtantsur - okay, so do you think raising the code review back makes sense ?08:11
*** jistr has joined #openstack-ironic08:14
dtantsurrameshg87, yes, probably. We just won't approve until we have an approved spec (and code clearly corresponds to it).08:14
rameshg87dtantsur - okay, thanks08:14
*** derekh_ has joined #openstack-ironic08:17
*** lucasagomes has joined #openstack-ironic08:29
lucasagomesmorning Ironic :)08:33
*** coolsvap is now known as coolsvap|afk08:34
Haomeng|2lucasagomes: morning:)08:34
mrdahey lucasagomes08:38
mrdalucasagomes: Are you doing testing on Dell hardware?  Can we chat about that briefly?08:39
lucasagomesmrda, hey, I'm not :( I think matt_dubs is08:40
takadayuikoHi lucasagomes :)08:40
mrdaahh, ok.08:40
lucasagomesmrda, but we can chat anyway08:40
lucasagomestakadayuiko, oh hey! good afternoon there :)08:40
mrdaIt was mentioned to me that you might be interested in ensuring Ironic works with Dell hardware.08:41
mrdaI might need to do similar08:41
lucasagomesmrda, that's correct, RH and Dell has a partnership and we are going to implement a drac driver AFAICT08:41
*** igor_ has joined #openstack-ironic08:41
mrdalucasagomes: do you know what hardware is being targeted?  Or the current progress?08:42
lucasagomesmrda, so I think matt_dubs is currently looking at it08:42
lucasagomesmrda, I don't know, but I can ask him today08:42
mrdathat's very interesting re: DRAC08:42
lucasagomesmrda, I didn't access the hardware to check it out yet08:42
mrdaI'd appreciated that - thank you.  I need to go see my family soon at it's been a 12 hour day, and I'll be in trouble soon :)08:43
lucasagomesmrda, yeah, hah I will talk to him today I let you know asap08:43
lucasagomescollaboration is very welcome you guys might want to work together on that08:43
mrdaI can probably get some test kit to play with if required.08:43
lucasagomesnice08:44
dtantsurmorning lucasagomes!08:44
mrdaanyhow, feel free to post here, or PM me, or email michael@the-davies.net once you talk to matty_dubs.08:44
mrdatime to go - have a great day ironic!08:44
*** mrda is now known as mrda_away08:45
lucasagomesmrda, ack will do, enjoy ur family!08:45
lucasagomesdtantsur, morning! and congrats :)08:45
dtantsurthanks :)08:45
dtantsursirushti, hi. Have you seen https://review.openstack.org/#/c/94925/3/specs/juno/better-bootloader-options.rst ? It contains ideas about local boot as well08:45
*** coolsvap|afk is now known as coolsvap08:45
takadayuikolucasagomes: Yes, it's evening ;)08:47
*** nosnos has quit IRC08:48
lucasagomestakadayuiko, ah, heh good evening then... and how was ur trip back to japan from US? no more jet lag?08:48
*** nosnos has joined #openstack-ironic08:48
*** martyntaylor has joined #openstack-ironic08:50
openstackgerritIhar Hrachyshka proposed a change to openstack/ironic: Synced jsonutils from oslo-incubator  https://review.openstack.org/9569108:51
takadayuikolucasagomes: There is no problem about jet lag, I'm fine! Thank you for concern. But I was in LinuxCon last week, so I couldn't come back to OpenStack :(08:52
*** nosnos has quit IRC08:53
lucasagomestakadayuiko, I see, well that's good as well :D I saw a couple of pictures from the LinuxCon Japan (by greg kroah hartman mostly) last week, really nice! Hope one day I can make it too08:53
*** max_lobur has joined #openstack-ironic08:55
*** pradipta is now known as pradipta_away08:55
*** lazy_prince2 has joined #openstack-ironic08:59
*** lazy_prince has quit IRC09:00
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic-specs: Add instance_info field to Node model  https://review.openstack.org/9570109:02
*** ramineni has left #openstack-ironic09:06
sirushtidtantsur, Thanks, will do09:08
takadayuikolucasagomes: yeah, it was my first time for LinuxCon. And it was also my first time seeing "live" Linus!09:08
dtantsurseeing live Linus sounds cool!09:08
lucasagomestakadayuiko, oh haha nice!09:08
lucasagomesI saw him only once as well, it was in 2010 at the first LinuxCon brazil09:09
* lucasagomes is getting old :(09:09
sirushtidtantsur, btw, probably have to factor in EFI boot too. Another related thing to ponder on: having a pxe_config per deploy. I suspect we'd need separate pxe_config templates for different nodes, no?09:09
dtantsurCould you elaborate on this? I'm not quite sure I understand the context09:10
*** igordcard has joined #openstack-ironic09:10
*** lazy_prince2 is now known as lazy_prince09:11
lucasagomessirushti, for EFI boot we need to create an EFI boot partition and all09:11
lucasagomesI think there's a guy from intel working on that09:11
dtantsurlucasagomes, it may be included into  https://review.openstack.org/#/c/94925/3/specs/juno/better-bootloader-options.rst than, what do you think?09:12
sirushtiRight, I assumed we'd have separate PXE config files for EFI?09:12
lucasagomesdtantsur, hmm right, well I think it's good to that blueprint make it flexible to extend and add other bootloaders (as needed for UEFI)09:13
lucasagomesbut I don't think we should actually do the UEFI work on that blueprint09:13
lucasagomesI would think about it as a plumbing working09:13
lucasagomessirushti, yes09:14
sirushtilucasagomes, question is, are there plans to have a pxe_config per deploy?09:15
sirushtiit'll be a lot more convenient that way right?09:16
lucasagomessirushti, you mean a pxe config file per machine deployed with the PXE driver?09:17
sirushtilucasagomes, yeah09:17
lucasagomessirushti, yes, I'm assuming that as well09:17
sirushtidtantsur, lucasagomes thanks for the clarifications :-)09:24
lucasagomessirushti, np :)09:24
*** lokesh184 has joined #openstack-ironic09:26
*** nosnos has joined #openstack-ironic09:35
*** tatyana has joined #openstack-ironic09:35
*** lokesh184 has quit IRC09:36
*** lokesh184 has joined #openstack-ironic09:36
*** lazy_prince2 has joined #openstack-ironic09:38
*** lazy_prince has quit IRC09:40
*** nikunj2512 has joined #openstack-ironic09:47
*** Mikhail_D_ltp has quit IRC09:48
*** matsuhashi has quit IRC09:58
*** matsuhashi has joined #openstack-ironic10:00
*** coolsvap is now known as coolsvap|afk10:00
*** rameshg87 has quit IRC10:00
*** matsuhashi has quit IRC10:07
*** nosnos has quit IRC10:07
*** matsuhashi has joined #openstack-ironic10:07
openstackgerritYuiko Takada proposed a change to openstack/ironic: Remove "node" parameter from methods handling power state in docs  https://review.openstack.org/9567010:09
takadayuikoTempest patches testing Ironic APIs are:10:11
takadayuikohttps://review.openstack.org/#/c/83345/10:11
takadayuikohttps://review.openstack.org/#/c/89472/10:11
takadayuikohttps://review.openstack.org/#/c/86002/10:11
takadayuikohttps://review.openstack.org/#/c/90282/10:11
*** matsuhashi has quit IRC10:12
takadayuikoWe should review these patches as well as possible because we know about Ironic well than Tempest reviewers :)10:13
lucasagomestakadayuiko, :) thank you! I will take a look when I get some free time10:13
takadayuikolucasagomes: I know you are busy, of course, just FYI. I think that by improving Tempest tests, all of us will be happy.10:16
lucasagomestakadayuiko, +1!! We rely on tempest a lot10:18
lucasagomeseverybody should review the ironic related tempest stuff10:18
*** rameshg87 has joined #openstack-ironic10:20
*** lazy_prince2 has quit IRC10:24
*** lokesh184 has quit IRC10:27
*** nikunj2512 has quit IRC10:27
*** lazy_prince has joined #openstack-ironic10:28
*** vkdrao has quit IRC10:29
*** nikunj2512 has joined #openstack-ironic10:29
*** lokesh184 has joined #openstack-ironic10:43
dtantsurvinbs, this bug is supposed to cover your request: https://bugs.launchpad.net/ironic/+bug/132358910:43
dtantsurfeel free to add comments/ideas/suggestions or just press "Affects me"10:44
vinbsdtantsur, thanks a lot! :)10:45
*** rameshg87 has quit IRC10:46
* dtantsur relocates10:49
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Nova Ironic Driver to not get deploy r&k from flavor  https://review.openstack.org/9555110:50
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Move PXE instance level parameters to instance_info  https://review.openstack.org/9485510:50
*** shausy has quit IRC11:02
lucasagomesdtantsur, thanks for pointing me to tempest, yeah I will have to change it too11:02
lucasagomes:(11:02
*** igordcard has quit IRC11:02
*** rameshg87 has joined #openstack-ironic11:05
*** rameshg87 has left #openstack-ironic11:17
*** lokesh184 has quit IRC11:19
*** nikunj2512 has quit IRC11:22
*** romcheg has joined #openstack-ironic11:24
*** sabah has quit IRC11:29
openstackgerritYuiko Takada proposed a change to openstack/ironic: Add util method generating random uuid  https://review.openstack.org/9573311:42
*** Alexei_9871 has joined #openstack-ironic11:44
*** lucasagomes is now known as lucas-hungry11:54
* lucas-hungry lunch time!11:54
romchegMorning guys!11:56
dtantsurmorning romcheg!12:00
takadayuikoHi, romcheg12:01
takadayuikoGood bye everyone, I'll go home!12:02
romchegHow're you guys doing?12:02
*** takadayuiko has quit IRC12:02
romchegBye takadayuiko!12:02
dtantsurFolks, do we have a way of marking a bug as `probably requiring a spec`?12:02
dtantsurFirst of all, I don't think they should be "Triaged", as w/o a spec it's not obvious how to fix them12:03
NobodyCamgood morning Ironic...12:16
dtantsurmorning NobodyCam!12:17
NobodyCamdtantsur: we could add a commment saying I think this change requiers a spec12:17
NobodyCamand morning dtantsur12:18
NobodyCamoh internets are slow this morning12:18
dtantsurAlso re https://review.openstack.org/#/c/91585/ : how many pages are we actually expecting when paginating?12:20
dtantsur(that's mostly for lucas-hungry, but others can think as well)12:20
*** linggao has joined #openstack-ironic12:20
NobodyCamahh :) i need to get with lucas-hungry this morning12:20
NobodyCambut first I need to wake up :-p12:22
NobodyCambrb morning walkies time12:22
*** jdob has joined #openstack-ironic12:33
*** rloo has joined #openstack-ironic12:37
dtantsurNobodyCam, or someone: could you set status of this https://bugs.launchpad.net/python-ironicclient/+bug/1229324 to "Fix Release". I'm getting "Forbidden" on it12:40
*** k4n0 has quit IRC12:40
*** rloo has quit IRC12:42
*** rloo has joined #openstack-ironic12:42
NobodyCamdtantsur: was the patch tagged with that bug?12:43
dtantsurNobodyCam, seems like yes12:43
dtantsursometimes it does no work. Also it does not work for Partial-Bug12:43
NobodyCamya12:44
openstackgerritDan Prince proposed a change to openstack/ironic: Add parallel_image_downloads option  https://review.openstack.org/9521312:49
*** vinbs_ has joined #openstack-ironic12:50
*** rloo has quit IRC12:51
*** romcheg has quit IRC12:52
*** rloo has joined #openstack-ironic12:52
*** romcheg has joined #openstack-ironic12:52
dtantsurdevananda, when you get here: are there any reasons now to keep https://review.openstack.org/#/c/73956/ blocked?12:52
*** vinbs has quit IRC12:52
Shrewsmorning all12:52
NobodyCamgood morning Shrews12:52
*** jgrimm has quit IRC12:53
*** vinbs_ has quit IRC12:56
*** jistr has quit IRC12:57
*** vinbs has joined #openstack-ironic12:59
*** sseago__ has joined #openstack-ironic13:01
*** sseago_ has quit IRC13:01
dtantsurShrews, morning13:02
*** jistr has joined #openstack-ironic13:03
*** sysexit has quit IRC13:03
rlooNobodyCam: morning! (Shrews, dtantsur, and all ironic'ers too)13:03
dtantsurmorning rloo :)13:04
rlooNobodyCam: wrt 93133... guess you're going to rework it?13:04
NobodyCamrloo yep... working it now..13:04
NobodyCamand good morning13:05
* dtantsur is pissed off by Launchpad :-[13:06
*** lucas-hungry is now known as lucasagomes13:07
lucasagomesmorning NobodyCam romcheg rloo13:07
NobodyCammorning lucasagomes13:07
lucasagomesdtantsur, by default I think we have 1000 items per page13:07
NobodyCamhey hey lucasagomes gots a second13:07
*** jcoufal has quit IRC13:07
*** rloo has quit IRC13:07
lucasagomesso idk if we are going to expect 1000 pages13:07
*** jcoufal_ has joined #openstack-ironic13:07
lucasagomesand 1000000 items registered13:07
*** rloo has joined #openstack-ironic13:08
dtantsurlucasagomes, if we never expect >500 pages, I think I'm ok with that patch :)13:08
dtantsurNobodyCam, could you close this https://bugs.launchpad.net/python-ironicclient/+bug/1285530 as invalid? Appropriate patch got -213:08
lucasagomesdtantsur, yeah, well I don;t want to set a limit13:08
lucasagomeslemme look at the code see the flaws13:08
dtantsurlucasagomes, recursion. Python limit is 100013:08
lucasagomesright13:09
* dtantsur is not quite sure that generators do involve recursion here13:09
dtantsurbut I'd prefer to be on a safe side13:09
lucasagomesyeah that's what I'm thinking because I'm using yield there13:10
lucasagomesidk if we are going to hit that problem13:10
lucasagomesI will make a test13:10
*** jbjohnso has joined #openstack-ironic13:11
dtantsurlucasagomes, yeah, test is the best way to decide13:11
NobodyCamlucasagomes: have you seen lifeless comments on 93133, just wanted you to see his comments13:13
lucasagomesNobodyCam, will take a look13:13
NobodyCamI about to rework deploy_utils to not repartition on rebuilds13:14
NobodyCamlucasagomes: his comments are on rev 3513:15
lucasagomesNobodyCam, to not repartiton!?13:15
lucasagomessometimes you need it13:15
NobodyCamthats why I wanted to chat about it13:16
lucasagomesif the new image is bigger than the previous one (and no grow rootfs utility were used)13:16
lucasagomesright13:16
lucasagomesI will check his comments, but I don't think it's a safe assumption that we don't need to repartition13:16
*** praefect has joined #openstack-ironic13:17
NobodyCamif new image is larger and preserve_ephemeral is set. we could end up trashing the ephemeral13:17
*** sysexit has joined #openstack-ironic13:19
lucasagomesNobodyCam, no, because the root is the last partition13:19
lucasagomesthe ephemeral is the first13:19
lucasagomesso it won't affect it13:19
NobodyCamoh thats right13:19
*** dtantsur has quit IRC13:32
*** rakesh_hs has joined #openstack-ironic13:33
*** matty_dubs|gone is now known as matty_dubs13:39
*** dtantsur has joined #openstack-ironic13:41
NobodyCambrb13:42
lucasagomesNobodyCam, commented on patch #3513:44
lucasagomesNobodyCam, I don't I feel that we are over complicating it13:44
lucasagomesNobodyCam, we shouldn't be wipping data from the disk like that or caring whether it's MBR GPT etc...13:45
lucasagomesNobodyCam, IMO if it's a problem with parted for not being less error-prone, maybe we should just use sfdisk/sgdisk in the background to do the partitioning13:46
lucasagomesand conserve the same interface for the DiskPartitioner (add_partition, get_partitions, commit)13:47
*** jgrimm has joined #openstack-ironic13:47
lucasagomeswhich seems to be generic enough13:47
dtantsurmay make sense13:48
dtantsuralso it can change situation around last 1MiB13:48
lucasagomes(and sfdisk friendly, since parted use start/end to create the partitions, and sfdisk uses size, and the DiskPartitioner interface expect size as a parameter to add a partition)13:48
lucasagomesyeah13:48
lucasagomess/I don't feel/I _do_ feel/g13:49
*** jcoufal has joined #openstack-ironic13:49
NobodyCamreading your comments now13:51
*** jcoufal_ has quit IRC13:52
*** vinbs has quit IRC13:52
*** jistr has quit IRC13:53
openstackgerritRuby Loo proposed a change to openstack/ironic: Implement API to get driver properties  https://review.openstack.org/7300513:53
*** igor_ has quit IRC13:54
NobodyCamlucasagomes: if I read your comments correctly I need to remove parted and insert sfdisk?13:56
lucasagomesNobodyCam, well, I would say maybe not we can just easily workaround this problem by removing the labels and then adding it back in the past13:58
lucasagomesbut idk I think that the time we spent talking about this workaround13:58
lucasagomesis not worth13:58
lucasagomesif we are going to spent time thinking about a workaround it would be better to just do the right thing13:58
lucasagomesand not having a workaround at all13:58
lucasagomesif sfdisk and sgdisk is more resilient to such errors with the labels, grand, let's just it13:59
*** annegentle has joined #openstack-ironic13:59
NobodyCami can agree I never saw this growing to 35 + revs,14:00
lucasagomesNobodyCam, looking at the DiskPatitioner interface, I don't think that we are going to need many (if any) changes at it14:00
lucasagomesNobodyCam, yeah14:00
lucasagomesI was ok in just removing the labels with tune2fs14:00
lucasagomesbut now it's total new level of complexity we are introducing there that might not worth to spent time in that workaround14:01
NobodyCamthe removing labels was what it started as, and that got shot down14:01
lucasagomesyeah14:01
rloolucasagomes, NobodyCam: me confused. How did it go from dealing with the labels, to wiping the start/end of the disk?14:01
lucasagomesI know14:01
lucasagomesrloo, see14:01
lucasagomesthat's the thing14:01
lucasagomeswe are not even thinking about the initial problem anymore14:01
lucasagomesthe initial problem is the labels14:01
rloolucasagomes, NobodyCam: I got the feeling that the wiping was needed to address a different issue.14:01
lucasagomeswe could simply iteract over the partitions and issue a tune2fs to remove the label14:01
dtantsurI also have no idea, why tune2fs won't work14:02
lucasagomesrloo, we are not :(14:02
lucasagomesdtantsur, I think it does14:02
lucasagomesNobodyCam, it does right?14:02
lucasagomesrloo, but wipping disks is a general problem for ironic14:02
lucasagomesrloo, we should wipe the whole data of the disk when a new tenant will use the machine... but anyway it's a diff problem and can't be done via iscsi14:03
NobodyCamthis was rev 2. which passed my local rebuild tests: https://review.openstack.org/#/c/93133/2/ironic/drivers/modules/deploy_utils.py14:03
NobodyCami just want to work on some thing that has a chance of landing14:04
*** jistr has joined #openstack-ironic14:04
openstackgerritRakesh H S proposed a change to openstack/ironic: ipmi double bridging functionality  https://review.openstack.org/9577514:04
dtantsurNobodyCam, I like rev 2 except for absent logging14:04
lucasagomeslifeless, ping re parted problem with labels14:04
NobodyCam:)14:04
lucasagomesNobodyCam, I feel sorry cause u've been very active on that problem solving it diff ways, and now I'm here saying to use sfdisk14:05
lucasagomesbut IMO, right now I think that's the best way, simply because that won't require a workaround14:05
rloolucasagomes, NobodyCam: yeah, best to all agree. Sorry, I guess I should have asked initially why you were wiping out the disk etc but I assumed it was needed.14:05
NobodyCamrloo: wipping may still be required for the reasions lifeless pointed out. removing raid / lvm data14:06
rlooNobodyCam: yes, that would be a different bug though.14:07
dtantsurWhy strip lvm data btw?14:09
NobodyCamdtantsur: when we initially partition a disk we need to ensure it is like a new disk. we can not antisapate the state we get disks in14:11
NobodyCam* anticipate14:12
dtantsurNobodyCam, I thought making a new partition will cancel any previous state (except for labels bug)14:12
dtantsurif we can simulate things on file, we can write a test and see14:12
NobodyCamdtantsur: some raids write data to the disk14:12
dtantsurNobodyCam, raids are even harder, I guess. Do we want to wipe their data or just the opposite?14:13
NobodyCamdtantsur: on a new deploy yes we do want to wipe.14:14
NobodyCamif its a rebuild maybe not so much14:14
dtantsurNobodyCam, what's gonna happen to raid than?14:14
rloodtantsur: wrt bug 1323589, lack of docn, and the etherpad: https://etherpad.openstack.org/p/Using_Ironic_to_launch_instances_on_real_hardware14:14
rloodtantsur: the link for 2) in the etherpad is old. The page got moved to a diff url, but I guess we still keep the old page.14:15
NobodyCamdtantsur: if its a new deploy I would not want left over raid config from last tenant on my disk14:16
dtantsurrloo, it's not mine etherpad actually, but will fix, thank you14:16
rloodtantsur: I just updated it ;)14:16
rloodtantsur: didn't know it wasn't yours.14:17
dtantsurrloo, good! I had a strange feeling right now, trying to understand what is wrong :D14:17
rloodtantsur: ha ha. Wonder how we can get the old page deleted.14:17
NobodyCambbt ... brb14:19
dtantsurrloo, so, page http://docs.openstack.org/developer/ironic/deploy/install-guide.html is mostly what we actually were looking for in https://bugs.launchpad.net/ironic/+bug/132358914:19
dtantsurmaybe need some updates, right?14:19
rloodtantsur: ah, I was wondering, which is why I looked. but then I saw the etherpad, and I wondered.14:20
rloodtantsur: guess I do a lot of 'wonder'ing.14:20
dtantsurrloo :) thanks for pointing, I'll check, what can be fixed for that bug14:20
rloodtantsur: yeah, if that page works for you, we could enhance it. The idea is that whenever Ironic graduates, it'll have 'official' install docs.14:20
rloodtantsur: I even think it might have been you that mentioned adding tftp stuff in that doc a few months ago. I think I ran out of steam and wasn't sure how much detail to add to it.14:21
rloodtantsur: sorry, not you. It was ALeksandr Gordeev. I have some notes about docn, in an etherpad: https://etherpad.openstack.org/p/IronicDocumentationTasks14:22
matty_dubsHmm, this is reminding me that I've been failing to do much with docs...14:25
matty_dubs:'(14:25
NobodyCammorning matty_dubs14:25
matty_dubsMorning NobodyCam14:25
dtantsurrloo, how do you like it now: https://bugs.launchpad.net/ironic/+bug/1323589 ?14:26
dtantsurmorning, matty_dubs14:26
rloomorning matty_dubs!14:26
rloodtantsur: I wonder if there is too much in this one bug. eg, is fedora even ready? i haven't looked recently to see if ironic is packaged for fedora.14:27
lucasagomesmatty_dubs, morning14:28
rloodtantsur: maybe use the etherpad to track. or a blueprint. and separate bugs for each part or something?14:28
dtantsurrloo, it is, at least in testing repo: http://repos.fedorapeople.org/repos/openstack-m/openstack-m/fedora-20/noarch/14:28
matty_dubsHowdy rloo, lucasagomes !14:28
dtantsurrloo, anyway, it's an optional part of the bug14:28
dtantsurI'm running Ironic and DevStack on Fedora as well14:29
rloodtantsur: so it is fine. as long as I'm not updating the docn :-)14:29
dtantsur:)14:29
rloodtantsur: sorry, the migration from nova baremetal is a totally different beast. i'd remove that!14:30
dtantsursure, as you wish14:31
dtantsurrloo, as author of https://bugs.launchpad.net/python-ironicclient/+bug/1304488 could you give your opinion on the discussion here: https://review.openstack.org/#/c/65865/ ?14:31
rloodtantsur: sure...14:32
rloodtantsur: do you know why we need/want argcomplete? or do i have to wade through it all to find out?14:33
dtantsurrloo, patch author point is that it provides correct autocompletion for subcommands14:33
dtantsurrloo, you can see what he writes in comments - I didn't check myself14:34
rlooI only added bug 1304488 cuz the doc folks have a script that uses that to generate docn.14:34
rlooif the doc folks aren't going to update their script to use argcomplete, i don't see any reason to have it. wish there was more context to these 'dropped' patches.14:35
dtantsurrloo, honestly, I would prefer to fix existing solution, rather than introducing yet another14:39
rloodtantsur: sigh. trying to think how to word this politely.14:39
rloodtantsur: do you think it is acceptable for people to review something, w/o knowing why we want that thing in the first place?14:40
rloodtantsur: you already asked about a bug, and the relationship to bash-completion. I am going to -1 it cuz there's no bug and no rationale for why I'd want this.14:41
dtantsurrloo, that makes sense. While I understand and appreciate good intention of the author, we need some order in what, when and how we add to Ironic14:42
dtantsurFor fixing completion (if it's really broken, that is), I would start with posting to ML and talking to all commands14:43
rloodtantsur: yup.14:43
*** rakesh_hs has quit IRC14:51
rloomatty_dubs: hey, wrt https://review.openstack.org/#/c/83577/. Are you OK if I -2 it? Or is 'abandoned' sufficient?14:54
matty_dubs-2 is fine by me. I'm not sure how to withdraw a patch14:54
rloomatty_dubs: ok. (I don't know either.)14:55
*** romcheg has left #openstack-ironic14:58
matty_dubsrloo: Some of us were joking in Atlanta that in addition to the '+2' dinner for cores, we should have a separate party for anyone who's received a -2. I'm in! ;)15:00
rloomatty_dubs: I think that if you haven't received a -2, you haven't lived yet ;)15:01
matty_dubsHaha, that too15:01
lucasagomeshah15:04
lucasagomesthat would be a great party15:04
lucasagomesI could as well :)15:04
lucasagomescould go*15:04
*** blamar has quit IRC15:06
linggaoping devananda,15:10
*** blamar has joined #openstack-ironic15:12
*** BadCub has joined #openstack-ironic15:13
NobodyCambrb... maken coffee.. quick walkies15:17
*** romcheg has joined #openstack-ironic15:18
openstackgerritDmitry Tantsur proposed a change to openstack/ironic: Add some real-world testing on DiskPartitioner  https://review.openstack.org/9462015:21
dtantsurNobodyCam, rloo may one of you finish reviewing https://review.openstack.org/#/c/92625/ please? It's still about caching in PXE15:22
rloodtantsur: are you reading my mind? I just started looking at that ;)15:23
dtantsurlol15:23
* dtantsur has some errands, be back in ~2 hours15:25
*** dtantsur is now known as dtantsur|afk15:25
*** mkerrin1 has quit IRC15:26
*** lazy_prince has quit IRC15:26
*** mkerrin has joined #openstack-ironic15:30
Shrewsdtantsur|afk: rloo: there seems to be an 'else' associated with a 'for' in that review. indentation fail, me thinks  :)15:31
rlooShrews: you are faster than me. I haven't gotten (or I missed) that.15:32
Shrewsmodules/pxe.py15:32
NobodyCamlucasagomes: looking at nova baremetal we had this: https://github.com/openstack/nova/blob/master/nova/cmd/baremetal_deploy_helper.py#L10515:33
rlooShrews: I see it.15:34
NobodyCamthink thats still needed?15:34
lucasagomesNobodyCam, not that I know15:34
lucasagomesI mean, idk why it was added in the first place15:34
rlooShrews: yeah, needs to be out-dented or whatever it is called.15:34
Shrewsrloo: yep15:35
dtantsur|afkShrews, rloo folks, for..else.. is a valid construction15:36
dtantsur|afkShrews, rloo else block is executed, if for loop was not intervented using `break`15:36
dtantsur|afkShrews, rloo that's exactly what I meant: if `break` was never hit, raise an exception15:37
rloodtantsur|afk: oh, interesting.15:37
dtantsur|afknow I'm really afk, thank you for reviewing :)15:38
Shrewswell that's an odd construct15:38
Shrewswill re-review with that in mind15:39
*** jgrimm has quit IRC15:39
*** graf_Pogonialo has joined #openstack-ironic15:42
*** graf_Pogonialo has left #openstack-ironic15:42
*** eghobo has joined #openstack-ironic15:43
*** jgrimm has joined #openstack-ironic15:52
*** shakamunyi has joined #openstack-ironic15:56
NobodyCamdoh...No valid host was found. Reason: No conductor service registered which supports driver pxe_ssh. (HTTP 400)15:58
NobodyCamtime to rebuild15:58
devanandamorning, all15:58
NobodyCamgood morning devananda :)15:59
lucasagomesmorning devananda15:59
* devananda catches up on scrollback15:59
lucasagomesdevananda, quick q... re instance_info spec... you mentioned to create a migration script15:59
lucasagomesis it like a bash script? something like pass the flavor id and the node id, so it extracts the deploy k&r parameters from the flavor and set it to the node's instance_info field16:00
lucasagomes?16:00
devanandalucasagomes: yea, something for an existing deployment (eg, of icehouse)16:01
devanandalucasagomes: we need to support existing users' upgrade path16:01
lucasagomesdevananda, gotcha, cool will do it16:01
lucasagomesyeah I was just a bit confused whether it would be a bash script or something else16:01
lucasagomeslike a step to step instruction etc16:01
*** matty_dubs is now known as matty_dubs|lunch16:03
devanandareviewing 95573 now so we can get this fixed for CI16:04
lucasagomescool, yeah i added u to the review list cause ur input is important there16:05
*** vinbs has joined #openstack-ironic16:06
devanandasirushti, lucasagomes: I don't see a reason for per-node pxe configs yet. OTOH, we do need more than one pxe config per conductor16:07
devanandasirushti, lucasagomes: so AIUI, we should provide one pxe config per /type/ of deploy, and link nodes as needed to that config16:08
devanandaooh -- nice tepest stuff! https://review.openstack.org/#/q/status:open+project:openstack/tempest+branch:master+topic:bp/missing-baremetal-api-test,n,z   <-- adam_g, you may be interested16:09
lucasagomesdevananda, I might be confused here... but we create one pxe config per node, using the mac address of that node16:10
lucasagomesor am I mixing stuff?16:10
devanandalucasagomes: but using a single template that only supports PXE booting a linux kernel16:11
devanandalucasagomes: AIUI, we need to support different config templates for windows, iPXE, and EFI16:11
lucasagomesright, sure yeah16:11
lucasagomesthis could be an parameter to the node, and if not present we fallback to the default config16:12
devanandadtantsur|afk: re: editing status of bug 1229324 -- LP is broken on bugs which were filed like that, and it's not possible for anyone to update them via the UI16:15
lucasagomesre tempest, here's another one: https://review.openstack.org/#/c/95789/ , needed by the instance_info stuff16:15
devanandadtantsur|afk: there is apparently an email interface for LP which works, some times, for those bugs.... but i haven't made the time to figure it out yet16:15
devanandadtantsur|afk: also I unblocked 73956. thanks for the ping!16:16
*** tatyana has quit IRC16:17
Shrewslucasagomes: fyi, that tempest change may conflict with mine: https://review.openstack.org/9443616:18
Shrewslucasagomes: mainly b/c i fixed the class name16:19
devanandaNobodyCam, lucasagomes, rloo: on the disk partitioner patch set -- why are we talking about wiping lvm data when we don't support creating it?16:20
NobodyCamdevananda: it was lifeless concern16:21
devanandai've been pretty clear in my conversations with the mirantis Fuel team that, at least for this cycle, I don't want Ironic to support LVM or software RAID16:21
NobodyCamwe do not know what the disk had before our first oartition16:21
NobodyCampartition even16:21
NobodyCamnot but if the disk has lvm or raid on it we should wipe it no?16:22
lucasagomesShrews, hmm right... I can add a dependency on urs if needed16:22
lucasagomesbut maybe git will be smart enough because the function I changed you didn't touch in ur patch, which is validate_driver_info()16:22
Shrewslucasagomes: it might merge ok. just leave it for now16:22
devanandarloo, dtantsur|afk: regarding official install docs -- that page (developer/ironic/deploy/install-guide) is gonna be it for a while, I think.16:23
lucasagomesdevananda, +1, we probably don't need to wipe _any_ data16:23
Shrewsi was just giving a heads-up16:23
lucasagomesShrews, I see, thanks for that16:23
rloodevananda: wrt docn. Yeah, until end of Juno at the earliest :-(16:24
devanandarloo: I wouldn't expect it until 6 months after graduation TBH16:24
rloodevananda: really? I thought it was a requirement *for* graduation. Wow.16:24
devanandarloo: I found out that what we have is what's required for graduation -- not inclusion in the openstack-docs repo16:25
rloodevananda: ahh. ok. We'll just try to keep our version up-to-date then...16:25
*** derekh_ has quit IRC16:26
devanandalinggao: pong16:27
rloodevananda: btw, wrt docn, if there is no official docn til later, do we need to use the DocImpact flag?16:28
linggaodevananda, first we are going to setup a third party CI for the ipminative deriver in a few weeks. We are preparing it now.16:29
rloodevananda: https://wiki.openstack.org/wiki/Documentation/DocImpact. Anne was surprised that I didn't know about it ;)16:29
*** jistr has quit IRC16:30
linggaodevananda, I am looking at what features I can contribue for Juno relase. There are a few things come to my mind.  Just want to run through you before I dig into details for the blueprints.16:30
linggao1. intergrate console with horizon16:31
linggao2. intergrate console with nova command line.16:31
linggao3. add ipminative console support.16:31
devanandarloo: true - we don't need to use it, but it's helpful for us as well, isn't it?16:31
*** jcoufal has quit IRC16:32
devanandarloo: perhaps we should set up a gerrit trigger that files a bug against ironic so we know to come back and udpate the docs ;)16:32
linggao4. reset service processor (BMC or bldes's on-board service processor)16:32
linggaodevananda, what do you think?16:32
rloodevananda: it supposedly sends email to openstack-docs@. If they're OK with that, then yes, we ought to 'get into the habit'. Presumably, the blueprint specs will indicate it too.16:33
devanandalinggao: re: CI for ipminative -- that's fantastic! there is a new weekly meeting that anteaya started, specifically for third-party-CI. you may be interested in following that16:33
linggaodevananda, that's great. I'll contact anteaya.16:34
devanandalinggao: getting console log (rather than interactive console) would be very helpful. this should be exposed also via Nova CLI and via Horizon (it should plug in fairly easily)16:34
anteayao/16:34
NobodyCammorning anteaya :)16:34
anteayahttps://wiki.openstack.org/wiki/Meetings/ThirdParty16:34
devanandalinggao: also, moving the IPMI credential storage out of its current location and into a mroe secure location would help all drivers16:34
anteayamorning NobodyCam16:34
anteayaNobodyCam: how are you doing?16:35
NobodyCamgood as can be.. :) thank you for asking, How are you :)16:35
anteaya:D16:35
anteayagood thanks16:35
linggaodevananda, all the console support, should one bp enough or should I separate them into deifferent BPs?16:35
anteayaI slept so much after the summit, I was exhausted16:35
*** martyntaylor has quit IRC16:36
devanandalinggao: one spec / bp should be fine, with several "work items"16:36
devanandalinggao: eg, add common code to APIs; implement it for ipmitool; implement for ipminative; implement in python client; implement bindings in nova; -- and add tests at each phase16:37
devanandalinggao: or something like that16:37
*** BadCub has left #openstack-ironic16:38
linggaodevananda, cool, I like that.  how about reset service processor (bmc)? Do you think it needs to get into Juno?16:38
devanandalinggao: we're tight on review bandwidth. please file a spec for that -- i agree it's a necessary feature -- but i can't promise what we'll have time for, and that's lower priority than things which affect graduation16:39
linggaodevananda, sure. I'll file a spec first.16:39
linggaothanks a lot. devananda.16:40
devanandalinggao: np. thank you!16:40
linggaoHi anteaya, heard you have started a weekly meeting on 3rd party CI.16:41
linggaoanreaya, when is it and what is the name of the IRC channel?16:41
anteayahttps://wiki.openstack.org/wiki/Meetings/ThirdParty16:41
anteayathe irc channel is where ever you happen to be16:42
anteayait is cross project so the meeting is the locus16:42
anteayaMondays at 1800 utc in #openstack-meeting16:42
*** romcheg has quit IRC16:43
linggaoanteaya, thanks for the info.16:43
anteayanp16:43
anteayait would also be useful to attend or at least read the logs of the -infra, -tc and -qa meetings16:44
linggaook.16:44
anteayasince the discussions there will have an impact on third party ci systems16:44
anteayalinggao: do you know how to find out about those meeting and access the logs?16:44
anteayaif no, i can show you16:44
linggaoanteaya, no. please show me.16:45
anteayaokay16:45
*** martyntaylor has joined #openstack-ironic16:45
lucasagomesok I'm done for the day, have a good night everybody!16:45
anteayago to wiki.openstack.org > online meetings16:45
anteayalucasagomes: good night16:45
devanandag'night lucasagomes16:45
*** lucasagomes is now known as lucas-dinner16:45
anteayalinggao: if you scroll down online meetings you will see project infrastructure (infra), technical committee (tc) and quality assurance (qa)16:46
anteayalinggao: can you find all of those?16:46
*** zdiN0bot has joined #openstack-ironic16:46
anteayalet me know if you can't16:46
NobodyCamhave a good night lucas-dinner16:47
*** lucas-dinner has quit IRC16:48
linggaoanteaya, I cannot find the quality assurance.16:48
anteayakk16:49
anteayahttps://wiki.openstack.org/wiki/Meetings/QATeamMeeting16:50
anteayathey are calling it QA16:50
anteayasorry about that16:50
linggaoanteaya, I found it.16:51
anteayagreat16:51
anteayaso those are the meeting times and agendas16:51
anteayaand that is the list of all openstack meetings, so you should find any meeting you need to listed there16:51
anteayanext up, logs16:52
anteayaeavesdrop.openstack.org16:52
linggaook16:52
anteayathe channel logs are under channel and meeting logs under meeting16:52
anteayafind the meeting log for yesterday's third party meeting16:52
anteayathen link me16:52
linggaoI found the log  yeaterday's third party meting log.16:54
*** matty_dubs|lunch is now known as matty_dubs16:54
linggaowhat do you mean by "link me" ?16:54
*** harlowja_away is now known as harlowja_16:55
anteayapost the url for the log you found in channel16:55
anteayaso that I may click16:55
linggaohttp://eavesdrop.openstack.org/meetings/third_party/2014/third_party.2014-05-26-18.00.txt16:56
anteayagreat16:56
anteayagood work16:56
*** Alexei_9871 has quit IRC16:56
anteayanow find the log for the same meeting in the channel logs16:56
linggaohttp://eavesdrop.openstack.org/irclogs/%23openstack-meeting/%23openstack-meeting.2014-05-26.log16:58
linggaothis is the correct one?16:58
anteayayes16:58
anteayagreat work16:58
anteayawe are done16:58
anteayayou have now learned what you need to know to find the agenda for any meeting16:59
anteayaand the meeting log for any meeting16:59
anteayaand the channel log for any logged channel in openstack16:59
anteayacongratulations16:59
linggaoanteaya, you are a great teacher. very patient, nice.16:59
anteaya:D16:59
anteayathanks for your time16:59
linggaothank you!16:59
anteayayou're welcome17:00
*** zdiN0bot has quit IRC17:00
linggao^_^17:00
anteaya:D17:00
*** igordcard has joined #openstack-ironic17:12
*** vinbs has quit IRC17:22
lifelessdevananda: this isn't about supporting LVM17:29
lifelessNobodyCam: hi17:29
NobodyCamlifeless: hi17:31
*** romcheg has joined #openstack-ironic17:32
*** romcheg has quit IRC17:33
NobodyCamlifeless: so how does switching to sfdisk sound. that should get rid of the label issue, then another patch to wide start and end of disk ?17:33
NobodyCamI'm looking to do what it takes to get things working for everyone17:33
praefectHi guys, I'm trying to test ironic in devstack (linuxbridge), the nodes boot up (libvirt) but their DHCP requests never get answered, which is normal since their MAC never get added in the dhcp host file of the dnsmasq process running in dhcp namespace.. am I missing something? is this dhcp server only for instances or is it used also for PXE boot of the bm nodes?17:33
lifelessNobodyCam: lucas spent a fair chunk of time on that; the wipe seems like its a shorter path to get *working* again.17:35
lifelessNobodyCam: sounds like we need to get devananda's attention, going from backscroll17:35
NobodyCamok so you read this morning chat17:36
NobodyCam:)17:36
lifelesshighlights only17:36
NobodyCamdevananda: ping17:36
devanandahi!17:36
NobodyCam:) hey hey17:36
lifelesspraefect: the one DHCP server - the neutron dhcp server for the subnet - does PXE and normal address allocation17:37
lifelessdevananda: so, I saw some concern about the disk start and end wiping strategy17:37
lifelessdevananda: related to fuel wanting Ironic to do LVM ?17:38
devanandalifeless: in the scrollback, there was a lengty conversation before i came online. i responded to bits of it that i skimmed17:39
lifelessdevananda: ok, so I fear you've misinterpreted17:39
devanandalifeless: wherein it seemed folks believed that the wipe-start-and-end was to erase LVM data17:39
dtantsur|afkrloo, addressed some of your comments here: https://review.openstack.org/#/c/92625/ please let me know what you think17:39
devanandawhich is not what I understood it to be -- and  Iwas making clear my objection to LVM/MDADM17:39
lifelessdevananda: the wipe start and end is to pretend to have a blank disk without writing 0's to the entire disk17:39
devanandalifeless: right -- I get that. there are partition tables and backup copies in those areas17:40
lifelessdevananda: the amount that needs to be written to achieve that is the union of sizes of metadata schemes of all sorts17:40
devanandalifeless: i suspect that i'm not disagreeing with you at all17:40
lifelessnot just the ones we support writing17:40
lifelessdevananda: cool, I'm just seeking clear consensus17:40
lifelessdevananda: so LVM gets mentioned, because its such a scheme we need to be sure to wipe, or some poor schmuck turning up with a previously used disk gets the short end of the stick17:41
*** eghobo has quit IRC17:41
dtantsur|afkdevananda, hi! Could you have a look at https://review.openstack.org/#/c/95573/ ? It's fix for urgent problem with NodeLocked and is somewhat controversial. I've put my points in commit message and comments.17:41
*** eghobo has joined #openstack-ironic17:42
devanandadtantsur|afk: yea, been mulling that over while taking care of other things17:42
dtantsur|afkthanks!17:42
*** dwalleck has joined #openstack-ironic17:42
NobodyCamI'm happy to work the fix thru to the end I just don't want to spin our wheels for another week17:43
devanandalifeless: ack17:43
lifelessNobodyCam: that sounds like devananda and I are in consensus -17:43
praefectlifeless: thanks so I have to see the bm MAC in there somehow I guess…17:43
devanandaNobodyCam: can you summarize all the objections at this point? I've lost track ... it seems like there is bikeshedding on exactly how many bytes to erase, when that's not the point17:43
lifelessdevananda: there was, I think we cleared that up yesterday17:43
lifelessdevananda: when I pointed out it wasnt' about the partition types we understand17:44
lifelessdevananda: there is a functional problem that needs fixing in the code (touching the partition table at all on a rebuild-preserve-ephemeral) but that issue pre-exists, however we need to fix it here17:45
devanandadtantsur|afk: my original objection to using 409 is that it's ultimately not a client-side-error at all17:45
NobodyCamwe started with the wipe at 4k then droped it to 1k (which corrupts the gpt table) but does not wipe it.17:45
NobodyCamlooking at the gpt specs we need to wipe 18k (or 16 cann't recall right now)17:45
dtantsur|afkdevananda, my point here is that it's not an error at all :) neither client not server. But at the end, server can't do anything about it, so it's responsibility of client - thus 4xx17:46
devanandadtantsur|afk: it's a server-side error in as much as we engineered it poorly and should never be exposing this situation at all17:46
devanandadtantsur|afk: api service should ACK that it got the request and stick it on the queue. done. hence my spec to fix this :)17:46
dtantsur|afkdtantsur|afk, if it is server-side error, nothing is wrong in reporting it with LOG.error, right? ;) And while I also prefer async approach generally, we have what we have for now17:47
*** Lingo has joined #openstack-ironic17:47
dtantsur|afkdtantsur|afk, reporting 5xx as error and failing test seems the right thing to do for me17:47
dtantsur|afkoh,why am I talking to myself?17:48
devanandaNobodyCam: that wipe only needs to happen when (re)deploying though, I presume, and not on a rebuild-preserve-ephemeral17:48
devanandadevananda: i dont know :)17:48
dtantsur|afk:D17:48
rloodtantsur|afk: thx.17:48
lifelessdevananda: correct (to NobodyCam ) - and I asked for that in my review17:48
dtantsur|afkdevananda, on the other side with async approach, imagine we got 2 deploy requests for the same node17:48
NobodyCamdevananda: labels need to be removed to use parted17:48
lifelessNobodyCam: its a more general problem, the parted stuff is just a sympotom17:49
dtantsur|afkdevananda, I doubt we should make client wait before telling him that node is in incorrect state17:49
NobodyCamack  I was working on a patch that replaced parted with sfdisk17:49
devanandadtantsur|afk: sure. so I know of two approaches that solve taht17:49
lifelessNobodyCam: I think thats premature17:49
*** dtantsur|afk is now known as dtantsur17:49
lifelessNobodyCam: we may want to, but the issues we had with it were troubling17:50
NobodyCamok17:50
devanandadtantsur|afk: 1. every request generates a request token. user can track that. (alternate: use callback to POST result back to user)17:50
lifelessNobodyCam: and making the disk look 'blank' on a new deploy is clearly the right thing to do17:50
devanandadtantsur: 2. certain API actions, like deploy, use an intent-lock. so concurrent requests will cause all-but-one to fail on API side, not waiting on RPC bus17:50
dtantsurdevananda, I don't like that (1) will require to store tokens in DB to make API instances stateless17:51
dtantsurdevananda, (2) sounds find. So periodic tasks don't fail things - should work!17:52
*** zdiN0bot has joined #openstack-ironic17:52
dtantsur(though in my previous experience, we preferred to let client decide about retrying/not retrying, but it was somewhat different application)17:53
*** dwalleck has quit IRC17:53
dtantsurdevananda, returning to the current problem: whatever solution we find now, it should be temporary, right? What do you think about 409 as a temporary solution?17:53
devanandadtantsur: have you reviewed https://review.openstack.org/#/c/94923/5/specs/juno/fully-async-api.rst ?17:54
*** dwalleck has joined #openstack-ironic17:54
dtantsurdevananda, I actually read it and left come comments. After this chat btw I understand your motivation better, so it may be useful to put some points there17:54
dtantsure.g. alternatives on async approach17:55
dtantsurdevananda, actually, I hope to get more ideas tomorrow, as I got seriously tired today :(17:58
*** dwalleck has quit IRC17:58
dtantsurSo wishing you all good night :)17:58
rloodtantsur: let me know if you have time to chat about 92625.17:58
dtantsurrloo, well, if it's not too long :)17:59
rloodtantsur: we can chat tomorrow then. Or I will just add more comments.17:59
dtantsurrloo, can I just answer something for you?17:59
devanandadtantsur: i'll keep thinking on this one, and try to find another fix for the gate today. good night :)17:59
rloodtantsur: wrt total_size < free or <= free. I don't really care, it is just that your if is total_size > free, not total_size >= free :-)18:00
*** rloo has quit IRC18:00
*** rloo has joined #openstack-ironic18:00
NobodyCamdevananda: lifeless: so stick with wiping start and end of disk, rework to not repartition on rebuilds with preserve_ephemeral set?18:01
*** dwalleck has joined #openstack-ironic18:02
dtantsurrloo, oh yes, didn't notice :) I actually see no serious difference, but I can fix it to some consistent way18:03
rloodtantsur: ok thx. Sorry about that, just made me wonder why it was off by 1...18:04
dtantsurrloo, after speaking to you I realized we need to somehow make room also for converting... But that's not for this patch, I guess18:04
rloodtantsur: don't add more functionality ;)18:05
dtantsuryeah, sometimes enough is enough :)18:05
rloodtantsur: i added comments. the test concerns me though. seems odd that the syntax is different, [] vs ().18:05
lifelessNobodyCam: I think if you do precisely what my review asks for, you'll be clear with deva and I18:05
lifelessNobodyCam: which was a little more than your last sentence, but yes.18:05
dtantsurrloo, it's just testing 2 functions that call the same function in a bit different way18:05
NobodyCamack18:06
rloolifeless, NobodyCam: but the intent is to address more that the volume label thing right?18:06
*** dwalleck has quit IRC18:06
NobodyCambrb18:06
*** dwalleck has joined #openstack-ironic18:06
rloodtantsur: looking...18:06
dtantsurrloo, it does not matter for sequence unpacking (that's what I do in fetch_images), but it does matter for equality comparison18:07
rloodtantsur: so you're saying that pxe._fetch_images(), the images_info argument can be different?18:07
dtantsurimages_info = sequence(sequence(uuid, path), sequence(uuid, path)), where sequence can be whatever: tuple, list...18:08
dtantsurthe only place where it matters is equality comparison in tests18:08
rloodtantsur: would you mind adding a docstring about images_info then? Or do you think it doesn't need a docstring?18:09
rloodtantsur: maybe it is just me. I assumed it was a tuple.18:10
lifelessrloo: sorry, don't quite parse that18:10
dtantsurrloo, I wish it was tuple everywhere, it is more correct; but values in pxe_info are lists18:11
rloolifeless. Well, NobodyCam's commit msg is misleading i think.18:11
dtantsurrloo, I can add a docstring if you want it confusing18:11
rloolifeless: "Workaround for conflicting volume labels".18:12
dtantsurI can even start using lists everywhere for the sake of consistency :)18:12
lifelessrloo: oh certainly, that should be fixed too18:12
rloolifeless, good. NobodyCam: ^^18:12
rloodtantsur: whichever you think is easier for people to understand/code to maintain/whatever.18:13
NobodyCamwill change... but that is how the patch started life18:13
NobodyCam:-p18:13
rlooNobodyCam: did you create a monster?18:13
rlooNobodyCam: err, I mean, a butterfly?18:14
NobodyCamlol seems so :-p (/me has seen the butterfly effect :-p)18:14
dtantsurrloo, problem is that it's ok from my point of view :) line 387: image_info[label] = [None, None]  <-- that's what I would not do, this should be a tuple by it's sense18:15
dtantsurrloo, what if I change this line to a tuple? That will make code consistent and more correct18:16
rloodtantsur: that makes sense with me. At first glance anyway; I'm not up-to-date on that code. Is that the only place where it is a list?18:17
dtantsurrloo, at first glance yes. I'll check better when I'll be changing it18:18
rloodtantsur: thx. if there are more places, then I'd say clean it up in another patch.18:18
dtantsurrloo, ack, will fix, thank you for helping clarify it :)18:18
rloodtantsur: thx.18:19
dtantsurthat's all for tomorrow, g'night now18:19
rloodtantsur: good night!18:19
*** dtantsur is now known as dtantsur|afk18:19
NobodyCamnight dtantsur18:19
*** krtaylor has quit IRC18:22
*** sysexit has quit IRC18:23
*** romcheg has joined #openstack-ironic18:27
*** romcheg has quit IRC18:27
*** sysexit has joined #openstack-ironic18:49
*** rloo has quit IRC18:49
*** rloo has joined #openstack-ironic18:49
*** rloo has quit IRC18:50
*** zdiN0bot has quit IRC18:50
*** rloo has joined #openstack-ironic18:50
*** rloo has quit IRC18:51
*** rloo has joined #openstack-ironic18:51
*** max_lobur has quit IRC18:56
*** dwalleck has quit IRC19:01
*** derekh_ has joined #openstack-ironic19:02
*** rloo has quit IRC19:03
*** rloo has joined #openstack-ironic19:03
*** Penick has joined #openstack-ironic19:04
*** Lingo is now known as BadCub19:05
*** sysexit has quit IRC19:09
*** rloo has quit IRC19:09
*** rloo has joined #openstack-ironic19:09
*** dwalleck has joined #openstack-ironic19:15
*** ifarkas has quit IRC19:27
*** sysexit has joined #openstack-ironic19:37
linggaodevanana, I am working on the console log specs. Just want to confirm with you that nova-baremtal did not implement the get-console-output, correct?19:40
devanandalinggao: afaik, correct. nova-bm only has support for shellinaboxd19:41
linggaowhich is the interactive console.19:42
linggaoIn order to use console log, we must save the console logs.19:42
linggaoThe it comes when to save it and where to save it. Any suggestions?19:43
linggaoand how to age it out.19:44
devanandalinggao: nope. i haven't researched that yet. i would start by looking at what nova does for VM's console logs and see if we can follow that precedent19:46
matty_dubsThat sounds like it could get icky. :-\19:47
matty_dubs(Though I agree with the approach.)19:47
linggaook, I'll start from that route first.19:47
linggaojbjhonso has a python lib called confluent, which is a  console server that stores the console logs.19:49
linggaoThe console can be accessed through command line as welll as http.19:51
*** rloo has quit IRC19:57
*** rloo has joined #openstack-ironic19:58
devanandapython-ironicclient is now gating symmetrically with ironic19:59
openstackgerritMartin Geisler proposed a change to openstack/python-ironicclient: Use Emacs-friendly file variable to set file encoding  https://review.openstack.org/9588219:59
devanandameaning tempest tests should run on the client too ,now19:59
*** dwalleck has quit IRC20:00
NobodyCambrb20:01
rloodevananda: yay for ironicclient!20:02
*** zdiN0bot has joined #openstack-ironic20:06
*** krtaylor has joined #openstack-ironic20:07
*** BadCub01_ has joined #openstack-ironic20:08
*** BadCub has quit IRC20:08
*** boris-42 has quit IRC20:21
*** boris-42 has joined #openstack-ironic20:21
linggaodevananda. with VM hypervisors, there is typically a serial console or a paravirtualized log for each virtual machine.20:22
linggaoIt is exposed on the host as pty or a plian file.20:23
linggaoNova libvirt driver just uses it to get console output.20:23
linggaoWith baremetal, we need to deside when and where to store them. xCAT used conserver, now is using confluent.20:25
linggaodevananda, So we have 2 options. 1 use third party console server to log and access the console. 2. Home grow our own console server in Ironic, we can use the ironic-conductor or a new daemon as the console server, spawn a process to keep saving the serial console to a file when the node is being powered on.  The file can be flushed with next power on action.20:34
linggaoThe console file can be saved on the host where the conductor is to begin with. Later we can add options to save it to user-supplied storeage devices.20:37
*** jbjohnso has quit IRC20:39
devanandalinggao: storing console log on conductor is fragile -- what happens when the conductor ring rebalances?20:40
linggaohmm,20:41
*** BadCub has joined #openstack-ironic20:41
linggaoshould the console log be moved to the new host when the  conductor ring rebalances?20:42
*** BadCub has quit IRC20:42
linggaoI do not know the details of the rebalance. do we have control over it?20:43
*** romcheg has joined #openstack-ironic20:43
linggaoOr, start the new console log on the new host. you just loose the old console after rebalance.20:44
devanandarebalance can occur eg. when a new conductor joins the ring, or one fails and is removed automaticaly20:44
devanandaso we can't guarantee to preserve local files20:44
devanandastoring in database is one option, though not necessarily scalable20:45
devanandastart new log and lose old content is an option, but not very appealing to operators20:45
matty_dubsOh, I see -- so Nova can just dump to local disk, since if the host goes, the VM goes too. But we can't, since we could lose the conductor (or just rebalance) without the BM node going down?20:45
devanandaright20:45
linggaoloosing console should not be a big deal, user usually want to log at the console when the deployment fails.20:46
linggaothey can just restart the node to get the new console logs. :-)20:47
linggaos/log/look/20:47
linggaoanother way is find a cinder storage for the console logs.20:49
linggaothat can be an option.20:50
*** jdob has quit IRC20:50
*** zdiN0bot has quit IRC20:50
matty_dubsIt seems like "I'd like to persistently store and write to this log" shouldn't be an Ironic problem.20:51
matty_dubsThough obviously, right now, it is.20:51
devanandamatty_dubs: it's not a user-writable log20:52
matty_dubsOh, "I" was Ironic, vs. an admin.20:52
devanandamatty_dubs: most hardware's BMC exposes a small buffer containing the last X kb of kernel log20:52
devanandaah20:52
devanandanvm20:53
linggaonvm? I am googling...20:54
matty_dubsBetter-stated, it seems like 'central logging' ought not to be an Ironic-specific task.20:55
matty_dubsnvm == nevermind20:55
matty_dubsThough not that I'm suggesting we should throw our hands up and say "Not our problem!" I just wonder if other projects are having this same issue.20:56
linggaolol, I found node version manager. :)20:56
matty_dubs<strike>We could write a log store in Node.js!</strike>20:57
*** praefect has quit IRC20:58
matty_dubsdevananda: I don't know much about BMC buffers, beyond basic hardware errors showing up there. But your comment about buffers makes me wonder if "Don't log stuff ourselves, but read from the BMC log if something goes wrong" is a viable option?20:59
*** romcheg has quit IRC21:00
linggaoit has hardware event logs, like node powered on or off, firmare updated etc. I do no think it has sol console log.21:02
matty_dubsAh, that might explain why my Googling wasn't turning up anything21:02
*** Penick has quit IRC21:02
linggao:)21:02
*** Penick has joined #openstack-ironic21:04
linggaobasically the console server will enalbe sol on BMC and saves any sol output real time to file in order to support console log.21:04
matty_dubsAh, okay. I think I misunderstood.21:05
matty_dubsWishful thinking on my part. ;)21:05
linggaoIt could cause a lot of traffic if a lot of nodes are being deployed at the same time. That's why the conserverd has an option that only saves the console for the ones you are looking at interactively.21:06
devanandalinggao: i was under the (perhaps incorrect) assumption that BMCs often maintain a serial console buffer as well, meaning one doesn't necessarily need continuous SOL connection to capture the serial output21:07
matty_dubsAFAICT that's not standard IPMI, at least, but I'm going only by what Google is telling me.21:08
devanandalinggao: the intention of this feature is to aid in debugging failed deployments. so the operator would need the console to have been logged once the deploy started, but  /before/ realizing that the deploy failed21:09
linggaoI asked jbjohnso if BMC stores the console itself, he said no.21:09
devanandalinggao: ok, thanks21:09
linggaodevananda, true.21:11
devanandathere is unfortunately no efficient way to store log files in MySQL21:11
devanandastoring as local files on the conductor is certainly the easiest solution21:12
linggaoright. we can begin with this.21:14
*** romcheg has joined #openstack-ironic21:14
linggaodevananda, do you prefer use a 3rd party console server or create our own?21:15
devanandalinggao: not entirely sure what you mean21:16
*** dwalleck has joined #openstack-ironic21:16
linggaoI mean use conserver or confluent, or implement the same functions in Ironic.21:16
Shrewsdevananda: question re: https://review.openstack.org/95213 ... since that changes behavior *after* a release, how is that dealt with? seems like there should at least be something documenting the behavior change somewhere21:17
linggaobasically they keep saving the consoles  output in console log and making sure the connection is alive all the time.21:17
devanandalinggao: can you paste links to those project's home pages?21:19
linggaohttp://www.conserver.com/21:19
devanandaShrews: like a DocImpact flag, or a bug, or a change to docs/...?21:20
matty_dubsI've got to head out; have a great day/night linggao and devananda (et al.)!21:21
devanandamatty_dubs: you too!21:21
linggaoconfluent is something jbjohnso is developing (console) for xCAT and openstack. I only know where is the source is.21:22
linggaohttp://sourceforge.net/p/xcat/confluent/ci/master/tree/21:22
Shrewsdevananda: Something like that. If someone is upgrading from I to J, this change would be altering their existing setup, so they'd need to be aware of the new config to reproduce what they had in I.21:22
*** matty_dubs is now known as matty_dubs|gone21:22
devanandaShrews: like upgrade notes :)21:23
Shrewsdevananda: if that is even a concern at this point... thus my question   :)21:23
linggaodevananda, but I know jbjohnso always have perfoamnce in mind when he develops code.21:23
devanandaShrews: let's assume there will be. then in the worst case, we didn't make it worse :)21:23
linggaomatty_dubs, good night,21:24
linggaodevananda, I also needs to go. talk to you tomorrow.21:24
linggaos/needs/need/ :)21:25
*** mrda_away is now known as mrda21:28
mrdaMorning Ironic!21:28
Shrewsmrda: g'morning21:29
devanandamornin!21:29
mrda\o21:29
*** linggao has quit IRC21:29
-openstackstatus- NOTICE: Zuul is offline due to an operational issue; ETA 2200 UTC.21:32
*** ChanServ changes topic to "Zuul is offline due to an operational issue; ETA 2200 UTC."21:32
*** Penick has quit IRC21:38
*** davidlenwell_ has joined #openstack-ironic21:40
*** davidlenwell_ has quit IRC21:44
*** davidlenwell has quit IRC21:45
*** kaizer has quit IRC21:46
*** davidlenwell has joined #openstack-ironic21:47
NobodyCammorning mrda21:50
*** romcheg has quit IRC21:51
*** harlowja_ is now known as harlowja_away21:57
*** harlowja_away is now known as harlowja_21:57
NobodyCamstarts tox on a rebuild and steps afk22:01
*** shakamunyi has quit IRC22:03
*** dwalleck has quit IRC22:08
*** romcheg has joined #openstack-ironic22:08
-openstackstatus- NOTICE: Zuul is started and processing changes that were in the queue when it was stopped. Changes uploaded or approved since then will need to be re-approved or rechecked.22:09
*** ChanServ changes topic to "OpenStack Bare Metal Provisioning | Docs: http://docs.openstack.org/developer/ironic/ | Bugs: https://bugs.launchpad.net/ironic | Status: https://etherpad.openstack.org/p/IronicWhiteBoard"22:09
*** shakamunyi has joined #openstack-ironic22:10
adam_gdevananda, wondering if you had any input on https://bugs.launchpad.net/ironic/+bug/132150422:23
devanandaadam_g: no - i haven't the hardware to run that test on, but very excited that you are!22:24
devanandaadam_g: initial guess would be aroudn 3 areas: network/io contention in copying the image. you seem to be working on that22:25
devanandaand there are a few other patches touching it too22:25
devanandaor - scheduler picking same node repeatedly and triggering races, but that would show up in logs22:25
devanandaor - some unknown contention within ir-cond or n-cpu22:26
adam_gdevananda, yeah--i was wondering what you thought about limiting the # of concurrent deployments to a pool of workers22:26
adam_gthat patch fixes the fail rate but increases deployment time considerably22:27
*** jgrimm has quit IRC22:27
devanandaadam_g: yea, i expect it would increase deploy time22:28
devanandaadam_g: i'd like to see a pool of deploy workers taht can scale based on load22:28
devanandaor be sized by the operator according to their network / io cap22:29
devanandaor something22:29
adam_gdevananda, interesting.22:29
adam_gyeah i was just thinking a config flag that an admin can tweak accordingly22:29
devanandathough IIRC, lifeless disagreed with that approach22:29
devanandaclearly, allowing an unlimited # of concurrent deploys is going to expose serious failure modes where the network gets saturated -- even after we move to an agent-based-download22:30
devanandathe saturation will move off of the conductor and onto the image source -- which is much easier to scale (add a proxy, or more glance backends, etc) but the network itself is not infinite22:31
lifelesshi22:31
devanandaadam_g: https://review.openstack.org/#/c/95213/22:31
lifelessso my main concern is that we don't pessimise first time-to-live by trading throughput for concurrency22:31
lifelessgreg says that the serialised version is currently a pessimisation22:32
lifelesswe haven't looked into why22:32
adam_gdevananda, yeah, i saw that. funny that came up the same time i hit this22:32
*** sysexit has quit IRC22:32
lifelessthe testbed we're working on has 10Gbps networking, and lots of memory22:32
devanandaadam_g: i suspect the RH folks hit the same issue, and thus wrote that22:32
lifelessso we should be able to write entirely to RAM on the recipient machines in short order22:32
adam_glifeless, receipient machine in this case is iscsi target / ironic node?22:33
lifelesswe already have https://bugs.launchpad.net/ironic/+bug/119966522:33
lifelessadam_g: yes22:33
lifelessadam_g: I suspect the reason the serialised version is slower right now is that dd calls fsync at the end of the copy22:34
lifelessand that will block until there are no dirty pages on the device22:34
adam_goflag=direct22:34
lifelessadam_g: yes22:34
adam_gwhat about the targets?22:34
lifelessadam_g: that means we don't keep a pointless copy in the page cache on the local system22:34
adam_gare they configured for async?22:34
lifelessadam_g: good question22:35
devanandaor are the iscsi targets set up for directio?22:35
adam_gdevananda, yeah, im curious22:35
devanandathat'd prevent the optimizations you're thinking of22:36
devanandaand i remember us doing that over a year ago22:36
lifelessI do like the serialisation thing in general22:36
lifelessbut22:36
lifelesssome network topologies (e.g. moonshot) will want to muliplex from the conductor22:37
lifeless(e.g. 10Gbps or more on the conductor, 1Gbps per recipient)22:37
lifelessso having a knob is likely necessary (though it would be great to make it automatic in some fashion eventually22:37
devanandasure22:39
*** romcheg has quit IRC22:39
devanandai don't see anything in DIB or ironic that is specifying direct IO for tgtadm22:42
devanandaeg, http://manpages.ubuntu.com/manpages/trusty/man8/tgtadm.8.html#contenttoc622:42
*** Penick has joined #openstack-ironic22:43
lifelessthats good22:44
lifelesssync we want the pagecache on the target22:44
lifelesssince22:44
adam_g-e aio?22:47
devanandaadam_g: i was just thinking the same thing22:47
devanandaworth a try22:47
adam_gi find it hard to believe tgt would default to writing to the page cache22:47
*** derekh_ has quit IRC22:51
devanandaok - i must go afk and find food. will bbiah22:52
*** zdiN0bot has joined #openstack-ironic22:57
*** zdiN0bot has quit IRC23:00
*** zdiN0bot has joined #openstack-ironic23:00
*** rloo has quit IRC23:04
*** rloo has joined #openstack-ironic23:04
*** zdiN0bot has quit IRC23:28
*** igordcard has quit IRC23:29
*** Penick has quit IRC23:30
*** rloo has quit IRC23:44
*** rloo has joined #openstack-ironic23:44
*** eguz has joined #openstack-ironic23:51
*** zdiN0bot has joined #openstack-ironic23:52
*** zdiN0bot1 has joined #openstack-ironic23:55
*** eghobo has quit IRC23:55
*** zdiN0bot has quit IRC23:57
openstackgerritJay Faulkner proposed a change to openstack/ironic-python-agent: Allow configdrive partition to be precreated  https://review.openstack.org/9596923:58
openstackgerritJay Faulkner proposed a change to openstack/ironic-python-agent: Allow configdrive partition to be precreated  https://review.openstack.org/9596923:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!