| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Change import orders with hacking guide https://review.openstack.org/486614 | 00:29 |
|---|---|---|
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Use API Definitions from neutron-lib https://review.openstack.org/478883 | 00:29 |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Change import orders with hacking guide https://review.openstack.org/486614 | 00:33 |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Use API Definitions from neutron-lib https://review.openstack.org/478883 | 00:33 |
| openstackgerrit | Ghanshyam Mann proposed openstack/neutron-fwaas master: Replace deprecated test.attr with decorators.attr https://review.openstack.org/486814 | 01:41 |
| openstackgerrit | Vu Cong Tuan proposed openstack/neutron-fwaas master: Firewall rule is not applied immediately when it has "port range" https://review.openstack.org/443385 | 01:42 |
| openstackgerrit | Vu Cong Tuan proposed openstack/neutron-fwaas master: Firewall rule is not applied immediately when it has "port range" https://review.openstack.org/443385 | 01:45 |
| *** Tim_Eberhard has joined #openstack-fwaas | 01:51 | |
| reedip | yushiro : good morning | 02:09 |
| yushiro | reedip, hi | 02:10 |
| reedip | yushiro : Any Action Items? | 02:10 |
| yushiro | reedip, At first, thank you for your yesterdays great work :) | 02:15 |
| yushiro | reedip, let me see, please reply my comment, please? https://review.openstack.org/#/c/486614/ | 02:15 |
| reedip | yushiro :) | 02:15 |
| reedip | checking | 02:18 |
| reedip | yushiro : I was just thinking if there are too many extra lines | 02:21 |
| reedip | they were working earlier without the extra lines, while the focus of the patch is mainly to fix the import order | 02:21 |
| reedip | yushiro : Eg. https://review.openstack.org/#/c/486614/5/neutron_fwaas/_i18n.py#17 | 02:22 |
| reedip | Sorry , yushiro : Eg. https://review.openstack.org/#/c/486614/5/neutron_fwaas/_i18n.py@17 | 02:22 |
| yushiro | reedip, In my patch, coding layer is out of scope. I changed an import order and align with hacking guide https://docs.openstack.org/hacking/latest/user/hacking.html#imports | 02:25 |
| reedip | yushiro : thats ok, I am just saying that we do not need extra lines where its not required. | 02:27 |
| reedip | yushiro : the guideline never states of addign an extra line between copyright and the first import module | 02:28 |
| yushiro | reedip, aha, you said that between copyright comment and a top of import module, right? | 02:29 |
| reedip | yes | 02:29 |
| reedip | yushiro : but also between the import module and any FUNCTION following it | 02:30 |
| reedip | a class should have 2 spaces, thats not true for the functions though | 02:30 |
| yushiro | reedip, yes, I saw several repos but both patterns exist :( | 02:30 |
| reedip | yushiro : I know, because its not wrong to have multiple new lines | 02:30 |
| reedip | yushiro : but our patch scope is to fix the import order, right | 02:31 |
| yushiro | yes | 02:31 |
| reedip | so these spaces wont impact the import order :) | 02:31 |
| yushiro | reedip, got it. So, I'll remove a top of space | 02:31 |
| reedip | yushiro : I am commenting on the patch, please check which ones are not required from your side as well ... | 02:32 |
| yushiro | reedip, OK | 02:32 |
| reedip | done | 02:32 |
| yushiro | light speed :) | 02:32 |
| reedip | :) | 02:33 |
| yushiro | also, Sridar har commented our patch and I hope to be merged ASAP. | 02:33 |
| yushiro | s/har/has | 02:33 |
| reedip | lets push it tonight, I am waiting for xgerman_ 's review as well | 02:53 |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Change import orders with hacking guide https://review.openstack.org/486614 | 02:55 |
| yushiro | done | 02:55 |
| yushiro | hopefully ASAP | 02:56 |
| yushiro | I'd like to update def fwg , l2-agent and configurable default fwg within today's IRC meeting.. | 02:57 |
| reedip | :) | 03:01 |
| *** Tim_Eberhard has quit IRC | 03:19 | |
| *** vishwana_ has joined #openstack-fwaas | 03:19 | |
| *** vishwana_ has quit IRC | 03:19 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 03:19 | |
| *** vishwanathj has quit IRC | 03:22 | |
| *** yamamoto has quit IRC | 03:45 | |
| *** yamamoto has joined #openstack-fwaas | 04:00 | |
| yushiro | reedip, could you check https://review.openstack.org/#/c/486614/ again? | 04:24 |
| openstackgerrit | iswarya vakati proposed openstack/neutron-fwaas master: Replace six.iteritems() with .items() https://review.openstack.org/486596 | 05:13 |
| yushiro | reedip, thanks for your review | 05:29 |
| reedip | :) | 05:30 |
| reedip | yamamoto : are nits in the commit message also not accepted for better readability in backports/ | 06:57 |
| reedip | ??? | 06:57 |
| *** jhesketh has joined #openstack-fwaas | 08:16 | |
| *** jhesketh_ has joined #openstack-fwaas | 08:22 | |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: FWaaS v2 extension for L2 agent https://review.openstack.org/323971 | 08:24 |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Generate default firewall group via project https://review.openstack.org/425769 | 08:24 |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: [WIP] Add configurable option for default_firewall_group https://review.openstack.org/475183 | 08:24 |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: OVS based l2 Firewall driver for FWaaS v2 https://review.openstack.org/447251 | 08:24 |
| *** jhesketh has quit IRC | 08:25 | |
| *** jhesketh_ is now known as jhesketh | 08:30 | |
| *** yamamoto has quit IRC | 08:33 | |
| *** yushiro has quit IRC | 08:45 | |
| *** yamamoto has joined #openstack-fwaas | 08:46 | |
| *** yamamoto has quit IRC | 08:50 | |
| *** yamamoto has joined #openstack-fwaas | 08:57 | |
| *** yamamoto has quit IRC | 09:05 | |
| *** yamamoto has joined #openstack-fwaas | 09:11 | |
| *** yamamoto has quit IRC | 09:28 | |
| *** yamamoto has joined #openstack-fwaas | 09:36 | |
| *** yamamoto has quit IRC | 09:40 | |
| *** yamamoto has joined #openstack-fwaas | 09:44 | |
| *** yamamoto has quit IRC | 09:48 | |
| *** yamamoto has joined #openstack-fwaas | 10:13 | |
| *** openstackgerrit has quit IRC | 10:17 | |
| *** openstackgerrit has joined #openstack-fwaas | 10:50 | |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: FWaaS v2 extension for L2 agent https://review.openstack.org/323971 | 10:50 |
| *** yamamoto has quit IRC | 12:18 | |
| *** yamamoto has joined #openstack-fwaas | 12:36 | |
| *** yamamoto has quit IRC | 13:12 | |
| *** TuanVu has joined #openstack-fwaas | 13:47 | |
| *** yushiro has joined #openstack-fwaas | 13:59 | |
| *** reedip_ has joined #openstack-fwaas | 14:00 | |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Use API Definitions from neutron-lib https://review.openstack.org/478883 | 14:06 |
| openstackgerrit | Vu Cong Tuan proposed openstack/neutron-fwaas master: FW rule applied incorrectly if port specified is a range https://review.openstack.org/443385 | 14:06 |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Change import orders with hacking guide https://review.openstack.org/486614 | 14:07 |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: OVS based l2 Firewall driver for FWaaS v2 https://review.openstack.org/447251 | 14:07 |
| *** Trident has quit IRC | 14:14 | |
| *** Trident has joined #openstack-fwaas | 14:14 | |
| *** yamamoto has joined #openstack-fwaas | 14:17 | |
| *** yamamoto has quit IRC | 14:25 | |
| *** TuanVu has quit IRC | 14:28 | |
| *** TuanVu has joined #openstack-fwaas | 14:28 | |
| *** reedip_ has quit IRC | 14:37 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 14:44 | |
| *** TuanVu has quit IRC | 14:51 | |
| *** Tim_Eberhard has quit IRC | 14:56 | |
| amotoki | yushiro: reedip: no update on neutronclient patch public->shared https://review.openstack.org/#/c/453204/ | 15:20 |
| amotoki | a release note needs to be improved. | 15:20 |
| amotoki | i am not sure which of you two is now taking care of it | 15:21 |
| *** vishwanathj has joined #openstack-fwaas | 15:24 | |
| *** yushiro has quit IRC | 15:33 | |
| *** vishwanathj has quit IRC | 15:36 | |
| *** vishwanathj has joined #openstack-fwaas | 15:37 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 15:45 | |
| openstackgerrit | boden proposed openstack/neutron-fwaas master: consume load_class_by_alias_or_classname from neutron-lib https://review.openstack.org/487139 | 16:35 |
| openstackgerrit | Akihiro Motoki proposed openstack/neutron-fwaas-dashboard master: Document cleanup and release notes for a new release https://review.openstack.org/487157 | 17:53 |
| *** yamamoto_ has joined #openstack-fwaas | 21:07 | |
| *** yamamoto_ has quit IRC | 22:05 | |
| *** yamamoto has joined #openstack-fwaas | 22:09 | |
| *** Tim_Eberhard has quit IRC | 23:35 | |
| *** vishwanathj has quit IRC | 23:37 | |
| *** vishwanathj has joined #openstack-fwaas | 23:37 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!