| *** yamamoto has joined #openstack-fwaas | 00:08 | |
| *** yushiro_afk is now known as yushiro | 00:40 | |
| yushiro | reedip, hi | 00:40 |
|---|---|---|
| yushiro | I read your e-mail about https://review.openstack.org/#/c/478883/ | 00:41 |
| yushiro | let me check step by step. | 00:42 |
| yushiro | First, I realized that RESOURCE_ATTRIBUTE_MAP is missing convert_to_string for source/destination port of firewall_rule. --> Broke backward compat | 00:46 |
| yushiro | Second, I pushed https://review.openstack.org/#/c/486133/ and added convert_to_string for them. | 00:47 |
| *** yushiro has quit IRC | 00:47 | |
| *** yushiro has joined #openstack-fwaas | 00:48 | |
| yushiro | reedip, sorry, I was suddenly disconnected. | 00:50 |
| *** trungnv has joined #openstack-fwaas | 01:05 | |
| *** vishwanathj has quit IRC | 03:08 | |
| *** vishwanathj has joined #openstack-fwaas | 03:08 | |
| reedip | yamamoto : hi , I saw your comment | 04:02 |
| reedip | I agree with you but can we include the integer related test cases later ? | 04:03 |
| yamamoto | hi | 04:04 |
| yamamoto | why? | 04:04 |
| *** yushiro is now known as yushiro_afk | 04:06 | |
| reedip | yamamoto : I was of the opinion to get the fix merged . But now I see that neutron lib version 1.9.1 has been released | 04:07 |
| reedip | yamamoto : nevermind ... | 04:07 |
| reedip | yushiro : I will try to align the code with 1.9.1 of neutron-lib | 04:07 |
| reedip | is that ok ? | 04:07 |
| *** yushiro_afk is now known as yushiro | 04:08 | |
| yushiro | reedip, OK but please add TODO and commit message about these change are temporary one. | 04:09 |
| yushiro | while neutron-lib which includes https://review.openstack.org/#/c/486133/ will be published. | 04:09 |
| yushiro | same comment PS18 | 04:10 |
| reedip | yushiro : https://review.openstack.org/#/c/485849/ | 04:10 |
| reedip | ohh , wait | 04:11 |
| reedip | 1.9.1 was released before the convert_to_string came | 04:11 |
| reedip | :( | 04:11 |
| yushiro | hmm, we should avoid/skip integer case as temporary fix. | 04:13 |
| yushiro | I believed that https://review.openstack.org/#/c/486133/ should be included in 1.9.1... | 04:14 |
| reedip | No , 1.9.1 was released 3 days ago and the fix which you gave merged 2 days ago :( | 04:20 |
| yushiro | oh, but non-cli library freeze was 2 days ago ... | 04:23 |
| reedip | maybe 1.9.2 is coming ... ??? | 04:25 |
| yushiro | I saved deadline... so | 04:41 |
| yushiro | anyway, I'll wait your patch :) | 04:47 |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Prevent inserting an unshared fwr into a shared fwp https://review.openstack.org/486377 | 05:24 |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 05:53 |
| reedip | yushiro : published the patch tentatively .. waiting for neutron-lib release | 05:53 |
| yushiro | thanks. Waiting jenkins result | 05:54 |
| yushiro | yamamoto, ping | 05:54 |
| yushiro | reedip, sorry, I just leave IRC for a while. Could you explain our situation to yamamoto ? | 06:01 |
| *** yushiro is now known as yushiro_afk | 06:01 | |
| *** yushiro_afk has quit IRC | 06:02 | |
| reedip | yamamoto : do you have any doubts ?? :) | 06:02 |
| yamamoto | ? | 06:09 |
| openstackgerrit | Tuan Luong-Anh proposed openstack/neutron-fwaas master: Replace uuid.uuid4() with uuidutils.generate_uuid() https://review.openstack.org/484245 | 06:10 |
| *** yushiro has joined #openstack-fwaas | 06:24 | |
| *** yamamoto has quit IRC | 06:34 | |
| openstackgerrit | Ritesh proposed openstack/neutron-fwaas master: Drop MANIFEST.in - it's not needed by pbr https://review.openstack.org/479260 | 06:36 |
| openstackgerrit | Siyi Luo proposed openstack/neutron-fwaas master: Enable some off-by-default checks https://review.openstack.org/478819 | 06:37 |
| yushiro | reedip, hi | 06:55 |
| reedip | yushiro : yep | 06:56 |
| yushiro | Thanks for your update PS19. | 06:56 |
| yushiro | OK, this is start line. Now, we can avoid/skip testing integer case as temporary solution. | 06:57 |
| yushiro | reedip, Is there some comments from yamamot? | 06:58 |
| reedip | yushiro : I dont think he had any comments earlier except to avoid skipping the tests | 07:01 |
| yushiro | OK. So, could you update PS20 to avoid integer cases? I'll review it. | 07:03 |
| openstackgerrit | chandanc proposed openstack/neutron-fwaas master: OVS based l2 Firewall driver for FWaaS v2 https://review.openstack.org/447251 | 07:37 |
| *** yamamoto has joined #openstack-fwaas | 07:45 | |
| yushiro | reedip, can I do that? | 07:54 |
| reedip | yushiro : I found skip_because() | 07:54 |
| reedip | https://docs.openstack.org/tempest/latest/library/decorators.html | 07:54 |
| reedip | But you can do it if you want to | 07:54 |
| yushiro | hmm, I don't want to self-review +2. So, hopefully you can :) | 07:55 |
| yushiro | Yes, this decorator is what I suggested to you. | 07:55 |
| reedip | hehehe | 07:57 |
| reedip | ok wait ... | 07:57 |
| yushiro | thank you so much | 07:58 |
| yushiro | After that, I try to rebase default fwg and l2-agent. | 08:00 |
| openstackgerrit | Vu Cong Tuan proposed openstack/neutron-fwaas master: Firewall rule is not applied immediately when it has "port range" https://review.openstack.org/443385 | 08:01 |
| reedip | oh I also have several patches on it | 08:02 |
| reedip | yamamoto : we would be putting the skip_decorator on the integer test cases | 08:03 |
| reedip | yamamoto : if you have any concerns, please let us know, so that we can avoid any negative review comments early :) | 08:03 |
| reedip | yushiro : but I need to put a bug in this decorator, right? | 08:08 |
| yushiro | reedip, ah, yes. Can I file a bug-report on LP? | 08:09 |
| reedip | I am doing that | 08:09 |
| yushiro | reedip, light speed :) | 08:10 |
| yamamoto | reedip: skip which test on which condition? | 08:11 |
| reedip | yamamoto : we were thinking of skipping the "integer only" test cases for source and destination port, till neutron-lib 1.9.2 is not released | 08:12 |
| reedip | I know it would mean breakages can seep in | 08:12 |
| reedip | but we also have similar tests for firewall_rules with Strings, so the only difference would be with respect to the data type used in firewall rule and not in the functioning | 08:13 |
| yamamoto | what's the point? | 08:13 |
| reedip | yamamoto : getting the current migration patch in ? But you are not having the same opinion, I guess | 08:14 |
| reedip | yamamoto : a lot of other patches are actually dependent on this patch | 08:14 |
| yamamoto | it's a bad idea to get a patch with known issues in. | 08:15 |
| reedip | I know yamamoto . what do you propose, waiting for neutron-lib ? | 08:15 |
| yamamoto | esp when it's mostly cosmetic patch like that. | 08:15 |
| yamamoto | how other patches are depending on that? | 08:17 |
| yamamoto | yes. i'm not entirely sure why you don't want to wait. | 08:19 |
| reedip | yamamoto : the problem is the cutoff of neutron-lib | 08:20 |
| reedip | there are patches w.r.t. default fwg, and L2 extension | 08:20 |
| reedip | yushiro may be able to provide more information on them | 08:21 |
| yamamoto | this? https://review.openstack.org/#/c/425769/ | 08:23 |
| yushiro | yamamoto, reedip yes. | 08:23 |
| reedip | yamamoto : I am trying to get in touch with neutron cores for the next release of neutron-lib , if there is any. However, if there is no release of neutron-lib then we may not be able to submit the patches which we are targetting in Pike and which are blocked due to migration | 08:23 |
| yamamoto | by dependant, you just means "touch same files"? | 08:23 |
| yushiro | 425769, 323971 and 475183 | 08:24 |
| yamamoto | i don't understand how the migration patch can block them. | 08:25 |
| yushiro | not only touch, but I think it requires stadium constraint | 08:25 |
| yamamoto | stadium constraint? | 08:26 |
| yushiro | after https://review.openstack.org/#/c/478883/ is merged, fwaas just finished migrating neutron-lib. | 08:27 |
| yushiro | yes | 08:27 |
| yamamoto | what do you mean by stadium constraint and how it's related with those patches? | 08:28 |
| yushiro | hmm, I'd like to merge https://review.openstack.org/#/c/478883/ first because I think it's more simple to rebase. In addition, neutron-lib migration is one of stadium constraint and need to finish during Pike. | 08:33 |
| yushiro | correct me if I am wrong. | 08:33 |
| reedip | actually thats our target for Pike | 08:34 |
| reedip | but I guess yamamoto is correct not to put something which might break afterwards | 08:35 |
| reedip | lets first try to discuss a new release for neutron-lib , if not, then we may move ahead with Plan B | 08:35 |
| yamamoto | yushiro: to me neither of them sound like a good reason to introduce the regression. | 08:36 |
| yushiro | yamamoto, OK, so, should we insert convert logic into fwaas as temporary solution while new neutron-lib will be published? | 08:36 |
| yushiro | In order to keep backward compatibility | 08:36 |
| reedip | yushiro : how do you plan to do that ? | 08:37 |
| yushiro | Anyway, currently, it cannot specify src/dest port as integer value. | 08:37 |
| yamamoto | i guess it's the simplest to keep RESOURCE_ATTRIBUTE_MAP in fwaas repo and merge the rest of https://review.openstack.org/#/c/478883/ | 08:38 |
| yamamoto | it's an equivalent of "insert convert logic into fwaas" i guess | 08:39 |
| yushiro | reedip, 1, Create new patch which adds convert logic in fwaas side. 2. https://review.openstack.org/#/c/478883/ PS19 3. Revert patch '1' when new neutron-lib is published. | 08:40 |
| yamamoto | yushiro: it can't? why are the tempest tests passing then? | 08:40 |
| reedip | got it | 08:40 |
| reedip | but I think we need to put this logic in 478883 | 08:41 |
| yushiro | yamamoto, I don't know but UT fails definitely. I wonder tempest test refers master repos for neutron-lib? | 08:41 |
| yushiro | As yamamoto said, keep current status is the most easy. | 08:42 |
| yamamoto | by "currently" you meant with the migration patch, not master? | 08:43 |
| yushiro | ah, yes. with migration patch. | 08:45 |
| yushiro | sorry, I'll leave for a while .... | 08:46 |
| *** yushiro is now known as yushiro_afk | 08:46 | |
| *** yamamoto has quit IRC | 09:02 | |
| *** yamamoto has joined #openstack-fwaas | 09:15 | |
| reedip | yamamoto , yushiro_afk I updated the patch (vv) | 09:25 |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 09:26 |
| *** yushiro_afk is now known as yushiro | 09:33 | |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 09:39 |
| yushiro | reedip, yamamoto let's decide next step... | 09:40 |
| *** yamamoto has quit IRC | 09:47 | |
| *** yamamoto has joined #openstack-fwaas | 10:02 | |
| *** yamamoto has quit IRC | 10:02 | |
| yushiro | reedip, ping | 10:08 |
| *** yamamoto has joined #openstack-fwaas | 10:33 | |
| reedip | yushiro: pomg | 10:37 |
| yushiro | reedip, sorry for late. | 10:44 |
| yushiro | reedip, I thought that https://review.openstack.org/478883 | 10:45 |
| yushiro | reedip, how about waiting this patch until a new neutron-lib will be published? | 10:46 |
| reedip | why , is there any issue ion the current code? | 10:47 |
| yushiro | ah!! sorry you just uploaded PS22 | 10:50 |
| yushiro | no pS21 | 10:50 |
| yushiro | I read PS19 | 10:50 |
| yushiro | OK, you just added converter into fwaas v1 and v2. | 10:51 |
| yushiro | OK, waiting Jenkins... | 10:52 |
| reedip | yepo | 10:55 |
| reedip | yep* | 10:55 |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 11:52 |
| yushiro | yamamoto, thanks for ur review. Could you check it again ? | 11:53 |
| yamamoto | yushiro: i will look later. maybe tomorrow. | 12:02 |
| yushiro | OK. | 12:03 |
| yushiro | I all reflected your comment now. | 12:03 |
| amotoki | yushiro: hopefully we would like to have a bug on neutron-lib. we are in the lib freeze phase and a bug would help a maintenance release. | 12:10 |
| yushiro | amotoki, Oh, OK. Is this term this weekend?? | 12:15 |
| amotoki | yushiro: the lib freeze was last week. this week is the feature freeze. | 12:16 |
| yushiro | amotoki, aha, yes. Thank you. So, I'll file a bug-report for tracability though deadline is over. | 12:18 |
| *** yamamoto has quit IRC | 12:19 | |
| yushiro | amotoki, https://bugs.launchpad.net/neutron/+bug/1706061 Just filed it. | 12:25 |
| openstack | Launchpad bug 1706061 in neutron "Missing conversion for firewall-rule in neutron-lib" [Undecided,New] | 12:25 |
| *** yamamoto has joined #openstack-fwaas | 12:36 | |
| *** yamamoto has quit IRC | 12:36 | |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Remove log translations https://review.openstack.org/479102 | 12:40 |
| openstackgerrit | iswarya vakati proposed openstack/neutron-fwaas master: Replace six.iteritems() with .items() https://review.openstack.org/486596 | 12:42 |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 13:21 |
| *** yamamoto has joined #openstack-fwaas | 13:36 | |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Change import orders with hacking guide https://review.openstack.org/486614 | 13:43 |
| *** yushiro has quit IRC | 13:43 | |
| *** yamamoto has quit IRC | 13:44 | |
| xgerman_ | o/ | 13:45 |
| *** reedip_ has joined #openstack-fwaas | 14:22 | |
| *** reedip has quit IRC | 14:56 | |
| *** reedip_ has quit IRC | 15:01 | |
| *** reedip has joined #openstack-fwaas | 15:03 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 15:03 | |
| amotoki | fwaas cores: is there a chance to get it in? https://review.openstack.org/#/c/482414/ | 15:44 |
| *** reedip_ has joined #openstack-fwaas | 15:45 | |
| openstackgerrit | Merged openstack/neutron-fwaas master: Move remaining policy rules specific to neutron-fwaas https://review.openstack.org/482414 | 17:14 |
| *** reedip_ has quit IRC | 17:24 | |
| *** yushiro has joined #openstack-fwaas | 20:59 | |
| *** yamamoto_ has joined #openstack-fwaas | 21:09 | |
| *** yushiro has quit IRC | 21:20 | |
| *** yamamoto_ has quit IRC | 21:20 | |
| *** yushiro2 has joined #openstack-fwaas | 21:20 | |
| *** yushiro2 has quit IRC | 21:38 | |
| *** yamamoto has joined #openstack-fwaas | 22:01 | |
| *** Tim_Eberhard has quit IRC | 22:02 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 22:04 | |
| *** Tim_Eber_ has joined #openstack-fwaas | 22:05 | |
| *** Tim_Eberhard has quit IRC | 22:08 | |
| *** Tim_Eber_ has quit IRC | 23:33 | |
| *** yushiro has joined #openstack-fwaas | 23:38 | |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Change import orders with hacking guide https://review.openstack.org/486614 | 23:49 |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Use API Definitions from neutron-lib https://review.openstack.org/478883 | 23:49 |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Change import orders with hacking guide https://review.openstack.org/486614 | 23:51 |
| yushiro | yamamoto, thanks for your review | 23:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!